language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
mrdoob
three.js
451d16f6787156568b5df26365425f71ab9fdb09.json
Fix missing return statement in copy functions
examples/jsm/nodes/utils/UVTransformNode.js
@@ -44,6 +44,8 @@ UVTransformNode.prototype.copy = function ( source ) { this.uv = source.uv; this.position = source.position; + return this; + }; UVTransformNode.prototype.toJSON = function ( meta ) {
true
Other
mrdoob
three.js
451d16f6787156568b5df26365425f71ab9fdb09.json
Fix missing return statement in copy functions
examples/jsm/nodes/utils/VelocityNode.js
@@ -152,6 +152,8 @@ VelocityNode.prototype.copy = function ( source ) { this.setParams( source.params ); + return this; + }; VelocityNode.prototype.toJSON = function ( meta ) {
true
Other
mrdoob
three.js
840057d7ccaa6ebac09a55bbf8b93c7c892d24bb.json
Fix viewports following #13593
examples/webgl_lines_fat_wireframe.html
@@ -144,9 +144,9 @@ renderer.setScissorTest( true ); - renderer.setScissor( 20, window.innerHeight - insetHeight - 20, insetWidth, insetHeight ); + renderer.setScissor( 20, 20, insetWidth, insetHeight ); - renderer.setViewport( 20, window.innerHeight - insetHeight - 20, insetWidth, insetHeight ); + ...
false
Other
mrdoob
three.js
b38125bbb4053d4667d1f5028a0bd29038bb9015.json
Upgrade dev dependencies
package-lock.json
@@ -1,22 +1,22 @@ { "name": "three", - "version": "0.105.1", + "version": "0.107.0", "lockfileVersion": 1, "requires": true, "dependencies": { "@babel/code-frame": { - "version": "7.0.0", - "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.0.0.tgz", - "integrity...
true
Other
mrdoob
three.js
b38125bbb4053d4667d1f5028a0bd29038bb9015.json
Upgrade dev dependencies
package.json
@@ -67,17 +67,17 @@ }, "homepage": "https://threejs.org/", "devDependencies": { - "@typescript-eslint/eslint-plugin": "^1.11.0", - "@typescript-eslint/parser": "^1.11.0", + "@typescript-eslint/eslint-plugin": "^2.0.0", + "@typescript-eslint/parser": "^2.0.0", "concurrently": "^4.1.1", - "es...
true
Other
mrdoob
three.js
f5110b235bfb3b1473809a1d3880434daaae9b04.json
add clearCoatNormal context only to physical
src/renderers/shaders/ShaderChunk/common.glsl.js
@@ -39,7 +39,9 @@ struct GeometricContext { vec3 position; vec3 normal; vec3 viewDir; +#ifdef PHYSICAL vec3 clearCoatNormal; +#endif }; vec3 transformDirection( in vec3 dir, in mat4 matrix ) {
false
Other
mrdoob
three.js
a19b279b8236e215c6f31d0b8c2ba18d3348e205.json
fix possible issue reflectnode with vertex shader
examples/jsm/nodes/accessors/ReflectNode.js
@@ -3,6 +3,8 @@ */ import { TempNode } from '../core/TempNode.js'; +import { PositionNode } from './PositionNode.js'; +import { NormalNode } from './NormalNode.js'; function ReflectNode( scope ) { @@ -44,7 +46,10 @@ ReflectNode.prototype.generate = function ( builder, output ) { case ReflectNode.VECTOR:...
false
Other
mrdoob
three.js
2a5e8f901d52c2f9afc2599f989609912eb75c09.json
fix vertex normal
examples/jsm/nodes/accessors/NormalNode.js
@@ -36,7 +36,8 @@ NormalNode.prototype.generate = function ( builder, output ) { case NormalNode.LOCAL: - result = 'geometryNormal'; + if ( builder.isShader( 'vertex' ) ) result = 'objectNormal'; + else result = 'geometryNormal'; break;
false
Other
mrdoob
three.js
29405750b95ea9d318ea3e90051966a1ea04ae1e.json
Add error if camera is null
src/objects/Sprite.js
@@ -60,6 +60,12 @@ Sprite.prototype = Object.assign( Object.create( Object3D.prototype ), { raycast: function ( raycaster, intersects ) { + if ( raycaster.camera === null ) { + + console.error( 'THREE.Sprite: "Raycaster.camera" needs to be set in order to raycast against sprites.' ); + + } + if ( _uvC === ...
false
Other
mrdoob
three.js
4f88d97af577e4b4f51e1943782e0380637e5233.json
add binding unittest
test/unit/src/math/Euler.tests.js
@@ -425,17 +425,22 @@ export default QUnit.module( 'Maths', () => { QUnit.test( "_onChangeCallback", ( assert ) => { + var b = false; + var a = new Euler( 11, 12, 13, "XYZ" ); var f = function () { - var b = true; + b = true; + assert.ok( a === this, "Passed!" ); }; - var a = new Eul...
true
Other
mrdoob
three.js
4f88d97af577e4b4f51e1943782e0380637e5233.json
add binding unittest
test/unit/src/math/Quaternion.tests.js
@@ -733,13 +733,14 @@ export default QUnit.module( 'Maths', () => { QUnit.test( "_onChangeCallback", ( assert ) => { var b = false; + var a = new Quaternion( 11, 12, 13, 1 ); var f = function () { b = true; + assert.ok( a === this, "Passed!" ); }; - var a = new Quaternion( 11, 12, 13,...
true
Other
mrdoob
three.js
8f5415d65769b966192b7123e46cc81467a6adad.json
Wrap the Project child elements in Panel
editor/js/Sidebar.Project.js
@@ -19,8 +19,14 @@ Sidebar.Project = function ( editor ) { var container = new UI.Panel(); container.setBorderTop( '0' ); + container.setPadding( '0' ); container.setPaddingTop( '20px' ); + var projectsettings = new UI.Panel(); + projectsettings.setBorderTop( '0' ); + + container.add( projectsettings ); + /...
false
Other
mrdoob
three.js
0f10beed950615f2a4430b8c8d317744143bfd93.json
Remove redundant styling for Panel
editor/css/dark.css
@@ -273,7 +273,6 @@ select { .Panel { color: #888; - border-top: 1px solid #222; } /* */
true
Other
mrdoob
three.js
0f10beed950615f2a4430b8c8d317744143bfd93.json
Remove redundant styling for Panel
editor/css/light.css
@@ -267,7 +267,6 @@ select { .Panel { color: #888; - border-top: 1px solid #ccc; } /* */
true
Other
mrdoob
three.js
685cc7d7571b7bf9a5c544ca887318ba16e710d9.json
Fix How-to-use-post-processing.html typo
docs/manual/en/introduction/How-to-use-post-processing.html
@@ -24,7 +24,7 @@ <h1>How to use post-processing</h1> <h2>Workflow</h2> <p> - The first step in the process is to import all necessary files from the examples directory. The guide assumes your are using the official + The first step in the process is to import all necessary files from the examples directory...
false
Other
mrdoob
three.js
b95ff4881678e6aca074c5377464a7a6845dde4a.json
Remove outdated ref to how Matrix4.compose works
docs/api/en/math/Matrix4.html
@@ -125,10 +125,7 @@ <h3>[method:Matrix4 clone]()</h3> <h3>[method:this compose]( [param:Vector3 position], [param:Quaternion quaternion], [param:Vector3 scale] )</h3> <p> Sets this matrix to the transformation composed of [page:Vector3 position], - [page:Quaternion quaternion] and [page:Vector3 scale]. Inter...
false
Other
mrdoob
three.js
9c27acebf97605027a38ea06d0262a3523396100.json
fix import, taphos nomore :'(
src/renderers/webgl/WebGLMaterials.js
@@ -1,7 +1,7 @@ -import { BackSide } from "../../constants"; +import { BackSide } from "../../constants.js"; /** - * @author taphos / https://github.com/taphos + * @author mrdoob / http://mrdoob.com/ * * This is a helper which deals with webgl specific logic of builtin materials * i.e. uniforms refresh before ...
false
Other
mrdoob
three.js
34c999bff92d7c572eaeaee549eed5ce668bdef9.json
get first intersection not the last one
examples/js/controls/TransformControls.js
@@ -56,7 +56,7 @@ THREE.TransformControls = function ( camera, domElement ) { var allIntersections = raycaster.intersectObject( object, true ); - for ( var i = allIntersections.length; i --; ) { + for ( var i = 0; i < allIntersections.length; i ++ ) { if ( allIntersections[ i ].object.visible || includeI...
true
Other
mrdoob
three.js
34c999bff92d7c572eaeaee549eed5ce668bdef9.json
get first intersection not the last one
examples/jsm/controls/TransformControls.js
@@ -79,7 +79,7 @@ var TransformControls = function ( camera, domElement ) { var allIntersections = raycaster.intersectObject( object, true ); - for ( var i = allIntersections.length; i --; ) { + for ( var i = 0; i < allIntersections.length; i ++ ) { if ( allIntersections[ i ].object.visible || includeInv...
true
Other
mrdoob
three.js
de5143943cadc49297fc61b0e271364b1dbaaaac.json
fix materials initialization
src/renderers/WebGLRenderer.js
@@ -282,7 +282,7 @@ function WebGLRenderer( parameters ) { objects = new WebGLObjects( _gl, geometries, attributes, info ); morphtargets = new WebGLMorphtargets( _gl ); programCache = new WebGLPrograms( _this, extensions, capabilities ); - materials = new WebGLMaterials(); + materials = new WebGLMaterials( p...
false
Other
mrdoob
three.js
4ee8bbe7caed69104d90db30303051002407e511.json
add css stylesheet support for svg add "opacity" support
examples/js/loaders/SVGLoader.js
@@ -51,6 +51,10 @@ THREE.SVGLoader.prototype = Object.assign( Object.create( THREE.Loader.prototype case 'svg': break; + case 'style': + parseCSSStylesheet( node ); + break; + case 'g': style = parseStyle( node, style ); break; @@ -91,7 +95,7 @@ THREE.SVGLoader.prototype = Objec...
true
Other
mrdoob
three.js
4ee8bbe7caed69104d90db30303051002407e511.json
add css stylesheet support for svg add "opacity" support
src/extras/core/ShapePath.js
@@ -13,6 +13,7 @@ function ShapePath() { this.type = 'ShapePath'; this.color = new Color(); + this.opacity = 1.0; this.subPaths = []; this.currentPath = null;
true
Other
mrdoob
three.js
c04487106911dcea86e806e5e8dd01b87ddeb170.json
Fix winding order
examples/webgl_buffergeometry_instancing_interleaved.html
@@ -101,14 +101,14 @@ geometry.setAttribute( 'uv', uvs ); var indices = new Uint16Array( [ - 0, 1, 2, - 2, 1, 3, - 4, 5, 6, - 6, 5, 7, - 8, 9, 10, - 10, 9, 11, - 12, 13, 14, - 14, 13, 15, + 0, 2, 1, + 2, 3, 1, + 4, 6, 5, + 6, 7, 5, + 8, 10, 9, + 10, 11, 9, + 12, 14...
false
Other
mrdoob
three.js
a0535a3e1b4eeaacbf22f8bc7c9673efc885c785.json
Fix TransformControl zoom for OrthographicCamera
examples/js/controls/TransformControls.js
@@ -1166,6 +1166,10 @@ THREE.TransformControlsGizmo = function () { handle.position.copy( this.worldPosition ); var eyeDistance = this.worldPosition.distanceTo( this.cameraPosition ); + // Orthographic camera zoom doesn't depend on eyeDistance, but on camera zoom factor. + if (this.camera.type == "Orthogr...
true
Other
mrdoob
three.js
a0535a3e1b4eeaacbf22f8bc7c9673efc885c785.json
Fix TransformControl zoom for OrthographicCamera
examples/jsm/controls/TransformControls.js
@@ -1189,6 +1189,10 @@ var TransformControlsGizmo = function () { handle.position.copy( this.worldPosition ); var eyeDistance = this.worldPosition.distanceTo( this.cameraPosition ); + // Orthographic camera zoom doesn't depend on eyeDistance, but on camera zoom factor. + if (this.camera.type == "Orthograp...
true
Other
mrdoob
three.js
789268fde43aeab6adbeafb874bd4cbb1c218b71.json
Fix lint errors
src/renderers/shaders/UniformsUtils.d.ts
@@ -5,5 +5,5 @@ export namespace UniformsUtils { export { mergeUniforms as merge, cloneUniforms as clone, - } + }; }
true
Other
mrdoob
three.js
789268fde43aeab6adbeafb874bd4cbb1c218b71.json
Fix lint errors
src/renderers/webgl/WebGLRenderStates.d.ts
@@ -4,18 +4,22 @@ import { Light } from '../../lights/Light'; import { WebGLLights } from './WebGLLights'; interface WebGLRenderState { - init(): void; - state: { - lightsArray: Light[]; + + init(): void; + state: { + lightsArray: Light[]; shadowsArray: Light[]; lights: WebGLLights; - }; - setupLights...
true
Other
mrdoob
three.js
789268fde43aeab6adbeafb874bd4cbb1c218b71.json
Fix lint errors
src/renderers/webvr/WebXRManager.d.ts
@@ -1,15 +1,19 @@ import { Group } from '../../objects/Group'; import { Camera } from '../../cameras/Camera'; -export interface WebXRManager { +export class WebXRManager { + + constructor( renderer: any, gl: WebGLRenderingContext ); + enabled: boolean; - getController( id: number ): Group; - setFramebufferScale...
true
Other
mrdoob
three.js
06c46eba9341e88dc70da69d91e0463edc561af2.json
change threshold to 0.9999999
src/math/Euler.js
@@ -147,7 +147,7 @@ Object.assign( Euler.prototype, { this._y = Math.asin( clamp( m13, - 1, 1 ) ); - if ( Math.abs( m13 ) < 1 ) { + if ( Math.abs( m13 ) < 0.9999999 ) { this._x = Math.atan2( - m23, m33 ); this._z = Math.atan2( - m12, m11 ); @@ -163,7 +163,7 @@ Object.assign( Euler.prototype, { ...
false
Other
mrdoob
three.js
7b23555d862502aa7cb603ad51c80e30de445b64.json
Add missing instanced comment to example
examples/webgl_buffergeometry_instancing_lambert.html
@@ -84,6 +84,7 @@ ` #define LAMBERT + // instanced attribute vec3 instanceOffset; attribute vec3 instanceColor; attribute float instanceScale; @@ -128,8 +129,8 @@ #include <defaultnormal_vertex> #include <begin_vertex> - // position instanced + // position instanced tran...
false
Other
mrdoob
three.js
4ed1865f6cfe813ea8088eb52d5ca5849e26ca4d.json
Remove unnecessary INSTANCED define
examples/webgl_buffergeometry_instancing_lambert.html
@@ -38,12 +38,8 @@ var customDepthVertexShader = ` // instanced - #ifdef INSTANCED - - attribute vec3 instanceOffset; - attribute float instanceScale; - - #endif + attribute vec3 instanceOffset; + attribute float instanceScale; #include <common> #include <uv_pars_vertex> @@ -70,12 +6...
false
Other
mrdoob
three.js
49bb5d1fb8ac3baf8ed27dc3a56c7a6c2f94158c.json
Set quaternion instead of rotation
examples/css3d_molecules.html
@@ -425,7 +425,7 @@ var objMatrix = new THREE.Matrix4().makeRotationAxis( axis.normalize(), radians ); object.matrix = objMatrix; - object.rotation.setFromRotationMatrix( object.matrix, object.rotation.order ); + object.quaternion.setFromRotationMatrix( object.matrix ); object.matrixA...
true
Other
mrdoob
three.js
49bb5d1fb8ac3baf8ed27dc3a56c7a6c2f94158c.json
Set quaternion instead of rotation
examples/webgl_geometry_extrude_splines.html
@@ -323,7 +323,7 @@ if ( ! params.lookAhead ) lookAt.copy( pos ).add( dir ); splineCamera.matrix.lookAt( splineCamera.position, lookAt, normal ); - splineCamera.rotation.setFromRotationMatrix( splineCamera.matrix, splineCamera.rotation.order ); + splineCamera.quaternion.setFromRotationMatrix( splineCa...
true
Other
mrdoob
three.js
d42d3e44b86df6d5bd3575fb65ae792cda4d1b2e.json
move example to jsfiddle
examples/gimbal_lock.html
@@ -1,172 +0,0 @@ -<!DOCTYPE html> -<html lang="en"> - <head> - <title>three.js webgl - gimbal lock</title> - <meta charset="utf-8" /> - <meta - name="viewport" - content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0" - /> - <style> - body { - color: #000; - font-family: M...
false
Other
mrdoob
three.js
cc30de34720bd765b5c60efeb00874eb6de7ab3f.json
fix error due to imprecise clamping at gimbal lock
examples/gimbal_lock.html
@@ -0,0 +1,172 @@ +<!DOCTYPE html> +<html lang="en"> + <head> + <title>three.js webgl - gimbal lock</title> + <meta charset="utf-8" /> + <meta + name="viewport" + content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0" + /> + <style> + body { + color: #000; + font-family: M...
true
Other
mrdoob
three.js
cc30de34720bd765b5c60efeb00874eb6de7ab3f.json
fix error due to imprecise clamping at gimbal lock
src/math/Euler.js
@@ -23,9 +23,7 @@ Euler.RotationOrders = [ 'XYZ', 'YZX', 'ZXY', 'XZY', 'YXZ', 'ZYX' ]; Euler.DefaultOrder = 'XYZ'; Object.defineProperties( Euler.prototype, { - x: { - get: function () { return this._x; @@ -37,12 +35,10 @@ Object.defineProperties( Euler.prototype, { this._x = value; this._onChang...
true
Other
mrdoob
three.js
83d283c12853088a33adecbdd15a589da6ccfd8b.json
fix description of the example
docs/manual/en/introduction/Loading-3D-models.html
@@ -100,7 +100,7 @@ <h2>Loading</h2> <p> Once you've imported a loader, you're ready to add a model to your scene. Syntax varies among different loaders — when using another format, check the examples and documentation for that - loader. For glTF, basic usage would be: + loader. For glTF, usage with global sc...
false
Other
mrdoob
three.js
b9a1f6ded446746c7e0535bf05ed879911b1aea2.json
resolve package-lock.json changes
package-lock.json
@@ -1,6 +1,6 @@ { "name": "three", - "version": "0.106.2", + "version": "0.105.1", "lockfileVersion": 1, "requires": true, "dependencies": {
false
Other
mrdoob
three.js
377747780d3a5d481d52d6178e9ea7abe3cc908c.json
Remove unneeded changes on webglprogram
src/renderers/webgl/WebGLProgram.js
@@ -648,8 +648,11 @@ function WebGLProgram( renderer, extensions, code, material, shader, parameters, var vertexGlsl = prefixVertex + vertexShader; var fragmentGlsl = prefixFragment + fragmentShader; - var glVertexShader = WebGLShader( gl, gl.VERTEX_SHADER, vertexGlsl, renderer.debug.checkShaderErrors ); - var gl...
false
Other
mrdoob
three.js
84c9f9249dff625b56871aa3f3600cba833f1529.json
Change webvr_multiview to use modules
examples/webvr_multiview.html
@@ -18,13 +18,12 @@ </style> </head> <body> + <script type="module"> - <script src="../build/three.js"></script> - <script src="js/vr/WebVR.js"></script> - - <script src="js/geometries/BoxLineGeometry.js"></script> - <script src="js/libs/stats.min.js"></script> - <script> + import * as THREE from '../b...
false
Other
mrdoob
three.js
d2bc4e1f35b317fc15efed5aaf83719b4efb8475.json
Fix lint issues and some minor changes
examples/webvr_multiview.html
@@ -85,7 +85,7 @@ var geometry = new THREE.IcosahedronBufferGeometry( radius ); - for ( var i = 0; i < 5000; i ++ ) { + for ( var i = 0; i < 20000; i ++ ) { var object = new THREE.Mesh( geometry, new THREE.MeshLambertMaterial( { color: Math.random() * 0xffffff } ) );
true
Other
mrdoob
three.js
d2bc4e1f35b317fc15efed5aaf83719b4efb8475.json
Fix lint issues and some minor changes
src/renderers/WebGLRenderer.js
@@ -84,7 +84,7 @@ function WebGLRenderer( parameters ) { * Enables error checking and reporting when shader programs are being compiled * @type {boolean} */ - checkShaderErrors: false + checkShaderErrors: true }; // clearing
true
Other
mrdoob
three.js
d2bc4e1f35b317fc15efed5aaf83719b4efb8475.json
Fix lint issues and some minor changes
src/renderers/webgl/WebGLMultiview.js
@@ -52,7 +52,7 @@ function WebGLMultiview( renderer, gl, contextAttributes ) { function isAvailable() { - return capabilities.multiview && !contextAttributes.antialias; + return capabilities.multiview && ! contextAttributes.antialias; }
true
Other
mrdoob
three.js
4a8c807be38e862d92fc74c46f0a17b9950ec5b2.json
Remove webgl_multiple_views_multiple example
examples/files.js
@@ -206,7 +206,6 @@ var files = { "webgl_multiple_renderers", "webgl_multiple_scenes_comparison", "webgl_multiple_views", - "webgl_multiple_views_multiview", "webgl_nearestneighbour", "webgl_panorama_cube", "webgl_panorama_dualfisheye",
true
Other
mrdoob
three.js
4a8c807be38e862d92fc74c46f0a17b9950ec5b2.json
Remove webgl_multiple_views_multiple example
examples/webgl_multiple_views_multiview.html
@@ -1,325 +0,0 @@ -<!DOCTYPE html> -<html lang="en"> - <head> - <title>three.js performance - animation</title> - <meta charset="utf-8"> - <meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0"> - <style> - body { - font-family: Monospace; - background-col...
true
Other
mrdoob
three.js
16d6cc4bd60278b26324fffc1d0106a783859a0e.json
Detect antialias on multiview.isAvailable()
examples/webvr_multiview.html
@@ -23,16 +23,17 @@ <script src="js/vr/WebVR.js"></script> <script src="js/geometries/BoxLineGeometry.js"></script> - + <script src="js/libs/stats.min.js"></script> <script> var container; var camera, scene, renderer; var room; + var stats; var count = 0; - var radius = 0.08; + v...
true
Other
mrdoob
three.js
16d6cc4bd60278b26324fffc1d0106a783859a0e.json
Detect antialias on multiview.isAvailable()
src/renderers/WebGLRenderer.js
@@ -317,7 +317,7 @@ function WebGLRenderer( parameters ) { // Multiview - var multiview = new WebGLMultiview( _this, _gl ); + var multiview = new WebGLMultiview( _this, _gl, _gl.getContextAttributes() ); this.multiview = multiview;
true
Other
mrdoob
three.js
16d6cc4bd60278b26324fffc1d0106a783859a0e.json
Detect antialias on multiview.isAvailable()
src/renderers/webgl/WebGLMultiview.js
@@ -8,7 +8,7 @@ import { Matrix3 } from '../../math/Matrix3.js'; import { Matrix4 } from '../../math/Matrix4.js'; import { Vector2 } from '../../math/Vector2.js'; -function WebGLMultiview( renderer, gl ) { +function WebGLMultiview( renderer, gl, contextAttributes ) { var DEFAULT_NUMVIEWS = 2; @@ -52,7 +52,7 @...
true
Other
mrdoob
three.js
a2d01af5ca5e053438d0d0569661d976c1a84818.json
Add webvr_multiview example
examples/files.js
@@ -335,6 +335,7 @@ var files = { "webvr_cubes", "webvr_dragging", "webvr_lorenzattractor", + "webvr_multiview", "webvr_panorama", "webvr_paint", "webvr_rollercoaster",
true
Other
mrdoob
three.js
a2d01af5ca5e053438d0d0569661d976c1a84818.json
Add webvr_multiview example
examples/webvr_multiview.html
@@ -0,0 +1,178 @@ +<!DOCTYPE html> +<html lang="en"> + <head> + <title>three.js webvr - ball shooter</title> + <meta charset="utf-8"> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=no"> + <style> + body { + font-family: Monospace; + background-color: #101010; + colo...
true
Other
mrdoob
three.js
5d319675f8d99b44f5e59abe44ba74eb273110d8.json
Remove ballshooter_multiview from examples list
examples/files.js
@@ -332,7 +332,6 @@ var files = { ], "webvr": [ "webvr_ballshooter", - "webvr_ballshooter_multiview", "webvr_cubes", "webvr_dragging", "webvr_lorenzattractor",
false
Other
mrdoob
three.js
99e80892df567fbeabaedc3664aca786f55e27a9.json
remove two sentences
docs/api/en/renderers/WebGLRenderer.html
@@ -478,7 +478,7 @@ <h3>[method:null setOpaqueSort]( [param:Function method] )</h3> <h3>[method:null setTransparentSort]( [param:Function method] )</h3> <p> - Sets the custom transparent sort function for the WebGLRenderLists. Pass null to use the default reversePainterSortStable function. In some cases the tr...
false
Other
mrdoob
three.js
dc96a86c7cf4878f1f26a36bb14a412ac011af63.json
remove example changes
examples/webgl_lines_fat.html
@@ -31,7 +31,6 @@ var matLine, matLineBasic, matLineDashed; var stats; var gui; - var mouse, raycaster, raycastPoint; // viewport var insetWidth; @@ -124,14 +123,6 @@ window.addEventListener( 'resize', onWindowResize, false ); onWindowResize(); - mouse = new THREE.Vector2(); - ...
false
Other
mrdoob
three.js
eb0b88689f438069e140c4b1b001c722683c588d.json
Remove flags used to toggle shadows in shaders The shaders only contain code for active shadows, so they don't need a separate flag to determine whether the shadow is enabled.
src/renderers/shaders/ShaderChunk/lights_fragment_begin.glsl.js
@@ -44,7 +44,7 @@ IncidentLight directLight; #if defined( USE_SHADOWMAP ) && ( UNROLLED_LOOP_INDEX < NUM_POINT_LIGHT_SHADOWS ) pointLightShadow = pointLightShadows[ i ]; - directLight.color *= all( bvec3( pointLightShadow.shadow, directLight.visible, receiveShadow ) ) ? getPointShadow( pointShadowMap[ i ], poi...
true
Other
mrdoob
three.js
eb0b88689f438069e140c4b1b001c722683c588d.json
Remove flags used to toggle shadows in shaders The shaders only contain code for active shadows, so they don't need a separate flag to determine whether the shadow is enabled.
src/renderers/shaders/ShaderChunk/lights_pars_begin.glsl.js
@@ -66,7 +66,6 @@ vec3 getAmbientLightIrradiance( const in vec3 ambientLightColor ) { #if defined( USE_SHADOWMAP ) && NUM_DIR_LIGHT_SHADOWS > 0 struct DirectionalLightShadow { - int shadow; float shadowBias; float shadowRadius; vec2 shadowMapSize; @@ -102,7 +101,6 @@ vec3 getAmbientLightIrradiance(...
true
Other
mrdoob
three.js
eb0b88689f438069e140c4b1b001c722683c588d.json
Remove flags used to toggle shadows in shaders The shaders only contain code for active shadows, so they don't need a separate flag to determine whether the shadow is enabled.
src/renderers/shaders/ShaderChunk/shadowmask_pars_fragment.glsl.js
@@ -13,7 +13,7 @@ float getShadowMask() { for ( int i = 0; i < NUM_DIR_LIGHT_SHADOWS; i ++ ) { directionalLight = directionalLightShadows[ i ]; - shadow *= all( bvec2( directionalLight.shadow, receiveShadow ) ) ? getShadow( directionalShadowMap[ i ], directionalLight.shadowMapSize, directionalLight.shadowBias, ...
true
Other
mrdoob
three.js
eb0b88689f438069e140c4b1b001c722683c588d.json
Remove flags used to toggle shadows in shaders The shaders only contain code for active shadows, so they don't need a separate flag to determine whether the shadow is enabled.
src/renderers/shaders/UniformsLib.d.ts
@@ -72,7 +72,6 @@ export let UniformsLib: { directionalLightShadows: { value: any[]; properties: { - shadow: {}; shadowBias: {}; shadowRadius: {}; shadowMapSize: {}; @@ -95,7 +94,6 @@ export let UniformsLib: { spotLightShadows: { value: any[]; properties: { - shadow: {}; ...
true
Other
mrdoob
three.js
eb0b88689f438069e140c4b1b001c722683c588d.json
Remove flags used to toggle shadows in shaders The shaders only contain code for active shadows, so they don't need a separate flag to determine whether the shadow is enabled.
src/renderers/shaders/UniformsLib.js
@@ -118,7 +118,6 @@ var UniformsLib = { } }, directionalLightShadows: { value: [], properties: { - shadow: {}, shadowBias: {}, shadowRadius: {}, shadowMapSize: {} @@ -138,7 +137,6 @@ var UniformsLib = { } }, spotLightShadows: { value: [], properties: { - shadow: {}, shadowBias: {}, ...
true
Other
mrdoob
three.js
eb0b88689f438069e140c4b1b001c722683c588d.json
Remove flags used to toggle shadows in shaders The shaders only contain code for active shadows, so they don't need a separate flag to determine whether the shadow is enabled.
src/renderers/webgl/WebGLLights.js
@@ -102,7 +102,6 @@ function ShadowUniformsCache() { case 'DirectionalLight': uniforms = { - shadow: false, shadowBias: 0, shadowRadius: 1, shadowMapSize: new Vector2() @@ -111,7 +110,6 @@ function ShadowUniformsCache() { case 'SpotLight': uniforms = { - shadow: ...
true
Other
mrdoob
three.js
96e61e337a633d19a56afac0394ac7a278aa994f.json
Add optionalTarget in CatmullRomCurve3.getPoint() CatmullRomCurve3.getPoint() should accept an [optional Vector3 target](https://github.com/mrdoob/three.js/blob/master/src/extras/curves/CatmullRomCurve3.js#L104) argument. It's missing in the TypeScript declaration file, which leads to compiler errors if users try to u...
src/extras/curves/CatmullRomCurve3.d.ts
@@ -43,6 +43,6 @@ export class CatmullRomCurve3 extends Curve<Vector3> { points: Vector3[]; - getPoint( t: number ): Vector3; + getPoint( t: number, optionalTarget?: Vector3 ): Vector3; }
false
Other
mrdoob
three.js
2b52a5409ed3ba1898d9f50a873f8e1626a371e6.json
Add helio polyfill to editor
editor/index.html
@@ -42,6 +42,7 @@ <script src="js/libs/ternjs/doc_comment.js"></script> <script src="js/libs/tern-threejs/threejs.js"></script> <script src="js/libs/signals.min.js"></script> + <script src="../examples/js/vr/HelioWebXRPolyfill.js"></script> <script type="module">
true
Other
mrdoob
three.js
2b52a5409ed3ba1898d9f50a873f8e1626a371e6.json
Add helio polyfill to editor
editor/js/Menubar.File.js
@@ -417,7 +417,14 @@ var MenubarFile = function ( editor ) { } ); loader.load( '../examples/jsm/webxr/VRButton.js', function ( content ) { + zip.file( 'js/VRButton.js', content ); + + } ); + loader.load( '../examples/js/vr/HelioWebXRPolyfill.js', function ( content ) { + + zip.file( 'js/HelioWebXRPolyfi...
true
Other
mrdoob
three.js
2b52a5409ed3ba1898d9f50a873f8e1626a371e6.json
Add helio polyfill to editor
editor/js/libs/app/index.html
@@ -16,6 +16,7 @@ </style> </head> <body ontouchstart=""> + <script src="../examples/js/vr/HelioWebXRPolyfill.js"></script> <script type="module">
true
Other
mrdoob
three.js
5473f78bd42a8e4ecafc07c87d4b19889531d886.json
Add VR support to publish zip
editor/js/Menubar.File.js
@@ -416,6 +416,9 @@ var MenubarFile = function ( editor ) { zip.file( 'js/three.module.js', content ); } ); + loader.load( '../examples/jsm/webxr/VRButton.js', function ( content ) { + zip.file( 'js/VRButton.js', content ); + } ); } ); options.add( option );
true
Other
mrdoob
three.js
5473f78bd42a8e4ecafc07c87d4b19889531d886.json
Add VR support to publish zip
editor/js/libs/app/index.html
@@ -21,8 +21,10 @@ import * as THREE from './js/three.module.js'; import { APP } from './js/app.js'; + import { VRButton } from './js/VRButton.js'; window.THREE = THREE; // Used by APP Scripts. + window.VRButton = VRButton; // Used by APP Scripts. var loader = new THREE.FileLoader(); loade...
true
Other
mrdoob
three.js
ba0980bdafc62ae66e9d30d17b89083fb694cb6d.json
Add VR configuration option
editor/index.html
@@ -54,6 +54,7 @@ import { Player } from './js/Player.js'; import { Sidebar } from './js/Sidebar.js'; import { Menubar } from './js/Menubar.js'; + import { VRButton } from '../examples/jsm/webxr/VRButton.js'; window.URL = window.URL || window.webkitURL; window.BlobBuilder = window.BlobBuilder ||...
true
Other
mrdoob
three.js
ba0980bdafc62ae66e9d30d17b89083fb694cb6d.json
Add VR configuration option
editor/js/Config.js
@@ -13,6 +13,7 @@ var Config = function () { 'project/title': '', 'project/editable': false, + 'project/webvr': false, 'project/renderer/antialias': true, 'project/renderer/shadows': true,
true
Other
mrdoob
three.js
ba0980bdafc62ae66e9d30d17b89083fb694cb6d.json
Add VR configuration option
editor/js/Sidebar.Project.js
@@ -54,6 +54,20 @@ var SidebarProject = function ( editor ) { projectsettings.add( editableRow ); + // WebVR + + var vrRow = new UIRow(); + var vr = new UICheckbox( config.getKey( 'project/vr' ) ).setLeft( '100px' ).onChange( function() { + + config.setKey( 'project/vr', this.getValue() ); + + } ); + + vrRow.add...
true
Other
mrdoob
three.js
ba0980bdafc62ae66e9d30d17b89083fb694cb6d.json
Add VR configuration option
editor/js/libs/app.js
@@ -1,3 +1,4 @@ + /** * @author mrdoob / http://mrdoob.com/ */ @@ -12,6 +13,11 @@ var APP = { var loader = new THREE.ObjectLoader(); var camera, scene; + // If VR support is turned on, this button will display + // when the player is running. + var vrButton; + // Returns true if VR support is enabled. ...
true
Other
mrdoob
three.js
853a1812a8cbc1cea83f54f2861d83e4a7ff112a.json
handle normal matrix for InstancedMesh
src/renderers/shaders/ShaderChunk/defaultnormal_vertex.glsl.js
@@ -3,7 +3,14 @@ vec3 transformedNormal = objectNormal; #ifdef USE_INSTANCING - transformedNormal = mat3( instanceMatrix ) * transformedNormal; + // this is in lieu of a per-instance normal-matrix + // shear transforms in the instance matrix are not supported + + mat3 m = mat3( instanceMatrix ); + + transformedNor...
false
Other
mrdoob
three.js
a5c9edd6864bf7b0b0be4644c5388271f39f0d5d.json
Add missing ParameterNames
src/renderers/webgl/WebGLPrograms.js
@@ -35,15 +35,16 @@ function WebGLPrograms( renderer, extensions, capabilities ) { }; var parameterNames = [ - "precision", "supportsVertexTextures", "instancing", - "map", "mapEncoding", "matcap", "matcapEncoding", "envMap", "envMapMode", "envMapEncoding", + "precision", "isWebGL2", "supportsVertexTextures", ...
false
Other
mrdoob
three.js
95c1ca3777626e7d0a0d83c8185e73e101eba194.json
remove material.combine from WebGLProgram
src/renderers/webgl/WebGLProgram.js
@@ -349,13 +349,13 @@ function generateEnvMapModeDefine( parameters ) { } -function generateEnvMapBlendingDefine( parameters, material ) { +function generateEnvMapBlendingDefine( parameters ) { var envMapBlendingDefine = 'ENVMAP_BLENDING_MULTIPLY'; if ( parameters.envMap ) { - switch ( material.combine ...
false
Other
mrdoob
three.js
30050632a7cee49038fd65fe3d5208cc94b32c46.json
Add renderer variable to type definition
examples/jsm/loaders/EquirectangularToCubeGenerator.d.ts
@@ -23,6 +23,7 @@ export interface EquirectangularToCubeGeneratorOptions { export class CubemapGenerator { constructor( renderer: WebGLRenderer ); + renderer: WebGLRenderer; fromEquirectangular( texture: Texture, options?: CubemapGeneratorOptions ): WebGLRenderTargetCube;
false
Other
mrdoob
three.js
4ef5ee3f8830286caf753aada75f5f43f7275e4f.json
Fix basisFile.transcodeImage parameters
examples/js/loaders/BasisTextureLoader.js
@@ -476,8 +476,8 @@ THREE.BasisTextureLoader.BasisWorker = function () { 0, mip, config.format, - hasAlpha, - 0 + 0, + hasAlpha ); if ( ! status ) {
true
Other
mrdoob
three.js
4ef5ee3f8830286caf753aada75f5f43f7275e4f.json
Fix basisFile.transcodeImage parameters
examples/jsm/loaders/BasisTextureLoader.js
@@ -489,8 +489,8 @@ BasisTextureLoader.BasisWorker = function () { 0, mip, config.format, - hasAlpha, - 0 + 0, + hasAlpha ); if ( ! status ) {
true
Other
mrdoob
three.js
65089d82e7e5e5ac78d53efc5dbb206dbf590fcf.json
fix empty name problem in GLTFLoader
examples/js/loaders/GLTFLoader.js
@@ -1826,7 +1826,7 @@ THREE.GLTFLoader = ( function () { texture.flipY = false; - if ( textureDef.name !== undefined ) texture.name = textureDef.name; + if ( textureDef.name ) texture.name = textureDef.name; // Ignore unknown mime types, like DDS files. if ( source.mimeType in MIME_TYPE_FORMATS ) ...
true
Other
mrdoob
three.js
65089d82e7e5e5ac78d53efc5dbb206dbf590fcf.json
fix empty name problem in GLTFLoader
examples/jsm/loaders/GLTFLoader.js
@@ -1891,7 +1891,7 @@ var GLTFLoader = ( function () { texture.flipY = false; - if ( textureDef.name !== undefined ) texture.name = textureDef.name; + if ( textureDef.name ) texture.name = textureDef.name; // Ignore unknown mime types, like DDS files. if ( source.mimeType in MIME_TYPE_FORMATS ) { ...
true
Other
mrdoob
three.js
4f7d05ff2b12ec9f9f568f4d4fd32df239a817b8.json
Use BufferGeometry for frustum helper
examples/jsm/csm/CSM.js
@@ -265,45 +265,55 @@ export default class CSM { helper( cameraMatrix ) { let frustum; - let geometry; + let geometry, vertices; const material = new THREE.LineBasicMaterial( { color: 0xffffff } ); const object = new THREE.Object3D(); for ( let i = 0; i < this.frustums.length; i ++ ) { frustum...
false
Other
mrdoob
three.js
87df048a6b3cc39c5cbd91c8e27cc23a111018e3.json
Allow leading whitespace in declaration regexp leading whitespace is common in copy-paste situations or when using multi-line template literals; this change allows (and ignores) leading whitespace when looking for glsl function declarations
examples/jsm/nodes/core/FunctionNode.js
@@ -6,7 +6,7 @@ import { TempNode } from './TempNode.js'; import { NodeLib } from './NodeLib.js'; -var declarationRegexp = /^([a-z_0-9]+)\s([a-z_0-9]+)\s*\((.*?)\)/i, +var declarationRegexp = /^\s*([a-z_0-9]+)\s([a-z_0-9]+)\s*\((.*?)\)/i, propertiesRegexp = /[a-z_0-9]+/ig; function FunctionNode( src, includes,...
false
Other
mrdoob
three.js
7de2e8d459b2c57842641d011596436f4ee98457.json
update nodematerial prem #18004
examples/jsm/nodes/accessors/ReflectNode.js
@@ -54,7 +54,7 @@ ReflectNode.prototype.generate = function ( builder, output ) { case ReflectNode.VECTOR: - var viewNormalNode = builder.context.viewNormal || new NormalNode(); + var viewNormalNode = builder.context.viewNormal || new NormalNode( NormalNode.VIEW ); var roughnessNode = builder.context...
true
Other
mrdoob
three.js
7de2e8d459b2c57842641d011596436f4ee98457.json
update nodematerial prem #18004
examples/jsm/nodes/misc/TextureCubeNode.js
@@ -10,72 +10,31 @@ import { ReflectNode } from '../accessors/ReflectNode.js'; import { NormalNode } from '../accessors/NormalNode.js'; import { ColorSpaceNode } from '../utils/ColorSpaceNode.js'; -function TextureCubeNode( value, textureSize, uv, bias ) { +function TextureCubeNode( value, uv, bias ) { TempNode...
true
Other
mrdoob
three.js
7de2e8d459b2c57842641d011596436f4ee98457.json
update nodematerial prem #18004
examples/jsm/nodes/misc/TextureCubeUVNode.js
@@ -6,157 +6,159 @@ import { TempNode } from '../core/TempNode.js'; import { ConstNode } from '../core/ConstNode.js'; import { StructNode } from '../core/StructNode.js'; import { FunctionNode } from '../core/FunctionNode.js'; +import { FunctionCallNode } from '../core/FunctionCallNode.js'; +import { ExpressionNode }...
true
Other
mrdoob
three.js
7de2e8d459b2c57842641d011596436f4ee98457.json
update nodematerial prem #18004
examples/webgl_materials_envmaps_hdr_nodes.html
@@ -1,35 +1,18 @@ <!DOCTYPE html> <html lang="en"> <head> - <title>threejs webgl - node material - hdr environment mapping</title> + <title>threejs webgl - materials - hdr environment mapping</title> <meta charset="utf-8"> <meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1....
true
Other
mrdoob
three.js
7de2e8d459b2c57842641d011596436f4ee98457.json
update nodematerial prem #18004
examples/webgl_materials_envmaps_pmrem_nodes.html
@@ -51,7 +51,6 @@ } from './jsm/nodes/Nodes.js'; var params = { - textureSize: 1024, roughness: 0.0, metalness: 0.0, exposure: 1.0, @@ -62,16 +61,14 @@ var container, stats; var camera, scene, renderer, controls; - var nodeMaterial, nodeTexture, nodeTextureSize, nodeTextureIntens...
true
Other
mrdoob
three.js
2a5b77170ad453da5ba1addb8665fdc1e1fc7274.json
Update jsm files.
examples/jsm/postprocessing/EffectComposer.js
@@ -294,6 +294,12 @@ Pass.FullScreenQuad = ( function () { Object.assign( FullScreenQuad.prototype, { + dispose: function () { + + this._mesh.geometry.dispose(); + + }, + render: function ( renderer ) { renderer.render( this._mesh, camera );
true
Other
mrdoob
three.js
2a5b77170ad453da5ba1addb8665fdc1e1fc7274.json
Update jsm files.
examples/jsm/renderers/CSS3DRenderer.js
@@ -16,6 +16,7 @@ var CSS3DObject = function ( element ) { this.element = element; this.element.style.position = 'absolute'; + this.element.style.pointerEvents = 'auto'; this.addEventListener( 'removed', function () { @@ -68,6 +69,7 @@ var CSS3DRenderer = function () { cameraElement.style.WebkitTransfor...
true
Other
mrdoob
three.js
d8d0bdd512bb642b2118784375b38b2c1c9ee8d8.json
Use new .applyMatrix4() method
src/core/BufferGeometry.js
@@ -129,7 +129,8 @@ BufferGeometry.prototype = Object.assign( Object.create( EventDispatcher.prototy if ( position !== undefined ) { - matrix.applyToBufferAttribute( position ); + position.applyMatrix4( matrix ); + position.needsUpdate = true; }
false
Other
mrdoob
three.js
4c3419040361c3ef57453c222d5c29a6aaa764be.json
Remove unused xr.submitFrame()
src/renderers/WebGLRenderer.js
@@ -1244,8 +1244,6 @@ function WebGLRenderer( parameters ) { } - xr.submitFrame(); - } // _gl.finish();
false
Other
mrdoob
three.js
f0ca50e72c5451c1677b5cc9d0b44700b6154c01.json
pass tests by removing trailing space
src/materials/Material.d.ts
@@ -128,7 +128,7 @@ export class Material extends EventDispatcher { colorWrite: boolean; /** - * Custom defines to be injected into the shader. These are passed in form of an object literal, with key/value pairs. { MY_CUSTOM_DEFINE: '' , PI2: Math.PI * 2 }. + * Custom defines to be injected into the shader. Th...
false
Other
mrdoob
three.js
19ef82b9430d1967e93fc601672803053883d89e.json
Add defines to material types
src/materials/Material.d.ts
@@ -30,6 +30,7 @@ export interface MaterialParameters { clippingPlanes?: Plane[]; clipShadows?: boolean; colorWrite?: boolean; + defines?: any; depthFunc?: DepthModes; depthTest?: boolean; depthWrite?: boolean; @@ -125,6 +126,12 @@ export class Material extends EventDispatcher { * Whether to render the m...
false
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
editor/js/Menubar.Help.js
@@ -48,4 +48,4 @@ var MenubarHelp = function ( editor ) { }; -export { MenubarHelp }; +export { MenubarHelp };
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
editor/js/commands/SetMaterialCommand.js
@@ -78,4 +78,4 @@ SetMaterialCommand.prototype = { }; -export { SetMaterialCommand }; +export { SetMaterialCommand };
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
editor/js/commands/SetMaterialMapCommand.js
@@ -134,4 +134,4 @@ SetMaterialMapCommand.prototype = { }; -export { SetMaterialMapCommand }; +export { SetMaterialMapCommand };
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
examples/js/loaders/VRMLLoader.js
@@ -2035,7 +2035,7 @@ THREE.VRMLLoader = ( function () { // materials can be influenced by the geometry (e.g. vertex normals). cloning is necessary to avoid // any side effects - return ( build.isObject3D || build.isMaterial ) ? build.clone() : build; + return ( build.isObject3D || build.isMaterial ) ...
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
examples/jsm/controls/TransformControls.d.ts
@@ -13,7 +13,7 @@ export class TransformControls extends Object3D { // API camera: Camera; - object: Object3D | undefined; + object: Object3D | undefined; enabled: boolean; axis: string | null; mode: string;
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
examples/jsm/exporters/PLYExporter.d.ts
@@ -9,6 +9,6 @@ export class PLYExporter { constructor(); - parse( object: Object3D, onDone: ( res: string ) => void, options: PLYExporterOptions ): string | null; + parse( object: Object3D, onDone: ( res: string ) => void, options: PLYExporterOptions ): string | null; }
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
examples/jsm/lines/WireframeGeometry2.d.ts
@@ -7,7 +7,7 @@ import { LineSegmentsGeometry } from './LineSegmentsGeometry'; export class WireframeGeometry2 extends LineSegmentsGeometry { - constructor( geometry: Geometry | BufferGeometry ); + constructor( geometry: Geometry | BufferGeometry ); isWireframeGeometry2: boolean; }
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
examples/jsm/loaders/BasisTextureLoader.d.ts
@@ -8,7 +8,7 @@ import { export class BasisTextureLoader extends Loader { constructor( manager?: LoadingManager ); - transcoderBinary: ArrayBuffer | null; + transcoderBinary: ArrayBuffer | null; transcoderPath: string; transcoderPending: Promise<void> | null;
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
examples/jsm/loaders/GLTFLoader.d.ts
@@ -29,8 +29,8 @@ export interface GLTF { export class GLTFLoader extends Loader { constructor( manager?: LoadingManager ); - dracoLoader: DRACOLoader | null; - ddsLoader: DDSLoader | null; + dracoLoader: DRACOLoader | null; + ddsLoader: DDSLoader | null; load( url: string, onLoad: ( gltf: GLTF ) => void, onPr...
true
Other
mrdoob
three.js
8aeac464bf796f15bd17b46312c3e5436b939d43.json
Remove non-breaking space from code.
examples/jsm/loaders/VRMLLoader.js
@@ -2072,7 +2072,7 @@ var VRMLLoader = ( function () { // materials can be influenced by the geometry (e.g. vertex normals). cloning is necessary to avoid // any side effects - return ( build.isObject3D || build.isMaterial ) ? build.clone() : build; + return ( build.isObject3D || build.isMaterial ) ? ...
true