language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | mrdoob | three.js | 1061e2e0cd220d84c1a6a14814ae8514cd04ef78.json | Add geometries es6 unit tests | test/unit/src/geometries/TorusKnotGeometry.tests.js | @@ -0,0 +1,110 @@
+/**
+ * @author TristanVALCKE / https://github.com/Itee
+ * @author Anonymous
+ */
+/* global QUnit */
+
+import {
+ TorusKnotGeometry,
+ TorusKnotBufferGeometry
+} from '../../../../src/geometries/TorusKnotGeometry';
+
+export default QUnit.module( 'Geometries', () => {
+
+ QUnit.module.todo( 'Spher... | true |
Other | mrdoob | three.js | 1061e2e0cd220d84c1a6a14814ae8514cd04ef78.json | Add geometries es6 unit tests | test/unit/src/geometries/TubeGeometry.tests.js | @@ -0,0 +1,85 @@
+/**
+ * @author TristanVALCKE / https://github.com/Itee
+ */
+/* global QUnit */
+
+import {
+ TubeGeometry,
+ TubeBufferGeometry
+} from '../../../../src/geometries/TubeGeometry';
+
+export default QUnit.module( 'Geometries', () => {
+
+ QUnit.module.todo( 'TubeGeometry', ( hooks ) => {
+
+ var geom... | true |
Other | mrdoob | three.js | 1061e2e0cd220d84c1a6a14814ae8514cd04ef78.json | Add geometries es6 unit tests | test/unit/src/geometries/WireframeGeometry.tests.js | @@ -0,0 +1,46 @@
+/**
+ * @author TristanVALCKE / https://github.com/Itee
+ */
+/* global QUnit */
+
+import { WireframeGeometry } from '../../../../src/geometries/WireframeGeometry';
+
+export default QUnit.module( 'Geometries', () => {
+
+ QUnit.module.todo( 'WireframeGeometry', ( hooks ) => {
+
+ var geometries = u... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/README.MD | @@ -0,0 +1,40 @@
+# THREEJS Benchmark Suite
+
+### Example: Adding a New Suite
+
+For adding a new Tests we need two things
+ - Adding the Test File
+ - Linking it on the benchmark.html page
+
+Some example could be like this
+```javascript
+(function() {
+ // We want to make sure THREE.JS is loaded for this Benchmark... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/benchmark.js | @@ -0,0 +1,79 @@
+var BenchClass = function() {
+ this.suites = [];
+ this.THREE = window.THREE ;
+ window.THREE = undefined;
+ Benchmark.options.maxTime = 1.0;
+ return this;
+}
+
+BenchClass.prototype.isTHREELoaded = function() {
+ return _.isObject(this.THREE);
+}
+
+BenchClass.prototype.newSuite = function(na... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/benchmarks.html | @@ -0,0 +1,51 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <meta charset="utf-8">
+ <title>ThreeJS Benchmark Tests - Using Files in /src</title>
+ <link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:700" rel="stylesheet" type="text/css">
+ <link href="normalize.css" rel="stylesheet" type="text/css">
+ <li... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/core/Float32Array.js | @@ -0,0 +1,82 @@
+(function() {
+
+ var input = new Float32Array(10000 * 3);
+ var output = new Float32Array(10000 * 3);
+
+ for (var j = 0, jl = input.length; j < jl; j++) {
+ input[j] = j;
+ }
+
+ var inputVectors = [];
+ var outputVectors = [];
+
+ for (var j = 0, jl = input.length / 3; j < jl; j++) {
+ ... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/core/Vector3Components.js | @@ -0,0 +1,110 @@
+(function() {
+
+ var s = Bench.newSuite("Vector 3 Components");
+
+ THREE = {};
+
+ THREE.Vector3 = function(x, y, z) {
+ this.x = x || 0;
+ this.y = y || 0;
+ this.z = z || 0;
+ };
+
+ THREE.Vector3.prototype = {
+ constructor: THREE.Vector3,
+ setComponent: function(index, valu... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/core/Vector3Length.js | @@ -0,0 +1,59 @@
+(function() {
+
+ var THREE = {};
+
+ THREE.Vector3 = function(x, y, z) {
+
+ this.x = x || 0;
+ this.y = y || 0;
+ this.z = z || 0;
+
+ };
+
+ THREE.Vector3.prototype = {
+ constructor: THREE.Vector3,
+ lengthSq: function() {
+ return this.x * this.x + this.y * this.y + this.z... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/core/Vector3Storage.js | @@ -0,0 +1,113 @@
+(function() {
+
+ THREE = {};
+
+ THREE.Vector3 = function(x, y, z) {
+
+ this.x = x || 0;
+ this.y = y || 0;
+ this.z = z || 0;
+
+ };
+
+ THREE.Vector3.prototype = {
+
+ constructor: THREE.Vector3,
+
+ length: function() {
+
+ return Math.sqrt(this.x * this.x + this.y * this... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/normalize.css | @@ -0,0 +1,419 @@
+/*! normalize.css v4.1.1 | MIT License | github.com/necolas/normalize.css */
+
+/**
+ * 1. Change the default font family in all browsers (opinionated).
+ * 2. Prevent adjustments of font size after orientation changes in IE and iOS.
+ */
+
+html {
+ font-family: sans-serif; /* 1 */
+ -ms-text-size... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/style.css | @@ -0,0 +1,96 @@
+html{
+ background-color: #FFE0F7;
+}
+
+body{
+ font-family: 'Source Sans Pro', sans-serif;
+}
+
+header{
+
+}
+header h1{
+ color: #6F0752;
+ border-bottom: 4px solid #A23183;
+ margin: 10px;
+}
+
+article{
+ border: 2px solid #B8509B;
+ margin:5px 10px;
+ border-radius:1... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/vendor/benchmark-2.1.0.min.js | @@ -0,0 +1 @@
+(function(){"use strict";function e(t){function s(e,n,t){var r=this;return r instanceof s?(Y.isPlainObject(e)?t=e:Y.isFunction(e)?(t=n,n=e):Y.isPlainObject(n)?(t=n,n=null,r.name=e):r.name=e,_(r,t),r.id||(r.id=++c),null==r.fn&&(r.fn=n),r.stats=ke(r.stats),void(r.times=ke(r.times))):new s(e,n,t)}function a... | true |
Other | mrdoob | three.js | 83fe533cc16ebb78e3ba72a3ae04a603b4bc00b0.json | Reintroduce benchmarks (unchanged) | test/benchmark/vendor/lodash.min.js | @@ -0,0 +1,127 @@
+/**
+ * @license
+ * lodash lodash.com/license | Underscore.js 1.8.3 underscorejs.org/LICENSE
+ */
+;(function(){function t(t,n){return t.set(n[0],n[1]),t}function n(t,n){return t.add(n),t}function r(t,n,r){switch(r.length){case 0:return t.call(n);case 1:return t.call(n,r[0]);case 2:return t.call(n,r... | true |
Other | mrdoob | three.js | fa11f5f2120600cc5686c2fd2333057e389f15d8.json | Update GLTFLoader.parse documentation | docs/examples/loaders/GLTFLoader.html | @@ -120,14 +120,15 @@ <h3>[method:null setCrossOrigin]( [page:String value] )</h3>
[page:String value] — The crossOrigin string to implement CORS for loading the url from a different domain that allows CORS.
</div>
- <h3>[method:null parse]( [page:Object json], [page:Function callBack], [page:String path] )</h... | false |
Other | mrdoob | three.js | 11b9d7d8ca3244322116a2e64448feb4f4ef82f9.json | reduce default particle count for IE and Edge | examples/webgl_gpgpu_protoplanet.html | @@ -266,11 +266,15 @@
if ( ! Detector.webgl ) Detector.addGetWebGLMessage();
+ var isIE = /Trident/i.test( navigator.userAgent );
+ var isEdge = /Edge/i.test( navigator.userAgent );
+
var hash = document.location.hash.substr( 1 );
+
if ( hash ) hash = parseInt( hash, 0 );
// Texture width for ... | false |
Other | mrdoob | three.js | 8d122e7777000ecb5988615a29b3045a91f1672e.json | Use WebVR 1.1 view matrices correctly in VREffect
This will make VREffect work correctly in cases where the view
transforms are not simply based on the head pose with the eye
translation applied. For example, they may contain eye orientation.
The code is partially based on an earlier attempt to fix this by
Brandon Jon... | examples/js/effects/VREffect.js | @@ -14,6 +14,9 @@ THREE.VREffect = function ( renderer, onError ) {
var eyeTranslationL = new THREE.Vector3();
var eyeTranslationR = new THREE.Vector3();
var renderRectL, renderRectR;
+ var headMatrix = new THREE.Matrix4();
+ var eyeMatrixL = new THREE.Matrix4();
+ var eyeMatrixR = new THREE.Matrix4();
var fr... | false |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/addons/io_three/exporter/scene.py | @@ -150,8 +150,7 @@ def write(self):
if geo_type == constants.GEOMETRY.lower():
geom_data.pop(constants.DATA)
elif geo_type == constants.BUFFER_GEOMETRY.lower():
- geom_data.pop(constants.ATTRIBUTES)
- geom_... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/js/review.js | @@ -133,21 +133,20 @@ function loadGeometry( data, url ) {
}
- var material = new THREE.MultiMaterial( data.materials );
var mesh;
if ( data.geometry.animations !== undefined && data.geometry.animations.length > 0 ) {
console.log( 'loading animation' );
data.materials[ 0 ].sk... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/cubeA.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces
+ $JSON --vertices --faces --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_animation.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/anim.blend --python $PYSCRIPT -- \
$JSON --vertices --faces --animation rest --bones --skinning \
- --embedAnimation
+ --embedAnimation --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_bump_spec_maps.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/planeA.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --faceMaterials --uvs --maps --copyTextures
+ $JSON --vertices --faces --faceMaterials --uvs --maps --exportText... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_diffuse_map.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/cubeA.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --faceMaterials --uvs --maps --copyTextures
+ $JSON --vertices --faces --faceMaterials --uvs --maps --exportTextu... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_influences.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/anim.blend --python $PYSCRIPT -- \
$JSON --vertices --faces --animation --bones --skinning \
- --embedAnimation --influencesPerVertex 4
+ --embedAnimation --influencesPerVertex 4 --geometryType Geometry
makereview $@ --tag $(ta... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_lambert_material.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/cubeA.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --faceMaterials
+ $JSON --vertices --faces --faceMaterials --geometryType Geometry
makereview $@ --tag $(tagname... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_light_map.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/lightmap.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --faceMaterials --uvs --maps --copyTextures
+ $JSON --vertices --faces --faceMaterials --uvs --maps --exportTe... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_mix_colors.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/cubeB.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --colors --faceMaterials --mixColors
+ $JSON --vertices --faces --colors --faceMaterials --mixColors --geometryTy... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_morph_targets.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/anim.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --morphTargets --embedAnimation
+ $JSON --vertices --faces --morphTargets --embedAnimation --geometryType Geometry... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_normal_map.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/planeB.blend --python $PYSCRIPT -- \
$JSON --vertices --faces --faceMaterials --uvs --maps --normals \
- --copyTextures
+ --exportTextures --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_normals.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/torusA.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --normals --indent
+ $JSON --vertices --faces --normals --indent --geometryType Geometry
makereview $@ --tag $(... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_phong_material.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/torusA.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --normals --faceMaterials
+ $JSON --vertices --faces --normals --faceMaterials --geometryType Geometry
makerevi... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_vertex_colors.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/cubeB.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --colors --faceMaterials
+ $JSON --vertices --faces --colors --faceMaterials --geometryType Geometry
makereview ... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_geometry_wireframe.bash | @@ -4,5 +4,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "$DIR/setup_test_env.bash"
blender --background $BLEND/cubeC.blend --python $PYSCRIPT -- \
- $JSON --vertices --faces --faceMaterials
+ $JSON --vertices --faces --faceMaterials --geometryType Geometry
makereview $@ --tag $(tagname... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_area_light.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_area_light.blend \
--python $PYSCRIPT -- $JSON --vertices --faces --scene \
- --lights --materials --embedGeometry
+ --lights --materials --embedGeometry --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_children.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_children.blend \
--python $PYSCRIPT -- $JSON --vertices --faces --scene \
- --cameras --materials --embedGeometry --lights --cameras
+ --cameras --materials --embedGeometry --lights --cameras --geometryType Geometry
maker... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_directional_light.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_directional_light.blend \
--python $PYSCRIPT -- $JSON --vertices --faces --scene \
- --lights --materials --embedGeometry
+ --lights --materials --embedGeometry --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_hemi_light.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_hemi_light.blend \
--python $PYSCRIPT -- $JSON --vertices --faces --scene \
- --lights --materials --embedGeometry
+ --lights --materials --embedGeometry --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_instancing.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_instancing.blend --python $PYSCRIPT -- \
$JSON --vertices --faces --scene --materials --enablePrecision \
- --precision 4 --embedGeometry --indent
+ --precision 4 --embedGeometry --indent --geometryType Geometry
makerevie... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_maps.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_maps.blend --python $PYSCRIPT -- \
$JSON --vertices --faces --scene --materials --maps \
- --uvs --embedGeometry --copyTextures
+ --uvs --embedGeometry --exportTextures --geometryType Geometry
makereview $@ --tag $(tagnam... | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_no_embed.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_instancing.blend --python $PYSCRIPT -- \
$JSON --vertices --faces --scene --materials --enablePrecision \
- --precision 4
+ --precision 4 --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_orthographic.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_orthographic_camera.blend \
--python $PYSCRIPT -- $JSON --vertices --faces --scene \
- --cameras --materials --embedGeometry
+ --cameras --materials --embedGeometry --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_perspective.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_perspective_camera.blend \
--python $PYSCRIPT -- $JSON --vertices --faces --scene \
- --cameras --materials --embedGeometry
+ --cameras --materials --embedGeometry --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_point_light.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_point_light.blend \
--python $PYSCRIPT -- $JSON --vertices --faces --scene \
- --lights --materials --embedGeometry
+ --lights --materials --embedGeometry --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 16b938bd9d600bf887274efb8f7284fa9256cf74.json | fix some blender exporter tests | utils/exporters/blender/tests/scripts/test_scene_spot_light.bash | @@ -5,5 +5,5 @@ source "$DIR/setup_test_env.bash"
blender --background $BLEND/scene_spot_light.blend \
--python $PYSCRIPT -- $JSON --vertices --faces --scene \
- --lights --materials --embedGeometry
+ --lights --materials --embedGeometry --geometryType Geometry
makereview $@ --tag $(tagname) | true |
Other | mrdoob | three.js | 5989d08230a8d5a6c82cc9c70172d2c920e79b0d.json | Fix OBJExporter without normals | examples/js/exporters/OBJExporter.js | @@ -124,7 +124,7 @@ THREE.OBJExporter.prototype = {
j = indices.getX( i + m ) + 1;
- face[ m ] = ( indexVertex + j ) + '/' + ( uvs ? ( indexVertexUvs + j ) : '' ) + '/' + ( indexNormals + j );
+ face[ m ] = ( indexVertex + j ) + '/' + ( uvs ? ( indexVertexUvs + j ) : '' ) + ( normals ? '/' + ( i... | false |
Other | mrdoob | three.js | dbb1a026f09c6ada1dbe069ce3dd460964abd9f3.json | Add OBJ loader to gltf example | examples/js/exporters/GLTFExporter.js | @@ -1487,4 +1487,4 @@ THREE.GLTFExporter.prototype = {
}
-};
+};
\ No newline at end of file | true |
Other | mrdoob | three.js | dbb1a026f09c6ada1dbe069ce3dd460964abd9f3.json | Add OBJ loader to gltf example | examples/misc_exporter_gltf.html | @@ -26,6 +26,7 @@
<button id="export_scene">Export Scene1</button>
<button id="export_scenes">Export Scene1 and Scene 2</button>
<button id="export_object">Export Sphere</button>
+ <button id="export_obj">Export WaltHead</button>
<button id="export_objects">Export Sphere and Grid</button>
<button ... | true |
Other | mrdoob | three.js | 171de9dfbbe6c0e133408c1c0fd5e57c544690d7.json | Fix OBJ loader with empty uvs or normals | examples/js/loaders/OBJLoader.js | @@ -286,19 +286,17 @@ THREE.OBJLoader = ( function () {
this.addVertex( ia, ib, ic );
- if ( ua !== undefined ) {
+ if ( ua !== undefined && ua !== '' ) {
var uvLen = this.uvs.length;
-
ia = this.parseUVIndex( ua, uvLen );
ib = this.parseUVIndex( ub, uvLen );
ic = this.parseUVIn... | false |
Other | mrdoob | three.js | 38de4ccca5ecc0df5779cbcee7a3c2f4e4f6cd64.json | Add padding to glb chunks | examples/js/exporters/GLTFExporter.js | @@ -128,7 +128,18 @@ THREE.GLTFExporter.prototype = {
* @param {string} text
* @return {ArrayBuffer}
*/
- function stringToArrayBuffer( text ) {
+ function stringToArrayBuffer( text, padded ) {
+ if ( padded ) {
+
+ var pad = getPaddedBufferSize( text.length ) - text.length;
+
+ for ( var i = 0; ... | false |
Other | mrdoob | three.js | d45a042cf962e9b1aa9441810ba118647b48aacb.json | Allow context menu when controls are disabled | examples/js/controls/OrbitControls.js | @@ -888,6 +888,8 @@ THREE.OrbitControls = function ( object, domElement ) {
function onContextMenu( event ) {
+ if ( scope.enabled === false ) return;
+
event.preventDefault();
} | false |
Other | mrdoob | three.js | 8d9130d3ddee37bd78c0aaf6de6da27e8f4c0c74.json | add example in list | examples/files.js | @@ -244,6 +244,7 @@ var files = {
"webgl_simple_gi",
"webgl_skinning_simple",
"webgl_sprites",
+ "webgl_sprites_nodes",
"webgl_terrain_dynamic",
"webgl_test_memory",
"webgl_test_memory2", | false |
Other | mrdoob | three.js | c99579810c266ede1eaa18acee77dae55fa5c0eb.json | Add displacementMap support to distanceRGBA shader | src/renderers/shaders/ShaderLib.js | @@ -192,6 +192,7 @@ var ShaderLib = {
uniforms: UniformsUtils.merge( [
UniformsLib.common,
+ UniformsLib.displacementmap,
{
lightPos: { value: new Vector3() }
} | true |
Other | mrdoob | three.js | c99579810c266ede1eaa18acee77dae55fa5c0eb.json | Add displacementMap support to distanceRGBA shader | src/renderers/shaders/ShaderLib/distanceRGBA_vert.glsl | @@ -2,6 +2,7 @@ varying vec4 vWorldPosition;
#include <common>
#include <uv_pars_vertex>
+#include <displacementmap_pars_vertex>
#include <morphtarget_pars_vertex>
#include <skinning_pars_vertex>
#include <clipping_planes_pars_vertex>
@@ -11,9 +12,19 @@ void main() {
#include <uv_vertex>
#include <skinbase... | true |
Other | mrdoob | three.js | 9b12fad68dba3ea23ca4e5c3f8cd428f0a19ab88.json | Remove overlooked slot | 0 defensive checks. | editor/js/commands/SetMaterialColorCommand.js | @@ -20,7 +20,7 @@ var SetMaterialColorCommand = function ( object, attributeName, newValue, slot )
this.object = object;
this.attributeName = attributeName;
- this.slot = slot | 0;
+ this.slot = slot;
var material = this.editor.getObjectMaterial( this.object, this.slot );
| true |
Other | mrdoob | three.js | 9b12fad68dba3ea23ca4e5c3f8cd428f0a19ab88.json | Remove overlooked slot | 0 defensive checks. | editor/js/commands/SetMaterialCommand.js | @@ -19,7 +19,7 @@ var SetMaterialCommand = function ( object, newMaterial , slot) {
this.object = object;
- this.slot = slot | 0;
+ this.slot = slot;
var material = this.editor.getObjectMaterial( this.object, this.slot );
| true |
Other | mrdoob | three.js | 62cae272869c70d99e95f75619973cdb750f7d1d.json | Load cube map only once | examples/webgl_materials_cubemap_balls_refraction.html | @@ -77,12 +77,8 @@
var geometry = new THREE.SphereBufferGeometry( 100, 32, 16 );
- var textureCube = new THREE.CubeTextureLoader()
- .setPath( 'textures/cube/Park3Med/' )
- .load( [ 'px.jpg', 'nx.jpg', 'py.jpg', 'ny.jpg', 'pz.jpg', 'nz.jpg' ] );
- textureCube.mapping = THREE.CubeRefractionMapping... | false |
Other | mrdoob | three.js | a5efcd16744d1ae71d3bf80c25d361ff1e1a9f4d.json | Remove dead code. | editor/js/commands/SetMaterialColorCommand.js | @@ -24,7 +24,6 @@ var SetMaterialColorCommand = function ( object, attributeName, newValue, slot )
var material = this.editor.getObjectMaterial( this.object, this.slot );
- //this.oldValue = ( object !== undefined ) ? this.object.material[ this.attributeName ].getHex() : undefined;
this.oldValue = ( material !=... | false |
Other | mrdoob | three.js | 4e651f4827b172960f9ff241515d190ac391f5e3.json | Add multiple material slots to three Editor. | editor/js/Editor.js | @@ -347,6 +347,38 @@ Editor.prototype = {
},
+ getObjectMaterial: function ( object, slot ) {
+
+ var material = object.material;
+
+ if( Array.isArray( material ) == true){
+ var slot = slot | 0;
+
+ if(slot < 0) slot = 0;
+ else if(slot >= material.length) slot = material.length;
+
+ material = mater... | true |
Other | mrdoob | three.js | 4e651f4827b172960f9ff241515d190ac391f5e3.json | Add multiple material slots to three Editor. | editor/js/Sidebar.Material.js | @@ -5,7 +5,10 @@
Sidebar.Material = function ( editor ) {
var signals = editor.signals;
+
var currentObject;
+
+ var currentMaterialSlot = 0;
var container = new UI.Panel();
container.setBorderTop( '0' );
@@ -14,13 +17,27 @@ Sidebar.Material = function ( editor ) {
// New / Copy / Paste
var copiedM... | true |
Other | mrdoob | three.js | 4e651f4827b172960f9ff241515d190ac391f5e3.json | Add multiple material slots to three Editor. | editor/js/commands/SetMaterialColorCommand.js | @@ -10,7 +10,7 @@
* @constructor
*/
-var SetMaterialColorCommand = function ( object, attributeName, newValue ) {
+var SetMaterialColorCommand = function ( object, attributeName, newValue, slot ) {
Command.call( this );
@@ -20,24 +20,30 @@ var SetMaterialColorCommand = function ( object, attributeName, newV... | true |
Other | mrdoob | three.js | 4e651f4827b172960f9ff241515d190ac391f5e3.json | Add multiple material slots to three Editor. | editor/js/commands/SetMaterialCommand.js | @@ -9,31 +9,40 @@
* @constructor
*/
-var SetMaterialCommand = function ( object, newMaterial ) {
+
+var SetMaterialCommand = function ( object, newMaterial , slot) {
Command.call( this );
this.type = 'SetMaterialCommand';
this.name = 'New Material';
this.object = object;
- this.oldMaterial = ( objec... | true |
Other | mrdoob | three.js | 4e651f4827b172960f9ff241515d190ac391f5e3.json | Add multiple material slots to three Editor. | editor/js/commands/SetMaterialValueCommand.js | @@ -10,16 +10,20 @@
* @constructor
*/
-var SetMaterialValueCommand = function ( object, attributeName, newValue ) {
+var SetMaterialValueCommand = function ( object, attributeName, newValue, slot ) {
Command.call( this );
this.type = 'SetMaterialValueCommand';
this.name = 'Set Material.' + attributeName... | true |
Other | mrdoob | three.js | 4205deffbee6a6c094546913af77903a82be3494.json | Improve introduction doc fixing small scope issues
Small issues:
- Missing `var` keywords
- Multiple left-hand assignments declaring global variables, more info: http://stackoverflow.com/questions/1758576/multiple-left-hand-assignment-with-javascript | docs/manual/introduction/How-to-update-things.html | @@ -69,14 +69,14 @@ <h3>[page:BufferGeometry]</h3>
geometry.addAttribute( 'position', new THREE.BufferAttribute( positions, 3 ) );
// draw range
-drawCount = 2; // draw the first 2 points, only
+var drawCount = 2; // draw the first 2 points, only
geometry.setDrawRange( 0, drawCount );
// material
var material ... | false |
Other | mrdoob | three.js | f9f4827a5959678f9de40e4ba88e1a97e30504fa.json | fix comparison with -0 in Math.js | test/unit/src/math/Math.js | @@ -24,12 +24,21 @@ QUnit.test( "Math.sign/polyfill", function( assert ) {
assert.ok( isNaN( Math.sign(new THREE.Vector3()) ) , "If x is NaN<object>, the result is NaN.");
assert.ok( isNaN( Math.sign() ) , "If x is NaN<undefined>, the result is NaN.");
assert.ok( isNaN( Math.sign('--3') ) , "If x is NaN<'--3'>, t... | false |
Other | mrdoob | three.js | c9a85c59f821841872daf13f5e1fc7111d11bc2c.json | Remove return statement from .update() | src/helpers/FaceNormalsHelper.js | @@ -110,8 +110,6 @@ FaceNormalsHelper.prototype.update = ( function () {
position.needsUpdate = true;
- return this;
-
};
}() ); | false |
Other | mrdoob | three.js | 10c8fcaa50c1c620d0deb4800490fb29742777a1.json | Remove return statement from .update() | src/helpers/VertexNormalsHelper.js | @@ -145,8 +145,6 @@ VertexNormalsHelper.prototype.update = ( function () {
position.needsUpdate = true;
- return this;
-
};
}() ); | false |
Other | mrdoob | three.js | f3258e2d0b91b1bd65a4ace0e8abfb829699c1cb.json | Remove unintelligible part of explanation
Not sure if the points are added to or replace present content of the curve? | docs/api/extras/core/Path.html | @@ -98,7 +98,7 @@ <h3>[method:null fromPoints]( [page:Array vector2s] )</h3>
<div>
points -- array of [page:Vector2 Vector2s].<br /><br />
- Adds to the from the points. Points are added to the [page:CurvePath.curves curves]
+ Points are added to the [page:CurvePath.curves curves]
array as [page:LineC... | false |
Other | mrdoob | three.js | 89a944794d2021876feaa2ab316b589006d1de6a.json | fix index error in example | docs/api/core/Geometry.html | @@ -159,8 +159,8 @@ <h3>[property:Array skinIndices]</h3>
In code another example could look like this:
<code>
// e.g.
- geometry.skinIndices[15] = new THREE.Vector4( 0, 5, 9, 0 );
- geometry.skinWeights[15] = new THREE.Vector4( 0.2, 0.5, 0.3, 0 );
+ geometry.skinIndices[15] = new THREE.Vector4( 0, ... | false |
Other | mrdoob | three.js | f095b7979d1dfbd3fd38f15dffd944629f0e66f3.json | fix typo Mixin => Mixing | docs/api/core/EventDispatcher.html | @@ -1,100 +1,100 @@
-<!DOCTYPE html>
-<html lang="en">
- <head>
+<!DOCTYPE html>
+<html lang="en">
+ <head>
<meta charset="utf-8" />
- <base href="../../" />
- <script src="list.js"></script>
- <script src="page.js"></script>
- <link type="text/css" rel="stylesheet" href="page.css" />
- </head>
- <body>
- <... | false |
Other | mrdoob | three.js | 40b030addac577fd823bf1997d546ce63bb3241b.json | remove duplicate verticesNeedUpdate | docs/api/core/DirectGeometry.html | @@ -82,9 +82,6 @@ <h3>[property:Boolean verticesNeedUpdate]</h3>
<h3>[property:Boolean normalsNeedUpdate]</h3>
<div>Default is false.</div>
- <h3>[property:Boolean verticesNeedUpdate]</h3>
- <div>Default is false.</div>
-
<h3>[property:Boolean colorsNeedUpdate]</h3>
<div>Default is false.</div>
| false |
Other | mrdoob | three.js | 57a483cfb8dbeb3e7a33af69f07bf10e6ec92e7d.json | remove unicode character from EllipseCurve.js | src/extras/curves/EllipseCurve.js | @@ -14,7 +14,7 @@ function EllipseCurve( aX, aY, xRadius, yRadius, aStartAngle, aEndAngle, aClockw
this.xRadius = xRadius || 1;
this.yRadius = yRadius || 1;
- this.aStartAngle = aStartAngle || 0;
+ this.aStartAngle = aStartAngle || 0;
this.aEndAngle = aEndAngle || 2 * Math.PI;
this.aClockwise = aClockwise |... | false |
Other | mrdoob | three.js | 0c37de10c09937193fec289d29eaea4edb33c81a.json | Generalize Reflector geometry | examples/js/objects/Reflector.js | @@ -2,9 +2,9 @@
* @author Slayvin / http://slayvin.net
*/
-THREE.Reflector = function ( width, height, options ) {
+THREE.Reflector = function ( geometry, options ) {
- THREE.Mesh.call( this, new THREE.PlaneBufferGeometry( width, height ) );
+ THREE.Mesh.call( this, geometry );
this.type = 'Reflect... | true |
Other | mrdoob | three.js | 0c37de10c09937193fec289d29eaea4edb33c81a.json | Generalize Reflector geometry | examples/webgl_mirror.html | @@ -86,9 +86,10 @@
var planeGeo = new THREE.PlaneBufferGeometry( 100.1, 100.1 );
- // reflector/mirror planes
+ // reflectors/mirrors
- var groundMirror = new THREE.Reflector( 100, 100, {
+ var geometry = new THREE.PlaneBufferGeometry( 100, 100 );
+ var groundMirror = new THREE.Reflector( geom... | true |
Other | mrdoob | three.js | 0ebf4a2669354109f449aca431abddaf8cb49439.json | Prevent needsUpdate true every frame | examples/webgl_materials_channels.html | @@ -63,6 +63,12 @@
side: 'double'
};
+ var sides = {
+ 'front': THREE.FrontSide,
+ 'back': THREE.BackSide,
+ 'double': THREE.DoubleSide
+ };
+
var cameraOrtho, cameraPerspective;
var controlsOrtho, controlsPerspective;
@@ -277,7 +283,7 @@
}
- if ( params.side !== material... | false |
Other | mrdoob | three.js | 9be2ae09e964443672dc014ced3378283fa81bf0.json | Set local path like in GLTFLoader | examples/js/loaders/ColladaLoader.js | @@ -19,7 +19,7 @@ THREE.ColladaLoader.prototype = {
var scope = this;
- scope.path = scope.path === undefined ? THREE.Loader.prototype.extractUrlBase( url ) : scope.path;
+ var path = scope.path === undefined ? THREE.Loader.prototype.extractUrlBase( url ) : scope.path;
va... | false |
Other | mrdoob | three.js | 24acde9a7581a1529e5a0452b1d80899b4bf8f8b.json | Add envmap to glTF 2.0 demo. | examples/webgl_loader_gltf2.html | @@ -253,6 +253,25 @@
if (sceneInfo.objectScale)
object.scale.copy(sceneInfo.objectScale);
+ if ( sceneInfo.addEnvMap ) {
+
+ var envMap = getEnvMap();
+
+ object.traverse( function( node ) {
+
+ if ( node.material && node.material.isMeshStandardMaterial ) {
+
+ node.material.en... | false |
Other | mrdoob | three.js | abdd1713c606135bc35028c6021698b52f27872b.json | Remove resetPose functionality.
Will be removed from spec going forward (handled at Platform level (or app)), better if just not present and relied upon.
See:
https://github.com/w3c/webvr/issues/189
https://bugs.chromium.org/p/chromium/issues/detail?id=706561 | examples/js/controls/VRControls.js | @@ -140,30 +140,6 @@ THREE.VRControls = function ( object, onError ) {
};
- this.resetPose = function () {
-
- if ( vrDisplay ) {
-
- vrDisplay.resetPose();
-
- }
-
- };
-
- this.resetSensor = function () {
-
- console.warn( 'THREE.VRControls: .resetSensor() is now .resetPose().' );
- this.resetPose();
-
- ... | false |
Other | mrdoob | three.js | e2256a3132e2cd9afaf96b336fbd61dd1e0ea6f9.json | Add module import doc | README.md | @@ -19,7 +19,7 @@ The aim of the project is to create an easy to use, lightweight, 3D library. The
### Usage ###
-Download the [minified library](http://threejs.org/build/three.min.js) and include it in your html.
+Download the [minified library](http://threejs.org/build/three.min.js) and include it in your html, ... | true |
Other | mrdoob | three.js | e2256a3132e2cd9afaf96b336fbd61dd1e0ea6f9.json | Add module import doc | docs/list.js | @@ -4,6 +4,7 @@ var list = {
"Getting Started": {
"Creating a scene": "manual/introduction/Creating-a-scene",
+ "Import via modules": "manual/introduction/Import-via-modules",
"WebGL compatibility check": "manual/introduction/WebGL-compatibility-check",
"How to run things locally": "manual/introducti... | true |
Other | mrdoob | three.js | e2256a3132e2cd9afaf96b336fbd61dd1e0ea6f9.json | Add module import doc | docs/manual/introduction/Import-via-modules.html | @@ -0,0 +1,72 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+ <meta charset="utf-8">
+ <base href="../../" />
+ <script src="list.js"></script>
+ <script src="page.js"></script>
+ <link type="text/css" rel="stylesheet" href="page.css" />
+ </head>
+ <body>
+ <h1>[name]</h1><br />
+
+ <div>
+ While importing t... | true |
Other | mrdoob | three.js | c39c1c6fdf8db8921a8eb6a9279537fba9150c44.json | Fix basic grammar mistake
http://data.grammarbook.com/blog/pronouns/1-grammar-error/ | docs/api/objects/Group.html | @@ -13,7 +13,7 @@
<h1>[name]</h1>
<div class="desc">
- This is almost identical to an [page:Object3D Object3D]. It's purpose is to make working
+ This is almost identical to an [page:Object3D Object3D]. Its purpose is to make working
with groups of objects syntactically clearer.
</div>
| false |
Other | mrdoob | three.js | 6161ab5733c23e7a7d77c97d093d6bbfa31cdc53.json | Fix clear color bug | src/renderers/webgl/WebGLState.js | @@ -13,7 +13,7 @@ function WebGLState( gl, extensions, paramThreeToGL ) {
var color = new Vector4();
var currentColorMask = null;
- var currentColorClear = new Vector4();
+ var currentColorClear = new Vector4( 0, 0, 0, 0 );
return {
@@ -58,7 +58,7 @@ function WebGLState( gl, extensions, paramThreeToGL ... | false |
Other | mrdoob | three.js | 06d8dc87199a2ac6c74e2ea6ed7703cf2fcdcb1b.json | remove self written clone non recursive | examples/js/loaders/GLTF2Loader.js | @@ -2653,10 +2653,7 @@ THREE.GLTF2Loader = ( function () {
}
//do not clone children as they will be replaced anyway
- var children = group.children
- group.children=[];
- var clonedgroup = group.clone();
- group.children=children;
+ var clonedgroup = group.clone( false )... | false |
Other | mrdoob | three.js | 228257762a865c00a2463de1275d1dba8099b4f6.json | Add tracks length check for MMDHelper | examples/js/loaders/MMDLoader.js | @@ -2304,7 +2304,8 @@ THREE.MMDHelper.prototype = {
// the name of them begins with "_".
mesh.mixer.addEventListener( 'loop', function ( e ) {
- if ( e.action._clip.tracks[ 0 ].name.indexOf( '.bones' ) !== 0 ) return;
+ if ( e.action._clip.tracks.length > 0 &&
+ e.action._clip.tracks[ 0 ].... | false |
Other | mrdoob | three.js | dafc784003c43e4c4e76573da2b61b8981828db8.json | Fix markup typos in WebGLRenderTarget doc | docs/api/renderers/WebGLRenderTarget.html | @@ -1,134 +1,134 @@
-<!DOCTYPE html>
-<html lang="en">
- <head>
+<!DOCTYPE html>
+<html lang="en">
+ <head>
<meta charset="utf-8" />
- <base href="../../" />
- <script src="list.js"></script>
- <script src="page.js"></script>
- <link type="text/css" rel="stylesheet" href="page.css" />
- </head>
- <body>
- <... | false |
Other | mrdoob | three.js | 3d6694b1e90bdb4eaea0cf7d53601dff2e482888.json | Remove imported constant FlatShading | src/renderers/WebGLRenderer.js | @@ -1,4 +1,4 @@
-import { REVISION, MaxEquation, MinEquation, RGB_ETC1_Format, RGBA_PVRTC_2BPPV1_Format, RGBA_PVRTC_4BPPV1_Format, RGB_PVRTC_2BPPV1_Format, RGB_PVRTC_4BPPV1_Format, RGBA_S3TC_DXT5_Format, RGBA_S3TC_DXT3_Format, RGBA_S3TC_DXT1_Format, RGB_S3TC_DXT1_Format, SrcAlphaSaturateFactor, OneMinusDstColorFactor, ... | false |
Other | mrdoob | three.js | ab8a00dcc6b191136b73ca838f8ee82e46627fb9.json | Remove preferred shading option | docs/examples/loaders/ColladaLoader.html | @@ -86,15 +86,6 @@ <h3>[method:Object parse]( [page:Document doc], [page:Function callBack], [page:
Parse an <em>XML Document</em> and return an [page:Object object] that contain loaded parts: .[page:Scene scene], .[page:Array morphs], .[page:Array skins], .[page:Array animations], .[page:Object dae]
</div>
- ... | true |
Other | mrdoob | three.js | ab8a00dcc6b191136b73ca838f8ee82e46627fb9.json | Remove preferred shading option | examples/js/loaders/ColladaLoader.js | @@ -31,7 +31,6 @@ THREE.ColladaLoader = function () {
var skins;
var flip_uv = true;
- var preferredShading = THREE.SmoothShading;
var options = {
// Force Geometry to always be centered at the local origin of the
@@ -213,12 +212,6 @@ THREE.ColladaLoader = function () {
}
- function setPreferredShadi... | true |
Other | mrdoob | three.js | fd6fe6ef1d2e307d837d8e876384a4f64e6e1f14.json | Update GLTF2Loader docs. | docs/examples/loaders/GLTF2Loader.html | @@ -14,13 +14,12 @@ <h1>[name]</h1>
<div class="desc">
A loader for *glTF* 2.0 resources.
<br /><br />
- <a href="https://www.khronos.org/gltf">glTF</a> (GL Transmission Format) is an open format
- specification for efficient delivery and loading of 3D content. Assets may be provided either
- in JSON (.gltf... | false |
Other | mrdoob | three.js | 0f93f98b350cfa4e7e1db9faad92d7ba37311515.json | apply mrdoob style on PRWM example | examples/webgl_loader_prwm.html | @@ -95,7 +95,8 @@
function init() {
- document.getElementById('endianness').innerHTML = THREE.PRWMLoader.isBigEndianPlatform() ? 'big-endian' : 'little-endian';
+
+ document.getElementById( 'endianness' ).innerHTML = THREE.PRWMLoader.isBigEndianPlatform() ? 'big-endian' : 'little-endian';
container =... | false |
Other | mrdoob | three.js | cace41463410b9e97f6900731d341206f9b28466.json | Add lights to duck example for good measure. | examples/js/loaders/GLTF2Loader.js | @@ -310,8 +310,7 @@ THREE.GLTF2Loader = ( function () {
var light = lights[ lightId ];
var lightNode;
- var lightParams = light[ light.type ];
- var color = new THREE.Color().fromArray( lightParams.color );
+ var color = new THREE.Color().fromArray( light.color );
switch ( light.type ) {
@@ -337... | true |
Other | mrdoob | three.js | cace41463410b9e97f6900731d341206f9b28466.json | Add lights to duck example for good measure. | examples/models/gltf/Duck/glTF-MaterialsCommon/Duck.gltf | @@ -141,11 +141,47 @@
"type" : "perspective"
}
],
+ "extensions" : {
+ "KHR_lights" : {
+ "lights" : [
+ {
+ "color" : [
+ 1.0,
+ 1.0,
+ 1.0
+ ],
... | true |
Other | mrdoob | three.js | cace41463410b9e97f6900731d341206f9b28466.json | Add lights to duck example for good measure. | examples/webgl_loader_gltf2.html | @@ -437,8 +437,8 @@
addLights:true,
addGround:true,
shadows:true,
- // TODO: 'glTF-MaterialsCommon', 'glTF-techniqueWebGL'
- extensions: ['glTF', 'glTF-Embedded', 'glTF-pbrSpecularGlossiness', 'glTF-Binary']
+ // TODO: 'glTF-techniqueWebGL'
+ extensions: ['glTF', 'glTF-Embedded', 'glTF... | true |
Other | mrdoob | three.js | 3abec128f1177b1515ecc13fd605a352f8bdbbf7.json | Accept primitive.indices=0 in GLTFLoader | examples/js/loaders/GLTF2Loader.js | @@ -1632,7 +1632,7 @@ THREE.GLTF2Loader = ( function () {
}
- if ( primitive.indices ) {
+ if ( primitive.indices !== undefined ) {
geometry.setIndex( dependencies.accessors[ primitive.indices ] );
@@ -1682,7 +1682,7 @@ THREE.GLTF2Loader = ( function () {
var meshNode;
- ... | true |
Other | mrdoob | three.js | 3abec128f1177b1515ecc13fd605a352f8bdbbf7.json | Accept primitive.indices=0 in GLTFLoader | examples/js/loaders/GLTFLoader.js | @@ -1644,7 +1644,7 @@ THREE.GLTFLoader = ( function () {
}
- if ( primitive.indices ) {
+ if ( primitive.indices !== undefined ) {
geometry.setIndex( dependencies.accessors[ primitive.indices ] );
@@ -1694,7 +1694,7 @@ THREE.GLTFLoader = ( function () {
var meshNode;
- i... | true |
Other | mrdoob | three.js | 42e26f906d1f25a701a345fd24bf9b209446fac4.json | Remove material.skinning from WebGLShadowMap | src/renderers/webgl/WebGLShadowMap.js | @@ -71,7 +71,6 @@ function WebGLShadowMap( _renderer, _lights, _objects, capabilities ) {
var depthMaterial = depthMaterialTemplate.clone();
depthMaterial.morphTargets = useMorphing;
- depthMaterial.skinning = useSkinning;
_depthMaterials[ i ] = depthMaterial;
@@ -83,7 +82,6 @@ function WebGLShadowMap( ... | false |
Other | mrdoob | three.js | 3bc8d4f997cb82076a4febf8ac83ebca390d3832.json | add draw range for instanced geometry | src/renderers/webgl/WebGLBufferRenderer.js | @@ -23,7 +23,7 @@ function WebGLBufferRenderer( gl, extensions, infoRender ) {
}
- function renderInstances( geometry ) {
+ function renderInstances( geometry, start, count ) {
var extension = extensions.get( 'ANGLE_instanced_arrays' );
@@ -36,8 +36,6 @@ function WebGLBufferRenderer( gl, extensions, infoRe... | false |
Other | mrdoob | three.js | 49eeb97c60a783377be842e2e2a1132a124f42e6.json | fix ios9 TypedArray.subarray(from, undefined) bug | src/animation/AnimationUtils.js | @@ -11,7 +11,9 @@ var AnimationUtils = {
if ( AnimationUtils.isTypedArray( array ) ) {
- return new array.constructor( array.subarray( from, to ) );
+ // in ios9 array.subarray(from, undefined) will return empty array
+ // but array.subarray(from) or array.subarray(from, len) is correct
+ return new arra... | false |
Other | mrdoob | three.js | 8349b07b5d3d1ebb55c7ee01ff27544604facd2e.json | Remove MultiMaterial from WebGLDeferredRenderer | examples/js/renderers/WebGLDeferredRenderer.js | @@ -67,8 +67,7 @@ THREE.WebGLDeferredRenderer = function ( parameters ) {
var _lightPrePass = false;
var _cacheKeepAlive = false;
- var _invisibleMaterial = new THREE.ShaderMaterial( { visible: false } );
-
+ var _tmpMaterial = new THREE.ShaderMaterial( { visible: false } );
var _tmpVector3 = new THREE.Vector3(... | false |
Other | mrdoob | three.js | c37c43ebb544044c04ca6a9bfab0984b8283efb5.json | Remove xMove function, tidy shapes array size | examples/webgl_geometry_text_shapes.html | @@ -65,12 +65,6 @@
side: THREE.DoubleSide
} );
- var xMove = function( shape, shapeMid ) {
-
- return shape.translate( shapeMid, 0, 0 );
-
- }
-
var message = " Three.js\nSimple text.";
var shapes = font.generateShapes( message, 100, 2 );
@@ -81,7 +75,7 @@
xMid = - 0.... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.