language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | mrdoob | three.js | ba79e7ce7745f5d6e7cbda305d1d7e6302cd8f54.json | add documentation for webglrenderer.compile | docs/api/renderers/WebGLRenderer.html | @@ -305,6 +305,9 @@ <h3>[method:null clearTarget]([page:WebGLRenderTarget renderTarget], [page:boole
This method clears a rendertarget. To do this, it activates the rendertarget.
</div>
+ <h3>[method:null compile]( [page:Scene scene], [page:Camera camera] )</h3>
+ <div>Compiles all materials in the scene with... | false |
Other | mrdoob | three.js | 24f2f9e249174b39d77accf0bfa237ab7285e334.json | Update binary implementation for glTF 2.0. | examples/js/loaders/GLTF2Loader.js | @@ -55,7 +55,7 @@ THREE.GLTF2Loader = ( function () {
var magic = convertUint8ArrayToString( new Uint8Array( data, 0, 4 ) );
- if ( magic === BINARY_EXTENSION_HEADER_DEFAULTS.magic ) {
+ if ( magic === BINARY_EXTENSION_HEADER_MAGIC ) {
extensions[ EXTENSIONS.KHR_BINARY_GLTF ] = new GLTFBinaryExtensio... | true |
Other | mrdoob | three.js | 24f2f9e249174b39d77accf0bfa237ab7285e334.json | Update binary implementation for glTF 2.0. | examples/webgl_loader_gltf.html | @@ -387,9 +387,8 @@
cameraPos: new THREE.Vector3(2, 1, 3),
objectRotation: new THREE.Euler(0, Math.PI, 0),
addLights:true,
- extensions: ["glTF"]
+ extensions: ["glTF", "glTF-Binary"]
},
-
{
name : "Duck", url : "./models/gltf/duck/%s/duck.gltf",
cameraPos: new THREE.Vect... | true |
Other | mrdoob | three.js | 29866387030346a4c775fb9fb46a4dec10a2b72b.json | add split to long animation function | examples/js/loaders/XfileLoader.js | @@ -2,7 +2,7 @@
/**
* @author Jey-en https://github.com/adrs2002
*
- * this loader repo → https://github.com/adrs2002/threeXfileLoader
+ * this loader repo -> https://github.com/adrs2002/threeXfileLoader
*
* This loader is load model (and animation) from .X file format. (for old DirectX).
* ! this versio... | true |
Other | mrdoob | three.js | 29866387030346a4c775fb9fb46a4dec10a2b72b.json | add split to long animation function | examples/webgl_loader_xfile.html | @@ -14,7 +14,7 @@
margin: 0px;
overflow: hidden;
}
-
+
#info {
color: #fff;
position: absolute;
@@ -38,10 +38,10 @@
<body>
<div id="canvase3d"></div>
- <!-- 描画領域のためのdiv要素を配置 -->
- <div id="info">
- <a href="http://threejs.org" tar... | true |
Other | mrdoob | three.js | 28c5f12f246585b9975c0aec5619cd96672b243d.json | Add sourcemaps to NPM 'dev' script. | package.json | @@ -31,7 +31,7 @@
"build-test": "rollup -c test/rollup.unit.config.js",
"build-uglify": "rollup -c && uglifyjs build/three.js -cm --preamble \"// threejs.org/license\" > build/three.min.js",
"build-closure": "rollup -c && java -jar utils/build/compiler/closure-compiler-v20160713.jar --warning_level=VERBO... | false |
Other | mrdoob | three.js | 66d4ecc0ae0e6d99522fb2c13e09a3e031a06480.json | mirror rtt only | examples/js/MirrorRTT.js | @@ -0,0 +1,9 @@
+THREE.MirrorRTT = function ( width, height, options ) {
+
+ THREE.Mirror.call( this, width, height, options );
+
+ this.geometry.setDrawRange( 0, 0 ); // avoid rendering geometry
+
+};
+
+THREE.MirrorRTT.prototype = Object.create( THREE.Mirror.prototype ); | true |
Other | mrdoob | three.js | 66d4ecc0ae0e6d99522fb2c13e09a3e031a06480.json | mirror rtt only | examples/webgl_mirror_nodes.html | @@ -37,6 +37,7 @@
<script src="../build/three.js"></script>
<script src="js/libs/dat.gui.min.js"></script>
<script src="js/Mirror.js"></script>
+ <script src="js/MirrorRTT.js"></script>
<script src="js/controls/OrbitControls.js"></script>
<!-- NodeLibrary -->
@@ -152,8 +153,7 @@
var planeGeo = ne... | true |
Other | mrdoob | three.js | ef59e58d05ed00082b0699882b8788bef33c6937.json | simplify electron startpoint | editor/package.json | @@ -1,5 +0,0 @@
-{
- "name" : "your-app",
- "version" : "0.1.0",
- "main" : "main.js"
-}
\ No newline at end of file | true |
Other | mrdoob | three.js | ef59e58d05ed00082b0699882b8788bef33c6937.json | simplify electron startpoint | package.json | @@ -34,7 +34,7 @@
"dev": "rollup -c -w",
"lint": "eslint src",
"test": "rollup -c test/rollup.unit.config.js -w",
- "editor-start": "electron ./editor/"
+ "editor-start": "electron ./editor/main.js"
},
"keywords": [
"three", | true |
Other | mrdoob | three.js | 08d40df55b87e14b1a5b7104cb715eab1b4d9f77.json | Check map.format for transparency in GLTF2Loader | examples/js/loaders/GLTF2Loader.js | @@ -1219,9 +1219,15 @@ THREE.GLTF2Loader = ( function () {
}
- // set transparent true if map baseColorTexture is specified because
- // A channel values of it can be less than 1.0.
- if ( materialParams.opacity < 1.0 || materialParams.map !== undefined ) materialParams.transparent = true;... | false |
Other | mrdoob | three.js | 0727fc42ff394dfad54c4fbc228deafeb967ece0.json | Remove .getHex() from GLTF2Loader | examples/js/loaders/GLTF2Loader.js | @@ -1212,7 +1212,7 @@ THREE.GLTF2Loader = ( function () {
} else {
- materialParams.color.setRGB( 1.0, 1.0, 1.0 ).getHex();
+ materialParams.color.setRGB( 1.0, 1.0, 1.0 );
materialParams.opacity = 1.0;
} | false |
Other | mrdoob | three.js | 294639a8182a4b92ea410b0d094500b2eb0d9c88.json | fix groups in extrudebuffergeometry | src/geometries/ExtrudeGeometry.js | @@ -641,11 +641,9 @@ ExtrudeBufferGeometry.prototype.addShape = function ( shape, options ) {
}
- if (options.extrudeMaterial !== undefined){
-
- scope.addGroup( start, verticesArray.length/3 -start, options.extrudeMaterial !== undefined ? options.extrudeMaterial : 1);
-
- }
+
+ scope.addGroup( star... | false |
Other | mrdoob | three.js | 1a2a9a335b52a395e2a19f7fdc286f3df1452ef6.json | Add BoomBox model into gltf loader example | examples/webgl_loader_gltf.html | @@ -66,7 +66,8 @@
<a href="https://github.com/KhronosGroup/glTF" target="_blank">glTF</a> loader
<br>
monster by <a href="http://www.3drt.com/downloads.htm" target="_blank">3drt</a> - COLLADA duck by Sony -
- Cesium models by <a href="http://cesiumjs.org/" target="_blank">Cesium</a>
+ Cesium models by <a hre... | false |
Other | mrdoob | three.js | d25ba360e20895aaac36d5ce06ed3f0a7c8a2d7f.json | Remove unnecessary comment | examples/js/loaders/GLTFLoader.js | @@ -1705,9 +1705,6 @@ THREE.GLTFLoader = ( function () {
// aspectRatio = xfov / yfov
var xfov = yfov * aspectRatio;
- // According to COLLADA spec...
- // aspect_ratio = xfov / yfov
- // yfov = ( yfov === undefined && xfov ) ? xfov / aspect_ratio : yfov;
var _camera = new THREE.PerspectiveCam... | false |
Other | mrdoob | three.js | e0bf8b370e7c6e5644cb6be58ddf5310a1b1fc84.json | Use animation.name for AnimationClip | examples/js/loaders/GLTFLoader.js | @@ -1822,7 +1822,9 @@ THREE.GLTFLoader = ( function () {
}
- return new THREE.AnimationClip( "animation_" + animationId, undefined, tracks );
+ var name = animation.name !== undefined ? animation.name : "animation_" + animationId;
+
+ return new THREE.AnimationClip( name, undefined, tracks );
} ... | false |
Other | mrdoob | three.js | e9d108bec519fd48e703c068b563dabb7eb772d8.json | Accept undefined skin.bindShapeMatrix | examples/js/loaders/GLTFLoader.js | @@ -1744,8 +1744,12 @@ THREE.GLTFLoader = ( function () {
return _each( json.skins, function ( skin ) {
+ var bindShapeMatrix = new THREE.Matrix4();
+
+ if ( skin.bindShapeMatrix !== undefined ) bindShapeMatrix.fromArray( skin.bindShapeMatrix );
+
var _skin = {
- bindShapeMatrix: new THREE.Matrix... | false |
Other | mrdoob | three.js | f4401306b089a0a8f5100761e41de5b7ff8dc0af.json | Accept undefined animation.samplers.interpolation | examples/js/loaders/GLTFLoader.js | @@ -1800,6 +1800,7 @@ THREE.GLTFLoader = ( function () {
: THREE.VectorKeyframeTrack;
var targetName = node.name ? node.name : node.uuid;
+ var interpolation = sampler.interpolation !== undefined ? INTERPOLATION[ sampler.interpolation ] : THREE.InterpolateLinear;
// KeyframeTrack.opti... | false |
Other | mrdoob | three.js | 6c96a31043f2e41884c4471abfa07698013a0861.json | Accept undefined scene.nodes | examples/js/loaders/GLTFLoader.js | @@ -2118,7 +2118,7 @@ THREE.GLTFLoader = ( function () {
if ( scene.extras ) _scene.userData = scene.extras;
- var nodes = scene.nodes;
+ var nodes = scene.nodes || [];
for ( var i = 0, l = nodes.length; i < l; i ++ ) {
| false |
Other | mrdoob | three.js | 69818a2b676d67150e2ee2fdcd6224836c80a148.json | Accept undefined mesh.primitives (for 1.0) | examples/js/loaders/GLTFLoader.js | @@ -1551,7 +1551,7 @@ THREE.GLTFLoader = ( function () {
if ( mesh.extras ) group.userData = mesh.extras;
- var primitives = mesh.primitives;
+ var primitives = mesh.primitives || [];
for ( var name in primitives ) {
| false |
Other | mrdoob | three.js | 5bef7d6947ba89e3f2f56c083521cd2b74e3224e.json | Accept undefined bufferView.byteLength (for 1.0) | examples/js/loaders/GLTFLoader.js | @@ -976,7 +976,9 @@ THREE.GLTFLoader = ( function () {
var arraybuffer = dependencies.buffers[ bufferView.buffer ];
- return arraybuffer.slice( bufferView.byteOffset, bufferView.byteOffset + bufferView.byteLength );
+ var byteLength = bufferView.byteLength !== undefined ? bufferView.byteLength : 0;
+
+ ... | false |
Other | mrdoob | three.js | c4464b92b87030a501260f9577cb1ba2ec881dc2.json | Rename Extra Helpers to Helpers | docs/list.js | @@ -174,7 +174,7 @@ var list = {
[ "WireframeGeometry", "api/geometries/WireframeGeometry" ]
],
- "Extras / Helpers": [
+ "Helpers": [
[ "ArrowHelper", "api/helpers/ArrowHelper" ],
[ "AxisHelper", "api/helpers/AxisHelper" ],
[ "BoxHelper", "api/helpers/BoxHelper" ], | false |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/ArrowHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/AxisHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/BoxHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/CameraHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/DirectionalLightHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/FaceNormalsHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" />
| true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/GridHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" />
| true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/HemisphereLightHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/PointLightHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/PolarGridHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/RectAreaLightHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/SkeletonHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/SpotLightHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" />
| true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/api/helpers/VertexNormalsHelper.html | @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
- <base href="../../../" />
+ <base href="../../" />
<script src="list.js"></script>
<script src="page.js"></script>
<link type="text/css" rel="stylesheet" href="page.css" /> | true |
Other | mrdoob | three.js | 5c483dc67ac7fc314008bca34f5d7a341f1c3f2c.json | Fix Helpers docs paths | docs/list.js | @@ -126,23 +126,6 @@ var list = {
[ "SplineCurve", "api/extras/curves/SplineCurve" ]
],
- "Extras / Helpers": [
- [ "ArrowHelper", "api/extras/helpers/ArrowHelper" ],
- [ "AxisHelper", "api/extras/helpers/AxisHelper" ],
- [ "BoxHelper", "api/extras/helpers/BoxHelper" ],
- [ "CameraHelper", "api/extras... | true |
Other | mrdoob | three.js | adb250a6bd186d328673b5862e9a706d1917dbb9.json | Fix CameraHelper docs typo | docs/api/extras/helpers/CameraHelper.html | @@ -24,8 +24,7 @@ <h2>Example</h2>
<code>
var camera = new THREE.PerspectiveCamera( 75, window.innerWidth / window.innerHeight, 0.1, 1000 );
-
-var helper = new THREE.CameraHelper( cameraPerspective );
+var helper = new THREE.CameraHelper( camera );
scene.add( helper );
</code>
| false |
Other | mrdoob | three.js | cfacb47f9ab14e17d926a2cea888df4ab0f69a0e.json | Support Texture format in GLTFLoader | examples/js/loaders/GLTFLoader.js | @@ -1072,6 +1072,15 @@ THREE.GLTFLoader = ( function () {
if ( texture.name !== undefined ) _texture.name = texture.name;
+ _texture.format = texture.format !== undefined ? WEBGL_TEXTURE_FORMATS[ texture.format ] : THREE.RGBAFormat;
+
+ if ( texture.internalFormat !== undefined && _texture.forma... | false |
Other | mrdoob | three.js | 9dbb37e2342ce9523d1559c00244905745352f14.json | Support texture name in GLTFLoader | examples/js/loaders/GLTFLoader.js | @@ -1070,6 +1070,8 @@ THREE.GLTFLoader = ( function () {
_texture.flipY = false;
+ if ( texture.name !== undefined ) _texture.name = texture.name;
+
if ( texture.sampler ) {
var sampler = json.samplers[ texture.sampler ]; | false |
Other | mrdoob | three.js | 67d67bfcc3ce96a80d18da4f90ad7e8792402ac8.json | Avoid unneeded geometry allocations. | src/helpers/ArrowHelper.js | @@ -24,11 +24,7 @@ import { Mesh } from '../objects/Mesh';
import { Line } from '../objects/Line';
import { Vector3 } from '../math/Vector3';
-var lineGeometry = new BufferGeometry();
-lineGeometry.addAttribute( 'position', new Float32BufferAttribute( [ 0, 0, 0, 0, 1, 0 ], 3 ) );
-
-var coneGeometry = new CylinderB... | true |
Other | mrdoob | three.js | 67d67bfcc3ce96a80d18da4f90ad7e8792402ac8.json | Avoid unneeded geometry allocations. | src/renderers/WebGLRenderer.js | @@ -297,25 +297,8 @@ function WebGLRenderer( parameters ) {
//
- var backgroundCamera = new OrthographicCamera( - 1, 1, 1, - 1, 0, 1 );
- var backgroundCamera2 = new PerspectiveCamera();
- var backgroundPlaneMesh = new Mesh(
- new PlaneBufferGeometry( 2, 2 ),
- new MeshBasicMaterial( { depthTest: false, depthWr... | true |
Other | mrdoob | three.js | b385a0dd095025a5dc7daa14568f626225c1d106.json | Document the AnimationUtils methods correctly | docs/api/animation/AnimationUtils.html | @@ -18,12 +18,12 @@ <h2>Methods</h2>
<h3>[method:Array arraySlice]( array, from, to )</h3>
<div>
- Convert an array to a specific type.
+ This is the same as Array.prototype.slice, but also works on typed arrays.
</div>
<h3>[method:Array convertArray]( array, type, forceClone )</h3>
... | false |
Other | mrdoob | three.js | c21d2e9839697c2ec532256d58acc9ddd5d8745b.json | fix an MTK device bug
In some Chinese MTK device, gl.getProgramParameter( program, gl.ACTIVE_UNIFORMS ) will return null but not 0, which will thow an Error.
this Commit can fix it. | src/renderers/webgl/WebGLUniforms.js | @@ -467,7 +467,7 @@ function WebGLUniforms( gl, program, renderer ) {
var n = gl.getProgramParameter( program, gl.ACTIVE_UNIFORMS );
- for ( var i = 0; i !== n; ++ i ) {
+ for ( var i = 0; i < n; ++ i ) {
var info = gl.getActiveUniform( program, i ),
path = info.name, | false |
Other | mrdoob | three.js | f1db9e5f4d701cacf58dafc12595014f65407c43.json | Add missing semicolon in PaintViveController | examples/js/vr/PaintViveController.js | @@ -52,7 +52,7 @@ THREE.PaintViveController = function ( id ) {
mesh.position.set( 0, 0.005, 0.0495 );
mesh.rotation.x = - 1.45;
mesh.scale.setScalar( 0.02 );
- this.add( mesh )
+ this.add( mesh );
var geometry = new THREE.IcosahedronGeometry( 0.1, 2 );
var material = new THREE.MeshBasicMaterial(); | false |
Other | mrdoob | three.js | a4ac61806c4cfd96665443ba98fc336f0e836165.json | Remove unnecessary comma in ShadowMapViewer | examples/js/utils/ShadowMapViewer.js | @@ -39,7 +39,7 @@ THREE.ShadowMapViewer = function ( light ) {
x: 10,
y: 10,
width: 256,
- height: 256,
+ height: 256
};
var camera = new THREE.OrthographicCamera( window.innerWidth / - 2, window.innerWidth / 2, window.innerHeight / 2, window.innerHeight / - 2, 1, 10 ); | false |
Other | mrdoob | three.js | 31397f8bb8a2a614e88fdc589af30b5fadc9a43e.json | Remove unnecessary comma in UnrealBloomPass | examples/js/postprocessing/UnrealBloomPass.js | @@ -231,7 +231,7 @@ THREE.UnrealBloomPass.prototype = Object.assign( Object.create( THREE.Pass.proto
uniforms: {
"colorTexture": { value: null },
"texSize": { value: new THREE.Vector2( 0.5, 0.5 ) },
- "direction": { value: new THREE.Vector2( 0.5, 0.5 ) },
+ "direction": { value: new THRE... | false |
Other | mrdoob | three.js | 683502300442112213a6d857cc83fc74cfaeea4e.json | Add missing semicolon in Math3Node | examples/js/nodes/math/Math3Node.js | @@ -44,7 +44,7 @@ THREE.Math3Node.prototype.generate = function( builder, output ) {
var a, b, c,
al = builder.getFormatLength( this.a.getType( builder ) ),
bl = builder.getFormatLength( this.b.getType( builder ) ),
- cl = builder.getFormatLength( this.c.getType( builder ) )
+ cl = builder.getFormatLength( th... | false |
Other | mrdoob | three.js | d606f272dcc1951e0a4becc55253dc9ce2767b48.json | Remove unnecessary comma in StandardNode | examples/js/nodes/materials/StandardNode.js | @@ -165,7 +165,7 @@ THREE.StandardNode.prototype.build = function( builder ) {
THREE.ShaderChunk[ "lights_pars" ],
THREE.ShaderChunk[ "lights_physical_pars_fragment" ],
THREE.ShaderChunk[ "shadowmap_pars_fragment" ],
- THREE.ShaderChunk[ "logdepthbuf_pars_fragment" ],
+ THREE.ShaderChunk[ "logdepthbuf_p... | false |
Other | mrdoob | three.js | 5918295ba320ba435e37a46f3caa92da73fa8712.json | Add missing semicolons in NodeMaterial | examples/js/nodes/NodeMaterial.js | @@ -41,7 +41,7 @@ THREE.NodeMaterial.addShortcuts = function( proto, prop, list ) {
}
};
- };
+ }
return ( function() {
@@ -335,7 +335,7 @@ THREE.NodeMaterial.prototype.getVar = function( uuid, type, ns ) {
var index = this.vars.length,
name = ns ? ns : 'nVv' + index;
- data = { name : name, ty... | false |
Other | mrdoob | three.js | 92340ca5ea24565f9a4f4a9ef0ab91c2c1abcfbf.json | Remove unnecessary comma in NodeBuilder | examples/js/nodes/NodeBuilder.js | @@ -67,7 +67,7 @@ THREE.NodeBuilder.prototype = {
addSlot : function( name ) {
this.slots.push( {
- name : name || '',
+ name : name || ''
} );
return this.update(); | false |
Other | mrdoob | three.js | 84fa8969e69cc95f24c8376674eed0b672615434.json | Add missing semicolon in SimplifyModifier | examples/js/modifiers/SimplifyModifier.js | @@ -134,7 +134,7 @@ THREE.SimplifyModifier = function() {
}
// we average the cost of collapsing at this vertex
- v.collapseCost = v.totalCost / v.costCount
+ v.collapseCost = v.totalCost / v.costCount;
// v.collapseCost = v.minCost;
}
@@ -349,7 +349,7 @@ THREE.SimplifyModifier = function() {
Verte... | false |
Other | mrdoob | three.js | abf57981b7af55d82b1d415d555b5ec68d543609.json | Add missing semicolon in PCDLoader | examples/js/loaders/PCDLoader.js | @@ -100,7 +100,7 @@ Object.assign( THREE.PCDLoader.prototype, THREE.EventDispatcher.prototype, {
}
- PCDheader.offset = {}
+ PCDheader.offset = {};
var sizeSum = 0;
for ( var i = 0; i < PCDheader.fields.length; i ++ ) {
| false |
Other | mrdoob | three.js | 892a92d47eb18ccfc8b0dd69fd09f6966fd55a20.json | Remove unnecessary comma in MTLLoader | examples/js/loaders/MTLLoader.js | @@ -473,7 +473,7 @@ THREE.MTLLoader.MaterialCreator.prototype = {
var texParams = {
scale: new THREE.Vector2( 1, 1 ),
- offset: new THREE.Vector2( 0, 0 ),
+ offset: new THREE.Vector2( 0, 0 )
};
| false |
Other | mrdoob | three.js | bfa24378d6418af7c49e519383788f9194c73875.json | Add missing semicolon in MD2Loader | examples/js/loaders/MD2Loader.js | @@ -308,4 +308,4 @@ THREE.MD2Loader.prototype = {
} )()
-}
+}; | false |
Other | mrdoob | three.js | 6f5d75c3c5899a209c82dbeecde57bd0ece4fd86.json | Add missing semicolon in HDRCubeTextureLoader | examples/js/loaders/HDRCubeTextureLoader.js | @@ -9,7 +9,7 @@ THREE.HDRCubeTextureLoader = function (manager) {
this.hdrLoader = new THREE.RGBELoader();
if( THREE.Encodings === undefined ) throw new Error( "HDRCubeMapLoader requires THREE.Encodings" );
-}
+};
THREE.HDRCubeTextureLoader.prototype.load = function(type, urls, onLoad, onProgress, onError) {... | false |
Other | mrdoob | three.js | 66b22edf2c8f75d55689ec9efbb24f6924a9284c.json | Fix implicit variable declaration in FBXLoader | examples/js/loaders/FBXLoader.js | @@ -64,7 +64,7 @@
THREE.FBXLoader.prototype.isFbxFormatASCII = function ( body ) {
- CORRECT = [ 'K', 'a', 'y', 'd', 'a', 'r', 'a', '\\', 'F', 'B', 'X', '\\', 'B', 'i', 'n', 'a', 'r', 'y', '\\', '\\' ];
+ var CORRECT = [ 'K', 'a', 'y', 'd', 'a', 'r', 'a', '\\', 'F', 'B', 'X', '\\', 'B', 'i', 'n', 'a', 'r', 'y',... | false |
Other | mrdoob | three.js | 0e55a079cec600a17eb67c669c683d13daa9d79d.json | Remove unnecessary comma in BVHLoader | examples/js/loaders/BVHLoader.js | @@ -116,7 +116,7 @@ THREE.BVHLoader.prototype = {
var keyframe = {
time: frameTime,
position: { x: 0, y: 0, z: 0 },
- rotation: new THREE.Quaternion(),
+ rotation: new THREE.Quaternion()
};
bone.frames.push( keyframe ); | false |
Other | mrdoob | three.js | 271ada4bb8ec049a678b6c934bffc5604463552e.json | Fix implicit declaration in 3MFLoader | examples/js/loaders/3MFLoader.js | @@ -235,7 +235,7 @@ THREE.ThreeMFLoader.prototype = {
for ( var i = 0; i < triangleNodes.length; i++ ) {
- triangleNode = triangleNodes[ i ];
+ var triangleNode = triangleNodes[ i ];
var v1 = triangleNode.getAttribute( 'v1' );
var v2 = triangleNode.getAttribute( 'v2' );
var v3 = triangleNod... | false |
Other | mrdoob | three.js | 938f881ceb956684ee7d9288f446b96c012bafc5.json | Add missing semicolons in SEA3DLZMA | examples/js/loaders/sea3d/SEA3DLZMA.js | @@ -577,7 +577,7 @@ SEA3D.File.LZMAUncompress = function( data ) {
return this.data[ this.position ++ ];
}
- }
+ };
var outStream = {
data: [],
@@ -587,12 +587,12 @@ SEA3D.File.LZMAUncompress = function( data ) {
this.data[ this.position ++ ] = value;
}
- }
+ };
LZMA.decompressFile( inStrea... | false |
Other | mrdoob | three.js | 6160d83b220550730a5310a3b96fab43aa60434e.json | Add missing semicolons in SEA3DLoader | examples/js/loaders/sea3d/SEA3DLoader.js | @@ -346,39 +346,39 @@ THREE.SEA3D.ScriptDomain = function( domain, root ) {
return domain.id;
- }
+ };
this.isRoot = function() {
return root;
- }
+ };
this.addEvent = function( type, listener ) {
events.addEventListener( type, listener );
- }
+ };
this.hasEvent = function( type, listen... | false |
Other | mrdoob | three.js | 476491aba1d81f20cd583d9a7c998a6f8fb1eff3.json | Add missing semicolons in SEA3DLegacy | examples/js/loaders/sea3d/SEA3DLegacy.js | @@ -456,7 +456,7 @@ THREE.SEA3D.prototype.readSkeleton = function( sea ) {
for ( var i = 0; i < sea.joint.length; i ++ ) {
- var bone = sea.joint[ i ]
+ var bone = sea.joint[ i ];
// get world inverse matrix
| false |
Other | mrdoob | three.js | af33f2a77d94534a050525ee705837f8b7a091ec.json | Add missing semicolons in SEA3DDeflate | examples/js/loaders/sea3d/SEA3DDeflate.js | @@ -77,7 +77,7 @@ var zip_border = new Array( // Order of the bit length code lengths
var zip_HuftList = function() {
this.next = null;
this.list = null;
-}
+};
var zip_HuftNode = function() {
this.e = 0; // number of extra bits or operation
@@ -86,7 +86,7 @@ var zip_HuftNode = function() {
// ... | false |
Other | mrdoob | three.js | a2a0c8879d63abd2697d80a396d842f343875542.json | Remove unnecessary comma in TransformControls | examples/js/controls/TransformControls.js | @@ -444,7 +444,7 @@
var group = {
handles: this[ "handles" ],
- pickers: this[ "pickers" ],
+ pickers: this[ "pickers" ]
};
| false |
Other | mrdoob | three.js | 9fbfbf75edf80df1232c3da5a57751d15dce7abe.json | Add missing semicolon in FlyControls | examples/js/controls/FlyControls.js | @@ -270,7 +270,7 @@ THREE.FlyControls = function ( object, domElement ) {
window.removeEventListener( 'keydown', _keydown, false );
window.removeEventListener( 'keyup', _keyup, false );
- }
+ };
var _mousemove = bind( this, this.mousemove );
var _mousedown = bind( this, this.mousedown ); | false |
Other | mrdoob | three.js | 189969453917a350ff2e6af4eaf256642bb84e41.json | Add missing semicolon in FirstPersonControls | examples/js/controls/FirstPersonControls.js | @@ -269,7 +269,7 @@ THREE.FirstPersonControls = function ( object, domElement ) {
window.removeEventListener( 'keydown', _onKeyDown, false );
window.removeEventListener( 'keyup', _onKeyUp, false );
- }
+ };
var _onMouseMove = bind( this, this.onMouseMove );
var _onMouseDown = bind( this, this.onMouseDown ... | false |
Other | mrdoob | three.js | b9d8e2168c47b5b665d85e65b392eb2ac227bd0a.json | Add missing semicolon in EditorControls | examples/js/controls/EditorControls.js | @@ -13,9 +13,9 @@ THREE.EditorControls = function ( object, domElement ) {
this.enabled = true;
this.center = new THREE.Vector3();
- this.panSpeed = 0.001
- this.zoomSpeed = 0.001
- this.rotationSpeed = 0.005
+ this.panSpeed = 0.001;
+ this.zoomSpeed = 0.001;
+ this.rotationSpeed = 0.005;
// internals
| false |
Other | mrdoob | three.js | 3d7e3b644e0517f6804b7fd118985c5c62acdde7.json | Add missing semicolon in DragControls | examples/js/controls/DragControls.js | @@ -232,4 +232,4 @@ THREE.DragControls = function( _camera, _objects, _domElement ) {
}
-}
+}; | false |
Other | mrdoob | three.js | 338211e3e6749bb45d99eb3fd9228945d2001094.json | Fix Object3D tests. | test/unit/src/core/Object3D.js | @@ -12,8 +12,7 @@ QUnit.test( "rotateX" , function( assert ) {
var angleInRad = 1.562;
obj.rotateX(angleInRad);
- // should calculate the correct rotation on x
- checkIfFloatsAreEqual(obj.rotation.x, angleInRad, assert);
+ assert.numEqual( obj.rotation.x, angleInRad, "x is equal" );
});
QUnit.test( "rotateY" ... | false |
Other | mrdoob | three.js | d83b92ec2eeb107ef6eeb2f1c212f2376a3568ed.json | Fix light and math tests. | src/lights/RectAreaLight.js | @@ -43,6 +43,17 @@ RectAreaLight.prototype = Object.assign( Object.create( Light.prototype ), {
return this;
+ },
+
+ toJSON: function ( meta ) {
+
+ var data = Light.prototype.toJSON.call( this, meta );
+
+ data.object.width = this.width;
+ data.object.height = this.height;
+
+ return data;
+
}
} ); | true |
Other | mrdoob | three.js | d83b92ec2eeb107ef6eeb2f1c212f2376a3568ed.json | Fix light and math tests. | src/loaders/ObjectLoader.js | @@ -38,6 +38,7 @@ import { SpotLight } from '../lights/SpotLight';
import { PointLight } from '../lights/PointLight';
import { DirectionalLight } from '../lights/DirectionalLight';
import { AmbientLight } from '../lights/AmbientLight';
+import { RectAreaLight } from '../lights/RectAreaLight';
import { OrthographicC... | true |
Other | mrdoob | three.js | d83b92ec2eeb107ef6eeb2f1c212f2376a3568ed.json | Fix light and math tests. | test/unit/src/math/Triangle.js | @@ -96,11 +96,10 @@ QUnit.test( "normal" , function( assert ) {
QUnit.test( "plane" , function( assert ) {
var a = new THREE.Triangle();
- // artificial normal is created in this case.
- assert.ok( a.plane().distanceToPoint( a.a ) == 0, "Passed!" );
- assert.ok( a.plane().distanceToPoint( a.b ) == 0, "Passed!" );
... | true |
Other | mrdoob | three.js | d83b92ec2eeb107ef6eeb2f1c212f2376a3568ed.json | Fix light and math tests. | test/unit/src/math/Vector2.js | @@ -225,7 +225,7 @@ QUnit.test( "setLength" , function( assert ) {
a = new THREE.Vector2( 0, 0 );
assert.ok( a.length() == 0, "Passed!" );
a.setLength( y );
- assert.ok( a.length() == 0, "Passed!" );
+ assert.ok( isNaN( a.length() ), "Passed!" );
});
QUnit.test( "lerp/clone", function( assert ) { | true |
Other | mrdoob | three.js | d83b92ec2eeb107ef6eeb2f1c212f2376a3568ed.json | Fix light and math tests. | test/unit/src/math/Vector3.js | @@ -235,7 +235,7 @@ QUnit.test( "setLength" , function( assert ) {
a = new THREE.Vector3( 0, 0, 0 );
assert.ok( a.length() == 0, "Passed!" );
a.setLength( y );
- assert.ok( a.length() == 0, "Passed!" );
+ assert.ok( isNaN( a.length() ), "Passed!" );
});
| true |
Other | mrdoob | three.js | d83b92ec2eeb107ef6eeb2f1c212f2376a3568ed.json | Fix light and math tests. | test/unit/src/math/Vector4.js | @@ -132,9 +132,9 @@ QUnit.test( "multiply/divide", function( assert ) {
b.multiplyScalar( -2 );
assert.ok( b.x == 2*x, "Passed!" );
- assert.ok( b.y == 2*y, "Passed!" );
- assert.ok( b.z == 2*z, "Passed!" );
- assert.ok( b.w == 2*w, "Passed!" );
+ assert.ok( b.y == 2*y, "Passed!" );
+ assert.ok( b.z == 2*z, "P... | true |
Other | mrdoob | three.js | 551fba84383ece7b214583c92216585974976bdd.json | Add NPM command to watch and rebuild tests. | package.json | @@ -33,7 +33,7 @@
"build-closure": "rollup -c && java -jar utils/build/compiler/closure-compiler-v20160713.jar --warning_level=VERBOSE --jscomp_off=globalThis --jscomp_off=checkTypes --externs utils/build/externs.js --language_in=ECMASCRIPT5_STRICT --js build/three.js --js_output_file build/three.min.js",
"de... | false |
Other | mrdoob | three.js | 42d9d311ba7a1d354031b1a5abba4be037b9c6d0.json | call gltfShader.update in object.onBeforeRender | examples/js/loaders/GLTF2Loader.js | @@ -136,15 +136,6 @@ THREE.GLTF2Loader = ( function () {
update: function ( scene, camera ) {
- // update scene graph
-
- scene.updateMatrixWorld();
-
- // update camera matrices and frustum
-
- camera.updateMatrixWorld();
- camera.matrixWorldInverse.getInverse( camera.matrixWorld );
-
for (... | true |
Other | mrdoob | three.js | 42d9d311ba7a1d354031b1a5abba4be037b9c6d0.json | call gltfShader.update in object.onBeforeRender | examples/js/loaders/GLTFLoader.js | @@ -135,15 +135,6 @@ THREE.GLTFLoader = ( function () {
update: function ( scene, camera ) {
- // update scene graph
-
- scene.updateMatrixWorld();
-
- // update camera matrices and frustum
-
- camera.updateMatrixWorld();
- camera.matrixWorldInverse.getInverse( camera.matrixWorld );
-
for ( ... | true |
Other | mrdoob | three.js | 42d9d311ba7a1d354031b1a5abba4be037b9c6d0.json | call gltfShader.update in object.onBeforeRender | examples/webgl_loader_gltf.html | @@ -338,7 +338,6 @@
function animate() {
requestAnimationFrame( animate );
if (mixer) mixer.update(clock.getDelta());
- THREE.GLTF2Loader.Shaders.update(scene, camera);
if (cameraIndex == 0)
orbitControls.update();
render(); | true |
Other | mrdoob | three.js | 5cd8b0300cf6f6befdf2657994b622a2c9ed31ff.json | Add points threshold to bounding sphere radius
Resolves issues described in #7710, #9309, and #10763. (hopefully) | src/objects/Points.js | @@ -46,6 +46,7 @@ Points.prototype = Object.assign( Object.create( Object3D.prototype ), {
sphere.copy( geometry.boundingSphere );
sphere.applyMatrix4( matrixWorld );
+ sphere.radius += threshold;
if ( raycaster.ray.intersectsSphere( sphere ) === false ) return;
| false |
Other | mrdoob | three.js | ebbe091bc4814762ad7da5c7676070adea0a12ad.json | Accept texture.source/sampler=0 in GLTF2Loader | examples/js/loaders/GLTF2Loader.js | @@ -1063,7 +1063,7 @@ THREE.GLTF2Loader = ( function () {
return _each( json.textures, function ( texture ) {
- if ( texture.source ) {
+ if ( texture.source !== undefined ) {
return new Promise( function ( resolve ) {
@@ -1103,7 +1103,7 @@ THREE.GLTF2Loader = ( function () {
_texture.... | false |
Other | mrdoob | three.js | 3faad2bfaba6890f56fa6945c0ccc601e65d0c83.json | Revert the change of GLTFLoader | examples/js/loaders/GLTFLoader.js | @@ -1644,7 +1644,7 @@ THREE.GLTFLoader = ( function () {
}
- if ( primitive.indices !== undefined ) {
+ if ( primitive.indices ) {
geometry.setIndex( dependencies.accessors[ primitive.indices ] );
@@ -1694,7 +1694,7 @@ THREE.GLTFLoader = ( function () {
var meshNode;
- i... | false |
Other | mrdoob | three.js | 3f68e221937cd45836a4fdaee3d33e1e1eb55ac6.json | Add a comment with a link to PR | src/core/Clock.js | @@ -18,7 +18,7 @@ Object.assign( Clock.prototype, {
start: function () {
- this.startTime = ( typeof performance === 'undefined' ? Date : performance ).now();
+ this.startTime = ( typeof performance === 'undefined' ? Date : performance ).now(); // see #10732
this.oldTime = this.startTime;
this.elapsedTi... | false |
Other | mrdoob | three.js | 68c57aa9c9d90ef76b0f7896b64476a24c6b484a.json | Add Clock support in node | src/core/Clock.js | @@ -18,7 +18,7 @@ Object.assign( Clock.prototype, {
start: function () {
- this.startTime = ( performance || Date ).now();
+ this.startTime = ( typeof performance === 'undefined' ? Date : performance ).now();
this.oldTime = this.startTime;
this.elapsedTime = 0;
@@ -52,7 +52,7 @@ Object.assign( Clock.pro... | false |
Other | mrdoob | three.js | cd140d94cd9961cc1557645adb686bf4942f6950.json | Replace magic numbers with descriptive var names | examples/js/loaders/GLTFLoader.js | @@ -1090,10 +1090,10 @@ THREE.GLTFLoader = ( function () {
var sampler = json.samplers[ texture.sampler ];
- _texture.magFilter = WEBGL_FILTERS[ sampler.magFilter || 9729 ];
- _texture.minFilter = WEBGL_FILTERS[ sampler.minFilter || 9986 ];
- _texture.wrapS = WEBGL_WRAPPINGS[ sampler.w... | false |
Other | mrdoob | three.js | accd0b3b2067ac05cd2557252ba4394fd04c7939.json | Simplify the code. | src/loaders/FileLoader.js | @@ -186,18 +186,9 @@ Object.assign( FileLoader.prototype, {
if ( request.overrideMimeType ) request.overrideMimeType( this.mimeType !== undefined ? this.mimeType : 'text/plain' );
- if ( this.requestHeader !== undefined ) {
+ for ( var header in this.requestHeader ) {
- var keys = Object.keys( this.req... | false |
Other | mrdoob | three.js | 70eec3685613801310ca3799289a96be883ae843.json | fix use of k without definition | examples/js/exporters/OBJExporter.js | @@ -20,7 +20,7 @@ THREE.OBJExporter.prototype = {
var normal = new THREE.Vector3();
var uv = new THREE.Vector2();
- var i, j, l, m, face = [];
+ var i, j, k, l, m, face = [];
var parseMesh = function ( mesh ) {
| false |
Other | mrdoob | three.js | 6f68f3c93fcbdf7a79bc9e99e47a17569580c502.json | Add setRequestHeader method to FileLoader | src/loaders/FileLoader.js | @@ -186,6 +186,21 @@ Object.assign( FileLoader.prototype, {
if ( request.overrideMimeType ) request.overrideMimeType( this.mimeType !== undefined ? this.mimeType : 'text/plain' );
+ if ( this.requestHeader !== undefined ) {
+
+ var keys = Object.keys( this.requestHeader );
+
+ for ( var i = 0, il = keys... | false |
Other | mrdoob | three.js | 1157238af9bed9ddc7d86d4538b4caaa26323b21.json | Fix typo in _removeInactiveAction.
Fixes #10700. | src/animation/AnimationMixer.js | @@ -284,7 +284,7 @@ Object.assign( AnimationMixer.prototype, EventDispatcher.prototype, {
var actionByRoot = actionsForClip.actionByRoot,
- rootUuid = ( actions._localRoot || this._root ).uuid;
+ rootUuid = ( action._localRoot || this._root ).uuid;
delete actionByRoot[ rootUuid ];
| false |
Other | mrdoob | three.js | c7d02f6d564903ee25c057d13842575200da04d6.json | Fix typo in AudioListener documentation | docs/api/audio/AudioListener.html | @@ -93,7 +93,7 @@ <h3>[method:Number getMasterVolume]()</h3>
Return the volume.
</div>
- <h3>[method:null getMasterVolume]( [page:Number value] )</h3>
+ <h3>[method:null setMasterVolume]( [page:Number value] )</h3>
<div>
Set the volume.
</div> | false |
Other | mrdoob | three.js | bc885619e770b64acd4a22f35c55c1436235ff9b.json | Remove USE_SPECULAR2MAP from shader | src/renderers/shaders/ShaderChunk/uv_pars_fragment.glsl | @@ -1,4 +1,4 @@
-#if defined( USE_MAP ) || defined( USE_BUMPMAP ) || defined( USE_NORMALMAP ) || defined( USE_SPECULARMAP ) || defined( USE_ALPHAMAP ) || defined( USE_EMISSIVEMAP ) || defined( USE_ROUGHNESSMAP ) || defined( USE_METALNESSMAP ) || defined( USE_GLOSSINESSMAP) || defined( USE_SPECULAR2MAP )
+#if defined( U... | true |
Other | mrdoob | three.js | bc885619e770b64acd4a22f35c55c1436235ff9b.json | Remove USE_SPECULAR2MAP from shader | src/renderers/shaders/ShaderChunk/uv_pars_vertex.glsl | @@ -1,4 +1,4 @@
-#if defined( USE_MAP ) || defined( USE_BUMPMAP ) || defined( USE_NORMALMAP ) || defined( USE_SPECULARMAP ) || defined( USE_ALPHAMAP ) || defined( USE_EMISSIVEMAP ) || defined( USE_ROUGHNESSMAP ) || defined( USE_METALNESSMAP ) || defined( USE_GLOSSINESSMAP) || defined( USE_SPECULAR2MAP )
+#if defined( U... | true |
Other | mrdoob | three.js | bc885619e770b64acd4a22f35c55c1436235ff9b.json | Remove USE_SPECULAR2MAP from shader | src/renderers/shaders/ShaderChunk/uv_vertex.glsl | @@ -1,4 +1,4 @@
-#if defined( USE_MAP ) || defined( USE_BUMPMAP ) || defined( USE_NORMALMAP ) || defined( USE_SPECULARMAP ) || defined( USE_ALPHAMAP ) || defined( USE_EMISSIVEMAP ) || defined( USE_ROUGHNESSMAP ) || defined( USE_METALNESSMAP ) || defined( USE_GLOSSINESSMAP) || defined( USE_SPECULAR2MAP )
+#if defined( U... | true |
Other | mrdoob | three.js | 8360b532643264f817e9d648b72e43c20f111ba5.json | Fix diffuse shader code of Specular-Glossiness | src/renderers/shaders/ShaderChunk/lights_physical_fragment.glsl | @@ -1,7 +1,7 @@
PhysicalMaterial material;
#ifdef STANDARD_SG
- material.diffuseColor = diffuseColor.rgb * ( 1.0 - max( max( specular2Factor.r, specular2Factor.g ), specular2Factor.b ) );
+ material.diffuseColor = diffuseColor.rgb;
material.specularRoughness = clamp( 1.0 - glossinessFactor, 0.04, 1.0 );
materia... | false |
Other | mrdoob | three.js | f99ce24e8212a1ff6fd2883e80140df325a15746.json | Move a comment line in AnimationAction | src/animation/AnimationAction.js | @@ -328,6 +328,8 @@ Object.assign( AnimationAction.prototype, {
_update: function( time, deltaTime, timeDirection, accuIndex ) {
+ // called by the mixer
+
if ( ! this.enabled ) {
// call ._updateWeight() to update ._effectiveWeight
@@ -337,8 +339,6 @@ Object.assign( AnimationAction.prototype, {
}
... | false |
Other | mrdoob | three.js | 8cda17649d7cfaff1a9728f3f02c7bc5075ab949.json | Fix comments in AnimationAction | src/animation/AnimationAction.js | @@ -66,8 +66,8 @@ function AnimationAction( mixer, clip, localRoot ) {
this.repetitions = Infinity; // no. of repetitions when looping
- this.paused = false; // false -> zero effective time scale
- this.enabled = true; // true -> zero effective weight
+ this.paused = false; // true -> zero effective ti... | false |
Other | mrdoob | three.js | 073f3736275625813b838cbb9547c8bfcf4096e9.json | Use 2D noise in webgl_gpgpu_water demo
Using 3D or higher simplex noise (for example, using 3D simplex noise in the demo) may be problematic because of [U.S. 6067776](https://www.google.com/patents/US6867776). (I am not a lawyer.) Fortunately, the demo doesn't appear to rely on 3D noise and can just use 2D noise ins... | examples/webgl_gpgpu_water.html | @@ -421,7 +421,7 @@
var mult = 0.025;
var r = 0;
for ( var i = 0; i < 15; i++ ) {
- r += multR * simplex.noise3d( x * mult, y * mult, z * mult );
+ r += multR * simplex.noise( x * mult, y * mult );
multR *= 0.53 + 0.025 * i;
mult *= 1.25;
} | false |
Other | mrdoob | three.js | 640043905206a080a36c0981a28aca6c42184767.json | use UserAgent to detect IE | examples/js/renderers/CSS3DRenderer.js | @@ -63,10 +63,7 @@ THREE.CSS3DRenderer = function () {
domElement.appendChild( cameraElement );
- // Should we replace to feature detection?
- // https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/transformstylepreserve3d.js
- // So far, we use `document.documentMode` to detect IE
- var isFlat... | false |
Other | mrdoob | three.js | 1a85493265460fb2db69da259ed841d0d2faa829.json | Remove usage of THREE.ImageUtils.loadTexture | examples/js/loaders/AssimpLoader.js | @@ -966,8 +966,7 @@
path = path.substr( path.lastIndexOf( "/" ) + 1 );
}
-
- return THREE.ImageUtils.loadTexture( baseURL + path );
+ return ( new TextureLoader() ).load( baseURL + path );
};
@@ -2350,4 +2349,4 @@
THREE.AssimpLoader = AssimpLoader;
-} )();
\ No newline at end of ... | false |
Other | mrdoob | three.js | 796539369ef1a808ccd6b250ec2b2a327cf7bd37.json | Simplify regex a bit, update comments. | src/animation/PropertyBinding.js | @@ -108,13 +108,12 @@ Object.assign( PropertyBinding, {
// be matched to parse the rest of the track name.
var directoryRe = /((?:[\w-]+[\/:])*)/;
- // Target node. May contain word characters (a-zA-Z0-9_) and '.' or '-'
- // characters, but must begin and end with a word character.
- var nodeRe = /(\w(?:[\w... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.