prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: if Slash Validator occurs, UNSTAKING_QUEUE's unstake amount will not be accurate
### Description
`UNSTAKING_QUEUE` holds `UnbondingDelegationEntry.initial_balance`.
If a `Slash Validator` occurs, which actually unstake amount is `UnbondingDelegationEntry.balance`, this value will be smaller than `UnbondingD... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Refactor external/internal function to avoid unnecessary SLOAD
### Description
The function below read storage slots that are previously read in the function that invokes it. We can refactor the external/internal functions to pass cached storage variables as stack variables and avoid the extra storage reads th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | rounding | false | false | Source: https://github.com/sherlock-audit/2023-02-carapace-judging/issues/27
## Found by
chaduke
## Summary
Some protection buyers will never be able to renew their protection due to delayed expiration processing.
## Vulnerability Detail
We show below how some buyers will not be able to renew their protection due... | Sherlock | 5 | Carapace |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: exit reverts if there are no claimable rewards
### Description
If the liquidity pool lacks claimable staker rewards (which is possible under certain conditions), the exit will always revert. Such cases are likely to surprise users and cause them to waste gas.
### Recommendation
- **Short term:** Make `claimRe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Bypass limit | true | true | ## Lines of code
https://github.com/debtdao/Line-of-Credit/blob/audit/code4rena-2022-11-03/contracts/modules/credit/SpigotedLine.sol#L106-L112
https://github.com/debtdao/Line-of-Credit/blob/audit/code4rena-2022-11-03/contracts/utils/SpigotedLineLib.sol#L75-L85
## Vulnerability details
## Impact
Lender can trade cl... | Code4rena | 5 | Debt DAO |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Negative Exponent
### Description
## Handling Negative Exponents in Pyth and Pyth EMA
In `pyth` and `pyth_ema`, while calculating the price from `pyth_price`, the case where the exponent (expo) of the price is negative is not handled.
## Code Example
### File: `oracles/pyth_ema.rs`
The code only considers... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Single-setting with no Fail-safe Mechanism in `_setPBXToken` Function
### Description
**Severity**: Low
**Status** : Unresolved
**Description**
The function `_setPBXToken` in the ComptrollerNoNFTPart1 smart contract allows for the setting of the PBXToken address by the admin. It checks if the PBXToken add... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: SENDELEMENTSTOPERSONALBUNDLER() FUNCTION CAN RUN INTO AN INFINITE LOOP
### Description
Users can call `sendElementsToPersonalBundler()` function to move every token inside a bundle to a personal bundle. This function uses a `while` loop to iterate through every `childToken` of every `childContract` until `chil... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: ZERO ADDRESS NOT CHECKED
### Description
The function `setTokenOracle` within the contract `OracleAggregator.sol` is not verifying the `callAddress` parameter is not the zero address to avoid having issues retrieving the token price data feed.
Code Location
-------------
### Recommendation
**SOLVED**: The is... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Use Ownable2StepUpgradeable for all contracts
### Description
**Severity:** Informational
**Description:** In the project, only the `src/oracle/LogarithmOracle.sol` and `src/hedge/gmx/GmxGasStation.sol` contracts utilize the `Ownable2StepUpgradeable` contract, while the rest rely on OwnableUpgradeable.
To ma... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: `createVault()` does not confirm whether `tokenType` and `token`’s type are the same
### Description
_Submitted by GimelSec, also found by antonttc_
### Impact
When calling `createVault()`, `tokenType` could be different from `token`’s type. If a user accidentally used the wrong `tokenType`, it could lea... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Native tokens in the DAOs are stuck
### Description
Both `_buyGovernanceTokenERC20DAO()` and `_buyGovernanceTokenERC721DAO()` will send their native token deposits to the DAO address when configured so:
```solidity
if (_daoDetails.depositTokenAddress == NATIVE_TOKEN_ADDRESS) {
payable(_daoDetails.assetsS... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Circuits rely on undefined behavior in lib�
### Description
Running the circuits to validate blocks triggers undefined behavior in the `libff` library. To maintain strong security guarantees and high performance, DeGate requires that certain computations be performed from the `ethsnarks` circuits. The operator ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Insufficient Account Checks
### Description
## Codebase Vulnerabilities
The codebase contains a broad class of vulnerabilities related to insufficient validation of intermediate accounts passed via `remaining_accounts`. These vulnerabilities may enable malicious actors to spoof the sender or manipulate oth... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Not using the SafeMath library
### Description
The [`SafeMath`](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v2.5.0/contracts/math/SafeMath.sol) library is not being used in the increment operation in [line 215](https://github.com/celo-org/celo-monorepo/blob/b2f0a58fcc7667d41585123aae5b24c47aa89... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Insufficient test coverage of new features
### Description
Code that was added to `reserve-index-dtf` to support trusted fillers and rebalancing is not sufficiently tested (figures 1.1–1.3). Several new functions in the Folio contract and the TrustedFillerRegistry contract are not tested at all, and some funct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: EffectiveTrader's nonce is not always invalidated
### Description
In the following code:
```solidity
function _validateTakerSignatureForSingleOrder(...) internal {
if (msg.sender != _order.effectiveTrader) {
validateSignature(
_order.effectiveTrader,
hashSingleOrder(_order),
_takerSignature
);
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: `ABONDToken::transferFrom` does not work as intended and allows theft of ETH funds from `Treasury`
### Description
The `ABONDToken::transferFrom` function suffers from a logical issue where the `fromState` post `Colors::_debit` is updated to the `msg.sender` and not to the `from` address. This not only breaks... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Time-skew Attack in RWAGauge Weight Calculations Through Precision Gaming
### Description
A precision-based timing attack exists in RWAGauge where malicious users can manipulate gauge weights by exploiting how the time-weighted averages are calculated, allowing them to maximize rewards through strategic wei... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Lack Of Prepaid Gas Validation May Result In Unintended Consumption Of Gas
### Description
To unstake BTC, users must first initiate a queue withdrawal request by signing BTC messages. This request is then processed by a relayer on the NEAR side, which invokes the `queue_withdrawal` function within the **bithi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: LeverageManager closeFee is only collected for pTKN, which can be easily bypassed.
### Description
LeverageManager closeFee is only collected for pTKN, which can be easily bypassed.
### Impact
User can bypass closeFee when removing leverage.
### Recommendation
Also charge closeFee for leftover borrowedTKN... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: 7. DISCREPANCY IN TRANSACTION RLP DECODING BETWEEN ZKEVM AND EVM
### Description
**Severity:** Low
**Path:** [StakeableVestingFactory.sol:deployStakeableVesting#L39-L71](https://github.com/0xPolygonHermez/zkevm-rom/blob/develop/main/load-tx-rlp.zkasm#L164-L206)
**Description:**
In the load-tx-rlp.zkasm impl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | upgrade | true | false | ## Low: Silent Failure in `voting_reset`
### Description
The `voting_reset` function silently ignores failures when attempting to upgrade the community account header for writing. If the `community_acc` account is not marked as writable, the `upgrade()` call fails, but the function still returns `Ok(())`, giving the c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | send vs call | false | false | _Submitted by leastwood, also found by 0xliumin, berndartmueller, cccz, Czar102, gzeon, hickuphh3, horsefacts, ilan, IllIllI, joestakey, m9800, p4st13r4, peritoflores, reassor, rfa, robee, sorrynotsorry, tintin, TrungOre, VAD37, WatchPug, and z3s_
[ForgottenRunesWarriorsMinter.sol#L610](https://github.com/code-423n4/2... | Code4rena | 3 | Forgotten Runes |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: AuraSpell openPositionFarm does not join pool
### Description
The function to open a position for the AuraSpell does not join the pool due to wrong conditional check.
### Impact
The rest of the function proceeds correctly without reverting. Users will think they joined the pool and are earning reward while... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Externally-owned accounts can be registered as contracts in the Augur contract
### Description
The [`registerContract`>](https://github.com/AugurProject/augur/blob/9a33c3269e812d0cb66d49b61a72db58e32e4749/packages/augur-core/source/contracts/Augur.sol#L90) [function](https://github.com/AugurProject/augur/blob/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Declare uint as uint256 and int as int256
### Description
To favor explicitness, all instances of `uint` should be declared as `uint256` and all instances of `int` should be declared as `int256`.
***Update:** Partially fixed in [pull request #81](https://github.com/reflexer-labs/geb/pull/81/files). Two insta... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inadequate Upper Bound for Protocol Fees
### Description
The Atlas contract features four types of fees: deposit fees, redemption fees, bridging fees, and Babylon rewards fees.
Each fee type has a maximum limit of `10000` basis points (bps), which equates to `100%`.
The `update_fee_deposit_bps` function ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Non-ideal handling of arithmetic
### Description
Improving certain arithmetic operations used in the contracts under review would increase readability and ensure consistency in the operations. For example, the handling of rounding directions could be improved. There is some consideration of the rounding direct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Wrong handling of call data check indices, forcing it sometimes to revert
### Description
Cold signers can add call data checks as whitelisted checks that hot signers could execute without timelocks, the call data checks depend on the indices of the encoded call. However, the protocol invalidly handles thes... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: A cross-check of contract parameters
### Description
If contracts `ActivePool`, `CollSurplusPool`, `DefaultPool`, `StabilityPool` and `BorrowerOperations` are deployed with the misconfigured `_collateralAddress` parameter, they will be unable to withdraw the deposited collateral.
### Recommendation
It is r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Check return values for both internal and external calls ✓ Fixed
### Description
There are some cases where functions which return values are called throughout the source code but the return values are not processed, nor checked.
The returns should in principle be handled and checked for validity to provide ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | true | ## Low: Core invariant not properly checked in base contract
### Description
One of the most important invariants of any stream is that it should never be possible to withdraw more than what has been deposited minus the refunded amount.
In `SablierV2Lockup::_withdraw()`, there is no explicit check for this; it impli... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Missing length checks
### Description
**Severity**: Low
**Status**: Resolved
**Description**
In Contract AFiMarnager.sol, the method `setSlippage(...)` needs to check that the length of uToken and slippage factor arrays are the same.
In Contract AFiOracle.sol, the method `intializeStalePriceDelay(...)` nee... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Users can entirely skip paying fees if there is no feeRecipient
### Description
`_takeFee` doesn't take a fee if the user's interest is 0 or if there's no fee recipient. And, from the `updateFeeRecipient`, we can see that the `feeRecipient_` can be set to address(0) for some reason.
During the period when th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | false | false | ## High: `distribute` DoS on missing `receiveRewards` implementation
### Description
`NFTXEligiblityManager._sendForReceiver` should check `returnData.length == 1` before decoding. Otherwise, if it returns no return data, the `abi.decode` call will revert and with it the whole `distribute` function .
A single poorly ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | false | ## High: Malicious actors can manipulate the `cross_chain_callback` callback
### Description
### Impact
Because the validator's signature message does not include the `from_chain` field, a malicious actor can preemptively execute the validator's transaction with an incorrect `from_chain` field. This can cause the sta... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: TRST-M-1 small LP providers may be unable to withdraw their deposits
### Description
**Description:**
In LiquidityPool’s initiateWithdraw(), it’s required that withdrawn value is above a minimum
parameter, or that withdrawn tokens is above the minimum parameter.
The issue is that **minDepositWithdraw** is... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary reading from storage.
### Description
**Description**
Function _calculate(), lines 470-472, 477.
Function _stake(), lines 365, 368, 370.
Function withdraw(), lines 396, 399.
Function _withdraw(), lines 404, 405, 406.
Multiple reads of values from mapping deposits.
**Recommendation**:
consider cr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Address parsing from tokenId to address string does not account for leading 0s
### Description
Policy token IDs are derived from the holder's account address. The address is intended to be displayed in the SVG generated when calling `tokenURI`. Currently, leading zeros are truncated, rendering the incorrect ad... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Locked Tokens In Milestone Contract
### Description
## Vulnerability Overview
In `BaseMilestone::setComplete`, the `OnlyDeposited` modifier allows a milestone to be marked as complete if and only if it is deposited fully. The problem arises from the modifier’s method of checking the balance, which checks if ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: DAO creators cannot freely update membership configuration
### Description
**Description:** While `MembershipFactory::updateDAOMembership` is intended to update the tier configurations for a specific DAO, this function can only be called by the [permissioned](https://github.com/OneWpOrg/audit-2024-10-oneworld/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | true | false | ## Medium: 5-CrossChainWETHSwapFeesChargedUnnecesarily
### Description
When doing a cross-chain transfer with any valid `fromToken`, using `sgETH` as `bridgeToken` and **WETH** as `toToken` via the
`WooRouterV2` swap on destination chain. The user is charged an unnecessary fee.
### Impact
Users lose unnecessary money... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Erroneous Calculation Leads To Unfair Liquidation
### Description
## Inlogic.move Vulnerability Overview
The `calculate_max_liquidation` function retrieves `max_liquidable_collateral` and `max_liquidable_debt`. During calculations done within the function, some inaccuracies undermine the accuracy of these va... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Insufficient Key Rotations
### Description
## Password-Based Key Derivation Function 2 (PBKDF2)
PBKDF2 enhances password security by increasing the computational costs to derive the cryptographic key from the password. The security of PBKDF2 primarily depends on the number of iterations (work factor) along wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | high | token | true | true | ## High: Precision Manipulation Due to Missing Mint Check
### Description
`deposit_handler` chooses the conversion precision (`conv_decimals`) as:
```rust
let conv_decimals = ctx
.accounts
.liquidation_token_mint
.as_ref()
.map(|mint| mint.decimals) // if Some ⇒ use its decimals
.unwrap_o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Cooldown contracts underreport the real balance of users because they only consider the balance of requests whose cooldown period is over
### Description
**Description:** Cooldown contracts underreport the real balance of users because not all active requests are accounted for; only those requests whose cooldo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: `ReferralsUtils.updateReferralsOpenFeeP()` implements wrong check
### Description
At L75 in the `updateReferralsOpenFeeP` function comparing sign is wrongly set to , resulting in an inability to set openFeeP to value in the correct range:
```solidity
File: ReferralsUtils.sol
74: function updateReferralsOpen... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Fund locked due to lack of an implementation for withdrawing service fees
### Description
**Severity**: Critical
**Status**: Resolved
**Location**: BandoRouterV1.sol
**Description**
In the BandoRouterV1 contract, the requestService() function requires the caller to pay the sum of request.weiAmount and ser... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing Verification for `tokenOut_` in `swapExactOut`
### Description
The `swapExactOut` function correctly verifies several conditions for `tokenIn_`, but it lacks a similar verification for `tokenOut_`, which could lead to indexing issues if `tokenOut_` exceeds the number of tokens managed by the contract. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing Event Emissions
### Description
Throughout the codebase, the constructors and initializers do not emit events after initializing sensitive variables in the system. Although in some cases, when those variables are updated using setter functions, an event is emitted:
* In the `initialize` function of `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Campaign creation reverts if exact native token amount not sent
### Description
The `setCampaign()` function requires depositing a reward token that will be disbursed to liquidity providers (LPs). The required amount for this function depends on the current balance of the campaign, which is influenced by th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Wrong invocation of Whirpools's updateFeesAndRewards will cause it to always revert
### Description
Deposits will be unwithdrawable from the lockbox.
### Proof of Concept
If the entire liquidity of a position has been removed, the withdraw function calls the `updateFeesAndRewards` function on the Orca pool ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Centralization risk: Lack of Access Control in requestFunds
### Description
The `requestFunds` function is marked with `onlyProtect`, but there's no mechanism to change or update the `protectStrategy` address once it is set. This could be a problem if the `protectStrategy` needs to be updated or changed due to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Single-sided liquidity calculation off with high `PrincipalToken` fees
### Description
_Acknowledged_
The `_splitUnderlyingTokenLiquidityKeepYt` function calculates the optimal split of a single underlying token (YBT) for a liquidity provision. It calculates the `amount0ToTokenize` based on the current ratio ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Cache array length outside of loop | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Violations of Solidity Style Guide Conventions - confusion naming.
### Description
**Severity**: Informational
**Status**: Acknowledged
**description**
The presence of variables like `value` and `_value` within the same codebase could cause
confusion.
**Recommendation:**
Align variable naming with the sty... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Add EIP-2981 NFT Royalty Standart Support
### Description
Consider adding EIP-2981 NFT Royalty Standard to the project
https://eips.ethereum.org/EIPS/eip-2981
Royalty (Copyright – EIP 2981):
* Fixed % royalties: For example, 6% of all sales go back to artists
* Declining royalties: There may be a continuous... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Max price deviation is too high
### Description
The `MAX_PRICE_DEVIATION_FROM_PREVIOUS_ROUND` parameter is intended to safeguard against price manipulation. It is utilized within the `_chainlinkPriceChangeAboveMax()` function to verify if the price has undergone a substantial change between consecutive roun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Emitting incorrect event value
### Description
The `LibShortRecord::burnNFT()` emits an incorrect event value.
### Impact
The `ERC721::Transfer` is an important event. The incorrect event logs may cause off-chain services to malfunction. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: The period check in `getNextUnstake()` always returns true
### Description
The function `getNextUnstake()` is used to get the next unstake request in the queue, while also verifying if the request can be fulfilled. One of the condition to make the request fulfillable is `unstake.period <= reportPeriod`.
```so... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | oracle | true | false | Source: https://github.com/sherlock-audit/2023-02-notional-judging/issues/19
## Found by
xiaoming90
## Summary
Trade might be settled with a large slippage causing a loss of assets as the `oracleSlippagePercentOrLimit` limit is not bounded and can exceed the `Constants.SLIPPAGE_LIMIT_PRECISION` threshold.
## Vuln... | Sherlock | 5 | Notional Update #2 |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: In LiquidVestingTokenFactory contract you can set merkleRootSigner via constructor or with function setMerkleRootSigner() in both cases there is no check for setting it to the zero address.
### Description
**Recommendation**:
Add check for the zero address to the contract constructor and function setMerkleRoo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Uniswap | false | true |
An init code hash is used to calculate the address of UniswapV2 pair contract. But the init code hash is not same as the latest UniswapV2 repository.
### Proof of Concept
UniswapV2Library.pairFor uses the following value as the init code hash of UniswapV2Pair.
hex"e18a34eb0e04b04f7a0ac29a6e80748dca96319b42c... | Code4rena | 5 | Numoen |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: `_treeCid` is not checked for duplicate value
### Description
The issue is identified within the [processOracleReport](https://github.com/lidofinance/community-staking-module/blob/a898d045b63303294752d1a60ad9dfe8d8ba69ca/src/CSFeeDistributor.sol#L129) function of the `CSFeeDistributor` contract. `_treeCid` sho... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: Missing upper limit definition in `replaceLenderFee()` of `HomeFi.sol`
### Description
_Submitted by MiloTruck, also found by __141345__, 0x52, 8olidity, cccz, Ch_301, codexploder, cryptonue, hansfriese, Ruhum, and sseefried_
[Community.sol#L392-L394](https://github.com/code-423n4/2022-... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Open TODOs
### Description
Code architecture, incentives, and error handling/reporting questions/issues should be resolved before deployment
*There is 1 instance of this issue:*
https://github.com/code-423n4/2022-05-sturdy/blob/78f51a7a74ebe8adfd055bdbaedfddc05632566f/smart-contracts/GeneralVault.sol#L77 | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Funds sent by an athlete to a closed distribution are impossible to return
### Description
It's possible for an athlete to send funds to a closed distribution with `FantiumClaimingV1.addDistributionAmount()` if they were not sent before (https://github.com/FantiumAG/smart-contracts/blob/a2d126453c1105028f1227... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unchecked Removal of the Paused\_Key
### Description
**Description:**
The function pa\_unpause\_feature() lacs a check on key's removal. The existence of the key is not checked. In this case, if the key does not exist, the contract will not panic, which may mislead the project manager and bring unexpected im... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | false | false | ## Medium: Unchecked subtraction underflow
### Description
L2 gas validation performs [an unchecked subtraction](https://github.com/matter-labs/zksync-2-contracts/blob/3f345ce52bc378c4b5d710c80d817db170775049/ethereum/contracts/zksync/facets/Mailbox.sol#L543), and a neighboring comment states that the underflow preven... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Isolate Key Signing
### Description
## User Signing Secrets in Martian Frontend
Originally, user signing secrets were passed from the background script into the Martian frontend via the `aemc get` call, where key signing would then be performed.
## Background Script Code
Isolating key signing to the backgr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Protocol charges platform fees twice
### Description
**Severity**
**Impact:** High
**Likelihood:** Low
**Description**
LP can call the repay on an underwater loan to retrieve their tokens back without their position being restored. If there are no other positions associated with this loan, the caller wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Rounding Clarification
### Description
## Regarding the TODOs in reserve
`ctoken_market_value_upper_bound` computes an upper bound estimate of the market value for a specified quantity of cTokens in terms of the underlying currency. Since this estimation is used solely in rate-limiting scenarios, employing `c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: contractEnabled should be a bool
### Description
The variable `contractEnabled` is declared in many contracts as a `uint` value, for example [within the `BasicTokenAdapters`](https://github.com/reflexer-labs/geb/blob/261407b6b332c2063e4256aa5f9b223d52dad7e1/src/BasicTokenAdapters.sol#L88) or the [`SAFEEngine`]... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: The missing check for `newEndTime`
### Description
There is an `extendEndTime` function here - https://github.com/vibexyz/vibe-contract/blob/d08057edbaf83b00d94dcaca2a05e3c44a45e4d9/contracts/mint/MintSaleBase.sol#L124. It allows contract owner to set new `endTime` for sale. But there is no check that `newEndT... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Duplicate Logic in Position Deletion and Liquidation Execution
### Description
The `AutomationLiquidationsV2` contract contains duplicated logic between the following functions:
1. **Position Deletion:** `_deletePosition` and `deletePosition` perform almost identical tasks for removing positions from storage.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | false | false | ## High: Possibility of taking burned shares
### Description
With attack it is possible to take burned shares profit even without taking shares before `processLidoOracleReport()` execution.
https://github.com/lidofinance/lido-dao/blob/ee1991b3bbea2a24b042b0a4433be04301992656/contracts/0.8.9/SelfOwnedStETHBurner.sol#L2... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Event is missing `indexed` fields
### Description
Each `event` should use three `indexed` fields if there are three or more fields
*There are 111 instances of this issue.* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: `VoteEscrowCore.safeTransferFrom` does not check correct magic bytes returned from receiver contract's `onERC721Received` function
### Description
[ERC721.sol#L395-L417](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/ce0068c21ecd97c6ec8fb0db08570f4b43029dde/contracts/token/ERC721/ERC721.sol#L39... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: [03] `L2CrossDomainMessenger._sendMessage`, `L2StandardBridge._initiateWithdrawal`, AND `L2ToL1MessagePasser.initiateWithdrawal` FUNCTIONS ALLOW RESPECTIVE `_to` OR `_target` TO BE `address(0)`
### Description
Calling `L2CrossDomainMessenger._sendMessage`, `L2StandardBridge._initiateWithdrawal`, and `L2ToL1Mes... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Rename `isAllowed` to `wasAllowed` in `Allowlist::allowUser`, `disallowUser`
### Description
`Allowlist::allowUser`, `disallowUser` return the existing `allowed` status into a named return variable called `isAllowed`, before potentially modifying the `allowed` status.
Since these functions can modify the `all... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Excessive Ether Funds are Refunded to the `buyer` Rather than `msg.sender`
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `ebf209a4d61287f7927cc21b23026f216e23ec1d`. The client provided the following explanation: Add Excessive Ether Funds are Refunded to the Buyer Rather than `msg.se... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Operator Can Prematurely Distribute Shares Before Investment Period Ends
### Description
The contract's batch processing functionality lacks validation of the investment period end time in both `processDeposit()` and batch processing functions (`startBatchProcess()`, `continueBatchProcess()`). While the `us... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | liquidation | true | false | **Severity**
**Impact:** Medium
**Likelihood:** Medium
**Description**
When validating a request to increase position size, the function `validateRequest` checks if the trade stays within exposure limits. However, the amounts and leverage used are `newCollateralAmount` and `newLeverage` instead of `collateralDelta`... | Pashov Audit Group | 3 | Gainsnetwork May |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Major insolvency risk in `LiquidationLogic::executeCrossLiquidateERC721()` due to not setting a maximum liquidation price
### Description
Whenever the price of a nft suffers a significant drop or the debt asset increases in price, there is a threshold after which liquidations are not profitable at all for t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | token | true | false | ## Gas: Avoid reading state variable twice
### Description
**Files:** `SystemContext.sol`, `L2StandardERC20.sol`
Reading state variables costs a lot of gas. It's better to always cache the state variable into local variable and read the local variable instead.
[File: code/contracts/zksync/contracts/bridge/L2Standard... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Missing Signer Verification in `voting_reset` Function Allows Unauthorized Execution
### Description
**Description:** The `voting_reset` function in `src/program/processor/voting_reset.rs` only verifies that the `admin` account's public key matches the operator address, but does not verify that the `admin` ac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Index Event Parameters for Improved Application Monitoring
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `972878e4a7abbd77618763e37d8d04fbddd6c019`.
**File(s) affected:**`GenericDifferentSpenderAdapter.sol`, `GenericBasicAdapter.sol`
**Description:** Application monitoring can be ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Privileged Roles and Ownership
### Description
**Update**
The team explained that the intention is to initially start off with a multisig being the owner, but then eventually transition into a DAO which would manage critical protocol decisions via a Governor contract coupled with a Timelock. They will be clear... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `NotSelf()` error declaration is unused
### Description
**Description:** The `DeleGatorCore` contract and `EIP7702DeleGatorCore` contract both define a custom error called `NotSelf()`, but this error is never actually thrown anywhere in either contract or their derived implementations.
**Recommended Mitigati... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: Users are able to front-run bad debt settlements to avoid insurance costs
### Description
_Submitted by kirk-baird, also found by itsmeSTYJ_
A user is able to front-run the call to `seizeBadDebt()` in `InsuranceFund.sol` to avoid paying the insurance costs.
`seizeBadDebt()` is called by `MarginAccount.se... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: `add_whitelist_ix` does not check for duplicate addresses
### Description
The `add_whitelist_ix` instruction is used to add a new address to the token whitelist.
However, it does not check whether an address has already been added. As a result, duplicate addresses can be inserted into the whitelist. Addition... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: setGlobalProtocolSwap/YieldFeePercentage() allow specifying higher precision than allowed
### Description
Severity: Low Risk
Context: ProtocolFeeController.sol#L398-L413
Description: The precision of the new values newProtocolSwapFeePercentage and newProtocolYieldFeePer-
centage aren't checked, it's possible t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: MarketPlace Change In Vesting Manager, Leads To Loss Of Previous MarketPlace Listing
### Description
When interacting with the `MarketPlace` contract and vesting listings, the `MarketPlace` contract calls the `VestingManager` contract (using the address gotten from the `MarketplaceSetting` contract) which c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | true | ## Medium: Vesting contract can lead to frequent reverts
### Description
The `Vesting` is used to lock funds on behalf of a user while giving them the ability to participate in the protocol. The idea behind the contract is that the amount of funds in the contract will gradually be unlocked over time, while giving the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing Event Emissions for State-Changing Functions
### Description
The protocol’s state-changing functions, such as `stake`, `deposit`, and `withdraw`, do not emit events after execution. Events are critical for notifying off-chain components (such as explorers, indexers, and dApps) of changes to account sta... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | true | false | ## Low: Only one vote is allowed per address
### Description
Once an address has a registered vote, it cannot vote again, even if the second vote submission is for a disjoint list of tokens.
Vote submission occurs in the internal function `_submitVote()`. The check to prevent double voting occurs on line [331]:
```s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Claim For Admin Transfer
### Description
## Admin Module Ownership Transfer
In the admin module, `transfer_admin` transfers the ownership of the protocol configuration to `new_admin`.
## Code Snippet
However, the function currently changes the admin to `new_admin` directly, which may result in the loss of ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Potential Data Corruption in Trie Structure
### Description
The issue is identified within the[`removeOrderFromNonRightmostNodeDescendants`](https://github.com/longgammalabs/hanji-contracts/blob/09b6188e028650b9c1758010846080c5f8c80f8e/src/TrieLib.sol#L780-L795) function of the `Trie` contract.
There is a cr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: optimizations - storage over memory
### Description
_Submitted by a_delamo_
In `Visor.sol`, the functions are using memory keyword, but using storage would reduce the gas cost.
**[xyz-ctrl (Visor) confirmed](https://github.com/code-423n4/2021-05-visorfinance-findings/issues/53#issuecomment-862599131):**
**... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.