prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary code blocks that check the same condition ✓ Fixed
### Description
In the `RewardsDistributor` there is a function that allows to set delegation fees for a `NodeRunner`. It adjusts the `fees[]` array for that node as appropriate. However, during its checks, it performs the same check twice in a row.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: `setMintPositionFee()` Function Almost Always Revert
### Description
The `setMintPositionFee()` function can set the `mintFeeInUsdc` value and can only be called by the admin. The problem is that the value of `mintFeeInUsdc` is too big:
```solidity
mintFeeInUsdc = 1_000_000;
```
The variable has 6 decimal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Sum of all user shares does not equal total supply
### Description
The `FxInitialFund` contract allows users to deposit up until the mint occurs, then funds can be withdrawn. Because users cannot deposit after withdrawals are enabled, the `totalSupply` is never updated and is therefore not accurate after withd... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Method `_getHaircutRate` should check if the price anchor is set or not
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**
In Contract VolatilePool.sol, the method `_getHaircutrate(...)` calculates the volatility of `fromAsset` and `toAsset` if they are not price anchor.
Since `pric... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Users can bypass auction mechanism for `LenderCommitmentGroup_Smart` liquidation mechanism for loans that are close to end of loan
### Description
`LenderCommitmentGroup_Smart` has an auction mechanism for users to help liquidate default loans. The auction begins from 8x of amountOwed gradually decreasing t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Redundant Write Operations
### Description
**Update**
**Fixed** in `e6db85b`. Implemented gas optimizations.
**File(s) affected:**`Pet.sol`, `Voucher.sol`
**Description:** The function `mintTo()` can write the same value as the custodial mapping because it maps an address to a boolean.
Consider the case whe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: balanceOf() can be circumvented via reentrancy and two pairs
### Description
A reentrancy issue can occur if two pairs with the same ERC1155 NFTid are deployed. Via a call to swap NFTs, the ERC1155 callback `onERC1155BatchReceived()` is called. This callback can start a second NFT swap via a second pair. As... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | upgrade | true | false | ## Low: `GelatoVRFConsumerBase` is not upgrade-safe
### Description
The `SpinGame` contract has been changed to be upgradeable. But, the contract inherits from `GelatoVRFConsumerBase`, which is not upgrade-safe as it lacks a reserved storage gap (`uint256[x] private __gap`) to prevent future storage collisions. This p... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | false | false | ## Gas: Lock struct has an unused member
### Description
The `Lock` struct contains a member which is unused throughout the codebase: `minter`. As a result, the `Lock` struct requires an additional storage slot, resulting in reading and writing to the struct being more gas intensive than necessary.
### Recommendation... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | true | ## Low: Different amount of input/output tokens can be returned in ExactIn and ExactOut configurations during the swap
### Description
The swap functionality of BunniSwapMath can yield different input and output token amounts on the same pool state, depending on the swap configuration (ExactIn or ExactOut). This enable... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Standardize `accountId` data type
### Description
**Description:** The `accountId` uses different data types in different contracts:
* `uint96` in [`GlobalConfiguration::Data`](https://github.com/zaros-labs/zaros-core-audit/blob/de09d030c780942b70f1bebcb2d245214144acd2/src/perpetuals/leaves/GlobalConfiguration... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: User can possess less value than before when `V2Migrator.migrate` function is called to give up `bathTokenV1` tokens and hold `bathTokenV2` tokens
### Description
Calling the following `V2Migrator.migrate` function executes `uint256 amountWithdrawn = bathTokenV1.withdraw(bathBalance)`.
Then, calling `bath... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Reentrancy Analysis
### Description
It was recommended before the audit to leave all reentrancy guards on SAM.sol and I would provide analysis of the necessity of each. My conclusions below are that I do not see reentrancy risk in any of these functions. I've included a breakdown of all external calls and anal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Floating pragma
### Description
All contracts in scope currently use floating pragma versions `^0.8.26` which means that the code can be compiled by any compiler version that is greater than or equal to `0.8.26`, and less than `0.9.0`.
However, it is recommended that contracts should be deployed with the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Excess Payment When Plugin Owner Reduces Price
### Description
The `click()` function in the `Multicall` contract does not verify that the received `msg.value` matches the calculated `price`, which is determined by calling `IQueuePlugin(plugin).getPrice() * amount`. This creates a vulnerability where users ma... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Incompatibility with fee-on-transfer or rebasing tokens
### Description
Some parts of the code operate under the assumption that the `safeTransfer()` and `safeTransferFrom()` functions will transfer an exact amount of tokens.
However, the actual amount of tokens received may be less for `fee-on-transfer` toke... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | false | false | ## Medium: Pool Upgrade Can Enable Unexpected Loss or Theft of Funds
### Description
**Update**
Mitigated. The client's response: "Along with positions limit added above, we plan to transfer proxy admin's ownership to a 48-hours timelock whenever the audit completed." The transfer still remains to be done.
**File(s) ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Withdrawal Cooldown Can Be Bypassed And Overly Restrictive
### Description
In the StakingManager contract, the `queueWithdrawal` function enforces a cooldown using `lastStakeTimestamp[msg.sender]`. While this aims to prevent immediate withdrawals after staking, there are a couple of edge cases worth noting:... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Incorrect deviation calculation in isDeviatingWithBpsCheck function
### Description
The current implementation of the `isDeviatingWithBpsCheck` function in the codebase leads to inaccurate deviation calculations, potentially allowing deviations beyond the specified limits.
### Impact
This miscalculation al... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: In LeverageModule.executeOpen/executeAdjust, vault.checkSkewMax should be called after updating the global position data
### Description
[[checkSkewMax](https://github.com/sherlock-audit/2023-12-flatmoney/blob/main/flatcoin-v1/src/FlatcoinVault.sol#L296)](https://github.com/sherlock-audit/2023-12-flatmoney/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | false | false | ## Medium: swap may be reverted if the input amount is not large enough, especially for low decimal tokens
### Description
The swap fees will be sent to the `externalBribe`. If the calculated swap fee is round down to zero, possible in low decimal tokens, the swap transaction will be reverted because `externalBribe` ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Use internal where possible
### Description
Several functions have an access control where the `msg.sender` is compared to `address(this)`, which means it can only be called from the same contract. In the current code with the various generic call mechanisms, this isn’t a safe check. For example, the function ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: CollateralToken 's conduit would have an open channel to an old Seaport when Seaport is updated
### Description
After filing for a new Seaport, the old Seaport would still have an open channel to it from the CollateralToken's conduit (assuming the old and new Seaport share the same conduit controller).
### Re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Undocumented, untested, custom behavior in transfer of ERC20 token
### Description
When the [`transfer`](https://github.com/compound-finance/compound-protocol-alpha/blob/6858417c91921208c0b3ff342b11065c09665b1b/contracts/Governance/Comp.sol#L93) and [`transferFrom`](https://github.com/compound-finance/compound... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Potential for Out-of-Gas Errors in Loops
### Description
**Severity**: Informational
**Status**: Resolved
**Description**:
The `claimRewards` function from airdrop contract processes rewards in a loop, which can potentially lead to out-of-gas errors if the arrays are too large.
**Scenario**: If a large nu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Inconsistent Blacklisting In Token Bridging
### Description
## Inconsistency in Blacklisted Addresses Treatment
There is an inconsistency in the treatment of blacklisted addresses when bridging tokens across different chains. This inconsistency is notable in the synchronization of blacklists between source... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Privileged Roles
### Description
**Update**
Addressed in: `a8d29c9d87d5e50e374a9dc5c91b3a98e608ead6`. The client added descriptions for the abilities of the roles. We still recommend this information is relayed to end users of the protocol.
**File(s) affected:**`Marketplace.sol`, `Listings.sol`, `RoyaltiesOra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | true | ## High: Wrong operator leads to unexecuted operations and lost tokens
### Description
DSClock allows scheduling of actions that may transfer ethers. Due to the use of the equality operator instead of assignment, only one scheduled action can be stored. As a result, any action previously stored is not taken into consi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | flash-loan | true | false | ## High: Attacker can perform a risk-free trade to mint free USDz tokens by opening then quickly closing positions for markets using negative `makerFee`
### Description
**Description:** Attacker can perform a risk-free trade to mint free USDz tokens by opening then quickly closing positions in markets using negative `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: There is no way to convert between custom and non-custom funds Won't Fix
### Description
Each fund is created using either `Funds.create()` or `Funds.createCustom()`. Both enforce a limitation that there can only be one fund per account:
**code/ethereum/contracts/Funds.sol:L348-L355**
```
function crea... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: The current idea of creating reETH and accepting several different assets in it exposes RIO users to losses
### Description
After the release of LRT, which will include the ability to deposit native eth and wrapped staking tokens like cbETH or wstETH, Rio users will be exposed to additional economic risks... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: Duplicate ERC20 tokens will send a greater than prorata token share leading to loss of DAO funds
### Description
The function `_setErc20TokensToIncludeInFork()` is an admin function for setting ERC20 tokens that are used when splitting funds to a fork. However, there are no sanity checks for duplicate ERC20... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Incorrect utilization rate forces protocol to issue maximum rewards indefinitely
### Description
The `RAACMinter` incorrectly measures total borrowed amount by using normalized debt (27 decimals) instead of debt token supply and compares this with total deposits (18 decimals). This artificially inflates the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: TRST-M-5 recoverFunds() does not handle popular ERC20 tokens like BNB
### Description
**Description:**
recoverFunds() is used for recovery in case of mistakenly-sent tokens. However, it uses unsafe
transfer to send tokens back, which will not support 100s of non-compatible ERC20 tokens.
Therefore it is l... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: Re-Entrancy Vulnerability potentially Leading to Contract Deadlock and Permanent Insol- vency
### Description
The `refundGame` function is vulnerable to a re-entrancy attack, which can be exploited to manipulate `totalOnLine` and cause an underflow. This happens because `payable(game.player).call{value: ref... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Using private rather than public for constants, saves gas
### Description
If needed, the value can be read from the verified contract source code. Savings are due to the compiler not having to create non-payable getter functions for deployment calldata, and not adding another entry to the method ID table.
Fil... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | false | false | ## Gas: Structs can be packed into fewer storage slots
### Description
Each slot saved can avoid an extra Gsset (20000 gas) for the first setting of the struct. Subsequent reads as well as writes have smaller gas savings | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Progressive Buy Cap Does Not Reach Intended 50M at Minute 50
### Description
The contract intends to ramp cumulative per-address buy caps from 200k to 50M tokens over 50 minutes. The constructor computes `slope` assuming 49 incremental steps (triangular number 1225) and includes 49 fixed 200k steps, but `cumul... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: AMM - funding can be called in emergency mode Pending
### Description
The [specification](https://github.com/mcdexio/documents/blob/b94b98a806d29d7ce135e1011b094868e07eeb5d/en/internal-amm.md#funding) for `AMM.funding()` states `isEmergency==FALSE` as a requirement. However, the state `isEmergency` does not ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Potential Optimization - Inefficient State Variable Declaration (not constant).
### Description
**Severity**: Informational
**Status**: Resolved
**description**
bpnmMain: _binanceBtcOracle, _chainLinkBtcOracle.
Described addresses are set at deployment and are intended to remain unchanged for the
contract's... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: [18] Contrary to whitepaper, backstop rate can be changed
### Description
### Finding description and impact
According to the whitepaper, the backstop rate should be immutable and set upon deployment.
> Owned pools are isolated lending pools where a delegated address can modify pool state and most pool param... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | other | true | true | ## Lines of code
https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contract/MinipoolManager.sol#L560
https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contract/MinipoolManager.sol#L676
## Vulnerability details
... | Code4rena | 5 | GoGoPool |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: User can alter amount returned by redeem function due to control transfer
### Description
_Submitted by 0xDjango_
Control is transferred to the receiver when receiving the ERC777. They are able to transfer the ERC777 to another account, at which time the before and after balance calculation will be incorre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: Stakers Accumulate `aSugar` Based On The Spot Price During The Claim
### Description
Let's say Alice stakes 100e18 of a token for 10 days. During these 10 days, the price of the token was 10 USD. At the end of the 10th day the price doubles and becomes 20 USD per token.
Alice harvests the accumulated `aSug... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: Malleability In Message’s Signature Check
### Description
During the `generateDepositAddressController` class execution, there are several checks being executed in order to guarantee that the request is safe to be processed. One of those checks is run in the `verifyDestinationSignature` function, in charge ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Use of arithmetic operators instead of LibMath functions
### Description
Given below is the list of occurrences in the codebase where arithmetic calculations are performed using arithmetic operators instead of using `LibMath` library functions:
* [In `ChainlinkAdapter.sol`](https://github.com/mcdexio/mai-pro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Last buy might charge the wrong fee
### Description
In the “last buy” process, the protocol automatically adjusts the price to fit the curve, ensuring precise SOL fundraising. This results in a change in the transaction price, which also alters the amount of SOL paid by the user. However, since the swap fee... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: User Can Receive a Discount Due to Loss of Precision
### Description
**Update**
From the team:
**File(s) affected:**`packages/amm/contracts/HifiPool.sol`
**Description:** The `getQuoteForBuyingHToken()` function is referenced by the `buyHToken()` function to determine how many underlying tokens are needed t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Swap amounts are always estimated with priority fee
### Description
A pool can have a priority fee that is only applied when the pool controller (contract) performs a swap. However, when estimating a swap with `getAmountOut`, the priority fee will always be applied as long as there is a controller and a pri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Cache storage variables that are read multiple times
### Description
The storage parameters `_feeCollector` in `_collectGovernanceFee` and `_sweepCollector` in `_sweep` are read multiple times. These parameters used to be immutable variables, and so it would have made sense just to inline them. However, for st... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Broken accounting when cancelUnwinding is called one epoch after startUnwinding
### Description
When a user calls `startUnwinding`, the positions mapping is updated as follows:
```solidity
positions[id] = UnwindingPosition({
shares: newShares,
fromEpoch: nextEpoch,
toEpoch: endEpoch,
fromRewardWeight... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Miscellaneous AngleProtocol General Comments 2
### Description
This section details miscellaneous findings discovered by the testing team that do not have direct security implications:
1. **Constructor allows empty governorList in RewardsDistributor.sol**
A governor plays an important role in RewardsDistr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: It's not guaranteed that users will receive the rewards
### Description
**Description:**
The users should believe in the contract owner to add the rewards after deployment, if the user stake waiting to receive a reward the owner could simply not add the rewards into the Staking contract.
The owner should... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Potential Mismanagement of Updated Withdrawal Vault Addresses
### Description
The issue is identified within the function [\_processWithdrawalProof](https://github.com/lidofinance/community-staking-module/blob/a898d045b63303294752d1a60ad9dfe8d8ba69ca/src/CSVerifier.sol#L308-L310) of the contract `CSVerifier... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: RubiconRouter.swapEntireBalance() doesn't handle the slippage check properly
### Description
_Submitted by Ruhum, also found by IllIllI, berndartmueller, eccentricexit, blackscale, and hansfriese_
The `swapEntireBalance()` function allows the user to pass a `buy_amt_min` value which is the minimum number of ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | overflow | true | false | ## High: functions revert if system is undercollateralized
### Description
The internal function `Treasury._loadSwapState()` calculates the `xNav` as follows:
```solidity
_state.xNav = _state.baseSupply.mul(_state.baseNav).sub(_state.fSupply.mul(_state.fNav)).div(_state.xSupply);
```
This is equivalent to:
```js
(b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | access-control | true | false | ## Gas: Use `bytes.concat()` instead of `abi.encodePacked()`, since this is preferred since `0.8.4`
### Description
**Issue Description** - The `abi.encodePacked()` function is used to concatenate multiple arguments into a byte array prior to `0.8.4`. However, since `0.8.4` the `bytes.concat()` function was introduced... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Bad debt may persist even after complete liquidation in Velo Vault due to truncation
### Description
When liquidating a user, if all their collateral is taken but it is not valuable enough to repay the entire loan they would be left with remaining debt. This is what is known as bad debt because there is no ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | false | false | ## Gas: pcvAddress and pcv stores the same value in storage and one can be removed
### Description
Within `BorrowerOperations.sol`, there are two variables (`pcvAddress` and `pcv`) that represent the same stored value. Since the casting `PCV(pcvAddress)` has no runtime impact, they can be considered redundant.
### Re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Auth2Step uses different modifiers from Auth
### Description
Solady's `Auth.transferOwnership` uses the `requiresAuth` modifier which checks `isAuthorized(msg.sender, msg.sig)`. However, in `Auth2Step.transferOwnership`, the `onlyOwner` modifier is used, which slightly differs from the original behavior as it ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: LpToken taint griefing
### Description
The [LpToken](https://github.com/ConicFinance/protocol/blob/7a66d26ef84f93059a811a189655e17c11d95f5c/contracts/LpToken.sol) cannot be minted or burned by a user if someone has transferred an amount of LpToken to them greater than `controller.getMinimumTaintedTransferAm... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Upgrade pragma
### Description
Using newer compiler versions and the optimizer give gas optimizations. Also, additional safety checks are available for free.
The advantages here are:
* **Contract existence checks** (>= 0.8.10): external calls skip contract existence checks if the external call has a return ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary require statement and return of bool value.
### Description
**Description**
Line 350, Function _stake() contains unnecessary require statement, since _payMe() always
either returns true or reverts. Also, there is no need in returning bool in function _stake and
stake(), since they can only return ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [06] There are currently no assurances that funds specified for operation are rightly matched
### Description
### Proof of Concept
Take a look at https://github.com/code-423n4/2024-03-zksync/blob/4f0ba34f34a864c354c7e8c47643ed8f4a250e13/code/contracts/ethereum/contracts/governance/Governance.sol#L168-L202
T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Contract registry has no entry for BRL
### Description
In [PR #8831](https://github.com/celo-org/celo-monorepo/pull/8831), the [`UsingRegistryV2` contract](https://github.com/celo-org/celo-monorepo/blob/63f75e33df2fe8f1a9005fce53de302d126fe2c3/packages/protocol/contracts/common/UsingRegistryV2.sol) provides va... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: An attacker can steal funds from multi-token vaults
### Description
## Handle
WatchPug
## Vulnerability details
The total balance should NOT be simply added from different tokens' tokenAmounts, considering that the price of tokens may not be the same.
https://github.com/code-423n4/2021-09-yaxis/blob/cf7d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Overestimation of Tokens Resulting in Oversupply
### Description
## Pool Math: Token Deposit Calculation
`pool_math::tokens_to_deposit` attempts to calculate the optimal deposit amounts `a_star` (for token A) and `b_star` (for token B) based on the current reserve ratios while adhering to user-specified maxim... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: If `repayLoanCallback` address doesn't implement `repayLoanCallback` try/catch won't go into the catch and will revert the tx
### Description
If `repayLoanCallback` address doesn't implement `repayLoanCallback` try/catch won't go into the catch and will revert the tx
### Impact
Lenders can stop borrowers f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Basket NFT have no name and symbol
### Description
_Submitted by Picodes, also found by cccz_
### Impact
The `Basket` contract is intended to be used behind a proxy. But the `ERC721` implementation used is not upgradeable, and its constructor is called at deployment time on the implementation. So all pro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `require()`/`revert()` statements should have descriptive reason strings
### Description
*There are 23 instances of this issue:*
https://github.com/debtdao/Line-of-Credit/blob/e8aa08b44f6132a5ed901f8daa231700c5afeb3a/contracts/modules/credit/EscrowedLine.sol#L64
https://github.com/debtdao/Line-of-Credit/blo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | false | ## High: Risk of unlimited slippage in NestedDca swaps
### Description
The swaps executed by the `NestedDca` contract from Uniswap V3 allow unlimited slippage because the slippage protection is assigned to a memory variable that is not passed on to the next function executing the swap.
When executing swaps on Uniswap... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Use a more recent version of solidity
### Description
- Use a solidity version of at least 0.8.2 to get simple compiler automatic inlining.
- Use a solidity version of at least 0.8.3 to get better struct packing and cheaper multiple storage reads.
- Use a solidity version of at least 0.8.4 to get custom errors... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Protocol Insolvency Risk Due to Lack of On-Chain Oracle
### Description
The protocol’s solvency relies on an off-chain `backendSigner` to determine the loan principal (`offerAmount`) without any on-chain verification of collateral value or an on-chain “unhealthy position” liquidation path. As a result, the pr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: TRST-L-1 createUniswapRangeOrder() does not validate direction for hedge
### Description
**Description:**
`_createUniswapRangeOrder()` is an internal function that receives parameters for hedge
action, including lower/upper tick and direction. It can be called from `hedgeDelta()`, in that
case parameters are... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Validation | true | true |
<https://github.com/code-423n4/2024-03-ondo-finance/blob/be2e9ebca6fca460c5b0253970ab280701a15ca1/contracts/ousg/rOUSG.sol#L586-L606>
<https://github.com/code-423n4/2024-03-ondo-finance/blob/be2e9ebca6fca460c5b0253970ab280701a15ca1/contracts/ousg/rOUSG.sol#L624-L640>
### Impact
The `BURNER_ROLE` cannot burn tokens ... | Code4rena | 5 | Ondo Finance |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [05] Journal can't be easily reset
### Description
Nibiru's journal implementation lacks the `reset()` function present in go-ethereum. While both implementations have `newJournal()`, go-ethereum specifically includes `reset()` for performance optimization:
Note that the optimization in this case is the fact ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Non-assembly method available
### Description
`assembly{ id := chainid() }` => `uint256 id = block.chainid;`
*There is 1 instance of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | flash-loan | true | false | ## Medium: Allowing the execution of more than a single `sunrise` function when enough time has passed is really dangerous
### Description
It is possible to advance multiple seasons if enough time passes. That can lead to serious problems for the protocol
### Impact
Medium, the scenario where the sunrise function is ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: RocketDAONodeTrustedUpgrade - upgrade does not prevent the use of the same address multiple times creating an inconsistency where getContractAddress returns outdated information ✓ Fixed
### Description
When adding a new contract, it is checked whether the address is already in use. This check is missing when ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Locks unlocking at the nexttimestamp will not trigger noactivelocks
### Description
The Opal protocol implements a governance mechanism that allows the users to vote on the weight of gauges. This is facilitated in the `_voteForGaugeweight()` function. This function imposes three checks on the `unlockTime` o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: The checkChainlinkFulfillment Modifier Will Revert for All Requests Whose Callback is not the Calling Contract
### Description
A Chainlinked contract stores a mapping of `unfulfilledRequests`. The modifier `cancelChainlinkRequest()` checks this mapping to ensure the `msg.sender` is the Oracle of the request. T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | timing | true | false | ## Medium: `Goldigovernor._getProposalState()` shouldn't use `totalSupply`
### Description
In `_getProposalState()`, it uses `Goldiswap(goldiswap).totalSupply()` during the comparison.
```solidity
function _getProposalState(uint256 proposalId) internal view returns (ProposalState) {
Proposal storage proposal = ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing burnAmount from MigrationComplete event
### Description
Insufficient data to show a user how much money was burnt from calling the `burnLockedUSDC()` on the contract. The actual amount of USDC to be burnt is calculated as the minimum of the provided burn amount (L2 total supply) and the USDC balance of... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary `start` parameter in `migrateUserStakes`.
### Description
**Description**
Perpetual TokensFarm.sol, Perpetual TokensFarmSDK.sol: function migrateUserStakes().
Providing this parameter is unnecessary since it must always be equal to the storage variable 'lastUserMigrated . In order to simplify the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | storage | true | false | ## High: LootBox - Unprotected selfdestruct in proxy implementation
### Description
When the `LootBoxController` is deployed, it also deploys an instance of `LootBox`. When someone calls `LootBoxController.plunder()` or `LootBoxController.executeCall()` the controller actually deploys a temporary proxy contract to a d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Unnecessary Validator Activation Delay For FullDeposit Minipools
### Description
Minipools created with an initial node deposit of **32 ETH** (MinipoolDeposit.Full, a.k.a **fullDeposit**) do not need to delay staking by some **scrubPeriod** in order to mitigate exploits associated with bad withdrawal credentia... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: UNNECESSARY VALIDATION
### Description
It was identified that the `addSafeguard` function in the `Saferoot` contract employs unnecessary validation to check if the `currentKey` is already used or not. However, because the `currentKey` is increased every time a safeguard is added, this condition is always true.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Aspects to Consider Regarding the `Multicall` Contract to be Aware Of
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> Acknowledged
**Description:**
* The function `blockhash()` will return 0 for a block number older than 256 from the curre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: `sDaiStrategy` can be bricked by a single attacker, requiring manual intervention to resolve
### Description
**Severity**
**Impact:** Medium, since the contract can be bricked, and this is most easily achieved when minimal funds are at risk
**Likelihood:** Medium, since this can be easily achieved with mi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: LpWrapper deposits and withdraws will be bricked if Velodrome gauge is killed.
### Description
Within the LpWrapper contract, all withdraws make a withdraw and deposit back in Core.sol. The problem is that in case the corresponding Velodrome gauge is killed, it will not allow for any new deposits to happen.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inefficient activation of boosts if `BGT`'s `activateBoostDelay` is changed
### Description
The `Staker._tryToBoost()` function calls `BGT.activateBoost()` and `BGT.queueBoost()` only when more than 8191 blocks have passed since the last boost.
While the `activateBoostDelay` parameter in `BGT` is currently s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Same comments for ERC20Distribution and ERC20DistributionNative
### Description
**Description**
There are instances in the ERC20Distribution contract where the comments correspond to the ERC20Distribution Native, such as comments are L272 and L273, they mention ether while it should be the fiat token.
**Reco... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Minimum amount to stake might not be equal to 1 token.
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
TestStake::stake()#1896.
Function 'stake() contains validation with the following error: "Minimum Stake Amount is 1,"
which implies that a minimum of 1 token must be staked... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Refactor internal function to avoid unnecessary SLOAD
### Description
The internal functions below read storage slots that are previously read in the functions that invoke them. We can refactor the internal functions so we could pass cached storage variables as stack variables and avoid the extra storage reads... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | timing | false | false | ## Low: Mismatching variable naming for `Metadata.depositBlock`
### Description
Based on [the inline doc ](https://github.com/USD-Pi-Protocol/contract/blob/main/contracts/lib/STBL_Structs.sol#L26-L27)of `Metadata.depositBlock` implies it saves the block number when the deposit was created, but in reality, this variabl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: Adding NFTS with AssociationType ORDERED or PRIMARY may cause overwriting
### Description
***Note: Prior to this audit, a group of wardens added test coverage. While auditing was not the purpose of the testing phase, relevant and valuable findings reported during that timeframe were eligible to be judged. A... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | true | false | ## High: Deletion does not delete all values
### Description
**Severity**: High
**Status**: Resolved
**Description**
In LibQuorum.sol, the function `pruneQuorums()` can be problematic on line: 143
That's because `quorumSignatureSenders` is a mapping containing a struct which is containing a mapping. And deleting ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Truncation in casting can lead to a founder receiving all the base tokens
### Description
The initialize function of the `Token` contract receives an array of `FounderParams`, which contains the ownership percent of each founder as a `uint256`. The initialize function checks that the sum of the percents is ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Basket becomes unusable if everybody burns their shares
### Description
_Submitted by kenzo_.
While handling the fees, the contract calculates the new `ibRatio` by dividing by `totalSupply`. This can be 0 leading to a division by 0.
#### Impact
If everybody burns their shares, in the next mint, `totalSup... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | true | false | ## High: Users can fail to unstake and lose their deserved ETH because malfunctioning or untrusted derivative cannot be removed
### Description
Calling the following `SafEth.adjustWeight` function can update the weight for an existing derivative to 0. However, there is no way to remove an existing derivative. If the e... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.