text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
in a follow up patch i would like to see this controller using self driver run and self trans
|
[
0
] |
this is going to start getting ridiculous at some point.
|
[
1
] |
huh can we just pass this for that argument then or do we really need a dummy child
|
[
0
] |
mox should be down a section
|
[
0
] |
I have never seen this before, what does the asterisk do here?
|
[
1
] |
are you sure this block of code should not be executed even if net ids is an empty set
|
[
0
] |
@nemvar told me to use deadsay, make up your goddamn minds
|
[
1
] |
this block is redundant and should be removed
|
[
0
] |
the character here is not necessary and cold potentialy because problems
|
[
0
] |
This feels kinda clumsy, especially when doing async. Thank for the support however.
|
[
1
] |
i still do not like this description p you are generating a sysroot that can be patched over extracted prebuilt package contents to create a complete sysroot
|
[
0
] |
Damn, this PR broke column pinning: https://deploy-preview-7857--material-ui-x.netlify.app/x/react-data-grid/column-pinning/ https://user-images.githubusercontent.com/13808724/219105465-240a5454-e12f-44d5-a5a0-5080367322a1.mov
|
[
1
] |
please get the retval from the keyvals dict
|
[
0
] |
and this check is useless because you used it before to move to this method
|
[
0
] |
it kindasortamaybenotreally makes sense on the terms of "this proc is spawned off the main thread" but why the fuck does it runtime instead of failing after realizing the src has changed, god knows
|
[
1
] |
Because the early Unix creators thought saving characters off names was worthwhile (see also `creat()`), which in retrospect looks ridiculous.
|
[
1
] |
apologies is this has been clarified in previous review cycles what would be the rational of this unusual approach to inheritance is that because you need to cherry pick only specific capabilities of the base class whereas in all the other case you would be ok with the dynamically built base classes
|
[
0
] |
took me a minute to realise what the scheduler driver is an eg filterscheduler might be nice for the slow of brain
|
[
0
] |
info normal status messages showing measurable units of positive work passing through under normal functioning of the system should not be so verbose as to overwhelm real signal with noise should not be continuous i m alive messages how can a race be a normal functioning of the system the race should be killed or the log trace is useless and should only bug the developer to do something about it
|
[
0
] |
use die instead of echo exit
|
[
0
] |
no jsdoc here or anywhere
|
[
0
] |
i can t find vmruntime getruntime requestconcurrentgc method i can only find vmruntime getruntime concurrentgc method is it typo what i request is that gc will not block the caller thread if we call vmruntime getruntime concurrentgc or runtime getruntime gc it will block the caller thread so i want to reuse the daemon thread to do gc so that caller thread will not be blocked
|
[
0
] |
this looks the firewall rules table
|
[
0
] |
tried restart the computer. The same problem. It looks like the XCH pending is lost forever. It is just ridiculous that such a minimal mistake like a transaction with zero fee will just banish the XCH forever
|
[
1
] |
Damn it, so close. I had `OutboxMessageSavedEvent` :grin:
|
[
1
] |
size t you passed in a uint t
|
[
0
] |
why did you change ipv icmp
|
[
0
] |
device class is a std string will fix brace style
|
[
0
] |
not working but i have a dirty hack for it
|
[
0
] |
holy shit. please suggest a name.
|
[
1
] |
so you have removed the pinctrl for gpio from gpio keys but now it should be put here in the btmrvl node
|
[
0
] |
Oh, damn. I often make spelling mistakes. :)
|
[
1
] |
agree unicode could shoot
|
[
0
] |
silly nit per hacking these need to be double quotes also the summary goes on the first line check the convention
|
[
0
] |
meganit alert i wonder if there would be any value in refactoring the block l l into a function the need of mocks would still hurt
|
[
0
] |
Goddamnit the one time I don't review a PR and shit like this gets through.
|
[
1
] |
this replicates drm mode copy drm mode duplicate
|
[
0
] |
style nit it should be empty issuers or empty x certificate array
|
[
0
] |
looks kind of ugly from code design stand point please align indentation in next line so that the first character is below the first character of prevent
|
[
0
] |
stop talking implemenation
|
[
0
] |
gross
|
[
0
] |
Really, this is slow on such a machine? sounds bizarre, but sure...
|
[
1
] |
Yes, I was talking nonsense yesterday. I will do some test later this day.
|
[
1
] |
I suspect we can detect if ffmpeg's stream parsing has been cut short due to a still frame thus giving nonsense fps. Then we can just set that the fps is not known instead of some silly stuff.
|
[
1
] |
Damn [apparently omitempty doesn't work for structs](https://github.com/golang/go/issues/11939). golang strikes again
|
[
1
] |
this may be a dumb question but should not this be metadata key self metadata key value self metadata value
|
[
0
] |
useless spaces
|
[
0
] |
It is ridiculous to take so much time to merge this. I am trying to get valueChanges for checkbox but it is not working. We are tired of hacking stuff...
|
[
1
] |
please use die instead of rolling your own or return see below
|
[
0
] |
The shitcurity buff the station deserves.
|
[
1
] |
there he is again why have you got q in your head
|
[
0
] |
Doesn't look like it was shipped out as of 2.2.6 either. The fixed code doesn't appear in 2.2.8. I know code quality is extremely important, but the time to release fixes seems a little ridiculous.
|
[
1
] |
should we then kill root helper argument here too
|
[
0
] |
@hramos you closed my issue, and I ask you why, you can't answer me, you are a stupid rubbish, I fuck your mother deeply!You don't understand a little of manners! you are son of a bitch!
|
[
1
] |
continuing comment from left side l implement this in each driver instead
|
[
0
] |
another stupid compiler question is this always in ssa form if vreg can have different value from different incoming edges is this always set to phi instruction
|
[
0
] |
arg is a pretty shitty name, not really obvious that it's a gun. try making it capital letters or something (if the first letter is a capital letter, add /improper in front of the name)
|
[
1
] |
done and remove all other unnecessary no delete
|
[
0
] |
What even, how does shit like this even happen.
|
[
1
] |
these mocks are the same for all tests and should be moved to the class level
|
[
0
] |
I am so fucking stupid [2]
|
[
1
] |
i agree that looks like a comment i would write myself it feels stupid to remove it from this patch then add it back in the next patch but it is the right thing to do
|
[
0
] |
because I don't want security to have access to an open uplink unless a traitor seriously fucks up and leaves it open for them.
|
[
1
] |
I am having problems with ng2-select. I can't drop its directive into multiple modules now in rc5. It was a good library for making nice multi-select dropdowns but now it's ridiculous that it can't be used twice in the application.
|
[
1
] |
Avoid posting screenshots with text information. It is ridiculous. Also it blocks searching for similar problems. Your problem is highlighted here: > `debug_build_guard` Google for that.
|
[
1
] |
in current ps db max attempts is useless
|
[
0
] |
why is pidof being used a process can change it is own name and because pidof to return their own pid at first glance without understanding the use case this feels dangerous
|
[
0
] |
Can the animal be made friendly to the quest giver instead? Because right now it looks like after finishing the mission the animal will just run off which will look a bit ridiculous.
|
[
1
] |
these are hardcoded here and in the zone functions put them all in one place
|
[
0
] |
I'm 90% sure this shouldn't spawn(). Also there's no check to make sure you're not already brainjacking so you can just spam the shit out of this.
|
[
1
] |
from operational point of view we can say that subnet without a network is useless i will change thanks
|
[
0
] |
shoot it failed times in a row let s revert this
|
[
0
] |
> OR... > > We could leave it uncapped for this weekend for shits and giggles. Insanely based tbh, but unwise.
|
[
1
] |
Wacky stuff. Fix seems fine.
|
[
1
] |
Damn you `on`Links!!!
|
[
1
] |
i would put a colon here and ditto for the rest of the procedures
|
[
0
] |
how about we expose this publicly this is a pretty useful api
|
[
0
] |
this autoclicker is very gay
|
[
1
] |
this is a constant that can come out of the loop if you are trying to reduce garbage
|
[
0
] |
got the bastard, will comment more where it s more visible for future reference
|
[
1
] |
no but if you did split it out i would happily that one whereas i am too big a coward to the rest of this alternatively you might want to add steps to reproduce to the checkin comment if you have them
|
[
0
] |
more kittens to die
|
[
0
] |
i think seamicro vendor pxe vendor should not be attributes of this class
|
[
0
] |
i think we need to kill server even if tests are failed
|
[
0
] |
function name and argument name sucks
|
[
1
] |
@lateralusX lgtm. I made an issue https://github.com/dotnet/runtime/issues/53607 for us to think about providing components a simple mechanism to register qcalls. Because the boilerplate to add a couple of icalls is a bit ridiculous.
|
[
1
] |
no, canconsume literally just checks if you can eat it the rest of the shit for that is handled in the pill code
|
[
1
] |
networkid should be network id
|
[
0
] |
small nit please remove this white space
|
[
0
] |
nit not required driver info is always a dict
|
[
0
] |
i think you mean vmwareapisession call method
|
[
0
] |
this cleans up the uart start stop such that the uart does not false trigger and deliver spurious characters that messes up the signature
|
[
0
] |
Unfuck our `.gitattributes` tbqh fam
|
[
1
] |
we need a bit nonce so that you are guaranteed to have a large integer here you do not want implementations to not care what they put in here and end up with ridiculously small values this is a security api and need to clearly define what is needed
|
[
0
] |
why not enum class our style prefers it over the obsolete c enums
|
[
0
] |
nit make this into constexpr offset t kwidth u
|
[
0
] |
please use self logger error instead of print
|
[
0
] |
w is a warning that a file should end in a blank newline h is the hacking rule about always having a single char summary of all docstrings something i personally think is silly and since nova also ignores it l i figured we could as well
|
[
0
] |
What about "auto-update" instead of electric? I agree wholeheartedly that "electric" is a rubbish descriptor and since it hasn't been used in the xml file before now its the right time to choose the better name.
|
[
1
] |
please check that the error type is correct kinvalidpassword
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.