text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
ided PR, this man was clearly killed by a true Lean Lunatic
|
[
1
] |
typo ass ymetric made my morning also slightly confused as to why there is not a asymmetric constant defined in the secrettype class
|
[
0
] |
can you remove this function i do not like i prefer that your remame the function has action plan finished
|
[
0
] |
One attack AT BEST. Don't use it for a melee weapon, ya shits.
|
[
1
] |
this thread is an infinite loop should we kill it at teardown or somewhere else
|
[
0
] |
It's better to forbidden use required field in Thrift or ProtocolBuffer. We could not remove it in the future and there will be a lot of rubbish code. For example, version hash, schema hash.... It is too terrible!!!!!
|
[
1
] |
Darn. I was too slow.
|
[
1
] |
we should validate the id i tag obj max tag length
|
[
0
] |
rs fr to rs fr are still clobbered by an external c call right
|
[
0
] |
nit you are initialising this as an empty tuple not a list as the comment suggests the type should be
|
[
0
] |
Why is our code so shitty :(
|
[
1
] |
@Clusterfack why the fuck did you merge this?
|
[
1
] |
Crap. And I LGTMed that? :(
|
[
1
] |
please use mock instead of mox
|
[
0
] |
this is the only call site where the cached vm ref might not be the right one to use eliminate a possible bug and just pass in the rescue vm ref as a parameter
|
[
0
] |
you mean this enabled opt cfg boolopt enabled default false and so on
|
[
0
] |
why to print and why just this why not just use a logger
|
[
0
] |
on a windows machine the above would stick a backwards slash in the middle if all you are trying to do is return secret ref payload to be used in a url could you just do join secret ref payload or something similar
|
[
0
] |
perhaps a dumb question but can this be done on a background thread perhaps return a promise
|
[
0
] |
s insepctorbasetest inspectorbasetest
|
[
0
] |
kill basically validates the pid that s a smart way to validate a pid i will update makefile with kill in a separate cl there s another case here though where the master could be dead but the pid is valid and does not belong to the master maybe check the command line as well or cwd of the pid fds etc i believe that it should be considered as unhealthy status of twistd for example if make status returns for a process running but unhealthy then puppet or most of system management tool would believe that it is not running and the following etc init d buildbot start would fail at the following check we could also update the above python check function but i believe that the example case you provided should be handled by a separate process checking for the health of a service the pid is valid and does not belong to the master in other words etc init d status should return running if a process is running for the service either it is healthy or not if make status should not be limited to the usage of etc init d buildbot then i would suggest to have another make target for health checking however once buildbot is migrated to service manager this makefile will no longer be used
|
[
0
] |
Do not comment like this, it fucks up conflict solving. Also why not just remove the code? And the icons?
|
[
1
] |
why not just use the ids here names do not need to be unique in neutron
|
[
0
] |
imho curly braces look useless here if you write the code in one line
|
[
0
] |
remove savanna please here by climate
|
[
0
] |
this method name does not look suggestive to me what about check user has access to subtree
|
[
0
] |
the heck is with this spacing?
|
[
1
] |
remove service ignore errors
|
[
0
] |
this seems to be a different bug if key getformat returns non null key getencoded should return non null as well
|
[
0
] |
ocd here but why the heck is there extra spaces in front of your copy right
|
[
0
] |
n jsonutils dumps must be used instead of json dumps
|
[
0
] |
damn does this do nothing then lol
|
[
1
] |
nit one day someone pep maybe is going to moan that the swift imports should come after the builtin lib imports
|
[
0
] |
dumb question where are these entry points currently loaded
|
[
0
] |
get a friend (good luck) 2. take drug delivery mission from Don Faggot 3. get your friend to finish before you do 4. ???? 5. PROFIT
|
[
1
] |
please remove this statement totally pmanager py itself is a big hack which is going to be thrown away in the near future
|
[
0
] |
I don't know how is that faggot? Enough cocks **for you**?
|
[
1
] |
just to confirm asynchronous destroy is ok in vd
|
[
0
] |
klass datetime
|
[
0
] |
this presumes that it ends in bz can t we just strip off the extension dest basename basename rpartition
|
[
0
] |
in that case you might as well have dptr as a uchar
|
[
0
] |
should there not be a setappdata toolsmodule draw nullptr here
|
[
0
] |
please choose services reconfiguration thread because thread duration is more than hours and all job could be aborted
|
[
0
] |
do we want to die if this fails
|
[
0
] |
root helper utils get root helper
|
[
0
] |
I agree with renaming all the `tri/foo.py` modules to `tri/_foo.py` (`tri/__init__.py` already reexports everything anyways). I'm not sure it's possible to have a proper deprecation for `from matplotlib.tri.tripcolor import tripcolor` (without ridiculous hacks)?
|
[
1
] |
delete this guy if the upload hook complains about revbumps use no verify
|
[
0
] |
it shits on material balance by making it so the best material available (in literaly everything) is an atmos thing you can just keep producing
|
[
1
] |
@kiminuo so next time I'm not fixing usings in pull requests. It is ridiculous to waste time on that if the "project" declines to automate it \U0001f937\u200d\u2642\ufe0f
|
[
1
] |
useless
|
[
0
] |
its far too gay for me, could you tone it down mr justoos?
|
[
1
] |
oops changed to set this mock verifier to a signedexchangehandlertest s member field
|
[
0
] |
why this change it is not a h violation it is h
|
[
0
] |
get better nomenclature wtf!
|
[
1
] |
Oh boy... this is a ridiculously big bug that was introduced in #5782 because we never tested with asymmetric kernels. `convolve` implements the wrong definition of convolution now: the kernel is not reversed, but it should be! I will work on a fix.
|
[
1
] |
also here the numeric argument to the oustringbuffer initialiser is the capacity
|
[
0
] |
What a weird type. :P
|
[
1
] |
i still think i change is not relevant here and should be removed
|
[
0
] |
useless line return between moreover and here below
|
[
0
] |
I worked around by passing a versioning variable and keeping track of versioning info via published packages. But it is completely ridiculous and incredible that this has been open and known for over a year
|
[
1
] |
>Are you kidding me?! How the hell?!
|
[
1
] |
ha i won get error as below debug nova filters req b e b bc admin admin filter aggregateimagepropertiesisolation returned host s from pid get filtered objects opt stack nova nova filters py error oslo messaging rpc dispatcher req b e b bc admin admin exception during message handling cpu allocation ratio trace oslo messaging rpc dispatcher traceback most recent call last trace oslo messaging rpc dispatcher file usr local lib python dist packages oslo messaging rpc dispatcher py line in dispatch and reply trace oslo messaging rpc dispatcher executor callback trace oslo messaging rpc dispatcher file usr local lib python dist packages oslo messaging rpc dispatcher py line in dispatch trace oslo messaging rpc dispatcher executor callback trace oslo messaging rpc dispatcher file usr local lib python dist packages oslo messaging rpc dispatcher py line in do dispatch trace oslo messaging rpc dispatcher result func ctxt new args trace oslo messaging rpc dispatcher file usr local lib python dist packages oslo messaging rpc server py line in inner trace oslo messaging rpc dispatcher return func args kwargs trace oslo messaging rpc dispatcher file opt stack nova nova scheduler manager py line in select destinations trace oslo messaging rpc dispatcher filter properties trace oslo messaging rpc dispatcher file opt stack nova nova scheduler filter scheduler py line in select destinations trace oslo messaging rpc dispatcher filter properties trace oslo messaging rpc dispatcher file opt stack nova nova scheduler filter scheduler py line in schedule trace oslo messaging rpc dispatcher filter properties index num trace oslo messaging rpc dispatcher file opt stack nova nova scheduler host manager py line in get filtered hosts trace oslo messaging rpc dispatcher hosts filter properties index trace oslo messaging rpc dispatcher file opt stack nova nova filters py line in get filtered objects trace oslo messaging rpc dispatcher list objs list objs trace oslo messaging rpc dispatcher file opt stack nova nova filters py line in filter all trace oslo messaging rpc dispatcher if self filter one obj filter properties trace oslo messaging rpc dispatcher file opt stack nova nova scheduler filters init py line in filter one trace oslo messaging rpc dispatcher return self host passes obj filter properties trace oslo messaging rpc dispatcher file opt stack nova nova scheduler filters core filter py line in host passes trace oslo messaging rpc dispatcher filter properties trace oslo messaging rpc dispatcher file opt stack nova nova scheduler filters core filter py line in get cpu allocation ratio trace oslo messaging rpc dispatcher cpu allocation ratio trace oslo messaging rpc dispatcher file opt stack nova nova scheduler filters utils py line in aggregate values from key trace oslo messaging rpc dispatcher aggregate vals set aggr metadata key name for aggr in aggrlist trace oslo messaging rpc dispatcher file opt stack nova nova scheduler filters utils py line in genexpr trace oslo messaging rpc dispatcher aggregate vals set aggr metadata key name for aggr in aggrlist trace oslo messaging rpc dispatcher keyerror cpu allocation ratio trace oslo messaging rpc dispatcher error oslo messaging drivers common req b e b bc admin admin returning exception cpu allocation ratio to caller error oslo messaging drivers common req b e b bc admin admin traceback most recent call last n file usr local lib python dist packages oslo messaging rpc dispatcher py line in dispatch and reply n executor callback n file usr local lib python dist packages oslo messaging rpc dispatcher py line in dispatch n executor callback n file usr local lib python dist packages oslo messaging rpc dispatcher py line in do dispatch n result func ctxt new args n file usr local lib python dist packages oslo messaging rpc server py line in inner n return func args kwargs n file opt stack nova nova scheduler manager py line in select destinations n filter properties n file opt stack nova nova scheduler filter scheduler py line in select destinations n filter properties n file opt stack nova nova scheduler filter scheduler py line in schedule n filter properties index num n file opt stack nova nova scheduler host manager py line in get filtered hosts n hosts filter properties index n file opt stack nova nova filters py line in get filtered objects n list objs list objs n file opt stack nova nova filters py line in filter all n if self filter one obj filter properties n file opt stack nova nova scheduler filters init py line in filter one n return self host passes obj filter properties n file opt stack nova nova scheduler filters core filter py line in host passes n filter properties n file opt stack nova nova scheduler filters core filter py line in get cpu allocation ratio n cpu allocation ratio n file opt stack nova nova scheduler filters utils py line in aggregate values from key n aggregate vals set aggr metadata key name for aggr in aggrlist n file opt stack nova nova scheduler filters utils py line in genexpr n aggregate vals set aggr metadata key name for aggr in aggrlist n keyerror cpu allocation ratio n
|
[
0
] |
@dimagi/team-commcare-hq note that this adds instrumentation to one of our prod workers. if anything goes wacky during deploy this would be a good place to look (but we think it's quite stable/tested so aren't expecting anything notable)
|
[
1
] |
this is fucking awful dear god why
|
[
1
] |
The description feels a bit weird. Also, fwiw, it allows to play sounds as well.
|
[
1
] |
i think calling os svc upstart will be a mistake as fedora images will be systemd based should os svc upstart be named os svc daemon or something
|
[
0
] |
are we sure nothing is relying on this monkey patch call being executed on import of cmd
|
[
0
] |
this is going to crash on many res txtatr because only or so have pautoset
|
[
0
] |
why remove the execute only this iser py lvm py linuxscsi py connector py and executor py
|
[
0
] |
the execn flags should be removed now
|
[
0
] |
is it sensible to use if defined google chrome build else endif so that the four chrome interfaces are only supported in google chrome builds and that the one chromium interface is only supported in chromium builds if not why not
|
[
0
] |
Does this actually work? Because you cant click when holding alt
|
[
1
] |
we should remove buildinfo in build dir
|
[
0
] |
Idunno I don't fucking freeze to death during my sleep
|
[
1
] |
I think it shouldn't be printed, already too much various crap in that string.
|
[
1
] |
for completeness you should also have fatal and trace
|
[
0
] |
Consider at the very least keeping `-Wno-unused-result`, because that's a pain in the ass and it doesn't help much in the context of where it appears.
|
[
1
] |
brant is this going to freak out your compliance friends
|
[
0
] |
oh damn it was GenericSSMParameterImage, not GenericSsmParameterImage
|
[
1
] |
remove this comment too btw the german oder was not translated to english or
|
[
0
] |
> Calling Path* function is too slow... What the hell are you talking about? Are you calling these functions inside a tight loop? Have you done performance monitoring? No, so please stop that nonsense. The function does not take 10 seconds to execute, and shlwapi is already loaded in memory when the shell is running.
|
[
1
] |
nit s audible players count audible players count
|
[
0
] |
i assume this needs to be a uint t so that you get compiler warnings if you pass in a plain by accident
|
[
0
] |
thanks p draig i will address those nits
|
[
0
] |
useless parantheses
|
[
0
] |
please initialize in the ctor also again is sync feature enabled
|
[
0
] |
Running integration tests in parallel is something that is 100% desirable in the future due to their relatively high cost currently so I feel this is a crappy bandaid at best.
|
[
1
] |
i think we can get rid of this normal behavior value id as it is not used now that the runtime flag is gone
|
[
0
] |
i would agree i first implemented killprocessgroup by calling the syscalls directly which i think makes sense kill should allow you to send any signal but not to kill any process the options here are doing that make killprocessgroup independently of process kill and then fixing process kill or fixing process kill and make it safe to be called with a negative pid maybe add a boolean kill process group to kill what do you think
|
[
0
] |
why changing the boolean condition here is self protocol fc valid
|
[
0
] |
the ultimate bikeshedding the semi colon is useless
|
[
0
] |
"/obj/item/projectile/energy/megabuster" Maybe they added it to text2path now that it just returns the path if it's given a path. But otherwise it breaks shit.
|
[
1
] |
is gn helpers py supposed to work fromgnstring true fails with gnexception raised
|
[
0
] |
can you tell the uefi people to please clean up their white space
|
[
0
] |
i am fine pulling this bit out and moving it over to a different bug just shoot me the new bug id
|
[
0
] |
make sure this doesnt lag for fuckin emps
|
[
1
] |
make this a clothing flag or something instead. lists like this suck.
|
[
1
] |
> I think I know whats happened with tests 2 and 5 of group 2. > > In test 2 you need to update the first row in the table to have A=0.2 and phi=1.5 otherwise it gives rubbish > In test 5, you have the tiled by option set to Run instead of group/pair (its above the plot) Yes, probably just user error. I don't know what I'm doing and am losing track easily.
|
[
1
] |
~~talking mad shit for someone who coulda been blown out of the sky by first last in several missions~~ I get what she's trying to do, but to me it's unnecessary
|
[
1
] |
i think you can use the return value of self patchobject to avoid having to import mock and create a mock object yourself statvfs mock self patchobject os statvfs autospec true statvfs mock return value f flag os st nosuid
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.