id
stringlengths
22
25
commit_message
stringlengths
137
6.96k
diffs
listlengths
0
63
derby-DERBY-3425-08010c53
DERBY-3425: J2EEDataSourceTest throws away stack trace for many errors Preserve stack trace on error by throwing the original exception instead of using fail() to report the error. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628746 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3427-ce68ae05
DERBY-3427: setting transaction isolation level to read committed raise ERROR X0X03: Invalid transaction state - held cursor requires same isolation level Made the network server use the requested holdability when preparing calls. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634206 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DRDAStatement.java", "hunks": [ { "added": [], "header": "@@ -41,7 +41,6 @@ import java.lang.reflect.Array;", "removed": [ "import org.apache.derby.iapi.jdbc.EngineConnection;" ] }, { "added":...
derby-DERBY-3428-5a6acbff
DERBY-3428: Doing a replication failover should shutdown the database and the connection should no longer be available The shutdown exception needs to be a StandardException in order to shut down the database (SQLException does not work) After failove, unfreeze the database before trying shutdown. Contributed by V Narayanan git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@632369 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java", "hunks": [ { "added": [ " * @throws StandardException 1) If the failover succeeds, an exception is", " * 2) If a failure occurs during network", " * @thr...
derby-DERBY-3430-a3203bfb
DERBY-3430 Inconsistency in JDBC autogen APIs between Connection.prepareStatement(...) and Statement.execute(...) Change prepareStatement to treat empty arrays for columnNames or columnIndexes as NO_GENERATED_KEYS git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629578 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java", "hunks": [ { "added": [ "\t\t\t(columnIndexes == null || columnIndexes.length == 0)" ], "header": "@@ -1213,7 +1213,7 @@ public abstract class EmbedConnection implements EngineConnection", ...
derby-DERBY-3431-7bceacaa
DERBY-3431: DatabaseMetaData.getConnection returns the wrong connection when using connection pooling. Added another tests for this issue in DatabaseMetaDataTest. Only the test for embedded is enabled, as the client driver has a bug. Also note that the embedded driver has a related bug, but it is not exposed by this test (see J2EEDataSourceTest.testConnectionLeakInDatabaseMetaData instead). Patch file: derby-3431-1b-test_repro.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@658181 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3431-8594dfd3
DERBY-3431: DatabaseMetaData.getConnection returns the wrong connection when using connection pooling. Added a test case exposing the bug where DatabaseMetaData.getConnection returns a reference to a connection it should not publish. Note that the test is disabled, because the bug is still at large. Patch file: derby-3431-2a-test.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@650814 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3431-ef81d0e4
DERBY-3431: DatabaseMetaData.getConnection returns the wrong connection when using connection pooling. Introduced a logical database metadata object in the client driver. This object is tightly associated with the logical connection, instead of the underlying physical connection. It will only publish a reference to the logical connection. Added regression tests. Note that one of the tests fails for embedded, which appers to have a similar bug to what the client driver had. Patch file: derby-3431-3b-client_logical_metadata.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@662383 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/LogicalConnection.java", "hunks": [ { "added": [ " /**", " * Logical database metadata object created on demand and then cached.", " * The lifetime of the metadata object is the same as this logical", ...
derby-DERBY-3432-1bac3f3a
DERBY-3432: Move replication code from org.apache.derby.impl.services.replication to o.a.d.i.store.replication Contributed by Jorgen Loland. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634706 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/store/replication/master/MasterFactory.java", "hunks": [ { "added": [ " org.apache.derby.iapi.store.replication.master.MasterFactory" ], "header": "@@ -1,7 +1,7 @@", "removed": [ " org.apache.derby.iap...
derby-DERBY-3438-89e0c080
DERBY-3438: Allow SQL query text to be null in StatementKey. Patch file: derby-3438-1a-allow_sql_null.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@631217 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/stmtcache/StatementKey.java", "hunks": [ { "added": [ " * @throws IllegalArgumentException if {@code schema} is {@code null}", " if (schema == null) {", " throw new IllegalArgumentException(\"...
derby-DERBY-3446-142b9afe
DERBY-3446: Make ResultSet.getStatement return the correct statement when created by a logical statement. Made LogicalStatementEntity constructor set itself as the statement owner in am.Statement, and ResultSet return the owner of the creating statement if set. If not set, the statement itself will be returned (as before). Patch file: derby-3446-2c_rs_getstatement_alternative.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@630784 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/LogicalStatementEntity.java", "hunks": [ { "added": [ "abstract class LogicalStatementEntity", " implements java.sql.Statement {" ], "header": "@@ -46,7 +46,8 @@ import org.apache.derby.shared.common.s...
derby-DERBY-3446-d798bb11
DERBY-3446: Make ResultSet.getStatement return the correct statement when created by a logical statement. Added regression test for the bug in JDBC statement caching environments. Patch file: derby-3446-3a-stmtpool_test.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@673327 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3448-04014b20
DERBY-3448 - backing out revision 636829, it doesn't actually build. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@636892 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/mailjdbc/utils/DbTasks.java", "hunks": [ { "added": [ "import java.util.Properties;" ], "header": "@@ -37,6 +37,7 @@ import java.sql.SQLException;", "removed": [] }, { "added": [ ...
derby-DERBY-3448-58a99b78
DERBY-3448 ; adjusting re-setting of auto-commit state and isolation level. Reinstating modifications of revision 636829, plus additional changes to enable build. Patch contributed by Manjula Kutty. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@638077 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/mailjdbc/tasks/Backup.java", "hunks": [ { "added": [ "public class Backup extends Thread{", "\tprivate Connection conn = null;", "\t", "\tpublic Backup(String name)throws Exception{", "\t\t...
derby-DERBY-3448-63e167ec
DERBY-3448 : adjusting re-setting of auto-commit state and isolation level. Patch contributed by Manjula Kutty. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@636829 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/mailjdbc/utils/DbTasks.java", "hunks": [ { "added": [], "header": "@@ -37,7 +37,6 @@ import java.sql.SQLException;", "removed": [ "import java.util.Properties;" ] }, { "added": [], ...
derby-DERBY-3448-cae4ed4f
DERBY-3448 Minor cleanup of DbTasks class - no need to implement Thread since it is never used as a thread - don't set system property for authorization as it is set in the required derby.properties - fix mt issue for getting connections (remove shared properties object) - don't have if != null checks for objects that cannot be null. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@631402 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/mailjdbc/utils/DbTasks.java", "hunks": [ { "added": [ "public class DbTasks {" ], "header": "@@ -44,7 +44,7 @@ import org.apache.derbyTesting.functionTests.util.streams.LoopingAlphabetReader;", "removed": ...
derby-DERBY-3454-c085d07b
DERBY-3454:All the public methods of ReplicationMessageTransmit and ReplicationMessageReceive should ensure that the socket connection exists (is not null) before performing the respective operations. Contributed by V Narayanan git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@633026 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/replication/net/ReplicationMessageReceive.java", "hunks": [ { "added": [ " sendMessage(ack);" ], "header": "@@ -236,7 +236,7 @@ public class ReplicationMessageReceive {", "removed": [ "...
derby-DERBY-3457-77a3bd13
DERBY-3457: Closing a logical connection must close all associated logical statements. Patch file: derby-3457-1c-stmt_closing.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@632112 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/LogicalStatementEntity.java", "hunks": [ { "added": [ " /** The owner of this logical entity. */", " private StatementCacheInteractor owner;" ], "header": "@@ -71,6 +71,8 @@ abstract class LogicalStatem...
derby-DERBY-3457-8a0018d2
DERBY-3457 (partial): Closing a caching logical connection must close all associated logical statements. This partial patch adds a list of open logical statements in SCI. The logic for maintaining the list when statements are closed, and for closing remaining open statements when the caching logical connection is closed, will follow in another patch. Patch file: derby-3457-2a-stmt_registration.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@631577 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/StatementCacheInteractor.java", "hunks": [ { "added": [ "import java.util.ArrayList;", "", "import org.apache.derby.shared.common.sanity.SanityManager;" ], "header": "@@ -4,10 +4,13 @@ import java.s...
derby-DERBY-3458-cd8191c8
DERBY-3458 Patch submitted by Stephan van Loendersloot. dblook should set the current schema to be a system schema so that collation of system schema (UCS_BASIC) gets used when dealing with queries using system table columns and character constants. Stephan has also provided comprehensive test for the dblook code change. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634037 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/tools/dblook.java", "hunks": [ { "added": [ "\t\t// Set the system schema to ensure that UCS_BASIC collation is used.", "\t\tStatement stmt = conn.createStatement();", "\t\tstmt.executeUpdate(\"SET SCHEMA SYS\");", ...
derby-DERBY-3461-e8aba825
DERBY-3461 The class EmbedSQLWarning is really an SQLWarning factory class. Therefore, it has been renamed to SQLWarningFactory. The unused method generateCsSQLWarning() has been removed. The remaining methods have been renamed to remove the reference to 'Embed'. Since the re-factored class is generic, it has been moved to org.apache.derby.iapi.error package. Contributed by Dibyendu Majumdar Email: dibyendu at mazumdar dot demon dot co dot uk git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@633290 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java", "hunks": [ { "added": [], "header": "@@ -30,7 +30,6 @@ import java.sql.DatabaseMetaData;", "removed": [ "import org.apache.derby.impl.jdbc.EmbedSQLWarning;" ] }, { ...
derby-DERBY-3465-9dc398ab
DERBY-3465: Removed a number of try-catch clauses that caught exceptions and printed a generic message without any information about the exception itself. Patch file: derby-3465-1a-remove_try_catch.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@631286 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3472-8dd309eb
DERBY-3472: Move the mf.workToDo call outside the synchronized block to avoid deadlocks. Contributed by Jorgen Loland git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@633063 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/replication/buffer/ReplicationLogBuffer.java", "hunks": [ { "added": [ " * ", " * Important: If methods in this class calls methods outside this package", " * (e.g. MasterFactory#workToDo), make sure that deadl...
derby-DERBY-3478-edeac317
DERBY-3478 Simple column names specified as part of "AS" clause in a table expression are ignored if the table expression is a view. Patch DERBY-3478 fixes this issue and adds a new test case. The fix adds a call to propagateDCLInfo also for views in FromBaseTable.bindNonVTITables which seems to have been always missing. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@808494 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3484-1a4ea31f
DERBY-3484 For JDBC 3.0 java.sql.Types constants use directly instead of through JDBC30Translation as JSR169 supports all the types git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@632413 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Types.java", "hunks": [ { "added": [], "header": "@@ -21,7 +21,6 @@", "removed": [ "import org.apache.derby.iapi.reference.JDBC30Translation;" ] } ] }, { "file": "java/drda/org/apache/derby/im...
derby-DERBY-3484-1e8a20fb
DERBY-3484 For JDBC 2.0/3.0 java.sql.ResultSet constants use directly instead of through JDBC[2,3]0Translation as JSR169 supports all the types git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@632456 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Connection.java", "hunks": [ { "added": [], "header": "@@ -23,7 +23,6 @@ package org.apache.derby.client.am;", "removed": [ "import org.apache.derby.shared.common.reference.JDBC30Translation;" ] }, ...
derby-DERBY-3484-a0118e1c
DERBY-3484 For JDBC 3.0 java.sql.Statement constants use directly instead of through JDBC30Translation as JSR169 supports all the types git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@632414 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedCallableStatement.java", "hunks": [ { "added": [ "import java.sql.Statement;" ], "header": "@@ -37,6 +37,7 @@ import java.sql.CallableStatement;", "removed": [] } ] }, { "file": "java/eng...
derby-DERBY-3489-f2ec1d8c
DERBY-3489: Error message XRE04 does not include the right port number. Contributed by V Narayanan * java/engine/org/apache/derby/impl/store/replication/net/ReplicationMessageTransmit.java The constructor has been modified to accept the SlaveAddress object instead of a host name and port number as was happening previously. * java/engine/org/apache/derby/impl/store/replication/net/ReplicationMessageReceive.java Modified the constructor to accept a SlaveAddress object instead of a host name and port number. Removed the getHostName() and getPort() functions, these functions seemed superfluous. They are no longer used in the SlaveController, they are used in only once place in the receiver when an exception was being thrown. * java/engine/org/apache/derby/impl/store/replication/slave/SlaveController.java slavehost and slaveport are no longer used (SlaveAddress object is instead used). introduced two functions getHostName and getPortNumber here that return the hostName and portNumber from SlaveAddress. * java/engine/org/apache/derby/impl/store/replication/master/MasterController.java slavehost and slaveport are no longer used (SlaveAddress object is instead used). introduced two functions getHostName and getPortNumber here that return the hostName and portNumber from SlaveAddress. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@644742 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/replication/master/MasterController.java", "hunks": [ { "added": [ "import java.net.UnknownHostException;" ], "header": "@@ -24,6 +24,7 @@ package org.apache.derby.impl.store.replication.master;", "removed": [...
derby-DERBY-349-1f3d2714
DERBY-349: Re-enable parameterMapping batch tests for DerbyNetClient Due to bug DERBY-349, the parameterMapping tests of various data types in the executeBatch() configuration had been disabled, because those tests were hanging. The tests are no longer hanging, so this submission re-enables the tests. This change also modifies the parameterMapping test program so that it knows how to unwind the BatchUpdateException when looking for an underlying Invalid Conversion exception. This means that we can have simpler and easier-to-read master output files, which makes the test easier to maintain. This change also deletes the separate jdk14 master file, since it is identical to the primary master file. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@391086 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3491-356ff6fc
DERBY-3462 DERBY-3491 Add permission checks for SystemPermission("server", "monitor" | "control") to NetworkServerMBean. Fix SystemPermission's handling of multiple actions and add tests. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@636878 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/mbeans/drda/NetworkServerMBean.java", "hunks": [ { "added": [ " * @see org.apache.derby.security.SystemPermission" ], "header": "@@ -31,7 +31,7 @@ package org.apache.derby.mbeans.drda;", "removed": [ " *" ...
derby-DERBY-3491-59176943
DERBY-3491 Change Derby's SystemPermission to be a two argument permission with: target-name: jmx|server|engine action: control|monitor|shutdown git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@636435 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/security/SystemPermission.java", "hunks": [ { "added": [ "import java.security.Permission;", "import java.util.ArrayList;", "import java.util.List;", "import java.util.Locale;", "import java.util.Set;", ...
derby-DERBY-3493-f30ee415
DERBY-2911: Implement a buffer manager using java.util.concurrent classes DERBY-3493: stress.multi times out waiting on testers with blocked testers waiting on the same statement Changed ConcurrentCache.create() to match Clock.create() more closely. The patch basically makes ConcurrentCache.create() use ConcurrentHashMap.get() directly instead of going through ConcurrentCache.getEntry(), which may block until the identity has been set by another thread. Then create() fails immediately if the object already exists in the cache, also if another thread is in the process of inserting the object into the cache. Since this introduced yet another difference between find() and create() in findOrCreateObject(), I also followed Øystein's suggestion from his review of DERBY-2911 and split findOrCreateObject() into a number of smaller methods, which I think makes the code easier to follow. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@635183 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/cache/ConcurrentCache.java", "hunks": [ { "added": [ " * Insert a {@code CacheEntry} into a free slot in the {@code", " * ReplacementPolicy}'s internal data structure, and return a {@code", " * Cach...
derby-DERBY-3494-860148c2
DERBY-3494 Move the setup of NormalizeResultSetNode into the NormalizeResultSetNode Removes ResultSetColumList.copyLengthsAndTypesToSource() and incorporate into the NormalizeResultSetNode init method. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@643644 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/NormalizeResultSetNode.java", "hunks": [ { "added": [ " * @param targetResultColumnList The target resultColumnList from ", " * the InsertNode or UpdateNode. These will", " ...
derby-DERBY-3494-c6564415
DERBY-3597 Incorporate DERBY-3310 and DERBY-3494 write-ups into NormalizeResultSetNode code comments. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@645638 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/NormalizeResultSetNode.java", "hunks": [ { "added": [ " *", " * child result set that needs one. See non-javadoc comments for ", " * a walk-through of a couple sample code paths.", " */", ...
derby-DERBY-3496-4c8f5703
DERBY-3496: CallableStatement with output parameter leaves cursor open after execution Patch file: derby-3496.diff (fixed the indentation problem) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@640787 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3502-477fd5e2
DERBY-3502: Ensure that conglomerate sharing works correctly in the presence of unique constraints over nullable columns. Contributed by: Anurag Shekhar (anurag dot shekhar at sun dot com) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634852 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/ConglomerateDescriptor.java", "hunks": [ { "added": [ "\t\t\t\t(indexRowGenerator.isUnique() && !othersIRG.isUnique()) ||", "\t\t\t\t\t(indexRowGenerator.isUniqueWithDuplicateNulls() && ", "\t\t\t\t\t\t!o...
derby-DERBY-3504-a63ab5e5
DERBY-3504 Fix timeout errors in management._Suite when running with classes. Was due to the spawned vm to execute the server failing as installing the policy file requires jars. Changed the decorator to add the -noSecurityManager flag if classes is being used with comments indicating if tests need a different behaviour they need to provide it. Added a SpawnedProcess utilitly class that correctly handles the output streams written by a spawned process by having two background threads that read from the streams into a buffer. This stops the change the process hangs due to being blocked writing stdout or stderr. Used this utility class in one more location where a vm was being spawned. Ideally the spawning of a java process should be in a single utility not scattered around multple tests, separate cleanup issue. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634425 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java", "hunks": [ { "added": [ "import java.io.IOException;", "import java.security.PrivilegedActionException;", "import java.security.PrivilegedExceptionAction;" ], "head...
derby-DERBY-3509-8971c8b7
DERBY-3509: The replication log shipper is not notified when a new replication transmitter is instantiated in MC#handleException. - Modified the handleException method to return the transmitter object that is created. - The log shipper bases its decision on whether it should continue with the log shipping based on if a valid transmitter object is created. Contributed by V Narayanan git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@644291 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/replication/master/AsynchronousLogShipper.java", "hunks": [ { "added": [ " private ReplicationMessageTransmit transmitter;" ], "header": "@@ -66,7 +66,7 @@ public class AsynchronousLogShipper extends Thread impleme...
derby-DERBY-3514-740feb0a
DERBY-3514 Ensure that the client socket used for network server commands is closed if the command throws an exception. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634865 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java", "hunks": [ { "added": [ " " ], "header": "@@ -760,7 +760,7 @@ public final class NetworkServerControlImpl {", "removed": [ "" ] }, { "a...
derby-DERBY-3519-33efbae6
DERBY-3519: junit regression test failure in testInertTime(org.apache.derbyTesting.functionTests.tests.lang.TimeHandlingTest)junit.framework.AssertionFailedError: expected:<2> but was:<3> git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1464386 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3520-86be795f
DERBY-3520 Convert views.sql to JUnit git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@635964 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3523-09828472
DERBY-3523 sql states (X0Y63, X0Y63, X0Y63.S) related to nulls in unique constraints are associated with wrong message texts Add upgrade test to verify messages are the same when created with 10.3 and with soft upgrade. Contributed by Anurag Shekhar (anurag dot shekhar at sun dot com) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@641398 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3523-5915e886
Back out upgrade test change for DERBY-3523. It was causing failures in the tinderbox run. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@641615 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3523-a8edfcf1
DERBY-3523 sql states (X0Y63, X0Y63, X0Y63.S) related to nulls in unique constraints are associated with wrong message texts add upgrade tests. Contributed by Anurag Shekhar (anurag dot shekhar at sun dot com) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@641911 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3525-3be5c9d7
DERBY-3525 Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@636753 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java", "hunks": [ { "added": [ "\t\treturn new BrokeredStatement(statementControl);" ], "header": "@@ -447,7 +447,7 @@ public abstract class BrokeredConnection implements EngineConnection", "...
derby-DERBY-3526-d18f3385
DERBY-3526: AsynchronousLogShipper#workToDo is blocked while the log shipper sends a log chunk Use a different object to synchronize on while calling wait and notifying the log shipper thread. Contributed by V Narayanan git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@642184 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/replication/master/AsynchronousLogShipper.java", "hunks": [ { "added": [ " /**", " * Object used to synchronize on while the log shipper thread", " * is moved into the wait state, or while notifying it....
derby-DERBY-3527-c283bcdc
DERBY-3527: The slave will not notice that a network cable is unplugged and will therefore reject failover/stopSlave commands Checks if the network connection is up by sending a ping message from the slave to the master. The shipment of the message has to happen in a separate thread because TCP timeout for send message is 2 minutes, and not configurable. Also added a message reader thread on the master that currently accepts two kinds of messages: ping and ack Contributed by Jorgen Loland git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@642982 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/replication/master/AsynchronousLogShipper.java", "hunks": [ { "added": [ " int buffers = ReplicationLogBuffer.DEFAULT_NUMBER_LOG_BUFFERS;" ], "header": "@@ -417,7 +417,7 @@ public class AsynchronousLogShipper e...
derby-DERBY-353-55b25e3e
DERBY-353: Return last user specified value for IDENTITY BY DEFAULT columns. The fix changed: a) Inside the InsertResultSet class getSetAutoincrementValue function the Data Dictionary is accessed to get the current identity value. Which is then updated in the identityVal variable which is then used by the identity_val_local() function to display to the user. b) The above process did not happen when there was a user supplied value. The system table was not accessed and the setIdentity() function in the GenericLanguageContext class was not called. c) My fix attacked the case when the user supplies a value for the identity column which can be done in the case of Generated by default and calls the setIdentity function to store the value in this case also. Thanks to Rick for doing code reviews. Submitted by V Narayanan (V.Narayanan@Sun.COM) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@267331 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/InsertResultSet.java", "hunks": [ { "added": [], "header": "@@ -178,7 +178,6 @@ public class InsertResultSet extends DMLWriteResultSet implements TargetResultSe", "removed": [ "" ] }, { ...
derby-DERBY-3536-b2fb1d5d
DERBY-3536: Fix casting of DECIMALs in TableFunctions on J2ME platforms. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@639428 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/VTIResultSet.java", "hunks": [ { "added": [ " else if ( typeID.isDecimalTypeId() ) { castDecimal( dtd, dvd ); }" ], "header": "@@ -718,6 +718,7 @@ class VTIResultSet extends NoPutResultSetImpl", ...
derby-DERBY-3542-9f61c8b3
DERBY-3543: NetworkServerControl with options but no command does not give usage message. Patch contributed by Martin Zaun Patch file: DERBY-3542-1.diff (wrong name, correct file) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@649381 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java", "hunks": [ { "added": [ " int command = findCommand(args);", " if (command == COMMAND_UNKNOWN)", " consolePropertyMessage(\"DRDA_NoCommand.U\");" ], ...
derby-DERBY-3543-9f61c8b3
DERBY-3543: NetworkServerControl with options but no command does not give usage message. Patch contributed by Martin Zaun Patch file: DERBY-3542-1.diff (wrong name, correct file) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@649381 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java", "hunks": [ { "added": [ " int command = findCommand(args);", " if (command == COMMAND_UNKNOWN)", " consolePropertyMessage(\"DRDA_NoCommand.U\");" ], ...
derby-DERBY-3544-c5d78768
DERBY-3544 If the network server fails to shutdown in NetworkServerTestSetup.teardown() then destory the process if it was run as a spearate jvm. Otherwise a chance of a hang existed when the executing the wait for on the process object. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@639433 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java", "hunks": [ { "added": [ " Throwable failedShutdown = null;", " failedShutdown = t;" ], "header": "@@ -369,13 +369,14 @@ final public class Netwo...
derby-DERBY-3548-ce9c46e9
DERBY-3548 Change SystemPrivilegesPermissionTest to only perform the fixture that tests using Subject if that class is available on the current virtual machine. Allows the test to pass and run useful fixtures in J2ME/CDC/Foundation 1.1 git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@639059 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3549-7a6650c3
DERBY-3549: Unable to start slave mode after authentication failure on a previous startSlave attempt Unboot database if startslave command fails on authentication. Contributed by Jorgen Loland git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@642219 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java", "hunks": [ { "added": [ " // Set to true if startSlave command is attempted on an", " // already booted database. Will raise an exception when", " // credenti...
derby-DERBY-3554-c6d09729
DERBY-3554 Change Collation test to run DatabaseMetaDataTest, BatchUpdateTest,GroupByExpressionTest, and UpdateableResultSetTest for only one locale Contributed by Suran Jayathilaka (suranjay at gmail dot com) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@640982 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3562-a292c89b
DERBY-3562: Delete unnecessary, old log files on the slave when a checkpoint is encountered in the log received from the master. Contributed by Jorgen Loland git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@643336 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java", "hunks": [ { "added": [ "\t\tif ((firstLogNeeded = getFirstLogNeeded(checkpoint))==-1)", "\t\t\treturn;", "\t\ttruncateLog(firstLogNeeded);", "\t}", "\t/** Get rid of o...
derby-DERBY-3566-419210d9
DERBY-3566 Alter column set data type not allowed in soft upgrade mode with unique constraint. Contributed by Anurag Shekhar (anurag dot shekhar at sun dot com) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@642420 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3567-0c97a104
DERBY-3567: Makes ALS#forceFlush time out after 5 seconds if not able to send message. Contributed by Jorgen Loland with modifications by Oystein Grovlen git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@644716 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/replication/master/AsynchronousLogShipper.java", "hunks": [ { "added": [ " private volatile boolean stopShipping = false;" ], "header": "@@ -99,7 +99,7 @@ public class AsynchronousLogShipper extends Thread implemen...
derby-DERBY-3570-fba255cd
DERBY-3570: Add ability to declare DETERMINISTIC routines. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@701367 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3571-f55d30a1
DERBY-3571: LOB locators are not released if the LOB columns are not accessed by the client. Added a release mechanism for LOBs. The client will keep track of locators and release them when the result set position is changed, or the result set closed. Locators are released one by one with individual stored procedure calls. This is rather ineffective and should be optimized (for instance by piggybacking). Also enabled a new test as part of the derbynet suite. Patch file: derby-3571-2a-simple_release.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@643819 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/ResultSet.java", "hunks": [ { "added": [ "import org.apache.derby.shared.common.sanity.SanityManager;" ], "header": "@@ -28,6 +28,7 @@ import java.sql.SQLException;", "removed": [] }, { "add...
derby-DERBY-3574-66a98185
DERBY-3574: Clean up whitespace problems introduced in revision 647931 (trailing whitespace, extra blank lines, mixing tabs and spaces on the same line) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@648180 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Blob.java", "hunks": [ { "added": [ "" ], "header": "@@ -29,9 +29,7 @@ import java.sql.SQLException;", "removed": [ " ", " ", " " ] }, { "added...
derby-DERBY-3574-80555116
DERBY-3574 With client, attempting to get the lob length after commit or connection close if there was a call to length() before commit does not throw an exception Contributed by Tiago R. Espinha (tiago at espinhas dot net) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@647931 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Blob.java", "hunks": [ { "added": [ " " ], "header": "@@ -30,9 +30,7 @@ import org.apache.derby.shared.common.reference.SQLState;", "removed": [ " //This boolean variable indicates whether the B...
derby-DERBY-3574-b905a171
DERBY-3574 With client, attempting to get the lob length after commit or connection close if there was a call to length() before commit does not throw an exception Add test for connection closed case. Contributed by Tiago R. Espinha (tiago at espinhas dot net) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@648012 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3580-10cd9408
DERBY-3580: Remove unused method Connection.resetConnection(LogWriter, String, Properties). Patch file: derby-3580-1a-remove-method.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@642726 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Connection.java", "hunks": [ { "added": [], "header": "@@ -308,37 +308,6 @@ public abstract class Connection implements java.sql.Connection,", "removed": [ " protected void resetConnection(LogWriter logWriter,", ...
derby-DERBY-3581-080c38f3
DERBY-3581 (partial): Changing certain properties on client DataSource objects causes existing connections to reflect the new values. First iteration of code removal / refactoring. Patch file: derby-3581-1a-remove_user_password_iteration1.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@648280 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/ClientPooledConnection.java", "hunks": [ { "added": [], "header": "@@ -69,8 +69,6 @@ public class ClientPooledConnection implements javax.sql.PooledConnection {", "removed": [ " private String user_;", " p...
derby-DERBY-3581-bbc2fd8f
DERBY-3581: Changing certain properties on client DataSource objects causes existing connections to reflect the new values. Removed a boolean flag that was only set to true and used in only one place. The meaning/use of the flag was also invalid, as new logical connections should not "recompute" its properties from the associated data source. This patch should not change any behavior, only remove unnecessary code. Patch file: derby-3581-3b-remove_recomputeFromDataSource_flag.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@667568 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Connection.java", "hunks": [ { "added": [ " protected void resetConnection(LogWriter logWriter)", " throws SqlException {", " // property encryptionManager_", " // if needed th...
derby-DERBY-3581-ea141d7c
DERBY-3581 (partial): Changing certain properties on client DataSource objects causes existing connections to reflect the new values. Removed data source reference from ClientPooledConnection, and also removed usage of "the new datasource reference" (new as in passed in from CPC) in Connection/NetConnection. Patch file: derby-3581-2a-remove_datasource_iteration1.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@649473 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/ClientPooledConnection.java", "hunks": [ { "added": [], "header": "@@ -67,9 +67,6 @@ public class ClientPooledConnection implements javax.sql.PooledConnection {", "removed": [ " // Cached stuff from constructor", ...
derby-DERBY-3582-4848ae56
DERBY-3582: IndexOutOfBoundsError in ClockPolicy.moveHand Make sure moveHand() and rotateClock() work if the clock is empty. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@643870 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/cache/ClockPolicy.java", "hunks": [ { "added": [ " * @return the holder under the clock hand, or {@code null} if the clock is", " * empty", " if (clock.isEmpty()) {", " ...
derby-DERBY-3586-f5e51e93
DERBY-3586: Remove am.Connection.reset(LogWriter,ClientBaseDataSource,boolean) and called methods. Removal of unused code in the client driver. Patch file: derby-3586-1a-connection_reset3_removal.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@643789 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Connection.java", "hunks": [ { "added": [], "header": "@@ -2098,21 +2098,6 @@ public abstract class Connection implements java.sql.Connection,", "removed": [ " synchronized public void reset(LogWriter logWriter, Cli...
derby-DERBY-3589-1dbc0b85
DERBY-3589: AllocPage.createPage() doesn't initialize minimumRecordSize correctly Use an object with named fields (PageCreationArgs) instead of an array to pass in arguments when creating a new page. This resolves the problem with StoredPage and AllocPage expecting the same field to be found on different positions in the array. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@644620 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/AllocPage.java", "hunks": [ { "added": [ "\tprotected void createPage(PageKey newIdentity, PageCreationArgs args)", "\t\tborrowedSpace = args.containerInfoSize;" ], "header": "@@ -270,22 +270,13 @@ ...
derby-DERBY-3595-51345f15
DERBY-3595: Make stack checking smarter in TableFunctionTest. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@652092 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3596-98ead91e
DERBY-3596: Creation of logical connections from a pooled connection causes resource leak on the server. Exposed method 'resetFromPool' through EngineConnection. The network server now detects when a client is requesting new logical connectio ns. This triggers some special logic, where the physical connection on the serve r side is kept and reset instead of being closed and opened again (this caused resources to leak earlier). The special logic must *not* be triggered for XA connections, as the XA code is already well-behaved. Patch file: derby-3596-5a-complex_skip_creds.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@666088 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java", "hunks": [ { "added": [ " /**", " * Tells if the reset / connect request is a deferred request.", " * This information is used to work around a bug (DERBY-3596) in a", " ...
derby-DERBY-3596-f2a8f001
DERBY-3596: Test cleanup only. Renamed test (added the word 'Physical'), added a missing fail(), changed some comments and added a constant for a SQL statement used multiple times. Patch file: derby-3596-3a-test_cleanup.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@660165 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3597-c6564415
DERBY-3597 Incorporate DERBY-3310 and DERBY-3494 write-ups into NormalizeResultSetNode code comments. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@645638 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/NormalizeResultSetNode.java", "hunks": [ { "added": [ " *", " * child result set that needs one. See non-javadoc comments for ", " * a walk-through of a couple sample code paths.", " */", ...
derby-DERBY-3601-20276f1e
DERBY-3601: Optimize LOBStateTracker for non-locator servers. From the Jira comment (improvements implemented); - LOBStateTracker.checkCurrentRow(): couldn't Arrays.fill() be moved inside the if block? - should discardState() and markAccessed() check the release flag? - should ResultSet.createLOBColumnTracker() use LOBStateTracker.NO_OP_TRACKER instead of allocating a new when serverSupportsLocators() returns false? Patch file: derby-3601-2a-non_locator_optimization.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@701156 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/LOBStateTracker.java", "hunks": [ { "added": [ " // Reset state for the next row.", " Arrays.fill(this.published, false);" ], "header": "@@ -130,9 +130,9 @@ class LOBStateTracker {", ...
derby-DERBY-3601-3b248981
DERBY-3601: Optimize LOBStateTracker for non-locator servers. Cleanup patch changing comments and code naming. No functional changes. Patch file: derby-3601-1a-comments_and_renaming.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@690133 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/LOBStateTracker.java", "hunks": [ { "added": [ " * An object that tracks the state of large objects (LOBs) for the current row", " * in a result set.", " * A LOB's state is either unpublished or published. When a L...
derby-DERBY-3603-aebcea3f
DERBY-3603: 'IN' clause ignores valid results. Patch contributed by A B (qozinx at gmail dot com) Some queries using multi-valued IN clauses were not returning the right results. An example of a query which was processed incorrectly is: select count(*) FROM spike.accounts account, spike.admin_units admin_unit, spike.bookings booking WHERE booking.child_id = 2 AND admin_unit.admin_unit_id IN (1,21) AND booking.booking_date_time_out >= 20080331000000 AND booking.booking_date_time_in <= 20080406235900 AND account.account_id = booking.account_id AND admin_unit.admin_unit_id = account.admin_unit_id; The issue involves the behavior of MultiProbeTableScanResultSet when it goes to re-open the scan; under certain circumstances, it was failing to reset the probing state, and so was performing the probing incorrectly, using only partial portions of the IN list values. For example, in the above query, there were certain rows which were only tested against the value "admin_unit_id = 21"; the "admin_unit_id = 1" case was skipped. MultiProbeTableScanResultSet.reopenCore() was using a heuristic test to distinguish between the two cases of: * A - The first is for join processing. In this case we have * a(nother) row from some outer table and we want to reopen this * scan to look for rows matching the new outer row. * * B - The second is for multi-probing. Here we want to reopen * the scan on this table to look for rows matching the next value * in the probe list. The patch modifies this code so that the caller passes in a boolean flag to specify which case is occurring, which avoids the problem thinking that it was in case "B" when in fact it was actually in case "A". git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@648492 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/MultiProbeTableScanResultSet.java", "hunks": [ { "added": [ " reopenCore(false);", " }", "", " /**", " * There are two scenarios for which we reopen this kind of scan:", ...
derby-DERBY-361-bd541987
DERBY-361 fix. Needed to force a checkpoint before compress, otherwise during crash recovery it was possible to redo a page that no longer existed in the file because of compress. This fix adds a number of recovery crash and transaction abort tests specific to compress into the storerecovery test suite. git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@202302 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/FileContainer.java", "hunks": [ { "added": [ " // make sure we don't execute redo recovery on any page", " // which is getting truncated. At this point we have an exclusive", " // ta...
derby-DERBY-3613-83412958
DERBY-3613: SELECT DISTINCT with GROUP BY produces wrong results Certain combinations of DISTINCT and GROUP BY in the same query were producing incorrect results. Duplicate rows were appearing in the results because the query was including all of the GROUP BY columns in the evaluation of the DISTINCT clause, not just the columns that were explicitly specified to be DISTINCT. For example, in the query: select distinct a, b from t group by a, b, c Derby was including two separate rows in the result which had the same value for columns a and b, but had different values for column c. Internally, GroupByList.bindGroupByColumns() was generating the extra column(s) from the group by list into the select's result column list, but this processing should not be performed when the query specifies distinct, because adding extra columns to the set of distinct columns changes the results. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@650728 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3616-26d0c8ed
DERBY-3616: Devise a platform-independent encoding for passing the Table Function signature from the compiler to the execution machinery. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@648232 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/io/FormatIdUtil.java", "hunks": [ { "added": [ "\tprivate\tstatic\tfinal\tint\t\tBYTE_MASK = 0xFF;", "\tprivate\tstatic\tfinal\tint\t\tNIBBLE_MASK = 0xF;", "\tprivate\tstatic\tfinal\tint\t\tNIBBLE_SHIFT = 4;", ...
derby-DERBY-3616-47e1295b
DERBY-3616: TableFunctionTest fails under Ubuntu 7.10 Removed all encoding/decoding of the table function's return type and instead stored it directly as a saved object in the compiled plan. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@649007 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/io/FormatIdUtil.java", "hunks": [ { "added": [], "header": "@@ -48,10 +48,6 @@ import java.io.IOException;", "removed": [ "\tprivate\tstatic\tfinal\tint\t\tBYTE_MASK = 0xFF;", "\tprivate\tstatic\tfinal\ti...
derby-DERBY-3618-44900c52
DERBY-3618 Perform thread dump with ASSERTS with jdk 1.5 or higher Contributed by Erlend Birkenes git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@678858 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/shared/org/apache/derby/shared/common/sanity/AssertFailure.java", "hunks": [ { "added": [ "import java.io.ByteArrayOutputStream;", "import java.io.PrintStream;", "import java.io.PrintWriter;", "import java.lang.reflect.InvocationTargetExc...
derby-DERBY-3618-47ae0cd9
DERBY-3618: Addressed some review comments in AssertFailure and AssertFailureTest Patch contributed by Erlend Birkenes <erlend@birkenes.net>. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@679742 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/shared/org/apache/derby/shared/common/sanity/AssertFailure.java", "hunks": [ { "added": [ " Derby - Class org.apache.derby.shared.common.sanity.AssertFailure" ], "header": "@@ -1,6 +1,6 @@", "removed": [ " Derby - Class org.apache...
derby-DERBY-3619-19a32c4e
DERBY-3619: Implement more load types for derbyTesting.perf.clients.Runner Added a class that creates databases for use in tests that simulate bank transactions. It is the intention that these databases follow the rules defined by the TPC-B benchmark specification as closely as possible. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@667586 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/perf/clients/BankAccountFiller.java", "hunks": [ { "added": [ "/*", "", "Derby - Class org.apache.derbyTesting.perf.clients.BankAccountFiller", "", "Licensed to the Apache Software Foundation (ASF...
derby-DERBY-3619-2445ee83
DERBY-3619: Implement more load types for org.apache.derbyTesting.perf.clients.Runner Added options to Runner to run the bank transaction test. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@671861 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/perf/clients/Runner.java", "hunks": [ { "added": [ "import java.util.HashMap;" ], "header": "@@ -27,7 +27,7 @@ import java.sql.DriverManager;", "removed": [ "import java.util.HashSet;" ] }...
derby-DERBY-3619-4ea38fbf
DERBY-3619: Implement more load types for org.apache.derbyTesting.perf.clients.Runner Added BLOB/CLOB load for the single-record update client. Added possibility to access rows by a non-indexed column or a column with a non-unique index instead of the primary key column (in the single-record update client and the single-record select client). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@658572 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/perf/clients/Runner.java", "hunks": [ { "added": [ "import java.util.Arrays;", "import java.util.HashSet;" ], "header": "@@ -26,6 +26,8 @@ import java.sql.Connection;", "removed": [] }, { ...
derby-DERBY-3619-6f53b7f4
DERBY-3619: Implement more load types for org.apache.derbyTesting.perf.clients.Runner Added simple selects of rows with columns containing a BLOB or a CLOB. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@650112 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/perf/clients/Runner.java", "hunks": [ { "added": [ "import java.sql.Types;" ], "header": "@@ -25,6 +25,7 @@ import java.io.PrintStream;", "removed": [] }, { "added": [ "\" ...
derby-DERBY-3619-f02a9f23
DERBY-3619: Implement more load types for org.apache.derbyTesting.perf.clients.Runner Added a test client (BankTransactionClient) that performs operations on a database created by BankAccountFiller. The transactions are supposed to have the same profile as the transactions in the TPC-B benchmark. The test client has not been wired into the Runner class yet. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@671462 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/perf/clients/BankAccountFiller.java", "hunks": [ { "added": [ " static final String ACCOUNT_TABLE = \"ACCOUNTS\";", " static final String BRANCH_TABLE = \"BRANCHES\";", " static final String TELLER_TABLE = \...
derby-DERBY-3624-4f29da3d
DERBY-3624: Missing deadlock in storetests/st_derby715.java Make both tests wait until the other thread has executed the SELECT statement and exhausted the ResultSet before they go on to the INSERT statements that should deadlock. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1618821 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3624-d76dd28c
DERBY-3624 testfailure in storetests/st_derby715 with ibm 1.5 on iseries machine; one deadlock message missing Change test to check locks rather than sleep for synchronization. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1530696 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3625-5314923a
DERBY-3625 Fixed SYSCS_UTIL.SYSCS_INPLACE_COMPRESS_TABLE() bug where during the defragment phase one part of the code would think there was enough room to move a record, but because the new record id on the destination page would take more room than on the source page the move actually would not succeed. In this case an XSDA3 errror would be thrown and the compress would fail. This would cause intermittent errors in the nightly concateTests. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@671605 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java", "hunks": [ { "added": [ " /**", " * Does this page have enough space to move the row to it.", " * <p>", " * Calculate if a row of length \"spaceNeeded\" with cur...
derby-DERBY-3625-cf775af5
DERBY-3625 Adding space check to case where we try to move row to a new page. I could not come up with a repro for this case, but seems safer to check for space than not. The case the code is trying to avoid is a free page that has been reclaimed with a nextid that requires more space than the row on the source page. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@672834 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java", "hunks": [ { "added": [ " if ((dest_page.getPageNumber() >= getPageNumber()) ||", " (!dest_page.spaceForCopy(row_size, record_id)))", " ...
derby-DERBY-3631-e1e6ecb2
DERBY-3631 UDF used with aggregate arguments results in error 30000 Add test case. Actual issue fixed with DERBY-3649 git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@719015 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3634-3527fd56
DERBY-3634 Cannot use row_number() in ORDER BY clause Patch derby-3634-remove-2, which removes the old windowing code to make the patch with new code (which fully replaces the old code except for the tests) more readable. Before that code is committed, OLAPTest is temporarily removed from lang/_Suite.java so as not to make regresions fail. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@820483 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.sql.ResultDescription;" ], "header": "@@ -25,6 +25,7 @@ import org.apache.derby.catalog.TypeDescriptor;", "removed": [] ...
derby-DERBY-3645-1d0c809d
derby-4477 Selecting / projecting a column whose value is represented by a stream more than once fails Patch derby-4477-partial-2. This patch clones streamable columns in occurence 2..n in ProjectRestrictResultset if they occur more than once in the select list. It also adds the three repro test cases from DERBY-3645, DERBY-3646 and DERBY-2349 to BLOBTest. The patch is not complete and needs to be revisted when cloning of store streams is implemented. Currenly the cloning occurs via materialization and this will exhaust memory when lobs are large. See FIXME in ProjectRestrictResultSet. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@902857 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java", "hunks": [ { "added": [ " @param cloneMapItem Item # for columns that need cloning", " @param reuseResult Whether or not to reuse the result row." ], "header": "@...
derby-DERBY-3646-1d0c809d
derby-4477 Selecting / projecting a column whose value is represented by a stream more than once fails Patch derby-4477-partial-2. This patch clones streamable columns in occurence 2..n in ProjectRestrictResultset if they occur more than once in the select list. It also adds the three repro test cases from DERBY-3645, DERBY-3646 and DERBY-2349 to BLOBTest. The patch is not complete and needs to be revisted when cloning of store streams is implemented. Currenly the cloning occurs via materialization and this will exhaust memory when lobs are large. See FIXME in ProjectRestrictResultSet. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@902857 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java", "hunks": [ { "added": [ " @param cloneMapItem Item # for columns that need cloning", " @param reuseResult Whether or not to reuse the result row." ], "header": "@...
derby-DERBY-3649-96e7da94
DERBY-3649 can't call a stored function with an aggregate argument without getting the following error: ERROR 42Y29 Move check for function in group by from AggregateExpressionVisitor to GroupByList git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@652533 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3649-e1e6ecb2
DERBY-3631 UDF used with aggregate arguments results in error 30000 Add test case. Actual issue fixed with DERBY-3649 git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@719015 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3650-0da1e72b
DERBY-3650 (partial) - Derby + Hibernate JPA 3.2.1 problem on entity with Blob/Clob Just adding some tests for the issue which don't pass yet, so not adding them to any suite yet. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@657124 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3650-1b454a1f
DERBY-4520 (partial): Refactor and extend data type cloning facilities Added functionality to clone store streams (without materialization). Delayed filling the byte buffer in OverflowInputStream constructor and in OverflowInputStream.resetStream. Orginal patch contributed by Mike Matrigali (mikem_app at sbcglobal dot net) as part of DERBY-3650, modified by Kristian Waagan (Kristian dot Waagan at Sun dot com). Patch file: derby-4520-3b-CloneableStream_and_delayed_fill.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@902742 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/io/FormatIdInputStream.java", "hunks": [ { "added": [], "header": "@@ -26,7 +26,6 @@ import java.io.IOException;", "removed": [ "import org.apache.derby.iapi.reference.SQLState;" ] }, { ...
derby-DERBY-3650-55bc97fc
DERBY-4477 Selecting / projecting a column whose value is represented by a stream more than once fails Patch derby-4477-lowmem-2, which adds test cases to check that lobs are not materialized when large, for the use cases covered by this issue. The test cases are added to the lowmem suite, which is not not part of the regular suites.All. This commit is preparatory in that the lobs are still small, so these changes should be revisited to change their sizes when the cloning handles materialization properly, cf DERBY-3650 and DERBY-4520. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@904538 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/functionTests/util/streams/LoopingAlphabetReader.java", "hunks": [ { "added": [ " /**", " * Reopen the stream.", " */", " public void reopen()", " throws IOException {", ...