Datasets:
willtheorangeguy
/
2022-Go-Time-Transcripts

Dataset card Data Studio Files
xet
 Community
text
stringlengths
0
2.35k
[278.10 --> 279.40] Learn more at fly.io.
[279.70 --> 280.60] Okay, here we go.
[282.36 --> 286.32] Hello and welcome to Go Time.
[286.32 --> 290.08] Today we're going to be talking about PRs.
[290.36 --> 291.50] What makes a good PR?
[292.06 --> 294.22] How do you do the best PR review?
[294.80 --> 299.72] Is there such thing as a PR that is too small, too big, too filled with emojis?
[300.20 --> 305.22] We'll be debating all the details and trying to help our fellow gophers master the art of
[305.22 --> 305.62] the PR.
[306.18 --> 309.40] Today I'm joined by three wonderful PR pros.
[309.40 --> 316.78] First, we have the wonderful Jeff Hernandez, who is a associate software engineer at the
[316.78 --> 317.44] New York Times.
[317.88 --> 318.52] Hello, Jeff.
[318.62 --> 319.34] How are you today?
[319.80 --> 321.26] Hi, doing well.
[321.36 --> 322.28] Thanks for having me back.
[322.50 --> 323.74] Thank you for joining us again.
[324.58 --> 329.04] Next up, we have Sarah Duncan, who's a staff software engineer at the New York Times.
[329.04 --> 333.62] She also teaches an introductory programming course at a high school.
[333.86 --> 335.00] So thank you for joining us.
[335.04 --> 336.78] I know you're a first time Go Time guest.
[336.94 --> 338.22] So lovely to have you.
[338.72 --> 339.58] Yeah, thanks for having me.
[339.94 --> 345.56] And last, but certainly not least, we have Natasha Dykes, who is a senior software engineer
[345.56 --> 349.10] at the New York Times and happens to be a cycling enthusiast.
[349.46 --> 349.64] Hi.
[349.92 --> 350.70] Thanks for having me.
[351.04 --> 351.44] Hiya.
[351.76 --> 352.98] Thank you for being here.
[352.98 --> 360.58] And we have the beautiful, the wonderful, the incomparable Natalie, who is my co-host.
[361.02 --> 361.28] Hello.
[361.84 --> 362.68] Hi, Angelica.
[362.74 --> 365.16] I think it's very smooth you skip pronouncing my last name.
[365.22 --> 366.50] I would probably do the same thing.
[366.58 --> 368.10] It's so complicated.
[368.84 --> 370.56] I haven't been on in a hot second.
[370.56 --> 375.48] So I'm kind of trying to minimize the amount of babbling and mistakes I get myself into.
[376.74 --> 377.60] Great strategy.
[378.06 --> 380.34] Yeah, we'll see if that persists throughout the episode.
[380.34 --> 383.62] I might just get overexcited and fumble over my words.
[384.12 --> 385.94] But thank you all for joining me today.
[386.14 --> 388.90] I'm extremely excited to talk about PRs.
[389.12 --> 391.02] So we're going to start with the very basics.
[391.66 --> 394.40] What is a PR and why do we even do them?
[394.86 --> 398.76] So I'm going to pass over to you, Sarah, when you're talking to your wonderful high school
[398.76 --> 400.92] students and they go, what is a PR?
[401.06 --> 402.00] Like, what is this thing?
[402.42 --> 403.46] How do you explain it to them?
[403.82 --> 404.04] Sure.
[404.04 --> 411.88] Well, PR stands for a pull request and it is typically used to refer to somebody who's
[411.88 --> 416.90] been making changes to a shared code base, making a request to add those changes back
[416.90 --> 419.94] into the common main.
[420.50 --> 422.22] Typically, it's like a branching situation.
[422.36 --> 424.26] So it's the main branch of that code base.
[424.70 --> 429.90] And that also typically corresponds to moving that code into production if it's a production
[429.90 --> 430.38] system.
[430.38 --> 438.02] So it's a way to get a review on your work and basically ask to add code to the main
[438.02 --> 438.42] system.
[439.08 --> 439.90] And why is it useful?
[440.14 --> 441.78] Why is this something that we want to be doing?
[442.14 --> 446.08] Is that something that maybe, I don't know, like Jeff, do you find PRs useful?
[446.56 --> 450.18] I mean, coming from like, at the times, at least I'm an associate software level.
[450.24 --> 451.42] So I'm kind of like the entry level.
[451.90 --> 457.46] So it's a great way to get feedback from my senior engineers and basically get a lot of
[457.46 --> 462.42] kind of feedback from them in terms of like what I can be doing better or like kind of
[462.42 --> 464.56] like code structure, how that could be improved.
[464.90 --> 468.26] Or even like tiny little like optimizations.
[468.66 --> 473.74] Or maybe there's a certain way that, for instance, Go likes to do things because as we all know,
[473.78 --> 474.70] Go is very opinionated.
[475.48 --> 480.42] So it's just it's like a way to tap into that resource from our senior engineers.
[480.42 --> 485.78] I feel like it's a great tool, especially for someone that's coming into a new team,
[486.16 --> 490.54] kind of getting the lay of the land, getting the norms that you typically might not get
[490.54 --> 492.52] like in through other forms of documentation.
[493.72 --> 494.16] No, for sure.
[494.66 --> 500.38] And in terms of assessing PRs, is there such thing as a good PR review?
[500.48 --> 502.86] Is there such thing as a bad PR review?
[502.86 --> 509.14] I would love to hear how you assess going about either putting in a PR or reviewing a PR.
[509.76 --> 515.52] Maybe Natasha, like when you're putting in a PR, how do you decide whether it's time to go
[515.52 --> 518.18] or whether you need to wait and do some more work?
[518.26 --> 521.34] Like at what point do you feel like, no, this is ready to be reviewed by my peers?
[521.84 --> 526.16] I think for me, it's helpful when I review like a ticket.
[526.30 --> 529.40] Usually it's for a feature or something that I'm working towards.
[529.40 --> 534.22] Sometimes I review to see if like the work that I've done actually meets the requirements.
[534.68 --> 537.80] And at that point, I can either say like, okay, it's ready to go.
[538.12 --> 543.84] I've cleaned up any notes for myself or made sure I did like go format, all of those small
[543.84 --> 544.28] things.
[544.40 --> 545.46] And then I'll open up a PR.
[545.80 --> 551.02] But I would say like, you can even open up a PR before you're ready, like ready to merge.
[551.12 --> 553.18] Sometimes it's good to just get that early feedback.
[553.60 --> 556.08] So it really depends on the work that I'm doing.
[556.08 --> 559.72] And Natalie, I see your intake of breath.
[560.02 --> 561.32] Do you have something you'd like to add?
[561.70 --> 561.96] Yeah.
[562.12 --> 564.72] You asked earlier, what is a PR?
[564.98 --> 567.80] And it's interesting also to compare PR and CR.
[568.10 --> 569.80] And why is it even pull, right?
[570.12 --> 573.22] So PR, as Sarah said, stands for pull request.
[573.74 --> 576.28] So let's split that into two questions.
[576.76 --> 577.36] Why pull?
[577.52 --> 578.20] Why not push?