text stringlengths 0 2.35k |
|---|
[578.30 --> 579.10] Why not merge? |
[579.14 --> 580.68] Or some other thing? |
[580.68 --> 584.70] And what is the difference or what do you prefer? |
[585.12 --> 589.20] CR, which stands for code review or PR as pull request. |
[589.64 --> 591.02] It's an interesting question to discuss. |
[591.12 --> 595.08] It's also interesting, even a little bit in the concept of like, what does that represent? |
[595.56 --> 596.94] Curious to hear everyone's thoughts. |
[597.52 --> 602.74] I think code review is more semantically correct for like the work that I'm typically doing. |
[602.74 --> 608.32] But I think the changes that you could potentially make don't necessarily need to touch code. |
[608.88 --> 610.50] It could be like a readme update. |
[610.62 --> 616.88] It could be some other stuff that's like kind of supporting the repository versus just the code. |
[617.54 --> 619.72] I don't know why it's called pull request though. |
[619.98 --> 620.84] Never really thought of that. |
[620.98 --> 623.46] So curious to hear what others think. |
[623.88 --> 631.64] Now this gets me kind of wanting to go to Wikipedia and kind of learn about where pull request came from and like that whole background. |
[631.64 --> 639.20] That's one of the things I'm like interested about, like just like where everything came from in terms of like software engineering best practices and naming conventions. |
[639.20 --> 648.54] Because once you're in the industry, you know, it's just something we know, you know, but it's not something that like, at least it's like, it's a term that's used across the whole industry. |
[648.54 --> 653.12] But it's not something that we as a team or something that we choose to use. |
[653.14 --> 656.42] It's just kind of like a shared language among software engineers. |
[656.58 --> 656.70] Right. |
[656.70 --> 659.96] So I was super cheeky and I did Google it just now. |
[659.96 --> 669.10] And it says that the name pull request comes from the idea that you're requesting the project to pull changes from your fork. |
[669.70 --> 677.60] That might not encompass all ways that we now use it in our language, but that's what Google's telling me on the top line. |
[678.52 --> 679.52] Yeah, it is interesting, right? |
[679.56 --> 680.78] You have this project. |
[680.88 --> 683.26] I mean, most of us use Git in some way. |
[683.46 --> 688.66] GitHub, GitLab, or I don't know too many other personal variations, but I'm sure that exists as well. |
[688.66 --> 702.32] So we're all kind of eventually are used to the concept of like having a main branch and then making branching kind of your changes from that and then asking to merge that back, whether frequent or not frequent. |
[702.32 --> 705.52] And yeah, like we all say PR. |
[705.80 --> 711.76] I've been always saying PR, but then recently I had to work with a ticketing system that is called ClickUp. |
[711.76 --> 716.04] And there they said that the label was code is in CR. |
[716.62 --> 718.22] And that was kind of interesting. |
[718.76 --> 721.86] Probably the first time I remember, let's say, encountering this. |
[722.00 --> 726.34] So I also went to dive a little into the semantics of that. |
[726.86 --> 731.94] Then there's also merge request, which kind of makes sense, but actually also not really in use. |
[732.30 --> 736.20] I've also heard it called like a changelog or CL. |
[736.20 --> 738.78] So there's a lot of different terms for it. |
[739.18 --> 741.76] What are you familiar with, you know, changelog to be? |
[742.14 --> 747.94] It's the same thing as like a pull request, but that's the certain companies call it a changelog. |
[748.16 --> 749.78] So you're submitting a changelog? |
[750.00 --> 752.00] Yeah, that's what I've understood it to be. |
[752.16 --> 753.94] It's just like something I heard in passing. |
[754.70 --> 764.58] Yeah, I've seen that in like in the Go repository, like in references to like the actual like the GitHub Go repo and like issues, people referring to changelogs. |
[764.58 --> 765.90] Yeah, it's a Google thing. |
[766.12 --> 766.84] It's a Google thing. |
[766.92 --> 769.70] Yeah, we'd totally be interested in learning more about that. |
[770.20 --> 776.68] That was me thinking that like the most basic of questions, what is a PR was just me doing my due diligence for the newbies. |
[776.70 --> 778.30] But now I see it's a whole debate. |
[779.34 --> 781.22] So many different words to use. |
[781.22 --> 782.12] This is great. |
[782.24 --> 787.82] We're opening up a Pandora's box of PR words and ways to think about code. |
[788.04 --> 788.62] I mean, right. |
[788.74 --> 790.12] Software is all about naming things. |
[790.70 --> 791.78] It starts this early. |
[791.78 --> 800.84] Okay, so when you're thinking about a PR, like I've heard many people complain about, oh, this PR is too long or this PR is so short. |
[800.92 --> 802.36] Why didn't you put it in one big PR? |
[802.60 --> 805.86] Is there such thing as a too long or a too short PR? |
[805.98 --> 806.86] Too big, too small? |
[807.00 --> 812.42] Or is it really just down to like dealer's choice, whatever that team is happy to review? |
[812.42 --> 822.44] If you're happy to review a thousand line PR or a five line PR, I'd love to hear anyone's view on kind of the length of the PR and how big it should be. |
[822.44 --> 832.18] Yeah, I definitely think that pull requests or merge requests or code reviews, these can be too long. |
[832.58 --> 834.54] Sometimes a pull request is too large. |
[834.78 --> 847.36] And my benchmark for helping set that norm on my team for what is an appropriate size pull request is really around like how well the pull request can be reviewed. |
[847.36 --> 861.14] So if you do have like a thousand line pull request, another common adage about engineers, like we're lazy and we're not probably not going to review a thousand line pull request as in depth as we would a 20 line pull request. |
[861.56 --> 868.46] So I think it's about thinking about how you can best set up your reviewers to give you a quality, thorough review. |
[868.46 --> 881.84] So I have some thoughts around like how to set that norm, but I'd love to hear from others like what you think about a length of a PR and whether a pull request can be too big or too small. |
[882.36 --> 888.96] Yeah, I don't think a pull request can necessarily be too small because it just takes one character to make a bug. |
[888.96 --> 891.28] So you're going to have to make that change. |
[891.66 --> 894.50] But I do think that I agree with you. |
[894.62 --> 906.18] It could be too long to kind of have a reviewer to actually sit down and understand all the changes, especially if they're not as familiar with you or with the code as you are. |
[906.40 --> 916.32] So I don't necessarily have the best strategy, but I think just like encapsulating certain functionalities, I think helps instead of just like an entire feature. |
[916.32 --> 919.90] Because it might be broken down into different kind of core parts. |
[920.32 --> 922.62] So that's typically how I lean on it. |
[923.62 --> 924.86] Now, Jeff, you have any thoughts? |
[925.50 --> 929.98] Yeah, I think that's it's totally like depending on what you're working on at the current moment. |
[930.16 --> 930.38] Right. |
[930.46 --> 939.06] So if you're building a new API from the ground up, like setting up the handling for the JSON, the payload, maybe that can be a PR. |
[939.24 --> 941.38] And then the actual business logic can be a separate thing. |
[941.44 --> 942.68] You're building up as you go. |
[942.74 --> 942.90] Right. |
[942.90 --> 955.74] And that's kind of something that I've learned from other people on the team because I have been guilty of this extremely large PR is where the ticket is done, but it's all in one PR and no one wants to review it. |
[955.78 --> 960.92] So you're going to maybe get a review if my next week, if you keep pinging people and bothering them. |
[961.04 --> 963.46] But otherwise, no one's going to want to touch that. |
[963.46 --> 972.06] And then you don't ever want to get in a situation where you have to offer to kind of go step by step with the reviewers. |
[972.70 --> 975.28] Like I've made this change because of this reason, like on a call. |
[975.40 --> 980.22] I feel like that's the worst case scenario where you have to actually walk them through it. |
[980.56 --> 984.62] Sometimes it's necessary, but it's something I would avoid. |
[984.98 --> 986.10] And I don't know. |
[986.16 --> 988.10] It's just it's kind of like a walk of shame. |
[988.10 --> 992.28] I mean, like you have to go through the whole thing with them, but they can definitely be too big. |
[992.38 --> 996.02] Walk of shame or you can like walk through the glory of your coding. |
[997.38 --> 998.12] I guess. |
[999.76 --> 1000.70] I'm just teasing. |
[1000.90 --> 1002.08] It's all how you think about it, right? |
[1002.44 --> 1008.70] Look at this beautiful PR that I constructed over many months that you now have to review with me. |
[1009.22 --> 1011.84] Look at this clever naming convention I did. |
[1011.96 --> 1013.38] Look at this great function. |
[1014.04 --> 1015.62] Don't you love this go routine? |
[1018.52 --> 1024.94] Also, so we talked a little bit about what you alluded to, Sarah, like being cognizant of the people who are reviewing your PR. |
[1025.40 --> 1030.90] So I'd love to hear a little bit about kind of how many people should review your PR before you merge it. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.