text stringlengths 0 2.35k |
|---|
[2761.46 --> 2762.06] And you kind of, |
[2762.34 --> 2764.10] it's a good prompt for the reviewer |
[2764.10 --> 2765.46] to think about why it's blocking |
[2765.46 --> 2766.84] and communicate that. |
[2767.22 --> 2770.12] But it's also ways of sharing |
[2770.12 --> 2771.52] like stylistic feedback |
[2771.52 --> 2772.72] in a way that's not blocking |
[2772.72 --> 2773.18] and say like, |
[2773.26 --> 2775.78] oh, like I see that you did it this way. |
[2775.86 --> 2777.34] Like typically when I approach this problem, |
[2777.38 --> 2779.04] I do it this other way. |
[2779.70 --> 2782.20] Just different styles, sharing my style. |
[2783.04 --> 2784.20] So I think it helps |
[2784.20 --> 2785.98] to kind of categorize the intention |
[2785.98 --> 2786.98] to your point Angelica |
[2786.98 --> 2789.94] around what the comment |
[2789.94 --> 2791.88] is supposed to be communicating. |
[2792.06 --> 2794.00] It like adds a little bit of color, |
[2794.10 --> 2796.48] I think to just the plain text otherwise. |
[2797.24 --> 2798.56] But curious if others |
[2798.56 --> 2799.66] have different opinions on it. |
[2799.76 --> 2801.16] Maybe you find them annoying. |
[2802.34 --> 2803.74] Follow up to that. |
[2803.92 --> 2806.30] So I'm 100% pro emoji |
[2806.30 --> 2808.94] as people on my team can attest to. |
[2809.06 --> 2811.26] I am always using emojis in Slack |
[2811.26 --> 2813.02] sometimes in GitHub. |
[2813.02 --> 2815.42] But I guess for that, |
[2815.96 --> 2817.34] if it's kind of meant to convey |
[2817.34 --> 2818.60] blocking versus not blocking |
[2818.60 --> 2819.96] as your example, |
[2820.76 --> 2822.08] is that like a way to kind of |
[2822.08 --> 2824.70] not have to use the actual |
[2824.70 --> 2825.92] like supported GitHub feature |
[2825.92 --> 2827.96] where it's like you want, |
[2828.04 --> 2829.02] you're requesting changes |
[2829.02 --> 2831.44] and kind of blocking the merge |
[2831.44 --> 2832.76] like full stop? |
[2832.88 --> 2833.90] Because I don't know |
[2833.90 --> 2834.92] how people perceive that, |
[2834.96 --> 2835.94] but maybe it could come off |
[2835.94 --> 2836.54] a little harsh, |
[2836.78 --> 2838.70] like actually using that feature |
[2838.70 --> 2839.76] and maybe like emojis |
[2839.76 --> 2841.56] isn't a nicer way to say that. |
[2841.64 --> 2843.50] But like if it's really blocking, |
[2843.84 --> 2844.98] shouldn't we just be using |
[2844.98 --> 2846.34] that specific feature |
[2846.34 --> 2847.32] to prevent it |
[2847.32 --> 2848.18] from actually going through? |
[2848.48 --> 2849.92] I think in that scenario, |
[2849.92 --> 2852.22] like you still do request changes |
[2852.22 --> 2854.16] and kind of formally block |
[2854.16 --> 2854.98] the pull request. |
[2855.20 --> 2856.72] But I know as a reviewer, |
[2856.78 --> 2858.36] if I get like changes requested |
[2858.36 --> 2858.98] on my PR |
[2858.98 --> 2861.08] and I go in and there are like 20 comments, |
[2861.34 --> 2863.86] it's hard for me to maybe initially |
[2863.86 --> 2865.34] like sift through those comments |
[2865.34 --> 2866.40] to figure out which ones |
[2866.40 --> 2867.66] are the ones that are causing |
[2867.66 --> 2869.20] the PR to be blocked. |
[2869.54 --> 2870.74] So it helps like streamline |
[2870.74 --> 2872.08] the communication in that way |
[2872.08 --> 2873.90] where if I'm blocking |
[2873.90 --> 2875.36] Angelica's pull request |
[2875.36 --> 2877.28] and I leave a bunch of comments |
[2877.28 --> 2878.16] and some of them are like, |
[2878.34 --> 2879.16] great job, you, |
[2879.32 --> 2880.12] this is really cool. |
[2880.28 --> 2881.86] And some of them are style |
[2881.86 --> 2884.14] and some of them are actually questions |
[2884.14 --> 2886.50] and then some of them are actual blocking |
[2886.50 --> 2887.80] like requests for changes. |
[2887.80 --> 2890.38] It helps kind of narrow to those |
[2890.38 --> 2891.98] and like create more of, |
[2892.14 --> 2894.92] I think like a clear checklist |
[2894.92 --> 2896.14] in a way of like what, |
[2896.40 --> 2897.74] you're expecting to be changed |
[2897.74 --> 2899.10] before being asked |
[2899.10 --> 2900.12] to re-review the code. |
[2900.50 --> 2901.58] So I just think it's helpful |
[2901.58 --> 2903.46] even if you are formally |
[2903.46 --> 2904.90] like blocking the pull request |
[2904.90 --> 2908.38] to communicate like what things |
[2908.38 --> 2909.34] you expect to be changed |
[2909.34 --> 2911.76] before you think that it could be merged. |
[2912.42 --> 2912.52] Gotcha. |
[2912.62 --> 2913.68] I don't know if I was just projecting |
[2913.68 --> 2914.54] my own fear, |
[2914.64 --> 2915.28] like seeing the, |
[2915.38 --> 2916.78] like the email where it says |
[2916.78 --> 2917.86] this has been like, |
[2918.06 --> 2918.98] changes have been requested |
[2918.98 --> 2920.10] and oh no, |
[2920.16 --> 2921.10] what did I do wrong? |
[2921.42 --> 2922.40] I need to do that. |
[2922.98 --> 2923.54] Don't worry. |
[2923.60 --> 2924.68] We all do stuff wrong |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.