text stringlengths 0 2.35k |
|---|
[2545.08 --> 2547.92] that sometimes it's kind of impolite |
[2547.92 --> 2548.64] either to correct |
[2548.64 --> 2550.30] or even to just say no to someone. |
[2550.80 --> 2553.84] So I had to learn and actively practice |
[2553.84 --> 2556.26] that when I propose some idea, |
[2556.36 --> 2557.90] I have to start with something like, |
[2558.10 --> 2559.94] feel free to reject that |
[2559.94 --> 2562.24] or there might be better alternatives, |
[2562.44 --> 2562.64] but, |
[2563.20 --> 2565.16] and sometimes it's still, |
[2565.38 --> 2566.30] depending on the context, |
[2566.30 --> 2568.26] it sounds sort of foreign, |
[2568.26 --> 2569.30] but I think it's fine |
[2569.30 --> 2570.74] that it sounds foreign |
[2570.74 --> 2572.74] because it's kind of like a standard |
[2572.74 --> 2575.06] across all the different cultures |
[2575.06 --> 2576.20] you'll get to work with |
[2576.20 --> 2577.62] that this is a, |
[2578.12 --> 2581.16] be nicer over being not nice enough. |
[2581.68 --> 2582.28] Yeah, definitely. |
[2582.74 --> 2584.58] My comment is going to be very like, |
[2585.12 --> 2586.20] less, slightly less serious, |
[2586.32 --> 2587.00] but it came to mind |
[2587.00 --> 2587.90] and it sounded like something |
[2587.90 --> 2588.76] that I would love to do. |
[2589.30 --> 2592.50] Can you like attach voice notes to PRs? |
[2592.50 --> 2594.42] You have looms in Git pull requests. |
[2594.90 --> 2595.22] Yeah, |
[2595.22 --> 2597.08] because I feel like I would love it |
[2597.08 --> 2598.74] if someone made like a suggestion |
[2598.74 --> 2601.36] and then I could like have a little voice note |
[2601.36 --> 2602.06] where they could say, |
[2602.14 --> 2602.68] this is why, |
[2602.80 --> 2604.00] because then you hear the tone |
[2604.00 --> 2606.42] and you hear them explaining it |
[2606.42 --> 2609.50] and then you could do like a verbal readout |
[2609.50 --> 2610.74] of your very long PR. |
[2611.42 --> 2612.44] That might be cool. |
[2614.06 --> 2615.86] Do emojis help with that? |
[2616.16 --> 2617.58] Like I find it really difficult |
[2617.58 --> 2620.80] to communicate through my words |
[2620.80 --> 2622.38] without emojis. |
[2622.50 --> 2624.84] Like I use emojis to help me |
[2624.84 --> 2626.44] more accurately portray |
[2626.44 --> 2629.20] the intention behind my comments. |
[2629.36 --> 2630.66] I, when I say something like, |
[2631.04 --> 2632.54] oh, I'm not sure about this. |
[2632.64 --> 2634.12] I'll do like a thinky emoji |
[2634.12 --> 2636.40] and like a funny like tongue emoji |
[2636.40 --> 2637.56] to show that it's like, |
[2637.94 --> 2639.34] not like a, what is this? |
[2639.88 --> 2641.98] Because I feel like words are not enough, |
[2642.04 --> 2642.78] which is why, |
[2642.92 --> 2644.52] and those of you who interact with me regularly, |
[2645.10 --> 2645.76] I think you'll be, |
[2645.88 --> 2647.90] it'll be very hard for you to find any space |
[2647.90 --> 2650.18] where I haven't put an emoji after my message |
[2650.18 --> 2652.38] or some kind of imagery, |
[2652.38 --> 2653.80] whether it be a meme or a GIF |
[2653.80 --> 2657.50] to try and kind of level up my communication |
[2657.50 --> 2658.58] from just being words |
[2658.58 --> 2660.90] to having that extra layer of like emotion. |
[2661.40 --> 2666.46] Is it appropriate to add many emojis to your PR? |
[2666.58 --> 2668.74] I know that you can like add the emoji reactions, |
[2668.98 --> 2669.64] but within it, |
[2669.92 --> 2672.42] is that a useful tool that in fact could be used |
[2672.42 --> 2674.64] to try and alleviate that risk |
[2674.64 --> 2677.20] of being misconstrued via just written word? |
[2677.20 --> 2679.52] So you mean the pull request description |
[2679.52 --> 2680.70] or actually each commit? |
[2682.32 --> 2684.42] I mean, open to views on either. |
[2685.00 --> 2686.72] Yeah, I recommend using emojis |
[2686.72 --> 2690.34] and like setting up norms around emoji use |
[2690.34 --> 2692.06] and like code review norms. |
[2692.34 --> 2693.58] It's like one of the suggestions |
[2693.58 --> 2696.12] that some of the other staff engineers |
[2696.12 --> 2700.06] and I put together in the norms template |
[2700.06 --> 2702.54] that we shared out with internally at the times. |
[2702.54 --> 2706.24] And I think it's the way that we use emojis |
[2706.24 --> 2709.02] in that template is around communicating |
[2709.02 --> 2711.16] the intention behind a review comment. |
[2711.96 --> 2715.40] So one of the things that is really hard to tell |
[2715.40 --> 2718.78] based on just the written word in terms of tone |
[2718.78 --> 2721.28] is like whether that piece of feedback |
[2721.28 --> 2722.62] is blocking or not. |
[2723.28 --> 2726.26] So is this just a stylistic thing |
[2726.26 --> 2729.48] that you think will help me level up my skills? |
[2729.48 --> 2732.50] Is this something that I actually need to do |
[2732.50 --> 2734.42] before merging in this code? |
[2735.16 --> 2737.78] That kind of communication can sometimes be hard |
[2737.78 --> 2742.20] and especially I think within different levels. |
[2742.34 --> 2743.78] Like I know when I was more entry level |
[2743.78 --> 2746.20] I had a hard time just like coming out |
[2746.20 --> 2746.76] and asking like, |
[2746.86 --> 2747.98] do I actually have to do that though? |
[2749.00 --> 2752.28] So we use emojis as a way |
[2752.28 --> 2754.26] of kind of categorizing the comment. |
[2754.64 --> 2756.14] So if it is blocking, |
[2756.68 --> 2758.16] you can communicate that being like, |
[2758.16 --> 2760.90] oh, like this will cause implications in this way. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.