author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,183 | 03.12.2020 13:10:07 | -3,600 | f12a734c74ff3799f27ce153943f381bc3954841 | [native] Use hook instead of connect functions and HOC in ThreadSettingsName
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-name.react.js",
"new_path": "native/chat/settings/thread-settings-name.react.js",
"diff": "@@ -7,27 +7,22 @@ import {\n} from 'lib/actions/thread-actions';\nimport { createLoadingStatusSelector } from 'lib/selectors/loading... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ThreadSettingsName
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D474 |
129,183 | 03.12.2020 13:29:37 | -3,600 | c06fb639035cfbcebe0c134196ad9fd9af1506d0 | [native] Use hook instead of connect functions and HOC in ThreadList
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-list.react.js",
"new_path": "native/components/thread-list.react.js",
"diff": "import invariant from 'invariant';\nimport SearchIndex from 'lib/shared/search-index';\n-import { type ThreadInfo, threadInfoPropType } from 'lib/types/thre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ThreadList
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D475 |
129,183 | 03.12.2020 13:34:52 | -3,600 | f0e86adf26fa2dbed4f22ca963494e76bcccd8cd | [native] Use hook instead of connect functions and HOC in UserList
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/user-list.react.js",
"new_path": "native/components/user-list.react.js",
"diff": "// @flow\n-import { type UserListItem, userListItemPropType } from 'lib/types/user-types';\n-import { connect } from 'lib/utils/redux-utils';\n+import type { Us... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in UserList
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D476 |
129,183 | 03.12.2020 13:51:24 | -3,600 | 90739100330de4f7b0d7b17d40ad6ac0b2621a4d | [native] Use hook instead of connect functions and HOC in ForgotPasswordPanel
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/forgot-password-panel.react.js",
"new_path": "native/account/forgot-password-panel.react.js",
"diff": "@@ -11,15 +11,17 @@ import {\nvalidEmailRegex,\n} from 'lib/shared/account-utils';\nimport type { LoadingStatus } from 'lib/types/loading-type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ForgotPasswordPanel
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D477 |
129,183 | 03.12.2020 15:07:29 | -3,600 | e11ca98bdb5ec6355833bd59eb074e397a22386b | [native] Use hook instead of connect functions and HOC in ThreadSettingsDescription
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-description.react.js",
"new_path": "native/chat/settings/thread-settings-description.react.js",
"diff": "@@ -8,30 +8,25 @@ import {\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\nimport { t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ThreadSettingsDescription
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D478 |
129,183 | 03.12.2020 15:14:43 | -3,600 | 43c03528ddd40a58f89ccfe50a52e392ba134e4f | [native] Use hook instead of connect functions and HOC in ThreadSettingsVisibility
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-visibility.react.js",
"new_path": "native/chat/settings/thread-settings-visibility.react.js",
"diff": "// @flow\nimport type { ThreadInfo } from 'lib/types/thread-types';\n-import { connect } from 'lib/utils/redux-utils';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ThreadSettingsVisibility
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D479 |
129,183 | 03.12.2020 15:19:15 | -3,600 | 7b6a31fb3b9745b9cd8b5d5f441bba56c37aca9c | [native] Use hook instead of connect functions and HOC in MessageHeader
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-header.react.js",
"new_path": "native/chat/message-header.react.js",
"diff": "// @flow\nimport { stringForUser } from 'lib/shared/user-utils';\n-import { connect } from 'lib/utils/redux-utils';\nimport * as React from 'react';\nimport { Vie... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in MessageHeader
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D480 |
129,183 | 03.12.2020 15:24:47 | -3,600 | 534474074ce1fd4ce568b8b28f9708dd7a05b59b | [native] Use hook instead of connect functions and HOC in Timestamp
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/timestamp.react.js",
"new_path": "native/chat/timestamp.react.js",
"diff": "// @flow\nimport { longAbsoluteDate } from 'lib/utils/date-utils';\n-import { connect } from 'lib/utils/redux-utils';\nimport * as React from 'react';\nimport { SingleLine ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in Timestamp
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D481 |
129,183 | 03.12.2020 15:26:01 | -3,600 | bbc7c7ae0d7e5e0a5802cdc91b2db4acd15e1e59 | [native] Use hook instead of connect functions and HOC in EditSettingButton
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/edit-setting-button.react.js",
"new_path": "native/components/edit-setting-button.react.js",
"diff": "// @flow\n-import { connect } from 'lib/utils/redux-utils';\nimport * as React from 'react';\nimport { TouchableOpacity, StyleSheet, Platfor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in EditSettingButton
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D482 |
129,183 | 03.12.2020 15:30:10 | -3,600 | 6f3cd5a14d32b86bec9c0892a75d367e89420a05 | [native] Use hook instead of connect functions and HOC in ListLoadingIndicator
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/list-loading-indicator.react.js",
"new_path": "native/components/list-loading-indicator.react.js",
"diff": "// @flow\n-import { connect } from 'lib/utils/redux-utils';\nimport * as React from 'react';\nimport { ActivityIndicator } from 'react... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ListLoadingIndicator
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D483 |
129,187 | 02.12.2020 23:50:25 | 18,000 | d9a27cb4f3b36f813162e270f81c313ee20071a4 | [web] Convert ChatTabs to Hook
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.react.js",
"new_path": "web/chat/chat-tabs.react.js",
"diff": "// @flow\nimport { unreadBackgroundCount } from 'lib/selectors/thread-selectors';\n-import { connect } from 'lib/utils/redux-utils';\n-import PropTypes from 'prop-types';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Convert ChatTabs to Hook
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D472 |
129,191 | 12.11.2020 16:18:50 | -3,600 | dc0874d5fdbdb2a6c3a7d8e3dc4f24f705d8c2a8 | [server] Send a message when friend request is sent or accepted
Test Plan: I've sent a friend request and a message was created and successfully displayed. The same for accepting a request.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/relationship-updaters.js",
"new_path": "server/src/updaters/relationship-updaters.js",
"diff": "import invariant from 'invariant';\nimport { sortIDs } from 'lib/shared/relationship-utils';\n+import { messageTypes } from 'lib/types/message-t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Send a message when friend request is sent or accepted
Test Plan: I've sent a friend request and a message was created and successfully displayed. The same for accepting a request.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat... |
129,183 | 08.12.2020 14:53:26 | -3,600 | bbb9ed92a1a684f0ad09c81ece8d4e3b76fef433 | [native] Replace possiblyPendingThreadInfoSelector with hooks
Summary: This needs to be done in order to have correct currentUser permissions in pending threads
Test Plan: Tested if input is removed when blocking users in pending threads, and that correct notices are displayed
Reviewers: ashoat, palys-swm
Subscribers: ... | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/thread-selectors.js",
"new_path": "lib/selectors/thread-selectors.js",
"diff": "// @flow\n-import invariant from 'invariant';\nimport _compact from 'lodash/fp/compact';\nimport _filter from 'lodash/fp/filter';\nimport _flow from 'lodash/fp/flow';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Replace possiblyPendingThreadInfoSelector with hooks
Summary: This needs to be done in order to have correct currentUser permissions in pending threads
Test Plan: Tested if input is removed when blocking users in pending threads, and that correct notices are displayed
Reviewers: ashoat, palys-swm
Reviewed ... |
129,183 | 09.12.2020 12:54:29 | -3,600 | 72c4b596fba739087efff084ab514b39642253e8 | [native] Use hook instead of connect functions and HOC in SaveSettingButton
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/save-setting-button.react.js",
"new_path": "native/chat/settings/save-setting-button.react.js",
"diff": "@@ -4,29 +4,21 @@ import * as React from 'react';\nimport { TouchableOpacity } from 'react-native';\nimport Icon from 'react-native-ve... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in SaveSettingButton
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D493 |
129,183 | 09.12.2020 13:00:52 | -3,600 | 24f929c25998002fe190efaa02abd426ef65dd45 | [native] Use hook instead of connect functions and HOC in ThreadSettingsCategory
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-category.react.js",
"new_path": "native/chat/settings/thread-settings-category.react.js",
"diff": "@@ -4,34 +4,30 @@ import invariant from 'invariant';\nimport * as React from 'react';\nimport { View, Text, Platform } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ThreadSettingsCategory
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D494 |
129,183 | 09.12.2020 13:06:00 | -3,600 | 2ad84a1d7253535300c6ac7fedecb74ffc4de4c6 | [native] Use hook instead of connect functions and HOC in ThreadSettingsListAction
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-list-action.react.js",
"new_path": "native/chat/settings/thread-settings-list-action.react.js",
"diff": "@@ -5,21 +5,18 @@ import { View, Text, Platform } from 'react-native';\nimport type { IoniconsGlyphs } from 'react-nat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ThreadSettingsListAction
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D495 |
129,183 | 09.12.2020 13:10:53 | -3,600 | 77efdf52be5cf70b8ea190fb0c98730c9e123346 | [native] Use hook instead of connect functions and HOC in PencilIcon
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/pencil-icon.react.js",
"new_path": "native/components/pencil-icon.react.js",
"diff": "@@ -4,20 +4,14 @@ import * as React from 'react';\nimport { Platform } from 'react-native';\nimport Icon from 'react-native-vector-icons/FontAwesome';\n-imp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in PencilIcon
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D496 |
129,183 | 09.12.2020 13:20:37 | -3,600 | 1c6314702d9058dd489ed848621f74b084e06a47 | [native] Convert BuildInfo to Hook
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/build-info.react.js",
"new_path": "native/more/build-info.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { View, Text, ScrollView } from 'react-native';\n-import { connect } from 'lib/uti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert BuildInfo to Hook
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D497 |
129,183 | 09.12.2020 14:12:20 | -3,600 | 95c9b8d499055b15e57e3cceda7d4022073be839 | [native] Remove unused RelationshipListAddButton
Summary: When removing relationshipUpdateModal, I forgot to delete this since it's never used anymore
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "DELETE",
"old_path": "native/more/relationship-list-add-button.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import * as React from 'react';\n-import Icon from 'react-native-vector-icons/Ionicons';\n-\n-import { connect } from 'lib/utils/redux-utils';\n-\n-import Button from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove unused RelationshipListAddButton
Summary: When removing relationshipUpdateModal, I forgot to delete this since it's never used anymore
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D498 |
129,187 | 14.12.2020 19:18:21 | 18,000 | 0f1b8689ce09786f09ec88484ee379a1c7013462 | [native] Convert DisconnectedBarVisibilityHandler to Hook
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/disconnected-bar-visibility-handler.react.js",
"new_path": "native/navigation/disconnected-bar-visibility-handler.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\n+import { useDispatch } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert DisconnectedBarVisibilityHandler to Hook
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D513 |
129,183 | 10.12.2020 15:20:32 | -3,600 | 73f9dc936daf21ab465a799955950ebc646df183 | [native] Display buttons to change relationship in personal threads
Test Plan: Checked if buttons are displayed correctly, made sure pressing them changes relationship
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/relationship-utils.js",
"new_path": "lib/shared/relationship-utils.js",
"diff": "// @flow\n+import {\n+ type RelationshipButton,\n+ userRelationshipStatus,\n+ relationshipButtons,\n+} from '../types/relationship-types';\n+import type { UserInfo } fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Display buttons to change relationship in personal threads
Test Plan: Checked if buttons are displayed correctly, made sure pressing them changes relationship
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D499 |
129,183 | 17.12.2020 14:41:07 | -3,600 | 5d0a6b1591cf9fae6f182176d563bb284b9e493d | [native] Use hook instead of connect functions and HOC in CalendarInputBar
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar-input-bar.react.js",
"new_path": "native/calendar/calendar-input-bar.react.js",
"diff": "import * as React from 'react';\nimport { View, Text } from 'react-native';\n-import { connect } from 'lib/utils/redux-utils';\n-\nimport Button f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in CalendarInputBar
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D518 |
129,183 | 17.12.2020 15:11:48 | -3,600 | 324fa7fd7298faae8de904f7fa71b93f88ad37d5 | [native] Use hook instead of connect functions and HOC in DeleteAccount
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/delete-account.react.js",
"new_path": "native/more/delete-account.react.js",
"diff": "// @flow\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport {\nText,\n@@ -19,56 +18,40 @@ import {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in DeleteAccount
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D519 |
129,183 | 17.12.2020 15:31:21 | -3,600 | 7c50a42566da693bf6b65ed8ddd0ecfdabfa10e3 | [native] Use hook instead of connect functions and HOC in Crash
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/crash.react.js",
"new_path": "native/crash.react.js",
"diff": "import Clipboard from '@react-native-community/clipboard';\nimport invariant from 'invariant';\nimport _shuffle from 'lodash/fp/shuffle';\n-import PropTypes from 'prop-types';\nimport * as R... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in Crash
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D520 |
129,183 | 14.12.2020 12:18:32 | -3,600 | b76238b16dd4a27f3d32bc88d4e67de52914f30d | [web] Display modal on see more sidebars click
Summary: Part two of creating modal with more sidebars
Test Plan: Flow, check if modal is displayed after clicking on button
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.react.js",
"new_path": "web/chat/chat-tabs.react.js",
"diff": "@@ -10,7 +10,10 @@ import ChatThreadBackground from './chat-thread-background.react';\nimport ChatThreadHome from './chat-thread-home.react';\nimport ChatThreadTab from './chat-t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display modal on see more sidebars click
Summary: Part two of creating modal with more sidebars
Test Plan: Flow, check if modal is displayed after clicking on button
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D505 |
129,183 | 14.12.2020 14:44:28 | -3,600 | 4b4b4a3d926926d6007f8263273db926726d97cf | [web] Display more sidebars in modal
Summary: Last step of creating new modal: display sidebars inside
Test Plan: Checked if sidebars are displayed correctly, if clicking on them hides modal and changes active thread
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -77,6 +77,7 @@ function ChatThreadListItem(props: Props) {\n} else {\nreturn (\n<ChatThreadListSeeMoreSidebars\n+ threadInfo={item.threadInfo}\nunread=... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display more sidebars in modal
Summary: Last step of creating new modal: display sidebars inside
Test Plan: Checked if sidebars are displayed correctly, if clicking on them hides modal and changes active thread
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revi... |
129,183 | 15.12.2020 14:59:12 | -3,600 | fe1debc16d56778bf12ba658d0b49e6550d32a6d | [web] Add searching to sidebarListModal
Test Plan: Check if input looks and works good
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -138,3 +138,44 @@ ul.list {\nmargin: 5px 3px 10px 0px;\noverflow: auto;\n}\n+\n+div.search {\n+ display: flex;\n+ background-color: #DDDDDD;\n+ border-radius: 5px;\n+ padd... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add searching to sidebarListModal
Test Plan: Check if input looks and works good
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D516 |
129,191 | 21.12.2020 12:17:39 | -3,600 | b480a683d8a8e54d88669f19f95971039c32281f | [server] Update personal threads creation script to handle role = -1
Test Plan: Create a thread with two friends, remove one and verify that the thread doesn't get updated.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-personal-threads.js",
"new_path": "server/src/scripts/create-personal-threads.js",
"diff": "@@ -48,6 +48,8 @@ async function markThreadsAsPersonal() {\nAND t.id != ${bots.squadbot.staffThreadID}\nAND m3.user IS NULL\nAND r2.id IS NULL... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update personal threads creation script to handle role = -1
Test Plan: Create a thread with two friends, remove one and verify that the thread doesn't get updated.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D533 |
129,191 | 21.12.2020 14:15:13 | -3,600 | 5b14481d685ef6a2fbb93c16ccfa3772bc2c1ee8 | [server] Handle personal threads with removed user
Test Plan: Create a personal thread with removed user. Open pending thread with this user and send a message or friend request and verify that a personal thread was created.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -190,6 +190,8 @@ async function createThread(\nINNER JOIN memberships m2\nON m2.thread = t.id AND m2.user = ${otherMemberID}\nWHERE t.type = ${threadTypes.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Handle personal threads with removed user
Test Plan: Create a personal thread with removed user. Open pending thread with this user and send a message or friend request and verify that a personal thread was created.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential R... |
129,183 | 21.12.2020 16:00:12 | -3,600 | 9aadfaba6b6979e6d4fb0bb5d8da63bc6ca1e2f4 | [native] Fix background tab not showing empty item
Test Plan: Check if empty item is showing correctly like before
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -221,7 +221,6 @@ class ChatThreadList extends React.PureComponent<Props, State> {\nusersSearchResults: $ReadOnlyArray<GlobalAccountUserInfo>,\n): Item[] =>... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix background tab not showing empty item
Test Plan: Check if empty item is showing correctly like before
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D537 |
129,183 | 18.12.2020 13:17:10 | -3,600 | 9ad3f86c16f54469a3ea33a2e446a7e367b771ff | [native] Use hook instead of connect functions and HOC in UserListUser
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/user-list-user.react.js",
"new_path": "native/components/user-list-user.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { Text, Platform, Alert } from 'react-native';\n-import { type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in UserListUser
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D527 |
129,183 | 18.12.2020 14:00:28 | -3,600 | 008f861b3f84004037ba9c8189db5368088a1512 | [server] Allow only parent thread members to be added to a sidebar
Test Plan: Checked if for sidebars adding user not in parent thread results in error, but it's still allowed for rest of threads
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -119,14 +119,22 @@ async function createThread(\ninvariant(initialMemberIDs, 'should be set');\nfor (const initialMemberID of initialMemberIDs) {\nconst in... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Allow only parent thread members to be added to a sidebar
Test Plan: Checked if for sidebars adding user not in parent thread results in error, but it's still allowed for rest of threads
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabrica... |
129,183 | 21.12.2020 14:38:29 | -3,600 | 9fad9090d96868b8d15d6f17782ea844e4365154 | Do not show sidebars inline if not active in 3 days
Test Plan: Check if correct sidebars are displayed inline, check if button to show more sidebars has correct text. Tested both on web and native
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -38,6 +38,7 @@ import {\n} from '../types/thread-types';\nimport { userInfoPropType } from '../types/user-types';\nimport type { UserInfo } from '../types/user-types';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Do not show sidebars inline if not active in 3 days
Test Plan: Check if correct sidebars are displayed inline, check if button to show more sidebars has correct text. Tested both on web and native
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabric... |
129,183 | 22.12.2020 10:07:30 | -3,600 | 9dea2b514da1a39e2b668da55b1fa19301376279 | [native] Add button to reject friend request in relationship list
Test Plan: Make sure button in displayed correctly, checked if updating relationship by pressing accept/reject buttons works correctly
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-list-item.react.js",
"new_path": "native/more/relationship-list-item.react.js",
"diff": "@@ -18,6 +18,7 @@ import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\nimport type { LoadingStatus } from 'lib/types/lo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add button to reject friend request in relationship list
Test Plan: Make sure button in displayed correctly, checked if updating relationship by pressing accept/reject buttons works correctly
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://pha... |
129,187 | 20.12.2020 22:43:27 | 18,000 | f76ed75e895904613e37e0a9e7120b01262ddeb9 | [native] codeVersion -> 71 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 71 |
129,187 | 23.12.2020 13:52:09 | 18,000 | bc893451b73fc501b887d48338fc519e008d69dd | [native] codeVersion -> 72
This is an iOS-only release to address an issue identified in the v71 release (see D551). | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 72
This is an iOS-only release to address an issue identified in the v71 release (see D551). |
129,191 | 17.12.2020 13:23:32 | -3,600 | 54627dbcce7718f00a24db172224989da4cdf69c | [native] Update pending thread name when changing members
Summary: We should update a pending thread when its members change
Test Plan: Search for a pending thread and check if the name is correct
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -16,13 +16,14 @@ import {\nimport { messageID } from 'lib/shared/message-utils';\nimport { getPotentialMemberItems } from 'lib/shared/search-ut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update pending thread name when changing members
Summary: We should update a pending thread when its members change
Test Plan: Search for a pending thread and check if the name is correct
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricato... |
129,191 | 17.12.2020 13:30:55 | -3,600 | 667fd85bce263acb2ef790282c485f0dbc1c1dff | [native] Block setting for all the pending threads
Summary: We should block settings for all the pending threads, not only personal
Test Plan: Check if settings can not be accessed from pending personal and pending thread
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-header-title.react.js",
"new_path": "native/chat/message-list-header-title.react.js",
"diff": "@@ -6,7 +6,7 @@ import * as React from 'react';\nimport { View, Platform } from 'react-native';\nimport Icon from 'react-native-vector-icons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Block setting for all the pending threads
Summary: We should block settings for all the pending threads, not only personal
Test Plan: Check if settings can not be accessed from pending personal and pending thread
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Rev... |
129,191 | 17.12.2020 14:21:34 | -3,600 | b67b1326ad752e8b8c025592049119db005f656b | [native] Create real thread when a message is sent
Test Plan: Create a personal thread and a pending thread with multiple users
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -178,20 +178,15 @@ function threadIsPersonalAndPending(threadInfo: ?(ThreadInfo | RawThreadInfo)) {\n);\n}\n-function getPendingPersonalThreadOtherUser(\n- threadInfo: ThreadInf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create real thread when a message is sent
Test Plan: Create a personal thread and a pending thread with multiple users
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D526 |
129,191 | 23.12.2020 13:57:47 | -3,600 | f91b6a194c19a771ba05c4822a363a6f56e60100 | [native] Create message list thread search component
Test Plan: Flow, check is the functionality remained the same
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "import invariant from 'invariant';\nimport * as React from 'react';\n-import { Text, View } from 'react-native';\n+import { View } from 'react-nat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create message list thread search component
Test Plan: Flow, check is the functionality remained the same
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D547 |
129,191 | 28.12.2020 12:31:14 | -3,600 | 6083a10fb278e8a20d2c98bc686f7f708178c647 | [native] Hide settings button on Android for pending threads
Test Plan: When pending thread is open, the button should not be visible. For a real thread, the button should still appear
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -19,6 +19,8 @@ import invariant from 'invariant';\nimport * as React from 'react';\nimport { Platform, View } from 'react-native';\n+import { threadIsPending } from 'lib/shared/th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Hide settings button on Android for pending threads
Test Plan: When pending thread is open, the button should not be visible. For a real thread, the button should still appear
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/... |
129,187 | 24.12.2020 15:35:02 | 18,000 | 3f8f49563f6949b4f28ea5e08c7c5c86162df0c0 | [native] Convert EditPassword data-binding to hook
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/edit-password.react.js",
"new_path": "native/more/edit-password.react.js",
"diff": "import { CommonActions } from '@react-navigation/native';\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert EditPassword data-binding to hook
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D555 |
129,187 | 24.12.2020 16:34:41 | 18,000 | f3c2e8525679720dff1c8cdbc1570d56b4ffe924 | [native] Convert ThemeHandler to hook
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/themes/theme-handler.react.js",
"new_path": "native/themes/theme-handler.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport {\ninitialMode as initialSystemTheme,\neventEmitter as systemThemeEventE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert ThemeHandler to hook
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D558 |
129,187 | 24.12.2020 22:07:54 | 18,000 | 9481589559286b04d911fd206adff2b0916c1714 | [native] Convert HeaderBackButton into Hook
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/header-back-button.react.js",
"new_path": "native/navigation/header-back-button.react.js",
"diff": "import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/stack';\nimport * as React from 'react';\n-import { connect } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert HeaderBackButton into Hook
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D560 |
129,187 | 28.12.2020 11:19:07 | 18,000 | f116325111cd0fc9dcb18be00a0c446236e54d3c | [native] codeVersion -> 73
This is an Android-only release to address an issue identified in the v72 release (see D562). | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 73
This is an Android-only release to address an issue identified in the v72 release (see D562). |
129,191 | 23.12.2020 15:33:55 | -3,600 | ccda03ba0ebc34022487fb86d2b787152e6455ad | [native] Make thread creator buttons navigate to message list with searching param
Test Plan: Test if header button on iOS and floating action on Android navigate to message list with search component visible
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -16,7 +16,10 @@ import {\nimport { threadSearchIndex as threadSearchIndexSelector } from 'lib/selectors/nav-selectors';\nimport { usersWithPersonalThreadSe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make thread creator buttons navigate to message list with searching param
Test Plan: Test if header button on iOS and floating action on Android navigate to message list with search component visible
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https:/... |
129,191 | 24.12.2020 15:13:31 | -3,600 | e523589964e02cd183e75e80afe76b5df41c0204 | [native] Use hooks in compose thread button
Test Plan: Flow, check if the button works ok
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/compose-thread-button.react.js",
"new_path": "native/chat/compose-thread-button.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { StyleSheet } from 'react-native';\nimport Icon from 'react... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hooks in compose thread button
Test Plan: Flow, check if the button works ok
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D554 |
129,191 | 31.12.2020 22:46:04 | 25,200 | 67bda27bd9b25b210096227dc5a205c9e8699f91 | [lib] Shim unsupported update relationship message
Test Plan: I removed min code version condition, sent a request and checked if the message was displayed correctly
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -732,6 +732,21 @@ function shimUnsupportedRawMessageInfos(\nrobotext: multimediaMessagePreview(shimmedRawMessageInfo),\nunsupportedMessageInfo: shimmedRawMessageInfo,\n};\n+ }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Shim unsupported update relationship message
Test Plan: I removed min code version condition, sent a request and checked if the message was displayed correctly
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D565 |
129,187 | 29.12.2020 01:09:28 | 18,000 | fbcd65535d2a4f400fb67423b7c36d813c2dc116 | [server] Script to rename user
Summary: This will change Atul's SquadCal username to `atul`
Test Plan: I ran the script with a test user in my local environment
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/rename-user.js",
"diff": "+// @flow\n+\n+import { updateTypes } from 'lib/types/update-types';\n+\n+import { createUpdates } from '../creators/update-creator';\n+import { dbQuery, SQL } from '../database/database';\n+import { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Script to rename user
Summary: This will change Atul's SquadCal username to `atul`
Test Plan: I ran the script with a test user in my local environment
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D563 |
129,183 | 22.12.2020 15:54:06 | -3,600 | 127950c99fe3cffd0296a9e8363aea33d999d75d | Add initialMessageID parameter when creating sidebar
Summary: First step of displaying message that started sidebar.
Test Plan: Make sure creating sidebars is possible only with new parameter, and all of the rest thread types do not have it
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -315,14 +315,24 @@ export type UpdateThreadRequest = {|\nchanges: ThreadChanges,\n|};\n-export type NewThreadRequest = {|\n- +type: ThreadType,\n+export type BaseNewThreadRequest ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add initialMessageID parameter when creating sidebar
Summary: First step of displaying message that started sidebar.
Test Plan: Make sure creating sidebars is possible only with new parameter, and all of the rest thread types do not have it
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adria... |
129,183 | 23.12.2020 14:21:24 | -3,600 | cbe6b3ed8a6ab81af96a8d9fc69bb8017f3ca314 | [server] Create function to fetch message info for id
Test Plan: Check if returned message info looks good, also tested together with next diff
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/message-fetchers.js",
"new_path": "server/src/fetchers/message-fetchers.js",
"diff": "@@ -675,6 +675,32 @@ async function fetchMessageInfoForEntryAction(\nreturn rawMessageInfoFromRows(result, viewer);\n}\n+async function fetchMessageInfoBy... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create function to fetch message info for id
Test Plan: Check if returned message info looks good, also tested together with next diff
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D548 |
129,187 | 03.01.2021 16:29:57 | 25,200 | 094a3926531311454bc793352a56053d4d89cf90 | [native] Fix dispatch call in ThemeHandler
Summary: I broke this in D558 :(
Test Plan: Make sure that status bar displays with dark text if OS is in light moded when booting a freshly installed native client
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/themes/theme-handler.react.js",
"new_path": "native/themes/theme-handler.react.js",
"diff": "@@ -35,7 +35,7 @@ function ThemeHandler() {\ndispatch({\ntype: updateThemeInfoActionType,\n- updateObject,\n+ payload: updateObject,\n});\n},\n[globalThemeInfo,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix dispatch call in ThemeHandler
Summary: I broke this in D558 :(
Test Plan: Make sure that status bar displays with dark text if OS is in light moded when booting a freshly installed native client
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul
Differential Revis... |
129,187 | 03.01.2021 17:19:32 | 25,200 | 386906cb15106e06f2ac5536ffafceb339b879e1 | [native] Convert MediaGalleryKeyboard data-binding to hook
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "import * as MediaLibrary from 'expo-media-library';\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert MediaGalleryKeyboard data-binding to hook
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D567 |
129,187 | 03.01.2021 19:16:35 | 25,200 | 352db962590d7b2e55bf9644e18fe191113a74c6 | [client] Use thread color for send icon
Test Plan: Make sure it looks right on web and native
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -512,6 +512,7 @@ class ChatInputBar extends React.PureComponent<Props, State> {\n</Animated.View>\n</TouchableOpacity>\n);\n+ const threadColor = `#${this.prop... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [client] Use thread color for send icon
Test Plan: Make sure it looks right on web and native
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D569 |
129,187 | 06.01.2021 12:58:36 | 18,000 | 2bf7fb6bb621609b701af8006fbfe9542f1aa0f2 | [native] codeVersion -> 74 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 74 |
129,183 | 04.01.2021 12:28:34 | -3,600 | 12e6af346b6f924cbb1cd7041893336ef5725312 | [native] Do not show sidebars below matching top-level threads in the search results
Test Plan: Check if matching top-level threads are displayed without sidebars below when search text is not empty
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -238,9 +238,9 @@ class ChatThreadList extends React.PureComponent<Props, State> {\ncontinue;\n}\nif (item.threadInfo.type === threadTypes.PERSONAL) {\n- pe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Do not show sidebars below matching top-level threads in the search results
Test Plan: Check if matching top-level threads are displayed without sidebars below when search text is not empty
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul
Differential Revision: https:/... |
129,187 | 07.01.2021 18:53:15 | 18,000 | 7f12502479bcf1d8b14a9bccf386da5fb5bedf23 | Remove calendar header | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -51,19 +51,6 @@ table.calendar > thead > tr > th {\nfont-size: 14px;\n}\ntextarea.entryText {\n- background: none;\n- width: 100%;\n- outline: none;\n- border: none;\n- resize: no... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove calendar header |
129,187 | 07.01.2021 18:54:09 | 18,000 | cebcc8d027dd1967525b8effea9ad3e6ea1d5317 | Rewrite calendar header from scratch | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -51,6 +51,19 @@ table.calendar > thead > tr > th {\nfont-size: 14px;\n}\ntextarea.entryText {\n+ box-sizing: border-box;\n+ font-family: -apple-system, BlinkMacSystemFont, \"Segoe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Rewrite calendar header from scratch |
129,187 | 11.01.2021 11:55:23 | 28,800 | 379751c2bf470b50c48d96b639008c3d6ffd1786 | Update to Comm | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "-## SquadCal\n+## Comm\n-SquadCal is the working name of this open source messaging project. The goal is to create a chat app that:\n-1. Is oriented around social planning,\n-2. Can support large communities, and\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update to Comm |
129,183 | 08.01.2021 14:20:46 | -3,600 | c70e96c4c087b739b9d423abf073aa1268ca787c | [web] Check if thread has VOICED permission to show reply tooltip
Test Plan: Check if reply tooltip is not displayed in threads without voiced permission
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/chat/text-message.react.js",
"new_path": "web/chat/text-message.react.js",
"diff": "@@ -6,9 +6,9 @@ import * as React from 'react';\nimport type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors';\nimport { onlyEmojiRegex } from 'lib/shared/emojis... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Check if thread has VOICED permission to show reply tooltip
Test Plan: Check if reply tooltip is not displayed in threads without voiced permission
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D575 |
129,187 | 12.01.2021 10:19:39 | 28,800 | e2371b4ddbfe0fe58c8dd6aaa52397bb540fc320 | [server] Script to add staff members
Test Plan: Run the script with my `test` user
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/add-staff.js",
"diff": "+// @flow\n+\n+import bots from 'lib/facts/bots';\n+\n+import { createScriptViewer } from '../session/scripts';\n+import { updateThread } from '../updaters/thread-updaters';\n+import { main } from './ut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Script to add staff members
Test Plan: Run the script with my `test` user
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D581 |
129,187 | 12.01.2021 11:15:39 | 28,800 | ee35c241672fbab2168b30d4e26cf7caf3d424f0 | [lib] Add staff.json and use it in isStaff
Summary: Now `isStaff` returns true for all four of us
Test Plan: Make sure I can still download an error report
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/facts/staff.json",
"diff": "+[\"256\",\"518252\",\"311149\",\"379341\"]\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/shared/user-utils.js",
"new_path": "lib/shared/user-utils.js",
"diff": "// @flow\n-import ashoat fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add staff.json and use it in isStaff
Summary: Now `isStaff` returns true for all four of us
Test Plan: Make sure I can still download an error report
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D582 |
129,187 | 12.01.2021 11:25:22 | 28,800 | d66d164ad501a5967e9fc095edd12a17684ba229 | [server] Add CreateThreadOptions type for createThread
Summary: I think this makes the code more readable at `createThread` callsites.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/bots/squadbot.js",
"new_path": "server/src/bots/squadbot.js",
"diff": "@@ -16,7 +16,9 @@ async function createSquadbotThread(userID: string): Promise<string> {\ntype: threadTypes.PERSONAL,\ninitialMemberIDs: [userID],\n};\n- const result = await cre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add CreateThreadOptions type for createThread
Summary: I think this makes the code more readable at `createThread` callsites.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D583 |
129,187 | 12.01.2021 15:43:08 | 28,800 | 48e6c28f548f4c041db40c3f9fb0f7e114e76700 | [native] Update default server URLs to use comm instead of squadcal
Summary: This fixes the `dev_environment.md` setup instructions.
Test Plan: Make sure that everything works on `http://localhost/comm/` after I update `server/facts/url.json` and `/private/etc/apache2/users/$USER.conf`
Reviewers: atul, subnub, palys-sw... | [
{
"change_type": "MODIFY",
"old_path": "native/utils/url-utils.js",
"new_path": "native/utils/url-utils.js",
"diff": "@@ -4,9 +4,9 @@ import invariant from 'invariant';\nimport { Platform } from 'react-native';\nconst productionServer = 'https://squadcal.org';\n-const localhostServer = 'http://local... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update default server URLs to use comm instead of squadcal
Summary: This fixes the `dev_environment.md` setup instructions.
Test Plan: Make sure that everything works on `http://localhost/comm/` after I update `server/facts/url.json` and `/private/etc/apache2/users/$USER.conf`
Reviewers: atul, subnub, palys... |
129,184 | 12.01.2021 19:42:26 | 28,800 | f638da040f1a7bf45b840aba30a7f0ca0ab1fde9 | .flowconfig M1 hack
Summary: Hack to get flow to run on Apple M1 Macs. Details:
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/.flowconfig",
"new_path": "lib/.flowconfig",
"diff": "[libs]\n[options]\n+sharedmemory.heap_size=3221225472\nesproposal.optional_chaining=enable\nesproposal.nullish_coalescing=enable\n"
},
{
"change_type": "MODIFY",
"old_path": "native/.flowcon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | .flowconfig M1 hack
Summary: Hack to get flow to run on Apple M1 Macs. Details: https://github.com/facebook/flow/issues/8538
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D588 |
129,184 | 12.01.2021 15:54:33 | 28,800 | ecfb48f1d12d836ebd51eb8e93018494a676a456 | added forceAddMembers option to updateThread() to support addStaff() script
Test Plan: Created test account, ran script, and verified account joined staff thread.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/add-staff.js",
"new_path": "server/src/scripts/add-staff.js",
"diff": "@@ -9,12 +9,18 @@ import { main } from './utils';\nconst newStaffIDs = ['518252'];\nasync function addStaff() {\n- await updateThread(createScriptViewer(bots.squadbot.use... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | added forceAddMembers option to updateThread() to support addStaff() script
Test Plan: Created test account, ran script, and verified account joined staff thread.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D585 |
129,184 | 12.01.2021 17:14:47 | 28,800 | f4b2795a15f59f2ed9f79e3e3691e73dae37c293 | imagePasted event emitter
Summary: textInputImagePasted() sends event with pasted image's file path to JS side
Test Plan: Successfully receiving events on JS side.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "patches/react-native+0.63.4.patch",
"new_path": "patches/react-native+0.63.4.patch",
"diff": "@@ -11,3 +11,65 @@ index 5dc03df..e526092 100644\n? (background, useForeground) =>\nuseForeground && TouchableNativeFeedback.canUseNativeForeground()\n? {nativeForegr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | imagePasted event emitter
Summary: textInputImagePasted() sends event with pasted image's file path to JS side
Test Plan: Successfully receiving events on JS side.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D586 |
129,187 | 13.01.2021 10:00:22 | 28,800 | c0cd09ee6bab8fc368fce9ebe60c6fc6601ccedc | [server] Script to add source message column to threads table
Test Plan: I ran it in my local environment
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/add-source-message-column.js",
"diff": "+// @flow\n+\n+import { dbQuery, SQL } from '../database/database';\n+import { main } from './utils';\n+\n+async function deleteUnreadColumn() {\n+ await dbQuery(SQL`\n+ ALTER TABLE thre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Script to add source message column to threads table
Test Plan: I ran it in my local environment
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D592 |
129,187 | 13.01.2021 11:13:33 | 28,800 | b91aeadf0e1e0897d0a7464a717e0b7a9925ea12 | [server] Rename initialMessageID to sourceMessageID
Summary: I noticed this was named differently, so just renaming it for consistency.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -334,7 +334,7 @@ export type NewThreadRequest =\n|}\n| {|\n+type: 5,\n- +initialMessageID: string,\n+ +sourceMessageID: string,\n...BaseNewThreadRequest,\n|};\n"
},
{
"cha... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rename initialMessageID to sourceMessageID
Summary: I noticed this was named differently, so just renaming it for consistency.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D594 |
129,187 | 13.01.2021 14:19:08 | 28,800 | 898c61e4816fc80cc3e9114e324c9adec6c36f61 | [server] Fix isSubthreadMember check in postMessageSend
Summary: Oops! We missed this spot when we introduced -1 as a possible value for the `role` column of `memberships`.
Test Plan: log the value on my server (very hard to test notifs locally)
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -288,7 +288,7 @@ async function postMessageSend(\n// Subthread info will be the same for each subthread, so we only parse\n// it once\nfor (const subthre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix isSubthreadMember check in postMessageSend
Summary: Oops! We missed this spot when we introduced -1 as a possible value for the `role` column of `memberships`.
Test Plan: log the value on my server (very hard to test notifs locally)
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, subn... |
129,187 | 13.01.2021 14:46:52 | 28,800 | 4cb6a710594e48d91657f8b5edc718bac967fc5e | [lib] Use 'sidebar' in notif text
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/notif-utils.js",
"new_path": "lib/shared/notif-utils.js",
"diff": "@@ -10,13 +10,13 @@ import {\ntype MessageType,\nmessageTypes,\n} from '../types/message-types';\n-import type { ThreadInfo } from '../types/thread-types';\n+import type { ThreadInfo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use 'sidebar' in notif text
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D597 |
129,187 | 13.01.2021 15:26:11 | 28,800 | 34a8148fdd0996a5a51ee215e50dcc1f99b34e7b | [lib] Fix robotext for CREATE_SUB_THREAD to handle sidebar
Summary: We use the string 'sidebar' instead of 'child thread' now. D573 handled `CREATE_THREAD` and `CREATE_SIDEBAR`, but not `CREATE_SUB_THREAD`.
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -28,7 +28,7 @@ import {\nmessageTypes,\nmessageTruncationStatus,\n} from '../types/message-types';\n-import type { ThreadInfo } from '../types/thread-types';\n+import { type T... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix robotext for CREATE_SUB_THREAD to handle sidebar
Summary: We use the string 'sidebar' instead of 'child thread' now. D573 handled `CREATE_THREAD` and `CREATE_SIDEBAR`, but not `CREATE_SUB_THREAD`.
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revisi... |
129,184 | 13.01.2021 16:56:21 | 28,800 | de1dc5dca7b9ed96f428b0e1a9ff3a2627527b64 | Types and additions to support photo_pasted
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -270,7 +270,30 @@ export type PhotoCapture = {|\nretries: number,\n|};\n-export type NativeMediaSelection = MediaLibrarySelection | PhotoCapture;\n+export type PhotoPaste = {|\n+ +s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Types and additions to support photo_pasted
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D599 |
129,184 | 14.01.2021 10:04:17 | 28,800 | cfeff0069315e882d9c6fa275081efa248828b98 | Getting image dimensions from objc side
Summary: Getting image height and width from UIImage and sending it over in event. Also, adding allowImagePaste prop in TextInput.js
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "patches/react-native+0.63.4.patch",
"new_path": "patches/react-native+0.63.4.patch",
"diff": "+diff --git a/node_modules/react-native/Libraries/Components/TextInput/TextInput.js b/node_modules/react-native/Libraries/Components/TextInput/TextInput.js\n+index b1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Getting image dimensions from objc side
Summary: Getting image height and width from UIImage and sending it over in event. Also, adding allowImagePaste prop in TextInput.js
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://p... |
129,183 | 14.01.2021 09:54:18 | -3,600 | e457238328747202534a1bf6501081072408e136 | [server] Convert source_message to string
Summary: ThreadInfo expects sourceMessageID to be a string
Test Plan: Checked if warnings are gone
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/thread-fetchers.js",
"new_path": "server/src/fetchers/thread-fetchers.js",
"diff": "@@ -53,7 +53,7 @@ async function fetchServerThreadInfos(\n: null,\nmembers: [],\nroles: {},\n- sourceMessageID: row.source_message,\n+ sourceMessageID: row.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Convert source_message to string
Summary: ThreadInfo expects sourceMessageID to be a string
Test Plan: Checked if warnings are gone
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D600 |
129,187 | 14.01.2021 18:01:03 | 28,800 | 56d525d49034ced5a69b37d91215fcb65bccff4b | [lib] Include sourceMessageID in rawThreadInfoFromThreadInfo
Summary: We don't actually use this function anywhere... but if it's in our codebase, it should work correctly, in case somebody does eventually use it for something.
Test Plan: careful inspection :)
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian,... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -507,7 +507,7 @@ function threadFrozenDueToViewerBlock(\n}\nfunction rawThreadInfoFromThreadInfo(threadInfo: ThreadInfo): RawThreadInfo {\n- return {\n+ const rawThreadInfo: Raw... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include sourceMessageID in rawThreadInfoFromThreadInfo
Summary: We don't actually use this function anywhere... but if it's in our codebase, it should work correctly, in case somebody does eventually use it for something.
Test Plan: careful inspection :)
Reviewers: palys-swm, KatPo
Reviewed By: KatPo
Subscri... |
129,191 | 11.01.2021 14:58:14 | -3,600 | 5da446f924b67fae83247f27c3cabf67e9a0a488 | [lib] Support other initial message types
Summary: All the types but SIDEBAR_SOURCE are supported
Test Plan: Created a new SIDEBAR SOURCE message in db, pointing to an image message. Verified that it was displayed correctly.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -544,8 +544,8 @@ function createMessageInfo(\nthreadInfos,\n);\ninvariant(\n- initialMessage && initialMessage.type === messageTypes.TEXT,\n- 'Sidebars can be created only fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Support other initial message types
Summary: All the types but SIDEBAR_SOURCE are supported
Test Plan: Created a new SIDEBAR SOURCE message in db, pointing to an image message. Verified that it was displayed correctly.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul
Differe... |
129,191 | 12.01.2021 16:18:35 | -3,600 | ba14dafee9c9d15aac8ef22eceaff1fd8d9e3226 | [server] Fetch all the initial messages in one query
Test Plan: Verify that sidebar source messages cause only one additional query
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/message-fetchers.js",
"new_path": "server/src/fetchers/message-fetchers.js",
"diff": "@@ -121,8 +121,9 @@ async function fetchCollapsableNotifs(\n}\n}\n+ const derivedMessages = await fetchDerivedMessages(collapseResult);\nfor (const userRo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fetch all the initial messages in one query
Test Plan: Verify that sidebar source messages cause only one additional query
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D589 |
129,191 | 14.01.2021 14:01:57 | -3,600 | c52234e0f99c43c1da3d39e4327498713e1c5244 | [lib] Use more precise types instead of invariant in newThreadRobotext
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -21,6 +21,8 @@ import {\nmessageTypes,\nmessageTruncationStatus,\n} from '../types/message-types';\n+import type { CreateSidebarMessageInfo } from '../types/message/create-sid... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use more precise types instead of invariant in newThreadRobotext
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D604 |
129,191 | 14.01.2021 17:22:30 | -3,600 | e668ded930ea3d2e5f52738579f2f48682b39b7f | [lib] Update create sidebar robotext
Test Plan: Create a message in db and check if it was displayed correctly
Reviewers: ashoat
Subscribers: subnub, atul, Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -92,14 +92,12 @@ function encodedThreadEntity(threadID: string, text: string): string {\n}\nfunction newThreadRobotext(\n- messageInfo: CreateThreadMessageInfo | CreateSidebar... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Update create sidebar robotext
Test Plan: Create a message in db and check if it was displayed correctly
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: subnub, atul, Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D607 |
129,187 | 15.01.2021 09:20:43 | 28,800 | 895b0326569d6f6110327b4e569557b261860859 | [web] Use hook for data-binding in App
Test Plan: Flow, run the website
Reviewers: palys-swm, subnub
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -6,10 +6,10 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport classNames from 'classnames';\nimport invariant from 'invariant';\nimport _isEqual from 'lodash/fp/isEqual';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook for data-binding in App
Test Plan: Flow, run the website
Reviewers: palys-swm, subnub
Reviewed By: subnub
Subscribers: KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D617 |
129,184 | 14.01.2021 13:35:48 | 28,800 | 4771f960ecd67ddc243d06682ab5f9733ef45a2d | Added PNG extension to appease EXImageLoader
Summary: Append PNG path extension to appease EXImageLoader. Note that our code ignores file extensions and looks at the magic numbers directly, and shouldn't be affected by this change.
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "patches/react-native+0.63.4.patch",
"new_path": "patches/react-native+0.63.4.patch",
"diff": "@@ -78,7 +78,7 @@ index 3e1839b..2df81fb 100644\n@optional\ndiff --git a/node_modules/react-native/Libraries/Text/TextInput/RCTBaseTextInputView.m b/node_modules/reac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Added PNG extension to appease EXImageLoader
Summary: Append PNG path extension to appease EXImageLoader. Note that our code ignores file extensions and looks at the magic numbers directly, and shouldn't be affected by this change.
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, ... |
129,187 | 15.01.2021 12:32:13 | 28,800 | b112b1548fb7d2ffe9b7832bdb2e2e0bd5f4d9c7 | Require curly braces for conditional blocks
Summary: Simple ESLint rule to require curly braces. More details [here](https://eslint.org/docs/rules/curly).
Test Plan: I misformatted a file and checked to make sure the formatting was fixed
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": ".eslintrc.json",
"new_path": ".eslintrc.json",
"diff": "\"parser\": \"babel-eslint\",\n\"plugins\": [\"react\", \"react-hooks\", \"flowtype\", \"monorepo\", \"import\"],\n\"rules\": {\n+ \"curly\": \"error\",\n\"linebreak-style\": \"error\",\n\"semi\": \"error... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Require curly braces for conditional blocks
Summary: Simple ESLint rule to require curly braces. More details [here](https://eslint.org/docs/rules/curly).
Test Plan: I misformatted a file and checked to make sure the formatting was fixed
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, A... |
129,191 | 15.01.2021 17:41:35 | -3,600 | ed62db69e20dddf9fc3ba9100a8e0bef3d70916a | [server] Create script which renames field in sidebar messages
Test Plan: Run the script and check if SIDEBAR_SOURCE and CREATE_SIDEBAR message were updated
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/rename-sidebar-message-fields.js",
"diff": "+// @flow\n+\n+import { messageTypes } from 'lib/types/message-types';\n+\n+import { dbQuery, SQL } from '../database/database';\n+import { main } from './utils';\n+\n+async function... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create script which renames field in sidebar messages
Test Plan: Run the script and check if SIDEBAR_SOURCE and CREATE_SIDEBAR message were updated
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D615 |
129,191 | 15.01.2021 17:44:22 | -3,600 | 40c937a343f47ede94d4e4f9fc7e0265a22b3860 | Rename initialMessage and initialMessageAuthor to sourceMessage and sourceMessageAuthor
Test Plan: Run the script from the previous diff and check if the message were displayed correctly. Flow.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -263,7 +263,7 @@ function createChatMessageItems(\nconst messageInfo = threadMessageInfos[i];\nconst originalMessageInfo =\nmessageInfo.type === messageTypes.SIDEBAR_S... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Rename initialMessage and initialMessageAuthor to sourceMessage and sourceMessageAuthor
Test Plan: Run the script from the previous diff and check if the message were displayed correctly. Flow.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://... |
129,184 | 19.01.2021 01:56:19 | 28,800 | dcc276a468aaf29084c8cb19b7c9a05b89c737e0 | Prevent image url from being pasted into text input when pasting image from browser
Summary: Minor fix to bypass pasting of image url
Test Plan: Tried it on a couple of images before and after change.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "patches/react-native+0.63.4.patch",
"new_path": "patches/react-native+0.63.4.patch",
"diff": "@@ -42,20 +42,25 @@ index 7e12add..6979293 100644\n@end\ndiff --git a/node_modules/react-native/Libraries/Text/TextInput/Multiline/RCTUITextView.m b/node_modules/reac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Prevent image url from being pasted into text input when pasting image from browser
Summary: Minor fix to bypass pasting of image url
Test Plan: Tried it on a couple of images before and after change.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revis... |
129,191 | 15.01.2021 16:04:52 | -3,600 | 5a24fffb682edebb617a9857ab85f5f1fa37a139 | [lib] Update notification text
Test Plan: I haven't tested it: we should probably think about finding a way to test notifications on local
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/notif-utils.js",
"new_path": "lib/shared/notif-utils.js",
"diff": "@@ -11,7 +11,6 @@ import {\nmessageTypes,\n} from '../types/message-types';\nimport type { ThreadInfo, ThreadType } from '../types/thread-types';\n-import { threadTypes } from '../ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Update notification text
Test Plan: I haven't tested it: we should probably think about finding a way to test notifications on local
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D614 |
129,191 | 20.01.2021 18:31:43 | -3,600 | 07d26f74fee8e4903831d7cdd41e6c604886d315 | [lib] Use message spec when shimming the message
Test Plan: Log out, log in, check sidebar source and create sidebar messages on version 74
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "import invariant from 'invariant';\nimport _maxBy from 'lodash/fp/maxBy';\n-import { shimUploadURI, multimediaMessagePreview } from '../media/media-utils';\n+import { multimediaM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use message spec when shimming the message
Test Plan: Log out, log in, check sidebar source and create sidebar messages on version 74
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D638 |
129,184 | 20.01.2021 19:26:07 | 28,800 | 17e95734fd902cbdc6ba1074e541e32d0dda663e | update
Summary: Updated react-navigation/stack from 5.12.6 to 5.12.8 to resolve issue where keyboard was not being dismissed when modal was displayed
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"@react-navigation/devtools\": \"^5.1.17\",\n\"@react-navigation/material-top-tabs\": \"^5.3.9\",\n\"@react-navigation/native\": \"^5.8.9\",\n- \"@react-navigation/stack\": \"^5.12.6\",\n+ \"@r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | update @react-navigation/stack
Summary: Updated react-navigation/stack from 5.12.6 to 5.12.8 to resolve issue where keyboard was not being dismissed when modal was displayed
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://... |
129,191 | 22.01.2021 12:51:16 | -3,600 | a2ac274e4fdc0d88e2df4ba482fcd8eef02d609b | [lib] Use message specs when creating notification collapse key
Test Plan: Flow. Again, testing notifs is hard.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "@@ -10,6 +10,7 @@ import type {\n} from '../../types/message/add-members';\nimport { values } from '../../utils/objects';\nimport type { M... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use message specs when creating notification collapse key
Test Plan: Flow. Again, testing notifs is hard.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D645 |
129,191 | 22.01.2021 15:38:44 | -3,600 | fef18b10d35f948547ce43ada672f553fa6afa2f | [lib] Use message specs to get a list of referenced users
Test Plan: Flow.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "@@ -98,4 +98,8 @@ export const addMembersMessageSpec: MessageSpec<\n},\ngeneratesNotifs: false,\n+\n+ userIDs(rawMessageInfo) {\n+ return ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use message specs to get a list of referenced users
Test Plan: Flow.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D647 |
129,191 | 25.01.2021 12:10:40 | -3,600 | 40ca72d3408825e4949fc2c6aac47e606ef92c50 | [lib] Use rawMessageInfoFromMessageData in createMediaMessageInfo function
Test Plan: Flow. Log out, log in, check messages
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -304,23 +304,8 @@ function createMediaMessageInfo(\ninput: MediaMessageInfoCreationInput,\n): RawMultimediaMessageInfo {\nconst messageData = createMediaMessageData(input);\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use rawMessageInfoFromMessageData in createMediaMessageInfo function
Test Plan: Flow. Log out, log in, check messages
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D651 |
129,191 | 25.01.2021 12:50:28 | -3,600 | 4d081fc7c92ef297042a07bcadeaf62aa56b1f31 | [lib] Remove message type switch from stripLocalIDs function
Test Plan: Created new text message and console logged the result of stripLocalIDs function
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -20,15 +20,10 @@ import {\ntype MessageStore,\nmessageTypes,\nmessageTruncationStatus,\n+ type RawComposableMessageInfo,\n} from '../types/message-types';\n-import type {\n- I... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Remove message type switch from stripLocalIDs function
Test Plan: Created new text message and console logged the result of stripLocalIDs function
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D652 |
129,183 | 14.01.2021 13:25:58 | -3,600 | e6d0fbbdafdebd45810b6bc386d8e52e748ff112 | Extract createPendingSidebar function
Summary: createPendingSidebar will be used in other tooltips
Test Plan: Flow, make sure creating sidebars from text messages still works
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -10,6 +10,7 @@ import {\nmakePermissionsBlob,\n} from '../permissions/thread-permissions';\nimport type { ChatThreadItem } from '../selectors/chat-selectors';\n+import type { Te... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extract createPendingSidebar function
Summary: createPendingSidebar will be used in other tooltips
Test Plan: Flow, make sure creating sidebars from text messages still works
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.as... |
129,183 | 14.01.2021 13:31:09 | -3,600 | 306ad4eb0427fd67715e279ddfe0d5dfee398ebf | Add option to create sidebar for multimedia message
Test Plan: Check if tooltip have new button, if sidebars are created with correct multimedia message as source and if the message is displayed correctly
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -10,6 +10,7 @@ import {\nmakePermissionsBlob,\n} from '../permissions/thread-permissions';\nimport type { ChatThreadItem } from '../selectors/chat-selectors';\n+import type { Mu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add option to create sidebar for multimedia message
Test Plan: Check if tooltip have new button, if sidebars are created with correct multimedia message as source and if the message is displayed correctly
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Rev... |
129,183 | 20.01.2021 12:18:58 | -3,600 | a8a5ccb4062dba530386e34521b35dbce257aaa0 | Use relationshipBlockedInEitherDirection function
Test Plan: Flow, make sure everything works as before
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -38,6 +38,7 @@ import type {\nUserInfos,\n} from '../types/user-types';\nimport { pluralize } from '../utils/text-utils';\n+import { relationshipBlockedInEitherDirection } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use relationshipBlockedInEitherDirection function
Test Plan: Flow, make sure everything works as before
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D633 |
129,191 | 25.01.2021 13:04:24 | -3,600 | b9202ead6d2e9695c66f5cbeab8d9ec5f2233652 | [lib] Use message spec when determining truncation status
Test Plan: Log out, log in, using console log check if the right truncation status is set for the messages
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-thread-message-spec.js",
"new_path": "lib/shared/messages/create-thread-message-spec.js",
"diff": "@@ -122,4 +122,6 @@ export const createThreadMessageSpec: MessageSpec<\nuserIDs(rawMessageInfo) {\nreturn rawMessageInfo.initialThread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use message spec when determining truncation status
Test Plan: Log out, log in, using console log check if the right truncation status is set for the messages
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D654 |
129,191 | 25.01.2021 14:19:56 | -3,600 | 15c74210f6cb41927dd27ec6bc52243b5605ea64 | [lib] Use message spec to return a list of thread ids
Test Plan: Console log in fetchInfos to check if thread id was added when creating a subthread
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sidebar-message-spec.js",
"new_path": "lib/shared/messages/create-sidebar-message-spec.js",
"diff": "@@ -138,4 +138,9 @@ export const createSidebarMessageSpec: MessageSpec<\nuserIDs(rawMessageInfo) {\nreturn rawMessageInfo.initialThr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use message spec to return a list of thread ids
Test Plan: Console log in fetchInfos to check if thread id was added when creating a subthread
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D655 |
129,187 | 26.01.2021 13:01:42 | 18,000 | f8775a40c9e5310396105a77a15c8b09b7a617b7 | [web] Fix minor typo in web SidebarListModal
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "web/modals/chat/sidebar-list-modal.react.js",
"new_path": "web/modals/chat/sidebar-list-modal.react.js",
"diff": "@@ -21,7 +21,7 @@ type Props = {|\n+setModal: (modal: ?React.Node) => void,\n+threadInfo: ThreadInfo,\n|};\n-function SidebarsListModal(props: Pro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix minor typo in web SidebarListModal
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D657 |
129,183 | 27.01.2021 08:54:48 | -3,600 | 598944f19e79ce1458f8cb09e9517551bd1aead9 | [lib] Create function to determine thread label from thread type
Test Plan: Flow, tested with next diffs
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -684,6 +684,21 @@ function threadNoun(threadType: ThreadType) {\nreturn threadType === threadTypes.SIDEBAR ? 'sidebar' : 'thread';\n}\n+function threadLabel(threadType: ThreadTy... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Create function to determine thread label from thread type
Test Plan: Flow, tested with next diffs
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D658 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.