author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,183 | 27.01.2021 08:55:44 | -3,600 | c76d7911461a57ab79c465253f111ed7f26bedf7 | [native] Use threadLabel function in ThreadVisibility
Test Plan: Tested all of thread types and checked if label is displayed correctly
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-visibility.react.js",
"new_path": "native/components/thread-visibility.react.js",
"diff": "import * as React from 'react';\nimport { View, Text, StyleSheet } from 'react-native';\n-import { threadTypes, type ThreadType } from 'lib/type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use threadLabel function in ThreadVisibility
Test Plan: Tested all of thread types and checked if label is displayed correctly
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D659 |
129,183 | 27.01.2021 09:42:51 | -3,600 | 67fa14923ddeec192b658ea18d24621179482573 | [lib] Update robotext message when changing thread type
Test Plan: Tested if robotext is displayed correctly when thread type is changed
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/change-settings-message-spec.js",
"new_path": "lib/shared/messages/change-settings-message-spec.js",
"diff": "@@ -8,6 +8,8 @@ import type {\nChangeSettingsMessageInfo,\nRawChangeSettingsMessageInfo,\n} from '../../types/message/change-setti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Update robotext message when changing thread type
Test Plan: Tested if robotext is displayed correctly when thread type is changed
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D660 |
129,191 | 27.01.2021 14:28:32 | -3,600 | 0188f749caa83cc27df89f020ff332ad66765dc8 | [lib] Allow displaying unsupported message robotext without the creator
Test Plan: Removed SIDEBAR_SOURCE from localUnshimTypes and checked if `first message in sidebar` was displayed (without the creator)
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/sidebar-source-message-spec.js",
"new_path": "lib/shared/messages/sidebar-source-message-spec.js",
"diff": "@@ -90,6 +90,7 @@ export const sidebarSourceMessageSpec: MessageSpec<\ncreatorID: rawMessageInfo.creatorID,\ntime: rawMessageInfo.ti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Allow displaying unsupported message robotext without the creator
Test Plan: Removed SIDEBAR_SOURCE from localUnshimTypes and checked if `first message in sidebar` was displayed (without the creator)
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revisi... |
129,183 | 29.01.2021 13:37:58 | -3,600 | 1424f5426bd5b14383c10464772b99abc5ea6450 | [native] Extract onPressCreateSidebar function
Test Plan: Flow, check if creating sidebars works as before for all message types
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-tooltip-modal.react.js",
"new_path": "native/chat/multimedia-tooltip-modal.react.js",
"diff": "// @flow\n-import invariant from 'invariant';\n-\n-import { createPendingSidebar } from 'lib/shared/thread-utils';\nimport type { MediaInfo } ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extract onPressCreateSidebar function
Test Plan: Flow, check if creating sidebars works as before for all message types
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D674 |
129,183 | 29.01.2021 13:41:09 | -3,600 | b59ac70475d317db1f46facb5086c3bef0cb9db0 | [native] Remove unused param from robotext tooltip params
Summary: I introduced it in D622 but ended up not using it
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/chat/robotext-message-tooltip-modal.react.js",
"new_path": "native/chat/robotext-message-tooltip-modal.react.js",
"diff": "@@ -11,7 +11,6 @@ import { onPressGoToSidebar, onPressCreateSidebar } from './sidebar-navigation';\nexport type RobotextMessageToo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove unused param from robotext tooltip params
Summary: I introduced it in D622 but ended up not using it
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D675 |
129,191 | 28.01.2021 14:09:23 | -3,600 | 1b214de833f39b456e3848d9e6a0f7ebc431f4fe | [native] Avoid undefined error when logging out with sidebar opened
Test Plan: Open sidebar and log in: the operation should be successful
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/chat/robotext-message.react.js",
"new_path": "native/chat/robotext-message.react.js",
"diff": "@@ -10,6 +10,7 @@ import { relationshipBlockedInEitherDirection } from 'lib/shared/relationship-ut\nimport { threadHasPermission } from 'lib/shared/thread-uti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid undefined error when logging out with sidebar opened
Test Plan: Open sidebar and log in: the operation should be successful
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D670 |
129,184 | 27.01.2021 12:59:21 | 28,800 | 8630d90d87c76129c7269f81faca4fe314ed9afa | Passing onTranscodingProgress down to ffmpeg statistics
Summary: Passing onTranscodingProgress callback down to ffmpeg so statistics can be "accessed" by inputStateContainer
Test Plan: Logged call to onTranscodingProgress and saw visual indication of progress.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411,... | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -69,6 +69,7 @@ import type { AppState } from '../redux/redux-setup';\nimport {\nInputStateContext,\ntype PendingMultimediaUploads,\n+ type Mult... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Passing onTranscodingProgress down to ffmpeg statistics
Summary: Passing onTranscodingProgress callback down to ffmpeg so statistics can be "accessed" by inputStateContainer
Test Plan: Logged call to onTranscodingProgress and saw visual indication of progress.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subsc... |
129,191 | 25.01.2021 14:19:56 | -3,600 | 1c93030a987102ea1ebfab5f607c15e94e46481d | move trim text to text-utils
Summary: move trim text from notif-utils to text-utils in order to make it more reusable
Test Plan: use the `trimText` function
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/notif-utils.js",
"new_path": "lib/shared/notif-utils.js",
"diff": "@@ -11,6 +11,7 @@ import {\nimport type { NotifTexts } from '../types/notif-types';\nimport type { ThreadInfo, ThreadType } from '../types/thread-types';\nimport type { RelativeUserI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | move trim text to text-utils
Summary: move trim text from notif-utils to text-utils in order to make it more reusable
Test Plan: use the `trimText` function
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.as... |
129,191 | 02.02.2021 11:54:22 | -3,600 | 263480781af5be2bf862c3a39a76fdd0538d01e8 | [server] Add replies count column
Test Plan: Run the script and check db schema. Create a new thread and check if the column value was set to 0.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/add-replies-count-column.js",
"diff": "+// @flow\n+\n+import { dbQuery, SQL } from '../database/database';\n+import { main } from './utils';\n+\n+async function addColumn() {\n+ const update = SQL`\n+ ALTER TABLE threads\n+ AD... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add replies count column
Test Plan: Run the script and check db schema. Create a new thread and check if the column value was set to 0.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D678 |
129,191 | 02.02.2021 12:41:53 | -3,600 | 3f9fb62783bf145fde630164889f5e00e4a9f327 | [lib] Add a new property to message spec telling if we should include the message in replies count
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/message-spec.js",
"new_path": "lib/shared/messages/message-spec.js",
"diff": "@@ -84,4 +84,5 @@ export type MessageSpec<Data, RawInfo, Info> = {|\n+userIDs?: (rawMessageInfo: RawInfo) => $ReadOnlyArray<string>,\n+startsThread?: boolean,\n+t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add a new property to message spec telling if we should include the message in replies count
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D682 |
129,191 | 02.02.2021 13:52:08 | -3,600 | c379523ea000f3d80d67bf055c1d5251a2ce2eb5 | [lib] Include replies count in thread types and fetch it from the db
Test Plan: Flow, log out, log in, check replies count in threads store using the debugger
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -285,6 +285,7 @@ function createPendingThread({\n},\nunread: false,\n},\n+ repliesCount: 0,\n};\nconst userInfos = Object.fromEntries(\n@@ -412,6 +413,7 @@ function rawThreadInf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include replies count in thread types and fetch it from the db
Test Plan: Flow, log out, log in, check replies count in threads store using the debugger
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.... |
129,191 | 02.02.2021 15:13:22 | -3,600 | abd1465166645540942346d74a50feb70efd6f95 | [server] Create migration script which computes replies count for sidebars
Test Plan: Run the script and check that the count was set properly for all the sidebars
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/compute_replies_count.js",
"diff": "+// @flow\n+\n+import { messageSpecs } from 'lib/shared/messages/message-specs';\n+import { messageTypes } from 'lib/types/message-types';\n+import { threadTypes } from 'lib/types/thread-typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create migration script which computes replies count for sidebars
Test Plan: Run the script and check that the count was set properly for all the sidebars
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.as... |
129,190 | 29.01.2021 09:53:09 | -3,600 | d425203864bba01eb4c3bb6b0e8ec9498f69c49c | Add a title to the sidebar for text messages
Summary: Add a title to the sidebar for text messages
Test Plan: Add new sidebars and see their titles inside of them and on the main chat screen
Reviewers: ashoat, palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -18,6 +18,7 @@ import {\ntype MessageTruncationStatus,\ntype MultimediaMessageData,\ntype MessageStore,\n+ type ComposableMessageInfo,\nmessageTypes,\nmessageTruncationStatus,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add a title to the sidebar for text messages
Summary: Add a title to the sidebar for text messages
Test Plan: Add new sidebars and see their titles inside of them and on the main chat screen
Reviewers: ashoat, palys-swm, KatPo
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential... |
129,191 | 04.02.2021 11:34:35 | -3,600 | a58652b6627972af93f3683a3cfed8f00f72aaad | [native] Display number of replies
Test Plan: Open two instances of the app, with different users. Send a message to a sidebar and check if replies count increases in the other app.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inline-sidebar.react.js",
"new_path": "native/chat/inline-sidebar.react.js",
"diff": "@@ -46,11 +46,15 @@ function InlineSidebar(props: Props) {\n}\nconst unreadStyle = threadInfo.currentUser.unread ? styles.unread : null;\n+ const repliesCount = t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Display number of replies
Test Plan: Open two instances of the app, with different users. Send a message to a sidebar and check if replies count increases in the other app.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: http... |
129,191 | 04.02.2021 15:19:38 | -3,600 | f97ca9d9ee1beaea1136ca622b67ed36aa4d56d9 | [server] Add sender column to memberships table
Test Plan: Run the script and check if the column was added.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/add-sender-column.js",
"diff": "+// @flow\n+\n+import { dbQuery, SQL } from '../database/database';\n+import { main } from './utils';\n+\n+async function addColumn() {\n+ const update = SQL`\n+ ALTER TABLE memberships\n+ ADD s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add sender column to memberships table
Test Plan: Run the script and check if the column was added.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D694 |
129,191 | 04.02.2021 15:44:16 | -3,600 | f4c4c480c6fcc2c294d97a00bdde0d24732995ef | [server] Update sender column
Test Plan: Send a message and check if the column was updated in db
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -186,9 +186,12 @@ async function updateRepliesCount(\nnewMessageDatas: MessageData[],\n) {\nconst updatedThreads = [];\n- const update = SQL`\n+\n+ const... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update sender column
Test Plan: Send a message and check if the column was updated in db
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D695 |
129,191 | 04.02.2021 16:56:02 | -3,600 | 70896659c39fd3174f83a5fcb887511d92a7469e | [lib] Add isSender to membership type and fetch it from db
Test Plan: Log out, log in, check in the debugger if thread store contains correct isSender values
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/user-selectors.js",
"new_path": "lib/selectors/user-selectors.js",
"diff": "@@ -87,6 +87,7 @@ const baseRelativeMemberInfoSelectorForMembersOfThread = (\npermissions: memberInfo.permissions,\nusername,\nisViewer: true,\n+ isSender: memberInfo.isS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add isSender to membership type and fetch it from db
Test Plan: Log out, log in, check in the debugger if thread store contains correct isSender values
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.c... |
129,184 | 01.02.2021 13:29:43 | 28,800 | 95d2bac5987931b291a1c5b1e69d1b39a3be20c7 | Modified validateAndConvert to handle video upload
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/media/file-utils.js",
"new_path": "lib/media/file-utils.js",
"diff": "@@ -8,31 +8,35 @@ import type { MediaType } from '../types/media-types';\ntype ResultMIME = 'image/png' | 'image/jpeg';\ntype MediaConfig = {|\n- mediaType: 'photo' | 'video' | 'photo_or... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Modified validateAndConvert to handle video upload
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D677 |
129,184 | 03.02.2021 06:27:46 | 28,800 | 6432699fb238e197dc8e8bd88ac5714da1bf51a6 | Show processingStep in multimedia progress indicator
Summary: Added text in multimedia progress indicator to show processingStep.
Test Plan: Tested with the usual video message scenarios (iOS/android, aspect ratios, multi-upload)
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inline-multimedia.react.js",
"new_path": "native/chat/inline-multimedia.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { View, StyleSheet } from 'react-native';\n+import { View, StyleSheet, Text } from 'react-native';\nimpor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Show processingStep in multimedia progress indicator
Summary: Added text in multimedia progress indicator to show processingStep.
Test Plan: Tested with the usual video message scenarios (iOS/android, aspect ratios, multi-upload)
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adria... |
129,191 | 04.02.2021 17:26:55 | -3,600 | a1ec80be6ceb4c366a8ee2178bf7954d2533c72b | [native] Display the senders
Test Plan: Open a parent thread and check if senders were displayed correctly
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/text-utils.js",
"new_path": "lib/utils/text-utils.js",
"diff": "@@ -31,4 +31,17 @@ function trimText(text: string, maxLength: number): string {\nreturn text.substr(0, maxLength - 3) + '...';\n}\n-export { pluralize, trimText };\n+function pluralizeAn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Display the senders
Test Plan: Open a parent thread and check if senders were displayed correctly
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D698 |
129,187 | 06.02.2021 13:00:35 | 18,000 | 5e48d9ce43115c2753523bde205234496b1127f3 | Increase heap_size in .flowconfig to max for M1
Summary: Based on [this comment](https://github.com/facebook/flow/issues/8538#issuecomment-774419666), but would be great if could test it out locally.
Test Plan: tests it :)
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/.flowconfig",
"new_path": "lib/.flowconfig",
"diff": "[libs]\n[options]\n-sharedmemory.heap_size=3221225472\n+sharedmemory.heap_size=4221225472\n+\nesproposal.optional_chaining=enable\nesproposal.nullish_coalescing=enable\n"
},
{
"change_type": "MO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Increase heap_size in .flowconfig to max for M1
Summary: Based on [this comment](https://github.com/facebook/flow/issues/8538#issuecomment-774419666), but would be great if @atul could test it out locally.
Test Plan: @atul tests it :)
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adri... |
129,191 | 04.02.2021 16:26:41 | -3,600 | f5a60bccdc3b4fd060bf8efcaa062219f3847167 | [server] Add migration script which computes sender status
Test Plan: Run the script and check in db if the status was set correctly
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/determine-sender-status.js",
"diff": "+// @flow\n+\n+import { messageSpecs } from 'lib/shared/messages/message-specs';\n+import { messageTypes } from 'lib/types/message-types';\n+import { updateTypes } from 'lib/types/update-t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add migration script which computes sender status
Test Plan: Run the script and check in db if the status was set correctly
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D696 |
129,191 | 08.02.2021 12:04:46 | -3,600 | 29f8791294c06f1f87f7649b3c9a76d061dfc839 | [server] Create setup sidebars script
Test Plan: Run the script when the columns were present and check the result. Drop columns, run and check again.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "DELETE",
"old_path": "server/src/scripts/add-replies-count-column.js",
"new_path": null,
"diff": "-// @flow\n-\n-import { dbQuery, SQL } from '../database/database';\n-import { main } from './utils';\n-\n-async function addColumn() {\n- const update = SQL`\n- ALTER TABLE threads\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create setup sidebars script
Test Plan: Run the script when the columns were present and check the result. Drop columns, run and check again.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D704 |
129,184 | 08.02.2021 05:59:09 | 28,800 | 058708f3fbbf910ef32d1f9bcb01bec1bd3064d8 | Minor color change for consistency in thread settings
Summary: Changed `addIcon` color in thread settings to be consistent with text (green -> blue)
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-list-action.react.js",
"new_path": "native/chat/settings/thread-settings-list-action.react.js",
"diff": "@@ -100,7 +100,7 @@ const unboundStyles = {\npaddingTop: Platform.OS === 'ios' ? 4 : 1,\n},\naddIcon: {\n- color: '#00... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Minor color change for consistency in thread settings
Summary: Changed `addIcon` color in thread settings to be consistent with text (green -> blue)
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
Differential Revision: https://phabricat... |
129,208 | 08.02.2021 12:50:31 | 18,000 | e0e6fddccdccf242892744d6b20dd6a63307a8a0 | [server] Added -1 type support to changeRole and changeRoleThreadQuery
Summary: Added -1 type support to changeRole and changeRoleThreadQuery.
Test Plan: Ran flow and made sure accounts could still be created and threads still work.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -61,6 +61,7 @@ type MembershipRowToDelete = {|\noperation: 'delete',\nuserID: string,\nthreadID: string,\n+ forceRowCreation?: bool... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Added -1 type support to changeRole and changeRoleThreadQuery
Summary: Added -1 type support to changeRole and changeRoleThreadQuery.
Test Plan: Ran flow and made sure accounts could still be created and threads still work.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Ad... |
129,208 | 08.02.2021 13:17:08 | 18,000 | 787d7c31eb98a1ba0c942bf92440642a26279748 | [server] Added ghostMemberIDs type to BaseNewThreadRequest
Summary: Added ghostMemberIDs
Test Plan: Tested with flow, also made sure createThread still works.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -338,6 +338,7 @@ export type BaseNewThreadRequest = {|\n+color?: ?string,\n+parentThreadID?: ?string,\n+initialMemberIDs?: ?$ReadOnlyArray<string>,\n+ +ghostMemberIDs?: ?$ReadOnly... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Added ghostMemberIDs type to BaseNewThreadRequest
Summary: Added ghostMemberIDs
Test Plan: Tested with flow, also made sure createThread still works.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D671 |
129,183 | 02.02.2021 08:39:41 | -3,600 | 358ba256e0d7f7d80b3faab32ba4f2c7888950cb | [web] Display sidebars inline
Test Plan: Check if sidebars are displayed inline correctly, if pressing navigates to correct sidebar and if styling matches native
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -368,3 +368,38 @@ div.imageGrid > span.multimedia:nth-last-child(n+5):first-child,\ndiv.imageGrid > span.multimedia:nth-last-child(n+5):first-child ~ * {\ngrid-column-en... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display sidebars inline
Test Plan: Check if sidebars are displayed inline correctly, if pressing navigates to correct sidebar and if styling matches native
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.... |
129,191 | 09.02.2021 14:42:16 | -3,600 | 08a4d1ec04e8f53f56415b7a243cf096a93f8758 | [web] Add option to open empty pending thread
Summary: Introduce new nav params (pendingThread and sourceMessage)
Test Plan: Create a button which calls useOnCLickPendingSidebar, click it and verify that empty page is displayed (app should not crash)
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub... | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -349,7 +349,7 @@ export default React.memo<BaseProps>(function ConnectedApp(props: BaseProps) {\nconst activeThreadCurrentlyUnread = useSelector(\n(state) =>\n!activeChatThreadID ||\n- !!state.thre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add option to open empty pending thread
Summary: Introduce new nav params (pendingThread and sourceMessage)
Test Plan: Create a button which calls useOnCLickPendingSidebar, click it and verify that empty page is displayed (app should not crash)
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu... |
129,184 | 12.02.2021 15:20:27 | 28,800 | 359b7644fd2b33bbf8ff9a9a4ad5a0d4b11f9551 | Image paste modal cleanup
Summary: Removed extraneous styles and closing tags.
Test Plan: Tested on iOS and everything looks and works the same.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/image-paste-modal.react.js",
"new_path": "native/chat/image-paste-modal.react.js",
"diff": "@@ -57,37 +57,26 @@ function ImagePasteModal(props: Props) {\nsafeAreaEdges={['top']}\n>\n<Image style={styles.image} source={{ uri: imagePasteStagingInfo.u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Image paste modal cleanup
Summary: Removed extraneous styles and closing tags.
Test Plan: Tested on iOS and everything looks and works the same.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D723 |
129,184 | 12.02.2021 15:03:10 | 28,800 | 35e8bca35b70b4eb9857868579719c14b98433d0 | Animate video playback modal in/out
Summary: Code written by Ashoat during video call explaining animations using the reanimated library.
Test Plan: Tested basic functionality on iOS. Will test media pipeline scenarios comprehensively after the remaining modal animation diffs.
Reviewers: ashoat, palys-swm
Subscribers: ... | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "@@ -5,18 +5,45 @@ import * as React from 'react';\nimport { useState } from 'react';\nimport { View, Text, TouchableWithoutFeedback } from 'react-na... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Animate video playback modal in/out
Summary: Code written by Ashoat during video call explaining animations using the reanimated library.
Test Plan: Tested basic functionality on iOS. Will test media pipeline scenarios comprehensively after the remaining modal animation diffs.
Reviewers: ashoat, palys-swm
Reviewed ... |
129,184 | 15.02.2021 01:59:11 | 28,800 | b0c91b0f91f32ff151104f85cb65939687eba0e0 | Toggle between video playback and multimedia modal
Summary: Display VideoPlaybackModal or MultimediaModal based on mediaInfo.type
Test Plan: Tested on iOS. Will test media pipeline scenarios comprehensively after the modal animation diffs.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karo... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "@@ -22,8 +22,9 @@ import {\nOverlayContext,\ntype OverlayContextType,\n} from '../navigation/overlay-context';\n-import type { Navig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Toggle between video playback and multimedia modal
Summary: Display VideoPlaybackModal or MultimediaModal based on mediaInfo.type
Test Plan: Tested on iOS. Will test media pipeline scenarios comprehensively after the modal animation diffs.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu... |
129,184 | 16.02.2021 00:29:47 | 28,800 | 48c364f1e4d1ea37865396bad7044817fb34b519 | [native] Use hook instead of connect functions and HOC in Modal
Summary: NA
Test Plan: Tried various modals (eg ImagePickerModal, ColorPickerModal) and they worked as before.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/thread-picker-modal.react.js",
"new_path": "native/calendar/thread-picker-modal.react.js",
"diff": "@@ -77,7 +77,7 @@ function ThreadPickerModal(props: Props) {\nonScreenEntryEditableThreadInfos(state),\n);\nreturn (\n- <Modal navigation={navig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in Modal
Summary: NA
Test Plan: Tried various modals (eg ImagePickerModal, ColorPickerModal) and they worked as before.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
Differential Revision: https... |
129,191 | 11.02.2021 18:21:59 | -3,600 | 129f18bd64fa4d3239f1dc271d1bb6ffcc57e2a0 | [lib] Extract real thread creation hook
Test Plan: Open pending sidebar, send couple of messages and check if exactly one sidebar was created.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -10,6 +10,7 @@ import {\nfetchMostRecentMessagesActionTypes,\nfetchMostRecentMessages,\n} from '../actions/message-actions';\n+import { newThread, newThreadActionTypes } from '.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Extract real thread creation hook
Test Plan: Open pending sidebar, send couple of messages and check if exactly one sidebar was created.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D718 |
129,183 | 17.02.2021 14:45:46 | -3,600 | 76e8aae6829441b84c6cb548f0d9985f27d63ffa | [web] Use correct icon
Summary: When I introduced D681, I accidentally changed icon used for composed message send status. This diff just brings it back
Test Plan: Make sure correct icon is displayed
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -4,7 +4,7 @@ import classNames from 'classnames';\nimport invariant from 'invariant';\nimport * as React from 'react';\nimport {\n- CornerDownRight as CircleIcon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use correct icon
Summary: When I introduced D681, I accidentally changed icon used for composed message send status. This diff just brings it back
Test Plan: Make sure correct icon is displayed
Reviewers: ashoat, palys-swm
Reviewed By: palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub, karol-bisztyga
D... |
129,184 | 15.02.2021 01:13:42 | 28,800 | 9e347b7a4d33852d54d22b90daa6c9526fe369ff | Podfile and xcodeproj tweaks for M1 iOS Simulator
Test Plan: I don't think these settings should affect Intel Macs.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile",
"new_path": "native/ios/Podfile",
"diff": "@@ -30,5 +30,11 @@ target 'SquadCal' do\nend\nend\nend\n+\n+ # M1 Simulator fix\n+ installer.pods_project.build_configurations.each do |config|\n+ config.build_settings[\"EXCLUDED_ARCHS[sdk=iphone... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Podfile and xcodeproj tweaks for M1 iOS Simulator
Test Plan: I don't think these settings should affect Intel Macs.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D724 |
129,191 | 17.02.2021 10:21:48 | -3,600 | b54974bb7d3fc0c06cdc5d1e3e6fcec87810c86a | [native] Create real thread when image is sent by pasting
Test Plan: Paste an image in pending sidebar and check if the thread was created
Reviewers: ashoat, atul
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -866,11 +866,18 @@ export default React.memo<BaseProps>(function ConnectedChatInputBar(\nname: ImagePasteModalRouteName,\nparams: {\nimagePasteStagingInfo: pas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create real thread when image is sent by pasting
Test Plan: Paste an image in pending sidebar and check if the thread was created
Reviewers: ashoat, atul
Reviewed By: ashoat, atul
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D735 |
129,187 | 19.02.2021 07:01:24 | 25,200 | 94387487bcd36c293a3ec58d03682957c76de274 | [native] Avoid importing useSelector directly from react-redux
Summary: Additional context [here](https://phabricator.ashoat.com/D743#inline-3620)
Test Plan: Flow
Reviewers: KatPo, subnub, palys-swm
Subscribers: zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "@@ -4,7 +4,6 @@ import invariant from 'invariant';\nimport * as React from 'react';\nimport { View, StyleSheet } from 'react-native'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid importing useSelector directly from react-redux
Summary: Additional context [here](https://phabricator.ashoat.com/D743#inline-3620)
Test Plan: Flow
Reviewers: KatPo, subnub, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://p... |
129,191 | 22.02.2021 12:30:34 | -3,600 | ca40e4328e32ed376e110e8984a4593a5006d24a | [lib] Add explicit type to messageContent functions
Summary: It appears that flow has some issues in determining the type of parameters inside spec functions. This is the first diff which adds explicit type annotations.
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyg... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "@@ -22,7 +22,7 @@ export const addMembersMessageSpec: MessageSpec<\nRawAddMembersMessageInfo,\nAddMembersMessageInfo,\n> = Object.freeze({... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add explicit type to messageContent functions
Summary: It appears that flow has some issues in determining the type of parameters inside spec functions. This is the first diff which adds explicit type annotations.
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, at... |
129,191 | 22.02.2021 13:22:24 | -3,600 | 41ecb7298c075afa380b5dc107fd0deff6b097bf | [lib] Add explicit type to robotext functions
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "@@ -19,6 +19,7 @@ import type {\nCreateMessageInfoParams,\nMessageSpec,\nMessageTitleParam,\n+ RobotextParams,\n} from './message-spec';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add explicit type to robotext functions
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D762 |
129,191 | 22.02.2021 13:31:31 | -3,600 | 7169a31b6abb8bfb5d73c48d783bc096eb4b5f74 | [lib] Add explicit type to shimUnsupportedMessageInfo functions
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sidebar-message-spec.js",
"new_path": "lib/shared/messages/create-sidebar-message-spec.js",
"diff": "import invariant from 'invariant';\n+import type { PlatformDetails } from '../../types/device-types';\nimport { messageTypes } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add explicit type to shimUnsupportedMessageInfo functions
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D763 |
129,191 | 22.02.2021 13:36:51 | -3,600 | 0952b48acffd677d338f61e24b741c3c37f4000c | [lib] Add explicit type to unshimMessageInfo functions
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sidebar-message-spec.js",
"new_path": "lib/shared/messages/create-sidebar-message-spec.js",
"diff": "@@ -166,7 +166,9 @@ export const createSidebarMessageSpec: MessageSpec<\n};\n},\n- unshimMessageInfo(unwrapped) {\n+ unshimMessageIn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add explicit type to unshimMessageInfo functions
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D764 |
129,191 | 22.02.2021 13:54:24 | -3,600 | dbc5ec8d23a66d8a11cd1c6bcaf6c821576ff9c3 | [lib] Add explicit type to notificationCollapseKey functions
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "@@ -140,7 +140,7 @@ export const addMembersMessageSpec: MessageSpec<\n};\n},\n- notificationCollapseKey(rawMessageInfo) {\n+ notificationC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add explicit type to notificationCollapseKey functions
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D766 |
129,191 | 22.02.2021 13:57:50 | -3,600 | 42f9ded8798448316d8f26702e7d16100064f350 | [lib] Add explicit type to userIDs functions
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "@@ -150,7 +150,7 @@ export const addMembersMessageSpec: MessageSpec<\ngeneratesNotifs: false,\n- userIDs(rawMessageInfo) {\n+ userIDs(rawM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add explicit type to userIDs functions
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D767 |
129,191 | 22.02.2021 14:00:25 | -3,600 | c193c6c824b65cb4afe4dfd953acd49859de88b8 | [lib] Add explicit type to threadIDs functions
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sidebar-message-spec.js",
"new_path": "lib/shared/messages/create-sidebar-message-spec.js",
"diff": "@@ -208,7 +208,9 @@ export const createSidebarMessageSpec: MessageSpec<\nreturn rawMessageInfo.initialThreadState.memberIDs;\n},\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add explicit type to threadIDs functions
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D768 |
129,208 | 18.02.2021 12:57:04 | 18,000 | bd81a863ad9451d04f349545ea494839a692637f | [native] Use hook instead of connect function and HOC in MessagePreview
Summary: Switched to hooks instead of the connect function the MessagePreview class.
Test Plan: Made sure that message previews still are displayed properly.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-preview.react.js",
"new_path": "native/chat/message-preview.react.js",
"diff": "@@ -14,53 +14,44 @@ import {\ntype RobotextMessageInfo,\n} from 'lib/types/message-types';\nimport { type ThreadInfo } from 'lib/types/thread-types';\n-import {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect function and HOC in MessagePreview
Summary: Switched to hooks instead of the connect function the MessagePreview class.
Test Plan: Made sure that message previews still are displayed properly.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adria... |
129,184 | 23.02.2021 20:30:57 | 28,800 | 69bf92bb114735cf665e8f3121461af738a5482c | [native] Rename MultimediaModal to ImageModal
Summary: NA
Test Plan: Everything seems to work as it did before.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "@@ -24,7 +24,7 @@ import {\nimport {\ntype NavigationRoute,\nVideoPlaybackModalRouteName,\n- MultimediaModalRouteName,\n+ ImageModal... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename MultimediaModal to ImageModal
Summary: NA
Test Plan: Everything seems to work as it did before.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D791 |
129,191 | 18.02.2021 12:55:44 | -3,600 | debfb95d6f4614b65cd1cd8ccda83e75f939cbbb | [web] Create failed send modal
Test Plan: Call `setModal(<FailedSendModal setModal={props.setModal} />)` and check if it was displayed correctly and if clicking close button closes the modal.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/chat/failed-send.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import css from '../../style.css';\n+import Modal from '../modal.react';\n+\n+type Props = {|\n+ +setModal: (modal: ?React.Node) => void,\n+|};\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Create failed send modal
Test Plan: Call `setModal(<FailedSendModal setModal={props.setModal} />)` and check if it was displayed correctly and if clicking close button closes the modal.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revi... |
129,184 | 24.02.2021 03:26:53 | 28,800 | dc57c99fe43ad56c24b0a9e8fe2fa96ae2d27677 | [native] Rename image-view-modal to image-modal
Summary: NA
Test Plan: Ran flow
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "RENAME",
"old_path": "native/media/image-view-modal.react.js",
"new_path": "native/media/image-modal.react.js",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename image-view-modal to image-modal
Summary: NA
Test Plan: Ran flow
Reviewers: ashoat, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D796 |
129,208 | 24.02.2021 14:14:20 | 18,000 | a9fadb8a6a2b7025f775d3ccb6898e649e292107 | [web] Use hooks instead of connect function and HOC in Calendar
Summary: Switched to hooks instead of the connect function in the Calendar class.
Test Plan: Checked if the calendar still showed up on web and worked correctly.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.react.js",
"new_path": "web/calendar/calendar.react.js",
"diff": "@@ -4,7 +4,6 @@ import { faFilter } from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport dateFormat from 'da... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hooks instead of connect function and HOC in Calendar
Summary: Switched to hooks instead of the connect function in the Calendar class.
Test Plan: Checked if the calendar still showed up on web and worked correctly.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, a... |
129,187 | 23.02.2021 15:39:53 | 18,000 | 824b3aa2ffb548e857b53ad19fd45004ff83c5ca | [server] Factor out updateRoleAndPermissions
Summary: This code was copied from `create-personal-threads.js` into `create-private-threads.js` in D722. This diff factors out the shared code.
Test Plan: Flow
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-personal-threads.js",
"new_path": "server/src/scripts/create-personal-threads.js",
"diff": "@@ -8,10 +8,7 @@ import { getRolePermissionBlobsForChat } from '../creators/role-creator';\nimport { createThread } from '../creators/thread-c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Factor out updateRoleAndPermissions
Summary: This code was copied from `create-personal-threads.js` into `create-private-threads.js` in D722. This diff factors out the shared code.
Test Plan: Flow
Reviewers: subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-biszty... |
129,187 | 23.02.2021 19:15:26 | 18,000 | 134796caca083f9d5230344ac3f9e66b6a45ba10 | [lib] Add comments about thread types
Test Plan: N/A
Reviewers: palys-swm, subnub
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -22,10 +22,18 @@ export const threadTypes = Object.freeze({\n//OPEN: 0, (DEPRECATED)\n//CLOSED: 1, (DEPRECATED)\n//SECRET: 2, (DEPRECATED)\n+ // an open subthread. has parent, top... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add comments about thread types
Test Plan: N/A
Reviewers: palys-swm, subnub
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D783 |
129,187 | 23.02.2021 19:35:19 | 18,000 | 710de34b672c19a591d02e7b9dc2d7bdc091d127 | [server] Fix up logic in updateThread to handle thread parent requirements
Summary: Noticed this was broken
Test Plan: didn't have time to test :( careful reading and Flow
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -961,6 +961,25 @@ function useLatestThreadInfo(\n]);\n}\n+type ThreadTypeParentRequirement = 'optional' | 'required' | 'disabled';\n+function getThreadTypeParentRequirement(\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix up logic in updateThread to handle thread parent requirements
Summary: Noticed this was broken
Test Plan: didn't have time to test :( careful reading and Flow
Reviewers: subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https:/... |
129,187 | 23.02.2021 19:49:56 | 18,000 | 99031615b791a063d580eb04fdae8bfafbba62bc | [server] Factor out threadRootChanged in updateThread
Test Plan: Flow
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -439,16 +439,17 @@ async function updateThread(\nthrow new ServerError('no_parent_thread_specified');\n}\n+ const threadRootChanged =\n+ nextParentThread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Factor out threadRootChanged in updateThread
Test Plan: Flow
Reviewers: subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D785 |
129,187 | 23.02.2021 19:51:38 | 18,000 | 370621ef18e27b09bc0d7d2ec270169a7df879e1 | [server] Add forceUpdateRoot to UpdateThreadOptions
Test Plan: Will be tested in concert with upcoming diffs
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -292,6 +292,7 @@ async function leaveThread(\ntype UpdateThreadOptions = Shape<{|\n+forceAddMembers: boolean,\n+ +forceUpdateRoot: boolean,\n|}>;\nasync ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add forceUpdateRoot to UpdateThreadOptions
Test Plan: Will be tested in concert with upcoming diffs
Reviewers: subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D786 |
129,187 | 23.02.2021 19:52:58 | 18,000 | d2515b1f3076dd5a0a68300ca14ade9cacd01843 | [server] Prevent updateThread from converting to PERSONAL/PRIVATE outside scripts
Summary: Updating this condition to handle `PRIVATE` thread and excluding scripts (since we're about to call it from a script)
Test Plan: Flow
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -336,7 +336,10 @@ async function updateThread(\nsqlUpdate.type = threadType;\n}\n- if (threadType === threadTypes.PERSONAL) {\n+ if (\n+ !viewer.isScript... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Prevent updateThread from converting to PERSONAL/PRIVATE outside scripts
Summary: Updating this condition to handle `PRIVATE` thread and excluding scripts (since we're about to call it from a script)
Test Plan: Flow
Reviewers: subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian,... |
129,187 | 23.02.2021 23:14:56 | 18,000 | 90372ac708c2ce09e7e16e4e0275e0c5a9e68887 | [server] Have script viewers automatically pass checkThreads
Summary: This is so we can use `updateThread` in scripts without having to pass permission checks
Test Plan: Tested in concert with upcoming script
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/thread-permission-fetchers.js",
"new_path": "server/src/fetchers/thread-permission-fetchers.js",
"diff": "@@ -79,6 +79,11 @@ async function checkThreads(\nthreadIDs: $ReadOnlyArray<string>,\nchecks: $ReadOnlyArray<Check>,\n): Promise<Set<st... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Have script viewers automatically pass checkThreads
Summary: This is so we can use `updateThread` in scripts without having to pass permission checks
Test Plan: Tested in concert with upcoming script
Reviewers: subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, karol-bis... |
129,184 | 24.02.2021 12:01:39 | 28,800 | fe0829c2a7b67de20992fea4e8be46e1ace49f61 | [native] Move VideoPlaybackModal close button to top right
Summary: Moved close button to top right to be more "reachable" on large devices and to be consistent with ImageModal
Test Plan: NA, here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "@@ -366,8 +366,8 @@ const unboundStyles = {\n},\ncloseButton: {\npaddingTop: 10,\n- paddingLeft: 20,\n- justifyContent: 'flex-start',\n+ paddingRigh... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move VideoPlaybackModal close button to top right
Summary: Moved close button to top right to be more "reachable" on large devices and to be consistent with ImageModal
Test Plan: NA, here's what it looks like: https://blob.sh/atul/33d5.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatP... |
129,187 | 24.02.2021 18:05:41 | 18,000 | 3165a3b8141482115cfbdc8b619b718086e9ca5a | [server] Rescind notifs from fix-new-thread-types script
Summary: Ugh... having to fix the fix script. Very frustrating. Ended up spamming lots of notifs with it, hopefully this will undo those notifs.
Test Plan: test on prod!
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -732,8 +732,10 @@ async function updateBadgeCount(\nFROM cookies\nWHERE user = ${userID}\nAND device_token IS NOT NULL\n- AND id != ${viewer.cookieID}\n`;\n+ if (viewer.data.cookieID)... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rescind notifs from fix-new-thread-types script
Summary: Ugh... having to fix the fix script. Very frustrating. Ended up spamming lots of notifs with it, hopefully this will undo those notifs.
Test Plan: test on prod!
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
... |
129,187 | 24.02.2021 19:26:12 | 18,000 | e80163e768afb4bfdafc6107ed1dd2ec0b49e827 | [lib] Break more ties in message timestamps with message IDs
Summary: Follow-up to D805
Test Plan: test on prod...
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -79,9 +79,16 @@ import { setNewSessionActionType } from '../utils/action-utils';\nconst _mapValuesWithKeys = _mapValues.convert({ cap: false });\n+const sortMessageLis... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Break more ties in message timestamps with message IDs
Summary: Follow-up to D805
Test Plan: test on prod...
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D806 |
129,184 | 23.02.2021 22:46:41 | 28,800 | 7971554e8155d7e9d4937da4067924ba83cabf42 | [native] Add spinner to VideoPlaybackModal
Summary: Spinner displayed until `onReadyForDisplay` callback
Test Plan: Works as expected on iOS. Will test android and media pipeline scenarios comprehensively after the native video playback diffs.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub, ... | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "@@ -213,6 +213,7 @@ function VideoPlaybackModal(props: Props) {\nconst [paused, setPaused] = useState(false);\nconst [percentElapsed, setPercentElap... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add spinner to VideoPlaybackModal
Summary: Spinner displayed until `onReadyForDisplay` callback
Test Plan: Works as expected on iOS. Will test android and media pipeline scenarios comprehensively after the native video playback diffs.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zr... |
129,187 | 24.02.2021 23:27:38 | 18,000 | 8822262610a85128f7d0c53142c4330d2c5cea07 | [native] Set ITSAppUsesNonExemptEncryption to NO for iOS builds
Summary: See [here](https://developer.apple.com/forums/thread/674299?answerId=663520022#663520022)... unblocks Testflight builds by circumventing some App Store Connect bug.
Test Plan: Upload a new Testflight build
Reviewers: atul, palys-swm
Subscribers: K... | [
{
"change_type": "MODIFY",
"old_path": "native/ios/SquadCal/Info.debug.plist",
"new_path": "native/ios/SquadCal/Info.debug.plist",
"diff": "<!DOCTYPE plist PUBLIC \"-//Apple//DTD PLIST 1.0//EN\" \"http://www.apple.com/DTDs/PropertyList-1.0.dtd\">\n<plist version=\"1.0\">\n<dict>\n+ <key>ITSAppUsesNo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Set ITSAppUsesNonExemptEncryption to NO for iOS builds
Summary: See [here](https://developer.apple.com/forums/thread/674299?answerId=663520022#663520022)... unblocks Testflight builds by circumventing some App Store Connect bug.
Test Plan: Upload a new Testflight build
Reviewers: atul, palys-swm
Reviewed B... |
129,208 | 25.02.2021 11:16:26 | 18,000 | 129754434e68c0209a8e5af88f91b782d670141b | [native] Use hook instead of the connect function and HOC in LogInPanelContainer
Summary: Switched to hooks instead of the connect function in the LogInPanelContainer class.
Test Plan: Made sure the login panel still showed up and worked correctly
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul... | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel-container.react.js",
"new_path": "native/account/log-in-panel-container.react.js",
"diff": "// @flow\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { View, Text, St... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of the connect function and HOC in LogInPanelContainer
Summary: Switched to hooks instead of the connect function in the LogInPanelContainer class.
Test Plan: Made sure the login panel still showed up and worked correctly
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo... |
129,208 | 25.02.2021 11:21:16 | 18,000 | 1905d3cb8d7a12cf1251ba629d801bf658bc398b | [native] Use hook instead of connect functions and HOC in ConnectedStatusBar
Summary: Switched to hooks instead of the connect function for the ConnectedStatusBar class
Test Plan: Made sure the statusbar still showed up and functioned normally.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul, k... | [
{
"change_type": "MODIFY",
"old_path": "native/connected-status-bar.react.js",
"new_path": "native/connected-status-bar.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport React from 'react';\nimport { StatusBar, Platform } from 'react-native';\nimport { globalLoadingStatusSel... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ConnectedStatusBar
Summary: Switched to hooks instead of the connect function for the ConnectedStatusBar class
Test Plan: Made sure the statusbar still showed up and functioned normally.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, z... |
129,208 | 25.02.2021 11:28:31 | 18,000 | aaa11d011c2a9ee7c54e9e2c63afffe8b9fd69f3 | [web] Use hook instead of connect and HOC in LogInModal
Test Plan: Tested if the login modal still popped up and fuctioned normally
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-modal.react.js",
"new_path": "web/modals/account/log-in-modal.react.js",
"diff": "@@ -16,23 +16,26 @@ import type {\nLogInResult,\nLogInStartingPayload,\n} from 'lib/types/account-types';\n-import type { DispatchActionPromise } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect and HOC in LogInModal
Test Plan: Tested if the login modal still popped up and fuctioned normally
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D773 |
129,208 | 25.02.2021 11:36:17 | 18,000 | edc2934bc323361f0cab9a7708676c21414a68c2 | [web] Use hook instead of connect and HOC in RegisterModal
Test Plan: Flow
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/register-modal.react.js",
"new_path": "web/modals/account/register-modal.react.js",
"diff": "@@ -13,23 +13,26 @@ import type {\nRegisterResult,\nLogInStartingPayload,\n} from 'lib/types/account-types';\n-import type { DispatchActionPromise }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect and HOC in RegisterModal
Test Plan: Flow
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D774 |
129,208 | 25.02.2021 11:38:19 | 18,000 | 53d7de9b2cc993a193dca2cf47f7fea89c414b00 | [web] Use hook instead of connect function and HOC in UserSettingsModal
Test Plan: Tested settings modal pop
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -29,10 +29,13 @@ import {\ntype CurrentUserInfo,\ncurrentUserPropType,\n} from 'lib/types/user-types';\n-import type { DispatchActionPr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect function and HOC in UserSettingsModal
Test Plan: Tested settings modal pop
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D775 |
129,208 | 25.02.2021 11:42:13 | 18,000 | 641026c507d901d80a85b0917e6470e2c991b6b5 | [web] Use hook instead of connect function and HOC in VerificationModal
Test Plan: Flow
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/verification-modal.react.js",
"new_path": "web/modals/account/verification-modal.react.js",
"diff": "@@ -7,17 +7,18 @@ import {\ntype ServerVerificationResult,\nverifyField,\n} from 'lib/types/verify-types';\n-import { connect } from 'lib/ut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect function and HOC in VerificationModal
Test Plan: Flow
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D776 |
129,208 | 25.02.2021 11:44:52 | 18,000 | f220ac7b45c4db44e95a9a12b1c24d8f82acae6d | [native] Use hook instead of connect function and HOC in AppearancePreferences
Test Plan: Tested to see if the theme could still be changed.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/more/appearance-preferences.react.js",
"new_path": "native/more/appearance-preferences.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { View, Text, ScrollView, Platform } from 'react-native';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect function and HOC in AppearancePreferences
Test Plan: Tested to see if the theme could still be changed.
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D79... |
129,208 | 25.02.2021 11:51:31 | 18,000 | 70b06ebaf621d886ff1da7b771a3c28bf6dc9d35 | [native] Use hook instead of connect function and HOC in CustomServerModal
Test Plan: Tested to see if modal still popped up and pressing go still worked
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/more/custom-server-modal.react.js",
"new_path": "native/more/custom-server-modal.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { Text, TextInput } from 'react-native';\n+import { useDispatch ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect function and HOC in CustomServerModal
Test Plan: Tested to see if modal still popped up and pressing go still worked
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.a... |
129,187 | 25.02.2021 10:50:38 | 18,000 | 9e15dd3594153b2c09e9729171511f128e298ef2 | [lib] Only pass threadID to getMostRecentNonLocalMessageID
Summary: Some potential callers have `RawThreadInfo` instead of `ThreadInfo`, so this will make it easier to use this function from more places.
Test Plan: Flow
Reviewers: atul, subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -111,7 +111,7 @@ function createChatThreadItem(\nmessages,\n);\nconst mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(\n- threadInfo,\n+ threadInfo.id,\nmes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Only pass threadID to getMostRecentNonLocalMessageID
Summary: Some potential callers have `RawThreadInfo` instead of `ThreadInfo`, so this will make it easier to use this function from more places.
Test Plan: Flow
Reviewers: atul, subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian... |
129,187 | 25.02.2021 10:52:52 | 18,000 | 27dad91483deef04ce62c2e1fe8dfda39db2c469 | [lib] Use getMostRecentNonLocalMessageID in ActivityHandler
Test Plan: Flow
Reviewers: atul, subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/activity-handler.react.js",
"new_path": "lib/socket/activity-handler.react.js",
"diff": "@@ -7,13 +7,14 @@ import {\nupdateActivityActionTypes,\nupdateActivity,\n} from '../actions/activity-actions';\n+import { getMostRecentNonLocalMessageID } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use getMostRecentNonLocalMessageID in ActivityHandler
Test Plan: Flow
Reviewers: atul, subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D809 |
129,187 | 25.02.2021 10:47:51 | 18,000 | 9657668b2a61a83c48b8eda70b8129479eedc65c | [lib] Avoid setting inaccessible MessageInfo as mostRecentMessageInfo
Summary: This fixes a bug where the `MessagePreview` displays "No messages" even though the `MessageList` shows messages.
Test Plan: Flow
Reviewers: atul, subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -84,8 +84,11 @@ function getMostRecentMessageInfo(\nif (!thread) {\nreturn null;\n}\n- for (let messageID of thread.messageIDs) {\n- return messages[messageID];\n+ for... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Avoid setting inaccessible MessageInfo as mostRecentMessageInfo
Summary: This fixes a bug where the `MessagePreview` displays "No messages" even though the `MessageList` shows messages.
Test Plan: Flow
Reviewers: atul, subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differenti... |
129,208 | 25.02.2021 11:58:52 | 18,000 | 62649c39a4c146e9e55b7cfcd63e2b59b6392d7e | [native] Use hook insteaf of connect function and HOC in DevTools
Test Plan: Checked if you could still navigate to dev tools, and functions such as 'Trigger a crash' still worked
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/more/dev-tools.react.js",
"new_path": "native/more/dev-tools.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { View, Text, ScrollView, Platform } from 'react-native';\nimport ExitApp from 'reac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook insteaf of connect function and HOC in DevTools
Test Plan: Checked if you could still navigate to dev tools, and functions such as 'Trigger a crash' still worked
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revis... |
129,208 | 25.02.2021 12:02:03 | 18,000 | 7782432a5ecb00d7b000f5ed39a31c1b21c79e0d | [native] Use hook instead of connect function and HOC in EditEmail
Test Plan: Checked if you could still navigate to the email section, and that changing email still worked
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/more/edit-email.react.js",
"new_path": "native/more/edit-email.react.js",
"diff": "import { CommonActions } from '@react-navigation/native';\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect function and HOC in EditEmail
Test Plan: Checked if you could still navigate to the email section, and that changing email still worked
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, karol-bisztyga
Differential Revision: ht... |
129,208 | 25.02.2021 20:42:18 | 18,000 | 2c626a520275c58189545086509854cb8d9855d9 | [web] Use hook instead of connect function in HistoryEntry
Test Plan: Tested to see if history entry still showed up, and functions such as restore entry still worked
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/modals/history/history-entry.react.js",
"new_path": "web/modals/history/history-entry.react.js",
"diff": "import classNames from 'classnames';\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimpor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect function in HistoryEntry
Test Plan: Tested to see if history entry still showed up, and functions such as restore entry still worked
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.asho... |
129,208 | 25.02.2021 20:44:54 | 18,000 | c7a0db0c54a273272f1ac83b48c370f97d3f9402 | [web] Use hook instead of connect function in HistoryModal
Test Plan: Checked if the history modal still popped up and worked correctly.
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/modals/history/history-modal.react.js",
"new_path": "web/modals/history/history-modal.react.js",
"diff": "@@ -7,7 +7,6 @@ import _filter from 'lodash/fp/filter';\nimport _flow from 'lodash/fp/flow';\nimport _map from 'lodash/fp/map';\nimport _unionBy from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect function in HistoryModal
Test Plan: Checked if the history modal still popped up and worked correctly.
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D814 |
129,208 | 25.02.2021 20:53:04 | 18,000 | 9b675d87a440cfc7a7e3c0945246b5ca2648aed1 | [web] Use hook instead of connect function and HOC in NewThreadModal
Test Plan: Flow
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/new-thread-modal.react.js",
"new_path": "web/modals/threads/new-thread-modal.react.js",
"diff": "// @flow\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { newThreadActionTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect function and HOC in NewThreadModal
Test Plan: Flow
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D817 |
129,208 | 25.02.2021 20:54:32 | 18,000 | 5ca9c8dd132666a9930e5d598c342fd6f81745cb | [web] Use hook instead of connect function in FilterPanel
Test Plan: Checked if the filter panel still showed up, and functions such as filtering, clear filter, and include deleted items still worked
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/filter-panel.react.js",
"new_path": "web/calendar/filter-panel.react.js",
"diff": "@@ -8,8 +8,8 @@ import {\n} from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport classNames from 'cl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect function in FilterPanel
Test Plan: Checked if the filter panel still showed up, and functions such as filtering, clear filter, and include deleted items still worked
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differen... |
129,191 | 25.02.2021 17:01:45 | -3,600 | 8bba96f97de80527fb27c4c36869384e314ea796 | [lib] Include source message id in pending thread id
Test Plan:
Create a thread from pending thread and check if correct members were added.
Create sideber (on web and native) and check if it was correct.
Reviewers: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -238,8 +238,14 @@ function getSingleOtherUser(\nreturn otherMemberIDs[0];\n}\n-function getPendingThreadKey(memberIDs: $ReadOnlyArray<string>) {\n- return [...memberIDs].sort().... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include source message id in pending thread id
Test Plan:
Create a thread from pending thread and check if correct members were added.
Create sideber (on web and native) and check if it was correct.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul, subnub
Differential... |
129,183 | 23.02.2021 09:11:45 | -3,600 | f239b577415f14e38f0b40258f8d67eac08c0622 | Extract hook to get message list data
Summary: Second part of extracting shared logic from message-list-container into hooks to get this working on web
Test Plan: Check if message list is displayed correctly like before
Reviewers: palys-swm, ashoat
Subscribers: ashoat, zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -17,7 +17,11 @@ import {\ncreateMessageInfo,\ngetMostRecentNonLocalMessageID,\n} from '../shared/message-utils';\n-import { threadIsTopLevel, threadInChatList } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extract hook to get message list data
Summary: Second part of extracting shared logic from message-list-container into hooks to get this working on web
Test Plan: Check if message list is displayed correctly like before
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, zrebcu411, Adr... |
129,184 | 01.03.2021 10:13:00 | 28,800 | 7b2823df87b04525cd35938a3f7b029d13b18832 | [native] Play button for video messages
Summary: Added play button for video messages
Test Plan: Looked fine on iOS Simulator:
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inline-multimedia.react.js",
"new_path": "native/chat/inline-multimedia.react.js",
"diff": "@@ -4,6 +4,7 @@ import * as React from 'react';\nimport { View, StyleSheet, Text } from 'react-native';\nimport * as Progress from 'react-native-progress';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Play button for video messages
Summary: Added play button for video messages
Test Plan: Looked fine on iOS Simulator: https://blob.sh/atul/comm-play-button.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.... |
129,208 | 02.03.2021 16:44:02 | 18,000 | 83670e83ddfb74c82c93ef7ee7d3cce897d03799 | [native] Use hook instead of connect function in MoreScreen
Test Plan: Checked if the user could still navigate to the more screen, and functions such as logging out, resending email verification, and deleting account still worked
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/more/more-screen.react.js",
"new_path": "native/more/more-screen.react.js",
"diff": "// @flow\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport {\nView,\n@@ -22,16 +21,13 @@ import {\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect function in MoreScreen
Test Plan: Checked if the user could still navigate to the more screen, and functions such as logging out, resending email verification, and deleting account still worked
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zr... |
129,208 | 02.03.2021 16:49:45 | 18,000 | 282904377237c6137eabe1c6fa500fe01330ea8a | [lib] Use hook instead of connect function in APIRequestHandler
Test Plan: Checked if mobile and web could still connect to the server
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/api-request-handler.react.js",
"new_path": "lib/socket/api-request-handler.react.js",
"diff": "// @flow\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport type { APIRequest } from '../t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use hook instead of connect function in APIRequestHandler
Test Plan: Checked if mobile and web could still connect to the server
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D826 |
129,208 | 02.03.2021 16:51:51 | 18,000 | ac6161d59b0a08f337b5fb42ae2bfa03f0f639a9 | [lib] Use hook instead of connect function in CalendarQueryHandler
Test Plan: Checked if when creating calendar queries it would be updated in real time from web to native and vise versa
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/calendar-query-handler.react.js",
"new_path": "lib/socket/calendar-query-handler.react.js",
"diff": "// @flow\nimport _isEqual from 'lodash/fp/isEqual';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport {\n@@ -14,39 +13,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use hook instead of connect function in CalendarQueryHandler
Test Plan: Checked if when creating calendar queries it would be updated in real time from web to native and vise versa
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision... |
129,208 | 02.03.2021 16:54:06 | 18,000 | 51d944f8ea8bb5813579740b5e74e50eb66a1fd2 | [lib] Use hook instead of connect function in MessageHandler
Test Plan: Checked if onMessage still fired and worked correcly on web and native
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/message-handler.react.js",
"new_path": "lib/socket/message-handler.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\n+import { useDispatch } from 'react-redux';\nimport { processMessagesActionType }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use hook instead of connect function in MessageHandler
Test Plan: Checked if onMessage still fired and worked correcly on web and native
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D828 |
129,208 | 02.03.2021 16:55:50 | 18,000 | b7d3e3b5c0de6bc7ea61596ae7a5590bbd5ba067 | [lib] Use hook instead of connect function in ReportHandler
Test Plan: Flow and also check if it still mounted correctly in web and native
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/report-handler.react.js",
"new_path": "lib/socket/report-handler.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { sendReportsActionTypes, sendReports } from '../actions/report-actions';\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use hook instead of connect function in ReportHandler
Test Plan: Flow and also check if it still mounted correctly in web and native
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D829 |
129,208 | 02.03.2021 16:58:29 | 18,000 | 6cd6f814748d5273d25c689ea7d7c6d95602d26a | [lib] Use hook instead of connect function in RequestResponseHandler
Test Plan: Checked if onMessage still fires
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/request-response-handler.react.js",
"new_path": "lib/socket/request-response-handler.react.js",
"diff": "// @flow\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\n+import { useDispatch } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use hook instead of connect function in RequestResponseHandler
Test Plan: Checked if onMessage still fires
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D830 |
129,208 | 02.03.2021 17:00:01 | 18,000 | a12f5926334b1e50abd8a2383b9ba1a01d78c417 | [lib] Use hook instead of connect function in UpdateHandler
Test Plan: Checked if onMessage was still being called on native and web
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/update-handler.react.js",
"new_path": "lib/socket/update-handler.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\n+import { useEffect } from 'react';\n+import { useDispatch } from 'react-redux';\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use hook instead of connect function in UpdateHandler
Test Plan: Checked if onMessage was still being called on native and web
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D831 |
129,208 | 02.03.2021 17:02:07 | 18,000 | fe64d89c9724e919fcced4194eb19814a2f1c9f8 | [native] Use hook instead of connect function in OrientationHandler
Test Plan: Clicked on a photo and checked if rotating the device still worked correctly (ios simulator)
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/orientation-handler.react.js",
"new_path": "native/navigation/orientation-handler.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport type { Orientations } from 'react-native-orientation... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect function in OrientationHandler
Test Plan: Clicked on a photo and checked if rotating the device still worked correctly (ios simulator)
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabr... |
129,208 | 02.03.2021 17:04:12 | 18,000 | 8ec0e9e6c9ae7304e0fbd20183f90afc787e304a | [native] Use hook instead of connect function in ColorPicker
Test Plan: Checked if the color picker still popped up and that threads colors could still be changed
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/components/color-picker.react.js",
"new_path": "native/components/color-picker.react.js",
"diff": "// @flow\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport {\nView,\n@@ -9,16 +8,12 @@ im... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect function in ColorPicker
Test Plan: Checked if the color picker still popped up and that threads colors could still be changed
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.as... |
129,183 | 18.02.2021 14:45:38 | -3,600 | 8eb83fc63995bf588f6ee211ccb345ec58d597b9 | [web] Add sidebar tooltip to robotext message
Summary: This diff requires D708 that introduces sidebar tooltip
Test Plan: Check if correct sidebar is opened, check if three dots button and sidebar menu are displayed correctly
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -107,13 +107,17 @@ div.conversationHeader:last-child {\npadding-top: 6px;\n}\n-div.robotext {\n+div.robotextContainer {\ntext-align: center;\ncolor: #333333;\npadding: 6... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add sidebar tooltip to robotext message
Summary: This diff requires D708 that introduces sidebar tooltip
Test Plan: Check if correct sidebar is opened, check if three dots button and sidebar menu are displayed correctly
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adria... |
129,208 | 04.03.2021 15:18:58 | 18,000 | c93907c9c353286fbf4cbcc425d3fb70761c247c | [native] Use hook instead of connect in InputStateContainer
Test Plan: Checked if text messages and such could still be sent to 2 user chats, group chats, and private chats.
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "// @flow\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { Platform } from 'rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect in InputStateContainer
Test Plan: Checked if text messages and such could still be sent to 2 user chats, group chats, and private chats.
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://pha... |
129,208 | 04.03.2021 15:21:30 | 18,000 | 5583343b80e067e5b9b97c60b7ad415de5a905a6 | [native] Use hook instead of connect in ConnectivityUpdater
Test Plan: Checked if onConnectionChange was still being called properly
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/redux/connectivity-updater.react.js",
"new_path": "native/redux/connectivity-updater.react.js",
"diff": "// @flow\nimport NetInfo from '@react-native-community/netinfo';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\n+import { u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect in ConnectivityUpdater
Test Plan: Checked if onConnectionChange was still being called properly
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D837 |
129,208 | 04.03.2021 15:55:03 | 18,000 | 2879517d113cbc7aa5db7433787c6d1428b8a185 | [web] Use hook instead of connect function in InnerThreadEntity
Test Plan: Checked if the robotext would still show up, and other message types still worked normally
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/chat/robotext-message.react.js",
"new_path": "web/chat/robotext-message.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\n+import { useDispatch } from 'react-redux';\nimport { type RobotextChatMessageInfoI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect function in InnerThreadEntity
Test Plan: Checked if the robotext would still show up, and other message types still worked normally
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator... |
129,208 | 04.03.2021 16:11:46 | 18,000 | 25f4e66f130d0f4ef4987c4d8da8dbce8a5d6beb | [native] Use hook instead of connect in RemoteImage
Test Plan: Checked if images still rendered properly, and that componentDidUpdate is being called when there are images present
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/media/remote-image.react.js",
"new_path": "native/media/remote-image.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\nimport { View, StyleSheet, ActivityIndicator } from 'react-native';\nimport FastIma... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect in RemoteImage
Test Plan: Checked if images still rendered properly, and that componentDidUpdate is being called when there are images present
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https... |
129,208 | 04.03.2021 16:28:41 | 18,000 | eaff95f81fe4a04f59f15f7364401f3fbe83725d | [web] Use hook instead of connect in Entry
Test Plan: Checked in entry still showed up correctly, and features such as deletion still worked
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/entry.react.js",
"new_path": "web/calendar/entry.react.js",
"diff": "import classNames from 'classnames';\nimport invariant from 'invariant';\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\n+import { useDispatch } from 'rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect in Entry
Test Plan: Checked in entry still showed up correctly, and features such as deletion still worked
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D840 |
129,187 | 24.02.2021 19:49:27 | 18,000 | 4ab4773450f6f20ee0912ed8905ce7389549a3a3 | [native] codeVersion -> 79 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 79 |
129,191 | 26.02.2021 13:26:25 | -3,600 | 6b1b5dfc0fce82f17a3306c894fc94bdaf4db23c | [native] Use thread watcher hook
Test Plan: Switched threads couple of times and checked using console log in thread watcher if watchedID map had correct values
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -14,8 +14,7 @@ import {\n} from 'lib/actions/message-actions';\nimport { registerFetchKey } from 'lib/reducers/loading-reducer';\nimport { messageKey } from 'lib/s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use thread watcher hook
Test Plan: Switched threads couple of times and checked using console log in thread watcher if watchedID map had correct values
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D820 |
129,191 | 26.02.2021 14:29:20 | -3,600 | 8819465863ee57cff6a5d4247747f6290c896082 | [native] Make sure that failed-send accepts only composable messages
Test Plan: Modify message creator to fail every second time. Send a message, check if retry button was displayed, retry and check if the message was sent.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -165,6 +165,17 @@ export function assertComposableMessageType(\n);\nreturn ourMessageType;\n}\n+export function assertComposableRawMessage(\n+ message: RawMessageInfo,\n+): RawC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make sure that failed-send accepts only composable messages
Test Plan: Modify message creator to fail every second time. Send a message, check if retry button was displayed, retry and check if the message was sent.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
D... |
129,187 | 05.03.2021 12:39:38 | 18,000 | 6bc4f2e95876ef8b7965c6f3f29c755545e1f207 | [native] Fix ThreadSettingsPromoteSidebar name
Summary: I accidentally named this incorrectly in D274. The class name should match the filename should match the import name.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-promote-sidebar.react.js",
"new_path": "native/chat/settings/thread-settings-promote-sidebar.react.js",
"diff": "@@ -43,7 +43,7 @@ type Props = {|\nrequest: UpdateThreadRequest,\n) => Promise<ChangeThreadSettingsPayload>,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix ThreadSettingsPromoteSidebar name
Summary: I accidentally named this incorrectly in D274. The class name should match the filename should match the import name.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://ph... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.