author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 05.03.2021 13:01:51 | 18,000 | 48dd94ff0f6256946072dda6cf9f7177c4a5ba6a | [native] Change text in ThreadSettingsPromoteSidebar
Summary: This is just a nit... I feel like the new language is a bit clearer. "Subthread" seems confusing
Test Plan: Flow
Reviewers: atul, KatPo, palys-swm
Subscribers: zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-promote-sidebar.react.js",
"new_path": "native/chat/settings/thread-settings-promote-sidebar.react.js",
"diff": "@@ -61,7 +61,7 @@ class ThreadSettingsPromoteSidebar extends React.PureComponent<Props> {\niosFormat=\"highlig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Change text in ThreadSettingsPromoteSidebar
Summary: This is just a nit... I feel like the new language is a bit clearer. "Subthread" seems confusing
Test Plan: Flow
Reviewers: atul, KatPo, palys-swm
Subscribers: zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D858 |
129,187 | 05.03.2021 17:14:25 | 18,000 | 7846cae5bc809e5cc3a348cf534c682c41eb1055 | [web] Prevent setting thread titles to multi-line strings
Summary: Web equivalent of D862. These aren't used a lot, but I figured it was better to keep them updated.
Test Plan: Flow
Reviewers: atul, karol-bisztyga, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/new-thread-modal.react.js",
"new_path": "web/modals/threads/new-thread-modal.react.js",
"diff": "@@ -23,6 +23,7 @@ import {\nuseDispatchActionPromise,\nuseServerCall,\n} from 'lib/utils/action-utils';\n+import { firstLine } from 'lib/utils/s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Prevent setting thread titles to multi-line strings
Summary: Web equivalent of D862. These aren't used a lot, but I figured it was better to keep them updated.
Test Plan: Flow
Reviewers: atul, karol-bisztyga, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.a... |
129,187 | 05.03.2021 17:22:39 | 18,000 | 841a1ed761926ac857e634ad960893b87603a566 | [server] Prevent multi-line thread titles
Summary: This diff is the final in the series about multi-line thread titles. It makes sure that the server code trims all thread titles it gets to a single line.
Test Plan: Flow, careful inspection
Reviewers: atul, karol-bisztyga, palys-swm
Subscribers: KatPo, zrebcu411, Adria... | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -20,6 +20,7 @@ import {\n} from 'lib/types/thread-types';\nimport { ServerError } from 'lib/utils/errors';\nimport { promiseAll } from 'lib/utils/promises'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Prevent multi-line thread titles
Summary: This diff is the final in the series about multi-line thread titles. It makes sure that the server code trims all thread titles it gets to a single line.
Test Plan: Flow, careful inspection
Reviewers: atul, karol-bisztyga, palys-swm
Subscribers: KatPo, zrebcu411, A... |
129,187 | 05.03.2021 19:33:51 | 18,000 | 3d21c5b668b3895c6859fde6053f36630a26660a | [native] codeVersion -> 80 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 80 |
129,187 | 06.03.2021 00:54:54 | 18,000 | e33030a334369793cba9a5daaf6db7af4d2a199c | [native] Revert "Use hook instead of connect in Search"
Summary: This reverts commit See discussion after land in D835
Test Plan: Make sure Calendar flow works
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/components/search.react.js",
"new_path": "native/components/search.react.js",
"diff": "// @flow\n+import PropTypes from 'prop-types';\nimport * as React from 'react';\n-import { View, TouchableOpacity, TextInput } from 'react-native';\n+import { View, V... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Revert "Use hook instead of connect in Search"
Summary: This reverts commit 7b538c685714bb1ca341213c52c0742b0561d65f. See discussion after land in D835
Test Plan: Make sure Calendar flow works
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricat... |
129,187 | 06.03.2021 02:29:06 | 18,000 | 0e2741a508d0d82bd20bd392efc2477072b6cfdd | [native] codeVersion -> 81 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 81 |
129,208 | 05.03.2021 11:43:45 | 18,000 | 8d2eef1e32853ae5bace5bdee81297d818eeeeee | [web] Use hook instead of connect in InputStateContainer
Test Plan: Checked if main content was still being rendered, and that sending text messages / multimedia still worked correctly
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/input/input-state-container.react.js",
"new_path": "web/input/input-state-container.react.js",
"diff": "@@ -8,8 +8,8 @@ import _omit from 'lodash/fp/omit';\nimport _partition from 'lodash/fp/partition';\nimport _sortBy from 'lodash/fp/sortBy';\nimport _mem... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect in InputStateContainer
Test Plan: Checked if main content was still being rendered, and that sending text messages / multimedia still worked correctly
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul
Differential Revision: ... |
129,187 | 06.03.2021 13:45:04 | 18,000 | c69d12534ee0a0bbcf2968baed22a63d97cc0b0d | [native] Use hook instead of connect in Search
Summary: Re-attempt of D835 after having to revert it in D868. Will comment with the diff between this and D835
Test Plan: Make sure it's possible to create calendar events
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/components/search.react.js",
"new_path": "native/components/search.react.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\nimport * as React from 'react';\n-import { View, ViewPropTypes, TouchableOpacity, TextInput } from 'react-native';\n+i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect in Search
Summary: Re-attempt of D835 after having to revert it in D868. Will comment with the diff between this and D835
Test Plan: Make sure it's possible to create calendar events
Reviewers: subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul... |
129,184 | 10.03.2021 00:33:48 | 28,800 | 498fb89a35e21e89a83312e7f6ed44aa15252c60 | [native] Introduce useIsAppForegrounded
Summary: Introduce useIsAppForegrounded hook. This will be changed in upcoming diffs as `foreground:boolean` is updated to `lifecycleState: LifecycleState`.
Test Plan: The updated components work as expected on iOS and android.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zre... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/shared/lifecycle-utils.js",
"diff": "+import { useSelector } from 'react-redux';\n+\n+function useIsAppForegrounded() {\n+ return useSelector((state) => state.foreground);\n+}\n+\n+export { useIsAppForegrounded };\n"
},
{
"change_typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce useIsAppForegrounded
Summary: Introduce useIsAppForegrounded hook. This will be changed in upcoming diffs as `foreground:boolean` is updated to `lifecycleState: LifecycleState`.
Test Plan: The updated components work as expected on iOS and android.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat... |
129,184 | 09.03.2021 13:17:18 | 28,800 | e2a42700ab5a18936f64696733db9db9d5469703 | Introduce LifecycleState type and UPDATE_LIFECYCLE_STATE action
Summary: Added LifecycleState and UPDATE_LIFECYCLE to set stage for converting `foreground:boolean` to `lifecycleState:LifecycleState`
Test Plan: Flow and things work as they did before on iOS.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Ad... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/foreground-reducer.js",
"new_path": "lib/reducers/foreground-reducer.js",
"diff": "import type { BaseAction } from '../types/redux-types';\n-export const backgroundActionType = 'BACKGROUND';\n-export const foregroundActionType = 'FOREGROUND';\nexp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce LifecycleState type and UPDATE_LIFECYCLE_STATE action
Summary: Added LifecycleState and UPDATE_LIFECYCLE to set stage for converting `foreground:boolean` to `lifecycleState:LifecycleState`
Test Plan: Flow and things work as they did before on iOS.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscrib... |
129,184 | 10.03.2021 01:37:30 | 28,800 | cb3994570ca71428a974fed2ed1535cd7dd2978f | Rename `state.foreground` to `state.lifecycleState`
Summary: Renamed `foreground` to `lifecycleState` in anticipation of converting property from boolean to LifecycleState.
Test Plan: Flow/things continue to work as expected in iOS simulator.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/connection-reducer.js",
"new_path": "lib/reducers/connection-reducer.js",
"diff": "@@ -22,7 +22,7 @@ import {\n} from '../types/socket-types';\nimport { setNewSessionActionType } from '../utils/action-utils';\nimport { getConfig } from '../utils/c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Rename `state.foreground` to `state.lifecycleState`
Summary: Renamed `foreground` to `lifecycleState` in anticipation of converting property from boolean to LifecycleState.
Test Plan: Flow/things continue to work as expected in iOS simulator.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zre... |
129,184 | 10.03.2021 11:45:37 | 28,800 | 1c6e6a3a61f7ddaa7e9ba76425273e704033d7c9 | [lib] Introduce useIsAppBackgroundedOrInactive
Summary: Created `useIsAppBackgroundedOrInactive` hook
Test Plan: Tested with VideoPlaybackModal (next diff) and hook works as expected.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/lifecycle-utils.js",
"new_path": "lib/shared/lifecycle-utils.js",
"diff": "import { useSelector } from 'react-redux';\n+// Note: This hook mimics the prior state.foreground property\n+// and considers `inactive` on iOS as equivalent to `active`\nfun... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce useIsAppBackgroundedOrInactive
Summary: Created `useIsAppBackgroundedOrInactive` hook
Test Plan: Tested with VideoPlaybackModal (next diff) and hook works as expected.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phab... |
129,184 | 10.03.2021 11:50:04 | 28,800 | 9aa33aeeefe93f265b55bf64a765cff0635e65e4 | [native] Pause video playback when app is backgrounded/inactive
Summary: Pause video playback when app is backgrounded or inactive based on `state.lifecycleState`
Test Plan: `VideoPlaybackModal` changed `paused` state as expected when switching apps, going to homescreen, opening control center, etc.
Reviewers: ashoat, ... | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "@@ -9,6 +9,7 @@ import Animated from 'react-native-reanimated';\nimport Icon from 'react-native-vector-icons/MaterialCommunityIcons';\nimport Video ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Pause video playback when app is backgrounded/inactive
Summary: Pause video playback when app is backgrounded or inactive based on `state.lifecycleState`
Test Plan: `VideoPlaybackModal` changed `paused` state as expected when switching apps, going to homescreen, opening control center, etc.
Reviewers: ashoa... |
129,191 | 09.03.2021 16:28:03 | -3,600 | c643fa0ff5e8d944014111d5eda0c19ee47ac724 | [lib] Limit username input length
Test Plan: Try to create accounts with username length: 5, 6, 191, 192 characters - 5 and 192 should fail, other succeed.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/account-utils.js",
"new_path": "lib/shared/account-utils.js",
"diff": "@@ -9,9 +9,15 @@ import type { AppState } from '../types/redux-types';\nimport type { PreRequestUserState } from '../types/session-types';\nimport type { CurrentUserInfo } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Limit username input length
Test Plan: Try to create accounts with username length: 5, 6, 191, 192 characters - 5 and 192 should fail, other succeed.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D876 |
129,191 | 11.03.2021 15:31:08 | -3,600 | 1ef53ff7ebbc505ac66a15491c4cd94d614c9a89 | [web] Correctly display longer usernames in edit account modal
Test Plan: Log in as a user with long username, open edit account modal and check if username was displayed correctly.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -451,12 +451,18 @@ div.modal-body div.form-footer div.modal-form-error ol {\npadding-left: 20px;\n}\n+div.form-text {\n+ display: flex;\n+ align-items: baseline;\n+}\ndiv.form-text > div.form-title {\nve... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Correctly display longer usernames in edit account modal
Test Plan: Log in as a user with long username, open edit account modal and check if username was displayed correctly.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.... |
129,187 | 12.03.2021 16:45:59 | 18,000 | 588853e46b4cfa075347fb2b7fcd9e23f19de972 | [web] Fix Safari layout after D893
Summary: I accidentally broke Safari in D893. This diff fixes it, and makes sure Chrome and Firefox are still fixed too.
Test Plan: Test scrolling up in chat view in Safari, Chrome, Firefox
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -49,7 +49,6 @@ input[type='submit']::-moz-focus-inner {\n}\nheader.header {\n- flex: 0 1 auto;\nbackground-image: url(../images/background.png);\nbackground-size: 3000px 2000px;\nbackground-attachment: f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix Safari layout after D893
Summary: I accidentally broke Safari in D893. This diff fixes it, and makes sure Chrome and Firefox are still fixed too.
Test Plan: Test scrolling up in chat view in Safari, Chrome, Firefox
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian, subnub... |
129,187 | 12.03.2021 15:38:31 | 18,000 | 65c7fe8d101ed5f4f49e1c6252e64ad6c12312f3 | [lib] Kill connect function and associated utilities
Test Plan: Flow
Reviewers: subnub, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/action-utils.js",
"new_path": "lib/utils/action-utils.js",
"diff": "// @flow\n-import invariant from 'invariant';\n-import _mapValues from 'lodash/fp/mapValues';\nimport _memoize from 'lodash/memoize';\nimport * as React from 'react';\nimport { useSe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Kill connect function and associated utilities
Test Plan: Flow
Reviewers: subnub, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D895 |
129,184 | 14.03.2021 23:26:01 | 25,200 | e84d6e0468f68085c699861695f7d25b4528176c | [web] [lib] Remove mediaMissionStepPropType
Summary: NA
Test Plan: flow
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "// @flow\n-import PropTypes from 'prop-types';\n-\nimport type { Shape } from './core';\n-import { type Platform, platformPropType } from './device-types';\n+import { type Platform } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [lib] Remove mediaMissionStepPropType
Summary: NA
Test Plan: flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D900 |
129,184 | 15.03.2021 12:22:18 | 25,200 | 5fb0686494d2ce5c6a108f3e82cf52d353dfe4b0 | [lib] Make types in `media-types.js` read-only
Summary: NA
Test Plan: flow and careful reading
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -4,68 +4,68 @@ import type { Shape } from './core';\nimport { type Platform } from './device-types';\nexport type Dimensions = $ReadOnly<{|\n- height: number,\n- width: number,\n+ +... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Make types in `media-types.js` read-only
Summary: NA
Test Plan: flow and careful reading
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D909 |
129,184 | 15.03.2021 00:24:53 | 25,200 | 9715833c3d94d13aec2541670be4667837d6827d | [native] Introduce generateThumbnail, rename FFmpeg:process to FFmpeg:trancodeVideo
Summary: Introduce `generateThumbnail` and rename `FFmpeg:process` to `FFmpeg:transcodeVideo`
Test Plan: verified thumbnail was generated by checking the console.log'd output path.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu... | [
{
"change_type": "MODIFY",
"old_path": "native/media/ffmpeg.js",
"new_path": "native/media/ffmpeg.js",
"diff": "@@ -74,7 +74,7 @@ class FFmpeg {\ntoRun.forEach(({ runCommand }) => runCommand());\n}\n- process(\n+ transcodeVideo(\nffmpegCommand: string,\ninputVideoDuration: number,\nonTranscodingProg... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce generateThumbnail, rename FFmpeg:process to FFmpeg:trancodeVideo
Summary: Introduce `generateThumbnail` and rename `FFmpeg:process` to `FFmpeg:transcodeVideo`
Test Plan: verified thumbnail was generated by checking the console.log'd output path.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
S... |
129,191 | 16.03.2021 16:38:08 | -3,600 | 1d1fc53b7109d9badf86eff4a75377a0be7ef097 | [lib] Remove unused variable
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/master-reducer.js",
"diff": "@@ -64,7 +64,7 @@ export default function baseReducer<N: BaseNavInfo, T: BaseAppState<N>>(\ncurrentUserInfo: reduceCurrentUserInfo(state.currentUserInfo, action),\nthreadSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Remove unused variable
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D908 |
129,191 | 09.03.2021 11:36:03 | -3,600 | e042b28a1db94587754ab9010730c9c41103afd9 | [native] Include messages from store in pending sidebar
Test Plan: Modify thread creator to always fail, send a message to pending sidebar and check if it was displayed
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -5,7 +5,6 @@ import _filter from 'lodash/fp/filter';\nimport _flow from 'lodash/fp/flow';\nimport _map from 'lodash/fp/map';\nimport _orderBy from 'lodash/fp/orderBy';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Include messages from store in pending sidebar
Test Plan: Modify thread creator to always fail, send a message to pending sidebar and check if it was displayed
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D8... |
129,183 | 15.03.2021 09:52:04 | -3,600 | dd874fe1b217170128e2b096ef51013aa5db52d8 | [web] Use ColorResult type
Summary: Follow up to D892 and type changes made there
Test Plan: Flow
Reviewers: palys-swm, ashoat
Subscribers: ashoat, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/color-picker.react.js",
"new_path": "web/modals/threads/color-picker.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { ChromePicker } from 'react-color';\n+import { type ColorResult, ChromePicker } from 'react-color';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use ColorResult type
Summary: Follow up to D892 and type changes made there
Test Plan: Flow
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D907 |
129,184 | 18.03.2021 08:39:43 | 25,200 | e3975e26cb8b79ba08a5d9dc6d592d341e066ccd | [native] Make types ReadOnly in media-utils/video-utils
Summary: NA
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-utils.js",
"new_path": "native/media/media-utils.js",
"diff": "@@ -18,20 +18,20 @@ import { saveMedia } from './save-media';\nimport { processVideo } from './video-utils';\ntype MediaProcessConfig = {|\n- hasWiFi: boolean,\n+ +hasWiFi: boole... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make types ReadOnly in media-utils/video-utils
Summary: NA
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D919 |
129,184 | 18.03.2021 10:55:20 | 25,200 | edbc6e8ea141a672d13db0740ef9e1aa719da8cb | [native] Add getTempDirectoryPath to native/file-utils
Summary: NA
Test Plan: flow and continues to work as expected
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/media/file-utils.js",
"new_path": "native/media/file-utils.js",
"diff": "@@ -425,9 +425,15 @@ async function copyFile(\n};\n}\n+const temporaryDirectoryPath: string = Platform.select({\n+ ios: filesystem.TemporaryDirectoryPath,\n+ default: `${filesystem... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add getTempDirectoryPath to native/file-utils
Summary: NA
Test Plan: flow and continues to work as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D920 |
129,184 | 18.03.2021 12:58:47 | 25,200 | f282e7907cf7ecc59e2feb307823ed823248b3fe | [native] Make types ReadOnly in lib/media/video-utils
Summary: NA
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/media/video-utils.js",
"new_path": "lib/media/video-utils.js",
"diff": "@@ -12,28 +12,28 @@ const { height: maxHeight, width: maxWidth } = maxDimensions;\nconst estimatedResultBitrate = 0.35; // in MiB/s\ntype Input = {|\n- inputPath: string,\n- inputHasCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make types ReadOnly in lib/media/video-utils
Summary: NA
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D922 |
129,191 | 18.03.2021 13:33:35 | -3,600 | f61f49a5549de45ea5b38520b3c275422b634f34 | [lib] Use correct parameter type in createPendingSidebar function
Summary: We should use the same type as in SidebarSourceMessageInfo type definition
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -25,11 +25,9 @@ import {\nthreadInfoFromSourceMessageIDSelector,\n} from '../selectors/thread-selectors';\nimport type {\n- MultimediaMessageInfo,\nRobotextMessageInfo,\nComposa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use correct parameter type in createPendingSidebar function
Summary: We should use the same type as in SidebarSourceMessageInfo type definition
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D918 |
129,184 | 19.03.2021 01:13:03 | 25,200 | 1839ac5c7c470040271d3d26a5e07701a576f219 | [native] Add thumbnail generation step to processVideo
Summary: Added thumbnail generation step to `processVideo`
Test Plan: Got path to `thumbnailURI` via `console.log` and made sure the JPG existed/looked correct visually.
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/media/video-utils.js",
"new_path": "lib/media/video-utils.js",
"diff": "@@ -29,10 +29,11 @@ type Input = {|\nexport type ProcessPlan = {|\n+action: 'process',\n+outputPath: string,\n+ +thumbnailPath: string,\n+ffmpegCommand: string,\n|};\ntype Plan =\n- | ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add thumbnail generation step to processVideo
Summary: Added thumbnail generation step to `processVideo`
Test Plan: Got path to `thumbnailURI` via `console.log` and made sure the JPG existed/looked correct visually.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, su... |
129,187 | 29.03.2021 12:44:59 | 14,400 | aafc03e9bc34ce685c1f994586a5a979921c4f11 | [native] Add some comments explaining uploadFile better
Test Plan: N/A
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -546,6 +546,10 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nif (uploadResult) {\nconst { id, mediaType, uri, dimen... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add some comments explaining uploadFile better
Test Plan: N/A
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D933 |
129,187 | 29.03.2021 13:16:22 | 14,400 | b584dc433614278dc3a1ce82b0a5a6c8aa884f15 | [native] Update SelectionWithID type to included video thumbnails
Summary: This type is now called `UploadFileInput` to represent its contents a little better.
Test Plan: Flow, will test in combination with future diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -78,9 +78,12 @@ function getNewLocalID() {\nreturn `localUpload${nextLocalUploadID++}`;\n}\n-type SelectionWithID = {|\n+type MediaIDs =\n+ | {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update SelectionWithID type to included video thumbnails
Summary: This type is now called `UploadFileInput` to represent its contents a little better.
Test Plan: Flow, will test in combination with future diffs
Reviewers: palys-swm, atul
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian, subnub
Dif... |
129,184 | 31.03.2021 10:10:25 | 14,400 | 548e1176291a6975d8e58a007c46d0fea9a7306b | [lib] minor localUploadID refactor
Summary: Moved getNextLocalUploadID to `lib/media/media-utils` and pulled out `localUploadPrefix`
Test Plan: things work as they did prior, localUploadIDs incrementing as before,etc
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/media/media-utils.js",
"new_path": "lib/media/media-utils.js",
"diff": "@@ -50,8 +50,15 @@ function multimediaMessagePreview(\nreturn `sent ${mediaContentString}`;\n}\n+const localUploadPrefix = 'localUpload';\n+\nfunction isLocalUploadID(id: string): bool... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] minor localUploadID refactor
Summary: Moved getNextLocalUploadID to `lib/media/media-utils` and pulled out `localUploadPrefix`
Test Plan: things work as they did prior, localUploadIDs incrementing as before,etc
Reviewers: ashoat, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub
... |
129,184 | 31.03.2021 11:55:52 | 14,400 | 948b2c8dedf7070c57e5ea35bf98b2c08e2aecd5 | [native] Modify retryMultimediaMessage to incorporate thumbnails
Summary: Modify retryMultimediaMessage to incorporate thumbnails. Written by Ashoat on Monday.
Test Plan: Will be tested with subsequent diff which actually uploads generated thumbnail
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, su... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -25,6 +25,8 @@ export type Video = {|\n+type: 'video',\n+dimensions: Dimensions,\n+loop?: boolean,\n+ +thumbnailID: string,\n+ +thumbnailURI: string,\n// stored on native only durin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Modify retryMultimediaMessage to incorporate thumbnails
Summary: Modify retryMultimediaMessage to incorporate thumbnails. Written by Ashoat on Monday.
Test Plan: Will be tested with subsequent diff which actually uploads generated thumbnail
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: Kat... |
129,184 | 31.03.2021 13:33:34 | 14,400 | 8c22947fb36953bf070f06437d9aca8f1e657dea | [native] Pass uploadThumbnailURI to input-state-container:uploadFile
Summary: Passing uploadThumbnailURI to `uploadFile` and unlinking it there (temporarily). Changes to `MediaResult` in `native/media/media-utils` to resolve flow issues.
Test Plan: Will be tested in subsequent diffs
Reviewers: ashoat, palys-swm
Subscri... | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -535,9 +535,11 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nconst uploadStart = Date.now();\nlet uploadExceptionMe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Pass uploadThumbnailURI to input-state-container:uploadFile
Summary: Passing uploadThumbnailURI to `uploadFile` and unlinking it there (temporarily). Changes to `MediaResult` in `native/media/media-utils` to resolve flow issues.
Test Plan: Will be tested in subsequent diffs
Reviewers: ashoat, palys-swm
Rev... |
129,187 | 30.03.2021 11:40:40 | 14,400 | 433e7c939780edcbb286a50d04fb77c507ac3838 | [web] Introduce nav reducer
Summary: This should be a pure refactor to introduce a new `reduceNavInfo` function on web.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -40,13 +40,13 @@ import LoadingIndicator from './loading-indicator.react';\nimport ResetPasswordModal from './modals/account/reset-password-modal.react';\nimport VerificationModal from './modals/ac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce nav reducer
Summary: This should be a pure refactor to introduce a new `reduceNavInfo` function on web.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D941 |
129,184 | 31.03.2021 16:27:06 | 14,400 | 3f928f6449fb5d8e8bd274354341782a85315607 | [web] use `getNextLocalUploadID` in web/inputStateContainer
Summary: Addressing
Test Plan: careful reading
Reviewers: ashoat, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "web/input/input-state-container.react.js",
"new_path": "web/input/input-state-container.react.js",
"diff": "@@ -27,6 +27,7 @@ import {\ntype MultimediaUploadCallbacks,\ntype MultimediaUploadExtras,\n} from 'lib/actions/upload-actions';\n+import { getNextLocalU... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] use `getNextLocalUploadID` in web/inputStateContainer
Summary: Addressing https://phabricator.ashoat.com/D947#22346
Test Plan: careful reading
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D951 |
129,187 | 31.03.2021 20:42:43 | 14,400 | 72385a2e49b5da1febfa9e3dff1c5c7272d1ee93 | [server] Prevent threads from being converted to SIDEBARs
Summary: If you're not born a `SIDEBAR`, you can't become one.
Test Plan: careful reading
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -343,7 +343,9 @@ async function updateThread(\nif (\n!viewer.isScriptViewer &&\n- (threadType === threadTypes.PERSONAL || threadType === threadTypes.PRIV... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Prevent threads from being converted to SIDEBARs
Summary: If you're not born a `SIDEBAR`, you can't become one.
Test Plan: careful reading
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D952 |
129,187 | 31.03.2021 20:52:13 | 14,400 | 7ca77320fcf8105ab5ab27ec5b0ec54be65a0c8c | [server] Prevent changing SIDEBAR parentThreadID
Test Plan: careful reading
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -425,6 +425,11 @@ async function updateThread(\nlet nextParentThreadID =\nparentThreadID !== undefined ? parentThreadID : oldParentThreadID;\n+ // You ca... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Prevent changing SIDEBAR parentThreadID
Test Plan: careful reading
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D953 |
129,187 | 31.03.2021 20:55:44 | 14,400 | c54604590a8d0f8deb4feb332a008cc9d0fbe5b7 | [server] recalculateAllPermissions -> recalculateThreadPermissions
Summary: This is a simple rename. The old name was ambiguous with the other function `recalculateAllThreadPermissions`.
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -30,7 +30,7 @@ import { fetchKnownUserInfos } from '../fetchers/user-fetchers';\nimport type { Viewer } from '../session/viewer';\nimport {\nchangeRole,\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] recalculateAllPermissions -> recalculateThreadPermissions
Summary: This is a simple rename. The old name was ambiguous with the other function `recalculateAllThreadPermissions`.
Test Plan: Flow
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: zrebcu411, Adrian, atul, subnub
Differen... |
129,187 | 05.04.2021 12:45:28 | 14,400 | 7e704d746eef7ceb9c4cdfc3ff5f0215a938338e | Factor out shared webpack config into lib/webpack/shared.cjs
Summary: We're going to use this in the upcoming `landing` project.
Test Plan: Make sure Webpack still builds and server still returns a working webpage on both dev and prod
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/webpack/shared.cjs",
"diff": "+const webpack = require('webpack');\n+const path = require('path');\n+const MiniCssExtractPlugin = require('mini-css-extract-plugin');\n+const TerserPlugin = require('terser-webpack-plugin');\n+const OptimizeCs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out shared webpack config into lib/webpack/shared.cjs
Summary: We're going to use this in the upcoming `landing` project.
Test Plan: Make sure Webpack still builds and server still returns a working webpage on both dev and prod
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adri... |
129,187 | 05.04.2021 15:13:29 | 14,400 | 5fa613d01d9f004a7ee8a2d26d02b4f2c6f9e4c2 | [landing] Hello World for landing page
Summary: Hot refresh, Webpack working
Test Plan: Load the loading page at `http://localhost/comm/misc/landing.html` and confirm hot refresh works if you edit `landing/landing.react.js`
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": ".DS_Store\nnode_modules\n+landing/node_modules\n+landing/dist\nlib/node_modules\n-web/node_modules/*\n+web/node_modules\nweb/dist\nserver/dist\n-server/node_modules/*\n+server/node_modules\nserver/secrets\nserver... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Hello World for landing page
Summary: Hot refresh, Webpack working
Test Plan: Load the loading page at `http://localhost/comm/misc/landing.html` and confirm hot refresh works if you edit `landing/landing.react.js`
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian, subnub
... |
129,187 | 05.04.2021 16:14:56 | 14,400 | 425775eef9ba9118ba727ac3e9260ea4acc80592 | [server] Add getLandingURLFacts and landing_url.json
Test Plan: Tested in conjunction with future diffs
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "docs/dev_environment.md",
"new_path": "docs/dev_environment.md",
"diff": "@@ -461,6 +461,22 @@ Your `app_url.json` file should look like this:\n}\n```\n+Finally, we'll create a file for the URLs in the landing page.\n+\n+```\n+vim server/facts/landing_url.json... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add getLandingURLFacts and landing_url.json
Test Plan: Tested in conjunction with future diffs
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D967 |
129,187 | 05.04.2021 16:29:04 | 14,400 | c6b3325e503d81dc4d8d89dbb7c0404779406c4e | [server] Create landing_compiled symlink and move old compiled symlink to app_compiled
Test Plan: Make sure server still returns a working website
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": ".eslintignore",
"new_path": ".eslintignore",
"diff": "@@ -3,7 +3,8 @@ lib/node_modules\nweb/dist\nweb/flow-typed\nweb/node_modules\n-server/compiled\n+server/app_compiled\n+server/landing_compiled\nserver/dist\nserver/secrets\nserver/facts\n"
},
{
"cha... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create landing_compiled symlink and move old compiled symlink to app_compiled
Test Plan: Make sure server still returns a working website
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D968 |
129,187 | 05.04.2021 19:39:51 | 14,400 | e2ff81665e711de7a658fd255519523ba58ec374 | [server] Make it possible to access landing from server
Test Plan: Tested in conjunction with future diffs
Reviewers: atul, palys-swm
Subscribers: KatPo, zrebcu411, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "server/.flowconfig",
"new_path": "server/.flowconfig",
"diff": ".*/web/flow-typed\n[include]\n+../landing\n../lib\n../web\n"
},
{
"change_type": "MODIFY",
"old_path": "server/loader.mjs",
"new_path": "server/loader.mjs",
"diff": "+const loc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Make it possible to access landing from server
Test Plan: Tested in conjunction with future diffs
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, zrebcu411, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D970 |
129,187 | 06.04.2021 15:51:42 | 14,400 | a7e595d4e504c366718b2efb38758b9eabc0c44d | [landing] Flow updates
Summary:
These updates are necessary to make `landing` page work with `flow-bin@0.137.0`, which is the version associated with `react-native@0.64.0`.
Wanted to submit them now to avoid having to deal with any rebasing later.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, zrebcu411, palys-swm... | [
{
"change_type": "MODIFY",
"old_path": "landing/.flowconfig",
"new_path": "landing/.flowconfig",
"diff": "+[include]\n+../lib\n+\n+[libs]\n+../lib/flow-typed\n+\n[options]\nmodule.name_mapper.extension='css' -> '<PROJECT_ROOT>/flow/CSSModule.js.flow'\nesproposal.optional_chaining=enable\n"
},
{
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Flow updates
Summary:
These updates are necessary to make `landing` page work with `flow-bin@0.137.0`, which is the version associated with `react-native@0.64.0`.
Wanted to submit them now to avoid having to deal with any rebasing later.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: Kat... |
129,184 | 07.04.2021 11:42:22 | 14,400 | 4fa4c2eadeb8696d61dbfaf81d0268dbc49b7a52 | [landing] Change landing page title to Comm
Summary: NA
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, palys-swm, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/landing-handler.js",
"new_path": "server/src/responders/landing-handler.js",
"diff": "@@ -52,7 +52,7 @@ async function landingResponder(req: $Request, res: $Response) {\n<html lang=\"en\">\n<head>\n<meta charset=\"utf-8\" />\n- <title>Hel... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Change landing page title to Comm
Summary: NA
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, palys-swm, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D976 |
129,184 | 07.04.2021 17:57:10 | 14,400 | bca0dfc26e36dbccaa16d1fd1cad308e859ba9b3 | [landing] Radial gradient background for landing page
Summary: Recreate radial gradient from figma
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, palys-swm, Adrian, subnub | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/landing.css",
"diff": "+html {\n+ overflow: hidden;\n+ height: 100%;\n+ background: radial-gradient(ellipse at bottom, #374151, #111827);\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Radial gradient background for landing page
Summary: Recreate radial gradient from figma
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, palys-swm, Adrian, subnub
Differential Revision: https://phabricator.ashoat.com/D977 |
129,184 | 08.04.2021 14:19:06 | 14,400 | 7e82fd73953180574519f00fff86b9924e596a49 | [landing] Recreate parallax star effect with `react-particles-js`
Summary:
Introduce `react-particle-js`:
Here's what it looks like:
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, palys-swm, Adrian, subnub | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -7,4 +7,5 @@ html {\nh1 {\nfont-family: 'IBM Plex Sans', sans-serif;\ncolor: white;\n+ font-size: 28px;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Recreate parallax star effect with `react-particles-js`
Summary:
Introduce `react-particle-js`: https://github.com/Wufe/react-particles-js
Here's what it looks like: https://blob.sh/atul/parallax.mov
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, palys-swm, Adrian, su... |
129,184 | 08.04.2021 15:34:35 | 14,400 | 7f6399eac6d3fcda3a5c7d464acc1a83db803799 | [landing] Add SVG to imageRule
Summary: Add SVG to imageRule so we can incorporate the illustrations from figma
Test Plan: I was able to add the eyeball illustration to the page (https://blob.sh/atul/eyeball.png)
Reviewers: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/webpack/shared.cjs",
"new_path": "lib/webpack/shared.cjs",
"diff": "@@ -63,7 +63,7 @@ function getBrowserBabelRule(babelConfig) {\n}\nconst imageRule = {\n- test: /\\.png$/,\n+ test: /\\.(png|svg)$/,\nuse: ['url-loader'],\n};\n@@ -173,10 +173,7 @@ function... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add SVG to imageRule
Summary: Add SVG to imageRule so we can incorporate the illustrations from figma
Test Plan: I was able to add the eyeball illustration to the page (https://blob.sh/atul/eyeball.png)
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian
Differential Revi... |
129,191 | 22.03.2021 17:14:50 | -3,600 | cbe4defdd26196f94e0810d712a746baacd88777 | [lib] Use parameters object in createRealThreadFromPendingThread function
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -402,14 +402,22 @@ function pendingThreadType(numberOfOtherMembers: number) {\n: threadTypes.CHAT_SECRET;\n}\n-async function createRealThreadFromPendingThread(\n- threadInfo: T... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use parameters object in createRealThreadFromPendingThread function
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian, atul, subnub
Differential Revision: https://phabricator.ashoat.com/D927 |
129,184 | 08.04.2021 17:10:46 | 14,400 | 3756cf49a54fafca83035c538db5dc6a21821adb | [landing] add landing workspace description to readme
Summary: NA
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -5,9 +5,11 @@ Comm is the working name of this open source messaging project.\n## Repo structure\nThe whole project is written in Flow-typed Javascript. The code is organized in a monorepo structure using Yarn W... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] add landing workspace description to readme
Summary: NA
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D985 |
129,191 | 09.04.2021 13:51:41 | -7,200 | a2c06ce607c9ebfc81aa2dac0ed7787b00237335 | [server] Make source message unique
Test Plan: Run the script. Try to create two threads with the same source_message and check if an error was returned.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-db.js",
"new_path": "server/src/scripts/create-db.js",
"diff": "@@ -155,7 +155,7 @@ async function createTables() {\ncreator bigint(20) NOT NULL,\ncreation_time bigint(20) NOT NULL,\ncolor char(6) COLLATE utf8mb4_bin NOT NULL,\n- sour... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Make source message unique
Test Plan: Run the script. Try to create two threads with the same source_message and check if an error was returned.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1001 |
129,183 | 12.04.2021 15:24:54 | -7,200 | b1db072216243538255ee1fd4a33d5328533e1af | [web] Allow nullable threadID in useOnClickThread
Summary: I need this for next diff, context [[ | here ]]
Test Plan: Flow, tested with next diffs
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/selectors/nav-selectors.js",
"new_path": "web/selectors/nav-selectors.js",
"diff": "@@ -124,10 +124,14 @@ const nonThreadCalendarQuery: (\n},\n);\n-function useOnClickThread(threadID: string) {\n+function useOnClickThread(threadID: ?string) {\nconst dispat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Allow nullable threadID in useOnClickThread
Summary: I need this for next diff, context [[ https://phabricator.ashoat.com/D995#inline-5473 | here ]]
Test Plan: Flow, tested with next diffs
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential R... |
129,184 | 16.04.2021 12:27:20 | 14,400 | 5ed34fe28f04c511c7756797cfa95c45dfed0b1b | [landing] Add copy to landing page
Summary: NA
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -2,10 +2,16 @@ html {\noverflow: hidden;\nheight: 100%;\nbackground: radial-gradient(ellipse at bottom, #374151, #111827);\n-}\n-\n-h1 {\nfont-family: 'IBM Plex Sans', sans-serif;\ncolor: whi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add copy to landing page
Summary: NA
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1012 |
129,184 | 19.04.2021 17:07:08 | 14,400 | e707969d113d088a34e24b12c1484599211fd6ee | [landing] Particles.js configuration tweak
Summary: NA
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/particles-config.json",
"new_path": "landing/particles-config.json",
"diff": "},\n\"move\": {\n\"enable\": true,\n- \"speed\": 1.5,\n+ \"speed\": 0.75,\n\"direction\": \"top\",\n\"random\": false,\n\"straight\": true,\n\"bounce\": false,\n\"attract\": ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Particles.js configuration tweak
Summary: NA
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1013 |
129,183 | 09.04.2021 11:46:29 | -7,200 | c67836260c7768cd7c2b5b51a8b91047c318ec39 | [web] Rename replyTooltip to replyButton
Summary: Part of refactoring done with tooltipMenu introduction: reply is not a tooltip, but rather button
Test Plan: Flow, check if reply is still possible
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -215,7 +215,7 @@ div.nonViewerMessageActionLinks {\ndiv.messageActionLinks > div + div {\nmargin-left: 4px;\n}\n-div.messageReplyTooltip {\n+div.messageReplyButton {\nfo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename replyTooltip to replyButton
Summary: Part of refactoring done with tooltipMenu introduction: reply is not a tooltip, but rather button
Test Plan: Flow, check if reply is still possible
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differentia... |
129,183 | 09.04.2021 12:19:23 | -7,200 | ce12f74c0e9e6470141673dc30ac54815b86bb3e | [web] Rename sidebarTooltip to messageActionTooltip
Summary: Part of refactoring done with tooltipMenu introduction: `sidebarTooltip` can be used not only for sidebars action
Test Plan: Flow, check if tooltip looks and works as before
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -218,7 +218,7 @@ div.messageActionLinks > div + div {\ndiv.messageReplyButton {\nfont-size: 14px;\n}\n-div.messageSidebarTooltip {\n+div.messageActionButton {\nfont-size... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename sidebarTooltip to messageActionTooltip
Summary: Part of refactoring done with tooltipMenu introduction: `sidebarTooltip` can be used not only for sidebars action
Test Plan: Flow, check if tooltip looks and works as before
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat,... |
129,183 | 09.04.2021 12:23:52 | -7,200 | 378ef4bf288eb263818e96338b96465585557448 | [web] Rename messageTooltipIcon to messageActionLinkIcon
Summary: Change of names used in reply and action button for messages to be clear what we call 'tooltip'
Test Plan: Flow, check if visually nothing changed
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -222,11 +222,11 @@ div.messageActionButton {\nfont-size: 16px;\n}\n-div.messageTooltipIcon {\n+div.messageActionLinkIcon {\npadding: 2px 3px;\nposition: relative;\n}\n-d... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename messageTooltipIcon to messageActionLinkIcon
Summary: Change of names used in reply and action button for messages to be clear what we call 'tooltip'
Test Plan: Flow, check if visually nothing changed
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, at... |
129,187 | 14.04.2021 13:13:49 | 14,400 | 57588fae748567e0d73e5a85dd2eb536d14e8caf | [web] Don't show Privacy tab in ThreadSettingsModal for sidebars
Summary: More accurately: for threads created as sidebars. More context [here](https://phabricator.ashoat.com/D1000?id=3007#inline-5622).
Test Plan: Check `ThreadSettingsModal` for a thread created as a sidebar
Reviewers: KatPo, palys-swm
Subscribers: Adr... | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/thread-settings-modal.react.js",
"new_path": "web/modals/threads/thread-settings-modal.react.js",
"diff": "@@ -338,7 +338,16 @@ class ThreadSettingsModal extends React.PureComponent<Props, State> {\nkey=\"general\"\n/>,\n];\n- if (this.possi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Don't show Privacy tab in ThreadSettingsModal for sidebars
Summary: More accurately: for threads created as sidebars. More context [here](https://phabricator.ashoat.com/D1000?id=3007#inline-5622).
Test Plan: Check `ThreadSettingsModal` for a thread created as a sidebar
Reviewers: KatPo, palys-swm
Reviewed By:... |
129,187 | 14.04.2021 23:39:14 | 14,400 | 9f08352bca5c5b675a4b0441bd63f7c8fb03f607 | [server] Get rid of unused MembershipRowToSave.subscription parameter
Summary: This isn't used anywhere so I'm getting rid of it to make the code simpler.
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -9,7 +9,6 @@ import {\nmakePermissionsForChildrenBlob,\n} from 'lib/permissions/thread-permissions';\nimport type { CalendarQuery }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Get rid of unused MembershipRowToSave.subscription parameter
Summary: This isn't used anywhere so I'm getting rid of it to make the code simpler.
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1022 |
129,187 | 19.04.2021 18:07:14 | 14,400 | b084cd806e337c65a15d36e6b91fd9fb4401c5dc | [server] Migration to update sidebars to depend on parent for KNOW_OF
Summary: This migration updates the database to reflect D1020
Test Plan: Run the migration and make sure the output looks good and the database looks right
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/sidebar-know-of-migration.js",
"diff": "+// @flow\n+\n+import bots from 'lib/facts/bots.json';\n+import { threadTypes, type ThreadType } from 'lib/types/thread-types';\n+\n+import { dbQuery, SQL } from '../database/database';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Migration to update sidebars to depend on parent for KNOW_OF
Summary: This migration updates the database to reflect D1020
Test Plan: Run the migration and make sure the output looks good and the database looks right
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differentia... |
129,191 | 19.04.2021 18:01:11 | -7,200 | 00bf4afecdb63116a13cd8e9c58804bdc28c0cd8 | [lib] Change generatePendingThreadColor to accept only an array
Test Plan: Login on two devices as different users. Search for a pending thread with both users and one another. Check if thread color is the same on both devices.
Reviewers: ashoat
Subscribers: ashoat, KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -79,11 +79,8 @@ function generateRandomColor() {\nreturn color;\n}\n-function generatePendingThreadColor(\n- userIDs: $ReadOnlyArray<string>,\n- viewerID: string,\n-) {\n- const... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Change generatePendingThreadColor to accept only an array
Test Plan: Login on two devices as different users. Search for a pending thread with both users and one another. Check if thread color is the same on both devices.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, Adrian, atul
Differen... |
129,191 | 20.04.2021 16:02:34 | -7,200 | 8b25f351525a3d086c2f3d163a7a1fedeb48734e | [lib] Introduce pending thread creation map
Test Plan: Create real thread from pending thread
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -129,6 +129,7 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nsendCallbacks: Array<() => void> = [];\nactiveURIs = ne... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce pending thread creation map
Test Plan: Create real thread from pending thread
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1034 |
129,184 | 19.04.2021 17:55:18 | 14,400 | cd1968d1808952bebf52dde685cac55721cbbf79 | [landing] Two-column CSS Grid
Summary: Naive two-column CSS Grid layout, will be fleshed out in subsequent diffs
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -10,18 +10,47 @@ h2 {\nfont-family: 'IBM Plex Mono', monospace;\n}\n-div.hero {\n+div.grid {\n+ display: grid;\n+ padding: 80px;\n+ row-gap: 18em;\n+ grid-template-columns: 1fr 1fr;\n+ grid-t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Two-column CSS Grid
Summary: Naive two-column CSS Grid layout, will be fleshed out in subsequent diffs
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1030 |
129,184 | 19.04.2021 18:39:47 | 14,400 | af879019739ecbc518e2a4e1aad314263ad59a78 | [landing] Text styling
Summary: Styling text based on values specified in "largest" breakpoint of Figma doc. Will consider differences at each breakpoint in later diffs.
Test Plan: NA, everything seems to look as it should on Safari/Chrome/Firefox so far
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -10,10 +10,33 @@ h2 {\nfont-family: 'IBM Plex Mono', monospace;\n}\n+h1.title {\n+ font-family: 'IBM Plex Sans', sans-serif;\n+ font-size: 24px;\n+ padding-left: 80px;\n+}\n+\n+span.purple {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Text styling
Summary: Styling text based on values specified in "largest" breakpoint of Figma doc. Will consider differences at each breakpoint in later diffs.
Test Plan: NA, everything seems to look as it should on Safari/Chrome/Firefox so far
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, pa... |
129,187 | 21.04.2021 16:30:26 | 14,400 | aa4330c2bcd7ff3d6e62a84f3e60fa4d117c110d | [native] Fix Android debug build on Android 10
Summary: See this Notion task:
Test Plan: Build it and run on Android 10
Reviewers: karol-bisztyga
Subscribers: KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -173,10 +173,8 @@ android {\n}\npackagingOptions {\n- pickFirst \"lib/armeabi-v7a/libc++_shared.so\"\n- pickFirst \"lib/arm64-v8a/libc++_shared.so\"\n- pickFirst \"lib... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Android debug build on Android 10
Summary: See this Notion task: https://www.notion.so/commapp/Android-build-insta-crashes-due-to-Flipper-dependency-b46d1aa7dde04b4185c80e1c695f4d8e
Test Plan: Build it and run on Android 10
Reviewers: karol-bisztyga
Reviewed By: karol-bisztyga
Subscribers: KatPo, paly... |
129,190 | 15.04.2021 12:49:50 | -7,200 | 438116e0fa35913712216dede46f348fb9c76e3d | [sqlite] prepare android
Summary: add necessary code to make sqlite work on android
Test Plan: Please read [this](https://phabricator.ashoat.com/D1010)
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/CommonCpp/DatabaseManagers/SQLiteManager.cpp",
"new_path": "native/CommonCpp/DatabaseManagers/SQLiteManager.cpp",
"diff": "@@ -5,6 +5,8 @@ namespace comm {\nSQLiteManager::SQLiteManager() {}\n+std::string SQLiteManager::sqliteFilePath;\n+\nstd::string S... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [sqlite] prepare android
Summary: add necessary code to make sqlite work on android
Test Plan: Please read [this](https://phabricator.ashoat.com/D1010)
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.... |
129,190 | 15.04.2021 12:50:04 | -7,200 | a6fdeb839e14dfbd6cfeb4e11a6ebacc8db57f89 | [sqlite] prepare ios
Summary: introduce necessary changes to make sqlite work on ios
Test Plan: Please read [this](https://phabricator.ashoat.com/D1010)
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/SquadCal.xcodeproj/project.pbxproj",
"new_path": "native/ios/SquadCal.xcodeproj/project.pbxproj",
"diff": "13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB51A68108700A75B9A /* Images.xcassets */; }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [sqlite] prepare ios
Summary: introduce necessary changes to make sqlite work on ios
Test Plan: Please read [this](https://phabricator.ashoat.com/D1010)
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat... |
129,191 | 22.04.2021 17:50:18 | -7,200 | 815625b26bf59d756693d743860480d15937d7fb | [native] Do not prune pending threads
Test Plan: Increase pruning frequency, create pending thread with failed message, open another thread and verify that pending thread is not included in pruning action.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/selectors/message-selectors.js",
"new_path": "native/selectors/message-selectors.js",
"diff": "import { createSelector } from 'reselect';\n+import { threadIsPending } from 'lib/shared/thread-utils';\nimport type { ThreadMessageInfo } from 'lib/types/mes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Do not prune pending threads
Test Plan: Increase pruning frequency, create pending thread with failed message, open another thread and verify that pending thread is not included in pruning action.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabric... |
129,184 | 22.04.2021 16:57:09 | 14,400 | a4ab86cee3847cab51f7c00c3408d24e5af5e4b1 | [landing] Animate eye animation on scroll with `lottie-interactivity`
Summary: Introduce `lottie-interactivity` and use it to animation eye illustration on scroll.
Test Plan: Looks fine on Chrome/Safari/Firefox
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "// @flow\n+import { create } from '@lottiefiles/lottie-interactivity';\nimport * as React from 'react';\nimport Particles from 'react-particles-js';\nimport css from './landing.css';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Animate eye animation on scroll with `lottie-interactivity`
Summary: Introduce `lottie-interactivity` and use it to animation eye illustration on scroll.
Test Plan: Looks fine on Chrome/Safari/Firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: http... |
129,184 | 23.04.2021 14:56:58 | 14,400 | b84ae6c5a56f404994f89306cba9b34c5584b204 | [landing] Read the docs button
Summary:
Button that links to Comm docs in Notion. SVG exported from Figma mockup.
What it looks like:
On hover:
Test Plan: Looks fine in Safari/Chrome/Firefox
Reviewers: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -6,6 +6,7 @@ import Particles from 'react-particles-js';\nimport css from './landing.css';\nimport particlesConfig from './particles-config.json';\n+import ReadDocsButton from './re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Read the docs button
Summary:
Button that links to Comm docs in Notion. SVG exported from Figma mockup.
What it looks like: https://blob.sh/atul/2516.png
On hover: https://blob.sh/atul/7528.png
Test Plan: Looks fine in Safari/Chrome/Firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatP... |
129,184 | 23.04.2021 15:45:35 | 14,400 | 072b16b561ad51bd99ad842af7602e186272552c | [landing] "Subscribe for updates" button
Summary:
Here's what it looks like:
On hover:
Test Plan: Looks fine on Safari/Chrome/Firefox
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/subscribe-btn.css",
"diff": "+.button {\n+ width: 265px;\n+ height: 68px;\n+ position: relative;\n+ border: none;\n+ background: transparent;\n+ padding: 24px, 32px, 24px, 32px;\n+ cursor: pointer;\n+ border-radius: 8px;\n+ font-family: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] "Subscribe for updates" button
Summary:
Here's what it looks like:
https://blob.sh/atul/0fd5.png
On hover:
https://blob.sh/atul/812e.png
Test Plan: Looks fine on Safari/Chrome/Firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.... |
129,190 | 23.04.2021 10:02:25 | -7,200 | 9fd65c50924c2a83bebc6d8990134a9d2b1250e8 | [sqlite] simplify sqlite_orm path
Summary: Add `sqlite_orm` path so the `#include` looks better in `SQLiteManager.h`
Test Plan: build the app for iOS/android
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/CommonCpp/DatabaseManagers/SQLiteManager.h",
"new_path": "native/CommonCpp/DatabaseManagers/SQLiteManager.h",
"diff": "#pragma once\n-#include \"../sqlite_orm/sqlite_orm.h\"\n+#include \"sqlite_orm.h\"\n#include \"DatabaseManagerInterface.h\"\n#include ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [sqlite] simplify sqlite_orm path
Summary: Add `sqlite_orm` path so the `#include` looks better in `SQLiteManager.h`
Test Plan: build the app for iOS/android
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.a... |
129,184 | 26.04.2021 15:13:44 | 14,400 | 8c7b3a3d0f6095944cf2fb17f1b88de871ffb054 | [landing] fix paths so they'll work on prod
Summary: Modify `server.js` so `images`/`fonts`/`icons` can be accessed from `commlanding` root
Test Plan: Assets appear correctly on Safari/Chrome/Firefox
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -49,7 +49,7 @@ function Landing(): React.Node {\nid=\"eye-illustration\"\nref={setEyeNode}\nmode=\"normal\"\n- src=\"../comm/images/animated_eye.json\"\n+ src=\"images/animated_eye.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] fix paths so they'll work on prod
Summary: Modify `server.js` so `images`/`fonts`/`icons` can be accessed from `commlanding` root
Test Plan: Assets appear correctly on Safari/Chrome/Firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabric... |
129,184 | 26.04.2021 11:53:01 | 14,400 | d61d48439e005799355d0b6a59652b9f74f5572f | [landing] Email subscription form
Summary: Here's what it looks like:
Test Plan: Looks good on Safari/Chrome/Firefox
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/subscription-form.css",
"diff": "+form {\n+ display: flex;\n+}\n+\n+.button {\n+ position: relative;\n+ width: auto;\n+ height: 50px;\n+ border: 1px solid white;\n+ border-radius: 8px;\n+ border-left: none;\n+ border-top-left-radius: 0px... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Email subscription form
Summary: Here's what it looks like: https://blob.sh/atul/d0a1.png
Test Plan: Looks good on Safari/Chrome/Firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1052 |
129,184 | 26.04.2021 12:01:44 | 14,400 | fde4c9182913087ad3047dc9b3d31d3d20c2ceaf | [landing] Styling and layout changes
Summary: Miscellaneous styling and layout changes.
Test Plan: Looks good on Safari/Chrome/Firefox.
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "html {\n- background: radial-gradient(ellipse at bottom, #374151, #111827);\n+ background: radial-gradient(ellipse at bottom, #1f252e, #111827);\nbackground-attachment: fixed;\nfont-family: 'IBM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Styling and layout changes
Summary: Miscellaneous styling and layout changes.
Test Plan: Looks good on Safari/Chrome/Firefox.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1053 |
129,184 | 26.04.2021 14:23:17 | 14,400 | 982c341515cefdea69d4295d50cf7523d1aeb138 | [landing] favicon
Summary: Added favicons from Daniel
Test Plan: Looks find on Safari/Chrome/Firefox
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": "server/landing_icons/apple-touch-icon.png",
"new_path": "server/landing_icons/apple-touch-icon.png",
"diff": "Binary files /dev/null and b/server/landing_icons/apple-touch-icon.png differ\n"
},
{
"change_type": "ADD",
"old_path": "server/landing_icons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] favicon
Summary: Added favicons from Daniel
Test Plan: Looks find on Safari/Chrome/Firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1055 |
129,190 | 23.04.2021 13:28:47 | -7,200 | 53b671166e40590bd172f894c8595124e2787c6e | [jsi] rename native module
Summary: rename native module exposed to js from `draftModule` to `CommCoreModule`
Test Plan: use `global.CommCoreModule.getDraft` and `global.CommCoreModule.updateDraft`
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "RENAME",
"old_path": "native/CommonCpp/NativeModules/DraftNativeModule.cpp",
"new_path": "native/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "-#include \"DraftNativeModule.h\"\n+#include \"CommCoreModule.h\"\n#include \"DatabaseManager.h\"\nnamespace comm {\n-jsi::String D... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [jsi] rename native module
Summary: rename native module exposed to js from `draftModule` to `CommCoreModule`
Test Plan: use `global.CommCoreModule.getDraft` and `global.CommCoreModule.updateDraft`
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Diff... |
129,184 | 26.04.2021 21:40:20 | 14,400 | 0bc0a9f4729e284ec24db54deb06ed63ced30146 | [landing] responsive font-sizes
Summary: Sets different font-sizes at each of the relevant breakpoints. The values can be adjusted based on feedback.
Test Plan: `Inspect Element` on Safari/Chrome confirms that the font-sizes are as expected at various widths.
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -17,12 +17,12 @@ h1.title {\npadding-left: 60px;\n}\n-span.purple {\n- color: #7e57c2;\n+h1 {\n+ font-size: 58px;\n}\n-h2.lede {\n- font-size: 56px;\n+span.purple {\n+ color: #7e57c2;\n}\nh2 ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] responsive font-sizes
Summary: Sets different font-sizes at each of the relevant breakpoints. The values can be adjusted based on feedback.
Test Plan: `Inspect Element` on Safari/Chrome confirms that the font-sizes are as expected at various widths.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatP... |
129,184 | 27.04.2021 09:30:55 | 14,400 | f88b042da3a9c3d6df05636b71bf5d9db0e40fc7 | [landing] Set maximum column width to 540px at 1099px breakpoint
Summary:
This change fixes the margin issue with the 1099px breakpoint discussed yesterday.
Here's what it looks like:
Test Plan: Looks good on Safari/Firefox
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -69,7 +69,8 @@ div.grid {\npadding-left: 60px;\npadding-right: 60px;\nrow-gap: 2em;\n- grid-template-columns: 1fr;\n+ grid-template-columns: minmax(auto, 540px);\n+ justify-content: center;\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Set maximum column width to 540px at 1099px breakpoint
Summary:
This change fixes the margin issue with the 1099px breakpoint discussed yesterday.
Here's what it looks like: https://blob.sh/atul/1610.png
Test Plan: Looks good on Safari/Firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, pa... |
129,184 | 27.04.2021 09:52:01 | 14,400 | ece948b938ec1ad610257d879b93560d04e45952 | [landing] Responsive subscription form
Summary:
two-row subscription form at 1099px breakpoint
here's what it looks like:
and at higher breakpoints:
Test Plan: looks good on safari/firefox
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -38,6 +38,7 @@ div.grid {\npadding-top: 20px;\npadding-left: 60px;\npadding-right: 60px;\n+ padding-bottom: 40px;\nrow-gap: 14em;\ncolumn-gap: 4em;\ngrid-template-rows: 1fr 1fr 1fr 1/6fr;\n"
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Responsive subscription form
Summary:
two-row subscription form at 1099px breakpoint
here's what it looks like: https://blob.sh/atul/c586.png
and at higher breakpoints: https://blob.sh/atul/1601.png
Test Plan: looks good on safari/firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-s... |
129,184 | 28.04.2021 12:50:04 | 14,400 | e95b243a5b4f530a048b90c9fa646dbdf03f0969 | [server] Email subscription endpoint
Summary: Endpoint for email subscriptions to be hit by form on landing page.
Test Plan: Modified user-actions:requestAccess to hit `subscribe-email` instead of `request-access` and logged that the endpoint was being hit.
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "@@ -150,3 +150,7 @@ export type AccessRequest = {|\n+email: string,\n+platform: DeviceType,\n|};\n+\n+export type EmailSubscriptionRequest = {|\n+ +email: string,\n+|};\n"
},
{... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Email subscription endpoint
Summary: Endpoint for email subscriptions to be hit by form on landing page.
Test Plan: Modified user-actions:requestAccess to hit `subscribe-email` instead of `request-access` and logged that the endpoint was being hit.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo,... |
129,184 | 28.04.2021 13:21:08 | 14,400 | 90a010351d2feb3def1b0f6e5e223b2d1f63abc6 | [server] validate email addresses in `user-responders` and `comm-landing-responders`
Summary: Introduce `tEmail` to validate email addresses with tcomb
Test Plan: Tested with `access-request` and `subscribe-email`
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/account-utils.js",
"new_path": "lib/shared/account-utils.js",
"diff": "@@ -15,6 +15,8 @@ const validUsernameRegexString = `^[a-zA-Z0-9][a-zA-Z0-9-_]{5,${\n}}$`;\nconst validUsernameRegex = new RegExp(validUsernameRegexString);\n+// usernames used to... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] validate email addresses in `user-responders` and `comm-landing-responders`
Summary: Introduce `tEmail` to validate email addresses with tcomb
Test Plan: Tested with `access-request` and `subscribe-email`
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: h... |
129,184 | 29.04.2021 14:48:13 | 14,400 | 6f52870b6edc0b3ee00002d8ee88af953ade45ed | [lib] Modify `lib/facts/ashoat.json`
Summary: Swap out gmail for comm.app address and add `landing_email` entry. Use `landing_email` in `subscribe-email-updates`.
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/ashoat.json",
"new_path": "lib/facts/ashoat.json",
"diff": "{\n\"id\": \"256\",\n- \"email\": \"ashoat@gmail.com\"\n+ \"email\": \"ashoat@gmail.com\",\n+ \"landing_email\": \"ashoat+landing@comm.app\"\n}\n"
},
{
"change_type": "MODIFY",
"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify `lib/facts/ashoat.json`
Summary: Swap out gmail for comm.app address and add `landing_email` entry. Use `landing_email` in `subscribe-email-updates`.
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1077 |
129,184 | 03.05.2021 11:37:38 | 25,200 | 34f5c52df5af22617874eb670ec4726490e5f2e9 | [landing] non breaking space for headline
Summary: We discussed how we didn't want the purple 'digital identity' text to be broken up into separate lines. Using non-breaking space addresses this.
Test Plan: Looks as expected on Safari/Chrome/Firefox
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -57,7 +57,7 @@ function Landing(): React.Node {\n<div className={css.hero_copy}>\n<h1>\nReclaim your\n- <span className={css.purple}> digital identity.</span>\n+ <span className={cs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] non breaking space for headline
Summary: We discussed how we didn't want the purple 'digital identity' text to be broken up into separate lines. Using non-breaking space addresses this.
Test Plan: Looks as expected on Safari/Chrome/Firefox
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-s... |
129,187 | 01.05.2021 09:22:00 | 14,400 | 76924da84cd6f40f9f88aa9c869783471b1d79ab | [native] Fix ChatThreadList search to top when active
Summary: This diff solves this [Notion issue](https://www.notion.so/commapp/ThreadList-scrolls-to-top-when-item-pressed-c60cd69ababd4b8bba0b957ff8b85de5), and is a better UX anyways.
Test Plan: Tested it on iOS and Android and made sure it's smooth
Reviewers: palys-... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "import invariant from 'invariant';\nimport _sum from 'lodash/fp/sum';\nimport * as React from 'react';\n-import { View, FlatList, Platform, TextInput } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix ChatThreadList search to top when active
Summary: This diff solves this [Notion issue](https://www.notion.so/commapp/ThreadList-scrolls-to-top-when-item-pressed-c60cd69ababd4b8bba0b957ff8b85de5), and is a better UX anyways.
Test Plan: Tested it on iOS and Android and made sure it's smooth
Reviewers: pal... |
129,187 | 02.05.2021 17:01:01 | 14,400 | 980375f24576d349ef07af9fc25d0cce283d662e | [native]
Summary: Fixes [this issue](https://github.com/ds300/patch-package/issues/166)
Test Plan:
1. Make sure `patch-package react-native` works without needing to manually patch `patch-package`
2. Make sure `yarn cleaninstall` works and still patches correctly
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"jest\": \"^25.1.0\",\n\"jetifier\": \"^1.6.4\",\n\"metro-react-native-babel-preset\": \"^0.59.0\",\n- \"patch-package\": \"^6.2.2\",\n+ \"patch-package\": \"^6.4.7\",\n\"postinstall-postinstal... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] patch-package@6.4.7
Summary: Fixes [this issue](https://github.com/ds300/patch-package/issues/166)
Test Plan:
1. Make sure `patch-package react-native` works without needing to manually patch `patch-package`
2. Make sure `yarn cleaninstall` works and still patches correctly
Reviewers: palys-swm
Subscribers... |
129,187 | 02.05.2021 14:59:02 | 14,400 | 560257f83ce1139b41c65c710b11ef9ccdbc9035 | [native]
Summary: This is necessary to fix the build with XCode 12.5.
Test Plan: In combination with D1087 and D1089, confirm that I can build iOS as (dev, release, archive) on (simulator, device
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -115,10 +115,10 @@ PODS:\n- libwebp/mux (1.1.0):\n- libwebp/demux\n- libwebp/webp (1.1.0)\n- - lottie-ios (3.1.3)\n- - lottie-react-native (3.2.1):\n- - lottie-ios (~> 3.1.3)\n- - Rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] lottie-react-native@4.0.2
Summary: This is necessary to fix the build with XCode 12.5.
Test Plan: In combination with D1087 and D1089, confirm that I can build iOS as (dev, release, archive) on (simulator, device
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabrica... |
129,187 | 02.05.2021 21:35:42 | 25,200 | 148227c313f4e8a5938e3901ce312790fcba736d | [native] Fix sqlite_orm compilation on XCode 12.5
Summary: More details [here](https://github.com/fnc12/sqlite_orm/issues/716)
Test Plan:
1. In combination with D1087 and D1088, confirm that I can build iOS as (dev, release, archive) on (simulator, device
2. Confirm that Android still builds as well
Reviewers: karol-bi... | [
{
"change_type": "MODIFY",
"old_path": "native/CommonCpp/sqlite_orm/sqlite_orm.h",
"new_path": "native/CommonCpp/sqlite_orm/sqlite_orm.h",
"diff": "@@ -4922,7 +4922,7 @@ namespace sqlite_orm {\n#include <sqlite3.h>\n#include <type_traits> // std::enable_if_t, std::is_arithmetic, std::is_same, std::e... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix sqlite_orm compilation on XCode 12.5
Summary: More details [here](https://github.com/fnc12/sqlite_orm/issues/716)
Test Plan:
1. In combination with D1087 and D1088, confirm that I can build iOS as (dev, release, archive) on (simulator, device
2. Confirm that Android still builds as well
Reviewers: karol... |
129,187 | 03.05.2021 11:06:52 | 25,200 | 8a65c5d1585271e34ab75f9215bd943bfb6352b1 | [native] Show a cancel button while search is active
Summary: Modelled after Signal. Right now it's impossible to exit the search experience, so I hacked together a solution this morning.
Test Plan: Play around with it
Reviewers: palys-swm, KatPo
Subscribers: Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -11,6 +11,7 @@ import {\nTouchableWithoutFeedback,\n} from 'react-native';\nimport { FloatingAction } from 'react-native-floating-action';\n+import Animate... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Show a cancel button while search is active
Summary: Modelled after Signal. Right now it's impossible to exit the search experience, so I hacked together a solution this morning.
Test Plan: Play around with it
Reviewers: palys-swm, KatPo
Subscribers: Adrian, atul
Differential Revision: https://phabricator... |
129,187 | 03.05.2021 16:26:54 | 25,200 | 55ed78c7e400f59192428b3b552afddbcd7a4207 | [native] codeVersion -> 82 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -143,8 +143,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 82 |
129,187 | 03.05.2021 17:55:45 | 25,200 | df6c7489a4e1e0678de33bf5e33d286680ae1f2b | [native] Increase tap target surface for clear search button
Test Plan: Test it on Android
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/search.react.js",
"new_path": "native/components/search.react.js",
"diff": "@@ -48,7 +48,11 @@ const Search = React.forwardRef<Props, typeof TextInput>(\nlet clearSearchInputIcon = null;\nif (searchText) {\nclearSearchInputIcon = (\n- <Toucha... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Increase tap target surface for clear search button
Test Plan: Test it on Android
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1097 |
129,187 | 03.05.2021 17:57:35 | 25,200 | fb18fe18029244b5cd72f0caf1dcad0f795eb78a | [native] codeVersion -> 83 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -143,8 +143,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 83 |
129,187 | 04.05.2021 16:12:23 | 25,200 | 56bbdb4a2f356df0b30bdf58a93188303ae1bb42 | [landing] Clean up design
Test Plan: Test it using Chrome
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -3,6 +3,8 @@ html {\nbackground-attachment: fixed;\nfont-family: 'IBM Plex Sans', sans-serif;\ncolor: white;\n+ word-break: break-word;\n+ max-width: 1920px;\n}\nh1,\n@@ -11,10 +13,13 @@ h2 {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Clean up design
Test Plan: Test it using Chrome
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1104 |
129,187 | 04.05.2021 19:54:13 | 25,200 | 17d0750d92c585933b65713229da34e981eeba63 | [landing] Final fixes (hopefully?)
Test Plan: Load it
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -13,13 +13,10 @@ h2 {\nfont-weight: 600;\n}\n-div.title_container {\n- grid-area: title_container;\n-}\n-\nh1.title {\nfont-family: 'IBM Plex Sans', sans-serif;\nfont-size: 24px;\n+ grid-area... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Final fixes (hopefully?)
Test Plan: Load it
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1106 |
129,190 | 07.05.2021 10:09:54 | -7,200 | 74a06822120d5537892c036feb2880601b9478a0 | [jsi] Add formatted c++ code
Summary: This is the code that's formatted using changes from D1047, pushed as a separate diff so the new style can be clearly seen.
Test Plan: None, please just see those files
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/cpp/jniHelpers.h",
"new_path": "native/android/app/src/cpp/jniHelpers.h",
"diff": "@@ -7,18 +7,15 @@ namespace comm {\nnamespace jni = facebook::jni;\n-struct HashMap : jni::JavaClass<\n- HashMap,\n- jni::JMap<jni::JString, jni::JObject>... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [jsi] Add formatted c++ code
Summary: This is the code that's formatted using changes from D1047, pushed as a separate diff so the new style can be clearly seen.
Test Plan: None, please just see those files
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, a... |
129,191 | 07.05.2021 15:18:32 | -7,200 | 9bebd6bbb4dcea5e9d07fb25f283a141379ad819 | [lib] Create a constant holding local id prefix
Summary: We use `local` in a lot of places, so it makes sense to store it in a constant
Test Plan: Flow, test basic functionality
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "// @flow\n+import { localIDPrefix } from '../shared/message-utils';\nimport type {\nRawEntryInfo,\nCalendarQuery,\n@@ -60,7 +61,7 @@ function createLocalEntry(\n): RawEntryInfo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Create a constant holding local id prefix
Summary: We use `local` in a lot of places, so it makes sense to store it in a constant
Test Plan: Flow, test basic functionality
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1119 |
129,187 | 10.05.2021 01:19:20 | 14,400 | b532a8e65e8c8ba7f03cffcdad34501b8eab5791 | [native] Move CommCoreModule shim to a separate file
Summary: I figured this would be better in a separate file
Test Plan: Flow
Reviewers: karol-bisztyga, palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/data/core-module-shim.js",
"diff": "+// @flow\n+\n+if (!global.CommCoreModule) {\n+ global.CommCoreModule = {\n+ getDraft: () => '',\n+ updateDraft: () => {},\n+ };\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/root... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move CommCoreModule shim to a separate file
Summary: I figured this would be better in a separate file
Test Plan: Flow
Reviewers: karol-bisztyga, palys-swm
Reviewed By: karol-bisztyga, palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1114 |
129,191 | 11.05.2021 12:54:44 | -7,200 | fca5b21b9a1e03ca43898c71b012ca392662c23f | [lib] Delete useRealThreadCreator hook
Summary: Here and in D1139 the last usages were removed so we can delete the hook completely
Test Plan: Flow, tested with other diffs
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -10,7 +10,7 @@ import {\nfetchMostRecentMessagesActionTypes,\nfetchMostRecentMessages,\n} from '../actions/message-actions';\n-import { newThread, newThreadActionTypes } from '.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Delete useRealThreadCreator hook
Summary: Here and in D1139 the last usages were removed so we can delete the hook completely
Test Plan: Flow, tested with other diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1140 |
129,191 | 11.05.2021 15:17:39 | -7,200 | 8715d2e89c87c0240a01902cd0628c5f57d6675f | [native] Replace OptimisticThreadInfo with ThreadInfo in camera modal
Summary: The same as in D1143, we can replace `OptimisticThreadInfo`
Test Plan: Create realized thread by sending an image using camera modal
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -652,10 +652,7 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nname: CameraModalRouteName,\nparams: {\npresentedFrom: this.props.route.key,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Replace OptimisticThreadInfo with ThreadInfo in camera modal
Summary: The same as in D1143, we can replace `OptimisticThreadInfo`
Test Plan: Create realized thread by sending an image using camera modal
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://... |
129,191 | 11.05.2021 15:27:16 | -7,200 | ec1bdf54a4e7dab77100508cedc1744b68630b09 | [native] Replace OptimisticThreadInfo with ThreadInfo in image paste modal
Summary: As in D1143 and D1144
Test Plan: Send image using copy and paste to a pending thread
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -815,14 +815,11 @@ export default React.memo<BaseProps>(function ConnectedChatInputBar(\nname: ImagePasteModalRouteName,\nparams: {\nimagePasteStagingInfo: pas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Replace OptimisticThreadInfo with ThreadInfo in image paste modal
Summary: As in D1143 and D1144
Test Plan: Send image using copy and paste to a pending thread
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1145 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.