author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,191 | 11.05.2021 15:28:23 | -7,200 | 84056cf9e5f7f482e21743ad64212e06cf3bcb70 | [native] Delete OptimisticThreadInfo
Summary: D1143, D1144 and D1145 removed all the usages of `OptimisticThreadInfo`, so we can safely delete it
Test Plan: Flow, tested with other diffs
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -166,11 +166,6 @@ export type ThreadInfo = {|\nrepliesCount: number,\n|};\n-export type OptimisticThreadInfo = {|\n- +threadInfo: ThreadInfo,\n- +sourceMessageID?: string,\n-|};\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delete OptimisticThreadInfo
Summary: D1143, D1144 and D1145 removed all the usages of `OptimisticThreadInfo`, so we can safely delete it
Test Plan: Flow, tested with other diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1... |
129,191 | 12.05.2021 15:22:01 | -7,200 | 1a67e2fb37670d6069abed0aa214a79cc805694a | [lib] Remove sourceMessageID parameter from useMessageListData hook
Summary: Use `sourceMessageID` property of `threadInfo`
Test Plan: The same as in D1149
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -400,19 +400,18 @@ const messageListData: (\n);\ntype UseMessageListDataArgs = {|\n- +sourceMessageID: ?string,\n+searching: boolean,\n+userInfoInputArray: $ReadOnlyAr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Remove sourceMessageID parameter from useMessageListData hook
Summary: Use `sourceMessageID` property of `threadInfo`
Test Plan: The same as in D1149
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1150 |
129,191 | 12.05.2021 15:25:16 | -7,200 | 40af7b067a4ffa78558d8d27f62cc5bef24fee5d | [native] Delete sourceMessageID nav param from message list
Summary: In D1149 and D1150 we removed the usages of this param so now it can be deleted
Test Plan: Tested with other diffs
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-types.js",
"new_path": "native/chat/message-list-types.js",
"diff": "@@ -10,7 +10,6 @@ import { useTextMessageRulesFunc } from '../markdown/rules.react';\nexport type MessageListParams = {|\n+threadInfo: ThreadInfo,\n- +sourceMessageID... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delete sourceMessageID nav param from message list
Summary: In D1149 and D1150 we removed the usages of this param so now it can be deleted
Test Plan: Tested with other diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1151 |
129,191 | 12.05.2021 15:27:51 | -7,200 | 542a74a629678152246e563a5e61cd60ceaf52f9 | [web] Delete sourceMessageID from NavInfo
Summary: In D1149 and D1150 all the usages were removed
Test Plan: Tested with other diffs
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/selectors/nav-selectors.js",
"new_path": "web/selectors/nav-selectors.js",
"diff": "@@ -171,7 +171,6 @@ function useOnClickPendingSidebar(\npayload: {\nactiveChatThreadID: pendingSidebarInfo.id,\npendingThread: pendingSidebarInfo,\n- sourceMessageID: messa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Delete sourceMessageID from NavInfo
Summary: In D1149 and D1150 all the usages were removed
Test Plan: Tested with other diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1152 |
129,184 | 13.05.2021 16:20:40 | 14,400 | 73b2dc0e743838fcd6a6d24f8cf5ae4e28147e79 | [native] memoize some `reanimated` nodes in `video-playback-modal`
Summary: memoized some of the `reanimated` nodes in `video-playback-modal` using `React.useMemo()`
Test Plan: The zoom in/out animation continues to work as it did previously. Tested on iOS simulator.
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adr... | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "@@ -172,18 +172,38 @@ function VideoPlaybackModal(props: Props) {\nimageHeight,\n]);\n- const left = sub(centerX, divide(imageWidth, 2));\n- const t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] memoize some `reanimated` nodes in `video-playback-modal`
Summary: memoized some of the `reanimated` nodes in `video-playback-modal` using `React.useMemo()`
Test Plan: The zoom in/out animation continues to work as it did previously. Tested on iOS simulator.
Reviewers: ashoat
Reviewed By: ashoat
Subscribe... |
129,183 | 12.05.2021 15:06:32 | -7,200 | cd8fb8c59d1aca4184c6d0678f96be0ca6675002 | [native] Rename more.react to profile.react
Summary: Next step in renaming more tab to profile, rename file and update imports
Test Plan: Flow, make sure more tab works
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -19,7 +19,7 @@ import KeyboardStateContainer from '../keyboard/keyboard-state-container.react';\nimport CameraModal from '../media/camera-modal.react... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename more.react to profile.react
Summary: Next step in renaming more tab to profile, rename file and update imports
Test Plan: Flow, make sure more tab works
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricat... |
129,183 | 12.05.2021 15:08:05 | -7,200 | fe650b8bab5acb57dcbca1a4c6bc71cc4b9281e2 | [native] Rename more-screen.react to profile-screen
Summary: Next step in renaming more tab to profile, rename file and update imports
Test Plan: Flow, make sure more tab still works
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "RENAME",
"old_path": "native/profile/more-screen.react.js",
"new_path": "native/profile/profile-screen.react.js",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "native/profile/profile.react.js",
"new_path": "native/profile/profile.react.js",
"diff": "@@ -... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename more-screen.react to profile-screen
Summary: Next step in renaming more tab to profile, rename file and update imports
Test Plan: Flow, make sure more tab still works
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: htt... |
129,183 | 12.05.2021 15:09:20 | -7,200 | 37f42bb01992ecf4e089c87a67b894b3a4237830 | [native] Rename more-header.react to profile-header.react
Summary: Next step in renaming more tab to profile, rename file and update imports
Test Plan: Flow, make sure more tab still works
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "RENAME",
"old_path": "native/profile/more-header.react.js",
"new_path": "native/profile/profile-header.react.js",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "native/profile/profile.react.js",
"new_path": "native/profile/profile.react.js",
"diff": "@@ -... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename more-header.react to profile-header.react
Summary: Next step in renaming more tab to profile, rename file and update imports
Test Plan: Flow, make sure more tab still works
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revisio... |
129,184 | 15.05.2021 19:16:58 | 14,400 | 8d851852ffb0f6c25ac0af5d397d1e5f1774a100 | [native] Disable `video-playback-modal` controls when opacity is 0
Summary: Disable the `video-playback-modal` controls when the opacity is at 0.
Test Plan: Behaves as expected when tested on iOS Simulator. Also logged state/Animated values to confirm they were as expected.
Reviewers: ashoat
Subscribers: KatPo, palys-s... | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "@@ -32,7 +32,12 @@ import { formatDuration } from './video-utils';\n/* eslint-disable import/no-named-as-default-member */\nconst {\nExtrapolate,\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Disable `video-playback-modal` controls when opacity is 0
Summary: Disable the `video-playback-modal` controls when the opacity is at 0.
Test Plan: Behaves as expected when tested on iOS Simulator. Also logged state/Animated values to confirm they were as expected.
Reviewers: ashoat
Reviewed By: ashoat
Su... |
129,187 | 17.05.2021 11:31:08 | 14,400 | 75765781f0525a54cbd8e2dff42a1d989558fb72 | [native] Add displayName to Search
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/search.react.js",
"new_path": "native/components/search.react.js",
"diff": "@@ -23,7 +23,7 @@ type Props = {|\n+containerStyle?: ViewStyle,\n+active?: boolean,\n|};\n-const Search = React.forwardRef<Props, typeof TextInput>(\n+\nfunction Forw... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add displayName to Search
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1166 |
129,187 | 17.05.2021 11:49:01 | 14,400 | 014383f649ff464cb488fb8f0fe6443c5a3ede43 | [native] Make GestureTouchableOpacity forward its TapGestureHandler ref
Test Plan: Will test in combo with diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, atul, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/gesture-touchable-opacity.react.js",
"new_path": "native/components/gesture-touchable-opacity.react.js",
"diff": "@@ -55,7 +55,10 @@ type Props = {|\n+overlay?: React.Node,\n+disabled?: boolean,\n|};\n-function GestureTouchableOpacity(props: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make GestureTouchableOpacity forward its TapGestureHandler ref
Test Plan: Will test in combo with @atul's diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, atul, Adrian
Differential Revision: https://phabricator.ashoat.com/D1167 |
129,184 | 17.05.2021 14:34:47 | 14,400 | 10dcf74924df66a05a74a2f0566b8d05fd9dbeda | [native] Avoid unnecessary Animated.Value instantiations in useReanimatedValueForBoolean
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/utils/animation-utils.js",
"new_path": "native/utils/animation-utils.js",
"diff": "@@ -198,9 +198,12 @@ function ratchetAlongWithKeyboardHeight(\n}\nfunction useReanimatedValueForBoolean(booleanValue: boolean): Value {\n- const reanimatedValueRef = Reac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid unnecessary Animated.Value instantiations in useReanimatedValueForBoolean
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1170 |
129,184 | 17.05.2021 14:35:50 | 14,400 | 5d3ab0e8938d9c9059cdf78ba6a705dc451f4c38 | [native] Add maxDist to GestureHandlers in GestureTouchableOpacity
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/gesture-touchable-opacity.react.js",
"new_path": "native/components/gesture-touchable-opacity.react.js",
"diff": "@@ -210,6 +210,7 @@ function ForwardedGestureTouchableOpacity(\n<TapGestureHandler\nonHandlerStateChange={tapEvent}\nmaxDuration... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add maxDist to GestureHandlers in GestureTouchableOpacity
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1171 |
129,184 | 17.05.2021 14:39:06 | 14,400 | cecdc190b916780dcd3802d76ac153c4bd380e09 | [native] Decrease VideoPlaybackModal controls opacity during dismissal
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "@@ -87,7 +87,7 @@ function VideoPlaybackModal(props: Props) {\n);\nconst controlsShowing = useValue(1);\n- const controlsOpacity = React.useMemo(\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Decrease VideoPlaybackModal controls opacity during dismissal
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1172 |
129,184 | 17.05.2021 14:46:15 | 14,400 | 6074904657a2ef46b05278a7cee894514552e4f7 | [native] Refactor buttons/gestures in VideoPlaybackModal
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "import invariant from 'invariant';\nimport * as React from 'react';\nimport { useState } from 'react';\n-import { View, Text } from 'react-native';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Refactor buttons/gestures in VideoPlaybackModal
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1173 |
129,184 | 17.05.2021 17:35:12 | 14,400 | 210f631067eca7b028b3d577c79f9721731e391b | [native] Introduce `outsideButtons` to `video-playback-modal`
Test Plan: na
Reviewers: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-playback-modal.react.js",
"new_path": "native/media/video-playback-modal.react.js",
"diff": "@@ -22,13 +22,20 @@ import { useSelector } from '../redux/redux-utils';\nimport { derivedDimensionsInfoSelector } from '../selectors/dimensions-sele... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `outsideButtons` to `video-playback-modal`
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1174 |
129,187 | 17.05.2021 22:31:04 | 14,400 | 072f6c4dda49d46efaefc377477a9171a5eb12e9 | [native] Move iOS fonts into Resources folder
Test Plan: Compile and run iOS app
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "RENAME",
"old_path": "native/ios/Anaheim-Regular.ttf",
"new_path": "native/ios/Resources/Anaheim-Regular.ttf",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "native/ios/OpenSans-Regular.ttf",
"new_path": "native/ios/Resources/OpenSans-Regular.ttf",
"diff"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move iOS fonts into Resources folder
Test Plan: Compile and run iOS app
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1175 |
129,187 | 17.05.2021 22:52:38 | 14,400 | 0ad72889e819e7961c952e8330a40be44958207b | [native] Add IBM Plex Sans font
Test Plan: Tested in combination with following diff
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": "native/android/app/src/main/assets/fonts/IBMPlexSans-Bold.ttf",
"new_path": "native/android/app/src/main/assets/fonts/IBMPlexSans-Bold.ttf",
"diff": "Binary files /dev/null and b/native/android/app/src/main/assets/fonts/IBMPlexSans-Bold.ttf differ\n"
},
{
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add IBM Plex Sans font
Test Plan: Tested in combination with following diff
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1176 |
129,184 | 18.05.2021 13:26:18 | 14,400 | 556fa4f20418c52c49f33bab0944b7b7ca598619 | [native] set default `activeTheme` and `preference` to `dark`
Test Plan: Created some new accounts and the active theme/preference in profile tab were as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/types/themes.js",
"new_path": "native/types/themes.js",
"diff": "@@ -16,7 +16,9 @@ export const osCanTheme =\n(Platform.OS === 'android' && Platform.Version >= 29);\nexport const defaultGlobalThemeInfo = {\n- activeTheme: osCanTheme ? null : 'light',\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] set default `activeTheme` and `preference` to `dark`
Test Plan: Created some new accounts and the active theme/preference in profile tab were as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1178 |
129,184 | 18.05.2021 13:40:00 | 14,400 | 2f74e5a5b27cd5e7a4c508446e7f69ad7b11420d | [native] conditionally display appearance preferences in profile tab if `__DEV__`
Test Plan: Preferences appear when built for dev, and don't appear when built for release
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/profile/profile-screen.react.js",
"new_path": "native/profile/profile-screen.react.js",
"diff": "@@ -153,6 +153,24 @@ class ProfileScreen extends React.PureComponent<Props> {\npanelIosHighlightUnderlay: underlay,\nlink: linkColor,\n} = this.props.colors... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] conditionally display appearance preferences in profile tab if `__DEV__`
Test Plan: Preferences appear when built for dev, and don't appear when built for release
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1179 |
129,184 | 18.05.2021 13:50:06 | 14,400 | c6348764a0b02a4065b5b3b97b022050999416e1 | [native] migrate light mode users to dark mode for soft launch
Test Plan: created an account, set to light mode, was migrated to dark mode
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -209,6 +209,10 @@ const migrations = {\ndrafts: undefined,\n};\n},\n+ [23]: (state) => ({\n+ ...state,\n+ globalThemeInfo: defaultGlobalThemeInfo,\n+ }),\n};\nconst persistConfig = {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] migrate light mode users to dark mode for soft launch
Test Plan: created an account, set to light mode, was migrated to dark mode
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1180 |
129,187 | 18.05.2021 14:20:28 | 14,400 | 1041ccc9a92b0d7fbc8d2f93c2f27ba73db2b55c | [native]
Summary: Noticed this package was pretty outdated while I was working on some related code and decided to update it.
Test Plan: Make sure credentials still persist on iOS and Android
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/native-credentials.js",
"new_path": "native/account/native-credentials.js",
"diff": "@@ -7,9 +7,13 @@ import {\nsetInternetCredentials,\nsetSharedWebCredentials,\nresetInternetCredentials,\n- type UserCredentials,\n} from 'react-native-keychain'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] react-native-keychain@7.0.0
Summary: Noticed this package was pretty outdated while I was working on some related code and decided to update it.
Test Plan: Make sure credentials still persist on iOS and Android
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision:... |
129,187 | 19.05.2021 12:11:28 | 14,400 | 05dc29abd3833a8d8089579fede15c19310e526a | [native] Avoid state.state in LogInPanel / RegisterPanel
Summary: Addressing feedback from D1183.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel-container.react.js",
"new_path": "native/account/log-in-panel-container.react.js",
"diff": "@@ -116,7 +116,7 @@ class BaseLogInPanelContainer extends React.PureComponent<Props, State> {\nsetActiveAlert={this.props.setActiveAlert}\no... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid state.state in LogInPanel / RegisterPanel
Summary: Addressing @atul's feedback from D1183.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1189 |
129,184 | 19.05.2021 11:32:41 | 14,400 | ca9583412602e5a4e9277bb597c11c9e0566bb4b | [native] add `Apps` to tab bar and create `apps-directory` placeholder
Test Plan: Apps tab appeared as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/apps/apps-directory.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { View, Text } from 'react-native';\n+\n+import { useStyles } from '../themes/colors';\n+\n+function AppsDirectory() {\n+ const styles = useSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] add `Apps` to tab bar and create `apps-directory` placeholder
Test Plan: Apps tab appeared as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1191 |
129,184 | 19.05.2021 15:12:17 | 14,400 | 696e083fd17129145123df0554a873fe8668a225 | [native] `app-directory` and `app-listing` layout
Summary: Here's what it looks like:
Test Plan: layout/views appeared as expected on iOS simulator
Reviewers: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/apps/app-listing.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { View, Text, TouchableOpacity } from 'react-native';\n+import Icon from 'react-native-vector-icons/FontAwesome';\n+\n+import { useStyles } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `app-directory` and `app-listing` layout
Summary: Here's what it looks like: https://blob.sh/atul/app-directory.png
Test Plan: layout/views appeared as expected on iOS simulator
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.... |
129,187 | 19.05.2021 17:36:44 | 14,400 | 2eeb5bbe14a6f1d2aea41aea7f45dc0598024b6a | [native] Rename Android packages/folders from SquadCal to Comm
Summary: This doesn't handle renaming the app, changing the app icon, changing the `rootProject.name` in Gradle, or changing the "applicationId" (`org.squadcal`).
Test Plan: Make sure the app compiles
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/cpp/jsiInstaller.cpp",
"new_path": "native/android/app/src/cpp/jsiInstaller.cpp",
"diff": "@@ -11,7 +11,7 @@ namespace react = facebook::react;\nclass CommHybrid : public jni::HybridClass<CommHybrid> {\npublic:\n- static auto constexpr k... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename Android packages/folders from SquadCal to Comm
Summary: This doesn't handle renaming the app, changing the app icon, changing the `rootProject.name` in Gradle, or changing the "applicationId" (`org.squadcal`).
Test Plan: Make sure the app compiles
Reviewers: atul
Reviewed By: atul
Subscribers: KatP... |
129,187 | 19.05.2021 17:42:14 | 14,400 | aeaf4a5dfcbbbec4d3e7e8e5305d3cf6b7a62f3c | [native] Change main component name from SquadCal to Comm
Test Plan: Make sure the app compiles and runs on iOS and Android
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/java/app/comm/MainActivity.java",
"new_path": "native/android/app/src/main/java/app/comm/MainActivity.java",
"diff": "@@ -24,7 +24,7 @@ public class MainActivity extends ReactFragmentActivity {\n*/\n@Override\nprotected String getMa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Change main component name from SquadCal to Comm
Test Plan: Make sure the app compiles and runs on iOS and Android
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1195 |
129,187 | 19.05.2021 18:56:26 | 14,400 | 7e35fcafca205539fe8f11c62db7a0c22ba3e2e6 | [lib] Delete unused threadIsPersonalAndPending function
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -201,12 +201,6 @@ function threadIsPending(threadID: ?string) {\nreturn threadID?.startsWith('pending');\n}\n-function threadIsPersonalAndPending(threadInfo: ?(ThreadInfo | RawT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Delete unused threadIsPersonalAndPending function
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1198 |
129,187 | 19.05.2021 22:59:00 | 14,400 | bd0c8e504d1e5ed03174cb2863a33299e02b0c18 | [server] Deprecate botherMonthlyActivesToUpdateAppVersion
Summary: We don't need to do this once we're on the app store.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "DELETE",
"old_path": "server/src/bots/app-version-update.js",
"new_path": null,
"diff": "-// @flow\n-\n-import invariant from 'invariant';\n-\n-import bots from 'lib/facts/bots';\n-import { messageTypes } from 'lib/types/message-types';\n-import { promiseAll } from 'lib/utils/promi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Deprecate botherMonthlyActivesToUpdateAppVersion
Summary: We don't need to do this once we're on the app store.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1202 |
129,187 | 19.05.2021 23:30:02 | 14,400 | ff1716ff2a7c721d636dc1bbab9962c5499d480a | [native] Remove threadPermissions.CREATE_SUBTHREADS from threadTypes.PERSONAL
Summary: `PERSONAL` is going to be a "thick" thread long-term, and as such won't support subthreads.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/role-creator.js",
"new_path": "server/src/creators/role-creator.js",
"diff": "@@ -192,7 +192,6 @@ function getRolePermissionBlobsForChat(\n[threadPermissions.VOICED]: true,\n[threadPermissions.EDIT_ENTRIES]: true,\n[threadPermissions.EDIT_T... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove threadPermissions.CREATE_SUBTHREADS from threadTypes.PERSONAL
Summary: `PERSONAL` is going to be a "thick" thread long-term, and as such won't support subthreads.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
D... |
129,184 | 20.05.2021 11:26:03 | 14,400 | 551e229b5eaf3986a5318cc2d16e48a53f7dbd90 | [lib][web][native] add `enabledApps` to redux
Test Plan: Verified with redux devtools
Reviewers: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/reducers/enabled-apps-reducer.js",
"diff": "+// @flow\n+\n+import type { EnabledApps } from '../types/enabled-apps';\n+import type { BaseAction } from '../types/redux-types';\n+\n+export const enableAppActionType = 'ENABLE_APP';\n+export con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib][web][native] add `enabledApps` to redux
Test Plan: Verified with redux devtools
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1209 |
129,187 | 20.05.2021 17:14:33 | 14,400 | b4a1ee565b01d9377331f4c5c93fb03b2c18aaa3 | [server] Introduce validateCandidateMembers
Summary: This function unifies member validation across `create_thread` and `update_thread`, and uses our new `MEMBERSHIP` permission to do the validation.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "import invariant from 'invariant';\nimport bots from 'lib/facts/bots';\n-import { relationshipBlockedInEitherDirection } from 'lib/shared/relationship-utils';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introduce validateCandidateMembers
Summary: This function unifies member validation across `create_thread` and `update_thread`, and uses our new `MEMBERSHIP` permission to do the validation.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo,... |
129,187 | 20.05.2021 23:22:01 | 14,400 | 8fb1b155bc52691fb19c7e4320e0670d3ed28e77 | [lib] Simplify rolePermissions merge condition in makePermissionsBlob
Summary: These conditions are logically equivalent.
Test Plan: Careful visual inspection
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/permissions/thread-permissions.js",
"new_path": "lib/permissions/thread-permissions.js",
"diff": "@@ -80,10 +80,7 @@ function makePermissionsBlob(\nfor (const permissionKey in rolePermissions) {\nconst permissionValue = rolePermissions[permissionKey];\ncon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Simplify rolePermissions merge condition in makePermissionsBlob
Summary: These conditions are logically equivalent.
Test Plan: Careful visual inspection
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1215 |
129,187 | 21.05.2021 15:23:37 | 14,400 | 508039a0ddb05a302798730d9947134ee79a18f9 | [native] Use font-weight 500 ("Medium") for wordmark
Test Plan: Visual inspection
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/res/drawable-hdpi/header.png",
"new_path": "native/android/app/src/main/res/drawable-hdpi/header.png",
"diff": "Binary files a/native/android/app/src/main/res/drawable-hdpi/header.png and b/native/android/app/src/main/res/drawable-h... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use font-weight 500 ("Medium") for wordmark
Test Plan: Visual inspection
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1220 |
129,187 | 21.05.2021 15:24:04 | 14,400 | daff6f95e430bb6922dc2ca61c958324904cbb5f | [landing] Use font-weight 500 ("Medium") for wordmark
Test Plan: Visual inspection
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -10,7 +10,7 @@ html {\nh1,\nh2 {\nfont-family: 'IBM Plex Mono', monospace;\n- font-weight: 600;\n+ font-weight: 500;\n}\nh1.title {\n@@ -107,7 +107,7 @@ div.footer_logo {\nfont-size: 24px;\ng... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Use font-weight 500 ("Medium") for wordmark
Test Plan: Visual inspection
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1221 |
129,187 | 21.05.2021 16:23:20 | 14,400 | f299c0862b7f19c2b50047f5105824a87ecded7a | [landing] Capitalize Internet
Test Plan: Visual inspection
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -87,7 +87,7 @@ function Landing(): React.Node {\n<span className={css.purple}> digital identity.</span>\n</h1>\n<p>\n- The internet is broken today. Private user data is owned ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Capitalize Internet
Test Plan: Visual inspection
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1222 |
129,187 | 21.05.2021 16:58:11 | 14,400 | 9a2ed32d77fb78502f3ce0d8a4bbbe7df3feabe9 | Introduce threadTypes.COMMUNITY_ROOT
Summary: Necessary for the soft launch since we're putting everything inside a community named "GENESIS"
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -24,6 +24,8 @@ export const threadTypes = Object.freeze({\nPERSONAL: 6,\n// canonical thread for each single user\nPRIVATE: 7,\n+ // aka \"org\". no parent, top-level, has admin\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce threadTypes.COMMUNITY_ROOT
Summary: Necessary for the soft launch since we're putting everything inside a community named "GENESIS"
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabric... |
129,187 | 24.05.2021 19:58:42 | 14,400 | 55dca642a6aa4a3264cf65143669fe10a417a51f | [server] Prevent users from turning threads into COMMUNITY_ROOTs
Summary: I also switched from a denylist to an allowlist. The intention was to change the default behavior for new thread types.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -339,9 +339,8 @@ async function updateThread(\nif (\n!viewer.isScriptViewer &&\n- (threadType === threadTypes.PERSONAL ||\n- threadType === threadTypes.P... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Prevent users from turning threads into COMMUNITY_ROOTs
Summary: I also switched from a denylist to an allowlist. The intention was to change the default behavior for new thread types.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys... |
129,187 | 24.05.2021 20:01:23 | 14,400 | d2e2462d981a227cdf8cd4b5c64ff9f2676c4558 | [server] Disable EDIT_PERMISSIONS for admins of COMMUNITY_ROOTs
Summary: Not even admins should be able to change the parent thread or thread type of a `COMMUNITY_ROOT`.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/role-creator.js",
"new_path": "server/src/creators/role-creator.js",
"diff": "@@ -134,7 +134,6 @@ function getRolePermissionBlobsForCommunity(): RolePermissionBlobs {\n[threadPermissions.CREATE_SIDEBARS]: true,\n[threadPermissions.ADD_MEMBE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Disable EDIT_PERMISSIONS for admins of COMMUNITY_ROOTs
Summary: Not even admins should be able to change the parent thread or thread type of a `COMMUNITY_ROOT`.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differenti... |
129,187 | 24.05.2021 20:28:29 | 14,400 | 185f673698f46c6440cd91fb9cad14c8c4b96f79 | [server] Prevent changing thread parents
Summary: See code comment. [This Notion task](https://www.notion.so/commapp/Add-community-column-to-threads-table-a8c542df0e7745fa8fc615cd52924882) tracks reverting this change.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, pal... | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -337,6 +337,15 @@ async function updateThread(\nsqlUpdate.type = threadType;\n}\n+ // We're temporarily blocking changing parent thread IDs. Note that ev... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Prevent changing thread parents
Summary: See code comment. [This Notion task](https://www.notion.so/commapp/Add-community-column-to-threads-table-a8c542df0e7745fa8fc615cd52924882) tracks reverting this change.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
... |
129,190 | 25.05.2021 07:47:05 | -7,200 | b116da6efd1251fdfe195e6dc72ab815f3a8079c | [native] Fix core module shim
Summary: Fix core module shim so now it implements the interface from `CommCoreModuleSchema`
Test Plan: try to modify methods of `SpecImpl` and see flow errors
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/data/core-module-shim.js",
"new_path": "native/data/core-module-shim.js",
"diff": "// @flow\n+import { type Spec } from '../schema/CommCoreModuleSchema';\n+\nif (!global.CommCoreModule) {\nconsole.warn(\n'Comm Core Module has not been attached! ' +\n'So... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix core module shim
Summary: Fix core module shim so now it implements the interface from `CommCoreModuleSchema`
Test Plan: try to modify methods of `SpecImpl` and see flow errors
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: ... |
129,184 | 24.05.2021 09:27:20 | 14,400 | 6f8cb3e46ea564879f88f43abc13d247138f5c94 | [ios] change display name to Comm
Summary: change display name to 'Comm'
Test Plan: looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundleDevelopmentRegion</key>\n<string>en</string>\n<key>CFBundleDisplayName</key>\n- <string>SquadCal</string>\n+ <string>Comm</string>\n<key>CFBundleExecutable... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [ios] change display name to Comm
Summary: change display name to 'Comm'
Test Plan: looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1238 |
129,184 | 25.05.2021 13:37:17 | 14,400 | 2d37da5baa5347338d8136370312e6eb795f4926 | [ios] replace splash screen for soft launch
Summary:
Replace splash screen with background that uses same radial gradient as landing page
Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Images.xcassets/SplashBackground.imageset/Contents.json",
"new_path": "native/ios/Comm/Images.xcassets/SplashBackground.imageset/Contents.json",
"diff": "{\n\"images\" : [\n{\n- \"idiom\" : \"universal\",\n\"filename\" : \"SplashBackground.png\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [ios] replace splash screen for soft launch
Summary:
Replace splash screen with background that uses same radial gradient as landing page
Here's what it looks like: https://blob.sh/atul/splash.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differentia... |
129,187 | 25.05.2021 15:40:20 | 14,400 | 2e92bdf306d60361469ae629a110289a2272e6cf | [server] Don't throw in updateThread if threadType isn't specified
Summary: I made a mistake in D1232. We should make sure we don't throw if `threadType` isn't specified.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -348,6 +348,8 @@ async function updateThread(\nif (\n!viewer.isScriptViewer &&\n+ threadType !== null &&\n+ threadType !== undefined &&\nthreadType !== t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't throw in updateThread if threadType isn't specified
Summary: I made a mistake in D1232. We should make sure we don't throw if `threadType` isn't specified.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Different... |
129,187 | 25.05.2021 17:54:43 | 14,400 | ee79883ee5de1a42f7fc2ceac2deafd266a8bd23 | [server] Reduce indentation for confirmParentPermissionPromise in updateThread
Summary: Separating this from the following diff to make it easier to review.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -462,12 +462,16 @@ async function updateThread(\n}\nconst confirmParentPermissionPromise = (async () => {\n+ if (!nextParentThreadID) {\n+ return;\n+ }\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Reduce indentation for confirmParentPermissionPromise in updateThread
Summary: Separating this from the following diff to make it easier to review.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: ... |
129,187 | 25.05.2021 15:42:46 | 14,400 | 09e1c1b14b852747847458b9cf8eb894fe95c536 | [server] Add ignorePermissions to UpdateThreadOptions
Summary: This is necessary to allow us to call `updateThread` in the context of the soft launch migration script.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -294,6 +294,7 @@ type UpdateThreadOptions = Shape<{|\n+forceAddMembers: boolean,\n+forceUpdateRoot: boolean,\n+silenceMessages: boolean,\n+ +ignorePermis... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add ignorePermissions to UpdateThreadOptions
Summary: This is necessary to allow us to call `updateThread` in the context of the soft launch migration script.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential... |
129,187 | 26.05.2021 00:58:04 | 14,400 | effa74832dd4ad5e0efe5937b359d33a52bb2dfe | [native] Add turbomodulejsijni to targets list for Android build
Summary: Android crashes on startup without this
Test Plan: Build Android
Reviewers: karol-bisztyga, atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -306,7 +306,7 @@ android {\nexternalNativeBuild {\ncmake {\narguments \"-DANDROID_STL=c++_shared\"\n- targets \"comm_jni_module\"\n+ targets \"comm_jni_module\", \"tur... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add turbomodulejsijni to targets list for Android build
Summary: Android crashes on startup without this
Test Plan: Build Android
Reviewers: karol-bisztyga, atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1249 |
129,187 | 26.05.2021 03:09:34 | 14,400 | 191cb97585f041f124c6be0ac0530f4cb9eb7532 | [server] Batch memberships table INSERTS and push notifs rescinds in thread-permission-updaters.js
Summary: These were causing MySQL timeouts when they were allowed all at the same time (~150,000 simultaneous queries).
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, pal... | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -531,6 +531,8 @@ const defaultSubscriptionString = JSON.stringify({\n});\nconst joinSubscriptionString = JSON.stringify({ home: tru... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Batch memberships table INSERTS and push notifs rescinds in thread-permission-updaters.js
Summary: These were causing MySQL timeouts when they were allowed all at the same time (~150,000 simultaneous queries).
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
... |
129,184 | 26.05.2021 15:34:22 | 14,400 | 5e5f302c83e46526f90a938d72360775f03a706e | [android] replace launcher icon for soft launch
Test Plan: looks as expected on android emulator
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/android/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml",
"diff": "+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<adaptive-icon xmlns:android=\"http://schemas.android.com/apk/res/android\">\n+ <background android:drawable=\"@color/ic_l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [android] replace launcher icon for soft launch
Test Plan: looks as expected on android emulator
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1257 |
129,184 | 25.05.2021 21:33:04 | 14,400 | c0d3abf65c1dd6585e2b76b61a1b1ef11fb5885b | [native] Add IBM Plex Sans Medium font
Summary: Added medium weight of IBM Plex Sans. Modified `logged-out-modal` to keep consistent with wordmark + splash screen.
Test Plan: Appears as expected on iOS simulator
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -763,8 +763,8 @@ const styles = StyleSheet.create({\ncolor: 'white',\nfontFamily: 'IBMPlexSans',\nfontSize: 56,\n- fontWeight: 'bold',\n- lineHeight:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add IBM Plex Sans Medium font
Summary: Added medium weight of IBM Plex Sans. Modified `logged-out-modal` to keep consistent with wordmark + splash screen.
Test Plan: Appears as expected on iOS simulator
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: htt... |
129,184 | 26.05.2021 20:08:40 | 14,400 | 566885a7304640f525e0ac517f4edc5eca61eb0c | [landing] Center landing page
Summary: Diff addresses issue from
Test Plan: Looks as expected on 28in display
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -4,7 +4,6 @@ html {\nfont-family: 'IBM Plex Sans', sans-serif;\ncolor: white;\nword-break: break-word;\n- max-width: 1920px;\n}\nh1,\n@@ -37,6 +36,9 @@ p {\n}\ndiv.grid {\n+ max-width: 1920px... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Center landing page
Summary: Diff addresses issue from https://www.notion.so/commapp/Landing-page-doesn-t-look-great-on-ultrawide-displays-dcdb7854d1f748cf9bd132e7c2c0e113
Test Plan: Looks as expected on 28in display
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differentia... |
129,187 | 27.05.2021 10:06:44 | 14,400 | e61161c1a22b3738a2d544c98c97a2e37f9d58a4 | [lib] Fix boolean logic in includeThreadPermissionForThreadType
Summary:
I made a pretty dumb mistake in D1200...
This diff should actually resolve [this Notion issue](https://www.notion.so/Cannot-post-in-a-new-thread-3f7f095994e74c74bd37fda8db6d0b67).
Test Plan: Make sure it's possible to create a sidebar from a messa... | [
{
"change_type": "MODIFY",
"old_path": "lib/permissions/prefixes.js",
"new_path": "lib/permissions/prefixes.js",
"diff": "@@ -53,8 +53,8 @@ function includeThreadPermissionForThreadType(\nthreadType: ThreadType,\n): boolean {\nif (\n- (threadType !== threadTypes.COMMUNITY_OPEN_SUBTHREAD ||\n- thread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix boolean logic in includeThreadPermissionForThreadType
Summary:
I made a pretty dumb mistake in D1200...
This diff should actually resolve [this Notion issue](https://www.notion.so/Cannot-post-in-a-new-thread-3f7f095994e74c74bd37fda8db6d0b67).
Test Plan: Make sure it's possible to create a sidebar from a me... |
129,184 | 27.05.2021 11:22:48 | 14,400 | 3acf5b3ffec71e3522ce7de6b7de897b1c0c9a82 | [lib] Don't show parent admin in `robotextName`
Test Plan: `robotextName` changes as expected following this change
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -543,11 +543,7 @@ function robotextName(\nuserInfos: UserInfos,\n): string {\nconst threadUsernames: string[] = threadInfo.members\n- .filter(\n- (threadMember) =>\n- threadMemb... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Don't show parent admin in `robotextName`
Test Plan: `robotextName` changes as expected following this change
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1268 |
129,187 | 27.05.2021 12:43:27 | 14,400 | 94a1bf222c4900a9db4830b1dc96b6f854114d52 | [lib] Remove unknown from LifecycleState
Summary: It's confusing for this to be included in `LifecycleState`, which is the type of `redux.lifecycleState`. We never actually set `redux.lifecycleState` to `unknown`, so we shouldn't have the type include that value.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, paly... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/lifecycle-state-types.js",
"new_path": "lib/types/lifecycle-state-types.js",
"diff": "// @flow\n-export type LifecycleState = 'active' | 'inactive' | 'background' | 'unknown';\n+export type LifecycleState = 'active' | 'inactive' | 'background';\n"
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Remove unknown from LifecycleState
Summary: It's confusing for this to be included in `LifecycleState`, which is the type of `redux.lifecycleState`. We never actually set `redux.lifecycleState` to `unknown`, so we shouldn't have the type include that value.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
S... |
129,187 | 27.05.2021 14:28:58 | 14,400 | 8d1799811d9553f94f4ec6779ce8c8d8b7caf201 | [native] codeVersion -> 84 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -268,8 +268,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 84 |
129,184 | 27.05.2021 15:50:36 | 14,400 | 0cbdb485fa51d21a6df49a148c1622882a77a9d4 | [native] Restrict appearance preferences and dev tools to staff
Summary: Conditionally display appearance preferences/dev tools with `isStaff`
Test Plan: Added/removed test id from staff list and observed whether appearance preferences/dev tools appeared.
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/profile/profile-screen.react.js",
"new_path": "native/profile/profile-screen.react.js",
"diff": "@@ -20,6 +20,7 @@ import {\n} from 'lib/actions/user-actions';\nimport { preRequestUserStateSelector } from 'lib/selectors/account-selectors';\nimport { cre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restrict appearance preferences and dev tools to staff
Summary: Conditionally display appearance preferences/dev tools with `isStaff`
Test Plan: Added/removed test id from staff list and observed whether appearance preferences/dev tools appeared.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, p... |
129,187 | 27.05.2021 16:34:46 | 14,400 | 31ebfe12c58213bcb4758773bdfcc6ddd74af590 | [server] Flip final condition in getRolePermissionBlobs
Summary: Putting this in a separate diff to make review easier.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/role-creator.js",
"new_path": "server/src/creators/role-creator.js",
"diff": "@@ -235,10 +235,7 @@ function getRolePermissionBlobs(threadType: ThreadType): RolePermissionBlobs {\n};\n}\n- if (threadType === threadTypes.COMMUNITY_ROOT) {\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Flip final condition in getRolePermissionBlobs
Summary: Putting this in a separate diff to make review easier.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1279 |
129,187 | 27.05.2021 17:45:22 | 14,400 | 53ba155c630941151ffbbcedca9787e50cf1cdcb | [native] Clear thread search text when cancel button pressed
Test Plan: Make sure it clears
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -229,6 +229,11 @@ class ChatThreadList extends React.PureComponent<Props, State> {\nthis.setState({ searchStatus: 'inactive' });\n};\n+ onSearchCancel = ()... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Clear thread search text when cancel button pressed
Test Plan: Make sure it clears
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1282 |
129,187 | 27.05.2021 21:01:38 | 14,400 | 8d9b9c420d37add15fcc990e46c34f392120089a | [server] Convert second param of dbQuery to options blob
Summary: Going to add another parameter and I thought it would be cleaner this way.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/database/database.js",
"new_path": "server/src/database/database.js",
"diff": "@@ -76,7 +76,11 @@ function FakeSQLResult() {\nFakeSQLResult.prototype = Array.prototype;\nconst fakeResult: any = new FakeSQLResult();\n-async function dbQuery(statement... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Convert second param of dbQuery to options blob
Summary: Going to add another parameter and I thought it would be cleaner this way.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1285 |
129,187 | 27.05.2021 21:04:00 | 14,400 | d814c1d53f8f5e5b87cf99b8d5349f727c91cd38 | [server] Add multipleStatements support to dbQuery
Summary: I need this for an upcoming diff
Test Plan: Tested in combination with following diff
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/database/database.js",
"new_path": "server/src/database/database.js",
"diff": "@@ -78,10 +78,20 @@ const fakeResult: any = new FakeSQLResult();\ntype QueryOptions = {|\n+triesLeft?: number,\n+ +multipleStatements?: boolean,\n|};\nasync function dbQu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add multipleStatements support to dbQuery
Summary: I need this for an upcoming diff
Test Plan: Tested in combination with following diff
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1287 |
129,187 | 27.05.2021 21:13:23 | 14,400 | 4c71d9edeb5f626890f3bc9c890d89d1afeeacf1 | [server] Add all new users to Genesis in createAccount
Summary: This is necessary so that they have the right permissions
Test Plan: Make sure account registration no longer errors
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/account-creator.js",
"new_path": "server/src/creators/account-creator.js",
"diff": "@@ -5,6 +5,7 @@ import bcrypt from 'twin-bcrypt';\nimport ashoat from 'lib/facts/ashoat';\nimport bots from 'lib/facts/bots';\n+import genesis from 'lib/fac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add all new users to Genesis in createAccount
Summary: This is necessary so that they have the right permissions
Test Plan: Make sure account registration no longer errors
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1291 |
129,187 | 28.05.2021 12:17:03 | 14,400 | 349c2fb28a3fc7778b1cb05f3b71a071601b30d3 | [native] Use getSingleOtherUser in RelationshipPrompt
Summary: Best to have a single utility that we use everywhere. Identified this while investigating [this Notion issue](https://www.notion.so/commapp/Invalid-friend-request-123d5fe61edf42e39ad5e6563d99caee)
Test Plan: Flow, also tested in combination with the next di... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/relationship-prompt.react.js",
"new_path": "native/chat/relationship-prompt.react.js",
"diff": "@@ -9,6 +9,7 @@ import {\nupdateRelationships as serverUpdateRelationships,\nupdateRelationshipsActionTypes,\n} from 'lib/actions/relationship-actions';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use getSingleOtherUser in RelationshipPrompt
Summary: Best to have a single utility that we use everywhere. Identified this while investigating [this Notion issue](https://www.notion.so/commapp/Invalid-friend-request-123d5fe61edf42e39ad5e6563d99caee)
Test Plan: Flow, also tested in combination with the next ... |
129,187 | 28.05.2021 12:32:47 | 14,400 | 94dec1b7a2cc8ed725505688ff8ecc6d62e7775b | [native] codeVersion -> 85 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -268,8 +268,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 85 |
129,187 | 28.05.2021 12:30:15 | 14,400 | c1abdc054fc96dae84fc6c328cdef26fc9d4010f | [server] Further push back the launch of some features
Summary: Similar to D1276. Realized I'll need to make another release...
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -280,7 +280,7 @@ async function createThread(\nlet joinRequest = {\nthreadID: existingThreadID,\n};\n- if (hasMinCodeVersion(viewer.platformDetails, 85)) {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Further push back the launch of some features
Summary: Similar to D1276. Realized I'll need to make another release...
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1294 |
129,184 | 28.05.2021 14:28:57 | 14,400 | 9536d51461be0403acb8ec05cb0340781aaff060 | [native] OS-specific `fontFamily`
Test Plan: Did a clean build on iOS (Product > Clean Build Folder) and Android (https://www.notion.so/commapp/Android-debugging-stuff-9a0da814517b4178a76588e8b278f324) and things appear as expected:
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -761,7 +761,7 @@ const styles = StyleSheet.create({\n},\nheader: {\ncolor: 'white',\n- fontFamily: 'IBMPlexSans',\n+ fontFamily: Platform.OS === 'ios... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] OS-specific `fontFamily`
Test Plan: Did a clean build on iOS (Product > Clean Build Folder) and Android (https://www.notion.so/commapp/Android-debugging-stuff-9a0da814517b4178a76588e8b278f324) and things appear as expected: https://blob.sh/atul/0b40.png
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Ka... |
129,187 | 28.05.2021 16:02:36 | 14,400 | 47dc9853e6cefb7956e3d4f09c5265e610fb3399 | [server] Get rid of eslint-disable no-irregular-whitespace
Test Plan: N/A
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/add-indexes-for-account-deletion.js",
"new_path": "server/src/scripts/add-indexes-for-account-deletion.js",
"diff": "@@ -4,13 +4,11 @@ import { dbQuery, SQL } from '../database/database';\nimport { main } from './utils';\nasync function addI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Get rid of eslint-disable no-irregular-whitespace
Test Plan: N/A
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1296 |
129,187 | 28.05.2021 17:33:42 | 14,400 | 7c612fdab83ad0d59fd33010002094f508df50c3 | [server] Script to add containing_thread_id column
Summary: Also adds indices for both `parent_thread_id` and the new `containing_thread_id`.
Test Plan: Run the script
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/add-containing-thread-id-column.js",
"diff": "+// @flow\n+\n+import { dbQuery, SQL } from '../database/database';\n+import { main } from './utils';\n+\n+async function addColumnAndIndexes() {\n+ await dbQuery(SQL`\n+ ALTER TAB... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Script to add containing_thread_id column
Summary: Also adds indices for both `parent_thread_id` and the new `containing_thread_id`.
Test Plan: Run the script
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1297 |
129,187 | 28.05.2021 17:34:43 | 14,400 | c54059719e0857635ff0a04396c6ff2200411fa4 | [server] Add containingThreadID to ServerThreadInfo
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -212,6 +212,7 @@ export type ServerThreadInfo = {|\n+color: string, // hex, without \"#\" or \"0x\"\n+creationTime: number, // millisecond timestamp\n+parentThreadID: ?string,\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add containingThreadID to ServerThreadInfo
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1298 |
129,187 | 28.05.2021 17:45:08 | 14,400 | 592dc67169e97d3392f7c505ad16239f7f380ead | [server] Set containingThreadID in createThread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -25,6 +25,7 @@ import { firstLine } from 'lib/utils/string-utils';\nimport { dbQuery, SQL } from '../database/database';\nimport { fetchMessageInfoByID } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Set containingThreadID in createThread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1299 |
129,187 | 28.05.2021 17:50:16 | 14,400 | cd3a384b1ff905c68147125731e217333e38815c | [server] Update containingThreadID in updateThread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -36,6 +36,7 @@ import { fetchMessageInfos } from '../fetchers/message-fetchers';\nimport {\nfetchThreadInfos,\nfetchServerThreadInfos,\n+ determineContai... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update containingThreadID in updateThread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1300 |
129,187 | 28.05.2021 18:40:39 | 14,400 | c54f727b07137e30f4f19d6196de4dca9ac75d52 | [server] Update containing_thread_id to set values for new column
Test Plan: Run the script
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/add-containing-thread-id-column.js",
"new_path": "server/src/scripts/add-containing-thread-id-column.js",
"diff": "// @flow\n+import invariant from 'invariant';\n+\n+import { threadTypes, type ServerThreadInfo } from 'lib/types/thread-types'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update containing_thread_id to set values for new column
Test Plan: Run the script
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1301 |
129,187 | 28.05.2021 17:13:37 | 14,400 | 6b614e170a7b997cc5b9222dbeddef368ff33dfb | [server] Change parameter format of updateDescendantPermissions
Summary: This is in preparation for adding a second property to `AncestorChanges`.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -210,7 +210,9 @@ async function changeRole(\n}\nif (!_isEqual(permissionsForChildren)(oldPermissionsForChildren)) {\n- toUpdateDesc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Change parameter format of updateDescendantPermissions
Summary: This is in preparation for adding a second property to `AncestorChanges`.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://ph... |
129,187 | 30.05.2021 11:48:08 | 14,400 | 07bfd498d5f31d25405f86d8be24be7bed620bac | [lib] Introduce threadTypeIsCommunityRoot
Summary: Going to use this check in a couple other places.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -60,6 +60,13 @@ export function assertThreadType(threadType: number): ThreadType {\nreturn threadType;\n}\n+export function threadTypeIsCommunityRoot(threadType: ThreadType): bool... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce threadTypeIsCommunityRoot
Summary: Going to use this check in a couple other places.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1303 |
129,187 | 30.05.2021 11:57:59 | 14,400 | 814a3e9f878a9fa1cbdf5f113163d032b58bb4b7 | [server] Add community column to threads table
Summary: This diff addresses [this issue](https://www.notion.so/commapp/Add-community-column-to-threads-table-a8c542df0e7745fa8fc615cd52924882). It will make it more efficient for us to check whether two threads are in the same community, for instance.
Test Plan: Will be t... | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/add-containing-thread-id-column.js",
"new_path": "server/src/scripts/add-containing-thread-id-column.js",
"diff": "@@ -12,7 +12,9 @@ async function addColumnAndIndexes() {\nawait dbQuery(SQL`\nALTER TABLE threads\nADD containing_thread_id BI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add community column to threads table
Summary: This diff addresses [this issue](https://www.notion.so/commapp/Add-community-column-to-threads-table-a8c542df0e7745fa8fc615cd52924882). It will make it more efficient for us to check whether two threads are in the same community, for instance.
Test Plan: Will be... |
129,187 | 30.05.2021 13:03:22 | 14,400 | 37c739f07d91542a50892f1fe7293f2a522dc6bf | [server] Add community to ServerThreadInfo
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -220,6 +220,7 @@ export type ServerThreadInfo = {|\n+creationTime: number, // millisecond timestamp\n+parentThreadID: ?string,\n+containingThreadID: ?string,\n+ +community: ?strin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add community to ServerThreadInfo
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1305 |
129,187 | 30.05.2021 13:08:27 | 14,400 | 859542a2defd4e2400102eb11ee0cda745ad6cda | [server] determineContainingThreadID -> determineThreadAncestry
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -26,7 +26,7 @@ import { firstLine } from 'lib/utils/string-utils';\nimport { dbQuery, SQL } from '../database/database';\nimport { fetchMessageInfoByID } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] determineContainingThreadID -> determineThreadAncestry
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1306 |
129,187 | 30.05.2021 16:27:55 | 14,400 | 98f27bbacde584e89af0f1e085e3509dc9077da1 | [server] Set community in createThread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -216,6 +216,7 @@ async function createThread(\ncolor,\nparentThreadID,\nthreadAncestry.containingThreadID,\n+ threadAncestry.community,\nnewRoles.default.i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Set community in createThread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1308 |
129,187 | 30.05.2021 16:57:29 | 14,400 | 37423af0e259c459c9fd9c0caa7ce0e72f3b7fe2 | [server] Update community in updateThread
Summary: Now that we can make sure that `parentThreadID` changes don't change the containing community, we can reenable them (despite it not being done anywhere in the UI).
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-s... | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -343,15 +343,6 @@ async function updateThread(\nsqlUpdate.type = threadType;\n}\n- // We're temporarily blocking changing parent thread IDs. Note that ev... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update community in updateThread
Summary: Now that we can make sure that `parentThreadID` changes don't change the containing community, we can reenable them (despite it not being done anywhere in the UI).
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, pal... |
129,187 | 30.05.2021 16:36:08 | 14,400 | 6bb786394b6027241a2c33b3db80ac5b910218fc | [server] Set community in same script that sets containing thread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "RENAME",
"old_path": "server/src/scripts/add-containing-thread-id-column.js",
"new_path": "server/src/scripts/add-thread-ancestry.js",
"diff": "@@ -6,6 +6,7 @@ import { dbQuery, SQL } from '../database/database';\nimport {\nfetchServerThreadInfos,\ngetContainingThreadID,\n+ getComm... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Set community in same script that sets containing thread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1310 |
129,187 | 30.05.2021 17:02:28 | 14,400 | ff9b0a8f9fae9dfa36bdeabdeb0e89339bcbc0e1 | [server] Add depth to ServerThreadInfo
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -221,6 +221,7 @@ export type ServerThreadInfo = {|\n+parentThreadID: ?string,\n+containingThreadID: ?string,\n+community: ?string,\n+ +depth: number,\n+members: $ReadOnlyArray<Ser... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add depth to ServerThreadInfo
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1312 |
129,187 | 30.05.2021 17:04:09 | 14,400 | 94dc24207596761e589e3a1024c2a80bc27085a4 | [server] Set depth in createThread and updateThread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -217,6 +217,7 @@ async function createThread(\nparentThreadID,\nthreadAncestry.containingThreadID,\nthreadAncestry.community,\n+ threadAncestry.depth,\nnew... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Set depth in createThread and updateThread
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1313 |
129,187 | 30.05.2021 17:09:30 | 14,400 | b7eb6ac6fd608b126a7dfca74394da8e9ebf8943 | [server] Set depth in add-thread-ancestory.js script
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/add-thread-ancestry.js",
"new_path": "server/src/scripts/add-thread-ancestry.js",
"diff": "@@ -58,19 +58,24 @@ async function setColumnForLayer(\nupdatedThreadInfos.push(threadInfo);\ncontinue;\n}\n+ const depth = parentThreadInfo ? parentTh... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Set depth in add-thread-ancestory.js script
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1314 |
129,187 | 30.05.2021 22:21:18 | 14,400 | 4e4a543e9538dc84bd1329cedad9ab05e6e907fd | [lib] Store thread name/description in genesis.json
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/genesis.json",
"new_path": "lib/facts/genesis.json",
"diff": "{\n- \"id\": \"1\"\n+ \"id\": \"1\",\n+ \"name\": \"GENESIS\",\n+ \"description\": \"This is the first community on Comm. In the future it will be possible to create threads outside of a c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Store thread name/description in genesis.json
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1315 |
129,187 | 30.05.2021 22:43:31 | 14,400 | a4efcdb283831ada1ce06b89ec13c4b05a78c28c | [server] Create GENESIS community in create-db.js script
Summary: Also updates it to use `createThread` directly.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-db.js",
"new_path": "server/src/scripts/create-db.js",
"diff": "import ashoat from 'lib/facts/ashoat';\nimport bots from 'lib/facts/bots';\n-import {\n- makePermissionsBlob,\n- makePermissionsForChildrenBlob,\n-} from 'lib/permissions... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create GENESIS community in create-db.js script
Summary: Also updates it to use `createThread` directly.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1316 |
129,187 | 30.05.2021 22:56:59 | 14,400 | c60074de06467ab8ab03e65a82fb6c2f2dede90f | Add new GENESIS ThreadType
Summary: We need this one to prevent users from leaving GENESIS.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -940,6 +940,7 @@ function getThreadTypeParentRequirement(\n} else if (\nthreadType === threadTypes.COMMUNITY_ROOT ||\nthreadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT ||\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add new GENESIS ThreadType
Summary: We need this one to prevent users from leaving GENESIS.
Test Plan: Will be tested in combination with following diffs
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1317 |
129,187 | 31.05.2021 12:40:52 | 14,400 | 7a9f86bb07cf19efd1317efab4996364de2822b4 | [native] codeVersion -> 86 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -268,8 +268,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 86 |
129,187 | 31.05.2021 14:26:00 | 14,400 | 4dc01130d0f7bb3cc50661120ff93aa586c3f2c8 | [server] Continue pushing back the launch of some features
Summary: Similar to D1276 and D1294. Realized I'll need to make another release (see comment in D1320)...
Test Plan: Flow
Reviewers: palys-swm, karol-bisztyga, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -289,7 +289,7 @@ async function createThread(\nlet joinRequest = {\nthreadID: existingThreadID,\n};\n- if (hasMinCodeVersion(viewer.platformDetails, 86)) {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Continue pushing back the launch of some features
Summary: Similar to D1276 and D1294. Realized I'll need to make another release (see comment in D1320)...
Test Plan: Flow
Reviewers: palys-swm, karol-bisztyga, atul
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.as... |
129,187 | 01.06.2021 14:07:42 | 14,400 | d5d518b1b5a661e0678d65a61ef0ccd883b27aad | [lib] Add string for community ThreadTypes to threadLabel
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -818,6 +818,12 @@ function threadLabel(threadType: ThreadType) {\nreturn 'Sidebar';\n} else if (threadType === threadTypes.PRIVATE) {\nreturn 'Private';\n+ } else if (\n+ thread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add string for community ThreadTypes to threadLabel
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1327 |
129,184 | 01.06.2021 09:43:19 | 14,400 | e40af1864494cf6faa69db514b25681297a15f02 | [native] Introduce `thread-settings-ancestors` component
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-ancestors.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { Text, View, ScrollView } from 'react-native';\n+import Icon from 'react-native-vector-icons/FontAwesome5';\n+\n+import {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `thread-settings-ancestors` component
Summary: Here's what it looks like: https://blob.sh/atul/thead-ancestors.mp4
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1328 |
129,184 | 01.06.2021 16:34:04 | 14,400 | b71287438ed288be2fa5dd24f51efdb175389828 | [native] Introduce `baseAncestorThreadInfos` selector and add ancestor path to `thread-settings`
Test Plan: Path appears as expected. Tested with threads with many ancestors and no ancestors (genesis)
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/thread-selectors.js",
"new_path": "lib/selectors/thread-selectors.js",
"diff": "@@ -240,6 +240,27 @@ const unreadBackgroundCount: (\n).length,\n);\n+const baseAncestorThreadInfos = (threadID: string) =>\n+ createSelector(\n+ (state: BaseAppState<... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `baseAncestorThreadInfos` selector and add ancestor path to `thread-settings`
Test Plan: Path appears as expected. Tested with threads with many ancestors and no ancestors (genesis)
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabric... |
129,191 | 31.05.2021 13:38:18 | -7,200 | 6762465ae9f721c086bcccac4887c34242a8210d | [server] Use multipleStatements mode in account deletion indexes script
Summary: Without multipleStatements mode an error is returned `You have an error in your SQL syntax...`. Enabling multipleStatements fixes the issue.
Test Plan: Run the script and check if indexes were added
Reviewers: ashoat
Subscribers: KatPo, Ad... | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/add-indexes-for-account-deletion.js",
"new_path": "server/src/scripts/add-indexes-for-account-deletion.js",
"diff": "// @flow\nimport { dbQuery, SQL } from '../database/database';\n+import { setScriptContext } from './script-context';\nimpor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use multipleStatements mode in account deletion indexes script
Summary: Without multipleStatements mode an error is returned `You have an error in your SQL syntax...`. Enabling multipleStatements fixes the issue.
Test Plan: Run the script and check if indexes were added
Reviewers: ashoat
Reviewed By: ashoa... |
129,184 | 02.06.2021 11:08:04 | 14,400 | 88fc77db44169bdb319c528e1d1ee8f0ab0ae150 | [native] Only send crash reports when staff or dev
Test Plan: Tested with different scenarios (staff and dev, staff and !dev, etc) and logged to ensure crash reports only sent when expected.
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/crash.react.js",
"new_path": "native/crash.react.js",
"diff": "@@ -18,6 +18,7 @@ import Icon from 'react-native-vector-icons/FontAwesome';\nimport { sendReportActionTypes, sendReport } from 'lib/actions/report-actions';\nimport { logOutActionTypes, logO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Only send crash reports when staff or dev
Test Plan: Tested with different scenarios (staff and dev, staff and !dev, etc) and logged to ensure crash reports only sent when expected.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoa... |
129,184 | 02.06.2021 15:43:59 | 14,400 | 08471ce68a9758c59de495018370fc08e4afb42a | Add `require-valid-file-annotation` rule to eslint
Summary: Added `require-valid-file-annotation` rule to eslint as suggested by (https://phabricator.ashoat.com/D1331#31510)
Test Plan: Removed `@flow` annotation from a file, ran eslint, got an error as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, ashoat, A... | [
{
"change_type": "MODIFY",
"old_path": ".eslintrc.json",
"new_path": ".eslintrc.json",
"diff": "\"parser\": \"babel-eslint\",\n\"plugins\": [\"react\", \"react-hooks\", \"flowtype\", \"monorepo\", \"import\"],\n\"rules\": {\n+ \"flowtype/require-valid-file-annotation\": [\"error\", \"always\"],\n\"c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add `require-valid-file-annotation` rule to eslint
Summary: Added `require-valid-file-annotation` rule to eslint as suggested by @ashoat (https://phabricator.ashoat.com/D1331#31510)
Test Plan: Removed `@flow` annotation from a file, ran eslint, got an error as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscri... |
129,184 | 02.06.2021 18:15:27 | 14,400 | ae1402fa636adcb90faeca2e4684a5dec4a35a6e | [lib] Fix eslint unused import in `calendar-query-handler`
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/calendar-query-handler.react.js",
"new_path": "lib/socket/calendar-query-handler.react.js",
"diff": "@@ -14,7 +14,6 @@ import type {\nCalendarQueryUpdateResult,\nCalendarQueryUpdateStartingPayload,\n} from '../types/entry-types';\n-import { type Lif... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix eslint unused import in `calendar-query-handler`
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1333 |
129,184 | 02.06.2021 18:57:44 | 14,400 | 406ef39753993a229023dafe4726cbd2aad7f545 | [lib][web][native] add `crashReportsEnabled` to redux
Test Plan: Verified with redux devtools
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/reducers/crash-reports-enabled-reducer.js",
"diff": "+// @flow\n+\n+import type { BaseAction } from '../types/redux-types';\n+\n+export const updateCrashReportsEnabledActionType =\n+ 'UPDATE_CRASH_REPORTS_ENABLED';\n+\n+export default functi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib][web][native] add `crashReportsEnabled` to redux
Test Plan: Verified with redux devtools
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1335 |
129,184 | 02.06.2021 21:56:27 | 14,400 | 7ff4eea99d6e830c18bc08bf906d428d6cc50cdf | [native] Introduce `useIsCrashReportingEnabled` hook and use in `crash.react.js`
Test Plan: Toggled `crashReportingEnabled` on/off and the `crash` component behaved/looked as expected when crash was manually triggered from dev menu
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/crash.react.js",
"new_path": "native/crash.react.js",
"diff": "@@ -18,7 +18,6 @@ import Icon from 'react-native-vector-icons/FontAwesome';\nimport { sendReportActionTypes, sendReport } from 'lib/actions/report-actions';\nimport { logOutActionTypes, logO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `useIsCrashReportingEnabled` hook and use in `crash.react.js`
Test Plan: Toggled `crashReportingEnabled` on/off and the `crash` component behaved/looked as expected when crash was manually triggered from dev menu
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differe... |
129,184 | 02.06.2021 19:45:27 | 14,400 | 47de31ad201ad3bcb32c7f6e38bd31bebbb7e05a | [native] Introduce `toggle-crash-reports` component and include in `profile-screen`
Summary: Note: The `toggle-crash-reports` component will be moved to a separate page in a subsequent diff.
Test Plan: Toggled the switch on/off and observed redux dev tools to confirm state changed as expected
Reviewers: ashoat
Subscrib... | [
{
"change_type": "MODIFY",
"old_path": "native/profile/profile-screen.react.js",
"new_path": "native/profile/profile-screen.react.js",
"diff": "@@ -51,6 +51,7 @@ import {\nimport { useSelector } from '../redux/redux-utils';\nimport { type Colors, useColors, useStyles } from '../themes/colors';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `toggle-crash-reports` component and include in `profile-screen`
Summary: Note: The `toggle-crash-reports` component will be moved to a separate page in a subsequent diff.
Test Plan: Toggled the switch on/off and observed redux dev tools to confirm state changed as expected
Reviewers: ashoat
Revi... |
129,184 | 03.06.2021 19:07:19 | 14,400 | bd0686a9c0bf7892d47dee5f8d61294997160a2e | [native] Extract `thread-ancestors` component out of `thread-settings-ancestors`
Summary: Simple cut/paste refactor, sets things up for subsequent diffs.
Test Plan: `thread-ancestors` continued to look and work as expected. should be simple cut/paste diff
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-ancestors.react.js",
"new_path": "native/chat/settings/thread-settings-ancestors.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { Text, View, ScrollView } from 'react-native';\n-import Icon from 'rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extract `thread-ancestors` component out of `thread-settings-ancestors`
Summary: Simple cut/paste refactor, sets things up for subsequent diffs.
Test Plan: `thread-ancestors` continued to look and work as expected. should be simple cut/paste diff
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, p... |
129,202 | 04.06.2021 09:45:06 | -28,800 | 75c589b8f40961b4e6784d88b20db0cdd73b46bb | Updating the README with the Ubuntu Setup information for Reactotron
Summary: Issue reactotron#815 prevents reactotron to connect to the android emulator. Running adb reverse fixes the issue.
Test Plan: Running the adb reverse command fixed the Issue on Ubuntu 20.04.
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adr... | [
{
"change_type": "MODIFY",
"old_path": "docs/linux_dev_environment.md",
"new_path": "docs/linux_dev_environment.md",
"diff": "@@ -28,6 +28,20 @@ If you're not on Ubuntu, you can look for distro-specific binaries using your pr\nFollow installation instructions from [react-native-debugger/issues/116#i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Updating the README with the Ubuntu Setup information for Reactotron
Summary: Issue reactotron#815 prevents reactotron to connect to the android emulator. Running adb reverse fixes the issue.
Test Plan: Running the adb reverse command fixed the Issue on Ubuntu 20.04.
Reviewers: ashoat
Reviewed By: ashoat
Subscribe... |
129,184 | 07.06.2021 23:42:46 | 14,400 | e95ece27b9323c4d61a5736dc27557df186f936c | [native] Move crash report toggling from main Profile page to separate Privacy page
Test Plan: Toggled crash report preferences and confirmed expected behavior by looking at Redux dev tools and triggering crashes via Developer Tools
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/route-names.js",
"new_path": "native/navigation/route-names.js",
"diff": "@@ -48,6 +48,7 @@ export const DevToolsRouteName = 'DevTools';\nexport const EditEmailRouteName = 'EditEmail';\nexport const EditPasswordRouteName = 'EditPassword';\nex... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move crash report toggling from main Profile page to separate Privacy page
Test Plan: Toggled crash report preferences and confirmed expected behavior by looking at Redux dev tools and triggering crashes via Developer Tools
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.