author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,184 | 04.06.2021 16:45:02 | 14,400 | bf662af826c7e0abbc08b06dcd9e71cb8a725d02 | [native] Use `pill` component in `thread-ancestors`
Test Plan: Continues to look/work as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-ancestors.react.js",
"new_path": "native/components/thread-ancestors.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { Text, View, ScrollView } from 'react-native';\n+import { View, ScrollView } from 'react-nativ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `pill` component in `thread-ancestors`
Test Plan: Continues to look/work as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1357 |
129,184 | 07.06.2021 13:45:12 | 14,400 | 4d1a496f847b1e65ed27854938bb2c25048a5410 | [native] Navigate to ancestor thread on tap in `thread-ancestors` component
Test Plan: Works and looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-ancestors.react.js",
"new_path": "native/components/thread-ancestors.react.js",
"diff": "// @flow\n+import { useNavigation } from '@react-navigation/native';\nimport * as React from 'react';\n-import { View, ScrollView } from 'react-na... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Navigate to ancestor thread on tap in `thread-ancestors` component
Test Plan: Works and looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1358 |
129,184 | 07.06.2021 14:59:39 | 14,400 | 074dfd4be8f1b2a0ce156d258c55330ac98ebc81 | [native] Use `pill` component in `thread-settings-parent`
Test Plan: Works and looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-parent.react.js",
"new_path": "native/chat/settings/thread-settings-parent.react.js",
"diff": "import invariant from 'invariant';\nimport * as React from 'react';\n-import { Text, View, Platform } from 'react-native';\n+imp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `pill` component in `thread-settings-parent`
Test Plan: Works and looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1359 |
129,184 | 07.06.2021 21:29:23 | 14,400 | fa8c78668ec63b499170bc9583d938aef2d62cd9 | [native] Use `pill` component in `thread-settings-visibility`
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-visibility.react.js",
"new_path": "native/chat/settings/thread-settings-visibility.react.js",
"diff": "@@ -20,7 +20,7 @@ function ThreadSettingsVisibility(props: Props) {\n<Text style={styles.label}>Visibility</Text>\n<Thre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `pill` component in `thread-settings-visibility`
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1360 |
129,184 | 08.06.2021 15:56:51 | 14,400 | 60da102261d9a4789eb06d0a89f200196dce4ea1 | [native] Minor search bar margin tweak
Summary:
Minor increase to search bar `marginTop`
Before:
After:
Test Plan: Looks as expected, no functional change
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -578,7 +578,7 @@ const unboundStyles = {\nsearch: {\nmarginBottom: 8,\nmarginHorizontal: 12,\n- marginTop: Platform.OS === 'android' ? 10 : 8,\n+ marginTop... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Minor search bar margin tweak
Summary:
Minor increase to search bar `marginTop`
Before: https://blob.sh/atul/padding8.png
After: https://blob.sh/atul/padding12.png
Test Plan: Looks as expected, no functional change
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential ... |
129,184 | 09.06.2021 16:08:12 | 14,400 | 2811eeda5db5d8bd4dec0ba1ea9cfa6818d3fa2a | [native] Minor `ThreadAncesters` tweaks
Summary:
Move `paddingHorizontal` from `container` to `contentContainer`
Hide horizontal scroll indicator
Test Plan: Looks and works as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-ancestors.react.js",
"new_path": "native/components/thread-ancestors.react.js",
"diff": "@@ -97,7 +97,13 @@ function ThreadAncestors(props: Props): React.Node {\nreturn (\n<View style={styles.container}>\n- <ScrollView horizontal={true... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Minor `ThreadAncesters` tweaks
Summary:
- Move `paddingHorizontal` from `container` to `contentContainer`
- Hide horizontal scroll indicator
Test Plan: Looks and works as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat... |
129,184 | 09.06.2021 16:39:11 | 14,400 | 8da14570de325463fa9c2625cd17cf801882ad52 | [native] Introduce `ThreadAncestorsLabel` component
Summary: Introduce `ThreadAncestorsLabel` which displays a non-interactive ancestor path that may be shortened with ellipsis if full path exceeds the given space.
Test Plan: Looks as expected when added to `ChatThreadListItem` (next diff)
Reviewers: ashoat
Subscribers... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/components/thread-ancestors-label.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import { ancestorThreadInfos } from 'lib/selectors/thread-selectors';\n+import { type ThreadInfo } from 'lib/types/thread-types';\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `ThreadAncestorsLabel` component
Summary: Introduce `ThreadAncestorsLabel` which displays a non-interactive ancestor path that may be shortened with ellipsis if full path exceeds the given space.
Test Plan: Looks as expected when added to `ChatThreadListItem` (next diff)
Reviewers: ashoat
Reviewe... |
129,184 | 09.06.2021 16:50:03 | 14,400 | 73d4cf6f9f7295a32267972a4af1b2e2be600e7e | [native] Show `ThreadAncestorsLabel` in `ChatThreadListItem`
Test Plan: Looks and works as expected on both iOS Simulator and physical device
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -11,6 +11,7 @@ import { shortAbsoluteDate } from 'lib/utils/date-utils';\nimport Button from '../components/button.react';\nimport ColorSplotch f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Show `ThreadAncestorsLabel` in `ChatThreadListItem`
Test Plan: Looks and works as expected on both iOS Simulator and physical device
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1393 |
129,187 | 09.06.2021 15:39:40 | 14,400 | 89dbd3256cddd207aef9b0e5905594f44c7006ea | Add ESLint rule to avoid unnecessary curly braces in JSX
Summary: Some context [here](https://phabricator.ashoat.com/D1360?id=4074#inline-7298).
Test Plan: `yarn eslint:fix`
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": ".eslintrc.json",
"new_path": ".eslintrc.json",
"diff": "\"groups\": [[\"builtin\", \"external\"], \"internal\"]\n}\n],\n- \"prefer-const\": \"error\"\n+ \"prefer-const\": \"error\",\n+ \"react/jsx-curly-brace-presence\": [\n+ \"error\",\n+ { \"props\": \"never... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add ESLint rule to avoid unnecessary curly braces in JSX
Summary: Some context [here](https://phabricator.ashoat.com/D1360?id=4074#inline-7298).
Test Plan: `yarn eslint:fix`
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1390 |
129,184 | 09.06.2021 20:41:38 | 14,400 | b15efb6a167afc77b707caabbaf0ce5ed4f9e6d7 | [native] Fix typo
Test Plan: continues to work as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -34,7 +34,7 @@ import {\n} from 'lib/types/thread-types';\nimport type { UserInfos } from 'lib/types/user-types';\n-import ThreadAncesters ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix typo
Test Plan: continues to work as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1394 |
129,190 | 09.06.2021 13:32:42 | -7,200 | b6949e4cd8cc61d77e8cb5ff8c8d7122cf208a59 | [native] Move draft for realized pending thread
Summary: When a thread gets realized, change the draft key from pending to realized so the draft's not gone
Test Plan: todo
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -1018,6 +1018,10 @@ function checkIfDefaultMembersAreVoiced(threadInfo: ThreadInfo) {\nreturn !!defaultRole.permissions[threadPermissions.VOICED];\n}\n+function draftKeyFromThre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move draft for realized pending thread
Summary: When a thread gets realized, change the draft key from pending to realized so the draft's not gone
Test Plan: todo
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricato... |
129,190 | 10.06.2021 14:25:47 | -7,200 | 3d5944a6b8cf3ba6830a332ac4fd5c48795a77f2 | [native] Consider only types of threads that can be pending
Summary: When using `pendingToRealizedThreadIDsSelector` we want to filter threads by their types and handle only those that can be pending
Test Plan: todo
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/thread-selectors.js",
"new_path": "lib/selectors/thread-selectors.js",
"diff": "@@ -25,6 +25,7 @@ import {\nroleIsAdminRole,\nthreadIsPending,\ngetPendingThreadID,\n+ threadTypeCanBePending,\n} from '../shared/thread-utils';\nimport type { EntryI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Consider only types of threads that can be pending
Summary: When using `pendingToRealizedThreadIDsSelector` we want to filter threads by their types and handle only those that can be pending
Test Plan: todo
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atu... |
129,187 | 05.06.2021 03:37:09 | 14,400 | 3117b102ff00409ccdd0b243277fee0711fee111 | [server] Throw ServerError if we can't determine the intendedRole in changeRole
Summary: This is a serious error and shouldn't result in a silent failure.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -105,9 +105,6 @@ async function changeRole(\ndbQuery(membershipQuery),\nchangeRoleThreadQuery(threadID, role),\n]);\n- if (!roleThr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Throw ServerError if we can't determine the intendedRole in changeRole
Summary: This is a serious error and shouldn't result in a silent failure.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revisio... |
129,187 | 05.06.2021 03:28:42 | 14,400 | 0f191408c582e93030058c2b511d708a13fed8bb | [server] Delete DEPRECATED_updateRoleAndPermissions
Summary: Since the previous diff removed the only two callsites, we can now remove this deprecated function.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/role-updaters.js",
"new_path": "server/src/updaters/role-updaters.js",
"diff": "import invariant from 'invariant';\nimport _isEqual from 'lodash/fp/isEqual';\n-import type {\n- ThreadType,\n- ThreadRolePermissionsBlob,\n-} from 'lib/types/t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete DEPRECATED_updateRoleAndPermissions
Summary: Since the previous diff removed the only two callsites, we can now remove this deprecated function.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1354 |
129,187 | 07.06.2021 15:12:02 | 14,400 | 4c360965df029546573ac1cdddd0f882dbdf76c3 | [server] Skip updates in changeRole if no change detected
Summary: We check this in the other permissions updaters, so I figured we might as well do it in `changeRole` as well.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -88,7 +88,7 @@ async function changeRole(\noptions?.setNewMembersToUnread && intent === 'join';\nconst membershipQuery = SQL`\n- SE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Skip updates in changeRole if no change detected
Summary: We check this in the other permissions updaters, so I figured we might as well do it in `changeRole` as well.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian... |
129,187 | 07.06.2021 16:25:15 | 14,400 | c3ab0cbcb222e4917d92bac1dcc4d4160a90befa | [server] Don't return threads without memberships rows in updateDescendantPermissions query
Summary: This should result in exactly the same behavior.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -370,7 +370,7 @@ async function updateDescendantPermissions(\nr.permissions AS role_permissions, m.permissions,\nm.permissions_for_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't return threads without memberships rows in updateDescendantPermissions query
Summary: This should result in exactly the same behavior.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: ht... |
129,187 | 07.06.2021 17:59:51 | 14,400 | 36c948b1744bb2485722e395910e8282df0a8d6a | [server] Pass thread depth into updateDescendantPermissions
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -128,6 +128,7 @@ async function changeRole(\nthreadType,\nhasContainingThreadID,\nrolePermissions: intendedRolePermissions,\n+ dept... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Pass thread depth into updateDescendantPermissions
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1368 |
129,187 | 07.06.2021 23:24:20 | 14,400 | c1aad9eca2c3db70ac311f33810daac116044533 | [server] Extract query logic of updateDescendantPermissions into new function
Summary: This diff introduces `fetchDescendantsForUpdate`. Extracting this will make a lot of sense in the context of future diffs.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, A... | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -365,106 +365,88 @@ type ChangedAncestor = {|\ntype AncestorChanges = {|\n+permissionsFromParent: ?ThreadPermissionsBlob,\n|};\n-\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Extract query logic of updateDescendantPermissions into new function
Summary: This diff introduces `fetchDescendantsForUpdate`. Extracting this will make a lot of sense in the context of future diffs.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Reviewed By: paly... |
129,187 | 07.06.2021 23:30:20 | 14,400 | 9c2d0b1086b8d54639bad8d4849dde19a7d70304 | [server] Rename AncestorChanges.permissionsFromParent to permissionsForChildren
Summary: We'll be naming the properties from the context of the parent, not the child, going forward.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -265,7 +265,7 @@ async function changeRole(\n!_isEqual(permissionsForChildren)(oldPermissionsForChildren)\n) {\ntoUpdateDescendants... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rename AncestorChanges.permissionsFromParent to permissionsForChildren
Summary: We'll be naming the properties from the context of the parent, not the child, going forward.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabrica... |
129,187 | 07.06.2021 23:32:39 | 14,400 | 25fff13695f818cbc187eca1982c4adcfbef02b4 | [server] Pass userIsMember in to updateDescendantPermissions
Summary: It will be checked in a future diff, which will update the fetch query and handle the new results.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -265,6 +265,7 @@ async function changeRole(\n!_isEqual(permissionsForChildren)(oldPermissionsForChildren)\n) {\ntoUpdateDescendants... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Pass userIsMember in to updateDescendantPermissions
Summary: It will be checked in a future diff, which will update the fetch query and handle the new results.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.co... |
129,187 | 08.06.2021 00:02:20 | 14,400 | 91a1eda42f3bfd4f98f31f8703f6c035e674e629 | [server] Update updateDescendantPermissions to consider containing thread membership
Summary: This was done for `changeRole` in D1350 and for `recalculateThreadPermissions` in D1351.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -388,6 +388,9 @@ async function updateDescendantPermissions(\nconst {\ncurRole,\ncurRolePermissions,\n+ curPermissionsFromParent,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update updateDescendantPermissions to consider containing thread membership
Summary: This was done for `changeRole` in D1350 and for `recalculateThreadPermissions` in D1351.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, ... |
129,187 | 08.06.2021 00:16:43 | 14,400 | 340ca6d37a3372c05880748168d4515283066ef3 | [server] Support multiple ancestors in fetchDescendantsForUpdate
Summary: This optimization was hard to do in the past, but since I am going to rework `updateDescendantPermissions` to iterate by depth, it becomes trivial.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribe... | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -376,7 +376,7 @@ async function updateDescendantPermissions(\nwhile (stack.length > 0) {\nconst ancestor = stack.shift();\n- const ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Support multiple ancestors in fetchDescendantsForUpdate
Summary: This optimization was hard to do in the past, but since I am going to rework `updateDescendantPermissions` to iterate by depth, it becomes trivial.
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Revie... |
129,187 | 08.06.2021 00:24:56 | 14,400 | 13d830007e91cc033a9a271b0ee236619fa0dceb | [server] Batch fetchDescendantsForUpdate fetches
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -510,10 +510,15 @@ type DescendantInfo = {|\n+depth: number,\n+users: Map<string, DescendantUserInfo>,\n|};\n+const fetchDescendant... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Batch fetchDescendantsForUpdate fetches
Test Plan: Will be tested in combination with following diffs
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1376 |
129,190 | 15.06.2021 14:46:55 | -7,200 | 303de37ea36ce30895d357a8d869e0660f581115 | [native] Apply core data provider
Summary: Apply core data provider introduced in D1121
Test Plan: todo
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -54,6 +54,7 @@ import {\nimport Button from '../components/button.react';\nimport ClearableTextInput from '../components/clearable-text-input.react';\n+import ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Apply core data provider
Summary: Apply core data provider introduced in D1121
Test Plan: todo
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1413 |
129,187 | 18.06.2021 12:29:14 | 14,400 | b5ce61dbc9857d5355b6ddc5b1404fd6d00717ba | [lib] Allow single-character usernames for soft launch
Test Plan: Copy-pasted into a JS REPL:
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/account-utils.js",
"new_path": "lib/shared/account-utils.js",
"diff": "@@ -10,9 +10,9 @@ import type { PreRequestUserState } from '../types/session-types';\nimport type { CurrentUserInfo } from '../types/user-types';\nconst usernameMaxLength = 191;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Allow single-character usernames for soft launch
Test Plan: Copy-pasted into a JS REPL: https://www.dropbox.com/s/rayjbmws1g8vmg7/Screen%20Shot%202021-06-18%20at%2012.31.28%20PM.png?dl=0
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.... |
129,187 | 18.06.2021 12:26:02 | 14,400 | c0ac27617e448cb46b961925e74329b6ab64d97d | [server] Delete a user's reports when they delete their account
Test Plan: Ran the query
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/account-deleters.js",
"new_path": "server/src/deleters/account-deleters.js",
"diff": "@@ -74,6 +74,10 @@ async function deleteAccount(\nFROM sessions s\nLEFT JOIN ids i ON i.id = s.id\nWHERE s.user = ${deletedUserID};\n+ DELETE r, i\n+ FROM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete a user's reports when they delete their account
Test Plan: Ran the query
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1424 |
129,184 | 13.06.2021 16:37:14 | 14,400 | 6f712bc130718acddc2d73568d1344c61bb40696 | [native] Use `pill` component in `thread-settings-child-thread`
Summary:
Before:
After:
Test Plan: Continues to work as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-child-thread.react.js",
"new_path": "native/chat/settings/thread-settings-child-thread.react.js",
"diff": "@@ -6,8 +6,7 @@ import { View, Platform } from 'react-native';\nimport type { ThreadInfo } from 'lib/types/thread-ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `pill` component in `thread-settings-child-thread`
Summary:
Before: https://blob.sh/atul/thread-settings-child-thread-before.png
After: https://blob.sh/atul/thread-settings-child-thread-after.png
Test Plan: Continues to work as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-s... |
129,184 | 18.06.2021 17:41:03 | 14,400 | aee87e2dee30bd713758debf0ecb3515fd930197 | [refactor] Rename `sanitizeAction` to `sanitizeActionSecrets`
Summary: Simple rename in preparation for upcoming user data sanitization diff
Test Plan: NA
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -78,7 +78,7 @@ import { setNewSessionActionType } from '../utils/action-utils';\nimport { getConfig } from '../utils/config';\nimport { dateString } from '../utils/date-ut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [refactor] Rename `sanitizeAction` to `sanitizeActionSecrets`
Summary: Simple rename in preparation for upcoming user data sanitization diff
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1427 |
129,184 | 21.06.2021 22:18:39 | 14,400 | 62487814ee3babe099b8f7129c649d17c00d6272 | [native] Fix `thread-visibility` icon color
Summary: Change the `thread-visibility` icon color based on the background color
Test Plan: Looks as expected (https://blob.sh/atul/thread-visibility-icon-color.png)
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-visibility.react.js",
"new_path": "native/components/thread-visibility.react.js",
"diff": "import * as React from 'react';\nimport { View, StyleSheet } from 'react-native';\n+import tinycolor from 'tinycolor2';\nimport { threadLabel } ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix `thread-visibility` icon color
Summary: Change the `thread-visibility` icon color based on the background color
Test Plan: Looks as expected (https://blob.sh/atul/thread-visibility-icon-color.png)
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https... |
129,184 | 21.06.2021 17:26:38 | 14,400 | 6e06ac376c82127819204fa684c38c1210e126fe | [lib] Factor out common functionality from `crash.react` and `report-creator` into `sanitizeReduxReport`
Test Plan: Continues to work as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/sanitization.js",
"new_path": "lib/utils/sanitization.js",
"diff": "@@ -11,6 +11,12 @@ import type {\n} from '../types/redux-types';\nimport { setNewSessionActionType } from './action-utils';\n+export type ReduxCrashReport = {|\n+ +preloadedState: Ap... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Factor out common functionality from `crash.react` and `report-creator` into `sanitizeReduxReport`
Test Plan: Continues to work as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1433 |
129,184 | 21.06.2021 21:22:01 | 14,400 | 136f250d910aacea4d3961e11e0e85995194cf26 | [lib] Introduce `generateColorRedactionFn` and use in `sanitizeNavState` and `sanitizePII`
Test Plan: Triggered a couple of crashes and imported into Redux Dev Tools...the colors changed as expected and were consistent throughout.
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/sanitization.js",
"new_path": "lib/utils/sanitization.js",
"diff": "@@ -17,6 +17,11 @@ export type ReduxCrashReport = {|\n+actions: $ReadOnlyArray<BaseAction>,\n|};\n+export type RedactionHelpers = {|\n+ +redactString: (string) => string,\n+ +redactC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `generateColorRedactionFn` and use in `sanitizeNavState` and `sanitizePII`
Test Plan: Triggered a couple of crashes and imported into Redux Dev Tools...the colors changed as expected and were consistent throughout.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differen... |
129,184 | 22.06.2021 11:53:50 | 14,400 | 67eed3fa1c134a15d850282dfe258b742990cf38 | [lib] Pull out common `...RouteName` redaction functionality from `sanitizePII` and `sanitizeNavState`
Test Plan: Triggered crash from developer menu, imported crash report into Redux dev tools
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/sanitization.js",
"new_path": "lib/utils/sanitization.js",
"diff": "@@ -155,6 +155,22 @@ function sanitizeReduxReport(reduxReport: ReduxCrashReport): ReduxCrashReport {\nconst MessageListRouteName = 'MessageList';\nconst ThreadSettingsRouteName = 'Th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Pull out common `...RouteName` redaction functionality from `sanitizePII` and `sanitizeNavState`
Test Plan: Triggered crash from developer menu, imported crash report into Redux dev tools
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.as... |
129,187 | 23.06.2021 11:23:56 | 14,400 | 8cbc5c0895ec3fe3bc840cd22833b00522a08b8c | Update LICENSE
Reference Comm | [
{
"change_type": "MODIFY",
"old_path": "LICENSE",
"new_path": "LICENSE",
"diff": "-Copyright (c) 2016, Ashoat\n+Copyright (c) 2021, Comm Technologies, Inc.\nAll rights reserved.\nRedistribution and use in source and binary forms, with or without\n@@ -11,7 +11,7 @@ modification, are permitted provide... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update LICENSE
Reference Comm |
129,187 | 22.06.2021 13:49:34 | 14,400 | 6ddf8e4f1977a2082d8ca7e9766f45a24f666fbb | [lib][native][web] Disable logging in with email
Summary: This is part of the [task](https://www.notion.so/commapp/Don-t-take-emails-during-signup-93e41f772b1349f2be8215896c0f31f8) to get rid of emails.
Test Plan: Flow, play around with log in
Reviewers: atul, palys-swm
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "@@ -94,13 +94,14 @@ export type LogInExtraInfo = {|\nexport type LogInInfo = {|\n...LogInExtraInfo,\n- +usernameOrEmail: string,\n+ +username: string,\n+password: string,\n+source?... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib][native][web] Disable logging in with email
Summary: This is part of the [task](https://www.notion.so/commapp/Don-t-take-emails-during-signup-93e41f772b1349f2be8215896c0f31f8) to get rid of emails.
Test Plan: Flow, play around with log in
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: Ka... |
129,187 | 22.06.2021 14:10:41 | 14,400 | 07fd6db60b4159a7a954570beba51784565a2d8c | [native] Get rid of "forgot password" functionality
Summary: Also gets rid of `LogInPanelContainer`, which handled animating between `LogInPanel` and `ForgotPasswordPanel`, and as such is no longer necessary.
Test Plan: Flow, visual inspection
Reviewers: atul, palys-swm
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "DELETE",
"old_path": "native/account/forgot-password-panel.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import invariant from 'invariant';\n-import React from 'react';\n-import { StyleSheet, View, Alert, Keyboard } from 'react-native';\n-import Animated from 'react-native-r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of "forgot password" functionality
Summary: Also gets rid of `LogInPanelContainer`, which handled animating between `LogInPanel` and `ForgotPasswordPanel`, and as such is no longer necessary.
Test Plan: Flow, visual inspection
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: Ka... |
129,187 | 22.06.2021 14:21:59 | 14,400 | 4d7efba01b75291964b3687d17492e57c3834d3f | [web] Get rid of "forgot password" functionality
Test Plan: Flow, visual inspection
Reviewers: palys-swm
Subscribers: KatPo, palys-swm, Adrian, atul | [
{
"change_type": "DELETE",
"old_path": "web/modals/account/forgot-password-modal.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import invariant from 'invariant';\n-import * as React from 'react';\n-\n-import {\n- forgotPasswordActionTypes,\n- forgotPassword,\n-} from 'lib/actions/user-actions... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of "forgot password" functionality
Test Plan: Flow, visual inspection
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1443 |
129,187 | 22.06.2021 14:24:07 | 14,400 | 47241ececafe70aa26637a06d8ef52f459f4e4a7 | [lib] Get rid of forgotPassword
Summary: Since none of the clients use this anymore, we can get rid of the Redux action. (The server endpoint is still there for old clients.)
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -189,17 +189,6 @@ const resetPassword = (fetchJSON: FetchJSON) => async (\n};\n};\n-const forgotPasswordActionTypes = Object.freeze({\n- started: 'FORGOT_PASSWORD_STARTED',\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of forgotPassword
Summary: Since none of the clients use this anymore, we can get rid of the Redux action. (The server endpoint is still there for old clients.)
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https:... |
129,187 | 22.06.2021 15:15:21 | 14,400 | e9ad5a6df6389aeee54e8bd2be9ad77c632e9e36 | [web] Get rid of verification functionality
Summary: This was used for verifying emails and resetting passwords, but since both of those rely on emails (which we're getting rid of), we can remove this code.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/verify-types.js",
"new_path": "lib/types/verify-types.js",
"diff": "@@ -24,9 +24,6 @@ export type HandleVerificationCodeResult = {|\n+resetPasswordUsername?: string,\n|};\n-type FailedVerificationResult = {|\n- +success: false,\n-|};\ntype EmailServe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of verification functionality
Summary: This was used for verifying emails and resetting passwords, but since both of those rely on emails (which we're getting rid of), we can remove this code.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, palys-swm, Adrian
Dif... |
129,187 | 22.06.2021 15:22:41 | 14,400 | 200554f89f3616ae704e90c68b364481ae048d55 | [native] Get rid of verification functionality
Summary: This was used for verifying emails and resetting passwords, but since both of those rely on emails (which we're getting rid of), we can remove this code.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "DELETE",
"old_path": "native/account/verification-modal.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import invariant from 'invariant';\n-import * as React from 'react';\n-import {\n- Image,\n- Text,\n- View,\n- StyleSheet,\n- ActivityIndicator,\n- Platform,\n- Keyboard,\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of verification functionality
Summary: This was used for verifying emails and resetting passwords, but since both of those rely on emails (which we're getting rid of), we can remove this code.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, palys-swm, Adrian
... |
129,187 | 22.06.2021 15:51:16 | 14,400 | 048fd22f43c4a3c5c9bac6e02914d806ff3fa989 | [native] Get rid of native deep linking config
Summary: We're not using this for verifications, and when we reintroduce it we'll want to do it for comm.app instead of squadcal.org anyways.
Test Plan: Make sure iOS and Android still run
Reviewers: atul, palys-swm
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/AndroidManifest.xml",
"new_path": "native/android/app/src/main/AndroidManifest.xml",
"diff": "<action android:name=\"android.intent.action.VIEW\" />\n<category android:name=\"android.intent.category.DEFAULT\" />\n<category android:n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of native deep linking config
Summary: We're not using this for verifications, and when we reintroduce it we'll want to do it for comm.app instead of squadcal.org anyways.
Test Plan: Make sure iOS and Android still run
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, palys-swm... |
129,187 | 22.06.2021 16:23:31 | 14,400 | 9ae6ca07bfb6912b257bbbb0318b09186f9a781a | [native] Get rid of email from profile screen
Test Plan: Flow, visual inspection
Reviewers: atul, palys-swm
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/route-names.js",
"new_path": "native/navigation/route-names.js",
"diff": "@@ -43,7 +43,6 @@ export const CalendarRouteName = 'Calendar';\nexport const BuildInfoRouteName = 'BuildInfo';\nexport const DeleteAccountRouteName = 'DeleteAccount';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of email from profile screen
Test Plan: Flow, visual inspection
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1448 |
129,187 | 23.06.2021 12:36:46 | 14,400 | 2cd378d0d3f5b5bcc53d636723332764efb46c2c | [web] Get rid of email from UserSettingsModal
Test Plan: Visual inspection, Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -9,12 +9,9 @@ import {\ndeleteAccount,\nchangeUserSettingsActionTypes,\nchangeUserSettings,\n- resendVerificationEmailActionTypes,\n- r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of email from UserSettingsModal
Test Plan: Visual inspection, Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1455 |
129,187 | 23.06.2021 12:38:40 | 14,400 | a2a6b8f9818a9d8dfde658c1837a783d63206564 | [lib] Get rid of resendVerificationEmail
Summary: Nothing is using this anymore as the relevant stuff has been removed from both native and web.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -201,17 +201,6 @@ const changeUserSettings = (fetchJSON: FetchJSON) => async (\nreturn { email: accountUpdate.updatedFields.email };\n};\n-const resendVerificationEmailActionT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of resendVerificationEmail
Summary: Nothing is using this anymore as the relevant stuff has been removed from both native and web.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1456 |
129,187 | 23.06.2021 16:03:32 | 14,400 | e387fa019194237b37df6e2c1b0ac90296613e4a | [lib] Split ServerSocketMessage into ServerServerSocketMessage and ClientServerSocketMessage
Summary: We need these to be different because the server will need to support old clients, but the new client code will have updated types.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -7,9 +7,9 @@ import {\nclientRequestSocketTimeout,\n} from '../shared/timeouts';\nimport {\n- type ServerSocketMessage,\n+ type ClientServerSocketMessage,\ntype StateS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Split ServerSocketMessage into ServerServerSocketMessage and ClientServerSocketMessage
Summary: We need these to be different because the server will need to support old clients, but the new client code will have updated types.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: Ka... |
129,187 | 23.06.2021 16:06:26 | 14,400 | ce8051ddcdf5a003684c2b623aa4efe472322dd4 | [lib] Split ServerRequest into ServerServerRequest and ClientServerRequest
Summary: We need these to be different because the server will need to support old clients, but the new client code will have updated types.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/socket-selectors.js",
"new_path": "lib/selectors/socket-selectors.js",
"diff": "@@ -17,7 +17,7 @@ import type {\n} from '../types/report-types';\nimport {\nserverRequestTypes,\n- type ServerRequest,\n+ type ClientServerRequest,\ntype ClientClient... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Split ServerRequest into ServerServerRequest and ClientServerRequest
Summary: We need these to be different because the server will need to support old clients, but the new client code will have updated types.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Diffe... |
129,187 | 23.06.2021 16:18:40 | 14,400 | 183c01aca3985fcb9a393f91ca90f135396d7d18 | [lib] Split StateSyncSocketPayload into ServerStateSyncSocketPayload and ClientStateSyncSocketPayload
Summary: We need these to be different because the server will need to support old clients, but the new client code will have updated types.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -8,7 +8,7 @@ import {\n} from '../shared/timeouts';\nimport {\ntype ClientServerSocketMessage,\n- type StateSyncServerSocketMessage,\n+ type ClientStateSyncServerSocke... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Split StateSyncSocketPayload into ServerStateSyncSocketPayload and ClientStateSyncSocketPayload
Summary: We need these to be different because the server will need to support old clients, but the new client code will have updated types.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscr... |
129,187 | 23.06.2021 16:38:10 | 14,400 | 61c5caf766623e14d8f02acbd89b3c71d9a741bf | [lib] Split UpdatesResult into ServerUpdatesResult and ClientUpdatesResult
Summary: We need these to be different because the server will need to support old clients, but the new client code will have updated types.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -69,7 +69,7 @@ import type {\nNewThreadResult,\nThreadJoinPayload,\n} from './thread-types';\n-import type { UpdatesResultWithUserInfos } from './update-types';\n+import type { Clie... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Split UpdatesResult into ServerUpdatesResult and ClientUpdatesResult
Summary: We need these to be different because the server will need to support old clients, but the new client code will have updated types.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Diffe... |
129,187 | 23.06.2021 16:44:47 | 14,400 | e52ff498338febc63a49ca0f32ef4fc1e6e55db1 | Remove email and emailVerified from CurrentUserInfo
Summary: This was complicated because the server still needs to include these for old clients.
Test Plan: Test with old clients and new clients on the new server
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -74,8 +74,6 @@ const register = (fetchJSON: FetchJSON) => async (\ncurrentUserInfo: {\nid: response.id,\nusername: registerInfo.username,\n- email: registerInfo.email,\n- emai... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove email and emailVerified from CurrentUserInfo
Summary: This was complicated because the server still needs to include these for old clients.
Test Plan: Test with old clients and new clients on the new server
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: ... |
129,187 | 23.06.2021 16:50:32 | 14,400 | aff85c8432a34e699c9e61b5271d20d5ae3b71fb | [native] Reduce spacing between wordmark and user input for short Androids
Summary: The spacing between `LogInPanel` and `RegisterPanel` is too much for short Android screens. This change makes it look more natural.
Test Plan: Visual inspection on Nexus 4 emulator
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/panel-components.react.js",
"new_path": "native/account/panel-components.react.js",
"diff": "@@ -129,7 +129,7 @@ class InnerPanel extends React.PureComponent<PanelProps, PanelState> {\nconst windowHeight = this.props.dimensions.height;\nconst co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reduce spacing between wordmark and user input for short Androids
Summary: The spacing between `LogInPanel` and `RegisterPanel` is too much for short Android screens. This change makes it look more natural.
Test Plan: Visual inspection on Nexus 4 emulator
Reviewers: atul, palys-swm
Reviewed By: palys-swm
... |
129,187 | 23.06.2021 16:52:55 | 14,400 | 0bb11ddce3a52e21cb83693c2d2de5500f3582be | [native] Remove email from RegisterPanel
Summary: This also let me simplify some height logic by making `RegisterPanel` shorter.
Test Plan: Visual inspection on iPhone 5s simulator
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "@@ -36,7 +36,6 @@ export type LogOutResponse = {|\nexport type RegisterInfo = {|\n...LogInExtraInfo,\n+username: string,\n- +email: string,\n+password: string,\n|};\n"
},
{
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove email from RegisterPanel
Summary: This also let me simplify some height logic by making `RegisterPanel` shorter.
Test Plan: Visual inspection on iPhone 5s simulator
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1... |
129,187 | 23.06.2021 17:13:19 | 14,400 | 96c7199b60c98a739351cc528e8b288cb6c6fb89 | [native] Get rid of ResetPasswordPanel
Summary: Forgot to remove this when I removed `VerificationModal`.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "DELETE",
"old_path": "native/account/reset-password-panel.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import invariant from 'invariant';\n-import React from 'react';\n-import {\n- Alert,\n- StyleSheet,\n- Keyboard,\n- View,\n- Text,\n- Platform,\n-} from 'react-native';\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of ResetPasswordPanel
Summary: Forgot to remove this when I removed `VerificationModal`.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1466 |
129,187 | 23.06.2021 17:17:57 | 14,400 | d8dfa820f3b25740820116ee26480579844c8fdb | [lib] Get rid of resetPassword
Summary: No endpoints calling this action so it can be removed now!
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -7,7 +7,6 @@ import type {\nLogInInfo,\nLogInResult,\nRegisterResult,\n- UpdatePasswordInfo,\nRegisterInfo,\nAccessRequest,\n} from '../types/account-types';\n@@ -147,46 +146,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of resetPassword
Summary: No endpoints calling this action so it can be removed now!
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1467 |
129,187 | 23.06.2021 17:22:42 | 14,400 | 28e046d4740fd57fcee20676b4e6e4378546d7e3 | [lib] Get rid of handleVerificationCode
Summary: No endpoints calling this action so it can be removed now!
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -17,7 +17,6 @@ import type {\nSubscriptionUpdateResult,\n} from '../types/subscription-types';\nimport type { UserInfo, AccountUpdate } from '../types/user-types';\n-import ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of handleVerificationCode
Summary: No endpoints calling this action so it can be removed now!
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1468 |
129,187 | 23.06.2021 18:35:06 | 14,400 | 863ff92125f758392c3810b3ea12c358156742f1 | Get rid of ChangeUserSettingsResult
Summary: The only thing that can be changed now is the user's password, and that doesn't go in Redux.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "import threadWatcher from '../shared/thread-watcher';\nimport type {\n- ChangeUserSettingsResult,\nLogOutResult,\nLogInInfo,\nLogInResult,\n@@ -152,9 +151,8 @@ const changeUserSe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of ChangeUserSettingsResult
Summary: The only thing that can be changed now is the user's password, and that doesn't go in Redux.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1469 |
129,187 | 23.06.2021 18:46:57 | 14,400 | c66de2962994135e419241ce1816c2aa6250bb4e | [server] Ignore emails in accountUpdater
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/user-types.js",
"new_path": "lib/types/user-types.js",
"diff": "@@ -59,7 +59,6 @@ export type CurrentUserInfo = LoggedInUserInfo | LoggedOutUserInfo;\nexport type AccountUpdate = {|\n+updatedFields: {|\n- +email?: ?string,\n+password?: ?string,\n|},\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Ignore emails in accountUpdater
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1470 |
129,187 | 23.06.2021 18:52:33 | 14,400 | c6c8193107d66aa65382da910cb486db952d76e6 | [server] Ignore emails in createAccount
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "@@ -45,7 +45,6 @@ type DeviceTokenUpdateRequest = {|\nexport type RegisterRequest = {|\n+username: string,\n- +email: string,\n+password: string,\n+calendarQuery?: ?CalendarQuery,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Ignore emails in createAccount
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1471 |
129,187 | 23.06.2021 18:55:49 | 14,400 | d59f6c64df6966e0285842da5d758fda5d279d4f | [server] Delete code for sending verification emails
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "DELETE",
"old_path": "server/src/emails/verification.js",
"new_path": null,
"diff": "-// @flow\n-\n-import React from 'react';\n-import { Item, Span, A, renderEmail } from 'react-html-email';\n-\n-import { verifyField } from 'lib/types/verify-types';\n-\n-import { createVerificatio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete code for sending verification emails
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1472 |
129,187 | 23.06.2021 19:22:48 | 14,400 | c0cb1786836627dc36f8bf61699efa841f6d0e3c | [server] Deprecate updatePassword
Summary: (This is the endpoint you would previously reach if you press the link in a "reset your password" email.)
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/account-updaters.js",
"new_path": "server/src/updaters/account-updaters.js",
"diff": "@@ -4,27 +4,15 @@ import bcrypt from 'twin-bcrypt';\nimport type {\nResetPasswordRequest,\n- LogInResponse,\nUpdatePasswordRequest,\n} from 'lib/types/acc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Deprecate updatePassword
Summary: (This is the endpoint you would previously reach if you press the link in a "reset your password" email.)
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1473 |
129,187 | 23.06.2021 19:25:52 | 14,400 | fe849cfcfb0378d9648ea385fded2ffa0f39fdc9 | [server] Don't include email/emailVerified fields in logIn response for new clients
Summary: (Otherwise this will be detected as inconsistent and patched later.)
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/user-responders.js",
"new_path": "server/src/responders/user-responders.js",
"diff": "@@ -4,6 +4,7 @@ import invariant from 'invariant';\nimport t from 'tcomb';\nimport bcrypt from 'twin-bcrypt';\n+import { hasMinCodeVersion } from 'lib/s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't include email/emailVerified fields in logIn response for new clients
Summary: (Otherwise this will be detected as inconsistent and patched later.)
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1474 |
129,187 | 23.06.2021 19:27:16 | 14,400 | 550b751170c60ee3bad993e3758bd546a0720c54 | [server] Shown placeholder in place of email field for old clients
Summary: This change will force inconsistency to be detected across all existing clients and should automatically replace their `currentUserInfo` with the placeholder-having version.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/user-fetchers.js",
"new_path": "server/src/fetchers/user-fetchers.js",
"diff": "@@ -205,7 +205,7 @@ async function fetchLoggedInUserInfos(\nuserIDs: $ReadOnlyArray<string>,\n): Promise<Array<OldLoggedInUserInfo | LoggedInUserInfo>> {\nconst... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Shown placeholder in place of email field for old clients
Summary: This change will force inconsistency to be detected across all existing clients and should automatically replace their `currentUserInfo` with the placeholder-having version.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
... |
129,187 | 23.06.2021 19:31:39 | 14,400 | 63bc402d5bd4b151216079aa532a740c5f418477 | [server] Deprecate checkAndSendPasswordResetEmail
Summary: (This is the endpoint you would previously reach if you entered a valid email in the "Forgot password" flow.)
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "DELETE",
"old_path": "server/src/emails/reset-password.js",
"new_path": null,
"diff": "-// @flow\n-\n-import React from 'react';\n-import { Item, Span, A, renderEmail } from 'react-html-email';\n-\n-import { verifyField } from 'lib/types/verify-types';\n-\n-import { createVerificat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Deprecate checkAndSendPasswordResetEmail
Summary: (This is the endpoint you would previously reach if you entered a valid email in the "Forgot password" flow.)
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.co... |
129,187 | 23.06.2021 19:38:05 | 14,400 | 58186b5970d1a8c7039d93f69c93fe0198db18e8 | [server] Deprecate codeVerificationResponder
Summary: (This endpoint would get triggered when you press a verification link in an email.)
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/verification-responders.js",
"new_path": "server/src/responders/verification-responders.js",
"diff": "import t from 'tcomb';\n-import type {\n- CodeVerificationRequest,\n- HandleVerificationCodeResult,\n-} from 'lib/types/verify-types';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Deprecate codeVerificationResponder
Summary: (This endpoint would get triggered when you press a verification link in an email.)
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1477 |
129,187 | 23.06.2021 19:40:11 | 14,400 | 29b05eda49984b274a12c0919af2d65d359df1d3 | [server] Delete code for handling verifications
Summary: We don't need to handle verification links sent in emails anymore.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron/cron.js",
"new_path": "server/src/cron/cron.js",
"diff": "@@ -19,7 +19,6 @@ import {\nimport { deleteInaccessibleThreads } from '../deleters/thread-deleters';\nimport { deleteExpiredUpdates } from '../deleters/update-deleters';\nimport { delete... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete code for handling verifications
Summary: We don't need to handle verification links sent in emails anymore.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1478 |
129,187 | 23.06.2021 20:13:22 | 14,400 | fc9b809cfe99d2cf42ded9b4c242977c1bad2e52 | [web] Get rid of email modals
Summary: (I deleted their uses earlier but I forgot to delete the modals themselves.)
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "DELETE",
"old_path": "web/modals/account/password-reset-email-modal.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import React from 'react';\n-\n-import css from '../../style.css';\n-import Modal from '../modal.react';\n-\n-type Props = {\n- onClose: () => void,\n-};\n-\n-ex... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of email modals
Summary: (I deleted their uses earlier but I forgot to delete the modals themselves.)
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1479 |
129,187 | 23.06.2021 20:16:21 | 14,400 | 98590217b5cd239be065755a8d60d9c068b9f301 | [server] Get rid of email columns in users table
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/account-creator.js",
"new_path": "server/src/creators/account-creator.js",
"diff": "@@ -82,9 +82,9 @@ async function createAccount(\n? request.deviceTokenUpdateRequest.deviceToken\n: viewer.deviceToken;\nconst [id] = await createIDs('users'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Get rid of email columns in users table
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1480 |
129,187 | 23.06.2021 20:18:34 | 14,400 | fd6e26e7ff44a1f24fcbe9d86ec6f0b9e6fa5f3d | [server] Remove verifications table from create-db script
Test Plan: Ran the query
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-db.js",
"new_path": "server/src/scripts/create-db.js",
"diff": "@@ -204,14 +204,6 @@ async function createTables() {\nstatus tinyint(1) UNSIGNED NOT NULL\n) ENGINE=InnoDB DEFAULT CHARSET=latin1;\n- CREATE TABLE verifications (\n- id b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Remove verifications table from create-db script
Test Plan: Ran the query
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1481 |
129,187 | 23.06.2021 20:19:01 | 14,400 | cb9b588445bf0cc5fdc873f1f6d5699d247b84f8 | [server] Migration to delete verifications table and email columns in users table
Test Plan: Ran the queries
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/delete-emails.js",
"diff": "+// @flow\n+\n+import { dbQuery, SQL } from '../database/database';\n+import { setScriptContext } from './script-context';\n+import { main } from './utils';\n+\n+setScriptContext({\n+ allowMultiStat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Migration to delete verifications table and email columns in users table
Test Plan: Ran the queries
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1482 |
129,187 | 23.06.2021 20:19:35 | 14,400 | f02a321753de84232e6cd8ceec870259f2a10987 | [web] Rename usernameOrEmail to username in LogInModal
Summary: I removed the email logic in D1441 but forgot to rename the property.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-modal.react.js",
"new_path": "web/modals/account/log-in-modal.react.js",
"diff": "@@ -34,26 +34,26 @@ type Props = {|\n+logIn: (logInInfo: LogInInfo) => Promise<LogInResult>,\n|};\ntype State = {|\n- +usernameOrEmail: string,\n+ +user... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename usernameOrEmail to username in LogInModal
Summary: I removed the email logic in D1441 but forgot to rename the property.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1483 |
129,187 | 23.06.2021 20:20:26 | 14,400 | 7e60665ec67863a8ee53024dc250ac1a82dbb904 | [server] Update merge-users script to not handle emails
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/merge-users.js",
"new_path": "server/src/scripts/merge-users.js",
"diff": "@@ -28,7 +28,6 @@ async function main() {\ntype ReplaceUserInfo = Shape<{|\n+username: boolean,\n- +email: boolean,\n+password: boolean,\n|}>;\nasync function mergeUs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update merge-users script to not handle emails
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1484 |
129,187 | 23.06.2021 20:20:50 | 14,400 | 35400bef5ecf857739ed19b177c4466981f2f3bf | Remaining emails-related cleanup
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/verify-types.js",
"new_path": "lib/types/verify-types.js",
"diff": "// @flow\n-import invariant from 'invariant';\n-\nexport const verifyField = Object.freeze({\nEMAIL: 0,\nRESET_PASSWORD: 1,\n});\nexport type VerifyField = $Values<typeof verifyField... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remaining emails-related cleanup
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1485 |
129,187 | 24.06.2021 12:01:52 | 14,400 | 1ac2ea564a167ad94e482b9c7cc76c87964aafe4 | [lib] Convert report, request, and update types to $ReadOnly
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/report-types.js",
"new_path": "lib/types/report-types.js",
"diff": "@@ -38,70 +38,70 @@ export type FlatErrorData = {|\n|};\nexport type ActionSummary = {|\n- type: $PropertyType<BaseAction, 'type'>,\n- time: number,\n- summary: string,\n+ +type: $Pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert report, request, and update types to $ReadOnly
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1488 |
129,187 | 24.06.2021 12:36:26 | 14,400 | a798da0c7196a9e137b9d2dfdd9896fff7276ea7 | [server] Use more explanatory var name for deciding when to use OldCurrentUserInfo
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/user-fetchers.js",
"new_path": "server/src/fetchers/user-fetchers.js",
"diff": "@@ -193,8 +193,11 @@ async function fetchCurrentUserInfo(\nthrow new ServerError('unknown_error');\n}\nconst currentUserInfo = currentUserInfos[0];\n- const has... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use more explanatory var name for deciding when to use OldCurrentUserInfo
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1490 |
129,184 | 23.06.2021 15:26:04 | 14,400 | 3b2d37b14c06e19ee61f6273ad97c4df70d08a00 | [redux] Add `enabledReports` to redux
Summary: Add `enabledReports` to redux so we don't have separate entries for `crashReportsEnabled`, `inconsistencyReportsEnabled`, etc
Test Plan: Tested with upcoming commit that replaces `crashReportsEnabled` where it is currently being used.
Reviewers: ashoat
Subscribers: KatPo, ... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/reducers/enabled-reports-reducer.js",
"diff": "+// @flow\n+\n+import type { EnabledReports } from '../types/enabled-reports';\n+import type { BaseAction } from '../types/redux-types';\n+\n+export const updateReportsEnabledActionType = 'UPDAT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [redux] Add `enabledReports` to redux
Summary: Add `enabledReports` to redux so we don't have separate entries for `crashReportsEnabled`, `inconsistencyReportsEnabled`, etc
Test Plan: Tested with upcoming commit that replaces `crashReportsEnabled` where it is currently being used.
Reviewers: ashoat
Reviewed By: ash... |
129,184 | 23.06.2021 15:59:42 | 14,400 | cc67ab5442a96c64fa937e98ee837a8f9edd7e3c | [redux] Remove `crashReportsEnabled`, replace with `enabledReports.crashReports`
Summary: Replace usage of `crashReportsEnabled` with `enabledReports.crashReports`
Test Plan: Tried existing `toggle-crash-reports` screen and ensured that it continued to work as expected via redux dev tools
Reviewers: ashoat
Subscribers:... | [
{
"change_type": "DELETE",
"old_path": "lib/reducers/crash-reports-enabled-reducer.js",
"new_path": null,
"diff": "-// @flow\n-\n-import type { BaseAction } from '../types/redux-types';\n-\n-export const updateCrashReportsEnabledActionType =\n- 'UPDATE_CRASH_REPORTS_ENABLED';\n-\n-export default fun... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [redux] Remove `crashReportsEnabled`, replace with `enabledReports.crashReports`
Summary: Replace usage of `crashReportsEnabled` with `enabledReports.crashReports`
Test Plan: Tried existing `toggle-crash-reports` screen and ensured that it continued to work as expected via redux dev tools
Reviewers: ashoat
Reviewed... |
129,184 | 23.06.2021 16:27:48 | 14,400 | 34ff7ce455f42b4fdb96dec33964c1b0edcf5dfa | [lib][native] Introduce hook to check whether specified report type is enabled
Summary: Replace `useIsCrashReportingEnabled` with `useIsReportEnabled(reportType: SupportedReports)` to determine whether particular report type is enabled.
Test Plan: Checked via redux dev tools that `toggle-crash-reports` component contin... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/utils/report-utils.js",
"diff": "+// @flow\n+\n+import { type SupportedReports } from '../types/enabled-reports';\n+import { useSelector } from './redux-utils';\n+\n+function useIsReportEnabled(reportType: SupportedReports): boolean {\n+ ret... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib][native] Introduce hook to check whether specified report type is enabled
Summary: Replace `useIsCrashReportingEnabled` with `useIsReportEnabled(reportType: SupportedReports)` to determine whether particular report type is enabled.
Test Plan: Checked via redux dev tools that `toggle-crash-reports` component cont... |
129,187 | 24.06.2021 15:23:57 | 14,400 | 98a9847c665b9ba881c7e57bb6cc6f2db0e948ea | [server] Make usernameOrEmail optional in log in input validator
Summary: I accidentally took the `t.maybe` out in D1485.
Test Plan: Make sure log in works again
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/user-responders.js",
"new_path": "server/src/responders/user-responders.js",
"diff": "@@ -177,7 +177,7 @@ async function accountCreationResponder(\nconst logInRequestInputValidator = tShape({\nusername: t.maybe(t.String),\n- usernameOrEma... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Make usernameOrEmail optional in log in input validator
Summary: I accidentally took the `t.maybe` out in D1485.
Test Plan: Make sure log in works again
Reviewers: palys-swm, atul
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1494 |
129,184 | 24.06.2021 16:00:52 | 14,400 | c00ebedc3aee097edd5ef98f22aa8dd12325f65a | [fix] Decrement redux version 27 -> 26
Summary: Merged `enabledReports` migration with the previous migration but missed decrementing redux version before landing.
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -250,7 +250,7 @@ const persistConfig = {\n'frozen',\n],\ndebug: __DEV__,\n- version: 27,\n+ version: 26,\nmigrate: createMigrate(migrations, { debug: __DEV__ }),\ntimeout: __DEV__ ? 0... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] Decrement redux version 27 -> 26
Summary: Merged `enabledReports` migration with the previous migration but missed decrementing redux version before landing.
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1495 |
129,184 | 24.06.2021 12:32:56 | 14,400 | 9ac8873d06524b3863091f02dad440d8c585873f | [native] Add report opt-in toggles to `privacy-preferences`
Summary: Here's how it looks:
Test Plan: Verified expected behavior with Redux dev tools
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/profile/privacy-preferences.react.js",
"new_path": "native/profile/privacy-preferences.react.js",
"diff": "@@ -4,7 +4,7 @@ import * as React from 'react';\nimport { View, Text, ScrollView } from 'react-native';\nimport { useStyles } from '../themes/colo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add report opt-in toggles to `privacy-preferences`
Summary: Here's how it looks: https://blob.sh/atul/privacy-preferences-screen.png
Test Plan: Verified expected behavior with Redux dev tools
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabri... |
129,187 | 25.06.2021 10:57:24 | 14,400 | 95a2d238c74b857c3b72796b13b9ac7ee7327760 | [server] Rename squadbot to commbot
Summary: This diff is just simple renames
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/bots.json",
"new_path": "lib/facts/bots.json",
"diff": "{\n- \"squadbot\": {\n+ \"commbot\": {\n\"userID\": \"5\",\n\"staffThreadID\": \"83794\"\n}\n"
},
{
"change_type": "RENAME",
"old_path": "server/src/bots/squadbot.js",
"new_path"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rename squadbot to commbot
Summary: This diff is just simple renames
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1500 |
129,184 | 25.06.2021 12:21:37 | 14,400 | 67c0950df61537151d838036b43ec65f003f060c | [eslint] Remove `*.cjs` from `lintstaged`
Summary: na
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": ".lintstagedrc.js",
"new_path": ".lintstagedrc.js",
"diff": "@@ -3,7 +3,7 @@ const { CLIEngine } = require('eslint');\nconst cli = new CLIEngine({});\nmodule.exports = {\n- '*.{js,mjs,cjs}': function eslint(files) {\n+ '*.{js,mjs}': function eslint(files) {\nre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [eslint] Remove `*.cjs` from `lintstaged`
Summary: na
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1501 |
129,184 | 25.06.2021 12:34:56 | 14,400 | cb386f9f032f86b3faecdd10c22dd0228af2d426 | [server] `dev` -> `development`
Summary: Renamed `NODE_ENV` from `dev` -> `development` to keep it consistent across lib/web/server/native
Test Plan: `console.log`ged before conditionals involving `NODE_ENV` and made sure value matched up with expectation
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/webpack/shared.cjs",
"new_path": "lib/webpack/shared.cjs",
"diff": "@@ -162,7 +162,7 @@ function createDevBrowserConfig(baseConfig, babelConfig) {\n...browserConfig.plugins,\nnew webpack.DefinePlugin({\n'process.env': {\n- NODE_ENV: JSON.stringify('dev'),\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] `dev` -> `development`
Summary: Renamed `NODE_ENV` from `dev` -> `development` to keep it consistent across lib/web/server/native
Test Plan: `console.log`ged before conditionals involving `NODE_ENV` and made sure value matched up with expectation
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, p... |
129,184 | 25.06.2021 12:37:06 | 14,400 | b7b7ae58a6e177fc7c694241f92ce229ec648224 | [web][lib] Add `process` to `.eslint:global`
Summary: na
Test Plan: no more `eslint` issues
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/.eslintrc.json",
"new_path": "lib/.eslintrc.json",
"diff": "{\n\"env\": {\n\"browser\": true\n+ },\n+ \"globals\": {\n+ \"process\": true\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/.eslintrc.json",
"new_path": "web/.eslintrc.js... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web][lib] Add `process` to `.eslint:global`
Summary: na
Test Plan: no more `eslint` issues
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1503 |
129,184 | 24.06.2021 14:38:09 | 14,400 | 6d265f29932113710e18b80c1ccd628b20a57a86 | [lib] Reset `enabledReports` on logout/account deletion/session invalidation
Summary: For non-dev/staff, disable all reports on logout/account deletion/session invalidation. For dev/staff, enable all reports on login
Test Plan: Logged in/out and checked redux dev tools to verify state changed as expected
Reviewers: ash... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/enabled-reports-reducer.js",
"new_path": "lib/reducers/enabled-reports-reducer.js",
"diff": "// @flow\n-import type { EnabledReports } from '../types/enabled-reports';\n+import {\n+ logOutActionTypes,\n+ deleteAccountActionTypes,\n+ logInActionTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Reset `enabledReports` on logout/account deletion/session invalidation
Summary: For non-dev/staff, disable all reports on logout/account deletion/session invalidation. For dev/staff, enable all reports on login
Test Plan: Logged in/out and checked redux dev tools to verify state changed as expected
Reviewers: ... |
129,190 | 28.06.2021 08:50:49 | -7,200 | 0be689e0d7e83665f4af6712c0582aa3064f8c6c | [native] Add removeAllDrafts
Summary: Add `removeAllDrafts` functionality to comm core module, so we can clear the drafts.
Test Plan: call `removeAllDrafts` and see if they've been cleaned up or not.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -20,6 +20,7 @@ public:\nvirtual void updateDraft(std::string key, std::string text) const = 0;\nvirtual boo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add removeAllDrafts
Summary: Add `removeAllDrafts` functionality to comm core module, so we can clear the drafts.
Test Plan: call `removeAllDrafts` and see if they've been cleaned up or not.
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential ... |
129,191 | 11.06.2021 11:32:07 | -7,200 | f5045ed507d86b67475042ba3146ebe1feb5870a | [native] Create chat context interface
Summary: Create an interface with one function which measures messages heights and returns a promise with the result
Test Plan: Tested with other diffs
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/chat-context.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import type { ChatMessageItem } from 'lib/selectors/chat-selectors';\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+\n+import type { ChatMe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create chat context interface
Summary: Create an interface with one function which measures messages heights and returns a promise with the result
Test Plan: Tested with other diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.co... |
129,191 | 11.06.2021 12:21:23 | -7,200 | b5d54e09f81f55bd952c879e12b4c6690fa588fe | [native] Create chat context
Summary: Created an empty context which currently doesn't do anything useful
Test Plan: Tested with other diffs
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/chat-context-provider.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import type { ChatMessageItem } from 'lib/selectors/chat-selectors';\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+\n+impor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create chat context
Summary: Created an empty context which currently doesn't do anything useful
Test Plan: Tested with other diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1401 |
129,191 | 21.06.2021 13:58:30 | -7,200 | baf29d85c44de621797074df17f69e5b89f69d83 | [native] Create ChatItemHeightMeasurer
Summary: Create a new component based on comment
Test Plan: Tested with D1403
Reviewers: ashoat
Subscribers: atul, Adrian, KatPo | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-context-provider.react.js",
"new_path": "native/chat/chat-context-provider.react.js",
"diff": "@@ -15,6 +15,15 @@ type Props = {|\n...BaseProps,\n|};\n+export type MeasurementTask = {|\n+ +messages: $ReadOnlyArray<ChatMessageItem>,\n+ +threadI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create ChatItemHeightMeasurer
Summary: Create a new component based on https://phabricator.ashoat.com/D1403#inline-7568 comment
Test Plan: Tested with D1403
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: atul, Adrian, KatPo
Differential Revision: https://phabricator.ashoat.com/D1431 |
129,191 | 11.06.2021 18:32:14 | -7,200 | b56af81e0773438016651b86235e279b2f844884 | [native] Use chat context provider
Summary: Wrap chat navigator with the new container. At this point it shouldn't have any visible impact.
Test Plan: Tested with other diffs.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/root.react.js",
"new_path": "native/root.react.js",
"diff": "@@ -18,6 +18,7 @@ import { PersistGate } from 'redux-persist/integration/react';\nimport { actionLogger } from 'lib/utils/action-logger';\n+import ChatContextProvider from './chat/chat-context... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use chat context provider
Summary: Wrap chat navigator with the new container. At this point it shouldn't have any visible impact.
Test Plan: Tested with other diffs.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1404 |
129,191 | 11.06.2021 14:47:40 | -7,200 | 1b34f7d8a9971446be2e16457b0c1650df5c724f | [native] Create height measurer hook
Summary: Introduce a new hook which checks if message list or threadInfo change, schedules a new measurement task when they do, and returns a promise with the result.
Test Plan: Tested with other diffs.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-context.js",
"new_path": "native/chat/chat-context.js",
"diff": "// @flow\n+import invariant from 'invariant';\nimport * as React from 'react';\nimport type { ChatMessageItem } from 'lib/selectors/chat-selectors';\n@@ -21,4 +22,19 @@ export ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create height measurer hook
Summary: Introduce a new hook which checks if message list or threadInfo change, schedules a new measurement task when they do, and returns a promise with the result.
Test Plan: Tested with other diffs.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Dif... |
129,191 | 15.06.2021 12:47:21 | -7,200 | 03e9e4c99b50d4db29e2d46ffe75f06a22c821fe | [native] Use MessageListContextProvider
Summary: Replace all the usages of `useMessageListContext` with `MessageListContextProvider` component
Test Plan: Check if messages list with text messages is rendered correctly. Open a tooltip with text message and check if it is correct.
Reviewers: ashoat
Subscribers: KatPo, Ad... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -30,10 +30,7 @@ import { type MessagesMeasurer, useHeightMeasurer } from './chat-context';\nimport ChatInputBar from './chat-input-bar.react';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use MessageListContextProvider
Summary: Replace all the usages of `useMessageListContext` with `MessageListContextProvider` component
Test Plan: Check if messages list with text messages is rendered correctly. Open a tooltip with text message and check if it is correct.
Reviewers: ashoat
Reviewed By: ashoa... |
129,191 | 10.06.2021 13:37:07 | -7,200 | e3386bcc8a7f77bf5c406370b8a9b6294cb1a5cd | [native] Merge sidebar navigation functions
Summary: The functions are now the same so it makes sense to merge them together.
Test Plan: Test for multimedia, text and robotext messages: open pending sidebar, create it, reopen and check if everything is correct.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-tooltip-modal.react.js",
"new_path": "native/chat/multimedia-tooltip-modal.react.js",
"diff": "@@ -11,7 +11,7 @@ import {\n} from '../navigation/tooltip.react';\nimport type { ChatMultimediaMessageInfoItem } from './multimedia-message.re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Merge sidebar navigation functions
Summary: The functions are now the same so it makes sense to merge them together.
Test Plan: Test for multimedia, text and robotext messages: open pending sidebar, create it, reopen and check if everything is correct.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Ka... |
129,187 | 28.06.2021 14:49:48 | 14,400 | 6907ab31fe8ea71b727b68f0d51085dac16a1c3a | [native] Add ParentThreadHeader to MessageListContainer while searching
Summary: [Here's what](https://www.dropbox.com/s/9ocbhj39ub2j9na/Screen%20Recording%202021-06-28%20at%202.51.02%20PM.mov?dl=0) it looks like.
Test Plan: Play around with it
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -4,16 +4,21 @@ import invariant from 'invariant';\nimport * as React from 'react';\nimport { View } from 'react-native';\n+import genesis from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add ParentThreadHeader to MessageListContainer while searching
Summary: [Here's what](https://www.dropbox.com/s/9ocbhj39ub2j9na/Screen%20Recording%202021-06-28%20at%202.51.02%20PM.mov?dl=0) it looks like.
Test Plan: Play around with it
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: K... |
129,187 | 28.06.2021 15:21:31 | 14,400 | 3d5ff8786b4e44b48e3d16f1b57b2ff1e1032ca6 | [native] Introduce ThreadPill component
Summary: Figured it would be good to factor this out so we only need to edit one place when we want to change it.
Test Plan: Test the various places it's used
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-child-thread.react.js",
"new_path": "native/chat/settings/thread-settings-child-thread.react.js",
"diff": "@@ -6,8 +6,8 @@ import { View, Platform } from 'react-native';\nimport type { ThreadInfo } from 'lib/types/thread-ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce ThreadPill component
Summary: Figured it would be good to factor this out so we only need to edit one place when we want to change it.
Test Plan: Test the various places it's used
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://p... |
129,187 | 28.06.2021 15:37:39 | 14,400 | cd335202d5cd5fc69526f7635aa8bb2a65100706 | [native] Introduce CommunityPill component
Summary: I want to use this inside `ParentThreadHeader` too so I'm factoring it out.
Test Plan: Make sure `ThreadAncestors` still looks correct
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/components/community-pill.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { View, StyleSheet } from 'react-native';\n+import Icon from 'react-native-vector-icons/FontAwesome5';\n+\n+import { memberHasAdminPower... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce CommunityPill component
Summary: I want to use this inside `ParentThreadHeader` too so I'm factoring it out.
Test Plan: Make sure `ThreadAncestors` still looks correct
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.a... |
129,187 | 28.06.2021 15:41:41 | 14,400 | 91bb833ddc600f0da9932dab0c72f7bd1bb10492 | [native] Use CommunityPill in ParentThreadHeader
Summary: Trying to make the UI more consistent, and make it more discoverable that the parent thread is pressable (implemented in next diff).
Test Plan: Make sure it looks good
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/parent-thread-header.react.js",
"new_path": "native/chat/parent-thread-header.react.js",
"diff": "@@ -5,7 +5,7 @@ import { View, Text } from 'react-native';\nimport type { ThreadInfo, ThreadType } from 'lib/types/thread-types';\n-import { SingleLin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use CommunityPill in ParentThreadHeader
Summary: Trying to make the UI more consistent, and make it more discoverable that the parent thread is pressable (implemented in next diff).
Test Plan: Make sure it looks good
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, Adrian
Diffe... |
129,187 | 28.06.2021 15:55:09 | 14,400 | 750be11fd260c5848957d929701c897441a1131b | [native] Convert ThreadSettingsParent to a function component
Summary: The single callback in this file is about to be factored out into a Hook, so I figured it would be cleaner to make `ThreadSettingsParent` a function component now.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-parent.react.js",
"new_path": "native/chat/settings/thread-settings-parent.react.js",
"diff": "@@ -12,32 +12,35 @@ import { MessageListRouteName } from '../../navigation/route-names';\nimport { useStyles } from '../../theme... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert ThreadSettingsParent to a function component
Summary: The single callback in this file is about to be factored out into a Hook, so I figured it would be cleaner to make `ThreadSettingsParent` a function component now.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscrib... |
129,187 | 28.06.2021 16:07:17 | 14,400 | 8b9e13a137da2ed303733002614ee9a1fc93b9bf | [native] Make React Navigation navigate function param $ReadOnly
Summary: I'll want to PR this up on `flow-typed` as well
Test Plan: Flow, tested in combination with next diff
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -786,13 +786,13 @@ declare module '@react-navigation/bottom-tabs' {\n& <DestinationRouteName: $Keys<ParamLi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make React Navigation navigate function param $ReadOnly
Summary: I'll want to PR this up on `flow-typed` as well
Test Plan: Flow, tested in combination with next diff
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D... |
129,187 | 28.06.2021 16:43:06 | 14,400 | 0b0acdbff946e9f57a847e101d22a6607e102cfb | [native] Factor out useNavigateToThread
Summary: We currently repeat the logic for constructing the key of a `MessageListRouteName` route in many places. This diff makes it so we only define it in one place.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -53,6 +53,10 @@ import { dateString } from 'lib/utils/date-utils';\nimport { ServerError } from 'lib/utils/errors';\nimport sleep from 'lib/utils/sleep';\n+import {\n+ t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Factor out useNavigateToThread
Summary: We currently repeat the logic for constructing the key of a `MessageListRouteName` route in many places. This diff makes it so we only define it in one place.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, Adrian
Differe... |
129,187 | 28.06.2021 16:45:11 | 14,400 | 642554534e5a88e27306cc20d362324184670fa2 | [native] Use PRIVATE instead of LOCAL for empty pending thread
Summary: This gets ignored / overwritten anyways, but I figured it's better to be consistent / correct.
Test Plan: Make sure pending thread `searching` state still works
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -552,7 +552,7 @@ class ChatThreadList extends React.PureComponent<Props, State> {\n}\nconst threadInfo = createPendingThread({\nviewerID: this.props.viewer... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use PRIVATE instead of LOCAL for empty pending thread
Summary: This gets ignored / overwritten anyways, but I figured it's better to be consistent / correct.
Test Plan: Make sure pending thread `searching` state still works
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Diff... |
129,187 | 28.06.2021 16:49:36 | 14,400 | 338dab186a8460aae4fb7c96445e96fd417dae71 | [native] Make ParentThreadHeader pressable
Test Plan: Press it
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/parent-thread-header.react.js",
"new_path": "native/chat/parent-thread-header.react.js",
"diff": "@@ -5,9 +5,11 @@ import { View, Text } from 'react-native';\nimport type { ThreadInfo, ThreadType } from 'lib/types/thread-types';\n+import Button fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make ParentThreadHeader pressable
Test Plan: Press it
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1527 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.