author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 28.06.2021 17:10:50 | 14,400 | 5452472eb96eb54f76f7a73b0c179aea767aade7 | [native] Make ParentThreadHeader horizontally scrollable
Test Plan: Play around with it
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/parent-thread-header.react.js",
"new_path": "native/chat/parent-thread-header.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { View, Text } from 'react-native';\n+import { View, Text, ScrollView } from 'react-native';\nimpor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make ParentThreadHeader horizontally scrollable
Test Plan: Play around with it
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1528 |
129,184 | 28.06.2021 13:13:39 | 14,400 | c0dd5b067a1bba85513cb69b6d0cd5e9d40668ea | [lib] Introduce `ReportStore` type and move `EnabledReports` to `report-types.js`
Summary: Move types/constants and fixed paths in preparation for subsequent diffs
Test Plan: Nothing changed functionally
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/enabled-reports-reducer.js",
"new_path": "lib/reducers/enabled-reports-reducer.js",
"diff": "@@ -6,12 +6,12 @@ import {\nlogInActionTypes,\n} from '../actions/user-actions';\nimport { isStaff } from '../shared/user-utils';\n+import type { BaseActi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `ReportStore` type and move `EnabledReports` to `report-types.js`
Summary: Move types/constants and fixed paths in preparation for subsequent diffs
Test Plan: Nothing changed functionally
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://pha... |
129,184 | 28.06.2021 13:42:46 | 14,400 | 3a9c7dad0e3d05a0174dd0809f919943ab006a90 | [lib] Include `enabledReports` in newly-created `reportStore` and rename `enabledReportsReducer` to `reportStoreReducer`
Summary: refactor
Test Plan: Toggled various reporting settings on/off in `privacy-preferences` and checked in redux dev tools that state was/changed as expected
Reviewers: ashoat
Subscribers: KatPo,... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/master-reducer.js",
"diff": "@@ -11,7 +11,6 @@ import reduceCalendarFilters from './calendar-filters-reducer';\nimport reduceConnectionInfo from './connection-reducer';\nimport reduceDataLoaded from '.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include `enabledReports` in newly-created `reportStore` and rename `enabledReportsReducer` to `reportStoreReducer`
Summary: refactor
Test Plan: Toggled various reporting settings on/off in `privacy-preferences` and checked in redux dev tools that state was/changed as expected
Reviewers: ashoat
Reviewed By: as... |
129,184 | 28.06.2021 14:52:44 | 14,400 | 34032f19e444f0bbd34802c095a3e8d07adf454f | [lib] Replace `state.queuedReports` with `state.reportStore.queuedReports`
Test Plan: Sent media reports and they continued to work as before. But instead of queuing/removing reports from `state.queuedReports`, they were queued/removed from `state.reportStore.queuedReports`
Reviewers: ashoat
Subscribers: KatPo, palys-s... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/master-reducer.js",
"diff": "@@ -17,7 +17,6 @@ import { reduceLoadingStatuses } from './loading-reducer';\nimport reduceNextLocalID from './local-id-reducer';\nimport { reduceMessageStore } from './mes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Replace `state.queuedReports` with `state.reportStore.queuedReports`
Test Plan: Sent media reports and they continued to work as before. But instead of queuing/removing reports from `state.queuedReports`, they were queued/removed from `state.reportStore.queuedReports`
Reviewers: ashoat
Reviewed By: ashoat
Sub... |
129,184 | 28.06.2021 19:53:57 | 14,400 | 4724f81b47b3fb55a8f7e33a6b1885f00428213e | [lib] Move entry/thread inconsistency reports to `state.reportStore.queuedReports`
Summary: Move entry/thread inconsistency reports to `state.reportStore.queuedReports`
Test Plan: Going to test after diff that filters out media reports from `reportStoreReduder`
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -24,10 +24,6 @@ import {\nfetchRevisionsForEntryActionTypes,\nrestoreEntryActionTypes,\n} from '../actions/entry-actions';\n-import {\n- sendReportActionTypes,\n- sendRepo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Move entry/thread inconsistency reports to `state.reportStore.queuedReports`
Summary: Move entry/thread inconsistency reports to `state.reportStore.queuedReports`
Test Plan: Going to test after diff that filters out media reports from `reportStoreReduder`
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Ka... |
129,184 | 28.06.2021 20:57:39 | 14,400 | 55fb8193983550ebe504eb6ac38709ec9642eb9f | [native] Migrate any existing reports to `state.reportStore.queuedReports`
Test Plan: didn't test, didn't think it was possible to go back to 26 and "redo" the migration
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -240,13 +240,25 @@ const migrations = {\n...state,\nqueuedReports: undefined,\nenabledReports: undefined,\n+ threadStore: {\n+ ...state.threadStore,\n+ inconsistencyReports: undefined... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Migrate any existing reports to `state.reportStore.queuedReports`
Test Plan: didn't test, didn't think it was possible to go back to 26 and "redo" the migration
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1516 |
129,184 | 29.06.2021 14:21:19 | 14,400 | e998f6b57351b4d886877d2c25b931c5af02f7c6 | [native] Add unread "dot" indicator to `sidebar-item`
Summary:
Here's what it looks like:
With alignment guides overlaid:
Test Plan: Marked sidebars as read/unread and observed the unread dot appear/disappear
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -12,6 +12,7 @@ import Button from '../components/button.react';\nimport ColorSplotch from '../components/color-splotch.react';\nimport { SingleLi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add unread "dot" indicator to `sidebar-item`
Summary:
Here's what it looks like: https://blob.sh/atul/unread-dot-sidebar.png
With alignment guides overlaid: https://blob.sh/atul/f497.png
Test Plan: Marked sidebars as read/unread and observed the unread dot appear/disappear
Reviewers: ashoat
Reviewed By: as... |
129,184 | 28.06.2021 20:40:55 | 14,400 | 13d11b9a7537145644223f6f570088c3dfdb579f | [lib] Conditionally add reports to `reportStore.queuedReports` based on `state.reportStore.enabledReports`
Test Plan: Toggled media reports on and off and observed whether media reports were sent in staff thread when multimedia message sent/save button pressed in `ImageModal`
Reviewers: ashoat
Subscribers: KatPo, palys... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/report-store-reducer.js",
"new_path": "lib/reducers/report-store-reducer.js",
"diff": "@@ -20,6 +20,7 @@ import {\n} from '../types/report-types';\nimport { setNewSessionActionType } from '../utils/action-utils';\nimport { isDev } from '../utils/d... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Conditionally add reports to `reportStore.queuedReports` based on `state.reportStore.enabledReports`
Test Plan: Toggled media reports on and off and observed whether media reports were sent in staff thread when multimedia message sent/save button pressed in `ImageModal`
Reviewers: ashoat
Reviewed By: ashoat
S... |
129,187 | 29.06.2021 18:57:31 | 14,400 | d5cf12f165de0ad192a6bf6b941d5a36293f628d | [native] Get rid of Shared Web Credentials on iOS
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/native-credentials.js",
"new_path": "native/account/native-credentials.js",
"diff": "import { Platform } from 'react-native';\nimport {\ngetInternetCredentials,\n- requestSharedWebCredentials,\nsetInternetCredentials,\n- setSharedWebCredentials,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of Shared Web Credentials on iOS
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1535 |
129,187 | 29.06.2021 18:58:23 | 14,400 | 31f0b444748f2acf84da93d6b76e47beca0fe92c | [native] Move iOS to app.comm bundle identifier
Test Plan: We'll test after landing!
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "ORGANIZATIONNAME = SquadCal;\nTargetAttributes = {\n13B07F861A680F5B00A75B9A = {\n- DevelopmentTeam = 6BF4H9TU5U;\n+ DevelopmentTeam = H98Y8MH53M;\nLa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move iOS to app.comm bundle identifier
Test Plan: We'll test after landing!
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1536 |
129,187 | 29.06.2021 19:02:17 | 14,400 | ddb4202c4ac92f4664eeb3565a4e53cad39bc33c | [native] Use Comm ORGANIZATIONNAME for iOS
Test Plan: Meh
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "isa = PBXProject;\nattributes = {\nLastUpgradeCheck = 1150;\n- ORGANIZATIONNAME = SquadCal;\n+ ORGANIZATIONNAME = \"Comm Technologies, Inc.\";\nTarget... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use Comm ORGANIZATIONNAME for iOS
Test Plan: Meh
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1537 |
129,184 | 30.06.2021 09:10:45 | 14,400 | 92d9bd84cfed3d9782b5a7297703ecc2c03ba30d | [landing] Create placeholder `privacy` and `terms of service` components and navigate between them using `activePage` state
Test Plan: Was able to navigate between the components as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/home.react.js",
"diff": "+// @flow\n+\n+import { create } from '@lottiefiles/lottie-interactivity';\n+import * as React from 'react';\n+\n+import css from './landing.css';\n+import ReadDocsButton from './read-docs-btn.react';\n+import St... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Create placeholder `privacy` and `terms of service` components and navigate between them using `activePage` state
Test Plan: Was able to navigate between the components as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoa... |
129,184 | 30.06.2021 09:36:15 | 14,400 | 07ef1a14d693dc87c060eb1e8d21b7c2bc00cb90 | [landing] Use sans-serif font for legal headers
Summary: Figured sans-serif headers would be better than monospace for the legal pages
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -18,6 +18,14 @@ h1.title {\ngrid-area: title_container;\n}\n+h1.legal {\n+ font-family: 'IBM Plex Sans', sans-serif;\n+}\n+\n+h2.legal {\n+ font-family: 'IBM Plex Sans', sans-serif;\n+}\n+\nh... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Use sans-serif font for legal headers
Summary: Figured sans-serif headers would be better than monospace for the legal pages
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1546 |
129,184 | 30.06.2021 10:41:49 | 14,400 | 9da6a601e60a9ced831d0de971f1fabfbb065927 | [landing] Pull footer out into its own css grid
Summary: Pull footer out of the main CSS grid and into `footerGrid`
Test Plan: Continues to look as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/home.react.js",
"new_path": "landing/home.react.js",
"diff": "@@ -6,7 +6,6 @@ import * as React from 'react';\nimport css from './landing.css';\nimport ReadDocsButton from './read-docs-btn.react';\nimport StarBackground from './star-background.react';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Pull footer out into its own css grid
Summary: Pull footer out of the main CSS grid and into `footerGrid`
Test Plan: Continues to look as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1548 |
129,184 | 30.06.2021 13:27:44 | 14,400 | c98a625da8aa9bd7409f2f0058b94079a24dba86 | [landing] Style footer and fade on link hover
Summary: Style/format footer and add fade on hover effect to links
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -125,20 +125,31 @@ div.read_the_docs {\npadding-bottom: 40px;\n}\n-div.footer_logo_container a {\n+div.footer_logo_container {\ngrid-area: footer_logo_container;\n+}\n+\n+div.footer_logo_cont... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Style footer and fade on link hover
Summary: Style/format footer and add fade on hover effect to links
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1549 |
129,184 | 30.06.2021 14:04:45 | 14,400 | 22b3a13150f60ab7f25192de1340b3245e8ef7a7 | [landing] Add `How Comm works` link to footer
Summary: Direct link to the placeholder Notion doc
Test Plan: I clicked the link and it took me to the Notion doc
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -149,7 +149,7 @@ div.footer_logo a {\ndiv.subscribe_updates {\ngrid-area: subscribe_updates;\n- align-self: center;\n+ align-self: flex-start;\n}\ndiv.particles {\n"
},
{
"change_type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add `How Comm works` link to footer
Summary: Direct link to the placeholder Notion doc
Test Plan: I clicked the link and it took me to the Notion doc
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1550 |
129,184 | 30.06.2021 14:23:16 | 14,400 | a7c52c42d59044daae10db02478850bdc6e201d6 | [landing] Style links in `legal-container`
Summary: Styled links in `legal-container` to be purple (and lighter purple on hover)
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -156,7 +156,7 @@ div.particles {\nz-index: -1;\n}\n-div.legalContainer {\n+div.legal_container {\nmax-width: 1920px;\nmargin-left: auto;\nmargin-right: auto;\n@@ -164,6 +164,16 @@ div.legalCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Style links in `legal-container`
Summary: Styled links in `legal-container` to be purple (and lighter purple on hover)
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1551 |
129,184 | 30.06.2021 17:15:20 | 14,400 | c6e558a4a951eb04cc69c97abc8b76ea601650c6 | [landing] Pull header out into its own "grid", give footer translucent blur effect
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/home.react.js",
"new_path": "landing/home.react.js",
"diff": "@@ -70,7 +70,6 @@ function Home(): React.Node {\n<div>\n<StarBackground className={css.particles} />\n<div className={css.grid}>\n- <h1 className={css.title}>Comm</h1>\n<div className={`${cs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Pull header out into its own "grid", give footer translucent blur effect
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1552 |
129,184 | 30.06.2021 19:56:11 | 14,400 | c7457a70aea70a451dac6e660d298ea3b5bad003 | [landing] Remove redundant `display:grid`
Test Plan: Checked smallest breakpoint and things continued to look as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -223,7 +223,6 @@ div.body_grid > div + .starting_section {\ndiv.body_grid,\ndiv.footer_grid,\ndiv.header_grid {\n- display: grid;\npadding-left: 3%;\npadding-right: 3%;\ngrid-template-columns... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Remove redundant `display:grid`
Test Plan: Checked smallest breakpoint and things continued to look as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1554 |
129,184 | 30.06.2021 20:00:42 | 14,400 | 47e252c53646f6fea4426d2547b5db2003506708 | [landing] Remove redundant `margin-left` and `margin-right`
Summary: addressed feedback from D1548
Test Plan: continues to look as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -283,8 +283,6 @@ div.body_grid > div + .starting_section {\n/* ===== LEGAL PAGE STYLING ===== */\ndiv.legal_container {\nmax-width: 540px;\n- margin-left: auto;\n- margin-right: auto;\npaddin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Remove redundant `margin-left` and `margin-right`
Summary: addressed feedback from D1548
Test Plan: continues to look as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1555 |
129,184 | 30.06.2021 20:12:09 | 14,400 | 97195695cf6c0b5888ab2a87279cb2af9e3f9b0e | [landing] Make sans-serif font default for `h1` and `h2`
Summary: addressed feedback from D1546 (made sans-serif the default for `h1`/`h2`
Test Plan: fonts continue to look as expected on main page/legal pages
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/home.react.js",
"new_path": "landing/home.react.js",
"diff": "@@ -80,7 +80,7 @@ function Home(): React.Node {\n/>\n</div>\n<div className={`${css.hero_copy} ${css.section}`}>\n- <h1>\n+ <h1 className={css.mono}>\nReclaim your\n<span className={css.purp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make sans-serif font default for `h1` and `h2`
Summary: addressed feedback from D1546 (made sans-serif the default for `h1`/`h2`
Test Plan: fonts continue to look as expected on main page/legal pages
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https... |
129,184 | 30.06.2021 20:22:59 | 14,400 | 490ec75f2e22daf6081159fc667cd5f9149f369a | [landing] Factor out `a:transition`
Summary: addressed feedback from D1552
Test Plan: fade continues to look as it did previously
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -13,6 +13,11 @@ body {\npadding: 0;\n}\n+a {\n+ transition: 0.2s;\n+ text-decoration: none;\n+}\n+\n/* ===== TEXT STYLES ===== */\nh1 {\nfont-size: 58px;\n@@ -69,8 +74,6 @@ div.header_grid {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Factor out `a:transition`
Summary: addressed feedback from D1552
Test Plan: fade continues to look as it did previously
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1557 |
129,184 | 30.06.2021 20:51:26 | 14,400 | 270ee9efd52e24151b8de4ed1fde6480f21bf389 | [landing] Use sans-serif font for "Comm" in "Comm is the keyserver company."
Summary: Use sans-serif font for Comm consistent with use of wordmark elsewhere
Test Plan: Looks as expected:
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/home.react.js",
"new_path": "landing/home.react.js",
"diff": "@@ -117,9 +117,13 @@ function Home(): React.Node {\n</div>\n<div className={css.keyserver_company}>\n- <h1 className={css.mono}>\n- Comm is the <span className={css.purple_accent}>keyserver<... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Use sans-serif font for "Comm" in "Comm is the keyserver company."
Summary: Use sans-serif font for Comm consistent with use of wordmark elsewhere
Test Plan: Looks as expected: https://blob.sh/atul/2f1d.png
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision... |
129,187 | 29.06.2021 19:09:43 | 14,400 | 09ea3920922986deb5bd373150d27ab22b06a0ef | [native] Finish removing Shared Web Credentials
Summary: Missed some spots in D1535.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/native-credentials.js",
"new_path": "native/account/native-credentials.js",
"diff": "// @flow\n-import { Platform } from 'react-native';\nimport {\ngetInternetCredentials,\nsetInternetCredentials,\n@@ -20,10 +19,6 @@ let storedNativeKeychainCred... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Finish removing Shared Web Credentials
Summary: Missed some spots in D1535.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1538 |
129,187 | 29.06.2021 19:11:05 | 14,400 | a7a1b982906de813ac006a6fc0cd4f13a0766286 | [native] Update bundle identifier in notif test files
Summary: (These files can be drag-n-dropped into an iOS Simulator to simulate receiving a notif.)
Test Plan: N/A
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/apns/badgeonly.apns",
"new_path": "native/ios/apns/badgeonly.apns",
"diff": "{\n- \"Simulator Target Bundle\": \"org.squadcal.app\",\n+ \"Simulator Target Bundle\": \"app.comm\",\n\"prefix\": \"somebody:\",\n\"body\": \"asdasd\",\n\"title\": \"test\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update bundle identifier in notif test files
Summary: (These files can be drag-n-dropped into an iOS Simulator to simulate receiving a notif.)
Test Plan: N/A
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1539 |
129,187 | 29.06.2021 19:14:55 | 14,400 | 2d4ae8828754388bba6b7d4745d063348f1d7ead | [native] Change Android applicationId to app.comm
Test Plan: Will test momentarily
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -265,11 +265,11 @@ android {\n}\ndefaultConfig {\n- applicationId \"org.squadcal\"\n+ applicationId 'app.comm'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkV... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Change Android applicationId to app.comm
Test Plan: Will test momentarily
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1540 |
129,187 | 29.06.2021 19:30:34 | 14,400 | 429aa663a9972d28b85093cca76dd9bea13a6b0a | [native] Switch Android to using Comm FCM config
Test Plan: Compile and run Android in prod mode so notifs work. Will need to wait on [this task](https://www.notion.so/commapp/Update-server-to-conditionally-use-Comm-notif-keys-for-newer-codeVersions-b265894dc1bb455a96d32a59d1e4751a) to test
Reviewers: atul
Subscribers:... | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/google-services.json",
"new_path": "native/android/app/google-services.json",
"diff": "{\n\"project_info\": {\n- \"project_number\": \"112225499479\",\n- \"firebase_url\": \"https://squadcal0.firebaseio.com\",\n- \"project_id\": \"squadcal0\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Switch Android to using Comm FCM config
Test Plan: Compile and run Android in prod mode so notifs work. Will need to wait on [this task](https://www.notion.so/commapp/Update-server-to-conditionally-use-Comm-notif-keys-for-newer-codeVersions-b265894dc1bb455a96d32a59d1e4751a) to test
Reviewers: atul
Reviewed ... |
129,187 | 29.06.2021 20:30:22 | 14,400 | ceccbabe8b04a7f2c5ee6742b7ca58d64b4c41af | [native] Hide Android signing key details
Test Plan: Make sure I can still build and run release mode, as well as build+sign a release APK
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -246,6 +246,20 @@ afterEvaluate {\npreBuild.dependsOn(prepareExternalLibs)\n}\n+// Release keystore via macOS Keychain Access\n+def getPassword(String keyLabel) {\n+ d... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Hide Android signing key details
Test Plan: Make sure I can still build and run release mode, as well as build+sign a release APK
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1542 |
129,187 | 30.06.2021 18:04:52 | 14,400 | 7c58777649e227e157622536ebcf275719cb0c93 | [native] Fix android release build
Summary: fix android release build
Test Plan: build android in the release mode
Reviewers: palys-swm, karol-bisztyga, atul
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/CMakeLists.txt",
"new_path": "native/android/app/CMakeLists.txt",
"diff": "@@ -15,9 +15,10 @@ set(PACKAGE_NAME \"comm_jni_module\")\nfind_package(fbjni REQUIRED CONFIG)\nset(BUILD_TESTING OFF)\n+set(HAVE_SYMBOLIZE OFF)\nset(WITH_GTEST OFF CA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix android release build
Summary: fix android release build
Test Plan: build android in the release mode
Reviewers: palys-swm, karol-bisztyga, atul
Reviewed By: atul
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1547 |
129,187 | 30.06.2021 23:41:57 | 14,400 | f3a0ca250ab550c9f8eb093aacf30bc1be019d14 | [native] Update to
Summary: This fixes the Android release build. See [this Notion task](https://www.notion.so/commapp/Android-release-build-doesn-t-compile-7b6a20438fad4ee4ad2a65f171206acd) for more details.
Test Plan: `cd native && yarn react-native run-android --variant=release`
Reviewers: karol-bisztyga, palys-swm,... | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -309,8 +309,8 @@ PODS:\n- React-Core\n- react-native-in-app-message (1.0.2):\n- React\n- - react-native-netinfo (4.4.0):\n- - React\n+ - react-native-netinfo (6.0.0):\n+ - React-Core\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update to @react-native-community/netinfo@6.0.0
Summary: This fixes the Android release build. See [this Notion task](https://www.notion.so/commapp/Android-release-build-doesn-t-compile-7b6a20438fad4ee4ad2a65f171206acd) for more details.
Test Plan: `cd native && yarn react-native run-android --variant=releas... |
129,184 | 01.07.2021 15:23:26 | 14,400 | 9935fd7a3b69cd093c770d23d9ae8842d11c763b | [native] Add legal notices to `register-panel`
Summary: Add links to the terms of use and privacy policy to the `register-panel`
Test Plan: Looks as expected and links open in mobile browser
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -97,7 +97,7 @@ class LogInPanel extends React.PureComponent<Props> {\nrender() {\nreturn (\n<Panel opacityValue={this.props.opacityValue}>\n- <View>\n+ <View... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add legal notices to `register-panel`
Summary: Add links to the terms of use and privacy policy to the `register-panel`
Test Plan: Looks as expected and links open in mobile browser
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.asho... |
129,184 | 01.07.2021 16:19:24 | 14,400 | dd461ec70bed7f13ff5950cad77bb4e340a4c50b | [lib] Add `role` to `keysWithStringsToBeRedacted` and `roles` to `keysWithObjectsWithKeysToBeRedacted`
Summary: Add keys to sanitization
Test Plan: Trigger crash report and import into redux dev tools
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/sanitization.js",
"new_path": "lib/utils/sanitization.js",
"diff": "@@ -65,6 +65,7 @@ const keysWithStringsToBeRedacted = new Set([\n'deletedUserID',\n'deviceToken',\n'updatedUserID',\n+ 'role',\n]);\n// eg {\"memberIDs\":[\"123\", \"456\"]} => {\"me... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add `role` to `keysWithStringsToBeRedacted` and `roles` to `keysWithObjectsWithKeysToBeRedacted`
Summary: Add keys to sanitization
Test Plan: Trigger crash report and import into redux dev tools
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabri... |
129,187 | 01.07.2021 16:25:40 | 14,400 | b9482be0b32f0be3614b30486b94bd08a226a6c5 | [native] Fix up LoggedOutModal for short devices and Android
Test Plan: test on iPhone 5s, Nexus 4, iPhone 12 Pro
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -27,6 +27,7 @@ import type { Shape } from 'lib/types/core';\nimport type { Dispatch } from 'lib/types/redux-types';\nimport { fetchNewCookieFromNativ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up LoggedOutModal for short devices and Android
Test Plan: test on iPhone 5s, Nexus 4, iPhone 12 Pro
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1568 |
129,187 | 01.07.2021 23:15:51 | 14,400 | 12ea24361892755e1fdd57c1f499c5455f195179 | [server] Change parameter format to push utils
Summary: Switching to a named parameter setup with an object being passed in.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/rescind.js",
"new_path": "server/src/push/rescind.js",
"diff": "@@ -58,7 +58,10 @@ async function rescindPushNotifs(\ndelivery.iosID,\nrow.unread_count,\n);\n- deliveryPromises[id] = apnPush(notification, delivery.iosDeviceTokens);\n+ deliveryP... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Change parameter format to push utils
Summary: Switching to a named parameter setup with an object being passed in.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1570 |
129,184 | 01.07.2021 21:06:23 | 14,400 | 09d70275f5f0a47696e9f7d765ae0f027296b1c1 | [landing] Set initial landing component based on URL
Summary: Set initial `activePage` based on `req.url`/`window.location.href`
Test Plan: Can navigate to `/privacy` and `/terms` and it appears as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -8,10 +8,21 @@ import Privacy from './privacy.react';\nimport SubscriptionForm from './subscription-form.react';\nimport Terms from './terms.react';\n-export type ActivePage = 'home... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Set initial landing component based on URL
Summary: Set initial `activePage` based on `req.url`/`window.location.href`
Test Plan: Can navigate to `/privacy` and `/terms` and it appears as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://... |
129,184 | 01.07.2021 22:28:27 | 14,400 | b40dff44398e6d835cb15eb067d30d5242f40287 | [native] Move padding from `styles.icon` to `styles.sidebar`
Summary:
Before:
After:
Test Plan: `SidebarItem` looks as expected in the thread list and `SidebarListModal`
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/sidebar-item.react.js",
"new_path": "native/chat/sidebar-item.react.js",
"diff": "@@ -60,13 +60,12 @@ const unboundStyles = {\nheight: 30,\nflexDirection: 'row',\ndisplay: 'flex',\n- paddingLeft: 6,\n+ paddingLeft: 40,\npaddingRight: 18,\nalignItem... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move padding from `styles.icon` to `styles.sidebar`
Summary:
Before: https://blob.sh/atul/6d56.png
After: https://blob.sh/atul/eea6.png
Test Plan: `SidebarItem` looks as expected in the thread list and `SidebarListModal`
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differen... |
129,184 | 01.07.2021 22:47:15 | 14,400 | a8f5091f5559a491a5e006316bcf7f261f15e8cc | [native] Reduce "profile" splotch size and shift up
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -135,6 +135,7 @@ const chatThreadListItemHeight = 80;\nconst unboundStyles = {\ncolorSplotch: {\nmarginLeft: 6,\n+ marginBottom: 14,\n},\ncontain... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reduce "profile" splotch size and shift up
Summary: Here's how it looks: https://blob.sh/atul/aff5.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1578 |
129,184 | 02.07.2021 10:25:02 | 14,400 | a3eb34814c9b0c8fe72ba20bdfa5086c1a330af9 | [native] Have `ThreadAncestorsLabel` match `threadName` and `lastActivity` color when unread
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -111,7 +111,10 @@ function ChatThreadListItem({\n<ColorSplotch color={data.threadInfo.color} size=\"profile\" />\n</View>\n<View style={styles.co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Have `ThreadAncestorsLabel` match `threadName` and `lastActivity` color when unread
Summary: Here's how it looks: https://blob.sh/atul/7d2c.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1... |
129,184 | 02.07.2021 13:58:24 | 14,400 | 52f640dbfa246ff80773f398f0f390e086bce88a | [native] Replace `ColorSplotch` rounded rectangle with squircle
Summary: Replace `ColorSplotch` rounded rectangle with squircle
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/color-splotch.react.js",
"new_path": "native/components/color-splotch.react.js",
"diff": "// @flow\nimport React from 'react';\n-import { View, StyleSheet } from 'react-native';\n+import { StyleSheet } from 'react-native';\n+import { Squircle... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Replace `ColorSplotch` rounded rectangle with squircle
Summary: Replace `ColorSplotch` rounded rectangle with squircle
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1584 |
129,184 | 02.07.2021 14:15:43 | 14,400 | c2d14134429cba1802e6d663f2c1bda490884286 | [native] Change `Profile` and `Apps` icon in tab bar
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -73,14 +73,14 @@ const profileTabOptions = {\ntabBarLabel: 'Profile',\n// eslint-disable-next-line react/display-name\ntabBarIcon: ({ color }) => (\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Change `Profile` and `Apps` icon in tab bar
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1585 |
129,184 | 02.07.2021 15:26:22 | 14,400 | 9e46104552871c4585e0cd1537e74b21030a3c4e | [native] Add `unreadIndicator` prop to `SidebarItem` and conditionally change padding
Summary: Here is what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -138,7 +138,7 @@ const chatThreadListItemHeight = 80;\nconst unboundStyles = {\ncolorSplotch: {\nmarginLeft: 6,\n- marginBottom: 14,\n+ marginBot... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add `unreadIndicator` prop to `SidebarItem` and conditionally change padding
Summary: Here is what it looks like: https://blob.sh/atul/4b01.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1... |
129,184 | 02.07.2021 16:18:45 | 14,400 | a7a3ee40922451cc6fd22413834bb62dfd183dfd | [native] Reduce `ChatThreadListItem` height and adjust margins
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -102,15 +102,16 @@ function ChatThreadListItem({\niosFormat=\"highlight\"\niosHighlightUnderlayColor={colors.listIosHighlightUnderlay}\niosActive... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reduce `ChatThreadListItem` height and adjust margins
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1590 |
129,187 | 02.07.2021 16:14:26 | 14,400 | 1329cfa529a7c21ed424fb59a58fae048fb4f74e | Add spacer to ChatThreadList
Test Plan: Visual inspection, Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -58,7 +58,8 @@ export type SidebarItem =\n+type: 'seeMore',\n+unread: boolean,\n+showingSidebarsInline: boolean,\n- |};\n+ |}\n+ | {| +type: 'spacer' |};\nexport type ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add spacer to ChatThreadList
Test Plan: Visual inspection, Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1589 |
129,187 | 02.07.2021 16:48:01 | 14,400 | f02936e6f0411d36511e75d6a5956f4bfabbec87 | [native] Specify sidebarHeight in only one file
Summary: Avoiding copy-paste.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-see-more-sidebars.react.js",
"new_path": "native/chat/chat-thread-list-see-more-sidebars.react.js",
"diff": "@@ -8,6 +8,7 @@ import type { ThreadInfo } from 'lib/types/thread-types';\nimport Button from '../components/button.react'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Specify sidebarHeight in only one file
Summary: Avoiding copy-paste.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1591 |
129,184 | 02.07.2021 17:03:54 | 14,400 | ee7623330857d9969e9efd29dd6c9c22de3b03a1 | [landing] Replace inactive `how-it-works` link with notion page
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/privacy.react.js",
"new_path": "landing/privacy.react.js",
"diff": "@@ -147,7 +147,10 @@ function Privacy(): React.Node {\nto access, view or control your Content.\n</strong>{' '}\nFor more information on how Comm works, please{' '}\n- <a href=\"https:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Replace inactive `how-it-works` link with notion page
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1592 |
129,187 | 02.07.2021 18:55:16 | 14,400 | 59b2a1005a0421a9d78c9e21303ac27b97ac7d83 | [native] Update Folly.podspec patch to include Futex
Summary: Was seeing an error about this when archiving the iOS app.
Test Plan: Make sure iOS archive build works
Reviewers: atul, karol-bisztyga
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "patches/react-native+0.63.4.patch",
"new_path": "patches/react-native+0.63.4.patch",
"diff": "@@ -439,7 +439,7 @@ index 9ae06db..35cc24e 100644\nversions['Flipper-PeerTalk'] ||= '~> 0.0.4'\nversions['Flipper-RSocket'] ||= '~> 1.1'\ndiff --git a/node_modules/re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update Folly.podspec patch to include Futex
Summary: Was seeing an error about this when archiving the iOS app.
Test Plan: Make sure iOS archive build works
Reviewers: atul, karol-bisztyga
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1593 |
129,187 | 02.07.2021 18:55:42 | 14,400 | e2aa296f95d122f6ec4b69106559cbe5b22562a8 | [native] Remove duplicate OLMKit entry in Podfile
Summary: The native module system is automatically detecting `OLMKit` already, so this entry is a duplicate.
Test Plan: Make sure iOS build still works
Reviewers: atul, karol-bisztyga
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile",
"new_path": "native/ios/Podfile",
"diff": "@@ -9,7 +9,6 @@ target 'Comm' do\npod 'ReactNativeKeyboardInput', :path => '../../node_modules/react-native-keyboard-input'\npod 'react-native-ffmpeg/min-lts', :podspec => '../../node_modules/reac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove duplicate OLMKit entry in Podfile
Summary: The native module system is automatically detecting `OLMKit` already, so this entry is a duplicate.
Test Plan: Make sure iOS build still works
Reviewers: atul, karol-bisztyga
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: h... |
129,187 | 02.07.2021 20:25:43 | 14,400 | 5fd44636ef06e2161a191a6792e584b5f54db6bd | [native] Skip extraneous routes in resetState
Summary: We were crashing because the `oldRoute` for `TabNavigator` had an extra tab. This diff makes sure us skip the extra tab.
Test Plan: Test to make sure problem is solved
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/root-router.js",
"new_path": "native/navigation/root-router.js",
"diff": "@@ -69,7 +69,9 @@ export type RootRouterNavigationProp<\n|};\ntype ResetStateRoute = {\n+ +name: string,\n+state?: { +routes: $ReadOnlyArray<ResetStateRoute> },\n+ ...\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Skip extraneous routes in resetState
Summary: We were crashing because the `oldRoute` for `TabNavigator` had an extra tab. This diff makes sure us skip the extra tab.
Test Plan: Test to make sure problem is solved
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revisi... |
129,187 | 02.07.2021 19:02:04 | 14,400 | a98891a19551b61bd5124cfab48f3a3dfa7f754e | [native] codeVersion -> 88 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -282,8 +282,8 @@ android {\napplicationId 'app.comm'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 86\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 88 |
129,187 | 02.07.2021 21:38:57 | 14,400 | dbb21c92deee83a4b13e23baab88cb0d384699b7 | [server] Use correct bundle ID in Apple push notif
Summary: This was a dumb oversight on my part...
Test Plan: Test in prod!
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/providers.js",
"new_path": "server/src/push/providers.js",
"diff": "@@ -71,6 +71,10 @@ function endAPNs() {\n}\n}\n+function getAPNsNotificationTopic(codeVersion: ?number): string {\n+ return codeVersion && codeVersion >= 87 ? 'app.comm' : 'org... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use correct bundle ID in Apple push notif
Summary: This was a dumb oversight on my part...
Test Plan: Test in prod!
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1599 |
129,184 | 02.07.2021 20:11:23 | 14,400 | 5102eb7c2cb71b9deb475ac29a6a8721e08f15aa | [landing] Introduce `Support` page
Summary:
Placeholder support page with support email address for soft launch.
Known issue: the footer isn't "sticky," will address in subsequent diff.
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -6,9 +6,10 @@ import Home from './home.react';\nimport css from './landing.css';\nimport Privacy from './privacy.react';\nimport SubscriptionForm from './subscription-form.react';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Introduce `Support` page
Summary:
Placeholder support page with support email address for soft launch.
Known issue: the footer isn't "sticky," will address in subsequent diff.
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision:... |
129,187 | 02.07.2021 21:06:16 | 14,400 | 0a6add784345d89b00b843fa65739597741f66a7 | [native] Change Android appID to app.comm.android
Summary: Apparently `app.comm` has already been used.
Test Plan: Run the app
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -279,7 +279,7 @@ android {\n}\ndefaultConfig {\n- applicationId 'app.comm'\n+ applicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkV... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Change Android appID to app.comm.android
Summary: Apparently `app.comm` has already been used.
Test Plan: Run the app
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1598 |
129,187 | 04.07.2021 18:21:17 | 14,400 | 619f3079d3cb45d82142a1da2c40d8f45c3eae82 | [native] codeVersion -> 89
Android-only release to change the app ID to `app.comm.android` because apparently `app.comm` was already taken. | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -282,8 +282,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 89
Android-only release to change the app ID to `app.comm.android` because apparently `app.comm` was already taken. |
129,187 | 03.07.2021 21:14:35 | 14,400 | 545e00c1c1d8f4c6362424f89a79a19f4466f01d | [native] Reduce unread font-weight in ThreadList
Summary: See screenshot in following diff
Test Plan: Visual inspection
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -87,8 +87,28 @@ function ChatThreadListItem({\nonPressItem(data.threadInfo, data.pendingPersonalThreadUserInfo);\n}, [onPressItem, data.threadInf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reduce unread font-weight in ThreadList
Summary: See screenshot in following diff
Test Plan: Visual inspection
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1602 |
129,187 | 03.07.2021 21:16:12 | 14,400 | 3f7c0df3b7bf1baa6526c43e34503e24375094d7 | [native] Increase thread name size in ChatThreadListItem
Summary: Here's how it looks:
Test Plan: Visual inspection
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -203,7 +203,7 @@ const unboundStyles = {\nthreadName: {\ncolor: 'listForegroundSecondaryLabel',\nflex: 1,\n- fontSize: 18,\n+ fontSize: 21,\n},\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Increase thread name size in ChatThreadListItem
Summary: Here's how it looks: https://www.dropbox.com/s/x68b04z21nwe9bd/Screen%20Shot%202021-07-03%20at%209.13.07%20PM.png?dl=0
Test Plan: Visual inspection
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https... |
129,187 | 05.07.2021 12:59:02 | 14,400 | 4877bc6a80b2226f5aec48f58fde90885a4cdeb5 | [lib] Delete reports from ReportStore on log in/out
Test Plan: I haven't really tested this...
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/report-store-reducer.js",
"new_path": "lib/reducers/report-store-reducer.js",
"diff": "@@ -52,12 +52,12 @@ export default function reduceReportStore(\naction.payload.sessionChange.cookieInvalidated)\n) {\nreturn {\n- queuedReports: updatedReports,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Delete reports from ReportStore on log in/out
Test Plan: I haven't really tested this...
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1605 |
129,187 | 05.07.2021 13:09:51 | 14,400 | dd5e0da0050fd4f89b877d31d41c9241f64b3a1c | [server] Update ashoat's message to new accounts for Comm soft launch
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/account-creator.js",
"new_path": "server/src/creators/account-creator.js",
"diff": "@@ -40,7 +40,7 @@ import {\nconst { commbot } = bots;\nconst ashoatMessages = [\n- 'welcome to SquadCal! thanks for helping to test the alpha.',\n+ 'welcome... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update ashoat's message to new accounts for Comm soft launch
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1607 |
129,187 | 05.07.2021 13:10:14 | 14,400 | ac53099a8e8b6ff2b71eb56efb808f6bf59815a9 | [native] Update notif alert to reference Comm instead of SquadCal
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/push/push-handler.react.js",
"new_path": "native/push/push-handler.react.js",
"diff": "@@ -147,7 +147,7 @@ class PushHandler extends React.PureComponent<Props, State> {\nandroidNotificationChannelID,\n'Default',\nfirebase.notifications.Android.Importanc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update notif alert to reference Comm instead of SquadCal
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1608 |
129,187 | 05.07.2021 14:01:14 | 14,400 | 24f7a69f1f4150673cabfd71cb2aa2ae3d97839c | [native] codeVersion -> 90 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -282,8 +282,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 90 |
129,184 | 05.07.2021 15:10:09 | 14,400 | 87de4c723e107b65308725829907d67ddc5089f4 | [android] Change floating action color from green to brand purple
Summary:
Before:
After:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -448,7 +448,7 @@ class ChatThreadList extends React.PureComponent<Props, State> {\nactions={floatingActions}\noverrideWithAction\nonPressItem={this.compose... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [android] Change floating action color from green to brand purple
Summary:
Before: https://blob.sh/atul/float_green.png
After: https://blob.sh/atul/float_purple.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.a... |
129,187 | 05.07.2021 16:11:35 | 14,400 | 9373ec763d9edb33ec511570a34963ebf16eda53 | [server] Rename backups from squadcal to comm
Test Plan: Test in prod!
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron/backups.js",
"new_path": "server/src/cron/backups.js",
"diff": "@@ -40,7 +40,7 @@ async function backupDB() {\n}\nconst dateString = dateFormat('yyyy-mm-dd-HH:MM');\n- const filename = `squadcal.${dateString}.sql.gz`;\n+ const filename = `comm.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rename backups from squadcal to comm
Test Plan: Test in prod!
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1610 |
129,187 | 05.07.2021 16:31:59 | 14,400 | 89bca8ad182ba7a5e1b1e8ad38361ab9d44864ed | [server] Switch UNIX user from squadcal to comm
Test Plan: Test in prod!
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/bash/backup_phabricator.sh",
"new_path": "server/bash/backup_phabricator.sh",
"diff": "@@ -10,7 +10,7 @@ PHABRICATOR_PATH=/var/www/phacility/phabricator\nBACKUP_PATH=/mnt/backup\n# The user that will be owning the backup files\n-BACKUP_USER=squadcal\n+B... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Switch UNIX user from squadcal to comm
Test Plan: Test in prod!
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1611 |
129,187 | 05.07.2021 16:32:11 | 14,400 | 13edd054e8deb53eac3c808d7f1e108df4cbfa6c | [server] Change systemd service from squadcal to comm
Test Plan: Test in prod!
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/bash/deploy.sh",
"new_path": "server/bash/deploy.sh",
"diff": "@@ -36,11 +36,11 @@ su $DAEMON_USER -c \"cd server && PORT=3001 timeout 60 bash/run-prod.sh\"\nset -e\n# STEP 3: flip it over\n-systemctl stop squadcal || true\n+systemctl stop comm || true\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Change systemd service from squadcal to comm
Test Plan: Test in prod!
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1612 |
129,184 | 05.07.2021 16:51:47 | 14,400 | fb3b3b08b83d81cca758ee711601e172d41c788a | [landing] Reduce font size for legal pages
Summary: Reduce font size (at largest and medium breakpoint) for legal pages
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -157,6 +157,16 @@ div.legal_container {\npadding-left: 60px;\npadding-right: 60px;\n}\n+div.legal_container h1 {\n+ font-size: 42px;\n+}\n+div.legal_container h2 {\n+ font-size: 38px;\n+}\n+d... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Reduce font size for legal pages
Summary: Reduce font size (at largest and medium breakpoint) for legal pages
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1613 |
129,187 | 05.07.2021 18:21:12 | 14,400 | 3ae6b8d8693f06d026532f3b0a2622cc4cf13fcb | [server] Fix personal thread detection code to require actual membership
Test Plan: Test in prod!
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -239,8 +239,8 @@ async function createThread(\nINNER JOIN memberships m2\nON m2.thread = t.id AND m2.user = ${otherMemberID}\nWHERE t.type = ${threadTypes.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix personal thread detection code to require actual membership
Test Plan: Test in prod!
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1614 |
129,184 | 05.07.2021 19:00:09 | 14,400 | ec9f47416fe2d599d1ada432e9e0234e2d03d578 | [native] Replace ">" with chevron icon in `ThreadAncestorsLabel`
Summary:
Before:
After:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-ancestors-label.react.js",
"new_path": "native/components/thread-ancestors-label.react.js",
"diff": "// @flow\nimport * as React from 'react';\n+import { Text, View } from 'react-native';\n+import Icon from 'react-native-vector-icons/F... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Replace ">" with chevron icon in `ThreadAncestorsLabel`
Summary:
Before: https://blob.sh/atul/ancestry-geq-path.png
After: https://blob.sh/atul/ancestry-chevron-path.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https:/... |
129,184 | 07.07.2021 12:14:03 | 14,400 | 57c11fea93b60f5e85ef2d1017aa4072490d8055 | Update `react-router-dom` libdef
Summary: Updated `react-router-dom` libdef because flow was complaining about `useHistory` hook not being exported
Test Plan: Flow no longer complains
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/react-router-dom_v5.x.x.js",
"new_path": "server/flow-typed/npm/react-router-dom_v5.x.x.js",
"diff": "-// flow-typed signature: 5c3ecc173e04f53b410aa08d80e28aa2\n-// flow-typed version: cb4e8f3aa2/react-router-dom_v5.x.x/flow_>=v0.98.x <=... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update `react-router-dom` libdef
Summary: Updated `react-router-dom` libdef because flow was complaining about `useHistory` hook not being exported
Test Plan: Flow no longer complains
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/... |
129,184 | 07.07.2021 17:06:24 | 14,400 | 1da424ccb4ff20c3c2d998f3a20c8ecbe6b094df | Update `react-router` & `react-router-dom` 5.1.2 -> 5.2.0
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/package.json",
"new_path": "landing/package.json",
"diff": "\"lib\": \"0.0.1\",\n\"react\": \"16.13.1\",\n\"react-dom\": \"16.13.1\",\n- \"react-hot-loader\": \"^4.12.14\"\n+ \"react-hot-loader\": \"^4.12.14\",\n+ \"react-router\": \"^5.2.0\",\n+ \"rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update `react-router` & `react-router-dom` 5.1.2 -> 5.2.0
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1617 |
129,184 | 07.07.2021 17:11:20 | 14,400 | 65a221e3ad4a96204e5da692d65e433c38439acf | [landing] Introduce `landing-ssr` and make it the server entry point
Summary: Introduce `LandingSSR` component and modify NodeServerRendering entry point to address issue where `Landing` wasn't getting `RouterContext` from `StaticRouter`
Test Plan: Able to use `useLocation` hook, `useHistory` hook, etc
Reviewers: ashoa... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/landing-ssr.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { StaticRouter } from 'react-router';\n+\n+import Landing from './landing.react';\n+\n+export type Props = {|\n+ +url: string,\n+|};\n+function Landi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Introduce `landing-ssr` and make it the server entry point
Summary: Introduce `LandingSSR` component and modify NodeServerRendering entry point to address issue where `Landing` wasn't getting `RouterContext` from `StaticRouter`
Test Plan: Able to use `useLocation` hook, `useHistory` hook, etc
Reviewers: as... |
129,184 | 07.07.2021 17:41:04 | 14,400 | af91e1e1c4164ccde461ac058ddc5cf3fd3d291e | [landing] Use `Switch`, `Route`, and `Link` in `landing`
Summary: Replace `activePage` state for "navigating" between components with `react-router` Switch, Route, and Link components
Test Plan: Able to navigate between pages (typing out url, clicking links, browser forward/back) as expected
Reviewers: ashoat
Subscribe... | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "// @flow\nimport * as React from 'react';\n+import { Switch, Route, Link, useLocation } from 'react-router-dom';\nimport Home from './home.react';\nimport css from './landing.css';\n@@... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Use `Switch`, `Route`, and `Link` in `landing`
Summary: Replace `activePage` state for "navigating" between components with `react-router` Switch, Route, and Link components
Test Plan: Able to navigate between pages (typing out url, clicking links, browser forward/back) as expected
Reviewers: ashoat
Revie... |
129,184 | 07.07.2021 17:48:19 | 14,400 | 73a30f5a1eab6d8517c914326115b0529888c3a7 | [landing] Remove `url` prop from `landing`
Summary: We no longer need `url` prop for `landing` component. However, we still need it for the `LandingSSR` component to give to the StaticRouter
Test Plan: Continues to work as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing-ssr.react.js",
"new_path": "landing/landing-ssr.react.js",
"diff": "@@ -5,10 +5,10 @@ import { StaticRouter } from 'react-router';\nimport Landing from './landing.react';\n-export type Props = {|\n+export type LandingSSRProps = {|\n+url: string... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Remove `url` prop from `landing`
Summary: We no longer need `url` prop for `landing` component. However, we still need it for the `LandingSSR` component to give to the StaticRouter
Test Plan: Continues to work as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differ... |
129,184 | 07.07.2021 18:28:08 | 14,400 | 580019c92f9ec1b67ea4eac380320c5c976e2b25 | [landing] Conditionally select router `basename` based on env
Summary: Conditionally select router `basename` based on env
Test Plan: hrefs match up
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing-ssr.react.js",
"new_path": "landing/landing-ssr.react.js",
"diff": "@@ -7,16 +7,13 @@ import Landing from './landing.react';\nexport type LandingSSRProps = {|\n+url: string,\n+ +basename: string,\n|};\nfunction LandingSSR(props: LandingSSRProps... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Conditionally select router `basename` based on env
Summary: Conditionally select router `basename` based on env
Test Plan: hrefs match up
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1621 |
129,184 | 08.07.2021 16:38:02 | 14,400 | ab7f21bef691114652894699cbe3c7463452f9f5 | [native] Update `AppsDirectory` icons
Summary:
Update `AppsDirectory` with SWMansionIcon
Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/apps/app-listing.react.js",
"new_path": "native/apps/app-listing.react.js",
"diff": "import * as React from 'react';\nimport { View, Text, TouchableOpacity } from 'react-native';\n-import Icon from 'react-native-vector-icons/FontAwesome';\nimport { useD... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update `AppsDirectory` icons
Summary:
Update `AppsDirectory` with SWMansionIcon
Here's how it looks: https://blob.sh/atul/56aa.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1642 |
129,184 | 08.07.2021 17:05:22 | 14,400 | 0f43e1dc8df1cc9e8da63068d0e5ac4589549bad | [native] Use `SWMansionIcon` for `ComposeThreadButton`
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/compose-thread-button.react.js",
"new_path": "native/chat/compose-thread-button.react.js",
"diff": "import * as React from 'react';\nimport { StyleSheet } from 'react-native';\n-import Icon from 'react-native-vector-icons/MaterialCommunityIcons';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `SWMansionIcon` for `ComposeThreadButton`
Summary: Here's how it looks: https://blob.sh/atul/0cdf.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1643 |
129,187 | 08.07.2021 18:10:39 | 14,400 | ab6f411779b2b4d173f76d2eaa538e493bf3a5df | Update all react-router libdefs
Summary: We should keep all of these in sync
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/flow-typed/npm/react-router-dom_v5.x.x.js",
"diff": "+// flow-typed signature: 2d02538a529a09fdbf202a871fbb5c75\n+// flow-typed version: 5f4b3cb313/react-router-dom_v5.x.x/flow_>=v0.104.x\n+\n+declare module \"react-router-dom\" {\n+ dec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update all react-router libdefs
Summary: We should keep all of these in sync
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1646 |
129,187 | 08.07.2021 17:51:45 | 14,400 | c8a837ebc379b9b193a0b9f48ca669f6279c517d | Avoid specifying serverFlow twice in .lintstagedrc.js
Test Plan: Make sure precommit still works
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": ".lintstagedrc.js",
"new_path": ".lintstagedrc.js",
"diff": "@@ -24,7 +24,7 @@ module.exports = {\n'{server,web,lib}/**/*.js': function serverFlow(files) {\nreturn 'yarn workspace server flow --quiet';\n},\n- '{landing,lib}/**/*.js': function serverFlow(files) ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Avoid specifying serverFlow twice in .lintstagedrc.js
Test Plan: Make sure precommit still works
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1644 |
129,187 | 08.07.2021 18:08:06 | 14,400 | 85d63aac24b9146ff4c754e42a902c3c30ce1b81 | [landing] Get rid of unused particles CSS selector
Summary: The new version of Flow noticed this, but for some reason the old version didn't.
Test Plan: Flow
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/home.react.js",
"new_path": "landing/home.react.js",
"diff": "@@ -68,7 +68,7 @@ function Home(): React.Node {\nreturn (\n<div>\n- <StarBackground className={css.particles} />\n+ <StarBackground />\n<div className={css.body_grid}>\n<div className={`${cs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Get rid of unused particles CSS selector
Summary: The new version of Flow noticed this, but for some reason the old version didn't.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1645 |
129,184 | 08.07.2021 19:38:03 | 14,400 | 61fee8758deb1aa0c74b622042a76951483e7d22 | [native] Style tab bar navigator based on figma prototype
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -93,7 +93,13 @@ const Tab = createBottomTabNavigator<\nTabParamList,\nTabNavigationProp<>,\n>();\n-const tabBarOptions = { keyboardHidesTabBar: false... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Style tab bar navigator based on figma prototype
Summary: Here's how it looks: https://blob.sh/atul/f0c4.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1648 |
129,187 | 09.07.2021 13:43:41 | 14,400 | 1e961407cdb62a2cb65e9cadf472d109fcc5c5f5 | [server] Fix up landing URL to match client request before passing down
Test Plan: It works on dev. We'll have to test on prod to know for sure, but I tested the RegEx locally with the prod config
Reviewers: atul
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/landing-handler.js",
"new_path": "server/src/responders/landing-handler.js",
"diff": "@@ -86,9 +86,15 @@ async function getWebpackCompiledRootComponentForSSR() {\n}\n}\n-const { basePath } = getLandingURLFacts();\n+const { basePath, baseR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix up landing URL to match client request before passing down
Test Plan: It works on dev. We'll have to test on prod to know for sure, but I tested the RegEx locally with the prod config
Reviewers: atul
Reviewed By: atul
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ash... |
129,184 | 09.07.2021 14:27:13 | 14,400 | 34ccb12c498780335ba5f14a2a599f8136335495 | [landing] Narrow landing page and shift "Comm" header to match
Summary: Narrow legal pages to `max-width` of `1080px` and have "Comm" header match
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -63,6 +63,8 @@ div.footer_grid {\npadding-right: 60px;\npadding-top: 20px;\npadding-bottom: 40px;\n+ transition-property: max-width;\n+ transition: 300ms;\n}\n/* ===== CSS HEADER GRID LAYOUT ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Narrow landing page and shift "Comm" header to match
Summary: Narrow legal pages to `max-width` of `1080px` and have "Comm" header match
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1652 |
129,184 | 09.07.2021 13:49:02 | 14,400 | 5d0d1a7d5a6f878bdecb124fef9a738c94acbafc | [native] Style top bar navigator based on figma prototype
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -25,6 +25,7 @@ import { threadIsPending } from 'lib/shared/thread-utils';\nimport { firstLine } from 'lib/utils/string-utils';\nimport KeyboardAvoidingView from '../components/key... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Style top bar navigator based on figma prototype
Summary: Here's how it looks: https://blob.sh/atul/84c9.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1651 |
129,184 | 09.07.2021 16:35:16 | 14,400 | bc948712e4dd4de054d5434acfe1181a31eacd4c | [native] Use `listBackground` color from figma and increase tab bar `borderTopWidth`
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -98,6 +98,7 @@ const tabBarOptions = {\nactiveTintColor: '#AE94DB',\nstyle: {\nbackgroundColor: '#0A0A0A',\n+ borderTopWidth: 1,\n},\n};\nfunction Ta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `listBackground` color from figma and increase tab bar `borderTopWidth`
Summary: Here's what it looks like: https://blob.sh/atul/ac43.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D165... |
129,184 | 09.07.2021 18:02:11 | 14,400 | 71d892e1045022499b1786fa53ba3c47d800908b | [native] Restyle `Search` component
Summary:
w/o query:
selected:
w/ query:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -584,7 +584,7 @@ const unboundStyles = {\nsearch: {\nmarginBottom: 8,\nmarginHorizontal: 18,\n- marginTop: 12,\n+ marginTop: 16,\n},\ncancelSearchButton: {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle `Search` component
Summary:
w/o query: https://blob.sh/atul/df6d.png
selected: https://blob.sh/atul/c401.png
w/ query: https://blob.sh/atul/9c0b.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.... |
129,184 | 10.07.2021 19:44:06 | 14,400 | b73280dc27bca87082e3fdea936c207840c84d87 | [native] Restyle `Chat.Navigator`
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -181,11 +181,6 @@ const header = (props: CoreStackHeaderProps) => {\nreturn <ChatHeader {...castProps} />;\n};\nconst headerBackButton = (props) => <HeaderBackButton {...props} />... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle `Chat.Navigator`
Summary: Here's what it looks like: https://blob.sh/atul/3891.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1657 |
129,184 | 10.07.2021 21:48:11 | 14,400 | 4a4e3aee4a3abd29069137bf9f6a30357a727b25 | [native] Restyle `ChatInputBar`
Summary:
iOS:
android:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -15,7 +15,6 @@ import {\n} from 'react-native';\nimport { TextInputKeyboardMangerIOS } from 'react-native-keyboard-input';\nimport Animated, { Easing } from 'r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle `ChatInputBar`
Summary:
iOS: https://blob.sh/atul/chat-input-bar-ios.png
https://blob.sh/atul/chat-input-bar-icons.mov
android: https://blob.sh/atul/chat-input-bar-android.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Re... |
129,184 | 10.07.2021 23:04:34 | 14,400 | fb854833791d51bdabe6dbfa81014be03960de8e | [native] Swap out floppy disk
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/image-modal.react.js",
"new_path": "native/media/image-modal.react.js",
"diff": "@@ -17,12 +17,12 @@ import {\n} from 'react-native-gesture-handler';\nimport Orientation from 'react-native-orientation-locker';\nimport Animated from 'react-native-r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Swap out floppy disk
Summary: Here's how it looks: https://blob.sh/atul/6285.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1659 |
129,184 | 11.07.2021 00:12:25 | 14,400 | b312040d1069938f4d95cb608f1b3bfe19707d6c | [native] Style header chevrons based on the designs
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-header-title.react.js",
"new_path": "native/chat/message-list-header-title.react.js",
"diff": "@@ -93,7 +93,7 @@ const unboundStyles = {\nforwardIcon: {\npaddingLeft: 7,\npaddingTop: 3,\n- color: 'link',\n+ color: 'headerChevron',\nfle... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Style header chevrons based on the designs
Summary: Here's how it looks: https://blob.sh/atul/fa33.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1660 |
129,184 | 11.07.2021 00:46:13 | 14,400 | f939fde1852151f4fa5938212497bbc5de36e6b7 | [native] Restyle `Profile.Navigator` headerStyle
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/profile/profile.react.js",
"new_path": "native/profile/profile.react.js",
"diff": "@@ -23,7 +23,7 @@ import {\ntype ScreenParamList,\ntype ProfileParamList,\n} from '../navigation/route-names';\n-import { useStyles } from '../themes/colors';\n+import { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle `Profile.Navigator` headerStyle
Summary: Here's how it looks: https://blob.sh/atul/a225.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1661 |
129,184 | 11.07.2021 01:07:36 | 14,400 | f6265f1323d404e0397a7d5f9384e1883dd2eefd | [native] Use `threadInfo.color` for `ChatInputBar` selection color
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -549,6 +549,7 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nstyle={this.props.styles.textInput}\ntextInputRef={this.textInputRef}\nref={th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `threadInfo.color` for `ChatInputBar` selection color
Summary: Here's how it looks: https://blob.sh/atul/6050.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1662 |
129,184 | 11.07.2021 18:57:53 | 14,400 | 65af1ea5ef137cd47a583c41d595e6b56b0a8af4 | [native] Replace pencil icon w/ SWMansion icon
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-description.react.js",
"new_path": "native/chat/settings/thread-settings-description.react.js",
"diff": "import invariant from 'invariant';\nimport * as React from 'react';\nimport { Text, Alert, ActivityIndicator, TextInpu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Replace pencil icon w/ SWMansion icon
Summary: Here's what it looks like: https://blob.sh/atul/dd59.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1664 |
129,184 | 11.07.2021 19:05:40 | 14,400 | 6ced494db96d42a7c2186313e2a9a47aa2ac6954 | [native] Fix `ComposeThreadButton` alignment
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/compose-thread-button.react.js",
"new_path": "native/chat/compose-thread-button.react.js",
"diff": "@@ -54,7 +54,7 @@ class ComposeThreadButton extends React.PureComponent<Props> {\nconst styles = StyleSheet.create({\ncomposeButton: {\n- paddingHor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix `ComposeThreadButton` alignment
Summary: Here's what it looks like: https://blob.sh/atul/fb20.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1665 |
129,184 | 11.07.2021 20:58:35 | 14,400 | 87377a11032571aa9b8789775a1a3ab4b8415e2c | [native] Use `SWMansionIcon` for log-in-panel and register-panel
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -4,7 +4,6 @@ import invariant from 'invariant';\nimport * as React from 'react';\nimport { View, StyleSheet, Alert, Keyboard, Platform } from 'react-native';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `SWMansionIcon` for log-in-panel and register-panel
Summary: Here's what it looks like: https://blob.sh/atul/8ca9.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1667 |
129,191 | 07.07.2021 09:25:54 | -7,200 | c232a30bc1355a881865108b4503da0163aae281 | [native] Introduce inner multimedia message
Summary: Split multimedia message and create a new component which will be rendered by the tooltip.
Test Plan: Open a thread with mutimedia message and check if it's rendered correctly
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/inner-multimedia-message.react.js",
"diff": "+// @flow\n+import invariant from 'invariant';\n+import * as React from 'react';\n+import { StyleSheet, View } from 'react-native';\n+\n+import type { Corners, Media } from 'lib/types/medi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce inner multimedia message
Summary: Split multimedia message and create a new component which will be rendered by the tooltip.
Test Plan: Open a thread with mutimedia message and check if it's rendered correctly
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential R... |
129,191 | 07.07.2021 11:03:03 | -7,200 | 869bd0b9929872aed61662d17360714f8b30d576 | [native] Change MultimediaMessage to be a functional component
Summary: This allows us using hooks. Navigation and route props will be used in next diffs.
Test Plan: Open a thread with multimedia message and check if it's correct
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "// @flow\n+import type {\n+ LeafRoute,\n+ NavigationProp,\n+ ParamListBase,\n+} from '@react-navigation/native';\n+import { useNavigation, useRoute } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Change MultimediaMessage to be a functional component
Summary: This allows us using hooks. Navigation and route props will be used in next diffs.
Test Plan: Open a thread with multimedia message and check if it's correct
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential ... |
129,191 | 07.07.2021 12:12:04 | -7,200 | 0ba8cee32d9a10682803e90c00f0132fffbc633a | [native] Introduce multimedia message utils
Summary: There are a couple of functions defined next to components and it causes circular dependencies. This diff moves the functions to one common place.
Test Plan: Test multimedia message functionality.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-item-height-measurer.react.js",
"new_path": "native/chat/chat-item-height-measurer.react.js",
"diff": "@@ -16,7 +16,7 @@ import { composedMessageMaxWidthSelector } from './composed-message-width';\nimport { dummyNodeForRobotextMessageHeightMea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce multimedia message utils
Summary: There are a couple of functions defined next to components and it causes circular dependencies. This diff moves the functions to one common place.
Test Plan: Test multimedia message functionality.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian,... |
129,191 | 07.07.2021 12:19:55 | -7,200 | 198ff4026d384ba972a74e60574f188cfc6d833a | [native] Extract stableKey to a common place
Summary: This function will be used in two places so I extracted it to a common place
Test Plan: Open multimedia modal.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "@@ -12,7 +12,6 @@ import * as React from 'react';\nimport { View, StyleSheet } from 'react-native';\nimport Animated from 'react-nat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extract stableKey to a common place
Summary: This function will be used in two places so I extracted it to a common place
Test Plan: Open multimedia modal.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1635 |
129,191 | 07.07.2021 13:50:09 | -7,200 | 1a7d3f84b54058fe929084be1bf85a2d587da5e3 | [native] Add on press props
Summary: Add an option to provide onPress callbacks. We will use onLongPress later to display a tooltip.
Test Plan: Check if opening image modal still works.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inline-multimedia.react.js",
"new_path": "native/chat/inline-multimedia.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { View, StyleSheet, Text, TouchableWithoutFeedback } from 'react-native';\n+import { View, StyleSheet, Te... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add on press props
Summary: Add an option to provide onPress callbacks. We will use onLongPress later to display a tooltip.
Test Plan: Check if opening image modal still works.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D16... |
129,191 | 07.07.2021 13:56:50 | -7,200 | 3d2525896eef05f26ec39e1882e0b3499ac94dc7 | [native] Render the whole message as a tooltip button
Summary: Render inner multimedia message and modify navigation props to contain exactly the info that is needed
Test Plan: Tested with the next diff
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-tooltip-button.react.js",
"new_path": "native/chat/multimedia-tooltip-button.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { View, StyleSheet } from 'react-native';\nimport Animated from 'react-native-reanimated'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Render the whole message as a tooltip button
Summary: Render inner multimedia message and modify navigation props to contain exactly the info that is needed
Test Plan: Tested with the next diff
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricat... |
129,191 | 07.07.2021 14:14:48 | -7,200 | 3e0529c1ef977c3f19189d28c4889adcebbb280a | [native] Open modal on long press
Summary: Measure the message and navigate to the modal.
Test Plan: Long press a multimedia message with multiple images and check if the whole message was highlighted.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message.react.js",
"new_path": "native/chat/message.react.js",
"diff": "@@ -92,6 +92,7 @@ class Message extends React.PureComponent<Props> {\n<MultimediaMessage\nitem={this.props.item}\nfocused={this.props.focused}\n+ toggleFocus={this.props.toggle... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Open modal on long press
Summary: Measure the message and navigate to the modal.
Test Plan: Long press a multimedia message with multiple images and check if the whole message was highlighted.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricato... |
129,191 | 09.07.2021 16:10:20 | -7,200 | a54630f74e4c13109dac42f4eaed5cc25a9ebdc2 | [native] Delete onLongPress prop from InlineMultimedia
Summary: It's no longer needed. OnLongPress is handled on message level instead.
Test Plan: Flow
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inline-multimedia.react.js",
"new_path": "native/chat/inline-multimedia.react.js",
"diff": "@@ -17,7 +17,6 @@ import Multimedia from '../media/multimedia.react';\ntype Props = {|\n+mediaInfo: MediaInfo,\n+onPress: () => void,\n- +onLongPress?: () =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delete onLongPress prop from InlineMultimedia
Summary: It's no longer needed. OnLongPress is handled on message level instead.
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1649 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.