author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,184 | 12.07.2021 11:55:02 | 14,400 | c28559e08ddacd1231304da3c81403dcf9e2fceb | [native] Restyle `Calendar` component
Summary:
Before:
After:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -1030,7 +1030,7 @@ const unboundStyles = {\nbottom: 0,\n},\nsectionHeader: {\n- backgroundColor: 'listSeparator',\n+ backgroundColor: 'panelForeground',\nborderBot... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle `Calendar` component
Summary:
Before: https://blob.sh/atul/caledar-reskin-before.png
After: https://blob.sh/atul/calendar-reskin-after.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com... |
129,184 | 12.07.2021 12:32:46 | 14,400 | f1b501efbb831240d069e8f38ad450b00fc2d9dc | [native] Restyle `SaveSettingButton`
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/save-setting-button.react.js",
"new_path": "native/chat/settings/save-setting-button.react.js",
"diff": "import * as React from 'react';\nimport { TouchableOpacity } from 'react-native';\n-import Icon from 'react-native-vector-icons/Ionico... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle `SaveSettingButton`
Summary: Here's how it looks: https://blob.sh/atul/d355.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1670 |
129,184 | 12.07.2021 13:57:51 | 14,400 | 515e2458c660c9163e2780cd19120c50723bd53d | [native] Restyle check mark
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/profile/appearance-preferences.react.js",
"new_path": "native/profile/appearance-preferences.react.js",
"diff": "import * as React from 'react';\nimport { View, Text, ScrollView, Platform } from 'react-native';\n-import Icon from 'react-native-vector-ic... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle check mark
Summary: Here's what it looks like: https://blob.sh/atul/3d1b.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1671 |
129,184 | 12.07.2021 14:31:31 | 14,400 | 78abc2a03330e25ae5b670129fbbd28f986937aa | [native] Restyle preference buttons
Summary: Here's how it looks:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/profile/appearance-preferences.react.js",
"new_path": "native/profile/appearance-preferences.react.js",
"diff": "@@ -65,6 +65,7 @@ class AppearancePreferences extends React.PureComponent<Props> {\nstyle={this.props.styles.row}\niosFormat=\"highlight\"\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle preference buttons
Summary: Here's how it looks: https://blob.sh/atul/preference-button-selected.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1672 |
129,184 | 12.07.2021 14:57:42 | 14,400 | d1762b3c1cbcacf6c9bd534c9d8a84936f32004e | [native] Change `ParentThreadHeader` background and add bottom border
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/parent-thread-header.react.js",
"new_path": "native/chat/parent-thread-header.react.js",
"diff": "@@ -51,7 +51,9 @@ const height = 48;\nconst unboundStyles = {\ncontainer: {\nheight,\n- backgroundColor: 'modalSubtext',\n+ backgroundColor: 'panelFor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Change `ParentThreadHeader` background and add bottom border
Summary: Here's what it looks like: https://blob.sh/atul/5757.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1673 |
129,184 | 12.07.2021 15:20:06 | 14,400 | ac904b4a3d5d9a686584268bc373844f5413eb23 | Tweak `ThreadSettingsDescription` style
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-description.react.js",
"new_path": "native/chat/settings/thread-settings-description.react.js",
"diff": "@@ -142,6 +142,7 @@ class ThreadSettingsDescription extends React.PureComponent<Props> {\nstyle={this.props.styles.add... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Tweak `ThreadSettingsDescription` style
Summary: Here's what it looks like: https://blob.sh/atul/d220.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1674 |
129,184 | 12.07.2021 15:57:05 | 14,400 | 9dd835eecd3c1ddeb6a42649ba506178546527de | [native] Use `SWMansionIcon` for `ThreadIcon`s
Summary:
Here's how it looks like in various usages:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/compose-subthread-modal.react.js",
"new_path": "native/chat/settings/compose-subthread-modal.react.js",
"diff": "import * as React from 'react';\nimport { Text } from 'react-native';\nimport IonIcon from 'react-native-vector-icons/Ionicons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `SWMansionIcon` for `ThreadIcon`s
Summary:
Here's how it looks like in various usages:
https://blob.sh/atul/75aa.png
https://blob.sh/atul/48d2.png
https://blob.sh/atul/5e6e.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revisi... |
129,184 | 12.07.2021 16:28:21 | 14,400 | 7867621ed8d8570765e97c7aba84bd3e2aaa6482 | [native] Use `threadInfo.color` as `selectionColor` for `ThreadSettingsName` and `ThreadSettingsDescription`
Summary: Here's how it looks:
Test Plan: Looks as expected (though will check w/ design team and possibly revert)
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-description.react.js",
"new_path": "native/chat/settings/thread-settings-description.react.js",
"diff": "@@ -100,6 +100,7 @@ class ThreadSettingsDescription extends React.PureComponent<Props> {\neditable={this.props.loading... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `threadInfo.color` as `selectionColor` for `ThreadSettingsName` and `ThreadSettingsDescription`
Summary: Here's how it looks: https://blob.sh/atul/7336.png
Test Plan: Looks as expected (though will check w/ design team and possibly revert)
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, paly... |
129,184 | 12.07.2021 17:32:00 | 14,400 | 5b69534059c4c8fa2c1edf1372b660870e31616f | [native] Introduce `BackgroundTabIllustration`
Summary:
Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/background-chat-thread-list.react.js",
"new_path": "native/chat/background-chat-thread-list.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { Text } from 'react-native';\n+import { Text, View } from 'react-native';\nimport { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `BackgroundTabIllustration`
Summary:
Here's what it looks like: https://blob.sh/atul/3e9c.png
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1677 |
129,191 | 13.07.2021 11:37:13 | -7,200 | 7688f3767cf278ff475fb0073e1460053afbe8df | [native] Rename multimedia tooltip modal
Summary: Rename multimedia tooltip to multimedia message tooltip
Test Plan: Open a multimedia message tooltip
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "RENAME",
"old_path": "native/chat/multimedia-tooltip-button.react.js",
"new_path": "native/chat/multimedia-message-tooltip-button.react.js",
"diff": "@@ -16,11 +16,11 @@ const { Value } = Animated;\nfunction noop() {}\ntype Props = {|\n- +navigation: AppNavigationProp<'MultimediaTo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename multimedia tooltip modal
Summary: Rename multimedia tooltip to multimedia message tooltip
Test Plan: Open a multimedia message tooltip
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1683 |
129,184 | 13.07.2021 11:48:39 | 14,400 | c49a568e6be013f9dd910cdf1c24fbdbfd8f6720 | [native] Apply `threadInfo.color` to chat input bar icons
Summary: Here's what it looks like:
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -201,7 +201,7 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nconst expandoButtonsWidth = interpolate(expandoButtonsOpen, {\ninputRange: [0,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Apply `threadInfo.color` to chat input bar icons
Summary: Here's what it looks like: https://blob.sh/atul/chatinputbarcolor.mp4
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1684 |
129,184 | 14.07.2021 15:05:32 | 14,400 | 067d4822c170a5b5cdfd795a01b1a3ffb38bd4e2 | [server] Resolve issue where empty array was being passed into `insertQuery` in `updateChangedUndirectedRelationships`
Summary: na
Test Plan: na
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/relationship-updaters.js",
"new_path": "server/src/updaters/relationship-updaters.js",
"diff": "@@ -255,7 +255,7 @@ async function updateUndirectedRelationships(\nasync function updateChangedUndirectedRelationships(\nchangeset: UndirectedRe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Resolve issue where empty array was being passed into `insertQuery` in `updateChangedUndirectedRelationships`
Summary: na
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1693 |
129,184 | 13.07.2021 20:07:11 | 14,400 | 60aeb682f59c545257d192fa4c6cc6d3c8bafe56 | [native] Add `SDWebImage` dependency to `@react-native-community/clipboard`
Test Plan: Was able to use `SDWebImage` dependency as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -396,6 +396,7 @@ PODS:\n- React\n- RNCClipboard (1.5.1):\n- React-Core\n+ - SDWebImage (~> 5.8)\n- RNCMaskedView (0.1.10):\n- React\n- RNDeviceInfo (8.0.7):\n@@ -789,7 +790,7 @@ SPEC ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add `SDWebImage` dependency to `@react-native-community/clipboard`
Test Plan: Was able to use `SDWebImage` dependency as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1689 |
129,184 | 13.07.2021 20:29:24 | 14,400 | 1add786fa360dfdd33277a817dabef3d24780e9b | [native] Introduce `setImageFromURL`
Test Plan: Was able to paste images added to `NSPasteboard` via `setImageFromURL`
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "patches/@react-native-community+clipboard+1.5.1.patch",
"new_path": "patches/@react-native-community+clipboard+1.5.1.patch",
"diff": "@@ -9,80 +9,11 @@ index 095b496..b19b07f 100644\n+ s.dependency 'SDWebImage', '~> 5.8'\n+\nend\n-diff --git a/node_modules/@re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `setImageFromURL`
Test Plan: Was able to paste images added to `NSPasteboard` via `setImageFromURL`
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1690 |
129,184 | 14.07.2021 13:17:50 | 14,400 | 8bda052c6b534dc2f3bdeaff25b33fd811f46407 | [native] Add copy image functionality to `ImageModal` on iOS
Summary: Here's how it looks:
Test Plan: Tested on iPhone 12 Pro where it worked as expected. Tested on android emulator where the "copy button" didn't show up (as expected)
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/image-modal.react.js",
"new_path": "native/media/image-modal.react.js",
"diff": "// @flow\n+import Clipboard from '@react-native-community/clipboard';\nimport invariant from 'invariant';\nimport * as React from 'react';\nimport {\n@@ -24,6 +25,7 @... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add copy image functionality to `ImageModal` on iOS
Summary: Here's how it looks: https://blob.sh/atul/4592.png
Test Plan: Tested on iPhone 12 Pro where it worked as expected. Tested on android emulator where the "copy button" didn't show up (as expected)
Reviewers: ashoat
Reviewed By: ashoat
Subscribers:... |
129,184 | 14.07.2021 16:26:50 | 14,400 | f3c7c4b6071e3d7ddd645e02db8cc84b52c52845 | [native] Change "Threads" -> "Inbox" in top tab bar and "Chat" -> "Inbox" in bottom tab bar
Summary: na
Test Plan: Looks as expected
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -183,7 +183,7 @@ const header = (props: CoreStackHeaderProps) => {\nconst headerBackButton = (props) => <HeaderBackButton {...props} />;\nconst chatThreadListOptions = ({ navigati... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Change "Threads" -> "Inbox" in top tab bar and "Chat" -> "Inbox" in bottom tab bar
Summary: na
Test Plan: Looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1694 |
129,187 | 14.07.2021 23:09:16 | 14,400 | e5f7094a8844af2c70991681f36c46efb525ce84 | [native] codeVersion -> 91 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -282,8 +282,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 91 |
129,187 | 21.03.2021 23:02:13 | 14,400 | f5ad72eb3ae1ae48aa15e7854bb977db5121bbf4 | RN0.64 3/*: Update Flow
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "landing/.flowconfig",
"new_path": "landing/.flowconfig",
"diff": "@@ -9,6 +9,8 @@ module.name_mapper.extension='css' -> '<PROJECT_ROOT>/flow/CSSModule.js.flow'\nesproposal.optional_chaining=enable\nesproposal.nullish_coalescing=enable\n+exact_by_default=true\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 3/*: Update Flow
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricat... |
129,187 | 21.03.2021 23:32:21 | 14,400 | f715fce54f9a82a0a78f9429de066ed3e6e35a7c | RN0.64 6/*: Miscellaneous config file changes
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": ".eslintrc.json",
"new_path": ".eslintrc.json",
"diff": "\"plugin:import/errors\",\n\"plugin:import/warnings\",\n\"plugin:prettier/recommended\",\n- \"prettier/react\",\n- \"prettier/flowtype\"\n+ \"prettier\"\n],\n\"parser\": \"babel-eslint\",\n\"plugins\": [\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 6/*: Miscellaneous config file changes
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revis... |
129,187 | 21.03.2021 23:41:58 | 14,400 | ad2e64cd1b7387367935fd09a8c18a10ec7cd69d | RN0.64 7/*: Android updates
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/CMakeLists.txt",
"new_path": "native/android/app/CMakeLists.txt",
"diff": "@@ -59,9 +59,9 @@ add_library(\n# Provides a relative path to your source file(s).\n../../node_modules/react-native/ReactCommon/jsi/jsi/jsi.cpp\n../../node_modules/re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 7/*: Android updates
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabr... |
129,187 | 21.03.2021 23:47:34 | 14,400 | a9e8c01ee1a5dde4c87f3dd31d0e5f3bfadede7f | RN0.64 8/*: iOS updates
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "COPY_PHASE_STRIP = NO;\nENABLE_STRICT_OBJC_MSGSEND = YES;\nENABLE_TESTABILITY = YES;\n+ \"EXCLUDED_ARCHS[sdk=iphonesimulator*]\" = \"arm64 \";\nGCC_C_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 8/*: iOS updates
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricat... |
129,187 | 22.03.2021 23:35:00 | 14,400 | c34e5c46ab90cefade02c8e5243907b167a30e63 | RN0.64 9/*: Fix action export Flow types
Summary:
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/activity-actions.js",
"new_path": "lib/actions/activity-actions.js",
"diff": "@@ -14,9 +14,9 @@ const updateActivityActionTypes = Object.freeze({\nsuccess: 'UPDATE_ACTIVITY_SUCCESS',\nfailed: 'UPDATE_ACTIVITY_FAILED',\n});\n-const updateActivity = ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 9/*: Fix action export Flow types
Summary: https://flow.org/en/docs/lang/types-first/
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subs... |
129,187 | 23.03.2021 00:47:49 | 14,400 | bb9ee3119a9f3721007eb087d819d56f0b2aebee | RN0.64 11/*: Fix simple-markdown Flow types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "@@ -6,51 +6,100 @@ import type { RelativeMemberInfo } from '../types/thread-types';\nimport { oldValidUsernameRegexString } from './account-utils';\n// simple-markdown types\n-type State =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 11/*: Fix simple-markdown Flow types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revisio... |
129,187 | 23.03.2021 01:09:20 | 14,400 | 2e7eec76ac46f7b0a0807d432fe82d8384d3d6e8 | RN0.64 12/*: Fix socket export Flow types
Summary:
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/activity-handler.react.js",
"new_path": "lib/socket/activity-handler.react.js",
"diff": "@@ -16,7 +16,7 @@ type Props = {|\n+activeThread: ?string,\n+frozen: boolean,\n|};\n-function ActivityHandler(props: Props) {\n+function ActivityHandler(props: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 12/*: Fix socket export Flow types
Summary: https://flow.org/en/docs/lang/types-first/
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Sub... |
129,187 | 26.03.2021 16:55:39 | 14,400 | 13cca2e952d834b1e270e8de74fb8119ffccca4b | RN0.64 16/*: Update react-hot-loader libdef
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/flow-typed/npm/react-hot-loader_v4.6.x.js",
"new_path": "web/flow-typed/npm/react-hot-loader_v4.6.x.js",
"diff": "-// flow-typed signature: 13db9b002bb52d52588a74ebc12f93e0\n-// flow-typed version: c6154227d1/react-hot-loader_v4.6.x/flow_>=v0.53.0 <=v0.103... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 16/*: Update react-hot-loader libdef
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revisio... |
129,187 | 28.03.2021 01:13:12 | 14,400 | 71baeec0859d9b7ce2e3b9e99f6fa70592fe5d83 | RN0.64 17/*: Update react-timeago to get new Flow types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "\"react-router\": \"^5.2.0\",\n\"react-router-dom\": \"^5.2.0\",\n\"react-switch\": \"^5.0.1\",\n- \"react-timeago\": \"^4.4.0\",\n+ \"react-timeago\": \"^5.2.0\",\n\"redux\": \"^4.0.4\",\n\"redux-dev... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 17/*: Update react-timeago to get new Flow types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differen... |
129,187 | 28.03.2021 14:54:15 | 14,400 | c96788b131012cb066a07219ec0d11cd1ebcb16c | RN0.64 18/*: Type web RouterHistory and update related libdefs
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/history_v4.x.x.js",
"new_path": "server/flow-typed/npm/history_v4.x.x.js",
"diff": "-// flow-typed signature: e461b9fe923a5f62ed607392b0742c02\n-// flow-typed version: c6154227d1/history_v4.x.x/flow_>=v0.25.x <=v0.103.x\n+// flow-typed si... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 18/*: Type web RouterHistory and update related libdefs
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
D... |
129,187 | 28.03.2021 15:55:43 | 14,400 | 923952b87acf37a6366c5c3368ff564c2fefcdc7 | RN0.64 21/*: Fix server SQL types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/flow-typed/npm/mysql_v2.x.x.js",
"diff": "+// flow-typed signature: c19cdbb02c8406091b029b937c58fb76\n+// flow-typed version: eaa5f54644/mysql_v2.x.x/flow_>=v0.104.x\n+\n+// TODO: Events on event emitters\n+// TODO: Ssl structure type in ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 21/*: Fix server SQL types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https:/... |
129,187 | 28.03.2021 21:58:45 | 14,400 | b0a5a382d1ed41d74c1ce14537b9c2574aa302d9 | RN0.64 22/*: Add rereadable-stream libdef
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/flow-typed/npm/rereadable-stream_vx.x.x.js",
"diff": "+// flow-typed signature: d2fab7bd2a9cee86a71d4dbf7d7d6fbc\n+// flow-typed version: <<STUB>>/rereadable-stream_v1.4.5/flow_v0.137.0\n+\n+/**\n+ * This is an autogenerated libdef stub f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 22/*: Add rereadable-stream libdef
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision:... |
129,187 | 19.04.2021 21:25:47 | 14,400 | d462bc6f9a5316e3b271d1e625ca79b7cd574264 | RN0.64 26/*: Fix up message types in message-fetchers.js code
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/message-fetchers.js",
"new_path": "server/src/fetchers/message-fetchers.js",
"diff": "@@ -10,6 +10,8 @@ import { messageSpecs } from 'lib/shared/messages/message-specs';\nimport { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 26/*: Fix up message types in message-fetchers.js code
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Di... |
129,187 | 19.04.2021 21:27:45 | 14,400 | 0490ee5b7110ace52e8e15224a9d9882f382d01f | RN0.64 29/*: Partially type nodemailer package
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/sendmail.js",
"new_path": "server/src/emails/sendmail.js",
"diff": "import nodemailer from 'nodemailer';\n-const sendmail = nodemailer.createTransport({ sendmail: true });\n+type MailInfo = {\n+ +from: string,\n+ +to: string,\n+ +subject: str... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 29/*: Partially type nodemailer package
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revi... |
129,187 | 19.04.2021 21:28:42 | 14,400 | 168590bdc137e845ad47c69c8aaea729855b3488 | RN0.64 30/*: Fix remaining server export Flow types
Summary:
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -51,7 +51,7 @@ import type { UpdatesForCurrentSession } from './update-creator';\nconst { commbot } = bots;\n-const privateThreadDescription =\n+const priv... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 30/*: Fix remaining server export Flow types
Summary: https://flow.org/en/docs/lang/types-first/
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: paly... |
129,187 | 09.07.2021 11:37:41 | 14,400 | 9d04079f71977dec82acfb498d651f5f389d348f | RN0.64 31/*: Fix navigateToSidebar type
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/sidebar-navigation.js",
"new_path": "native/chat/sidebar-navigation.js",
"diff": "@@ -7,27 +7,17 @@ import type { AppNavigationProp } from '../navigation/app-navigator.react';\nimport type { TooltipRoute } from '../navigation/tooltip.react';\nimpor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 31/*: Fix navigateToSidebar type
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: h... |
129,187 | 13.07.2021 16:32:23 | 14,400 | 1968e8dbc733030ad35fbda76615a93e7aba96e0 | RN0.64 36/*: Fix native simple-markdown types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/markdown/rules.react.js",
"new_path": "native/markdown/rules.react.js",
"diff": "@@ -15,7 +15,7 @@ import MarkdownLink from './markdown-link.react';\nimport { getMarkdownStyles } from './styles';\nexport type MarkdownRules = {|\n- +simpleMarkdownRules: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 36/*: Fix native simple-markdown types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revis... |
129,187 | 14.07.2021 15:53:45 | 14,400 | 543c42cb2f9d24c1ca45195e40e8d51532941d27 | RN0.64 37/*: Update Redux libdef
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/flow-typed/npm/redux_v4.x.x.js",
"new_path": "lib/flow-typed/npm/redux_v4.x.x.js",
"diff": "-// flow-typed signature: 99b2d8ebd0ab4be20976dc62a3bbf54c\n-// flow-typed version: c6154227d1/redux_v4.x.x/flow_>=v0.89.x <=v0.103.x\n+// flow-typed signature: cf5... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 37/*: Update Redux libdef
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https://... |
129,187 | 15.07.2021 17:24:42 | 14,400 | b6b486c7cdca4368391939f241856bb11521a1cb | RN0.64 41/*: Patch react-native-firebase Flow types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "patches/react-native-firebase+5.6.0.patch",
"new_path": "patches/react-native-firebase+5.6.0.patch",
"diff": "+diff --git a/node_modules/react-native-firebase/dist/common/commonTypes.flow.js.flow b/node_modules/react-native-firebase/dist/common/commonTypes.flo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.64 41/*: Patch react-native-firebase Flow types
Test Plan:
I tested the whole upgrade together:
1. Compile and run iOS and Android on release and debug
2. Make sure Flow typechecks
3. Make sure debugging tools still work
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential... |
129,187 | 16.07.2021 14:37:17 | 14,400 | 5c828a6023207a9092056a360d39585bc4c1a57e | [native] Fix unstable checksum for FBReactNativeSpec
Summary: This fixes [this GitHub issue](https://github.com/facebook/react-native/issues/31193) by pulling in [the commit](https://github.com/facebook/react-native/commit/bdfe2a51791046c4e6836576e08655431373ed67) that resolved it.
Test Plan: `pod install`
Reviewers: a... | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -765,7 +765,7 @@ SPEC CHECKSUMS:\nEXPermissions: 24b97f734ce9172d245a5be38ad9ccfcb6135964\nEXSplashScreen: c4ed5d39cd5dbc1329f8dec720e280276bafa28b\nFBLazyVector: 49cbe4b43e445b06bf29... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix unstable checksum for FBReactNativeSpec
Summary: This fixes [this GitHub issue](https://github.com/facebook/react-native/issues/31193) by pulling in [the commit](https://github.com/facebook/react-native/commit/bdfe2a51791046c4e6836576e08655431373ed67) that resolved it.
Test Plan: `pod install`
Reviewers... |
129,187 | 16.07.2021 23:35:55 | 14,400 | f817a59721bd6cf18fc0d9c405883609456a25fc | [native] Deprecate androidKeyboardResizesFrame
Summary:
React Native 0.64 no longer supports Android 4. The new `minSdkVersion` is 21, so `androidKeyboardResizesFrame` should always be `false`.
This diff removes all the code associated with `androidKeyboardResizesFrame`.
Test Plan: Flow
Reviewers: atul, palys-swm
Subsc... | [
{
"change_type": "MODIFY",
"old_path": "native/components/keyboard-avoiding-view.react.js",
"new_path": "native/components/keyboard-avoiding-view.react.js",
"diff": "@@ -11,7 +11,6 @@ import {\n} from 'react-native';\nimport type { ScreenRect, KeyboardEvent } from '../keyboard/keyboard';\n-import { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Deprecate androidKeyboardResizesFrame
Summary:
React Native 0.64 no longer supports Android 4. The new `minSdkVersion` is 21, so `androidKeyboardResizesFrame` should always be `false`.
This diff removes all the code associated with `androidKeyboardResizesFrame`.
Test Plan: Flow
Reviewers: atul, palys-swm
... |
129,187 | 16.07.2021 23:33:02 | 14,400 | a9ce31751baad21d824f8d584a9cb1c09e438416 | [native] Get rid of assorted JS Android 4 hacks
Summary: React Native 0.64 no longer supports Android 4. The new `minSdkVersion` is 21, so we can get rid of these hacks we had in place.
Test Plan: Flow
Reviewers: atul, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "import invariant from 'invariant';\nimport * as React from 'react';\n-import { StyleSheet, View, Platform } from 'react-native';\n+import { StyleSheet, View }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of assorted JS Android 4 hacks
Summary: React Native 0.64 no longer supports Android 4. The new `minSdkVersion` is 21, so we can get rid of these hacks we had in place.
Test Plan: Flow
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricat... |
129,187 | 17.07.2021 16:33:50 | 14,400 | e40f2154b2ebbab5b5c1e3dc27c6099df739a226 | [native] Patch React Native to prepare for Hermes and Flipper 0.98
Summary: These patches are necessary for both to work together.
Test Plan: Tested in combination with following diffs
Reviewers: atul, palys-swm, karol-bisztyga
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -118,13 +118,13 @@ PODS:\n- RCT-Folly (2021.04.26.00):\n- boost-for-react-native\n- DoubleConversion\n- - fmt\n+ - fmt (~> 6.2.1)\n- glog\n- RCT-Folly/Default (= 2021.04.26.00)\n- RCT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Patch React Native to prepare for Hermes and Flipper 0.98
Summary: These patches are necessary for both to work together.
Test Plan: Tested in combination with following diffs
Reviewers: atul, palys-swm, karol-bisztyga
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricato... |
129,187 | 17.07.2021 01:37:07 | 14,400 | b6e788adc7463a2176f77b0cdd316c0ee8668e32 | [native] Update to
Test Plan: Tested in combination with following diffs
Reviewers: atul, palys-swm, karol-bisztyga
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -27,14 +27,14 @@ PODS:\n- UMPermissionsInterface\n- EXSplashScreen (0.3.1):\n- UMCore\n- - FBLazyVector (0.64.0)\n- - FBReactNativeSpec (0.64.0):\n+ - FBLazyVector (0.64.2)\n+ - FBRea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update to react-native@0.64.2
Test Plan: Tested in combination with following diffs
Reviewers: atul, palys-swm, karol-bisztyga
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1752 |
129,187 | 17.07.2021 01:17:39 | 14,400 | faef6f5449e45cb54f2b892a3da9ed8c5346b288 | [native] Enable Hermes on iOS
Test Plan:
1. Compile and run iOS in debug and release
2. Confirm Hermes is running via `global.HermesInternal`
3. In debug, make sure Hermes can connect with Flipper debugger
Reviewers: atul, palys-swm, karol-bisztyga
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": ");\ninputPaths = (\n\"${PODS_ROOT}/Target Support Files/Pods-Comm/Pods-Comm-frameworks.sh\",\n+ \"${PODS_ROOT}/hermes-engine/destroot/Library/Framewor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Enable Hermes on iOS
Test Plan:
1. Compile and run iOS in debug and release
2. Confirm Hermes is running via `global.HermesInternal`
3. In debug, make sure Hermes can connect with Flipper debugger
Reviewers: atul, palys-swm, karol-bisztyga
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision... |
129,187 | 17.07.2021 17:34:23 | 14,400 | 80c81dd3896f4812359d07e1730550973c586cdf | [native] Update to
Summary: Deleting and regenerating `Podfile.lock` to pick up newer version of `SDWebImage`.
Test Plan: Compile and run iOS in debug and release
Reviewers: atul, palys-swm, karol-bisztyga
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -464,9 +464,9 @@ PODS:\n- React\n- RNVectorIcons (6.6.0):\n- React\n- - SDWebImage (5.9.3):\n- - SDWebImage/Core (= 5.9.3)\n- - SDWebImage/Core (5.9.3)\n+ - SDWebImage (5.11.1):\n+ - ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update to SDWebImage@5.11.1
Summary: Deleting and regenerating `Podfile.lock` to pick up newer version of `SDWebImage`.
Test Plan: Compile and run iOS in debug and release
Reviewers: atul, palys-swm, karol-bisztyga
Reviewed By: atul
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.as... |
129,190 | 19.07.2021 08:55:25 | -7,200 | 9fb9b7cd02145d144dc662474624c77b0690fe92 | [native] public keys - Add creator and deleter
Summary: Add creator and deleter for one-time keys
Test Plan: testing code is in D1582
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/creators/one-time-keys-creator.js",
"diff": "+// @flow\n+\n+import { dbQuery, SQL } from '../database/database';\n+import type { Viewer } from '../session/viewer';\n+\n+async function saveOneTimeKeys(\n+ viewer: Viewer,\n+ oneTimeKeys... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] public keys - Add creator and deleter
Summary: Add creator and deleter for one-time keys
Test Plan: testing code is in D1582
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1579 |
129,190 | 19.07.2021 10:11:34 | -7,200 | 26209e09f0a93fadd02b667ff1830b7c97d68f53 | [native] public keys - add types
Summary: Add types for user's public identity keys and one-time keys
Test Plan: testing code is in D1582
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/types/request-types.js",
"new_path": "lib/types/request-types.js",
"diff": "@@ -30,6 +30,7 @@ export const serverRequestTypes = Object.freeze({\nENTRY_INCONSISTENCY: 5,\nCHECK_STATE: 6,\nINITIAL_ACTIVITY_UPDATES: 7,\n+ MORE_ONE_TIME_KEYS: 8,\n});\ntype Ser... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] public keys - add types
Summary: Add types for user's public identity keys and one-time keys
Test Plan: testing code is in D1582
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1580 |
129,190 | 19.07.2021 10:11:56 | -7,200 | 3f4c683e0ab59b5d63fa6b02a8404047cb9f3940 | [native] public keys - add fetcher, responder, endpoints
Summary: todo
Test Plan: testing code is in D1582
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/types/endpoints.js",
"new_path": "lib/types/endpoints.js",
"diff": "@@ -75,6 +75,7 @@ const socketPreferredEndpoints = Object.freeze({\nCREATE_MULTIMEDIA_MESSAGE: 'create_multimedia_message',\nDELETE_UPLOAD: 'delete_upload',\nUPDATE_RELATIONSHIPS: 'update_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] public keys - add fetcher, responder, endpoints
Summary: todo
Test Plan: testing code is in D1582
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1581 |
129,187 | 19.07.2021 22:13:58 | 14,400 | 0841660126a73a14099fe6ff550f2dde0b832fbb | [native] Update to
Test Plan: Test iOS and Android and make sure animations still work
Reviewers: karol-bisztyga, palys-swm
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -452,8 +452,8 @@ PODS:\n- SDWebImageWebPCoder (~> 0.6.1)\n- RNFS (2.15.2):\n- React\n- - RNGestureHandler (1.8.0):\n- - React\n+ - RNGestureHandler (1.10.3):\n+ - React-Core\n- RNKeyc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update to react-native-gesture-handler@1.10.3
Test Plan: Test iOS and Android and make sure animations still work
Reviewers: karol-bisztyga, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1763 |
129,191 | 19.07.2021 11:06:09 | -7,200 | 9d11a3c31cb53f6b582200f38898bb962f765089 | [native] Move chatMessageItemHeight to utils
Summary: We do this to avoid a require loop
Test Plan: Open a thread and check if it is rendered correctly
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -29,8 +29,8 @@ import type { ScrollEvent } from '../types/react-native';\nimport type { ViewStyle } from '../types/styles';\nimport type { ChatNavigationProp } from './c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move chatMessageItemHeight to utils
Summary: We do this to avoid a require loop
Test Plan: Open a thread and check if it is rendered correctly
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1756 |
129,191 | 20.07.2021 16:34:03 | -7,200 | 4d50a2d7278a2299842a5e3cbe7838a4bdbfef71 | [native] Store currentTransitionSidebarSourceID in the context
Summary: We would like to store this outside the redux. The first step is to create a place to store it in the context.
Test Plan: Tested with next diffs
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/types/hook-types.js",
"diff": "+// @flow\n+\n+export type SetState<T> = ((T => T) | T) => void;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-context-provider.react.js",
"new_path": "native/chat/chat-context-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Store currentTransitionSidebarSourceID in the context
Summary: We would like to store this outside the redux. The first step is to create a place to store it in the context.
Test Plan: Tested with next diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: htt... |
129,191 | 21.07.2021 11:52:47 | -7,200 | 96a944eedf8a1e16e00558a786221e2c7bae480e | [native] Delete currentTransitionSidebarSourceID from redux
Summary: The last step: we can now delete the state and actions.
Test Plan: Check if opening a sidebar by using a tooltip works correctly including hiding the source message while the navigation is in progress.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atu... | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/default-state.js",
"new_path": "native/navigation/default-state.js",
"diff": "import type { StaleNavigationState } from '@react-navigation/native';\n+import type { BaseNavInfo } from 'lib/types/nav-types';\nimport { fifteenDaysEarlier, fiftee... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delete currentTransitionSidebarSourceID from redux
Summary: The last step: we can now delete the state and actions.
Test Plan: Check if opening a sidebar by using a tooltip works correctly including hiding the source message while the navigation is in progress.
Reviewers: ashoat
Reviewed By: ashoat
Subscr... |
129,187 | 21.07.2021 21:55:48 | 14,400 | a42cb4a1af4baf590e9b6c850de57bcb9c28d41a | [native] Rename linkPressActive to linkModalActive
Summary: Next diff will add a new, similar property to `MarkdownLinkContext` that will also block presses.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message.react.js",
"new_path": "native/chat/text-message.react.js",
"diff": "@@ -85,7 +85,7 @@ type Props = {\n// withOverlayContext\n+overlayContext: ?OverlayContextType,\n// MarkdownLinkContext\n- +linkPressActive: boolean,\n+ +linkIsBlockin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename linkPressActive to linkModalActive
Summary: Next diff will add a new, similar property to `MarkdownLinkContext` that will also block presses.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D1775 |
129,187 | 22.07.2021 14:26:07 | 14,400 | 0adcd13d8c97d03006405d39dd65bcee6a008dde | [lib] Refactor createPendingSidebar to improve readability
Summary: This diff should be a no-op, just moving things around. Longer variable names, colocating relevant code together, etc.
Test Plan: Flow, and tested in combination with following diffs
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -358,33 +358,46 @@ function createPendingThreadItem(\n}\nfunction createPendingSidebar(\n- messageInfo: ComposableMessageInfo | RobotextMessageInfo,\n- threadInfo: ThreadInfo,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Refactor createPendingSidebar to improve readability
Summary: This diff should be a no-op, just moving things around. Longer variable names, colocating relevant code together, etc.
Test Plan: Flow, and tested in combination with following diffs
Reviewers: palys-swm, atul
Reviewed By: atul
Subscribers: KatPo,... |
129,187 | 22.07.2021 14:58:46 | 14,400 | 10e0f48c1849c9904cebc853be9c08675a302270 | [lib] Avoid repeating logic in getThreadOtherUsers
Summary: While refactoring something else I realized this logic was repeated in a couple places.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -223,10 +223,7 @@ function getSingleOtherUser(\nif (!viewerID) {\nreturn undefined;\n}\n-\n- const otherMemberIDs = threadInfo.members\n- .filter(member => member.role && member... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Avoid repeating logic in getThreadOtherUsers
Summary: While refactoring something else I realized this logic was repeated in a couple places.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: atul
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1784 |
129,187 | 22.07.2021 16:50:14 | 14,400 | 81a483481e42a11ef96170e79f77806e9379030e | [native] codeVersion -> 92
Android-only release to solve notifications. (See [Notion task](https://www.notion.so/commapp/Android-fails-to-start-JS-runtime-from-notification-bb01f808f0e44201be941a6fbbc1a4a7).) | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 92
Android-only release to solve notifications. (See [Notion task](https://www.notion.so/commapp/Android-fails-to-start-JS-runtime-from-notification-bb01f808f0e44201be941a6fbbc1a4a7).) |
129,191 | 21.07.2021 13:41:12 | -7,200 | e7fd4338cb5ebf2de87def4ed6962f6edd2dfccb | [native] Create a hook which handles source message animation
Summary: The hook provides message container style and handles making source message visible again.
Test Plan: Tested with the next diff
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/utils.js",
"new_path": "native/chat/utils.js",
"diff": "// @flow\n+import invariant from 'invariant';\nimport * as React from 'react';\n+import Animated from 'react-native-reanimated';\nimport { useMessageListData } from 'lib/selectors/chat-selecto... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create a hook which handles source message animation
Summary: The hook provides message container style and handles making source message visible again.
Test Plan: Tested with the next diff
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.a... |
129,191 | 22.07.2021 16:42:26 | -7,200 | f6d6eaa16156e5798abe531951f93821c72e0992 | [native] Include interpolateColors in reanimated type definition
Summary: We would like to use this function but we need to have types for it first.
Test Plan: Flow.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/react-native-reanimated_v2.x.x.js",
"new_path": "native/flow-typed/npm/react-native-reanimated_v2.x.x.js",
"diff": "@@ -97,6 +97,15 @@ declare module 'react-native-reanimated' {\ninterpolationConfig: InterpolationConfig,\n) => Node;\n+ de... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Include interpolateColors in reanimated type definition
Summary: We would like to use this function but we need to have types for it first.
Test Plan: Flow.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1780 |
129,184 | 22.07.2021 13:40:20 | 14,400 | 0335582e01e36ac8499255e9639215c5af442e86 | [native] SQLite3 migrations
Summary: Support redux `persist.js`-style migrations in for sqlite3
Test Plan: Tested on iOS simulator and device. Android testing in progress
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -13,13 +13,48 @@ using namespace sqlite_orm;\nstd::string SQLiteQueryExecutor::sqliteFilePath;\n-void SQLit... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] SQLite3 migrations
Summary: Support redux `persist.js`-style migrations in for sqlite3
Test Plan: Tested on iOS simulator and device. Android testing in progress
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1781 |
129,191 | 23.07.2021 12:11:55 | -7,200 | fdab623dfdb558fe2ebc46b789b787898f637877 | [native] Animate message background color
Summary: Interpolate colors and use the result as a background of the message.
Test Plan: Navigate using tooltip to a sidebar with different thread color that its parent and check if the message is animated correctly.
Reviewers: ashoat
Subscribers: KatPo, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message-tooltip-button.react.js",
"new_path": "native/chat/text-message-tooltip-button.react.js",
"diff": "@@ -36,7 +36,10 @@ function TextMessageTooltipButton(props: Props): React.Node {\n}, [progress, windowWidth, initialCoordinates]);\ncons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Animate message background color
Summary: Interpolate colors and use the result as a background of the message.
Test Plan: Navigate using tooltip to a sidebar with different thread color that its parent and check if the message is animated correctly.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatP... |
129,184 | 20.07.2021 13:38:37 | 14,400 | 7d62de351b657eacf1a62526c7b647a486cc1373 | [lib] Add `Raw...MessageInfo` as valid argument type to `messageContent` for each message spec
Summary: In preparation for (re)using `messageContent` function for `content` column of `messages` table in sqlite
Test Plan: Tested in later diffs
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "@@ -32,7 +32,9 @@ export const addMembersMessageSpec: MessageSpec<\nRawAddMembersMessageInfo,\nAddMembersMessageInfo,\n> = Object.freeze({... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add `Raw...MessageInfo` as valid argument type to `messageContent` for each message spec
Summary: In preparation for (re)using `messageContent` function for `content` column of `messages` table in sqlite
Test Plan: Tested in later diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adr... |
129,184 | 23.07.2021 14:28:39 | 14,400 | 98132e9cf3f75d92de0bce27ad95840ca98fcad9 | [native] Add `messages` table to sqlite
Summary: Add `messages` table to sqlite based on the mysql `messages` table (+future_type column)
Test Plan: Table created as expected:
Reviewers: ashoat
Subscribers: KatPo, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -18,7 +18,7 @@ bool create_drafts_table(sqlite3 *db) {\nsqlite3_exec(\ndb,\n\"CREATE TABLE IF NOT EXISTS dr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add `messages` table to sqlite
Summary: Add `messages` table to sqlite based on the mysql `messages` table (+future_type column)
Test Plan: Table created as expected: https://blob.sh/atul/497f.png
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, palys-swm, Adrian, karol-bisztyga
Differential Rev... |
129,187 | 27.07.2021 01:35:30 | 14,400 | c57f0b6e4ac2504a222492d69ca71949bd1986dc | [native] codeVersion -> 93
Bumping version, but this isn't the real 93. See the v0.0.93 git tag for the real deal
(Non-public release to test Hermes, REA2, swipe-to-create-sidebar, etc.) | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 93
Bumping version, but this isn't the real 93. See the v0.0.93 git tag for the real deal
(Non-public release to test Hermes, REA2, swipe-to-create-sidebar, etc.) |
129,187 | 26.07.2021 20:37:04 | 14,400 | c7081be8fa10e5e701af3174f86f208987801aa5 | [native] Avoid hardcoding offset for delivery icon in SwipeableMessage
Summary: I realized it was possible to avoid this by changing the structure a little bit.
Test Plan: Make sure the animation looks exactly the same before and after
Reviewers: palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -90,20 +90,23 @@ class ComposedMessage extends React.PureComponent<Props> {\n);\n}\n- const fullMessageBoxStyle = [styles.messageBox, messageBoxStyle];\nle... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid hardcoding offset for delivery icon in SwipeableMessage
Summary: I realized it was possible to avoid this by changing the structure a little bit.
Test Plan: Make sure the animation looks exactly the same before and after
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: Adrian, karol-bi... |
129,187 | 26.07.2021 21:14:41 | 14,400 | 6f4a639b02535f5d46abc20581aefc386ce84c10 | [native] Convert composedMessageMaxWidthSelector to Hook
Test Plan: Flow, make sure everything still looks right
Reviewers: palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-item-height-measurer.react.js",
"new_path": "native/chat/chat-item-height-measurer.react.js",
"diff": "@@ -9,10 +9,9 @@ import { messageTypes, type MessageType } from 'lib/types/message-types';\nimport NodeHeightMeasurer from '../components/no... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert composedMessageMaxWidthSelector to Hook
Test Plan: Flow, make sure everything still looks right
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1801 |
129,187 | 26.07.2021 21:19:57 | 14,400 | 9bd07b8694815549fe076ce3a63a00ebd38a7943 | [native] Set width of swipeSnake in SwipeableMessage to messageListScreenWidth
Summary: We want it to be at least as wide as the screen
Test Plan: Make sure I can't pull the snake off screen
Reviewers: palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/swipeable-message.react.js",
"new_path": "native/chat/swipeable-message.react.js",
"diff": "@@ -20,6 +20,7 @@ import FontAwesomeIcon from 'react-native-vector-icons/FontAwesome';\nimport { useColors, useStyles } from '../themes/colors';\nimport typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Set width of swipeSnake in SwipeableMessage to messageListScreenWidth
Summary: We want it to be at least as wide as the screen
Test Plan: Make sure I can't pull the snake off screen
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://phabri... |
129,187 | 26.07.2021 21:30:04 | 14,400 | 64769527b4ab5d0fa9a17355b863a9fee78f63f2 | [native] Use threadColor for SwipeableMessage animation
Test Plan: Test with different thread colors
Reviewers: palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -97,6 +97,7 @@ class ComposedMessage extends React.PureComponent<Props> {\nonSwipeableWillOpen={this.reply}\nisViewer={isViewer}\nmessageBoxStyle={messageB... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use threadColor for SwipeableMessage animation
Test Plan: Test with different thread colors
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1803 |
129,187 | 27.07.2021 00:34:06 | 14,400 | 1b2d85cce829b42444db5a3920414e4c40c7b9c5 | [native] Introduce second SwipeSnake for sidebar in SwipeableMessage
Summary: Woohoo!
Test Plan: Test the interaction extensively on a real phone
Reviewers: palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/swipeable-message.react.js",
"new_path": "native/chat/swipeable-message.react.js",
"diff": "@@ -18,15 +18,16 @@ import Animated, {\n} from 'react-native-reanimated';\nimport type { IconProps } from 'react-native-vector-icons';\nimport FontAwesomeIc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce second SwipeSnake for sidebar in SwipeableMessage
Summary: Woohoo!
Test Plan: Test the interaction extensively on a real phone
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1805 |
129,187 | 27.07.2021 01:11:45 | 14,400 | 73041f3d8ad3f865357aa74a29e8708998227f54 | [native] Navigate to sidebar from SwipeableMessage
Summary: Actually performs the action when the user swipes
Test Plan: Test the threshold on a real phone
Reviewers: palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -19,6 +19,7 @@ import {\n} from './inline-sidebar.react';\nimport { MessageHeader } from './message-header.react';\nimport type { ChatMessageInfoItemWithHe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Navigate to sidebar from SwipeableMessage
Summary: Actually performs the action when the user swipes
Test Plan: Test the threshold on a real phone
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1806 |
129,184 | 27.07.2021 09:55:04 | 14,400 | 6bc65e13cca4f4679241f26829cdb63fd80564d6 | [native] Introduce `Message.h`
Summary: na
Test Plan: na, will know if something is wrong after subsequent diffs
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/DatabaseManagers/entities/Message.h",
"diff": "+#pragma once\n+\n+#include <string>\n+\n+namespace comm {\n+\n+struct Message {\n+ int id;\n+ int thread;\n+ int user;\n+ int type;\n+ int future_type;\n+ std::string content;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `Message.h`
Summary: na
Test Plan: na, will know if something is wrong after subsequent diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1807 |
129,184 | 27.07.2021 09:58:35 | 14,400 | 077bdd9ffd63907b74b288050b24713ec0c65b6a | [native] Get rid of `core-module-shim`
Summary: Got rid of `core-module-shim` altogether
Test Plan: Tested on iOS Simulator on debug/release, will test android before landing
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/data/core-data-provider.react.js",
"new_path": "native/data/core-data-provider.react.js",
"diff": "// @flow\n-import './core-module-shim';\nimport * as React from 'react';\nimport { useSelector } from 'react-redux';\n"
},
{
"change_type": "MODIF... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of `core-module-shim`
Summary: Got rid of `core-module-shim` altogether
Test Plan: Tested on iOS Simulator on debug/release, will test android before landing
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/... |
129,184 | 27.07.2021 10:09:46 | 14,400 | ad98badf8eb4e43efa3cb40924a1188f782e03b7 | [native] Add `messages` table to `sqlite_orm:make_table`
Summary: na
Test Plan: na, will be tested w/ subsequent diffs
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "#pragma once\n#include \"entities/Draft.h\"\n+#include \"entities/Message.h\"\n#include <jsi/jsi.h>\n#include ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add `messages` table to `sqlite_orm:make_table`
Summary: na
Test Plan: na, will be tested w/ subsequent diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1809 |
129,184 | 27.07.2021 10:21:31 | 14,400 | 4f1eb934bfd3851e383beefd7b08224fad6d0bbf | [CommCoreModule] Introduce `removeAllMessages()`
Summary: Introduce `removeAllMessages` to CommCoreModule
Test Plan: Will be tested in subsequent diffs
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -22,6 +22,7 @@ public:\nvirtual bool moveDraft(std::string oldKey, std::string newKey) const = 0;\nvirtual ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce `removeAllMessages()`
Summary: Introduce `removeAllMessages` to CommCoreModule
Test Plan: Will be tested in subsequent diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1810 |
129,184 | 27.07.2021 11:57:05 | 14,400 | dc73337b78a9115c6d7d16c9769e9d4a3d4b5536 | [CommCoreModule] Introduce `getAllMessages()`
Summary: Introduce `getAllMessages` to CommCoreModule
Test Plan: Builds.. will be tested in subsequent diffs
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -23,6 +23,7 @@ public:\nvirtual std::vector<Draft> getAllDrafts() const = 0;\nvirtual void removeAllDrafts(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce `getAllMessages()`
Summary: Introduce `getAllMessages` to CommCoreModule
Test Plan: Builds.. will be tested in subsequent diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1811 |
129,184 | 27.07.2021 12:17:15 | 14,400 | eaa6483c02273a069d2d64d0a8b4d65dfa7a7832 | [native] Introduce `MessageStoreOperation` and `processMessageStoreOperations` to `CommCoreModuleSchema`
Summary: Introducing types + adding `processMessageStoreOperations` function to spec on js side
Test Plan: Will be tested w/ subsequent diffs
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/schema/CommCoreModuleSchema.js",
"new_path": "native/schema/CommCoreModuleSchema.js",
"diff": "import { TurboModuleRegistry } from 'react-native';\nimport type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport';\n-import type { SQLiteMe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `MessageStoreOperation` and `processMessageStoreOperations` to `CommCoreModuleSchema`
Summary: Introducing types + adding `processMessageStoreOperations` function to spec on js side
Test Plan: Will be tested w/ subsequent diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian... |
129,184 | 27.07.2021 14:04:28 | 14,400 | afb7a4de3e7db4134fae603a6cef5590190ef438 | [CommCoreModule] Handle message removal in `processMessageStoreOperations`
Summary: Create list of ids to be removed in `processMessageStoreOperations` and pass to `sqlite_orm:remove<Message>(ids);`
Test Plan: Will test with subsequent diffs
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -24,6 +24,7 @@ public:\nvirtual void removeAllDrafts() const = 0;\nvirtual void removeAllMessages() const =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Handle message removal in `processMessageStoreOperations`
Summary: Create list of ids to be removed in `processMessageStoreOperations` and pass to `sqlite_orm:remove<Message>(ids);`
Test Plan: Will test with subsequent diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, kar... |
129,184 | 27.07.2021 14:59:31 | 14,400 | 6c65c7a507576aaed6eed1b6032223b98599908d | [CommCoreModule] Handle message replacement in `processMessageStoreOperations`
Summary:
Create list of `Message`s to be replaced in `processMessageStoreOperations` and pass to `sqlite_orm:replace(message);`
Currently there is a separate sql query for each message
Test Plan: Will be tested with subsequent diffs
Reviewer... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -25,6 +25,7 @@ public:\nvirtual void removeAllMessages() const = 0;\nvirtual std::vector<Message> getAllMes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Handle message replacement in `processMessageStoreOperations`
Summary:
Create list of `Message`s to be replaced in `processMessageStoreOperations` and pass to `sqlite_orm:replace(message);`
Currently there is a separate sql query for each message
Test Plan: Will be tested with subsequent diffs
Revi... |
129,190 | 28.07.2021 13:42:37 | -7,200 | ac4db13d95c4a02e5b051cd7913d4f08f5e18296 | [native] More clear function type for `MigrationFunction`
Summary: I just thought this is more clear, what do you think?
Test Plan: build
Reviewers: palys-swm, atul, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -97,7 +97,7 @@ bool create_messages_table(sqlite3 *db) {\nreturn false;\n}\n-typedef bool (*MigrationFuncti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] More clear function type for `MigrationFunction`
Summary: I just thought this is more clear, what do you think?
Test Plan: build
Reviewers: palys-swm, atul, ashoat
Reviewed By: palys-swm, atul, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.co... |
129,191 | 28.07.2021 12:52:37 | -7,200 | bb573072612e875d52068b6762731797d928ab3c | [native] Adjust message target position when author name is displayed in tooltip
Summary: We need to include an additional offset when an author name is displayed.
Test Plan: Test message animation when a source message wasn't created by a viewer.
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/utils.js",
"new_path": "native/chat/utils.js",
"diff": "@@ -11,6 +11,7 @@ import { useSelector } from '../redux/redux-utils';\nimport type { LayoutCoordinates, VerticalBounds } from '../types/layout-types';\nimport type { AnimatedViewStyle } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Adjust message target position when author name is displayed in tooltip
Summary: We need to include an additional offset when an author name is displayed.
Test Plan: Test message animation when a source message wasn't created by a viewer.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul, ka... |
129,184 | 28.07.2021 11:42:18 | 14,400 | 33f0c2104cffa1ca03679d1b920f5ad514febec6 | [native] Increase markdown link contrast
Summary: Addresses
Test Plan: na, looks as expected
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/markdown/styles.js",
"new_path": "native/markdown/styles.js",
"diff": "@@ -8,7 +8,7 @@ import type { GlobalTheme } from '../types/themes';\nconst unboundStyles = {\nlink: {\n- color: 'link',\n+ color: 'markdownLink',\ntextDecorationLine: 'underline',\n}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Increase markdown link contrast
Summary: Addresses https://www.notion.so/commapp/Make-markdown-links-white-45abc3430daf4e999519d5d58054e9cc?d=08a1b372-bf19-4392-b981-f5eff146934a
Test Plan: na, looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differen... |
129,187 | 29.07.2021 02:39:25 | 14,400 | c05a9ffe9dc758847dbc509de57f248c2f74ea46 | [native] Support optional triggerReply and triggerSidebar in SwipeableMessage
Summary: It should be possible to support just reply, just sidebar, or both.
Test Plan: Tested in combination with following diffs
Reviewers: palys-swm
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/swipeable-message.react.js",
"new_path": "native/chat/swipeable-message.react.js",
"diff": "@@ -26,8 +26,8 @@ import type { ViewStyle } from '../types/styles';\nimport { dividePastDistance } from '../utils/animation-utils';\nimport { useMessageList... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Support optional triggerReply and triggerSidebar in SwipeableMessage
Summary: It should be possible to support just reply, just sidebar, or both.
Test Plan: Tested in combination with following diffs
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: Adrian, atul, karol-bisztyga
Differential Revisi... |
129,187 | 29.07.2021 03:03:42 | 14,400 | 2f18b181f80c455b3565901bdf4b0f05d62d78f8 | [native] Support swipe-for-sidebar in MultimediaMessage
Summary: This was surprisingly easy!
Test Plan: Test by swiping a multimedia message
Reviewers: palys-swm
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -30,7 +30,7 @@ type BaseProps = {\n+item: ChatMessageInfoItemWithHeight,\n+sendFailed: boolean,\n+focused: boolean,\n- +swipeOptions?: SwipeOptions,\n+ +sw... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Support swipe-for-sidebar in MultimediaMessage
Summary: This was surprisingly easy!
Test Plan: Test by swiping a multimedia message
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1827 |
129,187 | 29.07.2021 03:09:36 | 14,400 | c6dfb0c106bfd985c701d6949184fc1d23cf9cd2 | [native] Handle non-swipeable case inside SwipeableMessage
Summary: I think the code is more simple and readable this way.
Test Plan: Test a variety of swipe cases
Reviewers: palys-swm
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -93,8 +93,6 @@ class ComposedMessage extends React.PureComponent<Props> {\n);\n}\n- let messageBox;\n- if (swipeOptions !== 'none') {\nconst triggerReply =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Handle non-swipeable case inside SwipeableMessage
Summary: I think the code is more simple and readable this way.
Test Plan: Test a variety of swipe cases
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1828 |
129,190 | 30.07.2021 09:50:08 | -7,200 | 77a3dc902126caf37fc275a93ed2ec4f0011c7b6 | [native] Add olm persist entity
Summary: please see the description here: D1794
Test Plan: none
Reviewers: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/DatabaseManagers/entities/OlmPersistAccount.h",
"diff": "+#pragma once\n+\n+#include <string>\n+\n+namespace comm {\n+\n+struct OlmPersistAccount {\n+ int id;\n+ std::string account_data;\n+};\n+\n+} // namespace comm\n"
}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add olm persist entity
Summary: please see the description here: D1794
Test Plan: none
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, KatPo, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1793 |
129,184 | 02.08.2021 14:45:41 | 14,400 | d24002b368a6d69040ff986dcc2b889ec8f3595a | [lib] Modify `ReassignmentResult` to include list of `MessageStoreOperation`s
Summary: Modify ReassignmentResult to include a set of operations **in addition to the modified messageStore**.
Test Plan: Set breakpoint and observed list of operations was returned as expected
Reviewers: ashoat
Subscribers: palys-swm, Adria... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -65,6 +65,8 @@ import {\ntype RawMessageInfo,\ntype LocalMessageInfo,\ntype MessageStore,\n+ type ReplaceMessageOperation,\n+ type MessageStoreOperation,\ntype Message... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify `ReassignmentResult` to include list of `MessageStoreOperation`s
Summary: Modify ReassignmentResult to include a set of operations **in addition to the modified messageStore**.
Test Plan: Set breakpoint and observed list of operations was returned as expected
Reviewers: ashoat
Reviewed By: ashoat
Subs... |
129,184 | 02.08.2021 11:58:24 | 14,400 | 5228576649af6d2b7d0727f71f4c9d6df918a93a | [native] Use swmansion `cloud-filled` icon in `community-pill`
Summary: Here's what it looks like:
Test Plan: na, looks as expected
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/components/community-pill.react.js",
"new_path": "native/components/community-pill.react.js",
"diff": "import * as React from 'react';\nimport { View, StyleSheet } from 'react-native';\n-import Icon from 'react-native-vector-icons/FontAwesome5';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use swmansion `cloud-filled` icon in `community-pill`
Summary: Here's what it looks like: https://blob.sh/atul/ed5b.png
Test Plan: na, looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1836 |
129,184 | 02.08.2021 12:08:00 | 14,400 | 9820873e90ad7e13dab27f692d32fb1bcbbdbec6 | [native] Use swmansion `reply-filled` and `sidebar-filled` icons in `swipeable-message`
Summary: Here's what it looks like:
Test Plan: na, looks as expected
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/swipeable-message.react.js",
"new_path": "native/chat/swipeable-message.react.js",
"diff": "@@ -17,10 +17,9 @@ import Animated, {\ntype SharedValue,\n} from 'react-native-reanimated';\nimport type { IconProps } from 'react-native-vector-icons';\n-i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use swmansion `reply-filled` and `sidebar-filled` icons in `swipeable-message`
Summary: Here's what it looks like: https://blob.sh/atul/0c09.png
Test Plan: na, looks as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator... |
129,187 | 02.08.2021 22:54:10 | 18,000 | e8ef4f72e213e24f82ed23096891e141f51c566c | [native] ALPHA -> BETA | [
{
"change_type": "MODIFY",
"old_path": "native/profile/build-info.react.js",
"new_path": "native/profile/build-info.react.js",
"diff": "@@ -17,7 +17,7 @@ function BuildInfo(props: { ... }): React.Node {\n<View style={styles.section}>\n<View style={styles.row}>\n<Text style={styles.label}>Release</Te... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] ALPHA -> BETA |
129,187 | 02.08.2021 21:57:32 | 18,000 | d5203951e99056fd0a90b55cf1e6aa8b95e53c6d | [native] codeVersion -> 94 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 94 |
129,187 | 02.08.2021 15:23:18 | 18,000 | f6fbdaa07413aba685512939b64b94a410e19c21 | [server] Avoid defining visibleExtractString twice in message-fetchers.js
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/message-fetchers.js",
"new_path": "server/src/fetchers/message-fetchers.js",
"diff": "@@ -38,6 +38,8 @@ export type FetchCollapsableNotifsResult = {\n[userID: string]: CollapsableNotifInfo[],\n};\n+const visibleExtractString = `$.${threadPe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Avoid defining visibleExtractString twice in message-fetchers.js
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: atul
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1838 |
129,187 | 02.08.2021 15:24:09 | 18,000 | 3ba52c674f4da4606d966052a0b0b557d6f53205 | [server] Introduce user_messages table
Summary: More details in the [Notion task](https://www.notion.so/commapp/Make-an-adjacency-table-for-messages-dd9c546a39d44fac89b8f4a7670bbcab)
Test Plan: I ran the script
Reviewers: palys-swm, atul, karol-bisztyga
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-db.js",
"new_path": "server/src/scripts/create-db.js",
"diff": "@@ -218,6 +218,14 @@ async function createTables() {\none_time_key CHAR(43) NOT NULL\n) ENGINE=InnoDB DEFAULT CHARSET=utf8;\n+ CREATE TABLE user_messages (\n+ recipient b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introduce user_messages table
Summary: More details in the [Notion task](https://www.notion.so/commapp/Make-an-adjacency-table-for-messages-dd9c546a39d44fac89b8f4a7670bbcab)
Test Plan: I ran the script
Reviewers: palys-swm, atul, karol-bisztyga
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revi... |
129,184 | 04.08.2021 09:27:26 | 14,400 | aa87445c9263c01526bab5df45a99d8f1b0b20de | [lib] Introduce `processMessageStoreOperations` to `message-reducer`
Summary: Introduce `processMessageStoreOperations`, which given a MessageStore and a list of MessageStoreOperations will apply the operations.
Test Plan: Set breakpoint w/ simple replacement case and function behaved as expected
Reviewers: ashoat
Subs... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -556,6 +556,22 @@ function ensureRealizedThreadIDIsUsedWhenPossible<\n: payload;\n}\n+// eslint-disable-next-line\n+function processMessageStoreOperations(\n+ messageS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `processMessageStoreOperations` to `message-reducer`
Summary: Introduce `processMessageStoreOperations`, which given a MessageStore and a list of MessageStoreOperations will apply the operations.
Test Plan: Set breakpoint w/ simple replacement case and function behaved as expected
Reviewers: ashoat
... |
129,184 | 04.08.2021 10:02:36 | 14,400 | f92c7bd6298bf88fc214a65446b4312d82977b1a | [lib] Modify `freshMessageStore` return type to include `messageStoreOperations`
Summary: na
Test Plan: Tested by logging in and making sure the messageStore.messages after processing operations matched freshStore
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -125,15 +125,25 @@ function threadIsWatched(\n);\n}\n+type FreshMessageStoreResult = {\n+ +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,\n+ +messageSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify `freshMessageStore` return type to include `messageStoreOperations`
Summary: na
Test Plan: Tested by logging in and making sure the messageStore.messages after processing operations matched freshStore
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Re... |
129,184 | 05.08.2021 17:16:37 | 14,400 | b664894d739a7d186ca22972d3b18237a712256a | [lib] Modify `filterByNewThreadInfos` return type to include `messageStoreOperations`
Summary: na
Test Plan: Haven't yet tested
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -549,10 +549,14 @@ function mergeNewMessages(\nreturn { messages, threads, local, currentAsOf };\n}\n+type FilterByNewThreadInfosResult = {\n+ +messageStoreOperations:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify `filterByNewThreadInfos` return type to include `messageStoreOperations`
Summary: na
Test Plan: Haven't yet tested
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1852 |
129,184 | 05.08.2021 17:29:30 | 14,400 | 9ae70cf9c493f5699ab8d26cd64c763a9cd74b9b | [lib] Modify `RemoveMessageOperation` payload to be array of messageIDs
Summary: Makes more sense and aligns better w/ what we're doing on the sqlite side
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -571,10 +571,9 @@ function filterByNewThreadInfos(\n}\n}\n- const messageStoreOperations = messageIDsToRemove.map(id => ({\n- type: 'remove',\n- payload: { id },\n- })... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify `RemoveMessageOperation` payload to be array of messageIDs
Summary: Makes more sense and aligns better w/ what we're doing on the sqlite side
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1853 |
129,184 | 04.08.2021 14:09:37 | 14,400 | 7c0adac8550b54650540997820fb1347efddcf3e | [lib] Modify `mergeNewMessages` return type to include `messageStoreOperations`
Summary: na
Test Plan: in progress
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -253,6 +253,10 @@ function reassignMessagesToRealizedThreads(\n};\n}\n+type MergeNewMessagesResult = {\n+ +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify `mergeNewMessages` return type to include `messageStoreOperations`
Summary: na
Test Plan: in progress
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1854 |
129,184 | 06.08.2021 18:01:40 | 14,400 | 12209aad972999481f0ef2e4126df9514f8102a7 | [lib] Introduce `messageStoreOperation` for `rehydrateActionType` in `reduceMessageStore`
Summary: na
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -1176,6 +1176,7 @@ function reduceMessageStore(\nconst newMessages = {};\nlet newThreads = threads,\nnewLocal = local;\n+ const messageIDsToBeRemoved = [];\nfor (const... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `messageStoreOperation` for `rehydrateActionType` in `reduceMessageStore`
Summary: na
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1860 |
129,184 | 06.08.2021 18:12:37 | 14,400 | ff651c50e0db79dec7b2b9b6a5dca650f0a69d4c | [lib] Introduce `RekeyMessageOperation`
Summary:
Introduce a `RekeyMessageOperation` op to handle the `send[Text/Multimedia]MessageActionTypes.success` action
We could just compose the `remove` and `replace` operations to achieve the same thing, but I think this API is cleaner
Test Plan: na
Reviewers: ashoat
Subscriber... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -338,9 +338,15 @@ export type ReplaceMessageOperation = {\n+payload: { +id: string, +messageInfo: RawMessageInfo },\n};\n+export type RekeyMessageOperation = {\n+ +type: 'rekey'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `RekeyMessageOperation`
Summary:
Introduce a `RekeyMessageOperation` op to handle the `send[Text/Multimedia]MessageActionTypes.success` action
We could just compose the `remove` and `replace` operations to achieve the same thing, but I think this API is cleaner
Test Plan: na
Reviewers: ashoat
Revie... |
129,190 | 03.08.2021 16:09:38 | -7,200 | 158496baa8984247b0177364ce28d544b8b4f703 | [native] Secure store - add mutual code
Summary: This is a mutual code for both platforms and methods of this class should be implemented separately for Android and iOS
Test Plan: it should just build
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/Tools/CommSecureStore.h",
"diff": "+#pragma once\n+\n+#include <folly/Optional.h>\n+\n+#include <string>\n+\n+namespace comm {\n+\n+class CommSecureStore {\n+public:\n+ void set(const std::string key, const std::string value... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Secure store - add mutual code
Summary: This is a mutual code for both platforms and methods of this class should be implemented separately for Android and iOS
Test Plan: it should just build
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differen... |
129,184 | 08.08.2021 17:58:20 | 14,400 | 01e944ad9cf55ae474d522ef001e87bb0077c712 | [lib] Introduce `processedMessageStore` invariant for `processServerRequestsAction` in `reduceMessageStore`
Summary: na
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -1233,8 +1233,24 @@ function reduceMessageStore(\nreturn newMessageStore;\n} else if (action.type === processServerRequestsActionType) {\nconst {\n+ messageStoreOperat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `processedMessageStore` invariant for `processServerRequestsAction` in `reduceMessageStore`
Summary: na
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1868 |
129,184 | 08.08.2021 22:30:49 | 14,400 | f010847fab894afd4b56a71f1d699125cd236178 | [lib] Handle `RekeyMessageOperation`s in `processMessageStoreOperations`
Summary: na
Test Plan: todo
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -638,6 +638,10 @@ function processMessageStoreOperations(\nfor (const id of operation.payload.ids) {\ndelete processedMessages[id];\n}\n+ } else if (operation.type ===... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Handle `RekeyMessageOperation`s in `processMessageStoreOperations`
Summary: na
Test Plan: todo
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1869 |
129,184 | 08.08.2021 22:53:50 | 14,400 | 95fa202b1e679269d8931dce4d28964411bdae90 | [lib] Introduce `messageStoreOperation` for `sendTextMessageActionTypes.success` action in `reduceMessageStore`
Summary: na
Test Plan: invariant
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -973,6 +973,7 @@ function reduceMessageStore(\nconst replaceMessageKey = (messageKey: string) =>\nmessageKey === payload.localID ? payload.serverID : messageKey;\nlet ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `messageStoreOperation` for `sendTextMessageActionTypes.success` action in `reduceMessageStore`
Summary: na
Test Plan: invariant
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1870 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.