author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,184 | 09.08.2021 13:46:39 | 14,400 | b520e6b24712c953d51bd1ef6c9c093de7aff4ab | [lib] Fix `LocallyComposedMessageInfo` type
Summary: fixes flow error in D1872
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -265,11 +265,19 @@ export type RawMessageInfo =\n| RawRobotextMessageInfo\n| RawSidebarSourceMessageInfo;\n-export type LocallyComposedMessageInfo = {\n+export type LocallyCompo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix `LocallyComposedMessageInfo` type
Summary: fixes flow error in D1872
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1871 |
129,184 | 09.08.2021 13:50:56 | 14,400 | de166b3b3e04501e0c0bae3829083b833450d630 | [lib] Introduce `messageStoreOperations` for `createLocalMessageActionType` action in `reduceMessageStore`
Summary: na
Test Plan: invariant
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -69,8 +69,6 @@ import {\ntype MessageStoreOperation,\ntype MessageTruncationStatus,\ntype ThreadMessageInfo,\n- type LocallyComposedMessageInfo,\n- type RawMultimediaM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `messageStoreOperations` for `createLocalMessageActionType` action in `reduceMessageStore`
Summary: na
Test Plan: invariant
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1872 |
129,184 | 09.08.2021 15:53:01 | 14,400 | e28f04091b9135f5cc458f1e5de38ea5eae31e18 | [lib] Introduce `messageStoreOperation` for `updateMultimediaMessageMediaActionType` in `reduceMessageStore`
Summary: last action type to be handled in `reduceMessageStore`
Test Plan: invariant
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -61,6 +61,7 @@ import {\n} from '../shared/thread-utils';\nimport threadWatcher from '../shared/thread-watcher';\nimport { unshimMessageInfos } from '../shared/unshim-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `messageStoreOperation` for `updateMultimediaMessageMediaActionType` in `reduceMessageStore`
Summary: last action type to be handled in `reduceMessageStore`
Test Plan: invariant
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phab... |
129,184 | 09.08.2021 18:06:30 | 14,400 | d0bec2f16beac5d627ad179be0b82c8dc821c0ff | [lib] Modify `reduceMessageStore` return type to include `messageStoreOperations`
Summary: have reduceMessageStore return list of messageStoreOperations
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/master-reducer.js",
"diff": "@@ -45,7 +45,7 @@ export default function baseReducer<N: BaseNavInfo, T: BaseAppState<N>>(\n];\n// Only allow checkpoints to increase if we are connected\n// or if the acti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify `reduceMessageStore` return type to include `messageStoreOperations`
Summary: have reduceMessageStore return list of messageStoreOperations
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1875 |
129,184 | 11.08.2021 10:27:09 | 14,400 | ebce09d934a3ba361f4776994b12f2e6e15f8b8e | [native] Remove "coming soon" apps from `APP_DIRECTORY_DATA`
Summary: Remove apps that aren't yet available from `APP_DIRECTORY_DATA`
Test Plan: The apps no longer appear in the apps directory
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/apps/apps-directory.react.js",
"new_path": "native/apps/apps-directory.react.js",
"diff": "@@ -17,27 +17,6 @@ const APP_DIRECTORY_DATA = [\nappIcon: 'calendar',\nappCopy: 'Shared calendar for your community',\n},\n- {\n- id: 'wiki',\n- available: false,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove "coming soon" apps from `APP_DIRECTORY_DATA`
Summary: Remove apps that aren't yet available from `APP_DIRECTORY_DATA`
Test Plan: The apps no longer appear in the apps directory
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabr... |
129,184 | 11.08.2021 11:06:46 | 14,400 | af5469239c9c8bfc499c37ce64aa1fbff693e19c | [native] Add 'chat' to `apps-directory`
Summary: We spoke about adding "Chat" to the `apps-directory` as a non-toggleable app (w/ alwaysEnabled prop) so the directory isn't so sparse once we remove "coming soon" apps
Test Plan: Looks as expected:
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/apps/app-listing.react.js",
"new_path": "native/apps/app-listing.react.js",
"diff": "@@ -11,19 +11,29 @@ import {\nimport type { SupportedApps } from 'lib/types/enabled-apps';\nimport SWMansionIcon from '../components/swmansion-icon.react';\n-import { u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add 'chat' to `apps-directory`
Summary: We spoke about adding "Chat" to the `apps-directory` as a non-toggleable app (w/ alwaysEnabled prop) so the directory isn't so sparse once we remove "coming soon" apps
Test Plan: Looks as expected: https://blob.sh/atul/e7da.png
Reviewers: ashoat
Reviewed By: ashoat
... |
129,184 | 11.08.2021 11:13:47 | 14,400 | 23d1e0db3ec015d416f715565e9acc259f4333bb | [native] Get rid of `available` prop in `AppListing`
Summary: For the time being we won't be listing unavailable apps in the apps directory, so I cut the `available` prop
Test Plan: Things continue looking as expected, flow
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/apps/app-listing.react.js",
"new_path": "native/apps/app-listing.react.js",
"diff": "@@ -15,7 +15,6 @@ import { useColors, useStyles } from '../themes/colors';\ntype Props = {\n+id: SupportedApps | 'chat',\n- +available: boolean,\n+alwaysEnabled: boolea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of `available` prop in `AppListing`
Summary: For the time being we won't be listing unavailable apps in the apps directory, so I cut the `available` prop
Test Plan: Things continue looking as expected, flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Diffe... |
129,184 | 11.08.2021 11:28:04 | 14,400 | ab4f5e5c2b43229fda71bba7f15fd2f5027aa18e | [native] Stop calling app "beta" in `BuildInfo`
Summary: Addresses one of the points mentioned:
Test Plan: Looks as expected:
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/profile/build-info.react.js",
"new_path": "native/profile/build-info.react.js",
"diff": "@@ -15,10 +15,6 @@ function BuildInfo(props: { ... }): React.Node {\nstyle={styles.scrollView}\n>\n<View style={styles.section}>\n- <View style={styles.row}>\n- <Te... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Stop calling app "beta" in `BuildInfo`
Summary: Addresses one of the points mentioned: https://www.notion.so/commapp/Satisfy-Apple-reviewers-3154595eb8b54991832edc578d9a3140
Test Plan: Looks as expected: https://blob.sh/atul/5450.png
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, ka... |
129,184 | 11.08.2021 13:41:33 | 14,400 | b604565d2ea45c34e95178e3c5b442f292dd9997 | [native] Add "report" button to `text-message-tooltip`
Summary: Here's what it looks like:
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message-tooltip-modal.react.js",
"new_path": "native/chat/text-message-tooltip-modal.react.js",
"diff": "@@ -25,6 +25,7 @@ export type TextMessageTooltipModalParams = TooltipParams<{\n}>;\nconst confirmCopy = () => displayActionResultModal('co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add "report" button to `text-message-tooltip`
Summary: Here's what it looks like: https://blob.sh/atul/report-text.mp4
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1890 |
129,184 | 11.08.2021 13:42:05 | 14,400 | b0ca7ef43c6da797ccec2bb74e520aa346e37a32 | [native] Add "report" button to `multimedia-message-tooltip`
Summary: Here's what it looks like:
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-tooltip-modal.react.js",
"new_path": "native/chat/multimedia-message-tooltip-modal.react.js",
"diff": "import * as React from 'react';\n+import { displayActionResultModal } from '../navigation/action-result-modal';\nimport {\ncre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add "report" button to `multimedia-message-tooltip`
Summary: Here's what it looks like: https://blob.sh/atul/report-media.mp4
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1891 |
129,184 | 11.08.2021 14:22:43 | 14,400 | da69b5e8efc7a169c85c031f7205a177e58280c7 | [lib] Introduce `PROCESSED_MSG_STORE_INVARIANTS_DISABLED`
Summary:
Pull `isDev` out from each invariant and use `PROCESSED_MSG_STORE_INVARIANTS_DISABLED` instead.
(for example, when we want to create the staff build with invariants enabled, we couls just set `PROCESSED_MSG_STORE_INVARIANTS_DISABLED = false`)
Test Plan:... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -92,6 +92,7 @@ import {\nimport { setNewSessionActionType } from '../utils/action-utils';\nimport { isDev } from '../utils/dev-utils';\n+const PROCESSED_MSG_STORE_INVA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `PROCESSED_MSG_STORE_INVARIANTS_DISABLED`
Summary:
Pull `isDev` out from each invariant and use `PROCESSED_MSG_STORE_INVARIANTS_DISABLED` instead.
(for example, when we want to create the staff build with invariants enabled, we couls just set `PROCESSED_MSG_STORE_INVARIANTS_DISABLED = false`)
Test Pl... |
129,187 | 11.08.2021 14:44:28 | 14,400 | 5d2f42bb5af9863153fa09af3af75f739b44b55d | [lib] Fix deduping of initialMembers in createPendingSidebar
Summary: Addresses part 1 of [this Notion task](https://www.notion.so/commapp/Specifying-userID-twice-in-initialMemberIDs-to-createThread-leads-to-crash-062791c5d498470b987b4592187d8548).
Test Plan: Test creating a sidebar in a `PERSONAL` thread from a messag... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -375,7 +375,7 @@ function createPendingSidebar(\n);\nconst threadName = trimText(messageTitle, 30);\n- const initialMembers = new Set();\n+ const initialMembers = new Map();\nif... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix deduping of initialMembers in createPendingSidebar
Summary: Addresses part 1 of [this Notion task](https://www.notion.so/commapp/Specifying-userID-twice-in-initialMemberIDs-to-createThread-leads-to-crash-062791c5d498470b987b4592187d8548).
Test Plan: Test creating a sidebar in a `PERSONAL` thread from a mess... |
129,190 | 03.08.2021 12:15:39 | -7,200 | fd3f0d49ca922af795017cd42d7fbfd9c6a00dbe | [native] Generate Keys - add Olm tools
Summary:
Adding olm tools to the comm repo.
The original code can be found [here](https://github.com/karol-bisztyga/olm_tests/tree/main/karol_tests)
Test Plan: none
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/CryptoTools/Tools.cpp",
"diff": "+#include \"Tools.h\"\n+\n+#include <random>\n+#include <string>\n+\n+namespace comm {\n+namespace crypto {\n+\n+Tools::Tools() {\n+ std::random_device rd;\n+ mt = std::mt19937(rd());\n+}\n+\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Generate Keys - add Olm tools
Summary:
Adding olm tools to the comm repo.
The original code can be found [here](https://github.com/karol-bisztyga/olm_tests/tree/main/karol_tests)
Test Plan: none
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Diffe... |
129,190 | 03.08.2021 12:16:20 | -7,200 | 97d632b53a3d2d35880d8cbe31d1bba882fda8f2 | [native] Generate Keys - add Olm session wrapper
Summary:
Adding olm session wrapper to the comm repo.
The original code can be found [here](https://github.com/karol-bisztyga/olm_tests/tree/main/karol_tests)
Test Plan: none
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/CryptoTools/Session.cpp",
"diff": "+#include \"Session.h\"\n+\n+#include \"Tools.h\"\n+\n+namespace comm {\n+namespace crypto {\n+\n+std::unique_ptr<Session> Session::createSessionAsInitializer(\n+ OlmAccount *account,\n+ st... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Generate Keys - add Olm session wrapper
Summary:
Adding olm session wrapper to the comm repo.
The original code can be found [here](https://github.com/karol-bisztyga/olm_tests/tree/main/karol_tests)
Test Plan: none
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm,... |
129,190 | 03.08.2021 12:17:14 | -7,200 | ceceed0b5fae7639788126116234e5a5562f8542 | [native] Generate Keys - add Persist structure
Summary:
Adding persist structure to the comm repo. This is used to pickling an account and its sessions.
The original code can be found [here](https://github.com/karol-bisztyga/olm_tests/tree/main/karol_tests)
Test Plan: none
Reviewers: palys-swm, ashoat
Subscribers: asho... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/CryptoTools/Persist.h",
"diff": "+#pragma once\n+\n+#include <string>\n+#include <unordered_map>\n+\n+#include \"Tools.h\"\n+\n+namespace comm {\n+namespace crypto {\n+\n+struct Persist {\n+ OlmBuffer account;\n+ std::unorde... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Generate Keys - add Persist structure
Summary:
Adding persist structure to the comm repo. This is used to pickling an account and its sessions.
The original code can be found [here](https://github.com/karol-bisztyga/olm_tests/tree/main/karol_tests)
Test Plan: none
Reviewers: palys-swm, ashoat
Reviewed By: ... |
129,190 | 03.08.2021 12:22:46 | -7,200 | e662cdd9204d0bc9a9b1388e473305bf448766ef | [native] Generate Keys - add untracked files to iOS
Summary: Syncing files newly added in the previous diffs with the iOS.
Test Plan: build iOS
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "71BE84492636A944002849D2 /* NativeModules.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 71BE843B2636A944002849D2 /* NativeModules.cpp */; };\n71B... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Generate Keys - add untracked files to iOS
Summary: Syncing files newly added in the previous diffs with the iOS.
Test Plan: build iOS
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D1845 |
129,191 | 11.08.2021 11:18:02 | -7,200 | 3f4e5571eb53e760c0d403f26702781e60aae1c1 | [native] Move message height functions to utils
Summary: We do this to avoid import cycles
Test Plan: Flow
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message.react.js",
"new_path": "native/chat/message.react.js",
"diff": "@@ -20,29 +20,10 @@ import type { ChatMessageInfoItemWithHeight } from '../types/chat-types';\nimport { type VerticalBounds } from '../types/layout-types';\nimport type { Layou... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move message height functions to utils
Summary: We do this to avoid import cycles
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1883 |
129,191 | 11.08.2021 12:34:32 | -7,200 | 9dc01821415743336d8e617b8a7ad7713bdb4b14 | [native] Remove message hiding logic
Summary: We're going to use a new mechanism and it's easier to remove the old one first
Test Plan: Check if the navigating to sidebar works
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -46,7 +46,6 @@ import type {\n} from '../types/chat-types';\nimport type { VerticalBounds } from '../types/layout-types';\nimport type { ViewableItemsChange } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove message hiding logic
Summary: We're going to use a new mechanism and it's easier to remove the old one first
Test Plan: Check if the navigating to sidebar works
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D18... |
129,191 | 11.08.2021 17:10:10 | -7,200 | fc8bcd03848caf6f56f9e9dc21aad35effd6510e | [native] Determine optimal animation parameters
Summary: I spent some time tweaking the values so that the animation looks correct and feels right
Test Plan: Open tooltip, close it, open again and navigate to a sidebar. Check if animation is correct.
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message.react.js",
"new_path": "native/chat/message.react.js",
"diff": "@@ -89,7 +89,7 @@ class Message extends React.PureComponent<Props, State> {\nreturn sub(\n1,\ninterpolateNode(overlayPosition, {\n- inputRange: [0.1, 0.11],\n+ inputRange: [0.0... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Determine optimal animation parameters
Summary: I spent some time tweaking the values so that the animation looks correct and feels right
Test Plan: Open tooltip, close it, open again and navigate to a sidebar. Check if animation is correct.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul,... |
129,187 | 12.08.2021 13:41:04 | 14,400 | 519c7b86ca1db5ce1e9e2956ccb047b7f5b3f225 | [server] Introduce createNewVersionResponder
Test Plan:
1. Try doing it with correct input
2. Try doing it with malformed input
3. Try doing it twice with the same version
Reviewers: atul
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/types/version-types.js",
"diff": "+// @flow\n+\n+import type { DeviceType } from './device-types';\n+\n+export type CreateNewVersionsRequest = {\n+ +codeVersion: number,\n+ +deviceType: DeviceType,\n+};\n"
},
{
"change_type": "MODIFY... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introduce createNewVersionResponder
Test Plan:
1. Try doing it with correct input
2. Try doing it with malformed input
3. Try doing it twice with the same version
Reviewers: atul
Reviewed By: atul
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1896 |
129,187 | 12.08.2021 13:52:33 | 14,400 | 0c43d498385eac7cffb26171be7edca330f8fb63 | [server] Introduce markVersionDeployedResponder
Test Plan:
1. Try it with a version that exists
2. Try it with a version that doesn't exist
Reviewers: atul
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/version-responders.js",
"new_path": "server/src/responders/version-responders.js",
"diff": "@@ -47,4 +47,31 @@ async function createNewVersionResponder(\n}\n}\n-export { createNewVersionResponder };\n+async function markVersionDeployedRes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introduce markVersionDeployedResponder
Test Plan:
1. Try it with a version that exists
2. Try it with a version that doesn't exist
Reviewers: atul
Reviewed By: atul
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1897 |
129,184 | 12.08.2021 11:49:23 | 14,400 | ef93c3332067a9eeeb8007713c22e1a193cd9f45 | [native] codeVersion -> 95 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 95 |
129,184 | 13.08.2021 10:11:28 | 14,400 | c753eb962961a2d1bf59e742dc37fde2c51f522d | [native] codeVersion -> 96 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 96 |
129,184 | 16.08.2021 13:37:42 | 14,400 | d3e23d4da1fb9b265645388079aba14202821074 | [iOS] Better explain use of camera and photos in the "purpose string"
Summary: Changed "purpose string" to appease apps store reviewers
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>NSLocationWhenInUseUsageDescription</key>\n<string>Allow $(PRODUCT_NAME) to access your location</string>\n<key>NSPhotoLibraryUsageDescription</key>\n- <string>Giv... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [iOS] Better explain use of camera and photos in the "purpose string"
Summary: Changed "purpose string" to appease apps store reviewers
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1901 |
129,184 | 16.08.2021 18:59:10 | 14,400 | a4e636ed8cdf613d46fa278ede0653a706ea3c08 | [lib] Make sure to properly rekey local->server message IDs in `mergeNewMessages`
Summary: Fixes issue that caused invariant to be triggered for Alicja (https://www.notion.so/commapp/Investigate-message-op-invariants-getting-triggered-ecf7783806f641719db1b9742d71d5c0)
Test Plan: No longer able to reproduce issue
Review... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -547,6 +547,11 @@ function mergeNewMessages(\n});\n}\n+ newMessageOps.push({\n+ type: 'remove',\n+ payload: { ids: [...localIDsToServerIDs.keys()] },\n+ });\n+\nfor (c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Make sure to properly rekey local->server message IDs in `mergeNewMessages`
Summary: Fixes issue that caused invariant to be triggered for Alicja (https://www.notion.so/commapp/Investigate-message-op-invariants-getting-triggered-ecf7783806f641719db1b9742d71d5c0)
Test Plan: No longer able to reproduce issue
Rev... |
129,184 | 16.08.2021 19:18:31 | 14,400 | 08e68514d2b88cb87b76f103820bacc4e3f2852a | [lib] remove handling of `fetchMessagesBeforeCursorActionTypes.success` from `mergeNewMessages`
Summary: We concluded that this was not necessary
Test Plan: none
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -414,16 +414,6 @@ function mergeNewMessages(\nconst oldThread = messageStoreAfterReassignment.threads[threadID];\nconst truncate = truncationStatus[threadID];\nif (!ol... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] remove handling of `fetchMessagesBeforeCursorActionTypes.success` from `mergeNewMessages`
Summary: We concluded that this was not necessary
Test Plan: none
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1906 |
129,184 | 17.08.2021 09:51:33 | 14,400 | 9976387b659d319fc96440af0906757e058c4225 | [lib] Introduce `RemoveMessagesForThreadOperation`
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -341,6 +341,11 @@ export type RemoveMessageOperation = {\n+payload: { +ids: $ReadOnlyArray<string> },\n};\n+export type RemoveMessagesForThreadOperation = {\n+ +type: 'remove_me... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `RemoveMessagesForThreadOperation`
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1907 |
129,184 | 17.08.2021 10:02:43 | 14,400 | 113bc3cab03e98d1b79c75b892a3f791640523b7 | [lib] Handle `RemoveMessagesForThreadOperation` in `processMessageStoreOperations`
Summary: Handle `RemoveMessagesForThreadOperation` on the JS side
Test Plan: copied example `messageStore.messages` from redux dev tools and tested functionality in repl
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -633,6 +633,12 @@ function processMessageStoreOperations(\nfor (const id of operation.payload.ids) {\ndelete processedMessages[id];\n}\n+ } else if (operation.type ===... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Handle `RemoveMessagesForThreadOperation` in `processMessageStoreOperations`
Summary: Handle `RemoveMessagesForThreadOperation` on the JS side
Test Plan: copied example `messageStore.messages` from redux dev tools and tested functionality in repl
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, ... |
129,184 | 17.08.2021 14:00:12 | 14,400 | 7e9d02a80d891a7614164ef603b1e245c85bfe29 | [lib] Remove `mediaType` invariant from `message-reducer` for `updateMultimediaMessageMediaActionType
Summary: na
Test Plan: flow, and was able to upload/send image on web (https://blob.sh/atul/ecd4.png)
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -1194,11 +1194,8 @@ function reduceMessageStore(\nif (singleMedia.id !== currentMediaID) {\nmedia.push(singleMedia);\n} else {\n- invariant(\n- mediaUpdate.type === 'p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Remove `mediaType` invariant from `message-reducer` for `updateMultimediaMessageMediaActionType
Summary: na
Test Plan: flow, and was able to upload/send image on web (https://blob.sh/atul/ecd4.png)
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: ht... |
129,184 | 17.08.2021 14:27:03 | 14,400 | fa98febf83a50fa72dbd2e12abdb9e312c4e571f | [native] codeVersion -> 97 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 97 |
129,191 | 17.08.2021 11:43:16 | -7,200 | 58f9b735ee935abadb351e42bdc93f49c40a0438 | [native] Wrap useAnimatedMessageTooltipButton arguments in an object
Summary: We're going to add new arguments and introducing an object args will make the code more readable
Test Plan: Flow.
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-tooltip-button.react.js",
"new_path": "native/chat/multimedia-message-tooltip-button.react.js",
"diff": "@@ -26,12 +26,12 @@ function MultimediaMessageTooltipButton(props: Props): React.Node {\nconst { progress } = props;\nconst ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Wrap useAnimatedMessageTooltipButton arguments in an object
Summary: We're going to add new arguments and introducing an object args will make the code more readable
Test Plan: Flow.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator... |
129,184 | 18.08.2021 15:01:40 | 14,400 | 71f835ac4c9d7d50253ac7714532dee72d2221fd | [lib] Skip adding new messages from unwatched threads
Summary: We want to filter out new messages that don't belong to watched threads
Test Plan: in progress
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -284,9 +284,13 @@ function mergeNewMessages(\n'messageStoreAfterOperations.messages should be equal to' +\n'messageStoreAfterReassignment.messages',\n);\n+ const local... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Skip adding new messages from unwatched threads
Summary: We want to filter out new messages that don't belong to watched threads
Test Plan: in progress
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1914 |
129,184 | 17.08.2021 16:20:31 | 14,400 | 2f9dd656296bb45cdcec570938c17c2366048ff5 | [lib] Introduce `assertMessageStoreMessagesAreEqual` and use in `mergeNewMessages`
Summary: Factor out invariant into separate function and use in `mergeNewMessages`
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -124,6 +124,33 @@ function threadIsWatched(\n);\n}\n+function assertMessageStoreMessagesAreEqual(\n+ processedMessageStore: MessageStore,\n+ expectedMessageStore: Mess... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `assertMessageStoreMessagesAreEqual` and use in `mergeNewMessages`
Summary: Factor out invariant into separate function and use in `mergeNewMessages`
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat... |
129,184 | 18.08.2021 16:54:03 | 14,400 | 828bf044af228d5ae9577f1629a2d0a35ff4c3ec | [lib] Use `assertMessageStoreMessagesAreEqual` everywhere else in `message-reducer`
Summary: Replace invariants with `assertMessageStoreMessagesAreEqual` everywhere else in file
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -710,10 +710,10 @@ function reduceMessageStore(\nmessageStoreOperations,\n);\n- invariant(\n- PROCESSED_MSG_STORE_INVARIANTS_DISABLED ||\n- _isEqual(processedMessageSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use `assertMessageStoreMessagesAreEqual` everywhere else in `message-reducer`
Summary: Replace invariants with `assertMessageStoreMessagesAreEqual` everywhere else in file
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabri... |
129,184 | 18.08.2021 18:02:28 | 14,400 | fc456d5c4586e73f17d90074c9fe1589ecf73079 | [native] codeVersion -> 98 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 98 |
129,184 | 18.08.2021 18:16:07 | 14,400 | 1cb3f4c3ebd4b84e16e8fcb63b7cf8c886cdea1d | [native] codeVersion -> 99 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 99 |
129,185 | 20.08.2021 09:43:14 | -7,200 | 9239da312a2440fe339412cc46cda0371c05dbec | [web] move links style to markdown.css
Summary: I moved links css from chat-message-list.css to markdown.css.
Test Plan: Open web chat and send link. It should be still styled.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -255,14 +255,6 @@ div.darkTextMessage {\ndiv.lightTextMessage {\ncolor: black;\n}\n-div.darkTextMessage a {\n- color: white;\n- text-decoration: underline;\n-}\n-div.lig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] move links style to markdown.css
Summary: I moved links css from chat-message-list.css to markdown.css.
Test Plan: Open web chat and send link. It should be still styled.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Rev... |
129,184 | 20.08.2021 13:45:40 | 14,400 | bd2e3fabeacf95271e69cffd3d5f5d9369b6e7e2 | [lib] Bump up `minCodeVersion` for video playback content
Summary: We were getting close to this placeholder value (we're currently on build 99), so bumped it up to arbitrary large number.
Test Plan: na, straightforward change
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/multimedia-message-spec.js",
"new_path": "lib/shared/messages/multimedia-message-spec.js",
"diff": "@@ -173,7 +173,7 @@ export const multimediaMessageSpec: MessageSpec<\nplatformDetails,\n);\n// TODO figure out first native codeVersion supp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Bump up `minCodeVersion` for video playback content
Summary: We were getting close to this placeholder value (we're currently on build 99), so bumped it up to arbitrary large number.
Test Plan: na, straightforward change
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Di... |
129,184 | 21.08.2021 21:01:59 | 14,400 | 9523a6a52efad0f60c26785b534d4fcd731251dc | [iOS] Remove `TestCrypto.h` from xcodeproj
Summary: I think this was probably just left in xcodeproj on accident?
Test Plan: na
Reviewers: karol-bisztyga, ashoat
Subscribers: palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "713EE40626C6676B003D7C48 /* CommTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = CommTests.x... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [iOS] Remove `TestCrypto.h` from xcodeproj
Summary: I think this was probably just left in xcodeproj on accident?
Test Plan: na
Reviewers: karol-bisztyga, ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D1934 |
129,184 | 22.08.2021 00:00:19 | 14,400 | ad3ec1c9ee89a02e58bc2ffac2def373bd9e84c6 | [CommCoreModule] Modify remove message operation to handle list of indices
Summary: Change `processMessageStoreOperations` on C++ side to correctly handle new "remove" API
Test Plan: Haven't tested yet, will test the C++ changes together before landing
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -243,7 +243,8 @@ std::vector<Message> SQLiteQueryExecutor::getAllMessages() const {\n}\nvoid SQLiteQueryExe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Modify remove message operation to handle list of indices
Summary: Change `processMessageStoreOperations` on C++ side to correctly handle new "remove" API
Test Plan: Haven't tested yet, will test the C++ changes together before landing
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, ... |
129,184 | 22.08.2021 00:03:05 | 14,400 | 58922075cfb0e362d9dbfadb2d8e97e040917534 | [CommCoreModule] Remove `creation` from `SQLiteMessageInfo` type and snake case future_type
Summary:
Already removed creation column on C++ side
Snake case `future_type` so it matches up with C++ side/db column name
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/schema/CommCoreModuleSchema.js",
"new_path": "native/schema/CommCoreModuleSchema.js",
"diff": "@@ -10,10 +10,9 @@ type SQLiteMessageInfo = {\n+thread: string,\n+user: string,\n+type: string,\n- +futureType: string,\n+ +future_type: string,\n+content: st... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Remove `creation` from `SQLiteMessageInfo` type and snake case future_type
Summary:
Already removed creation column on C++ side
Snake case `future_type` so it matches up with C++ side/db column name
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
... |
129,184 | 20.08.2021 15:33:34 | 14,400 | 23bc05fa8d9ef990daeec7f97d72c4fbf3384609 | [lib] Call `filterByNewThreadInfos` at top of `mergeNewMessages`
Summary: Refactor `mergeNewMessages` to include call to `filterByNewThreadInfos` as discussed
Test Plan: set breakpoint and observed expected behavior
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -298,13 +298,18 @@ function mergeNewMessages(\nreassignedThreadIDs,\n} = reassignMessagesToRealizedThreads(oldMessageStore, threadInfos);\n+ const {\n+ messageStoreOpe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Call `filterByNewThreadInfos` at top of `mergeNewMessages`
Summary: Refactor `mergeNewMessages` to include call to `filterByNewThreadInfos` as discussed
Test Plan: set breakpoint and observed expected behavior
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential ... |
129,184 | 20.08.2021 15:40:09 | 14,400 | ecbb4bb0ce39c8651d0daa13f3d6121553351149 | [lib] Remove `removeMessagesFromUnwatchedThreadOps` from `mergeNewMessages`
Summary: We no longer need these ops because we're calling `filterByNewThreadInfos` which creates them for us.
Test Plan: set breakpoint and observed expected behavior
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -509,16 +509,9 @@ function mergeNewMessages(\n_pickBy(thread => !!thread),\n)(threadsToMessageIDs);\n- const removeMessagesFromUnwatchedThreadOps: MessageStoreOperatio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Remove `removeMessagesFromUnwatchedThreadOps` from `mergeNewMessages`
Summary: We no longer need these ops because we're calling `filterByNewThreadInfos` which creates them for us.
Test Plan: set breakpoint and observed expected behavior
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, k... |
129,184 | 20.08.2021 17:16:14 | 14,400 | 30cfb145e2a9f63384e400843c632a24ea0fe1f1 | [lib] Call `reassignMessagesToRealizedThreads` from `filterByNewThreadInfos` and remove `reassignMessagesToRealizedThreads` from `mergeNewMessages`
Summary: Refactor as discussed
Test Plan: set breakpoints and observed correct behavior
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -292,20 +292,15 @@ function mergeNewMessages(\nthreadInfos: { +[threadID: string]: RawThreadInfo },\nactionType: *,\n): MergeNewMessagesResult {\n- const {\n- messageS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Call `reassignMessagesToRealizedThreads` from `filterByNewThreadInfos` and remove `reassignMessagesToRealizedThreads` from `mergeNewMessages`
Summary: Refactor as discussed
Test Plan: set breakpoints and observed correct behavior
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bis... |
129,184 | 23.08.2021 17:28:22 | 14,400 | 7d6577a571cf10110597202b36fc4b5671f3dc06 | [lib] Rename `filterByNewThreadInfos` to `reassignMessagesToRealizedAndWatchedThreads`
Summary: I think the new name better explains the behavior of the function. I'm very open to changing it to something more clear.
Test Plan: just a rename
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -296,7 +296,7 @@ function mergeNewMessages(\nmessageStoreOperations: filterUnwatchedThreadOps,\nmessageStore: filteredMessageStore,\nreassignedThreadIDs,\n- } = filter... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Rename `filterByNewThreadInfos` to `reassignMessagesToRealizedAndWatchedThreads`
Summary: I think the new name better explains the behavior of the function. I'm very open to changing it to something more clear.
Test Plan: just a rename
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, kar... |
129,184 | 23.08.2021 18:51:12 | 14,400 | 682b0f881daa007be04b6455ab61caf7cd02d648 | [lib] Misc naming tweaks in `mergeNewMessages`
Summary: Thought these changes made things a little more readable. No functional changes.
Test Plan: should be straightforward refactor
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -293,27 +293,35 @@ function mergeNewMessages(\nactionType: *,\n): MergeNewMessagesResult {\nconst {\n- messageStoreOperations: filterUnwatchedThreadOps,\n- messageStor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Misc naming tweaks in `mergeNewMessages`
Summary: Thought these changes made things a little more readable. No functional changes.
Test Plan: should be straightforward refactor
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ash... |
129,185 | 19.08.2021 16:51:30 | -7,200 | f73f724bddf7c2be6e34789f88d6a24b45ee5de8 | Update Reactotron code to use fetchDevServerHostname
Summary: Now device connects automatically with Reactotron tool using fetchDevServerHostname function.
Test Plan: Run app on android and ios emulators. Both connects with Reactotron server.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, ka... | [
{
"change_type": "MODIFY",
"old_path": "native/reactotron.js",
"new_path": "native/reactotron.js",
"diff": "import AsyncStorage from '@react-native-community/async-storage';\n+import { fetchDevServerHostnameSync } from './utils/url-utils';\n+\nlet reactotron: any = null;\n+\nif (__DEV__) {\nconst { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update Reactotron code to use fetchDevServerHostname
Summary: Now device connects automatically with Reactotron tool using fetchDevServerHostname function.
Test Plan: Run app on android and ios emulators. Both connects with Reactotron server.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers:... |
129,184 | 25.08.2021 12:24:58 | 14,400 | 3c6b856ac60fe50ad7feee6a528be1f71a0523a6 | [CommCoreModule] Create index on `thread` and `time` columns of messages table
Summary:
Query plan before:
Query plan after:
Test Plan: Logged path of sqlite db and used `EXPLAIN QUERY PLAN` to make sure index was being used
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -118,6 +118,29 @@ bool recreate_messages_table(sqlite3 *db) {\nreturn create_table(db, query, \"messages\")... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Create index on `thread` and `time` columns of messages table
Summary:
Query plan before: https://blob.sh/atul/ffc6.png
Query plan after: https://blob.sh/atul/fb1c.png
Test Plan: Logged path of sqlite db and used `EXPLAIN QUERY PLAN` to make sure index was being used
Reviewers: ashoat
Reviewed By: ... |
129,184 | 25.08.2021 13:52:19 | 14,400 | 0b65b3bf6bbc5168d96de1519a193ae5be0bc091 | [CommCoreModule] Introduce `removeMessagesForThreads`
Summary: Very similar to existing `SQLiteQueryExecutor::removeMessages`, but uses thread id instead of message id
Test Plan: will be tested with next diff
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -30,6 +30,7 @@ public:\nvirtual void removeAllMessages() const = 0;\nvirtual std::vector<Message> getAllMes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce `removeMessagesForThreads`
Summary: Very similar to existing `SQLiteQueryExecutor::removeMessages`, but uses thread id instead of message id
Test Plan: will be tested with next diff
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revisio... |
129,191 | 24.08.2021 14:31:29 | -7,200 | 898794b5fbb1bb3c655cd97cf704a554a69ebaa5 | [native] Remove currentDraftHeight parameter
Summary: We're now using a value stored in the context
Test Plan: Flow
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-tooltip-button.react.js",
"new_path": "native/chat/multimedia-message-tooltip-button.react.js",
"diff": "@@ -31,7 +31,6 @@ function MultimediaMessageTooltipButton(props: Props): React.Node {\ninitialCoordinates,\nmessageListVerti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove currentDraftHeight parameter
Summary: We're now using a value stored in the context
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1951 |
129,191 | 25.08.2021 16:22:33 | -7,200 | 17083000270b5dbee8e50867b57ebfc2c40f3fd7 | [native] Create dummy chat input bar
Summary: This is a simplified version of chat input bar which do not require navigation props and requires a prop which will be called with measured height
Test Plan: Tested with next diffs
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -799,34 +799,21 @@ const createThreadLoadingStatusSelector = createLoadingStatusSelector(\nnewThreadActionTypes,\n);\n-type ChatInputBarProps = {\n+type Connec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create dummy chat input bar
Summary: This is a simplified version of chat input bar which do not require navigation props and requires a prop which will be called with measured height
Test Plan: Tested with next diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul, karol-bisztyga
Differe... |
129,191 | 25.08.2021 16:35:34 | -7,200 | b6f689a7d5a35edf2eaac93a8edef02853b8b173 | [native] Create input bar height measurer
Summary: This component measures a chat input bar and returns a result using a callback prop
Test Plan: Tested with next diffs
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/sidebar-input-bar-height-measurer.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { View, StyleSheet } from 'react-native';\n+\n+import { useSelector } from '../redux/redux-utils';\n+import type { ChatMess... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create input bar height measurer
Summary: This component measures a chat input bar and returns a result using a callback prop
Test Plan: Tested with next diffs
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1954 |
129,191 | 26.08.2021 14:28:28 | -7,200 | de1e6a938a7c48f9bc7213d82765a9ab00bcd607 | [native] Delete unused utils
Summary: We're not going to use them
Test Plan: Flow
Reviewers: ashoat
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/utils.js",
"new_path": "native/chat/utils.js",
"diff": "@@ -8,7 +8,6 @@ import { useMessageListData } from 'lib/selectors/chat-selectors';\nimport { messageKey } from 'lib/shared/message-utils';\nimport { colorIsDark } from 'lib/shared/thread-utils... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delete unused utils
Summary: We're not going to use them
Test Plan: Flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1957 |
129,184 | 26.08.2021 15:02:37 | 25,200 | 11c61e7cf69a370ddda1d2ae9f10b72219c1ed47 | [web] Restyle "Join thread" button to include thread color
Summary: Here's how it looks:
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -182,7 +182,12 @@ class ChatInputBar extends React.PureComponent<Props> {\n}\njoinButton = (\n<div className={css.joinButtonContainer}>\n- <a onClick={this.onClickJo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Restyle "Join thread" button to include thread color
Summary: Here's how it looks: https://blob.sh/atul/4d64.png
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1958 |
129,184 | 26.08.2021 16:27:36 | 25,200 | 6bd460182be40be4fce303d7cf58fe48e55112f3 | [web] Add `faPlus` icon to "Join Thread" button
Summary: Here's how it looks:
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "// @flow\nimport { faFileImage } from '@fortawesome/free-regular-svg-icons';\n-import { faChevronRight } from '@fortawesome/free-solid-svg-icons';\n+import { faChevronR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add `faPlus` icon to "Join Thread" button
Summary: Here's how it looks: https://blob.sh/atul/46f7.png
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1959 |
129,184 | 26.08.2021 16:35:29 | 25,200 | 5e56afeaf147e5e865d939883eeacdb2190701c5 | [web] Remove explanatory text below "Join Thread" button
Summary: Here's how it looks:
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -278,11 +278,7 @@ class ChatInputBar extends React.PureComponent<Props> {\n</span>\n);\n} else if (defaultMembersAreVoiced && canJoin) {\n- content = (\n- <span clas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove explanatory text below "Join Thread" button
Summary: Here's how it looks: https://blob.sh/atul/67cb.png
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1960 |
129,184 | 25.08.2021 11:32:42 | 14,400 | 017a5a459077f4de8bd7e80b6740757dd0b07e0c | [native] Restyle "Join thread" button to include thread color
Summary: Here's what it looks like:
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -421,15 +421,24 @@ class ChatInputBar extends React.PureComponent<Props, State> {\n);\n} else {\nbuttonContent = (\n+ <View style={this.props.styles.joinButton... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Restyle "Join thread" button to include thread color
Summary: Here's what it looks like: https://blob.sh/atul/join_thread_btn.mov
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1939 |
129,184 | 25.08.2021 11:39:45 | 14,400 | 0e2a1407ac1a8aaa8f36736a90fb57a852e34b0a | [native] Get rid of redundant text below "Join Thread" button
Summary: Here's what it looks like:
Test Plan: na
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -472,11 +472,7 @@ class ChatInputBar extends React.PureComponent<Props, State> {\n</Text>\n);\n} else if (defaultMembersAreVoiced && canJoin) {\n- content = (\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of redundant text below "Join Thread" button
Summary: Here's what it looks like: https://blob.sh/atul/c509.png
Test Plan: na
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1940 |
129,191 | 30.08.2021 15:43:45 | -7,200 | e6070aa0e506ead1573ac30cf4a321c8b05e4c07 | [native] Set simplified animation flag
Summary: We need to use a simpler animation when a measurement is not finished, a keyboard is open or viewer is not a member of a sidebar
Test Plan: Tested with next diffs
Reviewers: ashoat, atul
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/utils.js",
"new_path": "native/chat/utils.js",
"diff": "@@ -6,8 +6,10 @@ import Animated from 'react-native-reanimated';\nimport { useMessageListData } from 'lib/selectors/chat-selectors';\nimport { messageKey } from 'lib/shared/message-utils';\n-i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Set simplified animation flag
Summary: We need to use a simpler animation when a measurement is not finished, a keyboard is open or viewer is not a member of a sidebar
Test Plan: Tested with next diffs
Reviewers: ashoat, atul
Reviewed By: ashoat, atul
Subscribers: Adrian, atul, karol-bisztyga
Differentia... |
129,184 | 31.08.2021 13:54:52 | 25,200 | 4df03ade6028e8a458336ac5135f64aa07f86ef8 | [lib] Avoid unnecessary `remove` op in `mergeNewMessages` when payload is empty
Summary: One of the issues we noticed when debugging truncation issue (which should be resolved by D1968)
Test Plan: set breakpoint and observed expected behavior
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -565,10 +565,12 @@ function mergeNewMessages(\n});\n}\n+ if (localIDsToServerIDs.size > 0) {\nnewMessageOps.push({\ntype: 'remove',\npayload: { ids: [...localIDsToServ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Avoid unnecessary `remove` op in `mergeNewMessages` when payload is empty
Summary: One of the issues we noticed when debugging truncation issue (which should be resolved by D1968)
Test Plan: set breakpoint and observed expected behavior
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm,... |
129,190 | 01.09.2021 12:32:06 | -7,200 | bcef7410d1301dad7ffaf0b8be3a06992ed1eea2 | [server] Add primary column to the cookies table
Summary: Add primary column to the cookies table for the primary devices task.
Test Plan: run the script on the existing database and recreate the database
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/add-primary-column-for-cookies.js",
"diff": "+// @flow\n+\n+import { dbQuery, SQL } from '../database/database';\n+import { main } from './utils';\n+\n+async function addPrimaryColumn() {\n+ await dbQuery(SQL`\n+ ALTER TABLE c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add primary column to the cookies table
Summary: Add primary column to the cookies table for the primary devices task.
Test Plan: run the script on the existing database and recreate the database
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Re... |
129,184 | 31.08.2021 13:33:35 | 25,200 | c018088710bf4b156d423018b2e982b858bb9980 | [lib] Handle truncation case in `mergeNewMessages`
Summary:
Should fix this issue:
If result set isn't contiguous with what we already have, dump existing messages for thread
Test Plan: haven't yet tested
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -433,6 +433,7 @@ function mergeNewMessages(\nsortMessageInfoList,\n)(unshimmedNewMessagesOfWatchedThreads);\n+ const newMessageOps: MessageStoreOperation[] = [];\ncons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Handle truncation case in `mergeNewMessages`
Summary:
Should fix this issue: https://www.notion.so/commapp/Message-op-invariants-triggering-with-build-99-df5f0587879e4d08acb93f5f6e807de9
If result set isn't contiguous with what we already have, dump existing messages for thread
Test Plan: haven't yet tested
R... |
129,184 | 03.09.2021 18:26:03 | 25,200 | a9594500e1917607901fd981a2d2eda311c7bdb8 | [native] codeVersion -> 100 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 100 |
129,184 | 04.09.2021 09:52:39 | 25,200 | 7f1ddc3849312892e22b658fb3a9ddf2e67a2fa8 | [native] codeVersion -> 101 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 101 |
129,184 | 07.09.2021 11:06:44 | 25,200 | 4cad0c2c91b98b107727ee29bc6e33a2b749a28f | [native] Replace "Testflight" with "App Store" in `client_version_unsupported` copy
Summary: na
Test Plan: na
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -276,7 +276,7 @@ class LogInPanel extends React.PureComponent<Props> {\n);\n} else if (e.message === 'client_version_unsupported') {\nconst app = Platform.se... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Replace "Testflight" with "App Store" in `client_version_unsupported` copy
Summary: na
Test Plan: na
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1987 |
129,187 | 07.09.2021 17:49:37 | 25,200 | a165956f30ecd42a36b99b8df053e0b6843277f7 | [native] Fix CameraModal crash
Summary: See the [Notion issue](https://www.notion.so/commapp/CameraModal-crash-cannot-read-property-navigation-c2a3b96491864ae4b57d08e38a14a1bb) for more details.
Test Plan: Confirm I can open the `CameraModal` again on a simulator
Reviewers: palys-swm, atul
Subscribers: Adrian, karol-bi... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -904,9 +904,10 @@ const ConnectedChatInputBar: React.ComponentType<ChatInputBarProps> = React.memo\nconst { navigation, route, ...restProps } = props;\nconst k... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix CameraModal crash
Summary: See the [Notion issue](https://www.notion.so/commapp/CameraModal-crash-cannot-read-property-navigation-c2a3b96491864ae4b57d08e38a14a1bb) for more details.
Test Plan: Confirm I can open the `CameraModal` again on a simulator
Reviewers: palys-swm, atul
Reviewed By: palys-swm
S... |
129,187 | 07.09.2021 22:42:27 | 25,200 | b6f0373a8a3080fb35b197ae21dfba3a09bb26c5 | [lib] Make ThreadInfo and RawThreadInfo types $ReadOnly
Test Plan: Flow
Reviewers: palys-swm
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -560,7 +560,7 @@ function rawThreadInfoFromServerThreadInfo(\ntype = shimThreadTypes[type];\n}\n- const rawThreadInfo: RawThreadInfo = {\n+ let rawThreadInfo: RawThreadInfo = {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Make ThreadInfo and RawThreadInfo types $ReadOnly
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1993 |
129,187 | 07.09.2021 22:55:54 | 25,200 | 289179fdbed290af9033d890eb2b542e6d47032b | [lib] Move thread ancestry functions to lib
Summary: This will be necessary in a following diff.
Test Plan: Flow
Reviewers: palys-swm
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -49,6 +49,7 @@ import {\ntype NewThreadResult,\nthreadTypes,\nthreadPermissions,\n+ threadTypeIsCommunityRoot,\n} from '../types/thread-types';\nimport { type ClientUpdateInfo, ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Move thread ancestry functions to lib
Summary: This will be necessary in a following diff.
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1994 |
129,187 | 07.09.2021 23:06:19 | 25,200 | 2a9a112c78df5f5a535e95b151988ee14b25ffe6 | [lib] Pass whole parentThreadInfo to CreatePendingThreadArgs
Summary: This will be necessary in a following diff.
Test Plan: Flow
Reviewers: palys-swm
Subscribers: Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -247,7 +247,7 @@ type CreatePendingThreadArgs = {\n+viewerID: string,\n+threadType: ThreadType,\n+members?: $ReadOnlyArray<GlobalAccountUserInfo | UserInfo>,\n- +parentThreadID?... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Pass whole parentThreadInfo to CreatePendingThreadArgs
Summary: This will be necessary in a following diff.
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D1995 |
129,184 | 07.09.2021 09:59:57 | 25,200 | 909bb571a8b2c0df8665bb473fdb74da0a25de23 | [CommCoreModule] Introduce `RekeyMessageOperation` to `MessageStoreOperations.h`
Summary: Introduce `RekeyMessageOperation` and use in `CommCoreModule:processMessageStoreOperations`
Test Plan: Same as D1984
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -218,6 +218,7 @@ jsi::Value CommCoreModule::getAllMessages(jsi::Runtime &rt) {\n});\n}\n+#define REKEY_OPERATION \"rekey\"\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce `RekeyMessageOperation` to `MessageStoreOperations.h`
Summary: Introduce `RekeyMessageOperation` and use in `CommCoreModule:processMessageStoreOperations`
Test Plan: Same as D1984
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
... |
129,184 | 07.09.2021 10:43:43 | 25,200 | 2dc1ad6fe95a77112bec84e53cc8f180f774961c | [CommCoreModule] Handle unsupported `op_type` in `processMessageStoreOperations`
Summary: Reject promise (and don't process any ops) if unsupported operation is passed in to `processMessageStoreOperations`
Test Plan:
1. Passed in nonsense op_type
2. Observed expected behavior:
Reviewers: ashoat, palys-swm
Subscribers: ... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -281,6 +281,16 @@ jsi::Value CommCoreModule::processMessageStoreOperations(\nauto to = rekey_payload.getProperty(rt, \"to\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Handle unsupported `op_type` in `processMessageStoreOperations`
Summary: Reject promise (and don't process any ops) if unsupported operation is passed in to `processMessageStoreOperations`
Test Plan:
1. Passed in nonsense op_type
2. Observed expected behavior: https://blob.sh/atul/a0be.png
Reviewers... |
129,184 | 09.09.2021 16:44:27 | 25,200 | 103c1ac33151d537a757bc56d9589cab58cb1e11 | [lib] Fix for "should have media" crash
Summary: The fix discussed during mid-week sync today.
Test Plan: Can now view chat that would previously crash:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -302,6 +302,15 @@ function createChatMessageItems(\nmessageInfo.type === messageTypes.SIDEBAR_SOURCE\n? messageInfo.sourceMessage\n: messageInfo;\n+\n+ if (\n+ (origin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix for "should have media" crash
Summary: The fix discussed during mid-week sync today.
Test Plan: Can now view chat that would previously crash: https://blob.sh/atul/c132.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phab... |
129,184 | 10.09.2021 23:02:03 | 25,200 | 6bd464cc24fcb3374f16059ce676b79a07b00ee1 | [lib] Handle empty media array case in `contentStringForMediaArray`
Summary: Showing "no media" seems better than crashing the app
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/media/media-utils.js",
"new_path": "lib/media/media-utils.js",
"diff": "@@ -21,8 +21,9 @@ function shimUploadURI(uri: string, platformDetails: ?PlatformDetails): string {\n}\nfunction contentStringForMediaArray(media: $ReadOnlyArray<Media>): string {\n- in... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Handle empty media array case in `contentStringForMediaArray`
Summary: Showing "no media" seems better than crashing the app
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2005 |
129,184 | 12.09.2021 17:10:31 | 25,200 | 8662cc9a2024fc18d439222a0bb3ec9f0b120bac | [native] `codeVersion` -> 102 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 102 |
129,184 | 12.09.2021 19:03:07 | 25,200 | 4b917f6ee57ed74033724ebf66a7905e16fbb82c | [native] `codeVersion` -> 103 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -284,8 +284,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 103 |
129,185 | 10.09.2021 09:52:15 | -7,200 | 52b8a3fab4b18ddfa11116013fbf823e46710ee8 | [lib] Add EDIT_THREAD_DESCRIPTION and EDIT_THREAD_COLOR permission
Summary: I added EDIT_THREAD_DESCRIPTION and EDIT_THREAD_COLOR permissions to thread-types.
Test Plan: My change doesn't modify any behavior and the server still works.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bis... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -77,6 +77,8 @@ export const threadPermissions = Object.freeze({\nVOICED: 'voiced',\nEDIT_ENTRIES: 'edit_entries',\nEDIT_THREAD_NAME: 'edit_thread',\n+ EDIT_THREAD_DESCRIPTION: 'ed... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add EDIT_THREAD_DESCRIPTION and EDIT_THREAD_COLOR permission
Summary: I added EDIT_THREAD_DESCRIPTION and EDIT_THREAD_COLOR permissions to thread-types.
Test Plan: My change doesn't modify any behavior and the server still works.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat... |
129,184 | 13.09.2021 15:32:33 | 25,200 | 11fc71c7d6d943c59e17ca9a20829b52e5ce0736 | [lib] Change `future_type` and `content` type in `SQLiteMessageInfo` to maybe string
Summary: want these to be nullable
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -356,8 +356,8 @@ export type SQLiteMessageInfo = {\n+thread: string,\n+user: string,\n+type: string,\n- +future_type: string,\n- +content: string,\n+ +future_type: ?string,\n+ +... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Change `future_type` and `content` type in `SQLiteMessageInfo` to maybe string
Summary: want these to be nullable
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2008 |
129,184 | 15.09.2021 17:00:18 | 14,400 | e1847fac50ae4d43873f97e834dd95d7fe256b0a | [CommCoreModule] Bump MPMCQueue capacity from 20 -> 100
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/Tools/WorkerThread.cpp",
"new_path": "native/cpp/CommonCpp/Tools/WorkerThread.cpp",
"diff": "namespace comm {\nWorkerThread::WorkerThread(const std::string name)\n- : tasks(folly::MPMCQueue<std::unique_ptr<taskType>>(20)), name(name) {\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Bump MPMCQueue capacity from 20 -> 100
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2015 |
129,184 | 17.09.2021 10:43:58 | 14,400 | cb1a21a6c58e3e1053feb2b9a68619953df9486a | [CommCoreModule] Log sqlite db path
Summary: I've been constantly stashing/unstashing this to get the sqlite db path and thought it might be helpful to others/worth logging
Test Plan:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -156,6 +156,11 @@ void SQLiteQueryExecutor::migrate() {\nsqlite3 *db;\nsqlite3_open(SQLiteQueryExecutor::sq... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Log sqlite db path
Summary: I've been constantly stashing/unstashing this to get the sqlite db path and thought it might be helpful to others/worth logging
Test Plan: https://blob.sh/atul/cdd2.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Diff... |
129,191 | 15.09.2021 17:55:45 | -7,200 | a915e77f7805285007e2db8b9ae40a10a700ad52 | [CommCoreModule] Remove unused parameters from core module functions
Summary: We don't use them, so they can be removed
Test Plan: Compile the app and run it
Reviewers: ashoat, karol-bisztyga
Subscribers: Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -396,9 +396,7 @@ jsi::Value CommCoreModule::initializeCryptoAccount(\n});\n}\n-jsi::Value\n-CommCoreModule::getUserPublicKe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Remove unused parameters from core module functions
Summary: We don't use them, so they can be removed
Test Plan: Compile the app and run it
Reviewers: ashoat, karol-bisztyga
Reviewed By: ashoat, karol-bisztyga
Subscribers: Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2014 |
129,187 | 20.09.2021 21:57:20 | 14,400 | b493901f7624e8cf648b0dd9345d4b31480f7aa8 | [server] Script to reset passwords
Summary: See context in [Notion task](https://www.notion.so/commapp/Temporary-script-to-reset-password-via-CLI-d3638d415cbf4ba695478f005fad51a4).
Test Plan: Ran the script on a test user in my local environment and then made sure I could log in with the new password on the web client
... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/scripts/reset-password.js",
"diff": "+// @flow\n+\n+import bcrypt from 'twin-bcrypt';\n+\n+import { dbQuery, SQL } from '../database/database';\n+import { main } from './utils';\n+\n+const userID = '-1';\n+const password = 'password';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Script to reset passwords
Summary: See context in [Notion task](https://www.notion.so/commapp/Temporary-script-to-reset-password-via-CLI-d3638d415cbf4ba695478f005fad51a4).
Test Plan: Ran the script on a test user in my local environment and then made sure I could log in with the new password on the web clien... |
129,184 | 21.09.2021 02:04:26 | 14,400 | a196b1ed44f8d859c4b5061573a13658809b9104 | [lib] Rename `SQLite*` -> `ClientDB*`
Summary: part of generally moving names away from being DB-specific
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -351,7 +351,7 @@ export type ReplaceMessageOperation = {\n+payload: { +id: string, +messageInfo: RawMessageInfo },\n};\n-export type SQLiteMessageInfo = {\n+export type ClientDB... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Rename `SQLite*` -> `ClientDB*`
Summary: part of generally moving names away from being DB-specific
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2027 |
129,179 | 21.09.2021 19:02:21 | 14,400 | f2045c4c709114ed2db86471acf8ae4274d09396 | fix: Dont require customizing of network_security_config for on device debug
Summary: Check out Notion Issue:
Test Plan: Run Anroid build on physical device
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/debug/res/xml/network_security_config.xml",
"new_path": "native/android/app/src/debug/res/xml/network_security_config.xml",
"diff": "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<network-security-config>\n<!-- allow cleartext traffic for ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | fix: Dont require customizing of network_security_config for on device debug
Summary: Check out Notion Issue: https://www.notion.so/commapp/Don-t-require-customizing-network_security_config-xml-for-on-device-debugging-c6e18ae2e9b443bf8efcfc01a70cf6f5
Test Plan: Run Anroid build on physical device
Reviewers: ashoat, ... |
129,184 | 17.09.2021 13:14:51 | 14,400 | df00cf8d623353981356cc5d6bfb062b07330992 | [lib] Include `$ReadOnlyArray<ClientDBMediaInfo>` in `ClientDBMessageInfo`
Summary: Each `ClientDBMediaInfo` corresponds to a row in the `media` table
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "import invariant from 'invariant';\nimport type { FetchResultInfoInterface } from '../utils/fetch-json';\n+import { type ClientDBMediaInfo } from './media-types';\nimport type {\nA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include `$ReadOnlyArray<ClientDBMediaInfo>` in `ClientDBMessageInfo`
Summary: Each `ClientDBMediaInfo` corresponds to a row in the `media` table
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com... |
129,184 | 17.09.2021 00:18:42 | 14,400 | 8add779fa5ed8bb78b64aea12b844e3b0d638b29 | [CommCoreModule] Create SQLite `media` table
Summary: DB migration to create `media` table in SQLite, add `container` and `thread` columns to `Media.h`
Test Plan:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "#include \"Logger.h\"\n#include \"sqlite_orm.h\"\n+#include \"entities/Media.h\"\n#include <sqlite3.h>\n#inclu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Create SQLite `media` table
Summary: DB migration to create `media` table in SQLite, add `container` and `thread` columns to `Media.h`
Test Plan: https://blob.sh/atul/e68a.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: ht... |
129,184 | 17.09.2021 15:18:05 | 14,400 | f33c8864639da5b45aafe21617fd541c8e1b9141 | [lib] Introduce `translateRawMessageInfoToClientDBMessageInfo`
Summary: translates `rawMessageInfo` (from redux) => `ClientDBMessageInfo` (which gets passed to C++ side)
Test Plan: will be tested once C++ side is modified to handle new `ClientDBMessageInfo` payload
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, A... | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/message-ops.utils.js",
"new_path": "lib/utils/message-ops.utils.js",
"diff": "// @flow\n+import { messageID } from '../shared/message-utils';\n+import { messageSpecs } from '../shared/messages/message-specs';\nimport type { Media, ClientDBMediaInfo }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `translateRawMessageInfoToClientDBMessageInfo`
Summary: translates `rawMessageInfo` (from redux) => `ClientDBMessageInfo` (which gets passed to C++ side)
Test Plan: will be tested once C++ side is modified to handle new `ClientDBMessageInfo` payload
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
... |
129,185 | 23.09.2021 13:10:51 | -7,200 | 71789755d3506cb5f6a01d1429814ddd98e703a2 | [lib] Add thread store operation types
Summary: I added thread operation types - `remove` and `replace`.
Test Plan: The change doesn't modify any behavior.
Reviewers: palys-swm, atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -243,6 +243,20 @@ export type ThreadStore = {\n+threadInfos: { +[id: string]: RawThreadInfo },\n};\n+export type RemoveThreadOperation = {\n+ +type: 'remove',\n+ +payload: { +ids:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add thread store operation types
Summary: I added thread operation types - `remove` and `replace`.
Test Plan: The change doesn't modify any behavior.
Reviewers: palys-swm, atul, ashoat
Reviewed By: palys-swm, atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: ht... |
129,184 | 22.09.2021 18:41:25 | 14,400 | e9b60ded31f37105d793ef89487afc2725b3d8e0 | [2/5] [CommCoreModule] Introduce `replaceMedia` in `SQLiteQueryExecutor`
Summary: Inserts or updates a row in SQLite `media` table.
Test Plan: Will be tested implicitly in next diff.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "#include \"../CryptoTools/Persist.h\"\n#include \"entities/Draft.h\"\n+#include \"entities/Media.h\"\n#include... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/5] [CommCoreModule] Introduce `replaceMedia` in `SQLiteQueryExecutor`
Summary: Inserts or updates a row in SQLite `media` table.
Test Plan: Will be tested implicitly in next diff.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: h... |
129,185 | 23.09.2021 14:44:10 | -7,200 | ae47a96f0ee9a5b911e24060cc8be1d8976d93ab | [lib] Introduce `RemoveAllThreadsOperation`
Summary: Introduce `RemoveAllThreadsOperation` to increase SQLite database performance.
Test Plan: I tested if new operation works in the same way like an old solution with `RemoveThreadOperation` on virtual iOS device. No error messages appeared.
Reviewers: palys-swm, ashoat... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -192,10 +192,7 @@ export default function reduceThreadInfos(\n};\nconst threadStoreOperations = [\n{\n- type: 'remove',\n- payload: {\n- ids: Object.keys(state.threadInf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `RemoveAllThreadsOperation`
Summary: Introduce `RemoveAllThreadsOperation` to increase SQLite database performance.
Test Plan: I tested if new operation works in the same way like an old solution with `RemoveThreadOperation` on virtual iOS device. No error messages appeared.
Reviewers: palys-swm, ash... |
129,184 | 27.09.2021 13:09:43 | 14,400 | 28ece287e120c3424c6e7a68b8a859ecce1eac45 | [CommCoreModule] Change `getStorage()` return type to `auto&`
Summary: Resolves issue with SQLite transactions detailed at:
Test Plan: No more OOM error from sqlite
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -237,7 +237,7 @@ void SQLiteQueryExecutor::migrate() {\nsqlite3_close(db);\n}\n-auto SQLiteQueryExecutor::g... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Change `getStorage()` return type to `auto&`
Summary: Resolves issue with SQLite transactions detailed at: https://www.notion.so/commapp/Client-DB-transactions-with-sqlite_orm-d97e6ff6f2484fffad0af7385330824b
Test Plan: No more OOM error from sqlite
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
... |
129,184 | 27.09.2021 17:25:18 | 14,400 | 76e35f8b2eb2c2c3aa2a1917c5a7a8586a393d37 | [landing] Rename `Home` component to `Keyservers`
Summary: Renaming existing `Home` component to `Keyservers`. We will create a new `App` component which will become the new "homepage".
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "RENAME",
"old_path": "landing/home.react.js",
"new_path": "landing/keyservers.react.js",
"diff": "@@ -10,7 +10,7 @@ import StarBackground from './star-background.react';\nconst useIsomorphicLayoutEffect =\ntypeof window !== 'undefined' ? React.useLayoutEffect : React.useEffect;\n-f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Rename `Home` component to `Keyservers`
Summary: Renaming existing `Home` component to `Keyservers`. We will create a new `App` component which will become the new "homepage".
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revis... |
129,184 | 27.09.2021 19:55:52 | 14,400 | a12b897b42f38079ad9350daf3652cceb1df817c | [landing] Pull out `Header` component
Summary: Pull out `Header` from `Landing` to its own component.
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/header.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { Link } from 'react-router-dom';\n+\n+import css from './landing.css';\n+\n+export type HeaderProps = {\n+ +isLegalPage: boolean,\n+};\n+function Header(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Pull out `Header` component
Summary: Pull out `Header` from `Landing` to its own component.
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2072 |
129,184 | 28.09.2021 13:37:54 | 14,400 | 71b4209883d458b43978b91644c4ce30def9c906 | [landing] Include app screenshot placeholder
Summary: For now it's just a prod screenshot of thread list.
Test Plan: Image shows up on page:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -10,6 +10,7 @@ function AppLanding(): React.Node {\n<StarBackground />\n<center>\n<h1>App Landing Page</h1>\n+ <img height={300} src=\"images/comm-screenshot.png\" />\n</cen... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Include app screenshot placeholder
Summary: For now it's just a prod screenshot of thread list.
Test Plan: Image shows up on page: https://blob.sh/atul/fca3.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.asho... |
129,184 | 28.09.2021 13:46:38 | 14,400 | b70d224e33b89831b6968f2d5a104e6d93d2f7aa | [landing] Create `app_landing_grid` grid
Summary: CSS grid for `AppLanding` component
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "import * as React from 'react';\n-import StarBackground from './star-background.react';\n+import css from './landing.css';\nfunction AppLanding(): React.Node {\nreturn (\n- <di... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Create `app_landing_grid` grid
Summary: CSS grid for `AppLanding` component
Test Plan: Here's what it looks like: https://blob.sh/atul/6aad.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2081 |
129,184 | 28.09.2021 14:21:44 | 14,400 | fc95c84ed0e4d6a7f70dc96d8b5988cab7423d12 | [landing] Create `tile_grid` grid
Summary: CSS grid for `AppLanding` component
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -13,6 +13,20 @@ function AppLanding(): React.Node {\n<div className={css.app_copy}>\n<h1>Comm Messenger</h1>\n<p className={css.mono}>Web3 Messenger. E2E encrypted. Blah..</... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Create `tile_grid` grid
Summary: CSS grid for `AppLanding` component
Test Plan: Here's what it looks like: https://blob.sh/atul/3a88.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2082 |
129,184 | 28.09.2021 14:35:41 | 14,400 | 3653bacb3b4060d263a71f590d0bbdf4f69bd587 | [landing] Make tile `div`s `display:flex`
Summary: So we can align text vertically in each tile (which will shortly become their own components)
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -196,10 +196,14 @@ div.tile_tl,\ndiv.tile_tr,\ndiv.tile_bl,\ndiv.tile_br {\n+ display: flex;\nwidth: 8vw;\nheight: 8vw;\nborder-radius: 36px;\nbackground-image: linear-gradient(120deg, #fdfbf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make tile `div`s `display:flex`
Summary: So we can align text vertically in each tile (which will shortly become their own components)
Test Plan: Here's what it looks like: https://blob.sh/atul/4bdf.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Diffe... |
129,184 | 28.09.2021 14:54:32 | 14,400 | 18628c4cb206ff82c7e9f90f3d6f6eed3c7a9e39 | [landing] Make `app_landing_grid` "responsive"
Summary: Re-arrange CSS grid at smallest breakpoint.
Test Plan:
Before:
After:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -315,7 +315,8 @@ div.body_grid > div + .starting_section {\n/* ===== COMMON CSS GRID LAYOUT ===== */\ndiv.body_grid,\ndiv.footer_grid,\n- div.header_grid {\n+ div.header_grid,\n+ div.app_land... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make `app_landing_grid` "responsive"
Summary: Re-arrange CSS grid at smallest breakpoint.
Test Plan:
Before: https://blob.sh/atul/before_smallest_break.png
After: https://blob.sh/atul/after_smallest_break.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
... |
129,184 | 28.09.2021 15:32:47 | 14,400 | 23bff70bbbc2fcc03347222ba16dd9635078e444 | [landing] Add icons to info tiles
Summary: Include `FontAwesomeIcon` in `landing/package.json` and use in `AppLanding`
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "// @flow\n+import {\n+ faLock,\n+ faUserShield,\n+ faUsers,\n+ faServer,\n+} from '@fortawesome/free-solid-svg-icons';\n+import { FontAwesomeIcon } from '@fortawesome/react-fon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add icons to info tiles
Summary: Include `FontAwesomeIcon` in `landing/package.json` and use in `AppLanding`
Test Plan: Here's what it looks like: https://blob.sh/atul/b26f.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://... |
129,190 | 30.09.2021 11:36:25 | -7,200 | 3f8300708cd405358e6d69dbc6aa31988d24988c | [services] Add scripts for the grpc server
Summary: Adds scripts for the grpc server that generate grpc files from protos, build and start the server
Test Plan: `./services/tunnelbroker/server/run.sh`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/package.json",
"diff": "+{\n+ \"name\": \"services\",\n+ \"version\": \"1.0.0\",\n+ \"private\": true,\n+ \"license\": \"BSD-3-Clause\",\n+ \"scripts\": {\n+ \"run-grpc-server\": \"cd .. && ./services/tunnelbroker/run.sh && ./services/t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Add scripts for the grpc server
Summary: Adds scripts for the grpc server that generate grpc files from protos, build and start the server
Test Plan: `./services/tunnelbroker/server/run.sh`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, a... |
129,190 | 30.09.2021 13:35:09 | -7,200 | bb2795175938395091190623e0d57c83763200cb | [native] Fix grpc for building
Summary: I missed adding `SortIncludes: false` in D2012 which results in build errors. Sorry that I broke master but this fix works
Test Plan: build
Reviewers: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/_generated/.clang-format",
"new_path": "native/cpp/CommonCpp/grpc/_generated/.clang-format",
"diff": "---\nDisableFormat: true\n+SortIncludes: false\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix grpc for building
Summary: I missed adding `SortIncludes: false` in D2012 which results in build errors. Sorry that I broke master but this fix works
Test Plan: build
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.c... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.