author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,184 | 28.09.2021 16:18:20 | 14,400 | db733f8e76dc7a2c9879fcccb53249aa1fae0959 | [landing] Make tiles "responsive"
Summary:
Stop hardcoding tile size and make them responsive
Snuck in a few related font size tweaks etc
Test Plan:
Before:
After:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -18,23 +18,25 @@ function AppLanding(): React.Node {\n<img height={600} src=\"images/comm-screenshot.png\" />\n</div>\n<div className={css.app_copy}>\n- <h1>Comm Messenger</... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make tiles "responsive"
Summary:
Stop hardcoding tile size and make them responsive
Snuck in a few related font size tweaks etc
Test Plan:
Before: https://blob.sh/atul/unresponsive_tiles.mov
After: https://blob.sh/atul/responsive_tiles.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: pa... |
129,184 | 28.09.2021 17:10:52 | 14,400 | b6e8abb748fd54e8c8575315b0a5a4f698a0cc06 | [landing] Have tiles change color on "hover"
Summary: Invert colors on hover
Test Plan:
Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -209,12 +209,20 @@ div.tile_br {\ndisplay: flex;\npadding: 24px;\nborder-radius: 36px;\n- background-image: linear-gradient(120deg, #fdfbfb 0%, #ebedee 100%);\n+ background-color: #ebedee;\nj... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Have tiles change color on "hover"
Summary: Invert colors on hover
Test Plan:
Here's how it looks:
https://blob.sh/atul/hover.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2087 |
129,184 | 28.09.2021 18:33:58 | 14,400 | 7fcb6cac733d6cba5dd772d61bcc4ec7ac3d08f1 | [landing] Add Twitter/GitHub social tiles to `AppLandingPage`
Summary:
Add social FontAwesome icons to `package.json`
Add Twitter and GitHub icons to bottom row of "tiles"
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "// @flow\n+import { faTwitter, faGithub } from '@fortawesome/free-brands-svg-icons';\nimport {\nfaLock,\nfaUserShield,\n@@ -39,6 +40,16 @@ function AppLanding(): React.Node {\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add Twitter/GitHub social tiles to `AppLandingPage`
Summary:
- Add social FontAwesome icons to `package.json`
- Add Twitter and GitHub icons to bottom row of "tiles"
Test Plan: Here's how it looks: https://blob.sh/atul/social_tiles.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-s... |
129,184 | 29.09.2021 09:00:44 | 14,400 | de236dedb1354ca97b71dd61ea171583ff3ef5d3 | [landing] Handle app screenshot dimensions/scaling in CSS
Summary: Instead of hard-coding dimensions, set in CSS and use `object-fit: scale-down`
Test Plan: Here's how the scaling looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -16,7 +16,7 @@ function AppLanding(): React.Node {\nreturn (\n<div className={css.app_landing_grid}>\n<div className={css.app_preview}>\n- <img height={600} src=\"images/com... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Handle app screenshot dimensions/scaling in CSS
Summary: Instead of hard-coding dimensions, set in CSS and use `object-fit: scale-down`
Test Plan: Here's how the scaling looks: https://blob.sh/atul/screenshot_object_fit.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, ... |
129,184 | 29.09.2021 13:11:45 | 14,400 | 12cdd4463f674dcb1ec0b987d5f6486d90197d02 | [landing] Replace `placeholder` in `Header` with Twitter/GitHub social buttons
Summary:
Remove `placeholder` (was an email icon that did nothing)
Add GitHub/Twitter Links
(Will remove Twitter/GitHub tiles in next diff)
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, k... | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "// @flow\n-import { faEnvelope } from '@fortawesome/free-solid-svg-icons';\n+import { faTwitter, faGithub } from '@fortawesome/free-brands-svg-icons';\nimport { FontAwesomeIcon } from '@... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Replace `placeholder` in `Header` with Twitter/GitHub social buttons
Summary:
- Remove `placeholder` (was an email icon that did nothing)
- Add GitHub/Twitter Links
(Will remove Twitter/GitHub tiles in next diff)
Test Plan: Here's what it looks like: https://blob.sh/atul/844a.png
Reviewers: ashoat, palys... |
129,184 | 29.09.2021 13:38:33 | 14,400 | f186a81230790a678cf4e4d54720d6c15d8fecd7 | [landing] Change color of `Header` links on hover instead of underline
Summary: Instead of underline to indicate active page/hover, we'll go with white/gray like the sitemap
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -113,12 +113,11 @@ div.top_nav h1 {\nfont-size: 16px;\n}\ndiv.top_nav a {\n- color: white;\n+ color: #8a8f98;\n}\ndiv.top_nav a:hover {\n- text-decoration: underline;\n- text-decoration-thick... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Change color of `Header` links on hover instead of underline
Summary: Instead of underline to indicate active page/hover, we'll go with white/gray like the sitemap
Test Plan: Here's what it looks like: https://blob.sh/atul/0ae4.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, ... |
129,184 | 29.09.2021 14:29:26 | 14,400 | 696a7a42bd01b95c5e178391bd49c7e741234a7a | [landing] Make `Header` "responsive"
Summary: CSS grid/etc changes to better layout `Header` on smaller devices
Test Plan:
Before:
After:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -109,9 +109,11 @@ div.top_nav {\nflex-direction: row;\njustify-content: space-evenly;\n}\n+\ndiv.top_nav h1 {\nfont-size: 16px;\n}\n+\ndiv.top_nav a {\ncolor: #8a8f98;\n}\n@@ -460,7 +462,30 @... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make `Header` "responsive"
Summary: CSS grid/etc changes to better layout `Header` on smaller devices
Test Plan:
Before: https://blob.sh/atul/landing_header_before.png
After: https://blob.sh/atul/landing_header_after.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, kar... |
129,184 | 29.09.2021 13:24:29 | 14,400 | bb9a85ea6f7a04dbee55f9e5e34b95302005eaf3 | [landing] Remove Twitter/GitHub "tiles"
Summary: Now that the Twitter/GitHub icons "live" in the `Header`, they can be removed from the grid of tiles.
Test Plan:
Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "// @flow\n-import { faTwitter, faGithub } from '@fortawesome/free-brands-svg-icons';\nimport {\nfaLock,\nfaUserShield,\n@@ -40,16 +39,6 @@ function AppLanding(): React.Node {\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Remove Twitter/GitHub "tiles"
Summary: Now that the Twitter/GitHub icons "live" in the `Header`, they can be removed from the grid of tiles.
Test Plan:
Here's what it looks like:
https://blob.sh/atul/18dc.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
... |
129,184 | 29.09.2021 14:39:20 | 14,400 | 3dc40fedb0ff4dd24a9795e15404db9e217406eb | [landing] Make `app_landing_grid` vertical padding "responsive"
Summary: na
Test Plan: Ensured it looked as expected at each breakpoint
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -236,8 +236,8 @@ div.subscribe_updates {\ndiv.app_landing_grid {\ngrid-template-columns: 1fr 1fr;\ngrid-template-areas: 'app_preview app_copy';\n- padding-top: 80px;\n- padding-bottom: 240px;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make `app_landing_grid` vertical padding "responsive"
Summary: na
Test Plan: Ensured it looked as expected at each breakpoint
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2105 |
129,184 | 30.09.2021 14:45:17 | 14,400 | 1c4cb54c888c3cf5826d02db78ad183d9610095a | [landing] Rename "Comm Messenger" tab to "App" in `Header`
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -26,7 +26,7 @@ function Header(props: HeaderProps): React.Node {\n</div>\n<div className={css.top_nav}>\n<Link to=\"/\">\n- <h1>Comm Messenger</h1>\n+ <h1>App</h1>\n</Link>\n<Link to=... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Rename "Comm Messenger" tab to "App" in `Header`
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2107 |
129,184 | 30.09.2021 15:25:04 | 14,400 | 429fec8e61acbdce023db399f51b404a24d1a094 | [landing] Indicate active tab in `Header`
Summary: Color the active tab white and inactive tab(s) gray.
Test Plan:
Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -6,12 +6,14 @@ import * as React from 'react';\nimport { Link } from 'react-router-dom';\nimport css from './landing.css';\n+import type { LandingPageName } from './landing.react';\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Indicate active tab in `Header`
Summary: Color the active tab white and inactive tab(s) gray.
Test Plan:
Here's what it looks like:
https://blob.sh/atul/header_active_tab.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://ph... |
129,184 | 30.09.2021 16:35:00 | 14,400 | 92b0998288a6f105baf7a59e6ad88fd998a2aa1c | [landing] Indicate active tab in `Footer` sitemap
Summary: Make active page link white in `Footer` sitemap
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -4,9 +4,14 @@ import * as React from 'react';\nimport { Link } from 'react-router-dom';\nimport css from './landing.css';\n+import type { LandingPageName } from './landing.react';\nim... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Indicate active tab in `Footer` sitemap
Summary: Make active page link white in `Footer` sitemap
Test Plan: Here's what it looks like: https://blob.sh/atul/5332.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.... |
129,184 | 30.09.2021 18:36:51 | 14,400 | f2a656e75b2a519b6e657a41ca9df22f688de5d5 | [landing] Fix `Header` tab margin at smallest breakpoint
Summary:
Before:
After:
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -463,8 +463,10 @@ div.body_grid > div + .starting_section {\njustify-content: flex-start;\nalign-self: flex-start;\n}\n- div.top_nav h1 {\n- margin-right: 16px;\n+\n+ div.active_tab,\n+ div.i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix `Header` tab margin at smallest breakpoint
Summary:
Before: https://blob.sh/atul/before_tab_margin_fix.png
After: https://blob.sh/atul/after_tab_margin_fix.png
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Re... |
129,190 | 04.10.2021 11:13:20 | -7,200 | f38f3643ed1638bf230f2ec42b9e41aeccb9b5ec | [services] Improve folder structure for grpc server
Summary: As discussed [here](https://www.notion.so/commapp/Directory-structure-for-the-grpc-docker-server-808e45ba87f8458c84c6f171d30d21a6) I improved the folder structure making it more clear and flat.
Test Plan: check that `cd services && yarn run-grpc-server` still... | [
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"private\": true,\n\"license\": \"BSD-3-Clause\",\n\"scripts\": {\n- \"run-grpc-server\": \"cd .. && ./services/tunnelbroker/run.sh && ./services/tunnelbroker/grpc-server/run.sh --overwrite... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Improve folder structure for grpc server
Summary: As discussed [here](https://www.notion.so/commapp/Directory-structure-for-the-grpc-docker-server-808e45ba87f8458c84c6f171d30d21a6) I improved the folder structure making it more clear and flat.
Test Plan: check that `cd services && yarn run-grpc-server` sti... |
129,190 | 04.10.2021 12:53:35 | -7,200 | 1698a80c39a75796d5ebd313ba136bc5e35232b9 | [native] Move jsi generated code to the `_generated` directory
Summary: in response to
Test Plan: build
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"diff": "#include \"../CryptoTools/CryptoModule.h\"\n#include \"../Tools/CommSecureStore.h\"\n#include \"../Tools/WorkerThread.h\"\n+#inclu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move jsi generated code to the `_generated` directory
Summary: in response to https://www.notion.so/commapp/Move-files-generated-by-react-native-codegen-to-_generated-directory-3796e6403a3d4f418a8f22fd4293fd9e
Test Plan: build
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm... |
129,184 | 04.10.2021 08:57:07 | 14,400 | e4f89c2e39601f3c0adbd0638cf603c31adeac12 | [CommCoreModule] `void virtual` -> `virtual void`
Summary: Super minor refactor, caught this inconsistency when reviewing
Test Plan: Builds successfully (Xcode)
Reviewers: ashoat, karol-bisztyga, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/MessageStoreOperations.h",
"new_path": "native/cpp/CommonCpp/NativeModules/MessageStoreOperations.h",
"diff": "@@ -11,7 +11,7 @@ public:\nMessageStoreOperationBase() = default;\nvirtual ~MessageStoreOperationBase() = default;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] `void virtual` -> `virtual void`
Summary: Super minor refactor, @karol-bisztyga caught this inconsistency when reviewing https://phabricator.ashoat.com/D2078
Test Plan: Builds successfully (Xcode)
Reviewers: ashoat, karol-bisztyga, palys-swm
Reviewed By: ashoat, karol-bisztyga
Subscribers: palys-s... |
129,184 | 04.10.2021 11:25:22 | 14,400 | 0661ce4de6dd8669fc4b3f714517df104c1645e6 | [landing] Make social icons more subtle
Summary: Change social icon styling based on feedback
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -51,12 +51,12 @@ function Header(props: HeaderProps): React.Node {\n<div className={css.social_icons}>\n<a href=\"https://twitter.com/commdotapp\">\n<div className={css.twitter_icon}>... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make social icons more subtle
Summary: Change social icon styling based on feedback
Test Plan: Here's what it looks like: https://blob.sh/atul/subtle_social_icons.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricato... |
129,184 | 03.10.2021 19:17:35 | 14,400 | 2ffe6b670b5a8f9d7d0e7bda95d12c837a50792f | [CommCoreModule] Make `*MessageOperation` member variables `const`
Summary: Modify `*MessageOperation` classes to have `const` member variables
Test Plan: Successfully built in XCode
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -33,9 +33,9 @@ public:\nvirtual void removeMessages(std::vector<std::string> ids) const = 0;\nvirtual void\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Make `*MessageOperation` member variables `const`
Summary: Modify `*MessageOperation` classes to have `const` member variables
Test Plan: Successfully built in XCode
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: h... |
129,184 | 04.10.2021 14:19:39 | 14,400 | 46f06f698ea6b88cd7084a126ca177717ed2c9c9 | [landing] Indicate that "How Comm works" entry in sitemap is external link
Summary: Add external link icon next to "How Comm works" entry in sitemap that links to Notion page
Test Plan: Looks as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "// @flow\n+import { faExternalLinkSquareAlt } from '@fortawesome/free-solid-svg-icons';\n+import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Indicate that "How Comm works" entry in sitemap is external link
Summary: Add external link icon next to "How Comm works" entry in sitemap that links to Notion page
Test Plan: Looks as expected: https://blob.sh/atul/a1de.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian,... |
129,184 | 04.10.2021 16:26:50 | 14,400 | 493da15be9fb6d40685337f390827f0b04e60fc3 | [landing] Add "Request Access" button to `Header`
Summary: The button doesn't do anything yet.
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -49,6 +49,11 @@ function Header(props: HeaderProps): React.Node {\n</div>\n</div>\n<div className={css.social_icons}>\n+ <a href=\"\">\n+ <div className={css.request_access}>\n+ <p>Re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add "Request Access" button to `Header`
Summary: The button doesn't do anything yet.
Test Plan: Here's how it looks: https://blob.sh/atul/request_access_button.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.a... |
129,191 | 05.10.2021 13:58:45 | -7,200 | 27aadcdc873180e3ca1d41688bf4805311b55a79 | Update clang format path
Summary: Update the path
Test Plan: Modify server.cpp, run clang format and check if there's no error about no such file and if the formatting was fixed.
Reviewers: ashoat, karol-bisztyga
Subscribers: Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": ".lintstagedrc.js",
"new_path": ".lintstagedrc.js",
"diff": "@@ -27,7 +27,7 @@ module.exports = {\n'{landing,lib}/**/*.js': function landingFlow(files) {\nreturn 'yarn workspace landing flow --quiet';\n},\n- 'native/**/*.{h,cpp}': function clangFormat(files) {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update clang format path
Summary: Update the path
Test Plan: Modify server.cpp, run clang format and check if there's no error about no such file and if the formatting was fixed.
Reviewers: ashoat, karol-bisztyga
Reviewed By: ashoat, karol-bisztyga
Subscribers: Adrian, atul
Differential Revision: https://phabrica... |
129,190 | 08.10.2021 09:24:20 | -7,200 | aed8900ba76706d18fb1f1bed0424f6b99430e72 | [native] Fix codegen for jsi
Summary: I forgot to update the target path where generated files for jsi are put
Test Plan: `cd native && yarn codegen-jsi`
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/codegen/src/index.js",
"new_path": "native/codegen/src/index.js",
"diff": "@@ -8,6 +8,6 @@ import codeGen from './CodeGen.js';\n('use strict');\nconst schemaInPath = path.resolve('./schema/CommCoreModuleSchema.js');\n-const outPath = path.resolve('./cpp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix codegen for jsi
Summary: I forgot to update the target path where generated files for jsi are put
Test Plan: `cd native && yarn codegen-jsi`
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D... |
129,190 | 08.10.2021 09:29:13 | -7,200 | 5a33d6bc621e4cceeb27ff3dd540bcfd4ce90a69 | [native] Secure random generator - iOS part
Summary: All the information's in D2126
Test Plan: All the information's in D2126
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "71142A7726C2650B0039DCBD /* CommSecureStoreIOSWrapper.mm in Sources */ = {isa = PBXBuildFile; fileRef = 71142A7626C2650A0039DCBD /* CommSecureStoreIOS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Secure random generator - iOS part
Summary: All the information's in D2126
Test Plan: All the information's in D2126
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2127 |
129,190 | 08.10.2021 09:31:07 | -7,200 | 054493cf72d2cf5374308ac2f9a3037963cbb651 | [native] Secure random generator - android part
Summary: All the information's in D2126
Test Plan: All the information's in D2126
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/android/app/src/cpp/PlatformSpecificTools.cpp",
"diff": "+#include \"PlatformSpecificTools.h\"\n+#include \"Logger.h\"\n+#include <fbjni/fbjni.h>\n+\n+using namespace facebook::jni;\n+\n+class PlatformSpecificToolsJavaClass\n+ : public Ja... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Secure random generator - android part
Summary: All the information's in D2126
Test Plan: All the information's in D2126
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2128 |
129,185 | 08.10.2021 12:59:36 | -7,200 | e8187fb53b459bb764dee4a65d4bea9ca171f021 | [CommCoreModule] Add `Thread.h` with c++ thread type
Summary: I introduced Thread type representing ThreadInfo in C++ layer.
Test Plan: The change doesn't modify app behavior.
Reviewers: palys-swm, atul, karol-bisztyga, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h",
"diff": "+#pragma once\n+\n+#include <memory>\n+#include <string>\n+\n+namespace comm {\n+\n+struct Thread {\n+ std::string id;\n+ int type;\n+ std::unique_ptr<std::string> name;\n+ std::... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Add `Thread.h` with c++ thread type
Summary: I introduced Thread type representing ThreadInfo in C++ layer.
Test Plan: The change doesn't modify app behavior.
Reviewers: palys-swm, atul, karol-bisztyga, ashoat
Reviewed By: palys-swm, atul, karol-bisztyga, ashoat
Subscribers: ashoat, palys-swm, Adr... |
129,184 | 05.10.2021 12:08:24 | 14,400 | 69a6afd94c81894dfaceab9d62e1267572580c69 | [landing] Reduce space between "tabs" in `Header`
Summary: Reduce the horizontal spacing between these elements as discussed.
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -107,13 +107,18 @@ div.top_nav {\nalign-self: center;\ndisplay: flex;\nflex-direction: row;\n- justify-content: space-evenly;\n+ justify-content: center;\n}\ndiv.top_nav h1 {\nfont-size: 16px... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Reduce space between "tabs" in `Header`
Summary: Reduce the horizontal spacing between these elements as discussed.
Test Plan: Here's how it looks: https://blob.sh/atul/ef90.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revisi... |
129,184 | 05.10.2021 14:27:34 | 14,400 | 4e10192ddf45488e2cddd1e6b1b9c4d9b1e7b69b | [landing] Update "cycling text" heading
Summary: Update "cycling text" styling and copy
Test Plan:
Figma:
How it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -19,18 +19,20 @@ function AppLanding(): React.Node {\n<img src=\"images/comm-screenshot.png\" />\n</div>\n<div className={css.app_copy}>\n- <h1 className={css.no_bottom_marg... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Update "cycling text" heading
Summary: Update "cycling text" styling and copy
Test Plan:
Figma: https://blob.sh/atul/695d.png
How it looks: https://blob.sh/atul/cycling_crypto_native.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differenti... |
129,184 | 05.10.2021 15:50:16 | 14,400 | db999b839deb7cc13d36f4ba3094f4477f9d95d3 | [landing] Turn 2x2 grid of "tiles" into "cards"
Summary:
Figma:
Here's what it looks like:
Test Plan: CSS could def use some cleaning up
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -37,19 +37,47 @@ function AppLanding(): React.Node {\n<div className={css.tile_grid}>\n<div className={css.tile_tl}>\n<FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={fa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Turn 2x2 grid of "tiles" into "cards"
Summary:
Figma: https://blob.sh/atul/8191.png
Here's what it looks like: https://blob.sh/atul/tiles_to_cards.mov
Test Plan: CSS could def use some cleaning up
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
... |
129,184 | 05.10.2021 17:20:56 | 14,400 | bf8f7d245b07a10b176fefd78757bb9e91ea44ed | [landing] Move "request access"/twtr/gh styles to header.css
Summary: na
Test Plan: Continues to look as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/header.css",
"diff": "+/* ===== REQUEST ACCESS BUTTON ===== */\n+\n+div.request_access {\n+ border-radius: 4px;\n+ padding-inline: 12px;\n+ margin-right: 12px;\n+ background-color: #7e57c2;\n+ color: #ebedee;\n+ transition: 300ms;\n+}\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move "request access"/twtr/gh styles to header.css
Summary: na
Test Plan: Continues to look as expected: https://blob.sh/atul/963e.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2133 |
129,184 | 05.10.2021 17:29:25 | 14,400 | 204e835628f841b88bc99e216868dfbe4897d5c4 | [landing] Move header grid to `header.css`
Summary: na, refactor
Test Plan: Continues to look as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "+/* ===== CSS HEADER GRID LAYOUT ===== */\n+div.header_grid {\n+ max-width: 1920px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ column-gap: 6em;\n+ padding-left: 60px;\n+ pad... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move header grid to `header.css`
Summary: na, refactor
Test Plan: Continues to look as expected: https://blob.sh/atul/e87e.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2134 |
129,184 | 05.10.2021 17:44:04 | 14,400 | 4ffb58c5d8e9b462f001033bf7cd81baed56ab00 | [landing] Move top nav styles to header.css
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -21,8 +21,56 @@ div.header_legal {\ntransition: 300ms;\n}\n-/* ===== REQUEST ACCESS BUTTON ===== */\n+/* ===== LOGO ===== */\n+div.logo {\n+ grid-area: logo;\n+}\n+\n+div.logo h1 {\n+ font-size... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move top nav styles to header.css
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2135 |
129,184 | 05.10.2021 18:16:02 | 14,400 | 5decf33dfdbd9ead2ce3cc94075f10df0ad454a9 | [landing] Move footer grid to `footer.css`
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/footer.css",
"diff": "+/* ===== CSS FOOTER GRID LAYOUT ===== */\n+div.footer_grid {\n+ max-width: 1920px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ column-gap: 6em;\n+ padding-left: 60px;\n+ padding-right: 60px;\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move footer grid to `footer.css`
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2136 |
129,184 | 05.10.2021 18:22:17 | 14,400 | 6637363064ac9ca4a2776034b8d9a08c4a2709dc | [landing] Move sitemap/subscription-form styles to `footer.css`
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -15,6 +15,50 @@ div.footer_grid {\ngrid-template-areas: 'sitemap subscribe_updates';\n}\n+div.sitemap {\n+ grid-area: sitemap;\n+}\n+\n+div.sitemap a {\n+ display: block;\n+ padding-bottom: 4px... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move sitemap/subscription-form styles to `footer.css`
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2137 |
129,184 | 06.10.2021 11:45:13 | 14,400 | 553b4269067f46baba24f184941278df44088e9c | [landing] Fix sitemap link colors
Summary: The active/inactive links in the footer depended on styles intended for the header. This issue became clear after refactoring out the header and footer styles.
Test Plan:
Before:
After:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -31,16 +31,20 @@ div.sitemap a {\nwidth: max-content;\n}\n-div.sitemap a.active_tab,\n-div.sitemap a:hover,\n-div.sitemap a:hover svg {\n+div.inactive_tab a,\n+div.inactive_tab svg {\n+ color: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix sitemap link colors
Summary: The active/inactive links in the footer depended on styles intended for the header. This issue became clear after refactoring out the header and footer styles.
Test Plan:
Before: https://blob.sh/atul/d988.png
After: https://blob.sh/atul/9b26.png
Reviewers: ashoat, palys-swm... |
129,184 | 06.10.2021 14:44:33 | 14,400 | cedcecc6f12aa00f90dd6b16a02dc4015f6964b5 | [server] Add iA Writer Duo to `local-fonts.css`
Summary: Include iA Writer Duo in `local-fonts` so we can use it for local development.
Test Plan: will test once prod is figured out
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": "server/fonts/iAWriterDuoS-Bold.woff2",
"new_path": "server/fonts/iAWriterDuoS-Bold.woff2",
"diff": "Binary files /dev/null and b/server/fonts/iAWriterDuoS-Bold.woff2 differ\n"
},
{
"change_type": "ADD",
"old_path": "server/fonts/iAWriterDuoS-BoldItali... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add iA Writer Duo to `local-fonts.css`
Summary: Include iA Writer Duo in `local-fonts` so we can use it for local development.
Test Plan: will test once prod is figured out
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: ht... |
129,184 | 07.10.2021 12:47:53 | 14,400 | 9c027265418fe91185f97d46fa24e4ad5e2df72b | [landing] Replace lorem ipsum with working copy
Summary:
Not the final copy, but better to work with than lorem ipsum
(the tile CSS is gross, that'll get cleaned up in later diff)
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -149,21 +149,25 @@ div.tile_grid {\ndisplay: grid;\nmargin-right: 16%;\ngrid-template-columns: 1fr;\n- grid-template-rows: 1fr 1fr 1fr 1fr;\n+ grid-template-rows: 1fr 1fr 1fr 1fr 1fr 1fr;\nro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Replace lorem ipsum with working copy
Summary:
Not the final copy, but better to work with than lorem ipsum
(the tile CSS is gross, that'll get cleaned up in later diff)
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differen... |
129,184 | 07.10.2021 15:49:29 | 14,400 | 3e4435a36c5d822f83e5806ac6d2d3538cc140fe | [landing] Update cycling header text
Summary: Update copy and interval.
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -22,10 +22,12 @@ function AppLanding(): React.Node {\n<h1 className={css.mono}>\nComm is crypto-native chat for{' '}\n<TextLoop\n- interval={1000}\n+ interval={1750}\nspring... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Update cycling header text
Summary: Update copy and interval.
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2163 |
129,184 | 07.10.2021 15:59:31 | 14,400 | a01dbe399de9aa5ab615bc652d02cfcb6b04a3e4 | [landing] Update `.app_copy` styling
Summary: Misc layout changes that set stage for introducing scroll snapping.
Test Plan: Looks as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -19,7 +19,7 @@ function AppLanding(): React.Node {\n<img src=\"images/comm-screenshot.png\" />\n</div>\n<div className={css.app_copy}>\n- <h1 className={css.mono}>\n+ <h1 cl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Update `.app_copy` styling
Summary: Misc layout changes that set stage for introducing scroll snapping.
Test Plan: Looks as expected: https://blob.sh/atul/f94c.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.a... |
129,184 | 07.10.2021 17:16:57 | 14,400 | 1117b47d97cf692712c4d1aa4c00e72d7a9667e1 | [landing] Include `StarBackground` in `AppLanding` page
Summary: To keep consistent with "Keyservers" page
Test Plan: Looks as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -11,9 +11,12 @@ import * as React from 'react';\nimport TextLoop from 'react-text-loop';\nimport css from './landing.css';\n+import StarBackground from './star-background.re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Include `StarBackground` in `AppLanding` page
Summary: To keep consistent with "Keyservers" page
Test Plan: Looks as expected: https://blob.sh/atul/112f.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.c... |
129,179 | 10.10.2021 15:46:12 | 14,400 | c0b6ce49e9c639bb674617c77d6963c52a6d1c19 | update project.pbxproj file
Summary:
Update open ssl in project.pbxproj file.
Notion Task:
Test Plan: run yarn cleaninstall with updated cocoapods `1.11.2`
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "inputPaths = (\n\"${PODS_ROOT}/Target Support Files/Pods-Comm/Pods-Comm-frameworks.sh\",\n\"${PODS_ROOT}/hermes-engine/destroot/Library/Frameworks/iph... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | update project.pbxproj file
Summary:
Update open ssl in project.pbxproj file.
Notion Task: https://www.notion.so/commapp/Confirm-Build-Settings-in-Xcode-fe5394291aea4b56b360bb12a524b666
Test Plan: run yarn cleaninstall with updated cocoapods `1.11.2`
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: a... |
129,184 | 11.10.2021 12:43:21 | 14,400 | 5163d888a15fb7134fa2e8e2edcde991fbe2c088 | [landing] Increase "card" row-gap
Summary: Based on feedback from Friday's design meeting
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -167,7 +167,7 @@ div.tile_grid {\nmargin-right: 16%;\ngrid-template-columns: 1fr;\ngrid-template-rows: 1fr 1fr 1fr 1fr 1fr 1fr;\n- row-gap: 20vh;\n+ row-gap: 26vh;\nmargin-top: 32vh;\nmargin-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Increase "card" row-gap
Summary: Based on feedback from Friday's design meeting
Test Plan: Here's how it looks: https://blob.sh/atul/am23.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2174 |
129,184 | 11.10.2021 14:04:21 | 14,400 | 9996f8deae3ef6ace493ed0921ed75422d6b8edf | [landing] Put "card" icon and title on same row
Summary: Put the icon and card "header" on the same row as discussed
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -190,7 +190,6 @@ div.tile_six {\nborder-radius: 8px;\nbackground-color: #ebedee;\njustify-content: center;\n- align-items: center;\nflex-direction: column;\ntransition: 300ms;\nscroll-snap-al... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Put "card" icon and title on same row
Summary: Put the icon and card "header" on the same row as discussed
Test Plan: Here's how it looks: https://blob.sh/atul/71ea.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabrica... |
129,184 | 11.10.2021 14:29:16 | 14,400 | db06fe265085068b702f37d2892936279f342f63 | [landing] Use monospace font for card "title"
Summary: na
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -201,6 +201,7 @@ div.tile_three p.tile_title,\ndiv.tile_four p.tile_title,\ndiv.tile_five p.tile_title,\ndiv.tile_six p.tile_title {\n+ font-family: 'iA Writer Duo S', monospace;\nfont-weight... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Use monospace font for card "title"
Summary: na
Test Plan: Here's how it looks: https://blob.sh/atul/2f50.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2178 |
129,184 | 11.10.2021 14:43:45 | 14,400 | 5ebdafa2ed20b1e7ab84f56abaa7ff8e928bb00e | [landing] Give cards transparent "tint" and blur effect
Summary: Adjust card design as discussed
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -46,7 +46,7 @@ function AppLanding(): React.Node {\n<div className={css.tile_grid}>\n<div className={css.tile_one}>\n<div className={css.tile_title_row}>\n- <FontAwesomeIcon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Give cards transparent "tint" and blur effect
Summary: Adjust card design as discussed
Test Plan: Here's what it looks like: https://blob.sh/atul/f7c5.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com... |
129,184 | 11.10.2021 15:49:27 | 14,400 | edb0a93e414e2a4cb62a101fed70886586651e28 | [landing] Adjust `request_access` responsiveness
Summary: Basically don't want the "Request Access" button to break into two lines right before smallest breakpoint.
Test Plan: Here's how it looks right before smallest breakpoint:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -88,7 +88,7 @@ div.request_access:hover {\n}\ndiv.request_access p {\n- font-size: 16px;\n+ font-size: 14px;\nfont-weight: bold;\nline-height: 2.5;\n}\n@@ -136,6 +136,16 @@ div.github_icon h1 {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Adjust `request_access` responsiveness
Summary: Basically don't want the "Request Access" button to break into two lines right before smallest breakpoint.
Test Plan: Here's how it looks right before smallest breakpoint: https://blob.sh/atul/1a23.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscr... |
129,184 | 11.10.2021 17:24:41 | 14,400 | 90eda1d72a7fd49db6390d9fe6a61f145ffae36a | [landing] Modify "think web3 discord" subheading to match design
Summary:
Make text purple as in design
Also adjusted font sizes so everything looked as expected on iphone 12 mini:
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -61,6 +61,8 @@ span.app_landing_subheading {\np.app_landing_subheading {\nfont-family: 'iA Writer Duo S', monospace;\n+ color: #7e57c2;\n+ font-size: 32px;\n}\nspan.purple_accent {\n@@ -414,7... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Modify "think web3 discord" subheading to match design
Summary:
Make text purple as in design
Also adjusted font sizes so everything looked as expected on iphone 12 mini: https://blob.sh/atul/ae40.png
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, A... |
129,190 | 12.10.2021 11:36:06 | -7,200 | e7af587d5a8cb677f9f6c04a99d25798ddc8f6ae | [native] Fix random string signs for secure random
Summary: in response to now the length is 64.
Test Plan: -
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/CryptoTools/Tools.cpp",
"new_path": "native/cpp/CommonCpp/CryptoTools/Tools.cpp",
"diff": "@@ -8,7 +8,7 @@ namespace crypto {\nstd::string Tools::generateRandomString(size_t size) {\nstatic std::string availableSigns =\n- \" 0123456789abcd... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix random string signs for secure random
Summary: in response to https://phabricator.ashoat.com/D2126#49597 now the length is 64.
Test Plan: -
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2173 |
129,184 | 12.10.2021 15:47:13 | 14,400 | 04fea8d18fb59489b39c28be49bf4649ed206f18 | [landing] Include `react-waypoint` dependency
Summary:
GitHub:
After struggling with `react-scrollama`, `scrollama`, and `scrollmagic`... this worked great out of the box w/ SSR
Test Plan: Added "waypoints" to `AppLanding`, logged `onPositionChange`, and verified it worked as expected
Reviewers: ashoat, palys-swm
Subsc... | [
{
"change_type": "MODIFY",
"old_path": "landing/package.json",
"new_path": "landing/package.json",
"diff": "\"@fortawesome/free-brands-svg-icons\": \"^5.15.4\",\n\"@fortawesome/react-fontawesome\": \"^0.1.5\",\n\"react-text-loop\": \"^2.3.0\",\n+ \"react-waypoint\": \"^10.1.0\",\n\"@lottiefiles/lott... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Include `react-waypoint` dependency
Summary:
GitHub: https://github.com/civiccc/react-waypoint
After struggling with `react-scrollama`, `scrollama`, and `scrollmagic`... this worked great out of the box w/ SSR
Test Plan: Added "waypoints" to `AppLanding`, logged `onPositionChange`, and verified it worked a... |
129,184 | 12.10.2021 16:05:18 | 14,400 | b8f7372ae3496c9a8b6aab2ef3b52d5b9a16de46 | [landing] Introduce `active_card` style
Summary:
Style for "active" info card
In next diff will use `react-waypoint` to conditionally apply style to "active" card
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -44,7 +44,7 @@ function AppLanding(): React.Node {\n(think "Web3 Discord")\n</p>\n<div className={css.tile_grid}>\n- <div className={css.tile_one}>\n+ <div classNa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Introduce `active_card` style
Summary:
Style for "active" info card
In next diff will use `react-waypoint` to conditionally apply style to "active" card
Test Plan: Here's how it looks: https://blob.sh/atul/ae35.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bi... |
129,184 | 13.10.2021 16:18:55 | 14,400 | 0422ad22c2f31c256317cb0043f72f7867b350fa | [landing] Absolutely position `StarBackground` and slow animation
Summary: NA
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/star-background.css",
"new_path": "landing/star-background.css",
"diff": "+div.star_container {\n+ position: absolute;\n+}\n+\n@keyframes parallax {\nfrom {\ntransform: translateY(0px);\n@@ -11,7 +15,7 @@ div.stars_small {\nwidth: 1px;\nheight: 1px;\nb... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Absolutely position `StarBackground` and slow animation
Summary: NA
Test Plan: Here's how it looks: https://watch.videodelivery.net/f983e2bc2d327065faa984e547b763d0
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.... |
129,184 | 13.10.2021 14:29:44 | 14,400 | 7d79131422a201064f1226aaa922fe8679564131 | [landing] Miscellaneous `InfoCard` styling tweaks
Summary:
More padding b/w header and description
Increased `row-gap`
Increased card padding
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -63,6 +63,7 @@ p.app_landing_subheading {\nfont-family: 'iA Writer Duo S', monospace;\ncolor: #7e57c2;\nfont-size: 32px;\n+ padding-inline: 0px;\n}\nspan.purple_accent {\n@@ -171,9 +172,9 @@ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Miscellaneous `InfoCard` styling tweaks
Summary:
- More padding b/w header and description
- Increased `row-gap`
- Increased card padding
Test Plan: Here's what it looks like: https://blob.sh/atul/c925.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Di... |
129,184 | 13.10.2021 13:03:57 | 14,400 | 1ff11b66ae70385bda582e04bb3d0773541b61c7 | [landing] Introduce `InfoCard` component and use in `AppLanding`
Summary: Will help avoid the boilerplate in D2187
Test Plan: Continues to look as before
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/info-card.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import css from './landing.css';\n+\n+type InfoCardProps = {\n+ +label: string,\n+ +active: boolean,\n+ +icon: React.Node,\n+ +description: string,\n+ +bas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Introduce `InfoCard` component and use in `AppLanding`
Summary: Will help avoid the boilerplate in D2187
Test Plan: Continues to look as before
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2198 |
129,184 | 13.10.2021 13:13:31 | 14,400 | f08977a7b73357b9438886d7ab020d1f754ee49b | [landing] Pull `CyclingHeader` component out of `AppLanding`
Summary: Simple refactor to clean things up a little
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -10,8 +10,8 @@ import {\n} from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\n-im... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Pull `CyclingHeader` component out of `AppLanding`
Summary: Simple refactor to clean things up a little
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2199 |
129,184 | 13.10.2021 14:08:19 | 14,400 | 4e89f36067dfb7d8ba2b6b3259ae4c2e29770462 | [landing] Style active `InfoCard` on scroll
Summary: Moved "waypoint" logic from `AppLanding` to `InfoCard`
Test Plan: Continues to work as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "// @flow\nimport * as React from 'react';\n+import { Waypoint } from 'react-waypoint';\nimport css from './landing.css';\ntype InfoCardProps = {\n+ +idx: number,\n+label: string,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Style active `InfoCard` on scroll
Summary: Moved "waypoint" logic from `AppLanding` to `InfoCard`
Test Plan: Continues to work as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2200 |
129,179 | 13.10.2021 18:35:44 | 14,400 | 81b3268d3727132d7609dd09d30945c0ff54a00d | clean up from D2120 -- remove unneed code
Summary: Remove repetitive functions
Test Plan: run the code, make sure it works
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/reactotron.js",
"new_path": "native/reactotron.js",
"diff": "import AsyncStorage from '@react-native-community/async-storage';\n-import { fetchDevServerHostnameSync } from './utils/url-utils';\n+import { getDevServerHostname } from './utils/url-utils';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | clean up from D2120 -- remove unneed code
Summary: Remove repetitive functions
Test Plan: run the code, make sure it works
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2205 |
129,184 | 14.10.2021 11:58:12 | 14,400 | ef0cf780729a77599ecd5fc66b36c84ea9f5fa03 | [landing] Pass icon to `InfoCard` as `IconDefinition` instead of `React.Node`
Summary: Addressed feedback from D2198
Test Plan: Continues to look as expected (after force restart)
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "// @flow\n+import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { Waypoint } from 'react-waypoint';\n@@ -9,7 +10,7 @@ type Inf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Pass icon to `InfoCard` as `IconDefinition` instead of `React.Node`
Summary: Addressed feedback from D2198
Test Plan: Continues to look as expected (after force restart)
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac
Differential Revision: https... |
129,184 | 14.10.2021 16:27:39 | 14,400 | 862c9696c162ed452241f157b0878063e77713f3 | [native] Update `native/package.json` clean scripts
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"license\": \"BSD-3-Clause\",\n\"scripts\": {\n\"clean\": \"yarn clean-android && yarn clean-ios && rm -rf node_modules/\",\n- \"clean-android\": \"cd android && ./gradlew clean && rm -rf build... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update `native/package.json` clean scripts
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2217 |
129,184 | 14.10.2021 18:01:38 | 14,400 | 6c91bb43a6ac8dfa05d47d29ed4d3d709a46cf90 | [landing] Replace prototype assets with higher resolution ones
Summary:
NA, swapping out PNGs
(will address blurry downscaled images in separate diff)
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/images/customizable-prototype.png",
"new_path": "server/images/customizable-prototype.png",
"diff": "Binary files a/server/images/customizable-prototype.png and b/server/images/customizable-prototype.png differ\n"
},
{
"change_type": "MODIFY",
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Replace prototype assets with higher resolution ones
Summary:
NA, swapping out PNGs
(will address blurry downscaled images in separate diff)
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential ... |
129,184 | 14.10.2021 18:14:26 | 14,400 | bd91b470e748c1877aa16a0e9e737e4d881c0896 | [landing] Fix issue with blurry downscaled images
Summary: Solution via GoojajiGreg on StackOverflow:
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -33,6 +33,20 @@ a {\nmargin-bottom: 0;\n}\n+@media screen and (-webkit-min-device-pixel-ratio: 0) and (min-resolution: 0.001dpcm) {\n+ img {\n+ image-rendering: -webkit-optimize-contrast !imp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix issue with blurry downscaled images
Summary: Solution via GoojajiGreg on StackOverflow: https://stackoverflow.com/questions/37906602/blurry-downscaled-images-in-chrome/69137897#69137897
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, bens... |
129,190 | 14.10.2021 10:36:23 | -7,200 | 672fe9843eee90a6ad0485e190460b4a7a1857b4 | [services] Fix make -j
Summary: I noticed there are some errors using `-j` flag.
Test Plan: `cd services && yarn run-grpc-server`
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/contents/server/build.sh",
"new_path": "services/tunnelbroker/contents/server/build.sh",
"diff": "set -e\n-echo \"building the server...\"\n+NPROC=0\n+\n+NPROC=$(nproc 2> /dev/null || echo 1)\n+if [[ $NPROC -eq 1 ]]\n+then\n+ NPROC=$(sysc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Fix make -j
Summary: I noticed there are some errors using `-j` flag.
Test Plan: `cd services && yarn run-grpc-server`
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2189 |
129,187 | 14.10.2021 19:04:05 | 14,400 | b0da13ca1b42156aaeb7d571df348d19aee5ee6b | [native] cd android before ./gradlew clean in yarn clean-all
Test Plan: Run it
Reviewers: atul, geekbrother, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"clean\": \"yarn clean-android && yarn clean-ios && rm -rf node_modules/\",\n\"clean-android\": \"cd android && rm -rf build app/build app/.cxx\",\n\"clean-ios\": \"rm -rf ios/Pods/\",\n- \"cle... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] cd android before ./gradlew clean in yarn clean-all
Test Plan: Run it
Reviewers: atul, geekbrother, palys-swm
Reviewed By: palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2221 |
129,187 | 14.10.2021 18:10:39 | 14,400 | 69d21088472f3074fab6a7cc6e05b955aaed78ac | [native] [expo-splash-screen-update] [2/4]
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"@react-navigation/stack\": \"^5.12.8\",\n\"base-64\": \"^0.1.0\",\n\"expo-haptics\": \"^10.1.0\",\n- \"expo-image-manipulator\": \"^8.4.0\",\n+ \"expo-image-manipulator\": \"^9.2.2\",\n\"expo-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [expo-splash-screen-update] [2/4] expo-image-manipulator@9.2.2
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabr... |
129,187 | 14.10.2021 18:15:44 | 14,400 | a30e4b3feaa10bbba96fc591392168f3a204ad1d | [native] [expo-splash-screen-update] [3/4]
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -356,6 +356,38 @@ PODS:\n- CocoaAsyncSocket (7.6.5)\n- DoubleConversion (1.1.6)\n- DVAssetLoaderDelegate (0.3.3)\n+ - EXConstants (11.0.2):\n+ - ExpoModulesCore\n+ - UMCore\n+ - EXFil... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [expo-splash-screen-update] [3/4] expo-media-library@12.1.2
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabrica... |
129,187 | 15.10.2021 23:03:51 | 14,400 | a331f2dc16b22b9a84afeb84bf525cd408ed3ff4 | [native] [expo-splash-screen-update] [4/4]
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -490,6 +490,7 @@ android {\ndependencies {\nimplementation fileTree(dir: \"libs\", include: [\"*.jar\"])\n+ implementation \"org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [expo-splash-screen-update] [4/4] expo-splash-screen@0.11.4
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabrica... |
129,184 | 17.10.2021 12:00:37 | 14,400 | f9e92bb32e98f2e1f7bc03018635f519d8901b0a | [native] `codeVersion` -> 104 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -395,8 +395,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 104 |
129,184 | 17.10.2021 13:21:50 | 14,400 | c81d5fb418075c5399797aa2f6b62bd4d79c9e51 | [native] `codeVersion` -> 105 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -395,8 +395,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 105 |
129,184 | 15.10.2021 15:27:18 | 14,400 | 7d87a11fc6c2c1ffd488a93300c03b4ab81cdd34 | [landing] Preload PNG or WEBP images based on WEBP browser support
Summary: Adapted from
Test Plan: Tested the WEBP supported case via console log
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -37,10 +37,22 @@ function AppLanding(): React.Node {\nconst [activeCardIdx, setActiveCardIdx] = React.useState(-1);\nReact.useEffect(() => {\n+ // Depending on WEBP browser ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Preload PNG or WEBP images based on WEBP browser support
Summary: Adapted from https://developers.google.com/speed/webp/faq#in_your_own_javascript
Test Plan: Tested the WEBP supported case via console log
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, ben... |
129,184 | 15.10.2021 15:42:34 | 14,400 | 941706a62d95704e3d257ea675e6ac63caa43cc4 | [landing] Start with "home screen" prototype before "federated"
Summary: Addressed feedback from yesterday
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -55,6 +55,14 @@ function AppLanding(): React.Node {\ntestImg.src = `data:image/webp;base64,${testWEBP}`;\n}, []);\n+ const imageIdx =\n+ activeCardIdx === -1\n+ ? 1\n+ : Mat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Start with "home screen" prototype before "federated"
Summary: Addressed feedback from yesterday
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D222... |
129,184 | 15.10.2021 16:20:24 | 14,400 | 75b6af3c6e5b3e06cfc55f5e7a375b22728d00d5 | [landing] Add purple radial gradient to top corner
Summary: na
Test Plan:
Here's what it looks like:
(Though, I prefer it in the top left corner:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -9,6 +9,11 @@ html {\n/* Override browser default to achieve edge-to-edge footer translucency effect */\nbody {\n+ background-image: radial-gradient(\n+ circle at top left,\n+ #2d008888 0%,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add purple radial gradient to top corner
Summary: na
Test Plan:
Here's what it looks like: https://blob.sh/atul/8bd2.png
(Though, I prefer it in the top left corner: https://blob.sh/atul/b61f.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, bo... |
129,184 | 18.10.2021 14:44:45 | 14,400 | 9d82497a1e8fd52e2ba35c2c520ae9abb26eac44 | [landing] Refactor screenshot pre-loading
Summary: Less repetition, more readable
Test Plan: Looks the same to me
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -15,53 +15,45 @@ import InfoCard from './info-card.react';\nimport css from './landing.css';\nimport StarBackground from './star-background.react';\n-const screenshotsWEBP =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Refactor screenshot pre-loading
Summary: Less repetition, more readable
Test Plan: Looks the same to me
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2238 |
129,179 | 18.10.2021 16:43:53 | 14,400 | 671880ff04a142138f524655a43be0a457ce96f5 | sort endpoints file alphabetically
Summary: small refactor: sort file alphabetically for consistency. is the plugin I use.
Test Plan: make sure the file isn't broken.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/endpoints.js",
"new_path": "server/src/endpoints.js",
"diff": "@@ -55,45 +55,45 @@ import { codeVerificationResponder } from './responders/verification-responders'\nimport { uploadDeletionResponder } from './uploads/uploads';\nconst jsonEndpoints: {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | sort endpoints file alphabetically
Summary: small refactor: sort file alphabetically for consistency. https://marketplace.visualstudio.com/items?itemName=richie5um2.vscode-sort-json is the plugin I use.
Test Plan: make sure the file isn't broken.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-... |
129,184 | 18.10.2021 21:47:50 | 14,400 | a83c000e63c50b0272d942bee7b1712a47d3ab17 | [landing] Get landing assets from CloudFront (CDN)
Summary: Previously, we were fetching directly from S3. Instead, we'll now fetch from AWS CloudFront (CDN in front of S3)
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -24,8 +24,7 @@ const screenshots = [\n'less-noisy-prototype',\n];\n-const LandingAssetsS3URL =\n- 'https://comm-landing-assets.s3.us-east-2.amazonaws.com';\n+const LandingAs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Get landing assets from CloudFront (CDN)
Summary: Previously, we were fetching directly from S3. Instead, we'll now fetch from AWS CloudFront (CDN in front of S3)
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, bens... |
129,184 | 19.10.2021 11:47:19 | 14,400 | 248529fbf61fac491771c48edf0911f26a0b21ce | [landing] Misc styling changes
Summary:
1. cleaner CSS selectors
2. reduced row-gap
3. misc font size changes so things were more "proportional"
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -180,7 +180,7 @@ div.app_copy {\nh1.cycling_header {\nfont-family: 'iA Writer Duo S', monospace;\n- font-size: 52px;\n+ font-size: 50px;\nmargin-top: 26vh;\nwhite-space: pre-wrap;\n}\n@@ -191... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Misc styling changes
Summary:
1. cleaner CSS selectors
2. reduced row-gap
3. misc font size changes so things were more "proportional"
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revisio... |
129,184 | 19.10.2021 11:53:11 | 14,400 | 3a79d65da519971ea4f3000699f67fea75a9754c | [landing] Get rid of `scroll-snap`
Summary: Decided to cut `scroll-snap` for now
Test Plan: Can scroll freely through page
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -13,7 +13,6 @@ div.footer_grid {\ntransition: 300ms;\ngrid-template-columns: 1fr 1fr;\ngrid-template-areas: 'sitemap subscribe_updates';\n- scroll-snap-align: center;\n}\ndiv.footer_legal {\n"
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Get rid of `scroll-snap`
Summary: Decided to cut `scroll-snap` for now
Test Plan: Can scroll freely through page
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2247 |
129,184 | 19.10.2021 11:55:54 | 14,400 | 6675d51e051fe9408a24c8044818d2af84e30ba9 | [landing] Get rid of `backdrop-filter`
Summary: Set `backdrop-filter` to none (except on Safari which seems to handle it okay?)
Test Plan: No more blur on Chrome
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -66,7 +66,7 @@ div.subscribe_updates {\n/* ===== VISUAL EFFECTS ===== */\ndiv.footer_blur {\nbackground-color: rgba(255, 255, 255, 0.125);\n- backdrop-filter: blur(2px);\n+ backdrop-filter: non... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Get rid of `backdrop-filter`
Summary: Set `backdrop-filter` to none (except on Safari which seems to handle it okay?)
Test Plan: No more blur on Chrome
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://p... |
129,184 | 19.10.2021 15:40:48 | 14,400 | 9f2ce19b702d9c69a417248d23664d63ef965b17 | Temporary changes for staff release
1. `expo-media-library`: don't include videos
2. `mediaConfig`: don't treat animated GIFs as videos
3. Enable `processedMessageStore` invariants for `release` build
4. Enable `processedThreadStore` invariants for `release` build
5. Patch to re-enable SplashScreen auto-hide | [
{
"change_type": "MODIFY",
"old_path": "lib/media/file-utils.js",
"new_path": "lib/media/file-utils.js",
"diff": "@@ -33,7 +33,7 @@ const mediaConfig: { [mime: string]: MediaConfig } = Object.freeze({\nserverTranscodesImage: true,\n},\n'image/gif': {\n- mediaType: 'photo_or_video',\n+ mediaType: 'ph... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Temporary changes for staff release
1. `expo-media-library`: don't include videos
2. `mediaConfig`: don't treat animated GIFs as videos
3. Enable `processedMessageStore` invariants for `release` build
4. Enable `processedThreadStore` invariants for `release` build
5. Patch to re-enable SplashScreen auto-hide |
129,184 | 19.10.2021 15:43:30 | 14,400 | 79ee30c6399860c33ff334b959323748bede3a3d | [native] `codeVersion` -> 106 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -395,8 +395,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 106 |
129,184 | 19.10.2021 13:48:15 | 14,400 | e1eebeeac94c667015a2ceb65b005c137ea55612 | [landing] Add two intermediate breakpoints for cycling_header/card_title
Summary: Add two new intermediate breakpoints on either side of the "medium" breakpoint to "buffer" the change in font-size to make it less jarring
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bis... | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -291,6 +291,17 @@ div.body_grid > div + .starting_section {\npadding-top: 80px;\n}\n+/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n+@media (max-width: 1699px) {\n+ div.tile_title_row > p.tile_ti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add two intermediate breakpoints for cycling_header/card_title
Summary: Add two new intermediate breakpoints on either side of the "medium" breakpoint to "buffer" the change in font-size to make it less jarring
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: pal... |
129,190 | 20.10.2021 10:05:26 | -7,200 | 74b4e13e59b5deca4422226f91abdd583205a41e | [services] Add backup server docker image
Summary:
The whole stack: D2207, D2208, D2209, D2210, D2211
Adding a new docker image for AWS built on the top of AWS base image from D2207
Test Plan: -
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Tags: #aws_init | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/Dockerfile",
"diff": "+FROM commapp/backup-base:1.0\n+\n+ENV SHELL=/bin/bash\n+\n+COPY services/backup/contents /transferred\n+COPY native/cpp/CommonCpp/grpc/protos/backup.proto /transferred/server/protos/backup.pro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Add backup server docker image
Summary:
The whole stack: D2207, D2208, D2209, D2210, D2211
Adding a new docker image for AWS built on the top of AWS base image from D2207
Test Plan: -
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Tags: #aws_in... |
129,184 | 20.10.2021 09:39:43 | 14,400 | 3cc3f115c9c83e22673019600df5348ca3619343 | Include link to landing page in README.md | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -9,7 +9,7 @@ The whole project is written in Flow-typed Javascript. The code is organized in\n- `native` contains the code for the React Native app, which supports both iOS and Android.\n- `server` contains the ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include link to landing page in README.md |
129,184 | 20.10.2021 10:35:09 | 14,400 | 67877c4c4c4c52c567bcf727158ef53dd903ba9c | [lib] Introduce `RemoveAllMessagesOperation` type
Summary:
Create `remove_all` op that can be passed to `processMessageStoreOperations`
Previously there was a `removeAllMessages` function... which will be removed in subsequent diff
Test Plan: flow
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-biszt... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -352,6 +352,15 @@ export type ReplaceMessageOperation = {\n+payload: { +id: string, +messageInfo: RawMessageInfo },\n};\n+export type RekeyMessageOperation = {\n+ +type: 'rekey'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `RemoveAllMessagesOperation` type
Summary:
Create `remove_all` op that can be passed to `processMessageStoreOperations`
Previously there was a `removeAllMessages` function... which will be removed in subsequent diff
Test Plan: flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: paly... |
129,201 | 20.10.2021 22:57:08 | -10,800 | 6b337224330990140a8b7532e0064e60014a2526 | [native] Removing unused gRPC plugins from the CMakeLists
Summary: Removing unused plugins from the gRPC building.
Test Plan: Build release for Android and IOS
Reviewers: ashoat, palys-swm, karol-bisztyga
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/CMakeLists.txt",
"new_path": "native/android/app/CMakeLists.txt",
"diff": "@@ -28,6 +28,11 @@ set(protobuf_BUILD_TESTS OFF)\n# gRPC building parameters\nset(gRPC_BUILD_CSHARP_EXT OFF)\nset(gRPC_SSL_PROVIDER \"package\" CACHE STRING \"SSL lib... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Removing unused gRPC plugins from the CMakeLists
Summary: Removing unused plugins from the gRPC building.
Test Plan: Build release for Android and IOS
Reviewers: ashoat, palys-swm, karol-bisztyga
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, boristopalov
Differential... |
129,190 | 21.10.2021 13:28:15 | -7,200 | bd273651a10b4efbf4f3809824bc7e17186be761 | [services] Use linux apline
Summary: Instead of using ubuntu we can use more lightweight linux alpine which is recommended for docker images
Test Plan: run all the scripts from `services` `package.json`
Reviewers: palys-swm, ashoat, geekbrother
Subscribers: geekbrother, ashoat, palys-swm, Adrian, atul, benschac, borist... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-base/Dockerfile",
"new_path": "services/backup/docker-base/Dockerfile",
"diff": "@@ -4,8 +4,8 @@ ENV SHELL=/bin/bash\nCOPY services/backup/contents /transferred\n-RUN apt update -y &&\\\n- apt install -y libcurl4-openssl-dev libssl-dev u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Use linux apline
Summary: Instead of using ubuntu we can use more lightweight linux alpine which is recommended for docker images
Test Plan: run all the scripts from `services` `package.json`
Reviewers: palys-swm, ashoat, geekbrother
Reviewed By: palys-swm, ashoat
Subscribers: geekbrother, ashoat, palys... |
129,179 | 20.10.2021 10:57:13 | 14,400 | 14872279453b38d3aec1ff6cbcbd690702bfe1b4 | refactor register currentUserInfo in account-creator.js + refactor lib/actions register action
Summary: refactor currentUserInfo object server side so its getting its values from fetchLoggedInUserInfo, refactor lib/action to reflect server side change.
Test Plan: register a new user.
Reviewers: ashoat, palys-swm
Subscr... | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -79,10 +79,7 @@ const register = (\nplatformDetails: getConfig().platformDetails,\n});\nreturn {\n- currentUserInfo: {\n- id: response.id,\n- username: registerInfo.username,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | refactor register currentUserInfo in account-creator.js + refactor lib/actions register action
Summary: refactor currentUserInfo object server side so its getting its values from fetchLoggedInUserInfo, refactor lib/action to reflect server side change.
Test Plan: register a new user.
Reviewers: ashoat, palys-swm
Re... |
129,184 | 21.10.2021 19:07:11 | 14,400 | 1c78e1b549324d2283bd3e0d21f1b71aad8fa434 | [iOS] Remove `showSplashScreenFor:rootViewController` from `AppDelegate.mm`
Summary: It appears that removing this from `AppDelegate.mm` resolves the "stuck" splash screen issue
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/AppDelegate.mm",
"new_path": "native/ios/Comm/AppDelegate.mm",
"diff": "@@ -120,13 +120,6 @@ extern RCTBridge *_bridge_reanimated;\nrootView.loadingViewFadeDelay = 0;\nrootView.loadingViewFadeDuration = 0.001;\n- // This sets up the splash scre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [iOS] Remove `showSplashScreenFor:rootViewController` from `AppDelegate.mm`
Summary: It appears that removing this from `AppDelegate.mm` resolves the "stuck" splash screen issue
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Di... |
129,179 | 21.10.2021 15:21:57 | 14,400 | d948651849c13461eb474f0ea8a84937d761e308 | feat: add accessability labels to images
Summary: add alt tags to images
Test Plan: view source for alt tags
Reviewers: ashoat, atul, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -16,12 +16,30 @@ import css from './landing.css';\nimport StarBackground from './star-background.react';\nconst screenshots = [\n- 'federated-prototype',\n- 'customizable-pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | feat: add accessability labels to images
Summary: add alt tags to images
Test Plan: view source for alt tags
Reviewers: ashoat, atul, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2254 |
129,179 | 21.10.2021 17:51:38 | 14,400 | 2c77ac717e12c6b2b4f59aefb1948bc9ada1f3d5 | fix centering issue hero text
Summary: Center hero text with phone on resize
Test Plan:
resize the window
Before:
After:
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -96,10 +96,13 @@ function AppLanding(): React.Node {\n</picture>\n</div>\n<div className={css.app_copy}>\n+ <div className={css.app_copy_wrapper}>\n<CyclingHeader />\n<p cla... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | fix centering issue hero text
Summary: Center hero text with phone on resize
Test Plan:
resize the window
Before: https://share.getcloudapp.com/Kou7e8D0
After: https://share.getcloudapp.com/04u5gnoG
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga,... |
129,179 | 27.10.2021 13:39:56 | 14,400 | 4dcc3c32fdc2f12a29a1cc610659fdf09fafa402 | [server] chore sort endpoints and add default user notifications to endpoints file
Summary: Sort endpoints file and add the default_user_settings type check for a responder
Test Plan: review
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/endpoints.js",
"new_path": "lib/types/endpoints.js",
"diff": "@@ -46,36 +46,37 @@ const socketOnlyEndpoints = Object.freeze({\ntype SocketOnlyEndpoint = $Values<typeof socketOnlyEndpoints>;\nconst socketPreferredEndpoints = Object.freeze({\n- UPDATE_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] chore sort endpoints and add default user notifications to endpoints file
Summary: Sort endpoints file and add the default_user_settings type check for a responder
Test Plan: review
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopal... |
129,184 | 27.10.2021 01:01:25 | 14,400 | 18cfce2968c58acfa798603185bacd20ee9812b7 | [CommCoreModule] Fix memory issue in `getAllMessages`
Summary: Described here:https://www.notion.so/commapp/Runtime-memory-issues-in-getAllMessages-b2bc7f334a094cabb4f92325adbcc4cc
Test Plan: Successfully builds, able to get expected response from `GetAllMessages`
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Ad... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -170,15 +170,17 @@ jsi::Value CommCoreModule::getAllMessages(jsi::Runtime &rt) {\n} catch (std::system_error &e) {\nerror =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Fix memory issue in `getAllMessages`
Summary: Described here:https://www.notion.so/commapp/Runtime-memory-issues-in-getAllMessages-b2bc7f334a094cabb4f92325adbcc4cc
Test Plan: Successfully builds, able to get expected response from `GetAllMessages`
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
S... |
129,179 | 27.10.2021 16:24:55 | 14,400 | 696c61f73b2dbcd36539e82d880023edb1da230f | [refactor][native] sort route names
Summary: sort routes alphabetically
Test Plan: make sure names are in order and no regression is introduced, build and run the app. Clicked through it a bit and make sure nothing is broken.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalo... | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/route-names.js",
"new_path": "native/navigation/route-names.js",
"diff": "@@ -23,49 +23,49 @@ import type { CustomServerModalParams } from '../profile/custom-server-modal.rea\nimport type { RelationshipListItemTooltipModalParams } from '../pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [refactor][native] sort route names
Summary: sort routes alphabetically
Test Plan: make sure names are in order and no regression is introduced, build and run the app. Clicked through it a bit and make sure nothing is broken.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adria... |
129,184 | 29.10.2021 15:02:06 | 14,400 | 316538446ac3d2027cf6719d81ee276ae026c20d | [CommCoreModule] Make `processMessageStoreOps:messageStoreOps` `vector<unique_ptr>`
Summary: Modify type of std::vector to be consistent
Test Plan: `processMessageStoreOps` continues to work as expected (cleared the message store, bulk loaded my prod message store, rekeyed some messages, etc)
Reviewers: ashoat, palys-s... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -228,7 +228,7 @@ jsi::Value CommCoreModule::processMessageStoreOperations(\njsi::Runtime &rt,\nconst jsi::Array &operations... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Make `processMessageStoreOps:messageStoreOps` `vector<unique_ptr>`
Summary: Modify type of std::vector to be consistent
Test Plan: `processMessageStoreOps` continues to work as expected (cleared the message store, bulk loaded my prod message store, rekeyed some messages, etc)
Reviewers: ashoat, paly... |
129,179 | 30.10.2021 16:07:12 | 14,400 | ea5b80a83c011218c48251aee50596151ca3c72a | [refactor][native] profile screen add additional cases to action row
Summary: handle danger text, custom right items, custom text
Test Plan: got to profile page make sure everything still works
Reviewers: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/components/action-row.react.js",
"new_path": "native/components/action-row.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { View, Text } from 'react-native';\n-import Icon from 'react-native-vector-icons/Ionicons';\n+import { Vie... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [refactor][native] profile screen add additional cases to action row
Summary: handle danger text, custom right items, custom text
Test Plan: got to profile page make sure everything still works
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differe... |
129,184 | 31.10.2021 14:25:47 | 14,400 | 0809df03dc169218559f47fa863e43b712dda4d5 | [CI] Introduce `exportOptions.plist`
Summary: This plist file gets passed as an argument to `xcodebuild -archive ...` for command-line builds to replace the export archive GUI wizard in Xcode
Test Plan: Tested locally, not yet on CI
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, ... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/ios/exportOptions.plist",
"diff": "+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!DOCTYPE plist PUBLIC \"-//Apple//DTD PLIST 1.0//EN\" \"http://www.apple.com/DTDs/PropertyList-1.0.dtd\">\n+<plist version=\"1.0\">\n+<dict>\n+ <key>destina... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `exportOptions.plist`
Summary: This plist file gets passed as an argument to `xcodebuild -archive ...` for command-line builds to replace the export archive GUI wizard in Xcode
Test Plan: Tested locally, not yet on CI
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, k... |
129,179 | 01.11.2021 14:02:47 | 14,400 | 7f66bdea48ec139e2cbc08a51a947b84058c239d | [server] query user settings on login + registration using user-fetchers fetchLoggedInUserInfo
Summary: query settings table and return user selected settings
Test Plan: login or register an account. View settings in redux
Reviewers: ashoat, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, borist... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/user-types.js",
"new_path": "lib/types/user-types.js",
"diff": "@@ -47,6 +47,9 @@ export type OldLoggedInUserInfo = {\nexport type LoggedInUserInfo = {\n+id: string,\n+username: string,\n+ +settings?: {\n+ +defaultNotifications?: string,\n+ },\n};\ne... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] query user settings on login + registration using user-fetchers fetchLoggedInUserInfo
Summary: query settings table and return user selected settings
Test Plan: login or register an account. View settings in redux
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: ashoat, palys-swm, ... |
129,184 | 01.11.2021 19:43:50 | 14,400 | 5138a01c38ddf79d00fc819408f729876000de48 | [native] `codeVersion` -> 108 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -424,8 +424,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 108 |
129,184 | 01.11.2021 19:51:18 | 14,400 | 43dc2cd611d8d7d35550f79a8800a501120f0472 | [native] `codeVersion` -> 109 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -424,8 +424,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 109 |
129,190 | 02.11.2021 08:48:17 | -3,600 | c7906646dfb662f0e6f04a032dbabb6cd4103b01 | [services] Disable unused grpc plugins
Summary: Disable plugins/extensions of grpc that we will not use for services tunnelbroker and backup.
Test Plan: build back and tunnelbroker services.
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: geekbrother, ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/backup/contents/server/CMakeLists.txt",
"new_path": "services/backup/contents/server/CMakeLists.txt",
"diff": "@@ -18,6 +18,15 @@ message(STATUS \"Using protobuf ${Protobuf_VERSION}\")\nset(_PROTOBUF_LIBPROTOBUF protobuf::libprotobuf)\nset(_PROTOBUF_P... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Disable unused grpc plugins
Summary: Disable plugins/extensions of grpc that we will not use for services tunnelbroker and backup.
Test Plan: build back and tunnelbroker services.
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, geekbrother, ashoat
Subscribers: geekbrother, ashoat, paly... |
129,179 | 01.11.2021 16:31:59 | 14,400 | 33dc6cd99916c8c3630a8f5039556d5a26886dda | [native][feature] add default notifications screen navigation + screen
Summary: Add navigation and basic (non-functional) notifs screen to profile
Test Plan: Go to profile, click default nofiticatons
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/route-names.js",
"new_path": "native/navigation/route-names.js",
"diff": "@@ -39,6 +39,7 @@ export const ColorPickerModalRouteName = 'ColorPickerModal';\nexport const ComposeSubthreadModalRouteName = 'ComposeSubthreadModal';\nexport const Com... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][feature] add default notifications screen navigation + screen
Summary: Add navigation and basic (non-functional) notifs screen to profile https://share.getcloudapp.com/v1ujNRRR https://linear.app/comm/issue/COM-20/default-notification-settings
Test Plan: Go to profile, click default nofiticatons
Reviewers: ... |
129,179 | 02.11.2021 12:08:25 | 14,400 | b0bd8a8fd639df2fbde4828c15e2c19ab3c34fcd | [native][refactor] use action row in default notification screen, remove styles
Summary: Remove repeated code, replaced with action rows
Test Plan: Click into default notifications, make sure rows are still rendering correctly
Reviewers: ashoat, atul
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/profile/default-notifications-preferences.react.js",
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "import * as React from 'react';\nimport { View, Text, ScrollView, Platform } from 'react-native';\n+import Action from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][refactor] use action row in default notification screen, remove styles
Summary: Remove repeated code, replaced with action rows https://share.getcloudapp.com/BluDYP2n
Test Plan: Click into default notifications, make sure rows are still rendering correctly
Reviewers: ashoat, atul
Reviewed By: ashoat
Subsc... |
129,187 | 04.11.2021 22:27:30 | 14,400 | 973ccc76334ea4fb2ecbc471e2138f13fc79ff7a | [lib] Update staff.json
Summary: Usernames:
Test Plan: N/A
Reviewers: atul, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/staff.json",
"new_path": "lib/facts/staff.json",
"diff": "-[\"256\", \"518252\", \"379341\", \"546465\", \"701071\", \"1073697\", \"1081630\", \"1074037\"]\n+[\n+ \"256\",\n+ \"518252\",\n+ \"379341\",\n+ \"546465\",\n+ \"701071\",\n+ \"1081630\",\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Update staff.json
Summary: Usernames: https://www.dropbox.com/s/y0l7977pvagl8hf/Screen%20Shot%202021-11-04%20at%2010.27.47%20PM.png?dl=0
Test Plan: N/A
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phab... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.