author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,184 | 04.11.2021 15:10:49 | 14,400 | f16dbb30cadd3332c81cb870a8f05b4c3a46293d | [CI] Add `googleapis` dependency to `native`
Summary: Add `googleapis` dependency so we can access `androidpublisherv3` endpoint from `upload-aab.js` script.
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"flow-mono-cli\": \"^1.5.0\",\n\"flow-typed\": \"^3.2.1\",\n\"fs-extra\": \"^8.1.0\",\n+ \"googleapis\": \"^89.0.0\",\n\"jest\": \"^26.6.3\",\n\"jetifier\": \"^1.6.4\",\n\"metro-react-native-ba... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Add `googleapis` dependency to `native`
Summary: Add `googleapis` dependency so we can access `androidpublisherv3` endpoint from `upload-aab.js` script.
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision:... |
129,179 | 05.11.2021 14:14:46 | 14,400 | fc9a99ccf555fd1ecb6ff72f73fc37b68bd5227a | [lib][refactor] sort ascending user action exports
Summary: sort exports asc
Test Plan: login and out of the application to confirm actions are still behaving as expected
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -220,27 +220,27 @@ const getUserPublicKeys = (\nawait fetchJSON('get_user_public_keys', data);\nexport {\n- logOutActionTypes,\n- logOut,\n- deleteAccountActionTypes,\n- delet... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib][refactor] sort ascending user action exports
Summary: sort exports asc
Test Plan: login and out of the application to confirm actions are still behaving as expected
Reviewers: atul, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: h... |
129,184 | 05.11.2021 13:16:52 | 14,400 | 13d6aa40368be7d78b0349286556d349a60e69fd | [CI] Get rid of iOS CI `pod install` step
Summary: This step is redundant and covered by `yarn cleaninstall`.
Test Plan:
Successfully built/archived/exported w/o `pod install` step:
{F5398}
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/ios.yml",
"new_path": ".github/workflows/ios.yml",
"diff": "@@ -58,10 +58,6 @@ jobs:\nAUTH_KEY: ${{secrets.AUTH_KEY}}\nrun: echo \"$AUTH_KEY\" > AUTH_KEY.p8\n- - name: Pod install\n- working-directory: ./native/ios\n- run: pod install\n-\n- n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Get rid of iOS CI `pod install` step
Summary: This step is redundant and covered by `yarn cleaninstall`.
Test Plan:
Successfully built/archived/exported w/o `pod install` step:
{F5398}
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Dif... |
129,191 | 02.11.2021 18:11:20 | -3,600 | da1a9b7f3dea9036af58d636dcd8dd17d83cf218 | [CommCoreModule] Introduce GlobalNetworkSingleton
Summary: Create a global object that can be used to interact with network module. This object is hiding all the threading related logic.
Test Plan: Tested with the next diffs.
Reviewers: karol-bisztyga, ashoat
Subscribers: def-au1t, Adrian, atul, benschac, boristopalov
... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/GlobalNetworkSingleton.cpp",
"diff": "+#include \"GlobalNetworkSingleton.h\"\n+\n+namespace comm {\n+GlobalNetworkSingleton GlobalNetworkSingleton::instance;\n+\n+NetworkModule &GlobalNetworkSin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce GlobalNetworkSingleton
Summary: Create a global object that can be used to interact with network module. This object is hiding all the threading related logic.
Test Plan: Tested with the next diffs.
Reviewers: karol-bisztyga, ashoat
Reviewed By: ashoat
Subscribers: def-au1t, Adrian, atul... |
129,191 | 02.11.2021 18:19:38 | -3,600 | 2e33b1b64404b1923b5c8920b03acb849ced5c1e | [CommCoreModule] Use network singleton in CommCoreModule
Summary: Modify functions to use network module via the singleton.
Test Plan: We're not calling this function currently, so nothing should change.
Reviewers: ashoat, karol-bisztyga
Subscribers: Adrian, atul, benschac, boristopalov
Tags: #background-notifications | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "#include \"CommCoreModule.h\"\n#include \"DatabaseManager.h\"\n+#include \"InternalModules/GlobalNetworkSingleton.h\"\n+#inclu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Use network singleton in CommCoreModule
Summary: Modify functions to use network module via the singleton.
Test Plan: We're not calling this function currently, so nothing should change.
Reviewers: ashoat, karol-bisztyga
Reviewed By: ashoat
Subscribers: Adrian, atul, benschac, boristopalov
Tags: ... |
129,184 | 08.11.2021 14:02:21 | 18,000 | 7c08466c6cf0772bed944c8830b3d0bf22d099bf | [native] `codeVersion` -> 112 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 112 |
129,184 | 08.11.2021 17:52:31 | 18,000 | 4ebaa65307008aa82b36041102e85bbe7ae2f2f6 | [native] `codeVersion` -> 113 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 113 |
129,190 | 09.11.2021 16:17:57 | -3,600 | 4ff0571ab3d3fddbbc4da5b87d782abeda68a732 | [services] Avoid boilerplate
Summary: In response to I made scripts spawning docker images parameterized.
Test Plan: Run all scripts from `services/package.json`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-base/config.sh",
"diff": "+#/bin/bash\n+\n+set -e\n+\n+IMAGE_NAME=\"commapp/backup-base\"\n+VERSION=\"1.0\"\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/config.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Avoid boilerplate
Summary: In response to https://linear.app/comm/issue/COM-29/avoid-dry-in-services, I made scripts spawning docker images parameterized.
Test Plan: Run all scripts from `services/package.json`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat,... |
129,184 | 10.11.2021 13:09:36 | 18,000 | 4867283d3baf7b1f3fa8b5f12752be5ea7eb753b | [native] `codeVersion` -> 114 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 114 |
129,184 | 10.11.2021 13:13:26 | 18,000 | ca30b49038f440b42687fa4ce47a408ed780af5b | [native] `codeVersion` -> 115 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 115 |
129,179 | 10.11.2021 15:32:29 | 18,000 | 0f34fe43ed01600a7207a3f5b31fb96b9dc1fe57 | [lib] [refactor] CHANGE_USER_SETTINGS --> CHANGE_USER_PASSWORD
Summary: CHANGE_USER_SETTING and USER_SETTINGS are a bit redundant so I renamed CHANGE_USER_SETTING to CHANGE_USER_PASSWORD
Test Plan: go though the user password change flow to confirm functionality isn't broken
Reviewers: atul, ashoat, palys-swm
Subscribe... | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -155,9 +155,9 @@ const logIn = (\n};\nconst changeUserSettingsActionTypes = Object.freeze({\n- started: 'CHANGE_USER_SETTINGS_STARTED',\n- success: 'CHANGE_USER_SETTINGS_SUCCE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] [refactor] CHANGE_USER_SETTINGS --> CHANGE_USER_PASSWORD
Summary: CHANGE_USER_SETTING and USER_SETTINGS are a bit redundant so I renamed CHANGE_USER_SETTING to CHANGE_USER_PASSWORD
Test Plan: go though the user password change flow to confirm functionality isn't broken
Reviewers: atul, ashoat, palys-swm
Revie... |
129,179 | 11.11.2021 14:30:19 | 18,000 | 1acbe8c1da4235f62dc2b8f8334742d5a355c745 | refactor add brackets to function
Summary: small code style change. Every other function had {} braces.
Test Plan: N/A make sure nothing is broken
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -216,8 +216,9 @@ const getUserPublicKeys = (\nfetchJSON: FetchJSON,\n): ((\ndata: GetUserPublicKeysArgs,\n-) => Promise<UserPublicKeys | null>) => async data =>\n- await fetch... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | refactor add brackets to function
Summary: small code style change. Every other function had {} braces.
Test Plan: N/A make sure nothing is broken
Reviewers: atul, palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.... |
129,184 | 11.11.2021 17:13:15 | 18,000 | ae9d23ef4b0185eb0bdf4ddc84755c38986cc8b1 | [lib] Add `PRIVATE` to `threadTypeCanBePending`
Summary: Fixes crash when creating a new thread from "New Message" screen
Test Plan: tbd
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -432,6 +432,15 @@ function pendingThreadType(numberOfOtherMembers: number): 4 | 6 | 7 {\n}\n}\n+function threadTypeCanBePending(threadType: ThreadType): boolean {\n+ return (\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add `PRIVATE` to `threadTypeCanBePending`
Summary: Fixes crash when creating a new thread from "New Message" screen
Test Plan: tbd
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D23... |
129,184 | 11.11.2021 17:42:16 | 18,000 | 5fc5edad781135a37efd30a09de8bc715ee60a26 | [native] `codeVersion` -> 117 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 117 |
129,184 | 11.11.2021 17:47:55 | 18,000 | ecd16fc4874e7714edae717629796b839b895d1d | [native] `codeVersion` -> 118 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 118 |
129,184 | 11.11.2021 18:12:30 | 18,000 | f3b70b37059b1c26076e15ff9e399c334bafa9c9 | [native] `codeVersion` -> 119 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 119 |
129,179 | 10.11.2021 10:25:32 | 18,000 | cfdeb1a0b188ea92e4b8818c13cc34a188299829 | [lib] [1/n] add UserSettingsRequest action
Summary: Add User Setting action for user default notification settings
Test Plan: N/A just a small piece of the redux life cycle
Reviewers: atul, ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -8,6 +8,7 @@ import type {\nRegisterResult,\nRegisterInfo,\nAccessRequest,\n+ UpdateUserSettingsRequest,\n} from '../types/account-types';\nimport type { GetUserPublicKeysArgs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] [1/n] add UserSettingsRequest action
Summary: Add User Setting action for user default notification settings
Test Plan: N/A just a small piece of the redux life cycle
Reviewers: atul, ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: ht... |
129,179 | 08.11.2021 07:40:29 | 18,000 | 7dd157e8993afd3f00bc58622d5b460c8f4d22c8 | [native] [2/n] add pref boilerplate for redux
Summary: Add boilerplate, more or less copy-pasta'ed from relationship-list.react.js
Test Plan: default notifications should still render, no new functionality yet, just breaking up diffs.
Reviewers: atul, palys-swm, ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/profile/default-notifications-preferences.react.js",
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "@@ -5,7 +5,9 @@ import { View, Text, ScrollView, Platform } from 'react-native';\nimport Action from '../components/ac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [2/n] add pref boilerplate for redux
Summary: Add boilerplate, more or less copy-pasta'ed from relationship-list.react.js
Test Plan: default notifications should still render, no new functionality yet, just breaking up diffs.
Reviewers: atul, palys-swm, ashoat
Reviewed By: ashoat
Subscribers: Adrian, karo... |
129,179 | 10.11.2021 12:06:30 | 18,000 | 355fa295da4d81c60c2d7075710562fe1fb49f3a | [lib] [4/n] add action types to base types
Summary: add USER_SETTINGS to base actions
Test Plan: N/A just adding types
Reviewers: atul, ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -764,6 +764,22 @@ export type BaseAction =\n| {\n+type: 'SET_THREAD_STORE',\n+payload: ThreadStore,\n+ }\n+ | {\n+ +type: 'SET_USER_SETTINGS_STARTED',\n+ +payload?: void,\n+ +loadin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] [4/n] add action types to base types
Summary: add USER_SETTINGS to base actions
Test Plan: N/A just adding types
Reviewers: atul, ashoat, palys-swm
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2342 |
129,184 | 12.11.2021 10:13:50 | 18,000 | 737d451b1fa6ed95ece61a9ae8903e2dd0043678 | [native] Add `jsonwebtoken` and `gaxios` to `package.json`
Summary:
So we can hit App Store Connect API endpoints:
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"flow-typed\": \"^3.2.1\",\n\"fs-extra\": \"^8.1.0\",\n\"googleapis\": \"^89.0.0\",\n+ \"gaxios\": \"^4.3.2\",\n+ \"jsonwebtoken\": \"^8.5.1\",\n\"jest\": \"^26.6.3\",\n\"jetifier\": \"^1.6.4\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add `jsonwebtoken` and `gaxios` to `package.json`
Summary:
So we can hit App Store Connect API endpoints:
https://developer.apple.com/documentation/appstoreconnectapi/generating_tokens_for_api_requests
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bis... |
129,190 | 15.11.2021 09:39:48 | -3,600 | 8cf304bee06686d3c50db10919586529686712ad | [services] Add oneof data to PullCompactionResponse
Summary: to make it consistent with `ResetKeyRequest`
Test Plan: backup service should run as usual
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/_generated/backup.pb.cc",
"new_path": "native/cpp/CommonCpp/grpc/_generated/backup.pb.cc",
"diff": "@@ -108,8 +108,7 @@ struct PullCompactionRequestDefaultTypeInternal {\nPROTOBUF_ATTRIBUTE_NO_DESTROY PROTOBUF_CONSTINIT PullCompaction... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Add oneof data to PullCompactionResponse
Summary: to make it consistent with `ResetKeyRequest`
Test Plan: backup service should run as usual
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement... |
129,184 | 15.11.2021 09:20:10 | 18,000 | 88d804813660d44a83a81b46a113ffe035c51008 | [CI] Introduce `assign-build:getAuthToken`
Summary: Generates auth token for use with App Store Connect API:
Test Plan: Was able to successfully make API calls
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/ios/assign-build.js",
"diff": "+// @flow\n+\n+const fs = require('fs');\n+const jwt = require('jsonwebtoken');\n+\n+const getAuthToken = () => {\n+ const p8 = fs.readFileSync('./AUTH_KEY.p8');\n+ const apiKeyID = process.env.AUTH_KEY_ID;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getAuthToken`
Summary: Generates auth token for use with App Store Connect API: https://developer.apple.com/documentation/appstoreconnectapi/generating_tokens_for_api_requests
Test Plan: Was able to successfully make API calls
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscriber... |
129,184 | 15.11.2021 09:36:32 | 18,000 | 04954b82acb6f9bd00723c3007b5ce94d16a97eb | [CI] Introduce `assign-build:getPreReleaseVersions`
Summary: Endpoint:
Test Plan: Got expected result
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "// @flow\nconst fs = require('fs');\n+const { request } = require('gaxios');\nconst jwt = require('jsonwebtoken');\n+const IOS_APP_ID = process.env.IOS_APP_ID;\n+\nconst getAuthTok... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getPreReleaseVersions`
Summary: Endpoint: https://developer.apple.com/documentation/appstoreconnectapi/list_prerelease_versions
Test Plan: Got expected result
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differ... |
129,184 | 15.11.2021 09:54:15 | 18,000 | eb54d5ca906c6649306c688d7a77ef266c7dbc9f | [CI] Introduce `assign-build:getCurrentVersionInfo`
Summary: Get information about the current version (based on git tag)
Test Plan: Got expected result.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -5,6 +5,8 @@ const { request } = require('gaxios');\nconst jwt = require('jsonwebtoken');\nconst IOS_APP_ID = process.env.IOS_APP_ID;\n+const GIT_REF = process.env.GITHUB_REF ??... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getCurrentVersionInfo`
Summary: Get information about the current version (based on git tag)
Test Plan: Got expected result.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricat... |
129,184 | 15.11.2021 11:30:20 | 18,000 | f3242ad6d4f7870f77e89d171736fd12693d69b4 | [CI] Introduce `assign-build:getCurrentVersionID`
Summary: Extract versionID from versionInfo if it exists.
Test Plan: Got versionID as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -71,11 +71,21 @@ const getCurrentVersionInfo = (preReleaseVersions, currentVersion) => {\n)[0];\n};\n+const getCurrentVersionID = (currentVersionInfo) => {\n+ if (!currentVersio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getCurrentVersionID`
Summary: Extract versionID from versionInfo if it exists.
Test Plan: Got versionID as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat... |
129,184 | 15.11.2021 11:40:57 | 18,000 | a121836b1074ab20ad19933a32fcf61f5fa5c6e8 | [CI] Introduce `assign-build:getBuildInfoForVersionID`
Summary: Given valid versionID, get build information.
Test Plan: Got build information as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -80,12 +80,35 @@ const getCurrentVersionID = (currentVersionInfo) => {\nreturn currentVersionInfo.id;\n};\n+const getBuildInfoForVersionID = async (authToken, versionID) => {\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getBuildInfoForVersionID`
Summary: Given valid versionID, get build information.
Test Plan: Got build information as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabrica... |
129,184 | 15.11.2021 11:56:26 | 18,000 | 6936e26f6f793585a0e146d54f175166efd589d5 | [CI] Introduce `assign-build:getBuildID`
Summary: Extracts buildID from buildInfo if it exists.
Test Plan: Got buildID as expected.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -102,13 +102,22 @@ const getBuildInfoForVersionID = async (authToken, versionID) => {\nreturn res.data.data[0];\n};\n+const getBuildID = (buildInfo) => {\n+ if (!buildInfo || !b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getBuildID`
Summary: Extracts buildID from buildInfo if it exists.
Test Plan: Got buildID as expected.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2371 |
129,184 | 15.11.2021 13:50:10 | 18,000 | 097e0b94089caff4850715c34e6335d846a548ef | [CI] Introduce `assign-build:assignBuildToStaffGroup`
Summary: Assigns build to staff staff testing group
Test Plan:
It worked for v1.0.119:
{F5525}
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -5,6 +5,7 @@ const { request } = require('gaxios');\nconst jwt = require('jsonwebtoken');\nconst IOS_APP_ID = process.env.IOS_APP_ID;\n+const IOS_STAFF_GROUP_ID = process.env.IO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:assignBuildToStaffGroup`
Summary: Assigns build to staff staff testing group
Test Plan:
It worked for v1.0.119:
{F5525}
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.as... |
129,179 | 12.11.2021 09:57:00 | 18,000 | 17ab9494405487c60aca11cc7056b15b687e215d | [1/n] change types CHANGE_USER_PASSWORD_SETTINGS --> CHANGE_USER_PASSWORD
Summary: start change references from changeSettings --> change password
Test Plan: test password change functionality on web and native
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -156,14 +156,16 @@ const logIn = (\n};\nconst changeUserSettingsActionTypes = Object.freeze({\n- started: 'CHANGE_USER_PASSWORD_SETTINGS_STARTED',\n- success: 'CHANGE_USER_PAS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] change types CHANGE_USER_PASSWORD_SETTINGS --> CHANGE_USER_PASSWORD
Summary: start change references from changeSettings --> change password
Test Plan: test password change functionality on web and native
Reviewers: atul, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga... |
129,179 | 15.11.2021 13:41:19 | 18,000 | 6cdc04b9ec7537092e82d3a8ebac9dfe4c2d931c | folllow up backend diff: refactor notification types
Summary: follow up diff from
Test Plan: make sure functionality still works and we're not getting any type errors
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "// @flow\n+import { values } from '../../lib/utils/objects';\nimport type { PlatformDetails, DeviceType } from './device-types';\nimport type {\nCalendarQuery,\n@@ -157,4 +158,14 @... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | folllow up backend diff: refactor notification types
Summary: follow up diff from https://phabricator.ashoat.com/D2276
Test Plan: make sure functionality still works and we're not getting any type errors
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristop... |
129,179 | 12.11.2021 10:06:27 | 18,000 | fdfe10ae51f38ac9ec3ac79a5c1c0da1a1ea0800 | [2/n] change account --> password types and some function names
Summary: continue changing references to Account --> Password
Test Plan: make sure change functionality functionality works in native and web
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -20,7 +20,7 @@ import type {\nimport type {\nUserPublicKeys,\nUserInfo,\n- AccountUpdate,\n+ PasswordUpdate,\n} from '../types/user-types';\nimport { getConfig } from '../util... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] change account --> password types and some function names
Summary: continue changing references to Account --> Password
Test Plan: make sure change functionality functionality works in native and web
Reviewers: atul, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, bor... |
129,179 | 12.11.2021 10:14:19 | 18,000 | d421a719b7ad104b64a5eb2323805772403fcc7a | [3/n] changeUserSettings --> changeUserPassword
Summary: continue changing references
Test Plan: same as above
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -155,12 +155,12 @@ const logIn = (\n};\n};\n-const changeUserSettingsActionTypes = Object.freeze({\n+const changeUserPasswordActionTypes = Object.freeze({\nstarted: 'CHANGE_US... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n] changeUserSettings --> changeUserPassword
Summary: continue changing references
Test Plan: same as above
Reviewers: atul, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2355 |
129,179 | 16.11.2021 11:56:12 | 18,000 | c2050295952d97afcb47730bdf80642454f793c8 | [4/n] [server] rename accountUpdater --> passwordUpdater, update legacy, prepend with old
Summary: update account to password, prepend old to legacy password updater
Test Plan: reset password, confirm functionality still works
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/endpoints.js",
"new_path": "server/src/endpoints.js",
"diff": "@@ -41,14 +41,14 @@ import {\n} from './responders/thread-responders';\nimport {\nuserSubscriptionUpdateResponder,\n- accountUpdateResponder,\n+ passwordUpdateResponder,\nsendVerificatio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [4/n] [server] rename accountUpdater --> passwordUpdater, update legacy, prepend with old
Summary: update account to password, prepend old to legacy password updater
Test Plan: reset password, confirm functionality still works
Reviewers: atul, palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, Adrian, karo... |
129,179 | 16.11.2021 13:49:19 | 18,000 | f035da0ca0d4b18a1a3a06c93a2945788f5c76e6 | [0/n] [native] add selection of default notif row
Summary: select prop. for default notif row
Test Plan: N/A do not review
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/profile/default-notifications-preferences.react.js",
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "@@ -38,14 +38,15 @@ type ProfileRowProps = {\n+content: string,\n+onPress: () => void,\n+danger?: boolean,\n+ +selecte... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [0/n] [native] add selection of default notif row
Summary: select prop. for default notif row
Test Plan: N/A do not review
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2382 |
129,184 | 16.11.2021 14:56:33 | 18,000 | e50b321d761afb783cf550fead82faf2cbfc25a1 | [lib] Add `rawMessageInfoFromClientDB` to `MessageSpec` type
Summary: For each message type, we'll implement a `rawMessageInfoFromClientDB` function to go from `ClientDBMessageInfo` -> `Raw[whatever]MessageInfo`
Test Plan: NA, just introduces type
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-biszt... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/message-spec.js",
"new_path": "lib/shared/messages/message-spec.js",
"diff": "@@ -4,6 +4,7 @@ import type { PlatformDetails } from '../../types/device-types';\nimport type { Media } from '../../types/media-types';\nimport type {\nMessageInf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add `rawMessageInfoFromClientDB` to `MessageSpec` type
Summary: For each message type, we'll implement a `rawMessageInfoFromClientDB` function to go from `ClientDBMessageInfo` -> `Raw[whatever]MessageInfo`
Test Plan: NA, just introduces type
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys... |
129,184 | 16.11.2021 15:30:29 | 18,000 | 855fa8d3a68c42ff822f284c9d4b8d097440b14d | [lib] Implement `rawMessageInfoFromClientDB` for `TEXT`
Summary: Pull `RawTextMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/text-message-spec.js",
"new_path": "lib/shared/messages/text-message-spec.js",
"diff": "@@ -4,7 +4,10 @@ import invariant from 'invariant';\nimport * as SimpleMarkdown from 'simple-markdown';\nimport { messageTypes } from '../../types/messa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `TEXT`
Summary: Pull `RawTextMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benscha... |
129,184 | 16.11.2021 15:45:06 | 18,000 | d93db45df94a6444c60107433cf416f8c93a9813 | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_THREAD`
Summary: Pull `RawCreateThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boris... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-thread-message-spec.js",
"new_path": "lib/shared/messages/create-thread-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_THREAD`
Summary: Pull `RawCreateThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-... |
129,184 | 16.11.2021 15:59:38 | 18,000 | 0253a067d2b456f6f2fba20db79ea02fdb08a201 | [lib] Implement `rawMessageInfoFromClientDB` for `ADD_MEMBERS`
Summary: Pull `RawAddMembersMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristop... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `ADD_MEMBERS`
Summary: Pull `RawAddMembersMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bis... |
129,184 | 16.11.2021 16:19:28 | 18,000 | a6cf92faaae7106222a2955107daf9997820b99b | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_SUB_THREAD`
Summary: Pull `RawCreateSubthreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sub-thread-message-spec.js",
"new_path": "lib/shared/messages/create-sub-thread-message-spec.js",
"diff": "@@ -4,7 +4,10 @@ import invariant from 'invariant';\nimport { permissionLookup } from '../../permissions/thread-permissions';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_SUB_THREAD`
Summary: Pull `RawCreateSubthreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian,... |
129,184 | 16.11.2021 16:39:57 | 18,000 | c72c8890ef25106ae65228382cc708376d9e524f | [lib] Implement `rawMessageInfoFromClientDB` for `CHANGE_SETTINGS`
Summary: Pull `RawChangeSettingsMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, b... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/change-settings-message-spec.js",
"new_path": "lib/shared/messages/change-settings-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CHANGE_SETTINGS`
Summary: Pull `RawChangeSettingsMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, ka... |
129,184 | 16.11.2021 16:47:25 | 18,000 | 2fd67790070d3f05e6d624ec4aa092ba0d91d151 | [lib] Implement `rawMessageInfoFromClientDB` for `REMOVE_MEMBERS`
Summary: Pull `RawRemoveMembersMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, bor... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/remove-members-message-spec.js",
"new_path": "lib/shared/messages/remove-members-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '..... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `REMOVE_MEMBERS`
Summary: Pull `RawRemoveMembersMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karo... |
129,184 | 16.11.2021 17:01:07 | 18,000 | c6be290f3f813c0c191c466fd072ce529ca249d8 | [lib] Implement `rawMessageInfoFromClientDB` for `CHANGE_ROLE`
Summary: Pull `RawChangeRoleMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopa... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/change-role-message-spec.js",
"new_path": "lib/shared/messages/change-role-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CHANGE_ROLE`
Summary: Pull `RawChangeRoleMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisz... |
129,184 | 16.11.2021 17:09:51 | 18,000 | d735bd12840c8236eb17298f63a3382ae8daac9d | [lib] Implement `rawMessageInfoFromClientDB` for `LEAVE_THREAD`
Summary: Pull `RawLeaveThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristo... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/leave-thread-message-spec.js",
"new_path": "lib/shared/messages/leave-thread-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `LEAVE_THREAD`
Summary: Pull `RawLeaveThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bi... |
129,184 | 16.11.2021 17:15:04 | 18,000 | 7a9c2174ded17f34987abc26e1b979e63cea444b | [lib] Implement `rawMessageInfoFromClientDB` for `JOIN_THREAD`
Summary: Pull `RawJoinThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopa... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/join-thread-message-spec.js",
"new_path": "lib/shared/messages/join-thread-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `JOIN_THREAD`
Summary: Pull `RawJoinThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisz... |
129,184 | 16.11.2021 17:20:37 | 18,000 | a8b52aace198f4249425119df68dcf1e32e24c3b | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_ENTRY`
Summary: Pull `RawJoinThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristop... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-entry-message-spec.js",
"new_path": "lib/shared/messages/create-entry-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_ENTRY`
Summary: Pull `RawJoinThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bis... |
129,184 | 16.11.2021 17:43:10 | 18,000 | 29f46bb0251159298307b8135ec50315211d52b9 | [lib] Implement `rawMessageInfoFromClientDB` for `EDIT_ENTRY`
Summary: Pull `RawEditEntryMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalo... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/edit-entry-message-spec.js",
"new_path": "lib/shared/messages/edit-entry-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `EDIT_ENTRY`
Summary: Pull `RawEditEntryMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-biszty... |
129,184 | 16.11.2021 17:46:14 | 18,000 | c4191b1620c67f265b24c4eb4b49ffbbf7ffa34a | [lib] Implement `rawMessageInfoFromClientDB` for `DELETE_ENTRY`
Summary: Pull `RawDeleteEntryMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopa... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/delete-entry-message-spec.js",
"new_path": "lib/shared/messages/delete-entry-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `DELETE_ENTRY`
Summary: Pull `RawDeleteEntryMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisz... |
129,184 | 16.11.2021 17:57:22 | 18,000 | 7130bf1f6f0b8faf8cfc36896559835a24a56f91 | [lib] Implement `rawMessageInfoFromClientDB` for `RESTORE_ENTRY`
Summary: Pull `RawRestoreEntryMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristo... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/restore-entry-message-spec.js",
"new_path": "lib/shared/messages/restore-entry-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `RESTORE_ENTRY`
Summary: Pull `RawRestoreEntryMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bi... |
129,184 | 16.11.2021 13:35:07 | 18,000 | 74535438f561576e3317ccfd86c42faf1ddb33e6 | [lib] Introduce `translateClientDBMediaInfoToMedia`
Summary:
Takes the `ClientDBMediaInfo` from the C++ side, and gives us a `Media` object.
We aren't considering video messages for now, but maybe we should be.
Test Plan: Seems to work:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, bensch... | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/message-ops-utils.js",
"new_path": "lib/utils/message-ops-utils.js",
"diff": "@@ -22,6 +22,24 @@ function translateMediaToClientDBMediaInfo(media: Media): ClientDBMediaInfo {\n};\n}\n+function translateClientDBMediaInfoToMedia(\n+ clientDBMediaInfo: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `translateClientDBMediaInfoToMedia`
Summary:
Takes the `ClientDBMediaInfo` from the C++ side, and gives us a `Media` object.
We aren't considering video messages for now, but maybe we should be.
Test Plan: Seems to work: https://blob.sh/atul/952f.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
... |
129,184 | 17.11.2021 13:00:03 | 18,000 | 100ef746be9cfdbb754c1a7d5161c9670672ec4e | [lib] Implement `rawMessageInfoFromClientDB` for `UPDATE_RELATIONSHIP`
Summary: Pull `RawUpdateRelationshipMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, bensc... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/update-relationship-message-spec.js",
"new_path": "lib/shared/messages/update-relationship-message-spec.js",
"diff": "@@ -4,7 +4,10 @@ import invariant from 'invariant';\nimport type { PlatformDetails } from '../../types/device-types';\nimp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `UPDATE_RELATIONSHIP`
Summary: Pull `RawUpdateRelationshipMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adri... |
129,184 | 17.11.2021 14:33:52 | 18,000 | 2de2415ccdd8c99e6a612dad534ab02b69f87318 | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_SIDEBAR`
Summary: Pull `RawCreateSidebarMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boris... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sidebar-message-spec.js",
"new_path": "lib/shared/messages/create-sidebar-message-spec.js",
"diff": "@@ -4,7 +4,10 @@ import invariant from 'invariant';\nimport type { PlatformDetails } from '../../types/device-types';\nimport { mess... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_SIDEBAR`
Summary: Pull `RawCreateSidebarMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-... |
129,190 | 19.11.2021 10:20:53 | -3,600 | 79f7b36e38d53b1fa014fa38c63d20cdb3cbafc0 | [1/n] [services] Add tools for the storage manager
Summary: Add tools to storage manager introduced in D2334
Test Plan: -
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/contents/server/src/Tools.h",
"diff": "+#include <exception>\n+\n+namespace comm {\n+namespace network {\n+\n+// 4MB limit\n+const size_t GRPC_CHUNK_SIZE_LIMIT = 4 * 1024 * 1024;\n+\n+// 5MB limit\n+const size_t AWS_MULTIPART_UPL... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] [services] Add tools for the storage manager
Summary: Add tools to storage manager introduced in D2334
Test Plan: -
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services
Differential Revisi... |
129,184 | 21.11.2021 16:36:35 | 18,000 | dd3e989a597cdf877ee72ea1c602df5df85be5ed | [native] `codeVersion` -> 120 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 120 |
129,190 | 22.11.2021 15:49:17 | -3,600 | abeefac291ca3a4871f8d191ff16fc8615cbe632 | [native] Fix build after proto refactor
Summary: In reponse to
Test Plan: build iOS/android
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"new_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"diff": "@@ -51,7 +51,7 @@ bool Client::becomeNewPrimaryDevice() {\nvoid Client::sendPong() {\ngrpc::ClientContext context;\ntunnelbroker::PongRequest request;\n- tunnel... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix build after proto refactor
Summary: In reponse to https://linear.app/comm/issue/ENG-207/fix-native-after-refactoring-proto-files
Test Plan: build iOS/android
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential R... |
129,184 | 22.11.2021 15:07:25 | 18,000 | bd1bcb9eb50a387f81f567d24f07ee4ab8375526 | [lib] Increase `create_account` timeout to 60s
Summary: Increase timeout since account creation can take a while.
Test Plan: NA
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -70,15 +70,20 @@ const registerActionTypes = Object.freeze({\nsuccess: 'REGISTER_SUCCESS',\nfailed: 'REGISTER_FAILED',\n});\n+const registerFetchJSONOptions = { timeout: 60000... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Increase `create_account` timeout to 60s
Summary: Increase timeout since account creation can take a while.
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2426 |
129,187 | 22.11.2021 19:58:21 | 18,000 | e49a887ed6acd0750162b17f3850d45d952de6ec | [native] Render PushHandler even if SplashScreen fails to hide
Summary: This should solve the notif badging issue once and for all!
Test Plan: This is based on our staff-only build 120
Reviewers: atul
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -186,8 +186,9 @@ function AppNavigator(props: AppNavigatorProps): React.Node {\nawait waitForInteractions();\ntry {\nawait SplashScreen.hideAsync();\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Render PushHandler even if SplashScreen fails to hide
Summary: This should solve the notif badging issue once and for all!
Test Plan: This is based on our staff-only build 120
Reviewers: atul
Reviewed By: atul
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: h... |
129,187 | 22.11.2021 23:36:07 | 18,000 | f9a1399e10593270df677f11aee8aa72f2f9f7f8 | Remove .vscode directory
Summary: It's being `.gitignore`'d, so we should exclude it from the repository.
Test Plan: N/A
Reviewers: atul, benschac, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "DELETE",
"old_path": ".vscode/launch.json",
"new_path": null,
"diff": "-{\n- \"configurations\": [\n- {\n- \"name\": \"Debug iOS Hermes\",\n- \"cwd\": \"${workspaceFolder}/native\",\n- \"type\": \"reactnativedirect\",\n- \"request\": \"attach\",\n- \"platform\": \"ios\",\n- \"trace... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove .vscode directory
Summary: It's being `.gitignore`'d, so we should exclude it from the repository.
Test Plan: N/A
Reviewers: atul, benschac, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2431 |
129,179 | 23.11.2021 14:49:12 | 18,000 | 522763355c3a34198ea47b5e45135ba221980c18 | [lib] fix: bad path
Summary: clean up import from:
Test Plan: make sure code still works by going to default notifs screen.
Reviewers: atul, ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "// @flow\n-import { values } from '../../lib/utils/objects';\n+import { values } from '../utils/objects';\nimport type { PlatformDetails, DeviceType } from './device-types';\nimpor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] fix: bad path
Summary: clean up import from: https://phabricator.ashoat.com/D2372
Test Plan: make sure code still works by going to default notifs screen.
Reviewers: atul, ashoat, palys-swm
Reviewed By: atul, ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator... |
129,184 | 23.11.2021 15:42:45 | 18,000 | 42b8d1e958558b3a2f4fea2ede48d82f0d646404 | [native] `codeVersion` -> 121 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 121 |
129,184 | 23.11.2021 15:47:21 | 18,000 | 8fd27eb9a42276ef48f7197bfd17c0584f8115a3 | [native] `codeVersion` -> 122 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 122 |
129,184 | 24.11.2021 14:54:23 | 18,000 | 6a24846120914118be9b8149138c90b8dfaee0a4 | [lib] Implement `messageContentForClientDB` for `SIDEBAR_SOURCE`
Summary: Serialize the entire `sourceMessage` so it can be reconstructed by `rawMessageInfoFromClientDBRow`
Test Plan: Will test with implementation of `SIDEBAR_SOURCE:rawMessageInfoFromClientDB`
Reviewers: ashoat
Subscribers: def-au1t, palys-swm, Adrian,... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/sidebar-source-message-spec.js",
"new_path": "lib/shared/messages/sidebar-source-message-spec.js",
"diff": "@@ -39,7 +39,11 @@ export const sidebarSourceMessageSpec: MessageSpec<\n},\nmessageContentForClientDB(data: RawSidebarSourceMessageI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `messageContentForClientDB` for `SIDEBAR_SOURCE`
Summary: Serialize the entire `sourceMessage` so it can be reconstructed by `rawMessageInfoFromClientDBRow`
Test Plan: Will test with implementation of `SIDEBAR_SOURCE:rawMessageInfoFromClientDB`
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: def... |
129,184 | 29.11.2021 23:45:31 | 28,800 | 92a0c7bf5903727091f23aea4f019d0037927676 | [native] `codeVersion` -> 123 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 123 |
129,184 | 29.11.2021 23:53:55 | 28,800 | 1752b228e0f112a544da401b76782a885fd6beb5 | [native] `codeVersion` -> 124 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 124 |
129,184 | 29.11.2021 14:48:55 | 28,800 | 316ebb30c03585172059b526bc049729320234fc | [CI] Run `[lib] yarn jest` on each push
Summary: Yeah ik CI stuff on pause, but this took like 10 seconds
Test Plan: Ran successfully on fork:
Reviewers: ashoat, benschac, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "RENAME",
"old_path": ".github/workflows/eslint_flow.yml",
"new_path": ".github/workflows/eslint_flow_jest.yml",
"diff": "-name: ESLint & Flow\n+name: ESLint & Flow & Jest\non:\npush:\n@@ -45,3 +45,7 @@ jobs:\n- name: '[native] flow'\nworking-directory: ./native\nrun: ./node_modules... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Run `[lib] yarn jest` on each push
Summary: Yeah ik CI stuff on pause, but this took like 10 seconds
Test Plan: Ran successfully on fork: https://blob.sh/atul/2f70.png
Reviewers: ashoat, benschac, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision... |
129,184 | 02.12.2021 16:51:58 | 28,800 | 2c194f207fcfe817673962e76cdeae8b0c427996 | [native] `codeVersion` -> 125 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 125 |
129,179 | 03.12.2021 13:37:02 | 18,000 | 5bd2821d51e376b912bc13152e523bb8a1002e87 | [1/n] remove active_card styling functionality on scroll
Summary: scroll page, active card should not light up anymore
Test Plan: scroll page, active card should not light up anymore
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\n-import { Waypoint } from 'react-waypoint';\nimport css from './landing.css';\nt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] remove active_card styling functionality on scroll
Summary: scroll page, active card should not light up anymore
Test Plan: scroll page, active card should not light up anymore
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential... |
129,179 | 03.12.2021 13:42:34 | 18,000 | 28dcc90a69f90d4a3099398022b090db63441ae2 | [2/n] [landing] change label to title in info block
Summary: label prop is changed to title prop
Test Plan: N/A code should run
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "@@ -6,19 +6,19 @@ import * as React from 'react';\nimport css from './landing.css';\ntype InfoCardProps = {\n- +label: string,\n+ +title: string,\n+icon: mixed,\n+description: stri... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] [landing] change label to title in info block
Summary: label prop is changed to title prop
Test Plan: N/A code should run
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2552 |
129,179 | 03.12.2021 13:45:40 | 18,000 | 86dfdfc1bfe3658bc3faa922cf14e6ed1ca1c1f9 | [3/n] [landing] remove font icon from info block
Summary: design no longer calls for icons in the info blocks
Test Plan: make sure the font icon isn't being rendered
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "// @flow\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport css from './landing.css';\ntype InfoCardProps = {\n+title: str... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n] [landing] remove font icon from info block
Summary: design no longer calls for icons in the info blocks
Test Plan: make sure the font icon isn't being rendered
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https:... |
129,179 | 03.12.2021 14:07:03 | 18,000 | df7f2a442de7e027b207bc31d361ce84ca2a4ca8 | [4/n] [landing] move meta data into asset file
Summary: Move asset data into its own file
Test Plan: Make sure site still renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/keyservers.react.js",
"new_path": "landing/keyservers.react.js",
"diff": "import { create } from '@lottiefiles/lottie-interactivity';\nimport * as React from 'react';\n+import { assetUrl } from './asset-meta-data';\nimport css from './landing.css';\nim... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [4/n] [landing] move meta data into asset file
Summary: Move asset data into its own file
Test Plan: Make sure site still renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2554 |
129,179 | 03.12.2021 14:25:28 | 18,000 | 79ba0c3c3d3c4510c9f2549f22650b63713d0d35 | [5/n] [landing] move preloadassets to hook
Summary: Move preload assets effect to a hook
Test Plan: look in developer console and see assets are being preloaded
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "import * as React from 'react';\n-import { assetUrl, assetMetaData } from './asset-meta-data';\n+import { assetMetaData } from './asset-meta-data';\nimport CyclingHeader from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [5/n] [landing] move preloadassets to hook
Summary: Move preload assets effect to a hook
Test Plan: look in developer console and see assets are being preloaded
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://pha... |
129,179 | 03.12.2021 14:38:07 | 18,000 | 76b773896dca7af1f585c0916a4016c42ff344a8 | [6/n] [landing] move picture into its own component
Summary: move picture to component
Test Plan: make sure picture is loading
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/Picture.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+type PictureProps = {\n+ +url: string,\n+ +alt: string,\n+};\n+\n+function Picture(props: PictureProps): React.Node {\n+ const { url, alt } = props;\n+ retur... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [6/n] [landing] move picture into its own component
Summary: move picture to component
Test Plan: make sure picture is loading
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2556 |
129,184 | 08.12.2021 16:47:31 | 18,000 | 21f6f0e03b59c5084d103a59ee945dcc89e807e8 | [native] Call C++ `processMessageStoreOperations` from redux-setup:reducer
Summary: Apply message store operations to the SQLite store.
Test Plan:
1. Set breakpoints and observed expected behavior
2. Checked the SQLite `messages` table and everything looked as expected
Reviewers: def-au1t, palys-swm, ashoat
Subscribers... | [
{
"change_type": "MODIFY",
"old_path": "native/redux/redux-setup.js",
"new_path": "native/redux/redux-setup.js",
"diff": "@@ -30,6 +30,7 @@ import {\nimport { updateTypes } from 'lib/types/update-types';\nimport { reduxLoggerMiddleware } from 'lib/utils/action-logger';\nimport { setNewSessionActionT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Call C++ `processMessageStoreOperations` from redux-setup:reducer
Summary: Apply message store operations to the SQLite store.
Test Plan:
1. Set breakpoints and observed expected behavior
2. Checked the SQLite `messages` table and everything looked as expected
Reviewers: def-au1t, palys-swm, ashoat
Reviewe... |
129,184 | 08.12.2021 22:18:25 | 18,000 | fd53c08608993a493da30dd846e84b087f62951a | [CommCoreModule] Implement `processMessageStoreOperationsSync`
Summary: To be used in the redux migration
Test Plan: Will be tested with subsequent diffs
Reviewers: def-au1t, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -326,6 +326,42 @@ jsi::Value CommCoreModule::processMessageStoreOperations(\n});\n}\n+bool CommCoreModule::processMessageSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Implement `processMessageStoreOperationsSync`
Summary: To be used in the redux migration
Test Plan: Will be tested with subsequent diffs
Reviewers: def-au1t, palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision:... |
129,184 | 08.12.2021 22:35:31 | 18,000 | 7ee4ae47a15165357a11725bd7120d180e232fe5 | [lib] Introduce `translateClientDBMessageInfosToRawMessageInfos`
Summary: Will be used to create `messageStore.messages` "in the correct shape" from an array of `clientDBMessageInfos`
Test Plan: Will be tested with subsequent diffs
Reviewers: palys-swm, def-au1t, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, bens... | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/message-ops-utils.js",
"new_path": "lib/utils/message-ops-utils.js",
"diff": "@@ -82,6 +82,17 @@ function translateClientDBMessageInfoToRawMessageInfo(\n].rawMessageInfoFromClientDB(clientDBMessageInfo);\n}\n+function translateClientDBMessageInfosToR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `translateClientDBMessageInfosToRawMessageInfos`
Summary: Will be used to create `messageStore.messages` "in the correct shape" from an array of `clientDBMessageInfos`
Test Plan: Will be tested with subsequent diffs
Reviewers: palys-swm, def-au1t, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ... |
129,184 | 09.12.2021 02:23:38 | 18,000 | 23cfcb478adee6684e498e88a915d7065aaccddf | [lib] Introduce `setMessageStoreMessages` redux action
Summary: To be dispatched from `sqlite-context-provider` in future diffs to restore `messageStore.messages` persisted in SQLite.
Test Plan: Will be tested with subsequent diffs.
Reviewers: palys-swm, def-au1t, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, ben... | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/message-actions.js",
"new_path": "lib/actions/message-actions.js",
"diff": "@@ -135,6 +135,7 @@ const sendMultimediaMessage = (\nconst saveMessagesActionType = 'SAVE_MESSAGES';\nconst processMessagesActionType = 'PROCESS_MESSAGES';\nconst messageSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `setMessageStoreMessages` redux action
Summary: To be dispatched from `sqlite-context-provider` in future diffs to restore `messageStore.messages` persisted in SQLite.
Test Plan: Will be tested with subsequent diffs.
Reviewers: palys-swm, def-au1t, ashoat
Reviewed By: palys-swm, ashoat
Subscribers:... |
129,184 | 09.12.2021 23:37:08 | 18,000 | fe44777bb087a7a624c860435907a36af54f63c9 | [lib] Fix `rawMessageInfoFromClientDB` to exclude `id` from local image messages
Summary: See D2601, but for image messages.
Test Plan: Our SQLite store and Redux store are no longer different
Reviewers: def-au1t, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/multimedia-message-spec.js",
"new_path": "lib/shared/messages/multimedia-message-spec.js",
"diff": "@@ -89,7 +89,6 @@ export const multimediaMessageSpec: MessageSpec<\n);\nconst rawImagesMessageInfo: RawImagesMessageInfo = {\ntype: messageT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix `rawMessageInfoFromClientDB` to exclude `id` from local image messages
Summary: See D2601, but for image messages.
Test Plan: Our SQLite store and Redux store are no longer different
Reviewers: def-au1t, palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benscha... |
129,190 | 14.12.2021 16:24:47 | -3,600 | e3d11ac0c7e94b6fa85761d69013176b3a75bc6d | [2/n][services] Tests - backup
Summary: the backup part for changes from D2574
Test Plan: See D2574
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/Dockerfile",
"new_path": "services/backup/docker-server/Dockerfile",
"diff": "FROM commapp/backup-base:1.0\n+ARG COMM_TEST_SERVICES\n+\nENV SHELL=/bin/bash\n+ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}\nCOPY services/backup/docke... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n][services] Tests - backup
Summary: the backup part for changes from D2574
Test Plan: See D2574
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2575 |
129,190 | 14.12.2021 16:24:51 | -3,600 | 12a2e02f81b1037788ca26b84a1673809e7c5257 | [3/n][services] Tests - tunnelbroker
Summary: the backup part for changes from D2574
Test Plan: See D2574
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/docker-server/Dockerfile",
"new_path": "services/tunnelbroker/docker-server/Dockerfile",
"diff": "FROM commapp/tunnelbroker-base:1.0\n+ARG COMM_TEST_SERVICES\n+\nENV SHELL=/bin/bash\n+ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}\nCOPY ser... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n][services] Tests - tunnelbroker
Summary: the backup part for changes from D2574
Test Plan: See D2574
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2576 |
129,179 | 14.12.2021 11:44:58 | 18,000 | 46ac8e7f39b23db322ee71a86b3097fbd92b1174 | [3/n] change default notifs from all, background, none --> Focused, Badge, Background
Summary:
change default notifs from all, background, none --> Focused, Badge, Background
{F5648}
Test Plan: go to default notifs, make sure they have the right content
Reviewers: atul, ashoat, palys-swm
Subscribers: Adrian, karol-bisz... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "@@ -163,9 +163,9 @@ export type DefaultNotificationPayload = {\n};\nexport const notificationTypes = Object.freeze({\n- ALL: 'all',\n+ FOCUSED: 'focused',\n+ BADGE_ONLY: 'badge_onl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n] change default notifs from all, background, none --> Focused, Badge, Background
Summary:
change default notifs from all, background, none --> Focused, Badge, Background
{F5648}
Test Plan: go to default notifs, make sure they have the right content
Reviewers: atul, ashoat, palys-swm
Reviewed By: ashoat
Subscr... |
129,179 | 06.12.2021 15:42:13 | 18,000 | 82361039b038f33cfd9a93a646b51b9394f90a2e | [10/n] [landing] move keyservers styles from landing to keyservers.css
Summary: move keyservers styles to it's own file from landing.css styles
Test Plan: Make sure keyservers styles still work as expected and didn't break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/keyservers.css",
"diff": "+div.body_grid {\n+ max-width: 1920px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ column-gap: 6em;\n+ padding-left: 60px;\n+ padding-right: 60px;\n+ padding-top: 20px;\n+ padding-bottom: 4... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [10/n] [landing] move keyservers styles from landing to keyservers.css
Summary: move keyservers styles to it's own file from landing.css styles
Test Plan: Make sure keyservers styles still work as expected and didn't break
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, ka... |
129,179 | 06.12.2021 15:57:25 | 18,000 | 557c28c3d43562259999798677ad5d0e38790ac5 | [11/n] [landing] move legal styles from landing to legal.css
Summary: Move all legal styles from landing.css to legal.css
Test Plan: Make sure legal styles are not broken on terms, support, privacy policy pages
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -218,31 +218,6 @@ div.tile_six {\ngrid-area: tile_six;\n}\n-/* ===== LEGAL PAGE STYLING ===== */\n-div.legal_container {\n- max-width: 1080px;\n- margin-left: auto;\n- margin-right: auto;\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [11/n] [landing] move legal styles from landing to legal.css
Summary: Move all legal styles from landing.css to legal.css
Test Plan: Make sure legal styles are not broken on terms, support, privacy policy pages
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga... |
129,179 | 06.12.2021 16:27:10 | 18,000 | c0bc1f98b19afc25920e3ce60623bbd63435dfa2 | [13/n] [landing] move info-card styles into info-card.css
Summary: move infocard styles from landing to info-card.css
Test Plan: make sure styles load and page isn't broken
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/info-card.css",
"diff": "+div.tile_title_row {\n+ display: flex;\n+ flex-direction: row;\n+ align-items: center;\n+ align-content: center;\n+ justify-content: flex-start;\n+ margin-left: 20px;\n+ margin-right: 20px;\n+ padding-bottom: 20... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [13/n] [landing] move info-card styles into info-card.css
Summary: move infocard styles from landing to info-card.css
Test Plan: make sure styles load and page isn't broken
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision:... |
129,179 | 06.12.2021 16:38:16 | 18,000 | a062da1aaefae8d7e1083e675bb6d3c3279e0e74 | [14/n] [landing] move cycling header css to cycling-header.css
Summary: move cycling header styles to cycling-header.css
Test Plan: make sure styles dont break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/cycling-header.css",
"diff": "+h1.cycling_header {\n+ font-family: 'iA Writer Duo S', monospace;\n+ font-size: 50px;\n+ margin: 0;\n+ white-space: pre-wrap;\n+}\n+\n+.app_landing_subheading {\n+ font-weight: bold;\n+ padding-inline: 4px;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [14/n] [landing] move cycling header css to cycling-header.css
Summary: move cycling header styles to cycling-header.css
Test Plan: make sure styles dont break
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phab... |
129,179 | 06.12.2021 18:10:37 | 18,000 | 5f56882611a9d1d15b58905eb457fbb6874167af | [15/n] [landing] remove dead code in landing
Summary: code was never used
Test Plan: N/A double check via grep
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "-.no_bottom_margin {\n- margin-bottom: 0;\n-}\n-\n.app_landing_subheading {\nfont-weight: bold;\npadding-inline: 4px;\n@@ -169,9 +165,4 @@ div.tile_six {\ndiv.tile_grid {\npadding-bottom: 4vh;\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [15/n] [landing] remove dead code in landing
Summary: code was never used
Test Plan: N/A double check via grep
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2568 |
129,179 | 06.12.2021 19:39:48 | 18,000 | a8a4c32d06099808c28f655fcefcc7032ac4e8f2 | [16/n] [landing] move hero sub header into cycling header
Summary: Move subheading content into cycling text component. Will turn it into a hero content component next diff
Test Plan: Make sure styles don't break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -32,11 +32,7 @@ function AppLanding(): React.Node {\n<div className={css.app_copy}>\n<div className={css.app_copy_wrapper}>\n<CyclingHeader />\n- <p className={css.app_landi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [16/n] [landing] move hero sub header into cycling header
Summary: Move subheading content into cycling text component. Will turn it into a hero content component next diff
Test Plan: Make sure styles don't break
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-... |
129,179 | 06.12.2021 20:27:54 | 18,000 | c9b4ddd33d058655c31beb31ff737709c3ed2030 | [18/n] [landing] remove old layout on landing app
Summary: remove html + css layout styles and structure
Test Plan: Layout should look broken and in non-functional state
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "import * as React from 'react';\nimport { assetMetaData } from './asset-meta-data';\n-import CyclingHeader from './cycling-header.react';\n+import HeroContent from './hero-cont... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [18/n] [landing] remove old layout on landing app
Summary: remove html + css layout styles and structure
Test Plan: Layout should look broken and in non-functional state
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: ht... |
129,179 | 07.12.2021 09:01:35 | 18,000 | 132f262b9be8fc7ced0bd277cca7f037fac1f885 | [20/n] [landing] add picture to infoblock component
Summary: Move picture into info-block component meet requirements on design
Test Plan: Make sure images are rendering.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -26,15 +26,12 @@ function AppLanding(): React.Node {\n<StarBackground />\n<Picture url={hero.url} alt={hero.alt} />\n<HeroContent />\n- <InfoCard title={federated.title} des... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [20/n] [landing] add picture to infoblock component
Summary: Move picture into info-block component meet requirements on design
Test Plan: Make sure images are rendering.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: h... |
129,179 | 07.12.2021 09:13:12 | 18,000 | 7eb04c13579f8a6fd917baae67e2a5307377b7e0 | [21/n] [landing] fix typo in asset file
Summary: Image URL is broken, remove typo
Test Plan: make sure image renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/asset-meta-data.js",
"new_path": "landing/asset-meta-data.js",
"diff": "@@ -18,7 +18,7 @@ export const assetMetaData = [\n},\n{\nalt: 'a web app screen highlighting web3 apps in Comm',\n- url: `${assetUrl}/'Customizable`,\n+ url: `${assetUrl}/Customiza... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [21/n] [landing] fix typo in asset file
Summary: Image URL is broken, remove typo
Test Plan: make sure image renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2578 |
129,179 | 07.12.2021 10:32:33 | 18,000 | ce3f9263cef2e310e040a2da9c8ae79281882e55 | [22/n] [landing] add css reset, apply spacing where broken
Summary: add reset with generic spacing where reset has stripped it.
Test Plan: Make sure header, footer keyserver and legal pages all look reasonable.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -16,6 +16,7 @@ nav.wrapper {\nmargin-left: auto;\nmargin-right: auto;\ndisplay: grid;\n+ padding: 16px 0;\nalign-items: center;\ngrid-template-columns: 40px repeat(12, 1fr) 40px;\ncolumn-gap: 1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [22/n] [landing] add css reset, apply spacing where broken
Summary: add reset with generic spacing where reset has stripped it.
Test Plan: Make sure header, footer keyserver and legal pages all look reasonable.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga... |
129,179 | 07.12.2021 10:45:11 | 18,000 | 99b7ad1f6105be702313ca4d3ac8f69fff7ee443 | [23/n] [landing] change name infocard --> infoblock
Summary: Info card should be a block per the design.
Test Plan: make sure code runs
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -4,7 +4,7 @@ import * as React from 'react';\nimport { assetMetaData } from './asset-meta-data';\nimport HeroContent from './hero-content.react';\n-import InfoCard from './i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [23/n] [landing] change name infocard --> infoblock
Summary: Info card should be a block per the design.
Test Plan: make sure code runs
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2580 |
129,179 | 07.12.2021 11:00:47 | 18,000 | 5201ef0c3728b0bc08c0e66a561789f8ca47433a | [24/n] [landing] make infoblock a section
Summary: should be a section
Test Plan: make sure page renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -15,13 +15,13 @@ function InfoBlock(props: InfoBlockProps): React.Node {\nconst { title, description, url, alt } = props;\nreturn (\n- <div className={css.info_block}>\n+ <sec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [24/n] [landing] make infoblock a section
Summary: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/section should be a section
Test Plan: make sure page renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: h... |
129,179 | 07.12.2021 11:35:26 | 18,000 | 541c32feee83044cc7afaea6946d3880fae1ff44 | [25/n] [landing] change content structure of info block
Summary: Make info block html less complex, rename css classes
Test Plan: make sure webpage renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.css",
"new_path": "landing/info-block.css",
"diff": "-div.tile_title_row {\n+div.content {\ndisplay: flex;\nflex-direction: row;\nalign-items: center;\n@@ -32,7 +32,7 @@ div.tile_title_row {\nmargin-right: 20px;\n}\n-div.tile_title_row > p.t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [25/n] [landing] change content structure of info block
Summary: Make info block html less complex, rename css classes
Test Plan: make sure webpage renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabrica... |
129,179 | 07.12.2021 12:20:44 | 18,000 | d8b7f08e2297b3ff2662c2a403c3e2e6d7b465da | [26/n] [landing] add css_class to asset meta
Summary: add css class to query info blocks from landing
Test Plan: make sure page renders, no type errors
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -10,6 +10,7 @@ type InfoBlockProps = {\n+description: string,\n+url: string,\n+alt: string,\n+ +css_class: string,\n};\nfunction InfoBlock(props: InfoBlockProps): React.Node {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [26/n] [landing] add css_class to asset meta
Summary: add css class to query info blocks from landing
Test Plan: make sure page renders, no type errors
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.... |
129,184 | 15.12.2021 15:27:13 | 18,000 | 4039a8147c4e32ef104edf195aeb162809e49a9f | [native] `codeVersion` -> 126 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 126 |
129,179 | 07.12.2021 12:46:30 | 18,000 | e83a3cb67c72da7bd2fbddd008ffe98b43939949 | [28/n] [landing] add css_class to info block to query with css grid
Summary: add css class name to query grid elements from landing
Test Plan: make sure page renders no flow errors
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -10,19 +10,22 @@ type InfoBlockProps = {\n+description: string,\n+url: string,\n+alt: string,\n- +css_class: string,\n+ +imageStyle: string,\n+ +infoStyle: string,\n};\nfuncti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [28/n] [landing] add css_class to info block to query with css grid
Summary: add css class name to query grid elements from landing
Test Plan: make sure page renders no flow errors
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential R... |
129,179 | 07.12.2021 17:56:59 | 18,000 | a3c7c6c52a2570b5dde48bb7e9137f54bf8eb720 | [29/n] [landing] add layout
Summary: add desktop grid layout
Test Plan: layout grid should match grid in figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -25,7 +25,9 @@ function AppLanding(): React.Node {\nreturn (\n<main className={css.wrapper}>\n<StarBackground />\n+ <div className={hero.imageStyle}>\n<Picture url={hero.url... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [29/n] [landing] add layout
Summary: add desktop grid layout
Test Plan: layout grid should match grid in figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2587 |
129,179 | 08.12.2021 12:08:28 | 18,000 | a383c185b4262ac6f0fb13438798587bd7ec48d7 | [30/n] [landing] add mobile layout for landing
Summary:
check mobile view at 1099px
{F5883}
Info blocks should still be incorrect.
Test Plan: check mobile view at 1099px should match design
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "'. lInfo lInfo lInfo lInfo lInfo lInfo . lImg lImg lImg lImg lImg .';\n}\n+@media screen and (max-width: 1099px) {\n+ .wrapper {\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [30/n] [landing] add mobile layout for landing
Summary:
check mobile view at 1099px
{F5883}
Info blocks should still be incorrect.
Test Plan: check mobile view at 1099px should match design
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Dif... |
129,179 | 08.12.2021 13:32:45 | 18,000 | 1498f13ace4d7cb2d77b458084832b9b71adc40c | [31/n] [landing] remove infoblock styling
Summary: remove styling, with fluid typography coming in additional diff it makes sense to remove styles now.
Test Plan: make sure page still renders.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.css",
"new_path": "landing/info-block.css",
"diff": "-div.content {\n- display: flex;\n- flex-direction: row;\n- align-items: center;\n- align-content: center;\n- justify-content: flex-start;\n- margin-left: 20px;\n- margin-right: 20px;\n- p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [31/n] [landing] remove infoblock styling
Summary: remove styling, with fluid typography coming in additional diff it makes sense to remove styles now.
Test Plan: make sure page still renders.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Di... |
129,179 | 08.12.2021 13:39:36 | 18,000 | c18c4ab9ae2f703d0879c5d8ec0dfcad8722954e | [32/n] [landing] move global css variables to shared
Summary: move root css variables to shared
Test Plan: make sure header colors still render correctly
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "+:root {\n+ --purple: #7e57c2;\n+ --white: #fff;\n+ --white1: #ebedee;\n+ --grey: #808080;\n+ --btn-bg: var(--purple);\n+ --unselected: var(--grey);\n+ --btn-color: var(--white1);\n+ --logo-color:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [32/n] [landing] move global css variables to shared
Summary: move root css variables to shared
Test Plan: make sure header colors still render correctly
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricato... |
129,179 | 08.12.2021 13:44:03 | 18,000 | 417000547349fa56e36c7023ad72eb0f81fee8d3 | [33/n] [landing] remove typography styles
Summary: remove typography with break points in favor of fluid and static typography classes.
Test Plan: make sure page still renders, typography is gone
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "@@ -53,52 +53,3 @@ a {\n}\n}\n}\n-\n-/* ===== TEXT STYLES ===== */\n-h1 {\n- font-size: 58px;\n- font-family: 'IBM Plex Sans', sans-serif;\n-}\n-\n-h2 {\n- font-size: 50px;\n- font-family: 'IBM Pl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [33/n] [landing] remove typography styles
Summary: remove typography with break points in favor of fluid and static typography classes.
Test Plan: make sure page still renders, typography is gone
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.