author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,179 | 08.12.2021 14:20:11 | 18,000 | 238115466d0011624b022530769378478d45c19d | [34/n] [landing] add fluid typography to body font
Summary: text should change size with screen size
Test Plan: resize window, view on mobile device
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "--unselected: var(--grey);\n--btn-color: var(--white1);\n--logo-color: var(--white);\n+ --min-font-size: 12px;\n+ --max-font-size: 28px;\n}\n/* ===== GENERAL PAGE STYLES ===== */\n@@ -15,6 +17,14 ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [34/n] [landing] add fluid typography to body font
Summary: text should change size with screen size
Test Plan: resize window, view on mobile device
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ash... |
129,179 | 08.12.2021 16:04:24 | 18,000 | f43f5e6574d0303fde6f1cfdb8a8015a0f76a270 | [35/n] [landing] style info-block
Summary: Add fluid styling to info-block
Test Plan: styling matching figma info block, resize window
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.css",
"new_path": "landing/info-block.css",
"diff": "+@supports ((-webkit-backdrop-filter: none) or (backdrop-filter: none)) {\n+ .info_block {\n+ background: rgba(235, 235, 235, 0.05);\n+ -webkit-backdrop-filter: blur(12px);\n+ backdrop-fil... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [35/n] [landing] style info-block
Summary: Add fluid styling to info-block
Test Plan: styling matching figma info block, resize window
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2593 |
129,179 | 08.12.2021 17:50:49 | 18,000 | 83899c46ec4cc5fba2211f954031de3977d3cb7a | [36/n] [landing] fix cycling header styles
Summary: fix cycling header styling. Had to review art collective content, it was breaking the layout
Test Plan: resize the web page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "--unselected: var(--grey);\n--btn-color: var(--white1);\n--logo-color: var(--white);\n+ --sub-heading-color: var(--purple);\n--min-font-size: 12px;\n--max-font-size: 28px;\n}\n"
},
{
"chan... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [36/n] [landing] fix cycling header styles
Summary: fix cycling header styling. Had to review art collective content, it was breaking the layout
Test Plan: resize the web page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revisi... |
129,179 | 08.12.2021 20:08:47 | 18,000 | cff5b0a15a681d90dee4a730a2404be88d87c1f6 | [37/n] [landing] fix text rendering
Summary: Fix rendering issues on firefox and optimize for text rendering
Test Plan: load the page, text should be crisp.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "@@ -17,6 +17,8 @@ html {\nbackground: radial-gradient(ellipse at bottom, #1f252e, #111827);\nbackground-attachment: fixed;\nfont-family: 'IBM Plex Sans', sans-serif;\n+ -moz-osx-font-smoothing: gr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [37/n] [landing] fix text rendering
Summary: Fix rendering issues on firefox and optimize for text rendering
Test Plan: load the page, text should be crisp.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabric... |
129,179 | 10.12.2021 15:00:56 | 18,000 | 55d9bec52b2dc37c5a339f2c5dfe19989a3afe51 | [39/n] [landing] Remove activeName prop from landing
Summary: Removing activename diff in favor of using active styles / hooks from react-router DOM
Test Plan: active links should not work
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -6,15 +6,9 @@ import * as React from 'react';\nimport { Link } from 'react-router-dom';\nimport footerStyles from './footer.css';\n-import type { LandingPageName } from './landing.rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [39/n] [landing] Remove activeName prop from landing
Summary: Removing activename diff in favor of using active styles / hooks from react-router DOM
Test Plan: active links should not work
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differ... |
129,179 | 10.12.2021 15:07:43 | 18,000 | e668fcecc12a4d8502774ea98c818850a958f8df | [40/n] [landing] re-add active links with react router dom props
Summary: Active tab functionality is reimplemented
Test Plan: click on footer links. They highlight correctly based on the page it's on.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -31,6 +31,7 @@ div.sitemap a {\nwidth: max-content;\n}\n+.inactive_tab,\ndiv.inactive_tab a,\ndiv.inactive_tab svg {\ncolor: #8a8f98;\n"
},
{
"change_type": "MODIFY",
"old_path": "l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [40/n] [landing] re-add active links with react router dom props
Summary: Active tab functionality is reimplemented
Test Plan: click on footer links. They highlight correctly based on the page it's on.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristo... |
129,179 | 13.12.2021 10:42:21 | 18,000 | fb86cde764275c78543201ffd44bd62a7e6886f0 | [41/n] [landing] remove styles and html in footer
Summary: Remove footer styles
Test Plan: page should still render, footer styles should be broken
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "-/* ===== CSS FOOTER GRID LAYOUT ===== */\n-div.footer_grid {\n- max-width: 1920px;\n- margin-left: auto;\n- margin-right: auto;\n- display: grid;\n- column-gap: 6em;\n- padding-left: 60px;\n- pad... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [41/n] [landing] remove styles and html in footer
Summary: Remove footer styles
Test Plan: page should still render, footer styles should be broken
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.asho... |
129,179 | 13.12.2021 10:46:20 | 18,000 | 9418fb4e9c31f1df90764feb29f43b45f0ba1253 | [42/n] [landing] add footer tag
Summary: use:
Test Plan: page should render
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -16,7 +16,7 @@ const navLinkProps = {\nfunction Footer(): React.Node {\nreturn (\n- <div>\n+ <footer>\n<NavLink to=\"/\">Comm</NavLink>\n<NavLink to=\"/keyservers\" exact {...navLinkP... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [42/n] [landing] add footer tag
Summary: use: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/footer
Test Plan: page should render
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/... |
129,179 | 13.12.2021 14:45:59 | 18,000 | 2f84c6f515b2e4f26aaa100e392778f95d32e741 | [43/n] [landing] put footer on 12 column grid / re-implement
Summary: style footer, it should match figma
Test Plan: Test footer on desktop browsers and mobile browsers
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "+footer.wrapper {\n+ max-width: 1850px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ padding: 50px 0;\n+ grid-template-columns: 40px repeat(12, 1fr) 40px;\n+ column-gap: 1.5%;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [43/n] [landing] put footer on 12 column grid / re-implement
Summary: style footer, it should match figma
Test Plan: Test footer on desktop browsers and mobile browsers
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: htt... |
129,190 | 17.12.2021 11:25:18 | -3,600 | 167674c0047a4a2578008177696f408e5817085c | [services] Fix building images
Summary:
Fix building images through yarn
This sources essential shell variables and makes building images work
Test Plan:
`cd services`
`yarn build-all`
`yarn build-base-image`
`yarn build-tunnelbroker-base`
`yarn build-backup-base`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ... | [
{
"change_type": "MODIFY",
"old_path": "services/docker-compose.yml",
"new_path": "services/docker-compose.yml",
"diff": "@@ -3,6 +3,7 @@ services:\nbase:\nbuild: base-image\nimage: commapp/services-base:1.0\n+ # tunnelbroker\ntunnelbroker-base:\nbuild:\ndockerfile: services/tunnelbroker/docker-base... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Fix building images
Summary:
Fix building images through yarn
This sources essential shell variables and makes building images work
Test Plan:
`cd services`
`yarn build-all`
`yarn build-base-image`
`yarn build-tunnelbroker-base`
`yarn build-backup-base`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed ... |
129,179 | 16.12.2021 21:00:33 | 18,000 | 6baeb9bb0d2047fca9389a0308ef2a3f623dd650 | [landing] remove unneeded spaces
Summary: remove unneeded spaces
Test Plan: N/A just removing empty lines
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -32,7 +32,6 @@ function Header(props: HeaderProps): React.Node {\n<NavLink to=\"/\" className={css.logo}>\n<h1>Comm</h1>\n</NavLink>\n-\n<div className={css.page_nav}>\n<NavLink to=\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] remove unneeded spaces
Summary: remove unneeded spaces
Test Plan: N/A just removing empty lines
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2634 |
129,179 | 17.12.2021 08:29:12 | 18,000 | 82b1e33d8409fc8316ff2bbd6199f2b0c2f52bc4 | [2/2] [landing] style hero cta button per figma
Summary: style hero cta button per figma {F6057}
Test Plan: view the app on a mobile device and desktop
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/hero-content.css",
"new_path": "landing/hero-content.css",
"diff": "color: var(--sub-heading-color);\n}\n+.contentWrapper {\n+ flex-basis: 300px;\n+}\n+\nbutton.request_access {\ndisplay: none;\n}\n@@ -50,12 +54,13 @@ button.request_access {\nall: unse... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/2] [landing] style hero cta button per figma
Summary: style hero cta button per figma {F6057}
Test Plan: view the app on a mobile device and desktop
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.... |
129,179 | 17.12.2021 15:29:42 | 18,000 | 80bdf3f41631cfbf9d3fa1ad450997d367dc43b3 | [fix] [landing] address header media query sizes
Summary:
Add a tablet sized break point for the header
Mobile and Tablet
{F6073}
Desktop
{F6074}
Test Plan: re-size the browser, view on a mobile device
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -76,12 +76,16 @@ button.request_access {\n@media screen and (max-width: 1099px) {\nnav.wrapper {\n- grid-template-columns: 16px repeat(6, 1fr) 16px;\n- grid-template-rows: 1fr 1fr;\n- column-ga... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] [landing] address header media query sizes
Summary:
Add a tablet sized break point for the header
Mobile and Tablet
{F6073}
Desktop
{F6074}
Test Plan: re-size the browser, view on a mobile device
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, borist... |
129,199 | 18.12.2021 15:08:18 | 18,000 | a5f3b7159d9e417aaf063edb80dbbc97d042322e | [server] Fixing `create-metadata-table` migration
Summary: This should not have been landed with this error. No excuses!
Test Plan:
Delete table, run SQL query in TablePlus.
Delete table, run script from `server` dir, as on Notion
Reviewers: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, boristo... | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-metadata-table.js",
"new_path": "server/src/scripts/create-metadata-table.js",
"diff": "@@ -7,7 +7,7 @@ async function createTable() {\nawait dbQuery(SQL`\nCREATE TABLE IF NOT EXISTS metadata (\nname varchar(255) NOT NULL,\n- data var... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fixing `create-metadata-table` migration
Summary: This should not have been landed with this error. No excuses!
Test Plan:
Delete table, run SQL query in TablePlus.
Delete table, run script from `server` dir, as on Notion
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bi... |
129,184 | 15.12.2021 13:11:20 | 18,000 | dca88dd1598697cd8947fb7a40a361d4619aa6e7 | [CommCoreModule] Implement `getAllMessagesSync`
Summary: This will primarily be used for testing.
Test Plan: `messageStore` reconstructed from the messages retrieved from `getAllMessagesSync` consistently matches up with redux `messageStore`
Reviewers: palys-swm, def-au1t, karol-bisztyga, ashoat
Subscribers: ashoat, Ad... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -159,6 +159,64 @@ jsi::Value CommCoreModule::removeAllDrafts(jsi::Runtime &rt) {\n});\n}\n+jsi::Array CommCoreModule::getAl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Implement `getAllMessagesSync`
Summary: This will primarily be used for testing.
Test Plan: `messageStore` reconstructed from the messages retrieved from `getAllMessagesSync` consistently matches up with redux `messageStore`
Reviewers: palys-swm, def-au1t, karol-bisztyga, ashoat
Reviewed By: palys-... |
129,179 | 20.12.2021 09:37:01 | 18,000 | fdf023fe1da96ddc7d9a90a6573b0061fc076548 | [fix] [landing] header on tablet page nav spacing
Summary:
fix visual bug were page nav items are too far from each other
Before: {F6094}
After: {F6095}
Test Plan: resize window see the spacing difference.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -30,7 +30,7 @@ nav.wrapper {\ntransition: 300ms;\n}\n-div.page_nav {\n+.page_nav {\ngrid-area: page_nav;\ndisplay: flex;\njustify-content: space-evenly;\n@@ -86,6 +86,7 @@ button.request_access... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] [landing] header on tablet page nav spacing
Summary:
fix visual bug were page nav items are too far from each other
Before: {F6094}
After: {F6095}
Test Plan: resize window see the spacing difference.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, b... |
129,190 | 21.12.2021 11:37:43 | -3,600 | b173902ec3b7f5355c43558e44427903f9c6583b | [2/n] [services] Backup tests - add storage manager tests
Summary: Tests for `AwsStorageManager`/`AwsS3Bucket` classes
Test Plan: `cd services && yarn test-backup-server`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "scripts/get_clang_paths.js",
"new_path": "scripts/get_clang_paths.js",
"diff": "@@ -14,6 +14,10 @@ const clangPaths = [\npath: 'services/backup/docker-server/contents/server/src',\nextensions: ['cpp', 'h'],\n},\n+ {\n+ path: 'services/backup/docker-server/cont... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] [services] Backup tests - add storage manager tests
Summary: Tests for `AwsStorageManager`/`AwsS3Bucket` classes
Test Plan: `cd services && yarn test-backup-server`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
D... |
129,190 | 21.12.2021 11:37:46 | -3,600 | 034ef7d4ec5d86e0384c6d5ec426b68153eeda15 | [3/n] [services] Backup tests - add mpu tests
Summary: Tests for `MultiPartUploader` class
Test Plan: `cd services && yarn test-backup-server`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/test/MultiPartUploadTest.cpp",
"diff": "+#include <gtest/gtest.h>\n+\n+#include \"AwsS3Bucket.h\"\n+#include \"AwsStorageManager.h\"\n+#include \"MultiPartUploader.h\"\n+#include \"TestTools.h\"\n+#i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n] [services] Backup tests - add mpu tests
Summary: Tests for `MultiPartUploader` class
Test Plan: `cd services && yarn test-backup-server`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https:... |
129,179 | 27.12.2021 13:51:20 | 18,000 | 6f72ff39b8ad2a22c3224a15b56ada8a47212795 | [revert] [landing] object spread syntax
Summary: reverting spread syntax per: project wide.
Test Plan: make sure the app still works.
Reviewers: atul, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -19,7 +19,7 @@ function InfoBlock(props: InfoBlockProps): React.Node {\nreturn (\n<>\n<div className={imageStyle}>\n- <Picture {...{ url, alt }} />\n+ <Picture alt={alt} url={... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [revert] [landing] object spread syntax
Summary: reverting spread syntax per: https://linear.app/comm/issue/ENG-313/revert-object-spread-syntax-for-react-props project wide.
Test Plan: make sure the app still works.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, boristo... |
129,179 | 28.12.2021 13:46:22 | 18,000 | 4ad2d5f351fceb247c1dc81d2a12437c24fc40a8 | [fix] [landing] footer renders full screen on large screens
Summary:
footer renders full screen on large screens
Before: {F6212}
After: {F6385}
Test Plan: resize window. make sure footer stretches
Reviewers: atul, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "footer.wrapper {\n+ background: rgba(235, 235, 235, 0.05);\n+ backdrop-filter: blur(12px);\n+ position: sticky;\n+ top: 100vh;\n+}\n+\n+.contentWrapper {\nmax-width: 1850px;\nmargin-left: auto;\nm... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] [landing] footer renders full screen on large screens
Summary:
footer renders full screen on large screens
Before: {F6212}
After: {F6385}
Test Plan: resize window. make sure footer stretches
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga, b... |
129,184 | 28.12.2021 18:33:30 | 18,000 | 85d402278455c0240edf21b2f7f576b5fb184be9 | [yarn] Bump `ws`
Summary:
Bumping `ws` from 5.2.2 -> 5.2.3 resolves a security issue.
Takes us from 30 to 29 vulnerabilities in `y audit`
Test Plan: Should be fine
Reviewers: varun, palys-swm, def-au1t, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -16287,9 +16287,9 @@ ws@^1.1.0, ws@^1.1.5:\nultron \"1.0.x\"\nws@^5.2.0:\n- version \"5.2.2\"\n- resolved \"https://registry.yarnpkg.com/ws/-/ws-5.2.2.tgz#dffef14866b8e8dc9133582514d1befaf96e980f\"\n- integrity ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [yarn] Bump `ws`
Summary:
Bumping `ws` from 5.2.2 -> 5.2.3 resolves a security issue.
Takes us from 30 to 29 vulnerabilities in `y audit`
Test Plan: Should be fine
Reviewers: varun, palys-swm, def-au1t, ashoat
Reviewed By: ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov
Differential Re... |
129,184 | 28.12.2021 22:01:37 | 18,000 | 15e32315f65525a3cf0b24c71e9c0c296caa93b8 | [native] `codeVersion` -> 127 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 127 |
129,185 | 27.12.2021 15:31:22 | -3,600 | aedcb49a2890ca1eb1cf8c9b60f488ca89f49d48 | [1/n] [id-schemas] [server] Introduce `tID` type for IDs in server validators
Summary: Introduce `tID` as `tcomb` type (refinement) defined as non-empty string (like `tPassword`).
Test Plan: No changes in server behavior yet.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/utils/validation-utils.js",
"new_path": "server/src/utils/validation-utils.js",
"diff": "@@ -63,6 +63,7 @@ const tPassword: TRefinement<string> = t.refinement(\nconst tCookie: TRegex = tRegex(/^(user|anonymous)=[0-9]+:[0-9a-f]+$/);\nconst tEmail: TR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] [id-schemas] [server] Introduce `tID` type for IDs in server validators
Summary: Introduce `tID` as `tcomb` type (refinement) defined as non-empty string (like `tPassword`).
Test Plan: No changes in server behavior yet.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, ... |
129,185 | 27.12.2021 15:31:22 | -3,600 | de04436dc5614da4c6f8c2acd9e769e221526519 | [2/n] [id-schemas] [server] Introduce `tNumber` as literal number for `tcomb` validation
Summary: Introducing util `tNumber` similar to existing `tBool` and `tString` for number values validation.
Test Plan: Tested with changes in future diffs.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, Adrian, atul, karol-biszt... | [
{
"change_type": "MODIFY",
"old_path": "server/src/utils/validation-utils.js",
"new_path": "server/src/utils/validation-utils.js",
"diff": "@@ -27,6 +27,10 @@ function tString(value: string): TIrreducible<string> {\nreturn t.irreducible('literal string', x => x === value);\n}\n+function tNumber(valu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] [id-schemas] [server] Introduce `tNumber` as literal number for `tcomb` validation
Summary: Introducing util `tNumber` similar to existing `tBool` and `tString` for number values validation.
Test Plan: Tested with changes in future diffs.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscriber... |
129,191 | 21.12.2021 18:03:42 | -3,600 | d967e73b8b825b9ed0678a123603f24cf7acd3a2 | [3/5][server] Delete earliestFocusedTimeConsideredCurrent method
Summary: We're no longer using it
Test Plan: Flow
Reviewers: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/shared/focused-times.js",
"new_path": "server/src/shared/focused-times.js",
"diff": "// @flow\n-import { pingFrequency } from 'lib/shared/timeouts';\n-\n-// If the time column for a given entry in the focused table has a time later\n-// than this, t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/5][server] Delete earliestFocusedTimeConsideredCurrent method
Summary: We're no longer using it
Test Plan: Flow
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2695 |
129,191 | 21.12.2021 18:28:32 | -3,600 | 18a44626a16ca842b50a6feb139b8ac7214e6d04 | [4/5][server] Do not update focused time after ping
Summary: We no longer need to update the time
Test Plan: Add a console log to verify that pong was returned correctly
Reviewers: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket/socket.js",
"new_path": "server/src/socket/socket.js",
"diff": "@@ -383,7 +383,7 @@ class Socket {\nthis.markActivityOccurred();\nreturn await this.handleResponsesClientSocketMessage(message);\n} else if (message.type === clientSocketMessageT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [4/5][server] Do not update focused time after ping
Summary: We no longer need to update the time
Test Plan: Add a console log to verify that pong was returned correctly
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: htt... |
129,191 | 21.12.2021 18:37:12 | -3,600 | 3cd09546102518e54801097822a86a9fbaab634d | [5/5][server] Delete updateActivityTime function
Summary: We don't need that
Test Plan: Flow
Reviewers: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket/socket.js",
"new_path": "server/src/socket/socket.js",
"diff": "@@ -70,7 +70,6 @@ import {\ncreateNewAnonymousCookie,\n} from '../session/cookies';\nimport { Viewer } from '../session/viewer';\n-import { updateActivityTime } from '../updaters... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [5/5][server] Delete updateActivityTime function
Summary: We don't need that
Test Plan: Flow
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2699 |
129,179 | 09.01.2022 19:30:47 | 18,000 | ae2083d4e50d8fe788b7b404248136db9646880c | [fix] [landing] copy change ETH wallet --> wallet
Summary:
copy change per:
{F7387}
Test Plan: go to landing and make sure copy is right
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/asset-meta-data.js",
"new_path": "landing/asset-meta-data.js",
"diff": "@@ -56,7 +56,7 @@ export const assetMetaData = [\nimageStyle: css.sovereignImage,\ninfoStyle: css.sovereignInfo,\ntitle: 'Sovereign',\n- description: `Log in with your ETH wallet. ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] [landing] copy change ETH wallet --> wallet
Summary:
copy change per: https://linear.app/comm/issue/ENG-399/replace-eth-wallet-with-wallet-on-landing-page
{F7387}
Test Plan: go to landing and make sure copy is right
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, ka... |
129,184 | 06.01.2022 17:11:01 | 18,000 | 1f7f8010972d9d16754648079dd87e438c63ef8e | [keyserver] Add `@grpc/grpc-js` to `package.json`
Summary: Don't have any code that's ready to commit.. still experimenting, but might as well get this in
Test Plan: NA
Reviewers: varun, palys-swm, geekbrother, benschac, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"tcomb\": \"^3.2.29\",\n\"twin-bcrypt\": \"^2.1.1\",\n\"uuid\": \"^3.3.3\",\n- \"web\": \"0.0.1\"\n+ \"web\": \"0.0.1\",\n+ \"@grpc/grpc-js\": \"^1.4.6\"\n},\n\"optionalDependencies\": {\n\"buf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Add `@grpc/grpc-js` to `package.json`
Summary: Don't have any code that's ready to commit.. still experimenting, but might as well get this in
Test Plan: NA
Reviewers: varun, palys-swm, geekbrother, benschac, ashoat
Reviewed By: benschac, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, b... |
129,179 | 10.01.2022 09:09:33 | 18,000 | 317d6f5d468a392d922aa7b839afdcbf519c8a6d | [web] [4/n] [refactor] use font-stack css variable
Summary: use css variable for font stack
Test Plan: make sure fonts still render correctly on the page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -10,8 +10,7 @@ html {\nheight: 100%;\n}\nbody {\n- font-family: -apple-system, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu',\n- 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', ui-sans-serif;\n+ fon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [4/n] [refactor] use font-stack css variable
Summary: use css variable for font stack
Test Plan: make sure fonts still render correctly on the page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricato... |
129,184 | 10.01.2022 12:47:24 | 18,000 | 14af49565eaae3b7ad9f2e6e9242d59266652297 | [native] `codeVersion` -> 128 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -430,8 +430,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 128 |
129,179 | 11.01.2022 02:18:35 | 18,000 | cd320d23f88971059cf9164981a2496cf6be5159 | [web] [9/n] remove Anaheim from project
Summary: remove anaheim font that's no longer used in the project
Test Plan: make sure there aren't any references to anaheim left. Confirm this style isn't in figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/fonts/local-fonts.css",
"new_path": "server/fonts/local-fonts.css",
"diff": "-/* latin-ext */\n-@font-face {\n- font-family: 'Anaheim';\n- font-style: normal;\n- font-weight: 400;\n- src: local('Anaheim'), local('Anaheim-Regular'), url(anaheim-latin-ext... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [9/n] remove Anaheim from project
Summary: remove anaheim font that's no longer used in the project
Test Plan: make sure there aren't any references to anaheim left. Confirm this style isn't in figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, bor... |
129,179 | 07.01.2022 08:32:29 | 18,000 | b7a381feea0f0d543076a60ba1bc646e93556412 | [web] [13/n] add base theme from default color swatch
Summary: add default theme from color swatch.
Test Plan: N/A its not being used anywhere.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/theme.css",
"diff": "+:root {\n+ --bg: var(--shades-black-100);\n+ --color: var(--shades-white-100);\n+ --color-disabled: var(--shades-black-60);\n+ --text-input-bg: var(--shades-black-80);\n+ --text-input-color: var(--shades-black-60);\n+ -... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [13/n] add base theme from default color swatch
Summary: add default theme from color swatch.
Test Plan: N/A its not being used anywhere.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.c... |
129,179 | 05.01.2022 11:18:39 | 18,000 | cbaff1bae726e514860ddf763b00d91a76150ac8 | [landing] [1/2] [refactor] extract cta button into a component
Summary: move cta button to it's own component, will be used in `/team` moving forward.
Test Plan: N/A, will render correctly in the following diff
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/button.css",
"diff": "+button.btn {\n+ all: unset;\n+ border-radius: 4px;\n+ font-size: 16px;\n+ background-color: var(--btn-bg);\n+ color: var(--btn-color);\n+ justify-content: center;\n+ padding: 12px 24px;\n+ transition: 300ms;\n+ fle... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] [1/2] [refactor] extract cta button into a component
Summary: move cta button to it's own component, will be used in `/team` moving forward.
Test Plan: N/A, will render correctly in the following diff
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, bori... |
129,179 | 06.01.2022 16:32:09 | 18,000 | 571fd08949cb4174443246d5cff7116a3b0324a5 | [11/n] [web] add font styles from figma to global variables
Summary: Add style guide values to css variables. Link to style guide:
Test Plan: N/A they aren't used yet
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "web/typography.css",
"new_path": "web/typography.css",
"diff": "--font-stack-sans-serif: -apple-system, 'Segoe UI', 'Roboto', 'Oxygen',\n'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue',\nui-sans-serif;\n+ --xxxl-font-32: 3.2rem;\n+ --xxl-fon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [11/n] [web] add font styles from figma to global variables
Summary: Add style guide values to css variables. Link to style guide: https://www.figma.com/file/RROVwCKAeFaO7tG64blzlx/Comm-Web-Design-System?node-id=1%3A16
Test Plan: N/A they aren't used yet
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscriber... |
129,179 | 10.01.2022 13:49:42 | 18,000 | a12aa8e1bdad73d4f0787edbe68f06418cc4c9ff | [web] [16/n] [refactor] move tool tip css into its own module
Summary: move tooltip styles from chat-message-list to tooltip
Test Plan: make sure page renders and styles look the same as production
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -108,50 +108,6 @@ div.innerRobotextContainer {\nword-break: break-word;\n}\n-div.messageTooltipMenu {\n- position: absolute;\n- background-color: black;\n- color: white;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [16/n] [refactor] move tool tip css into its own module
Summary: move tooltip styles from chat-message-list to tooltip
Test Plan: make sure page renders and styles look the same as production
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differentia... |
129,179 | 10.01.2022 15:36:19 | 18,000 | 5fcac902486961c612aa60a66585ecf3e34f857b | [web] [18/n] [refactor] move robo text css from chat-message-list to robotext-message
Summary: move robo text files to their own module
Test Plan: make sure local and production look the same and aren't broken <beforescreenshot> <afterscreenshot>
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bis... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -94,20 +94,6 @@ div.conversationHeader {\ndiv.conversationHeader:last-child {\npadding-top: 6px;\n}\n-\n-div.robotextContainer {\n- text-align: center;\n- color: #333333... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [18/n] [refactor] move robo text css from chat-message-list to robotext-message
Summary: move robo text files to their own module
Test Plan: make sure local and production look the same and aren't broken <beforescreenshot> <afterscreenshot>
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoa... |
129,179 | 11.01.2022 12:25:20 | 18,000 | 2120d8ce800217b886ab6f5bc4b87e6e9a7503c8 | [web] [19/n] [refactor] chat-input-bar styles moved to chat-input-bar
Summary:
refactor styles, move input bar styles to it's own modular css file
Production: {F7906}
Local: {F7914}
Test Plan: input bar looks and works the same as in production.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisz... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/chat/chat-input-bar.css",
"diff": "+div.inputBar {\n+ display: flex;\n+ flex-direction: column;\n+ border-top: 2px solid #e4e4e4;\n+}\n+div.inputBarTextInput {\n+ display: flex;\n+ padding: 16px;\n+ align-items: center;\n+ flex-shrink: 0;\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [19/n] [refactor] chat-input-bar styles moved to chat-input-bar
Summary:
refactor styles, move input bar styles to it's own modular css file
Production: {F7906}
Local: {F7914}
Test Plan: input bar looks and works the same as in production.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoa... |
129,179 | 12.01.2022 12:43:34 | 18,000 | e803eec84dd0cff9ea30e4fc2551848d4a99c7c0 | [web] [4/n] [darktheme] SquadCal --> to Comm branding in header
Summary: Add Comm branding to header
Test Plan: header should look like this <add image>
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -178,7 +178,7 @@ class App extends React.PureComponent<Props, State> {\n<React.Fragment>\n<header className={css['header']}>\n<div className={css['main-header']}>\n- <h1>SquadCal</h1>\n+ <h1>Comm</... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [4/n] [darktheme] SquadCal --> to Comm branding in header
Summary: Add Comm branding to header
Test Plan: header should look like this <add image>
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2... |
129,179 | 13.01.2022 16:22:07 | 18,000 | 0cb63db631dab2ed8b96ad40e2d874475ffeaa26 | [web] [typography] import heavier fonts from font source
Summary: Add our other font weights
Test Plan: fonts should render with additional weight, look at the docs:
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "// @flow\nimport '@fontsource/inter';\n+import '@fontsource/inter/500.css';\n+import '@fontsource/inter/600.css';\nimport { config as faConfig } from '@fortawesome/fontawesome-svg-core';\nimport { faC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [typography] import heavier fonts from font source
Summary: Add our other font weights
Test Plan: fonts should render with additional weight, look at the docs: https://fontsource.org/docs/getting-started
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Diffe... |
129,190 | 14.01.2022 09:45:13 | -3,600 | dcb5b15fa531b4eae9d1691188802e4093eda268 | [services] change server to service in commands
Summary: This makes commands for services consistent
Test Plan: Run changed commands
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"build-all\": \"./scripts/build_base_image.sh\",\n\"build-base-image\": \"./scripts/build_base_image.sh base\",\n\"build-tunnelbroker-base\": \"./scripts/build_base_image.sh tunnelbroker-ba... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] change server to service in commands
Summary: This makes commands for services consistent
Test Plan: Run changed commands
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul, boristopalov
Differential Revision: https://phabrica... |
129,179 | 13.01.2022 13:41:12 | 18,000 | 77c3a574855accfdf0c05d5d2cb27978ff5d2e93 | [web] update meta data SquadCal --> Comm
Summary:
update web meta data SquadCal --> Comm
Will swap out favicons in the next diff
Test Plan: {F8323}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -242,8 +242,8 @@ async function websiteResponder(\n/>\n<link rel=\"manifest\" href=\"site.webmanifest\" />\n<link rel=\"mask-icon\" href=\"safa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] update meta data SquadCal --> Comm
Summary:
update web meta data SquadCal --> Comm
Will swap out favicons in the next diff
Test Plan: {F8323}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2855 |
129,179 | 12.01.2022 12:11:07 | 18,000 | cb443482e07290ea93e35c90807d89126705c262 | [web] [2/n] [darktheme] import colors
Summary: Imports the color swatch into the web app
Test Plan: look in the console, you should see the colors loaded in dev tools {F8069}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -4,6 +4,7 @@ import '@fontsource/inter';\nimport '@fontsource/inter/500.css';\nimport '@fontsource/inter/600.css';\nimport 'basscss/css/basscss.min.css';\n+import './theme.css';\nimport { config as... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [2/n] [darktheme] import colors
Summary: Imports the color swatch into the web app
Test Plan: look in the console, you should see the colors loaded in dev tools {F8069}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://ph... |
129,196 | 04.01.2022 10:37:44 | -3,600 | bc3d324b8351a9cf7825205986b902c3131ff63e | Use SingleLine component for thread settings notifications.
Summary: Solve issue eng-299
Test Plan: Run application on iOS and Android (small and big size) emulators to see that bug described in disappears.
Reviewers: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-home-notifs.react.js",
"new_path": "native/chat/settings/thread-settings-home-notifs.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { Text, View, Switch } from 'react-native';\n+import { View, Switch... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use SingleLine component for thread settings notifications.
Summary: Solve issue eng-299
Test Plan: Run application on iOS and Android (small and big size) emulators to see that bug described in ENG-299 disappears.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, a... |
129,187 | 13.01.2022 02:49:53 | 18,000 | a4b1a03f194676f99d1d483beffa05725eb6ffd4 | [native] Rename ComposeThread to ComposeSubchannel
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-router.js",
"new_path": "native/chat/chat-router.js",
"diff": "@@ -27,7 +27,7 @@ import {\n} from '../navigation/navigation-utils';\nimport {\nChatThreadListRouteName,\n- ComposeThreadRouteName,\n+ ComposeSubchannelRouteName,\n} from '../navig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename ComposeThread to ComposeSubchannel
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Reviewed By: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/... |
129,187 | 13.01.2022 02:55:24 | 18,000 | 9c8c8d69fc2e879afed5f22fb180dcb43f4bdb8f | [native] Rename ComposeThreadModal to ComposeSubchannelModal
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga | [
{
"change_type": "RENAME",
"old_path": "native/chat/settings/compose-subthread-modal.react.js",
"new_path": "native/chat/settings/compose-subchannel-modal.react.js",
"diff": "@@ -15,21 +15,21 @@ import type { NavigationRoute } from '../../navigation/route-names';\nimport { ComposeSubchannelRouteName... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename ComposeThreadModal to ComposeSubchannelModal
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Reviewed By: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.a... |
129,187 | 13.01.2022 02:58:43 | 18,000 | c3fbf09073495b1e3bb4a71c2fae7cf26d2bf957 | Rename CREATE_SUBTHREADS to CREATE_SUBCHANNELS
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -861,7 +861,7 @@ const permissionsDisabledByBlockArray = [\nthreadPermissions.EDIT_THREAD_NAME,\nthreadPermissions.EDIT_THREAD_COLOR,\nthreadPermissions.EDIT_THREAD_DESCRIPTION,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Rename CREATE_SUBTHREADS to CREATE_SUBCHANNELS
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Reviewed By: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D284... |
129,179 | 20.01.2022 09:25:39 | 18,000 | 0ce4f75d176444734bcb84a0806502b24702a865 | [web] add SWM icons
Summary:
add icons to use in the application. These are the selected icons from icomoon
{F9166}
Test Plan: N/A
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "\"metadata\": {\n\"name\": \"AppIcons\",\n\"lastOpened\": 0,\n- \"created\": 1640708563820\n+ \"created\": 1642621856590\n},\n\"iconSets\": [\n{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add SWM icons
Summary:
add icons to use in the application. These are the selected icons from icomoon
{F9166}
Test Plan: N/A
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2889 |
129,179 | 13.01.2022 13:49:38 | 18,000 | d341a44e5b3e1bb7cf2989b2b750d8002b8f3ae2 | [web] replace favicons from squadcal to comm
Summary: update favicons to match comm brand {F8335}
Test Plan: load page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/icons/apple-touch-icon.png",
"new_path": "server/icons/apple-touch-icon.png",
"diff": "Binary files a/server/icons/apple-touch-icon.png and b/server/icons/apple-touch-icon.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/icons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] replace favicons from squadcal to comm
Summary: update favicons to match comm brand {F8335}
Test Plan: load page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2856 |
129,190 | 24.01.2022 11:23:09 | -3,600 | 70049ffec44a2f2902dfa9965262821bf5b953ba | Services - backup - install aws specific version
Summary:
Raised in
I think we should always install specific versions of libraries.
Test Plan:
```
cd services
yarn build-backup-base
```
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-base/contents/install_aws_sdk.sh",
"new_path": "services/backup/docker-base/contents/install_aws_sdk.sh",
"diff": "@@ -10,7 +10,7 @@ fi\npushd /usr/lib\n-git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp\n+git clone --rec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Services - backup - install aws specific version
Summary:
Raised in https://phabricator.ashoat.com/D2759#73477
I think we should always install specific versions of libraries.
Test Plan:
```
cd services
yarn build-backup-base
```
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers... |
129,179 | 24.01.2022 14:30:29 | 18,000 | fad95eb52d22a52d887f6339b1bcd550e165d6b5 | [web] [1/n] [style chat tabs] copy change focused --> focus
Summary: copy change to match the designs {F9240}
Test Plan: double check figma this is correct.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.react.js",
"new_path": "web/chat/chat-tabs.react.js",
"diff": "@@ -27,7 +27,7 @@ function ChatTabs(props: Props): React.Node {\n);\nconst { activeTab, setActiveTab } = threadListContext;\n- const onClickHome = React.useCallback(() => setActi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [1/n] [style chat tabs] copy change focused --> focus
Summary: copy change to match the designs {F9240}
Test Plan: double check figma this is correct.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.c... |
129,179 | 12.01.2022 12:19:24 | 18,000 | b46fb9d9de8ce211302291edc07316cb42e49ce1 | [web] [3/n] [darktheme] update colors in navigation header
Summary: swaps out old background with updated dark theme.
Test Plan: Header should look like this {F8075}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -62,6 +62,7 @@ header.header {\n}\ndiv.main-header {\nheight: 62px;\n+ background: var(--bg);\n}\ndiv.main-header > h1 {\nposition: absolute;\n@@ -92,7 +93,7 @@ ul.nav-bar > li > div {\npadding: 3px 20px... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [3/n] [darktheme] update colors in navigation header
Summary: swaps out old background with updated dark theme.
Test Plan: Header should look like this {F8075}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.... |
129,179 | 12.01.2022 12:45:04 | 18,000 | 9a9a634960a85988e4583cf19e97557f49aa7eb1 | [web] [5/n] [darktheme] update brand styling to Figma
Summary: styles for branding should match figma, layout and positioning are still off and will continue to be updated
Test Plan: header should look like this {F8095}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -63,13 +63,16 @@ header.header {\ndiv.main-header {\nheight: 62px;\nbackground: var(--bg);\n+ display: flex;\n+ align-items: center;\n}\ndiv.main-header > h1 {\n- position: absolute;\n- padding-top: 5px;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [5/n] [darktheme] update brand styling to Figma
Summary: styles for branding should match figma, layout and positioning are still off and will continue to be updated
Test Plan: header should look like this {F8095}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol... |
129,179 | 12.01.2022 15:31:26 | 18,000 | ae3d92963c89d61cefa643ebcdfab6ff550342df | [web] [7/n] [darktheme] update thread list color to dark
Summary: change thread list to dark theme
Test Plan: thread list should look like screen shot.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -3,7 +3,7 @@ div.container {\nwidth: 400px;\ntop: 0;\nbottom: 0;\n- background-color: white;\n+ background-color: var(--bg);\nborder-right: 2px solid #e4e4e4;\ndisplay: flex;\nflex-dire... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [7/n] [darktheme] update thread list color to dark
Summary: change thread list to dark theme
Test Plan: thread list should look like screen shot.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D28... |
129,179 | 12.01.2022 16:51:39 | 18,000 | f31b820c5978d555e1a795973544c0b2ba66f544 | [web] [10/n] [darktheme] update tool tip theme to dark
Summary:
match color theme from figma {F8149}
Test Plan: tool tip should look like screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -53,32 +53,32 @@ div.conversationHeader:last-child {\ndiv.messageLeftTooltip:after {\ntop: 7px;\nright: -14px;\n- border-color: transparent transparent transparent black... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [10/n] [darktheme] update tool tip theme to dark
Summary:
match color theme from figma {F8149}
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77360
Test Plan: tool tip should look like screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, ... |
129,179 | 13.01.2022 12:27:44 | 18,000 | f0e82ac34acceda27b725939e798ea3f9baa1348 | [web] [11/n] [darktheme] add border to main header
Summary: add border to main header {F8295}
Test Plan: it should look like figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -65,6 +65,7 @@ div.main-header {\nbackground: var(--bg);\ndisplay: flex;\nalign-items: center;\n+ border-bottom: 1px solid var(--border-color);\n}\ndiv.main-header > h1 {\ncolor: var(--fg);\n"
},
{
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [11/n] [darktheme] add border to main header
Summary: add border to main header {F8295}
Test Plan: it should look like figma https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77360
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, ka... |
129,179 | 13.01.2022 12:35:22 | 18,000 | 594d60f0cc28efaa9db47540f50dbd7676cc7876 | [web] [12/n] [darktheme] update border for chat tabs
Summary: to match figma {F8301}
Test Plan: should look like screen shot and match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -4,7 +4,7 @@ div.container {\ntop: 0;\nbottom: 0;\nbackground-color: var(--bg);\n- border-right: 2px solid #e4e4e4;\n+ border-right: 1px solid var(--border-color);\ndisplay: flex;\nflex... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [12/n] [darktheme] update border for chat tabs
Summary: to match figma {F8301} https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77360
Test Plan: should look like screen shot and match figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm,... |
129,179 | 13.01.2022 12:44:48 | 18,000 | 23a23d1c021974f0046d15c7d01a82b0b752d676 | [web] [14/n] [darktheme] add inactive chat tab selection bottom border
Summary: {F8315} to match figma
Test Plan: should match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -30,7 +30,8 @@ div.tabItemActive {\ndiv.tabItemInactive {\nbackground-color: var(--bg);\ncolor: var(--color-disabled);\n- margin-bottom: -1px;\n+ border: outset var(--border-color);\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [14/n] [darktheme] add inactive chat tab selection bottom border
Summary: {F8315} to match figma
Test Plan: should match figma https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77360
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, ... |
129,179 | 18.01.2022 15:58:14 | 18,000 | 80ceed7a0abc6f37fd494f149118f08398183849 | [web] [16/n] [darkmode] position send icon outside of input field background.
Summary: move send icon outside of input field {F8909}
Test Plan: add text to input field
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -6,6 +6,7 @@ div.inputBar {\ndiv.inputBarWrapper {\npadding: 16px;\ndisplay: flex;\n+ align-items: center;\nflex-direction: row;\nalign-items: center;\n}\n@@ -75,3 +76,11 @@ d... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [16/n] [darkmode] position send icon outside of input field background.
Summary: move send icon outside of input field {F8909}
Test Plan: add text to input field
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricato... |
129,179 | 19.01.2022 13:08:52 | 18,000 | 1c99643d6f3fdb84f7a8b2f2290f42e777c19328 | [web] [17/n] [darkmode] update image upload to correct white color
Summary: match figma, image upload should be white {F9051}
Test Plan: check figma that the right color is used
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -64,6 +64,11 @@ a.multimediaUpload > input[type='file'] {\nmargin: 0;\npadding: 0;\n}\n+\n+a.multimediaUpload > svg {\n+ color: var(--fg);\n+}\n+\ndiv.previews {\ndisplay: fle... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [17/n] [darkmode] update image upload to correct white color
Summary: match figma, image upload should be white {F9051}
Test Plan: check figma that the right color is used
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: ht... |
129,179 | 24.01.2022 15:03:49 | 18,000 | d6b1654a2b1d50acac099cd1f0b0b147d42f7bc6 | [web] [fix] comm header incorrect size
Summary: incorrect variable name was added and no font-size was applied {F9234}
Test Plan: make sure the header looks like <screenshot>
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -73,7 +73,7 @@ div.main-header > h1 {\nfont-family: var(--font-logo);\nline-height: var(--line-height-text);\nfont-weight: var(--semi-bold);\n- font-size: var(--logo-font);\n+ font-size: var(--logo-font-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] comm header incorrect size
Summary: incorrect variable name was added and no font-size was applied {F9234}
Test Plan: make sure the header looks like <screenshot>
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://pha... |
129,179 | 24.01.2022 15:17:45 | 18,000 | d194968a7e07e8095f6eba83f28e85d0992c4cc6 | [web] [refactor] component prop destructure to be consistent with project
Summary: keep component consistent with project
Test Plan: n/a component does exactly what it did before
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-tab.react.js",
"new_path": "web/chat/chat-thread-tab.react.js",
"diff": "@@ -6,19 +6,20 @@ import * as React from 'react';\nimport css from './chat-tabs.css';\ntype Props = {\n- title: string,\n- onClick: (title: string) => void,\n- tabIsA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] component prop destructure to be consistent with project
Summary: keep component consistent with project
Test Plan: n/a component does exactly what it did before
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https:/... |
129,179 | 24.01.2022 15:47:19 | 18,000 | 0b985d050842f837997eeb518f9c24d75734713a | [web] [1/n] [darkmodecalendar] swap image background for black
Summary: change image background from image to black, more theme'ing to come {F9408}
Test Plan: should look like screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/filter-panel.css",
"new_path": "web/calendar/filter-panel.css",
"diff": "@@ -3,15 +3,12 @@ div.container {\nwidth: 300px;\ntop: 62px;\nbottom: 0;\n- background-image: url(../images/background.png);\n- background-size: 3000px 2000px;\nbackground-at... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [1/n] [darkmodecalendar] swap image background for black
Summary: change image background from image to black, more theme'ing to come {F9408}
Test Plan: should look like screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision... |
129,179 | 24.01.2022 15:40:22 | 18,000 | 78e0bf87df9b253c1dc01ed5353f09592f055060 | [web] [4/n] [darkmodecalendar] theme calendar
Summary: theme calendar
Test Plan: should look like this. There isn't design. Happy to take unput
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -62,7 +62,7 @@ textarea.entryText {\n}\ntable.calendar td.day {\nborder: 1px solid transparent;\n- background-color: white;\n+ background: var(--calendar-day-bg);\nposition: relat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [4/n] [darkmodecalendar] theme calendar
Summary: theme calendar
Test Plan: should look like this. There isn't design. Happy to take unput
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2909 |
129,179 | 25.01.2022 07:57:52 | 18,000 | 998d8b46edbcf8cdefd79161c06da90afb91d407 | [web] [2/n] [darkmodecalendar] update heading text
Summary: update header styling {F9733}
Test Plan: header should match theme
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -34,6 +34,7 @@ nav.nav > a.monthLink {\nnav.nav > .monthName {\ndisplay: inline-block;\nwidth: 200px;\n+ color: var(--fg);\n}\ntable.calendar {\n"
},
{
"change_type": "MOD... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [2/n] [darkmodecalendar] update heading text
Summary: update header styling {F9733}
Test Plan: header should match theme
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2920 |
129,179 | 25.01.2022 08:04:02 | 18,000 | 9376da212c8d42695fb76c5b17470d9bd79aa2db | [web] [1,2,3/n] [layout] add css grid layout to top level
Summary:
add basic grid layout, it should be broken visually {F8893}
updated screen shot now that [1,2,3/n] are squashed
Test Plan: n/a
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -42,6 +42,7 @@ import FocusHandler from './redux/focus-handler.react';\nimport { useSelector } from './redux/redux-utils';\nimport VisibilityHandler from './redux/visibility-handler.react';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [1,2,3/n] [layout] add css grid layout to top level
Summary:
add basic grid layout, it should be broken visually {F8893}
updated screen shot now that [1,2,3/n] are squashed
Test Plan: n/a
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential R... |
129,179 | 25.01.2022 08:05:34 | 18,000 | 622a51cf717d652a758e0ad0981e997c18fa84f6 | [web] [5/n] [layout] add spaces component
Summary: Add section for community and inbox selection
Test Plan: should look like {F8539}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/sidebar/community-picker.css",
"diff": "+.container {\n+ display: flex;\n+ flex-direction: column;\n+ width: 84px;\n+ background: var(--community-bg);\n+ border-right: 1px solid var(--border-color);\n+}\n"
},
{
"change_type": "ADD",
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [5/n] [layout] add spaces component
Summary: Add section for community and inbox selection
Test Plan: should look like {F8539}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2869 |
129,179 | 25.01.2022 09:06:01 | 18,000 | 596a25e766d549a272359ddbf23fb555704285c7 | [web] [navigation] [2/n] move unread functionality to sidebar
Summary: move unread functionality to sidebar {F8993}
Test Plan: send a message to a test user and confirm correct unread count is showing up
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -9,7 +9,6 @@ import { config as faConfig } from '@fortawesome/fontawesome-svg-core';\nimport { faCalendar, faComments } from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [navigation] [2/n] move unread functionality to sidebar
Summary: move unread functionality to sidebar {F8993}
Test Plan: send a message to a test user and confirm correct unread count is showing up
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Diffe... |
129,179 | 25.01.2022 09:07:30 | 18,000 | f90c6d545ba2fd9770ae3a9e3e8e877b68558ec0 | [web] [navigation] [4/n] remove old navigation from header
Summary: remove app switcher from header {F9066}
Test Plan: make sure all code from header is gone
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -6,8 +6,6 @@ import '@fontsource/inter/600.css';\nimport 'basscss/css/basscss.min.css';\nimport './theme.css';\nimport { config as faConfig } from '@fortawesome/fontawesome-svg-core';\n-import { fa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [navigation] [4/n] remove old navigation from header
Summary: remove app switcher from header {F9066}
Test Plan: make sure all code from header is gone
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.c... |
129,179 | 20.01.2022 13:06:38 | 18,000 | ec30731c5f856cf55393adb22baf1fe44c424b1c | [web] [style app switcher] [1/n] add SWM icons
Summary: add icons to side bar per design. Designing sidebar coming in future diffs {F9196}
Test Plan: make sure icons render
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "@@ -11,6 +11,7 @@ import {\n} from 'lib/selectors/thread-selectors';\nimport { useSelector } from '../redux/redux-utils';\n+import SWMansionIcon from '../SWMansionIco... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [style app switcher] [1/n] add SWM icons
Summary: add icons to side bar per design. Designing sidebar coming in future diffs {F9196}
Test Plan: make sure icons render
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabr... |
129,179 | 20.01.2022 13:21:06 | 18,000 | ae10dc96b396cfaddc7f4b4288ca59d494478e13 | [web] [style app switcher] [2/n] toggle color on app switch
Summary: when clicking between apps (cal, chat) navigation toggles color both icon and text {F9202}
Test Plan: colors should toggle
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "@@ -89,13 +89,13 @@ function AppSwitcher(): React.Node {\n<ul>\n<li>\n<p className={calendarNavClasses}>\n- <SWMansionIcon icon=\"calendar\" color=\"#fff\" size={24} ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [style app switcher] [2/n] toggle color on app switch
Summary: when clicking between apps (cal, chat) navigation toggles color both icon and text {F9202}
Test Plan: colors should toggle
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revi... |
129,179 | 20.01.2022 13:39:34 | 18,000 | b6a51ebd4377302ea61ff0b646445336bf742e78 | [web] [style app switcher] [3/n] style notification bell
Summary:
style notif bell on sidebar
{F9208}
{F9209}
Test Plan: have a notif, make sure it looks right
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "@@ -95,8 +95,10 @@ function AppSwitcher(): React.Node {\n</li>\n<li>\n<p className={chatNavClasses}>\n+ <span className={css.chatIconWrapper}>\n<SWMansionIcon icon=\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [style app switcher] [3/n] style notification bell
Summary:
style notif bell on sidebar
{F9208}
{F9209}
Test Plan: have a notif, make sure it looks right
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator... |
129,179 | 20.01.2022 13:51:49 | 18,000 | 5676b6ecfdea01004638ef317b4f606fe392ced9 | [web] [style app switcher] [4/n] space nav items
Summary: space nav items accordingly {F9232}
Test Plan: make sure they match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/sidebar.css",
"new_path": "web/sidebar/sidebar.css",
"diff": ".container ul {\nlist-style-type: none;\n+ padding-top: 24px;\n+ padding-left: 28px;\n}\n.container ul li {\ncursor: pointer;\n+ padding-bottom: 24px;\n+ line-height: 0;\n+}\n+\n+.contai... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [style app switcher] [4/n] space nav items
Summary: space nav items accordingly {F9232}
Test Plan: make sure they match figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2897 |
129,179 | 20.01.2022 15:35:20 | 18,000 | 1c461c79b72cbb16416c41d1adb30e4a6ad10d1e | [web] [2/n] [style chat tabs] add icons
Summary: add swm icons to tab switcher, layout styles coming in future diffs {F9254}
Test Plan: icons should render like the screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.react.js",
"new_path": "web/chat/chat-tabs.react.js",
"diff": "@@ -42,11 +42,13 @@ function ChatTabs(props: Props): React.Node {\ntitle=\"Focus\"\ntabIsActive={activeTab === 'Focus'}\nonClick={onClickHome}\n+ icon=\"message-square-lines\"\n/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [2/n] [style chat tabs] add icons
Summary: add swm icons to tab switcher, layout styles coming in future diffs {F9254}
Test Plan: icons should render like the screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://p... |
129,179 | 20.01.2022 16:16:53 | 18,000 | fc1e458219c0d9f939fa32f61e9ffb88153efc39 | [web] [3/n] [style chat tabs] add spacing to chat tabs
Summary: add correct spacing. I accidentally added the wrong icon. {F9260}
Test Plan: make sure it looks like the figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -17,12 +17,19 @@ div.tabs {\n}\ndiv.tabItem {\n- flex: 1;\n- display: inline-block;\n- padding: 0.5rem 0.75rem;\n+ display: flex;\n+ justify-content: center;\n+ width: 50%;\n+ padding: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [3/n] [style chat tabs] add spacing to chat tabs
Summary: add correct spacing. I accidentally added the wrong icon. {F9260} https://linear.app/comm/issue/ENG-556/update-chat-tabs-with-the-correct-icon
Test Plan: make sure it looks like the figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers:... |
129,191 | 19.01.2022 16:40:45 | -3,600 | 7737291460d3b3a9c8fc1b5fe172cfcb0fab721f | [CommCoreModule] Remove notification from the center
Summary: When a CLEAR notification is received, we search for a notification and clear it in the notifications center
Test Plan: This diff was tested with the next diff
Reviewers: karol-bisztyga, marcinwasowicz, ashoat
Subscribers: benschac, ashoat, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/AppDelegate.mm",
"new_path": "native/ios/Comm/AppDelegate.mm",
"diff": "@@ -57,6 +57,8 @@ static void InitializeFlipper(UIApplication *application) {\n#import <RNReanimated/REAEventDispatcher.h>\n#import <RNReanimated/REAModule.h>\n+#import <Us... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Remove notification from the center
Summary: When a CLEAR notification is received, we search for a notification and clear it in the notifications center
Test Plan: This diff was tested with the next diff
Reviewers: karol-bisztyga, marcinwasowicz, ashoat
Reviewed By: karol-bisztyga, ashoat
Subscri... |
129,179 | 27.01.2022 07:42:57 | 18,000 | 882f4366eda7507b8b8e08932d0452c34fcaea66 | [web] [refactor] move modal styles to its own file
Summary: move styles to it's own file because I need to update modal styles in upcoming diffs {F10102}
Test Plan: make sure styles still render on page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/modal.css",
"diff": "+div.modal-overlay {\n+ position: fixed;\n+ left: 0;\n+ top: 0;\n+ bottom: 0;\n+ z-index: 4;\n+ width: 100%;\n+ background-color: rgba(0, 0, 0, 0.4);\n+ display: flex;\n+ flex-direction: column;\n+ align-items: ce... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] move modal styles to its own file
Summary: move styles to it's own file because I need to update modal styles in upcoming diffs {F10102}
Test Plan: make sure styles still render on page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differ... |
129,179 | 27.01.2022 08:31:42 | 18,000 | 20477fadef6e5bc31fdcb4f425260c9f29ae0a38 | [web] [fix] Comm header aligned correctly per figma
Summary: Header left-padding match figma {F9890}
Test Plan: should look like figma {F9891}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -78,7 +78,7 @@ div.main-header {\n}\ndiv.main-header > h1 {\ncolor: var(--fg);\n- padding: 0 6px;\n+ padding-left: 92px;\nfont-family: var(--font-logo);\nline-height: var(--line-height-text);\nfont-weigh... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] Comm header aligned correctly per figma
Summary: Header left-padding match figma {F9890}
Test Plan: should look like figma {F9891} https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1272%3A88750
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm... |
129,179 | 27.01.2022 08:35:48 | 18,000 | 7eba76f03f4654b9843d961376a3e704848e7a3d | [web] [docs] add a comment on how to use colors in the theme.css file
Summary: short comment to reduce diff review churn on new theme'ing concept
Test Plan: make sure the comment makes sense
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": ":root {\n+ /* Never use color values defined here directly in CSS. Add color variables to \"Color Theme\" below\n+\n+ The reason we never use color values defined here directly in CSS is\n+\n+ 1. It makes c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [docs] add a comment on how to use colors in the theme.css file
Summary: short comment to reduce diff review churn on new theme'ing concept
Test Plan: make sure the comment makes sense
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revis... |
129,179 | 27.01.2022 08:41:35 | 18,000 | 267f2f4945577f4cea698593c382c0dd6b420e4d | [web] swap out font icon for software mansion icon in menu button
Summary: change menu icon to match figma {F10134}
Test Plan: It should render correctly
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.react.js",
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "// @flow\n-import { faEllipsisV } from '@fortawesome/free-solid-svg-icons';\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] swap out font icon for software mansion icon in menu button
Summary: change menu icon to match figma {F10134}
Test Plan: It should render correctly
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D... |
129,179 | 25.01.2022 14:02:30 | 18,000 | f8cb9cc0092c99d72bc67bfa9e39be703ed484da | [web] [1/n] add inbox icon
Summary:
add icon on sidebar. This is non-functional because we don't have community switcher {F9916}
Test Plan: make sure the page matches the figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.css",
"new_path": "web/sidebar/community-picker.css",
"diff": ".container {\ndisplay: flex;\nflex-direction: column;\n+ align-items: center;\nwidth: 84px;\nbackground: var(--community-bg);\n+ padding-top: 24px;\nborder-right: 1px s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [1/n] add inbox icon
Summary:
add icon on sidebar. This is non-functional because we don't have community switcher {F9916}
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77595
Test Plan: make sure the page matches the figma
Reviewers: atul, ashoat
Reviewed By: atul, ash... |
129,179 | 25.01.2022 14:37:14 | 18,000 | 33811c7e7c2b3c48cd7b3feb716de01b26dd13b5 | [web] [2/n] add settings gear icon to community switcher
Summary: add settings gear button {F9928}
Test Plan: should look like figma, button doesn't do anything yet
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.css",
"new_path": "web/sidebar/community-picker.css",
"diff": "align-items: center;\nwidth: 84px;\nbackground: var(--community-bg);\n- padding-top: 24px;\n+ padding: 24px 0 32px 0;\nborder-right: 1px solid var(--border-color);\n+ f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [2/n] add settings gear icon to community switcher
Summary: add settings gear button {F9928}
Test Plan: should look like figma, button doesn't do anything yet
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.a... |
129,179 | 25.01.2022 16:22:34 | 18,000 | 995e56fe6331c6e5b8505404766b317bbe00b8be | [web] [4/n] show user modal on settings gear click
Summary: on click, user should be show modal {F9962}
Test Plan: click modal
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -35,7 +35,7 @@ import FocusHandler from './redux/focus-handler.react';\nimport { useSelector } from './redux/redux-utils';\nimport VisibilityHandler from './redux/visibility-handler.react';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [4/n] show user modal on settings gear click
Summary: on click, user should be show modal {F9962}
Test Plan: click modal
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2929 |
129,179 | 25.01.2022 16:32:43 | 18,000 | 905cb8530664bd301c604cd847c4fa9ce4b73f20 | [web] [5/n] remove account bar
Summary: remove account bar from header {F9956}
Test Plan: header and all css from the header are deleted. Functionality lives in bottom left gear icon
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "DELETE",
"old_path": "web/account-bar.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import invariant from 'invariant';\n-import * as React from 'react';\n-\n-import { preRequestUserStateSelector } from 'lib/selectors/account-selectors';\n-import type { PreRequestUserState } ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [5/n] remove account bar
Summary: remove account bar from header {F9956}
Test Plan: header and all css from the header are deleted. Functionality lives in bottom left gear icon
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: htt... |
129,179 | 26.01.2022 08:26:21 | 18,000 | d24ac0f154c2feaf5e2b338c96f5b6c7e1a7dbc0 | [web] [refactor] destructure props in user settings modal render
Summary: touching the render / styles. Wanted to clean up the render and make it consistent with the project
Test Plan: make sure functionality isn't broken.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -39,14 +39,14 @@ type TabProps = {\n};\nclass Tab extends React.PureComponent<TabProps> {\nrender() {\n+ const { selected, name, tabTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] destructure props in user settings modal render
Summary: touching the render / styles. Wanted to clean up the render and make it consistent with the project
Test Plan: make sure functionality isn't broken.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, ka... |
129,179 | 26.01.2022 13:31:42 | 18,000 | 4e25167dc4eb994b57954c19844094d09e7db556 | [web] [refactor] side bar thread list props destructure
Summary: update props to match project
Test Plan: make sure app still renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-sidebar.react.js",
"new_path": "web/chat/chat-thread-list-sidebar.react.js",
"diff": "@@ -14,13 +14,14 @@ type Props = {\n+sidebarInfo: SidebarInfo,\n};\nfunction ChatThreadListSidebar(props: Props): React.Node {\n- const { threadInfo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] side bar thread list props destructure
Summary: update props to match project
Test Plan: make sure app still renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2942 |
129,179 | 26.01.2022 09:44:09 | 18,000 | bd7d3aea7e6a462b6968126f987567af99dd6a76 | [web] [modal] update color theme
Summary:
color matches figma
{F10343}
Test Plan: Color swatch is correct, design still isn't there. Just wanted the modal to not look super off
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.css",
"new_path": "web/modals/account/user-settings-modal.css",
"diff": "@@ -2,7 +2,7 @@ div.modal-body {\npadding: 6px 6px;\nwidth: 100%;\nbox-sizing: border-box;\n- background-color: white;\n+ background-color: var(--mo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [modal] update color theme
Summary:
color matches figma
{F10343}
Test Plan: Color swatch is correct, design still isn't there. Just wanted the modal to not look super off
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://... |
129,184 | 28.01.2022 15:09:13 | 18,000 | 5cc74a41fb1e75f483c641680af8772545458841 | [CommCoreModule] Modify `NetworkModule::sendPong()` to actually send pong
Summary: Also modify `networkClient:sendPong()` to log any error instead of crashing app if the gRPC endpoint isn't accessible.
Test Plan: Able to send a pong
Reviewers: palys-swm, varun, def-au1t, ashoat
Subscribers: benschac, ashoat, Adrian, ka... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"diff": "@@ -20,10 +20,10 @@ void NetworkModule::initializeNetworkModule(\n}\nvoid NetworkModule::sendPon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Modify `NetworkModule::sendPong()` to actually send pong
Summary: Also modify `networkClient:sendPong()` to log any error instead of crashing app if the gRPC endpoint isn't accessible.
Test Plan: Able to send a pong
Reviewers: palys-swm, varun, def-au1t, ashoat
Reviewed By: palys-swm, ashoat
Subsc... |
129,179 | 29.01.2022 10:37:51 | 18,000 | 1ccf3160c535debe64aae163640cb4f82c93fa73 | [web] import shared css in login modal
Summary: didn't realize login modal code was shared with user settings. Changing the import {F10444}
Test Plan: make sure the css is rendering
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-modal.react.js",
"new_path": "web/modals/account/log-in-modal.react.js",
"diff": "@@ -23,8 +23,8 @@ import {\nimport { useSelector } from '../../redux/redux-utils';\nimport { webLogInExtraInfoSelector } from '../../selectors/account-s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] import shared css in login modal
Summary: didn't realize login modal code was shared with user settings. Changing the import {F10444}
Test Plan: make sure the css is rendering
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: http... |
129,179 | 29.01.2022 10:40:08 | 18,000 | 38d4dbec75e2aa14f95a2badfd34148571f85b0b | [web] add plus to icon set
Summary: forgot to add plus icon to icomoon {F10392}
Test Plan: everything should work as before with icons
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 30,\n+ \"paths\": [\"M512 42.645v938.717M42.645 512h938.717\"],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add plus to icon set
Summary: forgot to add plus icon to icomoon {F10392}
Test Plan: everything should work as before with icons
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2957 |
129,179 | 29.01.2022 10:51:23 | 18,000 | 1792446893b003dd0ab2ace20b8146d1dff35d49 | [web] [splash] SquadCal --> Comm
Summary: Remove Comm
Test Plan: N/A, squadcal should be gone
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/splash/splash.react.js",
"new_path": "web/splash/splash.react.js",
"diff": "@@ -89,7 +89,7 @@ class Splash extends React.PureComponent<Props, State> {\n<div className={css.top}>\n<header className={css.header}>\n<div className={css.headerContents}>\n- <h1>... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [splash] SquadCal --> Comm
Summary: Remove Comm
Test Plan: N/A, squadcal should be gone
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2962 |
129,179 | 29.01.2022 18:48:02 | 18,000 | d519abe338082e5cb55e766b7585c1391edc7aa5 | [native] [lib] move ancestor threads to hook in lib/shared
Summary: moving this function to a hook so we can re-use it in web
Test Plan: make sure ancestor thread labels are still working on native
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/shared/ancestor-threads.js",
"diff": "+// @flow\n+\n+import genesis from '../facts/genesis';\n+import {\n+ threadInfoSelector,\n+ ancestorThreadInfos,\n+} from '../selectors/thread-selectors';\n+import { threadIsPending } from '../shared/thr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [lib] move ancestor threads to hook in lib/shared
Summary: moving this function to a hook so we can re-use it in web
Test Plan: make sure ancestor thread labels are still working on native
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revi... |
129,179 | 30.01.2022 20:57:17 | 18,000 | fdec2d16616e49f66573c9892060c683e33ff658 | [native] [refactor] remove null path check
Summary: array never doesn't exist. This condition will never be met.
Test Plan: make sure ancestor threads still work.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-ancestors-label.react.js",
"new_path": "native/components/thread-ancestors-label.react.js",
"diff": "@@ -48,10 +48,6 @@ function ThreadAncestorsLabel(props: Props): React.Node {\nreturn unread ? [styles.pathText, styles.unread] : style... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [refactor] remove null path check
Summary: array never doesn't exist. This condition will never be met.
Test Plan: make sure ancestor threads still work.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.co... |
129,187 | 30.01.2022 16:21:36 | 18,000 | 750c842f82a0ffced457a6bca26b7ec022900e1d | [RN0.66] 13/n: Flow version upgrade
Summary: Fixes for type errors will follow in other diffs.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/.flowconfig",
"new_path": "landing/.flowconfig",
"diff": "[options]\nmodule.name_mapper.extension='css' -> '<PROJECT_ROOT>/flow/CSSModule.js.flow'\n-esproposal.optional_chaining=enable\n-esproposal.nullish_coalescing=enable\nexact_by_default=true\n+for... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 13/n: Flow version upgrade
Summary: Fixes for type errors will follow in other diffs.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2992 |
129,187 | 30.01.2022 21:14:33 | 18,000 | 12a04910e6bc95ed2348c411e994c1113908b1b9 | [RN0.66] 15/n: Update to
Summary: The old one has a `jcenter` dependency that no longer works.
Test Plan: Built and ran the whole stack on iOS and Android across various architectures
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -741,7 +741,7 @@ PODS:\n- React-jsinspector (0.66.4)\n- React-logger (0.66.4):\n- glog\n- - react-native-background-upload (5.6.0):\n+ - react-native-background-upload (6.5.1):\n- Rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 15/n: Update to react-native-background-uploader@6.5.1
Summary: The old one has a `jcenter` dependency that no longer works.
Test Plan: Built and ran the whole stack on iOS and Android across various architectures
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-biszt... |
129,187 | 30.01.2022 22:25:43 | 18,000 | 88d61c73194ddf122b041d55514dee9c2c39f0eb | [RN0.66] 19/n: Fix lodash/fp maxBy type
Summary: Flow fails to recognize the single-parameter variant when it's specified first. The variant with more parameters should always be specified first.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/flow-typed/npm/lodash_v4.x.x.js",
"new_path": "lib/flow-typed/npm/lodash_v4.x.x.js",
"diff": "@@ -2880,8 +2880,8 @@ declare module \"lodash/fp\" {\ndivide(dividend: number, divisor: number): number;\nfloor(number: number): number;\nmax<T>(array: $ReadOnlyA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 19/n: Fix lodash/fp maxBy type
Summary: Flow fails to recognize the single-parameter variant when it's specified first. The variant with more parameters should always be specified first.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differ... |
129,187 | 30.01.2022 22:38:13 | 18,000 | 31eec30a4aa1b882d6ea9f2ffba1b9d638f76080 | [RN0.66] 21/n: Fix type error in makePermissionsBlob
Summary: The type of `ThreadPermissionInfo` is very particular that `source` can only be non-null if `value` is `true`.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/permissions/thread-permissions.js",
"new_path": "lib/permissions/thread-permissions.js",
"diff": "@@ -5,6 +5,7 @@ import {\ntype ThreadType,\ntype ThreadPermission,\ntype ThreadRolePermissionsBlob,\n+ type ThreadPermissionInfo,\ntype ThreadPermissionsInfo,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 21/n: Fix type error in makePermissionsBlob
Summary: The type of `ThreadPermissionInfo` is very particular that `source` can only be non-null if `value` is `true`.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https:... |
129,187 | 30.01.2022 22:58:02 | 18,000 | d74f26559c9486860c1e25485e9680e779963701 | [RN0.66] 23/n: Move imports into module declarations for redux-devtools-extension
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/flow-typed/npm/redux-devtools-extension_v2.x.x.js",
"new_path": "web/flow-typed/npm/redux-devtools-extension_v2.x.x.js",
"diff": "// flow-typed signature: dde9329b5d39c60765e23c080dc5d018\n// flow-typed version: 9931c6ffb0/redux-devtools-extension_v2.x.x/f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 23/n: Move imports into module declarations for redux-devtools-extension
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator... |
129,187 | 30.01.2022 23:30:08 | 18,000 | 0451e9b720e57396f2619a3e544019ed04fbd5e8 | [RN0.66] 24/n: Move imports into module declarations for webpack
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/flow-typed/npm/webpack_v4.x.x.js",
"new_path": "web/flow-typed/npm/webpack_v4.x.x.js",
"diff": "// flow-typed signature: 249ddfcae5dfea268feb3f85fbd35f97\n// flow-typed version: d14eb225e8/webpack_v4.x.x/flow_>=v0.71.x <=v0.103.x\n-import * as http from 'h... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 24/n: Move imports into module declarations for webpack
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3003 |
129,187 | 30.01.2022 23:39:20 | 18,000 | 42b661c2fb7f27ffb4b5d180c5a7f3dcfd77874b | [RN0.66] 26/n: Use arrow function for web Entry's updateHeight
Summary: Flow doesn't want to see `this.memberFunction.bind` anymore, it seems. Fair enough...
Test Plan: Flow
Reviewers: benschac, palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/entry.react.js",
"new_path": "web/calendar/entry.react.js",
"diff": "@@ -150,14 +150,14 @@ class Entry extends React.PureComponent<Props, State> {\nthis.mounted = false;\n}\n- updateHeight() {\n+ updateHeight: () => void = () => {\ninvariant(\nthi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 26/n: Use arrow function for web Entry's updateHeight
Summary: Flow doesn't want to see `this.memberFunction.bind` anymore, it seems. Fair enough...
Test Plan: Flow
Reviewers: benschac, palys-swm, atul
Reviewed By: benschac, palys-swm
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://pha... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.