author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 30.01.2022 23:44:57 | 18,000 | c006173deed1ac5d5ac1f1760126365680ef8210 | [RN0.66] 27/n: Move imports into module declarations for body-parser
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac | [
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/body-parser_v1.x.x.js",
"new_path": "server/flow-typed/npm/body-parser_v1.x.x.js",
"diff": "// flow-typed signature: bac0ee66e0653772d037dc47b51a5e1f\n// flow-typed version: da30fe6876/body-parser_v1.x.x/flow_>=v0.25.x\n+declare module \"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 27/n: Move imports into module declarations for body-parser
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac
Differential Revision: https://phabricator.ashoat.com/D3006 |
129,187 | 30.01.2022 23:52:53 | 18,000 | c837d8c799c0ec20577db36bdcca0954ae227e2e | [RN0.66] 29/n: Fix ws type compatibility with events$EventEmitter type
Summary: See [here](https://github.com/facebook/flow/blob/main/lib/node.js); the `on` function must be able to take any kind of `string` to be compatible.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/ws_v7.x.x.js",
"new_path": "server/flow-typed/npm/ws_v7.x.x.js",
"diff": "@@ -99,6 +99,11 @@ declare class ws$WebSocketServer extends events$EventEmitter {\n*/\non(event: 'listening', () => mixed): this;\n+ /**\n+ * Included for compatibi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 29/n: Fix ws type compatibility with events$EventEmitter type
Summary: See [here](https://github.com/facebook/flow/blob/main/lib/node.js); the `on` function must be able to take any kind of `string` to be compatible.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, ... |
129,187 | 31.01.2022 00:12:23 | 18,000 | fce41a055b52c2e2d651851d02692b8fbb87b090 | [RN0.66] 30/n: Fix UserInfo types on server
Summary: The new version of Flow caught some type errors here. We were using `AccountUserInfo` (username cannot be `null`) when in fact we were returning `UserInfo` (username can be `null`).
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -10,7 +10,7 @@ import type {\n} from './message-types';\nimport type { ThreadSubscription } from './subscription-types';\nimport type { ServerUpdateInfo, ClientUpdateInfo } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 30/n: Fix UserInfo types on server
Summary: The new version of Flow caught some type errors here. We were using `AccountUserInfo` (username cannot be `null`) when in fact we were returning `UserInfo` (username can be `null`).
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: b... |
129,187 | 31.01.2022 00:31:18 | 18,000 | d6a162410eb1b3612049154abb82ef9960078505 | [RN0.66] 32/n: Fix type mismatch in updateAndReloadGeoipDB
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron/update-geoip-db.js",
"new_path": "server/src/cron/update-geoip-db.js",
"diff": "@@ -62,7 +62,7 @@ async function updateAndReloadGeoipDB(): Promise<void> {\nreturn;\n}\nfor (const id in cluster.workers) {\n- cluster.workers[id].send(reloadMessag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 32/n: Fix type mismatch in updateAndReloadGeoipDB
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3011 |
129,187 | 31.01.2022 02:09:14 | 18,000 | c71dbcd9649d2a450e39e063925450fa2944e758 | [RN0.66] 37/n: Fix type of generic TextInput component
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/components/text-input.react.js",
"new_path": "native/components/text-input.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { TextInput as BaseTextInput } from 'react-native';\n+import { TextInput } from 'react-native';\nimport { u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 37/n: Fix type of generic TextInput component
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3018 |
129,187 | 31.01.2022 02:13:50 | 18,000 | 29d706fe3680b9bf6f3d21ed924f0f6b782a919a | [RN0.66] 38/n: Fix function unbound from context Flow error across native FlatLists
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -509,10 +509,10 @@ class Calendar extends React.PureComponent<Props, State> {\ninvariant(false, 'keyExtractor conditions should be exhaustive');\n};\n- static getI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 38/n: Fix function unbound from context Flow error across native FlatLists
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com... |
129,187 | 31.01.2022 02:16:05 | 18,000 | 824d7824efdcf2d66ecd0fb35aa5bfd8947854ef | [RN0.66] 39/n: Fix KeyboardInputHost BaseProps type
Summary:
`ChatInputBar` can render `KeyboardInputHost` with a `textInputRef` set to `null`.
This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/keyboard/keyboard-input-host.react.js",
"new_path": "native/keyboard/keyboard-input-host.react.js",
"diff": "@@ -15,7 +15,7 @@ import { useStyles } from '../themes/colors';\nimport { type KeyboardState, KeyboardContext } from './keyboard-state';\ntype B... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 39/n: Fix KeyboardInputHost BaseProps type
Summary:
`ChatInputBar` can render `KeyboardInputHost` with a `textInputRef` set to `null`.
This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
D... |
129,187 | 31.01.2022 02:23:25 | 18,000 | d96a67373f912a779c53de86886d442bc2022d8a | [RN0.66] 40/n: Fix FlatList type in ChatList
Summary: This type error was caught as part of the Flow upgrade. Managed to remove a `$FlowFixMe` too!
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -11,10 +11,6 @@ import {\nTouchableWithoutFeedback,\nView,\n} from 'react-native';\n-import type {\n- Props as FlatListProps,\n- DefaultProps as FlatListDefaultProps,\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 40/n: Fix FlatList type in ChatList
Summary: This type error was caught as part of the Flow upgrade. Managed to remove a `$FlowFixMe` too!
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/... |
129,187 | 31.01.2022 02:33:46 | 18,000 | bf432e64a8960c2e294891cc50b2a4a8bc21e3ec | [RN0.66] 41/n: Patch Easing types
Summary: This is what Facebook did, so we'll do the same. It will be fixed in React Native 0.68 with [this patch](https://github.com/facebook/react-native/commit/851e87a1a6b4291b3e928b30185be18ac1079e0b).
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-b... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -247,6 +247,7 @@ class ChatList extends React.PureComponent<Props, State> {\ntoggleNewMessagesPill(show: boolean) {\nAnimated.timing(this.newMessagesPillProgress, {\n...... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 41/n: Patch Easing types
Summary: This is what Facebook did, so we'll do the same. It will be fixed in React Native 0.68 with [this patch](https://github.com/facebook/react-native/commit/851e87a1a6b4291b3e928b30185be18ac1079e0b).
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscriber... |
129,187 | 31.01.2022 02:54:02 | 18,000 | 26e284c31e7352331e85c7f7146867647f14a86a | [RN0.66] 42/n: Fix type of Search component
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/components/search.react.js",
"new_path": "native/components/search.react.js",
"diff": "@@ -25,7 +25,7 @@ type Props = {\n+active?: boolean,\n};\n-function ForwardedSearch(props: Props, ref: React.Ref<typeof BaseTextInput>) {\n+function ForwardedSearch(p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 42/n: Fix type of Search component
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3023 |
129,187 | 31.01.2022 03:07:39 | 18,000 | ab262673eef9e88b1785f40a1df9e21b4bfea78a | [RN0.66] 43/n: Fix KeyboardEvent type
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -29,7 +29,6 @@ import { fetchNewCookieFromNativeCredentials } from 'lib/utils/action-utils';\nimport KeyboardAvoidingView from '../components/keyboar... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 43/n: Fix KeyboardEvent type
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3024 |
129,187 | 31.01.2022 03:11:34 | 18,000 | e9469f4cfa8ef6fbcadcd1d7dbfd37d747278814 | [RN0.66] 44/n: Fix EventSubscription type
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -44,7 +44,7 @@ import {\nderivedDimensionsInfoSelector,\n} from '../selectors/dimensions-selectors';\nimport { splashStyleSelector } from '../splash'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 44/n: Fix EventSubscription type
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3025 |
129,187 | 31.01.2022 03:13:00 | 18,000 | 7a208aef32028e2ed4bab1bb587069cf134cff47 | [RN0.66] 45/n: Fix event.startCoordinates check in LoggedOutModal
Summary: Turns out that `event.startCoordinates` is only available on iOS, and Flow caught this. We should check before making the comparison here (should be a no-op).
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-biszty... | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -415,7 +415,10 @@ class LoggedOutModal extends React.PureComponent<Props, State> {\n}\nkeyboardShow = (event: KeyboardEvent) => {\n- if (_isEqual(eve... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 45/n: Fix event.startCoordinates check in LoggedOutModal
Summary: Turns out that `event.startCoordinates` is only available on iOS, and Flow caught this. We should check before making the comparison here (should be a no-op).
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: be... |
129,187 | 31.01.2022 03:23:22 | 18,000 | 31a55d6747cc550f76099cb39e1e94444fef7461 | [RN0.66] 46/n: Fix LifecycleEventEmitter types
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac | [
{
"change_type": "MODIFY",
"old_path": "native/lifecycle/lifecycle-event-emitter.js",
"new_path": "native/lifecycle/lifecycle-event-emitter.js",
"diff": "@@ -8,7 +8,7 @@ import * as TurboModuleRegistry from 'react-native/Libraries/TurboModule/TurboMo\nimport type { LifecycleState } from 'lib/types/l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 46/n: Fix LifecycleEventEmitter types
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac
Differential Revision: https://phabricator.ashoat.com/D3027 |
129,187 | 31.01.2022 05:52:49 | 18,000 | a96d76144150d88765b40c130a194456137e7cbb | [docs] Remove php7_module from httpd.conf module list
Summary: It's not available on new versions of macOS anyways.
Test Plan: I walked through these instructions today
Reviewers: atul, palys-swm
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "docs/dev_environment.md",
"new_path": "docs/dev_environment.md",
"diff": "@@ -353,7 +353,6 @@ LoadModule proxy_module libexec/apache2/mod_proxy.so\nLoadModule proxy_http_module libexec/apache2/mod_proxy_http.so\nLoadModule proxy_wstunnel_module libexec/apache2... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docs] Remove php7_module from httpd.conf module list
Summary: It's not available on new versions of macOS anyways.
Test Plan: I walked through these instructions today
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.... |
129,184 | 29.01.2022 15:05:25 | 18,000 | a3a57f69edb29084851ab27c1fecf4cb56c97bbb | [CommCoreModule] Implement `Client::send`
Summary: Filled out this boilerplate to communicate with dummy gRPC node server
Test Plan:
Was able to send stuff and see it on the other side
{F9982}
Reviewers: palys-swm, def-au1t, varun, karol-bisztyga, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"diff": "@@ -26,4 +26,17 @@ void NetworkModule::sendPong() {\nvoid NetworkModule::close() {\nthis->networ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Implement `Client::send`
Summary: Filled out this boilerplate to communicate with dummy gRPC node server
Test Plan:
Was able to send stuff and see it on the other side
{F9982}
Reviewers: palys-swm, def-au1t, varun, karol-bisztyga, ashoat
Reviewed By: palys-swm, karol-bisztyga, ashoat
Subscribers:... |
129,179 | 31.01.2022 13:42:58 | 18,000 | 9ce6b17f3c5868b1648cd8e8533cc4f7d54fa6c1 | [native] [refactor] remove unneed unread prop in thread ancestor
Summary: threadInfo has unread in it which is being passed down already
Test Plan: confirm unread functionality still works as expected.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -134,10 +134,7 @@ function ChatThreadListItem({\n<ColorSplotch color={data.threadInfo.color} size=\"profile\" />\n</View>\n<View style={styles.th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [refactor] remove unneed unread prop in thread ancestor
Summary: threadInfo has unread in it which is being passed down already
Test Plan: confirm unread functionality still works as expected.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differe... |
129,179 | 31.01.2022 16:45:50 | 18,000 | 92ef4cde7ede2bf4b6134f1fe5a3ed673c1fe5b5 | [web] swap font awesome plus for swm icon
Summary: use plus from swm per the design {F10398}
Test Plan: make sure icon renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -37,6 +37,9 @@ div.joinButtonContainer > a {\njustify-content: center;\ncursor: pointer;\n}\n+div.joinButtonContainer > a svg {\n+ color: var(--fg);\n+}\nspan.joinButtonText {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] swap font awesome plus for swm icon
Summary: use plus from swm per the design {F10398}
Test Plan: make sure icon renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2958 |
129,179 | 31.01.2022 17:28:58 | 18,000 | 7e16d29bddf6df127496392a2cd31bb13f8155ee | [web] fix bug safari thread menu icons positioned incorrectly
Summary:
on safari, there was a visual regression
Before: {F11351}
After: {F11350}
Test Plan: make sure browsers are consistent
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -112,7 +112,7 @@ div.sidebar .menu > button svg {\n.menu {\nposition: relative;\ndisplay: flex;\n- justify-content: end;\n+ justify-content: flex-end;\n}\n.menu > button {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] fix bug safari thread menu icons positioned incorrectly
Summary:
on safari, there was a visual regression
Before: {F11351}
After: {F11350}
https://stackoverflow.com/questions/54654050/difference-between-flex-end-and-end
Test Plan: make sure browsers are consistent
Reviewers: atul, ashoat
Reviewed By: ashoat
... |
129,179 | 31.01.2022 18:09:25 | 18,000 | f22f5052dcc2862fc963e0b38b3360b23a87b5cb | [web] [move] settings button from settings --> components
Summary: move button to shared components file follow up with re-name
Test Plan: N/A
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "RENAME",
"old_path": "web/sidebar/settings-button.css",
"new_path": "web/components/settings-button.css",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "web/sidebar/settings-button.react.js",
"new_path": "web/components/settings-button.react.js",
"diff": ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [move] settings button from settings --> components
Summary: move button to shared components file follow up with re-name
Test Plan: N/A
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3040 |
129,179 | 31.01.2022 18:10:55 | 18,000 | 05e26115d33f543cc42ee8d1cb6ccd61d7f8592c | [web] [rename] settings button --> button
Summary: change name from settings button --> button
Test Plan: N/A make sure nothing breaks
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "RENAME",
"old_path": "web/components/settings-button.css",
"new_path": "web/components/button.css",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "web/components/settings-button.react.js",
"new_path": "web/components/button.react.js",
"diff": "import clas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [rename] settings button --> button
Summary: change name from settings button --> button
Test Plan: N/A make sure nothing breaks
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3041 |
129,179 | 01.02.2022 08:03:26 | 18,000 | e168e9eb9126e3e4c3a57f23e22e8604c4ae8d3b | [web] create an input component
Summary: create generic input component
Test Plan: N/A its not used anywhere yet
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/input.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+type Props = {\n+ +type: string,\n+ +placeholder: string,\n+ +value: string,\n+ +onChange: (value: SyntheticEvent<HTMLInputElement>) => mixed,\n+ +disabled:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] create an input component
Summary: create generic input component
Test Plan: N/A its not used anywhere yet
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2964 |
129,179 | 01.02.2022 09:03:38 | 18,000 | d0fe8c657f58fd6b0cc45dd67dbcfeb4a2666496 | [web] replace html input modals with Input component
Summary:
replace input elements with components, will style inputs in the next diff.
{F11113}
{F11114}
Test Plan: make sure input forms work as expected in login / usersettings / delete
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-modal.react.js",
"new_path": "web/modals/account/log-in-modal.react.js",
"diff": "@@ -23,6 +23,7 @@ import {\nimport { useSelector } from '../../redux/redux-utils';\nimport { webLogInExtraInfoSelector } from '../../selectors/account-s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] replace html input modals with Input component
Summary:
replace input elements with components, will style inputs in the next diff.
{F11113}
{F11114}
Test Plan: make sure input forms work as expected in login / usersettings / delete
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, pal... |
129,179 | 01.02.2022 09:07:40 | 18,000 | 6e4b1143d1de6f45075316840634ebf06593be54 | [web] add label to input component
Summary: add label for both design + accessability
Test Plan: everything should still work since the prop is optional
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/input.react.js",
"new_path": "web/modals/input.react.js",
"diff": "@@ -8,10 +8,23 @@ type Props = {\n+value: string,\n+onChange: (value: SyntheticEvent<HTMLInputElement>) => mixed,\n+disabled: boolean,\n+ +label?: string,\n+ id?: string,\n};\nfuncti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add label to input component
Summary: add label for both design + accessability https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
Test Plan: everything should still work since the prop is optional
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bi... |
129,179 | 03.02.2022 11:35:34 | 18,000 | f897d84eb4ed4d79ca4670706de93b028200e3b1 | [web] [refactor] move ternary out of rendered css class
Summary: remove ternary from render and class name
Test Plan: make sure highlight still works.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/sidebar-item.react.js",
"new_path": "web/chat/sidebar-item.react.js",
"diff": "@@ -24,15 +24,12 @@ function SidebarItem(props: Props): React.Node {\nconst lastActivity = shortAbsoluteDate(lastUpdatedTime, timeZone);\nconst { unread } = threadInfo.curr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] move ternary out of rendered css class
Summary: remove ternary from render and class name
Test Plan: make sure highlight still works.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D307... |
129,179 | 03.02.2022 13:44:27 | 18,000 | a639c3e550e52562f53f1b3f1baaf2e7192c1bb5 | [web] update icons from icomoon
Summary:
add icons, (long arrow right), edit chat bubble, bug
{F12013}
Test Plan: make sure icons still work correctly
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 31,\n+ \"paths\": [\n+ \"M34.133 887.467h-17.067v17.067h17.067v-17.067zM899.536 899.536c6.663-6.666 6.663-17.473 0-24.139l-108.612-108.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] update icons from icomoon
Summary:
add icons, (long arrow right), edit chat bubble, bug
{F12013}
Test Plan: make sure icons still work correctly
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D30... |
129,184 | 03.02.2022 20:52:43 | 18,000 | 95208a50de36a7d7b1c9f1b0ac5d7f7979478452 | [native] `codeVersion` -> 129 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -433,8 +433,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 129 |
129,179 | 03.02.2022 18:25:42 | 18,000 | e504fd23f89483129c896c236736f77d1a32ddf3 | [web] [fix] header word mark font
Summary:
we've been loading from google fonts this whole time. I removed it preemptively, re-adding the font
{F12417}
Test Plan: should work on prod now
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -51,7 +51,7 @@ const baseHref = baseDomain + baseURL;\nconst access = promisify(fs.access);\nconst googleFontsURL =\n- 'https://fonts.googleapi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] header word mark font
Summary:
we've been loading from google fonts this whole time. I removed it preemptively, re-adding the font
{F12417}
Test Plan: should work on prod now
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: http... |
129,184 | 03.02.2022 12:58:45 | 18,000 | d6b18aaeba2cb8698d8d6ea5a879843cebeec868 | [CommCoreModule] Split `ClientGetReadReactor` `.h` and `.cpp`
Summary: NA
Test Plan: Copy/paste/still builds
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga
Subscribers: Adrian, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"diff": "+#include \"ClientGetReadReactor.h\"\n+\n+ClientGetReadReactor::ClientGetReadReactor(\n+ tunnelbroker::TunnelbrokerService::Stub *stub,\n+ std::string sessionID)\n+ : sessionID{sessio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Split `ClientGetReadReactor` `.h` and `.cpp`
Summary: NA
Test Plan: Copy/paste/still builds
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga
Reviewed By: ashoat
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3094 |
129,179 | 07.02.2022 09:32:49 | 18,000 | 3409a2e59a4e989314df3f67c4491fae3a4ca86c | [web] [fix] input bar on multiline text input and image uploader
Summary: fixes current regression in web {F12649}
Test Plan: add multiline text, drag and drop image, upload image. It all should work
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -56,7 +56,7 @@ div.layout {\nheight: 100vh;\ndisplay: grid;\ngrid-template-columns: 244px repeat(12, 1fr);\n- grid-template-rows: 65px 1fr;\n+ grid-template-rows: 65px calc(100vh - 65px);\ngrid-template-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] input bar on multiline text input and image uploader
Summary: fixes current regression in web {F12649}
Test Plan: add multiline text, drag and drop image, upload image. It all should work
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Re... |
129,190 | 08.02.2022 10:51:18 | -3,600 | f12c9ef9a3533cb0579b4423da87336f69552ae8 | [services] Backup - add AWS Tools
Summary:
This is needed for the database manager added later
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -37,7 +37,7 @@ set(_GRPC_CPP_PLUGIN_EXECUTABLE $<TARGET_FILE:gRPC::grpc_cpp_plugin>)\nset(BUILD_TESTING OFF C... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - add AWS Tools
Summary:
This is needed for the database manager added later
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3080 |
129,190 | 08.02.2022 10:52:26 | -3,600 | 035dcc8fa6bedddb83fe8e83b223f5fa296b2a91 | [services] Backup - Database - add Item
Summary:
Parent class for all database items
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -62,6 +62,7 @@ endforeach()\ninclude_directories(\n./src\n+ ./src/DatabaseEntities\n./_generated\n${Boost_INC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Database - add Item
Summary:
Parent class for all database items
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3083 |
129,184 | 07.02.2022 08:09:02 | 18,000 | 3b8c3ee41ae5892170e805f4aaffd760c0aec6a8 | [CommCoreModule] Set `readyState` to `SocketStatus::CLOSED` on `ClientGetReadReactor::OnDone`
Summary: Set `readyState` to `3: CLOSED` once the `Get()` stream is closed.
Test Plan: Logged `readyState` and it was as expected
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga, jimpo
Subscribers: Adrian, bensch... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"new_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"diff": "@@ -53,3 +53,8 @@ void ClientGetReadReactor::OnReadInitialMetadataDone(bool ok) {\nstd::lock_guard<std::mutex> guard{this->setReadyS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Set `readyState` to `SocketStatus::CLOSED` on `ClientGetReadReactor::OnDone`
Summary: Set `readyState` to `3: CLOSED` once the `Get()` stream is closed.
Test Plan: Logged `readyState` and it was as expected
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga, jimpo
Reviewed By: ashoat, ka... |
129,184 | 07.02.2022 12:57:44 | 18,000 | 94cccc82926822e27cdf23c351cbae736e6e7fd8 | [CommCoreModule] Add `endpoint: string` arg to `CommCoreModule.openSocket()`
Summary:
Right now we're just hardcoding in `localhost`
[ignore: D3125]
Test Plan: Haven't tested with anything other than `localhost`... but continues to build/work as expected
Reviewers: ashoat, varun, def-au1t, karol-bisztyga, jimpo
Subscri... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -887,7 +887,8 @@ jsi::Value CommCoreModule::getUserOneTimeKeys(jsi::Runtime &rt) {\n});\n}\n-jsi::Object CommCoreModule::op... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Add `endpoint: string` arg to `CommCoreModule.openSocket()`
Summary:
Right now we're just hardcoding in `localhost`
[ignore: D3125]
Test Plan: Haven't tested with anything other than `localhost`... but continues to build/work as expected
Reviewers: ashoat, varun, def-au1t, karol-bisztyga, jimpo
Re... |
129,184 | 07.02.2022 15:21:12 | 18,000 | 10a6a24973e7cddf03a14dc1643526fb786e08ba | [CommCoreModule] Make `GRPCStreamHostObj.readyState` readonly
Summary: Shouldn't be able to set `readyState` from the JS side
Test Plan: NA, still builds as expected
Reviewers: ashoat, varun, karol-bisztyga, palys-swm, def-au1t, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp",
"new_path": "native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp",
"diff": "@@ -172,10 +172,7 @@ void GRPCStreamHostObject::set(\nconst jsi::Value &value) {\nauto propName = name.utf8(runtime);\n- if (propNam... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Make `GRPCStreamHostObj.readyState` readonly
Summary: Shouldn't be able to set `readyState` from the JS side
Test Plan: NA, still builds as expected
Reviewers: ashoat, varun, karol-bisztyga, palys-swm, def-au1t, jimpo
Reviewed By: ashoat
Subscribers: Adrian, benschac
Differential Revision: https:... |
129,184 | 06.02.2022 19:43:17 | 18,000 | a1375e4f3d073a68173f81f132ff1e03c4bc11f4 | [CommCoreModule] Set `readyState` to `SocketStatus::CLOSING` on call to `ClientGetReadReactor::close()`
Summary: We don't really distinguish between `2: CLOSING` and `3: CLOSED` in `lib/socket.react.js`, but don't think it hurts to add this here.
Test Plan: Logged readyState
Reviewers: ashoat, palys-swm, def-au1t, varu... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"new_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"diff": "@@ -22,6 +22,10 @@ void ClientGetReadReactor::OnReadDone(bool ok) {\n}\nvoid ClientGetReadReactor::close() {\n+ {\n+ std::lock_guard... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Set `readyState` to `SocketStatus::CLOSING` on call to `ClientGetReadReactor::close()`
Summary: We don't really distinguish between `2: CLOSING` and `3: CLOSED` in `lib/socket.react.js`, but don't think it hurts to add this here.
Test Plan: Logged readyState
Reviewers: ashoat, palys-swm, def-au1t, v... |
129,190 | 09.02.2022 09:24:15 | -3,600 | 6bdcf54ff77d454686e8e8c4eaf4966893ce1102 | [services] Backup - add constants
Summary:
Constant values for the backup service
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Constants.h",
"diff": "+#pragma once\n+\n+#include <string>\n+\n+namespace comm {\n+namespace network {\n+\n+// 4MB limit\n+// WARNING: use keeping in mind that grpc adds its own headers to messa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - add constants
Summary:
Constant values for the backup service
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3079 |
129,179 | 09.02.2022 09:48:05 | 18,000 | 7fb384d842c746b9a12773de04fdc867f76c3b65 | [web] [fix] icon regression thread item
Summary: move icon back to where it once was {F13091}
Test Plan: should look like screen shot and where it was once before
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/sidebar-item.react.js",
"new_path": "web/chat/sidebar-item.react.js",
"diff": "@@ -28,8 +28,8 @@ function SidebarItem(props: Props): React.Node {\nreturn (\n<a className={css.threadButton} onClick={onClick}>\n<div className={css.threadRow}>\n- <div cl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] icon regression thread item
Summary: move icon back to where it once was {F13091}
Test Plan: should look like screen shot and where it was once before
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ash... |
129,179 | 09.02.2022 09:52:44 | 18,000 | 0a8c046bee6be69c5dc1ab090ddfff2727e00d7c | [web] re-skin robo text
Summary: match figma more closely {F11967}
Test Plan:
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/robotext-message.css",
"new_path": "web/chat/robotext-message.css",
"diff": "div.robotextContainer {\ntext-align: center;\n- color: #333333;\n+ color: var(--fg);\npadding: 6px 0;\nmargin: 0 40px 5px 40px;\n- font-size: 15px;\n+ font-size: var(--s-font... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] re-skin robo text
Summary: match figma more closely {F11967}
Test Plan: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77198
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabrica... |
129,179 | 07.02.2022 11:40:17 | 18,000 | 891b4d0f11f01b9e2561eed537dc4470769381ed | [web] [refactor] thread-list-sidebar, active thread style to use classnames lib instead of ternary
Summary: use the classnames library rather than ternary.
Test Plan: Make sure active class still renders.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-sidebar.react.js",
"new_path": "web/chat/chat-thread-list-sidebar.react.js",
"diff": "@@ -18,9 +18,13 @@ function ChatThreadListSidebar(props: Props): React.Node {\nconst { threadInfo, mostRecentNonLocalMessage } = sidebarInfo;\nconst... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] thread-list-sidebar, active thread style to use classnames lib instead of ternary
Summary: use the classnames library rather than ternary.
Test Plan: Make sure active class still renders.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differenti... |
129,179 | 09.02.2022 10:15:47 | 18,000 | e6ae1375ea6cd5fcbad75c13986cd4d5d62baf5a | [web] [feat] thread menu button hoverable
Summary:
remove menu button for threads
updated with hover: {F13085}
note: arrow positioning updated in future diffs.
Test Plan: should render, look like screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -134,7 +134,12 @@ div.sidebar .menu > button svg {\nfont-size: 16px;\ncolor: var(--thread-color-read);\n}\n-\n+div.sidebar .menu {\n+ display: none;\n+}\n+div.sidebar:hove... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [feat] thread menu button hoverable
Summary:
remove menu button for threads
updated with hover: {F13085}
note: arrow positioning updated in future diffs.
Test Plan: should render, look like screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
... |
129,179 | 09.02.2022 10:21:17 | 18,000 | de6e7d38b1e484cccad6a3da89e934e6403ce93a | [web] re-skin timestamp in message component
Summary: match figma more closely {F11955}
Test Plan: match figma more closely
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -41,10 +41,9 @@ div.loading {\n}\ndiv.conversationHeader {\n- text-transform: uppercase;\ncolor: var(--chat-timestamp-color);\n- font-size: 14px;\n- padding: 7px 0;\n+ f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] re-skin timestamp in message component
Summary: match figma more closely {F11955} https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77595
Test Plan: match figma more closely
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bis... |
129,179 | 09.02.2022 10:32:04 | 18,000 | 48d8013dc7f6fef415a85b87ed1befb839e5368a | [web] [fix] Calendar is on two lines
Summary:
make calendar on one line
before: {F13166}
after: {F13165}
Test Plan: should look like screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -23,7 +23,7 @@ div.content {\nnav.nav {\ntext-align: center;\nmargin: 8px auto 12px auto;\n- width: 250px;\n+ width: 350px;\ncolor: #333333;\ndisplay: flex;\nalign-items: center;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] Calendar is on two lines
Summary:
make calendar on one line
before: {F13166}
after: {F13165}
Test Plan: should look like screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3141 |
129,185 | 09.02.2022 15:58:22 | -3,600 | 12859895cdf453ff96ca41a70d04d3ea3c4fba70 | [native] Use `useRelationshipPrompt` hook in `RelationshipPrompt`
Summary: Switch to newly introduced hook with native `RelationshipPrompt`.
Test Plan: The prompt behavior didn't change. Tested on virtual iOS device.
Reviewers: palys-swm, benschac, atul, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyg... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/relationship-prompt.react.js",
"new_path": "native/chat/relationship-prompt.react.js",
"diff": "// @flow\n-import invariant from 'invariant';\nimport * as React from 'react';\nimport { Alert, Text, View } from 'react-native';\nimport Icon from 'rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `useRelationshipPrompt` hook in `RelationshipPrompt`
Summary: Switch to newly introduced hook with native `RelationshipPrompt`.
Test Plan: The prompt behavior didn't change. Tested on virtual iOS device.
Reviewers: palys-swm, benschac, atul, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac,... |
129,185 | 09.02.2022 17:36:05 | -3,600 | e081976919951cdaf98e6ed3fb3bd47c13d377e7 | [lib] Create hooks for common `DisconnectedBar` logic for web and native
Summary: Created hooks with common logic for web and mobile app.
Test Plan: Tested the hooks on mobile and web (in the next diffs)
Reviewers: palys-swm, benschac, atul, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/hooks/disconnected-bar.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { useDispatch } from 'react-redux';\n+\n+import { updateDisconnectedBarActionType } from '../types/socket-types';\n+import { useSelector } from '../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Create hooks for common `DisconnectedBar` logic for web and native
Summary: Created hooks with common logic for web and mobile app.
Test Plan: Tested the hooks on mobile and web (in the next diffs)
Reviewers: palys-swm, benschac, atul, ashoat
Reviewed By: palys-swm, benschac, ashoat
Subscribers: ashoat, Adri... |
129,185 | 09.02.2022 17:36:06 | -3,600 | 7188146230ea693c3f573f8c74df200e0317d784 | [native] Use `DisconnectedBar` logic from hook
Summary: Used newly introduced hooks in native app.
Test Plan: The change was teted on virtual iOS device with different network conditions. I didn't observed any behavior change.
Reviewers: palys-swm, atul, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/disconnected-bar-visibility-handler.react.js",
"new_path": "native/navigation/disconnected-bar-visibility-handler.react.js",
"diff": "// @flow\n-import * as React from 'react';\n-import { useDispatch } from 'react-redux';\n-\n-import { update... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `DisconnectedBar` logic from hook
Summary: Used newly introduced hooks in native app.
Test Plan: The change was teted on virtual iOS device with different network conditions. I didn't observed any behavior change.
Reviewers: palys-swm, atul, benschac, ashoat
Reviewed By: palys-swm, ashoat
Subscribers:... |
129,179 | 09.02.2022 13:29:24 | 18,000 | ac4520661c2a8d657b9db20cc397b808d2ba20b6 | [web] remove user settings borders
Summary:
{F12119}
No more white lines, will not land without all the modal updates
Test Plan: remove user settings borders from modal
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.css",
"new_path": "web/modals/account/user-settings-modal.css",
"diff": "@@ -38,7 +38,6 @@ div.modal-body input[type='submit'] {\nfont-size: 12px;\nmargin-right: 3px;\nborder-radius: 3px;\n- border: 1px solid var(--border... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] remove user settings borders
Summary:
{F12119}
No more white lines, will not land without all the modal updates
Test Plan: remove user settings borders from modal
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabrica... |
129,184 | 08.02.2022 16:18:08 | 18,000 | e0c71c04d2fd549863a206494f1becac8ec1bcbc | [CommCoreModule] Fill out `sessionSignature(deviceID) => toSign` boilerplate in `Client`
Summary: So we can hit `SessionSignature(...)` endpoint
Test Plan: Hit `tunnelbroker` with request and see if we get a response
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"new_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"diff": "@@ -127,5 +127,18 @@ void Client::assignSetReadyStateCallback(\nthis->clientGetReadReactor->assignSetReadyStateCallback(callback);\n}\n+std::string Client::sess... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Fill out `sessionSignature(deviceID) => toSign` boilerplate in `Client`
Summary: So we can hit `SessionSignature(...)` endpoint
Test Plan: Hit `tunnelbroker` with request and see if we get a response
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga, jimpo
Reviewed By: ashoat, varun
Su... |
129,184 | 08.02.2022 16:39:29 | 18,000 | b0280f92d3bab65a214bde91ddfde96821d43af6 | [CommCoreModule] Fill out `newSession(...) => sessionID` boilerplate in `Client`
Summary: So we can hit `NewSession(...)` endpoint
Test Plan: Hit `tunnelbroker` with request and see if we get a response
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"new_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"diff": "@@ -140,5 +140,32 @@ std::string Client::sessionSignature(std::string deviceID) {\nreturn response.tosign();\n}\n+std::string Client::newSession(\n+ std::string... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Fill out `newSession(...) => sessionID` boilerplate in `Client`
Summary: So we can hit `NewSession(...)` endpoint
Test Plan: Hit `tunnelbroker` with request and see if we get a response
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga, jimpo
Reviewed By: ashoat, varun
Subscribers: Adr... |
129,179 | 09.02.2022 14:45:58 | 18,000 | e97e636c9ec81d93a6f1780a9d5dad2091b79a03 | [web] add thread arrow
Summary: add arrow {F12369}
Test Plan: make sure it renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-see-more-sidebars.react.js",
"new_path": "web/chat/chat-thread-list-see-more-sidebars.react.js",
"diff": "import classNames from 'classnames';\nimport * as React from 'react';\n-import DotsThreeHorizontal from 'react-entypo-icons/lib/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add thread arrow
Summary: add arrow {F12369}
Test Plan: make sure it renders
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3095 |
129,179 | 09.02.2022 15:19:16 | 18,000 | 63c137107764589f1e337c80c59296acaf2cb616 | [web] button add, disabled and onClick
Summary: add additional types to button
Test Plan: make sure types are correct
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -6,17 +6,27 @@ import * as React from 'react';\nimport css from './button.css';\ntype Props = {\n- +onClick: () => mixed,\n+ +onClick: (event: SyntheticEvent<HTMLButtonE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] button add, disabled and onClick
Summary: add additional types to button
Test Plan: make sure types are correct
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3093 |
129,179 | 09.02.2022 15:27:36 | 18,000 | aa5a009ee4d23615411be51ef8ff129f7d66fc25 | [web] add button primary variant
Summary:
add button primary
{F12121}
Test Plan: make sure button looks correct
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.css",
"new_path": "web/components/button.css",
"diff": "justify-content: center;\nbackground: var(--settings-btn-bg);\nborder-color: transparent;\n+ font-size: var(--m-font-16);\n+}\n+\n+.primary {\n+ background: var(--btn-bg-primary);\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add button primary variant
Summary:
add button primary
{F12121}
Test Plan: make sure button looks correct
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3091 |
129,179 | 09.02.2022 15:36:02 | 18,000 | 0fad46c8844300314586ef06ba8d333b6a147e31 | [web] use button component in user-settings modal
Summary: use button component. It's not styled just yet, just importing {F11858}
Test Plan: make sure buttons work, render. functionality doesn't break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.css",
"new_path": "web/modals/account/user-settings-modal.css",
"diff": "@@ -33,25 +33,6 @@ div.modal-body textarea {\ndiv.large-modal-container div.modal-body textarea {\nwidth: 275px;\n}\n-div.modal-body input[type='sub... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] use button component in user-settings modal
Summary: use button component. It's not styled just yet, just importing {F11858}
Test Plan: make sure buttons work, render. functionality doesn't break
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differe... |
129,179 | 09.02.2022 15:50:46 | 18,000 | 2972f61ef6e52f93449a4d66d04aa465db47ebf2 | [web] button secondary variant
Summary: add secondary variant to button {F11852}
Test Plan: should look like figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.css",
"new_path": "web/components/button.css",
"diff": "border-radius: 4px;\n}\n+.secondary {\n+ border: 1px solid var(--btn-secondary-border);\n+ padding: 12px 24px;\n+ color: var(--fg);\n+ background: var(--shades-black-90);\n+ border-r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] button secondary variant
Summary: add secondary variant to button {F11852}
Test Plan: should look like figma https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1313%3A99486
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
D... |
129,179 | 09.02.2022 15:56:00 | 18,000 | 89e7ea9669538dfa6cbc2aeab8583a8dd443a471 | [web] add danger button variant
Summary: add danger button, should match figma {F11884}
Test Plan: button should still work as expected
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.css",
"new_path": "web/components/button.css",
"diff": "background: var(--settings-btn-bg);\nborder-color: transparent;\nfont-size: var(--m-font-16);\n+ padding: 12px 24px;\n+ border-radius: 4px;\n}\n.primary {\nbackground: var(--btn-bg-p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add danger button variant
Summary: add danger button, should match figma {F11884} https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1060%3A60514
Test Plan: button should still work as expected
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adria... |
129,179 | 09.02.2022 16:00:01 | 18,000 | 5de555ac9bed87a9350ab7a16273248958941f7c | [web] add className prop to btn
Summary: add className prop to support styling from the parent component
Test Plan: N/A
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -11,10 +11,18 @@ type Props = {\n+variant?: 'primary' | 'secondary' | 'danger' | 'round',\n+type?: string,\n+disabled?: boolean,\n+ +className?: string,\n};\nfunction Bu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add className prop to btn
Summary: add className prop to support styling from the parent component
Test Plan: N/A
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3064 |
129,179 | 09.02.2022 16:08:48 | 18,000 | ae4a2601e7884430439230c8526cc63b3530eeaa | [web] [refactor] button classnames to be more terse
Summary: small refactor, buttons work the same
Test Plan: make sure buttons aren't busted
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -18,17 +18,12 @@ function Button(props: Props): React.Node {\nconst {\nonClick,\nchildren,\n- variant,\n+ variant = 'primary',\ntype,\ndisabled = false,\nclassName = '',... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] button classnames to be more terse
Summary: small refactor, buttons work the same
Test Plan: make sure buttons aren't busted
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3065 |
129,179 | 09.02.2022 16:16:00 | 18,000 | e3a5b8c7b86a9fd05455b4ba69deca2f26c72919 | [web] [fix] a login button to modal
Summary: add button component to login modal. more design work to be done soon {F13109}
Test Plan: make sure login still works
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-modal.react.js",
"new_path": "web/modals/account/log-in-modal.react.js",
"diff": "@@ -21,6 +21,7 @@ import {\nuseServerCall,\n} from 'lib/utils/action-utils';\n+import Button from '../../components/button.react';\nimport { useSelector... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] a login button to modal
Summary: add button component to login modal. more design work to be done soon {F13109}
Test Plan: make sure login still works
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ash... |
129,179 | 09.02.2022 16:28:16 | 18,000 | d40b754693a3fb9e1667b593fed30a1aee61d1a3 | [web] clean up modal design
Summary: clean up modal , interm. CSS as a whole needs work to get this a lot closer to the intended design.{F11969}
Test Plan: N/A, make sure modal still works.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.css",
"new_path": "web/modals/account/user-settings-modal.css",
"diff": "@@ -34,19 +34,15 @@ div.large-modal-container div.modal-body textarea {\nwidth: 275px;\n}\ndiv.modal-body p.confirm-account-password {\n- padding: 3... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] clean up modal design
Summary: clean up modal , interm. CSS as a whole needs work to get this a lot closer to the intended design.{F11969}
Test Plan: N/A, make sure modal still works.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revisi... |
129,179 | 10.02.2022 09:34:43 | 18,000 | 6a808278513c3a944f4ea5e1f1f301208cd7e923 | [web] [remove] no longer use "react-entypo-icons"
Summary: remove package, icons aren't used in the project
Test Plan: make sure app doesn't crash
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "\"react-dnd\": \"^11.1.3\",\n\"react-dnd-html5-backend\": \"^11.1.3\",\n\"react-dom\": \"17.0.2\",\n- \"react-entypo-icons\": \"^1.4.1\",\n\"react-feather\": \"^2.0.3\",\n\"react-hot-loader\": \"^4.12... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [remove] no longer use "react-entypo-icons"
Summary: remove package, icons aren't used in the project
Test Plan: make sure app doesn't crash
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3096 |
129,179 | 10.02.2022 09:37:43 | 18,000 | ae0985dee4bc941125634b4ad51ae900b371d370 | [web] [theme] you need permission, update theme, center content
Summary:
before: {F13156}
after: {F13155}
Test Plan: make sure it looks okay
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -63,9 +63,9 @@ p.joinButtonText {\npadding-left: 12px;\n}\nspan.explanation {\n- color: #777777;\n+ color: var(--permission-color);\ntext-align: center;\n- padding-top: 4px;\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [theme] you need permission, update theme, center content
Summary:
before: {F13156}
after: {F13155}
Test Plan: make sure it looks okay
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3140 |
129,184 | 09.02.2022 14:53:23 | 18,000 | 0ae429c073d6897430975dfc850b85f8f69d132d | [CommCoreModule] Add `sessionSignature` & `newSession` boilerplate to `NetworkModule`
Summary: NA, boilerplate (should've been squashed with previous `Client` diffs)
Test Plan: Continues to build, able to call
Reviewers: ashoat, def-au1t, varun, palys-swm, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"diff": "@@ -83,4 +83,32 @@ void NetworkModule::assignSetReadyStateCallback(\nthis->networkClient->assign... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Add `sessionSignature` & `newSession` boilerplate to `NetworkModule`
Summary: NA, boilerplate (should've been squashed with previous `Client` diffs)
Test Plan: Continues to build, able to call
Reviewers: ashoat, def-au1t, varun, palys-swm, karol-bisztyga, jimpo
Reviewed By: ashoat
Subscribers: Adr... |
129,184 | 09.02.2022 15:07:51 | 18,000 | 6441b1c3300b6d2138253780279331229a6d1701 | [CommCoreModule] Introduce `PlatformSpecificTools::getDeviceOS()`
Summary: We need `deviceOS` for `SessionSignature(...)` unary gRPC call
Test Plan: Call function and log result. Only tested on iOS thus far, will test android before landing
Reviewers: ashoat, def-au1t, varun, palys-swm, karol-bisztyga, jimpo
Subscriber... | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/cpp/PlatformSpecificTools.cpp",
"new_path": "native/android/app/src/cpp/PlatformSpecificTools.cpp",
"diff": "@@ -33,4 +33,8 @@ void PlatformSpecificTools::generateSecureRandomBytes(\nbuffer = PlatformSpecificToolsJavaClass::generateSecur... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce `PlatformSpecificTools::getDeviceOS()`
Summary: We need `deviceOS` for `SessionSignature(...)` unary gRPC call
Test Plan: Call function and log result. Only tested on iOS thus far, will test android before landing
Reviewers: ashoat, def-au1t, varun, palys-swm, karol-bisztyga, jimpo
Review... |
129,184 | 09.02.2022 15:40:23 | 18,000 | 2671925ca5b2017d4bea51656fd0b23c24d54f7f | [CommCoreModule] Use `CONNECTING` instead of `0` in `readyState` initialization
Summary: Super minor fix, should've switched this over when we introduced the `SocketStatus` enum
Test Plan: Still builds
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp",
"new_path": "native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp",
"diff": "@@ -7,7 +7,7 @@ using namespace facebook;\nGRPCStreamHostObject::GRPCStreamHostObject(\njsi::Runtime &rt,\nstd::shared_ptr<react::Ca... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Use `CONNECTING` instead of `0` in `readyState` initialization
Summary: Super minor fix, should've switched this over when we introduced the `SocketStatus` enum
Test Plan: Still builds
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga
Reviewed By: ashoat
Subscribers: Adrian, benschac
... |
129,179 | 11.02.2022 10:02:36 | 18,000 | 4fb8282eeede012c90fda4ac2cc8641e7220470f | [web] add sidebar icon
Summary: add icon per figma {F13879}
Test Plan: make sure its the right icon. More updates to design coming in future diffs.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-button.js",
"new_path": "web/chat/message-action-button.js",
"diff": "// @flow\n-import { faEllipsisH } from '@fortawesome/free-solid-svg-icons';\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport classNames fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add sidebar icon
Summary: add icon per figma {F13879}
Test Plan: make sure its the right icon. More updates to design coming in future diffs.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3166 |
129,179 | 11.02.2022 10:04:09 | 18,000 | 3b7e9222ae6b69d307d9b8b2ab0dfc0b43cccdbb | [web] add icons, reply and chevron small
Summary: screenshot, add these two {F13851}
Test Plan: n/a make sure icons in the app don't break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 64,\n+ \"paths\": [\"M426.667 725.333l213.333-213.333-213.333-213.333\"],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add icons, reply and chevron small
Summary: screenshot, add these two {F13851}
Test Plan: n/a make sure icons in the app don't break
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3167 |
129,179 | 11.02.2022 10:06:14 | 18,000 | 1a74dfbc2eaaac1a25e89c33727f35476665cc1b | [web] add reply icon on hover
Summary: {F13881}
Test Plan: make sure page renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -100,9 +100,6 @@ div.nonViewerMessageActionLinks {\ndiv.messageActionLinks > div + div {\nmargin-left: 4px;\n}\n-div.messageReplyButton {\n- font-size: 14px;\n-}\ndiv.me... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add reply icon on hover
Summary: {F13881}
Test Plan: make sure page renders
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3168 |
129,179 | 11.02.2022 10:18:15 | 18,000 | 1a21b8f48a428cc5e16e4ec1235a37f825a9c046 | [web] [fix] thread thread moves on hover
Summary:
before: {F13814}
after: {F13813}
Test Plan: make sure its not moving
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -150,11 +150,12 @@ div.sidebar .menu > button svg {\ncolor: var(--thread-color-read);\n}\ndiv.sidebar .menu {\n- display: none;\n+ opacity: 0;\n}\ndiv.sidebar:hover .menu ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] thread thread moves on hover
Summary:
before: {F13814}
after: {F13813}
Test Plan: make sure its not moving
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3164 |
129,184 | 10.02.2022 21:05:14 | 18,000 | 0a06e4a9d2aaa7bafa78ec117f2d241fb45732eb | [CommCoreModule] Introduce `CommCoreModule::setNotifyToken`
Summary: Stores `notifyToken` value in the SQLite `metadata` table
Test Plan:
1. Call the function
2. Verify that the row was created in the SQLite DB
Reviewers: palys-swm, def-au1t, karol-bisztyga, varun, ashoat, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -55,6 +55,7 @@ public:\nvirtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;\nvirt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce `CommCoreModule::setNotifyToken`
Summary: Stores `notifyToken` value in the SQLite `metadata` table
Test Plan:
1. Call the function
2. Verify that the row was created in the SQLite DB
https://blob.sh/atul/50fb.png
Reviewers: palys-swm, def-au1t, karol-bisztyga, varun, ashoat, jimpo
Revie... |
129,179 | 14.02.2022 10:41:28 | 18,000 | a27f687018e61953ad819826d3e5663c54f8ea2f | [web] [remove] lastActivity from thread
Summary:
talked IRL with ashoat about removing timestamp {F12385}
follow up diff here:
Test Plan: make sure page renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/sidebar-item.react.js",
"new_path": "web/chat/sidebar-item.react.js",
"diff": "@@ -4,9 +4,7 @@ import classNames from 'classnames';\nimport * as React from 'react';\nimport type { SidebarInfo } from 'lib/types/thread-types';\n-import { shortAbsoluteDa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [remove] lastActivity from thread
Summary:
talked IRL with ashoat about removing timestamp {F12385}
follow up diff here: https://phabricator.ashoat.com/D3163
Test Plan: make sure page renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differenti... |
129,179 | 14.02.2022 10:43:25 | 18,000 | c3b7fe726365c224210fe019e66c3295aadd2cad | [web] [fix] ancestorThreads styling
Summary:
fix up styles. Right size chevrons, align correctly {F14090}
Assigning too since Atul is OOO.
Test Plan: n/a make sure it's close to figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -107,7 +107,7 @@ function ChatThreadListItem(props: Props): React.Node {\nconst isNotLast = idx !== ancestorThreads.length - 1;\nconst chevron = isNotL... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] ancestorThreads styling
Summary:
fix up styles. Right size chevrons, align correctly {F14090}
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77116
Assigning @ashoat too since Atul is OOO.
Test Plan: n/a make sure it's close to figma
Reviewers: atul, ashoat
Reviewe... |
129,179 | 14.02.2022 10:44:08 | 18,000 | b7aa268a54452383bb8d459f25d401a729346a0e | [web] [remove] text highlighting from active thread
Summary:
remove highlight on active (selected) thread screenshot (adding ashoat since atul is out today)
{F14039}
Test Plan: should work like before, without highlighting of text.
Reviewers: atul, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -38,18 +38,6 @@ div.thread div.title {\ncolor: var(--thread-color-read);\nline-height: var(--line-height-text);\n}\n-div.thread div.title.unread,\n-div.thread.activeThread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [remove] text highlighting from active thread
Summary:
remove highlight on active (selected) thread screenshot (adding ashoat since atul is out today)
{F14039}
Test Plan: should work like before, without highlighting of text.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-... |
129,179 | 15.02.2022 09:16:09 | 18,000 | 1a3f76d0c9c3f7846fb7494e03eaecf31651b1ff | [web] [refator] Chat thread list
Summary: destructure item a bit more. No new functionality.
Test Plan: make sure thread item still works.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -25,8 +25,14 @@ type Props = {\n};\nfunction ChatThreadListItem(props: Props): React.Node {\nconst { item, setModal } = props;\n- const { threadInfo, l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refator] Chat thread list
Summary: destructure item a bit more. No new functionality.
Test Plan: make sure thread item still works.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3184 |
129,179 | 15.02.2022 09:35:03 | 18,000 | fb93ae4b58bab7a9c48a983fee2f9e98a74b1b8e | [web] [darkmode] unread button
Summary:
theme unread button, no design in web. Generally just theme'ed with our color palette.
{F14033}
Adding ashoat since Atul is OOO today.
Test Plan: should work as before.
Reviewers: atul, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.react.js",
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "// @flow\n-import classNames from 'classnames';\nimport * as React from 'react';\nimport {\n@@ -17,6 +16,7 @@ import {\nuseDispatchActionPromise... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [darkmode] unread button
Summary:
theme unread button, no design in web. Generally just theme'ed with our color palette.
{F14033}
Adding ashoat since Atul is OOO today.
Test Plan: should work as before.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differ... |
129,179 | 15.02.2022 09:58:41 | 18,000 | 167b315db3e100c697174aaa71f267d63a211c12 | [web] [feat] add unread dot
Summary:
add unread dot per figma screen shot {F14118}
Ignore title color, will fix in a follow up diff.
Test Plan: match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -79,6 +79,11 @@ function ChatThreadListItem(props: Props): React.Node {\n[unread],\n);\n+ let unreadDot;\n+ if (unread) {\n+ unreadDot = <div className... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [feat] add unread dot
Summary:
add unread dot per figma screen shot {F14118}
Ignore title color, will fix in a follow up diff.
Test Plan: match figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.co... |
129,187 | 08.02.2022 22:40:50 | 18,000 | 03db030f6828c9b630035e7c8062f570b1465484 | [lib] Simplify filterChatThreadList
Summary:
It's good this function got factored out, because it turns out the logic can be significantly simplified now.
Depends on D2885
Test Plan: Flow, careful code inspection
Reviewers: def-au1t, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -1190,15 +1190,13 @@ function getThreadListSearchResults(\nusersSearchResults: $ReadOnlyArray<GlobalAccountUserInfo>,\nviewerID: ?string,\n): $ReadOnlyArray<ChatThreadItem> {\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Simplify filterChatThreadList
Summary:
It's good this function got factored out, because it turns out the logic can be significantly simplified now.
Depends on D2885
Test Plan: Flow, careful code inspection
Reviewers: def-au1t, palys-swm
Reviewed By: def-au1t, palys-swm
Subscribers: benschac, Adrian, atul, ... |
129,179 | 16.02.2022 15:12:46 | 18,000 | 8b1ffb2a4fa72fe66621599ff3502b3b024b4169 | [landing] [fix] footer layout on mobile
Summary:
before: {F15004}
after: {F15005}
side stepping normal diff review because we don't want a broken signup experience this week.
Test Plan: shrink browser, it should not look broken
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -18,7 +18,7 @@ footer.wrapper {\n}\n@media screen and (max-width: 1099px) {\n- footer.wrapper {\n+ .contentWrapper {\ngrid-template-columns: 16px repeat(6, 1fr) 16px;\ngrid-template-rows: 1fr 1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] [fix] footer layout on mobile
Summary:
before: {F15004}
after: {F15005}
side stepping normal diff review because we don't want a broken signup experience this week.
Test Plan: shrink browser, it should not look broken
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, k... |
129,179 | 22.02.2022 08:54:55 | 18,000 | 64e2cb75bc0560d7a65712ebe09dca5f0b7443f8 | [web] [fix] loading LoadingIndicator color to white
Summary: make loading indicator correct color {F14712}
Test Plan: should be white, when scrolling new messages
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.react.js",
"new_path": "web/chat/chat-message-list.react.js",
"diff": "@@ -187,7 +187,7 @@ class ChatMessageList extends React.PureComponent<Props, State> {\nif (item.itemType === 'loader') {\nreturn (\n<div key=\"loader\" className=... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] loading LoadingIndicator color to white
Summary: make loading indicator correct color {F14712}
Test Plan: should be white, when scrolling new messages
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ash... |
129,179 | 22.02.2022 09:22:01 | 18,000 | aa5887f7949a57f276573aa5144ffeeee72203cd | [web] [chore] add additional icons for drop down menu
Summary: Adds additional icons {F15348}
Test Plan: clean cache, re-load page, icons should render as expected
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 65,\n+ \"paths\": [\n+ \"M725.333 512h-426.667M725.333 512l-170.667 170.667M725.333 512l-170.667-170.667\"\n+ ],\n+ \"attrs\": [\n+ {\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [chore] add additional icons for drop down menu
Summary: Adds additional icons {F15348}
Test Plan: clean cache, re-load page, icons should render as expected
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.c... |
129,179 | 22.02.2022 10:05:01 | 18,000 | becd97298c437c4c43885f5196763cd5c3229673 | [web] [chore] add icon types to Icons component
Summary: Type icon names, add auto-complete to icon component for better developer experience
Test Plan: flow shouldn't error out
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/SWMansionIcon.react.js",
"new_path": "web/SWMansionIcon.react.js",
"diff": "@@ -5,8 +5,48 @@ import IcomoonReact from 'react-icomoon';\nimport iconSet from './icons/selection.json';\n+export type Icon =\n+ | 'arrow-right-small'\n+ | 'bell'\n+ | 'logout'\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [chore] add icon types to Icons component
Summary: Type icon names, add auto-complete to icon component for better developer experience
Test Plan: flow shouldn't error out
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabri... |
129,184 | 15.02.2022 15:27:51 | 28,800 | 970cc73a360c9ff6e1ac8e3bfac96b80c98d2bfb | [docker] Switch base image from `alpine:3.14` to `ubuntu:20.04`
Summary: This is Ubuntu "minimal" or whatever according to:
Test Plan: Putting this up to see what happens with the CI
Reviewers: varun, geekbrother, karol-bisztyga, jimpo, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-base/Dockerfile",
"new_path": "services/backup/docker-base/Dockerfile",
"diff": "@@ -4,8 +4,12 @@ ENV SHELL=/bin/bash\nCOPY services/backup/docker-base/contents /transferred\n-RUN apk update\n-RUN apk add curl-dev openssl-dev libuuid zli... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docker] Switch base image from `alpine:3.14` to `ubuntu:20.04`
Summary: This is Ubuntu "minimal" or whatever according to: https://ubuntu.com/blog/minimal-ubuntu-released
Test Plan: Putting this up to see what happens with the CI
Reviewers: varun, geekbrother, karol-bisztyga, jimpo, ashoat
Reviewed By: varun, karo... |
129,184 | 23.02.2022 12:44:54 | 18,000 | 9dda4dd52097119f7181fd7fe7538f4bbe46f255 | [CommCoreModule] Simplify `matchesInboundSession` return logic
Summary: Minor thing I noticed when working in `CryptoModule.cpp`
Test Plan: Close reading.. logic should be identical
Reviewers: karol-bisztyga, varun, palys-swm, jimpo, ashoat
Subscribers: benschac, ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp",
"new_path": "native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp",
"diff": "@@ -176,16 +176,13 @@ bool CryptoModule::matchesInboundSession(\n// Check that the inbound session matches the key this message is sup... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Simplify `matchesInboundSession` return logic
Summary: Minor thing I noticed when working in `CryptoModule.cpp`
Test Plan: Close reading.. logic should be identical
Reviewers: karol-bisztyga, varun, palys-swm, jimpo, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian
Diff... |
129,185 | 24.02.2022 13:11:50 | -3,600 | 6eefa46c7da69a7c48d4892296da58561e527f80 | [web] Disable "see full structure" button
Summary:
I disabled the button until we will have the feature implemented.
Test Plan:
The text disappears from bar on web.
{F15598}
Reviewers: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-ancestors.react.js",
"new_path": "web/chat/chat-thread-ancestors.react.js",
"diff": "@@ -11,6 +11,8 @@ import { useSelector } from '../redux/redux-utils';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport css from './chat-thread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Disable "see full structure" button
Summary:
https://linear.app/comm/issue/ENG-783/see-full-structure-button-doesnt-do-anything
I disabled the button until we will have the feature implemented.
Test Plan:
The text disappears from bar on web.
{F15598}
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat... |
129,179 | 24.02.2022 16:20:33 | 18,000 | b54b78480344195e857a34d405c057c9dbcf3afb | [web] [refactor] create modal context, use for setModal
Summary:
adds modal context to be used instead of internal state so we don't have to prop drill
Depends On: D3214
Test Plan: n/a this doesn't do anything yet.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/modal-provider.react.js",
"diff": "+// @flow\n+\n+import invariant from 'invariant';\n+import * as React from 'react';\n+\n+type Props = {\n+ +children: React.Node,\n+};\n+type ModalContextType = {\n+ +modal: ?React.Node,\n+ +setModal... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] create modal context, use for setModal
Summary:
adds modal context to be used instead of internal state so we don't have to prop drill
Depends On: D3214
Test Plan: n/a this doesn't do anything yet.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
... |
129,179 | 24.02.2022 16:44:23 | 18,000 | 6e04330f42aab96389295a9224166bdcec42ed56 | [web] [refactor] chat thread list item menu html cleanup
Summary:
fix up html + css while changing the unread theme
before: {F16220}
after: {F16221}
Test Plan: click unread, no new functionality or changes should happen.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.react.js",
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "@@ -74,23 +74,18 @@ function ChatThreadListItemMenu(props: Props): React.Node {\n}`;\nconst menuIconSize = renderStyle === 'chat' ? 24 : 16;\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] chat thread list item menu html cleanup
Summary:
fix up html + css while changing the unread theme
before: {F16220}
after: {F16221}
Test Plan: click unread, no new functionality or changes should happen.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, kar... |
129,184 | 24.02.2022 17:13:40 | 18,000 | b417f69c4044da4e0f32aee99f940f6c68d175ad | [web] Fix `TextMessage` styling for inbound messages
Summary:
Before:
After:
Test Plan: NA
Reviewers: palys-swm, def-au1t, varun, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -111,6 +111,9 @@ div.textMessage {\nwidth: 100%;\nbox-sizing: border-box;\n}\n+div.textMessageDefaultBackground {\n+ background-color: var(--text-message-default-backgro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix `TextMessage` styling for inbound messages
Summary:
Before: https://blob.sh/atul/2427.png
After: https://blob.sh/atul/d70c.png
Test Plan: NA
Reviewers: palys-swm, def-au1t, varun, benschac, ashoat
Reviewed By: palys-swm, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision:... |
129,184 | 25.02.2022 11:50:57 | 18,000 | 2ceaa19650940459a8d776408a27a697c2beb0c6 | [web] Get rid of duplicate variables in `theme.css`
Summary: NA
Test Plan: NA
Reviewers: varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--modal-bg: var(--shades-black-90);\n--join-bg: var(--shades-black-90);\n--help-color: var(--shades-black-60);\n- --modal-bg: var(--shades-black-90);\n--breadcrumb-color: var(--shades-black-60);\n--breadcru... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of duplicate variables in `theme.css`
Summary: NA
Test Plan: NA
Reviewers: varun, ashoat
Reviewed By: varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3291 |
129,179 | 25.02.2022 16:48:42 | 18,000 | aaff95b79181c891865ad2f6c00a8af512d13bfb | [web] [chore] fix typo calandarQuery --> calendarQuery
Summary: Saw a typo and wanted to fix it.
Test Plan: N/A application should run as expected.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/entry.react.js",
"new_path": "web/calendar/entry.react.js",
"diff": "@@ -482,7 +482,7 @@ const ConnectedEntry: React.ComponentType<BaseProps> = React.memo<BaseProps>(\nstate =>\n!!(state.currentUserInfo && !state.currentUserInfo.anonymous && true)... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [chore] fix typo calandarQuery --> calendarQuery
Summary: Saw a typo and wanted to fix it.
Test Plan: N/A application should run as expected.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3289 |
129,184 | 23.02.2022 23:29:38 | 18,000 | 8ac1900c521b72e1003825f774d3c046fb615bca | [web] Introduce and style `messageActionContainer` for `ComposedMessage`
Summary:
Before:
After:
Illustration of `messageActionActiveArea`:
Test Plan: NA
Reviewers: palys-swm, def-au1t, benschac, varun, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -82,24 +82,43 @@ div.messageBottomRightTooltip:after {\nborder-color: transparent transparent var(--tool-tip-bg) transparent;\n}\n-div.messageActionLinks {\n+div.message... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce and style `messageActionContainer` for `ComposedMessage`
Summary:
Before: https://blob.sh/atul/36ae.png
After: https://blob.sh/atul/5b10.png
Illustration of `messageActionActiveArea`: https://blob.sh/atul/aa2b.png
Test Plan: NA
Reviewers: palys-swm, def-au1t, benschac, varun, ashoat
Reviewed By: be... |
129,179 | 28.02.2022 10:18:13 | 18,000 | 15359388e442fc9c798288f64752ce27218e2eb7 | [1/n] [landing] add team page route
Summary:
add a route for the team page
{F6672}
Test Plan: go to route, make sure it renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "import * as React from 'react';\nimport { useRouteMatch } from 'react-router-dom';\n+import { isDev } from 'lib/utils/dev-utils';\n+\nimport AppLanding from './app-landing.react';\nimp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] [landing] add team page route
Summary:
add a route for the team page
{F6672}
Test Plan: go to route, make sure it renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2748 |
129,184 | 27.02.2022 17:45:49 | 18,000 | cd1400550f0d945df5f96bdc36c26b6e1a9da32f | [docker] Run `rm -rf /var/lib/apt/lists/*` after `apt-get install`
Summary: Addresses feedback from
Test Plan: CI
Reviewers: jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga, jimpo | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-base/Dockerfile",
"new_path": "services/backup/docker-base/Dockerfile",
"diff": "@@ -8,7 +8,8 @@ RUN apt-get update && apt-get install -y \\\nlibcurl4-openssl-dev \\\nlibssl-dev \\\nuuid-dev \\\n- zlib1g-dev\n+ zlib1g-dev \\\n+ && rm -rf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docker] Run `rm -rf /var/lib/apt/lists/*` after `apt-get install`
Summary: Addresses feedback from @jimpo: https://phabricator.ashoat.com/D3212#88571
Test Plan: CI
Reviewers: jimpo
Reviewed By: jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga, jimpo
Differential Revision: https://phabricato... |
129,184 | 25.02.2022 12:25:17 | 18,000 | 1ceb95e9448b929e19fb09b94542539b38ce38fd | [web] Get rid of "square" under `messageTooltipMenu`
Summary:
Before:
After:
Test Plan: NA
Reviewers: varun, benschac, def-au1t, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip.css",
"new_path": "web/chat/tooltip.css",
"diff": "@@ -14,14 +14,6 @@ div.messageTooltipMenu ul {\ndiv.messageTooltipMenu li:not(:last-child) {\npadding-bottom: 5px;\n}\n-div.messageTooltipMenu:after {\n- content: '';\n- position: absolute;\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of "square" under `messageTooltipMenu`
Summary:
Before: https://blob.sh/atul/6b5c.png
After: https://blob.sh/atul/2041.png
Test Plan: NA
Reviewers: varun, benschac, def-au1t, ashoat
Reviewed By: benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.a... |
129,184 | 28.02.2022 16:18:15 | 18,000 | 395d10a875b000515aaa3ff8fdb8f4d8669978a8 | [web] Remove unused styles
Summary: These styles no longer exist and I believe were left in by mistake.
Test Plan: NA
Reviewers: varun, def-au1t, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -76,8 +76,6 @@ class ComposedMessage extends React.PureComponent<Props> {\n});\nconst messageBoxContainerClassName = classNames({\n[css.messageBoxContainer]: tru... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove unused styles
Summary: These styles no longer exist and I believe were left in by mistake.
Test Plan: NA
Reviewers: varun, def-au1t, benschac, ashoat
Reviewed By: benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3305 |
129,184 | 28.02.2022 18:12:42 | 18,000 | 13216d67276e71a1b7522be1ea2262277a27c0b7 | [web] Fix typo in `style.css`
Summary: NA
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -276,7 +276,7 @@ div.color-picker-selector {\nonly screen and (min-device-pixel-ratio: 2),\nonly screen and (min-resolution: 320dpi),\nonly screen and (min-resolution: 2dppx) {\n- headqer.header,\n+ head... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix typo in `style.css`
Summary: NA
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3308 |
129,184 | 28.02.2022 16:01:25 | 18,000 | 55aa432cc87d7204a7ca86fef3255565a678bcc1 | [web] Rename `MessageActionButton` to `MessageActionButtons`
Summary: After subsequent diffs, this component will be the parent of the sidebar and reply buttons.
Test Plan: NA, just separating this out for easier review
Reviewers: benschac, palys-swm, def-au1t, varun
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -19,7 +19,7 @@ import { type InputState, InputStateContext } from '../input/input-state';\nimport css from './chat-message-list.css';\nimport FailedSend from './... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename `MessageActionButton` to `MessageActionButtons`
Summary: After subsequent diffs, this component will be the parent of the sidebar and reply buttons.
Test Plan: NA, just separating this out for easier review
Reviewers: benschac, palys-swm, def-au1t, varun
Reviewed By: palys-swm
Subscribers: ashoat, Adr... |
129,184 | 28.02.2022 21:45:01 | 18,000 | 0dffc27ea480416373e51e75448d2a8c38839b01 | [web] Misc renaming in `MessageActionButtons` component
Summary: Changed some previously implementation-specific variable names to be more generic
Test Plan: Find and replace
Reviewers: varun, benschac, def-au1t, palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-buttons.js",
"new_path": "web/chat/message-action-buttons.js",
"diff": "@@ -20,7 +20,7 @@ import type {\nimport { tooltipPositions, type TooltipPosition } from './tooltip-utils';\nimport { TooltipMenu, type TooltipStyle, TooltipButton }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Misc renaming in `MessageActionButtons` component
Summary: Changed some previously implementation-specific variable names to be more generic
Test Plan: Find and replace
Reviewers: varun, benschac, def-au1t, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: h... |
129,190 | 04.03.2022 11:52:31 | 0 | d160f83fb92dfde3a356fb83ad3e4058b0d506b7 | [services] Backup - add Database Entities Tools
Summary:
There is a "DB schema" described as in D2950 and the method for creating items by type.
Depends on D3076
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.h",
"diff": "+#pragma once\n+\n+#include \"Item.h\"\n+\n+#include <memory>\n+#include <type_traits>\n+\n+namespace comm {\n+namespace network {\n+namespace ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - add Database Entities Tools
Summary:
There is a "DB schema" described as in D2950 and the method for creating items by type.
Depends on D3076
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, at... |
129,190 | 04.03.2022 11:55:25 | 0 | c96a1b5897235638a17fa52cfe5a5a56529d61bc | [services] Backup - Database - add Log Item
Summary:
Item for `UserPersist` database entity
Depends on D3082
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: jimpo, benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -49,7 +49,7 @@ if ($ENV{COMM_SERVICES_DEV_MODE} MATCHES 1)\nset(DEV_HEADERS_PATH \"./dev\")\nendif()\n-file(G... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Database - add Log Item
Summary:
Item for `UserPersist` database entity
Depends on D3082
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: jimpo, benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator... |
129,190 | 04.03.2022 11:56:04 | 0 | 2d9294c892848881bade6eb6ee221f13970b3195 | [services] Backup - Database - add Backup Item
Summary:
C++ representation of the backup database entity
Depends on D3084
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Constants.h",
"new_path": "services/backup/docker-server/contents/server/src/Constants.h",
"diff": "@@ -24,8 +24,10 @@ const std::string AWS_REGION = \"us-east-2\";\n#ifdef COMM_TEST_SERVICES\nconst std::string... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Database - add Backup Item
Summary:
C++ representation of the backup database entity
Depends on D3084
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabr... |
129,190 | 04.03.2022 11:59:50 | 0 | a91bed30ff24a2acf215728d8ca61f3eae366852 | [services] Backup - Implementation structure
Summary:
Implementation structure based on the `.proto` file
Depends on D3087
Test Plan: Backup service builds successfully
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"new_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"diff": "@@ -12,11 +12,12 @@ BackupServiceImpl::BackupServiceImpl() {\nBackupServiceImpl::~BackupSe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Implementation structure
Summary:
Implementation structure based on the `.proto` file
Depends on D3087
Test Plan: Backup service builds successfully
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Di... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.