author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,190 | 04.03.2022 12:00:29 | 0 | 073083fa62b22ca383053e1dbc524719d772416e | [services] Backup - Add Tools
Summary:
Adding `Tools` with `getCurrentTimestamp` which will be needed for creating backup items.
Depends on D3158
Test Plan: Backup service builds
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Tools.cpp",
"diff": "+#include \"Tools.h\"\n+\n+#include <chrono>\n+\n+namespace comm {\n+namespace network {\n+\n+uint64_t getCurrentTimestamp() {\n+ using namespace std::chrono;\n+ return durat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add Tools
Summary:
Adding `Tools` with `getCurrentTimestamp` which will be needed for creating backup items.
Depends on D3158
Test Plan: Backup service builds
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian... |
129,190 | 04.03.2022 12:02:29 | 0 | d97608371e008bb4988c633569611ba98511a872 | [services] Backup - Add DB test for Backup
Summary:
Adding test for database operations on `BackupItem`s
Depends on D3160
Test Plan:
```
cd services
yarn test-backup-service
```
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -27,6 +27,10 @@ set(gRPC_BUILD_GRPC_RUBY_PLUGIN OFF)\nset(gRPC_BUILD_GRPC_PYTHON_PLUGIN OFF)\nset(gRPC_BUILD_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add DB test for Backup
Summary:
Adding test for database operations on `BackupItem`s
Depends on D3160
Test Plan:
```
cd services
yarn test-backup-service
```
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian,... |
129,190 | 04.03.2022 12:03:57 | 0 | 4d4958bd27adf003ba25c751438cd587214f3621 | [services] Backup - Add DB operations for Logs
Summary:
Database operations for `LogItem`s
Depends on D3161
Test Plan: Backup service still builds
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/DatabaseManager.cpp",
"new_path": "services/backup/docker-server/contents/server/src/DatabaseManager.cpp",
"diff": "@@ -115,6 +115,73 @@ void DatabaseManager::removeBackupItem(std::shared_ptr<BackupItem> item) ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add DB operations for Logs
Summary:
Database operations for `LogItem`s
Depends on D3161
Test Plan: Backup service still builds
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: h... |
129,190 | 04.03.2022 12:04:26 | 0 | 8b36cb33cbb66de41097604fc7af310345fd3e03 | [services] Backup - Add DB tests for Logs
Summary:
Add tests for database operations for `LogItem`s
Depends on D3175
Test Plan:
```
cd services
yarn test-backup-service
```
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/test/DatabaseManagerTest.cpp",
"new_path": "services/backup/docker-server/contents/server/test/DatabaseManagerTest.cpp",
"diff": "@@ -26,9 +26,8 @@ std::string generateName(const std::string prefix = \"\") {\nretur... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add DB tests for Logs
Summary:
Add tests for database operations for `LogItem`s
Depends on D3175
Test Plan:
```
cd services
yarn test-backup-service
```
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul... |
129,190 | 04.03.2022 12:05:35 | 0 | 051afff095af6ca5b56f528658a08f597208ef67 | [services] Backup - Reuse remove logic
Summary:
Reuse `innerRemoveItem` for BackupItem`s and `LogItem`s
Depends on D3177
Test Plan:
```
cd services
yarn test-backup-service
```
Reviewers: palys-swm, geekbrother, varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/DatabaseManager.cpp",
"new_path": "services/backup/docker-server/contents/server/src/DatabaseManager.cpp",
"diff": "@@ -28,14 +28,19 @@ void DatabaseManager::innerPutItem(\n}\n}\n-void DatabaseManager::innerRem... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Reuse remove logic
Summary:
Reuse `innerRemoveItem` for BackupItem`s and `LogItem`s
Depends on D3177
Test Plan:
```
cd services
yarn test-backup-service
```
Reviewers: palys-swm, geekbrother, varun, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
D... |
129,179 | 04.03.2022 09:37:08 | 18,000 | 5b248e50e2f59df0549f0c3a55855fc2382a3dd5 | [web] [fix] update chevron color
Summary:
chevron color should be shades-of-white-60 per figma in the thread ancestor settings on the chat screen.
{F17402}
{F17404}
Test Plan: double check figma that this is correct
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-ancestors.css",
"new_path": "web/chat/chat-thread-ancestors.css",
"diff": "@@ -29,6 +29,10 @@ div.ancestorKeyserverName {\nborder-radius: 0px 2px 2px 0px;\n}\n+div.ancestorSeparator {\n+ color: var(--thread-ancestor-separator-color);\n+}\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] update chevron color
Summary:
chevron color should be shades-of-white-60 per figma in the thread ancestor settings on the chat screen.
{F17402}
{F17404}
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/?node-id=1170%3A77104
Test Plan: double check figma that this is correct
Reviewers: atul, ashoat
R... |
129,184 | 07.03.2022 16:20:34 | 18,000 | f50a6c62783837bbad1a082cf6c7cde49bb5e859 | [web] Fix unread thread title styling in `ChatThreadListItem`
Summary: Title is correct color when unread:
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -27,7 +27,7 @@ div.activeThread,\ndiv.thread:hover {\nbackground: var(--selected-thread-bg);\n}\n-div.thread div.title {\n+div.title {\nflex: 1;\nfont-size: var(--m-font-1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix unread thread title styling in `ChatThreadListItem`
Summary: Title is correct color when unread: https://blob.sh/atul/664a.png
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoa... |
129,184 | 07.03.2022 19:54:21 | 18,000 | ed3e53aa1251c9d31d8d2d11cc4a997b4ce4fbe7 | [web] Fix unread sidebar title styling in `SidebarItem`
Summary: Looks as expected:
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -132,6 +132,9 @@ div.sidebarTitle {\ncolor: var(--thread-color-read);\nalign-self: flex-start;\n}\n+div.sidebarTitle.unread {\n+ color: var(--fg);\n+}\ndiv.sidebarLastActi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix unread sidebar title styling in `SidebarItem`
Summary: Looks as expected:
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3360 |
129,184 | 28.02.2022 18:07:25 | 18,000 | 94b1328fcf9ab2f735bd73a810d374cb30c4ebe4 | [web] Properly style `messageActionButtonsContainer`
Summary:
Before:
After:
Test Plan: NA
Reviewers: palys-swm, def-au1t, benschac, varun
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-buttons.css",
"new_path": "web/chat/message-action-buttons.css",
"diff": "-div.messageActionButton {\n+div.messageActionButtonsContainer {\n+ display: flex;\n+ flex-direction: row;\nfont-size: 16px;\n}\ndiv.messageActionLinkIcon {\n- pa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Properly style `messageActionButtonsContainer`
Summary:
Before: https://blob.sh/atul/b611.png
After: https://blob.sh/atul/1349.png
Test Plan: NA
Reviewers: palys-swm, def-au1t, benschac, varun
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoa... |
129,184 | 28.02.2022 18:30:19 | 18,000 | 3ecb605a9b54b3cf733918dfc3a4ad78449c8d6f | [web] Conditionally lay out `MessageActionButtons` based on `isViewer`
Summary: Match existing layout (reply button closer to message)... fixes issue knowingly "introduced" in D3306
Test Plan:
`!isViewer`:
`isViewer`:
Reviewers: varun, benschac, palys-swm, def-au1t, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-buttons.css",
"new_path": "web/chat/message-action-buttons.css",
"diff": "-div.messageActionButtonsContainer {\n+div.messageActionButtons {\ndisplay: flex;\n- flex-direction: row;\nfont-size: 16px;\n}\n+div.messageActionButtonsViewer {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Conditionally lay out `MessageActionButtons` based on `isViewer`
Summary: Match existing layout (reply button closer to message)... fixes issue knowingly "introduced" in D3306
Test Plan:
`!isViewer`: https://blob.sh/atul/400a.png
`isViewer`: https://blob.sh/atul/7c56.png
Reviewers: varun, benschac, palys-swm, ... |
129,184 | 08.03.2022 00:50:31 | 18,000 | 7b28a9deafcf8e72770e4a1435231a288e475c60 | [landing] Re-introduce hover styling for `Footer` links
Summary:
Bring back the hover styling from before. Here's how it looks:
{F18522}
Test Plan: NA, looks as expected
Reviewers: def-au1t, palys-swm, varun, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -54,7 +54,19 @@ footer.wrapper {\nvar(--largest-font-size)\n);\nfont-weight: 400;\n- color: #cccccc;\n+}\n+.navigation a,\n+.navigation svg {\n+ color: #808080;\n+ transition: 150ms;\n+ transit... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Re-introduce hover styling for `Footer` links
Summary:
Bring back the hover styling from before. Here's how it looks:
{F18522}
Test Plan: NA, looks as expected
Reviewers: def-au1t, palys-swm, varun, benschac, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential... |
129,184 | 28.02.2022 18:52:59 | 18,000 | 93d079ef9a8ce3257f96f8fe91b5df8c932c335b | [web] Remove extraneous `sidebarExistsOrCanBeCreated` prop in `MessageActionButtons`
Summary: Can use `useSidebarExistsOrCanBeCreated` hook directly instead of "drilling" it in.
Test Plan: Close reading, things seem to continue working as expected
Reviewers: def-au1t, palys-swm, varun, benschac
Subscribers: ashoat, Adr... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -140,7 +140,6 @@ class ComposedMessage extends React.PureComponent<Props> {\nmouseOverMessagePosition={this.props.mouseOverMessagePosition}\ncanReply={this.props... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove extraneous `sidebarExistsOrCanBeCreated` prop in `MessageActionButtons`
Summary: Can use `useSidebarExistsOrCanBeCreated` hook directly instead of "drilling" it in.
Test Plan: Close reading, things seem to continue working as expected
Reviewers: def-au1t, palys-swm, varun, benschac
Reviewed By: palys-s... |
129,184 | 28.02.2022 21:26:14 | 18,000 | 3f7eaeea385d080153fcae9c2654c1a413fbc5de | [web] Remove extraneous `containerPosition` prop from `MessageActionButtons`
Summary: We can get `containerPosition` from `mouseOverMessagePosition` instead of passing it in directly as a prop
Test Plan: NA, flow
Reviewers: def-au1t, palys-swm, varun, benschac
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -132,9 +132,6 @@ class ComposedMessage extends React.PureComponent<Props> {\n<MessageActionButtons\nthreadInfo={threadInfo}\nitem={item}\n- containerPosition={\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove extraneous `containerPosition` prop from `MessageActionButtons`
Summary: We can get `containerPosition` from `mouseOverMessagePosition` instead of passing it in directly as a prop
Test Plan: NA, flow
Reviewers: def-au1t, palys-swm, varun, benschac
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, ka... |
129,184 | 07.03.2022 20:25:07 | 18,000 | c94bd22e82868e749619008485ed7715ef2eaf13 | [web] Fix sidebar hover styling in `ChatThreadListSidebar`
Summary: Sidebars in the thread list were not being highlighted on hover.. figured they should be.
Test Plan:
Before:
{F18847}
After:
{F18848}
Reviewers: palys-swm, def-au1t, benschac, varun
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -24,7 +24,8 @@ div.thread:first-child {\npadding-top: 6px;\n}\ndiv.activeThread,\n-div.thread:hover {\n+div.thread:hover,\n+div.threadListSideBar:hover {\nbackground: var(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix sidebar hover styling in `ChatThreadListSidebar`
Summary: Sidebars in the thread list were not being highlighted on hover.. figured they should be.
Test Plan:
Before:
{F18847}
After:
{F18848}
Reviewers: palys-swm, def-au1t, benschac, varun
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-biszty... |
129,191 | 25.02.2022 16:39:15 | -3,600 | 18dec803fe3afefa1ef764572da700acb1b101d2 | [web] Add logged in section
Summary:
Display a label and username
{F17278}
{F17327}
Depends on D3320
Test Plan: Render the page instead of Calendar and check if it matches the design and if current username was displayed
Reviewers: benschac, atul, def-au1t
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/settings/account-settings.css",
"new_path": "web/settings/account-settings.css",
"diff": "color: var(--fg);\nfont-weight: var(--semi-bold);\nline-height: var(--line-height-display);\n+ padding-bottom: 55px;\n+}\n+\n+.content ul {\n+ list-style-type: none;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add logged in section
Summary:
Display a label and username
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1272%3A88750
{F17278}
{F17327}
Depends on D3320
Test Plan: Render the page instead of Calendar and check if it matches the design and if current username was displayed
Re... |
129,185 | 09.03.2022 16:18:44 | -3,600 | 871eb88878fe81683c1a16b466cd2b76cbfa72e8 | [web] Show sidebars modal from thread menu
Summary: Add action on Sidebars item in thread menu. It displays modal with sidebars.
Test Plan: Select thread with sidebars inside and select "Sidebars" from thread menu
Reviewers: palys-swm, benschac, atul, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/thread-menu.react.js",
"new_path": "web/chat/thread-menu.react.js",
"diff": "@@ -23,6 +23,7 @@ import {\nthreadPermissions,\n} from 'lib/types/thread-types';\n+import SidebarListModal from '../modals/chat/sidebar-list-modal.react';\nimport { useModalC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Show sidebars modal from thread menu
Summary: Add action on Sidebars item in thread menu. It displays modal with sidebars.
Test Plan: Select thread with sidebars inside and select "Sidebars" from thread menu
Reviewers: palys-swm, benschac, atul, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adri... |
129,191 | 03.03.2022 18:18:08 | -3,600 | adc557bce79874b5da7e03eeea3f5488bb891ea2 | [web] Export navigation tab types
Summary:
These will be used in a couple of places
Depends on D3339
Depends on D3336
Test Plan: Just check if opening chat and calendar still works
Reviewers: benschac, atul, def-au1t
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/types/nav-types.js",
"new_path": "web/types/nav-types.js",
"diff": "import type { BaseNavInfo } from 'lib/types/nav-types';\nimport type { ThreadInfo } from 'lib/types/thread-types';\n+export type NavigationTab = 'calendar' | 'chat' | 'apps' | 'settings';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Export navigation tab types
Summary:
These will be used in a couple of places
Depends on D3339
Depends on D3336
Test Plan: Just check if opening chat and calendar still works
Reviewers: benschac, atul, def-au1t
Reviewed By: benschac, atul
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: ht... |
129,184 | 07.03.2022 14:24:47 | 18,000 | 816c1f56fa3c9b0310e1215b49f6b9a41132b8d6 | [web] Change `messageActionButtons svg` color on hover
Summary:
Here's what it looks like:
{F18372}
Test Plan: Looks as expected
Reviewers: def-au1t, palys-swm, benschac, varun
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-buttons.css",
"new_path": "web/chat/message-action-buttons.css",
"diff": "@@ -2,6 +2,12 @@ div.messageActionButtons {\ndisplay: flex;\nfont-size: 16px;\n}\n+div.messageActionButtons svg {\n+ color: var(--color-disabled);\n+}\n+div.messa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Change `messageActionButtons svg` color on hover
Summary:
Here's what it looks like:
{F18372}
Test Plan: Looks as expected
Reviewers: def-au1t, palys-swm, benschac, varun
Reviewed By: palys-swm, benschac
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3357 |
129,184 | 09.03.2022 12:58:39 | 18,000 | c06b6b718261d7629e0ddd6398f652e68390aba6 | [native] `codeVersion` -> 130 | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"diff": "@@ -13,7 +13,7 @@ namespace comm {\nnamespace jsi = facebook::jsi;\nclass CommCoreModule : public facebook::react::CommCoreModuleS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 130 |
129,179 | 25.02.2022 15:55:11 | 18,000 | f855c95576d153f026c26d3d32414c38f3e1eccf | [web] [fix] updated icons component
Summary: fix the "filled" icon, it's now message-filed-round and outline-key to key
Test Plan: N/A this will break production because we don't have the new icon json yet. Nothing to test.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/SWMansionIcon.react.js",
"new_path": "web/SWMansionIcon.react.js",
"diff": "@@ -17,7 +17,7 @@ export type Icon =\n| 'plus'\n| 'settings'\n| 'wrench'\n- | 'Filled'\n+ | 'message-filled-round'\n| 'bug'\n| 'cloud'\n| 'copy'\n@@ -27,7 +27,7 @@ export type Icon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] updated icons component
Summary: fix the "filled" icon, it's now message-filed-round and outline-key to key
Test Plan: N/A this will break production because we don't have the new icon json yet. Nothing to test.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, k... |
129,179 | 28.02.2022 12:37:25 | 18,000 | 005ec1e0e28e43834a12a44287c32ebd9eba2183 | [web] fix input icons to be the correct size
Summary:
re-size the icons with padding,
before: {F16689}
after: {F16690}
Test Plan: check figma, make sure the icons are the correct size:
Reviewers: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -226,7 +226,7 @@ class ChatInputBar extends React.PureComponent<Props> {\nif (this.props.inputState.draft.length) {\nsendButton = (\n<a onClick={this.onSend} classNa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] fix input icons to be the correct size
Summary:
re-size the icons with padding,
before: {F16689}
after: {F16690}
Test Plan: check figma, make sure the icons are the correct size: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79456
Reviewers: atul
Reviewed By: atul
Su... |
129,179 | 02.03.2022 13:25:22 | 18,000 | 641c446d3677ab492359f90ddb2a00f63e33d446 | [web] [fix] update cloud icon to correct size with paddings
Summary: update font size so cloud icon in bread crumb is the correct size {F17394} {F17396}
Test Plan: go to figma, check the sizes match:
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-ancestors.react.js",
"new_path": "web/chat/chat-thread-ancestors.react.js",
"diff": "@@ -51,7 +51,7 @@ function ThreadAncestors(props: ThreadAncestorsProps): React.Node {\n() => (\n<div className={css.ancestorKeyserver}>\n<div className={c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] update cloud icon to correct size with paddings
Summary: update font size so cloud icon in bread crumb is the correct size {F17394} {F17396}
Test Plan: go to figma, check the sizes match: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/?node-id=1170%3A77104
Reviewers: atul, ashoat
Reviewed By: atul, a... |
129,184 | 09.03.2022 13:43:30 | 18,000 | d19789f31d765bcb990b43ff701beb1ef007a05a | [web] Pull `getIconPosition` out of `toggleTooltip`
Summary: NA
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-buttons.js",
"new_path": "web/chat/message-action-buttons.js",
"diff": "@@ -20,6 +20,7 @@ import type {\nItemAndContainerPositionInfo,\nMessagePositionInfo,\nOnMessagePositionWithContainerInfo,\n+ PositionInfo,\n} from './position-types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Pull `getIconPosition` out of `toggleTooltip`
Summary: NA
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Reviewed By: varun
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3356 |
129,184 | 09.03.2022 14:38:57 | 18,000 | 6d44ac4b235666c9f5e78997d28d9b89805bb6e9 | [web] `threadListSideBar` -> `threadListSidebar`
Summary: Super minor rename addressing feedback:
Test Plan: Searched repo for `threadListSide[B/b]ar` and found no other occurrences
Reviewers: palys-swm, def-au1t, varun, benschac, jimpo
Subscribers: ashoat, Adrian, karol-bisztyga, palys-swm | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-sidebar.react.js",
"new_path": "web/chat/chat-thread-list-sidebar.react.js",
"diff": "@@ -21,7 +21,7 @@ function ChatThreadListSidebar(props: Props): React.Node {\nreturn (\n<div\n- className={classNames(css.threadListSideBar, css.sid... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] `threadListSideBar` -> `threadListSidebar`
Summary: Super minor rename addressing @palys-swm feedback: https://phabricator.ashoat.com/D3361?id=10124#inline-19750
Test Plan: Searched repo for `threadListSide[B/b]ar` and found no other occurrences
Reviewers: palys-swm, def-au1t, varun, benschac, jimpo
Reviewed ... |
129,184 | 09.03.2022 20:07:37 | 18,000 | ba52e334ec4fa96283455ae90338d7388219db31 | [landing] Reintroduce hover styling for `Header` nav links
Summary: Bring back hover styling for `Header` nav links
Test Plan:
Here's how it looks:
{F19519}
Reviewers: def-au1t, varun, benschac, palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -24,10 +24,14 @@ nav.wrapper {\n.tab {\nfont-size: 24px;\n- font-weight: 400;\n- color: var(--unselected);\n+ font-weight: 500;\n+ color: #808080;\nfont-family: 'IBM Plex Sans', sans-serif;\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Reintroduce hover styling for `Header` nav links
Summary: Bring back hover styling for `Header` nav links
Test Plan:
Here's how it looks:
{F19519}
Reviewers: def-au1t, varun, benschac, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator... |
129,191 | 09.03.2022 18:55:00 | -3,600 | 2f88cd59f456cf69f32a1ebb4b2ba0c1115b8d82 | [web] Address remaining code review comments from D3341
Summary:
Rename `activeThreadCurrentlyUnread` and delete unused variable
Depends on D3341
Depends on D3387
Test Plan: Flow
Reviewers: benschac, atul, def-au1t
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "// @flow\n-import invariant from 'invariant';\nimport * as React from 'react';\nimport { useDispatch } from 'react-redux';\n@@ -20,7 +19,7 @@ function AppSwitcher(): ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Address remaining code review comments from D3341
Summary:
Rename `activeThreadCurrentlyUnread` and delete unused variable
Depends on D3341
Depends on D3387
Test Plan: Flow
Reviewers: benschac, atul, def-au1t
Reviewed By: benschac, atul
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: http... |
129,184 | 15.03.2022 14:28:59 | 14,400 | e9743411cc8f0cd6ee15e7732a594acde3016aa3 | [landing] Fix "fluid" `font-size` for `keyserver.js:h1`
Summary: Before these were 24px at smallest breakpoint and 56px at largest breakpoint. Now we linearly interpolate over that range.
Test Plan: Here's how it looks: {F22355}
Reviewers: palys-swm, benschac, ashoat
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/keyservers.css",
"new_path": "landing/keyservers.css",
"diff": "@@ -4,14 +4,15 @@ div.body_grid {\nmargin-right: auto;\ndisplay: grid;\ncolumn-gap: 6em;\n- padding-left: 60px;\n- padding-right: 60px;\n- padding-top: 20px;\n- padding-bottom: 40px;\n+ pa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix "fluid" `font-size` for `keyserver.js:h1`
Summary: Before these were 24px at smallest breakpoint and 56px at largest breakpoint. Now we linearly interpolate over that range.
Test Plan: Here's how it looks: {F22355}
Reviewers: palys-swm, benschac, ashoat
Reviewed By: ashoat
Subscribers: Adrian, karol-... |
129,184 | 15.03.2022 15:32:47 | 14,400 | 1349fa4902f811ea699ee41e7995457f3460d9b2 | [landing] Fix "fluid" `font-size` for `hero-content:sub_heading`
Summary: Continues to look as expected. Maintains proportion with the cycling header now which seems like it's actually a slight improvement.
Test Plan: Here's how it looks: {F22395}
Reviewers: benschac, palys-swm, ashoat
Subscribers: Adrian, karol-biszty... | [
{
"change_type": "MODIFY",
"old_path": "landing/hero-content.css",
"new_path": "landing/hero-content.css",
"diff": ".sub_heading {\ncolor: var(--sub-heading-color);\n- --smallest-font-size: 16px;\n- --largest-font-size: 50px;\n- --font-scale: calc(0.75rem + 1.25vw);\n-\n- font-size: clamp(\n- var(--... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix "fluid" `font-size` for `hero-content:sub_heading`
Summary: Continues to look as expected. Maintains proportion with the cycling header now which seems like it's actually a slight improvement.
Test Plan: Here's how it looks: {F22395}
Reviewers: benschac, palys-swm, ashoat
Reviewed By: ashoat
Subscrib... |
129,184 | 15.03.2022 15:53:24 | 14,400 | a97182d344c3db9f9c4871cce9cc6aec3a748a8b | [landing] Fix "fluid" `font-size` for `footer:navigation a`
Summary: Interpolate from 16px to 24px for width of 320px to 1850px.
Test Plan:
Continues to look as expected:
{F22428} (towards end)
Reviewers: def-au1t, palys-swm, benschac
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -44,15 +44,7 @@ footer.wrapper {\n}\n.navigation a {\n- --smallest-font-size: 16px;\n- --largest-font-size: 24px;\n- --scale: calc(0.75rem + 2vw);\n-\n- font-size: clamp(\n- var(--smallest-font... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix "fluid" `font-size` for `footer:navigation a`
Summary: Interpolate from 16px to 24px for width of 320px to 1850px.
Test Plan:
Continues to look as expected:
{F22428} (towards end)
Reviewers: def-au1t, palys-swm, benschac
Reviewed By: palys-swm, benschac
Subscribers: ashoat, Adrian, karol-bisztyga
Di... |
129,184 | 15.03.2022 16:04:00 | 14,400 | e266efa148f69aab345b705719681251f63c9fd1 | [landing] Fix "fluid" `font-size`/`padding-bottom` for `info-block:title`
Summary: Interpolate over values from width of 320px to 1850px
Test Plan:
Continues to look as expected:
{F22464}
Reviewers: benschac, palys-swm, ashoat
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.css",
"new_path": "landing/info-block.css",
"diff": "}\n.title {\n- --smallest-font-size: 30px;\n- --largest-font-size: 50px;\n- --smallest-padding-size: 16px;\n- --largest-padding-size: 48px;\n- --scale: calc(0.75rem + 2vw);\n-\nfont-family... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix "fluid" `font-size`/`padding-bottom` for `info-block:title`
Summary: Interpolate over values from width of 320px to 1850px
Test Plan:
Continues to look as expected:
{F22464}
Reviewers: benschac, palys-swm, ashoat
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga
Differential Revision: https:/... |
129,184 | 16.03.2022 18:06:38 | 14,400 | 85f151280180750e957603125660a4af194b681d | [web] Remove `div.bottomContainer` from `Splash`
Summary:
Cut `div.bottomContainer` in `splash.react.js` and associated styles in `splash.css`.
Here's how it looks:
{F23236}
depends on D3447
Test Plan: Same as D3447 (tldr: make sure we can still log in, etc)
Reviewers: def-au1t, palys-swm, benschac, varun
Subscribers: ... | [
{
"change_type": "MODIFY",
"old_path": "web/splash/splash.css",
"new_path": "web/splash/splash.css",
"diff": "@@ -59,45 +59,3 @@ p.introDescription {\nfont-weight: 300;\npadding-top: 5px;\n}\n-div.bottomContainer {\n- z-index: 2;\n- position: relative;\n- overflow: auto;\n- height: 100%;\n-}\n-div.b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove `div.bottomContainer` from `Splash`
Summary:
Cut `div.bottomContainer` in `splash.react.js` and associated styles in `splash.css`.
Here's how it looks:
{F23236}
---
depends on D3447
Test Plan: Same as D3447 (tldr: make sure we can still log in, etc)
Reviewers: def-au1t, palys-swm, benschac, varun
Re... |
129,200 | 11.03.2022 15:43:21 | 18,000 | 1e857b8e6fb50517a65340bea990d96f66054853 | choose which app url facts to use based on request url
Summary:
use getAppURLFactsFromRequestURL to choose which app URL facts to use.
depends on D3406
Test Plan: flow
Reviewers: palys-swm, atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/handlers.js",
"new_path": "server/src/responders/handlers.js",
"diff": "@@ -13,6 +13,7 @@ import {\ncreateNewAnonymousCookie,\n} from '../session/cookies';\nimport type { Viewer } from '../session/viewer';\n+import { type AppURLFacts, get... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | choose which app url facts to use based on request url
Summary:
use getAppURLFactsFromRequestURL to choose which app URL facts to use.
depends on D3406
Test Plan: flow
Reviewers: palys-swm, atul, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac
Differential Revision: ht... |
129,200 | 11.03.2022 17:56:32 | 18,000 | 02dc417d09f4d7d288e42f1a3900a6a836460821 | use landing base route path to construct endpoints
Summary:
we should avoid hardcoding paths like /commlanding/. instead we should get the paths from the landing_url.json file.
depends on D3413
Test Plan: flow
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac | [
{
"change_type": "MODIFY",
"old_path": "server/src/server.js",
"new_path": "server/src/server.js",
"diff": "@@ -58,9 +58,9 @@ if (cluster.isMaster) {\nconst router = express.Router();\nrouter.use('/images', express.static('images'));\n- router.use('/commlanding/images', express.static('images'));\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | use landing base route path to construct endpoints
Summary:
we should avoid hardcoding paths like /commlanding/. instead we should get the paths from the landing_url.json file.
depends on D3413
Test Plan: flow
Reviewers: atul, palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bis... |
129,190 | 21.03.2022 10:32:21 | -3,600 | aecb238e4d71a66292c293cdfd2ad140cb659de8 | [services] Backup - remove auth from implementation
Summary: We will no longer use authentication in the backup service.
Test Plan:
```
cd services
yarn run-backup-service
```
This should build
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"new_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"diff": "@@ -23,32 +23,10 @@ BackupServiceImpl::CreateNewBackup(grpc::CallbackServerContext *contex... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - remove auth from implementation
Summary: We will no longer use authentication in the backup service.
Test Plan:
```
cd services
yarn run-backup-service
```
This should build
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac
Differential Revisio... |
129,179 | 15.03.2022 12:41:29 | 14,400 | ec9b4fe9e731605cb74587e445d790922777d031 | [web] [refactor] move use unread into its own hook
Summary:
Move unread toggle into it's own hook. This functionality is used in native as well.
{F21455}
Test Plan: Toggle unread in web, make sure the functionality still works.
Reviewers: atul, palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/hooks/toggle-unread-status.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import {\n+ setThreadUnreadStatus,\n+ setThreadUnreadStatusActionTypes,\n+} from '../actions/activity-actions';\n+import type {\n+ SetThreadUnreadSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] move use unread into its own hook
Summary:
Move unread toggle into it's own hook. This functionality is used in native as well.
https://linear.app/comm/issue/ENG-861/refactor-unreadstatus-into-hook-for-both-native-and-web
{F21455}
Test Plan: Toggle unread in web, make sure the functionality still wor... |
129,179 | 21.03.2022 14:50:32 | 14,400 | 2674c50021d3466222de55b056d6aa60bc916cf2 | [web] [fix] update icons svg json to remove blue pre-fill colors.
Summary:
before: {F23760}
after: {F23761}
{F23762}
Test Plan: icons should render correctly with correct color
Reviewers: atul, def-au1t, palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/selection.json",
"new_path": "web/icons/selection.json",
"diff": "],\n\"attrs\": [\n{\n- \"fill\": \"rgb(0, 26, 114)\",\n\"opacity\": 0.15000000596046448\n},\n{\n- \"fill\": \"rgb(0, 26, 114)\",\n\"opacity\": 0.15000000596046448\n},\n- {\n- \"fill\":... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] ENG-897 update icons svg json to remove blue pre-fill colors.
Summary:
https://linear.app/comm/issue/ENG-897/fix-icons-with-blue-fill
before: {F23760}
after: {F23761}
{F23762}
Test Plan: icons should render correctly with correct color
Reviewers: atul, def-au1t, palys-swm, ashoat
Reviewed By: def-au1t... |
129,179 | 21.03.2022 14:58:55 | 14,400 | 31321ec29f341b13f561e2366cd01c23a38aba03 | [web] [fix] align unread buttons
Summary: there isn't a design for unread button, but I'd assume we would want to align the buttons across the board.
Test Plan: make sure buttons are aligned. (three dot vertical buttons)
Reviewers: atul, def-au1t, palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.css",
"new_path": "web/chat/chat-thread-list-item-menu.css",
"diff": "@@ -44,6 +44,10 @@ div.sidebar:hover .menu {\ndisplay: block;\n}\n+.menuSidebar {\n+ padding-right: 2px;\n+}\n+\nbutton.menuContent {\nborder: none;\ncurs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] align unread buttons
Summary: there isn't a design for unread button, but I'd assume we would want to align the buttons across the board.
Test Plan: make sure buttons are aligned. (three dot vertical buttons)
Reviewers: atul, def-au1t, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Ad... |
129,190 | 22.03.2022 09:38:37 | -3,600 | 82073b570fb58b893555a4d486ab2d45ed1f4706 | [services] Add comments about indexes
Summary:
Raised here
Adding comments in places where database indexes are needed.
Test Plan: None, these are just comments
Reviewers: palys-swm, varun, atul, geekbrother, jimpo, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h",
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h",
"diff": "@@ -9,6 +9,16 @@ namespace comm {\nnamespace network {\nnamespace database... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Add comments about indexes
Summary:
Raised here https://phabricator.ashoat.com/D3087#86770
Adding comments in places where database indexes are needed.
Test Plan: None, these are just comments
Reviewers: palys-swm, varun, atul, geekbrother, jimpo, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-s... |
129,179 | 14.03.2022 12:31:27 | 14,400 | f2ca31d0a87be35a49ebaa2ae41c4dc868725d76 | [web] [fix] hover state background color on thread list
Summary:
update the hover color
before: {F21536}
after: {F21535}
Test Plan: hover color should match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -24,9 +24,19 @@ div.thread:first-child {\npadding-top: 6px;\n}\ndiv.activeThread,\n-div.thread:hover,\ndiv.threadListSidebar:hover {\n- background: var(--selected-thread-b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] hover state background color on thread list
Summary:
https://linear.app/comm/issue/ENG-869/thread-list-hover-background-is-wrong-color, update the hover color
before: {F21536}
after: {F21535}
Test Plan: hover color should match figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoa... |
129,179 | 23.03.2022 09:40:36 | 14,400 | a5cee196b7a61aff71d65f01b9b964245d1d2703 | [web] [refactor] move props to single destructure in top of chat thread list item menu component
Summary: move props destructure to one place
Test Plan: N/A - shouldn't get any flow errors. Page should render normally
Reviewers: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.react.js",
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "@@ -15,9 +15,8 @@ type Props = {\n+renderStyle?: 'chat' | 'thread',\n};\nfunction ChatThreadListItemMenu(props: Props): React.Node {\n- const { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] move props to single destructure in top of chat thread list item menu component
Summary: move props destructure to one place
Test Plan: N/A - shouldn't get any flow errors. Page should render normally
Reviewers: atul
Reviewed By: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differe... |
129,179 | 25.03.2022 12:54:32 | 14,400 | dd249a8d6049e0ed68f3e6a5c63e54cc16de0a3d | [web] [refactor] destructure props in message preview component
Summary: no functionality changes. Just keeping the component consistent with the rest of the codebase and destructuring props.
Test Plan: message preview component still works like it did before changes.
Reviewers: atul, def-au1t, palys-swm
Subscribers: a... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-preview.react.js",
"new_path": "web/chat/message-preview.react.js",
"diff": "@@ -22,7 +22,15 @@ type Props = {\n+threadInfo: ThreadInfo,\n};\nfunction MessagePreview(props: Props): React.Node {\n- if (!props.messageInfo) {\n+ const {\n+ messag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] destructure props in message preview component
Summary: no functionality changes. Just keeping the component consistent with the rest of the codebase and destructuring props.
Test Plan: message preview component still works like it did before changes.
Reviewers: atul, def-au1t, palys-swm
Reviewed B... |
129,179 | 25.03.2022 13:02:46 | 14,400 | ec5704f78a30b36694686fbd1db118150164eb29 | [web] [refactor] message preview styles solidified into one ternary statement
Summary: move styles into a single call
Test Plan: click and hover about chat thread list items. Functionality should be the same
Reviewers: atul, def-au1t, palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -28,11 +28,11 @@ div.threadListSidebar:hover {\nbackground: var(--thread-active-bg);\n}\n-div.activeThread :is(div.dark, .lastMessage span.light, .title) {\n+div.activeThr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] message preview styles solidified into one ternary statement
Summary: move styles into a single call
Test Plan: click and hover about chat thread list items. Functionality should be the same
Reviewers: atul, def-au1t, palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm,... |
129,179 | 25.03.2022 13:31:21 | 14,400 | 426e725ba0427e10dbfdd7447fdbb3a187265842 | [web] [refactor] simplify username logic in message preview
Summary: simplify rendering logic for username in message preview
Test Plan: username logic is the same as production. No new functionality
Reviewers: atul, def-au1t, palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-preview.react.js",
"new_path": "web/chat/message-preview.react.js",
"diff": "@@ -48,30 +48,24 @@ function MessagePreview(props: Props): React.Node {\nthreadInfo,\ngetDefaultTextMessageRules().simpleMarkdownRules,\n);\n- if (messageInfo.type ==... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] simplify username logic in message preview
Summary: simplify rendering logic for username in message preview
Test Plan: username logic is the same as production. No new functionality
Reviewers: atul, def-au1t, palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisz... |
129,179 | 25.03.2022 13:59:22 | 14,400 | cf4fd35e30c523d22974dac976a90bdbbf0c9043 | [web] [refactor] move hasUsername logic to variable
Summary:
move logic to variable thats descriptive of what it checks for
{F25114}
{F25115}
Test Plan: no new added functionality, username should render as normal
Reviewers: atul, palys-swm, def-au1t, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-preview.react.js",
"new_path": "web/chat/message-preview.react.js",
"diff": "@@ -49,13 +49,13 @@ function MessagePreview(props: Props): React.Node {\ngetDefaultTextMessageRules().simpleMarkdownRules,\n);\n- let usernameText = null;\n- if (\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] move hasUsername logic to variable
Summary:
move logic to variable thats descriptive of what it checks for
{F25114}
{F25115}
Test Plan: no new added functionality, username should render as normal
Reviewers: atul, palys-swm, def-au1t, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Ad... |
129,190 | 21.03.2022 09:55:06 | -3,600 | 92c1f81fc0e5ef67c2df4cea95dffe1916ff2282 | [services] Backup - Update proto file
Summary: We want to remove authentication from the backup service
Test Plan: None, it's just a change in the proto file.
Reviewers: palys-swm, varun, jimpo, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/_generated/backup.pb.cc",
"new_path": "native/cpp/CommonCpp/grpc/_generated/backup.pb.cc",
"diff": "@@ -301,6 +301,7 @@ const ::PROTOBUF_NAMESPACE_ID::uint32 TableStruct_backup_2eproto::offsets[] PROT\n::PROTOBUF_NAMESPACE_ID::interna... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Update proto file
Summary: We want to remove authentication from the backup service
Test Plan: None, it's just a change in the proto file.
Reviewers: palys-swm, varun, jimpo, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac
Differential Revision: https:... |
129,191 | 18.03.2022 14:19:37 | -3,600 | 7d9fa21308344ae6551d4b163fadd3cfe8aada64 | [web] Directly render code that is no longer conditional
Summary:
Simplify the code by directly rendering instead of first assigning to a variable
{F24416}
{F24417}
{F24418}
Depends on D3473
Test Plan: Flow
Reviewers: benschac, atul, def-au1t
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/settings/password-change-modal.js",
"new_path": "web/settings/password-change-modal.js",
"diff": "@@ -65,8 +65,18 @@ class PasswordChangeModal extends React.PureComponent<Props, State> {\n}\nrender() {\n+ let errorMsg;\n+ if (this.state.errorMessage) {\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Directly render code that is no longer conditional
Summary:
Simplify the code by directly rendering instead of first assigning to a variable
{F24416}
{F24417}
{F24418}
Depends on D3473
Test Plan: Flow
Reviewers: benschac, atul, def-au1t
Reviewed By: benschac, atul
Subscribers: ashoat, Adrian, karol-bisztyga
... |
129,191 | 18.03.2022 14:22:44 | -3,600 | 1ab0d664e919bc270684bcc9e09bc45d29b3efb0 | [web] Update password modal copy
Summary:
Update the text that is displayed.
{F24324}
Depends on D3474
Test Plan: Flow
Reviewers: benschac, atul, def-au1t
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/settings/password-change-modal.js",
"new_path": "web/settings/password-change-modal.js",
"diff": "@@ -74,7 +74,11 @@ class PasswordChangeModal extends React.PureComponent<Props, State> {\nconst { inputDisabled } = this.props;\nreturn (\n- <Modal name=\"Edi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Update password modal copy
Summary:
Update the text that is displayed.
{F24324}
Depends on D3474
Test Plan: Flow
Reviewers: benschac, atul, def-au1t
Reviewed By: benschac, atul
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3475 |
129,190 | 29.03.2022 13:30:23 | -7,200 | 489a50d1db4cb1c6835eb9c30ed71997b7c4297d | [services] Backup - Add comments to the db entities
Summary:
Context
Some comments to clarify things around DB entities.
Test Plan: None - these are just comments
Reviewers: varun, geekbrother, jimpo, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h",
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h",
"diff": "@@ -10,6 +10,17 @@ namespace network {\nnamespace database {\n/**\n+ * bac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add comments to the db entities
Summary:
Context - https://phabricator.ashoat.com/D2950#93128
Some comments to clarify things around DB entities.
Test Plan: None - these are just comments
Reviewers: varun, geekbrother, jimpo, palys-swm
Reviewed By: varun, palys-swm
Subscribers: ashoat, palys-s... |
129,187 | 30.03.2022 15:13:22 | 14,400 | dcd0a2c4afbbae2bf3329229345bfb3c5a22ca9e | [server] Reorder Express routers
Summary: The order of these matters - see code comment.
Test Plan: I actually tested reordering these live on prod, and it worked
Reviewers: varun
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "server/src/server.js",
"new_path": "server/src/server.js",
"diff": "@@ -125,13 +125,11 @@ if (cluster.isMaster) {\n);\n};\n- const squadCalRouter = express.Router();\n- setupAppRouter(squadCalRouter);\n- server.use(squadCalBaseRoutePath, squadCalRouter);\n-\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Reorder Express routers
Summary: The order of these matters - see code comment.
Test Plan: I actually tested reordering these live on prod, and it worked
Reviewers: varun
Reviewed By: varun
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, yayabosh
Differential Revision: https://phabricator... |
129,179 | 30.03.2022 16:59:36 | 14,400 | cca39d8b963b035bac2c4b22cdb82af9c32afba4 | [native] [fix] update timestamp to lowercase
Summary:
{F27438} update timestamp to match web
web: {F27439}
Test Plan: open simulator, make sure the timestamp is lowercase
Reviewers: atul, yayabosh, def-au1t, palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "native/chat/timestamp.react.js",
"new_path": "native/chat/timestamp.react.js",
"diff": "@@ -19,11 +19,7 @@ function Timestamp(props: Props): React.Node {\nif (props.display === 'modal') {\nstyle.push(styles.modal);\n}\n- return (\n- <SingleLine style={style}>\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [fix] ENG-949 update timestamp to lowercase
Summary:
{F27438} update timestamp to match web
web: {F27439}
Test Plan: open simulator, make sure the timestamp is lowercase
Reviewers: atul, yayabosh, def-au1t, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga... |
129,190 | 31.03.2022 16:19:51 | -7,200 | 52ef4052d7ab552f754fe3d8d67439804753f48f | [services] Backup - Add client reactor base classes - bidi reactor
Summary:
Depends on D3513
Adding client base classes for reactors - bidi reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, jimpo, varun, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h",
"diff": "+#include <grpcpp/grpcpp.h>\n+\n+namespace comm {\n+namespace network {\n+namespace reactor {\n+\n+template <class Request, class ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add client reactor base classes - bidi reactor
Summary:
Depends on D3513
Adding client base classes for reactors - bidi reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, jimpo, varun, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, ... |
129,190 | 31.03.2022 16:19:54 | -7,200 | 886ec256ac88c18993fd7dd1abfc08ccbf885b84 | [services] Backup - Add client reactor base classes - read reactor
Summary:
Depends on D3465
Adding client base classes for reactors - read reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, varun, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h",
"diff": "+#include <grpcpp/grpcpp.h>\n+\n+namespace comm {\n+namespace network {\n+namespace reactor {\n+\n+template <class Request, class ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add client reactor base classes - read reactor
Summary:
Depends on D3465
Adding client base classes for reactors - read reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, varun, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, ... |
129,190 | 31.03.2022 16:19:56 | -7,200 | 3ffc1665dda6f86a3bdb700974de22c60c24e025 | [services] Backup - Add client reactor base classes - write reactor
Summary:
Depends on D3514
Adding client base classes for reactors - write reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: jimpo, geekbrother, palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h",
"diff": "+#include <grpcpp/grpcpp.h>\n+\n+namespace comm {\n+namespace network {\n+namespace reactor {\n+\n+template <class Request, class... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add client reactor base classes - write reactor
Summary:
Depends on D3514
Adding client base classes for reactors - write reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: jimpo, geekbrother, palys-swm, varun
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian... |
129,190 | 31.03.2022 16:19:59 | -7,200 | 3d75f07ca0c529a3553f75c714fb62fb583abd22 | [services] Backup - Add blob client
Summary:
Depends on D3515
Adding blob client to the backup service
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, varun, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Reactors/client/blob/BlobPutClientReactor.h",
"diff": "+#pragma once\n+\n+#include \"ClientBidiReactorBase.h\"\n+#include \"Constants.h\"\n+\n+#include \"../_generated/blob.grpc.pb.h\"\n+#include... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add blob client
Summary:
Depends on D3515
Adding blob client to the backup service
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, varun, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac
Differential Revision: https:... |
129,190 | 31.03.2022 16:20:01 | -7,200 | cd537913f227b2af6d1f87318b23c3e412c751c0 | [services] Backup - Add server reactor implementations - pull backup reactor
Summary:
Depends on D3466
Add implementation for the pull backup reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, varun, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"diff": "+#pragma once\n+\n+#include \"ServerBidiReactorBase.h\"\n+\n+#include \"../_generated/backup.grpc.pb.h\"\n+#include \"../_generated/backup.pb.h\"\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add server reactor implementations - pull backup reactor
Summary:
Depends on D3466
Add implementation for the pull backup reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, varun, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian... |
129,179 | 31.03.2022 10:28:38 | 14,400 | e84e0e6f1daa0ab99a684744f6a190e2cb35db49 | [web] [refactor] destructure props to match project
Summary: update props to stay consistent with project in side-bar item
Test Plan: side bar item still renders and shows unread as expected
Reviewers: atul, palys-swm, def-au1t, yayabosh
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/sidebar-item.react.js",
"new_path": "web/chat/sidebar-item.react.js",
"diff": "@@ -13,10 +13,15 @@ type Props = {\n+sidebarInfo: SidebarInfo,\n};\nfunction SidebarItem(props: Props): React.Node {\n- const { threadInfo } = props.sidebarInfo;\n+ const {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] destructure props to match project
Summary: update props to stay consistent with project in side-bar item
Test Plan: side bar item still renders and shows unread as expected
Reviewers: atul, palys-swm, def-au1t, yayabosh
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga... |
129,184 | 30.03.2022 16:19:46 | 14,400 | 519041e90b4ca64aea6744dee6575bfce7176f0e | [web] Add hover states to "Focus"/"Background" tabs
Summary: Quick thing to make things feel more interactive:
Test Plan:
Looks as expected:
{F27416}
Reviewers: def-au1t, palys-swm, benschac
Subscribers: ashoat, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -28,6 +28,11 @@ div.tabItem {\ncolor: var(--color-disabled);\nborder: 2px solid var(--border-color);\nborder-width: 0 0 3px 0;\n+ transition: 150ms;\n+}\n+div.tabItem:hover {\n+ color: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add hover states to "Focus"/"Background" tabs
Summary: Quick thing to make things feel more interactive: https://linear.app/comm/issue/ENG-952/introduce-hover-states-for-focus-and-background-tabs
Test Plan:
Looks as expected:
{F27416}
Reviewers: def-au1t, palys-swm, benschac
Reviewed By: palys-swm
Subscriber... |
129,184 | 29.03.2022 15:32:43 | 14,400 | 852cfc7624596b8c2bedebfa5394761030b2c588 | [web] Increase clickable region of `ChatThreadListSidebar`
Summary:
Basically D3543 but for `ChatThreadListSidebar`
Clickable area before:
{F26853}
Clickable area after:
{F26854}
Test Plan: Looks and behaves as expected: [will drag in video on phabricator]
Reviewers: ashoat, palys-swm, def-au1t
Subscribers: Adrian, kar... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-sidebar.react.js",
"new_path": "web/chat/chat-thread-list-sidebar.react.js",
"diff": "@@ -5,7 +5,10 @@ import * as React from 'react';\nimport type { SidebarInfo } from 'lib/types/thread-types';\n-import { useThreadIsActive } from '..... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Increase clickable region of `ChatThreadListSidebar`
Summary:
Basically D3543 but for `ChatThreadListSidebar`
Clickable area before:
{F26853}
Clickable area after:
{F26854}
Test Plan: Looks and behaves as expected: [will drag in video on phabricator]
Reviewers: ashoat, palys-swm, def-au1t
Reviewed By: ashoa... |
129,184 | 30.03.2022 14:54:07 | 14,400 | b5745bc3701bb9646a20a45df73271d8f31bf652 | [web] Add message timestamp to `MessageActionButtons` component
Summary:
Display message timestamp in `MessageActionButtons` on hover. Additional context here:
Depends on D3570
Test Plan:
Looks as expected:
{F27368}
Reviewers: def-au1t, palys-swm, ashoat, benschac
Subscribers: Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-buttons.css",
"new_path": "web/chat/message-action-buttons.css",
"diff": "@@ -6,6 +6,25 @@ div.messageActionContainer {\npadding: 0 6px;\nbackground-color: var(--message-action-tooltip-bg);\nborder-radius: 8px;\n+ width: fit-content;\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add message timestamp to `MessageActionButtons` component
Summary:
Display message timestamp in `MessageActionButtons` on hover. Additional context here: https://linear.app/comm/issue/ENG-799/message-tooltip-position-is-incorrect
---
Depends on D3570
Test Plan:
Looks as expected:
{F27368}
Reviewers: def-au1t... |
129,179 | 07.03.2022 16:01:31 | 18,000 | 8fa68bd370814c4856e079baaa8164d9a342b223 | [2/n] [landing] add team to footer component
Summary:
add team link to footer
{F6678}
Test Plan: click the footer link, make sure it goes to team page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -5,6 +5,8 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { NavLink } from 'react-router-dom';\n+import { isDev } from 'l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] [landing] add team to footer component
Summary:
add team link to footer
{F6678}
Test Plan: click the footer link, make sure it goes to team page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.... |
129,190 | 01.04.2022 08:33:37 | -7,200 | d7d2a98056ef738e591431a03c736c671ac1364f | [services] Backup - Add server reactor implementations - create new backup reactor
Summary:
Depends on D3517
Add implementation for the create new backup reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, varun, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h",
"diff": "+#pragma once\n+\n+#include \"ServerBidiReactorBase.h\"\n+#include \"ServiceBlobClient.h\"\n+#include \"Tools.h\"\n+\n+#include \"../_generated... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add server reactor implementations - create new backup reactor
Summary:
Depends on D3517
Add implementation for the create new backup reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, varun, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys... |
129,190 | 01.04.2022 08:35:14 | -7,200 | a54d824439a5f407e93dc17eb928ad0a2e3d5e56 | [services] Backup - Add server reactor implementations - send log reactor
Summary:
Depends on D3467
Add implementation for the send log reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, varun, geekbrother, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"diff": "+#pragma once\n+\n+#include \"ServerReadReactorBase.h\"\n+\n+#include \"../_generated/backup.grpc.pb.h\"\n+#include \"../_generated/backup.pb.h\"\n+\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add server reactor implementations - send log reactor
Summary:
Depends on D3467
Add implementation for the send log reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, varun, geekbrother, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul... |
129,190 | 01.04.2022 08:35:58 | -7,200 | c6533b46436e797d71a2e0f0468902abd480e8dd | [services] Backup - Add server reactor implementations - recover backup key reactor
Summary:
Depends on D3516
Add implementation for the recover backup key reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, varun, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benscha... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.h",
"diff": "+#pragma once\n+\n+#include \"ServerBidiReactorBase.h\"\n+\n+#include \"../_generated/backup.grpc.pb.h\"\n+#include \"../_generated/backup.pb.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add server reactor implementations - recover backup key reactor
Summary:
Depends on D3516
Add implementation for the recover backup key reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, varun, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, pal... |
129,190 | 01.04.2022 08:36:32 | -7,200 | 6cede023718fff4a85f3e11b4486f862c3bbed55 | [services] Backup - Update service implementation
Summary:
Depends on D3518
Use server reactor implementations from the D3467 in the service implementation
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: jimpo, geekbrother, varun, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"new_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"diff": "#include \"BackupServiceImpl.h\"\n-#include \"ServerBidiReactorBase.h\"\n-#include \"Serve... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Update service implementation
Summary:
Depends on D3518
Use server reactor implementations from the D3467 in the service implementation
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: jimpo, geekbrother, varun, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, ... |
129,185 | 25.03.2022 13:18:39 | -3,600 | 60780083d92072fb85e803293b87bab04b4c5020 | [web] Introduce member action callbacks in `ThreadMember` component
Summary: Introduce callbacks in menu in `ThreadMember` component - the same that are used in mobile app.
Test Plan: The actions can be tested after introducing memebrs modal
Reviewers: palys-swm, benschac, atul
Subscribers: ashoat, palys-swm, Adrian, a... | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/members/member.react.js",
"new_path": "web/modals/threads/members/member.react.js",
"diff": "@@ -8,10 +8,16 @@ import {\nimport classNames from 'classnames';\nimport * as React from 'react';\n+import {\n+ removeUsersFromThread,\n+ changeThre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce member action callbacks in `ThreadMember` component
Summary: Introduce callbacks in menu in `ThreadMember` component - the same that are used in mobile app.
Test Plan: The actions can be tested after introducing memebrs modal
Reviewers: palys-swm, benschac, atul
Reviewed By: palys-swm
Subscribers: ... |
129,185 | 25.03.2022 13:18:46 | -3,600 | bc98f9ff50f326f11fb67ee2f9bc844b355c9b7c | [web] Introduce `MembersModal`
Summary:
Introduce modal with thread members. It contains tabs with members and admins lists.
{F19103}
Test Plan: It can be run from thread actions menu after the following diff.
Reviewers: palys-swm, benschac, atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, ben... | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/members/members-modal.css",
"new_path": "web/modals/threads/members/members-modal.css",
"diff": "+div.membersContainer {\n+ display: flex;\n+ flex-direction: column;\n+ overflow: hidden;\n+ margin: 16px;\n+}\n+\ndiv.membersList {\noverflow: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `MembersModal`
Summary:
Introduce modal with thread members. It contains tabs with members and admins lists.
{F19103}
Test Plan: It can be run from thread actions menu after the following diff.
Reviewers: palys-swm, benschac, atul, ashoat
Reviewed By: palys-swm, benschac, ashoat
Subscribers: ashoat... |
129,200 | 01.04.2022 15:24:13 | 14,400 | 1525275526a6f477440106d459afe2a2598f9ea4 | [docs] make visual studio code section more precise
Summary: removed an unnecessary sentence and changed `VSCode` to `Visual Studio Code`
Test Plan: docs
Reviewers: geekbrother, atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "docs/dev_services.md",
"new_path": "docs/dev_services.md",
"diff": "@@ -56,6 +56,6 @@ You can find the full list of scripts [here](https://github.com/CommE2E/comm/blo\n# Developing and debugging\n-## VSCode\n+## Visual Studio Code\n-If you are using VSCode as ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docs] make visual studio code section more precise
Summary: removed an unnecessary sentence and changed `VSCode` to `Visual Studio Code`
Test Plan: docs
Reviewers: geekbrother, atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, benschac, yayabosh
Differential Revision:... |
129,190 | 01.04.2022 08:50:16 | -7,200 | d0b3a163e2fb4be1fe5d5738aea80e15dfbeb3a3 | [services] Blob - Add server reactor implementations - get reactor
Summary:
Depends on D3520
Add implementations for the server reactors - get reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, varun, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/blob/src/Reactors/server/GetReactor.h",
"diff": "+#pragma once\n+\n+#include \"ServerWriteReactorBase.h\"\n+\n+#include \"../_generated/blob.grpc.pb.h\"\n+#include \"../_generated/blob.pb.h\"\n+\n+#include <aws/s3/model/GetObjectRequest... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Blob - Add server reactor implementations - get reactor
Summary:
Depends on D3520
Add implementations for the server reactors - get reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, varun, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adria... |
129,190 | 01.04.2022 08:50:19 | -7,200 | 0f1c274ceed378cfbe728e15347ba80695cc460f | [services] Blob - Add server reactor implementations - put reactor
Summary:
Depends on D3470
Add implementations for the server reactors - put reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, varun, jimpo, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/blob/src/Reactors/server/PutReactor.h",
"diff": "+#pragma once\n+\n+#include \"ServerBidiReactorBase.h\"\n+\n+#include \"../_generated/blob.grpc.pb.h\"\n+#include \"../_generated/blob.pb.h\"\n+\n+#include <memory>\n+#include <string>\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Blob - Add server reactor implementations - put reactor
Summary:
Depends on D3470
Add implementations for the server reactors - put reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, varun, jimpo, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, ... |
129,190 | 01.04.2022 08:50:23 | -7,200 | 9262ba1f6dfa8402217e77e183a88c7393312f44 | [services] Blob - Update service implementation
Summary:
Depends on D3521
Update implementation of the blob service
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, jimpo, varun
Subscribers: ashoat, palys-swm, Adrian, atul, benschac | [
{
"change_type": "MODIFY",
"old_path": "services/blob/src/BlobServiceImpl.cpp",
"new_path": "services/blob/src/BlobServiceImpl.cpp",
"diff": "#include \"MultiPartUploader.h\"\n#include \"Tools.h\"\n+#include \"GetReactor.h\"\n+#include \"PutReactor.h\"\n+\n#include <iostream>\n#include <memory>\n@@ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Blob - Update service implementation
Summary:
Depends on D3521
Update implementation of the blob service
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: geekbrother, palys-swm, jimpo, varun
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac
Differential Rev... |
129,179 | 04.04.2022 10:24:43 | 14,400 | 18a5e194e034a9549a9e95b61c1fe2054a286ac0 | [web] [refactor] use assetUrl variable
Summary:
swap hard coded url for assetUrl variable like the rest of the project uses.
{F29632}
Test Plan: go to the keyserver page. arrow should render.
Reviewers: atul, palys-swm, def-au1t, yayabosh
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "landing/read-docs-btn.react.js",
"new_path": "landing/read-docs-btn.react.js",
"diff": "import * as React from 'react';\n+import { assetUrl } from './asset-meta-data';\nimport css from './read-docs-btn.css';\nfunction ReadDocsButton(): React.Node {\n@@ -12,10 ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] use assetUrl variable
Summary:
swap hard coded url for assetUrl variable like the rest of the project uses.
{F29632}
Test Plan: go to the keyserver page. arrow should render.
Reviewers: atul, palys-swm, def-au1t, yayabosh
Reviewed By: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, y... |
129,179 | 05.04.2022 15:45:18 | 14,400 | 98a4cdea0d312527ebe7a45bbce7cf2638d5eb83 | [web] [refactor] rename assetUrl to assetsCacheURLPrefix
Summary:
rename, did a findall, replace using vscode tool
Test Plan: run landing project. Images load
Reviewers: atul, palys-swm, def-au1t, yayabosh
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "landing/asset-meta-data.js",
"new_path": "landing/asset-meta-data.js",
"diff": "@@ -11,11 +11,11 @@ export type Asset = {\n+infoStyle: string,\n};\n-export const assetUrl = 'https://dh9fld3hutpxf.cloudfront.net';\n+export const assetsCacheURLPrefix = 'https://... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] [ENG-971] rename assetUrl to assetsCacheURLPrefix
Summary:
rename, did a findall, replace using vscode tool
https://linear.app/comm/issue/ENG-971/rename-asseturl-to-assetscacheurlprefix
Test Plan: run landing project. Images load
Reviewers: atul, palys-swm, def-au1t, yayabosh
Reviewed By: atul
Su... |
129,179 | 04.04.2022 15:56:48 | 14,400 | d04163e9c8f7d8aa55a0e2265a25fda56556d3a5 | [web] [refactor] destructure props in confirm-leave-thread-modal
Summary:
just moving props to a destructure on top of file
Test Plan: click leave button
Reviewers: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/confirm-leave-thread-modal.react.js",
"new_path": "web/modals/threads/confirm-leave-thread-modal.react.js",
"diff": "@@ -14,16 +14,19 @@ type Props = {\n+onConfirm: () => void,\n};\nfunction ConfirmLeaveThreadModal(props: Props): React.Node ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] [ENG-716] destructure props in confirm-leave-thread-modal
Summary:
just moving props to a destructure on top of file
https://linear.app/comm/issue/ENG-716/introduce-leave-channel-modal
Test Plan: click leave button
Reviewers: atul
Reviewed By: atul
Subscribers: ashoat, palys-swm, Adrian, karol-b... |
129,203 | 01.04.2022 17:22:38 | 25,200 | a3532d10d1c37e3a5bfc2cd5852eb7e0f1816d82 | [web] Removed extraneous `.loading-indicator-loading` CSS selector
Summary: Noticed this CSS selector and rule was repeated twice in the same file. Removed the second occurrence.
Test Plan: Close reading.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, benschac | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -107,9 +107,6 @@ span.loading-indicator-loading {\ntransform: rotate(360deg);\n}\n}\n-span.loading-indicator-loading {\n- display: inline-block;\n-}\nspan.loading-indicator-loading-medium:after {\nconten... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Removed extraneous `.loading-indicator-loading` CSS selector
Summary: Noticed this CSS selector and rule was repeated twice in the same file. Removed the second occurrence.
Test Plan: Close reading.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, bens... |
129,184 | 05.04.2022 13:58:27 | 14,400 | ad6d2646d75105368b67da72db6ebea825cc6bb2 | [docs] Fix `generate-olm-config.js` script in `dev_environment` docs
Summary: filename suffix should've been `.js` not `.json`
Test Plan: didn't work before, now it does work
Reviewers: palys-swm, ashoat, benschac, yayabosh
Subscribers: Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "docs/dev_environment.md",
"new_path": "docs/dev_environment.md",
"diff": "@@ -573,7 +573,7 @@ The second config file contains some details that the keyserver needs in order t\n```\ncd keyserver\n-yarn script dist/scripts/generate-olm-config.json\n+yarn script ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docs] Fix `generate-olm-config.js` script in `dev_environment` docs
Summary: filename suffix should've been `.js` not `.json`
Test Plan: didn't work before, now it does work
Reviewers: palys-swm, ashoat, benschac, yayabosh
Reviewed By: ashoat, yayabosh
Subscribers: Adrian, karol-bisztyga, yayabosh
Differential R... |
129,187 | 30.03.2022 11:28:17 | 14,400 | 8c887ebc7fb9702487fe3873534528c7b835fb72 | [lib] New action to fetch single message for a list of threads
Summary: Needed to fetch messages for message previews
Test Plan: promised to help test this :)
Reviewers: def-au1t
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, yayabosh, def-au1t | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/message-actions.js",
"new_path": "lib/actions/message-actions.js",
"diff": "@@ -5,6 +5,7 @@ import invariant from 'invariant';\nimport type {\nFetchMessageInfosPayload,\nSendMessageResult,\n+ SimpleMessagesPayload,\n} from '../types/message-types';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] New action to fetch single message for a list of threads
Summary: Needed to fetch messages for message previews
Test Plan: @def-au1t promised to help test this :)
Reviewers: def-au1t
Reviewed By: def-au1t
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, yayabosh, def-au1t
Differential Revisio... |
129,190 | 07.04.2022 11:38:59 | -7,200 | 0d5cbefb48f1288b72ed88d729fd266796de144c | [services] Backup - Apply reading log chunk in send log reactor
Summary:
Depends on D3531
After reading the user id we want to read log chunks
Test Plan: backup service build
Reviewers: palys-swm, geekbrother, varun, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"diff": "@@ -44,6 +44,14 @@ SendLogReactor::readRequest(backup::SendLogReques... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Apply reading log chunk in send log reactor
Summary:
Depends on D3531
After reading the user id we want to read log chunks
Test Plan: backup service build
Reviewers: palys-swm, geekbrother, varun, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
Di... |
129,190 | 01.04.2022 08:51:00 | -7,200 | 0d2aef2ffe0a7e4b25c32dbf883fd66bb5dedc2a | [services] Backup - Use terminateCallback for create new backup reactor
Summary:
Depends on D3560
Use termination callback (added in the previous diff) in `CreateNewBackupReactor`.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, jimpo, varun
Subscribers: ashoat, palys-swm, Adri... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h",
"diff": "@@ -45,7 +45,7 @@ public:\nstd::unique_ptr<ServerBid... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Use terminateCallback for create new backup reactor
Summary:
Depends on D3560
Use termination callback (added in the previous diff) in `CreateNewBackupReactor`.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, jimpo, varun
Reviewed By: palys-swm
Subscri... |
129,184 | 07.04.2022 11:19:37 | 14,400 | ab4844f485a0147b896579ec1261e5a9dca252c1 | [web] Remove unused CSS selectors from `thread-settings-modal.css`
Summary: Remove CSS selectors that are obviously unused.
Test Plan: IDE would give me a red squiggle in JSX if selector was missing.
Reviewers: palys-swm, def-au1t, ashoat
Subscribers: Adrian, karol-bisztyga, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/thread-settings-modal.css",
"new_path": "web/modals/threads/thread-settings-modal.css",
"diff": "@@ -9,19 +9,11 @@ div.modal-body {\ndisplay: flex;\nflex-direction: column;\n}\n-div.resized-modal-body {\n- min-height: 250px;\n-}\ndiv.modal-b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove unused CSS selectors from `thread-settings-modal.css`
Summary: Remove CSS selectors that are obviously unused.
Test Plan: IDE would give me a red squiggle in JSX if selector was missing.
Reviewers: palys-swm, def-au1t, ashoat
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga, benschac, yayabosh
... |
129,179 | 06.04.2022 16:03:35 | 14,400 | 7493f1a8982a6252c4de12cf81b51d8fe7191dfd | [web] [fix] calendar hover history + add show on hover
Summary:
on hover, add and history prompt are now visible
{F31678}
Test Plan: hover over days on the calendar
Reviewers: atul, palys-swm, def-au1t
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -141,7 +141,7 @@ span.rightActionLinks {\noverflow: hidden;\n}\ndiv.actionLinks svg {\n- fill: gray;\n+ fill: var(--fg);\nwidth: 10px;\nheight: 10px;\n}\n@@ -150,7 +150,7 @@ div.a... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] [ENG-965] calendar hover history + add show on hover
Summary:
on hover, add and history prompt are now visible
https://linear.app/comm/issue/ENG-965/calendar-buttons-only-visible-on-hover
{F31678}
Test Plan: hover over days on the calendar
Reviewers: atul, palys-swm, def-au1t
Reviewed By: palys-swm
Sub... |
129,185 | 08.04.2022 16:03:16 | -7,200 | 93d5f95888fc080104bffedd07e5c700f9fd3720 | [web] Introduce `Subchannels` action in thread menu
Summary:
Introduce action in thread menu, that launches subchannels modal
{F28442}
Test Plan: In thread actions menu subchannels action should be available for thread that contain some subchannels
Reviewers: palys-swm, benschac, atul
Subscribers: ashoat, Adrian, atul,... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/thread-menu.react.js",
"new_path": "web/chat/thread-menu.react.js",
"diff": "@@ -28,6 +28,7 @@ import SidebarListModal from '../modals/chat/sidebar-list-modal.react';\nimport { useModalContext } from '../modals/modal-provider.react';\nimport ConfirmLe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `Subchannels` action in thread menu
Summary:
Introduce action in thread menu, that launches subchannels modal
{F28442}
Test Plan: In thread actions menu subchannels action should be available for thread that contain some subchannels
Reviewers: palys-swm, benschac, atul
Reviewed By: palys-swm
Subscr... |
129,179 | 11.04.2022 11:42:19 | 14,400 | ee737ed798bf8b057f7ed4c25e5bea456e351031 | [lib] [feat] add useIsomorphicLayoutEffect hook
Summary: Add useIsomorphicLayoutEffect hook to lib folder
Test Plan: N/A it's not used yet. It's an exact copy of useIsomorphicLayoutEffect in `keyserver.react.js` in `landing`
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/hooks/isomorphic-layout-effect.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+export const useIsomorphicLayoutEffect: typeof React.useEffect =\n+ typeof window !== 'undefined' ? React.useLayoutEffect : React.useEffec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] [feat] add useIsomorphicLayoutEffect hook
Summary: Add useIsomorphicLayoutEffect hook to lib folder
Test Plan: N/A it's not used yet. It's an exact copy of useIsomorphicLayoutEffect in `keyserver.react.js` in `landing`
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-... |
129,184 | 07.04.2022 17:58:39 | 14,400 | f5406d5fa9cf521f8b0cc16975ee9f4ccb7a9159 | [web] Introduce `ColorSelectorButton` component with basic styling
Summary:
Introduce `ColorSelectorButton` component with basic styling.
Note: The actual functionality will be introduced in subsequent diffs.
Test Plan:
Looks as expected (each of the colored circles is a `ColorSelectorButton`):
{F32715}
Reviewers: paly... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/threads/color-selector-button.css",
"diff": "+div.container {\n+ height: 48px;\n+ width: 48px;\n+ border-radius: 24px;\n+ cursor: pointer;\n+ align-items: center;\n+ justify-content: center;\n+ display: flex;\n+ transition: 150ms;\n+}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `ColorSelectorButton` component with basic styling
Summary:
Introduce `ColorSelectorButton` component with basic styling.
Note: The actual functionality will be introduced in subsequent diffs.
Test Plan:
Looks as expected (each of the colored circles is a `ColorSelectorButton`):
{F32715}
Reviewers:... |
129,184 | 07.04.2022 18:39:27 | 14,400 | c673fd7cc38903ca5c82dd963e5462d7ffd89a83 | [web] Introduce `ColorSelector` component with basic styling
Summary:
Introduce `ColorSelector` component with basic layout/styling.
Note: The actual functionality will be introduced in subsequent diffs.
Depends on D3660
Test Plan:
Looks as expected:
{F32745}
Reviewers: palys-swm, def-au1t, benschac
Subscribers: Adrian... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/threads/color-selector.css",
"diff": "+div.container {\n+ display: flex;\n+ flex-direction: column;\n+ width: 100%;\n+}\n+\n+div.row {\n+ display: flex;\n+ flex-direction: row;\n+ align-items: center;\n+ justify-content: space-between... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `ColorSelector` component with basic styling
Summary:
Introduce `ColorSelector` component with basic layout/styling.
Note: The actual functionality will be introduced in subsequent diffs.
---
Depends on D3660
Test Plan:
Looks as expected:
{F32745}
Reviewers: palys-swm, def-au1t, benschac
Reviewed... |
129,184 | 10.04.2022 21:18:18 | 14,400 | b51b1aa74d0e07ecfdfe33a1cc14a56054c3a758 | [web] Rearrange `selectedThreadColorsObj` in `thread-utils`
Summary: Change the order of colors in `thread-utils` to match the order that we want in the `ColorSelector` component.
Test Plan: Looks as expected.
Reviewers: palys-swm, def-au1t, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -83,15 +83,15 @@ function colorIsDark(color: string): boolean {\n}\nconst selectedThreadColorsObj = {\n- 'B8753D': 1,\n- 'C85000': 2,\n- 'AA4B4B': 3,\n- '4B87AA': 4,\n- '648CAA'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rearrange `selectedThreadColorsObj` in `thread-utils`
Summary: Change the order of colors in `thread-utils` to match the order that we want in the `ColorSelector` component.
Test Plan: Looks as expected.
Reviewers: palys-swm, def-au1t, ashoat
Reviewed By: ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, b... |
129,179 | 12.04.2022 14:30:26 | 14,400 | 81b208556caffba788927b9ae996499ee48194ca | [landing] [feat] add team layout
Summary: adds generic layout to match expo.dev
Test Plan: layout should generally look the same
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/team.css",
"diff": "+.wrapper {\n+ padding: 16px 0;\n+ margin: 0 auto 48px auto;\n+}\n+\n+.header {\n+ font-family: 'iA Writer Duo S', monospace;\n+ font-weight: 500;\n+ line-height: 1.35;\n+ text-align: center;\n+ --scale: calc(0.75rem ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] [feat] [ENG-353] add team layout
Summary: adds generic layout to match expo.dev https://expo.dev/about
Test Plan: layout should generally look the same
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh
Differential Revision: https://phabri... |
129,179 | 08.04.2022 10:03:40 | 14,400 | ee7f08fabbeb768bc9f7f3b0439185f742e6a975 | [landing] [chore] remove isDev flags
Summary: remove dev flags
Test Plan: works on both production and development
Reviewers: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -5,8 +5,6 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { NavLink } from 'react-router-dom';\n-import { isDev } from 'l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] [chore] remove isDev flags
Summary: remove dev flags
Test Plan: works on both production and development
Reviewers: atul
Reviewed By: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh
Differential Revision: https://phabricator.ashoat.com/D3673 |
129,190 | 13.04.2022 13:02:43 | -7,200 | c59027f71a3222939ed28886d317d7d6cbd69dd0 | [services] Backup - mind empty attachment holders
Summary:
Depends on D3583
Use `assignItemFromDatabaseUserIDCreatedIndex` method introduced in the previous diff in the `DatabaseManager`.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, jimpo, varun
Subscribers: ashoat, palys-sw... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/DatabaseManager.cpp",
"new_path": "services/backup/docker-server/contents/server/src/DatabaseManager.cpp",
"diff": "@@ -126,9 +126,11 @@ void DatabaseManager::putLogItem(const LogItem &item) {\nrequest.AddItem(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - mind empty attachment holders
Summary:
Depends on D3583
Use `assignItemFromDatabaseUserIDCreatedIndex` method introduced in the previous diff in the `DatabaseManager`.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother, jimpo, varun
Reviewed By: palys-swm
... |
129,190 | 07.04.2022 16:47:14 | -7,200 | 13281b52060f4154e70ad12cdb78f86d29d0e0a5 | [services] Backup - Send log - add store in database
Summary:
Depends on D3585
Add logic for storing the log data in the database.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, jimpo, varun, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"diff": "@@ -31,9 +31,14 @@ class SendLogReactor : public ServerReadReactorBa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Send log - add store in database
Summary:
Depends on D3585
Add logic for storing the log data in the database.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, jimpo, varun, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, y... |
129,190 | 07.04.2022 16:47:17 | -7,200 | 423e9137192f8736d2d85143e22e6b82d42f996d | [services] Backup - Send log - initialize put reactor method
Summary:
Depends on D3586
Adding a method called `initializePutReactor` for initializing the put client reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, ya... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"diff": "#include \"Constants.h\"\n#include \"ServerReadReactorBase.h\"\n+#in... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Send log - initialize put reactor method
Summary:
Depends on D3586
Adding a method called `initializePutReactor` for initializing the put client reactor
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-sw... |
129,190 | 07.04.2022 16:47:22 | -7,200 | 6fd6264896255fadf54ad5543f1557731324eaea | [services] Backup - Send log - add reactor state mutex
Summary:
Depends on D3647
Adding a mutex for reactor's methods. The reason for this is explained in the comments.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabo... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h",
"diff": "@@ -40,6 +40,7 @@ class SendLogReactor : public ServerReadReactorBas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Send log - add reactor state mutex
Summary:
Depends on D3647
Adding a mutex for reactor's methods. The reason for this is explained in the comments.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, A... |
129,190 | 07.04.2022 16:47:36 | -7,200 | a122d984366560cac0f15c87bd6ae42a09bde288 | [services] Blob - Fix test name for storage manager tests
Summary:
Depends on D3594
This name was just wrong
Test Plan:
```
cd services
yarn test-blob-service
```
still works
Reviewers: geekbrother, palys-swm, varun, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/blob/test/StorageManagerTest.cpp",
"new_path": "services/blob/test/StorageManagerTest.cpp",
"diff": "using namespace comm::network;\n-class AWSToolsTest : public testing::Test {\n+class StorageManagerTest : public testing::Test {\npublic:\nprotected:\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Blob - Fix test name for storage manager tests
Summary:
Depends on D3594
This name was just wrong
Test Plan:
```
cd services
yarn test-blob-service
```
still works
Reviewers: geekbrother, palys-swm, varun, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
Di... |
129,190 | 13.04.2022 14:10:47 | -7,200 | ffec9cf8362a18fba086ba9554d5e5a01e0c3d7e | [services] Backup - Add blob get client reactor
Summary:
Depends on D3627
Adding blob client reactor for `get` operation.
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/client/blob/BlobGetClientReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/client/blob/BlobGetClientReactor.h",
"diff": "#pragma once\n#include \"ClientReadReactorBase... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add blob get client reactor
Summary:
Depends on D3627
Adding blob client reactor for `get` operation.
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
Differential Revision: https://phabri... |
129,190 | 07.04.2022 16:47:53 | -7,200 | fb2954458f3350c3295fa355749253cec91da24e | [services] Backup - Implement get method in service blob client
Summary:
Depends on D3630
Just calling `Get` method in `ServiceBlobClient`
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h",
"new_path": "services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h",
"diff": "#pragma once\n+#include \"BlobGetClientReactor.h\"\n#include \"BlobPut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Implement get method in service blob client
Summary:
Depends on D3630
Just calling `Get` method in `ServiceBlobClient`
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
Differential Revisio... |
129,190 | 07.04.2022 16:47:56 | -7,200 | 56ca2282dde43f8eddcb7d27d793179a8a6ba902 | [services] Backup - pull backup reactor - initialize get reactor
Summary:
Depends on D3632
Adding basic structure for `PullBackupReactor` as well as the logic for `initializeGetReactor`.
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"diff": "#pragma once\n+#include \"BlobGetClientReactor.h\"\n+#include ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - pull backup reactor - initialize get reactor
Summary:
Depends on D3632
Adding basic structure for `PullBackupReactor` as well as the logic for `initializeGetReactor`.
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian... |
129,190 | 07.04.2022 16:50:52 | -7,200 | c593d0fa82e55252bd451f653d13e2fb4a1f55a4 | [services] Backup - pull backup reactor - compaction - initialize
Summary:
Depends on D3633
Adding logic for the `initialize` method.
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"diff": "@@ -29,6 +29,7 @@ class PullBackupReactor : public ServerWrite... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - pull backup reactor - compaction - initialize
Summary:
Depends on D3633
Adding logic for the `initialize` method.
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
Differential Revision: ht... |
129,190 | 07.04.2022 16:50:55 | -7,200 | bf058231b3dfc55cbefa80225301ae87ff71d70b | [services] Backup - pull backup reactor - compaction - write response
Summary:
Depends on D3637
The logic for `writeResponse` handling writing compaction chunks
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"diff": "@@ -88,8 +88,29 @@ void PullBackupReactor::initialize() {\nstd... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - pull backup reactor - compaction - write response
Summary:
Depends on D3637
The logic for `writeResponse` handling writing compaction chunks
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh... |
129,190 | 07.04.2022 16:50:58 | -7,200 | 797df3207b7f7748d35e75c46b2cc8fd71abe921 | [services] Backup - Log item - handle lack of attachment holders
Summary:
Depends on D3634
Handle a case when the log item does not have attachment holders.
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.cpp",
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.cpp",
"diff": "@@ -56,8 +56,11 @@ void LogItem::assignItemFromDatabase(const AttributeValue... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Log item - handle lack of attachment holders
Summary:
Depends on D3634
Handle a case when the log item does not have attachment holders.
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
Di... |
129,179 | 13.04.2022 08:40:35 | 14,400 | 53e27e650642e99432e2aaf6606bd7d3dcd478d8 | [web] [fix] replace useLayoutEffect with useEffect
Summary:
useLayoutEffect isn't needed here
Test Plan: open and close the menu button in header
Reviewers: atul, def-au1t, palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/components/menu.react.js",
"new_path": "web/components/menu.react.js",
"diff": "@@ -58,11 +58,7 @@ function Menu(props: MenuProps): React.Node {\nreturn () => window.removeEventListener('resize', updatePosition);\n}, [updatePosition]);\n- // useLayoutEffec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] [ENG-986] replace useLayoutEffect with useEffect
Summary:
useLayoutEffect isn't needed here
https://linear.app/comm/issue/ENG-986/regression-uselayouteffect-warning-in-keyserver-console
Test Plan: open and close the menu button in header
Reviewers: atul, def-au1t, palys-swm
Reviewed By: def-au1t, palys... |
129,179 | 13.04.2022 08:43:46 | 14,400 | 9eff5619b3223f1f630f9dcf22b31c7747d23f67 | [web] [refactor] use lib useIsomorphicLayoutEffect
Summary: replace `useIsomorphicLayoutEffect` and React.useLayout effect with lib
Test Plan: console error shouldn't exist anymore from layout effect. Keyserver and menu button work as expected
Reviewers: atul, def-au1t, palys-swm
Subscribers: ashoat, palys-swm, Adrian... | [
{
"change_type": "MODIFY",
"old_path": "landing/keyservers.react.js",
"new_path": "landing/keyservers.react.js",
"diff": "import { create } from '@lottiefiles/lottie-interactivity';\nimport * as React from 'react';\n+import { useIsomorphicLayoutEffect } from 'lib/hooks/isomorphic-layout-effect.react... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect
Summary: replace `useIsomorphicLayoutEffect` and React.useLayout effect with lib
Test Plan: console error shouldn't exist anymore from layout effect. Keyserver and menu button work as expected
Reviewers: atul, def-au1t, palys-swm
Reviewed By: def-au1t, p... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.