author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,184 | 12.04.2022 15:40:38 | 14,400 | 38632c63ef00823a8efc28d774c0f6322eee4214 | [web] Remove "active" `transition` for `ColorSelectorButton` component
Summary: Addresses feedback from here:
Test Plan:
Looks as expected:
{F38040}
Reviewers: def-au1t, palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, yayabosh, palys-swm | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/color-selector-button.css",
"new_path": "web/modals/threads/color-selector-button.css",
"diff": "@@ -6,13 +6,11 @@ div.container {\nalign-items: center;\njustify-content: center;\ndisplay: flex;\n- transition: 150ms;\n}\ndiv.active,\ndiv.con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove "active" `transition` for `ColorSelectorButton` component
Summary: Addresses feedback from @palys-swm here: https://phabricator.ashoat.com/D3699#101943
Test Plan:
Looks as expected:
{F38040}
Reviewers: def-au1t, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, ya... |
129,191 | 14.04.2022 20:26:39 | -7,200 | 9b4481c37d33b74f10f932dc6378bce0ac7e9564 | [lib] Fix memoization of useRelationshipPrompt
Summary:
We were using callbacks but the return value was never memoized.
Depends on D3734
Test Plan: Send friend request by using relationship prompt and check if the state was updated.
Reviewers: benschac, atul, def-au1t
Subscribers: ashoat, Adrian, karol-bisztyga, yayab... | [
{
"change_type": "MODIFY",
"old_path": "lib/hooks/relationship-prompt.js",
"new_path": "lib/hooks/relationship-prompt.js",
"diff": "@@ -52,10 +52,13 @@ function useRelationshipPrompt(\nonErrorCallback,\n);\n- return {\n+ return React.useMemo(\n+ () => ({\notherUserInfo,\ncallbacks,\n- };\n+ }),\n+ [... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix memoization of useRelationshipPrompt
Summary:
We were using callbacks but the return value was never memoized.
Depends on D3734
Test Plan: Send friend request by using relationship prompt and check if the state was updated.
Reviewers: benschac, atul, def-au1t
Reviewed By: atul
Subscribers: ashoat, Adrian... |
129,179 | 19.04.2022 09:46:09 | 14,400 | d77f80b11afb0614c2e8a3f1c161998f2bcf4332 | [web] [fix] update thread selected state text
Summary:
change text color per issue and conversation with ashoat.
{F37149}
Test Plan: select a chat thread list item on web
Reviewers: atul, palys-swm, def-au1t
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -31,11 +31,11 @@ div.threadListSidebar:hover {\n}\ndiv.activeThread :is(div.dark, .lastMessage span.read, .title) {\n- color: var(--fg);\n+ color: var(--chat-thread-list-c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] [ENG-731] update thread selected state text
Summary:
change text color per issue and conversation with ashoat.
https://linear.app/comm/issue/ENG-731/appearance-of-thread-selected-state-makes-it-look-unread
{F37149}
Test Plan: select a chat thread list item on web
Reviewers: atul, palys-swm, def-au1t
Re... |
129,179 | 19.04.2022 12:50:20 | 14,400 | c6f4c30d210e8a092d48485e67787e61e005c430 | [web] [fix] add notif dot for thread
Summary:
adds notif dot to thread in conversation selector
{F23185}
Test Plan: send your self a message from one user to another, click sidebar to toggle off unread.
Reviewers: atul, def-au1t, palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-sidebar.react.js",
"new_path": "web/chat/chat-thread-list-sidebar.react.js",
"diff": "@@ -19,10 +19,17 @@ type Props = {\nfunction ChatThreadListSidebar(props: Props): React.Node {\nconst { sidebarInfo } = props;\nconst { threadInfo, ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] ENG-730 add notif dot for thread
Summary:
adds notif dot to thread in conversation selector
https://linear.app/comm/issue/ENG-730/unread-indication-for-sidebars-is-very-strange
{F23185}
Test Plan: send your self a message from one user to another, click sidebar to toggle off unread.
Reviewers: atul, def... |
129,179 | 19.04.2022 13:02:11 | 14,400 | 0aa0ced7a43d4ddb7cb4797a14268289c4f9580c | [web] [fix] dot alignment
Summary:
dot wasn't aligned with color splotch
{F38740}
{F38751}
Test Plan: send a new message, un read dot should be aligned
Reviewers: atul, def-au1t, yayabosh, palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -132,10 +132,11 @@ function ChatThreadListItem(props: Props): React.Node {\n<>\n<div className={containerClassName} onClick={onClick}>\n<div className=... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] dot alignment
Summary:
dot wasn't aligned with color splotch
{F38740}
{F38751}
Test Plan: send a new message, un read dot should be aligned
Reviewers: atul, def-au1t, yayabosh, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh
Differential Revision: ht... |
129,179 | 19.04.2022 13:07:36 | 14,400 | bcf164d0220b1f7070544c1eda36cfa18cef13bb | [web] [fix] fix unread last message timestamp
Summary:
size and padding didn't match figma.
after:
{F38726}
before:
{F38727}
Test Plan:
it should match figma
Reviewers: atul, def-au1t, palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -109,6 +109,7 @@ div.lastActivity {\nfont-size: var(--xxs-font-10);\ncolor: var(--fg);\nline-height: 1.5;\n+ padding-right: 16px;\nfont-weight: var(--semi-bold);\nwhite-sp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] fix unread last message timestamp
Summary:
size and padding didn't match figma.
after:
{F38726}
before:
{F38727}
Test Plan:
it should match figma
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79583
Reviewers: atul, def-au1t, palys-swm
Reviewed By: palys-swm
Su... |
129,190 | 13.04.2022 16:22:03 | -7,200 | 6a19136b312a06cdcd45e7e5fd81118b25abffb3 | [services] Backup - pull backup reactor - logs - write response
Summary:
Depends on D3635
The logic for `writeResponse` handling writing compaction chunks
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h",
"diff": "#pragma once\n#include \"BlobGetClientReactor.h\"\n+#include \... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - pull backup reactor - logs - write response
Summary:
Depends on D3635
The logic for `writeResponse` handling writing compaction chunks
Test Plan: The same as in D3535
Reviewers: palys-swm, geekbrother
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
Diff... |
129,190 | 13.04.2022 16:22:11 | -7,200 | 7bc7053e2401f804e53a18c153e8af7b81624a5d | [services] Backup - Blob client reactors - add getStatus
Summary:
Depends on D3719
We need to be able to pull the status by external objects from blob client reactors.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/client/blob/BlobGetClientReactor.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/client/blob/BlobGetClientReactor.h",
"diff": "@@ -28,6 +28,7 @@ public:\nstd::unique_ptr<grp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob client reactors - add getStatus
Summary:
Depends on D3719
We need to be able to pull the status by external objects from blob client reactors.
Test Plan:
```
cd services
yarn run-backup-service
```
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, b... |
129,190 | 21.04.2022 12:18:28 | -7,200 | 92c64841f20b903c86180017595628ef5b0b11ef | [services] Backup/Blob - wrap terminateCallback into try...catch
Summary:
Depends on D3720
We need to be able to throw in the `terminationCallback` and handle it gracefully.
Test Plan:
```
cd services
yarn run-backup-service
yarn run-blob-service
```
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, be... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h",
"diff": "@@ -65,8 +65,8 @@ template... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup/Blob - wrap terminateCallback into try...catch
Summary:
Depends on D3720
We need to be able to throw in the `terminationCallback` and handle it gracefully.
Test Plan:
```
cd services
yarn run-backup-service
yarn run-blob-service
```
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat... |
129,190 | 21.04.2022 12:18:57 | -7,200 | 5aefcb036f32244f949de75e538cdb19561de9e0 | [services] Backup/Blob - Add validate method to server write reactor base
Summary:
Depends on D3721
Adding the `validate` method to the server write reactor base
Test Plan:
```
cd services
yarn run-backup-service
yarn run-blob-service
```
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yaya... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h",
"diff": "@@ -33,6 +33,7 @@ public... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup/Blob - Add validate method to server write reactor base
Summary:
Depends on D3721
Adding the `validate` method to the server write reactor base
Test Plan:
```
cd services
yarn run-backup-service
yarn run-blob-service
```
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm,... |
129,190 | 21.04.2022 12:19:24 | -7,200 | cc6f856b5658dcf2e77ef0e86b3e740083047397 | [services] Backup/Blob - Use this when reffering status
Summary:
Depends on D3803
Add `this->` when referring to status in base reactor classes
Test Plan:
```
cd services
yarn run-backup-service
yarn run-blob-service
```
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h",
"diff": "@@ -50,7 +50,7 @@ void Ser... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup/Blob - Use this when reffering status
Summary:
Depends on D3803
Add `this->` when referring to status in base reactor classes
Test Plan:
```
cd services
yarn run-backup-service
yarn run-blob-service
```
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, ben... |
129,179 | 15.04.2022 14:09:41 | 14,400 | 862ab3ac242c2dad98feefa276f99e5453b41cbe | [native] [refactor] use usePromoteSidebar hook
Summary:
use hook in native, remove old code
Test Plan: use promote thread feature like you normally would.
Reviewers: atul, def-au1t, palys-swm
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-promote-sidebar.react.js",
"new_path": "native/chat/settings/thread-settings-promote-sidebar.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { Text, Alert, ActivityIndicator, View } from 'react-native... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [refactor] [ENG-991] use usePromoteSidebar hook
Summary:
use hook in native, remove old code
https://linear.app/comm/issue/ENG-991/promote-sidebar-to-subthread-on-web
Test Plan: use promote thread feature like you normally would.
Reviewers: atul, def-au1t, palys-swm
Reviewed By: palys-swm
Subscribers: ash... |
129,190 | 22.04.2022 10:06:25 | -7,200 | c36fd0770f7ab348e3d228ba9d3b48098689a5a4 | [services] Backup/Blob - Add comments to delete this
Summary:
Depends on D3722
Test Plan: None - these are just comments
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h",
"new_path": "services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h",
"diff": "@@ -58,6 +58,8 @@ ServerBi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup/Blob - Add comments to delete this
Summary:
Depends on D3722
https://linear.app/comm/issue/ENG-960/add-comments-for-delete-this
Test Plan: None - these are just comments
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
... |
129,190 | 22.04.2022 10:06:27 | -7,200 | fb4294397173621f36f0160bfe536bbe5be90224 | [services] Backup/Blob - Hide nextWrite, expose start
Summary:
Depends on D3727
Test Plan: The same as D3535 - services should work the same
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"new_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"diff": "@@ -43,7 +43,7 @@ BackupServiceImpl::PullBackup(\ngrpc::CallbackServerContext *context,\nc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup/Blob - Hide nextWrite, expose start
Summary:
Depends on D3727
https://linear.app/comm/issue/ENG-1002/replace-nextwrite-with-start-in-reactors
Test Plan: The same as D3535 - services should work the same
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, ben... |
129,200 | 22.04.2022 17:06:02 | 14,400 | e6e82dcdb360749557cb3e0917c3b8ca308d2617 | [Identity] Reorder Dockerfile contents
Summary: Addressing a comment from in a previous diff. We should install rustfmt immediately after setting the user.
Test Plan: Build the docker image
Reviewers: jimpo, atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh, jimpo | [
{
"change_type": "MODIFY",
"old_path": "services/identity/Dockerfile",
"new_path": "services/identity/Dockerfile",
"diff": "@@ -4,6 +4,9 @@ FROM rust:1.57\nRUN useradd -m comm\nUSER comm\n+# The build.rs script depends on rustfmt\n+RUN rustup component add rustfmt\n+\nRUN mkdir -p /home/comm/app/ide... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [Identity] Reorder Dockerfile contents
Summary: Addressing a comment from @jimpo in a previous diff. We should install rustfmt immediately after setting the user.
Test Plan: Build the docker image
Reviewers: jimpo, atul
Reviewed By: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh, jimpo
Diff... |
129,179 | 25.04.2022 08:23:07 | 14,400 | bdc048e8d4f5b2968cc027c57d892ca81f9d8396 | [web,native] [chore] add covariant declarations to props that were missing
Summary:
Test Plan: run flow on `native` and `web` adding as a reviewer because this was initially a comment of D3811
Reviewers: atul, palys-swm, ashoat, def-au1t, yayabosh
Subscribers: Adrian, karol-bisztyga, ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/loading-indicator.react.js",
"new_path": "native/calendar/loading-indicator.react.js",
"diff": "@@ -7,9 +7,9 @@ import Icon from 'react-native-vector-icons/Feather';\nimport type { LoadingStatus } from 'lib/types/loading-types';\ntype Props = {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web,native] [chore] [ENG-1032] add covariant declarations to props that were missing
Summary: https://linear.app/comm/issue/ENG-1032/add-missing-covariant-declarations-in-web-and-native
Test Plan: run flow on `native` and `web` adding @ashoat as a reviewer because this was initially a comment of D3811
Reviewers: at... |
129,179 | 22.04.2022 17:13:26 | 14,400 | 2bfb55f8eab6b1e9d99d1adc5388045028a88dd5 | [native] [fix] fix prompt copy
Summary: Update copy, confirm with adding ashoat as review because it's copy that he should have final review on.
Test Plan: N/A not changing functionality, just the content.
Reviewers: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, yayabosh, ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-promote-sidebar.react.js",
"new_path": "native/chat/settings/thread-settings-promote-sidebar.react.js",
"diff": "@@ -26,7 +26,7 @@ class ThreadSettingsPromoteSidebar extends React.PureComponent<Props> {\nonClick = () => {\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [fix] [ENG-1016] fix prompt copy
Summary: Update copy, confirm with @ashoat, adding ashoat as review because it's copy that he should have final review on.
Test Plan: N/A not changing functionality, just the content.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyg... |
129,179 | 19.04.2022 16:00:43 | 14,400 | 691803efd7c9f7aa0e9dbc7702efa03472e39d7f | [web] [fix] Additional Changes for that were missed before landing.
Summary: follow up from comments that were not landed
Test Plan: make sure all diff review has been addressed correctly.
Reviewers: atul, palys-swm, def-au1t, yayabosh, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -95,7 +95,7 @@ function ChatThreadListItem(props: Props): React.Node {\nreturn (\n<ChatThreadListSidebar\nsidebarInfo={sidebarInfo}\n- isMultipleSideba... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] [ENG-1024] Additional Changes for ENG-766 that were missed before landing.
Summary: follow up from https://phabricator.ashoat.com/D3539 comments that were not landed
Test Plan: make sure all diff review has been addressed correctly.
Reviewers: atul, palys-swm, def-au1t, yayabosh, ashoat
Reviewed By: ash... |
129,179 | 25.04.2022 11:33:04 | 14,400 | 3969047afed71d4174d7da718e0411e1084904ea | [lib,web,native,landing] [chore] update eslint config to correctly handle cjs files
Summary: update eslint config to ignore files, rather than add the comments,
Test Plan: go to webpack files, red swiggles are now gone.
Reviewers: atul, palys-swm, def-au1t, yayabosh, benschac
Subscribers: ashoat, palys-swm, Adrian, kar... | [
{
"change_type": "MODIFY",
"old_path": ".eslintrc.json",
"new_path": ".eslintrc.json",
"diff": "},\n\"import/ignore\": [\"react-native\"],\n\"import/internal-regex\": \"^(lib|native|keyserver|web)/\"\n+ },\n+ \"overrides\": [\n+ {\n+ \"files\": \"*.cjs\",\n+ \"env\": {\n+ \"node\": true,\n+ \"common... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib,web,native,landing] [chore] update eslint config to correctly handle cjs files
Summary: update eslint config to ignore files, rather than add the comments, https://eslint.org/docs/user-guide/configuring/ignoring-code
Test Plan: go to webpack files, red swiggles are now gone.
Reviewers: atul, palys-swm, def-au1t... |
129,187 | 25.04.2022 11:47:07 | 14,400 | 3ad88fafa1ae96a783940c2f516a9b2baf2e3ea6 | [lib] Fix ESLint errors on lib/webpack/shared.cjs
Summary: In the parent diff we make ESLint work with `.cjs` files. This diff corrects the resultant errors.
Test Plan: `eslint lib/webpack/shared.cjs`
Reviewers: benschac
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "lib/webpack/shared.cjs",
"new_path": "lib/webpack/shared.cjs",
"diff": "-const webpack = require('webpack');\n-const path = require('path');\n+const { CleanWebpackPlugin } = require('clean-webpack-plugin');\nconst MiniCssExtractPlugin = require('mini-css-extra... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix ESLint errors on lib/webpack/shared.cjs
Summary: In the parent diff we make ESLint work with `.cjs` files. This diff corrects the resultant errors.
Test Plan: `eslint lib/webpack/shared.cjs`
Reviewers: benschac
Reviewed By: benschac
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, yayabosh
Differen... |
129,187 | 25.04.2022 11:48:43 | 14,400 | ee2a23439c28e8b212ed32799324de92acc7f809 | Enable lint-staged for cjs files
Summary: Depends on D3834
Test Plan: Ehh I haven't actually tested this. Seems fine though...
Reviewers: benschac
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": ".lintstagedrc.js",
"new_path": ".lintstagedrc.js",
"diff": "@@ -4,7 +4,7 @@ const { getClangPaths } = require('./scripts/get_clang_paths');\nconst cli = new CLIEngine({});\nmodule.exports = {\n- '*.{js,mjs}': function eslint(files) {\n+ '*.{js,mjs,cjs}': funct... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Enable lint-staged for cjs files
Summary: Depends on D3834
Test Plan: Ehh I haven't actually tested this. Seems fine though...
Reviewers: benschac
Reviewed By: benschac
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, yayabosh
Differential Revision: https://phabricator.ashoat.com/D3835 |
129,179 | 26.04.2022 10:57:04 | 14,400 | 1f0272f1e14fbb0fecb16cda4f0df573452cdfb6 | [web] [fix] change modal x default to show on default
Summary:
re-add the close button
{F43992}
{F43993}
Test Plan: all modals should have the x button by default. attaching screen shots.
Reviewers: atul, palys-swm, def-au1t
Subscribers: ashoat, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/modal.react.js",
"new_path": "web/modals/modal.react.js",
"diff": "@@ -37,7 +37,7 @@ class Modal extends React.PureComponent<Props> {\nfixedHeight,\nname,\nicon,\n- withCloseButton = false,\n+ withCloseButton = true,\n} = this.props;\nconst overlayC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] [ENG-1033] change modal x default to show on default
Summary:
re-add the close button
{F43992}
{F43993}
https://linear.app/comm/issue/ENG-1033/close-button-removed-from-modal
Test Plan: all modals should have the x button by default. attaching screen shots.
Reviewers: atul, palys-swm, def-au1t
Reviewed... |
129,185 | 26.04.2022 17:28:05 | -7,200 | 3274d77df84a01bae672d710cb7ee964a831cabf | [web] Remove `Modal`s usused style
Summary: The style has not been used anywhere in the project
Test Plan: Nothing changes in project
Reviewers: palys-swm, atul, benschac
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/modal.css",
"new_path": "web/modals/modal.css",
"diff": "@@ -67,18 +67,6 @@ div.modal-header > h2 svg {\ndisplay: flex;\n}\n-div.intro-modal {\n- padding: 10px 21px 12px 21px;\n- border-radius: 5px;\n- border: 1px solid #c8c8c8;\n- background-color:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove `Modal`s usused style
Summary: The style has not been used anywhere in the project
Test Plan: Nothing changes in project
Reviewers: palys-swm, atul, benschac
Reviewed By: atul
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, benschac, yayabosh
Differential Revision: https://phabricator.a... |
129,185 | 26.04.2022 17:28:26 | -7,200 | d8e2452fd22d37e9f544e0a0f346a701299b9e01 | [web] Adjust `SubchannelsModal` size to match designs
Summary:
Changed `SubchannelsModal` content size to match design in Figma.
{F36324}
Test Plan: Open `SubchannelsModal` from thread actions menu
Reviewers: palys-swm, atul, benschac
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/subchannels/subchannels-modal.css",
"new_path": "web/modals/threads/subchannels/subchannels-modal.css",
"diff": "@@ -5,6 +5,8 @@ div.subchannelsListContainer {\nline-height: var(--line-height-text);\ncolor: var(--subchannels-modal-color);\nr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Adjust `SubchannelsModal` size to match designs
Summary:
Changed `SubchannelsModal` content size to match design in Figma.
{F36324}
Test Plan: Open `SubchannelsModal` from thread actions menu
Reviewers: palys-swm, atul, benschac
Reviewed By: atul
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga,... |
129,184 | 27.04.2022 09:19:43 | 18,000 | 9c862dfb76d77aae4441852894354590db67d3ea | [keyserver] Bump `firebase-admin` to `10.1.0`
Summary:
Downstream dependencies have issues surfaced by `yarn audit`
Checked the `10.0.2` and `10.1.0` release notes and found no evidence of breaking changes:
Test Plan: CI
Reviewers: def-au1t, palys-swm, ashoat
Subscribers: Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/package.json",
"new_path": "keyserver/package.json",
"diff": "\"dateformat\": \"^3.0.3\",\n\"express\": \"^4.17.1\",\n\"express-ws\": \"^4.0.0\",\n- \"firebase-admin\": \"^10.0.1\",\n+ \"firebase-admin\": \"^10.1.0\",\n\"geoip-lite\": \"^1.4.0\",\n\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Bump `firebase-admin` to `10.1.0`
Summary:
Downstream dependencies have issues surfaced by `yarn audit`
Checked the `10.0.2` and `10.1.0` release notes and found no evidence of breaking changes: https://github.com/firebase/firebase-admin-node/releases
Test Plan: CI
Reviewers: def-au1t, palys-swm, ashoat... |
129,187 | 27.04.2022 23:15:07 | 14,400 | 25931883c550a7645b322f0d736638fef824096e | [keyserver] Dockerfile for Node keyserver
Summary:
With script dependencies in place, this diff completes the Dockerfile for the Node keyserver.
Depends on D3870
Test Plan: `docker-compose up --build`
Reviewers: palys-swm, jimpo
Subscribers: Adrian, atul, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/Dockerfile",
"new_path": "keyserver/Dockerfile",
"diff": "@@ -40,3 +40,26 @@ COPY native/ios/Podfile native/ios/\n# Actually run yarn\nRUN yarn cleaninstall\n+\n+#-------------------------------------------------------------------------------\n+# STE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Dockerfile for Node keyserver
Summary:
With script dependencies in place, this diff completes the Dockerfile for the Node keyserver.
Depends on D3870
Test Plan: `docker-compose up --build`
Reviewers: palys-swm, jimpo
Reviewed By: palys-swm
Subscribers: Adrian, atul, karol-bisztyga, yayabosh
Different... |
129,184 | 27.04.2022 09:33:58 | 18,000 | bd743e58e318110fe2c419ac0bc3e7cc24610b49 | [native] Bump `react-native-svg` to `12.3.0`
Summary:
Downstream dependencies have issues surfaced by `yarn audit`
Checked the release notes: and didn't find any breaking changes
Depends on D3855
Test Plan: CI
Reviewers: def-au1t, palys-swm, ashoat
Subscribers: Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -895,8 +895,8 @@ PODS:\n- RNScreens (3.8.0):\n- React-Core\n- React-RCTImage\n- - RNSVG (12.1.1):\n- - React\n+ - RNSVG (12.3.0):\n+ - React-Core\n- RNVectorIcons (6.6.0):\n- React\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Bump `react-native-svg` to `12.3.0`
Summary:
Downstream dependencies have issues surfaced by `yarn audit`
Checked the release notes: https://github.com/react-native-svg/react-native-svg/releases and didn't find any breaking changes
---
Depends on D3855
Test Plan: CI
Reviewers: def-au1t, palys-swm, ashoat... |
129,179 | 02.05.2022 11:23:22 | 14,400 | 80abee4eb84a0af9a81c69d2ab318951aec79d36 | [lib] [refactor] add memo in inline sidebar hook
Summary: updating the hook per my comment in my last diff:
Test Plan: use the application like normal. replied should reflect in a sidebar as they do normally.
Reviewers: atul, def-au1t, yayabosh, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/hooks/inline-sidebar-text.react.js",
"new_path": "lib/hooks/inline-sidebar-text.react.js",
"diff": "@@ -29,7 +29,13 @@ function useInlineSidebarText(\nreturn senders.length > 0 ? `${pluralizeAndTrim(senders, 25)} sent ` : '';\n}, [threadMembers]);\n- retur... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] [refactor] [ENG-530] add memo in inline sidebar hook
Summary: updating the hook per my comment in my last diff: https://phabricator.ashoat.com/D3879#inline-23803
Test Plan: use the application like normal. replied should reflect in a sidebar as they do normally.
Reviewers: atul, def-au1t, yayabosh, ashoat
Rev... |
129,190 | 28.04.2022 15:16:07 | -7,200 | cd7375d7e288fb46a6d144aa7995e62565e37621 | [services] Fix clang paths
Summary:
Fixing clang paths that are broken because of the directory refactoring
Test Plan:
```
yarn clang-format-all
```
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/java/app/comm/android/fbjni/NetworkModule.java",
"new_path": "native/android/app/src/main/java/app/comm/android/fbjni/NetworkModule.java",
"diff": "package app.comm.android.fbjni;\n-public class NetworkModule { public static native ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Fix clang paths
Summary:
https://linear.app/comm/issue/ENG-915/services-fix-clang-paths
Fixing clang paths that are broken because of the directory refactoring
Test Plan:
```
yarn clang-format-all
```
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, yayabos... |
129,190 | 05.05.2022 16:40:45 | -7,200 | df1c524f0670cecf1605db8fc031f92fc7be6d3d | [services] Rename Reactor Utility
Summary:
Renaming `ReactorUtility` -> `ReactorStatusHolder`
Test Plan:
services should still build
```
cd services
yarn test-blob-service
yarn test-backup-service
```
Reviewers: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Reactors/BaseReactor.h",
"new_path": "services/backup/src/Reactors/BaseReactor.h",
"diff": "#pragma once\n-#include \"ReactorUtility.h\"\n+#include \"ReactorStatusHolder.h\"\n#include <grpcpp/grpcpp.h>\n@@ -12,7 +12,7 @@ namespace reactor {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Rename Reactor Utility
Summary:
https://linear.app/comm/issue/ENG-1086/discuss-the-structure-of-reactor-utility
Renaming `ReactorUtility` -> `ReactorStatusHolder`
Test Plan:
services should still build
```
cd services
yarn test-blob-service
yarn test-backup-service
```
Reviewers: ashoat
Reviewed By: as... |
129,184 | 05.05.2022 09:23:55 | 14,400 | 8951a8faa85ecafda325635d342cd736577122de | [web] Remove unnecessary `form_footer` div and corresponding styles
Summary: There's no need for this div. We can achieve the same thing with just the `modal_form_error` div.
Test Plan:
Looks as expected:
{F50800}
Reviewers: ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/thread-settings-modal.css",
"new_path": "web/modals/threads/thread-settings-modal.css",
"diff": "@@ -11,16 +11,13 @@ div.modal_body p {\nfont-size: 14px;\ntext-align: center;\n}\n-div.modal_body div.form_footer {\n+div.modal_form_error {\ndi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove unnecessary `form_footer` div and corresponding styles
Summary: There's no need for this div. We can achieve the same thing with just the `modal_form_error` div.
Test Plan:
Looks as expected:
{F50800}
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga, yayabosh
Diffe... |
129,184 | 05.05.2022 09:30:49 | 14,400 | b626b982eeffb603aecc36a4e40121b7b6aace3c | [web] Add gear icon to `ThreadSettingsModal` header
Summary: Added the gear icon to the header, why not
Test Plan:
Looks as expected:
{F50811}
Reviewers: palys-swm, ashoat
Subscribers: Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/thread-settings-modal.react.js",
"new_path": "web/modals/threads/thread-settings-modal.react.js",
"diff": "@@ -159,7 +159,11 @@ const ConnectedThreadSettingsModal: React.ComponentType<BaseProps> = React.memo<\n}\nreturn (\n- <Modal name=\"Th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add gear icon to `ThreadSettingsModal` header
Summary: Added the gear icon to the header, why not
Test Plan:
Looks as expected:
{F50811}
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga, yayabosh
Differential Revision: https://phabricator.ashoat.com/D3927 |
129,184 | 05.05.2022 09:38:28 | 14,400 | cb2b044b0ed62bd7a68397b536d0a13a0bfe93b3 | [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" components
Summary: Addresses feedback from in a previous stack. Makes `ThreadSettingsModal` cleaner.
Test Plan:
Things continue to look/work as expected:
{F50949}
Reviewers: ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, yayabosh, palys-swm | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/thread-settings-delete-tab.react.js",
"new_path": "web/modals/threads/thread-settings-delete-tab.react.js",
"diff": "@@ -76,7 +76,7 @@ function ThreadSettingsDeleteTab(\n);\nreturn (\n- <>\n+ <form method=\"POST\">\n<div>\n<p className={css.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" components
Summary: Addresses feedback from @palys-swm in a previous stack. Makes `ThreadSettingsModal` cleaner.
Test Plan:
Things continue to look/work as expected:
{F50949}
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: Adrian... |
129,179 | 05.05.2022 12:40:59 | 14,400 | ea7b3df152a7f3a0f4a7e5e122b6c409cd63ae4d | [chore] bump husky package
Summary: yarn upgrade-interactive, chose husky. minor bug fixes in the github tag notes
Test Plan: make sure husky is still working.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -8982,9 +8982,9 @@ human-signals@^2.1.0:\nintegrity sha512-B4FFZ6q/T2jhhksgkbEW3HBvWIfDW85snkQgawt07S7J5QXTk6BkNV+0yAeZrM5QpMAdYlocGoljn0sJ/WQkFw==\nhusky@^7.0.0:\n- version \"7.0.0\"\n- resolved \"https://regis... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [chore] bump husky package
Summary: yarn upgrade-interactive, chose husky. minor bug fixes in the github tag notes
Test Plan: make sure husky is still working.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh
Differential Revision: https://phabrica... |
129,179 | 05.05.2022 14:33:28 | 14,400 | 10c75023f54353c4f2f1d03a842dd36cb2d82aa1 | [chore][landing] bump fortawesome package
Summary: bumped icon package using yarn upgrade-interactive
Test Plan: cleaninstalled, ran landing and checked all components using the fortawesome package. Everything still worked as expected
Reviewers: atul
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "resolved \"https://registry.yarnpkg.com/@fortawesome/fontawesome-common-types/-/fontawesome-common-types-0.2.36.tgz#b44e52db3b6b20523e0c57ef8c42d315532cb903\"\nintegrity sha512-a/7BiSgobHAgBWeN7N0w+lAhInrGxksn13uK7... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [chore][landing] bump fortawesome package
Summary: bumped icon package using yarn upgrade-interactive
Test Plan: cleaninstalled, ran landing and checked all components using the fortawesome package. Everything still worked as expected
Reviewers: atul
Reviewed By: atul
Subscribers: ashoat, palys-swm, Adrian, karol-... |
129,190 | 11.04.2022 15:39:43 | -7,200 | ac99b83189cf0357882c10d92d9b2aa99755f2dc | [services] Dev mode - Fix Backup service
Summary: Fix dev mode in backup service. Until now it seems like it was broken.
Test Plan:
```
docker-compose down
yarn test-blob-service-dev-mode
yarn test-backup-service-dev-mode
```
Reviewers: jimpo, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/DatabaseManager.h",
"new_path": "services/backup/src/DatabaseManager.h",
"diff": "#include <memory>\n#include <string>\n-#ifdef COMM_SERVICES_DEV_MODE\n-#include \"DatabaseSimulator.h\"\n-#endif\n-\nnamespace comm {\nnamespace network {\nna... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Dev mode - Fix Backup service
Summary: Fix dev mode in backup service. Until now it seems like it was broken.
Test Plan:
```
docker-compose down
yarn test-blob-service-dev-mode
yarn test-backup-service-dev-mode
```
Reviewers: jimpo, palys-swm
Reviewed By: jimpo, palys-swm
Subscribers: ashoat, palys-swm,... |
129,190 | 11.04.2022 15:39:46 | -7,200 | 916fd9cdf7709b95c10d83f2546346acd643f0ca | [services] Dev mode - Add localstack to docker compose
Summary:
Depends on D3695
Adding localstack configuration to the `docker-compose.yml` file.
Test Plan:
```
cd services
docker-compose down && docker-compose up localstack
```
Reviewers: palys-swm, jimpo, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac... | [
{
"change_type": "MODIFY",
"old_path": "services/docker-compose.yml",
"new_path": "services/docker-compose.yml",
"diff": "@@ -2,6 +2,8 @@ version: \"3.9\"\nnetworks:\nservices-net:\nname: services-net\n+volumes:\n+ localstack:\nservices:\n# tunnelbroker\ntunnelbroker-server:\n@@ -61,3 +63,18 @@ serv... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Dev mode - Add localstack to docker compose
Summary:
Depends on D3695
Adding localstack configuration to the `docker-compose.yml` file.
Test Plan:
```
cd services
docker-compose down && docker-compose up localstack
```
Reviewers: palys-swm, jimpo, ashoat
Reviewed By: jimpo, ashoat
Subscribers: ashoat, ... |
129,190 | 11.04.2022 15:39:48 | -7,200 | 474b3296954bb6f1010dce88f12d7d002474b896 | [services] Dev mode - Add terraform
Summary:
Depends on D3692
Adding terraform configurations for the S3 and Dynamo DB.
Test Plan:
```
cd services/terraform
./run.sh
```
Reviewers: palys-swm, jimpo, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/terraform/.gitignore",
"diff": "+# Local .terraform directories\n+**/.terraform/*\n+\n+# .tfstate files\n+*.tfstate\n+*.tfstate.*\n+\n+# Crash log files\n+crash.log\n+crash.*.log\n+\n+# Exclude all .tfvars files, which are likely to con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Dev mode - Add terraform
Summary:
Depends on D3692
Adding terraform configurations for the S3 and Dynamo DB.
Test Plan:
```
cd services/terraform
./run.sh
```
Reviewers: palys-swm, jimpo, ashoat
Reviewed By: palys-swm, jimpo, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh
Diff... |
129,190 | 11.04.2022 15:39:51 | -7,200 | 48bddf139b7b4132f69c4fc7625f8560fb791003 | [services] Dev mode - Add scripts for running local cloud
Summary:
Depends on D3693
Adding scripts so the local cloud can be easily launched.
Test Plan:
```
cd services
docker-compose down
yarn run-local-cloud
```
Reviewers: palys-swm, jimpo
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"run-all-services\": \"./scripts/run_all_services.sh\",\n\"test-all-services\": \"./scripts/test_all_services.sh\",\n\"test-all-services-dev-mode\": \"export COMM_SERVICES_DEV_MODE=1 && ./s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Dev mode - Add scripts for running local cloud
Summary:
Depends on D3693
Adding scripts so the local cloud can be easily launched.
Test Plan:
```
cd services
docker-compose down
yarn run-local-cloud
```
Reviewers: palys-swm, jimpo
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, ben... |
129,179 | 06.05.2022 15:48:11 | 14,400 | 7a4b2a0a726400766bce97e0eef428691e5bcb26 | [native] [fix] fix hot reload compose component
Summary:
Test Plan: when editing compose component, it shouldn't move the developer back to inbox
Reviewers: atul, palys-swm, def-au1t, yayabosh, ashoat
Subscribers: ashoat, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/composed-message-constants.js",
"diff": "+// @flow\n+\n+export const clusterEndHeight = 7;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-messag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [fix] [ENG-1099] fix hot reload compose component
Summary: https://linear.app/comm/issue/ENG-1099/refactor-composed-message-component-to-fix-hot-reload
Test Plan: when editing compose component, it shouldn't move the developer back to inbox
Reviewers: atul, palys-swm, def-au1t, yayabosh, ashoat
Reviewed By... |
129,184 | 09.05.2022 14:54:09 | 14,400 | bd6e290b586a3dc1a39dbea9e8ca9888149bac1b | [native] `codeVersion` -> 131 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 131 |
129,184 | 09.05.2022 15:03:54 | 14,400 | d5313f3b0b103715bc43bffadd3b41f1186e5a51 | [native] `codeVersion` -> 132 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 132 |
129,187 | 09.05.2022 18:30:19 | 14,400 | 96a7a0a46e9aced94024e4a5bbc7e08d8c689987 | [keyserver] Make all url.json files optional
Summary:
Now we won't crash due to a missing `url.json` file until we actually need it.
Depends on D3977
Test Plan: Make sure I can still use the keyserver without `commapp_url.json` or `landing_url.json`
Reviewers: atul, palys-swm
Subscribers: Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/creators/report-creator.js",
"new_path": "keyserver/src/creators/report-creator.js",
"diff": "@@ -27,7 +27,7 @@ import { fetchUsername } from '../fetchers/user-fetchers';\nimport { handleAsyncPromise } from '../responders/handlers';\nimport { cre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Make all url.json files optional
Summary:
Now we won't crash due to a missing `url.json` file until we actually need it.
Depends on D3977
Test Plan: Make sure I can still use the keyserver without `commapp_url.json` or `landing_url.json`
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: A... |
129,190 | 10.05.2022 11:54:41 | -7,200 | 723497a431f5635b1008e5f7ba536b2c0ae53fc4 | [services] Blob - Delete dangling build_server.sh script
Summary:
Depends on D3970
I missed deleting this script back in D3906
Test Plan:
The blob service should still build properly
```
cd services
yarn run-blob-service
```
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "DELETE",
"old_path": "services/blob/docker/build_server.sh",
"new_path": null,
"diff": "-#!/bin/bash\n-\n-set -e\n-\n-# folly hack - https://github.com/facebook/folly/pull/1231\n-sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' /usr/lib/folly/folly/detai... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Blob - Delete dangling build_server.sh script
Summary:
Depends on D3970
I missed deleting this script back in D3906
Test Plan:
The blob service should still build properly
```
cd services
yarn run-blob-service
```
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian,... |
129,179 | 10.05.2022 12:45:01 | 14,400 | 027afc303a766c3119152701982584e7764be20e | [chore] [web] bump fortawesome in web directory
Summary:
bump packages in web folder
Test Plan:
open components like filter-panel.react that use the fortawesome icon package.
run `yarn upgrade-interactive` select packages in web
Reviewers: atul, palys-swm
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "dependencies:\ntslib \"^2.1.0\"\n-\"@fortawesome/fontawesome-common-types@^0.2.25\", \"@fortawesome/fontawesome-common-types@^0.2.36\":\n+\"@fortawesome/fontawesome-common-types@^0.2.36\":\nversion \"0.2.36\"\nreso... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [chore] [web] bump fortawesome in web directory
Summary:
bump packages in web folder
Test Plan:
open components like filter-panel.react that use the fortawesome icon package.
run `yarn upgrade-interactive` select @fortawesome packages in web
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: ashoat, Adrian... |
129,200 | 04.05.2022 14:28:36 | 14,400 | 086389e20728cffe34f38267165815d5542915ec | [Identity] Set max width to 80 characters
Summary:
The rustfmt default is 100 characters, but we use 80 in the Comm codebase
Depends on D3853
Test Plan: Ran cargo build
Reviewers: karol-bisztyga, palys-swm, jimpo, atul
Subscribers: ashoat, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/rustfmt.toml",
"new_path": "services/identity/rustfmt.toml",
"diff": "tab_spaces = 2\n+max_width = 80\n"
},
{
"change_type": "MODIFY",
"old_path": "services/identity/src/config.rs",
"new_path": "services/identity/src/config.rs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [Identity] Set max width to 80 characters
Summary:
The rustfmt default is 100 characters, but we use 80 in the Comm codebase
Depends on D3853
Test Plan: Ran cargo build
Reviewers: karol-bisztyga, palys-swm, jimpo, atul
Reviewed By: karol-bisztyga, atul
Subscribers: ashoat, Adrian, atul, yayabosh
Differential Rev... |
129,179 | 11.05.2022 14:39:31 | 14,400 | 206d81a9a61887b165d7135b9fda6e5d8f82e68f | [native] [refactor] refactor container margin bottom if statement
Summary:
use if else syntax the that's used project wide.
before:
{F53859}
after:
{F53857}
Test Plan: Cluster margin should work as expected in chat view.
Reviewers: atul, palys-swm, def-au1t, dereknelson
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -73,9 +73,15 @@ class ComposedMessage extends React.PureComponent<Props> {\nconst alignStyle = isViewer\n? styles.rightChatBubble\n: styles.leftChatBubble;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [refactor] [ENG-530] refactor container margin bottom if statement
Summary:
use if else syntax the that's used project wide.
before:
{F53859}
after:
{F53857}
Test Plan: Cluster margin should work as expected in chat view.
Reviewers: atul, palys-swm, def-au1t, dereknelson
Reviewed By: palys-swm
Subscribe... |
129,190 | 12.05.2022 11:37:51 | -7,200 | 16867717704f35c9a9df30edfa97ed23839d5680 | [services] Base image - Rename contents to docker
Summary:
Renaming the` contents` folder to the `docker` folder for the base image.
Test Plan:
```
cd services
yarn build-base-image
```
Reviewers: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/base-image/Dockerfile",
"new_path": "services/base-image/Dockerfile",
"diff": "@@ -20,13 +20,13 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \\\nRUN mkdir -p /transferred/scripts\nWORKDIR /transferred/scripts\n-COPY conte... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Base image - Rename contents to docker
Summary:
https://linear.app/comm/issue/ENG-1121/reconsider-base-imagecontents-directory
Renaming the` contents` folder to the `docker` folder for the base image.
Test Plan:
```
cd services
yarn build-base-image
```
Reviewers: ashoat
Reviewed By: ashoat
Subscribers... |
129,185 | 13.05.2022 10:50:30 | -7,200 | a4570c8b558d0bfad9efe98d7e6f7d16a2153f21 | [web] Introduce custom `Radio` component
Summary:
Introduce custom "Radio" component matching the one from our design system.
GIF:
{F51576}
Test Plan: The component is not used yet, tested when introducing notification settings.
Reviewers: palys-swm, benschac, atul
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/components/radio.css",
"diff": "+.radio {\n+ appearance: none;\n+ background-color: transparent;\n+ width: 24px;\n+ height: 24px;\n+ border: 1px solid var(--radio-border);\n+ border-radius: 50%;\n+ display: flex;\n+ align-items: center;\n+ j... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce custom `Radio` component
Summary:
Introduce custom "Radio" component matching the one from our design system.
GIF:
{F51576}
Test Plan: The component is not used yet, tested when introducing notification settings.
Reviewers: palys-swm, benschac, atul
Reviewed By: palys-swm, atul
Subscribers: ashoat... |
129,185 | 13.05.2022 10:50:30 | -7,200 | 7345b813c94e0d4a269d28fdcbe5194d676eb51e | [web] Introduce `NotificationsOptionInfo` component
Summary:
Introduce component describing feature of notification settings. It can be true or false (strikethrough text).
{F51586}
Test Plan: Not used in app yet. Tested after introducing notifications modal.
Reviewers: palys-swm, benschac, atul
Subscribers: ashoat, Adr... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/threads/notifications/notifications-modal.css",
"diff": "+div.optionInfo {\n+ display: flex;\n+ align-items: center;\n+ column-gap: 4px;\n+}\n+\n+div.optionInfoInvalid {\n+ text-decoration: line-through;\n+ color: var(--notification-s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `NotificationsOptionInfo` component
Summary:
Introduce component describing feature of notification settings. It can be true or false (strikethrough text).
{F51586}
Test Plan: Not used in app yet. Tested after introducing notifications modal.
Reviewers: palys-swm, benschac, atul
Reviewed By: palys-... |
129,185 | 13.05.2022 10:50:30 | -7,200 | 247f81bf62455b3f70a9d5173a5b56a9924465cd | [web] Introduce `NotificationsOption` component
Summary:
Introduce a component describing one notification setting with radio button.
{F51598}
Test Plan: It's not used yet. Tested when introducing modal with multiple options in one of next diffs.
Reviewers: palys-swm, atul, benschac
Subscribers: ashoat, Adrian, atul, y... | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/notifications/notifications-modal.css",
"new_path": "web/modals/threads/notifications/notifications-modal.css",
"diff": "+div.optionContainer {\n+ display: flex;\n+ padding: 16px 32px 16px 16px;\n+ align-items: center;\n+ border-radius: 8px;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `NotificationsOption` component
Summary:
Introduce a component describing one notification setting with radio button.
{F51598}
Test Plan: It's not used yet. Tested when introducing modal with multiple options in one of next diffs.
Reviewers: palys-swm, atul, benschac
Reviewed By: palys-swm, atul
S... |
129,185 | 13.05.2022 10:50:31 | -7,200 | 3503a1e4c9ea411b307d4023accfd1947759833b | [web] Introduce thread notification settings options in modal
Summary:
Introduce notification settings options in modal, that can be selected by the user.
{F51650}
Test Plan: The modal can be tested after introducing notification item in thread actions menu.
Reviewers: palys-swm, atul, benschac
Subscribers: ashoat, Adr... | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/notifications/notifications-modal.react.js",
"new_path": "web/modals/threads/notifications/notifications-modal.react.js",
"diff": "@@ -6,8 +6,10 @@ import { threadInfoSelector } from 'lib/selectors/thread-selectors';\nimport Button from '../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce thread notification settings options in modal
Summary:
Introduce notification settings options in modal, that can be selected by the user.
{F51650}
Test Plan: The modal can be tested after introducing notification item in thread actions menu.
Reviewers: palys-swm, atul, benschac
Reviewed By: atul
... |
129,190 | 11.05.2022 13:46:42 | -7,200 | 0c347d82e6df133e447c75dbc37371e6cf043181 | [services] Document base reactor
Summary:
Depends on D4002
Test Plan: None - there are just comments
Reviewers: ashoat, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/lib/src/BaseReactor.h",
"new_path": "services/lib/src/BaseReactor.h",
"diff": "@@ -12,10 +12,20 @@ namespace reactor {\nclass BaseReactor {\npublic:\n+ // Returns a status holder that consists of:\n+ // - reactor's state,\n+ // - status of the operati... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Document base reactor
Summary:
Depends on D4002
https://linear.app/comm/issue/ENG-969/add-documentation-for-the-reactor-base-classes
Test Plan: None - there are just comments
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh
Differential... |
129,190 | 11.05.2022 16:36:21 | -7,200 | 6da201fb0202e529bb4b410c0daeb71859190e34 | [services] Add documentation for base reactors
Summary:
Depends on D4003
Test Plan: None - there are just comments
Reviewers: ashoat, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/lib/src/client-base-reactors/ClientBidiReactorBase.h",
"new_path": "services/lib/src/client-base-reactors/ClientBidiReactorBase.h",
"diff": "@@ -8,6 +8,11 @@ namespace comm {\nnamespace network {\nnamespace reactor {\n+// This is how this type of reac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Add documentation for base reactors
Summary:
Depends on D4003
https://linear.app/comm/issue/ENG-969/add-documentation-for-the-reactor-base-classes
Test Plan: None - there are just comments
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh... |
129,179 | 12.05.2022 18:22:53 | 14,400 | 141a61f432a4839891a2b9686ce5ba28eb4c1f1b | [web] [refactor] use input component
Summary: use our input component moving forward
Test Plan: type text into input field
Reviewers: atul, palys-swm, def-au1t
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/chat/sidebar-list-modal.react.js",
"new_path": "web/modals/chat/sidebar-list-modal.react.js",
"diff": "@@ -15,6 +15,7 @@ import SidebarItem from '../../chat/sidebar-item.react';\nimport { useSelector } from '../../redux/redux-utils';\nimport globalC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] [ENG-536] use input component
Summary: use our input component moving forward
Test Plan: type text into input field
Reviewers: atul, palys-swm, def-au1t
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, yayabosh
Differential Revision: https://phabricator.ashoat.com/D4023 |
129,184 | 12.05.2022 13:07:27 | 14,400 | c951c3f795c8f60b599cd36c8c7d8d81b99684eb | [web] Remove unused/unnecessary selectors from `thread-settings-delete-tab.css`
Summary:
1. Remove the `textarea` selector which isn't used
2. Remove the "line" separating the notice from the instructions to delete
Depends on 4016
Test Plan:
Before:
{F54881}
After:
{F54882}
Reviewers: def-au1t, palys-swm, benschac
Subs... | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/thread-settings-delete-tab.css",
"new_path": "web/modals/threads/thread-settings-delete-tab.css",
"diff": "@@ -21,23 +21,7 @@ div.form_content input {\nmargin-bottom: 4px;\n}\n-div.form_content textarea {\n- padding: 12px;\n- background: var... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove unused/unnecessary selectors from `thread-settings-delete-tab.css`
Summary:
1. Remove the `textarea` selector which isn't used
2. Remove the "line" separating the notice from the instructions to delete
---
Depends on 4016
Test Plan:
Before:
{F54881}
After:
{F54882}
Reviewers: def-au1t, palys-swm, ben... |
129,184 | 12.05.2022 13:12:14 | 14,400 | f36c4b80757467339e1d771e1056d08735760978 | [web] Use `Input` component in `ThreadSettingsDeleteTab`
Summary:
Before:
{F54894}
After:
{F54895}
Depends on D4017
Test Plan: Looks as expected, flow
Reviewers: def-au1t, palys-swm, benschac
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/thread-settings-delete-tab.react.js",
"new_path": "web/modals/threads/thread-settings-delete-tab.react.js",
"diff": "@@ -14,6 +14,7 @@ import {\n} from 'lib/utils/action-utils';\nimport Button from '../../components/button.react.js';\n+impor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use `Input` component in `ThreadSettingsDeleteTab`
Summary:
Before:
{F54894}
After:
{F54895}
---
Depends on D4017
Test Plan: Looks as expected, flow
Reviewers: def-au1t, palys-swm, benschac
Reviewed By: palys-swm, benschac
Subscribers: ashoat, Adrian, yayabosh
Differential Revision: https://phabricator.a... |
129,191 | 28.04.2022 15:25:15 | -7,200 | 2fa239ba71a44dd30e6160c8865f2115e6959d78 | [web] Add user-cross icon
Summary: We need this icon on friend list
Test Plan: Display the icon and check if it is displayed correctly
Reviewers: benschac, atul, def-au1t
Subscribers: yayabosh, Adrian, ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/SWMansionIcon.react.js",
"new_path": "web/SWMansionIcon.react.js",
"diff": "@@ -76,7 +76,8 @@ export type Icon =\n| 'all-notifs'\n| 'badge-notifs'\n| 'muted-notifs'\n- | 'check';\n+ | 'check'\n+ | 'user-cross';\ntype SWMansionIconProps = {\n+icon: Icon,\n"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add user-cross icon
Summary: We need this icon on friend list
Test Plan: Display the icon and check if it is displayed correctly
Reviewers: benschac, atul, def-au1t
Reviewed By: benschac, atul
Subscribers: yayabosh, Adrian, ashoat
Differential Revision: https://phabricator.ashoat.com/D4006 |
129,191 | 11.05.2022 17:35:11 | -7,200 | f8ae5734bbedcb5692bbd24be4bab9c9622a3d93 | [web] Memoize friend list row buttons
Summary:
Shouldn't matter that much, but still it is probably a good idea
Depends on D4007
Test Plan: The same as D4007. Also check if cancel request and reject still work.
Reviewers: benschac, atul, def-au1t
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/settings/relationship/friend-list-row.react.js",
"new_path": "web/settings/relationship/friend-list-row.react.js",
"diff": "@@ -16,9 +16,9 @@ function FriendListRow(props: UserRowProps): React.Node {\nconst { userInfo } = props;\nconst { friendUser, unfrie... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Memoize friend list row buttons
Summary:
Shouldn't matter that much, but still it is probably a good idea
Depends on D4007
Test Plan: The same as D4007. Also check if cancel request and reject still work.
Reviewers: benschac, atul, def-au1t
Reviewed By: benschac, atul
Subscribers: ashoat, Adrian, yayabosh
... |
129,191 | 12.05.2022 20:37:48 | -7,200 | a00305277cd0a89983ebfa8db6971911eef710ad | [web] Introduce block list modal
Summary:
In this modal we display a list of users that are blocked.
{F55707}
Depends on D4037
Test Plan: Open the list and check if all the blocked users are displayed and sorted.
Reviewers: benschac, atul, def-au1t
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/settings/relationship/block-list-modal.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import { userRelationshipStatus } from 'lib/types/relationship-types';\n+import type { AccountUserInfo } from 'lib/types/user-type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce block list modal
Summary:
In this modal we display a list of users that are blocked.
{F55707}
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1313%3A98810
Depends on D4037
Test Plan: Open the list and check if all the blocked users are displayed and sorted.
Reviewers... |
129,179 | 13.05.2022 14:48:37 | 14,400 | 632ebc627ecfd688d5defd3f870a7bc1d8adaacf | [web] [fix] fix empty chat screen on load
Summary:
fixes:
before:
{F55778}
after:
{F55777}
Test Plan: clear application cookies (both user and anonymous) in the browser dev tools. Adding ashoat since we paired on it.
Reviewers: atul, ashoat, palys-swm, def-au1t
Subscribers: Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/redux/redux-setup.js",
"new_path": "web/redux/redux-setup.js",
"diff": "@@ -8,6 +8,7 @@ import {\n} from 'lib/actions/user-actions';\nimport baseReducer from 'lib/reducers/master-reducer';\nimport { mostRecentlyReadThreadSelector } from 'lib/selectors/thre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] [ENG-977] fix empty chat screen on load
Summary:
fixes: https://linear.app/comm/issue/ENG-977/on-initial-load-a-conversation-should-be-selected
before:
{F55778}
after:
{F55777}
Test Plan: clear application cookies (both user and anonymous) in the browser dev tools. Adding ashoat since we paired on it.
... |
129,196 | 17.05.2022 15:08:56 | -7,200 | e4430fd6d5369b01cccb632ff5a14eae953bef12 | Introduce and run clang-format updated to newer version
Summary: Update clang-format to v1.8.0 since 1.7.0 does not work on Intel
Test Plan: Check that yarn clang-format-all works on Intel mac
Reviewers: palys-swm, atul, ashoat
Subscribers: Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/CommSecureStore.mm",
"new_path": "native/ios/Comm/CommSecureStore.mm",
"diff": "@@ -28,4 +28,4 @@ folly::Optional<std::string> CommSecureStore::get(const std::string key) const {\n: folly::none;\n}\n-};\n+}; // namespace comm\n"
},
{
"c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce and run clang-format updated to newer version
Summary: Update clang-format to v1.8.0 since 1.7.0 does not work on Intel
Test Plan: Check that yarn clang-format-all works on Intel mac
Reviewers: palys-swm, atul, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: Adrian, yayabosh
Differential Revision: ht... |
129,190 | 19.05.2022 13:40:00 | -7,200 | f997677296b611490eb08185abfff57ae21050e8 | [services] Move generateUUID to global tools
Summary:
Depends on D4026
Extracting `generateUUID` from tunnelbroker into the global tools
Test Plan: Services still build
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/lib/src/GlobalTools.cpp",
"new_path": "services/lib/src/GlobalTools.cpp",
"diff": "#include \"GlobalTools.h\"\n#include <openssl/sha.h>\n+#include <boost/uuid/uuid.hpp>\n+#include <boost/uuid/uuid_generators.hpp>\n+#include <boost/uuid/uuid_io.hpp>\n#... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Move generateUUID to global tools
Summary:
Depends on D4026
Extracting `generateUUID` from tunnelbroker into the global tools
Test Plan: Services still build
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh
Differential Revision: https://phabricator.as... |
129,200 | 10.05.2022 16:23:08 | 14,400 | 8969a3a820b9543c8be4617325ee2da0c8ae5255 | [services][identity] helper function to create primary key for DynamoDB
Summary:
This function takes a partition key and optional sort key and returns a primary key for the DynamoDB client.
Depends on D3920
Test Plan: Unit tested
Reviewers: jimpo, karol-bisztyga, palys-swm
Subscribers: ashoat, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/database.rs",
"new_path": "services/identity/src/database.rs",
"diff": "+use std::collections::HashMap;\n+\nuse rusoto_core::Region;\n-use rusoto_dynamodb::DynamoDbClient;\n+use rusoto_dynamodb::{AttributeValue, DynamoDbClient};\npub stru... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][identity] helper function to create primary key for DynamoDB
Summary:
This function takes a partition key and optional sort key and returns a primary key for the DynamoDB client.
Depends on D3920
Test Plan: Unit tested
Reviewers: jimpo, karol-bisztyga, palys-swm
Reviewed By: jimpo, karol-bisztyga, palys... |
129,179 | 19.05.2022 15:34:05 | 14,400 | 4635612d06ef16eef512b752212137e225052b26 | [native, lib, web] move search sidebar functionality to lib hooks
Summary: move sidebar search to lib/hooks from web,native
Test Plan: use feature in both web and native
Reviewers: atul, palys-swm, def-au1t, ashoat
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/hooks/search-sidebars.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import { sidebarInfoSelector } from '../selectors/thread-selectors';\n+import type { SetState } from '../types/hook-types';\n+import type { SidebarInfo, ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native, lib, web] move search sidebar functionality to lib hooks
Summary: move sidebar search to lib/hooks from web,native
Test Plan: use feature in both web and native
Reviewers: atul, palys-swm, def-au1t, ashoat
Reviewed By: atul, palys-swm
Subscribers: ashoat, Adrian, yayabosh
Differential Revision: https://p... |
129,184 | 23.05.2022 17:14:44 | 14,400 | 2f3a72ed206f58c6d45fdfda290b0e84a746ec64 | [CI] Add `keyserver: yarn test` to CI
Summary: NA
Test Plan: Will test via Buildkite CI
Reviewers: def-au1t, palys-swm, benschac, ashoat
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/eslint_flow_jest.yml",
"new_path": ".buildkite/eslint_flow_jest.yml",
"diff": "@@ -5,5 +5,6 @@ steps:\n- 'yarn eslint --max-warnings=0 & yarn workspace lib flow & yarn workspace web flow & yarn workspace landing flow & yarn workspace native flow'\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Add `keyserver: yarn test` to CI
Summary: NA
Test Plan: Will test via Buildkite CI
Reviewers: def-au1t, palys-swm, benschac, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, yayabosh
Differential Revision: https://phabricator.ashoat.com/D4110 |
129,184 | 24.05.2022 16:42:12 | 14,400 | cf76516a57cce6df0f397848bcfdc7070f7d6596 | [native] `codeVersion` -> 133 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 133 |
129,190 | 25.05.2022 11:25:35 | -7,200 | 3667a7b5bd160a9338161dab9dce0b02cf741747 | [services] Backup - Implement generating holder
Summary:
Depends on D4029
Test Plan: Services still build
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Tools.cpp",
"new_path": "services/backup/src/Tools.cpp",
"diff": "#include \"Tools.h\"\n+#include \"GlobalTools.h\"\n+\n#include <chrono>\n#include <cstdlib>\n#include <random>\n@@ -19,5 +21,13 @@ std::string generateRandomString(std::size_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Implement generating holder
Summary:
Depends on D4029
https://linear.app/comm/issue/ENG-1128/implement-generating-holders
Test Plan: Services still build
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh
Differential Revision: https://phabricat... |
129,190 | 25.05.2022 11:31:27 | -7,200 | 89ac57ecc175823a04f872046544429a50b24ff7 | [services] Backup - Convert attachment holders from vector to string
Summary:
Depends on D4076
In we agreed to keep attachment lists in strings delimited with a single character.
Test Plan: Services still build
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/DatabaseEntities/BackupItem.cpp",
"new_path": "services/backup/src/DatabaseEntities/BackupItem.cpp",
"diff": "#include \"BackupItem.h\"\n#include \"Constants.h\"\n+#include \"GlobalConstants.h\"\nnamespace comm {\nnamespace network {\n@@ -2... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Convert attachment holders from vector to string
Summary:
Depends on D4076
In https://linear.app/comm/issue/ENG-1029/handle-attachments we agreed to keep attachment lists in strings delimited with a single character.
Test Plan: Services still build
Reviewers: palys-swm
Reviewed By: palys-swm
S... |
129,179 | 25.05.2022 14:36:56 | 14,400 | e0b2f89460b03829661143efd255019aa6f53823 | [lib, native, web] move onChangeSearch to hook
Summary: move onChangeSearch to lib/hooks/ from native and web.
Test Plan: Use the search sidebar feature in both native and web and confirm functionality still works as expected.
Reviewers: atul, palys-swm, def-au1t
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "lib/hooks/search-sidebars.js",
"new_path": "lib/hooks/search-sidebars.js",
"diff": "@@ -20,7 +20,7 @@ function useSearchSidebars(\n+listData: $ReadOnlyArray<SidebarInfo>,\n+searchState: SidebarSearchState,\n+setSearchState: SetState<SidebarSearchState>,\n- +se... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib, native, web] move onChangeSearch to hook
Summary: move onChangeSearch to lib/hooks/ from native and web.
Test Plan: Use the search sidebar feature in both native and web and confirm functionality still works as expected.
Reviewers: atul, palys-swm, def-au1t
Reviewed By: atul
Subscribers: ashoat, Adrian, yaya... |
129,184 | 25.05.2022 15:10:42 | 14,400 | 2f9948e9a30df83abe6332723014e754d351dfcc | [native] `codeVersion` -> 134 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 134 |
129,184 | 25.05.2022 15:49:34 | 14,400 | 40455fc82eeb0c8c92abe69ed79e8f2bea5eeb92 | [yarn] Bump `ansi-regex`
Summary: Takes `yarn audit` from 56->47 issues
Test Plan: CI
Reviewers: ashoat, palys-swm, def-au1t
Subscribers: Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -3733,17 +3733,17 @@ ansi-html@0.0.7:\nansi-regex@^2.0.0:\nversion \"2.1.1\"\nresolved \"https://registry.yarnpkg.com/ansi-regex/-/ansi-regex-2.1.1.tgz#c3b33ab5ee360d86e0e628f0468ae7ef27d654df\"\n- integrity sha... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [yarn] Bump `ansi-regex`
Summary: Takes `yarn audit` from 56->47 issues
Test Plan: CI
Reviewers: ashoat, palys-swm, def-au1t
Reviewed By: ashoat
Subscribers: Adrian, yayabosh
Differential Revision: https://phabricator.ashoat.com/D4128 |
129,179 | 27.05.2022 13:52:33 | 14,400 | 50a152a78c584830761063b41f1a0fabe99b130b | [web, lib] [refactor] move clear query to lib/hooks
Summary: move clear query method to lib hooks.
Test Plan: clear query functionality should work as it did before on web. This clear query wasn't implemented on native.
Reviewers: atul, palys-swm, def-au1t
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "lib/hooks/search-sidebars.js",
"new_path": "lib/hooks/search-sidebars.js",
"diff": "@@ -21,6 +21,7 @@ function useSearchSidebars(\n+searchState: SidebarSearchState,\n+setSearchState: SetState<SidebarSearchState>,\n+onChangeSearchInputText: (text: string) => mi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web, lib] [refactor] [ENG-536] move clear query to lib/hooks
Summary: move clear query method to lib hooks.
Test Plan: clear query functionality should work as it did before on web. This clear query wasn't implemented on native.
Reviewers: atul, palys-swm, def-au1t
Reviewed By: palys-swm
Subscribers: ashoat, Adri... |
129,187 | 01.06.2022 05:13:44 | 14,400 | fc22a7ffc480f3a2309f85a32c103a6306def98e | [keyserver] Run Docker as non-root user
Summary:
See [Linear task](https://linear.app/comm/issue/ENG-1076/update-node-dockerfile-to-not-run-as-root)
Depends on D4177
Test Plan: Make sure `docker-compose down -v && docker-compose up --build` still works
Reviewers: palys-swm, atul
Subscribers: varun, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/Dockerfile",
"new_path": "keyserver/Dockerfile",
"diff": "FROM node:16.13-bullseye\n-WORKDIR /app\n-\n#-------------------------------------------------------------------------------\n# STEP 0: INSTALL PREREQS\n# Install prereqs first so we don't hav... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Run Docker as non-root user
Summary:
See [Linear task](https://linear.app/comm/issue/ENG-1076/update-node-dockerfile-to-not-run-as-root)
Depends on D4177
Test Plan: Make sure `docker-compose down -v && docker-compose up --build` still works
Reviewers: palys-swm, atul
Reviewed By: atul
Subscribers: var... |
129,185 | 07.06.2022 11:46:27 | -7,200 | 5e7526cca2b4d76387bc98b579c880484d33bee1 | [web] Fix multimedia `onRemove` event propagation
Summary: Fix for multimedia remove issue:
Test Plan: Try to upload and remove that multimedia on web. It should be removed without being opened.
Reviewers: palys-swm, atul
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/media/multimedia.react.js",
"new_path": "web/media/multimedia.react.js",
"diff": "@@ -97,7 +97,8 @@ class Multimedia extends React.PureComponent<Props> {\n);\n}\n- remove: () => void = () => {\n+ remove: (event: SyntheticEvent<HTMLElement>) => void = event... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix multimedia `onRemove` event propagation
Summary: Fix for multimedia remove issue: https://linear.app/comm/issue/ENG-1224/uploaded-media-are-displayed-in-fullscreen-modal-when-trying-to-remove
Test Plan: Try to upload and remove that multimedia on web. It should be removed without being opened.
Reviewers: p... |
129,187 | 08.06.2022 00:22:47 | -7,200 | 6576a659bdf279a80ecde77ab5b365b2a7107a23 | [keyserver] GitHub Actions CI for Docker keyserver
Summary: Linear task: [ENG-997](https://linear.app/comm/issue/ENG-997/add-node-keyserver-docker-build-to-ci)
Test Plan: This diff is actually the test!
Reviewers: atul
Subscribers: palys-swm, Adrian, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".github/workflows/docker_keyserver.yml",
"diff": "+name: Docker keyserver CI\n+\n+on:\n+ push:\n+ branches: [master]\n+ paths-ignore:\n+ - 'native/**'\n+ - 'docs/**'\n+ - 'services/**'\n+\n+jobs:\n+ build:\n+ runs-on: ubuntu-18.04\n+\n+ steps:\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] GitHub Actions CI for Docker keyserver
Summary: Linear task: [ENG-997](https://linear.app/comm/issue/ENG-997/add-node-keyserver-docker-build-to-ci)
Test Plan: This diff is actually the test!
Reviewers: atul
Reviewed By: atul
Subscribers: palys-swm, Adrian, yayabosh
Differential Revision: https://phab.... |
129,184 | 02.06.2022 18:38:18 | 14,400 | 49e3bbd53c0f604c1d8d8990f66d66d22151bdf0 | [lib] Rename `reduceThreadUpdates` => `generateOpsForThreadUpdates`
Summary:
More accurately reflects the behavior of the function
Depends on D4197
Test Plan: No other occurences of "reduceThreadUpdates" in the codebase
Reviewers: def-au1t, palys-swm
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -52,7 +52,7 @@ import { setNewSessionActionType } from '../utils/action-utils';\nimport { getConfig } from '../utils/config';\nimport { sanitizeActionSecrets } from '../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Rename `reduceThreadUpdates` => `generateOpsForThreadUpdates`
Summary:
More accurately reflects the behavior of the function
---
Depends on D4197
Test Plan: No other occurences of "reduceThreadUpdates" in the codebase
Reviewers: def-au1t, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, yayabo... |
129,184 | 02.06.2022 18:53:38 | 14,400 | 0b7b96118692029255e016fc9c997ad54aed8723 | [lib] Destructure some properties in `reduceThreadInfos` to improve readability
Summary:
Super minor noop refactor. Thought destructuring some properties would make things a little more readable.
Depends on D4198
Test Plan: Noop
Reviewers: palys-swm, def-au1t
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -219,7 +219,8 @@ function reduceThreadInfos(\naction.type === processUpdatesActionType ||\naction.type === newThreadActionTypes.success\n) {\n- if (action.payload.update... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Destructure some properties in `reduceThreadInfos` to improve readability
Summary:
Super minor noop refactor. Thought destructuring some properties would make things a little more readable.
---
Depends on D4198
Test Plan: Noop
Reviewers: palys-swm, def-au1t
Reviewed By: palys-swm
Subscribers: ashoat, Adria... |
129,187 | 13.06.2022 14:47:15 | 25,200 | ccb9976f761cdb58ac527c2aeb312872c89edd86 | [keyserver] Type BackupConfig
Summary: We should really have a type for this
Test Plan: Just Flow for this one
Reviewers: atul, yayabosh
Subscribers: palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/cron/backups.js",
"new_path": "keyserver/src/cron/backups.js",
"diff": "@@ -16,9 +16,18 @@ const readdir = promisify(fs.readdir);\nconst lstat = promisify(fs.lstat);\nconst unlink = promisify(fs.unlink);\n+type BackupConfig = {\n+ +enabled: boole... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Type BackupConfig
Summary: We should really have a type for this
Test Plan: Just Flow for this one
Reviewers: atul, yayabosh
Reviewed By: atul, yayabosh
Subscribers: palys-swm, Adrian
Differential Revision: https://phab.comm.dev/D4262 |
129,187 | 15.06.2022 16:59:02 | 25,200 | cc2960919b8cc354a8729e5425d3c56f0259c388 | [keyserver] Extract deleteBackup
Summary: Working on [ENG-1234](https://linear.app/comm/issue/ENG-1234/add-functionality-to-limit-disk-space-usage-of-keyserver-mysql-backups), which will also require deleting old backups. Figured I'd extract this code.
Test Plan: Tested in combination with the next diff
Reviewers: atul... | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/cron/backups.js",
"new_path": "keyserver/src/cron/backups.js",
"diff": "@@ -194,19 +194,19 @@ function trySaveBackup(\n}\nasync function deleteOldestBackup() {\n- const [backupConfig, backupInfos] = await Promise.all([\n- getBackupConfig(),\n- ge... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Extract deleteBackup
Summary: Working on [ENG-1234](https://linear.app/comm/issue/ENG-1234/add-functionality-to-limit-disk-space-usage-of-keyserver-mysql-backups), which will also require deleting old backups. Figured I'd extract this code.
Test Plan: Tested in combination with the next diff
Reviewers: a... |
129,184 | 16.06.2022 23:22:55 | 25,200 | a00c99afbd5284c79a0597942846f1d9349cfbd7 | [native] `codeVersion` -> 135 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 135 |
129,196 | 07.06.2022 14:21:35 | -7,200 | 3ec3e117814a1da00a239a018868297cceedc7a9 | Prepare SQLiteQueryExecutor for single thread retrieval
Summary: This diff extends SQLiteQueryExecutor API to include method to retrieve single thread based on its ID
Test Plan: No testing plan. Further diffs will use this functionality and provide appropriate testing plan.
Reviewers: palys-swm, atul, varun
Subscribers... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -25,6 +25,7 @@ namespace jsi = facebook::jsi;\nclass DatabaseQueryExecutor {\npublic:\nvirtual std::string ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Prepare SQLiteQueryExecutor for single thread retrieval
Summary: This diff extends SQLiteQueryExecutor API to include method to retrieve single thread based on its ID
Test Plan: No testing plan. Further diffs will use this functionality and provide appropriate testing plan.
Reviewers: palys-swm, atul, varun
Reviewe... |
129,184 | 21.06.2022 21:29:59 | 25,200 | 15d88b32ad15562cb2749952e32f9ccfda63f255 | [lib] Get rid of `emptyArray` in `thread-reducer`
Summary:
This isn't used anywhere else and doesn't seem necessary? Seems like an unnecesary indirection instead of just placing an empty array (eg `[]`)
Depends on D4195
Test Plan: Didn't test
Reviewers: def-au1t, palys-swm
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -127,14 +127,13 @@ function generateOpsForThreadUpdates(\nreturn threadOperations;\n}\n-const emptyArray = [];\nfunction findInconsistencies(\naction: BaseAction,\nbefor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of `emptyArray` in `thread-reducer`
Summary:
This isn't used anywhere else and doesn't seem necessary? Seems like an unnecesary indirection instead of just placing an empty array (eg `[]`)
---
Depends on D4195
Test Plan: Didn't test
Reviewers: def-au1t, palys-swm
Reviewed By: palys-swm
Subscribers:... |
129,191 | 06.06.2022 13:52:41 | -7,200 | ee84b8052c24187beaba517b5a22a19fadc92bd0 | [web] Introduce add user item
Summary:
This component will be used on friend and block add lists.
{F80067}
Test Plan: Render the component on a modal and check if it looks correctly and reacts to user click action
Reviewers: def-au1t, atul, benschac
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/settings/relationship/add-users-list-item.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import type { AccountUserInfo } from 'lib/types/user-types.js';\n+\n+import css from './add-users-list.css';\n+\n+type Props = ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce add user item
Summary:
This component will be used on friend and block add lists.
{F80067}
Test Plan: Render the component on a modal and check if it looks correctly and reacts to user click action
Reviewers: def-au1t, atul, benschac
Reviewed By: atul
Subscribers: ashoat, Adrian, yayabosh
Differe... |
129,200 | 15.06.2022 13:07:16 | 14,400 | 05ad755d06d0de0d97963fc2c4e8f3df52639328 | [services][identity] clean up some redundancies
Summary: just some small refactors. not adding jim since this is a pretty trivial diff
Test Plan: ran cargo build
Reviewers: palys-swm, karol-bisztyga
Subscribers: ashoat, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/config.rs",
"new_path": "services/identity/src/config.rs",
"diff": "@@ -31,5 +31,5 @@ pub enum Error {\nfn get_key_from_file<P: AsRef<Path>>(path: P) -> Result<Key, Error> {\nlet bytes = fs::read(path)?;\n- Key::from_bytes(&bytes).map_err... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][identity] clean up some redundancies
Summary: just some small refactors. not adding jim since this is a pretty trivial diff
Test Plan: ran cargo build
Reviewers: palys-swm, karol-bisztyga
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, atul, yayabosh
Differential Revision: https://phab.comm.dev/D42... |
129,184 | 21.06.2022 16:13:09 | 25,200 | e8adf23f4dc8d2885b3ef53ad133af4fcf41dbaf | [lib] Simplify conditional logic in `wrapActionPromise:loadingInfo`
Summary: Noticed that some of the logic here could be simplified w/ optional chaining + nullish coalescing... so made those changes
Test Plan: Close reading + flow
Reviewers: palys-swm, def-au1t, yayabosh, ashoat
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/action-utils.js",
"new_path": "lib/utils/action-utils.js",
"diff": "@@ -60,13 +60,8 @@ function wrapActionPromise<\n): PromisedAction {\nconst loadingInfo: LoadingInfo = {\nfetchIndex: nextPromiseIndex++,\n- trackMultipleRequests: !!(\n- loadingOptio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Simplify conditional logic in `wrapActionPromise:loadingInfo`
Summary: Noticed that some of the logic here could be simplified w/ optional chaining + nullish coalescing... so made those changes
Test Plan: Close reading + flow
Reviewers: palys-swm, def-au1t, yayabosh, ashoat
Reviewed By: palys-swm, yayabosh, a... |
129,184 | 22.06.2022 12:34:58 | 25,200 | 9cf8c25cb67c77bac4257513c30b04edb42d20ba | [lib] Write some tests for `text-utils:trim(...)`
Summary: There's only three functions in `text-utils` so might as well crank out some unit tests for all of them.
Test Plan: Ran tests
Reviewers: def-au1t, palys-swm, yayabosh
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/text-utils.js",
"new_path": "lib/utils/text-utils.js",
"diff": "@@ -24,8 +24,10 @@ function pluralize(\nfunction trimText(text: string, maxLength: number): string {\nif (text.length <= maxLength) {\nreturn text;\n+ } else if (maxLength <= 3) {\n+ ret... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Write some tests for `text-utils:trim(...)`
Summary: There's only three functions in `text-utils` so might as well crank out some unit tests for all of them.
Test Plan: Ran tests
Reviewers: def-au1t, palys-swm, yayabosh
Reviewed By: palys-swm, yayabosh
Subscribers: ashoat, Adrian
Differential Revision: http... |
129,184 | 22.06.2022 13:00:46 | 25,200 | c200b83200bf719b6053305d2647b3e9a64da98d | [lib] Write some tests for `text-utils: pluralizeAndTrim(...)`
Summary: Did `pluralize(...)` and `trim(...)` so might as well do `pluralizeAndTrim(...)`
Test Plan: Ran tests
Reviewers: def-au1t, palys-swm, yayabosh
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/text-utils.js",
"new_path": "lib/utils/text-utils.js",
"diff": "@@ -40,7 +40,7 @@ function pluralizeAndTrim(\nreturn text;\n}\n}\n- return pluralize(nouns, 1);\n+ return trimText(pluralize(nouns, 1), maxLength);\n}\nexport { pluralize, trimText, plur... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Write some tests for `text-utils: pluralizeAndTrim(...)`
Summary: Did `pluralize(...)` and `trim(...)` so might as well do `pluralizeAndTrim(...)`
Test Plan: Ran tests
Reviewers: def-au1t, palys-swm, yayabosh
Reviewed By: palys-swm, yayabosh
Subscribers: ashoat, Adrian
Differential Revision: https://phab.co... |
129,191 | 06.06.2022 14:54:23 | -7,200 | 3fc1f94f82fb5adad177b2650d049dd592c55250 | [web] Prepare a list of users that should be displayed
Summary:
Create a list of users and sort it by username.
Depends on D4269
Test Plan: Render the component and check if the list is sorted correctly.
Reviewers: def-au1t, atul
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/settings/relationship/add-users-list.react.js",
"new_path": "web/settings/relationship/add-users-list.react.js",
"diff": "@@ -43,7 +43,6 @@ function AddUsersList(props: Props): React.Node {\nconst searchTextPresent = searchText.length > 0;\nconst userInfos... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Prepare a list of users that should be displayed
Summary:
Create a list of users and sort it by username.
Depends on D4269
Test Plan: Render the component and check if the list is sorted correctly.
Reviewers: def-au1t, atul
Reviewed By: atul
Subscribers: ashoat, Adrian, yayabosh
Differential Revision: http... |
129,184 | 22.06.2022 15:15:21 | 25,200 | 79a5ee1c5c9c3a5992f5444b7afba8f1561c4e23 | [lib] Rename `threadIsWatched` to `isThreadWatched`
Summary:
I think this is a better name.
This is an "opinionated" change, so open to abandoning if others disagree.
Depends on D4334
Test Plan: flow
Reviewers: def-au1t, palys-swm, yayabosh
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -112,7 +112,7 @@ function threadsToMessageIDsFromMessageInfos(\nreturn threads;\n}\n-function threadIsWatched(\n+function isThreadWatched(\nthreadID: string,\nthreadIn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Rename `threadIsWatched` to `isThreadWatched`
Summary:
I think this is a better name.
This is an "opinionated" change, so open to abandoning if others disagree.
---
Depends on D4334
Test Plan: flow
Reviewers: def-au1t, palys-swm, yayabosh
Reviewed By: palys-swm, yayabosh
Subscribers: ashoat, Adrian
Diffe... |
129,184 | 22.06.2022 15:48:31 | 25,200 | 8a9bef17c3834d98a484c07f9b79b184e98dc035 | [lib] Return `mergeNewMessages(...)` directly where possible in `reduceMessageStore(...)`
Summary:
Basically D4337, but for all the other `mergeNewMessages(...)` callsites.
This is just a noop refactor, trying to simplify `message-reducer`
Depends on D4337
Test Plan: Close reading, flow
Reviewers: def-au1t, palys-swm, ... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -726,16 +726,12 @@ function reduceMessageStore(\naction.payload.messagesResult.truncationStatuses,\n);\n- const {\n- messageStoreOperations,\n- messageStore: mergedMes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Return `mergeNewMessages(...)` directly where possible in `reduceMessageStore(...)`
Summary:
Basically D4337, but for all the other `mergeNewMessages(...)` callsites.
This is just a noop refactor, trying to simplify `message-reducer`
---
Depends on D4337
Test Plan: Close reading, flow
Reviewers: def-au1t, p... |
129,184 | 22.06.2022 19:11:44 | 25,200 | 4bea17c16501975a74cd012d1b50c8038f16c9d8 | [web][landing] Fix miscellaneous CSS issues
Summary:
Ran the code analysis tool in IDE which surfaced some misc CSS issues. I'll label each issue inline.
Depends on D4338
Test Plan: NA, careful reading
Reviewers: palys-swm, def-au1t, yayabosh
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.css",
"new_path": "landing/info-block.css",
"diff": ".description {\nline-height: 1.5;\nfont-weight: 400;\n- font-family: 'IBM Plex Sans';\n+ font-family: 'IBM Plex Sans', sans-serif;\n}\n"
},
{
"change_type": "MODIFY",
"old_path... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web][landing] Fix miscellaneous CSS issues
Summary:
Ran the code analysis tool in IDE which surfaced some misc CSS issues. I'll label each issue inline.
---
Depends on D4338
Test Plan: NA, careful reading
Reviewers: palys-swm, def-au1t, yayabosh
Reviewed By: palys-swm, yayabosh
Subscribers: ashoat, Adrian
Diff... |
129,190 | 27.06.2022 12:09:42 | -7,200 | 5c6ae6d154c327cfa93f9cd601ca7912f505650d | [services] Tests - Add tools
Summary:
Depends on D4164
Adding tools with one function: `generate_nbytes`. It returns `n` bytes (that are the same).
Test Plan: this doesn't do anything on its own. Tests can be built.
Reviewers: palys-swm, geekbrother, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/commtest/tests/lib/tools.rs",
"diff": "+use bytesize::ByteSize;\n+\n+#[allow(dead_code)]\n+pub fn generate_nbytes(number_of_bytes: usize, predefined_byte_value: Option<u8>) -> Vec<u8> {\n+ let byte_value = predefined_byte_value.unwrap_o... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Add tools
Summary:
Depends on D4164
Adding tools with one function: `generate_nbytes`. It returns `n` bytes (that are the same).
Test Plan: this doesn't do anything on its own. Tests can be built.
Reviewers: palys-swm, geekbrother, varun
Reviewed By: palys-swm, varun
Subscribers: ashoat, palys-... |
129,190 | 27.06.2022 12:09:44 | -7,200 | 0b9ee720e5ac10272d4f531b4ce63e64d32887b2 | [services] Tests - Add create new backup
Summary:
Depends on D4225
Adding a script for creating a new backup.
Test Plan: This, for now, doesn't do anything.
Reviewers: ashoat, palys-swm, varun
Subscribers: jimpo, ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/commtest/tests/backup/create_new_backup.rs",
"diff": "+#[path = \"./backup_utils.rs\"]\n+mod backup_utils;\n+#[path = \"../lib/tools.rs\"]\n+mod tools;\n+\n+use crate::backup_utils::{\n+ proto::create_new_backup_request::Data::*, proto:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Add create new backup
Summary:
Depends on D4225
Adding a script for creating a new backup.
Test Plan: This, for now, doesn't do anything.
Reviewers: ashoat, palys-swm, varun
Reviewed By: palys-swm, varun
Subscribers: jimpo, ashoat, palys-swm, Adrian, atul, yayabosh
Differential Revision: https... |
129,190 | 27.06.2022 12:09:47 | -7,200 | 4605babb58c12a8000a72a828e514bcbf8744a7b | [services] Tests - Add send log
Summary:
Depends on D4165
Adding a script for sending log.
Test Plan: This, for now, doesn't do anything.
Reviewers: ashoat, palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/commtest/tests/backup/send_log.rs",
"diff": "+#[path = \"./backup_utils.rs\"]\n+mod backup_utils;\n+#[path = \"../lib/tools.rs\"]\n+mod tools;\n+\n+use crate::backup_utils::{\n+ proto::send_log_request::Data::*, proto::SendLogRequest, B... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Add send log
Summary:
Depends on D4165
Adding a script for sending log.
Test Plan: This, for now, doesn't do anything.
Reviewers: ashoat, palys-swm, varun
Reviewed By: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh
Differential Revision: https://phab.comm.dev/D4166 |
129,190 | 27.06.2022 12:09:49 | -7,200 | 6ae9b544bcc40848bc5554afeb356f7aae00f8c8 | [services] Tests - Add byte size crate
Summary:
Depends on D4166
Adding `bytesize` crate
Test Plan: None, this is not used yet, the project can still be built.
Reviewers: palys-swm, varun, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/Cargo.lock",
"new_path": "services/commtest/Cargo.lock",
"diff": "@@ -35,6 +35,12 @@ version = \"1.1.0\"\nsource = \"registry+https://github.com/rust-lang/crates.io-index\"\nchecksum = \"c4872d67bab6358e59559027aa3b9157c53d9358c51423c17554809... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Add byte size crate
Summary:
Depends on D4166
Adding `bytesize` crate
Test Plan: None, this is not used yet, the project can still be built.
Reviewers: palys-swm, varun, geekbrother, ashoat
Reviewed By: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh
Differential Revisi... |
129,190 | 27.06.2022 12:09:56 | -7,200 | df941b8c438c469e412fb0b5b7bde7628219f452 | [services] Backup - Fix data size database limit
Summary:
Depends on D4232
The database limit is invalid. I found out in the docs that it should be 400kb (link in the code).
Test Plan: -
Reviewers: palys-swm, ashoat
Subscribers: varun, ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Constants.h",
"new_path": "services/backup/src/Constants.h",
"diff": "@@ -18,7 +18,9 @@ const std::string BACKUP_TABLE_NAME =\n// than the chunk limit, once we get the amount of data of size equal to the\n// limit, we wouldn't know if we sh... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Fix data size database limit
Summary:
Depends on D4232
The database limit is invalid. I found out in the docs that it should be 400kb (link in the code).
Test Plan: -
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: varun, ashoat, palys-swm, Adrian, atul, yayabosh
Diff... |
129,191 | 13.06.2022 19:16:51 | -7,200 | cbbc1a7d19815144fa21d93fd1b82db23559b1c5 | [web] Introduce block users modal
Summary:
This modal allows blocking users. Only users that are not blocked by the viewer can be blocked.
{F82770}
Depends on D4312
Test Plan: Render the modal and check if blocking users works correctly.
Reviewers: def-au1t, atul
Subscribers: ashoat, Adrian, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/settings/relationship/block-users-modal.react.js",
"diff": "+// @flow\n+\n+import { faUserShield } from '@fortawesome/free-solid-svg-icons';\n+import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\n+import * as React from 'react'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce block users modal
Summary:
This modal allows blocking users. Only users that are not blocked by the viewer can be blocked.
{F82770}
Depends on D4312
Test Plan: Render the modal and check if blocking users works correctly.
Reviewers: def-au1t, atul
Reviewed By: atul
Subscribers: ashoat, Adrian, ya... |
129,200 | 27.06.2022 02:57:48 | 14,400 | a9bf0e442d0806779da81e1f7ff712d74b39f9bd | [services][identity] PAKE workflow enum
Summary: This enum lets us determine if a PAKE login request is part of a registration or login workflow, so that we can send back the appropriate response struct
Test Plan: cargo build worked
Reviewers: jimpo, palys-swm, karol-bisztyga
Subscribers: ashoat, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/service.rs",
"new_path": "services/identity/src/service.rs",
"diff": "@@ -26,6 +26,11 @@ mod proto {\ntonic::include_proto!(\"identity\");\n}\n+enum PakeWorkflow {\n+ Registration,\n+ Login,\n+}\n+\n#[derive(derive_more::Constructor)]\npu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][identity] PAKE workflow enum
Summary: This enum lets us determine if a PAKE login request is part of a registration or login workflow, so that we can send back the appropriate response struct
Test Plan: cargo build worked
Reviewers: jimpo, palys-swm, karol-bisztyga
Reviewed By: palys-swm
Subscribers: as... |
129,200 | 24.06.2022 09:14:25 | 14,400 | 0867427da96b7e27a862b4bd5b7a8a0f498319cd | [services][identity] helper function to start PAKE login
Summary: fetch registration data from database, generate challenge for user, return challenge or error
Test Plan: tested with method that calls this helper function
Reviewers: palys-swm, jimpo, karol-bisztyga
Subscribers: ashoat, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/service.rs",
"new_path": "services/identity/src/service.rs",
"diff": "use chrono::Utc;\nuse constant_time_eq::constant_time_eq;\nuse futures_core::Stream;\n+use opaque_ke::{\n+ CredentialFinalization, CredentialRequest, ServerLogin,\n+ Se... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][identity] helper function to start PAKE login
Summary: fetch registration data from database, generate challenge for user, return challenge or error
Test Plan: tested with method that calls this helper function
Reviewers: palys-swm, jimpo, karol-bisztyga
Reviewed By: palys-swm, karol-bisztyga
Subscriber... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.