author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,948 | 17.10.2018 09:57:02 | 25,200 | 9d17eba121dab054c21307b9696ba7471dff4a74 | compressio: do not schedule new I/Os when there is no worker (stream closed). | [
{
"change_type": "MODIFY",
"old_path": "pkg/compressio/compressio.go",
"new_path": "pkg/compressio/compressio.go",
"diff": "@@ -323,10 +323,10 @@ func (p *pool) schedule(c *chunk, callback func(*chunk) error) error {\ninputChan chan *chunk\noutputChan chan result\n)\n- if c != nil {\n+ if c != nil &... | Go | Apache License 2.0 | google/gvisor | compressio: do not schedule new I/Os when there is no worker (stream closed).
PiperOrigin-RevId: 217536677
Change-Id: Ib9a5a2542df12d0bc5592b91463ffd646e2ec295 |
259,891 | 17.10.2018 10:50:24 | 25,200 | 9b3550f70bf1612e2c474b3826b0347b21503401 | runsc: Add --pid flag to runsc kill.
pid allows specific processes to be signalled rather than the container root
process or all processes in the container. containerd needs to SIGKILL exec'd
processes that timeout and check whether processes are still alive. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -756,8 +756,22 @@ func (l *Loader) signalProcess(cid string, pid, signo int32, sendToFGProcess boo\nep, ok := l.processes[eid]\nl.mu.Unlock()\n+ // The caller may be signaling a process not... | Go | Apache License 2.0 | google/gvisor | runsc: Add --pid flag to runsc kill.
--pid allows specific processes to be signalled rather than the container root
process or all processes in the container. containerd needs to SIGKILL exec'd
processes that timeout and check whether processes are still alive.
PiperOrigin-RevId: 217547636
Change-Id: I2058ebb548b51c8eb748f5884fb88bad0b532e45 |
259,891 | 17.10.2018 10:54:19 | 25,200 | 8cbca46b6d99bcf0b2647ffa247b0963f872916b | Remove incorrect TODO. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/events.go",
"new_path": "runsc/boot/events.go",
"diff": "@@ -29,7 +29,6 @@ type Event struct {\n// Stats is the runc specific stats structure for stability when encoding and\n// decoding stats.\n-// TODO: Many fields aren't obtainable due to a lack ... | Go | Apache License 2.0 | google/gvisor | Remove incorrect TODO.
PiperOrigin-RevId: 217548429
Change-Id: Ie640c881fdc4fc70af58c8ca834df1ac531e519a |
259,881 | 17.10.2018 11:51:43 | 25,200 | 578fe5a50dcf8e104b6bce3802987b0f8c069ade | Fix PTRACE_GETREGSET write size
The existing logic is backwards and writes iov_len == 0 for a full write. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/ptrace.go",
"new_path": "pkg/sentry/kernel/ptrace.go",
"diff": "@@ -921,7 +921,13 @@ func (t *Task) Ptrace(req int64, pid ThreadID, addr, data usermem.Addr) error {\nif err != nil {\nreturn err\n}\n- ar.End -= usermem.Addr(n)\n+\n+ // Update ... | Go | Apache License 2.0 | google/gvisor | Fix PTRACE_GETREGSET write size
The existing logic is backwards and writes iov_len == 0 for a full write.
PiperOrigin-RevId: 217560377
Change-Id: I5a39c31bf0ba9063a8495993bfef58dc8ab7c5fa |
259,881 | 17.10.2018 13:05:14 | 25,200 | 8fa6f6fe769ede042b651e5b82bd93721e3aa339 | Reflow comment to 80 columns | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/strace.go",
"new_path": "pkg/sentry/strace/strace.go",
"diff": "@@ -568,8 +568,10 @@ func (s SyscallMap) SyscallExit(context interface{}, t *kernel.Task, sysno, rval\n}\n}\n-// ConvertToSysnoMap converts the names to a map keyed on the syscal... | Go | Apache License 2.0 | google/gvisor | Reflow comment to 80 columns
PiperOrigin-RevId: 217573168
Change-Id: Ic1914d0ef71bab020e3ee11cf9c4a50a702bd8dd |
259,854 | 17.10.2018 13:24:52 | 25,200 | 8c85f5e9ce1d7e25010ac295006555a46034bc39 | Fix typos in socket_test | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/socket_test.go",
"new_path": "pkg/sentry/fs/host/socket_test.go",
"diff": "@@ -71,18 +71,18 @@ func TestSocketIsBlocking(t *testing.T) {\nt.Fatalf(\"newSocket(%v) failed => %v\", pair[0], err)\n}\ndefer sock.DecRef()\n- // Test that the sock... | Go | Apache License 2.0 | google/gvisor | Fix typos in socket_test
PiperOrigin-RevId: 217576188
Change-Id: I82e45c306c5c9161e207311c7dbb8a983820c1df |
259,854 | 17.10.2018 16:30:11 | 25,200 | f7419fec26d1fd0d12936cc44f2c3481bbade033 | Use generic ilist in Unix transport queue
This should improve performance. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/BUILD",
"new_path": "pkg/sentry/socket/unix/transport/BUILD",
"diff": "package(licenses = [\"notice\"]) # Apache 2.0\nload(\"//tools/go_stateify:defs.bzl\", \"go_library\")\n+load(\"//tools/go_generics:defs.bzl\", \"go_template... | Go | Apache License 2.0 | google/gvisor | Use generic ilist in Unix transport queue
This should improve performance.
PiperOrigin-RevId: 217610560
Change-Id: I370f196ea2396f1715a460b168ecbee197f94d6c |
259,854 | 20.10.2018 17:57:19 | 25,200 | d7c11c741752813e56b7d8726a575a520260c56a | Refcount Unix transport queue
This allows us to release messages in the queue when all users close. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/BUILD",
"new_path": "pkg/sentry/socket/unix/transport/BUILD",
"diff": "@@ -29,6 +29,7 @@ go_library(\nvisibility = [\"//:sandbox\"],\ndeps = [\n\"//pkg/ilist\",\n+ \"//pkg/refs\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n\"/... | Go | Apache License 2.0 | google/gvisor | Refcount Unix transport queue
This allows us to release messages in the queue when all users close.
PiperOrigin-RevId: 218033550
Change-Id: I2f6e87650fced87a3977e3b74c64775c7b885c1b |
259,884 | 21.10.2018 19:41:44 | 25,200 | c2c0f9cb7e8320de06ef280c6184bb6aeda71627 | Updated cleanup code to be more explicit about ignoring errors.
Errors are shown as being ignored by assigning to the blank identifier. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -190,7 +190,9 @@ func (c *Cgroup) Install(res *specs.LinuxResources) error {\n// Mark that cgroup resources are owned by me.\nlog.Debugf(\"Creating cgroup %q\", c.Name)\nc.Own = true\n-... | Go | Apache License 2.0 | google/gvisor | Updated cleanup code to be more explicit about ignoring errors.
Errors are shown as being ignored by assigning to the blank identifier.
PiperOrigin-RevId: 218103819
Change-Id: I7cc7b9d8ac503a03de5504ebdeb99ed30a531cf2 |
259,858 | 23.10.2018 11:26:31 | 25,200 | ce3a762038006429b1eb3b855d4e9c5d700edfda | Remove artificial name length check.
This should be determined by the filesystem. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/handlers.go",
"new_path": "pkg/p9/handlers.go",
"diff": "@@ -27,8 +27,6 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/log\"\n)\n-const maximumNameLength = 255\n-\n// ExtractErrno extracts a syscall.Errno from a error, best effort.\nfunc ExtractErrno... | Go | Apache License 2.0 | google/gvisor | Remove artificial name length check.
This should be determined by the filesystem.
PiperOrigin-RevId: 218376553
Change-Id: I55d176e2cdf8acdd6642789af057b98bb8ca25b8 |
259,858 | 23.10.2018 12:51:26 | 25,200 | 1369e17504f994024aea84bb0e4aa9ddce00f70a | Remove blanket TODO, as it is self-evident. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -378,7 +378,6 @@ func (e *endpoint) Peek([][]byte) (uintptr, tcpip.ControlMessages, *tcpip.Error)\n// SetSockOpt sets a socket option. Currently not supported.... | Go | Apache License 2.0 | google/gvisor | Remove blanket TODO, as it is self-evident.
PiperOrigin-RevId: 218390517
Change-Id: Ic891c1626e62a6c4ed57f8180740872bcd1be177 |
259,858 | 24.10.2018 15:51:46 | 25,200 | e7191f058f550cc3a203a854a1d81f7746c96e53 | Use TRAP to simplify vsyscall emulation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess.go",
"diff": "@@ -357,15 +357,13 @@ func (t *thread) destroy() {\n// init initializes trace options.\nfunc (t *thread) init() {\n- // Set our TRACESYSGOOD option to d... | Go | Apache License 2.0 | google/gvisor | Use TRAP to simplify vsyscall emulation.
PiperOrigin-RevId: 218592058
Change-Id: I373a2d813aa6cc362500dd5a894c0b214a1959d7 |
259,853 | 25.10.2018 11:45:37 | 25,200 | 479cd52a6075066e93ce0c1bd0f183bb5df4fcc7 | Uninstall() should not fail if a cgroup directory doesn't exist
It can be occurred if two controllers are mounted together or if Uninstall() is called on a error path. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -229,7 +229,11 @@ func (c *Cgroup) Uninstall() error {\ndefer cancel()\nb := backoff.WithContext(backoff.NewConstantBackOff(100*time.Millisecond), ctx)\nif err := backoff.Retry(func() e... | Go | Apache License 2.0 | google/gvisor | Uninstall() should not fail if a cgroup directory doesn't exist
It can be occurred if two controllers are mounted together or if Uninstall() is called on a error path.
PiperOrigin-RevId: 218723886
Change-Id: I69d7a3c0685a7da38527ea8b7b301dbe96268285 |
259,881 | 26.10.2018 12:17:51 | 25,200 | 624cc329d89bff5f2b0e787d255e718514ec585b | Order feature strings by block | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid.go",
"new_path": "pkg/cpuid/cpuid.go",
"diff": "@@ -228,6 +228,37 @@ var linuxBlockOrder = []block{1, 6, 0, 5, 2, 4}\n// names of the basic features in Linux defined in\n// arch/x86/kernel/cpu/capflags.c.\nvar x86FeatureStrings = map[Feature]st... | Go | Apache License 2.0 | google/gvisor | Order feature strings by block
PiperOrigin-RevId: 218894181
Change-Id: I97d0c74175f4aa528363f768a0a85d6953ea0bfd |
259,881 | 26.10.2018 14:25:26 | 25,200 | e60525e4ddd9a7fff8b27d0be8119ce3203a2f5c | Add block 3 features to /proc/cpuinfo
Linux added these block 3 features to the end of /proc/cpuinfo in
This also fixes that block 3 features were completely missing from
FeatureSet.FlagsString(false) because FlagsString only prints Linux
blocks regardless of the cpuinfo option. | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid.go",
"new_path": "pkg/cpuid/cpuid.go",
"diff": "@@ -222,7 +222,7 @@ const (\n// which doesn't match well here, so for the /proc/cpuinfo generation we simply\n// re-map the blocks to Linux's ordering and then go through the bits in each\n// bloc... | Go | Apache License 2.0 | google/gvisor | Add block 3 features to /proc/cpuinfo
Linux added these block 3 features to the end of /proc/cpuinfo in
dfb4a70f20c5b3880da56ee4c9484bdb4e8f1e65.
This also fixes that block 3 features were completely missing from
FeatureSet.FlagsString(false) because FlagsString only prints Linux
blocks regardless of the cpuinfo option.
PiperOrigin-RevId: 218913816
Change-Id: I2f9c38c7c9da4b247a140877d4aca782e80684bd |
259,891 | 29.10.2018 10:30:58 | 25,200 | b42a2a32038a8d9098d94c0435fe99e1e2b9a7f2 | Removes outdated TODO. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -668,13 +668,6 @@ func (l *Loader) waitContainer(cid string, waitStatus *uint32) error {\n}\nfunc (l *Loader) waitPID(tgid kernel.ThreadID, cid string, clearStatus bool, waitStatus *uint32)... | Go | Apache License 2.0 | google/gvisor | Removes outdated TODO.
PiperOrigin-RevId: 219151173
Change-Id: I73014ea648ae485692ea0d44860c87f4365055cb |
260,013 | 29.10.2018 11:54:28 | 25,200 | 422863373f0c90693a21feecb70e89387e3dfd13 | Add copybara rules to export C++ test code. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -9,6 +9,7 @@ http_archive(\nurl = \"https://github.com/bazelbuild/bazel-gazelle/releases/download/0.15.0/bazel-gazelle-0.15.0.tar.gz\",\nsha256 = \"6e875ab4b6bf64a38c352887760f21203ab054676d9c1b274963907e0768740... | Go | Apache License 2.0 | google/gvisor | Add copybara rules to export C++ test code.
PiperOrigin-RevId: 219166541
Change-Id: Ieebadaed4096eb48f00fba663e1c76fb41438078 |
259,891 | 29.10.2018 11:54:35 | 25,200 | 805a27c441c2ca133a3a37dc45f79286b5044a70 | Install containerd and crictl when running tests in Kokoro. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -48,6 +48,60 @@ set +e\nbazel test --test_output=errors //...\nexit_code=${?}\n+# This function spawns a subshell to install crictl and containerd.\n+installCrictl() (\n+ # Fail on any error.... | Go | Apache License 2.0 | google/gvisor | Install containerd and crictl when running tests in Kokoro.
PiperOrigin-RevId: 219166563
Change-Id: If4922eb5dd119b00f2c4bc7a5e016016ce9b9e45 |
259,858 | 30.10.2018 22:45:51 | 25,200 | 0091db9cbddb6c9fb4c96fbde980780c98006eda | kvm: use private futexes.
Use private futexes for performance and to align with other runtime uses. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/machine_unsafe.go",
"diff": "@@ -88,7 +88,7 @@ func (c *vCPU) notify() {\n_, _, errno := syscall.RawSyscall6(\nsyscall.SYS_FUTEX,\nuintptr(unsafe.Pointer(&c.state)),\n- linux.FUTE... | Go | Apache License 2.0 | google/gvisor | kvm: use private futexes.
Use private futexes for performance and to align with other runtime uses.
PiperOrigin-RevId: 219422634
Change-Id: Ief2af5e8302847ea6dc246e8d1ee4d64684ca9dd |
259,858 | 31.10.2018 10:07:06 | 25,200 | e9dbd5ab67bc31e59910930e6c1b551c0fd05ee6 | kvm: avoid siginfo allocations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/context.go",
"new_path": "pkg/sentry/platform/kvm/context.go",
"diff": "@@ -29,6 +29,9 @@ type context struct {\n// machine is the parent machine, and is immutable.\nmachine *machine\n+ // info is the arch.SignalInfo cached for this con... | Go | Apache License 2.0 | google/gvisor | kvm: avoid siginfo allocations.
PiperOrigin-RevId: 219492587
Change-Id: I47f6fc0b74a4907ab0aff03d5f26453bdb983bb5 |
259,992 | 31.10.2018 11:27:10 | 25,200 | ccc3d7ca11a2a623587c651a6690aaa46d2c2665 | Make lazy open the mode of operation for fsgofer
With recent changes to 9P server, path walks are now safe inside
open, create, rename and setattr calls. To simplify the code, remove
the lazyopen=false mode that was used for bind mounts, and converge
all mounts to using lazy open. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -124,9 +124,6 @@ func (g *Gofer) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\nats = append(ats, fsgofer.NewAttachPoint(\"/\", fsgofer.Config{\nROMount: spec.Root.Readonly,\... | Go | Apache License 2.0 | google/gvisor | Make lazy open the mode of operation for fsgofer
With recent changes to 9P server, path walks are now safe inside
open, create, rename and setattr calls. To simplify the code, remove
the lazyopen=false mode that was used for bind mounts, and converge
all mounts to using lazy open.
PiperOrigin-RevId: 219508628
Change-Id: I073e7e1e2e9a9972d150eaf4cb29e553997a9b76 |
259,858 | 31.10.2018 15:49:10 | 25,200 | c4bbb54168a9014048d2144110e70daf5a5b8211 | kvm: add detailed traces on vCPU errors.
This improves debuggability greatly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill.go",
"new_path": "pkg/sentry/platform/kvm/bluepill.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"reflect\"\n\"syscall\"\n+ \"gvisor.googlesource.com/gvisor/pkg/sentry/arch\"\n\"gvisor.googlesource.com/gvisor/pkg/sentry/platform/s... | Go | Apache License 2.0 | google/gvisor | kvm: add detailed traces on vCPU errors.
This improves debuggability greatly.
PiperOrigin-RevId: 219551560
Change-Id: I2ecaffdd1c17b0d9f25911538ea6f693e2bc699f |
259,858 | 31.10.2018 15:58:21 | 25,200 | fb613020c7db323c705adf6ae0f954bee4ab5fec | kvm: simplify floating point logic.
This reduces the number of floating point save/restore cycles required (since
we don't need to restore immediately following the switch, this always happens
in a known context) and allows the kernel hooks to capture state. This lets us
remove calls like "Current()". | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_amd64.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_amd64.go",
"diff": "@@ -47,8 +47,8 @@ func redpill() {\n// bluepillArchEnter is called during bluepillEnter.\n//\n//go:nosplit\n-func bluepillArchEnter(context *arch.Sign... | Go | Apache License 2.0 | google/gvisor | kvm: simplify floating point logic.
This reduces the number of floating point save/restore cycles required (since
we don't need to restore immediately following the switch, this always happens
in a known context) and allows the kernel hooks to capture state. This lets us
remove calls like "Current()".
PiperOrigin-RevId: 219552844
Change-Id: I7676fa2f6c18b9919718458aa888b832a7db8cab |
259,854 | 31.10.2018 18:21:11 | 25,200 | eeddae1199d9b84ee84011be0019328724ebdcf3 | Use syserr style error translation in netstack's rawfile
Replacing map lookups with slice indexing is higher performance. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/rawfile/errors.go",
"new_path": "pkg/tcpip/link/rawfile/errors.go",
"diff": "package rawfile\nimport (\n+ \"fmt\"\n\"syscall\"\n\"gvisor.googlesource.com/gvisor/pkg/tcpip\"\n)\n-var translations = map[syscall.Errno]*tcpip.Error{\n- syscall.EEXIS... | Go | Apache License 2.0 | google/gvisor | Use syserr style error translation in netstack's rawfile
Replacing map lookups with slice indexing is higher performance.
PiperOrigin-RevId: 219569901
Change-Id: I9b7cd22abd4b95383025edbd5a80d1c1a4496936 |
259,854 | 31.10.2018 18:41:48 | 25,200 | 59b7766af7c78f330d09044e68bb195e495993ea | Fix a race where keepalives could be sent while there is pending data | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/BUILD",
"new_path": "pkg/tcpip/transport/tcp/BUILD",
"diff": "@@ -62,8 +62,6 @@ go_test(\n\"tcp_test.go\",\n\"tcp_timestamp_test.go\",\n],\n- # FIXME\n- tags = [\"flaky\"],\ndeps = [\n\":tcp\",\n\"//pkg/tcpip\",\n"
},
{
"change_... | Go | Apache License 2.0 | google/gvisor | Fix a race where keepalives could be sent while there is pending data
PiperOrigin-RevId: 219571556
Change-Id: I5a1042c1cb05eb2711eb01627fd298bad6c543a6 |
259,891 | 01.11.2018 10:35:04 | 25,200 | a4cc93c7bf40679e62a2b0eaa2419a4a9536cc14 | Close http.Response.Body after Get request.
From
"When err is nil, resp always contains a non-nil resp.Body. Caller should close
resp.Body when done reading from it." | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/testutil/testutil.go",
"new_path": "runsc/test/testutil/testutil.go",
"diff": "@@ -230,9 +230,13 @@ func Poll(cb func() error, timeout time.Duration) error {\n// WaitForHTTP tries GET requests on a port until the call succeeds or timeout.\nfunc Wait... | Go | Apache License 2.0 | google/gvisor | Close http.Response.Body after Get request.
From https://golang.org/pkg/net/http/#Get:
"When err is nil, resp always contains a non-nil resp.Body. Caller should close
resp.Body when done reading from it."
PiperOrigin-RevId: 219658052
Change-Id: I556e88ac4f2c90cd36ab16cd3163d1a52afc32b7 |
259,968 | 01.11.2018 11:57:09 | 25,200 | b23cd33682a9a8bd727fa45b8424eb55d91c3086 | modify modeRegexp to adapt the default spec of containerd
the mode=755
didn't match the pattern modeRegexp = regexp.MustCompile("0[0-7][0-7][0-7]").
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tmpfs/fs.go",
"new_path": "pkg/sentry/fs/tmpfs/fs.go",
"diff": "@@ -44,7 +44,7 @@ const (\n)\n// modeRegexp is the expected format of the mode option.\n-var modeRegexp = regexp.MustCompile(\"0[0-7][0-7][0-7]\")\n+var modeRegexp = regexp.MustCompi... | Go | Apache License 2.0 | google/gvisor | modify modeRegexp to adapt the default spec of containerd
https://github.com/containerd/containerd/blob/master/oci/spec.go#L206, the mode=755
didn't match the pattern modeRegexp = regexp.MustCompile("0[0-7][0-7][0-7]").
Closes #112
Signed-off-by: Juan <xionghuan.cn@gmail.com>
Change-Id: I469e0a68160a1278e34c9e1dbe4b7784c6f97e5a
PiperOrigin-RevId: 219672525 |
259,884 | 01.11.2018 17:39:20 | 25,200 | 9d69d85bc13d4f0956a39951b5cd6777f938cffd | Make error messages a bit more user friendly.
Updated error messages so that it doesn't print full Go struct representations
when running a new container in a sandbox. For example, this occurs frequently
when commands are not found when doing a 'kubectl exec'. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"encoding/json\"\n\"fmt\"\n\"sort\"\n+ \"strings\"\n\"text/tabwriter\"\n\"time\"\n@@ -88,6 +89,16 @@ type ExecArgs struct {\nContainerID string\n}\n+//... | Go | Apache License 2.0 | google/gvisor | Make error messages a bit more user friendly.
Updated error messages so that it doesn't print full Go struct representations
when running a new container in a sandbox. For example, this occurs frequently
when commands are not found when doing a 'kubectl exec'.
PiperOrigin-RevId: 219729141
Change-Id: Ic3a7bc84cd7b2167f495d48a1da241d621d3ca09 |
259,992 | 01.11.2018 17:43:50 | 25,200 | b6b81fd04ba93db3268ff649c9d23a25c9b89db5 | Add new log format that is compatible with Kubernetes
Fluentd configuration uses 'log' for the log message
while containerd uses 'msg'. Since we can't have a single
JSON format for both, add another log format and make
debug log configurable. | [
{
"change_type": "MODIFY",
"old_path": "pkg/log/BUILD",
"new_path": "pkg/log/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_library(\n\"glog.go\",\n\"glog_unsafe.go\",\n\"json.go\",\n+ \"json_k8s.go\",\n\"log.go\",\n],\nimportpath = \"gvisor.googlesource.com/gvisor/pkg/log\",\n"
},
{
"change_type": "AD... | Go | Apache License 2.0 | google/gvisor | Add new log format that is compatible with Kubernetes
Fluentd configuration uses 'log' for the log message
while containerd uses 'msg'. Since we can't have a single
JSON format for both, add another log format and make
debug log configurable.
PiperOrigin-RevId: 219729658
Change-Id: I2a6afc4034d893ab90bafc63b394c4fb62b2a7a0 |
259,992 | 01.11.2018 17:51:22 | 25,200 | 5cd55cd90fd5a32685807a57617cde6f5f76d22b | Use spec with clean paths for gofer
Otherwise the gofer's attach point may be different from sandbox when there
symlinks in the path. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader_test.go",
"new_path": "runsc/boot/loader_test.go",
"diff": "@@ -77,8 +77,11 @@ func startGofer(root string) (int, func(), error) {\nsyscall.Close(goferEnd)\nreturn 0, nil, fmt.Errorf(\"error creating server on FD %d: %v\", goferEnd, err)\n}\n... | Go | Apache License 2.0 | google/gvisor | Use spec with clean paths for gofer
Otherwise the gofer's attach point may be different from sandbox when there
symlinks in the path.
PiperOrigin-RevId: 219730492
Change-Id: Ia9c4c2d16228c6a1a9e790e0cb673fd881003fe1 |
259,891 | 01.11.2018 18:28:12 | 25,200 | 704b56a40d0a041a4e6f814c3dbb1f9ec15f9002 | First crictl integration tests.
More tests will come, but it's worth getting what's done so far reviewed. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -80,7 +80,7 @@ installCrictl() (\nchmod +x ${shim_path}\nsudo -n -E mv ${shim_path} /usr/local/bin\n- # Configure containerd.\n+ # Configure containerd-shim.\nlocal shim_config_path=/etc/cont... | Go | Apache License 2.0 | google/gvisor | First crictl integration tests.
More tests will come, but it's worth getting what's done so far reviewed.
PiperOrigin-RevId: 219734531
Change-Id: If15ca6e6855e3d1cc28c83b5f9c3a72cb65b2e59 |
259,854 | 05.11.2018 17:22:41 | 28,800 | 95722dc4dd00b5efc182a05605e6e460383e618e | Use correct company name in copyright header
These files were added with the wrong name after all of the existing files
were corrected. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/buffer_test.go",
"new_path": "pkg/p9/buffer_test.go",
"diff": "-// Copyright 2018 Google Inc.\n+// Copyright 2018 Google LLC\n//\n// Licensed under the Apache License, Version 2.0 (the \"License\");\n// you may not use this file except in compliance wit... | Go | Apache License 2.0 | google/gvisor | Use correct company name in copyright header
These files were added with the wrong name after all of the existing files
were corrected.
PiperOrigin-RevId: 220202068
Change-Id: Ia0d15233c1aa69330356a7cf16b5aa00d978e09c |
259,992 | 05.11.2018 17:41:22 | 28,800 | a467f092616122f1f718df2a375ba66e97997594 | Log when external signal is received | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -445,6 +445,18 @@ const (\nDeliverToForegroundProcessGroup\n)\n+func (s SignalDeliveryMode) String() string {\n+ switch s {\n+ case DeliverToProcess:\n+ return \"Process\"\n+ case D... | Go | Apache License 2.0 | google/gvisor | Log when external signal is received
PiperOrigin-RevId: 220204591
Change-Id: I21a9c6f5c12a376d18da5d10c1871837c4f49ad2 |
259,881 | 06.11.2018 13:11:56 | 28,800 | 6ae1c90b891fdefa47c9be943369a7e7bbd75907 | Move bazelrc to new location
Bazel 0.18 moved the workspace bazelrc location from //tools/bazel.rc to
//.bazelrc. The old location will be dropped by a future version of
bazel.
This bumps the minimum required version of bazel to 0.18.
More context:
https://groups.google.com/forum/#!msg/bazel-discuss/ycDacctX2vw/EGFxGLibAgAJ | [
{
"change_type": "RENAME",
"old_path": "tools/bazel.rc",
"new_path": ".bazelrc",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -255,7 +255,7 @@ gVisor currently requires x86\\_64 Linux to build.\nMake sure the following dep... | Go | Apache License 2.0 | google/gvisor | Move bazelrc to new location
Bazel 0.18 moved the workspace bazelrc location from //tools/bazel.rc to
//.bazelrc. The old location will be dropped by a future version of
bazel.
This bumps the minimum required version of bazel to 0.18.
More context:
https://groups.google.com/forum/#!msg/bazel-discuss/ycDacctX2vw/EGFxGLibAgAJ
PiperOrigin-RevId: 220338084
Change-Id: Ib6fa83a4a0f89e8e898d67152c7bd429e0b9b21e |
259,891 | 06.11.2018 16:17:16 | 28,800 | a81111d5448346098af375de82aec44459239689 | Fix problem where crictl tests would signal both error and done channels | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/testutil/crictl.go",
"new_path": "runsc/test/testutil/crictl.go",
"diff": "@@ -212,6 +212,7 @@ func (cc *Crictl) run(args ...string) (string, error) {\noutput, err := cmd.CombinedOutput()\nif err != nil {\nerrCh <- fmt.Errorf(\"error: \\\"%v\\\", ou... | Go | Apache License 2.0 | google/gvisor | Fix problem where crictl tests would signal both error and done channels
PiperOrigin-RevId: 220372291
Change-Id: I054ba56a23c402c7244b476d7d6fe72084942a0e |
259,992 | 07.11.2018 12:00:51 | 28,800 | dce61075c03907a70362878d362b2b95ff06addf | Fix flaky TestCacheResolutionTimeout
Increase timeout to prevent the entry from being
found when there is delay on the address resolution
goroutine that doesn't mark the request as failed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/linkaddrcache_test.go",
"new_path": "pkg/tcpip/stack/linkaddrcache_test.go",
"diff": "@@ -237,8 +237,8 @@ func TestCacheResolutionFailed(t *testing.T) {\n}\nfunc TestCacheResolutionTimeout(t *testing.T) {\n- resolverDelay := 50 * time.Milliseco... | Go | Apache License 2.0 | google/gvisor | Fix flaky TestCacheResolutionTimeout
Increase timeout to prevent the entry from being
found when there is delay on the address resolution
goroutine that doesn't mark the request as failed.
PiperOrigin-RevId: 220504789
Change-Id: I7e44fd95d8624bd69962f862fbf5517a81395f2a |
259,992 | 07.11.2018 13:32:26 | 28,800 | c92b9b7086b89fd8e7f5913bf74d04761163e24b | Add more logging to controller.go | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -169,7 +169,7 @@ type containerManager struct {\n// StartRoot will start the root container process.\nfunc (cm *containerManager) StartRoot(cid *string, _ *struct{}) error {\n- log.... | Go | Apache License 2.0 | google/gvisor | Add more logging to controller.go
PiperOrigin-RevId: 220519632
Change-Id: Iaeec007fc1aa3f0b72569b288826d45f2534c4bf |
259,992 | 07.11.2018 21:30:11 | 28,800 | d12a0dd6b8afaca9fbb5fe60fb84a3ae0502261a | Fix test --race violation
SetupContainerInRoot was setting Config.RootDir unnecessarily
and causing a --race violation in TestMultiContainerDestroyStarting. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -1287,24 +1287,25 @@ func TestReadonlyMount(t *testing.T) {\n// TestAbbreviatedIDs checks that runsc supports using abbreviated container\n// IDs in place of full ... | Go | Apache License 2.0 | google/gvisor | Fix test --race violation
SetupContainerInRoot was setting Config.RootDir unnecessarily
and causing a --race violation in TestMultiContainerDestroyStarting.
PiperOrigin-RevId: 220580073
Change-Id: Ie0b28c19846106c7458a92681b708ae70f87d25a |
259,992 | 07.11.2018 23:28:37 | 28,800 | 90e81b2e5c665b9fc149f97dcf15142c190260c6 | Add test that volume can be mounted on top of a symlink | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/root/crictl_test.go",
"new_path": "runsc/test/root/crictl_test.go",
"diff": "@@ -25,6 +25,7 @@ import (\n\"os/exec\"\n\"path\"\n\"path/filepath\"\n+ \"strings\"\n\"testing\"\n\"time\"\n@@ -79,6 +80,43 @@ func TestMountPaths(t *testing.T) {\nt.Fatal(... | Go | Apache License 2.0 | google/gvisor | Add test that volume can be mounted on top of a symlink
PiperOrigin-RevId: 220588094
Change-Id: I18915e892ceac86eac1f89ebcadffb4fdf8d0cf6 |
259,985 | 08.11.2018 11:08:41 | 28,800 | 5a0be6fa203273d1e4ab06a206eaffeca5724533 | Create stubs for syscalls upto Linux 4.4.
Create syscall stubs for missing syscalls upto Linux 4.4 and advertise
a kernel version of 4.4. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode.go",
"new_path": "pkg/sentry/fs/inode.go",
"diff": "@@ -439,10 +439,7 @@ func (i *Inode) CheckOwnership(ctx context.Context) bool {\n// CheckCapability checks whether `ctx` has capability `cp` with respect to\n// operations on this Inode.\n... | Go | Apache License 2.0 | google/gvisor | Create stubs for syscalls upto Linux 4.4.
Create syscall stubs for missing syscalls upto Linux 4.4 and advertise
a kernel version of 4.4.
PiperOrigin-RevId: 220667680
Change-Id: Idbdccde538faabf16debc22f492dd053a8af0ba7 |
259,992 | 09.11.2018 10:57:45 | 28,800 | 93e88760b0d0c9c6656f7773f68540b1853d169b | Add tests multicontainer start/stop
Each container has its respective gofer. Test that
gofer can be shutdown when a container stops and that
it doesn't affect other containers. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/multi_container_test.go",
"new_path": "runsc/container/multi_container_test.go",
"diff": "@@ -732,3 +732,94 @@ func TestMultiContainerDestroyStarting(t *testing.T) {\n}\nwg.Wait()\n}\n+\n+// TestMultiContainerGoferStop tests that IO operations ... | Go | Apache License 2.0 | google/gvisor | Add tests multicontainer start/stop
Each container has its respective gofer. Test that
gofer can be shutdown when a container stops and that
it doesn't affect other containers.
PiperOrigin-RevId: 220829898
Change-Id: I2a44a3cf2a88577e6ad1133afc622bbf4a5f6591 |
259,962 | 09.11.2018 14:37:42 | 28,800 | 33089561b1d53dada959a312ab69574cd6635b4b | Add an implementation of a SACK scoreboard as per RFC6675. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -131,3 +131,9 @@ http_archive(\n\"https://github.com/google/glog/archive/028d37889a1e80e8a07da1b8945ac706259e5fd8.tar.gz\",\n],\n)\n+\n+go_repository(\n+ name = \"com_github_google_btree\",\n+ importpath = \"git... | Go | Apache License 2.0 | google/gvisor | Add an implementation of a SACK scoreboard as per RFC6675.
PiperOrigin-RevId: 220866996
Change-Id: I89d48215df57c00d6a6ec512fc18712a2ea9080b |
259,992 | 09.11.2018 14:53:24 | 28,800 | d97ccfa346d23d99dcbe634a10fa5d81b089100d | Close donated files if containerManager.Start() fails | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -213,6 +213,12 @@ type StartArgs struct {\nfunc (cm *containerManager) Start(args *StartArgs, _ *struct{}) error {\nlog.Debugf(\"containerManager.Start: %+v\", args)\n+ defer func()... | Go | Apache License 2.0 | google/gvisor | Close donated files if containerManager.Start() fails
PiperOrigin-RevId: 220869535
Change-Id: I9917e5daf02499f7aab6e2aa4051c54ff4461b9a |
259,854 | 13.11.2018 18:01:26 | 28,800 | 7f60294a7367ee62cc5e0bd21648a68184c4ca5e | Implement TCP_NODELAY and TCP_CORK
Previously, TCP_NODELAY was always enabled and we would lie about it being
configurable. TCP_NODELAY is now disabled by default (to match Linux) in the
socket layer so that non-gVisor users don't automatically start using this
questionable optimization. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -157,7 +157,13 @@ type SocketOperations struct {\n}\n// New creates a new endpoint socket.\n-func New(t *kernel.Task, family int, skType transport.SockTy... | Go | Apache License 2.0 | google/gvisor | Implement TCP_NODELAY and TCP_CORK
Previously, TCP_NODELAY was always enabled and we would lie about it being
configurable. TCP_NODELAY is now disabled by default (to match Linux) in the
socket layer so that non-gVisor users don't automatically start using this
questionable optimization.
PiperOrigin-RevId: 221368472
Change-Id: Ib0240f66d94455081f4e0ca94f09d9338b2c1356 |
259,854 | 14.11.2018 11:57:58 | 28,800 | b5e91eaa52cfb9b43dff0f857938ca231068924d | Clean up tcp.sendData | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/buffer/view.go",
"new_path": "pkg/tcpip/buffer/view.go",
"diff": "@@ -146,7 +146,7 @@ func (vv VectorisedView) Views() []View {\n}\n// Append appends the views in a vectorised view to this vectorised view.\n-func (vv *VectorisedView) Append(vv2 *Vect... | Go | Apache License 2.0 | google/gvisor | Clean up tcp.sendData
PiperOrigin-RevId: 221484739
Change-Id: I44c71f79f99d0d00a2e70a7f06d7024a62a5de0a |
259,854 | 15.11.2018 13:16:05 | 28,800 | 9d8e49d9505e0b2659be01ec49cdad1948134188 | Process delayed packets when delay is disabled
Moving the wakeup logic into the disable blocks is an optimization. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -654,20 +654,24 @@ func (e *endpoint) SetSockOpt(opt interface{}) *tcpip.Error {\ncase tcpip.DelayOption:\nif v == 0 {\natomic.StoreUint32(&e.delay, 0)\n+\n+ /... | Go | Apache License 2.0 | google/gvisor | Process delayed packets when delay is disabled
Moving the wakeup logic into the disable blocks is an optimization.
PiperOrigin-RevId: 221677028
Change-Id: Ib5a5a6d52cc77b4bbc5dedcad9ee1dbb3da98deb |
259,985 | 15.11.2018 15:13:52 | 28,800 | f7aa9371247a3e7d8c490ac0fd4c4f3ff6de2017 | Advertise vsyscall support via /proc/<pid>/maps.
Also update test utilities for probing vsyscall support and add a
metric to see if vsyscalls are actually used in sandboxes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -131,6 +131,7 @@ go_library(\n\"//pkg/cpuid\",\n\"//pkg/eventchannel\",\n\"//pkg/log\",\n+ \"//pkg/metric\",\n\"//pkg/refs\",\n\"//pkg/secio\",\n\"//pkg/sentry/arch\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Advertise vsyscall support via /proc/<pid>/maps.
Also update test utilities for probing vsyscall support and add a
metric to see if vsyscalls are actually used in sandboxes.
PiperOrigin-RevId: 221698834
Change-Id: I57870ecc33ea8c864bd7437833f21aa1e8117477 |
259,858 | 16.11.2018 12:16:37 | 28,800 | bb9a2bb62ed37f9b29c7ab4418b8b90417d1b2a2 | Update futex to use usermem abstractions.
This eliminates the indirection that existed in task_futex. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/futex/BUILD",
"new_path": "pkg/sentry/kernel/futex/BUILD",
"diff": "@@ -36,7 +36,9 @@ go_library(\nimportpath = \"gvisor.googlesource.com/gvisor/pkg/sentry/kernel/futex\",\nvisibility = [\"//pkg/sentry:internal\"],\ndeps = [\n+ \"//pkg/abi/li... | Go | Apache License 2.0 | google/gvisor | Update futex to use usermem abstractions.
This eliminates the indirection that existed in task_futex.
PiperOrigin-RevId: 221832498
Change-Id: Ifb4c926d493913aa6694e193deae91616a29f042 |
259,992 | 16.11.2018 18:07:52 | 28,800 | 237f9c7a5e7078b46303f1262b77372a2f6a7f7b | Don't fail when destroyContainerFS is called more than once
This can happen when destroy is called multiple times or when destroy
failed previously and is being called again. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -673,10 +673,11 @@ func destroyContainerFS(ctx context.Context, cid string, k *kernel.Kernel) error\ndefer root.DecRef()\n// Do a best-effort unmount by flushing the refs and unmount\n- // with \"d... | Go | Apache License 2.0 | google/gvisor | Don't fail when destroyContainerFS is called more than once
This can happen when destroy is called multiple times or when destroy
failed previously and is being called again.
PiperOrigin-RevId: 221882034
Change-Id: I8d069af19cf66c4e2419bdf0d4b789c5def8d19e |
259,992 | 19.11.2018 15:25:00 | 28,800 | fadffa2ff831034ff63146abf408ff71462b9f43 | Add unsupported syscall events for get/setsockopt | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -43,6 +43,7 @@ go_library(\n\"shm.go\",\n\"signal.go\",\n\"socket.go\",\n+ \"tcp.go\",\n\"time.go\",\n\"timer.go\",\n\"tty.go\",\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/... | Go | Apache License 2.0 | google/gvisor | Add unsupported syscall events for get/setsockopt
PiperOrigin-RevId: 222148953
Change-Id: I21500a9f08939c45314a6414e0824490a973e5aa |
259,881 | 19.11.2018 18:02:50 | 28,800 | 03c1eb78b583ca3247f299889146675311727325 | Reference upstream licenses
Include copyright notices and the referenced LICENSE file. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/safecopy/BUILD",
"new_path": "pkg/sentry/platform/safecopy/BUILD",
"diff": "load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\n-package(licenses = [\"notice\"]) # Apache 2.0\n+package(licenses = [\"notice\"]) # Apache 2.0,... | Go | Apache License 2.0 | google/gvisor | Reference upstream licenses
Include copyright notices and the referenced LICENSE file.
PiperOrigin-RevId: 222171321
Change-Id: I0cc0b167ca51b536d1087bf1c4742fdf1430bc2a |
259,992 | 20.11.2018 15:07:12 | 28,800 | 8b314b0bf402da58f90ccaac852a880d375f0885 | Fix recursive read lock taken on TaskSet
SyncSyscallFiltersToThreadGroup and Task.TheadID() both acquired TaskSet RWLock
in R mode and could deadlock if a writer comes in between. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/seccomp.go",
"new_path": "pkg/sentry/kernel/seccomp.go",
"diff": "@@ -179,20 +179,19 @@ func (t *Task) evaluateSyscallFilters(sysno int32, args arch.SyscallArguments, i\n// AppendSyscallFilter adds BPF program p as a system call filter.\n//\n... | Go | Apache License 2.0 | google/gvisor | Fix recursive read lock taken on TaskSet
SyncSyscallFiltersToThreadGroup and Task.TheadID() both acquired TaskSet RWLock
in R mode and could deadlock if a writer comes in between.
PiperOrigin-RevId: 222313551
Change-Id: I4221057d8d46fec544cbfa55765c9a284fe7ebfa |
259,992 | 20.11.2018 17:23:14 | 28,800 | 5236b78242677612ac71b19cee85b3bf4cca4008 | Dumps stacks if watchdog thread is stuck | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -190,7 +190,24 @@ func (w *Watchdog) loop() {\n// runTurn runs a single pass over all tasks and reports anything it finds.\nfunc (w *Watchdog) runTurn() {\n- tasks := ... | Go | Apache License 2.0 | google/gvisor | Dumps stacks if watchdog thread is stuck
PiperOrigin-RevId: 222332703
Change-Id: Id5c3cf79591c5d2949895b4e323e63c48c679820 |
259,854 | 21.11.2018 18:09:22 | 28,800 | 1918563525662d6645ec921e61aa7e6da92af0dd | Make ToView non-allocating for single VectorizedViews containing a single View | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/buffer/view.go",
"new_path": "pkg/tcpip/buffer/view.go",
"diff": "@@ -132,7 +132,13 @@ func (vv VectorisedView) Size() int {\n}\n// ToView returns a single view containing the content of the vectorised view.\n+//\n+// If the vectorised view contains ... | Go | Apache License 2.0 | google/gvisor | Make ToView non-allocating for single VectorizedViews containing a single View
PiperOrigin-RevId: 222483471
Change-Id: I6720690b20167dd541fdfa5218eba7c9f7483347 |
259,975 | 26.11.2018 09:49:53 | 28,800 | b3b60ea29adf9415c9c7b98ba331dacd92f231b7 | Implementation of preadv2 for Linux 4.4 support
Implement RWF_HIPRI (4.6) silently passes the read call.
Implement -1 offset calls readv. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -150,6 +150,13 @@ const (\nPermissionsMask = 0777\n)\n+// Values for preadv2/pwritev2.\n+const (\n+ RWF_HIPRI = 0x0001\n+ RWF_DSYNC = 0X0002\n+ RWF_SYNC = 0x0004\n+)\n+\n// Stat represent... | Go | Apache License 2.0 | google/gvisor | Implementation of preadv2 for Linux 4.4 support
Implement RWF_HIPRI (4.6) silently passes the read call.
Implement -1 offset calls readv.
PiperOrigin-RevId: 222840324
Change-Id: If9ddc1e8d086e1a632bdf5e00bae08205f95b6b0 |
259,881 | 27.11.2018 09:24:17 | 28,800 | 071aeea9d3ff783b2946ef291b1c440aa9b21b88 | Disable crictl tests
gvisor-containerd-shim installation is currently broken. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -100,10 +100,11 @@ EOF\n)\n# Install containerd and crictl.\n-if [[ ${exit_code} -eq 0 ]]; then\n- installCrictl\n- exit_code=${?}\n-fi\n+# FIXME: gvisor-containerd-shim installation broken.\... | Go | Apache License 2.0 | google/gvisor | Disable crictl tests
gvisor-containerd-shim installation is currently broken.
PiperOrigin-RevId: 223002877
Change-Id: I2b890c5bf602a96c475c3805f24852ead8593a35 |
259,974 | 27.11.2018 12:45:04 | 28,800 | 9e0f13237793897c805f75af163006049b37e784 | Add procid support for arm64 platform | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/procid/BUILD",
"new_path": "pkg/sentry/platform/procid/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nsrcs = [\n\"procid.go\",\n\"procid_amd64.s\",\n+ \"procid_arm64.s\",\n],\nimportpath = \"gvisor.googlesource.com/gvisor/pkg/sentry/platform... | Go | Apache License 2.0 | google/gvisor | Add procid support for arm64 platform
Change-Id: I7c3db8dfdf95a125d7384c1d67c3300dbb99a47e
PiperOrigin-RevId: 223039923 |
260,013 | 27.11.2018 17:47:16 | 28,800 | 5bd02b224fd0eb81fc028644137a24d0bbf7dab5 | Save shutdown flags first.
With rpcinet if shutdown flags are not saved before making
the rpc a race is possible where blocked threads are woken
up before the flags have been persisted. This would mean
that threads can block indefinitely in a recvmsg after a
shutdown(SHUT_RD) has happened. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -354,6 +354,13 @@ func (s *socketOperations) Listen(t *kernel.Task, backlog int) *syserr.Error {\n// Shutdown implements socket.Socket.Shutdown.\nfunc (s *sock... | Go | Apache License 2.0 | google/gvisor | Save shutdown flags first.
With rpcinet if shutdown flags are not saved before making
the rpc a race is possible where blocked threads are woken
up before the flags have been persisted. This would mean
that threads can block indefinitely in a recvmsg after a
shutdown(SHUT_RD) has happened.
PiperOrigin-RevId: 223089783
Change-Id: If595e7add12aece54bcdf668ab64c570910d061a |
259,891 | 28.11.2018 10:09:22 | 28,800 | 7b86d36a63e9b281834fdb6c2db0840df992c57c | Fix crictl tests.
gvisor-containerd-shim moved. It now has a stable URL that run_tests.sh always
uses. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -75,8 +75,10 @@ installCrictl() (\nsudo -n -E make install\n# Install gvisor-containerd-shim.\n+ local latest=/tmp/gvisor-containerd-shim-latest\nlocal shim_path=/tmp/gvisor-containerd-shim\n... | Go | Apache License 2.0 | google/gvisor | Fix crictl tests.
gvisor-containerd-shim moved. It now has a stable URL that run_tests.sh always
uses.
PiperOrigin-RevId: 223188822
Change-Id: I5687c78289404da27becd8d5949371e580fdb360 |
259,884 | 29.11.2018 04:48:15 | 28,800 | db0473b1bec1481e5a7807752b5eaa72c816c562 | Add a new docs directory. refs
Add a new 'docs' directory for that can be built on in the future. Docs are
divided into a 'user guide', 'contributor guide', and 'architecture guide'.
This is currently a work in progress. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "docs/README.md",
"diff": "+# gVisor Documentation\n+\n+**This doc is a work in progress. For the definitive documentation please see\n+the [README](../README.md)**\n+\n+gVisor is a user-space kernel, written in Go, that implements a substantial\... | Go | Apache License 2.0 | google/gvisor | Add a new docs directory. refs #109
Add a new 'docs' directory for that can be built on in the future. Docs are
divided into a 'user guide', 'contributor guide', and 'architecture guide'.
This is currently a work in progress.
PiperOrigin-RevId: 223326836
Change-Id: I78d08d6a89d686e92d3415d4269463e8e74bddee |
259,854 | 29.11.2018 15:45:02 | 28,800 | 99fb1138696c520f8db7064320e14ec63c2458b6 | Test that full segments will be sent when delay/cork is enabled | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"diff": "@@ -1449,6 +1449,71 @@ func TestUndelay(t *testing.T) {\n})\n}\n+func TestMSSNotDelayed(t *testing.T) {\n+ tests := []struct {\n+ name string\n+ fn func(tcpip.End... | Go | Apache License 2.0 | google/gvisor | Test that full segments will be sent when delay/cork is enabled
PiperOrigin-RevId: 223425575
Change-Id: Idd777e04c69e6ffcbfb0bdbea828a8b8b42d7672 |
259,854 | 03.12.2018 17:02:28 | 28,800 | 5560615c531bc2a0108a4db1e9877f0397a69f8f | Return an int32 for netlink SO_RCVBUF
Untyped integer constants default to type int and the binary package will panic
if one tries to encode an int. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netlink/socket.go",
"new_path": "pkg/sentry/socket/netlink/socket.go",
"diff": "@@ -298,7 +298,7 @@ func (s *Socket) GetSockOpt(t *kernel.Task, level int, name int, outLen int) (in\nreturn nil, syserr.ErrInvalidArgument\n}\n// We don't have l... | Go | Apache License 2.0 | google/gvisor | Return an int32 for netlink SO_RCVBUF
Untyped integer constants default to type int and the binary package will panic
if one tries to encode an int.
PiperOrigin-RevId: 223890001
Change-Id: Iccc3afd6d74bad24c35d764508e450fd317b76ec |
259,948 | 04.12.2018 13:13:13 | 28,800 | ad8f293e1af99f3c04d1020bb51b46c0dba60e45 | sentry: save copy of tcp segment's delivered views to avoid in-struct pointers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/encode.go",
"new_path": "pkg/state/encode.go",
"diff": "@@ -119,9 +119,10 @@ func (es *encodeState) register(obj reflect.Value) uint64 {\nif size := typ.Size(); size > 0 {\nr := addrRange{addr, addr + size}\nif !es.values.IsEmptyRange(r) {\n- panic(f... | Go | Apache License 2.0 | google/gvisor | sentry: save copy of tcp segment's delivered views to avoid in-struct pointers.
PiperOrigin-RevId: 224033238
Change-Id: Ie5b1854b29340843b02c123766d290a8738d7631 |
259,854 | 04.12.2018 13:14:22 | 28,800 | 8cbd6153a69ae370a3c5d3795952a1de00f7436b | Fix available calculation when merging TCP segments | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -411,7 +411,7 @@ func (s *sender) sendData() {\nif seg.flags == 0 {\n// Merge segments if allowed.\nif seg.data.Size() != 0 {\n- available := int(seg.sequenceNumber.Size... | Go | Apache License 2.0 | google/gvisor | Fix available calculation when merging TCP segments
PiperOrigin-RevId: 224033418
Change-Id: I780be973e8be68ac93e8c9e7a100002e912f40d2 |
260,013 | 04.12.2018 14:27:46 | 28,800 | 5a6a1eb420620c3d41a9db4ddf7ac7b163310f09 | Enforce name length restriction on paths.
NAME_LENGTH must be enforced per component. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -458,6 +458,12 @@ func (d *Dirent) walk(ctx context.Context, root *Dirent, name string, walkMayUnl\nif !IsDir(d.Inode.StableAttr) {\nreturn nil, syscall.ENOTDIR\n}\n+\n+ // The compon... | Go | Apache License 2.0 | google/gvisor | Enforce name length restriction on paths.
NAME_LENGTH must be enforced per component.
PiperOrigin-RevId: 224046749
Change-Id: Iba8105b00d951f2509dc768af58e4110dafbe1c9 |
259,948 | 04.12.2018 14:29:56 | 28,800 | adafc08d7cee594ea94abefbedf67ea315922550 | sentry: save / restore netstack procfs configuration. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/BUILD",
"new_path": "pkg/sentry/fs/proc/BUILD",
"diff": "@@ -20,6 +20,7 @@ go_library(\n\"stat.go\",\n\"sys.go\",\n\"sys_net.go\",\n+ \"sys_net_state.go\",\n\"task.go\",\n\"uid_gid_map.go\",\n\"uptime.go\",\n"
},
{
"change_type": "MO... | Go | Apache License 2.0 | google/gvisor | sentry: save / restore netstack procfs configuration.
PiperOrigin-RevId: 224047120
Change-Id: Ia6cb17fa978595cd73857b6178c4bdba401e185e |
260,013 | 04.12.2018 14:33:34 | 28,800 | 2cab0e82ad8c1e38392b8c35aaa65d1121a9e2b2 | Linkat(2) should sanity check flags. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_file.go",
"new_path": "pkg/sentry/syscalls/linux/sys_file.go",
"diff": "@@ -1251,6 +1251,12 @@ func Linkat(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscal\n// AT_SYMLINK_FOLLOW can be specified in flags to cau... | Go | Apache License 2.0 | google/gvisor | Linkat(2) should sanity check flags.
PiperOrigin-RevId: 224047765
Change-Id: I6f3c75b33c32bf8f8910ea3fab35406d7d672d87 |
260,013 | 04.12.2018 18:14:17 | 28,800 | ffcbda0c8bd772c9019977775daf1d86891c3f28 | Partial writes should loop in rpcinet.
FileOperations.Write should return ErrWouldBlock to allow the upper
layer to loop and sendmsg should continue writing where it left off
on a partial write. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -212,6 +212,11 @@ func (s *socketOperations) Write(ctx context.Context, _ *fs.File, src usermem.IO\n}\nn, err := rpcWrite(t, &pb.SyscallRequest_Write{&pb.Write... | Go | Apache License 2.0 | google/gvisor | Partial writes should loop in rpcinet.
FileOperations.Write should return ErrWouldBlock to allow the upper
layer to loop and sendmsg should continue writing where it left off
on a partial write.
PiperOrigin-RevId: 224081631
Change-Id: Ic61f6943ea6b7abbd82e4279decea215347eac48 |
259,881 | 04.12.2018 18:52:56 | 28,800 | 076f107643fafab30a0d45dd5af49b8bd4b574b9 | Remove initRegs arg from clone
It is always the same as t.initRegs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/ptrace_unsafe.go",
"new_path": "pkg/sentry/platform/ptrace/ptrace_unsafe.go",
"diff": "@@ -130,8 +130,8 @@ func (t *thread) getSignalInfo(si *arch.SignalInfo) error {\n// call attach on it.\n//\n// Precondition: the OS thread must be... | Go | Apache License 2.0 | google/gvisor | Remove initRegs arg from clone
It is always the same as t.initRegs.
PiperOrigin-RevId: 224085550
Change-Id: I5cc4ddc3b481d4748c3c43f6f4bb50da1dbac694 |
260,006 | 04.12.2018 19:08:13 | 28,800 | fab029c50b445e06ba770c9ccd7d6d0a06e15057 | Remove incorrect code and improve testing of Stack.GetMainNICAddress
This removes code that should have never made it in in the first place, but did so due to incomplete testing. With the new tests the original code fails, the new code passes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -119,16 +119,6 @@ func (n *NIC) getMainNICAddress(protocol tcpip.NetworkProtocolNumber) (tcpip.Add\n}\n- // If no primary endpoints then check for other endpoints.\n- if r == nil {\n- f... | Go | Apache License 2.0 | google/gvisor | Remove incorrect code and improve testing of Stack.GetMainNICAddress
This removes code that should have never made it in in the first place, but did so due to incomplete testing. With the new tests the original code fails, the new code passes.
PiperOrigin-RevId: 224086966
Change-Id: I646fef76977f4528f3705f497b95fad6b3ec32bc |
259,975 | 05.12.2018 10:52:44 | 28,800 | 06131fe749e3715534f9d551528d89048ae1398b | Check for CAP_SYS_RESOURCE in prctl(PR_SET_MM, ...)
If sys_prctl is called with PR_SET_MM without CAP_SYS_RESOURCE,
the syscall should return failure with errno set to EPERM.
See: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_prctl.go",
"new_path": "pkg/sentry/syscalls/linux/sys_prctl.go",
"diff": "@@ -87,6 +87,10 @@ func Prctl(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall\n}\ncase linux.PR_SET_MM:\n+ if !t.HasCapability(linux.C... | Go | Apache License 2.0 | google/gvisor | Check for CAP_SYS_RESOURCE in prctl(PR_SET_MM, ...)
If sys_prctl is called with PR_SET_MM without CAP_SYS_RESOURCE,
the syscall should return failure with errno set to EPERM.
See: http://man7.org/linux/man-pages/man2/prctl.2.html
PiperOrigin-RevId: 224182874
Change-Id: I630d1dd44af8b444dd16e8e58a0764a0cf1ad9a3 |
259,881 | 05.12.2018 12:45:35 | 28,800 | 592f5bdc675ae2933919b649b45551c6781c7876 | Add context to mount errors
This makes it more obvious why a mount failed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/overlay.go",
"new_path": "pkg/sentry/fs/overlay.go",
"diff": "@@ -95,10 +95,10 @@ func isXattrOverlay(name string) bool {\n// - lower must not have dynamic file/directory content.\nfunc NewOverlayRoot(ctx context.Context, upper *Inode, lower *Ino... | Go | Apache License 2.0 | google/gvisor | Add context to mount errors
This makes it more obvious why a mount failed.
PiperOrigin-RevId: 224203880
Change-Id: I7961774a7b6fdbb5493a791f8b3815c49b8f7631 |
259,948 | 05.12.2018 13:50:14 | 28,800 | fda4557e3dc19c72f857b107a52359723cd37216 | sentry: skip waiting for undrain for netstack TCP endpoints in error state. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -976,25 +976,35 @@ func (e *endpoint) protocolMainLoop(handshake bool) *tcpip.Error {\ne.mu.Unlock()\n}\nif n¬ifyClose != 0 && closeTimer == nil {\n- // Reset... | Go | Apache License 2.0 | google/gvisor | sentry: skip waiting for undrain for netstack TCP endpoints in error state.
PiperOrigin-RevId: 224214981
Change-Id: I4c1dd5b1c856f7a4f9866a5dda44a5297e92486a |
259,885 | 05.12.2018 14:26:24 | 28,800 | 23438b36327524ba3e71b6416d71863fb4dfa166 | Update MM.usageAS when mremap copies or moves a mapping. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/syscalls.go",
"new_path": "pkg/sentry/mm/syscalls.go",
"diff": "@@ -463,6 +463,7 @@ func (mm *MemoryManager) MRemap(ctx context.Context, oldAddr usermem.Addr, oldSi\nvma.id.IncRef()\n}\nmm.vmas.Add(newAR, vma)\n+ mm.usageAS += uint64(newAR.Length... | Go | Apache License 2.0 | google/gvisor | Update MM.usageAS when mremap copies or moves a mapping.
PiperOrigin-RevId: 224221509
Change-Id: I7aaea74629227d682786d3e435737364921249bf |
259,881 | 05.12.2018 14:31:07 | 28,800 | 9f64e64a6ee1fe44a05ed57893785fa9064125e1 | Enforce directory accessibility before delete Walk
By Walking before checking that the directory is writable and
executable, MayDelete may return the Walk error (e.g., ENOENT) which
would normally be masked by a permission error (EACCES). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -1461,6 +1461,10 @@ func checkSticky(ctx context.Context, dir *Dirent, victim *Dirent) error {\n//\n// Compare Linux kernel fs/namei.c:may_delete.\nfunc MayDelete(ctx context.Context,... | Go | Apache License 2.0 | google/gvisor | Enforce directory accessibility before delete Walk
By Walking before checking that the directory is writable and
executable, MayDelete may return the Walk error (e.g., ENOENT) which
would normally be masked by a permission error (EACCES).
PiperOrigin-RevId: 224222453
Change-Id: I108a7f730e6bdaa7f277eaddb776267c00805475 |
259,948 | 05.12.2018 15:01:41 | 28,800 | 7f35daddd2cabef2e7ffb6899e1a54ff8c0475c6 | sentry: support save / restore of TCP bind socket after shutdown. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint_state.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint_state.go",
"diff": "@@ -92,8 +92,8 @@ func (e *endpoint) beforeSave() {\npanic(\"endpoint still has waiters upon save\")\n}\n- if !((e.state == stateBound || e.state == s... | Go | Apache License 2.0 | google/gvisor | sentry: support save / restore of TCP bind socket after shutdown.
PiperOrigin-RevId: 224227677
Change-Id: I08b0e0c0574170556269900653e5bcf9e9e5c9c9 |
259,975 | 06.12.2018 09:25:57 | 28,800 | 4d8c7ae869a4e9bf60c7ea9aff79a0bee551fbc9 | Fixing O_TRUNC behavior to match Linux. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/flags.go",
"new_path": "pkg/sentry/syscalls/linux/flags.go",
"diff": "@@ -22,6 +22,9 @@ import (\n// flagsToPermissions returns a Permissions object from Linux flags.\n// This includes truncate permission if O_TRUNC is set in the mask... | Go | Apache License 2.0 | google/gvisor | Fixing O_TRUNC behavior to match Linux.
PiperOrigin-RevId: 224351139
Change-Id: I9453bd75e5a8d38db406bb47fdc01038ac60922e |
259,985 | 06.12.2018 11:14:57 | 28,800 | 685eaf119ffa6c44c4dcaec0e083bbdc0271231a | Add counters for memory events.
Also ensure an event is emitted at startup. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/memevent/BUILD",
"new_path": "pkg/sentry/kernel/memevent/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_library(\n\":memory_events_go_proto\",\n\"//pkg/eventchannel\",\n\"//pkg/log\",\n+ \"//pkg/metric\",\n\"//pkg/sentry/kernel\",\n\"//pkg/sentry/usag... | Go | Apache License 2.0 | google/gvisor | Add counters for memory events.
Also ensure an event is emitted at startup.
PiperOrigin-RevId: 224372065
Change-Id: I5f642b6d6b13c6468ee8f794effe285fcbbf29cf |
259,881 | 06.12.2018 11:42:23 | 28,800 | 666db00c262c7d6d6359fbaba28e344d015a7823 | Convert ValueSet to a map
Unlike FlagSet, order doesn't matter here, so it can simply be a map. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/flag.go",
"new_path": "pkg/abi/flag.go",
"diff": "@@ -46,30 +46,25 @@ func (s FlagSet) Parse(val uint64) string {\nreturn strings.Join(flags, \"|\")\n}\n-// ValueSet is a slice of syscall values and their name. Parse will replace\n-// values that exact... | Go | Apache License 2.0 | google/gvisor | Convert ValueSet to a map
Unlike FlagSet, order doesn't matter here, so it can simply be a map.
PiperOrigin-RevId: 224377910
Change-Id: I15810c698a7f02d8614bf09b59583ab73cba0514 |
259,853 | 06.12.2018 15:26:58 | 28,800 | 1b1a42ba6dc7953db742959a54fd19124348f3fc | A sandbox process should wait until it has not been moved into cgroups | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/boot.go",
"new_path": "runsc/cmd/boot.go",
"diff": "@@ -69,6 +69,9 @@ type Boot struct {\n// userLogFD is the file descriptor to write user logs to.\nuserLogFD int\n+\n+ // startSyncFD is the file descriptor to synchronize runsc and sandbox.\n+ start... | Go | Apache License 2.0 | google/gvisor | A sandbox process should wait until it has not been moved into cgroups
PiperOrigin-RevId: 224418900
Change-Id: I53cf4d7c1c70117875b6920f8fd3d58a3b1497e9 |
259,948 | 07.12.2018 17:03:06 | 28,800 | 9984138abee51d6145469f9298bfeb8a98589709 | sentry: turn "dynamically-created" procfs files into static creation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/proc.go",
"new_path": "pkg/sentry/fs/proc/proc.go",
"diff": "@@ -85,8 +85,6 @@ func New(ctx context.Context, msrc *fs.MountSource) (*fs.Inode, error) {\np := &proc{k: k, pidns: pidns}\np.InitDir(ctx, map[string]*fs.Inode{\n- // Note that the... | Go | Apache License 2.0 | google/gvisor | sentry: turn "dynamically-created" procfs files into static creation.
PiperOrigin-RevId: 224600982
Change-Id: I547253528e24fb0bb318fc9d2632cb80504acb34 |
259,992 | 08.12.2018 09:20:55 | 28,800 | b89f9909d77c9b41adf15c032bf588c99fc4b7eb | Update K8s support
Add pointers to Minikube and gvisor-containerd-shim. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -191,9 +191,9 @@ chmod a+x runsc\nsudo mv runsc /usr/local/bin\n```\n-### Configuring Docker\n+### Running with Docker\n-Next, configure Docker to use `runsc` by adding a runtime entry to your Docker\n+To use gV... | Go | Apache License 2.0 | google/gvisor | Update K8s support
Add pointers to Minikube and gvisor-containerd-shim.
PiperOrigin-RevId: 224654334
Change-Id: Icefefbe531e901fe4807ba81904de8b01baf8a15 |
259,854 | 09.12.2018 00:49:37 | 28,800 | 25b8424d754bd659a0f976f82f7c8846dc2a194f | Stub out TCP_QUICKACK | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -698,6 +698,18 @@ func getSockOptTCP(t *kernel.Task, ep commonEndpoint, name, outLen int) (interfa\nreturn int32(v), nil\n+ case linux.TCP_QUICKACK:\n+ i... | Go | Apache License 2.0 | google/gvisor | Stub out TCP_QUICKACK
PiperOrigin-RevId: 224696233
Change-Id: I45c425d9e32adee5dcce29ca7439a06567b26014 |
259,881 | 10.12.2018 12:36:27 | 28,800 | 99d595869332f817de8f570fae184658c513a43c | Validate FS_BASE in Task.Clone
arch_prctl already verified that the new FS_BASE was canonical, but
Task.Clone did not. Centralize these checks in the arch packages.
Failure to validate could cause an error in PTRACE_SET_REGS when we try
to switch to the app. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/arch.go",
"new_path": "pkg/sentry/arch/arch.go",
"diff": "@@ -115,6 +115,12 @@ type Context interface {\n// SetStack sets the current stack pointer.\nSetStack(value uintptr)\n+ // TLS returns the current TLS pointer.\n+ TLS() uintptr\n+\n+ // S... | Go | Apache License 2.0 | google/gvisor | Validate FS_BASE in Task.Clone
arch_prctl already verified that the new FS_BASE was canonical, but
Task.Clone did not. Centralize these checks in the arch packages.
Failure to validate could cause an error in PTRACE_SET_REGS when we try
to switch to the app.
PiperOrigin-RevId: 224862398
Change-Id: Iefe63b3f9aa6c4810326b8936e501be3ec407f14 |
259,985 | 10.12.2018 12:47:20 | 28,800 | fc297702511edef4760c4f7a1d89cc6f02347d50 | Add type safety to shm ids and keys. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/shm/shm.go",
"new_path": "pkg/sentry/kernel/shm/shm.go",
"diff": "@@ -51,6 +51,12 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/syserror\"\n)\n+// Key represents a shm segment key. Analogous to a file name.\n+type Key int32\n+\n+// ID rep... | Go | Apache License 2.0 | google/gvisor | Add type safety to shm ids and keys.
PiperOrigin-RevId: 224864380
Change-Id: I49542279ad56bf15ba462d3de1ef2b157b31830a |
259,854 | 10.12.2018 17:55:45 | 28,800 | 5d87d8865f8771c00b84717d40f27f8f93dda7ca | Implement MSG_WAITALL
MSG_WAITALL requests that recv family calls do not perform short reads. It only
has an effect for SOCK_STREAM sockets, other types ignore it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/socket.go",
"new_path": "pkg/sentry/fs/host/socket.go",
"diff": "@@ -169,7 +169,7 @@ func NewSocketWithDirent(ctx context.Context, d *fs.Dirent, f *fd.FD, flags fs.F\nep := transport.NewExternal(e.stype, uniqueid.GlobalProviderFromContext(ct... | Go | Apache License 2.0 | google/gvisor | Implement MSG_WAITALL
MSG_WAITALL requests that recv family calls do not perform short reads. It only
has an effect for SOCK_STREAM sockets, other types ignore it.
PiperOrigin-RevId: 224918540
Change-Id: Id97fbf972f1f7cbd4e08eec0138f8cbdf1c94fe7 |
259,974 | 10.12.2018 21:34:08 | 28,800 | 52fe3b87a415006a4ef96548e33a7153b14ac28d | Add safecopy support for arm64 platform. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/safecopy/BUILD",
"new_path": "pkg/sentry/platform/safecopy/BUILD",
"diff": "@@ -6,11 +6,15 @@ go_library(\nname = \"safecopy\",\nsrcs = [\n\"atomic_amd64.s\",\n+ \"atomic_arm64.s\",\n\"memclr_amd64.s\",\n+ \"memclr_arm64.s\",\n\"memcpy_amd6... | Go | Apache License 2.0 | google/gvisor | Add safecopy support for arm64 platform.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I565214581eeb44045169da7f44d45a489082ac3a
PiperOrigin-RevId: 224938170 |
259,884 | 10.12.2018 22:56:19 | 28,800 | 93ac04a6c32003597b3c639480126f8048988b72 | Minor wording update to Kubernetes support section of the README
Updated the README to correct some wording and clarify a bit that containerd
CRI runtime is needed. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -236,7 +236,8 @@ the gVisor addon is enabled, pods with `io.kubernetes.cri.untrusted-workload`\nset to true will execute with `runsc`. Follow [these instructions][minikube] to\nenable gVisor addon.\n-You can als... | Go | Apache License 2.0 | google/gvisor | Minor wording update to Kubernetes support section of the README
Updated the README to correct some wording and clarify a bit that containerd
CRI runtime is needed.
PiperOrigin-RevId: 224944753
Change-Id: I7b9c527500f99571aca7ef73058472ae9b3d5371 |
259,881 | 10.12.2018 23:58:20 | 28,800 | 77a443269a81bc81d1d0b4ac46406745e882be88 | Fix test tag argument typo
The argument is --test_tag_filters, not --test_tag_filter.
Also switch to ... instead of :*, as it doesn't require special shell
quoting to avoid * expansion. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/README.md",
"new_path": "test/syscalls/README.md",
"diff": "@@ -39,13 +39,13 @@ tag:\n```bash\n# Run all tests in native environment:\n-$ bazel test --test_tag_filter=native //test/syscalls:*\n+$ bazel test --test_tag_filters=native //test/syscal... | Go | Apache License 2.0 | google/gvisor | Fix test tag argument typo
The argument is --test_tag_filters, not --test_tag_filter.
Also switch to ... instead of :*, as it doesn't require special shell
quoting to avoid * expansion.
PiperOrigin-RevId: 224949618
Change-Id: I45dd6acbaeae29f2cc0baa977b086b5c037c6a88 |
259,956 | 11.12.2018 11:39:17 | 28,800 | 5934fad1d781f13d04184c7585014a98a3b86958 | Remove unused envv variable from two funcs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/interpreter.go",
"new_path": "pkg/sentry/loader/interpreter.go",
"diff": "@@ -37,7 +37,7 @@ const (\n)\n// parseInterpreterScript returns the interpreter path and argv.\n-func parseInterpreterScript(ctx context.Context, filename string, f *fs... | Go | Apache License 2.0 | google/gvisor | Remove unused envv variable from two funcs.
PiperOrigin-RevId: 225041520
Change-Id: Ib1afc693e592d308d60db82022c5b7743fd3c646 |
259,881 | 11.12.2018 15:32:23 | 28,800 | 2b6df6a2049e839e39717f90c1760f3d410c98f1 | Format unshare flags
unshare actually takes a subset of clone flags, but has no unique flags,
so formatting as clone flags is close enough. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64.go",
"new_path": "pkg/sentry/strace/linux64.go",
"diff": "@@ -289,7 +289,7 @@ var linuxAMD64 = SyscallMap{\n269: makeSyscallInfo(\"faccessat\", Hex, Path, Oct, Hex),\n270: makeSyscallInfo(\"pselect6\", Hex, Hex, Hex, Hex, Hex, Hex),\n... | Go | Apache License 2.0 | google/gvisor | Format unshare flags
unshare actually takes a subset of clone flags, but has no unique flags,
so formatting as clone flags is close enough.
PiperOrigin-RevId: 225082774
Change-Id: I5b580f18607c7785f323e37809094115520a17c0 |
259,881 | 11.12.2018 16:11:53 | 28,800 | 24c1158b9c21f7f8b7126e810d623a518422052e | Add "trace signal" option
This option is effectively equivalent to -panic-signal, except that the
sandbox does not die after logging the traceback. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -198,10 +198,17 @@ type Config struct {\n// WatchdogAction sets what action the watchdog takes when triggered.\nWatchdogAction watchdog.Action\n- // PanicSignal register signal handling tha... | Go | Apache License 2.0 | google/gvisor | Add "trace signal" option
This option is effectively equivalent to -panic-signal, except that the
sandbox does not die after logging the traceback.
PiperOrigin-RevId: 225089593
Change-Id: Ifb1c411210110b6104613f404334bd02175e484e |
259,885 | 11.12.2018 17:04:42 | 28,800 | a2c868a098fcb51dcdf629045c5f5c0f68c2766f | Add rvalue ref-qualified PosixErrorOr<T>::ValueOrDie() overloads.
This allows ValueOrDie() to be called on PosixErrorOr rvalues (e.g.
temporaries) holding move-only types without extraneous std::move()s. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/itimer.cc",
"new_path": "test/syscalls/linux/itimer.cc",
"diff": "@@ -126,7 +126,7 @@ SignalTestResult ItimerSignalTest(int id, clock_t main_clock,\nsa.sa_handler = &SignalTestSignalHandler;\nsa.sa_flags = SA_RESTART;\nsigemptyset(&sa.sa_ma... | Go | Apache License 2.0 | google/gvisor | Add rvalue ref-qualified PosixErrorOr<T>::ValueOrDie() overloads.
This allows ValueOrDie() to be called on PosixErrorOr rvalues (e.g.
temporaries) holding move-only types without extraneous std::move()s.
PiperOrigin-RevId: 225098036
Change-Id: I662862e4f3562141f941845fc6e197edb27ce29b |
259,985 | 12.12.2018 13:09:10 | 28,800 | 75e39eaa74c65b6f7cfb95addb6ac0cbcc7d951a | Pass information about map writableness to filesystems.
This is necessary to implement file seals for memfds. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/binder/binder.go",
"new_path": "pkg/sentry/fs/binder/binder.go",
"diff": "@@ -302,7 +302,7 @@ func (bp *Proc) Ioctl(ctx context.Context, io usermem.IO, args arch.SyscallArgum\n}\n// AddMapping implements memmap.Mappable.AddMapping.\n-func (bp *Pr... | Go | Apache License 2.0 | google/gvisor | Pass information about map writableness to filesystems.
This is necessary to implement file seals for memfds.
PiperOrigin-RevId: 225239394
Change-Id: Ib3f1ab31385afc4b24e96cd81a05ef1bebbcbb70 |
259,985 | 12.12.2018 13:17:46 | 28,800 | f93c288dd70846f335239e2d0cb351135a756f51 | Fix a data race on Shm.key. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/shm/shm.go",
"new_path": "pkg/sentry/kernel/shm/shm.go",
"diff": "@@ -66,16 +66,21 @@ type Registry struct {\n// userNS owns the IPC namespace this registry belong to. Immutable.\nuserNS *auth.UserNamespace\n+ // mu protects all fields below.... | Go | Apache License 2.0 | google/gvisor | Fix a data race on Shm.key.
PiperOrigin-RevId: 225240907
Change-Id: Ie568ce3cd643f3e4a0eaa0444f4ed589dcf6031f |
259,854 | 12.12.2018 18:40:04 | 28,800 | f484b6d4c2f1dea6169ed50a5d3d1809e8f007be | Flush socket test description
This ensures that we know what type of socket caused a timeout. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_test_util.h",
"new_path": "test/syscalls/linux/socket_test_util.h",
"diff": "@@ -379,6 +379,7 @@ class SocketPairTest : public ::testing::TestWithParam<SocketPairKind> {\nSocketPairTest() {\n// gUnit uses printf, so so will we.\nprin... | Go | Apache License 2.0 | google/gvisor | Flush socket test description
This ensures that we know what type of socket caused a timeout.
PiperOrigin-RevId: 225294255
Change-Id: I9033bd0f3791d3b5714aa08d111cf58a3014d252 |
259,854 | 13.12.2018 13:01:56 | 28,800 | 6253d32cc932e76608be5c57a4870b3d61464487 | transport/tcp: remove unused error return values | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -245,11 +245,7 @@ func (l *listenContext) createEndpointAndPerformHandshake(s *segment, opts *head\n}\n// Perform the 3-way handshake.\n- h, err := newHandshake(ep... | Go | Apache License 2.0 | google/gvisor | transport/tcp: remove unused error return values
PiperOrigin-RevId: 225421480
Change-Id: I1e9259b0b7e8490164e830b73338a615129c7f0e |
259,854 | 13.12.2018 13:19:39 | 28,800 | 4659f7ed1a63f031b5450d065684ef6c32d35f01 | Fix WAITALL and RCVTIMEO interaction | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -1352,6 +1352,9 @@ func (s *SocketOperations) RecvMsg(t *kernel.Task, dst usermem.IOSequence, flags\ndst = dst.DropFirst(rn)\nif err := t.BlockWithDeadli... | Go | Apache License 2.0 | google/gvisor | Fix WAITALL and RCVTIMEO interaction
PiperOrigin-RevId: 225424296
Change-Id: I60fcc2b859339dca9963cb32227a287e719ab765 |
259,884 | 14.12.2018 13:21:21 | 0 | 3a7894df044c149113c97edd273e57703c32534b | Fix sandbox.json instructions for containerd 1.1
Annotations aren't part of the PodSandboxMetadata but rather part of the
PodSandboxConfig object. crictl's parsing logic seems to ignore
extraneous fields so it silently fails to create pods using the
untrusted workload runtime.
See: | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -78,10 +78,10 @@ $ cat > sandbox.json << EOL\n\"name\": \"nginx-sandbox\",\n\"namespace\": \"default\",\n\"attempt\": 1,\n- \"uid\": \"hdishd83djaidwnduwk28bcsb\",\n+ \"uid\": \"hdishd83djaidwnduwk28bcsb\"\n+ },... | Go | Apache License 2.0 | google/gvisor | Fix sandbox.json instructions for containerd 1.1
Annotations aren't part of the PodSandboxMetadata but rather part of the
PodSandboxConfig object. crictl's parsing logic seems to ignore
extraneous fields so it silently fails to create pods using the
untrusted workload runtime.
See: https://github.com/kubernetes-sigs/cri-tools/blob/v1.13.0/vendor/k8s.io/kubernetes/pkg/kubelet/apis/cri/runtime/v1alpha2/api.pb.go#L775 |
259,854 | 14.12.2018 16:12:51 | 28,800 | e1dcf92ec5cf7d9bf58fb322f46f6ae2d98699d2 | Implement SO_SNDTIMEO | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/BUILD",
"new_path": "pkg/sentry/fs/host/BUILD",
"diff": "@@ -71,6 +71,7 @@ go_test(\n\"//pkg/sentry/context\",\n\"//pkg/sentry/context/contexttest\",\n\"//pkg/sentry/fs\",\n+ \"//pkg/sentry/kernel/time\",\n\"//pkg/sentry/socket\",\n\"//pkg/s... | Go | Apache License 2.0 | google/gvisor | Implement SO_SNDTIMEO
PiperOrigin-RevId: 225620490
Change-Id: Ia726107b3f58093a5f881634f90b071b32d2c269 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.