author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,853 | 14.12.2018 16:23:03 | 28,800 | 3cf84e3bef865214fcf2b080a05065f0a9e976ec | Mark sync.Mutex in TTYFileOperations as nosave | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/tty.go",
"new_path": "pkg/sentry/fs/host/tty.go",
"diff": "@@ -35,7 +35,7 @@ type TTYFileOperations struct {\nfileOperations\n// mu protects the fields below.\n- mu sync.Mutex\n+ mu sync.Mutex `state:\"nosave\"`\n// FGProcessGroup is the for... | Go | Apache License 2.0 | google/gvisor | Mark sync.Mutex in TTYFileOperations as nosave
PiperOrigin-RevId: 225621767
Change-Id: Ie3a42cdf0b0de22a020ff43e307bf86409cff329 |
259,858 | 14.12.2018 18:03:43 | 28,800 | 5d8cf31346376eb7c6a93bad3eab7666f145fa0e | Move fdnotifier package to reduce internal confusion. | [
{
"change_type": "RENAME",
"old_path": "pkg/waiter/fdnotifier/BUILD",
"new_path": "pkg/fdnotifier/BUILD",
"diff": "@@ -8,7 +8,7 @@ go_library(\n\"fdnotifier.go\",\n\"poll_unsafe.go\",\n],\n- importpath = \"gvisor.googlesource.com/gvisor/pkg/waiter/fdnotifier\",\n+ importpath = \"gvisor.googlesource.... | Go | Apache License 2.0 | google/gvisor | Move fdnotifier package to reduce internal confusion.
PiperOrigin-RevId: 225632398
Change-Id: I909e7e2925aa369adc28e844c284d9a6108e85ce |
259,854 | 14.12.2018 22:10:19 | 28,800 | f74eed464b55d9640432432cd96d811578e9081e | Add blocking recv tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -356,6 +356,10 @@ syscall_test(test = \"//test/syscalls/linux:socket_netdevice_test\")\nsyscall_test(test = \"//test/syscalls/linux:socket_netlink_route_test\")\n+syscall_test(test = \"//test... | Go | Apache License 2.0 | google/gvisor | Add blocking recv tests
PiperOrigin-RevId: 225646045
Change-Id: Ic712ebc627587ef4a9486f0b39fe8c96100f10ff |
260,006 | 16.12.2018 23:04:56 | 28,800 | e491ebbacf548a2a2f818f1093b09d6f1c13e7e0 | Allow sending of multicast and IPv6 link-local packets w/o route.
Same as with broadcast packets, sending of a multicast packet shouldn't require
accessing the route table. The same applies to IPv6 link-local addresses, which
aren't routable at all (they don't belong to any subnet by definition). | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6.go",
"new_path": "pkg/tcpip/header/ipv6.go",
"diff": "@@ -77,6 +77,9 @@ const (\n// IPv6MinimumMTU is the minimum MTU required by IPv6, per RFC 2460,\n// section 5.\nIPv6MinimumMTU = 1280\n+\n+ // IPv6Any is the non-routable IPv6 \"any\" ... | Go | Apache License 2.0 | google/gvisor | Allow sending of multicast and IPv6 link-local packets w/o route.
Same as with broadcast packets, sending of a multicast packet shouldn't require
accessing the route table. The same applies to IPv6 link-local addresses, which
aren't routable at all (they don't belong to any subnet by definition).
PiperOrigin-RevId: 225775870
Change-Id: Ic53e6560c125a83be2be9c3d112e66b36e8dfe7b |
259,985 | 17.12.2018 14:11:10 | 28,800 | e9c4f69f36308b370579c954badc7ad90146d6e7 | Enable recently-fixed test case for shm_test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/shm.cc",
"new_path": "test/syscalls/linux/shm.cc",
"diff": "@@ -427,6 +427,13 @@ TEST(ShmTest, RequestingDuplicateCreationFails) {\nPosixErrorIs(EEXIST, _));\n}\n+TEST(ShmTest, NonExistentSegmentsAreNotFound) {\n+ const TempPath keyfile = A... | Go | Apache License 2.0 | google/gvisor | Enable recently-fixed test case for shm_test.
PiperOrigin-RevId: 225887356
Change-Id: Iee000dcfc9e0168c2566edf41c66108be9b68cd6 |
259,881 | 17.12.2018 17:34:09 | 28,800 | b62591e6a813ec19a1fd74943584c4fead81f670 | Expose internal testing flag
Never to used outside of runsc tests! | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -218,7 +218,7 @@ type Config struct {\n// ToFlags returns a slice of flags that correspond to the given Config.\nfunc (c *Config) ToFlags() []string {\n- return []string{\n+ f := []string{\... | Go | Apache License 2.0 | google/gvisor | Expose internal testing flag
Never to used outside of runsc tests!
PiperOrigin-RevId: 225919013
Change-Id: Ib3b14aa2a2564b5246fb3f8933d95e01027ed186 |
259,885 | 18.12.2018 07:22:44 | 28,800 | e7b47844d969673cec06ea745d577155131ecf3b | Correctly handle filenames containing spaces in ParseProcMapsLine. | [
{
"change_type": "MODIFY",
"old_path": "test/util/BUILD",
"new_path": "test/util/BUILD",
"diff": "@@ -46,6 +46,16 @@ cc_library(\n],\n)\n+cc_test(\n+ name = \"proc_util_test\",\n+ size = \"small\",\n+ srcs = [\"proc_util_test.cc\"],\n+ deps = [\n+ \":proc_util\",\n+ \":test_util\",\n+ ],\n+)\n+\ncc_... | Go | Apache License 2.0 | google/gvisor | Correctly handle filenames containing spaces in ParseProcMapsLine.
PiperOrigin-RevId: 225992500
Change-Id: Icc8b1675f1cb625fc5e8ef7389beb42fa7bfaa13 |
259,992 | 18.12.2018 10:27:16 | 28,800 | 03226cd95055aee73d4e4dfcb4954490b4fd8a2d | Add BPFAction type with Stringer | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/seccomp.go",
"new_path": "pkg/abi/linux/seccomp.go",
"diff": "package linux\n+import \"fmt\"\n+\n// Seccomp constants taken from <linux/seccomp.h>.\nconst (\nSECCOMP_MODE_NONE = 0\nSECCOMP_MODE_FILTER = 2\n- SECCOMP_RET_KILL_PROCESS = 0x80000000\... | Go | Apache License 2.0 | google/gvisor | Add BPFAction type with Stringer
PiperOrigin-RevId: 226018694
Change-Id: I98965e26fe565f37e98e5df5f997363ab273c91b |
259,885 | 18.12.2018 11:51:22 | 28,800 | 3b3f02627870a06de4e1fc3178d5bd23f627a97a | Truncate ar before calling mm.breakCopyOnWriteLocked().
... as required by the latter's precondition. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/pma.go",
"new_path": "pkg/sentry/mm/pma.go",
"diff": "@@ -138,6 +138,10 @@ func (mm *MemoryManager) getPMAsLocked(ctx context.Context, vseg vmaIterator, ar\nvar cowerr error\nif opts.breakCOW {\n+ if pend.Start() < ar.End {\n+ // Adjust ar to ref... | Go | Apache License 2.0 | google/gvisor | Truncate ar before calling mm.breakCopyOnWriteLocked().
... as required by the latter's precondition.
PiperOrigin-RevId: 226033824
Change-Id: I6bc46d0e100c61cc58cb5fc69e70c4ca905cd92d |
259,885 | 18.12.2018 12:15:22 | 28,800 | 0759f3afee5b02d1f43b54f90111086cdc78338e | Allow PosixErrorOr<T> to be implicitly constructible from copyable T. | [
{
"change_type": "MODIFY",
"old_path": "test/util/posix_error.h",
"new_path": "test/util/posix_error.h",
"diff": "@@ -74,9 +74,9 @@ class ABSL_MUST_USE_RESULT PosixError {\ntemplate <typename T>\nclass ABSL_MUST_USE_RESULT PosixErrorOr {\npublic:\n- PosixErrorOr(const PosixError& error); // NOLINT\n... | Go | Apache License 2.0 | google/gvisor | Allow PosixErrorOr<T> to be implicitly constructible from copyable T.
PiperOrigin-RevId: 226037787
Change-Id: I5fb5f55f68b67dd86bbff46349b46e3e8e6b9d1b |
259,885 | 18.12.2018 13:49:22 | 28,800 | 898838e34d1b0c76405f3e7f7f5fa7f1a444da0e | Fix mremap expansion with mm.checkInvariants = true.
Also remove useless RSS changes in mm.movePMAsLocked(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/pma.go",
"new_path": "pkg/sentry/mm/pma.go",
"diff": "@@ -679,7 +679,7 @@ func Unpin(prs []PinnedRange) {\n// movePMAsLocked moves all pmas in oldAR to newAR.\n//\n// Preconditions: mm.activeMu must be locked for writing. oldAR.Length() != 0.\n-/... | Go | Apache License 2.0 | google/gvisor | Fix mremap expansion with mm.checkInvariants = true.
Also remove useless RSS changes in mm.movePMAsLocked().
PiperOrigin-RevId: 226052996
Change-Id: If59fd259b93238fb2f15c1c8ebfeda14cb590a87 |
259,975 | 19.12.2018 13:14:53 | 28,800 | ff7178a4d10f9f1fb34e54fed5ef27cfbff5d6f9 | Implement pwritev2.
Implement pwritev2 and associated unit tests.
Clean up preadv2 unit tests.
Tag RWF_ flags in both preadv2 and pwritev2 with associated bug tickets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -152,9 +152,10 @@ const (\n// Values for preadv2/pwritev2.\nconst (\n- RWF_HIPRI = 0x0001\n- RWF_DSYNC = 0X0002\n- RWF_SYNC = 0x0004\n+ RWF_HIPRI = 0x00000001\n+ RWF_DSYNC = 0x00000002\n+... | Go | Apache License 2.0 | google/gvisor | Implement pwritev2.
Implement pwritev2 and associated unit tests.
Clean up preadv2 unit tests.
Tag RWF_ flags in both preadv2 and pwritev2 with associated bug tickets.
PiperOrigin-RevId: 226222119
Change-Id: Ieb22672418812894ba114bbc88e67f1dd50de620 |
259,948 | 20.12.2018 09:51:26 | 28,800 | 25d62850ce8a420600194009a7257148c43cc5f8 | test: deflake socket_inet_loopback. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -185,6 +185,11 @@ TEST_P(SocketInetLoopbackTest, TCP) {\nSyscallSucceeds());\n// Accept the connection.\n+ //\n+ // We have to assign a name to... | Go | Apache License 2.0 | google/gvisor | test: deflake socket_inet_loopback.
PiperOrigin-RevId: 226350590
Change-Id: Idff080705f644f8f78ce92b53c77eecc37e002e7 |
259,885 | 20.12.2018 13:27:25 | 28,800 | 194ef586fcb1bec049ee8777c2e5f70997de7a87 | Rename limits.MemoryPagesLocked to limits.MemoryLocked.
"RLIMIT_MEMLOCK: This is the maximum number of bytes of memory that may
be locked into RAM." - getrlimit(2) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/limits/limits.go",
"new_path": "pkg/sentry/limits/limits.go",
"diff": "@@ -33,7 +33,7 @@ const (\nRss\nProcessCount\nNumberOfFiles\n- MemoryPagesLocked\n+ MemoryLocked\nAS\nLocks\nSignalsPending\n"
},
{
"change_type": "MODIFY",
"old_path... | Go | Apache License 2.0 | google/gvisor | Rename limits.MemoryPagesLocked to limits.MemoryLocked.
"RLIMIT_MEMLOCK: This is the maximum number of bytes of memory that may
be locked into RAM." - getrlimit(2)
PiperOrigin-RevId: 226384346
Change-Id: Iefac4a1bb69f7714dc813b5b871226a8344dc800 |
259,854 | 20.12.2018 13:47:46 | 28,800 | f6274804e14ece853c952cb71fde73dfb06b733a | Make read and write respect SO_RCVTIMEO and SO_SNDTIMEO | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_read.go",
"new_path": "pkg/sentry/syscalls/linux/sys_read.go",
"diff": "package linux\nimport (\n+ \"time\"\n+\n\"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n\"gvisor.googlesource.com/gvisor/pkg/sentry/arch\"\n\"gvisor.googles... | Go | Apache License 2.0 | google/gvisor | Make read and write respect SO_RCVTIMEO and SO_SNDTIMEO
PiperOrigin-RevId: 226387521
Change-Id: I0579ab262320fde6c72d2994dd38437f01a99ea5 |
259,881 | 21.12.2018 10:47:41 | 28,800 | 5c7f70a07d8f4b08db3446e0cf75ad43bb2c1953 | Update rules_go, gazelle, and Go | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "load(\"@bazel_tools//tools/build_defs/repo:http.bzl\", \"http_archive\")\nhttp_archive(\nname = \"io_bazel_rules_go\",\n- url = \"https://github.com/bazelbuild/rules_go/releases/download/0.16.4/rules_go-0.16.4.tar.... | Go | Apache License 2.0 | google/gvisor | Update rules_go, gazelle, and Go
PiperOrigin-RevId: 226511383
Change-Id: I3a42572d44582d5713841799ec1fd9695d050938 |
259,992 | 21.12.2018 11:52:39 | 28,800 | 1679ef31ef15344eba218a5251fa1fb1438b4cb7 | inotify notifies watchers when control events bit are set
The code that matches the event being published with events watchers
was wronly matching all watchers in case any of the control event bits
were set.
Issue | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inotify_watch.go",
"new_path": "pkg/sentry/fs/inotify_watch.go",
"diff": "@@ -76,15 +76,17 @@ func isRenameEvent(eventMask uint32) bool {\n// Notify queues a new event on this watch.\nfunc (w *Watch) Notify(name string, events uint32, cookie uint... | Go | Apache License 2.0 | google/gvisor | inotify notifies watchers when control events bit are set
The code that matches the event being published with events watchers
was wronly matching all watchers in case any of the control event bits
were set.
Issue #121
PiperOrigin-RevId: 226521230
Change-Id: Ie2c42bc4366faaf59fbf80a74e9297499bd93f9e |
259,881 | 21.12.2018 12:14:17 | 28,800 | 0e9b32485670bb321b9b2eee3f1860e0db43d377 | Fix test util tests
We actually need to include test main! | [
{
"change_type": "MODIFY",
"old_path": "test/util/BUILD",
"new_path": "test/util/BUILD",
"diff": "@@ -52,7 +52,9 @@ cc_test(\nsrcs = [\"proc_util_test.cc\"],\ndeps = [\n\":proc_util\",\n+ \":test_main\",\n\":test_util\",\n+ \"@com_google_googletest//:gtest\",\n],\n)\n@@ -84,7 +86,9 @@ cc_test(\n\":f... | Go | Apache License 2.0 | google/gvisor | Fix test util tests
We actually need to include test main!
PiperOrigin-RevId: 226524447
Change-Id: I9d9e631611183c7c1fbae1c20a222c9aeef269b2 |
259,854 | 21.12.2018 13:12:32 | 28,800 | b515556519a44d4b6a23590e236bb4f30726b5bf | Implement SO_KEEPALIVE, TCP_KEEPIDLE, and TCP_KEEPINTVL.
Within gVisor, plumb new socket options to netstack.
Within netstack, fix GetSockOpt and SetSockOpt return value logic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/tcp.go",
"new_path": "pkg/abi/linux/tcp.go",
"diff": "@@ -52,3 +52,9 @@ const (\nTCP_ZEROCOPY_RECEIVE = 35\nTCP_INQ = 36\n)\n+\n+// Socket constants from include/net/tcp.h.\n+const (\n+ MAX_TCP_KEEPIDLE = 32767\n+ MAX_TCP_KEEPINTVL = 32767\n+)\n"... | Go | Apache License 2.0 | google/gvisor | Implement SO_KEEPALIVE, TCP_KEEPIDLE, and TCP_KEEPINTVL.
Within gVisor, plumb new socket options to netstack.
Within netstack, fix GetSockOpt and SetSockOpt return value logic.
PiperOrigin-RevId: 226532229
Change-Id: If40734e119eed633335f40b4c26facbebc791c74 |
259,853 | 21.12.2018 15:39:04 | 28,800 | 89b18f7108e2c3a04169e0b79b615429fbb08a99 | Remove gunit_no_heapcheck from deps
heapcheck works fine now. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -254,14 +254,15 @@ cc_binary(\n],\nlinkstatic = 1,\ndeps = [\n+ # The heap check doesn't handle mremap properly.\n+ \"@com_google_googletest//:gtest\",\n+ \"@com_google_absl//absl... | Go | Apache License 2.0 | google/gvisor | Remove gunit_no_heapcheck from deps
heapcheck works fine now.
PiperOrigin-RevId: 226552252
Change-Id: Ifcf17a377b3d6512a576f54462dd81c1d4c7b17c |
259,854 | 21.12.2018 19:45:43 | 28,800 | 0df0df35fc4aa4d69dc01f7c7e2d9e0530a34db7 | Stub out SO_OOBINLINE.
We don't explicitly support out-of-band data and treat it like normal in-band
data. This is equilivent to SO_OOBINLINE being enabled, so always report that
it is enabled. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -678,6 +678,18 @@ func getSockOptSocket(t *kernel.Task, s socket.Socket, ep commonEndpoint, family\nreturn int32(v), nil\n+ case linux.SO_OOBINLINE:\n+ i... | Go | Apache License 2.0 | google/gvisor | Stub out SO_OOBINLINE.
We don't explicitly support out-of-band data and treat it like normal in-band
data. This is equilivent to SO_OOBINLINE being enabled, so always report that
it is enabled.
PiperOrigin-RevId: 226572742
Change-Id: I4c30ccb83265e76c30dea631cbf86822e6ee1c1b |
260,013 | 26.12.2018 11:24:29 | 28,800 | bfa2f314ca05854b0d08aa2f5c2b93b16542d95f | Add EventChannel messages for uncaught signals. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "+load(\"@io_bazel_rules_go//proto:def.bzl\", \"go_proto_library\")\n+\npackage(licenses = [\"notice\"]) # Apache 2.0\nload(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\n@@... | Go | Apache License 2.0 | google/gvisor | Add EventChannel messages for uncaught signals.
PiperOrigin-RevId: 226936778
Change-Id: I2a6dda157c55d39d81e1b543ab11a58a0bfe5c05 |
259,854 | 26.12.2018 23:51:00 | 28,800 | bce2f9751f415da869d04ccb53833b024373666d | Plumb IP_MULTICAST_TTL to netstack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -531,8 +531,10 @@ func GetSockOpt(t *kernel.Task, s socket.Socket, ep commonEndpoint, family int,\ncase linux.SOL_IPV6:\nreturn getSockOptIPv6(t, ep, nam... | Go | Apache License 2.0 | google/gvisor | Plumb IP_MULTICAST_TTL to netstack.
PiperOrigin-RevId: 226993086
Change-Id: I71757f231436538081d494da32ca69f709bc71c7 |
259,992 | 28.12.2018 13:47:19 | 28,800 | a891afad6d7e3b09bafdccb4cc4b9fc4e577620e | Simplify synchronization between runsc and sandbox process
Make 'runsc create' join cgroup before creating sandbox process.
This removes the need to synchronize platform creation and ensure
that sandbox process is charged to the right cgroup from the start. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -81,9 +81,6 @@ const (\n// and return its ExitStatus.\nContainerWait = \"containerManager.Wait\"\n- // ContainerWaitForLoader blocks until the container's loader has been created.\n... | Go | Apache License 2.0 | google/gvisor | Simplify synchronization between runsc and sandbox process
Make 'runsc create' join cgroup before creating sandbox process.
This removes the need to synchronize platform creation and ensure
that sandbox process is charged to the right cgroup from the start.
PiperOrigin-RevId: 227166451
Change-Id: Ieb4b18e6ca0daf7b331dc897699ca419bc5ee3a2 |
259,992 | 02.01.2019 11:38:51 | 28,800 | 8e586db16274c2563fb13c95bafa9e20ea3d73ce | Add /proc/net/psched content
FIO reads this file and expects it to be well formed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -16,6 +16,7 @@ package proc\nimport (\n\"fmt\"\n+ \"time\"\n\"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n\"gvisor.googlesource.com/gvisor/pkg/sentry/context\"\n@@ -42,7 +43,1... | Go | Apache License 2.0 | google/gvisor | Add /proc/net/psched content
FIO reads this file and expects it to be well formed.
PiperOrigin-RevId: 227554483
Change-Id: Ia48ae2377626dd6a2daf17b5b4f5119f90ece55b |
260,013 | 03.01.2019 13:22:12 | 28,800 | d89836fe51eeef4920439d6d2433f2ee6f37aec9 | Add test for reopening socketpair end via procfs. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_unix.cc",
"new_path": "test/syscalls/linux/socket_unix.cc",
"diff": "#include \"test/syscalls/linux/socket_unix.h\"\n+#include <errno.h>\n#include <net/if.h>\n#include <stdio.h>\n#include <sys/ioctl.h>\n@@ -1175,6 +1176,17 @@ TEST_P(... | Go | Apache License 2.0 | google/gvisor | Add test for reopening socketpair end via procfs.
PiperOrigin-RevId: 227738801
Change-Id: Ic0c5d10c3b1f21b3f85ff9a661a55db77fab77b0 |
259,854 | 03.01.2019 13:52:30 | 28,800 | b709997d78a9504d1d9a14eb2dffae327cd69238 | Rename linux.Errno.Error to linux.Errno.String.
Using linux.Errno as an error doesn't work very well as none of the sentry code
expects error to contain a linux.Errno.
This moves using syserr.Error.ToLinux as an error in a syscall handler from a
runtime error to a compile error. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/errors.go",
"new_path": "pkg/abi/linux/errors.go",
"diff": "@@ -25,8 +25,8 @@ func (e *Errno) Number() int {\nreturn e.number\n}\n-// Error implements error.Error.\n-func (e *Errno) Error() string {\n+// String implements fmt.Stringer.String.\n+f... | Go | Apache License 2.0 | google/gvisor | Rename linux.Errno.Error to linux.Errno.String.
Using linux.Errno as an error doesn't work very well as none of the sentry code
expects error to contain a linux.Errno.
This moves using syserr.Error.ToLinux as an error in a syscall handler from a
runtime error to a compile error.
PiperOrigin-RevId: 227744312
Change-Id: Iea63108a5b198296c908614e09c01733dd684da0 |
259,992 | 03.01.2019 14:09:47 | 28,800 | d033a76fa6e215cb302e5383dbd7b0120de4395d | Apply chroot for --network=host too | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -529,11 +529,13 @@ func (s *Sandbox) createSandboxProcess(spec *specs.Spec, conf *boot.Config, bund\n} else {\nreturn fmt.Errorf(\"can't run sandbox process as user nobody since we ... | Go | Apache License 2.0 | google/gvisor | Apply chroot for --network=host too
PiperOrigin-RevId: 227747566
Change-Id: Ide9df4ac1391adcd1c56e08d6570e0d149d85bc4 |
259,854 | 03.01.2019 15:09:31 | 28,800 | 4a4cc7dc3794535f3d65736cde4293ecf0e565e0 | Allow creating syserr.Errors at runtime.
Not allowing this was an oversight. | [
{
"change_type": "MODIFY",
"old_path": "pkg/syserr/syserr.go",
"new_path": "pkg/syserr/syserr.go",
"diff": "@@ -68,8 +68,21 @@ func New(message string, linuxTranslation *linux.Errno) *Error {\nreturn err\n}\n+// NewDynamic creates a new error with a dynamic error message and an errno\n+// translatio... | Go | Apache License 2.0 | google/gvisor | Allow creating syserr.Errors at runtime.
Not allowing this was an oversight.
PiperOrigin-RevId: 227757813
Change-Id: I845800ab69028b7320afca36d832c477ff17c5ce |
259,885 | 07.01.2019 15:04:00 | 28,800 | e44cb43b9c2292239c33fb77ddd6510ef52e1a7a | Default syscall_test shard_count to 5. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/build_defs.bzl",
"new_path": "test/syscalls/build_defs.bzl",
"diff": "# syscall_test is a macro that will create targets to run the given test target\n# on the host (native) and runsc.\n-def syscall_test(test, shard_count = 1, size = \"small\"):\... | Go | Apache License 2.0 | google/gvisor | Default syscall_test shard_count to 5.
PiperOrigin-RevId: 228243120
Change-Id: I2726d580f4f9fad0ecc6a912e0e576ed9e08ce72 |
259,885 | 07.01.2019 15:39:14 | 28,800 | dc4849e49c354ee43256a4a117a217f86767a059 | Add usermem support for arm64 platform. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/usermem/BUILD",
"new_path": "pkg/sentry/usermem/BUILD",
"diff": "@@ -24,6 +24,7 @@ go_library(\n\"bytes_io.go\",\n\"bytes_io_unsafe.go\",\n\"usermem.go\",\n+ \"usermem_arm64.go\",\n\"usermem_x86.go\",\n],\nimportpath = \"gvisor.googlesource.com/gvis... | Go | Apache License 2.0 | google/gvisor | Add usermem support for arm64 platform.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
PiperOrigin-RevId: 228249611
Change-Id: I1046e70bec4274f18b9948eefd6b0d546e4c48bb |
259,992 | 07.01.2019 23:01:10 | 28,800 | 5ce542ecc749cb9a1e8d216c7181aeaebfbc3110 | Undo changes in case of failure to create file/dir/symlink
File/dir/symlink creation is multi-step and may leave state behind in
case of failure in one of the steps. Added best effort attempt to
clean up. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/BUILD",
"new_path": "runsc/fsgofer/BUILD",
"diff": "@@ -18,6 +18,7 @@ go_library(\n\"//pkg/log\",\n\"//pkg/p9\",\n\"//pkg/syserr\",\n+ \"//runsc/specutils\",\n\"@org_golang_x_sys//unix:go_default_library\",\n],\n)\n"
},
{
"change_type": "... | Go | Apache License 2.0 | google/gvisor | Undo changes in case of failure to create file/dir/symlink
File/dir/symlink creation is multi-step and may leave state behind in
case of failure in one of the steps. Added best effort attempt to
clean up.
PiperOrigin-RevId: 228286612
Change-Id: Ib03c27cd3d3e4f44d0352edc6ee212a53412d7f1 |
259,942 | 08.01.2019 12:34:08 | 28,800 | 3f45878b7323697c82e06649144e2a4f39018a12 | Implement Stringer for tcpip.StatCounter
This enables formatting tcpip.Stats readably with %+v. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tcpip.go",
"new_path": "pkg/tcpip/tcpip.go",
"diff": "@@ -568,6 +568,10 @@ func (s *StatCounter) IncrementBy(v uint64) {\natomic.AddUint64(&s.count, v)\n}\n+func (s *StatCounter) String() string {\n+ return strconv.FormatUint(s.Value(), 10)\n+}\n+\n/... | Go | Apache License 2.0 | google/gvisor | Implement Stringer for tcpip.StatCounter
This enables formatting tcpip.Stats readably with %+v.
PiperOrigin-RevId: 228379088
Change-Id: I6a9876454a22f151ee752cf94589b4188729458f |
259,885 | 08.01.2019 12:51:04 | 28,800 | f95b94fbe3e557b16ed2b78c87e8936c0aeab6c5 | Grant no initial capabilities to non-root UIDs.
See modified comment in auth.NewUserCredentials(); compare to the
behavior of setresuid(2) as implemented by
//pkg/sentry/kernel/task_identity.go:kernel.Task.setKUIDsUncheckedLocked(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/auth/credentials.go",
"new_path": "pkg/sentry/kernel/auth/credentials.go",
"diff": "@@ -119,19 +119,24 @@ func NewUserCredentials(kuid KUID, kgid KGID, extraKGIDs []KGID, capabilities *T\n// Set additional GIDs.\ncreds.ExtraKGIDs = append(cre... | Go | Apache License 2.0 | google/gvisor | Grant no initial capabilities to non-root UIDs.
See modified comment in auth.NewUserCredentials(); compare to the
behavior of setresuid(2) as implemented by
//pkg/sentry/kernel/task_identity.go:kernel.Task.setKUIDsUncheckedLocked().
PiperOrigin-RevId: 228381765
Change-Id: I45238777c8f63fcf41b99fce3969caaf682fe408 |
260,013 | 08.01.2019 12:56:59 | 28,800 | 3676b7ff1ca07e9fec1e380a0c2068390ce5d8de | Improve loader related error messages returned to users. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -184,6 +184,7 @@ go_library(\n\"//pkg/state\",\n\"//pkg/state/statefile\",\n\"//pkg/sync\",\n+ \"//pkg/syserr\",\n\"//pkg/syserror\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/stack\",\n"
},... | Go | Apache License 2.0 | google/gvisor | Improve loader related error messages returned to users.
PiperOrigin-RevId: 228382827
Change-Id: Ica1d30e0df826bdd77f180a5092b2b735ea5c804 |
260,013 | 08.01.2019 14:45:17 | 28,800 | bc19103d589352d7a31f088585d68ef224eaed4c | Enable proc/self/fd test on linux and disable only on gvisor. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_unix.cc",
"new_path": "test/syscalls/linux/socket_unix.cc",
"diff": "@@ -1176,8 +1176,9 @@ TEST_P(UnixSocketPairTest, SocketShutdown) {\nEXPECT_EQ(data, absl::string_view(buf, 3));\n}\n+TEST_P(UnixSocketPairTest, SocketReopenFromProc... | Go | Apache License 2.0 | google/gvisor | Enable proc/self/fd test on linux and disable only on gvisor.
PiperOrigin-RevId: 228403149
Change-Id: Iab212e49d9eb27d785bddc9fd447835ce8c485ae |
260,013 | 08.01.2019 17:12:14 | 28,800 | dd761c170cc2d44eee20757a6088f80a9322342c | Allow MSG_OOB and MSG_DONTROUTE to be no-ops on recvmsg(2). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"new_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"diff": "@@ -63,6 +63,10 @@ var messageHeader64Len = uint64(binary.Size(MessageHeader64{}))\n// multipleMessageHeader64Len is the length of a multipeMessageHeader6... | Go | Apache License 2.0 | google/gvisor | Allow MSG_OOB and MSG_DONTROUTE to be no-ops on recvmsg(2).
PiperOrigin-RevId: 228428223
Change-Id: I433ba5ffc15ea4c2706ec944901b8269b1f364f8 |
259,992 | 09.01.2019 09:17:04 | 28,800 | 0d7023d581612e1670ef36490a827e46968d6d08 | Restore to original cgroup after sandbox and gofer processes are created
The original code assumed that it was safe to join and not restore cgroup,
but Container.Run will not exit after calling start, making cgroup cleanup
fail because there were still processes inside the cgroup. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "package cgroup\nimport (\n+ \"bufio\"\n\"context\"\n\"fmt\"\n\"io/ioutil\"\n@@ -168,12 +169,12 @@ type Cgroup struct {\n}\n// New creates a new Cgroup instance if the spec includes a cgrou... | Go | Apache License 2.0 | google/gvisor | Restore to original cgroup after sandbox and gofer processes are created
The original code assumed that it was safe to join and not restore cgroup,
but Container.Run will not exit after calling start, making cgroup cleanup
fail because there were still processes inside the cgroup.
PiperOrigin-RevId: 228529199
Change-Id: I12a48d9adab4bbb02f20d71ec99598c336cbfe51 |
259,853 | 09.01.2019 13:13:04 | 28,800 | 252e57992d0a5872bb0f1f41c38c004662a729de | Allow to specify a custom path to runsc for syscall-test-runner | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -535,8 +535,6 @@ go_binary(\n],\ndeps = [\n\"//pkg/log\",\n- \"//runsc/boot\",\n- \"//runsc/container\",\n\"//runsc/specutils\",\n\"//runsc/test/testutil\",\n\"//test/syscalls/gtest\",\n"
}... | Go | Apache License 2.0 | google/gvisor | Allow to specify a custom path to runsc for syscall-test-runner
PiperOrigin-RevId: 228574092
Change-Id: Id93abcca1ce964eb595907df9355702d469bc33b |
259,885 | 09.01.2019 17:53:31 | 28,800 | 9270d940eb1a6e31587c34f4644189f3b2c002e1 | Minor memevent fixes.
Call MemoryEvents.done.Add(1) outside of MemoryEvents.run() so that if
MemoryEvents.Stop() => MemoryEvents.done.Wait() is called before the
goroutine starts running, it still waits for the goroutine to stop.
Use defer to call MemoryEvents.done.Done() in MemoryEvents.run() so that it's
called even if the goroutine panics. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/memevent/memory_events.go",
"new_path": "pkg/sentry/kernel/memevent/memory_events.go",
"diff": "@@ -69,11 +69,12 @@ func (m *MemoryEvents) Start() {\nif m.period == 0 {\nreturn\n}\n+ m.done.Add(1)\ngo m.run() // S/R-SAFE: doesn't interact wit... | Go | Apache License 2.0 | google/gvisor | Minor memevent fixes.
- Call MemoryEvents.done.Add(1) outside of MemoryEvents.run() so that if
MemoryEvents.Stop() => MemoryEvents.done.Wait() is called before the
goroutine starts running, it still waits for the goroutine to stop.
- Use defer to call MemoryEvents.done.Done() in MemoryEvents.run() so that it's
called even if the goroutine panics.
PiperOrigin-RevId: 228623307
Change-Id: I1b0459e7999606c1a1a271b16092b1ca87005015 |
259,975 | 10.01.2019 09:43:43 | 28,800 | 7f8de3bf92decbd745a4bc4e8aebf1ba1159ed4b | Fixing select call to not enforce RLIMIT_NOFILE.
Removing check to RLIMIT_NOFILE in select call.
Adding unit test to select suite to document behavior.
Moving setrlimit class from mlock to a util file for reuse.
Fixing flaky test based on comments from Jamie. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_poll.go",
"new_path": "pkg/sentry/syscalls/linux/sys_poll.go",
"diff": "@@ -82,7 +82,7 @@ func doPoll(t *kernel.Task, pfdAddr usermem.Addr, nfds uint, timeout time.Durati\n}\nfunc doSelect(t *kernel.Task, nfds int, readFDs, writeF... | Go | Apache License 2.0 | google/gvisor | Fixing select call to not enforce RLIMIT_NOFILE.
Removing check to RLIMIT_NOFILE in select call.
Adding unit test to select suite to document behavior.
Moving setrlimit class from mlock to a util file for reuse.
Fixing flaky test based on comments from Jamie.
PiperOrigin-RevId: 228726131
Change-Id: Ie9dbe970bbf835ba2cca6e17eec7c2ee6fadf459 |
259,881 | 10.01.2019 17:15:33 | 28,800 | bde588ff05cad3591025a1e313eebe61cd82e421 | Define name earlier | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/build_defs.bzl",
"new_path": "test/syscalls/build_defs.bzl",
"diff": "@@ -13,6 +13,8 @@ def _syscall_test(test, shard_count, size, platform):\n# Prepend \"runsc\" to non-native platform names.\nfull_platform = platform if platform == \"native\" e... | Go | Apache License 2.0 | google/gvisor | Define name earlier
PiperOrigin-RevId: 228805981
Change-Id: I4f4c4a5d8de325dff38f6dfb92108fc848d823fd |
259,853 | 11.01.2019 10:31:21 | 28,800 | f8c8f241540fa79b47090ce4808c2c0cfbe44a12 | runsc: Collect zombies of sandbox and gofer processes
And we need to wait a gofer process before cgroup.Uninstall,
because it is running in the sandbox cgroups. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -119,6 +119,12 @@ type Container struct {\n// be 0 if the gofer has been killed.\nGoferPid int `json:\"goferPid\"`\n+ // goferIsChild is set if a gofer process is a child of... | Go | Apache License 2.0 | google/gvisor | runsc: Collect zombies of sandbox and gofer processes
And we need to wait a gofer process before cgroup.Uninstall,
because it is running in the sandbox cgroups.
PiperOrigin-RevId: 228904020
Change-Id: Iaf8826d5b9626db32d4057a1c505a8d7daaeb8f9 |
259,885 | 11.01.2019 14:47:14 | 28,800 | 290bcb6de9c4aeff65bbfa06b8addecdbc51ca88 | Require CAP_SYS_CHROOT in ChrootTest.ProcMountsMountinfoNoEscape. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/chroot.cc",
"new_path": "test/syscalls/linux/chroot.cc",
"diff": "@@ -280,6 +280,7 @@ TEST(ChrootTest, ProcMemSelfMapsNoEscapeProcOpen) {\n// /proc/self/mountinfo.\nTEST(ChrootTest, ProcMountsMountinfoNoEscape) {\nSKIP_IF(!ASSERT_NO_ERRNO_A... | Go | Apache License 2.0 | google/gvisor | Require CAP_SYS_CHROOT in ChrootTest.ProcMountsMountinfoNoEscape.
PiperOrigin-RevId: 228949227
Change-Id: I8f47bcd56aab706081218ec7498af8049ccd6d63 |
259,885 | 11.01.2019 14:47:45 | 28,800 | bf65e06c5f00eb41e40dfbb07dda31c6b7ae443e | Clean up some uses of fork() in tests.
Fix a few cases where async-signal-unsafe code is executed in a forked
process pre-execve.
Ensure that the return value of fork() is always checked. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1460,7 +1460,6 @@ cc_binary(\n\"//test/util:logging\",\n\"//test/util:multiprocess_util\",\n\"//test/util:signal_util\",\n- \"//test/util:test_main\",\n\"//test/util:test_util\",... | Go | Apache License 2.0 | google/gvisor | Clean up some uses of fork() in tests.
- Fix a few cases where async-signal-unsafe code is executed in a forked
process pre-execve.
- Ensure that the return value of fork() is always checked.
PiperOrigin-RevId: 228949310
Change-Id: I3096cb7d7394b8d9ab81b0e0245f2060713ef589 |
259,854 | 14.01.2019 13:06:16 | 28,800 | 003eedea1c66d3ff07b28accb46bbe9abfa8c89c | Deflake RecvLessThanBufferWaitAll. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_stream_blocking.cc",
"new_path": "test/syscalls/linux/socket_stream_blocking.cc",
"diff": "@@ -98,7 +98,10 @@ TEST_P(BlockingStreamSocketPairTest, RecvLessThanBuffer) {\nSyscallSucceedsWithValue(sizeof(sent_data)));\n}\n-TEST_P(Block... | Go | Apache License 2.0 | google/gvisor | Deflake RecvLessThanBufferWaitAll.
PiperOrigin-RevId: 229238781
Change-Id: Ib5a1e46293583efcb09e255fcd400c3fcc53ef1b |
259,948 | 14.01.2019 13:32:31 | 28,800 | 7182b9cf52087bc354104ad2a23fcf4c468ab20e | netstack: release port inline for listening sockets only. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -410,18 +410,18 @@ func (e *endpoint) Close() {\ne.mu.Lock()\n- // We always release ports inline so that they are immediately available\n- // for reuse after ... | Go | Apache License 2.0 | google/gvisor | netstack: release port inline for listening sockets only.
PiperOrigin-RevId: 229243918
Change-Id: Ie14ef34e66ae851ed080f57b7d26a369a66f7664 |
259,853 | 14.01.2019 14:07:05 | 28,800 | a46b6d453d198b96949342a81750114bfa5a5429 | runsc: set up a minimal chroot from the sandbox process
In this case, new mounts are not created in the host mount namspaces, so
tearDownChroot isn't needed, because chroot will be destroyed with a
sandbox mount namespace.
In additional, pivot_root can't be called instead of chroot. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/BUILD",
"new_path": "runsc/cmd/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_library(\n\"boot.go\",\n\"capability.go\",\n\"checkpoint.go\",\n+ \"chroot.go\",\n\"cmd.go\",\n\"create.go\",\n\"debug.go\",\n"
},
{
"change_type": "MODIFY",
"old_path": "... | Go | Apache License 2.0 | google/gvisor | runsc: set up a minimal chroot from the sandbox process
In this case, new mounts are not created in the host mount namspaces, so
tearDownChroot isn't needed, because chroot will be destroyed with a
sandbox mount namespace.
In additional, pivot_root can't be called instead of chroot.
PiperOrigin-RevId: 229250871
Change-Id: I765bdb587d0b8287a6a8efda8747639d37c7e7b6 |
259,853 | 14.01.2019 16:11:13 | 28,800 | 343ebe9789087b099ea7feae19879f5c24e59bf1 | Fix a few compilation warnings
test/syscalls/linux/wait.cc:626:8: warning: lambda capture 'this' is not
used
302
[this, stack] { ASSERT_THAT(FreeStack(stack), SyscallSucceeds()); });
303
^~~~~
test/syscalls/linux/priority.cc:195:17: warning: lambda capture
'kParentPriority' is not required to be captured for this use
273
ScopedThread([kParentPriority, kChildPriority]() {
274
^~~~~~~~~~~~~~~~ | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/priority.cc",
"new_path": "test/syscalls/linux/priority.cc",
"diff": "@@ -192,7 +192,7 @@ TEST(GetpriorityTest, CloneMaintainsPriority) {\nASSERT_THAT(setpriority(PRIO_PROCESS, getpid(), kParentPriority),\nSyscallSucceeds());\n- ScopedThrea... | Go | Apache License 2.0 | google/gvisor | Fix a few compilation warnings
test/syscalls/linux/wait.cc:626:8: warning: lambda capture 'this' is not
used
302
[this, stack] { ASSERT_THAT(FreeStack(stack), SyscallSucceeds()); });
303
^~~~~
test/syscalls/linux/priority.cc:195:17: warning: lambda capture
'kParentPriority' is not required to be captured for this use
273
ScopedThread([kParentPriority, kChildPriority]() {
274
^~~~~~~~~~~~~~~~
PiperOrigin-RevId: 229275900
Change-Id: I6f0c88efc7891c6c729378a2fa70f70b1b9046a7 |
259,944 | 15.01.2019 04:54:36 | 28,800 | c120d7ee2d46a93551075667a01a15bdec8ec1a9 | Use cni v0.7.0.
Use cni v0.7.0 in the integration test. | [
{
"change_type": "MODIFY",
"old_path": "test/e2e/containerd-install.sh",
"new_path": "test/e2e/containerd-install.sh",
"diff": "wget -q --https-only \\\nhttps://github.com/containerd/containerd/releases/download/v${CONTAINERD_VERSION}/containerd-${CONTAINERD_VERSION}.linux-amd64.tar.gz \\\n- https:/... | Go | Apache License 2.0 | google/gvisor | Use cni v0.7.0. (#11)
Use cni v0.7.0 in the integration test.
Signed-off-by: Lantao Liu <lantaol@google.com> |
259,944 | 15.01.2019 04:55:38 | 28,800 | f39907aa5d3d1b4ffb2dc0bb08954da1dea6f0b8 | Port containerd fix
Adds a timeout and cancel to shim fifo open | [
{
"change_type": "MODIFY",
"old_path": "pkg/proc/exec.go",
"new_path": "pkg/proc/exec.go",
"diff": "@@ -191,6 +191,12 @@ func (e *execProcess) start(ctx context.Context) (err error) {\ne.stdin = sc\n}\nvar copyWaitGroup sync.WaitGroup\n+ ctx, cancel := context.WithTimeout(ctx, 30*time.Second)\n+ def... | Go | Apache License 2.0 | google/gvisor | Port containerd fix https://github.com/containerd/containerd/pull/2877. (#12)
Adds a timeout and cancel to shim fifo open
Signed-off-by: Lantao Liu <lantaol@google.com> |
259,872 | 15.01.2019 11:14:59 | 28,800 | 6c117a01e97b5604dc474cf02269cf03fc797af8 | Set end of subslice as begin of next subslice
syscall test split testcase via shard count, reset
high bound as begin of next subslice, cause the slice
is half-open range. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/syscall_test_runner.go",
"new_path": "test/syscalls/syscall_test_runner.go",
"diff": "@@ -271,7 +271,8 @@ func main() {\n// Calculate subslice of tests to run.\nshardSize := int(math.Ceil(float64(len(testCases)) / float64(total)))\nbegin := index... | Go | Apache License 2.0 | google/gvisor | Set end of subslice as begin of next subslice
syscall test split testcase via shard count, reset
high bound as begin of next subslice, cause the slice
is half-open range.
Change-Id: I1954f57c93cbfd9be518153315da305a2de377a0
PiperOrigin-RevId: 229405199 |
259,992 | 15.01.2019 14:12:19 | 28,800 | 92cf3764e032740f0c84a1b242c54b99f45a6bf0 | Create working directory if it doesn't yet exist | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -1699,6 +1699,27 @@ func TestDestroyStarting(t *testing.T) {\n}\n}\n+func TestCreateWorkingDir(t *testing.T) {\n+ for _, conf := range configs(overlay) {\n+ t.Logf... | Go | Apache License 2.0 | google/gvisor | Create working directory if it doesn't yet exist
PiperOrigin-RevId: 229438125
Change-Id: I58eb0d10178d1adfc709d7b859189d1acbcb2f22 |
259,985 | 18.01.2019 10:01:08 | 28,800 | 8d7c10e90840cfecf53089e7cc3507cac2804fd1 | Display /proc/net entries for all network configurations.
Most of the entries are stubbed out at the moment, but even those were
only displayed if IPv6 support was enabled. The entries should be
displayed with IPv4-support only, and with only loopback devices. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -29,17 +29,16 @@ import (\n// newNet creates a new proc net entry.\nfunc (p *proc) newNetDir(ctx context.Context, msrc *fs.MountSource) *fs.Inode {\nvar contents map[string]*fs.In... | Go | Apache License 2.0 | google/gvisor | Display /proc/net entries for all network configurations.
Most of the entries are stubbed out at the moment, but even those were
only displayed if IPv6 support was enabled. The entries should be
displayed with IPv4-support only, and with only loopback devices.
PiperOrigin-RevId: 229946441
Change-Id: I18afaa3af386322787f91bf9d168ab66c01d5a4c |
259,853 | 18.01.2019 12:16:24 | 28,800 | c063a1350f4ac6249fb26e6125c9cc99db14263b | runsc: create a new proc mount if the sandbox process is running in a new pidns | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/boot.go",
"new_path": "runsc/cmd/boot.go",
"diff": "@@ -75,6 +75,9 @@ type Boot struct {\n// startSyncFD is the file descriptor to synchronize runsc and sandbox.\nstartSyncFD int\n+\n+ // pidns is set if the sanadbox is in its own pid namespace.\n+ p... | Go | Apache License 2.0 | google/gvisor | runsc: create a new proc mount if the sandbox process is running in a new pidns
PiperOrigin-RevId: 229971902
Change-Id: Ief4fac731e839ef092175908de9375d725eaa3aa |
259,853 | 18.01.2019 16:07:28 | 28,800 | c0a981629cf44688687548490c5e665d851afe06 | Start a sandbox process in a new userns only if CAP_SETUID is set
In addition, it fixes a race condition in TestMultiContainerGoferStop.
There are two scripts copy the same set of files into the same directory
and sometime one of this command fails with EXIST. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/multi_container_test.go",
"new_path": "runsc/container/multi_container_test.go",
"diff": "@@ -739,11 +739,6 @@ func TestMultiContainerGoferStop(t *testing.T) {\nt.Fatal(\"error finding test_app:\", err)\n}\n- dir, err := ioutil.TempDir(testutil... | Go | Apache License 2.0 | google/gvisor | Start a sandbox process in a new userns only if CAP_SETUID is set
In addition, it fixes a race condition in TestMultiContainerGoferStop.
There are two scripts copy the same set of files into the same directory
and sometime one of this command fails with EXIST.
PiperOrigin-RevId: 230011247
Change-Id: I9289f72e65dc407cdcd0e6cd632a509e01f43e9c |
259,853 | 22.01.2019 16:45:45 | 28,800 | 5f08f8fd8162fa2fc2ca7b862263081d8d07b206 | Don't bind-mount runsc into a sandbox mntns | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/boot.go",
"new_path": "runsc/cmd/boot.go",
"diff": "@@ -129,7 +129,6 @@ func (b *Boot) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\nFatalf(\"error setting up chroot: %v\", err)\n}\n- specutils.ExePath = \"/runsc\"\nif !b.applyCap... | Go | Apache License 2.0 | google/gvisor | Don't bind-mount runsc into a sandbox mntns
PiperOrigin-RevId: 230437407
Change-Id: Id9d8ceeb018aad2fe317407c78c6ee0f4b47aa2b |
259,853 | 23.01.2019 17:07:38 | 28,800 | af89fb49af1c9112753c718eb8538bcd9d2a6c6c | socket_netlink_route: ignore negative port ID values
netlink_autobind() sets a port id to a process ID, if this address is
available. Otherwise, it will set a port id to a random negative value. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_netlink_route.cc",
"new_path": "test/syscalls/linux/socket_netlink_route.cc",
"diff": "#include <linux/rtnetlink.h>\n#include <sys/socket.h>\n#include <sys/types.h>\n+#include <unistd.h>\n#include <vector>\n#include \"gtest/gtest.h\"... | Go | Apache License 2.0 | google/gvisor | socket_netlink_route: ignore negative port ID values
netlink_autobind() sets a port id to a process ID, if this address is
available. Otherwise, it will set a port id to a random negative value.
PiperOrigin-RevId: 230631956
Change-Id: I11692e4fe9421e77d9406627b4e7772e4d9b105a |
259,881 | 23.01.2019 18:23:39 | 28,800 | 74f5100a92854bb244f560847cd8f459a8a06688 | Fix cases of missing braces on if | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -261,7 +261,9 @@ TEST_P(SocketInetReusePortTest, TcpPortReuseMultiThread) {\nASSERT_THAT(listen(fd, 40), SyscallSucceeds());\n// On the first b... | Go | Apache License 2.0 | google/gvisor | Fix cases of missing braces on if
PiperOrigin-RevId: 230641540
Change-Id: Icccc3cdeec191138940f0ecea0a29798359d2b1f |
259,992 | 24.01.2019 14:19:07 | 28,800 | 01679f3b5ab957c274690a62f0fce5d332ee94af | Increase gofer coverage in tests
Lots of tests use /tmp for the tests. Force /tmp to be
mounted over fsgofer instead of tmpfs. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -42,6 +42,7 @@ syscall_test(test = \"//test/syscalls/linux:chmod_test\")\nsyscall_test(\nsize = \"medium\",\ntest = \"//test/syscalls/linux:chown_test\",\n+ use_tmpfs = True, # chwon tests re... | Go | Apache License 2.0 | google/gvisor | Increase gofer coverage in tests
Lots of tests use /tmp for the tests. Force /tmp to be
mounted over fsgofer instead of tmpfs.
PiperOrigin-RevId: 230788985
Change-Id: Id6597ed88133232d15e808c48126bf77cb32673e |
259,858 | 24.01.2019 17:01:20 | 28,800 | b5088ba59c4b6e6fe19a38e15a5472d36f80b397 | cleanup: extract the kernel from context | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ashmem/BUILD",
"new_path": "pkg/sentry/fs/ashmem/BUILD",
"diff": "@@ -21,7 +21,6 @@ go_library(\n\"//pkg/sentry/fs\",\n\"//pkg/sentry/fs/fsutil\",\n\"//pkg/sentry/fs/tmpfs\",\n- \"//pkg/sentry/kernel\",\n\"//pkg/sentry/kernel/time\",\n\"//pkg/sen... | Go | Apache License 2.0 | google/gvisor | cleanup: extract the kernel from context
Change-Id: I94704a90beebb53164325e0cce1fcb9a0b97d65c
PiperOrigin-RevId: 230817308 |
259,992 | 24.01.2019 22:41:28 | 28,800 | cc995207531965b70bc1b812a70b91f242a92086 | Add runsc logs to test results | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/syscall_test_runner.go",
"new_path": "test/syscalls/syscall_test_runner.go",
"diff": "@@ -168,6 +168,10 @@ func runTestCaseRunsc(testBin string, tc gtest.TestCase, t *testing.T) {\nif *strace {\nargs = append(args, \"-strace\")\n}\n+ if outDir, o... | Go | Apache License 2.0 | google/gvisor | Add runsc logs to test results
PiperOrigin-RevId: 230850177
Change-Id: I34eb24e8ff8dd9ce3e7f5eb2dc2ee58eeac49f07 |
259,992 | 25.01.2019 14:38:10 | 28,800 | c28f886c0bb0ff996e07fc133e0ebe1d842b496a | Execute statically linked binary
Mounting lib and lib64 are not necessary anymore and simplifies the test. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/BUILD",
"new_path": "runsc/container/BUILD",
"diff": "@@ -65,7 +65,9 @@ go_test(\ngo_binary(\nname = \"test_app\",\n+ testonly = 1,\nsrcs = [\"test_app.go\"],\n+ pure = \"on\",\ndeps = [\n\"//runsc/test/testutil\",\n\"@com_github_google_subcomm... | Go | Apache License 2.0 | google/gvisor | Execute statically linked binary
Mounting lib and lib64 are not necessary anymore and simplifies the test.
PiperOrigin-RevId: 230971195
Change-Id: Ib91a3ffcec4b322cd3687c337eedbde9641685ed |
259,885 | 25.01.2019 22:37:41 | 28,800 | a8b8e13154fe39396b9139e8409cb822bbe0a68a | Deflake socket_stream_blocking tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_stream_blocking.cc",
"new_path": "test/syscalls/linux/socket_stream_blocking.cc",
"diff": "@@ -62,12 +62,14 @@ TEST_P(BlockingStreamSocketPairTest, BlockPartialWriteClosed) {\n});\n// Leave time for write to become blocked.\n- absl::... | Go | Apache License 2.0 | google/gvisor | Deflake socket_stream_blocking tests.
PiperOrigin-RevId: 231020482
Change-Id: Idd9168678b18d03aac473adcc40902e27e06d0a1 |
259,885 | 28.01.2019 10:59:01 | 28,800 | 1cedccf8e9b63757c182477f803afcb27bd9e17e | Drop the one-page limit for /proc/[pid]/{cmdline,environ}.
It never actually should have applied to environ (the relevant change in
Linux 4.2 is "proc: fix PAGE_SIZE limit of
/proc/$PID/cmdline"), and we claim to be Linux 4.4 now anyway. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/exec_args.go",
"new_path": "pkg/sentry/fs/proc/exec_args.go",
"diff": "@@ -101,12 +101,6 @@ func (f *execArgFile) Read(ctx context.Context, _ *fs.File, dst usermem.IOSequen\nreturn 0, syserror.EINVAL\n}\n- // N.B. Linux 4.2 eliminates the ar... | Go | Apache License 2.0 | google/gvisor | Drop the one-page limit for /proc/[pid]/{cmdline,environ}.
It never actually should have applied to environ (the relevant change in
Linux 4.2 is c2c0bb44620d "proc: fix PAGE_SIZE limit of
/proc/$PID/cmdline"), and we claim to be Linux 4.4 now anyway.
PiperOrigin-RevId: 231250661
Change-Id: I37f9c4280a533d1bcb3eebb7803373ac3c7b9f15 |
259,948 | 28.01.2019 11:57:45 | 28,800 | 196e9f9d82287e30380414f9a47a12c3cda56e41 | Convert outdated TODO to NOTE. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/sigprocmask.cc",
"new_path": "test/syscalls/linux/sigprocmask.cc",
"diff": "@@ -232,7 +232,7 @@ TEST_F(SigProcMaskTest, SignalHandler) {\nEXPECT_THAT(raw_sigprocmask(SIG_UNBLOCK, &mask, nullptr), SyscallSucceeds());\n// Check that the unblo... | Go | Apache License 2.0 | google/gvisor | Convert outdated TODO to NOTE.
PiperOrigin-RevId: 231263193
Change-Id: Ib732c9639462f7994d473050495d88c2855434af |
259,885 | 28.01.2019 13:02:04 | 28,800 | 9114471a5a5428bd8858d291811249314473d12d | Remove obsolete gVisor-specific test condition. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/sigprocmask.cc",
"new_path": "test/syscalls/linux/sigprocmask.cc",
"diff": "@@ -232,10 +232,7 @@ TEST_F(SigProcMaskTest, SignalHandler) {\nEXPECT_THAT(raw_sigprocmask(SIG_UNBLOCK, &mask, nullptr), SyscallSucceeds());\n// Check that the unbl... | Go | Apache License 2.0 | google/gvisor | Remove obsolete gVisor-specific test condition.
PiperOrigin-RevId: 231274510
Change-Id: I8f65157dbe18dae1c6235147fc4d27e0c844c833 |
259,948 | 28.01.2019 15:33:09 | 28,800 | ae6e37df2abe450b30aba0908c212e9a1f81b84a | Convert TODO into FIXME. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -76,9 +76,7 @@ func newTaskDir(t *kernel.Task, msrc *fs.MountSource, pidns *kernel.PIDNamespace\n\"fd\": newFdDir(t, msrc),\n\"fdinfo\": newFdInfoDir(t, msrc),\n\"gid_map\": new... | Go | Apache License 2.0 | google/gvisor | Convert TODO into FIXME.
PiperOrigin-RevId: 231301228
Change-Id: I3e18f3a12a35fb89a22a8c981188268d5887dc61 |
259,962 | 29.01.2019 01:37:54 | 28,800 | 24cb2c0a7256cdb515c2fc2cfc90d130e2a405ef | Use recvmmsg() instead of readv() to read packets from NIC.
This should reduce the number of syscalls required to process packets
significantly and improve throughputs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/BUILD",
"new_path": "pkg/tcpip/link/fdbased/BUILD",
"diff": "@@ -27,6 +27,7 @@ go_test(\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/header\",\n+ \"//pkg/tcpip/link/rawfile\",\n\"//pkg/tcpip/stack\",\n],\n)\n"
},
{
"... | Go | Apache License 2.0 | google/gvisor | Use recvmmsg() instead of readv() to read packets from NIC.
This should reduce the number of syscalls required to process packets
significantly and improve throughputs.
PiperOrigin-RevId: 231366886
Change-Id: I8b38077262bf9c53176bc4a94b530188d3d7c0ca |
259,885 | 29.01.2019 08:00:33 | 28,800 | 57c202ead2d937e40c5d10da409504ac474165d1 | Refactor out NewEventFD to a test utility. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -481,6 +481,7 @@ cc_binary(\nsrcs = [\"dup.cc\"],\nlinkstatic = 1,\ndeps = [\n+ \"//test/util:eventfd_util\",\n\"//test/util:file_descriptor\",\n\"//test/util:posix_error\",\n\"//... | Go | Apache License 2.0 | google/gvisor | Refactor out NewEventFD to a test utility.
PiperOrigin-RevId: 231404512
Change-Id: I31efcc23a0c4a48ef6fbba3ca07415d79290f55c |
259,885 | 29.01.2019 09:05:51 | 28,800 | 3c5f8dfd4b0a7157343bacb62620e4f11612c3b7 | Don't assume that stdout is always writable in PollTest.Nfds.
stdout can be (and, in automated testing, often is) a host pipe or
similar resource shared between multiple parallel tests, such that it
can become transiently full during testing. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1246,6 +1246,7 @@ cc_binary(\nlinkstatic = 1,\ndeps = [\n\":base_poll_test\",\n+ \"//test/util:eventfd_util\",\n\"//test/util:file_descriptor\",\n\"//test/util:logging\",\n\"//te... | Go | Apache License 2.0 | google/gvisor | Don't assume that stdout is always writable in PollTest.Nfds.
stdout can be (and, in automated testing, often is) a host pipe or
similar resource shared between multiple parallel tests, such that it
can become transiently full during testing.
PiperOrigin-RevId: 231413569
Change-Id: Id14991b5f71e53c894695899e65e1be4dd228cc6 |
259,854 | 29.01.2019 16:22:34 | 28,800 | ff1c3bb0b577a4ea55a64de39415a8d31142b741 | Fix NIC endpoint forwarding.
Also adds a test for regular NIC forwarding. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -43,6 +43,7 @@ go_test(\n\"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/link/channel\",\n+ \"//pkg/tcpip/link/loopback\",\n\"//pkg/waiter\",\n],\n)\n"
},
{
"chang... | Go | Apache License 2.0 | google/gvisor | Fix NIC endpoint forwarding.
Also adds a test for regular NIC forwarding.
PiperOrigin-RevId: 231495279
Change-Id: Ic7edec249568e9ad0280cea77eac14478c9073e1 |
259,853 | 29.01.2019 17:14:26 | 28,800 | dd577f5410a90d31a927b7b0fd6c4bb32b34b9f9 | runsc: reap a sandbox process only in sandbox.Wait() | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -235,7 +235,7 @@ func (cm *containerManager) Start(args *StartArgs, _ *struct{}) error {\nerr := cm.l.startContainer(cm.l.k, args.Spec, args.Conf, args.CID, args.FilePayload.Files)\... | Go | Apache License 2.0 | google/gvisor | runsc: reap a sandbox process only in sandbox.Wait()
PiperOrigin-RevId: 231504064
Change-Id: I585b769aef04a3ad7e7936027958910a6eed9c8d |
259,974 | 30.01.2019 11:48:02 | 28,800 | cedff8d3aef3bc2055b1a7c3ad47a4c8297367ea | Add muldiv/rd_tsc support for arm64 platform. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/time/BUILD",
"new_path": "pkg/sentry/time/BUILD",
"diff": "load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\n-package(licenses = [\"notice\"]) # Apache 2.0\n+package(licenses = [\"notice\"]) # Apache 2.0, portions BSD\nload(\"//to... | Go | Apache License 2.0 | google/gvisor | Add muldiv/rd_tsc support for arm64 platform.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: If35459be78e023346a140184401172f8e023c7f9
PiperOrigin-RevId: 231638020 |
259,853 | 31.01.2019 10:33:09 | 28,800 | 7e8a56087bfb4ab89e058cd9f9d2459a06275559 | runsc: check whether a container is deleted or not before setupContainerFS | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -430,6 +430,15 @@ func (l *Loader) run() error {\n}\n}\n+ l.mu.Lock()\n+ defer l.mu.Unlock()\n+\n+ eid := execID{cid: l.sandboxID}\n+ ep, ok := l.processes[eid]\n+ if !ok {\n+ return fmt.Er... | Go | Apache License 2.0 | google/gvisor | runsc: check whether a container is deleted or not before setupContainerFS
PiperOrigin-RevId: 231811387
Change-Id: Ib143fb9a4d0fa1f105d1a3a3bd533dfc44e792af |
259,992 | 31.01.2019 11:29:55 | 28,800 | f1c1ee8a8ea6c0035aa799af3d7f5733fa2275d0 | Don't mask out sticky bit to/from gofer
RELNOTES: sticky bit propagates to gofers now. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/buffer.go",
"new_path": "pkg/p9/buffer.go",
"diff": "@@ -144,7 +144,7 @@ func (b *buffer) ReadGID() GID {\n// ReadPermissions reads a file mode value and applies the mask for permissions.\nfunc (b *buffer) ReadPermissions() FileMode {\n- return b.ReadFi... | Go | Apache License 2.0 | google/gvisor | Don't mask out sticky bit to/from gofer
RELNOTES: sticky bit propagates to gofers now.
PiperOrigin-RevId: 231822453
Change-Id: I73426170b9457350480a3b144a2baf937e7cb477 |
259,992 | 31.01.2019 12:53:00 | 28,800 | a497f5ed5f97e4ad49ed60dd46f0146ae45eefd6 | Invalidate COW mappings when file is truncated
This changed required making fsutil.HostMappable use
a backing file to ensure the correct FD would be used
for read/write operations.
RELNOTES: relnotes is needed for the parent CL. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/BUILD",
"new_path": "pkg/sentry/fs/fsutil/BUILD",
"diff": "@@ -71,7 +71,6 @@ go_library(\n\"host_file_mapper_state.go\",\n\"host_file_mapper_unsafe.go\",\n\"host_mappable.go\",\n- \"host_mappable_state.go\",\n\"inode.go\",\n\"inode_cached.... | Go | Apache License 2.0 | google/gvisor | Invalidate COW mappings when file is truncated
This changed required making fsutil.HostMappable use
a backing file to ensure the correct FD would be used
for read/write operations.
RELNOTES: relnotes is needed for the parent CL.
PiperOrigin-RevId: 231836164
Change-Id: I8ae9639715529874ea7d80a65e2c711a5b4ce254 |
259,992 | 31.01.2019 14:36:52 | 28,800 | aec5b67c8116035fca8b8c560debe66b04b788a7 | Add syscall test dimension for --file_access=shared | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/build_defs.bzl",
"new_path": "test/syscalls/build_defs.bzl",
"diff": "@@ -6,18 +6,22 @@ def syscall_test(test, shard_count = 5, size = \"small\", use_tmpfs = False):\n_syscall_test(test, shard_count, size, \"native\", False)\n_syscall_test(test, ... | Go | Apache License 2.0 | google/gvisor | Add syscall test dimension for --file_access=shared
PiperOrigin-RevId: 231856279
Change-Id: I175db87374890a62a3a3c2ddef727668ff854ce4 |
259,853 | 31.01.2019 15:17:50 | 28,800 | 4e695adcd0c739101c3d50431ca18b1b911c9238 | gvisor/gofer: Use pivot_root instead of chroot | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/chroot.go",
"new_path": "runsc/cmd/chroot.go",
"diff": "@@ -36,6 +36,29 @@ func mountInChroot(chroot, src, dst, typ string, flags uint32) error {\nreturn nil\n}\n+func pivotRoot(root string) error {\n+ if err := os.Chdir(root); err != nil {\n+ return... | Go | Apache License 2.0 | google/gvisor | gvisor/gofer: Use pivot_root instead of chroot
PiperOrigin-RevId: 231864273
Change-Id: I8545b72b615f5c2945df374b801b80be64ec3e13 |
259,853 | 01.02.2019 18:12:12 | 28,800 | 4f5fd311dca3eccd7a3bc8aaf19ed11d6755ee0a | gvisor/test: Remove gtest shard env variables | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/syscall_test_runner.go",
"new_path": "test/syscalls/syscall_test_runner.go",
"diff": "@@ -83,7 +83,7 @@ func runTestCaseNative(testBin string, tc gtest.TestCase, t *testing.T) {\n// Remove shard env variables so that the gunit binary does not try... | Go | Apache License 2.0 | google/gvisor | gvisor/test: Remove gtest shard env variables
PiperOrigin-RevId: 232071420
Change-Id: I5aa57f3dc4aac637d6f467445b4b3110fc08ac80 |
259,891 | 04.02.2019 16:34:37 | 28,800 | 3eae03fe4f2813dc56d6e33cd7feb7760fccfb25 | Deflake unlink test.
Multiple tests were creating the same directory before removing it, making it
possible for concurrent tests to fail because the directory already exists. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/unlink.cc",
"new_path": "test/syscalls/linux/unlink.cc",
"diff": "@@ -47,19 +47,20 @@ TEST(UnlinkTest, DirNotEmpty) {\n}\nTEST(UnlinkTest, Rmdir) {\n- std::string path = JoinPath(GetAbsoluteTestTmpdir(), \"NewDir\");\n- ASSERT_THAT(mkdir(pa... | Go | Apache License 2.0 | google/gvisor | Deflake unlink test.
Multiple tests were creating the same directory before removing it, making it
possible for concurrent tests to fail because the directory already exists.
PiperOrigin-RevId: 232389814
Change-Id: I35d409fff4b3fd864b30fee742cb587b14975c23 |
259,975 | 05.02.2019 10:00:22 | 28,800 | 0cf7fc4e115c2dcc40901c44b238ab36b5d966fc | Change /proc/PID/cmdline to read environment vector.
Change proc to return envp on overwrite of argv with limitations from
upstream.
Add unit tests
Change layout of argv/envp on the stack so that end of argv is contiguous with
beginning of envp. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/stack.go",
"new_path": "pkg/sentry/arch/stack.go",
"diff": "@@ -170,6 +170,24 @@ func (s *Stack) Load(args []string, env []string, aux Auxv) (StackLayout, error)\n// Make sure we start with a 16-byte alignment.\ns.Align(16)\n+ // Push the envir... | Go | Apache License 2.0 | google/gvisor | Change /proc/PID/cmdline to read environment vector.
- Change proc to return envp on overwrite of argv with limitations from
upstream.
- Add unit tests
- Change layout of argv/envp on the stack so that end of argv is contiguous with
beginning of envp.
PiperOrigin-RevId: 232506107
Change-Id: I993880499ab2c1220f6dc456a922235c49304dec |
259,992 | 07.02.2019 11:40:45 | 28,800 | 9ef3427ac14a84002497f3c8bac346486cb36f2b | Implement semctl(2) SETALL and GETALL | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "package semaphore\nimport (\n+ \"fmt\"\n\"sync\"\n\"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n@@ -75,6 +76,9 @@ type Set struct {\nperms fs.FilePe... | Go | Apache License 2.0 | google/gvisor | Implement semctl(2) SETALL and GETALL
PiperOrigin-RevId: 232914984
Change-Id: Id2643d7ad8e986ca9be76d860788a71db2674cda |
259,985 | 07.02.2019 14:43:18 | 28,800 | 2ba74f84be8b9d3d588fb834414d151607799fd3 | Implement /proc/net/unix. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -191,6 +191,15 @@ const (\nSO_TXTIME = 61\n)\n+// enum socket_state, from uapi/linux/net.h.\n+const (\n+ SS_FREE = 0 // Not allocated.\n+ SS_UNCONNECTED = 1 // Unconnected to any sock... | Go | Apache License 2.0 | google/gvisor | Implement /proc/net/unix.
PiperOrigin-RevId: 232948478
Change-Id: Ib830121e5e79afaf5d38d17aeef5a1ef97913d23 |
259,853 | 07.02.2019 19:31:50 | 28,800 | fda4d1f4f11201c34bd15d41ba4c94279d135d95 | gvisor/tests: save runsc logs for each container in a separate directory | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/syscall_test_runner.go",
"new_path": "test/syscalls/syscall_test_runner.go",
"diff": "@@ -171,7 +171,13 @@ func runTestCaseRunsc(testBin string, tc gtest.TestCase, t *testing.T) {\nargs = append(args, \"-strace\")\n}\nif outDir, ok := syscall.Get... | Go | Apache License 2.0 | google/gvisor | gvisor/tests: save runsc logs for each container in a separate directory
PiperOrigin-RevId: 232990964
Change-Id: Icfa426d5e83c7d3e56b0b92e6a9e1229bcb8361b |
259,854 | 07.02.2019 23:14:06 | 28,800 | 80f901b16b8bb8fe397cc44578035173f5155b24 | Plumb IP_ADD_MEMBERSHIP and IP_DROP_MEMBERSHIP to netstack.
Also includes a few fixes for IPv4 multicast support. IPv6 support is coming in
a followup CL. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -204,15 +204,30 @@ const (\n// uapi/linux/socket.h.\nconst SockAddrMax = 128\n-// SockAddrInt is struct sockaddr_in, from uapi/linux/in.h.\n+// InetAddr is struct in_addr, from uapi/l... | Go | Apache License 2.0 | google/gvisor | Plumb IP_ADD_MEMBERSHIP and IP_DROP_MEMBERSHIP to netstack.
Also includes a few fixes for IPv4 multicast support. IPv6 support is coming in
a followup CL.
PiperOrigin-RevId: 233008638
Change-Id: If7dae6222fef43fda48033f0292af77832d95e82 |
259,956 | 08.02.2019 10:50:14 | 28,800 | 5079b38a9af1d66ad720005d7487dd711a0cb713 | Keep FilePayloads open on server side until after RPC completed.
Prevents URPC FDs from being closed mid-call, especially if they
are used as raw FDs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/fd/fd.go",
"new_path": "pkg/fd/fd.go",
"diff": "@@ -158,6 +158,9 @@ func New(fd int) *FD {\n// The returned FD is always blocking (Go 1.9+).\nfunc NewFromFile(file *os.File) (*FD, error) {\nfd, err := syscall.Dup(int(file.Fd()))\n+ // Technically, the runt... | Go | Apache License 2.0 | google/gvisor | Keep FilePayloads open on server side until after RPC completed.
Prevents URPC FDs from being closed mid-call, especially if they
are used as raw FDs.
PiperOrigin-RevId: 233087955
Change-Id: I815a2ff32cc5f03774605aef0b35a32862f8e633 |
259,854 | 08.02.2019 18:22:31 | 28,800 | 85d53d81d9f544277e3e86f83558cbc008ff7adb | Use socket address functions in unbound IPv4 UDP tests.
Also switch to the correct casing style for local address variables. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -69,67 +69,6 @@ PosixError SetAddrPort(int family, sockaddr_storage* addr, uint16_t port) {\n}\n}\n-struct TestAddress {\n- std::string descrip... | Go | Apache License 2.0 | google/gvisor | Use socket address functions in unbound IPv4 UDP tests.
Also switch to the correct casing style for local address variables.
PiperOrigin-RevId: 233161128
Change-Id: Ibc4a10a5d3ab04c40907aa885e8237b255c65a79 |
259,853 | 11.02.2019 12:42:20 | 28,800 | ecce96bab56de3aedd7d5cf47a6981f0f56acba1 | gvisor: Run syscall tests in kokoro on the rbe cluster | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc_rbe",
"new_path": ".bazelrc_rbe",
"diff": "@@ -51,10 +51,10 @@ build:remote --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1\n# \"extra_toolchains\" to be selected (given constraints defined in\n# \"exec_compatible_with\").\n# More about platforms: ht... | Go | Apache License 2.0 | google/gvisor | gvisor: Run syscall tests in kokoro on the rbe cluster
PiperOrigin-RevId: 233458853
Change-Id: I92c734b8075aa31e040fe7b4770bcf608e271e7a |
259,853 | 11.02.2019 18:04:29 | 28,800 | 3ff9dc9cc1f69605f9e9e3c028d81957c37349a3 | gvisor: check that ptrace properly handles int3 | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/ptrace.cc",
"new_path": "test/syscalls/linux/ptrace.cc",
"diff": "@@ -809,6 +809,44 @@ TEST(PtraceTest,\n// These tests requires knowledge of architecture-specific syscall convention.\n#ifdef __x86_64__\n+TEST(PtraceTest, Int3) {\n+ switch ... | Go | Apache License 2.0 | google/gvisor | gvisor: check that ptrace properly handles int3
PiperOrigin-RevId: 233516412
Change-Id: I7a0f1443de7eeebb5d8ad59e4759ca2e036a3c4d |
259,881 | 13.02.2019 11:58:49 | 28,800 | 2c7488454e7fcbf98c00bcdceb70cb8e2fa98c96 | Expose XSAVES in /proc/cpuinfo
Linux started doing this in
("x86/fpu/xstate: Re-enable XSAVES"), which first appeared in 4.8. | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid.go",
"new_path": "pkg/cpuid/cpuid.go",
"diff": "@@ -361,6 +361,7 @@ var x86FeatureStrings = map[Feature]string{\nX86FeatureXSAVEOPT: \"xsaveopt\",\nX86FeatureXSAVEC: \"xsavec\",\nX86FeatureXGETBV1: \"xgetbv1\",\n+ X86FeatureXSAVES: \"xsaves\",\... | Go | Apache License 2.0 | google/gvisor | Expose XSAVES in /proc/cpuinfo
Linux started doing this in b8be15d588060a03569ac85dc4a0247460988f5b
("x86/fpu/xstate: Re-enable XSAVES"), which first appeared in 4.8.
PiperOrigin-RevId: 233800931
Change-Id: Icac2c2b03ccf1a91f3070431efb5152ca619fca3 |
259,885 | 13.02.2019 14:24:23 | 28,800 | 0e84ae72e086c77cea066000a898b7bc951ba790 | Improve safecopy sanity checks.
Fix CopyIn/CopyOut/ZeroOut range checks.
Include the faulting signal number in the panic message. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/safecopy/safecopy_unsafe.go",
"new_path": "pkg/sentry/platform/safecopy/safecopy_unsafe.go",
"diff": "@@ -92,14 +92,14 @@ func CopyIn(dst []byte, src unsafe.Pointer) (int, error) {\nreturn len(dst), nil\n}\n- if faultN, srcN := uintptr(faul... | Go | Apache License 2.0 | google/gvisor | Improve safecopy sanity checks.
- Fix CopyIn/CopyOut/ZeroOut range checks.
- Include the faulting signal number in the panic message.
PiperOrigin-RevId: 233829501
Change-Id: I8959ead12d05dbd4cd63c2b908cddeb2a27eb513 |
259,853 | 13.02.2019 19:37:44 | 28,800 | cbd6b35c56011d6e2d75a68385bdc984fdf35317 | gvisor/kokoro: run apt-get update before apt-get install
We need to update the package lists, otherwise apt-get
install can request an old package which has been
removed from repositories. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -99,7 +99,8 @@ install_runtime() {\ninstall_crictl_test_deps() {\n# Install containerd.\n# libseccomp2 needs to be downgraded in order to install libseccomp-dev.\n- sudo -n -E apt-get install... | Go | Apache License 2.0 | google/gvisor | gvisor/kokoro: run apt-get update before apt-get install
We need to update the package lists, otherwise apt-get
install can request an old package which has been
removed from repositories.
PiperOrigin-RevId: 233879031
Change-Id: I2e1b3afd9d01008f774f10efd8852fd3f5e1c882 |
259,992 | 15.02.2019 08:22:26 | 28,800 | e34d27e8b6709809582eb0ad43c7232f2d5ab8ad | Redirect FIXME to more appropriate bug | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -1139,11 +1139,14 @@ func setSockOptIP(t *kernel.Task, ep commonEndpoint, name int, optVal []byte) *s\nMulticastAddr: tcpip.Address(req.MulticastAddr[:])... | Go | Apache License 2.0 | google/gvisor | Redirect FIXME to more appropriate bug
PiperOrigin-RevId: 234147487
Change-Id: I779a6012832bb94a6b89f5bcc7d821b40ae969cc |
259,891 | 15.02.2019 11:17:51 | 28,800 | a9cb3dcd9df373fb7a531476bf1da69fc9189e3a | Move SO_TIMESTAMP from different transport endpoints to epsocket.
SO_TIMESTAMP is reimplemented in ping and UDP sockets (and needs to be added for
TCP), but can just be implemented in epsocket for simplicity. This will also
make SIOCGSTAMP easier to implement. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -150,11 +150,24 @@ type SocketOperations struct {\nEndpoint tcpip.Endpoint\nskType transport.SockType\n- // readMu protects access to readView, control, ... | Go | Apache License 2.0 | google/gvisor | Move SO_TIMESTAMP from different transport endpoints to epsocket.
SO_TIMESTAMP is reimplemented in ping and UDP sockets (and needs to be added for
TCP), but can just be implemented in epsocket for simplicity. This will also
make SIOCGSTAMP easier to implement.
PiperOrigin-RevId: 234179300
Change-Id: Ib5ea0b1261dc218c1a8b15a65775de0050fe3230 |
259,854 | 15.02.2019 18:39:10 | 28,800 | c611dbc5a7399922588e3fd99b22bda19f684afe | Implement IP_MULTICAST_IF.
This allows setting a default send interface for IPv4 multicast. IPv6 support
will come later. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -27,7 +27,6 @@ package epsocket\nimport (\n\"bytes\"\n\"math\"\n- \"strings\"\n\"sync\"\n\"syscall\"\n\"time\"\n@@ -191,6 +190,15 @@ func New(t *kernel.T... | Go | Apache License 2.0 | google/gvisor | Implement IP_MULTICAST_IF.
This allows setting a default send interface for IPv4 multicast. IPv6 support
will come later.
PiperOrigin-RevId: 234251379
Change-Id: I65922341cd8b8880f690fae3eeb7ddfa47c8c173 |
259,885 | 19.02.2019 14:19:07 | 28,800 | bb47d8a545f82849f637c480459109e16be336cf | Fix clone(CLONE_NEWUSER).
Use new user namespace for namespace creation checks.
Ensure userns is never nil since it's used by other namespaces. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_clone.go",
"new_path": "pkg/sentry/kernel/task_clone.go",
"diff": "@@ -17,7 +17,6 @@ package kernel\nimport (\n\"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n\"gvisor.googlesource.com/gvisor/pkg/bpf\"\n- \"gvisor.googlesource.com/gvis... | Go | Apache License 2.0 | google/gvisor | Fix clone(CLONE_NEWUSER).
- Use new user namespace for namespace creation checks.
- Ensure userns is never nil since it's used by other namespaces.
PiperOrigin-RevId: 234673175
Change-Id: I4b9d9d1e63ce4e24362089793961a996f7540cd9 |
259,885 | 19.02.2019 15:48:39 | 28,800 | bed6f8534b1bedaad031682fe052b5a46d9cb3ee | Set rax to syscall number on SECCOMP_RET_TRAP. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/seccomp.go",
"new_path": "pkg/sentry/kernel/seccomp.go",
"diff": "@@ -75,6 +75,9 @@ func (t *Task) checkSeccompSyscall(sysno int32, args arch.SyscallArguments, ip u\n// portion of the return value will be passed as si_errno.\" -\n// Documenta... | Go | Apache License 2.0 | google/gvisor | Set rax to syscall number on SECCOMP_RET_TRAP.
PiperOrigin-RevId: 234690475
Change-Id: I1cbfb5aecd4697a4a26ec8524354aa8656cc3ba1 |
259,885 | 19.02.2019 15:52:47 | 28,800 | 2840f7c1b12c88f47f7c3c8df659ca436f5901b6 | Add p9.Sticky. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/p9.go",
"new_path": "pkg/p9/p9.go",
"diff": "@@ -139,8 +139,11 @@ const (\n// AllPermissions is a mask with rwx bits set for user, group and others.\nAllPermissions FileMode = 0777\n+ // Sticky is a mode bit indicating sticky directories.\n+ Sticky File... | Go | Apache License 2.0 | google/gvisor | Add p9.Sticky.
PiperOrigin-RevId: 234691125
Change-Id: I2a588153ded5a4fbed07bc2f0937a43ccfba791b |
259,891 | 19.02.2019 16:40:31 | 28,800 | ec2460b1890aa1dbf8bd84f11dbdb3758e2443b2 | netstack: Add SIOCGSTAMP support.
Ping sometimes uses this instead of SO_TIMESTAMP. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -157,15 +157,17 @@ type SocketOperations struct {\n// from Endpoint.\nreadCM tcpip.ControlMessages\nsender tcpip.FullAddress\n+\n// sockOptTimestamp corr... | Go | Apache License 2.0 | google/gvisor | netstack: Add SIOCGSTAMP support.
Ping sometimes uses this instead of SO_TIMESTAMP.
PiperOrigin-RevId: 234699590
Change-Id: Ibec9c34fa0d443a931557a2b1b1ecd83effe7765 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.