author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,974 | 20.02.2019 15:09:50 | 28,800 | 15d3189884c2e8050992381ff2a1f0521eae0ba2 | Make some ptrace commands x86-only | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -95,6 +95,8 @@ go_library(\n\"posixtimer.go\",\n\"process_group_list.go\",\n\"ptrace.go\",\n+ \"ptrace_amd64.go\",\n+ \"ptrace_arm64.go\",\n\"rseq.go\",\n\"seccomp.go\",\n\"seqatomic_... | Go | Apache License 2.0 | google/gvisor | Make some ptrace commands x86-only
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I9751f859332d433ca772d6b9733f5a5a64398ec7
PiperOrigin-RevId: 234877624 |
259,891 | 22.02.2019 13:33:49 | 28,800 | b75aa515044367094e762985a4b1a1f0580e3ad6 | Rename ping endpoints to icmp endpoints. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/BUILD",
"new_path": "pkg/tcpip/network/arp/BUILD",
"diff": "@@ -30,6 +30,6 @@ go_test(\n\"//pkg/tcpip/link/sniffer\",\n\"//pkg/tcpip/network/ipv4\",\n\"//pkg/tcpip/stack\",\n- \"//pkg/tcpip/transport/ping\",\n+ \"//pkg/tcpip/transport/icm... | Go | Apache License 2.0 | google/gvisor | Rename ping endpoints to icmp endpoints.
PiperOrigin-RevId: 235248572
Change-Id: I5b0538b6feb365a98712c2a2d56d856fe80a8a09 |
259,933 | 25.02.2019 10:01:25 | 28,800 | c14a1a161869804af5ae2f1f73fd8eeb135ff043 | Fix race condition in NIC.DeliverNetworkPacket
cl/234850781 introduced a race condition in NIC.DeliverNetworkPacket
by failing to hold a lock. This change fixes this regressesion by acquiring
a read lock before iterating through n.endpoints, and then releasing the lock
once iteration is complete. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -403,14 +403,19 @@ func (n *NIC) DeliverNetworkPacket(linkEP LinkEndpoint, remote, _ tcpip.LinkAddr\n// route to each IPv4 network endpoint and let each endpoint handle the\n// packet.\... | Go | Apache License 2.0 | google/gvisor | Fix race condition in NIC.DeliverNetworkPacket
cl/234850781 introduced a race condition in NIC.DeliverNetworkPacket
by failing to hold a lock. This change fixes this regressesion by acquiring
a read lock before iterating through n.endpoints, and then releasing the lock
once iteration is complete.
PiperOrigin-RevId: 235549770
Change-Id: Ib0133288be512d478cf759c3314dc95ec3205d4b |
259,992 | 25.02.2019 12:16:44 | 28,800 | 10426e0f31e427e90e69fee83f199ea521b8fe3d | Handle invalid offset in sendfile(2) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_file.go",
"new_path": "pkg/sentry/syscalls/linux/sys_file.go",
"diff": "@@ -2022,7 +2022,6 @@ func Sendfile(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysc\n}\n// Setup for sending data.\n- var offset uint64\nva... | Go | Apache License 2.0 | google/gvisor | Handle invalid offset in sendfile(2)
PiperOrigin-RevId: 235578698
Change-Id: I608ff5e25eac97f6e1bda058511c1f82b0e3b736 |
259,885 | 25.02.2019 13:02:56 | 28,800 | 41167e6c508240a127f96bfa519b909c16ee0933 | Don't call WalkGetAttr for walk(names=[]). | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/handlers.go",
"new_path": "pkg/p9/handlers.go",
"diff": "@@ -237,7 +237,7 @@ func (t *Tattach) handle(cs *connState) message {\n// We want the same traversal checks to apply on attach, so always\n// attach at the root and use the regular walk paths.\nna... | Go | Apache License 2.0 | google/gvisor | Don't call WalkGetAttr for walk(names=[]).
PiperOrigin-RevId: 235587729
Change-Id: I37074416b10a30ca3a00d11bcde338d8d979beaf |
259,992 | 25.02.2019 19:20:52 | 28,800 | 52a2abfca43cffdb9cafb91a4266dacf51525470 | Fix cgroup when path is relative
This can happen when 'docker run --cgroup-parent=' flag is set. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -161,20 +161,59 @@ func countCpuset(cpuset string) (int, error) {\nreturn count, nil\n}\n+// LoadPaths loads cgroup paths for given 'pid', may be set to 'self'.\n+func LoadPaths(pid str... | Go | Apache License 2.0 | google/gvisor | Fix cgroup when path is relative
This can happen when 'docker run --cgroup-parent=' flag is set.
PiperOrigin-RevId: 235645559
Change-Id: Ieea3ae66939abadab621053551bf7d62d412e7ee |
259,992 | 26.02.2019 09:32:20 | 28,800 | 23fe059761a470d7724b462ad8ead09356ec21b7 | Lazily allocate inotify map on inode | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode_inotify.go",
"new_path": "pkg/sentry/fs/inode_inotify.go",
"diff": "@@ -39,9 +39,7 @@ type Watches struct {\n}\nfunc newWatches() *Watches {\n- return &Watches{\n- ws: make(map[uint64]*Watch),\n- }\n+ return &Watches{}\n}\n// MarkUnlinked i... | Go | Apache License 2.0 | google/gvisor | Lazily allocate inotify map on inode
PiperOrigin-RevId: 235735865
Change-Id: I84223eb18eb51da1fa9768feaae80387ff6bfed0 |
259,940 | 26.02.2019 11:47:42 | 28,800 | a2b794b30dd952793f4d99a9423cef7efdc7843f | FPE_INTOVF (integer overflow) should be 2 refer to Linux. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"diff": "@@ -290,7 +290,7 @@ func (c *vCPU) SwitchToUser(switchOpts ring0.SwitchOpts, info *arch.SignalInfo)\ncase ring0.Overflow:\n*info = arch.SignalInfo{\nSig... | Go | Apache License 2.0 | google/gvisor | FPE_INTOVF (integer overflow) should be 2 refer to Linux.
Signed-off-by: Ruidong Cao <crdfrank@gmail.com>
Change-Id: I03f8ab25cf29257b31f145cf43304525a93f3300
PiperOrigin-RevId: 235763203 |
260,013 | 26.02.2019 15:46:39 | 28,800 | aeb7283a9106319db598a908708e80875fcb5c3d | Improve PosixErrorOr messages using gtest matchers.
There was a minor bug whth IsPosixErrorOkAndHoldsMatcher where
it wouldn't display the actual value contained. This fixes that
and adds a few other minor improvements. | [
{
"change_type": "MODIFY",
"old_path": "test/util/posix_error.cc",
"new_path": "test/util/posix_error.cc",
"diff": "@@ -74,15 +74,10 @@ bool PosixErrorIsMatcherCommonImpl::MatchAndExplain(\ninner_listener.Clear();\nif (!code_matcher_.MatchAndExplain(error.errno_value(), &inner_listener)) {\n- *resul... | Go | Apache License 2.0 | google/gvisor | Improve PosixErrorOr messages using gtest matchers.
There was a minor bug whth IsPosixErrorOkAndHoldsMatcher where
it wouldn't display the actual value contained. This fixes that
and adds a few other minor improvements.
PiperOrigin-RevId: 235809065
Change-Id: I487e5072e9569eb06104522963e9a1b34204daaf |
259,992 | 27.02.2019 10:05:46 | 28,800 | 6df212b831dcc3350b7677423ec7835ed40b3f22 | Don't log twice to debug log when --log isn't set | [
{
"change_type": "MODIFY",
"old_path": "runsc/main.go",
"new_path": "runsc/main.go",
"diff": "@@ -192,7 +192,13 @@ func main() {\ncmd.Fatalf(\"error dup'ing fd %d to stderr: %v\", f.Fd(), err)\n}\n+ if logFile == os.Stderr {\n+ // Suppress logging to stderr when debug log is enabled. Otherwise all\n... | Go | Apache License 2.0 | google/gvisor | Don't log twice to debug log when --log isn't set
PiperOrigin-RevId: 235940853
Change-Id: I9c5b4cf18b199fb74044a5edb131bfff59dec945 |
259,885 | 28.02.2019 13:13:38 | 28,800 | 05d721f9eec3ad0a430906b968a2876bf37c44a7 | Hold dataMu for writing in CachingInodeOperations.WriteOut.
fsutil.SyncDirtyAll mutates the DirtySet. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/inode_cached.go",
"new_path": "pkg/sentry/fs/fsutil/inode_cached.go",
"diff": "@@ -322,9 +322,9 @@ func (c *CachingInodeOperations) WriteOut(ctx context.Context, inode *fs.Inode)\nc.attrMu.Lock()\n// Write dirty pages back.\n- c.dataMu.RLo... | Go | Apache License 2.0 | google/gvisor | Hold dataMu for writing in CachingInodeOperations.WriteOut.
fsutil.SyncDirtyAll mutates the DirtySet.
PiperOrigin-RevId: 236183349
Change-Id: I7e809d5b406ac843407e61eff17d81259a819b4f |
259,992 | 28.02.2019 18:37:34 | 28,800 | 3b44377eda93137212e6e437b62dcb216566b858 | Fix "-c dbg" build break
Remove allocation from vCPU.die() to save stack space.
Closes | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -71,11 +71,13 @@ BAZEL_BUILD_RBE_FLAGS=(\n####################\nbuild_everything() {\n+ FLAVOR=\"${1}\"\n+\ncd ${WORKSPACE_DIR}\nbazel \\\n\"${BAZEL_RBE_FLAGS[@]}\" \\\nbuild \\\n- \"${BAZEL_... | Go | Apache License 2.0 | google/gvisor | Fix "-c dbg" build break
Remove allocation from vCPU.die() to save stack space.
Closes #131
PiperOrigin-RevId: 236238102
Change-Id: Iafca27a1a3a472d4cb11dcda9a2060e585139d11 |
259,992 | 01.03.2019 10:55:22 | 28,800 | 3dbd4a16f8ae4da967f69fd93870462d1b3554f5 | Add semctl(GETPID) syscall
Also added unimplemented notification for semctl(2)
commands. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/sem.go",
"new_path": "pkg/abi/linux/sem.go",
"diff": "@@ -29,6 +29,7 @@ const (\nconst (\nSEM_STAT = 18\nSEM_INFO = 19\n+ SEM_STAT_ANY = 20\n)\nconst SEM_UNDO = 0x1000\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/se... | Go | Apache License 2.0 | google/gvisor | Add semctl(GETPID) syscall
Also added unimplemented notification for semctl(2)
commands.
PiperOrigin-RevId: 236340672
Change-Id: I0795e3bd2e6d41d7936fabb731884df426a42478 |
259,881 | 01.03.2019 14:37:18 | 28,800 | 96226f9a473c0c55e0b632f9fbe883b078a234ea | Mark socket_ipv4_udp_unbound_loopback flaky
To do so, we must add the ability to add tags to the syscall tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -363,7 +363,11 @@ syscall_test(\ntest = \"//test/syscalls/linux:socket_ip_udp_loopback_test\",\n)\n-syscall_test(test = \"//test/syscalls/linux:socket_ipv4_udp_unbound_loopback_test\")\n+sysc... | Go | Apache License 2.0 | google/gvisor | Mark socket_ipv4_udp_unbound_loopback flaky
To do so, we must add the ability to add tags to the syscall tests.
PiperOrigin-RevId: 236380371
Change-Id: I76d15feb2700f20115b27aab362a88cebe8c7a6a |
259,858 | 01.03.2019 15:04:15 | 28,800 | d811c1016d090ea88a687bd9bef4951dc08b391d | ptrace: drop old FIXME
The globalPool uses a sync.Once mechanism for initialization,
and no cleanup is strictly required. It's not really feasible
to have the platform implement a full creation -> destruction
cycle (due to the way filters are assumed to be installed), so
drop the FIXME. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/ptrace.go",
"new_path": "pkg/sentry/platform/ptrace/ptrace.go",
"diff": "// The requested operation is performed in the traced subprocess thread\n// (e.g. set registers, execute, return).\n//\n-// FIXME: This package is currently slo... | Go | Apache License 2.0 | google/gvisor | ptrace: drop old FIXME
The globalPool uses a sync.Once mechanism for initialization,
and no cleanup is strictly required. It's not really feasible
to have the platform implement a full creation -> destruction
cycle (due to the way filters are assumed to be installed), so
drop the FIXME.
PiperOrigin-RevId: 236385278
Change-Id: I98ac660ed58cc688d8a07147d16074a3e8181314 |
259,881 | 05.03.2019 13:53:36 | 28,800 | bd46185e24e03b93ac551a5ddfffb06975f157c8 | Add NoRandomSave to tests with correctness DisableSave
Tests using DisableSave because a portion of the test is *incompatible*
with S/R clearly cannot use random S/R, as the saves may occur in the
DisableSave critical section.
Most such tests already have NoRandomSave. Add it to the rest. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/flock.cc",
"new_path": "test/syscalls/linux/flock.cc",
"diff": "@@ -431,7 +431,7 @@ TEST_F(FlockTest, TestDupFdFollowedByLock) {\n// NOTE: These blocking tests are not perfect. Unfortunantely it's very hard to\n// determine if a thread was ... | Go | Apache License 2.0 | google/gvisor | Add NoRandomSave to tests with correctness DisableSave
Tests using DisableSave because a portion of the test is *incompatible*
with S/R clearly cannot use random S/R, as the saves may occur in the
DisableSave critical section.
Most such tests already have NoRandomSave. Add it to the rest.
PiperOrigin-RevId: 236914708
Change-Id: Iee1cf044cfa7cb8d5aba21ddc130926218210c48 |
259,962 | 05.03.2019 16:40:40 | 28,800 | 1718fdd1a8e16f36433b069a0f5d88ea7bdb65f5 | Add new retransmissions and recovery related metrics. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -82,6 +82,12 @@ var Metrics = tcpip.Stats{\nSegmentsSent: mustCreateMetric(\"/netstack/tcp/segments_sent\", \"Number of TCP segments sent.\"),\nResetsSen... | Go | Apache License 2.0 | google/gvisor | Add new retransmissions and recovery related metrics.
PiperOrigin-RevId: 236945145
Change-Id: I051760d95154ea5574c8bb6aea526f488af5e07b |
259,992 | 05.03.2019 22:19:23 | 28,800 | fcba4e8f040ab4b40e04b9315d718d7e5aa44635 | Add uncaught signal message to the user log
This help troubleshoot cases where the container is killed and the
app logs don't show the reason. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -46,6 +46,7 @@ go_library(\n\"//pkg/sentry/fs/tty\",\n\"//pkg/sentry/inet\",\n\"//pkg/sentry/kernel\",\n+ \"//pkg/sentry/kernel:uncaught_signal_go_proto\",\n\"//pkg/sentry/kernel/auth\",\n\"//pkg/s... | Go | Apache License 2.0 | google/gvisor | Add uncaught signal message to the user log
This help troubleshoot cases where the container is killed and the
app logs don't show the reason.
PiperOrigin-RevId: 236982883
Change-Id: I361892856a146cea5b04abaa3aedbf805e123724 |
259,881 | 06.03.2019 12:54:45 | 28,800 | 54ac76c305935b12b78ab6b464111dd227acdcbf | Remove unsafe ScopedSigaction
ScopedSigaction is not async-signal-safe, so it cannot be used after fork.
Replace it with plain sigaction, which is safe. This is in a unique child
anyways, so it doesn't need any cleanup. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/kill.cc",
"new_path": "test/syscalls/linux/kill.cc",
"diff": "@@ -70,7 +70,8 @@ TEST(KillTest, CanKillAllPIDs) {\nsa.sa_sigaction = SigHandler;\nsigfillset(&sa.sa_mask);\nsa.sa_flags = SA_SIGINFO;\n- auto cleanup = ScopedSigaction(SIGWINCH,... | Go | Apache License 2.0 | google/gvisor | Remove unsafe ScopedSigaction
ScopedSigaction is not async-signal-safe, so it cannot be used after fork.
Replace it with plain sigaction, which is safe. This is in a unique child
anyways, so it doesn't need any cleanup.
PiperOrigin-RevId: 237102411
Change-Id: I5c6ea373bbac67b9c4db204ceb1db62d338d9178 |
259,881 | 06.03.2019 13:18:25 | 28,800 | cdd63375d39e92c6964df0487dcf7d8ff013c9e7 | Increase ipv4_udp_unbound_loopback size to medium
Now that tests aren't running in parallel, this test occassionally
takes too long and times out. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -364,6 +364,7 @@ syscall_test(\n)\nsyscall_test(\n+ size = \"medium\",\n# Multicast packets can be received by the wrong test if run in parallel.\nparallel = False,\ntest = \"//test/syscalls/... | Go | Apache License 2.0 | google/gvisor | Increase ipv4_udp_unbound_loopback size to medium
Now that tests aren't running in parallel, this test occassionally
takes too long and times out.
PiperOrigin-RevId: 237106971
Change-Id: I195a4b77315c9f5511c9e8ffadddb7aaa78beafd |
259,853 | 08.03.2019 13:32:37 | 28,800 | 832589cb076a638ca53076ebb66afb9fac4597d1 | Fix tests which fail in kokoro
* open_create_test_runsc_ptrace_shared doesn't expect the write access to /
* exec_test_runsc_ptrace_shared could not find /usr/share/zoneinfo/
* clock_gettime_test_runsc_ptrace_shared didn't expect that
a thread cpu time can be zero.
* affinity_test_runsc_ptrace_shared expected minimum 3 cpus | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -177,16 +177,10 @@ run_root_tests() {\n# Run syscall unit tests.\nrun_syscall_tests() {\ncd ${WORKSPACE_DIR}\n- # TODO: Exclude tests which fail.\nbazel \\\n\"${BAZEL_RBE_FLAGS[@]}\" \\\ntest... | Go | Apache License 2.0 | google/gvisor | Fix tests which fail in kokoro
* open_create_test_runsc_ptrace_shared doesn't expect the write access to /
* exec_test_runsc_ptrace_shared could not find /usr/share/zoneinfo/
* clock_gettime_test_runsc_ptrace_shared didn't expect that
a thread cpu time can be zero.
* affinity_test_runsc_ptrace_shared expected minimum 3 cpus
PiperOrigin-RevId: 237509429
Change-Id: I477937e5d2cdf3f8720836bfa972abd35d8220a3 |
259,944 | 08.03.2019 17:53:36 | 28,800 | b7015c1a46fbea47ad8e7985583b30bd918ddc4b | Put the gvisor user log into sandbox log directory. | [
{
"change_type": "MODIFY",
"old_path": "pkg/go-runsc/utils.go",
"new_path": "pkg/go-runsc/utils.go",
"diff": "@@ -39,18 +39,8 @@ func putBuf(b *bytes.Buffer) {\n}\n// FormatLogPath parses runsc config, and fill in %ID% in the log path.\n-// * For debug-log, it fills in the id in place;\n-// * For us... | Go | Apache License 2.0 | google/gvisor | Put the gvisor user log into sandbox log directory. (#17)
Signed-off-by: Lantao Liu <lantaol@google.com> |
259,854 | 08.03.2019 19:04:29 | 28,800 | 86036f979b34855f0c945056f908961ccb804c1e | Validate multicast addresses in multicast group operations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -459,6 +459,10 @@ func (e *endpoint) SetSockOpt(opt interface{}) *tcpip.Error {\ne.multicastAddr = addr\ncase tcpip.AddMembershipOption:\n+ if !header.IsV4Mult... | Go | Apache License 2.0 | google/gvisor | Validate multicast addresses in multicast group operations.
PiperOrigin-RevId: 237559843
Change-Id: I93a9d83a08cd3d49d5fc7fcad5b0710d0aa04aaa |
259,854 | 08.03.2019 20:26:55 | 28,800 | 281092e842445cfb9ff474aae81c169954b469cb | Make IP_MULTICAST_LOOP and IP_MULTICAST_TTL allow setting int or char.
This is the correct Linux behavior, and at least PHP depends on it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -1193,24 +1193,30 @@ func copyInMulticastRequest(optVal []byte) (linux.InetMulticastRequestWithNIC, *\nreturn req, nil\n}\n-// reduceToByte ORs all of th... | Go | Apache License 2.0 | google/gvisor | Make IP_MULTICAST_LOOP and IP_MULTICAST_TTL allow setting int or char.
This is the correct Linux behavior, and at least PHP depends on it.
PiperOrigin-RevId: 237565639
Change-Id: I931af09c8ed99a842cf70d22bfe0b65e330c4137 |
259,854 | 09.03.2019 11:39:41 | 28,800 | 71d53382bfb3a6f05e90e31df8f39d22c0131040 | Fix getsockopt(IP_MULTICAST_IF).
getsockopt(IP_MULTICAST_IF) only supports struct in_addr.
Also adds support for setsockopt(IP_MULTICAST_IF) with struct in_addr. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -888,7 +888,7 @@ func getSockOptIP(t *kernel.Task, ep commonEndpoint, name, outLen int) (interfac\nreturn int32(v), nil\ncase linux.IP_MULTICAST_IF:\n- i... | Go | Apache License 2.0 | google/gvisor | Fix getsockopt(IP_MULTICAST_IF).
getsockopt(IP_MULTICAST_IF) only supports struct in_addr.
Also adds support for setsockopt(IP_MULTICAST_IF) with struct in_addr.
PiperOrigin-RevId: 237620230
Change-Id: I75e7b5b3e08972164eb1906f43ddd67aedffc27c |
259,992 | 11.03.2019 11:46:18 | 25,200 | bc9b979b9412ad5852872c1a9bee462f73d2455e | Add profiling commands to runsc
Example:
runsc debug --root=<dir> \
--profile-heap=/tmp/heap.prof \
--profile-cpu=/tmp/cpu.prod --profile-delay=30 \
<container ID> | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp.go",
"new_path": "pkg/seccomp/seccomp.go",
"diff": "@@ -55,7 +55,7 @@ func Install(rules SyscallRules) error {\n}\n// Uncomment to get stack trace when there is a violation.\n- // defaultAction = uint32(linux.SECCOMP_RET_TRAP)\n+ // default... | Go | Apache License 2.0 | google/gvisor | Add profiling commands to runsc
Example:
runsc debug --root=<dir> \
--profile-heap=/tmp/heap.prof \
--profile-cpu=/tmp/cpu.prod --profile-delay=30 \
<container ID>
PiperOrigin-RevId: 237848456
Change-Id: Icff3f20c1b157a84d0922599eaea327320dad773 |
259,853 | 11.03.2019 17:00:48 | 25,200 | 4a8062990f33f33b3972feb0a7f2abe55bae16c7 | gvisor/kokoro: don't downgrade libseccomp
It isn't required with a new vm image. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -44,6 +44,9 @@ use_bazel.sh latest\nwhich bazel\nbazel version\n+# Load the kvm module\n+sudo -n -E modprobe kvm\n+\n# Bazel start-up flags for RBE.\nBAZEL_RBE_FLAGS=(\n\"--bazelrc=${WORKSPAC... | Go | Apache License 2.0 | google/gvisor | gvisor/kokoro: don't downgrade libseccomp
It isn't required with a new vm image.
PiperOrigin-RevId: 237915203
Change-Id: I813e7f1801d0766cec598413718e5ddd4c3d8cdf |
259,858 | 11.03.2019 18:18:41 | 25,200 | 6e6dbf0e566270ae96a4db81d9d04275d0fffb00 | kvm: minimum guest/host timekeeping delta. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64_unsafe.go",
"diff": "@@ -87,17 +87,26 @@ func (c *vCPU) setCPUID() error {\n// setSystemTime sets the TSC for the vCPU.\n//\n-// FIXME: This introduces a sligh... | Go | Apache License 2.0 | google/gvisor | kvm: minimum guest/host timekeeping delta.
PiperOrigin-RevId: 237927368
Change-Id: I359badd1967bb118fe74eab3282c946c18937edc |
259,901 | 12.03.2019 15:35:32 | 25,200 | 8003bd6a5c012784c0b2a2dad93cbec969fac3b0 | Make gonet.PacketConn implement net.Conn.
gonet.PacketConn now implements net.Conn, allowing it to be returned from
net.Dial.Dialer functions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet.go",
"diff": "@@ -557,6 +557,21 @@ func (c *PacketConn) newRemoteOpError(op string, remote net.Addr, err error) *ne\n}\n}\n+// RemoteAddr implements net.Conn.RemoteAddr.\n+func (c ... | Go | Apache License 2.0 | google/gvisor | Make gonet.PacketConn implement net.Conn.
gonet.PacketConn now implements net.Conn, allowing it to be returned from
net.Dial.Dialer functions.
PiperOrigin-RevId: 238111980
Change-Id: I174884385ff4d9b8e9918fac7bbb5b93ca366ba7 |
259,992 | 13.03.2019 15:24:09 | 25,200 | 70d06134442843cd4355590c4155ee6594558c00 | Reduce PACKET_RX_RING memory usage
Previous memory allocation was excessive (80 MB). Changed
it to use 2 MB instead. There is no drop in perfomance due
to this change:
ab -n 100 -c 10 ==> 10 MB file
80 MB: 178 MB/s
2 MB: 181 MB/s | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/mmap_amd64_unsafe.go",
"new_path": "pkg/tcpip/link/fdbased/mmap_amd64_unsafe.go",
"diff": "@@ -40,11 +40,13 @@ const (\n// We overallocate the frame size to accommodate space for the\n// TPacketHdr+RawSockAddrLinkLayer+MAC header and any... | Go | Apache License 2.0 | google/gvisor | Reduce PACKET_RX_RING memory usage
Previous memory allocation was excessive (80 MB). Changed
it to use 2 MB instead. There is no drop in perfomance due
to this change:
ab -n 100 -c 10 http://server/latin10m.txt ==> 10 MB file
80 MB: 178 MB/s
2 MB: 181 MB/s
PiperOrigin-RevId: 238321594
Change-Id: I1c8aed13cad5d75f4506d2b406b305117055fbe5 |
259,885 | 14.03.2019 07:42:13 | 25,200 | fb9919881c7dc98eaf97cad2a70d187bd78f1566 | Use WalkGetAttr in gofer.inodeOperations.Create.
p9.Twalk.handle() with a non-empty path also stats the walked-to path
anyway, so the preceding GetAttr is completely wasted. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/path.go",
"new_path": "pkg/sentry/fs/gofer/path.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"fmt\"\n\"syscall\"\n+ \"gvisor.googlesource.com/gvisor/pkg/log\"\n\"gvisor.googlesource.com/gvisor/pkg/p9\"\n\"gvisor.googlesource.com/gvisor/pkg/se... | Go | Apache License 2.0 | google/gvisor | Use WalkGetAttr in gofer.inodeOperations.Create.
p9.Twalk.handle() with a non-empty path also stats the walked-to path
anyway, so the preceding GetAttr is completely wasted.
PiperOrigin-RevId: 238440645
Change-Id: I7fbc7536f46b8157639d0d1f491e6aaa9ab688a3 |
259,891 | 14.03.2019 10:45:54 | 25,200 | 6ee3d6614b3616a62e177630dfd152ab61211ba2 | Fix flaky RawPingAndSockets (and MultipleSocketsRecieve just in case). | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/raw_socket_ipv4.cc",
"new_path": "test/syscalls/linux/raw_socket_ipv4.cc",
"diff": "@@ -164,24 +164,46 @@ TEST_F(RawSocketTest, MultipleSocketReceive) {\nicmp.un.echo.id = 2018;\nASSERT_NO_FATAL_FAILURE(SendEmptyICMP(&icmp));\n- // Receive ... | Go | Apache License 2.0 | google/gvisor | Fix flaky RawPingAndSockets (and MultipleSocketsRecieve just in case).
PiperOrigin-RevId: 238474202
Change-Id: Ib8c431e973e8cf1e1c8ee2f8c1978ddb8e88b0b8 |
259,985 | 18.03.2019 10:47:59 | 25,200 | cea1dd7d21b976ad5cb145b94be7b1bf879235be | Remove racy access to shm fields. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/shm/shm.go",
"new_path": "pkg/sentry/kernel/shm/shm.go",
"diff": "@@ -286,7 +286,7 @@ func (r *Registry) remove(s *Shm) {\ndefer s.mu.Unlock()\nif s.key != linux.IPC_PRIVATE {\n- panic(fmt.Sprintf(\"Attempted to remove shm segment %+v from th... | Go | Apache License 2.0 | google/gvisor | Remove racy access to shm fields.
PiperOrigin-RevId: 239016776
Change-Id: Ia7af4258e7c69b16a4630a6f3278aa8e6b627746 |
259,891 | 18.03.2019 11:31:12 | 25,200 | 88d791c259cc2f81b18547ae7f7859c3508cef21 | Replace use of ucontext with ucontext_t. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/sigaltstack.cc",
"new_path": "test/syscalls/linux/sigaltstack.cc",
"diff": "@@ -143,7 +143,7 @@ void badhandler(int sig, siginfo_t* siginfo, void* arg) {\nbadhandler_recursive_faults--;\nFault();\n}\n- FixupFault(reinterpret_cast<ucontext*>... | Go | Apache License 2.0 | google/gvisor | Replace use of ucontext with ucontext_t.
PiperOrigin-RevId: 239026571
Change-Id: Ifd01674855094f3abad497776f418023452033a1 |
259,942 | 19.03.2019 08:29:37 | 25,200 | 928809fa7d3b682c7e2e06c9f9b1f3fb5d75a0d6 | Add layer 2 stats (tx, rx) X (packets, bytes) to netstack | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -42,6 +42,20 @@ type NIC struct {\nprimary map[tcpip.NetworkProtocolNumber]*ilist.List\nendpoints map[NetworkEndpointID]*referencedNetworkEndpoint\nsubnets []tcpip.Subnet\n+\n+ stats NI... | Go | Apache License 2.0 | google/gvisor | Add layer 2 stats (tx, rx) X (packets, bytes) to netstack
PiperOrigin-RevId: 239194420
Change-Id: Ie193e8ac2b7a6db21195ac85824a335930483971 |
259,992 | 19.03.2019 10:37:46 | 25,200 | 7b33df68450bdb9519cf650a8d92fa4a81f37fa0 | Fix data race in netlink send buffer size | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netlink/socket.go",
"new_path": "pkg/sentry/socket/netlink/socket.go",
"diff": "@@ -291,6 +291,8 @@ func (s *Socket) GetSockOpt(t *kernel.Task, level int, name int, outLen int) (in\nif outLen < sizeOfInt32 {\nreturn nil, syserr.ErrInvalidArgu... | Go | Apache License 2.0 | google/gvisor | Fix data race in netlink send buffer size
PiperOrigin-RevId: 239221041
Change-Id: Icc19e32a00fa89167447ab2f45e90dcfd61bea04 |
259,853 | 19.03.2019 17:32:23 | 25,200 | 87cce0ec08b9d629a5e3a88be411b1721d767301 | netstack: reduce MSS from SYN to account tcp options
See: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/README.md",
"new_path": "pkg/sentry/fs/proc/README.md",
"diff": "@@ -11,7 +11,6 @@ inconsistency, please file a bug.\nThe following files are implemented:\n-\n| File /proc/ | Content |\n| :------------------------ | :------------------------... | Go | Apache License 2.0 | google/gvisor | netstack: reduce MSS from SYN to account tcp options
See: https://tools.ietf.org/html/rfc6691#section-2
PiperOrigin-RevId: 239305632
Change-Id: Ie8eb912a43332e6490045dc95570709c5b81855e |
259,992 | 20.03.2019 10:35:13 | 25,200 | c7877b0a14778af9165eb2b841513b6f7dfdcbee | Fail in case mount option is unknown | [
{
"change_type": "MODIFY",
"old_path": "runsc/specutils/fs.go",
"new_path": "runsc/specutils/fs.go",
"diff": "@@ -20,7 +20,6 @@ import (\n\"syscall\"\nspecs \"github.com/opencontainers/runtime-spec/specs-go\"\n- \"gvisor.googlesource.com/gvisor/pkg/log\"\n)\ntype mapping struct {\n@@ -121,7 +120,7 @... | Go | Apache License 2.0 | google/gvisor | Fail in case mount option is unknown
PiperOrigin-RevId: 239425816
Change-Id: I3b1479c61b4222c3931a416c4efc909157044330 |
259,985 | 20.03.2019 14:30:00 | 25,200 | 81f4829d1195276d037f8bd23a2ef69e88f5ae6c | Record sockets created during accept(2) for all families.
Track new sockets created during accept(2) in the socket table for all
families. Previously we were only doing this for unix domain sockets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -504,6 +504,8 @@ func (s *SocketOperations) Accept(t *kernel.Task, peerRequested bool, flags int,\n}\nfd, e := t.FDMap().NewFDFrom(0, ns, fdFlags, t.Thre... | Go | Apache License 2.0 | google/gvisor | Record sockets created during accept(2) for all families.
Track new sockets created during accept(2) in the socket table for all
families. Previously we were only doing this for unix domain sockets.
PiperOrigin-RevId: 239475550
Change-Id: I16f009f24a06245bfd1d72ffd2175200f837c6ac |
259,853 | 20.03.2019 18:39:57 | 25,200 | 064fda1a759fa3e73d25da3fd535d256ac8ccfb0 | gvisor: don't allocate a new credential object on fork
A credential object is immutable, so we don't need to copy it for a new
task. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_clone.go",
"new_path": "pkg/sentry/kernel/task_clone.go",
"diff": "@@ -252,7 +252,7 @@ func (t *Task) Clone(opts *CloneOptions) (ThreadID, *SyscallControl, error) {\nTaskContext: tc,\nFSContext: fsc,\nFDMap: fds,\n- Credentials: creds.Fo... | Go | Apache License 2.0 | google/gvisor | gvisor: don't allocate a new credential object on fork
A credential object is immutable, so we don't need to copy it for a new
task.
PiperOrigin-RevId: 239519266
Change-Id: I0632f641fdea9554779ac25d84bee4231d0d18f2 |
259,891 | 21.03.2019 11:53:11 | 25,200 | ba937d74f9a69893cde8c7e8cb9c2d1cdadb2b70 | Address typos from github. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -157,8 +157,8 @@ There are several factors influencing performance. The platform choice has the\nlargest direct impact that varies depending on the specific workload. There is\nno best platform: Ptrace works uni... | Go | Apache License 2.0 | google/gvisor | Address typos from github.
https://github.com/google/gvisor/pull/132
PiperOrigin-RevId: 239641377
Change-Id: I7ba6b57730800cc98496c83cb643e70ec902ed3d |
259,854 | 21.03.2019 13:18:00 | 25,200 | ba828233b9e934992ac024232e5018ce9971f334 | Clear msghdr flags on successful recvmsg.
.net sets these flags to -1 and then uses their result, especting it to be
zero.
Does not set actual flags (e.g. MSG_TRUNC), but setting to zero is more correct
than what we did before. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"new_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"diff": "@@ -57,6 +57,10 @@ const nameLenOffset = 8\n// to the ControlLen field.\nconst controlLenOffset = 40\n+// flagsOffset is the offset form the start of the ... | Go | Apache License 2.0 | google/gvisor | Clear msghdr flags on successful recvmsg.
.net sets these flags to -1 and then uses their result, especting it to be
zero.
Does not set actual flags (e.g. MSG_TRUNC), but setting to zero is more correct
than what we did before.
PiperOrigin-RevId: 239657951
Change-Id: I89c5f84bc9b94a2cd8ff84e8ecfea09e01142030 |
259,891 | 21.03.2019 18:03:49 | 25,200 | 0cd5f2004444b1c792ab3d4bd3b01699b11b9553 | Replace manual pty copies to/from userspace with safemem operations.
Also, changing queue.writeBuf from a buffer.Bytes to a [][]byte should reduce
copying and reallocating of slices. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tty/BUILD",
"new_path": "pkg/sentry/fs/tty/BUILD",
"diff": "@@ -24,6 +24,7 @@ go_library(\n\"//pkg/sentry/fs\",\n\"//pkg/sentry/fs/fsutil\",\n\"//pkg/sentry/kernel/auth\",\n+ \"//pkg/sentry/safemem\",\n\"//pkg/sentry/socket/unix/transport\",\n\"/... | Go | Apache License 2.0 | google/gvisor | Replace manual pty copies to/from userspace with safemem operations.
Also, changing queue.writeBuf from a buffer.Bytes to a [][]byte should reduce
copying and reallocating of slices.
PiperOrigin-RevId: 239713547
Change-Id: I6ee5ff19c3ee2662f1af5749cae7b73db0569e96 |
259,854 | 21.03.2019 18:10:13 | 25,200 | 125d3a19e3a0e8d5549dca061f3dec9e0f5aa9d4 | Test TCP sockets with MSG_TRUNC|MSG_PEEK. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"new_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"diff": "@@ -538,5 +538,34 @@ TEST_P(TCPSocketPairTest, SetOOBInline) {\nEXPECT_EQ(get, kSockOptOn);\n}\n+TEST_P(TCPSocketPairTest, MsgTruncMsgPeek) {\n+... | Go | Apache License 2.0 | google/gvisor | Test TCP sockets with MSG_TRUNC|MSG_PEEK.
PiperOrigin-RevId: 239714368
Change-Id: I35860b880a1d8885eb8c2d4ff267caaf72d91088 |
259,854 | 21.03.2019 18:52:03 | 25,200 | 7d0227ff16f4397924fb008a7452f6ed3f8205e0 | Add test for short recvmsg iovec length. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_generic.cc",
"new_path": "test/syscalls/linux/socket_generic.cc",
"diff": "@@ -257,6 +257,32 @@ TEST_P(AllSocketPairTest, RecvmsgPeekMsghdrFlagsCleared) {\nEXPECT_EQ(msg.msg_flags, 0);\n}\n+TEST_P(AllSocketPairTest, RecvmsgIovNotUpda... | Go | Apache License 2.0 | google/gvisor | Add test for short recvmsg iovec length.
PiperOrigin-RevId: 239718991
Change-Id: Idc78557a8e9bfdd3cb7d8ec4db708364652640a4 |
259,872 | 21.03.2019 22:03:34 | 25,200 | 45ba52f8246a7060da48e250512a734a79187adf | Allow BP and OF can be called from user space
Change the DPL from 0 to 3 for Breakpoint and Overflow,
then user space could trigger Breakpoint and Overflow
as excepected. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/kernel_amd64.go",
"new_path": "pkg/sentry/platform/ring0/kernel_amd64.go",
"diff": "@@ -27,9 +27,15 @@ func (k *Kernel) init(opts KernelOpts) {\n// Setup the IDT, which is uniform.\nfor v, handler := range handlers {\n+ // Allow Break... | Go | Apache License 2.0 | google/gvisor | Allow BP and OF can be called from user space
Change the DPL from 0 to 3 for Breakpoint and Overflow,
then user space could trigger Breakpoint and Overflow
as excepected.
Change-Id: Ibead65fb8c98b32b7737f316db93b3a8d9dcd648
PiperOrigin-RevId: 239736648 |
259,853 | 26.03.2019 15:09:35 | 25,200 | 79aca14a0cd70720e8a8f8bd6c1499ab1ffbd8d3 | Use toolchain configs from bazel_0.23.0
bazel 0.24.0 isn't compatible with bazel_0.20.0 configs:
(10:32:27) ERROR:
bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.20.0/default/BUILD:57:1:
no such attribute 'dynamic_runtime_libs' in 'cc_toolchain' rule | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc_rbe",
"new_path": ".bazelrc_rbe",
"diff": "# limitations under the License.\n# Note for gVisor authors:\n-# This version is a derivative of: bazel-0.20.0.bazelrc\n+# This version is a derivative of: bazel-0.23.0.bazelrc\n# From: https://github.com/baz... | Go | Apache License 2.0 | google/gvisor | Use toolchain configs from bazel_0.23.0
bazel 0.24.0 isn't compatible with bazel_0.20.0 configs:
(10:32:27) ERROR:
bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.20.0/default/BUILD:57:1:
no such attribute 'dynamic_runtime_libs' in 'cc_toolchain' rule
PiperOrigin-RevId: 240436868
Change-Id: Iee68c9b79d907ca2bdd124386aaa77c786e089ce |
259,853 | 26.03.2019 17:14:04 | 25,200 | 654e878abba174d8f7d588f38ecfd5a020bf581e | netstack: Don't exclude length when a pseudo-header checksum is calculated
This is a preparation for GSO changes (cl/234508902).
RELNOTES[gofers]: Refactor checksum code to include length, which
it already did, but in a convoluted way. Should be a no-op. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/checksum.go",
"new_path": "pkg/tcpip/header/checksum.go",
"diff": "package header\nimport (\n+ \"encoding/binary\"\n+\n\"gvisor.googlesource.com/gvisor/pkg/tcpip\"\n\"gvisor.googlesource.com/gvisor/pkg/tcpip/buffer\"\n)\n@@ -76,12 +78,17 @@ fu... | Go | Apache License 2.0 | google/gvisor | netstack: Don't exclude length when a pseudo-header checksum is calculated
This is a preparation for GSO changes (cl/234508902).
RELNOTES[gofers]: Refactor checksum code to include length, which
it already did, but in a convoluted way. Should be a no-op.
PiperOrigin-RevId: 240460794
Change-Id: I537381bc670b5a9f5d70a87aa3eb7252e8f5ace2 |
259,885 | 27.03.2019 10:45:17 | 25,200 | 26583e413e40666f70170025cd4c5224f45fdfa3 | Convert []byte to string without copying in usermem.CopyStringIn.
This is the same technique used by Go's strings.Builder
(https://golang.org/src/strings/builder.go#L45), and for the same
reason. (We can't just use strings.Builder because there's no way to get
the underlying []byte to pass to usermem.IO.CopyIn.) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/usermem/BUILD",
"new_path": "pkg/sentry/usermem/BUILD",
"diff": "@@ -25,6 +25,7 @@ go_library(\n\"bytes_io_unsafe.go\",\n\"usermem.go\",\n\"usermem_arm64.go\",\n+ \"usermem_unsafe.go\",\n\"usermem_x86.go\",\n],\nimportpath = \"gvisor.googlesource.co... | Go | Apache License 2.0 | google/gvisor | Convert []byte to string without copying in usermem.CopyStringIn.
This is the same technique used by Go's strings.Builder
(https://golang.org/src/strings/builder.go#L45), and for the same
reason. (We can't just use strings.Builder because there's no way to get
the underlying []byte to pass to usermem.IO.CopyIn.)
PiperOrigin-RevId: 240594892
Change-Id: Ic070e7e480aee53a71289c7c120850991358c52c |
259,853 | 27.03.2019 11:08:33 | 25,200 | 5d94c893ae38f09f5132ab43d48204ab49121960 | gvisor/runsc: address typos from github
Fixes:
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/list.go",
"new_path": "runsc/cmd/list.go",
"diff": "@@ -42,7 +42,7 @@ func (*List) Name() string {\n// Synopsis implements subcommands.Command.Synopsis.\nfunc (*List) Synopsis() string {\n- return \"list contaners started by runsc with the given root... | Go | Apache License 2.0 | google/gvisor | gvisor/runsc: address typos from github
Fixes: https://github.com/google/gvisor/issues/143
Fixes #143
PiperOrigin-RevId: 240600719
Change-Id: Id1731b9969f98e32e52e144a6643e12b0b70f168 |
259,962 | 28.03.2019 18:17:40 | 25,200 | cc0e96a4bd3348ecc2a636fd90118b8e5cce672c | Fix Panic in SACKScoreboard.Delete.
The panic was caused by modifying the tree while iterating which invalidated the
iterator.
Also fixes another bug in SACKScoreboard.Insert() which was causing blocks to be
merged incorrectly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/sack_scoreboard.go",
"new_path": "pkg/tcpip/transport/tcp/sack_scoreboard.go",
"diff": "@@ -77,7 +77,7 @@ func (s *SACKScoreboard) Insert(r header.SACKBlock) {\nsacked := i.(header.SACKBlock)\n// There is a hole between these two SACK b... | Go | Apache License 2.0 | google/gvisor | Fix Panic in SACKScoreboard.Delete.
The panic was caused by modifying the tree while iterating which invalidated the
iterator.
Also fixes another bug in SACKScoreboard.Insert() which was causing blocks to be
merged incorrectly.
PiperOrigin-RevId: 240895053
Change-Id: Ia72b8244297962df5c04283346da5226434740af |
259,962 | 29.03.2019 12:04:42 | 25,200 | 45c54b1f4e2bb6fcad14b8b7734d6a1847329901 | Fix incorrect checksums in TCP and UDP tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/testing/context/context.go",
"new_path": "pkg/tcpip/transport/tcp/testing/context/context.go",
"diff": "@@ -327,9 +327,7 @@ func (c *Context) BuildSegment(payload []byte, h *Headers) buffer.VectorisedView\n})\n// Calculate the TCP pseud... | Go | Apache License 2.0 | google/gvisor | Fix incorrect checksums in TCP and UDP tests.
PiperOrigin-RevId: 241025361
Change-Id: I292e7aea9a4b294b11e4f736e107010d9524586b |
259,885 | 29.03.2019 13:15:49 | 25,200 | 69afd0438e3213b8bf6d74bdf9c288772f81e834 | Return srclen in proc.idMapFileOperations.Write. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/uid_gid_map.go",
"new_path": "pkg/sentry/fs/proc/uid_gid_map.go",
"diff": "@@ -169,5 +169,8 @@ func (imfo *idMapFileOperations) Write(ctx context.Context, file *fs.File, src u\nif err != nil {\nreturn 0, err\n}\n- return int64(len(b)), nil\n... | Go | Apache License 2.0 | google/gvisor | Return srclen in proc.idMapFileOperations.Write.
PiperOrigin-RevId: 241037926
Change-Id: I4b0381ac1c7575e8b861291b068d3da22bc03850 |
259,885 | 29.03.2019 16:24:29 | 25,200 | 26e8d9981fcf6d08199a9fd9c609d9715c3cf37e | Use kernel.Task.CopyScratchBuffer in syscalls/linux where possible. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -550,17 +550,16 @@ func (t *Task) afterLoad() {\nt.futexWaiter = futex.NewWaiter()\n}\n-// copyScratchBufferLen is the length of the copyScratchBuffer field of the Task\n-// struc... | Go | Apache License 2.0 | google/gvisor | Use kernel.Task.CopyScratchBuffer in syscalls/linux where possible.
PiperOrigin-RevId: 241072126
Change-Id: Ib4d9f58f550732ac4c5153d3cf159a5b1a9749da |
259,885 | 01.04.2019 10:17:28 | 25,200 | 60efd53822fe8bb6b737a1e9a722d8317807ee9a | Fix MemfdTest_OtherProcessCanOpenFromProcfs.
Make the body of InForkedProcess async-signal-safe.
Pass the correct path to open(). | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/memfd.cc",
"new_path": "test/syscalls/linux/memfd.cc",
"diff": "@@ -485,10 +485,12 @@ TEST(MemfdTest, CanOpenFromProcfs) {\nTEST(MemfdTest, OtherProcessCanOpenFromProcfs) {\nconst FileDescriptor memfd =\nASSERT_NO_ERRNO_AND_VALUE(MemfdCreat... | Go | Apache License 2.0 | google/gvisor | Fix MemfdTest_OtherProcessCanOpenFromProcfs.
- Make the body of InForkedProcess async-signal-safe.
- Pass the correct path to open().
PiperOrigin-RevId: 241348774
Change-Id: I753dfa36e4fb05521e659c173e3b7db0c7fc159b |
259,853 | 01.04.2019 12:52:19 | 25,200 | a4b34e26372528ef60140acef0b7c1ab1934f82a | gvisor: convert ilist to ilist:generic_list
ilist:generic_list works faster (cl/240185278) and
the code looks cleaner without type casting. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/BUILD",
"new_path": "pkg/sentry/fs/BUILD",
"diff": "@@ -14,6 +14,7 @@ go_library(\n\"dirent_cache.go\",\n\"dirent_list.go\",\n\"dirent_state.go\",\n+ \"event_list.go\",\n\"file.go\",\n\"file_operations.go\",\n\"file_overlay.go\",\n@@ -46,7 +47,6 ... | Go | Apache License 2.0 | google/gvisor | gvisor: convert ilist to ilist:generic_list
ilist:generic_list works faster (cl/240185278) and
the code looks cleaner without type casting.
PiperOrigin-RevId: 241381175
Change-Id: I8487ab1d73637b3e9733c253c56dce9e79f0d35f |
259,885 | 01.04.2019 14:46:28 | 25,200 | b4006686d2752857b406c6c7e53a112efca826ff | Don't expand COW-break on executable VMAs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/pma.go",
"new_path": "pkg/sentry/mm/pma.go",
"diff": "@@ -318,7 +318,23 @@ func (mm *MemoryManager) getPMAsInternalLocked(ctx context.Context, vseg vmaIter\npanic(fmt.Sprintf(\"pma %v needs to be copied for writing, but is not readable: %v\", pse... | Go | Apache License 2.0 | google/gvisor | Don't expand COW-break on executable VMAs.
PiperOrigin-RevId: 241403847
Change-Id: I4631ca05734142da6e80cdfa1a1d63ed68aa05cc |
259,985 | 01.04.2019 15:38:08 | 25,200 | 7cff746ef2bbe5351e5985bebc88efc9e0881c78 | Save/restore simple devices.
We weren't saving simple devices' last allocated inode numbers, which
caused inode number reuse across S/R. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/device/BUILD",
"new_path": "pkg/sentry/device/BUILD",
"diff": "-load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\n-\npackage(licenses = [\"notice\"])\n+load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\n+\ngo_lib... | Go | Apache License 2.0 | google/gvisor | Save/restore simple devices.
We weren't saving simple devices' last allocated inode numbers, which
caused inode number reuse across S/R.
PiperOrigin-RevId: 241414245
Change-Id: I964289978841ef0a57d2fa48daf8eab7633c1284 |
259,858 | 01.04.2019 16:17:40 | 25,200 | 7543e9ec2043af7d071373aeec04b92a98051087 | Add release hook and version flag | [
{
"change_type": "MODIFY",
"old_path": "runsc/BUILD",
"new_path": "runsc/BUILD",
"diff": "@@ -6,12 +6,13 @@ go_binary(\nname = \"runsc\",\nsrcs = [\n\"main.go\",\n+ \"version.go\",\n],\npure = \"on\",\nvisibility = [\n\"//visibility:public\",\n],\n- x_defs = {\"main.gitRevision\": \"{GIT_REVISION}\"... | Go | Apache License 2.0 | google/gvisor | Add release hook and version flag
PiperOrigin-RevId: 241421671
Change-Id: Ic0cebfe3efd458dc42c49f7f812c13318705199a |
259,858 | 01.04.2019 16:54:43 | 25,200 | b19b7f3e46ce57bec4b70c7f7ef748295dec558b | Drop godoc handling. | [
{
"change_type": "MODIFY",
"old_path": "cmd/gvisor-website/app.yaml",
"new_path": "cmd/gvisor-website/app.yaml",
"diff": "runtime: go111\nhandlers:\n+ - url: /(change|cl||issue)(/.*)?\n+ secure: always\n+ script: auto\n- url: /.*\nsecure: always\nscript: auto\n- # TODO: remove this when published\n+... | Go | Apache License 2.0 | google/gvisor | Drop godoc handling. |
259,854 | 02.04.2019 10:25:24 | 25,200 | 27a8830ca2021406f1232a257a8c971f83f793f2 | Fix governance link on community page. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/community/_index.md",
"new_path": "content/docs/community/_index.md",
"diff": "@@ -18,7 +18,7 @@ collaborate.\n<iframe src=\"https://calendar.google.com/calendar/b/1/embed?showTitle=0&height=600&wkst=1&bgcolor=%23FFFFFF&src=bd6f4k2... | Go | Apache License 2.0 | google/gvisor | Fix governance link on community page. (#2) |
259,854 | 02.04.2019 10:26:01 | 25,200 | cf172c7ab4e8e8d3c95be7be88e14fae0e8c11c6 | Tweaks to architecture guide | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/overview.md",
"new_path": "content/docs/architecture_guide/overview.md",
"diff": "title = \"Overview & Platforms\"\nweight = 10\n+++\n-gVisor sandbox consists of multiple processes when running. These sandboxes\n+A gVisor sandbo... | Go | Apache License 2.0 | google/gvisor | Tweaks to architecture guide (#4) |
259,891 | 02.04.2019 11:26:47 | 25,200 | a40ee4f4b8a6874157759723583d6489bbac7f23 | Change bug number for duplicate bug. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -232,7 +232,7 @@ func (cm *containerManager) Start(args *StartArgs, _ *struct{}) error {\n}\n// Prevent CIDs containing \"..\" from confusing the sentry when creating\n// /container... | Go | Apache License 2.0 | google/gvisor | Change bug number for duplicate bug.
PiperOrigin-RevId: 241567897
Change-Id: I580eac04f52bb15f4aab7df9822c4aa92e743021 |
259,881 | 02.04.2019 11:35:32 | 25,200 | b11221fe7ce7a3620c8145de2d4219ab2b8625b7 | Reword to remove duplicate "Linux"
"Linux x86_64 Linux 3.17+" is wordy. Reword to mention Linux only once. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": "content/docs/includes/install_gvisor.md",
"diff": "-> Note: gVisor requires Linux x86\\_64 Linux 3.17+.\n+> Note: gVisor supports only x86\\_64 and requires Linux 3.17+.\nThe easiest way to get `runsc` is ... | Go | Apache License 2.0 | google/gvisor | Reword to remove duplicate "Linux" (#6)
"Linux x86_64 Linux 3.17+" is wordy. Reword to mention Linux only once. |
259,854 | 02.04.2019 10:10:39 | 25,200 | 882a3a914ea8fb48f15e29f24fc0ed6a56fa84f6 | Capitalize "the" after colon in title | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/security.md",
"new_path": "content/docs/architecture_guide/security.md",
"diff": "@@ -7,7 +7,7 @@ exploitation of kernel bugs when running untrusted code. In order to understand\nhow gVisor achieves this goal, it is first necess... | Go | Apache License 2.0 | google/gvisor | Capitalize "the" after colon in title
https://blog.apastyle.org/apastyle/2011/06/capitalization-after-colons.html |
259,854 | 02.04.2019 10:48:18 | 25,200 | 0d1c1d94eec097edd8a53e44bff25e479f85bb10 | Remove duplicate word not | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/security.md",
"new_path": "content/docs/architecture_guide/security.md",
"diff": "@@ -138,7 +138,7 @@ We allow a sandbox to do the following.\nfiles. The calls include duplication and closing of file descriptors,\nsynchronizatio... | Go | Apache License 2.0 | google/gvisor | Remove duplicate word not |
259,854 | 02.04.2019 10:49:24 | 25,200 | f419ffb46d34654e69e8dba3174bba3bc192f5c4 | Add that veth is not required if networking is disabled. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/security.md",
"new_path": "content/docs/architecture_guide/security.md",
"diff": "@@ -138,7 +138,7 @@ We allow a sandbox to do the following.\nfiles. The calls include duplication and closing of file descriptors,\nsynchronizatio... | Go | Apache License 2.0 | google/gvisor | Add that veth is not required if networking is disabled. |
259,854 | 02.04.2019 10:53:24 | 25,200 | dacb87a938986fa937c682062fa035f36566dea8 | Replace distinct with independent.
I think this is clearer. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/security.md",
"new_path": "content/docs/architecture_guide/security.md",
"diff": "@@ -146,8 +146,8 @@ For gVisor development, there are several engineering principles that are\nemployed in order to ensure that the system meets i... | Go | Apache License 2.0 | google/gvisor | Replace distinct with independent.
I think this is clearer. |
259,858 | 02.04.2019 13:42:14 | 25,200 | ff7f193073fdc075f47d1d8f0a450ec5fd130097 | Use a top-level docs link | [
{
"change_type": "MODIFY",
"old_path": "content/_index.html",
"new_path": "content/_index.html",
"diff": "@@ -37,7 +37,7 @@ Capable of running most Linux applications unmodified, with zero configuration.\n{{< blocks/section color=\"white\" >}}\n{{% blocks/feature icon=\"fas fa-book\" title=\"Read th... | Go | Apache License 2.0 | google/gvisor | Use a top-level docs link |
259,884 | 02.04.2019 03:27:24 | 14,400 | 4c7a3ecacd432f16287be8a2dc144a2bb50ad163 | Fix edit links in documentation | [
{
"change_type": "MODIFY",
"old_path": "layouts/partials/page-meta-links.html",
"new_path": "layouts/partials/page-meta-links.html",
"diff": "{{ $gh_repo := ($.Param \"github_repo\") }}\n{{ if $gh_repo }}\n<div class=\"td-page-meta ml-2 pb-1 pt-2 mb-0\">\n-{{ $editURL := printf \"%s/edit/master/cont... | Go | Apache License 2.0 | google/gvisor | Fix edit links in documentation |
259,884 | 29.03.2019 23:53:20 | 14,400 | 009f45da3bc2d6c66e597e56f02aa32f4ffb8d2b | Remove superfluous section from compatibility top | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -36,8 +36,3 @@ The following applications/images have been tested:\n* wordpress\n[bug]: https://github.com/google/gvisor/issues\n-\n-##... | Go | Apache License 2.0 | google/gvisor | Remove superfluous section from compatibility top |
259,884 | 30.03.2019 00:02:19 | 14,400 | 0fa497a567ba0b387f4b42035a3894dca37018f5 | Update syscall ref doc generator | [
{
"change_type": "MODIFY",
"old_path": "cmd/parse-syscall-annotations/main.go",
"new_path": "cmd/parse-syscall-annotations/main.go",
"diff": "@@ -59,14 +59,14 @@ var (\nr2 *regexp.Regexp\nmdTemplate = template.Must(template.New(\"name\").Parse(`+++\n-title = \"Syscall Reference\"\n-description = \"S... | Go | Apache License 2.0 | google/gvisor | Update syscall ref doc generator |
259,884 | 30.03.2019 00:43:21 | 14,400 | 96dedf5dd6c42125b3c6f976a1447de96e804600 | Removed link to filesystem page | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/FAQ.md",
"new_path": "content/docs/user_guide/FAQ.md",
"diff": "@@ -26,7 +26,6 @@ Note that `kubectl cp` works because it does the copy by exec'ing inside the\nsandbox, and thus gVisor cache is aware of the new files and dirs.\nThere ar... | Go | Apache License 2.0 | google/gvisor | Removed link to filesystem page |
259,884 | 31.03.2019 20:18:04 | 14,400 | 0803a82bffccdd609db03743d145c3d6656f220e | Updated style for top page cover | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "assets/scss/_custom_styles.scss",
"diff": "+// Custom styles.\n+\n+// The table anchor for syscall references so that entries referenced\n+// directly by an anchor aren't buried underneath the header.\n+a.doc-table-anchor {\n+ display: block;\n+... | Go | Apache License 2.0 | google/gvisor | Updated style for top page cover |
259,884 | 31.03.2019 20:26:11 | 14,400 | 9288f50ee371b6bfc96c5ca7ef208be955e7314c | Convert background from png to jpg
jpeg is much smaller for the background image. 2.5mb -> 86.7kb | [
{
"change_type": "RENAME",
"old_path": "content/background.png",
"new_path": "assets/backgrounds/background.png",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "content/background.svg",
"new_path": "assets/backgrounds/background.svg",
"diff": ""
},
{
"change_type":... | Go | Apache License 2.0 | google/gvisor | Convert background from png to jpg
jpeg is much smaller for the background image. 2.5mb -> 86.7kb |
259,884 | 31.03.2019 20:57:11 | 14,400 | d37053976470412c4895ca30c370d80e3ea42d76 | Adjust link color to improve accessibility. | [
{
"change_type": "MODIFY",
"old_path": "assets/scss/_styles_project.scss",
"new_path": "assets/scss/_styles_project.scss",
"diff": "// Custom styles.\n+// Apply the link-color to blocks with white background to improve\n+// accessibility.\n+a, .td-box--secondary p > a, .td-box--white p > a {\n+ colo... | Go | Apache License 2.0 | google/gvisor | Adjust link color to improve accessibility. |
259,884 | 31.03.2019 20:59:43 | 14,400 | 8a30257ad9eb5f38b11732c6cfa93d0f6adf9624 | Adjust bottom padding for title/logo | [
{
"change_type": "MODIFY",
"old_path": "assets/scss/_styles_project.scss",
"new_path": "assets/scss/_styles_project.scss",
"diff": "@@ -31,7 +31,7 @@ a.doc-table-anchor {\n// Left align the cover block and increase text size.\n.td-default main section.td-cover-block h1 {\n- padding-bottom: 6rem;\n+ ... | Go | Apache License 2.0 | google/gvisor | Adjust bottom padding for title/logo |
259,884 | 31.03.2019 21:05:39 | 14,400 | 025a0a7999724afdb3e3214172ef565da572dc92 | Center the cover block for mobile devices | [
{
"change_type": "MODIFY",
"old_path": "assets/scss/_styles_project.scss",
"new_path": "assets/scss/_styles_project.scss",
"diff": "@@ -30,6 +30,11 @@ a.doc-table-anchor {\n}\n// Left align the cover block and increase text size.\n+.td-default main section.td-cover-block {\n+ @media (max-width: 768p... | Go | Apache License 2.0 | google/gvisor | Center the cover block for mobile devices |
259,884 | 31.03.2019 22:19:43 | 14,400 | 0e99ceece3bfb6103c6a81d480b6bd85247a4f1c | Update cover to match layout from designers | [
{
"change_type": "MODIFY",
"old_path": "assets/scss/_styles_project.scss",
"new_path": "assets/scss/_styles_project.scss",
"diff": "@@ -21,26 +21,47 @@ a.doc-table-anchor {\nwidth: auto;\n}\n-// Only show the logo in the header after scrolling down the page.\n+// Only show the navbar after scrolling... | Go | Apache License 2.0 | google/gvisor | Update cover to match layout from designers |
259,858 | 02.04.2019 16:14:53 | 25,200 | d81ea7a799cd39fa23ff7b26a3bc0c8a0d894dc1 | Drop performance guide until complete | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/FAQ.md",
"new_path": "content/docs/user_guide/FAQ.md",
"diff": "@@ -30,7 +30,3 @@ There are also different filesystem modes that can be used to avoid this issue.\n### What's the security model?\nSee the [Security Model](../../architectu... | Go | Apache License 2.0 | google/gvisor | Drop performance guide until complete |
259,858 | 02.04.2019 16:19:47 | 25,200 | 63d5bb5a161a7231f0cc2b8a9a3005210b4157f1 | Update the conditional deploy | [
{
"change_type": "MODIFY",
"old_path": "cloudbuild.yaml",
"new_path": "cloudbuild.yaml",
"diff": "# limitations under the License.\nsteps:\n- # Generate the website\n+ # Generate the website.\n- name: 'gcr.io/gvisor-website/hugo:0.53'\nargs: [\"make\"]\n- # Test the HTML for issues\n+ # Test the HTM... | Go | Apache License 2.0 | google/gvisor | Update the conditional deploy |
259,985 | 02.04.2019 16:45:27 | 25,200 | d14a7de65865e14383e3c4e68400446189b2e5e8 | Fix more data races in shm debug messages. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/shm/shm.go",
"new_path": "pkg/sentry/kernel/shm/shm.go",
"diff": "@@ -286,7 +286,7 @@ func (r *Registry) remove(s *Shm) {\ndefer s.mu.Unlock()\nif s.key != linux.IPC_PRIVATE {\n- panic(fmt.Sprintf(\"Attempted to remove shm segment %d (key=%d)... | Go | Apache License 2.0 | google/gvisor | Fix more data races in shm debug messages.
PiperOrigin-RevId: 241630409
Change-Id: Ie0df5f5a2f20c2d32e615f16e2ba43c88f963181 |
259,858 | 02.04.2019 17:08:26 | 25,200 | 4ab738270aed18cf7aa111e2f53e9ca7f6a53a73 | Substitute true for return | [
{
"change_type": "MODIFY",
"old_path": "cloudbuild.yaml",
"new_path": "cloudbuild.yaml",
"diff": "@@ -25,4 +25,4 @@ steps:\nargs:\n- '-c'\n- |\n- [[ \"$BRANCH_NAME\" == \"master\" ]] && gcloud app deploy public/app.yaml || return 0\n+ [[ \"$BRANCH_NAME\" == \"master\" ]] && gcloud app deploy public/... | Go | Apache License 2.0 | google/gvisor | Substitute true for return |
259,854 | 02.04.2019 14:27:54 | 25,200 | da61580968c8a5862a28f29c5f95fe8a23fbd961 | Update user guide platform description to match architecture section.
syscall interception is an important part of the platform. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/platforms.md",
"new_path": "content/docs/user_guide/platforms.md",
"diff": "@@ -8,9 +8,9 @@ platform.\n## What is a Platform?\n-gVisor requires a *platform* to implement basic context switching and memory\n-mapping functionality. These ... | Go | Apache License 2.0 | google/gvisor | Update user guide platform description to match architecture section.
syscall interception is an important part of the platform. |
259,858 | 02.04.2019 17:57:26 | 25,200 | 811de2bbe57ff863b50dec4a0f2494afd551a89e | Ensure exact match for project | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -69,7 +69,7 @@ account](https://cloud.google.com/cloud-build/docs/securing-builds/set-service-a\n```\n{\n- PROJECT_NUMBER=$(gcloud projects list --filter=gvisor-website --format=\"value(projectNumber)\")\n+ PROJ... | Go | Apache License 2.0 | google/gvisor | Ensure exact match for project |
259,854 | 02.04.2019 18:03:01 | 25,200 | 9549ed31f9617ec10f85595f152022f0e550605d | Add docs for disabling external networking.
This is a useful feature for truly untrusted code. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/networking.md",
"new_path": "content/docs/user_guide/networking.md",
"diff": "@@ -33,4 +33,26 @@ Add the following `runtimeArgs` to your Docker configuration\n}\n```\n+## Disabling external networking\n+\n+To completely isolate the host... | Go | Apache License 2.0 | google/gvisor | Add docs for disabling external networking.
This is a useful feature for truly untrusted code. |
259,884 | 03.04.2019 00:53:36 | 14,400 | d369412917fdc2bb87037358b225b3897a515ee8 | Remove parse-syscall-annotations tool for now
Some more work needs to be done for generating syscall compatibility
reference documentation. | [
{
"change_type": "DELETE",
"old_path": "cmd/parse-syscall-annotations/.gitignore",
"new_path": null,
"diff": "-parse-syscall-annotations\n"
},
{
"change_type": "DELETE",
"old_path": "cmd/parse-syscall-annotations/main.go",
"new_path": null,
"diff": "-// Copyright 2018 Google LLC\... | Go | Apache License 2.0 | google/gvisor | Remove parse-syscall-annotations tool for now
Some more work needs to be done for generating syscall compatibility
reference documentation. |
259,884 | 03.04.2019 02:10:26 | 14,400 | 95e9f1e2d83a630cb7fe280a6c971b97bb31f1b0 | Update Kubernetes doc page
Add info on RuntimeClass
Add section headers to clearly show content organization | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/kubernetes.md",
"new_path": "content/docs/user_guide/kubernetes.md",
"diff": "title = \"Kubernetes\"\nweight = 30\n+++\n-gVisor can run sandboxed containers in a Kubernetes cluster with Minikube. After\n-the gVisor addon is enabled, pod... | Go | Apache License 2.0 | google/gvisor | Update Kubernetes doc page
- Add info on RuntimeClass
- Add section headers to clearly show content organization |
259,884 | 03.04.2019 01:48:18 | 14,400 | 5f7f96b50bf797cac2fb40262c7b69f8ad7025f9 | Add a /syscall redirect to compatibility docs
/syscall -> /docs/user_guide/compatibility/amd64
/syscall/amd64 -> /docs/user_guide/compatibility/amd64
/syscall/amd64/.* -> /docs/user_guide/compatibility/amd64/#%s | [
{
"change_type": "MODIFY",
"old_path": "cmd/gvisor-website/main.go",
"new_path": "cmd/gvisor-website/main.go",
"diff": "@@ -30,17 +30,24 @@ var redirects = map[string]string{\n\"/cl\": \"https://gvisor-review.googlesource.com/\",\n\"/issue\": \"https://github.com/google/gvisor/issues\",\n\"/issue/ne... | Go | Apache License 2.0 | google/gvisor | Add a /syscall redirect to compatibility docs
/syscall -> /docs/user_guide/compatibility/amd64
/syscall/amd64 -> /docs/user_guide/compatibility/amd64
/syscall/amd64/.* -> /docs/user_guide/compatibility/amd64/#%s |
259,858 | 03.04.2019 00:14:55 | 25,200 | 6eb84a20ba51d9725f79a9b2b47e0de1af450667 | Update lead text
The text fully-virtualized may be taken to mean virtualized hardware, so drop that. | [
{
"change_type": "MODIFY",
"old_path": "content/_index.html",
"new_path": "content/_index.html",
"diff": "@@ -13,7 +13,7 @@ description = \"A container sandbox runtime focused on security, efficiency, and\n{{< /blocks/cover >}}\n{{% blocks/lead color=\"secondary\" %}}\n-gVisor is an open-source, <a ... | Go | Apache License 2.0 | google/gvisor | Update lead text
The text fully-virtualized may be taken to mean virtualized hardware, so drop that. |
259,891 | 03.04.2019 11:48:33 | 25,200 | c79e81bd27cd9cccddb0cece30bf47efbfca41b7 | Addresses data race in tty implementation.
Also makes the safemem reading and writing inline, as it makes it easier to see
what locks are held. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tty/queue.go",
"new_path": "pkg/sentry/fs/tty/queue.go",
"diff": "@@ -63,49 +63,6 @@ type queue struct {\ntransformer\n}\n-// ReadToBlocks implements safemem.Reader.ReadToBlocks.\n-func (q *queue) ReadToBlocks(dst safemem.BlockSeq) (uint64, error... | Go | Apache License 2.0 | google/gvisor | Addresses data race in tty implementation.
Also makes the safemem reading and writing inline, as it makes it easier to see
what locks are held.
PiperOrigin-RevId: 241775201
Change-Id: Ib1072f246773ef2d08b5b9a042eb7e9e0284175c |
259,891 | 03.04.2019 11:09:07 | 25,200 | 51bfff9f74e3e25a05d070bae19b89aef2187643 | Remove unnecessary curly braces around bash commands. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": "content/docs/includes/install_gvisor.md",
"diff": "@@ -16,13 +16,11 @@ user `nobody` to avoid unnecessary privileges. The `/usr/local/bin` directory is\na good place to put the `runsc` binary.\n```bash\n-{... | Go | Apache License 2.0 | google/gvisor | Remove unnecessary curly braces around bash commands. |
259,884 | 03.04.2019 03:37:27 | 14,400 | 0fa5356531014baa82606c15fcc401cd5012ef84 | Only deploy if in the gvisor-website project | [
{
"change_type": "MODIFY",
"old_path": "cloudbuild.yaml",
"new_path": "cloudbuild.yaml",
"diff": "@@ -24,5 +24,4 @@ steps:\nentrypoint: 'bash'\nargs:\n- '-c'\n- - |\n- [[ \"$BRANCH_NAME\" == \"master\" ]] && gcloud app deploy public/app.yaml || true\n+ - 'if [[ \"$PROJECT_ID\" == \"gvisor-website\" ... | Go | Apache License 2.0 | google/gvisor | Only deploy if in the gvisor-website project |
259,854 | 03.04.2019 10:51:34 | 25,200 | 6592608d3ca9353ded2c18b92969760a24a8a727 | Add required version to Docker user guide. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/docker.md",
"new_path": "content/docs/user_guide/docker.md",
"diff": "@@ -11,8 +11,8 @@ gVisor with the default platform.\n## Configuring Docker\n-> Note: This guide requires Docker. Refer to the [Docker documentation][docker] for\n-> h... | Go | Apache License 2.0 | google/gvisor | Add required version to Docker user guide. |
259,881 | 03.04.2019 18:05:30 | 25,200 | 9cf33960fc61309140a67587748570a36e78fc75 | Only CopyOut CPU when it changes
This will save copies when preemption is not caused by a CPU migration. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/rseq.go",
"new_path": "pkg/sentry/kernel/rseq.go",
"diff": "@@ -88,6 +88,7 @@ func (t *Task) RSEQCPUAddr() usermem.Addr {\nfunc (t *Task) SetRSEQCPUAddr(addr usermem.Addr) error {\nt.rseqCPUAddr = addr\nif addr != 0 {\n+ t.rseqCPU = int32(hos... | Go | Apache License 2.0 | google/gvisor | Only CopyOut CPU when it changes
This will save copies when preemption is not caused by a CPU migration.
PiperOrigin-RevId: 241844399
Change-Id: I2ba3b64aa377846ab763425bd59b61158f576851 |
259,992 | 03.04.2019 09:13:14 | 25,200 | 8f8fc33a874b16d529dfacecdd6b34a42c98d514 | Update install_gvisor.md | [
{
"change_type": "MODIFY",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": "content/docs/includes/install_gvisor.md",
"diff": "@@ -11,7 +11,7 @@ With corresponding SHA512 checksums here:\n`https://storage.googleapis.com/gvisor/releases/nightly/${yyyy-mm-dd}/runsc.sha512`\n**It is ... | Go | Apache License 2.0 | google/gvisor | Update install_gvisor.md |
259,858 | 04.04.2019 14:22:32 | 25,200 | e9508967b0a1c9a8398adf5f6c28be79353f8a1f | Format workspace | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "# Load go bazel rules and gazelle.\nload(\"@bazel_tools//tools/build_defs/repo:http.bzl\", \"http_archive\")\n+\nhttp_archive(\nname = \"io_bazel_rules_go\",\n- url = \"https://github.com/bazelbuild/rules_go/releas... | Go | Apache License 2.0 | google/gvisor | Format workspace
Change-Id: Ibb77656c46942eb123cd6cff8b471a526468d2dd
PiperOrigin-RevId: 242007583 |
259,858 | 04.04.2019 17:04:30 | 25,200 | 75c8ac38e0f6cc4eb3726c89aee41357cd592c4b | BUILD: Add useful go_path target | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "+package(licenses = [\"notice\"]) # Apache 2.0\n+\n+load(\"@io_bazel_rules_go//go:def.bzl\", \"go_path\")\n+\n# The sandbox filegroup is used for sandbox-internal dependencies.\npackage_group(\nname = \"sandbox\",\n@@ -5,3... | Go | Apache License 2.0 | google/gvisor | BUILD: Add useful go_path target
Change-Id: Ibd6d8a1a63826af6e62a0f0669f8f0866c8091b4
PiperOrigin-RevId: 242037969 |
259,881 | 04.04.2019 17:13:31 | 25,200 | 75a5ccf5d98876c26305da0feff20e4a148027ec | Remove defer from trivial ThreadID methods
In particular, ns.IDOfTask and tg.ID are used for gettid and getpid,
respectively, where removing defer saves ~100ns. This may be a small
improvement to application logging, which may call gettid/getpid
frequently. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/threads.go",
"new_path": "pkg/sentry/kernel/threads.go",
"diff": "@@ -196,8 +196,9 @@ func (ns *PIDNamespace) NewChild(userns *auth.UserNamespace) *PIDNamespace {\n// task has that TID, TaskWithID returns nil.\nfunc (ns *PIDNamespace) TaskWit... | Go | Apache License 2.0 | google/gvisor | Remove defer from trivial ThreadID methods
In particular, ns.IDOfTask and tg.ID are used for gettid and getpid,
respectively, where removing defer saves ~100ns. This may be a small
improvement to application logging, which may call gettid/getpid
frequently.
PiperOrigin-RevId: 242039616
Change-Id: I860beb62db3fe077519835e6bafa7c74cba6ca80 |
259,853 | 04.04.2019 17:42:51 | 25,200 | 88409e983c463b6d9c8085e7fdbe7ff45b3c5184 | gvisor: Add support for the MS_NOEXEC mount option | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/context.go",
"new_path": "pkg/sentry/fs/context.go",
"diff": "@@ -46,6 +46,11 @@ func ContextCanAccessFile(ctx context.Context, inode *Inode, reqPerms PermMask)\np = uattr.Perms.Group\n}\n+ // Do not allow programs to be executed if MS_NOEXEC is ... | Go | Apache License 2.0 | google/gvisor | gvisor: Add support for the MS_NOEXEC mount option
https://github.com/google/gvisor/issues/145
PiperOrigin-RevId: 242044115
Change-Id: I8f140fe05e32ecd438b6be218e224e4b7fe05878 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.