author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,884 | 03.04.2019 22:33:28 | 14,400 | 896812ebe2e0d435aafba96aeb08152a16579a70 | Adjust font sizes for headers | [
{
"change_type": "MODIFY",
"old_path": "assets/scss/_styles_project.scss",
"new_path": "assets/scss/_styles_project.scss",
"diff": "@@ -67,7 +67,7 @@ a.doc-table-anchor {\n@media (min-width: 768px) {\nwidth: 50%;\n}\n- font-size: 2rem;\n+ font-size: $h1-font-size;\n}\n.td-default main section.td-cov... | Go | Apache License 2.0 | google/gvisor | Adjust font sizes for headers |
259,858 | 04.04.2019 21:46:15 | 25,200 | f28db3f7755e46056b12ba45cffce700873dca4e | Remove confusing fully- prefix | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/_index.md",
"new_path": "content/docs/architecture_guide/_index.md",
"diff": "title = \"Architecture Guide\"\nweight = 20\n+++\n-gVisor provides a fully-virtualized environment in order to sandbox untrusted\n+gVisor provides a v... | Go | Apache License 2.0 | google/gvisor | Remove confusing fully- prefix |
259,884 | 03.04.2019 02:32:50 | 14,400 | 383e6cbd07181e8df4987a7b0bad8889e6731afa | Updated README to be more contributor friendly
Remove doc about deploying and running Cloud Builds since that is
mostly handled by CI.
Re-organize to have info on contributing first. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -21,8 +21,6 @@ public:\npublic/app.yaml: public\ncp -vr cmd/gvisor-website/app.yaml public/\n-\n-\n# Load repositories.\nupstream:\nmkdir -p upstream\n@@ -44,29 +42,38 @@ content/docs/community/sigs: upstream/comm... | Go | Apache License 2.0 | google/gvisor | Updated README to be more contributor friendly
- Remove doc about deploying and running Cloud Builds since that is
mostly handled by CI.
- Re-organize to have info on contributing first. |
259,992 | 02.04.2019 21:16:28 | 25,200 | f4135148a842066ba9399e41bf030a650c291f49 | Expand user guide landing page | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/_index.md",
"new_path": "content/docs/user_guide/_index.md",
"diff": "@@ -3,6 +3,10 @@ title = \"User Guide\"\nweight = 10\n+++\n-Using gVisor for the first time? To get started, use either the [Docker Quick\n-Start](./docker/), the [OC... | Go | Apache License 2.0 | google/gvisor | Expand user guide landing page |
259,992 | 04.04.2019 16:51:50 | 25,200 | a5852fe8fa01500627308b9ae8732d579527fd56 | Add runsc debug commands to Debugging section | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/debugging.md",
"new_path": "content/docs/user_guide/debugging.md",
"diff": "@@ -31,3 +31,73 @@ sudo systemctl restart docker\nRun your container again, and inspect the files under `/tmp/runsc`. The log file\nwith name `boot` will contai... | Go | Apache License 2.0 | google/gvisor | Add runsc debug commands to Debugging section |
259,885 | 05.04.2019 17:53:24 | 25,200 | 124bafc81c7291d31cbe2a74f9bda155d0f71469 | Deflake PtraceTest.SeizeSetOptions. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/ptrace.cc",
"new_path": "test/syscalls/linux/ptrace.cc",
"diff": "@@ -1152,10 +1152,46 @@ TEST(PtraceTest, SeizeSetOptions) {\nEXPECT_TRUE(WIFSTOPPED(status) && WSTOPSIG(status) == (SIGTRAP | 0x80))\n<< \" status \" << status;\n- // SIGKILL... | Go | Apache License 2.0 | google/gvisor | Deflake PtraceTest.SeizeSetOptions.
PiperOrigin-RevId: 242226319
Change-Id: Iefc78656841315f6b7d48bd85db451486850264d |
259,992 | 03.04.2019 12:18:46 | 25,200 | 37433204a8ecda68ea2164315686006240bf11aa | Edits to user guide + added filesystem section | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/FAQ.md",
"new_path": "content/docs/user_guide/FAQ.md",
"diff": "@@ -20,12 +20,13 @@ not realize a new file was copied to a given directory. To invalidate the cache\nand force a refresh, create a file under the directory in question and ... | Go | Apache License 2.0 | google/gvisor | Edits to user guide + added filesystem section |
259,885 | 08.04.2019 16:31:06 | 25,200 | 9471c013483b0709479c51d470ac840621ae7d46 | Export kernel.SignalInfoPriv.
Also add kernel.SignalInfoNoInfo, and use it in RLIMIT_FSIZE checks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/tty.go",
"new_path": "pkg/sentry/fs/host/tty.go",
"diff": "@@ -344,11 +344,8 @@ func (t *TTYFileOperations) checkChange(ctx context.Context, sig linux.Signal) e\n// 040b6362d58f \"tty: fix leakage of -ERESTARTSYS to userland\" doesn't\n// ap... | Go | Apache License 2.0 | google/gvisor | Export kernel.SignalInfoPriv.
Also add kernel.SignalInfoNoInfo, and use it in RLIMIT_FSIZE checks.
PiperOrigin-RevId: 242562428
Change-Id: I4887c0e1c8f5fddcabfe6d4281bf76d2f2eafe90 |
259,962 | 09.04.2019 11:22:28 | 25,200 | eaac2806ffadbb3db6317e58c61b855b1350f0aa | Add TCP checksum verification. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -154,6 +154,7 @@ var Metrics = tcpip.Stats{\nSlowStartRetransmits: mustCreateMetric(\"/netstack/tcp/slow_start_retransmits\", \"Number of segments retran... | Go | Apache License 2.0 | google/gvisor | Add TCP checksum verification.
PiperOrigin-RevId: 242704699
Change-Id: I87db368ca343b3b4bf4f969b17d3aa4ce2f8bd4f |
259,853 | 09.04.2019 11:30:35 | 25,200 | 93b3c9b76c16104cbb5cc55b6f2339cb43c356b5 | runsc: set UID and GID if gofer is executed in a new user namespace
Otherwise, we will not have capabilities in the user namespace.
And this patch adds the noexec option for mounts. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -866,8 +866,13 @@ func (c *Container) createGoferProcess(spec *specs.Spec, conf *boot.Config, bund\n// Setup any uid/gid mappings, and create or join the configured user\n//... | Go | Apache License 2.0 | google/gvisor | runsc: set UID and GID if gofer is executed in a new user namespace
Otherwise, we will not have capabilities in the user namespace.
And this patch adds the noexec option for mounts.
https://github.com/google/gvisor/issues/145
PiperOrigin-RevId: 242706519
Change-Id: I1b78b77d6969bd18038c71616e8eb7111b71207c |
259,881 | 09.04.2019 12:51:13 | 25,200 | 3513350de63079505a1ad142942cc50ae8e511dc | Specify /proc explicitly | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/security.md",
"new_path": "content/docs/architecture_guide/security.md",
"diff": "@@ -37,8 +37,8 @@ might involve some combination of the following:\n1. Racing with multiple threads in order to hit specific code paths.\nFor exam... | Go | Apache License 2.0 | google/gvisor | Specify /proc explicitly |
259,859 | 09.04.2019 14:56:04 | 25,200 | b3b140ea4f9e1b632463cbf83c97f58464eceeac | syscalls: sendfile: limit the count to MAX_RW_COUNT
From sendfile spec and also the linux kernel code, we should
limit the count arg to 'MAX_RW_COUNT'. This patch export
'MAX_RW_COUNT' in kernel pkg and use it in the implementation
of sendfile syscall. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_usermem.go",
"new_path": "pkg/sentry/kernel/task_usermem.go",
"diff": "@@ -22,10 +22,10 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/syserror\"\n)\n-// _MAX_RW_COUNT is the maximum size in bytes of a single read or write.\n+// MAX_R... | Go | Apache License 2.0 | google/gvisor | syscalls: sendfile: limit the count to MAX_RW_COUNT
From sendfile spec and also the linux kernel code, we should
limit the count arg to 'MAX_RW_COUNT'. This patch export
'MAX_RW_COUNT' in kernel pkg and use it in the implementation
of sendfile syscall.
Signed-off-by: Li Qiang <pangpei.lq@antfin.com>
Change-Id: I1086fec0685587116984555abd22b07ac233fbd2
PiperOrigin-RevId: 242745831 |
259,881 | 09.04.2019 16:25:03 | 25,200 | 0e14e48b84fd8f759bb5a0f5261cdb090d1ffe90 | Match multi-word State
From a recent test failure:
"State:\tD (disk sleep)\n"
"disk sleep" does not match \w+. We need to allow spaces. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -99,8 +99,11 @@ std::vector<std::string> saved_argv; // NOLINT\nvoid CompareProcessState(absl::string_view state, int pid) {\nauto status_file = ASSERT_NO_ERRNO_AND_VALUE(\nGe... | Go | Apache License 2.0 | google/gvisor | Match multi-word State
From a recent test failure:
"State:\tD (disk sleep)\n"
"disk sleep" does not match \w+. We need to allow spaces.
PiperOrigin-RevId: 242762469
Change-Id: Ic8d05a16669412a72c1e76b498373e5b22fe64c4 |
259,912 | 10.04.2019 10:48:28 | 25,200 | 7140b1fdca1cc9c9c711955a49e6e7fc41f339d9 | Fixed /proc/cpuinfo permissions
This also applies these permissions to other static proc files. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/inode.go",
"new_path": "pkg/sentry/fs/fsutil/inode.go",
"diff": "@@ -452,3 +452,15 @@ type InodeGenericChecker struct{}\nfunc (InodeGenericChecker) Check(ctx context.Context, inode *fs.Inode, p fs.PermMask) bool {\nreturn fs.ContextCanAcce... | Go | Apache License 2.0 | google/gvisor | Fixed /proc/cpuinfo permissions
This also applies these permissions to other static proc files.
Change-Id: I4167e585fed49ad271aa4e1f1260babb3239a73d
PiperOrigin-RevId: 242898575 |
259,891 | 10.04.2019 12:35:43 | 25,200 | f7aff0aaa4320505933df838cf5b551b69d5e513 | Allow threads with CAP_SYS_RESOURCE to raise hard rlimits. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_map_test.go",
"new_path": "pkg/sentry/kernel/fd_map_test.go",
"diff": "@@ -40,7 +40,7 @@ func newTestFDMap() *FDMap {\nfunc TestFDMapMany(t *testing.T) {\nfile := filetest.NewTestFile(t)\nlimitSet := limits.NewLimitSet()\n- limitSet.Set(li... | Go | Apache License 2.0 | google/gvisor | Allow threads with CAP_SYS_RESOURCE to raise hard rlimits.
PiperOrigin-RevId: 242919489
Change-Id: Ie3267b3bcd8a54b54bc16a6556369a19e843376f |
259,891 | 10.04.2019 16:33:44 | 25,200 | c8368e477b8f2dedaadacbd6efbb455879c9b1d6 | rlimits test: don't exceed nr_open.
Even superuser cannot raise RLIMIT_NOFILE above /proc/sys/fs/nr_open, so
start the test by lowering the limits before raising. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/rlimits.cc",
"new_path": "test/syscalls/linux/rlimits.cc",
"diff": "@@ -29,6 +29,12 @@ TEST(RlimitTest, SetRlimitHigher) {\nstruct rlimit rl = {};\nEXPECT_THAT(getrlimit(RLIMIT_NOFILE, &rl), SyscallSucceeds());\n+ // Lower the rlimit first,... | Go | Apache License 2.0 | google/gvisor | rlimits test: don't exceed nr_open.
Even superuser cannot raise RLIMIT_NOFILE above /proc/sys/fs/nr_open, so
start the test by lowering the limits before raising.
Change-Id: Ied6021c64178a6cb9098088a1a3384db523a226f
PiperOrigin-RevId: 242965249 |
259,992 | 04.04.2019 10:45:10 | 25,200 | 644a73cb468acca68a78ae0a881c7eb5bd16e750 | Added "Powered by gVisor" image to footer | [
{
"change_type": "MODIFY",
"old_path": "layouts/partials/footer.html",
"new_path": "layouts/partials/footer.html",
"diff": "<div class=\"col-6 col-sm-4 text-right text-xs-center order-sm-3\">\n{{ with $links }}\n{{ with index . \"developer\"}}\n+ <ul class=\"list-inline mb-0\">\n{{ template \"footer... | Go | Apache License 2.0 | google/gvisor | Added "Powered by gVisor" image to footer |
259,858 | 11.04.2019 13:35:34 | 25,200 | fab6352ac8de0b2c1e1e01563602912b69bdb249 | README: add build badge | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -36,6 +36,8 @@ be found at [gvisor.dev][gvisor-dev].\n## Installing from source\n+[](https://storage.googleapis.com/gvisor-build-badges/buil... | Go | Apache License 2.0 | google/gvisor | README: add build badge
Change-Id: Ie6b73ac729c8c85b1229e09da5b113be9780fa95
PiperOrigin-RevId: 243131814 |
259,858 | 11.04.2019 14:17:03 | 25,200 | efacb8d900cd7b5ca53e5a96b65ba78a368efc02 | CONTRIBUTING: add style guide pointer | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -32,7 +32,9 @@ directory tree.\n### Coding Guidelines\n-All code should conform to the [Go style guidelines][gostyle].\n+All Go code should conform to the [Go style guidelines][gostyle]. C++ code\n+s... | Go | Apache License 2.0 | google/gvisor | CONTRIBUTING: add style guide pointer
Change-Id: I93a78a6b2bb2eaa69046c6cfecee2e4cfcf20e44
PiperOrigin-RevId: 243140359 |
259,858 | 11.04.2019 18:54:14 | 25,200 | 4e9c131c589d02cb3360d8cd43449e5a58a8e882 | Use HUGO_ENV="production" to avoid noindex header | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -43,7 +43,7 @@ $(GO_TARGET): public $(GO_SOURCE)\ncd cmd/gvisor-website && find . -name \"*.go\" -exec cp --parents \\{\\} ../../public \\;\npublic/static: node_modules config.toml $(shell find archetypes assets c... | Go | Apache License 2.0 | google/gvisor | Use HUGO_ENV="production" to avoid noindex header |
259,944 | 12.04.2019 14:55:11 | 25,200 | 14f1de4a45daa75ef016fabb56d86cbd9b902504 | Also push the shim v2 binary to the GCS bucket. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -7,7 +7,9 @@ SOURCES=$(shell find cmd/ pkg/ vendor/ -name '*.go')\nDEPLOY_PATH=cri-containerd-staging/gvisor-containerd-shim\nVERSION=$(shell git rev-parse HEAD)\n-all: bin/gvisor-containerd-shim bin/containerd-sh... | Go | Apache License 2.0 | google/gvisor | Also push the shim v2 binary to the GCS bucket. (#23)
Signed-off-by: Lantao Liu <lantaol@google.com> |
259,884 | 14.04.2019 18:51:22 | 14,400 | 676d4dc5a31ac9e2edec8cd1ee051f61606c66a7 | Add troubleshooting section to README (fixes | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -55,10 +55,24 @@ If you have Go installed you can run a local version of the website via the\n`public/` directory.\n```\n-{\ncd public/\ngo run main.go\n-}\n```\nAccess the site at http://localhost:8080\n+\n+## ... | Go | Apache License 2.0 | google/gvisor | Add troubleshooting section to README (fixes #28) |
259,884 | 14.04.2019 18:43:24 | 14,400 | 0e00a7d2da990ef8bd846c19c9a286539ad819a3 | Add some basic questions to the FAQ
Adds some basic questions and answers to the FAQ about supported CPU
architectures and binary formats.
Adds a variable and shortcode for the minimium required Linux version. | [
{
"change_type": "MODIFY",
"old_path": "config.toml",
"new_path": "config.toml",
"diff": "@@ -137,3 +137,6 @@ no = 'Sorry to hear that. Please <a href=\"https://github.com/USERNAME/REPOSITORY\nurl = \"https://groups.google.com/forum/#!forum/gvisor-dev\"\nicon = \"fa fa-envelope\"\ndesc = \"Get info ... | Go | Apache License 2.0 | google/gvisor | Add some basic questions to the FAQ
- Adds some basic questions and answers to the FAQ about supported CPU
architectures and binary formats.
- Adds a variable and shortcode for the minimium required Linux version. |
259,884 | 12.04.2019 23:19:26 | 14,400 | 80036845c18e1e41e3610cf2ff4a25345f444070 | Install gVisor using a subshell.
If the user copy-and-pastes the commands to install gVisor in one go,
the commands should stop early if there is an error. Particularly, if
the runsc sha does not match. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": "content/docs/includes/install_gvisor.md",
"diff": "@@ -14,11 +14,14 @@ as user `nobody` to avoid unnecessary privileges. The `/usr/local/bin` directory\na good place to put the `runsc` binary.\n```bash\n+(... | Go | Apache License 2.0 | google/gvisor | Install gVisor using a subshell.
If the user copy-and-pastes the commands to install gVisor in one go,
the commands should stop early if there is an error. Particularly, if
the runsc sha does not match. |
259,992 | 17.04.2019 11:14:24 | 25,200 | 9f8c89fc7fb7c4588713eb376fa56c4c3026d43c | Return error from fdbased.New
RELNOTES: n/a | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -136,10 +136,9 @@ type Options struct {\n//\n// Makes fd non-blocking, but does not take ownership of fd, which must remain\n// open for the lifetime of the retu... | Go | Apache License 2.0 | google/gvisor | Return error from fdbased.New
RELNOTES: n/a
PiperOrigin-RevId: 244031742
Change-Id: Id0cdb73194018fb5979e67b58510ead19b5a2b81 |
259,992 | 16.04.2019 15:44:35 | 25,200 | 45028bdd82ca3f54d8bb0e99330b1bab6e64cb78 | Update Linux version requirement for GSO | [
{
"change_type": "MODIFY",
"old_path": "config.toml",
"new_path": "config.toml",
"diff": "@@ -139,4 +139,4 @@ no = 'Sorry to hear that. Please <a href=\"https://github.com/USERNAME/REPOSITORY\ndesc = \"Get info on the development of gVisor\"\n[params.vars]\n-required_linux = \"3.17+\"\n+required_lin... | Go | Apache License 2.0 | google/gvisor | Update Linux version requirement for GSO |
259,992 | 17.04.2019 12:56:23 | 25,200 | c8cee7108f1a1b37e89961c6dd69ccab97952c86 | Use FD limit and file size limit from host
FD limit and file size limit is read from the host, instead
of using hard-coded defaults, given that they effect the sandbox
process. Also limit the direct cache to use no more than half
if the available FDs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/BUILD",
"new_path": "pkg/sentry/fs/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_library(\n\"dentry.go\",\n\"dirent.go\",\n\"dirent_cache.go\",\n+ \"dirent_cache_limiter.go\",\n\"dirent_list.go\",\n\"dirent_state.go\",\n\"event_list.go\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Use FD limit and file size limit from host
FD limit and file size limit is read from the host, instead
of using hard-coded defaults, given that they effect the sandbox
process. Also limit the direct cache to use no more than half
if the available FDs.
PiperOrigin-RevId: 244050323
Change-Id: I787ad0fdf07c49d589e51aebfeae477324fe26e6 |
259,854 | 18.04.2019 11:50:26 | 25,200 | 133700007a8495c7d8df53801b1d34345d6c5cf8 | Only emit unimplemented syscall events for unsupported values.
Only emit unimplemented syscall events for setting SO_OOBINLINE and SO_LINGER
when attempting to set unsupported values. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -247,6 +247,15 @@ type SockAddrUnix struct {\nPath [UnixPathMax]int8\n}\n+// Linger is struct linger, from include/linux/socket.h.\n+type Linger struct {\n+ OnOff int32\n+ Linger int3... | Go | Apache License 2.0 | google/gvisor | Only emit unimplemented syscall events for unsupported values.
Only emit unimplemented syscall events for setting SO_OOBINLINE and SO_LINGER
when attempting to set unsupported values.
PiperOrigin-RevId: 244229675
Change-Id: Icc4562af8f733dd75a90404621711f01a32a9fc1 |
259,881 | 18.04.2019 15:22:47 | 25,200 | c931c8e0829914718a729e20d7db0c2bf4e73f0b | Format struct pollfd in poll(2)/ppoll(2)
I0410 15:40:38.854295 3776 x:0] [ 1] poll_test E poll(0x2b00bfb5c020 [{FD: 0x3 anon_inode:[eventfd], Events: POLLOUT, REvents: ...}], 0x1, 0x1)
I0410 15:40:38.854348 3776 x:0] [ 1] poll_test X poll(0x2b00bfb5c020 [{FD: 0x3 anon_inode:[eventfd], Events: POLLOUT|POLLERR|POLLHUP, REvents: POLLOUT}], 0x1, 0x1) = 0x1 (10.765?s) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/BUILD",
"new_path": "pkg/sentry/strace/BUILD",
"diff": "@@ -11,6 +11,7 @@ go_library(\n\"futex.go\",\n\"linux64.go\",\n\"open.go\",\n+ \"poll.go\",\n\"ptrace.go\",\n\"signal.go\",\n\"socket.go\",\n"
},
{
"change_type": "MODIFY",
"... | Go | Apache License 2.0 | google/gvisor | Format struct pollfd in poll(2)/ppoll(2)
I0410 15:40:38.854295 3776 x:0] [ 1] poll_test E poll(0x2b00bfb5c020 [{FD: 0x3 anon_inode:[eventfd], Events: POLLOUT, REvents: ...}], 0x1, 0x1)
I0410 15:40:38.854348 3776 x:0] [ 1] poll_test X poll(0x2b00bfb5c020 [{FD: 0x3 anon_inode:[eventfd], Events: POLLOUT|POLLERR|POLLHUP, REvents: POLLOUT}], 0x1, 0x1) = 0x1 (10.765?s)
PiperOrigin-RevId: 244269879
Change-Id: If07ba54a486fdeaaedfc0123769b78d1da862307 |
259,974 | 18.04.2019 16:20:45 | 25,200 | f4d434c18002c96511decf8ff1ebdbede46ca6a1 | Enable vDSO support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "vdso/BUILD",
"new_path": "vdso/BUILD",
"diff": "@@ -12,6 +12,11 @@ config_setting(\nconstraint_values = [\"@bazel_tools//platforms:x86_64\"],\n)\n+config_setting(\n+ name = \"aarch64\",\n+ constraint_values = [\"@bazel_tools//platforms:aarch64\"],\n+)\n+\ngenr... | Go | Apache License 2.0 | google/gvisor | Enable vDSO support on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I20103cd6d193431ab7e8120005da1f567b9bc2eb
PiperOrigin-RevId: 244280119 |
259,899 | 18.04.2019 17:48:54 | 25,200 | cec2cdc12f30e87e5b0f6750fe1c132d89fcfb6d | tcpip/transport/udp: add Forwarder type
Add a UDP forwarder for intercepting and forwarding UDP sessions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet_test.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet_test.go",
"diff": "@@ -222,6 +222,62 @@ func TestCloseReaderWithForwarder(t *testing.T) {\nsender.close()\n}\n+func TestUDPForwarder(t *testing.T) {\n+ s, terr := newLoopbackS... | Go | Apache License 2.0 | google/gvisor | tcpip/transport/udp: add Forwarder type
Add a UDP forwarder for intercepting and forwarding UDP sessions.
Change-Id: I2d83c900c1931adfc59a532dd4f6b33a0db406c9
PiperOrigin-RevId: 244293576 |
259,854 | 19.04.2019 16:15:37 | 25,200 | 358eb52a76ebd41baf52972f901af0ff398e131b | Add support for the MSG_TRUNC msghdr flag.
The MSG_TRUNC flag is set in the msghdr when a message is truncated.
Fixes google/gvisor#200 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -376,7 +376,7 @@ func (s *SocketOperations) Read(ctx context.Context, _ *fs.File, dst usermem.IOS\nif dst.NumBytes() == 0 {\nreturn 0, nil\n}\n- n, _, _,... | Go | Apache License 2.0 | google/gvisor | Add support for the MSG_TRUNC msghdr flag.
The MSG_TRUNC flag is set in the msghdr when a message is truncated.
Fixes google/gvisor#200
PiperOrigin-RevId: 244440486
Change-Id: I03c7d5e7f5935c0c6b8d69b012db1780ac5b8456 |
259,881 | 22.04.2019 18:17:25 | 25,200 | f86c35a51ff92718e36ff6075339300be11e09b3 | Clean up state error handling | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/state.go",
"new_path": "pkg/sentry/control/state.go",
"diff": "@@ -64,7 +64,7 @@ func (s *State) Save(o *SaveOpts, _ *struct{}) error {\nlog.Infof(\"Save succeeded: exiting...\")\n} else {\nlog.Warningf(\"Save failed: exiting...\")\n- s.Kern... | Go | Apache License 2.0 | google/gvisor | Clean up state error handling
PiperOrigin-RevId: 244773836
Change-Id: I32223f79d2314fe1ac4ddfc63004fc22ff634adf |
259,884 | 22.04.2019 01:07:33 | 14,400 | e986ad2f37767bea14e86f0cb388aeba051fd9eb | Redirect www.gvisor.dev to gvisor.dev | [
{
"change_type": "MODIFY",
"old_path": "cmd/gvisor-website/main.go",
"new_path": "cmd/gvisor-website/main.go",
"diff": "@@ -23,6 +23,7 @@ import (\n\"net/http\"\n\"os\"\n\"regexp\"\n+ \"strings\"\n)\nvar redirects = map[string]string{\n@@ -56,6 +57,20 @@ func redirectWithQuery(w http.ResponseWriter,... | Go | Apache License 2.0 | google/gvisor | Redirect www.gvisor.dev to gvisor.dev |
259,884 | 22.04.2019 22:42:46 | 14,400 | 7853b971d43f773002ea92ecc95af7becd9dac55 | Fix some html errors (refs
Fix duplicate main_navbar id on top page.
Fix missing ';' in nbsp entity in footer.
Fix nested <a> tags in checkpoint/restore doc.
Fix nested <p> tags on top page feature blocks.
Add '--check-html' option to htmlproofer build step. | [
{
"change_type": "MODIFY",
"old_path": "cloudbuild.yaml",
"new_path": "cloudbuild.yaml",
"diff": "@@ -18,7 +18,7 @@ steps:\nargs: [\"make\"]\n# Test the HTML for issues.\n- name: 'gcr.io/gvisor-website/html-proofer:3.10.2'\n- args: [\"htmlproofer\", \"--disable-external\", \"public/static\"]\n+ args... | Go | Apache License 2.0 | google/gvisor | Fix some html errors (refs #46 #51)
- Fix duplicate main_navbar id on top page.
- Fix missing ';' in nbsp entity in footer.
- Fix nested <a> tags in checkpoint/restore doc.
- Fix nested <p> tags on top page feature blocks.
- Add '--check-html' option to htmlproofer build step. |
259,891 | 23.04.2019 11:32:34 | 25,200 | df21460cfdf589299e98171407741e3c253debe4 | Fix container_test flakes.
Create, Start, and Destroy were racing to create and destroy the
metadata directory of containers.
This is a re-upload of
but with the
correct account. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -99,7 +99,9 @@ type Container struct {\n// BundleDir is the directory containing the container bundle.\nBundleDir string `json:\"bundleDir\"`\n- // Root is the directory con... | Go | Apache License 2.0 | google/gvisor | Fix container_test flakes.
Create, Start, and Destroy were racing to create and destroy the
metadata directory of containers.
This is a re-upload of
https://gvisor-review.googlesource.com/c/gvisor/+/16260, but with the
correct account.
Change-Id: I16b7a9d0971f0df873e7f4145e6ac8f72730a4f1
PiperOrigin-RevId: 244892991 |
259,992 | 23.04.2019 16:10:05 | 25,200 | 908edee04f92055a8c53a63d1b8d57ffe56aa682 | Replace os.File with fd.FD in fsgofer
os.NewFile() accounts for 38% of CPU time in localFile.Walk().
This change switchs to use fd.FD which is much cheaper to create.
Now, fd.New() in localFile.Walk() accounts for only 4%. | [
{
"change_type": "MODIFY",
"old_path": "pkg/fd/fd.go",
"new_path": "pkg/fd/fd.go",
"diff": "@@ -167,6 +167,24 @@ func NewFromFile(file *os.File) (*FD, error) {\nreturn New(fd), nil\n}\n+// Open is equivallent to open(2).\n+func Open(path string, openmode int, perm uint32) (*FD, error) {\n+ f, err :=... | Go | Apache License 2.0 | google/gvisor | Replace os.File with fd.FD in fsgofer
os.NewFile() accounts for 38% of CPU time in localFile.Walk().
This change switchs to use fd.FD which is much cheaper to create.
Now, fd.New() in localFile.Walk() accounts for only 4%.
PiperOrigin-RevId: 244944983
Change-Id: Ic892df96cf2633e78ad379227a213cb93ee0ca46 |
259,992 | 23.04.2019 16:24:51 | 25,200 | db334f7154a1d4beedd8bd418a88c3f043ebe173 | Remove reflection from 9P serving path
p9.messageByType was taking 7% of p9.recv before, spending time
with reflection and map lookup. Now it's reduced to 1%. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/messages.go",
"new_path": "pkg/p9/messages.go",
"diff": "@@ -16,7 +16,7 @@ package p9\nimport (\n\"fmt\"\n- \"reflect\"\n+ \"math\"\n\"gvisor.googlesource.com/gvisor/pkg/fd\"\n)\n@@ -2140,7 +2140,7 @@ func (r *Rlconnect) String() string {\n}\n// message... | Go | Apache License 2.0 | google/gvisor | Remove reflection from 9P serving path
p9.messageByType was taking 7% of p9.recv before, spending time
with reflection and map lookup. Now it's reduced to 1%.
PiperOrigin-RevId: 244947313
Change-Id: I42813f920557b7656f8b29157eb32acd79e11fa5 |
259,992 | 23.04.2019 17:45:34 | 25,200 | 7c9c5fd36dbff21cf255aaf08278729b02613222 | Add Linux version to requirements section | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -45,6 +45,7 @@ architectures may become available in the future.\nMake sure the following dependencies are installed:\n+* Linux 4.14.77+ ([older linux][old-linux])\n* [git][git]\n* [Bazel][bazel] 0.18+\n* [Pytho... | Go | Apache License 2.0 | google/gvisor | Add Linux version to requirements section
PiperOrigin-RevId: 244959388
Change-Id: Ifb08678d975cf9f694a21012f9a1e9f45b1f197c |
259,884 | 23.04.2019 22:12:56 | 14,400 | 66cc254a8710cdaeb6e56bb45aec1e51f696660a | Fix feature block rendering (fixes
Render feature blocks as markdown again.
Feature block inner content is contained in a <div> rather than a <p>
to avoid nested <p> tags. | [
{
"change_type": "MODIFY",
"old_path": "content/_index.html",
"new_path": "content/_index.html",
"diff": "@@ -20,32 +20,32 @@ gVisor integrates with <a href=\"https://www.docker.com/\" target=\"_blank\" rel=\"no\n{{< blocks/section color=\"dark\" >}}\n-{{< blocks/feature icon=\"fas fa-lock\" title=\... | Go | Apache License 2.0 | google/gvisor | Fix feature block rendering (fixes #56)
- Render feature blocks as markdown again.
- Feature block inner content is contained in a <div> rather than a <p>
to avoid nested <p> tags. |
259,854 | 24.04.2019 14:50:30 | 25,200 | 962567aafd2ead6846db5add07bb7a02ed562ff4 | Add Unix socket tests for the MSG_CTRUNC msghdr flag.
TCP tests and the implementation will come in followup CLs.
Updates google/gvisor#206
Updates google/gvisor#207 | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_unix.cc",
"new_path": "test/syscalls/linux/socket_unix.cc",
"diff": "#include <stdio.h>\n#include <sys/ioctl.h>\n#include <sys/socket.h>\n+#include <sys/types.h>\n#include <sys/un.h>\n+\n#include <vector>\n#include \"gtest/gtest.h\"\... | Go | Apache License 2.0 | google/gvisor | Add Unix socket tests for the MSG_CTRUNC msghdr flag.
TCP tests and the implementation will come in followup CLs.
Updates google/gvisor#206
Updates google/gvisor#207
PiperOrigin-RevId: 245121470
Change-Id: Ib50b62724d3ba0cbfb1374e1f908798431ee2b21 |
259,884 | 25.04.2019 01:15:17 | 25,200 | 03be9ae88ca857da4f2243d17b06bd5bc38f88db | Update required bazel version to 0.23.0 in README
Bazel 0.23.0 is required due to the use of cc_flags_supplier.bzl in the vdso
package. cc_flags_supplier.bzl was added in 0.23.0. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -47,7 +47,7 @@ Make sure the following dependencies are installed:\n* Linux 4.14.77+ ([older linux][old-linux])\n* [git][git]\n-* [Bazel][bazel] 0.18+\n+* [Bazel][bazel] 0.23.0+\n* [Python][python]\n* [Docker ve... | Go | Apache License 2.0 | google/gvisor | Update required bazel version to 0.23.0 in README
Bazel 0.23.0 is required due to the use of cc_flags_supplier.bzl in the vdso
package. cc_flags_supplier.bzl was added in 0.23.0.
PiperOrigin-RevId: 245192715
Change-Id: I4258c064e5cc3bac2a587c887e0d8f87b6678ec7 |
259,881 | 25.04.2019 17:45:56 | 25,200 | f17cfa4d53742923b5c91b149b82a05bcda3ea20 | Perform explicit CPUID and FP state compatibility checks on restore | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid.go",
"new_path": "pkg/cpuid/cpuid.go",
"diff": "@@ -446,6 +446,20 @@ const (\nextendedFeatures // Returns some extended feature bits in edx and ecx.\n)\n+// These are the extended floating point state features. They are used to\n+// enumerate f... | Go | Apache License 2.0 | google/gvisor | Perform explicit CPUID and FP state compatibility checks on restore
PiperOrigin-RevId: 245341004
Change-Id: Ic4d581039d034a8ae944b43e45e84eb2c3973657 |
259,891 | 26.04.2019 11:06:59 | 25,200 | f4d34b420bd30b9c3725f9247c9145808aab0ffb | Change name of sticky test arg. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/sticky.cc",
"new_path": "test/syscalls/linux/sticky.cc",
"diff": "#include \"test/util/test_util.h\"\n#include \"test/util/thread_util.h\"\n-DEFINE_int32(scratch_uid1, 65534, \"first scratch UID\");\n+DEFINE_int32(scratch_uid, 65534, \"firs... | Go | Apache License 2.0 | google/gvisor | Change name of sticky test arg.
PiperOrigin-RevId: 245451875
Change-Id: Icee2c4ed74564e77454c60d60f456454443ccadf |
259,891 | 26.04.2019 11:08:37 | 25,200 | 5f13338d30fb59241cf7f1aa6374c54c69677314 | Fix reference counting bug in /proc/PID/fdinfo/. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/fds.go",
"new_path": "pkg/sentry/fs/proc/fds.go",
"diff": "@@ -236,24 +236,6 @@ func (f *fdDirFile) Readdir(ctx context.Context, file *fs.File, ser fs.DentrySer\n})\n}\n-// fdInfoInode is a single file in /proc/TID/fdinfo/.\n-//\n-// +statei... | Go | Apache License 2.0 | google/gvisor | Fix reference counting bug in /proc/PID/fdinfo/.
PiperOrigin-RevId: 245452217
Change-Id: I7164d8f57fe34c17e601079eb9410a6d95af1869 |
259,858 | 26.04.2019 13:51:48 | 25,200 | 5749f64314d38516badec156ab048d3523294a81 | kvm: remove non-sane sanity check
Apparently some platforms don't have pSize < vSize.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/physical_map.go",
"new_path": "pkg/sentry/platform/kvm/physical_map.go",
"diff": "@@ -50,8 +50,9 @@ type physicalRegion struct {\nvar physicalRegions []physicalRegion\n// fillAddressSpace fills the host address space with PROT_NONE mapp... | Go | Apache License 2.0 | google/gvisor | kvm: remove non-sane sanity check
Apparently some platforms don't have pSize < vSize.
Fixes #208
PiperOrigin-RevId: 245480998
Change-Id: I2a98229912f4ccbfcd8e79dfa355104f14275a9c |
259,891 | 26.04.2019 16:50:35 | 25,200 | 43dff57b878edb5502daf486cbc13b058780dd56 | Make raw sockets a toggleable feature disabled by default. | [
{
"change_type": "MODIFY",
"old_path": "pkg/syserr/netstack.go",
"new_path": "pkg/syserr/netstack.go",
"diff": "@@ -45,6 +45,7 @@ var (\nErrNoSuchFile = New(tcpip.ErrNoSuchFile.String(), linux.ENOENT)\nErrInvalidOptionValue = New(tcpip.ErrInvalidOptionValue.String(), linux.EINVAL)\nErrBroadcastDisab... | Go | Apache License 2.0 | google/gvisor | Make raw sockets a toggleable feature disabled by default.
PiperOrigin-RevId: 245511019
Change-Id: Ia9562a301b46458988a6a1f0bbd5f07cbfcb0615 |
259,899 | 26.04.2019 22:45:45 | 25,200 | 66bca6fc221393c9553cbaa0486e07c8124e2477 | tcpip/adapters/gonet: add CloseRead & CloseWrite methods to Conn
Add the CloseRead & CloseWrite methods that performs shutdown on the
corresponding Read & Write sides of a connection. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet.go",
"diff": "@@ -435,6 +435,28 @@ func (c *Conn) Close() error {\nreturn nil\n}\n+// CloseRead shuts down the reading side of the TCP connection. Most callers\n+// should just use... | Go | Apache License 2.0 | google/gvisor | tcpip/adapters/gonet: add CloseRead & CloseWrite methods to Conn
Add the CloseRead & CloseWrite methods that performs shutdown on the
corresponding Read & Write sides of a connection.
Change-Id: I3996a2abdc7cd68a2becba44dc4bd9f0919d2ce1
PiperOrigin-RevId: 245537950 |
259,992 | 29.04.2019 15:32:45 | 25,200 | ddab854b9a895603664fa4abfa525f6a29047083 | Reduce memory allocations on serving path
Cache last used messages and reuse them for subsequent requests.
If more messages are needed, they are created outside the cache
on demand. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/buffer.go",
"new_path": "pkg/p9/buffer.go",
"diff": "@@ -20,7 +20,8 @@ import (\n// encoder is used for messages and 9P primitives.\ntype encoder interface {\n- // Decode decodes from the given buffer.\n+ // Decode decodes from the given buffer. Decode ... | Go | Apache License 2.0 | google/gvisor | Reduce memory allocations on serving path
Cache last used messages and reuse them for subsequent requests.
If more messages are needed, they are created outside the cache
on demand.
PiperOrigin-RevId: 245836910
Change-Id: Icf099ddff95df420db8e09f5cdd41dcdce406c61 |
259,992 | 29.04.2019 18:40:51 | 25,200 | 2843f2a956f5ef23e621f571f5c3e6a1e4a8223a | Skip flaky ClockGettime.CputimeId
Test times out when it runs on a single core. Skip until the
bug in the Go runtime is fixed. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/clock_gettime.cc",
"new_path": "test/syscalls/linux/clock_gettime.cc",
"diff": "@@ -55,6 +55,10 @@ void spin_ns(int64_t ns) {\n// Test that CLOCK_PROCESS_CPUTIME_ID is a superset of CLOCK_THREAD_CPUTIME_ID.\nTEST(ClockGettime, CputimeId) {\... | Go | Apache License 2.0 | google/gvisor | Skip flaky ClockGettime.CputimeId
Test times out when it runs on a single core. Skip until the
bug in the Go runtime is fixed.
PiperOrigin-RevId: 245866466
Change-Id: Ic3e72131c27136d58b71f6b11acc78abf55895d4 |
259,854 | 29.04.2019 21:20:05 | 25,200 | 81ecd8b6eab7457b331762626f8c210fec3504e6 | Implement the MSG_CTRUNC msghdr flag for Unix sockets.
Updates google/gvisor#206 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/control.go",
"new_path": "pkg/sentry/fs/host/control.go",
"diff": "@@ -32,17 +32,20 @@ func newSCMRights(fds []int) control.SCMRights {\n}\n// Files implements control.SCMRights.Files.\n-func (c *scmRights) Files(ctx context.Context, max int... | Go | Apache License 2.0 | google/gvisor | Implement the MSG_CTRUNC msghdr flag for Unix sockets.
Updates google/gvisor#206
PiperOrigin-RevId: 245880573
Change-Id: Ifa715e98d47f64b8a32b04ae9378d6cd6bd4025e |
259,881 | 30.04.2019 15:41:42 | 25,200 | 23ca9886c6cfe499438f1b994ee66a4f803673ae | Update reference to old type | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dentry.go",
"new_path": "pkg/sentry/fs/dentry.go",
"diff": "@@ -73,8 +73,8 @@ func (c *CollectEntriesSerializer) Written() int {\nreturn len(c.Entries)\n}\n-// DirCtx is used by node.Readdir to emit directory entries. It is not\n-// thread-safe.\... | Go | Apache License 2.0 | google/gvisor | Update reference to old type
PiperOrigin-RevId: 246036806
Change-Id: I5554a43a1f8146c927402db3bf98488a2da0fbe7 |
259,858 | 30.04.2019 21:52:45 | 25,200 | 2c1c1c9917617ddac0042aa0e7ae14d5032100c5 | CONTRIBUTING: fix broken repository link | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -144,5 +144,5 @@ one above, the\n[gccla]: https://cla.developers.google.com/about/google-corporate\n[gerrit]: https://gvisor-review.googlesource.com\n[gostyle]: https://github.com/golang/go/wiki/Code... | Go | Apache License 2.0 | google/gvisor | CONTRIBUTING: fix broken repository link
PiperOrigin-RevId: 246079174
Change-Id: I423078a065e0cc5d258d674b4f2f0680a5db0aee |
259,891 | 02.05.2019 18:56:40 | 25,200 | bf40fa21292f08e66a274169ad1318e62fbc542b | Replace dynamic macros with constants in memfd test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/memfd.cc",
"new_path": "test/syscalls/linux/memfd.cc",
"diff": "@@ -38,8 +38,15 @@ namespace {\n// The header sys/memfd.h isn't available on all systems, so redefining some of\n// the constants here.\n#define F_LINUX_SPECIFIC_BASE 1024\n+\n... | Go | Apache License 2.0 | google/gvisor | Replace dynamic macros with constants in memfd test.
PiperOrigin-RevId: 246433167
Change-Id: Idb9b6c20ee1da193176288dfd2f9d85ec0e69c54 |
259,853 | 02.05.2019 19:26:16 | 25,200 | c967fbdaa2cda260312f73a3f75744ac1ad11176 | runsc: move test_app in a separate directory
Opensource tools (e. g. https://github.com/fatih/vim-go) can't hanlde more than
one golang package in one directory. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/BUILD",
"new_path": "runsc/container/BUILD",
"diff": "-load(\"@io_bazel_rules_go//go:def.bzl\", \"go_binary\", \"go_library\", \"go_test\")\n+load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_test\")\npackage(licenses = [\"notice\"]... | Go | Apache License 2.0 | google/gvisor | runsc: move test_app in a separate directory
Opensource tools (e. g. https://github.com/fatih/vim-go) can't hanlde more than
one golang package in one directory.
PiperOrigin-RevId: 246435962
Change-Id: I67487915e3838762424b2d168efc54ae34fb801f |
259,853 | 02.05.2019 19:33:19 | 25,200 | 5f8225c009fcf297139c54c7b329da4aff679ece | runsc: don't create an empty network namespace if NetworkHost is set
With this change, we will be able to run runsc do in a host network namespace. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -472,6 +472,8 @@ func (s *Sandbox) createSandboxProcess(spec *specs.Spec, conf *boot.Config, bund\nif ns, ok := specutils.GetNS(specs.NetworkNamespace, spec); ok && conf.Network != ... | Go | Apache License 2.0 | google/gvisor | runsc: don't create an empty network namespace if NetworkHost is set
With this change, we will be able to run runsc do in a host network namespace.
PiperOrigin-RevId: 246436660
Change-Id: I8ea18b1053c88fe2feed74239b915fe7a151ce34 |
260,006 | 03.05.2019 07:01:38 | 25,200 | 2d8e90b31102fa784f1657153db99d6fe52b4e9d | Proper cleanup of sockets that used REUSEPORT
Fixed a small logic error that broke proper accounting of MultiPortEndpoints. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/transport_demuxer.go",
"new_path": "pkg/tcpip/stack/transport_demuxer.go",
"diff": "@@ -171,7 +171,7 @@ func (ep *multiPortEndpoint) singleRegisterEndpoint(t TransportEndpoint) {\n// A new endpoint is added into endpointsArr and its index there... | Go | Apache License 2.0 | google/gvisor | Proper cleanup of sockets that used REUSEPORT
Fixed a small logic error that broke proper accounting of MultiPortEndpoints.
PiperOrigin-RevId: 246502126
Change-Id: I1a7d6ea134f811612e545676212899a3707bc2c2 |
259,992 | 03.05.2019 09:41:08 | 25,200 | 6b9ab65163528239c9fbf10053427513513e6ab0 | Skip flaky ClockGettime.CputimeId take 2
The test also times out when GCE machine has 2 CPUs. I cannot
repro it locally with a 2 CPU cgroup though. Let's skip the
test when there are 2 CPUs to stop the flakiness and retest it
once the fix is available. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/clock_gettime.cc",
"new_path": "test/syscalls/linux/clock_gettime.cc",
"diff": "@@ -56,8 +56,9 @@ void spin_ns(int64_t ns) {\n// Test that CLOCK_PROCESS_CPUTIME_ID is a superset of CLOCK_THREAD_CPUTIME_ID.\nTEST(ClockGettime, CputimeId) {\n... | Go | Apache License 2.0 | google/gvisor | Skip flaky ClockGettime.CputimeId take 2
The test also times out when GCE machine has 2 CPUs. I cannot
repro it locally with a 2 CPU cgroup though. Let's skip the
test when there are 2 CPUs to stop the flakiness and retest it
once the fix is available.
PiperOrigin-RevId: 246523363
Change-Id: I9d9d922a5be3aa7bc91dff5a1807ca99f3f4a4f9 |
259,992 | 03.05.2019 09:53:26 | 25,200 | 95614bbefa2f4657c77b2040630088fdec7f5dd1 | Increase timeout to wait for port to become available
TestHttpd fails sporadically waiting for the port on slow
machines. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/image_test.go",
"new_path": "runsc/test/image/image_test.go",
"diff": "@@ -103,7 +103,7 @@ func TestHttpd(t *testing.T) {\n}\n// Wait until it's up and running.\n- if err := testutil.WaitForHTTP(port, 5*time.Second); err != nil {\n+ if err := ... | Go | Apache License 2.0 | google/gvisor | Increase timeout to wait for port to become available
TestHttpd fails sporadically waiting for the port on slow
machines.
PiperOrigin-RevId: 246525277
Change-Id: Ie0ea71e3c4664d24f580eabd8f7461e47079f734 |
259,853 | 03.05.2019 11:20:12 | 25,200 | 3f3e3a63033f87dd42076423661b62c04d10c15f | gvisor/kokoro: save runsc logs | [
{
"change_type": "MODIFY",
"old_path": "kokoro/continuous.cfg",
"new_path": "kokoro/continuous.cfg",
"diff": "@@ -7,5 +7,7 @@ action {\ndefine_artifacts {\nregex: \"**/sponge_log.xml\"\nregex: \"**/sponge_log.log\"\n+ regex: \"**/outputs.zip\"\n+ regex: \"**/runsc-logs.tar.gz\"\n}\n}\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | gvisor/kokoro: save runsc logs
PiperOrigin-RevId: 246542315
Change-Id: Ia9ba2bc104e0af3277d3b6102122c13d320ea802 |
259,891 | 03.05.2019 13:04:46 | 25,200 | 264d012d81d210c6d949554667c6fbf8e330587a | Add netfilter ABI for iptables support. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -32,6 +32,7 @@ go_library(\n\"linux.go\",\n\"mm.go\",\n\"netdevice.go\",\n+ \"netfilter.go\",\n\"netlink.go\",\n\"netlink_route.go\",\n\"poll.go\",\n"
},
{
"change_type": "ADD",
"... | Go | Apache License 2.0 | google/gvisor | Add netfilter ABI for iptables support.
Change-Id: Ifbd2abf63ea8062a89b83e948d3e9735480d8216
PiperOrigin-RevId: 246559904 |
259,853 | 03.05.2019 14:00:31 | 25,200 | 24d8656585e6072ff7d5a00a7eb4bd25cba42dc4 | gofer: don't leak file descriptors
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/cache_policy.go",
"new_path": "pkg/sentry/fs/gofer/cache_policy.go",
"diff": "@@ -139,11 +139,12 @@ func (cp cachePolicy) revalidate(ctx context.Context, name string, parent, child\n// TODO(b/112031682): If we have a directory FD in the par... | Go | Apache License 2.0 | google/gvisor | gofer: don't leak file descriptors
Fixes #219
PiperOrigin-RevId: 246568639
Change-Id: Ic7afd15dde922638d77f6429c508d1cbe2e4288a |
259,854 | 03.05.2019 21:00:29 | 25,200 | b4a9f186872d6687f34e609a39aa10eb33cce1d2 | Update tcpip Clock description.
The tcpip.Clock comment stated that times provided by it should not be used for
netstack internal timekeeping. This comment was from before the interface
supported monotonic times. The monotonic times that it provides are now be the
preferred time source for netstack internal timekeeping. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tcpip.go",
"new_path": "pkg/tcpip/tcpip.go",
"diff": "@@ -125,7 +125,7 @@ func (e ErrSaveRejection) Error() string {\n// A Clock provides the current time.\n//\n// Times returned by a Clock should always be used for application-visible\n-// time, but... | Go | Apache License 2.0 | google/gvisor | Update tcpip Clock description.
The tcpip.Clock comment stated that times provided by it should not be used for
netstack internal timekeeping. This comment was from before the interface
supported monotonic times. The monotonic times that it provides are now be the
preferred time source for netstack internal timekeeping.
PiperOrigin-RevId: 246618772
Change-Id: I853b720e3d719b03fabd6156d2431da05d354bda |
259,891 | 05.05.2019 16:06:11 | 25,200 | ff8ed5e6a5a391c5465230121af09afa5d1906e9 | Fix raw socket behavior and tests.
Some behavior was broken due to the difficulty of running automated raw
socket tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/icmp.go",
"new_path": "pkg/tcpip/network/ipv4/icmp.go",
"diff": "@@ -72,7 +72,24 @@ func (e *endpoint) handleICMP(r *stack.Route, netHeader buffer.View, vv buffer.V\nreceived.Invalid.Increment()\nreturn\n}\n+\n+ // Only send a reply if t... | Go | Apache License 2.0 | google/gvisor | Fix raw socket behavior and tests.
Some behavior was broken due to the difficulty of running automated raw
socket tests.
Change-Id: I152ca53916bb24a0208f2dc1c4f5bc87f4724ff6
PiperOrigin-RevId: 246747067 |
259,885 | 06.05.2019 16:38:37 | 25,200 | 14f0e7618e28dac78ca7b00ec61fcec062159009 | Ensure all uses of MM.brk occur under MM.mappingMu in MM.Brk(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/syscalls.go",
"new_path": "pkg/sentry/mm/syscalls.go",
"diff": "@@ -694,8 +694,9 @@ func (mm *MemoryManager) Brk(ctx context.Context, addr usermem.Addr) (usermem.Ad\n// Can't defer mm.mappingMu.Unlock(); see below.\nif addr < mm.brk.Start {\n+ ad... | Go | Apache License 2.0 | google/gvisor | Ensure all uses of MM.brk occur under MM.mappingMu in MM.Brk().
PiperOrigin-RevId: 246921386
Change-Id: I71d8908858f45a9a33a0483470d0240eaf0fd012 |
259,884 | 22.04.2019 22:13:11 | 14,400 | 0b4eca7b32702a3d88435cc0afb0e169e5c274f0 | Fix links to syscall man pages (refs: | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/amd64.md",
"new_path": "content/docs/user_guide/compatibility/amd64.md",
"diff": "@@ -73,8 +73,8 @@ syscalls. 231 syscalls are not yet documented.\n<td>Returns ENOSYS; Obsolete</td>\n</tr>\n<tr>\n- <td><a class=\"doc-table... | Go | Apache License 2.0 | google/gvisor | Fix links to syscall man pages (refs: #50) |
259,858 | 29.04.2019 10:00:02 | 25,200 | 0f5e7e011cd3f023fa69675c10ad022f0dc7f712 | build: fix deploy target for Makefile
Because the go.mod and related files were not being copying, the
packages are resolved within the current $GOROOT, which does not work.
This change copies all application files, not just Go source files and
app.yaml. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -5,21 +5,19 @@ NPM := npm\nGCLOUD := gcloud\nGCP_PROJECT := gvisor-website\n-# Source Go files. example: main.go foo/bar.go\n-GO_SOURCE = $(shell find cmd/gvisor-website -type f -name \"*.go\" | sed 's/ /\\\\ /g')... | Go | Apache License 2.0 | google/gvisor | build: fix deploy target for Makefile
Because the go.mod and related files were not being copying, the
packages are resolved within the current $GOROOT, which does not work.
This change copies all application files, not just Go source files and
app.yaml. |
259,992 | 07.05.2019 10:53:50 | 25,200 | e5432fa1b365edcebf9c8c01e2c40ade3014f282 | Remove defers from gofer.contextFile
Most are single line methods in hot paths. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/context_file.go",
"new_path": "pkg/sentry/fs/gofer/context_file.go",
"diff": "@@ -28,156 +28,156 @@ type contextFile struct {\nfunc (c *contextFile) walk(ctx context.Context, names []string) ([]p9.QID, contextFile, error) {\nctx.Uninterrupt... | Go | Apache License 2.0 | google/gvisor | Remove defers from gofer.contextFile
Most are single line methods in hot paths.
PiperOrigin-RevId: 247050267
Change-Id: I428d78723fe00b57483185899dc8fa9e1f01e2ea |
259,854 | 07.05.2019 14:26:24 | 25,200 | 20862f0db27efac0eed3bb23d01b22b09bddfa27 | Add gonet.DialContextTCP.
Allows cancellation and timeouts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet.go",
"diff": "package gonet\nimport (\n+ \"context\"\n\"errors\"\n\"io\"\n\"net\"\n@@ -495,6 +496,12 @@ func fullToUDPAddr(addr tcpip.FullAddress) *net.UDPAddr {\n// DialTCP create... | Go | Apache License 2.0 | google/gvisor | Add gonet.DialContextTCP.
Allows cancellation and timeouts.
PiperOrigin-RevId: 247090428
Change-Id: I91907f12e218677dcd0e0b6d72819deedbd9f20c |
259,885 | 10.05.2019 13:36:56 | 25,200 | 5ee8218483ce172400c21780d5dbc1ec2ba54d63 | Add pgalloc.DelayedEvictionManual. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -304,10 +304,11 @@ func (k *Kernel) SaveTo(w io.Writer) error {\ndefer k.resumeTimeLocked()\n// Evict all evictable MemoryFile allocations.\n- k.mf.FlushEvictions()\n+ k.mf.St... | Go | Apache License 2.0 | google/gvisor | Add pgalloc.DelayedEvictionManual.
PiperOrigin-RevId: 247667272
Change-Id: I16b04e11bb93f50b7e05e888992303f730e4a877 |
259,881 | 10.05.2019 17:36:42 | 25,200 | c61a2e709a810233c310e409c07b0ed696f4e858 | Modernize mknod test | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1028,6 +1028,7 @@ cc_binary(\nsrcs = [\"mknod.cc\"],\nlinkstatic = 1,\ndeps = [\n+ \"//test/util:file_descriptor\",\n\"//test/util:temp_path\",\n\"//test/util:test_main\",\n\"//t... | Go | Apache License 2.0 | google/gvisor | Modernize mknod test
PiperOrigin-RevId: 247704588
Change-Id: I1e63e2b310145695fbe38429b91e44d72473fcd6 |
259,853 | 13.05.2019 10:37:24 | 25,200 | ec248daf29974c3c3f99f4c110059e2c4e50fbe0 | gvisor/hostnet: restart epoll_wait after epoll_ctl
Otherwise changes of epoll_ctl will not have affect. | [
{
"change_type": "MODIFY",
"old_path": "pkg/fdnotifier/fdnotifier.go",
"new_path": "pkg/fdnotifier/fdnotifier.go",
"diff": "@@ -40,6 +40,10 @@ type notifier struct {\n// notifications.\nepFD int\n+ // eventFD is used to restart epoll_wait in waitAndNotify after\n+ // reconfiguring epFD.\n+ eventFD i... | Go | Apache License 2.0 | google/gvisor | gvisor/hostnet: restart epoll_wait after epoll_ctl
Otherwise changes of epoll_ctl will not have affect.
PiperOrigin-RevId: 247964961
Change-Id: I9fbb35c44766421af45d9ed53760e0c324d80d99 |
259,858 | 26.04.2019 10:51:20 | 25,200 | 599590c9d7c1f94dfcb69342da9e0e025f0fc94a | Add performance guide. | [
{
"change_type": "MODIFY",
"old_path": "layouts/partials/head.html",
"new_path": "layouts/partials/head.html",
"diff": "src=\"https://code.jquery.com/jquery-3.3.1.min.js\"\nintegrity=\"sha256-FgpCb/KJQlLNfOu91ta32o/NMZxltwRo8QtmkMRdAu8=\"\ncrossorigin=\"anonymous\"></script>\n+<script\n+ src=\"https... | Go | Apache License 2.0 | google/gvisor | Add performance guide. |
259,975 | 26.04.2019 16:37:31 | 25,200 | b4eea426529db8b386560f7301a09421fa7031ca | Adding data from working benchmarks | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "static/performance/density.csv",
"diff": "+runtime,method,metric,result\n+runc,density.empty,memory_usage,2460794.88\n+runc,density.node,memory_usage,18692915.2\n+runc,density.ruby,memory_usage,18854543.36\n+runsc,density.empty,memory_usage,2253... | Go | Apache License 2.0 | google/gvisor | Adding data from working benchmarks |
259,975 | 01.05.2019 12:20:26 | 25,200 | b879aa444d0a2a87c892296ed5f7ec62842da6eb | Update applications numbers after node/ruby refactor | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "static/performance/applications.csv",
"diff": "+runtime,method,metric,result\n+runc,http.node,transfer_rate,3880.44\n+runc,http.node,latency,11.0\n+runc,http.node,requests_per_second,901.04\n+runc,http.ruby,transfer_rate,3182.51\n+runc,http.ruby... | Go | Apache License 2.0 | google/gvisor | Update applications numbers after node/ruby refactor |
259,975 | 02.05.2019 10:02:44 | 25,200 | 07c8695865899ef7b60c92cb861e500dfc65c3ff | Update fio to display in log scale | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/performance.md",
"new_path": "content/docs/architecture_guide/performance.md",
"diff": "@@ -205,13 +205,13 @@ through the [Gofer](../) as a result of our [security model](../security/), but\nin most cases are dominated by **impl... | Go | Apache License 2.0 | google/gvisor | Update fio to display in log scale |
259,858 | 07.05.2019 13:26:42 | 25,200 | e86a939edf3a4aaff8c11f70c3b7acb44eb7cd7a | Add clarifying notes. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/performance.md",
"new_path": "content/docs/architecture_guide/performance.md",
"diff": "@@ -92,6 +92,11 @@ This test is the result of running many instances of a container (typically 50)\nand calculating available memory on the ... | Go | Apache License 2.0 | google/gvisor | Add clarifying notes. |
259,858 | 13.05.2019 14:50:57 | 25,200 | 5dcfe3c758e9b2ca0c87d6bb843094b083a9515b | Clarify sizes and file locations. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/performance.md",
"new_path": "content/docs/architecture_guide/performance.md",
"diff": "@@ -235,17 +235,18 @@ The high costs of VFS operations can manifest in benchmarks that execute many\nsuch operations in the hot path for ser... | Go | Apache License 2.0 | google/gvisor | Clarify sizes and file locations. |
259,975 | 13.05.2019 15:03:34 | 25,200 | 5b3f25047fe8dd4d04262ea56c38a134291d0067 | Upload latest set of benchmarks
Also includes redis density benchmark. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/performance.md",
"new_path": "content/docs/architecture_guide/performance.md",
"diff": "@@ -85,7 +85,7 @@ For many use cases, fixed memory overheads are a primary concern. This may be\nbecause sandboxed containers handle a low v... | Go | Apache License 2.0 | google/gvisor | Upload latest set of benchmarks
Also includes redis density benchmark. |
259,858 | 13.05.2019 15:12:03 | 25,200 | 9ea68ce1655ddadc8e3ca4c65fd2922d2564b33d | Drop confusing kvm-bare syscall time
The difference is only due to different machines. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/performance.md",
"new_path": "content/docs/architecture_guide/performance.md",
"diff": "@@ -90,17 +90,16 @@ therefore important to achieve high densities for efficiency.\nThe above figure demonstrates these costs based on three ... | Go | Apache License 2.0 | google/gvisor | Drop confusing kvm-bare syscall time
The difference is only due to different machines. |
259,858 | 13.05.2019 15:20:45 | 25,200 | ad7ef8410f908aa8b1286f9796692c5aaeb68447 | Fixup redis container count. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/performance.md",
"new_path": "content/docs/architecture_guide/performance.md",
"diff": "@@ -88,12 +88,12 @@ therefore important to achieve high densities for efficiency.\n{{< graph id=\"density\" url=\"/performance/density.csv\"... | Go | Apache License 2.0 | google/gvisor | Fixup redis container count. |
259,853 | 14.05.2019 16:00:53 | 25,200 | fff21b99e45136510a0148eada57ff28966dc27e | kokoro: run tests with a default docker container runtime
We want to know that our environment set up properly
and docker tests pass with a native runtime. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -142,10 +142,21 @@ EOF\nrun_docker_tests() {\ncd ${WORKSPACE_DIR}\n+ # Run tests with a default runtime (runc).\n+ bazel test \\\n+ \"${BAZEL_BUILD_FLAGS[@]}\" \\\n+ --test_env=RUNSC_RUNTIME=... | Go | Apache License 2.0 | google/gvisor | kokoro: run tests with a default docker container runtime
We want to know that our environment set up properly
and docker tests pass with a native runtime.
PiperOrigin-RevId: 248229294
Change-Id: I06c221e5eeed6e01bdd1aa935333c57e8eadc498 |
259,853 | 15.05.2019 11:10:56 | 25,200 | 85380ff03d21da417ad74d28b293c768d7effb4f | gvisor/runsc: use a veth link address instead of generating a new one | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -153,10 +153,6 @@ run_docker_tests() {\n# configuration, e.g. save/restore not supported with hostnet.\ndeclare -a variations=(\"\" \"-kvm\" \"-hostnet\" \"-overlay\")\nfor v in \"${variation... | Go | Apache License 2.0 | google/gvisor | gvisor/runsc: use a veth link address instead of generating a new one
PiperOrigin-RevId: 248367340
Change-Id: Id792afcfff9c9d2cfd62cae21048316267b4a924 |
259,992 | 15.05.2019 14:35:30 | 25,200 | ecb0f00e10017e82698c326b4d83294c9e20dfbd | Cleanup around urpc file payload handling
urpc always closes all files once the RPC function returns. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -211,12 +211,6 @@ type StartArgs struct {\nfunc (cm *containerManager) Start(args *StartArgs, _ *struct{}) error {\nlog.Debugf(\"containerManager.Start: %+v\", args)\n- defer func()... | Go | Apache License 2.0 | google/gvisor | Cleanup around urpc file payload handling
urpc always closes all files once the RPC function returns.
PiperOrigin-RevId: 248406857
Change-Id: I400a8562452ec75c8e4bddc2154948567d572950 |
259,853 | 15.05.2019 17:20:14 | 25,200 | 2105158d4bee4fb36658dba32eb8104cf4e96467 | gofer: don't call hostfile.Close if hostFile is nil | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/path.go",
"new_path": "pkg/sentry/fs/gofer/path.go",
"diff": "@@ -121,13 +121,17 @@ func (i *inodeOperations) Create(ctx context.Context, dir *fs.Inode, name string\nqids, unopened, mask, p9attr, err := i.fileState.file.walkGetAttr(ctx, []s... | Go | Apache License 2.0 | google/gvisor | gofer: don't call hostfile.Close if hostFile is nil
PiperOrigin-RevId: 248437159
Change-Id: Ife71f6ca032fca59ec97a82961000ed0af257101 |
259,854 | 16.05.2019 11:58:10 | 25,200 | 40419a16eb8bfbfd9bbb4e20957a5ec9e846a22a | Add test for duplicate proc entries.
The issue with duplicate /proc/sys entries seems to have been fixed in:
Git hash
Fixes google/gvisor#125 | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -214,6 +214,8 @@ syscall_test(test = \"//test/syscalls/linux:priority_test\")\nsyscall_test(\nsize = \"medium\",\n+ # We don't want our proc changing out from under us.\n+ parallel = False,\n... | Go | Apache License 2.0 | google/gvisor | Add test for duplicate proc entries.
The issue with duplicate /proc/sys entries seems to have been fixed in:
PiperOrigin-RevId 229305982
Git hash dc8450b5676d4c4ac9bcfa23cabd862e0060527d
Fixes google/gvisor#125
PiperOrigin-RevId: 248571903
Change-Id: I76ff3b525c93dafb92da6e5cf56e440187f14579 |
259,881 | 17.05.2019 13:04:44 | 25,200 | 04105781ad558662e1e48bad17197df244ff7841 | Fix gofer rename ctime and cleanup stat_times test
There is a lot of redundancy that we can simplify in the stat_times
test. This will make it easier to add new tests. However, the
simplification reveals that cached uattrs on goferfs don't properly
update ctime on rename. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/inode.go",
"new_path": "pkg/sentry/fs/fsutil/inode.go",
"diff": "@@ -341,7 +341,7 @@ func (InodeNotDirectory) RemoveDirectory(context.Context, *fs.Inode, string) err\n}\n// Rename implements fs.FileOperations.Rename.\n-func (InodeNotDirect... | Go | Apache License 2.0 | google/gvisor | Fix gofer rename ctime and cleanup stat_times test
There is a lot of redundancy that we can simplify in the stat_times
test. This will make it easier to add new tests. However, the
simplification reveals that cached uattrs on goferfs don't properly
update ctime on rename.
PiperOrigin-RevId: 248773425
Change-Id: I52662728e1e9920981555881f9a85f9ce04041cf |
259,881 | 17.05.2019 13:46:18 | 25,200 | 4a842836e560322bb3944b59ff43b9d60cc0f867 | Return EPERM for mknod
This more directly matches what Linux does with unsupported
nodes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/path.go",
"new_path": "pkg/sentry/fs/gofer/path.go",
"diff": "@@ -281,9 +281,9 @@ func (i *inodeOperations) Bind(ctx context.Context, dir *fs.Inode, name string,\n}\n// CreateFifo implements fs.InodeOperations.CreateFifo. Gofer nodes do not... | Go | Apache License 2.0 | google/gvisor | Return EPERM for mknod
This more directly matches what Linux does with unsupported
nodes.
PiperOrigin-RevId: 248780425
Change-Id: I17f3dd0b244f6dc4eb00e2e42344851b8367fbec |
259,881 | 20.05.2019 13:34:06 | 25,200 | 6588427451c605ee00c8b1a9b6cba06724627ccb | Fix incorrect tmpfs timestamp updates
* Creation of files, directories (and other fs objects) in a directory
should always update ctime.
* Same for removal.
* atime should not be updated on lookup, only readdir.
I've also renamed some misleading functions that update mtime and ctime. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/inode.go",
"new_path": "pkg/sentry/fs/fsutil/inode.go",
"diff": "@@ -192,6 +192,16 @@ func (i *InodeSimpleAttributes) NotifyStatusChange(ctx context.Context) {\ni.mu.Unlock()\n}\n+// NotifyModificationAndStatusChange updates the modificati... | Go | Apache License 2.0 | google/gvisor | Fix incorrect tmpfs timestamp updates
* Creation of files, directories (and other fs objects) in a directory
should always update ctime.
* Same for removal.
* atime should not be updated on lookup, only readdir.
I've also renamed some misleading functions that update mtime and ctime.
PiperOrigin-RevId: 249115063
Change-Id: I30fa275fa7db96d01aa759ed64628c18bb3a7dc7 |
259,881 | 21.05.2019 17:04:58 | 25,200 | c8857f72696c1097a427b75f4340969e20cc0e95 | Fix inconsistencies in ELF anonymous mappings
* A segment with filesz == 0, memsz > 0 should be an anonymous only
mapping. We were failing to load such an ELF.
* Anonymous pages are always mapped RW, regardless of the segment
protections. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/elf.go",
"new_path": "pkg/sentry/loader/elf.go",
"diff": "@@ -223,13 +223,8 @@ func parseHeader(ctx context.Context, f *fs.File) (elfInfo, error) {\n// mapSegment maps a phdr into the Task. offset is the offset to apply to\n// phdr.Vaddr.\nfu... | Go | Apache License 2.0 | google/gvisor | Fix inconsistencies in ELF anonymous mappings
* A segment with filesz == 0, memsz > 0 should be an anonymous only
mapping. We were failing to load such an ELF.
* Anonymous pages are always mapped RW, regardless of the segment
protections.
PiperOrigin-RevId: 249355239
Change-Id: I251e5c0ce8848cf8420c3aadf337b0d77b1ad991 |
259,881 | 22.05.2019 11:14:29 | 25,200 | 69eac1198f3dae9a41ddf1903e9dda7972ed5d77 | Move wait constants to abi/linux package
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -52,6 +52,7 @@ go_library(\n\"tty.go\",\n\"uio.go\",\n\"utsname.go\",\n+ \"wait.go\",\n],\nimportpath = \"gvisor.googlesource.com/gvisor/pkg/abi/linux\",\nvisibility = [\"//visibility:public\... | Go | Apache License 2.0 | google/gvisor | Move wait constants to abi/linux package
Updates #214
PiperOrigin-RevId: 249483756
Change-Id: I0d3cf4112bed75a863d5eb08c2063fbc506cd875 |
259,881 | 22.05.2019 15:53:13 | 25,200 | 711290a7f6c434ddbfe401e46002afd30df26aa5 | Add support for wait(WNOTHREAD) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_exit.go",
"new_path": "pkg/sentry/kernel/task_exit.go",
"diff": "@@ -782,6 +782,10 @@ type WaitOptions struct {\n// for.\nCloneTasks bool\n+ // If SiblingChildren is true, events from children tasks of any task\n+ // in the thread group ... | Go | Apache License 2.0 | google/gvisor | Add support for wait(WNOTHREAD)
PiperOrigin-RevId: 249537694
Change-Id: Iaa4bca73a2d8341e03064d59a2eb490afc3f80da |
259,858 | 22.05.2019 16:59:21 | 25,200 | 21915eb58b875809b60c0a43e53a97ea0560c299 | Remove obsolete TODO.
There no obvious reason to require that BlockSize and StatFS
are MountSource operations. Today they are in INodeOperations,
and they can be moved elsewhere in the future as part of a
normal refactor process. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/mount.go",
"new_path": "pkg/sentry/fs/mount.go",
"diff": "@@ -42,10 +42,6 @@ type DirentOperations interface {\n// MountSourceOperations contains filesystem specific operations.\ntype MountSourceOperations interface {\n- // TODO(b/67778729): Add:... | Go | Apache License 2.0 | google/gvisor | Remove obsolete TODO.
There no obvious reason to require that BlockSize and StatFS
are MountSource operations. Today they are in INodeOperations,
and they can be moved elsewhere in the future as part of a
normal refactor process.
PiperOrigin-RevId: 249549982
Change-Id: Ib832e02faeaf8253674475df4e385bcc53d780f3 |
259,881 | 22.05.2019 18:10:54 | 25,200 | f65dfec09650768626a9af916b0487afa557a930 | Add WCLONE / WALL support to waitid
The previous commit adds WNOTHREAD support to waitid, so we may as well
complete the upstream change.
Linux added WCLONE, WALL, WNOTHREAD support to waitid(2) in
("wait: allow sys_waitid() to
accept __WNOTHREAD/__WCLONE/__WALL"). i.e., Linux 4.7. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_thread.go",
"new_path": "pkg/sentry/syscalls/linux/sys_thread.go",
"diff": "@@ -181,6 +181,32 @@ func Vfork(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall\nreturn clone(t, syscall.CLONE_VM|syscall.CLONE_VFOR... | Go | Apache License 2.0 | google/gvisor | Add WCLONE / WALL support to waitid
The previous commit adds WNOTHREAD support to waitid, so we may as well
complete the upstream change.
Linux added WCLONE, WALL, WNOTHREAD support to waitid(2) in
91c4e8ea8f05916df0c8a6f383508ac7c9e10dba ("wait: allow sys_waitid() to
accept __WNOTHREAD/__WCLONE/__WALL"). i.e., Linux 4.7.
PiperOrigin-RevId: 249560587
Change-Id: Iff177b0848a3f7bae6cb5592e44500c5a942fbeb |
259,858 | 22.05.2019 18:18:01 | 25,200 | 79738d3958a027bcf449cf1bd608f3adec42b72c | Log unhandled faults only at DEBUG level. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_run.go",
"new_path": "pkg/sentry/kernel/task_run.go",
"diff": "@@ -26,7 +26,6 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/sentry/memmap\"\n\"gvisor.googlesource.com/gvisor/pkg/sentry/platform\"\n\"gvisor.googlesource.com/gvisor/pkg... | Go | Apache License 2.0 | google/gvisor | Log unhandled faults only at DEBUG level.
PiperOrigin-RevId: 249561399
Change-Id: Ic73c68c8538bdca53068f38f82b7260939addac2 |
259,962 | 22.05.2019 18:56:18 | 25,200 | 022bd0fd1091a29a41fa4c065ac35e45e3d6c576 | Fix the signature for gopark.
gopark's signature was changed from having a string reason to a
uint8.
See:
This broke execution tracing of the sentry.
Switching to the right signature makes tracing work again.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sleep/sleep_unsafe.go",
"new_path": "pkg/sleep/sleep_unsafe.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n+// +build go1.11\n+// +build !go1.13\n+\n// Package sleep allows goroutine... | Go | Apache License 2.0 | google/gvisor | Fix the signature for gopark.
gopark's signature was changed from having a string reason to a
uint8.
See: https://github.com/golang/go/commit/4d7cf3fedbc382215df5ff6167ee9782a9cc9375
This broke execution tracing of the sentry.
Switching to the right signature makes tracing work again.
Updates #220
PiperOrigin-RevId: 249565311
Change-Id: If77fd276cecb37d4003c8222f6de510b8031a074 |
259,992 | 23.05.2019 06:46:55 | 25,200 | c091e6236922f1e9af7afbe811fd03ec297aae16 | Set sticky bit to /tmp
This is generally done for '/tmp' to prevent accidental
deletion of files. More details here: | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -290,7 +290,7 @@ func mountSubmounts(ctx context.Context, conf *Config, mns *fs.MountNamespace, r\n}\n}\n- if err := mountTmp(ctx, conf, mns, root, fds, mounts); err != nil {\n+ if err := mountTmp(... | Go | Apache License 2.0 | google/gvisor | Set sticky bit to /tmp
This is generally done for '/tmp' to prevent accidental
deletion of files. More details here:
http://man7.org/linux/man-pages/man1/chmod.1.html#RESTRICTED_DELETION_FLAG_OR_STICKY_BIT
PiperOrigin-RevId: 249633207
Change-Id: I444a5b406fdef664f5677b2f20f374972613a02b |
259,907 | 23.05.2019 16:54:38 | 25,200 | 6240abb205f9e5cdbad1c864dbed345d92f04b09 | Added boilerplate code for ext4 fs.
Initialized BUILD with license
Mount is still unimplemented and is not meant to be
part of this CL. Rest of the fs interface is implemented.
Referenced the Linux kernel appropriately when needed | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/fs/ext4/BUILD",
"diff": "+package(licenses = [\"notice\"])\n+\n+load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\n+\n+go_library(\n+ name = \"ext4\",\n+ srcs = [\"fs.go\"],\n+ importpath = \"gvisor.googlesource.com/gvisor/pkg/se... | Go | Apache License 2.0 | google/gvisor | Added boilerplate code for ext4 fs.
Initialized BUILD with license
Mount is still unimplemented and is not meant to be
part of this CL. Rest of the fs interface is implemented.
Referenced the Linux kernel appropriately when needed
PiperOrigin-RevId: 249741997
Change-Id: Id1e4c7c9e68b3f6946da39896fc6a0c3dcd7f98c |
259,853 | 23.05.2019 22:27:36 | 25,200 | 409e8eea60f096b34c9005b302dc821f38ac19ed | runsc/do: do a proper cleanup if a command failed due to internal errors
Fatalf calls os.Exit and a process exits without calling defer callbacks.
Should we do this for other runsc commands? | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/cmd.go",
"new_path": "runsc/cmd/cmd.go",
"diff": "@@ -22,19 +22,26 @@ import (\n\"strconv\"\n\"syscall\"\n+ \"github.com/google/subcommands\"\nspecs \"github.com/opencontainers/runtime-spec/specs-go\"\n\"gvisor.googlesource.com/gvisor/pkg/log\"\n\"gv... | Go | Apache License 2.0 | google/gvisor | runsc/do: do a proper cleanup if a command failed due to internal errors
Fatalf calls os.Exit and a process exits without calling defer callbacks.
Should we do this for other runsc commands?
PiperOrigin-RevId: 249776310
Change-Id: If9d8b54d0ae37db443895906eb33bd9e9b600cc9 |
259,853 | 23.05.2019 23:20:11 | 25,200 | a949133c4b22a87c79310b2d825f2899028d6088 | gvisor: interrupt the sendfile system call if a task has been interrupted
sendfile can be called for a big range and it can require significant
amount of time to process it, so we need to handle task interrupts in
this system call. | [
{
"change_type": "MODIFY",
"old_path": "pkg/amutex/amutex.go",
"new_path": "pkg/amutex/amutex.go",
"diff": "@@ -33,6 +33,9 @@ type Sleeper interface {\n// SleepFinish is called by AbortableMutex.Lock() once a contended mutex\n// is acquired or the wait is aborted.\nSleepFinish(success bool)\n+\n+ //... | Go | Apache License 2.0 | google/gvisor | gvisor: interrupt the sendfile system call if a task has been interrupted
sendfile can be called for a big range and it can require significant
amount of time to process it, so we need to handle task interrupts in
this system call.
PiperOrigin-RevId: 249781023
Change-Id: Ifc2ec505d74c06f5ee76f93b8d30d518ec2d4015 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.