author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,881 | 24.05.2019 13:23:01 | 25,200 | 6cdec6fadf7515a2d8feddcbc3058927897cbbc9 | Wrap comments and reword in common present tense | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/prctl.go",
"new_path": "pkg/abi/linux/prctl.go",
"diff": "@@ -16,80 +16,80 @@ package linux\n// PR_* flags, from <linux/pcrtl.h> for prctl(2).\nconst (\n- // PR_SET_PDEATHSIG will set the process' death signal.\n+ // PR_SET_PDEATHSIG sets the pro... | Go | Apache License 2.0 | google/gvisor | Wrap comments and reword in common present tense
PiperOrigin-RevId: 249888234
Change-Id: Icfef32c3ed34809c34100c07e93e9581c786776e |
259,858 | 24.05.2019 16:16:54 | 25,200 | ed5793808e9d97789c9494d86c9fa4ed62df46bb | Remove obsolete TODO.
We don't need to model internal interfaces after the system
call interfaces (which are objectively worse and simply use a
flag to distinguish between two logically different operations). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode_operations.go",
"new_path": "pkg/sentry/fs/inode_operations.go",
"diff": "@@ -117,9 +117,6 @@ type InodeOperations interface {\n// Remove removes the given named non-directory under dir.\n//\n// The caller must ensure that this operation is... | Go | Apache License 2.0 | google/gvisor | Remove obsolete TODO.
We don't need to model internal interfaces after the system
call interfaces (which are objectively worse and simply use a
flag to distinguish between two logically different operations).
PiperOrigin-RevId: 249916814
Change-Id: I45d02e0ec0be66b782a685b1f305ea027694cab9 |
260,017 | 27.05.2019 20:12:08 | -3,600 | b57660dffbc5a49882d9ba8e5136158e640b3885 | Changed example command for profiling CPU/heap
Profiling a container that runs `sleep 1000` command dumps an empty CPU profile that may cause unnecessary questions. I suggest replacing this example with one mentioned in the same doc above. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/debugging.md",
"new_path": "content/docs/user_guide/debugging.md",
"diff": "@@ -89,7 +89,7 @@ the options available:\nFor example:\n```bash\n-docker run --runtime=runsc-prof --rm -d alpine sleep 1000\n+docker run --runtime=runsc-prof --... | Go | Apache License 2.0 | google/gvisor | Changed example command for profiling CPU/heap
Profiling a container that runs `sleep 1000` command dumps an empty CPU profile that may cause unnecessary questions. I suggest replacing this example with one mentioned in the same doc above. |
260,017 | 28.05.2019 11:53:18 | -3,600 | 7c94c9d77c6287d296f4ffed925ef5efa3a173f1 | Changed sleep time in examples
from 0.1 sec to 1 sec (in two places), according to the feedback | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/debugging.md",
"new_path": "content/docs/user_guide/debugging.md",
"diff": "@@ -46,7 +46,7 @@ gVisor. It connects to the sandbox process, collects a stack dump, and writes\nit to the console. For example:\n```bash\n-docker run --runtime... | Go | Apache License 2.0 | google/gvisor | Changed sleep time in examples
from 0.1 sec to 1 sec (in two places), according to the feedback |
259,884 | 29.05.2019 04:17:23 | 14,400 | b532e65552a6035a827b5df28aaaee4d003c420e | Add gitter link to footer | [
{
"change_type": "MODIFY",
"old_path": "config.toml",
"new_path": "config.toml",
"diff": "@@ -115,6 +115,11 @@ no = 'Sorry to hear that. Please <a href=\"https://github.com/USERNAME/REPOSITORY\nurl = \"/docs/\"\nicon = \"fa fa-book\"\ndesc = \"Read our documentation to understand gVisor, its archite... | Go | Apache License 2.0 | google/gvisor | Add gitter link to footer |
259,858 | 24.05.2019 17:10:43 | 25,200 | 2165b77774eaa40bb7d870fddea733cd899006b9 | Remove obsolete bug.
The original bug is no longer relevant, and the FIXME here
contains lots of obsolete information. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dentry.go",
"new_path": "pkg/sentry/fs/dentry.go",
"diff": "@@ -83,9 +83,6 @@ type DirCtx struct {\nattrs map[string]DentAttr\n// DirCursor is the directory cursor.\n- // TODO(b/67778717): Once Handles are removed this can just live in the\n- // ... | Go | Apache License 2.0 | google/gvisor | Remove obsolete bug.
The original bug is no longer relevant, and the FIXME here
contains lots of obsolete information.
PiperOrigin-RevId: 249924036 |
259,858 | 24.05.2019 18:09:38 | 25,200 | f29ea87d2aa155e1b7966c9f899441cd11eae4ab | Create annotated tags for release. | [
{
"change_type": "MODIFY",
"old_path": "tools/tag_release.sh",
"new_path": "tools/tag_release.sh",
"diff": "# validate a provided release name, create a tag and push it. It must be\n# run manually when a release is created.\n-set -euxo pipefail\n+set -xeu\n# Check arguments.\nif [ \"$#\" -ne 2 ]; th... | Go | Apache License 2.0 | google/gvisor | Create annotated tags for release.
PiperOrigin-RevId: 249929942 |
259,992 | 28.05.2019 11:16:45 | 25,200 | 1e42b4cfcad9ff4becb1041b14107815f585becf | Update internal flag name and documentation
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/exec.go",
"new_path": "runsc/cmd/exec.go",
"diff": "@@ -40,6 +40,8 @@ import (\n\"gvisor.googlesource.com/gvisor/runsc/specutils\"\n)\n+const privateClearStatusFlag = \"private-clear-status\"\n+\n// Exec implements subcommands.Command for the \"exec\... | Go | Apache License 2.0 | google/gvisor | Update internal flag name and documentation
Updates #234
PiperOrigin-RevId: 250323553 |
259,853 | 28.05.2019 11:47:46 | 25,200 | 673358c0d94f82ac56d9f4f6e7aec7ff5761e1cc | runsc/do: allow to run commands in a host network namespace | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -182,6 +182,17 @@ run_syscall_tests() {\n--test_tag_filters=runsc_ptrace //test/syscalls/...\n}\n+run_runsc_do_tests() {\n+ local runsc=$(find bazel-bin/runsc -type f -executable -name \"runs... | Go | Apache License 2.0 | google/gvisor | runsc/do: allow to run commands in a host network namespace
PiperOrigin-RevId: 250329795 |
259,881 | 28.05.2019 18:02:07 | 25,200 | 507a15dce974d0cff18253ba50af29d6579bacc5 | Always wait on tracee children
After ("wait/ptrace: assume
__WALL if the child is traced") (Linux 4.7), tracees are always eligible
for waiting, regardless of type. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_exit.go",
"new_path": "pkg/sentry/kernel/task_exit.go",
"diff": "@@ -803,13 +803,17 @@ type WaitOptions struct {\n}\n// Preconditions: The TaskSet mutex must be locked (for reading or writing).\n-func (o *WaitOptions) matchesTask(t *Task... | Go | Apache License 2.0 | google/gvisor | Always wait on tracee children
After bf959931ddb88c4e4366e96dd22e68fa0db9527c ("wait/ptrace: assume
__WALL if the child is traced") (Linux 4.7), tracees are always eligible
for waiting, regardless of type.
PiperOrigin-RevId: 250399527 |
259,853 | 28.05.2019 22:28:01 | 25,200 | 4b9cb381572e0f61f2a6c2259094548172900e0d | gvisor: socket() returns EPROTONOSUPPORT if protocol is not supported | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/provider.go",
"new_path": "pkg/sentry/socket/epsocket/provider.go",
"diff": "@@ -76,7 +76,7 @@ func getTransportProtocol(ctx context.Context, stype transport.SockType, protoco\nreturn header.TCPProtocolNumber, nil\n}\n}\n- return 0, ... | Go | Apache License 2.0 | google/gvisor | gvisor: socket() returns EPROTONOSUPPORT if protocol is not supported
PiperOrigin-RevId: 250426407 |
259,853 | 28.05.2019 23:02:07 | 25,200 | b52e571a6188ce90b5a13b002753230780119db9 | runsc/do: don't specify the read-only flag for the root mount
The root mount is an overlay mount. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/do.go",
"new_path": "runsc/cmd/do.go",
"diff": "@@ -106,7 +106,6 @@ func (c *Do) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}) su\nspec := &specs.Spec{\nRoot: &specs.Root{\nPath: absRoot,\n- Readonly: true,\n},\nProcess: &specs.Pro... | Go | Apache License 2.0 | google/gvisor | runsc/do: don't specify the read-only flag for the root mount
The root mount is an overlay mount.
PiperOrigin-RevId: 250429317 |
259,962 | 29.05.2019 11:30:59 | 25,200 | 035a8fa38ed21da2e06db22d3dfd6122610fb856 | Add support for collecting execution trace to runsc.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/pprof.go",
"new_path": "pkg/sentry/control/pprof.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"errors\"\n\"runtime\"\n\"runtime/pprof\"\n+ \"runtime/trace\"\n\"sync\"\n\"gvisor.googlesource.com/gvisor/pkg/fd\"\n@@ -52,6 +53,9 @@ type Profile s... | Go | Apache License 2.0 | google/gvisor | Add support for collecting execution trace to runsc.
Updates #220
PiperOrigin-RevId: 250532302 |
259,976 | 29.05.2019 16:48:19 | 25,200 | b18df9bed6af3ff9b526c9ebdcde33dffeac161e | Add VmData field to /proc/{pid}/status
VmData is the size of private data segments.
It has the same meaning as in Linux. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -578,7 +578,7 @@ func (s *statusData) ReadSeqFileData(ctx context.Context, h seqfile.SeqHandle) (\n}\nfmt.Fprintf(&buf, \"TracerPid:\\t%d\\n\", tpid)\nvar fds int\n- var vss, rs... | Go | Apache License 2.0 | google/gvisor | Add VmData field to /proc/{pid}/status
VmData is the size of private data segments.
It has the same meaning as in Linux.
Change-Id: Iebf1ae85940a810524a6cde9c2e767d4233ddb2a
PiperOrigin-RevId: 250593739 |
259,881 | 29.05.2019 17:46:50 | 25,200 | 8d25cd0b40694d1911724816d72b34d0717878d6 | Update procid for Go 1.13
Upstream Go has no changes here. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/procid/procid_amd64.s",
"new_path": "pkg/sentry/platform/procid/procid_amd64.s",
"diff": "// +build amd64\n// +build go1.8\n-// +build !go1.13\n+// +build !go1.14\n#include \"textflag.h\"\n"
},
{
"change_type": "MODIFY",
"old_pa... | Go | Apache License 2.0 | google/gvisor | Update procid for Go 1.13
Upstream Go has no changes here.
PiperOrigin-RevId: 250602731 |
259,992 | 30.05.2019 12:01:41 | 25,200 | 38de91b028639ef5f4a4c8874b3ee23503fd2f3a | Add build guard to files using go:linkname
Funcion signatures are not validated during compilation. Since
they are not exported, they can change at any time. The guard
ensures that they are verified at least on every version upgrade. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n+// +build go1.12\n+// +build !go1.14\n+\... | Go | Apache License 2.0 | google/gvisor | Add build guard to files using go:linkname
Funcion signatures are not validated during compilation. Since
they are not exported, they can change at any time. The guard
ensures that they are verified at least on every version upgrade.
PiperOrigin-RevId: 250733742 |
259,858 | 31.05.2019 15:42:08 | 25,200 | 132bf68de47569e761227de9fd6177e8b32f6c38 | Switch to new dedicated RBE project. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/common.cfg",
"new_path": "kokoro/common.cfg",
"diff": "@@ -11,7 +11,7 @@ before_action {\n# Configure bazel to access RBE.\nbazel_setting {\n# Our GCP project name\n- project_id: \"copybara-shentu\"\n+ project_id: \"gvisor-rbe\"\n# Use RBE for execution... | Go | Apache License 2.0 | google/gvisor | Switch to new dedicated RBE project.
PiperOrigin-RevId: 250970783 |
259,891 | 31.05.2019 16:14:04 | 25,200 | d58eb9ce828fd7c831f30e922e01f1d2b84e462c | Add basic iptables structures to netstack. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/tcpip/iptables/BUILD",
"diff": "+package(licenses = [\"notice\"])\n+\n+load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\n+\n+go_library(\n+ name = \"iptables\",\n+ srcs = [\n+ \"iptables.go\",\n+ \"targets.go\",\n+ \"types... | Go | Apache License 2.0 | google/gvisor | Add basic iptables structures to netstack.
Change-Id: Ib589906175a59dae315405a28f2d7f525ff8877f |
259,962 | 31.05.2019 16:16:24 | 25,200 | 033f96cc9313d7ceb3df14227ef3724ec3295d2a | Change segment queue limit to be of fixed size.
Netstack sets the unprocessed segment queue size to match the receive
buffer size. This is not required as this queue only needs to hold enough
for a short duration before the endpoint goroutine can process it.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -335,7 +335,7 @@ func newEndpoint(stack *stack.Stack, netProto tcpip.NetworkProtocolNumber, waite\ne.probe = p\n}\n- e.segmentQueue.setLimit(2 * e.rcvBufSize)\... | Go | Apache License 2.0 | google/gvisor | Change segment queue limit to be of fixed size.
Netstack sets the unprocessed segment queue size to match the receive
buffer size. This is not required as this queue only needs to hold enough
for a short duration before the endpoint goroutine can process it.
Updates #230
PiperOrigin-RevId: 250976323 |
259,853 | 03.06.2019 10:58:38 | 25,200 | 8e926e3f74cef3d04b37c6a68ba5de966e9d9839 | gvisor: validate a new map region in the mremap syscall
Right now, mremap allows to remap a memory region over MaxUserAddress,
this means that we can change the stub region. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/syscalls.go",
"new_path": "pkg/sentry/mm/syscalls.go",
"diff": "@@ -470,6 +470,16 @@ func (mm *MemoryManager) MRemap(ctx context.Context, oldAddr usermem.Addr, oldSi\nreturn 0, syserror.EINVAL\n}\n+ // Check that the new region is valid.\n+ _, er... | Go | Apache License 2.0 | google/gvisor | gvisor: validate a new map region in the mremap syscall
Right now, mremap allows to remap a memory region over MaxUserAddress,
this means that we can change the stub region.
PiperOrigin-RevId: 251266886 |
259,881 | 03.06.2019 12:47:21 | 25,200 | 955685845e6c1d855315978291195f35a73d7cc1 | Remove spurious period | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -432,7 +432,7 @@ func createMemoryFile() (*pgalloc.MemoryFile, error) {\nreturn mf, nil\n}\n-// Run runs the root container..\n+// Run runs the root container.\nfunc (l *Loader) Run() error... | Go | Apache License 2.0 | google/gvisor | Remove spurious period
PiperOrigin-RevId: 251288885 |
259,881 | 03.06.2019 13:30:51 | 25,200 | 6e1f51f3eb44bdee85c50d075e750e857adef9fd | Remove duplicate socket tests
socket_unix_abstract.cc: Subset of socket_abstract.cc
socket_unix_filesystem.cc: Subset of socket_filesystem.cc | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -417,12 +417,6 @@ syscall_test(\ntest = \"//test/syscalls/linux:socket_stream_nonblock_local_test\",\n)\n-syscall_test(\n- size = \"large\",\n- shard_count = 10,\n- test = \"//test/syscalls/l... | Go | Apache License 2.0 | google/gvisor | Remove duplicate socket tests
socket_unix_abstract.cc: Subset of socket_abstract.cc
socket_unix_filesystem.cc: Subset of socket_filesystem.cc
PiperOrigin-RevId: 251297117 |
259,962 | 03.06.2019 16:58:59 | 25,200 | bfe32209923472da2d8e263b6cb725a2e64a8689 | Delete debug log lines left by mistake.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -19,7 +19,6 @@ import (\n\"encoding/binary\"\n\"hash\"\n\"io\"\n- \"log\"\n\"sync\"\n\"time\"\n@@ -307,7 +306,6 @@ func (e *endpoint) handleSynSegment(ctx *listenC... | Go | Apache License 2.0 | google/gvisor | Delete debug log lines left by mistake.
Updates #236
PiperOrigin-RevId: 251337915 |
259,858 | 03.06.2019 18:04:43 | 25,200 | 18e6e63503251cdc0b9432765b6eaa9ffa002824 | Allow specification of origin in cloudbuild. | [
{
"change_type": "MODIFY",
"old_path": "cloudbuild/go.yaml",
"new_path": "cloudbuild/go.yaml",
"diff": "@@ -17,4 +17,6 @@ steps:\nentrypoint: 'bash'\nargs:\n- '-c'\n- - 'if [[ \"$BRANCH_NAME\" == \"master\" ]]; then git push origin go:go; fi'\n+ - 'if [[ \"$BRANCH_NAME\" == \"master\" ]]; then git p... | Go | Apache License 2.0 | google/gvisor | Allow specification of origin in cloudbuild.
PiperOrigin-RevId: 251347966 |
259,853 | 03.06.2019 21:24:56 | 25,200 | 00f8663887cbf9057d93e8848eb9538cf1c0cff4 | gvisor/fs: return a proper error from FileWriter.Write in case of a short-write
The io.Writer contract requires that Write writes all available
bytes and does not return short writes. This causes errors with
io.Copy, since our own Write interface does not have this same
contract. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/file.go",
"new_path": "pkg/sentry/fs/file.go",
"diff": "@@ -545,12 +545,28 @@ type lockedWriter struct {\n// Write implements io.Writer.Write.\nfunc (w *lockedWriter) Write(buf []byte) (int, error) {\n- n, err := w.File.FileOperations.Write(w.Ctx... | Go | Apache License 2.0 | google/gvisor | gvisor/fs: return a proper error from FileWriter.Write in case of a short-write
The io.Writer contract requires that Write writes all available
bytes and does not return short writes. This causes errors with
io.Copy, since our own Write interface does not have this same
contract.
PiperOrigin-RevId: 251368730 |
259,853 | 03.06.2019 21:47:09 | 25,200 | 90a116890fcea9fd39911bae854e4e67608a141d | gvisor/sock/unix: pass creds when a message is sent between unconnected sockets
and don't report a sender address if it doesn't have one | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/socket.go",
"new_path": "pkg/sentry/fs/gofer/socket.go",
"diff": "@@ -139,3 +139,8 @@ func (e *endpoint) UnidirectionalConnect() (transport.ConnectedEndpoint, *syserr\nfunc (e *endpoint) Release() {\ne.inode.DecRef()\n}\n+\n+// Passcred imp... | Go | Apache License 2.0 | google/gvisor | gvisor/sock/unix: pass creds when a message is sent between unconnected sockets
and don't report a sender address if it doesn't have one
PiperOrigin-RevId: 251371284 |
259,858 | 03.06.2019 22:59:35 | 25,200 | f520d0d585e159da902b2880c5e115abeaacf9cb | Resolve impossible dependencies. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -38,8 +38,8 @@ http_archive(\n# External repositories, in sorted order.\ngo_repository(\nname = \"com_github_cenkalti_backoff\",\n+ commit = \"2146c9339422\",\nimportpath = \"github.com/cenkalti/backoff\",\n- ta... | Go | Apache License 2.0 | google/gvisor | Resolve impossible dependencies.
PiperOrigin-RevId: 251377523 |
259,884 | 02.06.2019 15:20:37 | 14,400 | 837a5b13223c33f81e094ccbef1bfa86950c2899 | Add y-axis label to redis benchmark
Adds a "method" to the redis benchmark csv
fixes | [
{
"change_type": "MODIFY",
"old_path": "static/performance/redis.csv",
"new_path": "static/performance/redis.csv",
"diff": "-runtime,metric,result\n-runc,PING_INLINE,30525.03\n-runc,PING_BULK,30293.85\n-runc,SET,30257.19\n-runc,GET,30312.21\n-runc,INCR,30525.03\n-runc,LPUSH,30712.53\n-runc,RPUSH,304... | Go | Apache License 2.0 | google/gvisor | Add y-axis label to redis benchmark
Adds a "method" to the redis benchmark csv
fixes #69 |
259,858 | 04.06.2019 11:06:13 | 25,200 | 7436ea247bc946b36a7e5e6ca6019796ef76d85c | Fix Kokoro revision and 'go get usage'
As a convenience for debugging, also factor the scripts such that
can be run without Kokoro. In the future, this may be used to add
additional presubmit hooks that run without Kokoro. | [
{
"change_type": "DELETE",
"old_path": "kokoro/run_build.sh",
"new_path": null,
"diff": "-#!/bin/bash\n-\n-# Copyright 2018 The gVisor Authors.\n-#\n-# Licensed under the Apache License, Version 2.0 (the \"License\");\n-# you may not use this file except in compliance with the License.\n-# You may o... | Go | Apache License 2.0 | google/gvisor | Fix Kokoro revision and 'go get usage'
As a convenience for debugging, also factor the scripts such that
can be run without Kokoro. In the future, this may be used to add
additional presubmit hooks that run without Kokoro.
PiperOrigin-RevId: 251474868 |
259,858 | 04.06.2019 14:42:25 | 25,200 | 6f92038ce0d2062c3dfd84fe65141ee09deeabfc | Use github directory if it exists.
Unfortunately, kokoro names the top-level directory per the SCM type. This
means there's no way to make the job names match; we simply need to probe for
the existence of the correct directory. | [
{
"change_type": "MODIFY",
"old_path": "tools/run_build.sh",
"new_path": "tools/run_build.sh",
"diff": "@@ -23,9 +23,11 @@ set -x\n(which use_bazel.sh && use_bazel.sh latest) || which bazel\nbazel version\n-# Switch into the workspace and checkout the appropriate commit.\n-if [[ -v KOKORO_GIT_COMMIT... | Go | Apache License 2.0 | google/gvisor | Use github directory if it exists.
Unfortunately, kokoro names the top-level directory per the SCM type. This
means there's no way to make the job names match; we simply need to probe for
the existence of the correct directory.
PiperOrigin-RevId: 251519409 |
259,858 | 04.06.2019 23:08:20 | 25,200 | cecb71dc37a77d8e4e88cdfada92a37a72c67602 | Building containerd with go modules is broken, use GOPATH. | [
{
"change_type": "MODIFY",
"old_path": "tools/run_tests.sh",
"new_path": "tools/run_tests.sh",
"diff": "@@ -106,18 +106,31 @@ install_runtime() {\nsudo -n ${WORKSPACE_DIR}/runsc/test/install.sh --runtime ${RUNTIME}\n}\n+install_helper() {\n+ PACKAGE=\"${1}\"\n+ TAG=\"${2}\"\n+ GOPATH=\"${3}\"\n+\n+ ... | Go | Apache License 2.0 | google/gvisor | Building containerd with go modules is broken, use GOPATH.
PiperOrigin-RevId: 251583707 |
259,858 | 01.06.2019 00:42:25 | 25,200 | 483794db83cf238ba0825a7a0ec0b47b4e173bc3 | Intercept all ?go-get=1 requests. | [
{
"change_type": "MODIFY",
"old_path": "cmd/gvisor-website/main.go",
"new_path": "cmd/gvisor-website/main.go",
"diff": "@@ -49,7 +49,28 @@ var prefixHelpers = map[string]string{\n\"c/linux/amd64\": \"/docs/user_guide/compatibility/amd64/#%s\",\n}\n-var validId = regexp.MustCompile(`^[A-Za-z0-9-]*/?$... | Go | Apache License 2.0 | google/gvisor | Intercept all ?go-get=1 requests. |
259,853 | 05.06.2019 22:50:48 | 25,200 | 79f7cb6c1c4c16e3aca44d7fdc8e9f2487a605cf | netstack/sniffer: log GSO attributes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sniffer/sniffer.go",
"new_path": "pkg/tcpip/link/sniffer/sniffer.go",
"diff": "@@ -118,7 +118,7 @@ func NewWithFile(lower tcpip.LinkEndpointID, file *os.File, snapLen uint32) (tcp\n// logs the packet before forwarding to the actual dispatcher.\n... | Go | Apache License 2.0 | google/gvisor | netstack/sniffer: log GSO attributes
PiperOrigin-RevId: 251788534 |
259,962 | 06.06.2019 08:05:46 | 25,200 | 85be01b42d4ac48698d1e8f50a4cf2607a4fc50b | Add multi-fd support to fdbased endpoint.
This allows an fdbased endpoint to have multiple underlying fd's from which
packets can be read and dispatched/written to.
This should allow for higher throughput as well as better scalability of the
network stack as number of connections increases.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "// FD based endpoints can be used in the networking stack by calling New() to\n// create a new endpoint, and then passing it as an argument to\n// Stack.CreateNIC()... | Go | Apache License 2.0 | google/gvisor | Add multi-fd support to fdbased endpoint.
This allows an fdbased endpoint to have multiple underlying fd's from which
packets can be read and dispatched/written to.
This should allow for higher throughput as well as better scalability of the
network stack as number of connections increases.
Updates #231
PiperOrigin-RevId: 251852825 |
259,985 | 06.06.2019 14:30:50 | 25,200 | 8b8bd8d5b28a8e41f59fc3465c38964986bfb084 | Try increase listen backlog. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -198,7 +198,7 @@ TEST_P(SocketInetReusePortTest, TcpPortReuseMultiThread) {\nASSERT_THAT(\nbind(fd, reinterpret_cast<sockaddr*>(&listen_addr), ... | Go | Apache License 2.0 | google/gvisor | Try increase listen backlog.
PiperOrigin-RevId: 251928000 |
259,992 | 06.06.2019 14:37:12 | 25,200 | bf0b1b9d767736e632fa56b90d904fee968d8d3d | Add overlay dimension to FS related syscall tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -13,11 +13,17 @@ syscall_test(\ntest = \"//test/syscalls/linux:accept_bind_test\",\n)\n-syscall_test(test = \"//test/syscalls/linux:access_test\")\n+syscall_test(\n+ add_overlay = True,\n+ te... | Go | Apache License 2.0 | google/gvisor | Add overlay dimension to FS related syscall tests
PiperOrigin-RevId: 251929314 |
259,992 | 06.06.2019 15:54:54 | 25,200 | 93aa7d11673392ca51ba69122ff5fe1aad7331b9 | Remove tmpfs restriction from test
runsc supports UDS over gofer mounts and tmpfs is
not needed for this test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -669,12 +669,7 @@ syscall_test(\ntest = \"//test/syscalls/linux:write_test\",\n)\n-syscall_test(\n- test = \"//test/syscalls/linux:proc_net_unix_test\",\n- # Unix domain socket creation isn't... | Go | Apache License 2.0 | google/gvisor | Remove tmpfs restriction from test
runsc supports UDS over gofer mounts and tmpfs is
not needed for this test.
PiperOrigin-RevId: 251944870 |
259,885 | 06.06.2019 16:26:00 | 25,200 | a26043ee53a2f38b81c9eaa098d115025e87f4c3 | Implement reclaim-driven MemoryFile eviction. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/hostmm/BUILD",
"diff": "+load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"hostmm\",\n+ srcs = [\n+ \"cgroup.go\",\n+ \"hostmm.go\",\n+ ],\n+ importpath = \"gviso... | Go | Apache License 2.0 | google/gvisor | Implement reclaim-driven MemoryFile eviction.
PiperOrigin-RevId: 251950660 |
259,885 | 06.06.2019 16:27:09 | 25,200 | b3f104507d7a04c0ca058cbcacc5ff78d853f4ba | "Implement" mbind(2).
We still only advertise a single NUMA node, and ignore mempolicy
accordingly, but mbind() at least now succeeds and has effects reflected
by get_mempolicy().
Also fix handling of nodemasks: round sizes to unsigned long (as
documented and done by Linux), and zero trailing bits when copying them
out. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/mm.go",
"new_path": "pkg/abi/linux/mm.go",
"diff": "@@ -114,3 +114,12 @@ const (\nMPOL_MODE_FLAGS = (MPOL_F_STATIC_NODES | MPOL_F_RELATIVE_NODES)\n)\n+\n+// Flags for mbind(2).\n+const (\n+ MPOL_MF_STRICT = 1 << 0\n+ MPOL_MF_MOVE = 1 << 1\n+ MPOL... | Go | Apache License 2.0 | google/gvisor | "Implement" mbind(2).
We still only advertise a single NUMA node, and ignore mempolicy
accordingly, but mbind() at least now succeeds and has effects reflected
by get_mempolicy().
Also fix handling of nodemasks: round sizes to unsigned long (as
documented and done by Linux), and zero trailing bits when copying them
out.
PiperOrigin-RevId: 251950859 |
259,884 | 06.06.2019 16:57:18 | 25,200 | 6a4c0065642922c157511fa2cd3feea85cb7c44b | Add the gVisor gitter badge to the README
Moves the build badge to just below the logo and adds the gitter badge next to
it for consistency. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "\n+[](https://storage.googleapis.com/gvisor-build-badges/build.html)\n+[![gVisor chat](https://badges.gitter.im/gvisor... | Go | Apache License 2.0 | google/gvisor | Add the gVisor gitter badge to the README
Moves the build badge to just below the logo and adds the gitter badge next to
it for consistency.
PiperOrigin-RevId: 251956383 |
259,992 | 06.06.2019 17:48:53 | 25,200 | 2e43dcb26b4ccbc4d4f314be61806a82f073a50e | Add alsologtostderr option
When set sends log messages to the error log:
sudo ./runsc --logtostderr do ls
I0531 17:59:58.105064 144564 x:0] ***************************
I0531 17:59:58.105087 144564 x:0] Args: [runsc --logtostderr do ls]
I0531 17:59:58.105112 144564 x:0] PID: 144564
I0531 17:59:58.105125 144564 x:0] UID: 0, GID: 0
[...] | [
{
"change_type": "MODIFY",
"old_path": "runsc/main.go",
"new_path": "runsc/main.go",
"diff": "@@ -53,6 +53,7 @@ var (\nlogFD = flag.Int(\"log-fd\", -1, \"file descriptor to log to. If set, the 'log' flag is ignored.\")\ndebugLogFD = flag.Int(\"debug-log-fd\", -1, \"file descriptor to write debug log... | Go | Apache License 2.0 | google/gvisor | Add alsologtostderr option
When set sends log messages to the error log:
sudo ./runsc --logtostderr do ls
I0531 17:59:58.105064 144564 x:0] ***************************
I0531 17:59:58.105087 144564 x:0] Args: [runsc --logtostderr do ls]
I0531 17:59:58.105112 144564 x:0] PID: 144564
I0531 17:59:58.105125 144564 x:0] UID: 0, GID: 0
[...]
PiperOrigin-RevId: 251964377 |
259,885 | 06.06.2019 17:57:42 | 25,200 | c933f3eede5634bf778dfb757fb68d927a43a7a8 | Change visibility of //pkg/sentry/time. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/time/BUILD",
"new_path": "pkg/sentry/time/BUILD",
"diff": "@@ -32,7 +32,7 @@ go_library(\n\"tsc_arm64.s\",\n],\nimportpath = \"gvisor.googlesource.com/gvisor/pkg/sentry/time\",\n- visibility = [\"//pkg/sentry:internal\"],\n+ visibility = [\"//:sandb... | Go | Apache License 2.0 | google/gvisor | Change visibility of //pkg/sentry/time.
PiperOrigin-RevId: 251965598 |
259,858 | 06.06.2019 22:08:49 | 25,200 | e5fb3aab122c546441c595c2135a273468c5a997 | BUILD: Use runsc to generate version
This also ensures BUILD files are correctly formatted. | [
{
"change_type": "MODIFY",
"old_path": "runsc/BUILD",
"new_path": "runsc/BUILD",
"diff": "-package(\n- licenses = [\"notice\"], # Apache 2.0\n-)\n+package(licenses = [\"notice\"]) # Apache 2.0\nload(\"@io_bazel_rules_go//go:def.bzl\", \"go_binary\")\nload(\"@bazel_tools//tools/build_defs/pkg:pkg.bzl... | Go | Apache License 2.0 | google/gvisor | BUILD: Use runsc to generate version
This also ensures BUILD files are correctly formatted.
PiperOrigin-RevId: 251990267 |
259,891 | 07.06.2019 12:54:53 | 25,200 | 8afbd974da2483d8f81e3abde5c9d689719263cb | Address Ian's comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/iptables/iptables.go",
"new_path": "pkg/tcpip/iptables/iptables.go",
"diff": "@@ -34,9 +34,9 @@ const (\n// all packets.\nfunc DefaultTables() *IPTables {\ntables := IPTables{\n- Tables: map[string]*Table{\n- tablenameNat: &Table{\n- BuiltinChains: m... | Go | Apache License 2.0 | google/gvisor | Address Ian's comments.
Change-Id: I7445033b1970cbba3f2ed0682fe520dce02d8fad |
259,885 | 07.06.2019 14:51:18 | 25,200 | 48961d27a8bcc76b3783a7cc4a4a5ebcd5532d25 | Move //pkg/sentry/memutil to //pkg/memutil. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/memutil/BUILD",
"diff": "+load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"memutil\",\n+ srcs = [\"memutil_unsafe.go\"],\n+ importpath = \"gvisor.googlesource.com/gviso... | Go | Apache License 2.0 | google/gvisor | Move //pkg/sentry/memutil to //pkg/memutil.
PiperOrigin-RevId: 252124156 |
259,885 | 10.06.2019 15:46:17 | 25,200 | 589f36ac4ae31b1f7f35a74d982398e48c28aa31 | Move //pkg/sentry/platform/procid to //pkg/procid. | [
{
"change_type": "RENAME",
"old_path": "pkg/sentry/platform/procid/BUILD",
"new_path": "pkg/procid/BUILD",
"diff": "@@ -9,8 +9,8 @@ go_library(\n\"procid_amd64.s\",\n\"procid_arm64.s\",\n],\n- importpath = \"gvisor.googlesource.com/gvisor/pkg/sentry/platform/procid\",\n- visibility = [\"//pkg/sentry... | Go | Apache License 2.0 | google/gvisor | Move //pkg/sentry/platform/procid to //pkg/procid.
PiperOrigin-RevId: 252501653 |
259,853 | 11.06.2019 09:37:01 | 25,200 | 307a9854edd4a1257b0393d39d8b4fca7b4223e4 | gvisor/test: create a per-testcase directory for runsc logs
Otherwise it's hard to find a directory for a specific test case. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/syscall_test_runner.go",
"new_path": "test/syscalls/syscall_test_runner.go",
"diff": "@@ -200,7 +200,11 @@ func runTestCaseRunsc(testBin string, tc gtest.TestCase, t *testing.T) {\nargs = append(args, \"-strace\")\n}\nif outDir, ok := syscall.Get... | Go | Apache License 2.0 | google/gvisor | gvisor/test: create a per-testcase directory for runsc logs
Otherwise it's hard to find a directory for a specific test case.
PiperOrigin-RevId: 252636901 |
259,992 | 11.06.2019 13:55:17 | 25,200 | a775ae82fed4f703db28edc3d9d58b5652d6979d | Fix broken pipe error building version file
(11:34:09) ERROR: /tmpfs/src/github/repo/runsc/BUILD:82:1: Couldn't build file runsc/version.txt: Executing genrule //runsc:deb-version failed (Broken pipe): bash failed: error executing command | [
{
"change_type": "MODIFY",
"old_path": "runsc/BUILD",
"new_path": "runsc/BUILD",
"diff": "@@ -82,7 +82,7 @@ pkg_tar(\ngenrule(\nname = \"deb-version\",\nouts = [\"version.txt\"],\n- cmd = \"$(location :runsc) -version | head -n 1 | sed 's/^[^0-9]*//' > $@\",\n+ cmd = \"$(location :runsc) -version | ... | Go | Apache License 2.0 | google/gvisor | Fix broken pipe error building version file
(11:34:09) ERROR: /tmpfs/src/github/repo/runsc/BUILD:82:1: Couldn't build file runsc/version.txt: Executing genrule //runsc:deb-version failed (Broken pipe): bash failed: error executing command
PiperOrigin-RevId: 252691902 |
259,992 | 11.06.2019 14:30:34 | 25,200 | 847c4b9759c49cb30728579cfb0f4a69f1987b94 | Use net.HardwareAddr for FDBasedLink.LinkAddress
It prints formatted to the log. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/network.go",
"new_path": "runsc/boot/network.go",
"diff": "@@ -56,7 +56,7 @@ type FDBasedLink struct {\nAddresses []net.IP\nRoutes []Route\nGSOMaxSize uint32\n- LinkAddress []byte\n+ LinkAddress net.HardwareAddr\n// NumChannels controls how many und... | Go | Apache License 2.0 | google/gvisor | Use net.HardwareAddr for FDBasedLink.LinkAddress
It prints formatted to the log.
PiperOrigin-RevId: 252699551 |
259,853 | 11.06.2019 16:35:42 | 25,200 | 69c8657a66ac1a7e3bfd388de0a7cd28ac4b51cd | kokoro: don't overwrite test results for different runtimes | [
{
"change_type": "MODIFY",
"old_path": "tools/run_tests.sh",
"new_path": "tools/run_tests.sh",
"diff": "@@ -175,13 +175,17 @@ run_docker_tests() {\n# configuration, e.g. save/restore not supported with hostnet.\ndeclare -a variations=(\"\" \"-kvm\" \"-hostnet\" \"-overlay\")\nfor v in \"${variations... | Go | Apache License 2.0 | google/gvisor | kokoro: don't overwrite test results for different runtimes
PiperOrigin-RevId: 252724255 |
259,858 | 11.06.2019 19:23:27 | 25,200 | df110ad4fe571721a7eb4a5a1f9ce92584ef7809 | Eat sendfile partial error
For sendfile(2), we propagate a TCP error through the system call layer.
This should be eaten if there is a partial result. This change also adds
a test to ensure that there is no panic in this case, for both TCP sockets
and unix domain sockets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/error.go",
"new_path": "pkg/sentry/syscalls/linux/error.go",
"diff": "@@ -92,6 +92,10 @@ func handleIOError(t *kernel.Task, partialResult bool, err, intr error, op strin\n// TODO(gvisor.dev/issue/161): In some cases SIGPIPE should\n//... | Go | Apache License 2.0 | google/gvisor | Eat sendfile partial error
For sendfile(2), we propagate a TCP error through the system call layer.
This should be eaten if there is a partial result. This change also adds
a test to ensure that there is no panic in this case, for both TCP sockets
and unix domain sockets.
PiperOrigin-RevId: 252746192 |
259,853 | 12.06.2019 10:47:38 | 25,200 | 0d05a12fd394e464d44d8d39c58b22249358ed19 | gvisor/ptrace: print guest registers if a stub stopped with unexpected code | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess.go",
"diff": "@@ -21,6 +21,7 @@ import (\n\"sync\"\n\"syscall\"\n+ \"gvisor.googlesource.com/gvisor/pkg/log\"\n\"gvisor.googlesource.com/gvisor/pkg/procid\"\n\"gvisor... | Go | Apache License 2.0 | google/gvisor | gvisor/ptrace: print guest registers if a stub stopped with unexpected code
PiperOrigin-RevId: 252855280 |
259,853 | 12.06.2019 11:54:15 | 25,200 | bb849bad296f372670c2d2cf97424f74cf750ce2 | gvisor/runsc: apply seccomp filters before parsing a state file | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -16,6 +16,7 @@ go_library(\n\"limits.go\",\n\"loader.go\",\n\"network.go\",\n+ \"pprof.go\",\n\"strace.go\",\n],\nimportpath = \"gvisor.googlesource.com/gvisor/runsc/boot\",\n"
},
{
"change... | Go | Apache License 2.0 | google/gvisor | gvisor/runsc: apply seccomp filters before parsing a state file
PiperOrigin-RevId: 252869983 |
259,962 | 12.06.2019 13:34:47 | 25,200 | 70578806e8d3e01fae2249b3e602cd5b05d378a0 | Add support for TCP_CONGESTION socket option.
This CL also cleans up the error returned for setting congestion
control which was incorrectly returning EINVAL instead of ENOENT. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -920,6 +920,30 @@ func getSockOptTCP(t *kernel.Task, ep commonEndpoint, name, outLen int) (interfa\nt.Kernel().EmitUnimplementedEvent(t)\n+ case linux.TC... | Go | Apache License 2.0 | google/gvisor | Add support for TCP_CONGESTION socket option.
This CL also cleans up the error returned for setting congestion
control which was incorrectly returning EINVAL instead of ENOENT.
PiperOrigin-RevId: 252889093 |
259,858 | 12.06.2019 10:17:58 | 25,200 | c1636b150ab0041782634b3d5909ec818675e14d | Add /pr support for links.
This also updates the canonical package name to include a /gvisor
suffix. This is more flexible to allow for future packages or git hook
interception. | [
{
"change_type": "MODIFY",
"old_path": "cmd/gvisor-website/main.go",
"new_path": "cmd/gvisor-website/main.go",
"diff": "@@ -30,28 +30,34 @@ import (\n)\nvar redirects = map[string]string{\n- \"/change\": \"https://gvisor.googlesource.com/gvisor/\",\n- \"/cl\": \"https://gvisor-review.googlesource.co... | Go | Apache License 2.0 | google/gvisor | Add /pr support for links.
This also updates the canonical package name to include a /gvisor
suffix. This is more flexible to allow for future packages or git hook
interception. |
259,858 | 12.06.2019 15:58:32 | 25,200 | e352f464780b22945308469de4e92a4f068b4805 | Minor BUILD file cleanup. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/muxed/BUILD",
"new_path": "pkg/tcpip/link/muxed/BUILD",
"diff": "load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\n-package(\n- licenses = [\"notice\"], # Apache 2.0\n-)\n+package(licenses = [\"notice\"])\ngo_library(\nname = ... | Go | Apache License 2.0 | google/gvisor | Minor BUILD file cleanup.
PiperOrigin-RevId: 252918338 |
259,962 | 13.06.2019 13:40:37 | 25,200 | 9f77b36fa100761eb3eabbb87f5111419202a9d5 | Set optlen correctly when calling getsockopt. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"new_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"diff": "@@ -679,7 +679,7 @@ TEST_P(TCPSocketPairTest, SetCongestionControlFailsForUnsupported) {\nauto sockets = ASSERT_NO_ERRNO_AND_VALUE(NewSocketPair... | Go | Apache License 2.0 | google/gvisor | Set optlen correctly when calling getsockopt.
PiperOrigin-RevId: 253096085 |
259,970 | 13.06.2019 14:26:26 | 25,200 | b915a25597a961311ceb57f89d18eaee9c9461d8 | Fix use of "2 ^ 30".
2 ^ 30 is 28, not | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -259,7 +259,7 @@ func New(args Args) (*Loader, error) {\n// Adjust the total memory returned by the Sentry so that applications that\n// use /proc/meminfo can make allocations based on this... | Go | Apache License 2.0 | google/gvisor | Fix use of "2 ^ 30".
2 ^ 30 is 28, not 1073741824. |
259,884 | 13.06.2019 15:44:17 | 25,200 | 4fdd560b76dfe4e3df83a8cba5a070ce7142b433 | Set the HOME environment variable (fixes
runsc will now set the HOME environment variable as required by POSIX. The
user's home directory is retrieved from the /etc/passwd file located on the
container's file system during boot. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -18,6 +18,7 @@ go_library(\n\"network.go\",\n\"pprof.go\",\n\"strace.go\",\n+ \"user.go\",\n],\nimportpath = \"gvisor.googlesource.com/gvisor/runsc/boot\",\nvisibility = [\n@@ -69,6 +70,7 @@ go_lib... | Go | Apache License 2.0 | google/gvisor | Set the HOME environment variable (fixes #293)
runsc will now set the HOME environment variable as required by POSIX. The
user's home directory is retrieved from the /etc/passwd file located on the
container's file system during boot.
PiperOrigin-RevId: 253120627 |
259,885 | 13.06.2019 15:52:49 | 25,200 | 0c8603084d9399fde250c68fe30a084749d937ff | Add p9 and unet benchmarks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/transport_test.go",
"new_path": "pkg/p9/transport_test.go",
"diff": "@@ -179,6 +179,51 @@ func TestSendClosed(t *testing.T) {\n}\n}\n+func BenchmarkSendRecv(b *testing.B) {\n+ server, client, err := unet.SocketPair(false)\n+ if err != nil {\n+ b.Fatalf(... | Go | Apache License 2.0 | google/gvisor | Add p9 and unet benchmarks.
PiperOrigin-RevId: 253122166 |
259,985 | 13.06.2019 17:23:35 | 25,200 | 05ff1ffaadaa0ac370365eb14febc761506735ce | Implement getsockopt() SO_DOMAIN, SO_PROTOCOL and SO_TYPE.
SO_TYPE was already implemented for everything but netlink sockets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -668,12 +668,6 @@ func GetSockOpt(t *kernel.Task, s socket.Socket, ep commonEndpoint, family int,\nfunc getSockOptSocket(t *kernel.Task, s socket.Socket,... | Go | Apache License 2.0 | google/gvisor | Implement getsockopt() SO_DOMAIN, SO_PROTOCOL and SO_TYPE.
SO_TYPE was already implemented for everything but netlink sockets.
PiperOrigin-RevId: 253138157 |
259,962 | 14.06.2019 07:30:30 | 25,200 | a8608c501b23f89ac3df50cde7428cb3c4b56145 | Enable Receive Buffer Auto-Tuning for runsc.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -847,9 +847,17 @@ func newEmptyNetworkStack(conf *Config, clock tcpip.Clock) (inet.Stack, error) {\n// privileges.\nRaw: true,\n})}\n+\n+ // Enable SACK Recovery.\nif err := s.Stack.SetTran... | Go | Apache License 2.0 | google/gvisor | Enable Receive Buffer Auto-Tuning for runsc.
Updates #230
PiperOrigin-RevId: 253225078 |
259,853 | 17.06.2019 17:07:44 | 25,200 | 66cc0e9f928218ca642a41fa67bb163197aa1f37 | gvisor/bazel: use python2 to build runsc-debian
$ bazel build runsc:runsc-debian
File ".../bazel_tools/tools/build_defs/pkg/make_deb.py", line 311,
in GetFlagValue:
flagvalue = flagvalue.decode('utf-8')
AttributeError: 'str' object has no attribute 'decode'
make_deb.py is incompatible with Python3. | [
{
"change_type": "MODIFY",
"old_path": "Dockerfile",
"new_path": "Dockerfile",
"diff": "FROM ubuntu:bionic\n-RUN apt-get update && apt-get install -y curl gnupg2 git\n+RUN apt-get update && apt-get install -y curl gnupg2 git python3\nRUN echo \"deb [arch=amd64] http://storage.googleapis.com/bazel-ap... | Go | Apache License 2.0 | google/gvisor | gvisor/bazel: use python2 to build runsc-debian
$ bazel build runsc:runsc-debian
File ".../bazel_tools/tools/build_defs/pkg/make_deb.py", line 311,
in GetFlagValue:
flagvalue = flagvalue.decode('utf-8')
AttributeError: 'str' object has no attribute 'decode'
make_deb.py is incompatible with Python3.
https://github.com/bazelbuild/bazel/issues/8443
PiperOrigin-RevId: 253691923 |
259,853 | 18.06.2019 01:40:12 | 25,200 | 3d1e44a677ecacbf81888211a93cef0a71c1c6c0 | gvisor/kokoro: don't modify tests names in the BUILD file | [
{
"change_type": "ADD",
"old_path": "runsc/test/BUILD",
"new_path": "runsc/test/BUILD",
"diff": ""
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "runsc/test/build_defs.bzl",
"diff": "+\"\"\"Defines a rule for runsc test targets.\"\"\"\n+\n+load(\"@io_bazel_rules_go//go... | Go | Apache License 2.0 | google/gvisor | gvisor/kokoro: don't modify tests names in the BUILD file
PiperOrigin-RevId: 253746380 |
259,992 | 18.06.2019 11:02:29 | 25,200 | ec15fb116248b549a1d6c5ca835aaa52681a9bd7 | Fix PipeTest_Streaming timeout
Test was calling Size() inside read and write loops. Size()
makes 2 syscalls to return the pipe size, making the test
do a lot more work than it should. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pipe.cc",
"new_path": "test/syscalls/linux/pipe.cc",
"diff": "@@ -50,32 +50,28 @@ struct PipeCreator {\n};\nclass PipeTest : public ::testing::TestWithParam<PipeCreator> {\n- protected:\n- FileDescriptor rfd;\n- FileDescriptor wfd;\n-\npubl... | Go | Apache License 2.0 | google/gvisor | Fix PipeTest_Streaming timeout
Test was calling Size() inside read and write loops. Size()
makes 2 syscalls to return the pipe size, making the test
do a lot more work than it should.
PiperOrigin-RevId: 253824690 |
259,847 | 18.06.2019 14:17:31 | 25,200 | 2e1379867a77bfa94cc740b6d1407d3702810c73 | Replace usage of deprecated strtoul/strtoull | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -42,6 +42,7 @@ cc_binary(\nname = \"exec_state_workload\",\ntestonly = 1,\nsrcs = [\"exec_state_workload.cc\"],\n+ deps = [\"@com_google_absl//absl/strings\"],\n)\nsh_binary(\n"
... | Go | Apache License 2.0 | google/gvisor | Replace usage of deprecated strtoul/strtoull
PiperOrigin-RevId: 253864770 |
259,992 | 18.06.2019 15:34:58 | 25,200 | 0e07c94d545aa971bb2a05b738f856181a3ff463 | Kill sandbox process when 'runsc do' exits | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/do.go",
"new_path": "runsc/cmd/do.go",
"diff": "@@ -42,6 +42,7 @@ type Do struct {\nroot string\ncwd string\nip string\n+ quiet bool\n}\n// Name implements subcommands.Command.Name.\n@@ -71,6 +72,7 @@ func (c *Do) SetFlags(f *flag.FlagSet) {\nf.Strin... | Go | Apache License 2.0 | google/gvisor | Kill sandbox process when 'runsc do' exits
PiperOrigin-RevId: 253882115 |
259,985 | 18.06.2019 16:20:42 | 25,200 | 546b2948cb4304a99b0d719d5a99dcb7edaace18 | Use return values from syscalls in eventfd tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/eventfd.cc",
"new_path": "test/syscalls/linux/eventfd.cc",
"diff": "@@ -53,9 +53,9 @@ TEST(EventfdTest, Nonblock) {\nvoid* read_three_times(void* arg) {\nint efd = *reinterpret_cast<int*>(arg);\nuint64_t l;\n- read(efd, &l, sizeof(l));\n- r... | Go | Apache License 2.0 | google/gvisor | Use return values from syscalls in eventfd tests.
PiperOrigin-RevId: 253890611 |
259,992 | 18.06.2019 19:14:52 | 25,200 | ca245a428b367e9eb29ae51386beccb6a2d3022b | Attempt to fix TestPipeWritesAccumulate
Test fails because it's reading 4KB instead of the
expected 64KB. Changed the test to read pipe buffer
size instead of hardcode and added some logging in
case the reason for failure was not pipe buffer size. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fdpipe/pipe_test.go",
"new_path": "pkg/sentry/fs/fdpipe/pipe_test.go",
"diff": "@@ -358,9 +358,9 @@ func TestPipeReadAheadBuffer(t *testing.T) {\n}\n}\n-// This is very important for pipes in general because they can return EWOULDBLOCK and for\n-... | Go | Apache License 2.0 | google/gvisor | Attempt to fix TestPipeWritesAccumulate
Test fails because it's reading 4KB instead of the
expected 64KB. Changed the test to read pipe buffer
size instead of hardcode and added some logging in
case the reason for failure was not pipe buffer size.
PiperOrigin-RevId: 253916040 |
260,008 | 19.06.2019 08:06:55 | 25,200 | 0d1dc50b70baf6b4a3752d5c761f608feea9f30e | Mark tcp_socket test flaky. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -2939,6 +2939,8 @@ cc_binary(\ntestonly = 1,\nsrcs = [\"tcp_socket.cc\"],\nlinkstatic = 1,\n+ # FIXME(b/135470853)\n+ tags = [\"flaky\"],\ndeps = [\n\":socket_test_util\",\n\"//te... | Go | Apache License 2.0 | google/gvisor | Mark tcp_socket test flaky.
PiperOrigin-RevId: 253997465 |
259,881 | 19.06.2019 13:39:57 | 25,200 | 9d2efaac5af3618a637abe2dba23f63387dd086e | Add renamed children pathNodes to target parent
Otherwise future renames may miss Renamed calls. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/p9test/client_test.go",
"new_path": "pkg/p9/p9test/client_test.go",
"diff": "@@ -269,14 +269,14 @@ type fileGenerator func(*Harness, string, p9.File) (*Mock, *Mock, p9.File)\nfunc walkHelper(h *Harness, name string, dir p9.File) (parentBackend *Mock, wa... | Go | Apache License 2.0 | google/gvisor | Add renamed children pathNodes to target parent
Otherwise future renames may miss Renamed calls.
PiperOrigin-RevId: 254060946 |
259,881 | 19.06.2019 14:47:01 | 25,200 | 773423a997eb19c48942ccb8a390be72bbd9d5e1 | Abort loop on failure
As-is, on failure these will infinite loop, resulting in test timeout
instead of failure. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tcp_socket.cc",
"new_path": "test/syscalls/linux/tcp_socket.cc",
"diff": "@@ -268,7 +268,7 @@ TEST_P(TcpSocketTest, BlockingLargeWrite_NoRandomSave) {\nchar readbuf[2500] = {};\nint n = -1;\nwhile (n != 0) {\n- EXPECT_THAT(n = RetryEINTR(re... | Go | Apache License 2.0 | google/gvisor | Abort loop on failure
As-is, on failure these will infinite loop, resulting in test timeout
instead of failure.
PiperOrigin-RevId: 254074989 |
259,881 | 19.06.2019 17:17:12 | 25,200 | c2d87d5d7cd1b7c9e601bfabdcbf53aebfb89de4 | Mark tcp_socket test flaky (for real)
The tag on the binary has no effect. It must be on the test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -609,6 +609,8 @@ syscall_test(test = \"//test/syscalls/linux:sysret_test\")\nsyscall_test(\nsize = \"medium\",\nshard_count = 10,\n+ # FIXME(b/135470853)\n+ tags = [\"flaky\"],\ntest = \"//te... | Go | Apache License 2.0 | google/gvisor | Mark tcp_socket test flaky (for real)
The tag on the binary has no effect. It must be on the test.
PiperOrigin-RevId: 254103480 |
259,854 | 19.06.2019 18:39:55 | 25,200 | 7e49515696f628a41ed63199570d25dfbe9d8848 | Deflake SendFileTest_Shutdown.
The sendfile syscall's backing doSplice contained a race with regard to
blocking. If the first attempt failed with syserror.ErrWouldBlock and then
the blocking file became ready before registering a waiter, we would just
return the ErrWouldBlock (even if we were supposed to block). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"new_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"diff": "@@ -48,12 +48,12 @@ func doSplice(t *kernel.Task, outFile, inFile *fs.File, opts fs.SpliceOpts, nonB\nif ch == nil {\nch = make(chan struct{}, 1)\n}\n- if... | Go | Apache License 2.0 | google/gvisor | Deflake SendFileTest_Shutdown.
The sendfile syscall's backing doSplice contained a race with regard to
blocking. If the first attempt failed with syserror.ErrWouldBlock and then
the blocking file became ready before registering a waiter, we would just
return the ErrWouldBlock (even if we were supposed to block).
PiperOrigin-RevId: 254114432 |
259,881 | 20.06.2019 11:30:08 | 25,200 | b46ec3704b60bebdd63a597c62f3f471ee0d9be9 | Drop extra character | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -117,7 +117,7 @@ func New(conf *boot.Config, args *Args) (*Sandbox, error) {\n// occurs. Any errors occurring during cleanup itself are ignored.\nc := specutils.MakeCleanup(func() {... | Go | Apache License 2.0 | google/gvisor | Drop extra character
PiperOrigin-RevId: 254237530 |
260,008 | 20.06.2019 12:54:40 | 25,200 | 0b2135072d3a6b418f87f166b58dcf877f7c2fba | Implement madvise(MADV_DONTFORK) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/lifecycle.go",
"new_path": "pkg/sentry/mm/lifecycle.go",
"diff": "@@ -86,10 +86,22 @@ func (mm *MemoryManager) Fork(ctx context.Context) (*MemoryManager, error) {\n}\n// Copy vmas.\n+ dontforks := false\ndstvgap := mm2.vmas.FirstGap()\nfor srcvse... | Go | Apache License 2.0 | google/gvisor | Implement madvise(MADV_DONTFORK)
PiperOrigin-RevId: 254253777 |
259,881 | 20.06.2019 13:33:29 | 25,200 | 292f70cbf7b4d2da9f2fc5d1049ba49e6846e805 | Add package docs to seqfile and ramfs
These are the only packages missing docs: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/seqfile/seqfile.go",
"new_path": "pkg/sentry/fs/proc/seqfile/seqfile.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n+// Package seqfile provides dynamic ordered files.... | Go | Apache License 2.0 | google/gvisor | Add package docs to seqfile and ramfs
These are the only packages missing docs:
https://godoc.org/gvisor.dev/gvisor
PiperOrigin-RevId: 254261022 |
259,885 | 20.06.2019 13:33:43 | 25,200 | 7db8685100bc5f69ec42e5498781301ee835667c | Preallocate auth.NewAnonymousCredentials() in contexttest.TestContext.
Otherwise every call to, say, fs.ContextCanAccessFile() in a benchmark
using contexttest allocates new auth.Credentials, a new
auth.UserNamespace, ... | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/context/contexttest/contexttest.go",
"new_path": "pkg/sentry/context/contexttest/contexttest.go",
"diff": "@@ -59,6 +59,7 @@ func Context(tb testing.TB) context.Context {\nl: limits.NewLimitSet(),\nmf: mf,\nplatform: p,\n+ creds: auth.NewAnonymousCr... | Go | Apache License 2.0 | google/gvisor | Preallocate auth.NewAnonymousCredentials() in contexttest.TestContext.
Otherwise every call to, say, fs.ContextCanAccessFile() in a benchmark
using contexttest allocates new auth.Credentials, a new
auth.UserNamespace, ...
PiperOrigin-RevId: 254261051 |
260,008 | 20.06.2019 15:57:11 | 25,200 | 3c7448ab6f178cfc171545d15ae039f318e38225 | Deflake TestSIGALRMToMainThread.
Bump up the threshold on number of SIGALRMs received by worker
threads from 50 to 200. Even with the new threshold we still
expect that the majority of SIGALRMs are received by the
thread group leader. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/itimer.cc",
"new_path": "test/syscalls/linux/itimer.cc",
"diff": "@@ -196,13 +196,18 @@ int TestSIGALRMToMainThread() {\n// ITIMER_REAL-generated SIGALRMs prefer to deliver to the thread group leader\n// (but don't guarantee it), so we expe... | Go | Apache License 2.0 | google/gvisor | Deflake TestSIGALRMToMainThread.
Bump up the threshold on number of SIGALRMs received by worker
threads from 50 to 200. Even with the new threshold we still
expect that the majority of SIGALRMs are received by the
thread group leader.
PiperOrigin-RevId: 254289787 |
259,854 | 20.06.2019 20:39:22 | 25,200 | dc36c34a766500507e4ac90547b58b88625bbc0d | Close FD on TcpSocketTest loop failure.
This helps prevent the blocking call from getting stuck and causing a test
timeout. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tcp_socket.cc",
"new_path": "test/syscalls/linux/tcp_socket.cc",
"diff": "@@ -265,10 +265,16 @@ TEST_P(TcpSocketTest, BlockingLargeWrite_NoRandomSave) {\nScopedThread t([this, &read_bytes]() {\n// Avoid interrupting the blocking write in ma... | Go | Apache License 2.0 | google/gvisor | Close FD on TcpSocketTest loop failure.
This helps prevent the blocking call from getting stuck and causing a test
timeout.
PiperOrigin-RevId: 254325926 |
259,853 | 21.06.2019 11:54:28 | 25,200 | f94653b3dea629f365ce5742b99bbcaa7673ded2 | kernel: call t.mu.Unlock() explicitly in WithMuLocked
defer here doesn't improve readability, but we know it slower that
the explicit call. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -703,8 +703,8 @@ func (t *Task) FDMap() *FDMap {\n// WithMuLocked executes f with t.mu locked.\nfunc (t *Task) WithMuLocked(f func(*Task)) {\nt.mu.Lock()\n- defer t.mu.Unlock()\nf... | Go | Apache License 2.0 | google/gvisor | kernel: call t.mu.Unlock() explicitly in WithMuLocked
defer here doesn't improve readability, but we know it slower that
the explicit call.
PiperOrigin-RevId: 254441473 |
259,992 | 21.06.2019 12:45:50 | 25,200 | 5ba16d51a950d55684c0348a9445784363467c9c | Add list of stuck tasks to panic message | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -271,23 +271,23 @@ func (w *Watchdog) reportStuckWatchdog() {\nw.onStuckTask(true, &buf)\n}\n-func (w *Watchdog) onStuckTask(newTaskFound bool, buf *bytes.Buffer) {\n+... | Go | Apache License 2.0 | google/gvisor | Add list of stuck tasks to panic message
PiperOrigin-RevId: 254450309 |
259,907 | 21.06.2019 15:41:42 | 25,200 | 727375321f292878237ac6ace447e43ed393750c | ext4 block group descriptor implementation in disk layout package. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"diff": "+package(licenses = [\"notice\"])\n+\n+load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\n+\n+go_library(\n+ name = \"disklayout\",\n+ srcs = [\n+ \"block_group.go\",\n+ \"block_gr... | Go | Apache License 2.0 | google/gvisor | ext4 block group descriptor implementation in disk layout package.
PiperOrigin-RevId: 254482180 |
259,847 | 21.06.2019 15:55:15 | 25,200 | ae4ef32b8c77a067229c593af784fbfa3098fd97 | Deflake TestSimpleReceive failures due to timeouts
This test will occasionally fail waiting to read a packet. From repeated runs,
I've seen it up to 1.5s for waitForPackets to complete. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/sharedmem_test.go",
"new_path": "pkg/tcpip/link/sharedmem/sharedmem_test.go",
"diff": "@@ -636,7 +636,7 @@ func TestSimpleReceive(t *testing.T) {\nsyscall.Write(c.rxCfg.EventFD, []byte{1, 0, 0, 0, 0, 0, 0, 0})\n// Wait for packet to be... | Go | Apache License 2.0 | google/gvisor | Deflake TestSimpleReceive failures due to timeouts
This test will occasionally fail waiting to read a packet. From repeated runs,
I've seen it up to 1.5s for waitForPackets to complete.
PiperOrigin-RevId: 254484627 |
259,853 | 21.06.2019 17:24:11 | 25,200 | ab6774cebf5c618d0cae579e84bd39666857f78b | gvisor/fs: getdents returns 0 if offset is equal to FileMaxOffset
FileMaxOffset is a special case when lseek(d, 0, SEEK_END) has been called. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -948,9 +948,6 @@ func direntReaddir(ctx context.Context, d *Dirent, it DirIterator, root *Dirent,\nif dirCtx.Serializer == nil {\npanic(\"Dirent.Readdir: serializer must not be nil\")... | Go | Apache License 2.0 | google/gvisor | gvisor/fs: getdents returns 0 if offset is equal to FileMaxOffset
FileMaxOffset is a special case when lseek(d, 0, SEEK_END) has been called.
PiperOrigin-RevId: 254498777 |
259,992 | 24.06.2019 15:01:58 | 25,200 | b21b1db7003aea8615ab9e6a4f07b74c97a32c24 | Allow to change logging options using 'runsc debug'
New options are:
runsc debug --strace=off|all|function1,function2
runsc debug --log-level=warning|info|debug
runsc debug --log-packets=true|false
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/log/log.go",
"new_path": "pkg/log/log.go",
"diff": "@@ -50,6 +50,19 @@ const (\nDebug\n)\n+func (l Level) String() string {\n+ switch l {\n+ case Warning:\n+ return \"Warning\"\n+ case Info:\n+ return \"Info\"\n+ case Debug:\n+ return \"Debug\"\n+ default:... | Go | Apache License 2.0 | google/gvisor | Allow to change logging options using 'runsc debug'
New options are:
runsc debug --strace=off|all|function1,function2
runsc debug --log-level=warning|info|debug
runsc debug --log-packets=true|false
Updates #407
PiperOrigin-RevId: 254843128 |
259,853 | 24.06.2019 15:47:52 | 25,200 | c5486f512224dc0fda6b3509c1eb9f83dff950b4 | platform/ptrace: specify PTRACE_O_TRACEEXIT for stub-processes
The tracee is stopped early during process exit, when registers are still
available, allowing the tracer to see where the exit occurred, whereas the
normal exit notifi? cation is done after the process is finished exiting.
Without this option, dumpAndPanic fails to get registers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess.go",
"diff": "@@ -376,7 +376,7 @@ func (t *thread) init() {\nsyscall.PTRACE_SETOPTIONS,\nuintptr(t.tid),\n0,\n- syscall.PTRACE_O_TRACESYSGOOD,\n+ syscall.PTRACE_O_TRA... | Go | Apache License 2.0 | google/gvisor | platform/ptrace: specify PTRACE_O_TRACEEXIT for stub-processes
The tracee is stopped early during process exit, when registers are still
available, allowing the tracer to see where the exit occurred, whereas the
normal exit notifi? cation is done after the process is finished exiting.
Without this option, dumpAndPanic fails to get registers.
PiperOrigin-RevId: 254852917 |
259,985 | 24.06.2019 15:55:26 | 25,200 | 94a6bfab5d0a2a1950915d7db9cd5e1502de8c13 | Implement /proc/net/tcp. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/BUILD",
"new_path": "pkg/sentry/fs/proc/BUILD",
"diff": "@@ -31,6 +31,7 @@ go_library(\nvisibility = [\"//pkg/sentry:internal\"],\ndeps = [\n\"//pkg/abi/linux\",\n+ \"//pkg/binary\",\n\"//pkg/log\",\n\"//pkg/sentry/context\",\n\"//pkg/sentry... | Go | Apache License 2.0 | google/gvisor | Implement /proc/net/tcp.
PiperOrigin-RevId: 254854346 |
259,858 | 24.06.2019 17:28:46 | 25,200 | 7f5d0afe525af4728ed5ec75193e9e4560d9558c | Add O_EXITKILL to ptrace options.
This prevents a race before PDEATH_SIG can take effect during
a sentry crash.
Discovered and solution by avagin@. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess.go",
"diff": "@@ -370,13 +370,16 @@ func (t *thread) destroy() {\n// init initializes trace options.\nfunc (t *thread) init() {\n- // Set our TRACESYSGOOD option to d... | Go | Apache License 2.0 | google/gvisor | Add O_EXITKILL to ptrace options.
This prevents a race before PDEATH_SIG can take effect during
a sentry crash.
Discovered and solution by avagin@.
PiperOrigin-RevId: 254871534 |
259,916 | 21.06.2019 22:40:16 | 25,200 | 3688e6e99d16b0c6ecb7c8b3528a541ce6afe3a7 | Add CLOCK_BOOTTIME as a CLOCK_MONOTONIC alias
Makes CLOCK_BOOTTIME available with
* clock_gettime
* timerfd_create
* clock_gettime vDSO
CLOCK_BOOTTIME is implemented as an alias to CLOCK_MONOTONIC.
CLOCK_MONOTONIC already keeps track of time across save
and restore. This is the closest possible behavior to Linux
CLOCK_BOOTIME, as there is no concept of suspend/resume.
Updates google/gvisor#218 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_time.go",
"new_path": "pkg/sentry/syscalls/linux/sys_time.go",
"diff": "@@ -121,8 +121,13 @@ func getClock(t *kernel.Task, clockID int32) (ktime.Clock, error) {\nswitch clockID {\ncase linux.CLOCK_REALTIME, linux.CLOCK_REALTIME_CO... | Go | Apache License 2.0 | google/gvisor | Add CLOCK_BOOTTIME as a CLOCK_MONOTONIC alias
Makes CLOCK_BOOTTIME available with
* clock_gettime
* timerfd_create
* clock_gettime vDSO
CLOCK_BOOTTIME is implemented as an alias to CLOCK_MONOTONIC.
CLOCK_MONOTONIC already keeps track of time across save
and restore. This is the closest possible behavior to Linux
CLOCK_BOOTIME, as there is no concept of suspend/resume.
Updates google/gvisor#218 |
259,853 | 24.06.2019 21:43:14 | 25,200 | fd16a329ce0c9fa1e7dd4c0fc1edc201f4c19571 | fsgopher: reopen files via /proc/self/fd
When we reopen file by path, we can't be sure that
we will open exactly the same file. The file can be
deleted and another one with the same name can be
created. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader_test.go",
"new_path": "runsc/boot/loader_test.go",
"diff": "@@ -37,6 +37,9 @@ import (\nfunc init() {\nlog.SetLevel(log.Debug)\nrand.Seed(time.Now().UnixNano())\n+ if err := fsgofer.OpenProcSelfFD(); err != nil {\n+ panic(err)\n+ }\n}\nfunc t... | Go | Apache License 2.0 | google/gvisor | fsgopher: reopen files via /proc/self/fd
When we reopen file by path, we can't be sure that
we will open exactly the same file. The file can be
deleted and another one with the same name can be
created.
PiperOrigin-RevId: 254898594 |
259,885 | 25.06.2019 15:37:11 | 25,200 | ffee0f36b1314934e694863f1cb00924e6fc582e | Add //pkg/fdchannel.
To accompany flipcall connections in cases where passing FDs is required
(as for gofers). | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/fdchannel/BUILD",
"diff": "+load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"fdchannel\",\n+ srcs = [\"fdchannel_unsafe.go\"],\n+ importpath = \"gvisor.dev... | Go | Apache License 2.0 | google/gvisor | Add //pkg/fdchannel.
To accompany flipcall connections in cases where passing FDs is required
(as for gofers).
PiperOrigin-RevId: 255062277 |
259,881 | 25.06.2019 17:11:10 | 25,200 | e98ce4a2c681855b6b4f2c1298484f60014e4b88 | Add TODO reminder to remove tmpfs caching options
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tmpfs/fs.go",
"new_path": "pkg/sentry/fs/tmpfs/fs.go",
"diff": "@@ -133,6 +133,9 @@ func (f *Filesystem) Mount(ctx context.Context, device string, flags fs.MountSou\n}\n// Construct a mount which will follow the cache options provided.\n+ //\n+ /... | Go | Apache License 2.0 | google/gvisor | Add TODO reminder to remove tmpfs caching options
Updates #179
PiperOrigin-RevId: 255081565 |
259,884 | 14.06.2019 21:07:53 | 14,400 | 8d8380564f8284899183a0799bccb8c0b9096566 | Redirect to the custom domain from appspot.com | [
{
"change_type": "MODIFY",
"old_path": "cmd/gvisor-website/main.go",
"new_path": "cmd/gvisor-website/main.go",
"diff": "@@ -97,6 +97,14 @@ func hostRedirectHandler(h http.Handler) http.Handler {\nhttp.Redirect(w, r, r.URL.String(), http.StatusMovedPermanently)\nreturn\n}\n+\n+ if *projectId != \"\" ... | Go | Apache License 2.0 | google/gvisor | Redirect to the custom domain from appspot.com |
259,884 | 13.06.2019 22:14:41 | 14,400 | 8e6c43e5c57ffbe6a4c0c11f1e61e2eaa76db52c | Add fragment links to sub-headers in docs (fixes
Allows users to copy links to sub-headers within docs. | [
{
"change_type": "MODIFY",
"old_path": "assets/scss/_styles_project.scss",
"new_path": "assets/scss/_styles_project.scss",
"diff": "@@ -72,3 +72,10 @@ a.doc-table-anchor {\n.td-default main section.td-cover-block p.lead strong {\nfont-weight: bold;\n}\n+\n+.td-page,.td-section {\n+ main a.header-lin... | Go | Apache License 2.0 | google/gvisor | Add fragment links to sub-headers in docs (fixes #61)
Allows users to copy links to sub-headers within docs. |
259,858 | 24.06.2019 15:49:08 | 25,200 | 34954077893756672f9a91f751032e2e1ce9ca30 | Add group to install instructions | [
{
"change_type": "MODIFY",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": "content/docs/includes/install_gvisor.md",
"diff": "@@ -21,7 +21,7 @@ a good place to put the `runsc` binary.\nsha512sum -c runsc.sha512\nchmod a+x runsc\nsudo mv runsc /usr/local/bin\n- sudo chown root /us... | Go | Apache License 2.0 | google/gvisor | Add group to install instructions |
259,992 | 26.06.2019 14:23:35 | 25,200 | 42e212f6b7d4f6dd70e9751562f1524231e39a0e | Preserve permissions when checking lower
The code was wrongly assuming that only read access was
required from the lower overlay when checking for permissions.
This allowed non-writable files to be writable in the overlay.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode_overlay.go",
"new_path": "pkg/sentry/fs/inode_overlay.go",
"diff": "@@ -537,12 +537,6 @@ func overlayCheck(ctx context.Context, o *overlayEntry, p PermMask) error {\nif o.upper != nil {\nerr = o.upper.check(ctx, p)\n} else {\n- if p.Write {... | Go | Apache License 2.0 | google/gvisor | Preserve permissions when checking lower
The code was wrongly assuming that only read access was
required from the lower overlay when checking for permissions.
This allowed non-writable files to be writable in the overlay.
Fixes #316
PiperOrigin-RevId: 255263686 |
259,853 | 27.06.2019 13:23:49 | 25,200 | e2760839033618410cdea9aeab039e096cde54be | gvisor/ptrace: grub initial thread registers only once | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess.go",
"diff": "@@ -155,6 +155,7 @@ func newSubprocess(create func() (*thread, error)) (*subprocess, error) {\nerrChan <- err\nreturn\n}\n+ firstThread.grabInitRegs()\n... | Go | Apache License 2.0 | google/gvisor | gvisor/ptrace: grub initial thread registers only once
PiperOrigin-RevId: 255465635 |
259,853 | 28.06.2019 11:48:27 | 25,200 | 8a625ceeb173307094e81d273458b6651e54220a | runsc: allow openat for runsc-race
I see that runsc-race is killed by SIGSYS, because openat isn't
allowed by seccomp filters:
60052 openat(AT_FDCWD, "/proc/sys/vm/overcommit_memory",
O_RDONLY|O_CLOEXEC <unfinished ...>
60052 <... openat resumed> ) = 257
60052 --- SIGSYS {si_signo=SIGSYS, si_code=SYS_SECCOMP, si_call_addr=0xfaacf1,
si_syscall=__NR_openat, si_arch=AUDIT_ARCH_X86_64} --- | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/extra_filters_race.go",
"new_path": "runsc/boot/filter/extra_filters_race.go",
"diff": "@@ -33,6 +33,7 @@ func instrumentationFilters() seccomp.SyscallRules {\nsyscall.SYS_MUNLOCK: {},\nsyscall.SYS_NANOSLEEP: {},\nsyscall.SYS_OPEN: {},\n+ sys... | Go | Apache License 2.0 | google/gvisor | runsc: allow openat for runsc-race
I see that runsc-race is killed by SIGSYS, because openat isn't
allowed by seccomp filters:
60052 openat(AT_FDCWD, "/proc/sys/vm/overcommit_memory",
O_RDONLY|O_CLOEXEC <unfinished ...>
60052 <... openat resumed> ) = 257
60052 --- SIGSYS {si_signo=SIGSYS, si_code=SYS_SECCOMP, si_call_addr=0xfaacf1,
si_syscall=__NR_openat, si_arch=AUDIT_ARCH_X86_64} ---
PiperOrigin-RevId: 255640808 |
259,907 | 28.06.2019 12:06:17 | 25,200 | 7c13789818ec43644c3a159cd5cad2a5aad2e26d | Superblock interface in the disk layout package for ext4. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"new_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_library(\n\"block_group.go\",\n\"block_group_32.go\",\n\"block_group_64.go\",\n+ \"superblock.go\",\n],\nimportpath = \"gvisor.dev/gvisor/pkg/s... | Go | Apache License 2.0 | google/gvisor | Superblock interface in the disk layout package for ext4.
PiperOrigin-RevId: 255644277 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.