author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,853 | 28.06.2019 13:22:28 | 25,200 | e21d49c2d82b7d109bc7c8955edea1787de59ac0 | platform/ptrace: return more detailed errors
Right now, if we can't create a stub process, we will see this error:
panic: unable to activate mm: resource temporarily unavailable
It would be better to know the root cause of this "resource temporarily
unavailable". | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess_linux.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess_linux.go",
"diff": "@@ -306,7 +306,7 @@ func (s *subprocess) createStub() (*thread, error) {\narch.SyscallArgument{Value: 0},\narch.SyscallArgument{Value: 0})\n... | Go | Apache License 2.0 | google/gvisor | platform/ptrace: return more detailed errors
Right now, if we can't create a stub process, we will see this error:
panic: unable to activate mm: resource temporarily unavailable
It would be better to know the root cause of this "resource temporarily
unavailable".
PiperOrigin-RevId: 255656831 |
259,907 | 28.06.2019 16:17:19 | 25,200 | c4da599e22e1490dc2a108cbf85ba19af2f5e2df | ext4: disklayout: SuperBlock interface implementations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"new_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"diff": "@@ -9,14 +9,21 @@ go_library(\n\"block_group_32.go\",\n\"block_group_64.go\",\n\"superblock.go\",\n+ \"superblock_32.go\",\n+ \"superblock_64.go\",\n+ \"superbloc... | Go | Apache License 2.0 | google/gvisor | ext4: disklayout: SuperBlock interface implementations.
PiperOrigin-RevId: 255687771 |
259,858 | 28.06.2019 20:34:03 | 25,200 | 6d204f6a3474f411dc39b59886973e3518cf1cec | Drop local_server support. | [
{
"change_type": "DELETE",
"old_path": "pkg/p9/local_server/BUILD",
"new_path": null,
"diff": "-load(\"@io_bazel_rules_go//go:def.bzl\", \"go_binary\")\n-\n-package(licenses = [\"notice\"])\n-\n-go_binary(\n- name = \"local_server\",\n- srcs = [\"local_server.go\"],\n- deps = [\n- \"//pkg/fd\",\n- \... | Go | Apache License 2.0 | google/gvisor | Drop local_server support.
PiperOrigin-RevId: 255713414 |
259,854 | 29.06.2019 09:22:09 | 25,200 | 3446f4e29bd547e5576caf16d8c2bb45560439e9 | Add stack trace printing to reference leak checking. | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "package refs\nimport (\n+ \"bytes\"\n+ \"fmt\"\n\"reflect\"\n\"runtime\"\n\"sync\"\n@@ -197,6 +199,11 @@ type AtomicRefCount struct {\n// name is immutable after EnableLeakCheck is called.... | Go | Apache License 2.0 | google/gvisor | Add stack trace printing to reference leak checking.
PiperOrigin-RevId: 255759891 |
259,854 | 01.07.2019 17:45:19 | 25,200 | 0aa9418a778b2fffef4ea4691e97868b498e3b22 | Fix unix/transport.queue reference leaks.
Fix two leaks for connectionless Unix sockets:
* Double connect: Subsequent connects would leak a reference on the previously
connected endpoint.
* Close unconnected: Sockets which were not connected at the time of closure
would leak a reference on their receiver. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/connectionless.go",
"new_path": "pkg/sentry/socket/unix/transport/connectionless.go",
"diff": "@@ -54,30 +54,25 @@ func (e *connectionlessEndpoint) isBound() bool {\n// Close puts the endpoint in a closed state and frees all re... | Go | Apache License 2.0 | google/gvisor | Fix unix/transport.queue reference leaks.
Fix two leaks for connectionless Unix sockets:
* Double connect: Subsequent connects would leak a reference on the previously
connected endpoint.
* Close unconnected: Sockets which were not connected at the time of closure
would leak a reference on their receiver.
PiperOrigin-RevId: 256070451 |
259,907 | 02.07.2019 14:03:31 | 25,200 | d8ec2fb671e68a2504c10bd254ae64f33752430d | Ext4: DiskLayout: Inode interface. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"new_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_library(\n\"block_group.go\",\n\"block_group_32.go\",\n\"block_group_64.go\",\n+ \"inode.go\",\n\"superblock.go\",\n\"superblock_32.go\",\n\"su... | Go | Apache License 2.0 | google/gvisor | Ext4: DiskLayout: Inode interface.
PiperOrigin-RevId: 256234390 |
260,008 | 02.07.2019 17:56:57 | 25,200 | 1178a278ae2501cdd19ffaf6e10c2e3c34b143d0 | Mark timers_test flaky because setrlimit(RLIMIT_CPU) is broken in some kernels. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -3001,6 +3001,8 @@ cc_binary(\ntestonly = 1,\nsrcs = [\"timers.cc\"],\nlinkstatic = 1,\n+ # FIXME(b/136599201)\n+ tags = [\"flaky\"],\ndeps = [\n\"//test/util:cleanup\",\n\"//test... | Go | Apache License 2.0 | google/gvisor | Mark timers_test flaky because setrlimit(RLIMIT_CPU) is broken in some kernels.
https://bugzilla.redhat.com/show_bug.cgi?id=1568337
PiperOrigin-RevId: 256276198 |
259,853 | 03.07.2019 13:57:24 | 25,200 | 116cac053e2e4e167caa9707439065af7c7b82b3 | netstack/udp: connect with the AF_UNSPEC address family means disconnect | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -285,14 +285,14 @@ func bytesToIPAddress(addr []byte) tcpip.Address {\n// GetAddress reads an sockaddr struct from the given address and converts it\n// ... | Go | Apache License 2.0 | google/gvisor | netstack/udp: connect with the AF_UNSPEC address family means disconnect
PiperOrigin-RevId: 256433283 |
260,008 | 03.07.2019 16:00:29 | 25,200 | 9f2f9f0cab7ad9bbdcde23e8c98ea42c38c1e4e8 | futex: compare keys for equality when doing a FUTEX_UNLOCK_PI. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/futex/futex.go",
"new_path": "pkg/sentry/kernel/futex/futex.go",
"diff": "@@ -729,14 +729,14 @@ func (m *Manager) UnlockPI(t Target, addr usermem.Addr, tid uint32, private bool\n}\nb := m.lockBucket(&k)\n- err = m.unlockPILocked(t, addr, tid,... | Go | Apache License 2.0 | google/gvisor | futex: compare keys for equality when doing a FUTEX_UNLOCK_PI.
PiperOrigin-RevId: 256453827 |
259,884 | 03.07.2019 20:12:16 | 25,200 | da57fb9d25d947195147868253a928f83980c1fd | Fix syscall doc for getresgid | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64.go",
"diff": "@@ -168,7 +168,7 @@ var AMD64 = &kernel.SyscallTable{\n117: syscalls.Supported(\"setresuid\", Setresuid),\n118: syscalls.Supported(\"getresuid\", Getresuid),\n1... | Go | Apache License 2.0 | google/gvisor | Fix syscall doc for getresgid
PiperOrigin-RevId: 256481284 |
259,907 | 08.07.2019 10:43:11 | 25,200 | 8f9b1ca8e7066df529b89422937e3212bf761262 | ext4: disklayout: inode impl. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"new_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"diff": "@@ -8,7 +8,10 @@ go_library(\n\"block_group.go\",\n\"block_group_32.go\",\n\"block_group_64.go\",\n+ \"disklayout.go\",\n\"inode.go\",\n+ \"inode_new.go\",\n+ \"i... | Go | Apache License 2.0 | google/gvisor | ext4: disklayout: inode impl.
PiperOrigin-RevId: 257010414 |
259,858 | 09.07.2019 16:42:54 | 25,200 | dea3cb92f2c9fffb604cedde6998b3209c91e716 | build: add nogo for static validation | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "package(licenses = [\"notice\"]) # Apache 2.0\n-load(\"@io_bazel_rules_go//go:def.bzl\", \"go_path\")\n+load(\"@io_bazel_rules_go//go:def.bzl\", \"go_path\", \"nogo\")\nload(\"@bazel_gazelle//:def.bzl\", \"gazelle\")\n# Th... | Go | Apache License 2.0 | google/gvisor | build: add nogo for static validation
PiperOrigin-RevId: 257297820 |
259,907 | 09.07.2019 18:34:58 | 25,200 | 7965b1272bb0579da47960e64ea902c74f49483d | ext4: disklayout: Directory Entry implementation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"new_path": "pkg/sentry/fs/ext4/disklayout/BUILD",
"diff": "@@ -8,6 +8,9 @@ go_library(\n\"block_group.go\",\n\"block_group_32.go\",\n\"block_group_64.go\",\n+ \"dirent.go\",\n+ \"dirent_new.go\",\n+ \"dirent_old.go\",\n\"... | Go | Apache License 2.0 | google/gvisor | ext4: disklayout: Directory Entry implementation.
PiperOrigin-RevId: 257314911 |
259,884 | 10.07.2019 01:21:03 | 14,400 | 8a641256470955691d5851ffca9b4b890df8855c | Copy app engine app files in cloudbuild
Fixes website deploy step | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -14,9 +14,12 @@ APP_TARGET = $(patsubst cmd/gvisor-website/%,public/%,$(APP_SOURCE))\ndefault: website\n.PHONY: default\n-website: all-upstream $(APP_TARGET) public/static\n+website: all-upstream app public/static... | Go | Apache License 2.0 | google/gvisor | Copy app engine app files in cloudbuild
Fixes website deploy step |
259,853 | 11.07.2019 12:52:12 | 25,200 | a018b229b57dff92ca0d99079180aa556dacbabc | kokoro: use bazel 2.27.1
The latest version 2.28.0 doesn't work:
./runsc/linux_amd64_pure_stripped/runsc: operation not permitted, want 0 | [
{
"change_type": "MODIFY",
"old_path": "tools/run_tests.sh",
"new_path": "tools/run_tests.sh",
"diff": "@@ -45,7 +45,8 @@ readonly TEST_PACKAGES=(\"//pkg/...\" \"//runsc/...\" \"//tools/...\")\n#######################\n# Install the latest version of Bazel and log the version.\n-(which use_bazel.sh ... | Go | Apache License 2.0 | google/gvisor | kokoro: use bazel 2.27.1
The latest version 2.28.0 doesn't work:
./runsc/linux_amd64_pure_stripped/runsc: operation not permitted, want 0
PiperOrigin-RevId: 257663312 |
259,907 | 11.07.2019 17:16:27 | 25,200 | 2eeca68900eeb57a679eccc08fe172b1d9ddf97f | Added tiny ext4 image.
The image is of size 64Kb which supports 64 1k blocks
and 16 inodes. This is the smallest size mkfs.ext4 works with.
Added README.md documenting how this was created and included
all files on the device under assets. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/fs/ext/assets/README.md",
"diff": "+### Tiny Ext4 Image\n+\n+The image is of size 64Kb which supports 64 1k blocks and 16 inodes. This is the\n+smallest size mkfs.ext4 works with.\n+\n+This image was generated using the following comm... | Go | Apache License 2.0 | google/gvisor | Added tiny ext4 image.
The image is of size 64Kb which supports 64 1k blocks
and 16 inodes. This is the smallest size mkfs.ext4 works with.
Added README.md documenting how this was created and included
all files on the device under assets.
PiperOrigin-RevId: 257712672 |
259,891 | 11.07.2019 21:24:27 | 25,200 | 44427d8e267b4c4445c1c217637d802f71e9bf52 | Add a stub for /dev/tty.
Actual implementation to follow, but this will satisfy applications that
want it to just exist. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dev/BUILD",
"new_path": "pkg/sentry/fs/dev/BUILD",
"diff": "@@ -11,6 +11,7 @@ go_library(\n\"full.go\",\n\"null.go\",\n\"random.go\",\n+ \"tty.go\",\n],\nimportpath = \"gvisor.dev/gvisor/pkg/sentry/fs/dev\",\nvisibility = [\"//pkg/sentry:internal... | Go | Apache License 2.0 | google/gvisor | Add a stub for /dev/tty.
Actual implementation to follow, but this will satisfy applications that
want it to just exist. |
259,891 | 11.07.2019 21:31:26 | 25,200 | ddef7f8078ba87ae2c73c6b89668e01d1da76cfe | Fix license year and remove Read. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dev/tty.go",
"new_path": "pkg/sentry/fs/dev/tty.go",
"diff": "-// Copyright 2018 The gVisor Authors.\n+// Copyright 2019 The gVisor Authors.\n//\n// Licensed under the Apache License, Version 2.0 (the \"License\");\n// you may not use this file e... | Go | Apache License 2.0 | google/gvisor | Fix license year and remove Read. |
259,858 | 12.07.2019 14:33:23 | 25,200 | 4ad67050895d0129f736d8728c62ff9957ada8d7 | CONTRIBUTING: add logs access instructions. | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -86,6 +86,11 @@ Code changes are accepted via [pull request][github].\nWhen approved, the change will be submitted by a team member and automatically\nmerged into the repository.\n+### Presubmit chec... | Go | Apache License 2.0 | google/gvisor | CONTRIBUTING: add logs access instructions.
PiperOrigin-RevId: 257870018 |
259,891 | 12.07.2019 15:16:01 | 25,200 | 6ebb925acd6336760f6f9453e860944e0e314a7b | Add permission, char device, and uid checks. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/dev.cc",
"new_path": "test/syscalls/linux/dev.cc",
"diff": "@@ -148,6 +148,10 @@ TEST(DevTest, WriteDevFull) {\nTEST(DevTest, TTYExists) {\nstruct stat statbuf = {};\nASSERT_THAT(stat(\"/dev/tty\", &statbuf), SyscallSucceeds());\n+ // Check... | Go | Apache License 2.0 | google/gvisor | Add permission, char device, and uid checks.
Change-Id: I8307bfb390a56424aaa651285a218aad277c4aed |
260,008 | 15.07.2019 15:21:12 | 25,200 | ab44d145bb9806fa363d79e49b4190c62fcd669f | Fix initialization of badhandler_low_water_mark in SigaltstackTest.
It is now correctly initialized to the top of the signal stack.
Previously it was initialized to the address of 'stack.ss_sp' on
the main thread stack. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/sigaltstack.cc",
"new_path": "test/syscalls/linux/sigaltstack.cc",
"diff": "@@ -175,7 +175,7 @@ TEST(SigaltstackTest, WalksOffBottom) {\n// Trigger a single fault.\nbadhandler_low_water_mark =\n- reinterpret_cast<char*>(&stack.ss_sp) + SIGS... | Go | Apache License 2.0 | google/gvisor | Fix initialization of badhandler_low_water_mark in SigaltstackTest.
It is now correctly initialized to the top of the signal stack.
Previously it was initialized to the address of 'stack.ss_sp' on
the main thread stack.
PiperOrigin-RevId: 258248363 |
259,891 | 15.07.2019 17:27:54 | 25,200 | 3d78baf06d32141fb1c9c136cc01e3e204309969 | Replace vector of arrays with array of arrays.
C++ does not like vectors of arrays (because arrays are not copy-constructable). | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/raw_socket_icmp.cc",
"new_path": "test/syscalls/linux/raw_socket_icmp.cc",
"diff": "@@ -195,7 +195,7 @@ TEST_F(RawSocketICMPTest, MultipleSocketReceive) {\n// Receive on socket 1.\nconstexpr int kBufSize = kEmptyICMPSize;\n- std::vector<cha... | Go | Apache License 2.0 | google/gvisor | Replace vector of arrays with array of arrays.
C++ does not like vectors of arrays (because arrays are not copy-constructable).
PiperOrigin-RevId: 258270980 |
259,853 | 15.07.2019 19:26:16 | 25,200 | 6a8ff6daefc670455f40326afd53b51b632a32dc | kvm: wake up all waiter of vCPU.state
Now we call FUTEX_WAKE with ^uintptr(0) of waiters, but in this case only one
waiter will be waked up. If we want to wake up all of them, the number of
waiters has to be set to math.MaxInt32. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/machine_unsafe.go",
"diff": "@@ -21,6 +21,7 @@ package kvm\nimport (\n\"fmt\"\n+ \"math\"\n\"sync/atomic\"\n\"syscall\"\n\"unsafe\"\n@@ -134,7 +135,7 @@ func (c *vCPU) notify() {\... | Go | Apache License 2.0 | google/gvisor | kvm: wake up all waiter of vCPU.state
Now we call FUTEX_WAKE with ^uintptr(0) of waiters, but in this case only one
waiter will be waked up. If we want to wake up all of them, the number of
waiters has to be set to math.MaxInt32.
PiperOrigin-RevId: 258285286 |
259,883 | 15.07.2019 22:49:58 | 25,200 | cf4fc510fd80c5a23e271db677a8721385c45a4d | Support /proc/net/dev
This proc file reports the stats of interfaces. We could use ifconfig
command to check the result.
COPYBARA_INTEGRATE_REVIEW=https://gvisor-review.googlesource.com/c/gvisor/+/18282/ | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -155,37 +155,40 @@ func (n *netDev) ReadSeqFileData(ctx context.Context, h seqfile.SeqHandle) ([]se\ncontents[1] = \" face |bytes packets errs drop fifo frame compressed multicast... | Go | Apache License 2.0 | google/gvisor | Support /proc/net/dev
This proc file reports the stats of interfaces. We could use ifconfig
command to check the result.
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com>
Change-Id: Ia7c1e637f5c76c30791ffda68ee61e861b6ef827
COPYBARA_INTEGRATE_REVIEW=https://gvisor-review.googlesource.com/c/gvisor/+/18282/
PiperOrigin-RevId: 258303936 |
259,853 | 16.07.2019 15:05:12 | 25,200 | 89368456d86e2329c46594490c58cfc51c9c7c92 | test/integration: wait a background process
Otherwise this process can be killed before it prints the test message. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/integration/regression_test.go",
"new_path": "runsc/test/integration/regression_test.go",
"diff": "@@ -32,7 +32,7 @@ func TestBindOverlay(t *testing.T) {\n}\nd := testutil.MakeDocker(\"bind-overlay-test\")\n- cmd := \"nc -l -U /var/run/sock& sleep 1... | Go | Apache License 2.0 | google/gvisor | test/integration: wait a background process
Otherwise this process can be killed before it prints the test message.
PiperOrigin-RevId: 258448204 |
259,916 | 16.07.2019 14:03:40 | 25,200 | 02d1bd67f073dd8e99ce591d1285d1bbc152b424 | Add CLOCK_BOOTTIME tests to timerfd.cc | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/timerfd.cc",
"new_path": "test/syscalls/linux/timerfd.cc",
"diff": "@@ -44,21 +44,24 @@ PosixErrorOr<FileDescriptor> TimerfdCreate(int clockid, int flags) {\n//\n// - Because clock_gettime(CLOCK_MONOTONIC) is implemented through the VDSO,\n... | Go | Apache License 2.0 | google/gvisor | Add CLOCK_BOOTTIME tests to timerfd.cc |
259,881 | 17.07.2019 11:13:37 | 25,200 | ca829158e385c591d4be21c87cc6ab45116a7cce | Properly invalidate cache in rename and remove
We were invalidating the wrong overlayEntry in rename and missing invalidation
in rename and remove if lower exists. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode_overlay.go",
"new_path": "pkg/sentry/fs/inode_overlay.go",
"diff": "@@ -339,7 +339,9 @@ func overlayRemove(ctx context.Context, o *overlayEntry, parent *Dirent, child *\n}\n}\nif child.Inode.overlay.lowerExists {\n- return overlayCreateWhit... | Go | Apache License 2.0 | google/gvisor | Properly invalidate cache in rename and remove
We were invalidating the wrong overlayEntry in rename and missing invalidation
in rename and remove if lower exists.
PiperOrigin-RevId: 258604685 |
259,891 | 17.07.2019 11:47:59 | 25,200 | 9f1189130ed8c9172700a76fd5796b7319fbb8b9 | Add AF_UNIX, SOCK_RAW sockets, which exist for some reason.
tcpdump creates these. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/unix.go",
"new_path": "pkg/sentry/socket/unix/unix.go",
"diff": "@@ -68,6 +68,12 @@ func New(ctx context.Context, endpoint transport.Endpoint, stype linux.SockType)\n// NewWithDirent creates a new unix socket using an existing dirent.\nf... | Go | Apache License 2.0 | google/gvisor | Add AF_UNIX, SOCK_RAW sockets, which exist for some reason.
tcpdump creates these.
PiperOrigin-RevId: 258611829 |
259,962 | 17.07.2019 13:55:32 | 25,200 | 542fbd01a7ed38baca941f88c0b254adef691188 | Fix race in FDTable.GetFDs(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -81,7 +81,9 @@ type FDTable struct {\n// mu protects below.\nmu sync.Mutex `state:\"nosave\"`\n- // used contains the number of non-nil entries.\n+ // used contains the nu... | Go | Apache License 2.0 | google/gvisor | Fix race in FDTable.GetFDs().
PiperOrigin-RevId: 258635459 |
259,907 | 17.07.2019 14:46:57 | 25,200 | 8e3e021aca89427381af75a47f19b1fe78bf132e | ext: Filesystem init implementation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fs.go",
"new_path": "pkg/abi/linux/fs.go",
"diff": "@@ -20,6 +20,7 @@ package linux\nconst (\nANON_INODE_FS_MAGIC = 0x09041934\nDEVPTS_SUPER_MAGIC = 0x00001cd1\n+ EXT_SUPER_MAGIC = 0xef53\nOVERLAYFS_SUPER_MAGIC = 0x794c7630\nPIPEFS_MAGIC = 0x5049... | Go | Apache License 2.0 | google/gvisor | ext: Filesystem init implementation.
PiperOrigin-RevId: 258645957 |
259,907 | 17.07.2019 15:47:45 | 25,200 | 84a59de5dc3a0b8a260c942958cd91e014dc8d9b | ext: disklayout: extents support. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/disklayout/BUILD",
"new_path": "pkg/sentry/fs/ext/disklayout/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_library(\n\"dirent_new.go\",\n\"dirent_old.go\",\n\"disklayout.go\",\n+ \"extent.go\",\n\"inode.go\",\n\"inode_new.go\",\n\"inode_old.go\",\n@@... | Go | Apache License 2.0 | google/gvisor | ext: disklayout: extents support.
PiperOrigin-RevId: 258657776 |
259,885 | 17.07.2019 15:48:33 | 25,200 | 2bc398bfd8fbe38776a512329bd0c40c9c7a5cdf | Separate O_DSYNC and O_SYNC. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -34,13 +34,14 @@ const (\nO_TRUNC = 00001000\nO_APPEND = 00002000\nO_NONBLOCK = 00004000\n+ O_DSYNC = 00010000\nO_ASYNC = 00020000\nO_DIRECT = 00040000\nO_LARGEFILE = 00100000\nO_DIRECTOR... | Go | Apache License 2.0 | google/gvisor | Separate O_DSYNC and O_SYNC.
PiperOrigin-RevId: 258657913 |
259,881 | 17.07.2019 16:10:44 | 25,200 | 6f7e2bb388cb29a355dece8921671c0085f53ea9 | Take copyMu in Revalidate
copyMu is required to read child.overlay.upper. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/mount_overlay.go",
"new_path": "pkg/sentry/fs/mount_overlay.go",
"diff": "@@ -66,13 +66,17 @@ func (o *overlayMountSourceOperations) Revalidate(ctx context.Context, name stri\npanic(\"an overlay cannot revalidate file objects from the lower fs\")... | Go | Apache License 2.0 | google/gvisor | Take copyMu in Revalidate
copyMu is required to read child.overlay.upper.
PiperOrigin-RevId: 258662209 |
259,916 | 17.07.2019 20:25:18 | 25,200 | 2d11fa05f7b705f74c737f5a59fe40414bb6f8d8 | sys_time: Wrap comments to 80 columns | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_time.go",
"new_path": "pkg/sentry/syscalls/linux/sys_time.go",
"diff": "@@ -125,9 +125,11 @@ func getClock(t *kernel.Task, clockID int32) (ktime.Clock, error) {\nlinux.CLOCK_MONOTONIC_RAW, linux.CLOCK_BOOTTIME:\n// CLOCK_MONOTONIC... | Go | Apache License 2.0 | google/gvisor | sys_time: Wrap comments to 80 columns |
259,853 | 18.07.2019 15:39:47 | 25,200 | eefa817cfdb04ff07e7069396f21bd6ba2c89957 | net/tcp/setockopt: impelment setsockopt(fd, SOL_TCP, TCP_INQ) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/control.go",
"new_path": "pkg/sentry/socket/control/control.go",
"diff": "@@ -225,14 +225,14 @@ func putCmsg(buf []byte, flags int, msgType uint32, align uint, data []int32) ([\nreturn alignSlice(buf, align), flags\n}\n-func putCmsgSt... | Go | Apache License 2.0 | google/gvisor | net/tcp/setockopt: impelment setsockopt(fd, SOL_TCP, TCP_INQ)
PiperOrigin-RevId: 258859507 |
260,006 | 19.07.2019 09:27:33 | 25,200 | 0e040ba6e87f5fdcb23854909aad39aa1883925f | Handle interfaceAddr and NIC options separately for IP_MULTICAST_IF
This tweaks the handling code for IP_MULTICAST_IF to ignore the InterfaceAddr
if a NICID is given. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -252,7 +252,7 @@ func (e *endpoint) connectRoute(nicid tcpip.NICID, addr tcpip.FullAddress) (stac\nif nicid == 0 {\nnicid = e.multicastNICID\n}\n- if localAddr... | Go | Apache License 2.0 | google/gvisor | Handle interfaceAddr and NIC options separately for IP_MULTICAST_IF
This tweaks the handling code for IP_MULTICAST_IF to ignore the InterfaceAddr
if a NICID is given.
PiperOrigin-RevId: 258982541 |
259,918 | 19.07.2019 16:29:13 | 25,200 | 32e6be0045fde1837c5ceb4ce44bffe4e4488b05 | Create the initial binary for each of the 5 runtime's test-runner.
Repeated code is planned to be factored out to improve clarity and readability. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "runsc/test/runtimes/proctor-go.go",
"diff": "+// Copyright 2019 The gVisor Authors.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may ob... | Go | Apache License 2.0 | google/gvisor | Create the initial binary for each of the 5 runtime's test-runner.
Repeated code is planned to be factored out to improve clarity and readability.
PiperOrigin-RevId: 259059978 |
259,853 | 22.07.2019 13:27:13 | 25,200 | ec906e46c0f99ab4d134c1d7bd84b48ea0a78488 | kvm: fix race between machine.Put and machine.Get
m.available.Signal() has to be called under m.mu.RLock, otherwise it can
race with machine.Get:
m.Get | m.Put
m.mu.Lock() |
Seatching available vcpu|
| m.available.Signal()
m.available.Wait | | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -388,7 +388,10 @@ func (m *machine) Get() *vCPU {\nfunc (m *machine) Put(c *vCPU) {\nc.unlock()\nruntime.UnlockOSThread()\n+\n+ m.mu.RLock()\nm.available.Signal(... | Go | Apache License 2.0 | google/gvisor | kvm: fix race between machine.Put and machine.Get
m.available.Signal() has to be called under m.mu.RLock, otherwise it can
race with machine.Get:
m.Get | m.Put
-------------------------------------
m.mu.Lock() |
Seatching available vcpu|
| m.available.Signal()
m.available.Wait |
PiperOrigin-RevId: 259394051 |
259,891 | 22.07.2019 17:05:02 | 25,200 | 5ddf9adb2b12a2cbccdcf609c5cc140fa0dbd81d | Fix up and add some iptables ABI. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "package(licenses = [\"notice\"])\n-load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\n+load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\ngo_library(\nname = \"linux\",\n@... | Go | Apache License 2.0 | google/gvisor | Fix up and add some iptables ABI.
PiperOrigin-RevId: 259437060 |
259,907 | 23.07.2019 15:50:35 | 25,200 | bd7708956f0c9e00e88eff9b35b22eea75e71f5f | ext: Added extent tree building logic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/BUILD",
"new_path": "pkg/sentry/fs/ext/BUILD",
"diff": "package(licenses = [\"notice\"])\n-load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\n+load(\"//tools/go_stateify:defs.bzl\", \"go_library\", \"go_test\")\ngo_library(\nname = \"ext... | Go | Apache License 2.0 | google/gvisor | ext: Added extent tree building logic.
PiperOrigin-RevId: 259628657 |
259,907 | 23.07.2019 18:59:55 | 25,200 | d7bb79b6f177e8c58d47695e0ee1a072475463c4 | ext: Add ext2 and ext3 tiny images. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/assets/README.md",
"new_path": "pkg/sentry/fs/ext/assets/README.md",
"diff": "-### Tiny Ext4 Image\n+### Tiny Ext(2/3/4) Images\n-The image is of size 64Kb which supports 64 1k blocks and 16 inodes. This is the\n-smallest size mkfs.ext4 works... | Go | Apache License 2.0 | google/gvisor | ext: Add ext2 and ext3 tiny images.
PiperOrigin-RevId: 259657917 |
259,907 | 23.07.2019 20:34:49 | 25,200 | 7e38d643334647fb79c7cc8be35745699de264e6 | ext: Inode creation logic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/disklayout/inode_new.go",
"new_path": "pkg/sentry/fs/ext/disklayout/inode_new.go",
"diff": "@@ -62,7 +62,7 @@ func (in *InodeNew) Size() uint64 {\n// InodeSize implements Inode.InodeSize.\nfunc (in *InodeNew) InodeSize() uint16 {\n- return ol... | Go | Apache License 2.0 | google/gvisor | ext: Inode creation logic.
PiperOrigin-RevId: 259666476 |
259,976 | 30.04.2019 23:35:36 | -28,800 | 1c5b6d9bd26ba090610d05366df90d4fee91c677 | Use different pidns among different containers
The different containers in a sandbox used only one pid
namespace before. This results in that a container can see
the processes in another container in the same sandbox.
This patch use different pid namespace for different containers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -92,6 +92,9 @@ type ExecArgs struct {\n// ContainerID is the container for the process being executed.\nContainerID string\n+\n+ // PIDNamespace is the pid namespace for the pro... | Go | Apache License 2.0 | google/gvisor | Use different pidns among different containers
The different containers in a sandbox used only one pid
namespace before. This results in that a container can see
the processes in another container in the same sandbox.
This patch use different pid namespace for different containers.
Signed-off-by: chris.zn <chris.zn@antfin.com> |
259,907 | 24.07.2019 16:02:07 | 25,200 | 2ed832ff86ee29970d0a3991297de818bda67b9c | ext: testing environment setup with VFS2 support. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/BUILD",
"new_path": "pkg/sentry/fs/ext/BUILD",
"diff": "@@ -15,7 +15,10 @@ go_library(\ndeps = [\n\"//pkg/abi/linux\",\n\"//pkg/binary\",\n+ \"//pkg/sentry/context\",\n\"//pkg/sentry/fs/ext/disklayout\",\n+ \"//pkg/sentry/kernel/auth\",\n+ \"... | Go | Apache License 2.0 | google/gvisor | ext: testing environment setup with VFS2 support.
PiperOrigin-RevId: 259835948 |
259,907 | 24.07.2019 17:58:28 | 25,200 | 417096f781c4fe74ff8a6db5c0fa0d46ba08e81d | ext: Add tests for root directory inode. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/BUILD",
"new_path": "pkg/sentry/fs/ext/BUILD",
"diff": "@@ -44,6 +44,7 @@ go_test(\n\"//pkg/sentry/context\",\n\"//pkg/sentry/context/contexttest\",\n\"//pkg/sentry/fs/ext/disklayout\",\n+ \"//pkg/sentry/kernel/auth\",\n\"//pkg/sentry/vfs\",\... | Go | Apache License 2.0 | google/gvisor | ext: Add tests for root directory inode.
PiperOrigin-RevId: 259856442 |
259,907 | 24.07.2019 19:06:52 | 25,200 | 83767574951f8ab4727070741451991ba848f6a6 | ext: filesystem boilerplate code. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/BUILD",
"new_path": "pkg/sentry/fs/ext/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nsrcs = [\n\"dentry.go\",\n\"ext.go\",\n+ \"filesystem.go\",\n\"inode.go\",\n\"utils.go\",\n],\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/s... | Go | Apache License 2.0 | google/gvisor | ext: filesystem boilerplate code.
PiperOrigin-RevId: 259865366 |
259,992 | 26.07.2019 15:46:13 | 25,200 | 2762692621aec8b3d1e1839c2dc18965a4af0a18 | Add debug symbols to published runsc binary
This allows published binary to be debugged if needed. | [
{
"change_type": "MODIFY",
"old_path": "tools/run_build.sh",
"new_path": "tools/run_build.sh",
"diff": "@@ -31,16 +31,19 @@ elif [[ -v KOKORO_GIT_COMMIT ]] && [[ -d github/repo ]]; then\nfi\n# Build runsc.\n-bazel build //runsc\n+bazel build -c opt --strip=never //runsc\n# Move the runsc binary into... | Go | Apache License 2.0 | google/gvisor | Add debug symbols to published runsc binary
This allows published binary to be debugged if needed.
PiperOrigin-RevId: 260228367 |
259,853 | 26.07.2019 16:52:28 | 25,200 | 4183b9021ac1d055085dc1fd2f525689fc055d78 | runsc: propagate the alsologtostderr to sub-commands | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -198,6 +198,9 @@ type Config struct {\n// sandbox and Gofer process run as root inside a user namespace with root\n// mapped to the caller's user.\nRootless bool\n+\n+ // AlsoLogToStderr al... | Go | Apache License 2.0 | google/gvisor | runsc: propagate the alsologtostderr to sub-commands
PiperOrigin-RevId: 260239119 |
259,891 | 29.07.2019 13:18:58 | 25,200 | 09be87bbee1e4338b488f22199d0f079ffec8d0e | Add iptables types for syscalls tests.
Unfortunately, Linux's ip_tables.h header doesn't compile in C++ because it
implicitly converts from void* to struct xt_entry_target*. C allows this, but
C++ does not. So we have to re-implement many types ourselves.
Relevant code here: | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -904,6 +904,14 @@ cc_binary(\n],\n)\n+cc_library(\n+ name = \"iptables_types\",\n+ testonly = 1,\n+ hdrs = [\n+ \"iptables.h\",\n+ ],\n+)\n+\ncc_binary(\nname = \"itimer_test\",\n... | Go | Apache License 2.0 | google/gvisor | Add iptables types for syscalls tests.
Unfortunately, Linux's ip_tables.h header doesn't compile in C++ because it
implicitly converts from void* to struct xt_entry_target*. C allows this, but
C++ does not. So we have to re-implement many types ourselves.
Relevant code here:
https://github.com/torvalds/linux/blob/master/include/uapi/linux/netfilter_ipv4/ip_tables.h#L222
PiperOrigin-RevId: 260565570 |
259,975 | 29.07.2019 16:46:28 | 25,200 | f0507e1db1574ff165000fa5e34b651413f37aae | Fix flaky stat.cc test.
This test flaked on my current CL. Linux makes no guarantee
that two inodes will consecutive (overflows happen). | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/stat.cc",
"new_path": "test/syscalls/linux/stat.cc",
"diff": "@@ -539,9 +539,8 @@ TEST(SimpleStatTest, AnonDeviceAllocatesUniqueInodesAcrossSaveRestore) {\nASSERT_THAT(fstat(fd1.get(), &st1), SyscallSucceeds());\nASSERT_THAT(fstat(fd2.get()... | Go | Apache License 2.0 | google/gvisor | Fix flaky stat.cc test.
This test flaked on my current CL. Linux makes no guarantee
that two inodes will consecutive (overflows happen).
https://github.com/avagin/linux-task-diag/blob/master/fs/inode.c#L880
PiperOrigin-RevId: 260608240 |
259,956 | 29.07.2019 17:17:58 | 25,200 | a3e9031e665e5707ff1d181a577a808ff6d67452 | Use x/sys/unix for sentry/host interaction; abi is for guest/sentry. | [
{
"change_type": "MODIFY",
"old_path": "pkg/unet/BUILD",
"new_path": "pkg/unet/BUILD",
"diff": "@@ -11,8 +11,8 @@ go_library(\nimportpath = \"gvisor.dev/gvisor/pkg/unet\",\nvisibility = [\"//visibility:public\"],\ndeps = [\n- \"//pkg/abi/linux\",\n\"//pkg/gate\",\n+ \"@org_golang_x_sys//unix:go_defa... | Go | Apache License 2.0 | google/gvisor | Use x/sys/unix for sentry/host interaction; abi is for guest/sentry.
PiperOrigin-RevId: 260613864 |
259,907 | 29.07.2019 19:16:07 | 25,200 | ddf25e3331a18a74d0e01d74fee7f82963fe778c | ext: extent reader implementation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/BUILD",
"new_path": "pkg/sentry/fs/ext/BUILD",
"diff": "@@ -42,6 +42,7 @@ go_library(\n\"//pkg/sentry/fs/ext/disklayout\",\n\"//pkg/sentry/kernel/auth\",\n\"//pkg/sentry/kernel/pipe\",\n+ \"//pkg/sentry/safemem\",\n\"//pkg/sentry/usermem\",\n... | Go | Apache License 2.0 | google/gvisor | ext: extent reader implementation.
PiperOrigin-RevId: 260629559 |
259,979 | 30.07.2019 10:53:55 | -28,800 | 50f3447786e09bb6c7bc4255c01a7339193a66a0 | Combine multiple epoll events copies
Allocate a larger memory buffer and combine multiple copies into one copy,
to reduce the number of copies from kernel memory to user memory. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_epoll.go",
"new_path": "pkg/sentry/syscalls/linux/sys_epoll.go",
"diff": "@@ -107,20 +107,21 @@ func EpollCtl(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysc\n// copyOutEvents copies epoll events from the kernel... | Go | Apache License 2.0 | google/gvisor | Combine multiple epoll events copies
Allocate a larger memory buffer and combine multiple copies into one copy,
to reduce the number of copies from kernel memory to user memory.
Signed-off-by: Hang Su <darcy.sh@antfin.com> |
259,974 | 30.07.2019 10:59:57 | 25,200 | 1decf764718f66097ce5bbfe2cd14a883a4ef713 | Change syscall.POLL to syscall.PPOLL.
syscall.POLL is not supported on arm64, using syscall.PPOLL
to support both the x86 and arm64. refs
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/543 from xiaobo55x:master | [
{
"change_type": "MODIFY",
"old_path": "pkg/fdnotifier/poll_unsafe.go",
"new_path": "pkg/fdnotifier/poll_unsafe.go",
"diff": "@@ -35,8 +35,14 @@ func NonBlockingPoll(fd int32, mask waiter.EventMask) waiter.EventMask {\nevents: int16(mask.ToLinux()),\n}\n+ ts := syscall.Timespec{\n+ Sec: 0,\n+ Nsec: ... | Go | Apache License 2.0 | google/gvisor | Change syscall.POLL to syscall.PPOLL.
syscall.POLL is not supported on arm64, using syscall.PPOLL
to support both the x86 and arm64. refs #63
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I2c81a063d3ec4e7e6b38fe62f17a0924977f505e
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/543 from xiaobo55x:master ba598263fd3748d1addd48e4194080aa12085164
PiperOrigin-RevId: 260752049 |
259,884 | 30.07.2019 16:55:05 | 25,200 | 885e17f890d1d7c559871f720c40cef5cad69bc2 | Remove unused const variables | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/network.go",
"new_path": "runsc/sandbox/network.go",
"diff": "@@ -33,13 +33,6 @@ import (\n\"gvisor.dev/gvisor/runsc/specutils\"\n)\n-const (\n- // Annotations used to indicate whether the container corresponds to a\n- // pod or a container withi... | Go | Apache License 2.0 | google/gvisor | Remove unused const variables
PiperOrigin-RevId: 260824989 |
259,907 | 30.07.2019 18:19:15 | 25,200 | 9fbe984dc13f1af42bf3a73b696f7358794dd2d4 | ext: block map file reader implementation.
Also adds stress tests for block map reader and intensifies extent reader tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/BUILD",
"new_path": "pkg/sentry/fs/ext/BUILD",
"diff": "@@ -54,6 +54,7 @@ go_test(\nname = \"ext_test\",\nsize = \"small\",\nsrcs = [\n+ \"block_map_test.go\",\n\"ext_test.go\",\n\"extent_test.go\",\n],\n"
},
{
"change_type": "MODIFY"... | Go | Apache License 2.0 | google/gvisor | ext: block map file reader implementation.
Also adds stress tests for block map reader and intensifies extent reader tests.
PiperOrigin-RevId: 260838177 |
259,885 | 30.07.2019 20:31:29 | 25,200 | a7d5e0d254f22dc7d76f7f5bc86b8793f67e2f5f | Cache pages in CachingInodeOperations.Read when memory evictions are delayed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/inode_cached.go",
"new_path": "pkg/sentry/fs/fsutil/inode_cached.go",
"diff": "@@ -568,21 +568,30 @@ type inodeReadWriter struct {\n// ReadToBlocks implements safemem.Reader.ReadToBlocks.\nfunc (rw *inodeReadWriter) ReadToBlocks(dsts safem... | Go | Apache License 2.0 | google/gvisor | Cache pages in CachingInodeOperations.Read when memory evictions are delayed.
PiperOrigin-RevId: 260851452 |
259,904 | 31.07.2019 11:25:25 | 25,200 | 12c4eb294a43f4a84a789871730869d164ef52c9 | Fix ICMPv4 EchoReply packet checksum
The checksum was not being reset before being re-calculated and sent out.
This caused the sent checksum to always be `0x0800`.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/icmp.go",
"new_path": "pkg/tcpip/network/ipv4/icmp.go",
"diff": "@@ -94,6 +94,7 @@ func (e *endpoint) handleICMP(r *stack.Route, netHeader buffer.View, vv buffer.V\npkt := header.ICMPv4(hdr.Prepend(header.ICMPv4MinimumSize))\ncopy(pkt, h... | Go | Apache License 2.0 | google/gvisor | Fix ICMPv4 EchoReply packet checksum
The checksum was not being reset before being re-calculated and sent out.
This caused the sent checksum to always be `0x0800`.
Fixes #605.
PiperOrigin-RevId: 260965059 |
259,884 | 31.07.2019 20:29:07 | 25,200 | 0a246fab80581351309cdfe39ffeeffa00f811b1 | Basic support for 'ip route'
Implements support for RTM_GETROUTE requests for netlink sockets.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netlink_route.go",
"new_path": "pkg/abi/linux/netlink_route.go",
"diff": "@@ -189,3 +189,139 @@ const (\nconst (\nARPHRD_LOOPBACK = 772\n)\n+\n+// RouteMessage struct rtmsg, from uapi/linux/rtnetlink.h.\n+type RouteMessage struct {\n+ Family uint... | Go | Apache License 2.0 | google/gvisor | Basic support for 'ip route'
Implements support for RTM_GETROUTE requests for netlink sockets.
Fixes #507
PiperOrigin-RevId: 261051045 |
259,985 | 01.08.2019 13:57:41 | 25,200 | 79511e8a50facd509b8180d0160762b510dd6196 | Implement getsockopt(TCP_INFO).
Export some readily-available fields for TCP_INFO and stub out the rest. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -845,6 +845,68 @@ func getSockOptSocket(t *kernel.Task, s socket.Socket, ep commonEndpoint, family\nreturn nil, syserr.ErrProtocolNotAvailable\n}\n+func ... | Go | Apache License 2.0 | google/gvisor | Implement getsockopt(TCP_INFO).
Export some readily-available fields for TCP_INFO and stub out the rest.
PiperOrigin-RevId: 261191548 |
259,884 | 01.08.2019 00:50:46 | 14,400 | 46ee8873ffca2468eecf813cb2163f1d31ce390f | Remove superfluous redirects | [
{
"change_type": "MODIFY",
"old_path": "content/_index.html",
"new_path": "content/_index.html",
"diff": "@@ -41,7 +41,7 @@ Read the [documentation](./docs/) to understand gVisor, its architecture and tra\n{{% /blocks/feature %}}\n{{% blocks/feature icon=\"fas fa-code-branch\" title=\"Contribute to ... | Go | Apache License 2.0 | google/gvisor | Remove superfluous redirects |
259,992 | 29.07.2019 18:35:27 | 25,200 | 6ee109aca465e88b6e00a7b36b865649afb4e809 | Added section about attaching debugger | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/debugging.md",
"new_path": "content/docs/user_guide/debugging.md",
"diff": "@@ -56,6 +56,30 @@ sudo runsc --root /var/run/docker/runtime-runsc/moby debug --stacks 63254c6ab3a6\n> `/var/run/docker/runtime-[runtime-name]/moby`. If in doub... | Go | Apache License 2.0 | google/gvisor | Added section about attaching debugger |
259,884 | 01.08.2019 18:47:55 | 25,200 | 3eff0531adc6d28eea49be65fa747e2b3163f44d | Set sandbox oom_score_adj
Set /proc/self/oom_score_adj based on oomScoreAdj specified in the OCI bundle.
When new containers are added to the sandbox oom_score_adj for the sandbox and
all other gofers are adjusted so that oom_score_adj is equal to the lowest
oom_score_adj of all containers in the sandbox.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -475,7 +475,13 @@ func (c *Container) Start(conf *boot.Config) error {\n}\nc.changeStatus(Running)\n- return c.save()\n+ if err := c.save(); err != nil {\n+ return err\n+ }\... | Go | Apache License 2.0 | google/gvisor | Set sandbox oom_score_adj
Set /proc/self/oom_score_adj based on oomScoreAdj specified in the OCI bundle.
When new containers are added to the sandbox oom_score_adj for the sandbox and
all other gofers are adjusted so that oom_score_adj is equal to the lowest
oom_score_adj of all containers in the sandbox.
Fixes #512
PiperOrigin-RevId: 261242725 |
259,992 | 02.08.2019 13:46:42 | 25,200 | b461be88a8036ca0455aceb8b6c723d6b6fded4f | Stops container if gofer is killed
Each gofer now has a goroutine that polls on the FDs used
to communicate with the sandbox. The respective gofer is
destroyed if any of the FDs is closed.
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -88,6 +88,7 @@ go_library(\n\"//runsc/specutils\",\n\"@com_github_golang_protobuf//proto:go_default_library\",\n\"@com_github_opencontainers_runtime-spec//specs-go:go_default_library\",\n+ \"@org_g... | Go | Apache License 2.0 | google/gvisor | Stops container if gofer is killed
Each gofer now has a goroutine that polls on the FDs used
to communicate with the sandbox. The respective gofer is
destroyed if any of the FDs is closed.
Closes #601
PiperOrigin-RevId: 261383725 |
259,992 | 02.08.2019 16:33:51 | 25,200 | 960a5e5536d5d961028ef60123e3b00ff3c04a56 | Remove stale TODO
This was done in commit | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -630,7 +630,6 @@ func (l *Loader) startContainer(spec *specs.Spec, conf *Config, cid string, file\n// sentry currently supports only 1 mount namespace, which is tied to a\n// single user na... | Go | Apache License 2.0 | google/gvisor | Remove stale TODO
This was done in commit 04cbb13ce9b151cf906f42e3f18ce3a875f01f63
PiperOrigin-RevId: 261414748 |
259,884 | 11.07.2019 08:41:52 | -32,400 | 5f6e3739ef5d4d4bb761ec8a2a764976326b05fb | runsc permissions update in install instructions
Make the instructions clearer by putting the chown and chmod together and make it match the FAQ by setting the permissions bits exactly. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": "content/docs/includes/install_gvisor.md",
"diff": "@@ -19,9 +19,9 @@ a good place to put the `runsc` binary.\nwget https://storage.googleapis.com/gvisor/releases/nightly/latest/runsc\nwget https://storage.... | Go | Apache License 2.0 | google/gvisor | runsc permissions update in install instructions
Make the instructions clearer by putting the chown and chmod together and make it match the FAQ by setting the permissions bits exactly. |
259,997 | 06.08.2019 01:15:48 | -36,000 | 607be0585fdc659ec3c043c989a8a6f86fcc14db | Add option to configure reference leak checking | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -231,6 +231,20 @@ const (\nLeaksLogTraces\n)\n+// String returns LeakMode's string representation.\n+func (l LeakMode) String() string {\n+ switch l {\n+ case NoLeakChecking:\n+ return ... | Go | Apache License 2.0 | google/gvisor | Add option to configure reference leak checking |
259,974 | 05.08.2019 03:16:50 | 0 | 83fdb7739e2da5636147bac89d2508be507801dc | Change syscall.EPOLLET to unix.EPOLLET
syscall.EPOLLET has been defined with different values on amd64 and
arm64(-0x80000000 on amd64, and 0x80000000 on arm64), while unix.EPOLLET
has been unified this value to 0x80000000(golang/go#5328). ref | [
{
"change_type": "MODIFY",
"old_path": "pkg/fdnotifier/BUILD",
"new_path": "pkg/fdnotifier/BUILD",
"diff": "@@ -10,5 +10,8 @@ go_library(\n],\nimportpath = \"gvisor.dev/gvisor/pkg/fdnotifier\",\nvisibility = [\"//:sandbox\"],\n- deps = [\"//pkg/waiter\"],\n+ deps = [\n+ \"//pkg/waiter\",\n+ \"@org_g... | Go | Apache License 2.0 | google/gvisor | Change syscall.EPOLLET to unix.EPOLLET
syscall.EPOLLET has been defined with different values on amd64 and
arm64(-0x80000000 on amd64, and 0x80000000 on arm64), while unix.EPOLLET
has been unified this value to 0x80000000(golang/go#5328). ref #63
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: Id97d075c4e79d86a2ea3227ffbef02d8b00ffbb8 |
259,997 | 06.08.2019 11:57:50 | -36,000 | 8d89c0d92b3839eed0839b1a9bc7666e6261d972 | Remove traces option for ref leak mode | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -116,12 +116,10 @@ func MakeWatchdogAction(s string) (watchdog.Action, error) {\n// MakeRefsLeakMode converts type from string\nfunc MakeRefsLeakMode(s string) (refs.LeakMode, error) {\nswi... | Go | Apache License 2.0 | google/gvisor | Remove traces option for ref leak mode |
259,881 | 06.08.2019 10:34:06 | 25,200 | 704f9610f3d1add26c266888de62d884338f52cc | Require pread/pwrite for splice file offsets
If there is an offset, the file must support pread/pwrite. See
fs/splice.c:do_splice. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"new_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"diff": "@@ -207,6 +207,10 @@ func Splice(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscal\nreturn 0, nil, syserror.ESPIPE\n}\nif outOffset != ... | Go | Apache License 2.0 | google/gvisor | Require pread/pwrite for splice file offsets
If there is an offset, the file must support pread/pwrite. See
fs/splice.c:do_splice.
PiperOrigin-RevId: 261944932 |
259,884 | 10.07.2019 01:41:06 | 14,400 | 000ed17d48a09821c23eddac5087197fd1692e14 | Add redirect from old URL.
Adds url redirect from old syscall docs url to new url
make server now runs the Go server and implements redirects.
make devserver runs the hugo dev server. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -64,10 +64,14 @@ compatibility-docs: bin/generate-syscall-docs upstream/gvisor/bazel-bin/runsc/li\n.PHONY: compatibility-docs\n# Run a local content development server. Redirects will not be supported.\n-server: a... | Go | Apache License 2.0 | google/gvisor | Add redirect from old URL.
- Adds url redirect from old syscall docs url to new url
- make server now runs the Go server and implements redirects.
- make devserver runs the hugo dev server. |
259,992 | 06.08.2019 23:25:28 | 25,200 | e70eafc9e5bb5b1ffd6fb7001c2c0d77a5368486 | Make loading container in a sandbox more robust | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -138,6 +138,34 @@ type Container struct {\nRootContainerDir string\n}\n+// loadSandbox loads all containers that belong to the sandbox with the given\n+// ID.\n+func loadSan... | Go | Apache License 2.0 | google/gvisor | Make loading container in a sandbox more robust
PiperOrigin-RevId: 262071646 |
259,992 | 07.08.2019 12:53:44 | 25,200 | 79cc4397fd99fbdd5c74ac5bb7804a463d7981d8 | Set gofer's OOM score adjustment
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -1176,30 +1176,16 @@ func (c *Container) adjustOOMScoreAdj(conf *boot.Config) error {\nreturn nil\n}\n- // Set oom_score_adj for the sandbox.\n+ // Set the lowest of all con... | Go | Apache License 2.0 | google/gvisor | Set gofer's OOM score adjustment
Updates #512
PiperOrigin-RevId: 262195448 |
259,907 | 07.08.2019 15:23:19 | 25,200 | ad67e5a7a0869f475f923a0ce4c9446340c6a11a | ext: IterDirent unit tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/ext_test.go",
"new_path": "pkg/sentry/fs/ext/ext_test.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"fmt\"\n\"os\"\n\"path\"\n+ \"sort\"\n\"testing\"\n\"github.com/google/go-cmp/cmp\"\n@@ -79,6 +80,120 @@ func setUp(t *testing.T, imagePath strin... | Go | Apache License 2.0 | google/gvisor | ext: IterDirent unit tests.
PiperOrigin-RevId: 262226761 |
259,907 | 07.08.2019 16:43:08 | 25,200 | 3b368cabf9a6c08a19724a1a0f2f52c16461b7a9 | ext: Read unit tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/BUILD",
"new_path": "pkg/sentry/fs/ext/BUILD",
"diff": "@@ -76,6 +76,7 @@ go_test(\n\"//pkg/sentry/context/contexttest\",\n\"//pkg/sentry/fs/ext/disklayout\",\n\"//pkg/sentry/kernel/auth\",\n+ \"//pkg/sentry/usermem\",\n\"//pkg/sentry/vfs\",\... | Go | Apache License 2.0 | google/gvisor | ext: Read unit tests.
PiperOrigin-RevId: 262242410 |
259,907 | 07.08.2019 17:19:43 | 25,200 | 40d6d8c15b7deb8c1df1d8e764b014ca7140873e | ext: StatAt unit tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/ext_test.go",
"new_path": "pkg/sentry/fs/ext/ext_test.go",
"diff": "@@ -23,6 +23,7 @@ import (\n\"testing\"\n\"github.com/google/go-cmp/cmp\"\n+ \"github.com/google/go-cmp/cmp/cmpopts\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gviso... | Go | Apache License 2.0 | google/gvisor | ext: StatAt unit tests.
PiperOrigin-RevId: 262249166 |
259,907 | 07.08.2019 19:12:48 | 25,200 | 08cd5e1d368716f262ba9c31d94b1d7a29dbc5cf | ext: Seek unit tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/ext/BUILD",
"new_path": "pkg/sentry/fs/ext/BUILD",
"diff": "@@ -78,6 +78,7 @@ go_test(\n\"//pkg/sentry/kernel/auth\",\n\"//pkg/sentry/usermem\",\n\"//pkg/sentry/vfs\",\n+ \"//pkg/syserror\",\n\"//runsc/test/testutil\",\n\"@com_github_google_go-cm... | Go | Apache License 2.0 | google/gvisor | ext: Seek unit tests.
PiperOrigin-RevId: 262264674 |
259,885 | 08.08.2019 11:45:33 | 25,200 | 06102af65ad2d0e5a89c5e7dfe281afd5346ed4f | memfs fixes.
Unexport Filesystem/Dentry/Inode.
Support SEEK_CUR in directoryFD.Seek().
Hold Filesystem.mu before touching directoryFD.off in
directoryFD.Seek().
Remove deleted Dentries from their parent directory.childLists.
Remove invalid FIXMEs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/memfs/BUILD",
"new_path": "pkg/sentry/fsimpl/memfs/BUILD",
"diff": "@@ -11,8 +11,8 @@ go_template_instance(\nprefix = \"dentry\",\ntemplate = \"//pkg/ilist:generic_list\",\ntypes = {\n- \"Element\": \"*Dentry\",\n- \"Linker\": \"*Dentry\",\n+... | Go | Apache License 2.0 | google/gvisor | memfs fixes.
- Unexport Filesystem/Dentry/Inode.
- Support SEEK_CUR in directoryFD.Seek().
- Hold Filesystem.mu before touching directoryFD.off in
directoryFD.Seek().
- Remove deleted Dentries from their parent directory.childLists.
- Remove invalid FIXMEs.
PiperOrigin-RevId: 262400633 |
259,997 | 09.08.2019 17:13:06 | -36,000 | 73985c6545d887644d8aa4f0e00491cc903501c7 | Fix the Stringer for leak mode | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -235,11 +235,11 @@ const (\nfunc (l LeakMode) String() string {\nswitch l {\ncase NoLeakChecking:\n- return \"NoLeakChecking\"\n+ return \"disabled\"\ncase LeaksLogWarning:\n- return \"... | Go | Apache License 2.0 | google/gvisor | Fix the Stringer for leak mode |
259,974 | 09.08.2019 13:16:46 | 25,200 | 1c9da886e72aebc1c44c66715e3ec45f6d5eff5b | Add initial ptrace stub and syscall support for arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/elf.go",
"new_path": "pkg/abi/linux/elf.go",
"diff": "@@ -89,3 +89,17 @@ const (\n// AT_SYSINFO_EHDR is the address of the VDSO.\nAT_SYSINFO_EHDR = 33\n)\n+\n+// ELF ET_CORE and ptrace GETREGSET/SETREGSET register set types.\n+//\n+// See include... | Go | Apache License 2.0 | google/gvisor | Add initial ptrace stub and syscall support for arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I1dbd23bb240cca71d0cc30fc75ca5be28cb4c37c
PiperOrigin-RevId: 262619519 |
259,962 | 09.08.2019 14:49:05 | 25,200 | 5a38eb120abe0aecd4b64cf9e3a9e1ff1dc0edd7 | Add congestion control states to sender.
This change just introduces different congestion control states and
ensures the sender.state is updated to reflect the current state
of the connection.
It is not used for any decisions yet but this is required before
algorithms like Eiffel/PRR can be implemented.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -39,6 +39,28 @@ const (\nnDupAckThreshold = 3\n)\n+// ccState indicates the current congestion control state for this sender.\n+type ccState int\n+\n+const (\n+ // Open ... | Go | Apache License 2.0 | google/gvisor | Add congestion control states to sender.
This change just introduces different congestion control states and
ensures the sender.state is updated to reflect the current state
of the connection.
It is not used for any decisions yet but this is required before
algorithms like Eiffel/PRR can be implemented.
Fixes #394
PiperOrigin-RevId: 262638292 |
259,853 | 09.08.2019 22:33:40 | 25,200 | af90e68623c729d0e3b06a1e838c5584d2d8b7c2 | netlink: return an error in nlmsgerr
Now if a process sends an unsupported netlink requests,
an error is returned from the send system call.
The linux kernel works differently in this case. It returns errors in the
nlmsgerr netlink message.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netlink.go",
"new_path": "pkg/abi/linux/netlink.go",
"diff": "@@ -122,3 +122,9 @@ const (\nNETLINK_EXT_ACK = 11\nNETLINK_DUMP_STRICT_CHK = 12\n)\n+\n+// NetlinkErrorMessage is struct nlmsgerr, from uapi/linux/netlink.h.\n+type NetlinkErrorMessage... | Go | Apache License 2.0 | google/gvisor | netlink: return an error in nlmsgerr
Now if a process sends an unsupported netlink requests,
an error is returned from the send system call.
The linux kernel works differently in this case. It returns errors in the
nlmsgerr netlink message.
Reported-by: syzbot+571d99510c6f935202da@syzkaller.appspotmail.com
PiperOrigin-RevId: 262690453 |
259,854 | 12.08.2019 13:29:47 | 25,200 | eac690e358e25897bb878fdfd1ad7036054162e2 | Fix netstack build error on non-AMD64.
This stub had the wrong function signature. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/mmap.go",
"new_path": "pkg/tcpip/link/fdbased/mmap.go",
"diff": "package fdbased\n-import \"gvisor.dev/gvisor/pkg/tcpip\"\n-\n// Stubbed out version for non-linux/non-amd64 platforms.\n-func newPacketMMapDispatcher(fd int, e *endpoint) (... | Go | Apache License 2.0 | google/gvisor | Fix netstack build error on non-AMD64.
This stub had the wrong function signature.
PiperOrigin-RevId: 262992682 |
259,985 | 12.08.2019 17:33:26 | 25,200 | 691c2f8173dfe7349e8289697299839cda32b495 | Compute size of struct tcp_info instead of hardcoding it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -366,7 +366,7 @@ type TCPInfo struct {\n}\n// SizeOfTCPInfo is the binary size of a TCPInfo struct.\n-const SizeOfTCPInfo = 104\n+var SizeOfTCPInfo = int(binary.Size(TCPInfo{}))\n// C... | Go | Apache License 2.0 | google/gvisor | Compute size of struct tcp_info instead of hardcoding it.
PiperOrigin-RevId: 263040624 |
259,853 | 13.08.2019 11:54:59 | 25,200 | 8d97b22aa8e565ff05c5e9209f13d2394e9706c8 | tests: print stack traces if test failed by timeout | [
{
"change_type": "MODIFY",
"old_path": "runsc/main.go",
"new_path": "runsc/main.go",
"diff": "@@ -22,6 +22,7 @@ import (\n\"io\"\n\"io/ioutil\"\n\"os\"\n+ \"os/signal\"\n\"path/filepath\"\n\"strings\"\n\"syscall\"\n@@ -116,6 +117,13 @@ func main() {\n// All subcommands must be registered before flag... | Go | Apache License 2.0 | google/gvisor | tests: print stack traces if test failed by timeout
PiperOrigin-RevId: 263184083 |
259,854 | 13.08.2019 12:09:48 | 25,200 | 99bf75a6dc1cbad2d688ef80354f45940a40a3a1 | gonet: Replace NewPacketConn with DialUDP.
This better matches the standard library and allows creating connected
PacketConns. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet.go",
"diff": "@@ -556,32 +556,50 @@ type PacketConn struct {\nwq *waiter.Queue\n}\n-// NewPacketConn creates a new PacketConn.\n-func NewPacketConn(s *stack.Stack, addr tcpip.FullA... | Go | Apache License 2.0 | google/gvisor | gonet: Replace NewPacketConn with DialUDP.
This better matches the standard library and allows creating connected
PacketConns.
PiperOrigin-RevId: 263187462 |
259,992 | 13.08.2019 12:21:33 | 25,200 | c386f046c1db5b065acf52ad3dde8080a38ddf01 | Fix file mode check in fsgofer Attach | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -125,7 +125,7 @@ func (a *attachPoint) Attach() (p9.File, error) {\nreturn nil, fmt.Errorf(\"stat file %q, err: %v\", a.prefix, err)\n}\nmode := syscall.O_RDWR\n- if a.conf.ROMount ... | Go | Apache License 2.0 | google/gvisor | Fix file mode check in fsgofer Attach
PiperOrigin-RevId: 263189654 |
259,854 | 13.08.2019 12:47:46 | 25,200 | 072d941e325686e877395dabb4320c39e5e82a8a | Add note to name logging mentioning trace logging should be enabled to debug. | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -325,6 +325,8 @@ func (r *AtomicRefCount) finalize() {\nmsg := fmt.Sprintf(\"%sAtomicRefCount %p owned by %q garbage collected with ref count of %d (want 0)\", note, r, r.name, n)\nif l... | Go | Apache License 2.0 | google/gvisor | Add note to name logging mentioning trace logging should be enabled to debug.
PiperOrigin-RevId: 263194584 |
259,992 | 13.08.2019 13:32:18 | 25,200 | 0e907c4298e635d5960b1aeefde2294a6a795cbc | Fix file mode check in pipeOperations | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fdpipe/pipe.go",
"new_path": "pkg/sentry/fs/fdpipe/pipe.go",
"diff": "@@ -87,7 +87,7 @@ func (p *pipeOperations) init() error {\nlog.Warningf(\"pipe: cannot stat fd %d: %v\", p.file.FD(), err)\nreturn syscall.EINVAL\n}\n- if s.Mode&syscall.S_IFIF... | Go | Apache License 2.0 | google/gvisor | Fix file mode check in pipeOperations
PiperOrigin-RevId: 263203441 |
260,015 | 13.08.2019 16:25:09 | 25,200 | 462bafb2e7a4d56b788a7467a9e7c05604f55a15 | Add variable controlling the go binary path. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "# Base path used to install.\nDESTDIR=/usr/local\n+GC=go\nGO_BUILD_FLAGS=\nGO_TAGS=\nGO_LDFLAGS=-ldflags '-s -w -extldflags \"-static\"'\n@@ -12,10 +13,10 @@ all: binaries\nbinaries: bin/gvisor-containerd-shim bin/co... | Go | Apache License 2.0 | google/gvisor | Add variable controlling the go binary path. (#35) |
259,885 | 13.08.2019 17:52:53 | 25,200 | cee044c2ab009c9faae154e1751eef93430fc141 | Add vfs.DynamicBytesFileDescriptionImpl.
This replaces fs/proc/seqfile for vfs2-based filesystems. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/BUILD",
"new_path": "pkg/sentry/vfs/BUILD",
"diff": "@@ -18,6 +18,7 @@ go_library(\n\"permissions.go\",\n\"resolving_path.go\",\n\"syscalls.go\",\n+ \"testutil.go\",\n\"vfs.go\",\n],\nimportpath = \"gvisor.dev/gvisor/pkg/sentry/vfs\",\n@@ -40,7 ... | Go | Apache License 2.0 | google/gvisor | Add vfs.DynamicBytesFileDescriptionImpl.
This replaces fs/proc/seqfile for vfs2-based filesystems.
PiperOrigin-RevId: 263254647 |
259,884 | 14.08.2019 10:05:14 | 14,400 | 76a12063a6566a2e1c8e2c3589ebf90e91da3dc7 | Fix performance graph shortcode invocations | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/performance.md",
"new_path": "content/docs/architecture_guide/performance.md",
"diff": "@@ -68,7 +68,7 @@ accesses. Page faults and other Operating System (OS) mechanisms are translated\nthrough the Sentry, but once mappings are... | Go | Apache License 2.0 | google/gvisor | Fix performance graph shortcode invocations |
259,974 | 15.08.2019 02:04:47 | 0 | 0624858593847096b68ecbd262e2cae6ea79048a | Rename rawfile/blockingpoll_unsafe.go to rawfile/blockingpoll_stub_unsafe.go. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/rawfile/BUILD",
"new_path": "pkg/tcpip/link/rawfile/BUILD",
"diff": "@@ -7,7 +7,7 @@ go_library(\nsrcs = [\n\"blockingpoll_amd64.s\",\n\"blockingpoll_amd64_unsafe.go\",\n- \"blockingpoll_unsafe.go\",\n+ \"blockingpoll_stub_unsafe.go\",\n\"errors... | Go | Apache License 2.0 | google/gvisor | Rename rawfile/blockingpoll_unsafe.go to rawfile/blockingpoll_stub_unsafe.go.
Signed-off-by: Haibo Xu haibo.xu@arm.com
Change-Id: I2376e502c1a860d5e624c8a8e3afab5da4c53022 |
259,974 | 15.08.2019 02:20:30 | 0 | 52843719ca8f4e5a91fed4916ecb0e483ac025b9 | Rename fdbased/mmap.go to fdbased/mmap_stub.go. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/BUILD",
"new_path": "pkg/tcpip/link/fdbased/BUILD",
"diff": "@@ -7,9 +7,9 @@ go_library(\nsrcs = [\n\"endpoint.go\",\n\"endpoint_unsafe.go\",\n- \"mmap.go\",\n\"mmap_amd64.go\",\n\"mmap_amd64_unsafe.go\",\n+ \"mmap_stub.go\",\n\"packet_d... | Go | Apache License 2.0 | google/gvisor | Rename fdbased/mmap.go to fdbased/mmap_stub.go.
Signed-off-by: Haibo Xu haibo.xu@arm.com
Change-Id: Id4489554b9caa332695df8793d361f8332f6a13b |
259,974 | 15.08.2019 03:11:15 | 0 | 1b1e39d7a1846e9afa9b794c5780a703f4b05211 | Enabling pkg/tcpip/link support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/BUILD",
"new_path": "pkg/tcpip/link/fdbased/BUILD",
"diff": "@@ -7,9 +7,9 @@ go_library(\nsrcs = [\n\"endpoint.go\",\n\"endpoint_unsafe.go\",\n- \"mmap_amd64.go\",\n- \"mmap_amd64_unsafe.go\",\n+ \"mmap.go\",\n\"mmap_stub.go\",\n+ \"mmap... | Go | Apache License 2.0 | google/gvisor | Enabling pkg/tcpip/link support on arm64.
Signed-off-by: Haibo Xu haibo.xu@arm.com
Change-Id: Ib6b4aa2db19032e58bf0395f714e6883caee460a |
259,985 | 15.08.2019 14:04:44 | 25,200 | 6cfc76798b586a6c33c1ec311cb5f0d82b90ca72 | Document source and versioning of the TCPInfo struct. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -292,7 +292,10 @@ const SizeOfLinger = 8\n// TCPInfo is a collection of TCP statistics.\n//\n-// From uapi/linux/tcp.h.\n+// From uapi/linux/tcp.h. Newer versions of Linux continue to... | Go | Apache License 2.0 | google/gvisor | Document source and versioning of the TCPInfo struct.
PiperOrigin-RevId: 263637194 |
259,891 | 15.08.2019 16:30:25 | 25,200 | ef045b914bc8d9795f9184aed4b13351be70a3cf | Add tests for "cooked" AF_PACKET sockets. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -249,6 +249,8 @@ syscall_test(\ntest = \"//test/syscalls/linux:open_test\",\n)\n+syscall_test(test = \"//test/syscalls/linux:packet_socket_test\")\n+\nsyscall_test(test = \"//test/syscalls/li... | Go | Apache License 2.0 | google/gvisor | Add tests for "cooked" AF_PACKET sockets.
PiperOrigin-RevId: 263666789 |
259,907 | 16.08.2019 10:18:58 | 25,200 | 4bab7d7f084c4ce4a8bf5860b71df6aee757cd5c | vfs: Remove vfs.DefaultDirectoryFD from embedding vfs.DefaultFD.
This fixes the implementation ambiguity issues when a filesystem
implementation embeds vfs.DefaultDirectoryFD to its directory FD along
with an internal common fileDescription utility.
For similar reasons also removes FileDescriptionDefaultImpl from
DynamicBytesFileDescriptionImpl. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/file_description.go",
"new_path": "pkg/sentry/fsimpl/ext/file_description.go",
"diff": "@@ -16,18 +16,16 @@ package ext\nimport (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n- \"gvisor.dev/gvisor/pkg/sentry/arch\"\n\"gvisor.dev/gvisor/pkg/sentr... | Go | Apache License 2.0 | google/gvisor | vfs: Remove vfs.DefaultDirectoryFD from embedding vfs.DefaultFD.
This fixes the implementation ambiguity issues when a filesystem
implementation embeds vfs.DefaultDirectoryFD to its directory FD along
with an internal common fileDescription utility.
For similar reasons also removes FileDescriptionDefaultImpl from
DynamicBytesFileDescriptionImpl.
PiperOrigin-RevId: 263795513 |
260,006 | 16.08.2019 15:57:46 | 25,200 | f7114e0a27db788af512af8678595954996bcd7f | Add subnet checking to NIC.findEndpoint and consolidate with NIC.getRef
This adds the same logic to NIC.findEndpoint that is already done in
NIC.getRef. Since this makes the two functions very similar they were combined
into one with the originals being wrappers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -186,41 +186,73 @@ func (n *NIC) primaryEndpoint(protocol tcpip.NetworkProtocolNumber) *referencedN\nreturn nil\n}\n+func (n *NIC) getRef(protocol tcpip.NetworkProtocolNumber, dst tcpip... | Go | Apache License 2.0 | google/gvisor | Add subnet checking to NIC.findEndpoint and consolidate with NIC.getRef
This adds the same logic to NIC.findEndpoint that is already done in
NIC.getRef. Since this makes the two functions very similar they were combined
into one with the originals being wrappers.
PiperOrigin-RevId: 263864708 |
259,853 | 16.08.2019 17:32:20 | 25,200 | 2a1303357c3d928cca95601241fc16baca0e5f41 | ptrace: detect if a stub process exited unexpectedly | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess.go",
"diff": "@@ -354,6 +354,9 @@ func (t *thread) wait(outcome waitOutcome) syscall.Signal {\ncontinue // Spurious stop.\n}\nif stopSig == syscall.SIGTRAP {\n+ if st... | Go | Apache License 2.0 | google/gvisor | ptrace: detect if a stub process exited unexpectedly
PiperOrigin-RevId: 263880577 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.