author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,853 | 16.08.2019 19:30:59 | 25,200 | 3e4102b2ead18aa768e1b8082d9865a9c567ce4e | netstack: disconnect an unix socket only if the address family is AF_UNSPEC
Linux allows to call connect for ANY and the zero port. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -291,18 +291,22 @@ func bytesToIPAddress(addr []byte) tcpip.Address {\nreturn tcpip.Address(addr)\n}\n-// GetAddress reads an sockaddr struct from the gi... | Go | Apache License 2.0 | google/gvisor | netstack: disconnect an unix socket only if the address family is AF_UNSPEC
Linux allows to call connect for ANY and the zero port.
PiperOrigin-RevId: 263892534 |
259,891 | 19.08.2019 10:04:54 | 25,200 | bd826092fecf32a87a3207a23c3795e819babce7 | Read iptables via sockopts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/stack.go",
"new_path": "pkg/sentry/socket/epsocket/stack.go",
"diff": "@@ -198,8 +198,8 @@ func (s *Stack) IPTables() (iptables.IPTables, error) {\n// FillDefaultIPTables sets the stack's iptables to the default tables, which\n// all... | Go | Apache License 2.0 | google/gvisor | Read iptables via sockopts.
PiperOrigin-RevId: 264180125 |
259,883 | 19.08.2019 12:09:08 | 25,200 | a63f88855f9c5d9340028e5828617a263dbf3023 | hostinet: fix parsing route netlink message
We wrongly parses output interface as gateway address.
The fix is straightforward.
Fixes
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/684 from tanjianfeng:fix-638 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/stack.go",
"new_path": "pkg/sentry/socket/hostinet/stack.go",
"diff": "@@ -203,8 +203,14 @@ func ExtractHostRoutes(routeMsgs []syscall.NetlinkMessage) ([]inet.Route, error)\ninetRoute.DstAddr = attr.Value\ncase syscall.RTA_SRC:\ninet... | Go | Apache License 2.0 | google/gvisor | hostinet: fix parsing route netlink message
We wrongly parses output interface as gateway address.
The fix is straightforward.
Fixes #638
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com>
Change-Id: Ia4bab31f3c238b0278ea57ab22590fad00eaf061
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/684 from tanjianfeng:fix-638 b940e810367ad1273519bfa594f4371bdd293e83
PiperOrigin-RevId: 264211336 |
259,975 | 19.08.2019 14:06:22 | 25,200 | 67d7864f839037c5188c2a9e7ec5e7b11a7672a2 | Document RWF_HIPRI not implemented for preadv2/pwritev2.
Document limitation of no reasonable implementation for RWF_HIPRI
flag (High Priority Read/Write for block-based file systems). | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -178,6 +178,8 @@ const (\n// Values for preadv2/pwritev2.\nconst (\n+ // Note: gVisor does not implement the RWF_HIPRI feature, but the flag is\n+ // accepted as a valid flag argument for... | Go | Apache License 2.0 | google/gvisor | Document RWF_HIPRI not implemented for preadv2/pwritev2.
Document limitation of no reasonable implementation for RWF_HIPRI
flag (High Priority Read/Write for block-based file systems).
PiperOrigin-RevId: 264237589 |
259,975 | 20.08.2019 15:05:17 | 25,200 | 3d0715b3f8e7864104e9cbb29b16e6a6b7568d63 | Fix flaky futex test.
The test is long running (175128 ms or so) which causes timeouts.
The test simply makes sure that private futexes can acquire
locks concurrently. Dropping current threads and increasing the
number of locks each thread tests the same concurrency concerns
but drops execution time to ~1411 ms. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/futex.cc",
"new_path": "test/syscalls/linux/futex.cc",
"diff": "@@ -689,10 +689,10 @@ TEST_P(PrivateAndSharedFutexTest, PITryLockConcurrency_NoRandomSave) {\nstd::atomic<int> a = ATOMIC_VAR_INIT(0);\nconst bool is_priv = IsPrivate();\n- std... | Go | Apache License 2.0 | google/gvisor | Fix flaky futex test.
The test is long running (175128 ms or so) which causes timeouts.
The test simply makes sure that private futexes can acquire
locks concurrently. Dropping current threads and increasing the
number of locks each thread tests the same concurrency concerns
but drops execution time to ~1411 ms.
PiperOrigin-RevId: 264476144 |
259,891 | 20.08.2019 16:34:37 | 25,200 | 6c3a242143dd234e7ef5979a41dfe648cea23d84 | Add tests for raw AF_PACKET sockets. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -255,6 +255,8 @@ syscall_test(\ntest = \"//test/syscalls/linux:open_test\",\n)\n+syscall_test(test = \"//test/syscalls/linux:packet_socket_raw_test\")\n+\nsyscall_test(test = \"//test/syscall... | Go | Apache License 2.0 | google/gvisor | Add tests for raw AF_PACKET sockets.
PiperOrigin-RevId: 264494359 |
259,853 | 20.08.2019 19:09:45 | 25,200 | 7609da6cb937f1152206dc0fe7294982ea7160e1 | test: reset a signal handler before closing a signal channel
goroutine 5 [running]:
os/signal.process(0x10e21c0, 0xc00050c280)
third_party/go/gc/src/os/signal/signal.go:227 +0x164
os/signal.loop()
third_party/go/gc/src/os/signal/signal_unix.go:23 +0x3e
created by os/signal.init.0
third_party/go/gc/src/os/signal/signal_unix.go:29 +0x41 | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/syscall_test_runner.go",
"new_path": "test/syscalls/syscall_test_runner.go",
"diff": "@@ -280,6 +280,7 @@ func runTestCaseRunsc(testBin string, tc gtest.TestCase, t *testing.T) {\nif err = cmd.Run(); err != nil {\nt.Errorf(\"test %q exited with s... | Go | Apache License 2.0 | google/gvisor | test: reset a signal handler before closing a signal channel
goroutine 5 [running]:
os/signal.process(0x10e21c0, 0xc00050c280)
third_party/go/gc/src/os/signal/signal.go:227 +0x164
os/signal.loop()
third_party/go/gc/src/os/signal/signal_unix.go:23 +0x3e
created by os/signal.init.0
third_party/go/gc/src/os/signal/signal_unix.go:29 +0x41
PiperOrigin-RevId: 264518530 |
260,006 | 20.08.2019 23:27:29 | 25,200 | 7e79ca02251d0e085e2f1fc05b3811291e85fc0b | Add tcpip.Route.String and tcpip.AddressMask.Prefix | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tcpip.go",
"new_path": "pkg/tcpip/tcpip.go",
"diff": "@@ -31,6 +31,7 @@ package tcpip\nimport (\n\"errors\"\n\"fmt\"\n+ \"math/bits\"\n\"reflect\"\n\"strconv\"\n\"strings\"\n@@ -145,8 +146,17 @@ type Address string\ntype AddressMask string\n// String... | Go | Apache License 2.0 | google/gvisor | Add tcpip.Route.String and tcpip.AddressMask.Prefix
PiperOrigin-RevId: 264544163 |
259,853 | 21.08.2019 19:05:56 | 25,200 | 5fd63d1c7fc8ea8d0aff30abc6403aa4491b6f81 | tests: retry connect if it fails with EINTR
test/syscalls/linux/proc_net_tcp.cc:252: Failure
Value of: connect(client->get(), &addr, addrlen)
Expected: not -1 (success)
Actual: -1 (of type int), with errno PosixError(errno=4 Interrupted system call) | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc_net_tcp.cc",
"new_path": "test/syscalls/linux/proc_net_tcp.cc",
"diff": "@@ -249,7 +249,8 @@ TEST(ProcNetTCP, State) {\nstd::unique_ptr<FileDescriptor> client =\nASSERT_NO_ERRNO_AND_VALUE(IPv4TCPUnboundSocket(0).Create());\n- ASSERT_TH... | Go | Apache License 2.0 | google/gvisor | tests: retry connect if it fails with EINTR
test/syscalls/linux/proc_net_tcp.cc:252: Failure
Value of: connect(client->get(), &addr, addrlen)
Expected: not -1 (success)
Actual: -1 (of type int), with errno PosixError(errno=4 Interrupted system call)
PiperOrigin-RevId: 264743815 |
259,997 | 22.08.2019 22:52:43 | -36,000 | 7672eaae25eebad650e71ba790e1585736866ccc | Add log prefix for better clarity | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -237,9 +237,9 @@ func (l LeakMode) String() string {\ncase NoLeakChecking:\nreturn \"disabled\"\ncase LeaksLogWarning:\n- return \"warning\"\n+ return \"log-names\"\ncase LeaksLogTraces... | Go | Apache License 2.0 | google/gvisor | Add log prefix for better clarity |
259,883 | 19.08.2019 23:13:03 | -28,800 | 2c3e2ed2bf4aa61bf317545fe428ff3adac95f92 | unix: return ECONNRESET if peer closed with data not read
For SOCK_STREAM type unix socket, we shall return ECONNRESET if peer is
closed with data not read.
We explictly set a flag when closing one end, to differentiate from
just shutdown (where zero shall be returned).
Fixes: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/socket.go",
"new_path": "pkg/sentry/fs/host/socket.go",
"diff": "@@ -385,3 +385,6 @@ func (c *ConnectedEndpoint) RecvMaxQueueSize() int64 {\nfunc (c *ConnectedEndpoint) Release() {\nc.ref.DecRefWithDestructor(c.close)\n}\n+\n+// CloseUnread ... | Go | Apache License 2.0 | google/gvisor | unix: return ECONNRESET if peer closed with data not read
For SOCK_STREAM type unix socket, we shall return ECONNRESET if peer is
closed with data not read.
We explictly set a flag when closing one end, to differentiate from
just shutdown (where zero shall be returned).
Fixes: #735
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com> |
259,881 | 22.08.2019 13:19:47 | 25,200 | 52e674b44d77b0a227d2b74dd75ae29c036fb01b | Remove ASSERT from fork child
The gunit macros are not safe to use in the child. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pty_root.cc",
"new_path": "test/syscalls/linux/pty_root.cc",
"diff": "@@ -50,7 +50,7 @@ TEST(JobControlRootTest, StealTTY) {\n// of 1.\npid_t child = fork();\nif (!child) {\n- ASSERT_THAT(setsid(), SyscallSucceeds());\n+ TEST_PCHECK(setsid(... | Go | Apache License 2.0 | google/gvisor | Remove ASSERT from fork child
The gunit macros are not safe to use in the child.
PiperOrigin-RevId: 264904348 |
259,992 | 22.08.2019 13:25:29 | 25,200 | 0034aaa82ac00a75866e77a3570febdec8d291d1 | Send sandbox log to test log
This used to be the case, but when --alsologtostderr
was added, it stopped logging. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/testutil/testutil.go",
"new_path": "runsc/test/testutil/testutil.go",
"diff": "@@ -129,6 +129,8 @@ func TestConfig() *boot.Config {\nreturn &boot.Config{\nDebug: true,\nLogFormat: \"text\",\n+ DebugLogFormat: \"text\",\n+ AlsoLogToStderr: true,\nLog... | Go | Apache License 2.0 | google/gvisor | Send sandbox log to test log
This used to be the case, but when --alsologtostderr
was added, it stopped logging.
PiperOrigin-RevId: 264905640 |
259,858 | 22.08.2019 14:33:16 | 25,200 | 761e4bf2fe520dae1120341b09c26be1577a2adb | Ensure yield-equivalent with an already-expired timeout. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_block.go",
"new_path": "pkg/sentry/kernel/task_block.go",
"diff": "package kernel\nimport (\n+ \"runtime\"\n\"time\"\nktime \"gvisor.dev/gvisor/pkg/sentry/kernel/time\"\n@@ -121,6 +122,17 @@ func (t *Task) block(C <-chan struct{}, timerC... | Go | Apache License 2.0 | google/gvisor | Ensure yield-equivalent with an already-expired timeout.
PiperOrigin-RevId: 264920977 |
259,992 | 22.08.2019 18:25:57 | 25,200 | f225fdbbe77c2017225517adcf67df70fcf8e36e | Log message sent before logging is setup
Moved log message to after the log options have
been read and log setup. | [
{
"change_type": "MODIFY",
"old_path": "runsc/main.go",
"new_path": "runsc/main.go",
"diff": "@@ -117,13 +117,6 @@ func main() {\n// All subcommands must be registered before flag parsing.\nflag.Parse()\n- if *testOnlyAllowRunAsCurrentUserWithoutChroot {\n- // SIGTERM is sent to all processes if a t... | Go | Apache License 2.0 | google/gvisor | Log message sent before logging is setup
Moved log message to after the log options have
been read and log setup.
PiperOrigin-RevId: 264964171 |
259,975 | 23.08.2019 16:53:00 | 25,200 | a5d0115943c591173ea322cd1d721c89fc9c442d | Second try at flaky futex test.
The flake had the call to futex_unlock_pi() returning EINVAL with the
FUTEX_OWNER_DIED set. In this case, userspace has to clean up stale
state. So instead of calling FUTEX_UNLOCK_PI outright, we'll use the
advised atomic compare_exchange as advised in the man page. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/futex.cc",
"new_path": "test/syscalls/linux/futex.cc",
"diff": "@@ -125,6 +125,10 @@ int futex_lock_pi(bool priv, std::atomic<int>* uaddr) {\nif (priv) {\nop |= FUTEX_PRIVATE_FLAG;\n}\n+ int zero = 0;\n+ if (uaddr->compare_exchange_strong(z... | Go | Apache License 2.0 | google/gvisor | Second try at flaky futex test.
The flake had the call to futex_unlock_pi() returning EINVAL with the
FUTEX_OWNER_DIED set. In this case, userspace has to clean up stale
state. So instead of calling FUTEX_UNLOCK_PI outright, we'll use the
advised atomic compare_exchange as advised in the man page.
PiperOrigin-RevId: 265163920 |
259,853 | 26.08.2019 09:58:16 | 25,200 | c9c52c024cf20c1c66327171af4287129724326e | fsgofer_test.go: a socket file path can't be longer than UNIX_MAX_PATH (108) | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer_test.go",
"new_path": "runsc/fsgofer/fsgofer_test.go",
"diff": "@@ -635,7 +635,15 @@ func TestAttachInvalidType(t *testing.T) {\nt.Fatalf(\"Mkfifo(%q): %v\", fifo, err)\n}\n- socket := filepath.Join(dir, \"socket\")\n+ dirFile, err := os.... | Go | Apache License 2.0 | google/gvisor | fsgofer_test.go: a socket file path can't be longer than UNIX_MAX_PATH (108)
PiperOrigin-RevId: 265478578 |
259,923 | 26.08.2019 09:27:07 | -7,200 | 5c82fbe1aac83ce76c628c6ee382c77df8d331ea | Add missing sudo in setup-command | [
{
"change_type": "MODIFY",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": "content/docs/includes/install_gvisor.md",
"diff": "@@ -21,7 +21,7 @@ a good place to put the `runsc` binary.\nsha512sum -c runsc.sha512\nsudo mv runsc /usr/local/bin\nsudo chown root:root /usr/local/bin/ru... | Go | Apache License 2.0 | google/gvisor | Add missing sudo in setup-command |
259,985 | 26.08.2019 16:38:04 | 25,200 | 1fdefd41c5410291b50c3f28ca13f423031f1f12 | netstack/tcp: Add LastAck transition.
Add missing state transition to LastAck, which should happen when the
endpoint has already recieved a FIN from the remote side, and is
sending its own FIN. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -664,7 +664,14 @@ func (s *sender) maybeSendSegment(seg *segment, limit int, end seqnum.Value) (se\nsegEnd = seg.sequenceNumber.Add(1)\n// Transition to FIN-WAIT1 state ... | Go | Apache License 2.0 | google/gvisor | netstack/tcp: Add LastAck transition.
Add missing state transition to LastAck, which should happen when the
endpoint has already recieved a FIN from the remote side, and is
sending its own FIN.
PiperOrigin-RevId: 265568314 |
259,858 | 26.08.2019 21:35:10 | 25,200 | b4cdaef4a1d545867d8e34036c5ed3175e55079d | Don't lose test output. | [
{
"change_type": "MODIFY",
"old_path": "tools/run_tests.sh",
"new_path": "tools/run_tests.sh",
"diff": "@@ -176,7 +176,6 @@ run_docker_tests() {\nbazel test \\\n\"${BAZEL_BUILD_FLAGS[@]}\" \\\n--test_env=RUNSC_RUNTIME=\"\" \\\n- --test_output=all \\\n//runsc/test/image:image_test\n# These names are ... | Go | Apache License 2.0 | google/gvisor | Don't lose test output.
PiperOrigin-RevId: 265606322 |
259,993 | 29.07.2019 14:57:14 | 25,200 | c319b360d134cff66000fd036fce8b3816c296ea | First pass at implementing Unix Domain Socket support. No tests.
This commit adds support for detecting the socket file type, connecting
to a Unix Domain Socket, and providing bidirectional communication
(without file descriptor transfer support). | [
{
"change_type": "MODIFY",
"old_path": "pkg/fd/fd.go",
"new_path": "pkg/fd/fd.go",
"diff": "@@ -22,6 +22,7 @@ import (\n\"runtime\"\n\"sync/atomic\"\n\"syscall\"\n+ \"net\"\n)\n// ReadWriter implements io.ReadWriter, io.ReaderAt, and io.WriterAt for fd. It\n@@ -185,6 +186,21 @@ func OpenAt(dir *FD, ... | Go | Apache License 2.0 | google/gvisor | First pass at implementing Unix Domain Socket support. No tests.
This commit adds support for detecting the socket file type, connecting
to a Unix Domain Socket, and providing bidirectional communication
(without file descriptor transfer support). |
259,993 | 30.07.2019 14:58:26 | 25,200 | 07d329d89f25e4649731199c3025f4fa0ed52bdb | Restrict seccomp filters for UDS support.
This commit further restricts the seccomp filters required for Gofer
access ot Unix Domain Sockets (UDS). | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/config.go",
"new_path": "runsc/fsgofer/filter/config.go",
"diff": "@@ -39,6 +39,8 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_SETSOCKOPT: []seccomp.Rule{\n{\nseccomp.AllowAny{},\n+ seccomp.AllowValue(syscall.SOL_SOCKET),\n+... | Go | Apache License 2.0 | google/gvisor | Restrict seccomp filters for UDS support.
This commit further restricts the seccomp filters required for Gofer
access ot Unix Domain Sockets (UDS). |
259,992 | 27.08.2019 10:46:06 | 25,200 | c39564332bdd5030b9031ed3b1a428464fea670e | Mount volumes as super user
This used to be the case, but regressed after a recent change.
Also made a few fixes around it and clean up the code a bit.
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/mounts.go",
"new_path": "pkg/sentry/fs/mounts.go",
"diff": "@@ -171,8 +171,6 @@ type MountNamespace struct {\n// NewMountNamespace returns a new MountNamespace, with the provided node at the\n// root, and the given cache size. A root must always ... | Go | Apache License 2.0 | google/gvisor | Mount volumes as super user
This used to be the case, but regressed after a recent change.
Also made a few fixes around it and clean up the code a bit.
Closes #720
PiperOrigin-RevId: 265717496 |
259,992 | 27.08.2019 10:51:23 | 25,200 | 8fd89fd7a2b4a69c76b126fa52f47757b6076d36 | Fix sendfile(2) error code
When output file is in append mode, sendfile(2) should fail
with EINVAL and not EBADF.
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"new_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"diff": "@@ -91,22 +91,29 @@ func Sendfile(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysc\n}\n// Get files.\n+ inFile := t.GetFile(inFD)\n+ if ... | Go | Apache License 2.0 | google/gvisor | Fix sendfile(2) error code
When output file is in append mode, sendfile(2) should fail
with EINVAL and not EBADF.
Closes #721
PiperOrigin-RevId: 265718958 |
259,975 | 27.08.2019 14:48:36 | 25,200 | f64d9a7d93865b1ab5246a5ded2ece890582b902 | Fix pwritev2 flaky test.
Fix a uninitialized memory bug in pwritev2 test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pwritev2.cc",
"new_path": "test/syscalls/linux/pwritev2.cc",
"diff": "@@ -244,8 +244,10 @@ TEST(Pwritev2Test, TestInvalidOffset) {\nconst FileDescriptor fd =\nASSERT_NO_ERRNO_AND_VALUE(Open(file.path(), O_RDWR));\n+ char buf[16];\nstruct io... | Go | Apache License 2.0 | google/gvisor | Fix pwritev2 flaky test.
Fix a uninitialized memory bug in pwritev2 test.
PiperOrigin-RevId: 265772176 |
259,858 | 27.08.2019 23:24:33 | 25,200 | 784f48a78debe68435b8fb59e8132d4dbc47ce48 | kokoro: Add scripts to rebuild images.
These scripts generated the following images:
gvisor-kokoro-testing/image-a53bac71541a209e (ubuntu 18.04)
gvisor-kokoro-testing/image-f5b20c5fbd23f448 (ubuntu 16.04)
Any modifications to these scripts should generate new images. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/ubuntu1604/10_core.sh",
"diff": "+#!/bin/bash\n+\n+# Copyright 2019 The gVisor Authors.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You... | Go | Apache License 2.0 | google/gvisor | kokoro: Add scripts to rebuild images.
These scripts generated the following images:
gvisor-kokoro-testing/image-a53bac71541a209e (ubuntu 18.04)
gvisor-kokoro-testing/image-f5b20c5fbd23f448 (ubuntu 16.04)
Any modifications to these scripts should generate new images.
PiperOrigin-RevId: 265843929 |
259,858 | 28.08.2019 22:06:09 | 25,200 | 06ae36185ec0a68b4d191ba1c86d4dc250ac2b38 | Fix kokoro image build scripts
The /tmpfs directory needs to be writable, and kokoro needs passwordless sudo
access to execute the test scripts. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/ubuntu1604/40_kokoro.sh",
"new_path": "kokoro/ubuntu1604/40_kokoro.sh",
"diff": "@@ -33,10 +33,15 @@ if useradd -c \"kbuilder user\" -m -s /bin/bash kbuilder; then\nchmod 0600 ~kbuilder/.ssh/authorized_keys\nfi\n+# Give passwordless sudo access.\n+cat >... | Go | Apache License 2.0 | google/gvisor | Fix kokoro image build scripts
The /tmpfs directory needs to be writable, and kokoro needs passwordless sudo
access to execute the test scripts.
PiperOrigin-RevId: 266063723 |
259,858 | 28.08.2019 22:34:45 | 25,200 | f048c8be1e7636df238e616b41a123ada2049759 | Fix permissions on .ssh files | [
{
"change_type": "MODIFY",
"old_path": "kokoro/ubuntu1604/40_kokoro.sh",
"new_path": "kokoro/ubuntu1604/40_kokoro.sh",
"diff": "@@ -31,6 +31,7 @@ if useradd -c \"kbuilder user\" -m -s /bin/bash kbuilder; then\nmkdir -p ~kbuilder/.ssh\n(IFS=$'\\n'; echo \"${ssh_public_keys[*]}\") > ~kbuilder/.ssh/aut... | Go | Apache License 2.0 | google/gvisor | Fix permissions on .ssh files
PiperOrigin-RevId: 266066839 |
259,891 | 26.08.2019 13:09:49 | 25,200 | 9e7378a377440fe2d33920e2cb20028c728886da | Add a shortlist of commonly request debugging tools. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -36,5 +36,20 @@ The following applications/images have been tested:\n* tomcat\n* wordpress\n+## Debugging tools\n+\n+Most common debugg... | Go | Apache License 2.0 | google/gvisor | Add a shortlist of commonly request debugging tools. |
259,891 | 26.08.2019 15:16:44 | 25,200 | 16582ade1743b2b4e93ebe90a5e46dd13a54b6f6 | Added gdb, lsof, ps, ss, and top. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -45,10 +45,15 @@ Most common debugging utilities work. Specific tools include:\n| curl | Working |\n| dig | Working |\n| drill | Workin... | Go | Apache License 2.0 | google/gvisor | Added gdb, lsof, ps, ss, and top. |
259,891 | 26.08.2019 15:33:29 | 25,200 | a89ee859b9b15cdfbfd1eb5219e97fc9884c92d2 | Added note about --net-raw. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -38,7 +38,9 @@ The following applications/images have been tested:\n## Debugging tools\n-Most common debugging utilities work. Specific... | Go | Apache License 2.0 | google/gvisor | Added note about --net-raw. |
259,891 | 26.08.2019 16:30:08 | 25,200 | 8e406b0bf96f2f8b39275d1d0b9a3283678c0755 | Added nc, ip, and sshd. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -48,12 +48,15 @@ old versions of ping, require excplicitly enabling raw sockets via the unsafe\n| dig | Working |\n| drill | Working |\... | Go | Apache License 2.0 | google/gvisor | Added nc, ip, and sshd. |
259,891 | 26.08.2019 16:32:00 | 25,200 | cc587e6039a3c6429d77e29ba8c8816583ef4c84 | ip route not quite submitted yet | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -48,7 +48,7 @@ old versions of ping, require excplicitly enabling raw sockets via the unsafe\n| dig | Working |\n| drill | Working |\n|... | Go | Apache License 2.0 | google/gvisor | ip route not quite submitted yet |
259,891 | 26.08.2019 16:33:28 | 25,200 | 6e350e809a8486e09eca9c9bae351270c8cfe907 | Added link for ss | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -55,7 +55,7 @@ old versions of ping, require excplicitly enabling raw sockets via the unsafe\n| nslookup | Working |\n| ping | Working ... | Go | Apache License 2.0 | google/gvisor | Added link for ss |
259,891 | 27.08.2019 10:14:25 | 25,200 | 942c740920785f70de2ab95efd249e2fd89acc43 | Added more tools. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -36,29 +36,47 @@ The following applications/images have been tested:\n* tomcat\n* wordpress\n-## Debugging tools\n+## Utilities\n-Most ... | Go | Apache License 2.0 | google/gvisor | Added more tools. |
259,891 | 27.08.2019 15:55:33 | 25,200 | e0ef639496db0205cec6752b482c30df0e64b80b | Added busybox note, changed route | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -38,9 +38,14 @@ The following applications/images have been tested:\n## Utilities\n-Most common utilities work. Note that some tools, s... | Go | Apache License 2.0 | google/gvisor | Added busybox note, changed route |
259,884 | 29.08.2019 11:14:56 | 25,200 | 5c09a0e59e9a2abcc266bd0903a3a54eee81ff66 | Add link to ip bug | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -63,7 +63,7 @@ Most common utilities work. Note that:\n| gosu | Working |\n| grep | Working (unless stdin is a pipe and stdout is /dev/... | Go | Apache License 2.0 | google/gvisor | Add link to ip bug |
259,885 | 29.08.2019 10:50:48 | 25,200 | 36a8949b2a52aabbe3f0548f1207c133da113c56 | Add limit_host_fd_translation Gofer mount option. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/inode_cached.go",
"new_path": "pkg/sentry/fs/fsutil/inode_cached.go",
"diff": "@@ -66,10 +66,8 @@ type CachingInodeOperations struct {\n// mfp is used to allocate memory that caches backingFile's contents.\nmfp pgalloc.MemoryFileProvider\n... | Go | Apache License 2.0 | google/gvisor | Add limit_host_fd_translation Gofer mount option.
PiperOrigin-RevId: 266177409 |
259,985 | 29.08.2019 14:31:44 | 25,200 | f74affe2035ba038674a0b958d8a31348fba15bc | Handle new representation of abstract UDS paths.
When abstract unix domain socket paths are displayed in
/proc/net/unix, Linux historically emitted null bytes as padding at
the end of the path. Newer versions of Linux (v4.9,
e7947ea770d0de434d38a0f823e660d3fd4bebb5) display these as '@'
characters.
Update proc_net_unix test to handle both version of the padding. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc_net_unix.cc",
"new_path": "test/syscalls/linux/proc_net_unix.cc",
"diff": "@@ -56,19 +56,44 @@ struct UnixEntry {\nstd::string path;\n};\n+// Abstract socket paths can have either trailing null bytes or '@'s as padding\n+// at the end,... | Go | Apache License 2.0 | google/gvisor | Handle new representation of abstract UDS paths.
When abstract unix domain socket paths are displayed in
/proc/net/unix, Linux historically emitted null bytes as padding at
the end of the path. Newer versions of Linux (v4.9,
e7947ea770d0de434d38a0f823e660d3fd4bebb5) display these as '@'
characters.
Update proc_net_unix test to handle both version of the padding.
PiperOrigin-RevId: 266230200 |
259,858 | 30.08.2019 15:01:55 | 25,200 | 888e87909e1a6c3cf93498e6ecb2d451c7551153 | Add C++ toolchain and fix compile issues.
This was accidentally introduced in
Fixes | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -32,6 +32,17 @@ load(\"@bazel_gazelle//:deps.bzl\", \"gazelle_dependencies\", \"go_repository\")\ngazelle_dependencies()\n+# Load C++ rules.\n+http_archive(\n+ name = \"rules_cc\",\n+ sha256 = \"67412176974bfce3... | Go | Apache License 2.0 | google/gvisor | Add C++ toolchain and fix compile issues.
This was accidentally introduced in 31f05d5d4f62c4cd4fe3b95b333d0130aae4b2c1.
Fixes #788.
PiperOrigin-RevId: 266462843 |
259,858 | 30.08.2019 15:26:26 | 25,200 | 3ec0b64d8c7d1649fd06291f3b5d0a3ca6db98d6 | Update image to install docker and fix permissions | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/ubuntu1604/25_docker.sh",
"diff": "+#!/bin/bash\n+\n+# Copyright 2019 The gVisor Authors.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# Y... | Go | Apache License 2.0 | google/gvisor | Update image to install docker and fix permissions
PiperOrigin-RevId: 266467361 |
259,992 | 30.08.2019 17:17:45 | 25,200 | 502c47f7a70a088213faf27b60e6f62ece4dd765 | Return correct buffer size for ioctl(socket, FIONREAD)
Ioctl was returning just the buffer size from epsocket.endpoint
and it was not considering data from epsocket.SocketOperations
that was read from the endpoint, but not yet sent to the caller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -2104,7 +2104,8 @@ func (s *SocketOperations) Ioctl(ctx context.Context, _ *fs.File, io usermem.IO,\n// SIOCGSTAMP is implemented by epsocket rather than... | Go | Apache License 2.0 | google/gvisor | Return correct buffer size for ioctl(socket, FIONREAD)
Ioctl was returning just the buffer size from epsocket.endpoint
and it was not considering data from epsocket.SocketOperations
that was read from the endpoint, but not yet sent to the caller.
PiperOrigin-RevId: 266485461 |
260,006 | 30.08.2019 17:18:05 | 25,200 | afbdf2f212739880e70a5450a9292e3265caecba | Fix data race accessing referencedNetworkEndpoint.kind
Wrapping "kind" into atomic access functions.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -139,7 +139,7 @@ func (n *NIC) getMainNICAddress(protocol tcpip.NetworkProtocolNumber) (tcpip.Add\nif list, ok := n.primary[protocol]; ok {\nfor e := list.Front(); e != nil; e = e.Next(... | Go | Apache License 2.0 | google/gvisor | Fix data race accessing referencedNetworkEndpoint.kind
Wrapping "kind" into atomic access functions.
Fixes #789
PiperOrigin-RevId: 266485501 |
259,885 | 30.08.2019 18:09:25 | 25,200 | f3dabdfc486874edc986ff63abe74ec1c85e18e1 | Fix async-signal-unsafety in MlockallTest_Future. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mlock.cc",
"new_path": "test/syscalls/linux/mlock.cc",
"diff": "@@ -169,26 +169,24 @@ TEST(MlockallTest, Future) {\n// Run this test in a separate (single-threaded) subprocess to ensure that a\n// background thread doesn't try to mmap a lar... | Go | Apache License 2.0 | google/gvisor | Fix async-signal-unsafety in MlockallTest_Future.
PiperOrigin-RevId: 266491246 |
259,885 | 30.08.2019 19:05:30 | 25,200 | 0352cf5866ddb5eea24fa35c69e2e43038cfb60a | Remove support for non-incremental mapped accounting. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/inode_cached.go",
"new_path": "pkg/sentry/fs/fsutil/inode_cached.go",
"diff": "@@ -796,11 +796,6 @@ func (c *CachingInodeOperations) AddMapping(ctx context.Context, ms memmap.Mappi\nmf.MarkUnevictable(c, pgalloc.EvictableRange{r.Start, r.E... | Go | Apache License 2.0 | google/gvisor | Remove support for non-incremental mapped accounting.
PiperOrigin-RevId: 266496644 |
259,885 | 03.09.2019 15:09:34 | 25,200 | eb94066ef26fc95d6b645124642b4f1248ad5e11 | Ensure that flipcall.Endpoint.Shutdown() shuts down inactive peers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/flipcall/ctrl_futex.go",
"new_path": "pkg/flipcall/ctrl_futex.go",
"diff": "@@ -121,7 +121,16 @@ func (ep *Endpoint) enterFutexWait() error {\n}\nfunc (ep *Endpoint) exitFutexWait() {\n- atomic.AddInt32(&ep.ctrl.state, -epsBlocked)\n+ switch eps := atomic.... | Go | Apache License 2.0 | google/gvisor | Ensure that flipcall.Endpoint.Shutdown() shuts down inactive peers.
PiperOrigin-RevId: 267022978 |
260,004 | 03.09.2019 18:41:40 | 25,200 | 144127e5e1c548150f49501a7decb82ec2e239f2 | Validate IPv6 Hop Limit field for received NDP packets
Make sure that NDP packets are only received if their IP header's hop limit
field is set to 255, as per RFC 4861. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/BUILD",
"new_path": "pkg/tcpip/network/ipv6/BUILD",
"diff": "@@ -23,7 +23,10 @@ go_library(\ngo_test(\nname = \"ipv6_test\",\nsize = \"small\",\n- srcs = [\"icmp_test.go\"],\n+ srcs = [\n+ \"icmp_test.go\",\n+ \"ndp_test.go\",\n+ ],\nemb... | Go | Apache License 2.0 | google/gvisor | Validate IPv6 Hop Limit field for received NDP packets
Make sure that NDP packets are only received if their IP header's hop limit
field is set to 255, as per RFC 4861.
PiperOrigin-RevId: 267061457 |
260,006 | 04.09.2019 14:18:02 | 25,200 | 7bf1d426d5f8ba5a3ddfc8f0cd73cc12e8a83c16 | Handle subnet and broadcast addresses correctly with NIC.subnets
This also renames "subnet" to "addressRange" to avoid any more confusion with
an interface IP's subnet.
Lastly, this also removes the Stack.ContainsSubnet(..) API since it isn't used
by anyone. Plus the same information can be obtained from
Stack.NICAddressRanges(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -41,7 +41,7 @@ type NIC struct {\npromiscuous bool\nprimary map[tcpip.NetworkProtocolNumber]*ilist.List\nendpoints map[NetworkEndpointID]*referencedNetworkEndpoint\n- subnets []tcpip.Su... | Go | Apache License 2.0 | google/gvisor | Handle subnet and broadcast addresses correctly with NIC.subnets
This also renames "subnet" to "addressRange" to avoid any more confusion with
an interface IP's subnet.
Lastly, this also removes the Stack.ContainsSubnet(..) API since it isn't used
by anyone. Plus the same information can be obtained from
Stack.NICAddressRanges().
PiperOrigin-RevId: 267229843 |
259,858 | 04.09.2019 18:47:47 | 25,200 | bcddd0a4778916f6a5347246a81fbe236050d2c4 | Fix continuous build breakage | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "@@ -20,7 +20,7 @@ source $(dirname $0)/common.sh\nrunsc=$(build -c opt //runsc)\n# Build packages.\n-pkg=$(build -c opt --host_force_python=py2 //runsc:debian)\n+pkg=$(build -c opt --host_force_python... | Go | Apache License 2.0 | google/gvisor | Fix continuous build breakage
PiperOrigin-RevId: 267277711 |
259,992 | 04.09.2019 18:55:39 | 25,200 | 0f5cdc1e00488823f1f7b9884c15b899677362b6 | Resolve flakes with TestMultiContainerDestroy
Some processes are reparented to the root container depending
on the kill order and the root container would not reap in time.
So some zombie processes were still present when the test checked.
Fix it by running the second container inside a PID namespace. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -760,12 +760,11 @@ func (l *Loader) destroyContainer(cid string) error {\nif err := l.signalAllProcesses(cid, int32(linux.SIGKILL)); err != nil {\nreturn fmt.Errorf(\"sending SIGKILL to all... | Go | Apache License 2.0 | google/gvisor | Resolve flakes with TestMultiContainerDestroy
Some processes are reparented to the root container depending
on the kill order and the root container would not reap in time.
So some zombie processes were still present when the test checked.
Fix it by running the second container inside a PID namespace.
PiperOrigin-RevId: 267278591 |
259,854 | 04.09.2019 19:06:44 | 25,200 | fbbb2f7ed6a2f735c8e8d48e8b5264d2057e93ad | Run proc_net tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -305,6 +305,8 @@ syscall_test(\nsyscall_test(test = \"//test/syscalls/linux:proc_pid_uid_gid_map_test\")\n+syscall_test(test = \"//test/syscalls/linux:proc_net_test\")\n+\nsyscall_test(\nsize... | Go | Apache License 2.0 | google/gvisor | Run proc_net tests.
PiperOrigin-RevId: 267280086 |
259,858 | 04.09.2019 22:24:42 | 25,200 | 91518fd553b828ce9f3fa84d91f20a45a8f0c81d | Fix build when no tags are present
This should correct the continuous build. | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "@@ -49,7 +49,7 @@ if [[ -v KOKORO_ARTIFACTS_DIR ]]; then\n# Is it a tagged release? Build that instead. In that case, we also try to\n# update the base release directory, in case this is an update. Fi... | Go | Apache License 2.0 | google/gvisor | Fix build when no tags are present
This should correct the continuous build. |
259,884 | 04.09.2019 23:19:09 | 25,200 | e31686500db56a5fcd4070561643d702a94da0c3 | Allow non-unique group IDs in bazel docker containers
Allow non-unique group IDs in the bazel docker container in order to avoid
failures using host group IDs that are already present in the image.
Issue | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -22,7 +22,7 @@ bazel-server-start: docker-build\n--privileged \\\ngvisor-bazel \\\nsh -c \"while :; do sleep 100; done\" && \\\n- docker exec --user 0:0 -i gvisor-bazel sh -c \"groupadd --gid $(GID) gvisor && user... | Go | Apache License 2.0 | google/gvisor | Allow non-unique group IDs in bazel docker containers
Allow non-unique group IDs in the bazel docker container in order to avoid
failures using host group IDs that are already present in the image.
Issue #801
PiperOrigin-RevId: 267306089 |
259,993 | 05.09.2019 07:16:36 | 14,400 | 4573efe84b2d52112a9370dd5a469e9d11959ab4 | Switch from net to unet to open Unix Domain Sockets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/fd/BUILD",
"new_path": "pkg/fd/BUILD",
"diff": "@@ -7,6 +7,9 @@ go_library(\nsrcs = [\"fd.go\"],\nimportpath = \"gvisor.dev/gvisor/pkg/fd\",\nvisibility = [\"//visibility:public\"],\n+ deps = [\n+ \"//pkg/unet\",\n+ ],\n)\ngo_test(\n"
},
{
"change_... | Go | Apache License 2.0 | google/gvisor | Switch from net to unet to open Unix Domain Sockets. |
259,993 | 05.09.2019 15:26:16 | 14,400 | 4288a578832eae652f73ae411ece2d4b6590062e | Remove seccomp permissions, and clean up the Attach logic. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/config.go",
"new_path": "runsc/fsgofer/filter/config.go",
"diff": "@@ -36,23 +36,6 @@ var allowedSyscalls = seccomp.SyscallRules{\nseccomp.AllowAny{},\n},\n},\n- syscall.SYS_SETSOCKOPT: []seccomp.Rule{\n- {\n- seccomp.AllowAny{},\n- seccom... | Go | Apache License 2.0 | google/gvisor | Remove seccomp permissions, and clean up the Attach logic. |
259,858 | 05.09.2019 16:37:06 | 25,200 | 1a0a940587e4db8923ca81b78d7bba395eb56ce1 | Fix repository build scripts
This has the following fixes:
* Packages are passed to the tools/make_repository.sh command.
* All matching tags are built, for commits with multiple.
* The binary path is generated by the build command.
* Output from signing the repository is supressed.
* Allow a release author. | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "@@ -24,16 +24,17 @@ pkg=$(build -c opt --host_force_python=py2 //runsc:runsc-debian)\n# Build a repository, if the key is available.\nif [[ -v KOKORO_REPO_KEY ]]; then\n- repo=$(tools/make_repository.... | Go | Apache License 2.0 | google/gvisor | Fix repository build scripts
This has the following fixes:
* Packages are passed to the tools/make_repository.sh command.
* All matching tags are built, for commits with multiple.
* The binary path is generated by the build command.
* Output from signing the repository is supressed.
* Allow a release author.
Change-Id: I2d08954ba76e35612f352be99d5bb99080f80892 |
259,992 | 05.09.2019 11:13:59 | 25,200 | cac17854648c71d00e8067314fd144525964dd53 | Add that Docker user defined network doesn't work to the FAQ | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/FAQ.md",
"new_path": "content/docs/user_guide/FAQ.md",
"diff": "@@ -27,6 +27,14 @@ Binaries run in gVisor should be built for the\nYes. Please see the [Docker Quick Start](/docs/user_guide/docker/).\n+### Can I run Kubernets pods using ... | Go | Apache License 2.0 | google/gvisor | Add that Docker user defined network doesn't work to the FAQ |
259,884 | 10.09.2019 07:09:08 | 0 | b9b719dcb6acde3b58e983b27bf34ad591bae16b | Add note about some days not having releases
Issue | [
{
"change_type": "MODIFY",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": "content/docs/includes/install_gvisor.md",
"diff": "@@ -2,10 +2,13 @@ The easiest way to get `runsc` is from the [latest nightly\nbuild][latest-nightly]. After you download the binary, check it against the\... | Go | Apache License 2.0 | google/gvisor | Add note about some days not having releases
Issue #107 |
259,884 | 11.09.2019 00:07:25 | 25,200 | d24be656c9321de8b65e9d21c41f756056847eb1 | Update required Bazel version in README. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -48,7 +48,7 @@ Make sure the following dependencies are installed:\n* Linux 4.14.77+ ([older linux][old-linux])\n* [git][git]\n-* [Bazel][bazel] 0.23.0+\n+* [Bazel][bazel] 0.28.0+\n* [Python][python]\n* [Docker ... | Go | Apache License 2.0 | google/gvisor | Update required Bazel version in README.
PiperOrigin-RevId: 268397389 |
259,858 | 11.09.2019 18:48:26 | 25,200 | c06ef5131f1ccd3106ccf4fa4e787db079db2d96 | Fix authorization for continuous integration.
The credentials must be explicitly refreshed for pushing to
the repository on the Go branch. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/go.cfg",
"new_path": "kokoro/go.cfg",
"diff": "build_file: \"repo/scripts/go.sh\"\n+before_action {\n+ fetch_keystore {\n+ keystore_resource {\n+ keystore_config_id: 73898\n+ keyname: \"kokoro-github-access-token\"\n+ }\n+ }\n+}\n+\n+env_vars {\n+ key: ... | Go | Apache License 2.0 | google/gvisor | Fix authorization for continuous integration.
The credentials must be explicitly refreshed for pushing to
the repository on the Go branch.
PiperOrigin-RevId: 268589817 |
259,858 | 11.09.2019 21:03:12 | 25,200 | 1e6bdd58551246f6ae662a20b733a9c9dd5ef225 | Update key environment variables. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/build.cfg",
"new_path": "kokoro/build.cfg",
"diff": "@@ -11,7 +11,7 @@ before_action {\nenv_vars {\nkey: \"KOKORO_REPO_KEY\"\n- value: \"$KOKORO_ROOT/src/keystore/73898_kokoro-repo-key\"\n+ value: \"73898_kokoro-repo-key\"\n}\naction {\n"
},
{
"... | Go | Apache License 2.0 | google/gvisor | Update key environment variables.
PiperOrigin-RevId: 268604220 |
259,858 | 11.09.2019 21:49:18 | 25,200 | 96a25e080c2b2e10e0d92b544f5830f85f8540e0 | Ensure appropriate tools are installed on image. | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "source $(dirname $0)/common.sh\n+# Install required packages for make_repository.sh et al.\n+sudo apt-get update && sudo apt-get install -y dpkg-sig coreutils gpg apt-utils\n+\n# Build runsc.\nrunsc=$... | Go | Apache License 2.0 | google/gvisor | Ensure appropriate tools are installed on image.
PiperOrigin-RevId: 268608466 |
259,858 | 11.09.2019 22:29:07 | 25,200 | 69f2c41b7acc4b72df9fe5fad984e05f78bfe6cd | Drop unavailable package. | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "source $(dirname $0)/common.sh\n# Install required packages for make_repository.sh et al.\n-sudo apt-get update && sudo apt-get install -y dpkg-sig coreutils gpg apt-utils\n+sudo apt-get update && sud... | Go | Apache License 2.0 | google/gvisor | Drop unavailable package.
PiperOrigin-RevId: 268614014 |
259,858 | 12.09.2019 13:43:07 | 25,200 | 574eda88808138b2dd72ebe6bbca80a09a13c7fb | Update repository directory structure.
Currently it will not work with apt out of the box, as we
require the dists/ prefix, along with a distribution name.
This tweaks the overall structure to allow for the same URL
prefix to be used for all repositories, and enables multiple
architectures.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "@@ -32,12 +32,14 @@ fi\n# Install installs artifacts.\ninstall() {\n- local dir=\"$1\"\n- mkdir -p \"${dir}\"\n- cp -f \"${runsc}\" \"${dir}\"/runsc\n- sha512sum \"${dir}\"/runsc | awk '{print $1 \" r... | Go | Apache License 2.0 | google/gvisor | Update repository directory structure.
Currently it will not work with apt out of the box, as we
require the dists/ prefix, along with a distribution name.
This tweaks the overall structure to allow for the same URL
prefix to be used for all repositories, and enables multiple
architectures.
Fixes #852
PiperOrigin-RevId: 268756104 |
259,858 | 13.09.2019 11:38:40 | 25,200 | 2bbf73d9ed85bbff81f1e56a6753dfe402682459 | Remove stale configurations. | [
{
"change_type": "DELETE",
"old_path": "cloudbuild/go.Dockerfile",
"new_path": null,
"diff": "-FROM ubuntu\n-RUN apt-get -q update && apt-get install -qqy git rsync\n"
},
{
"change_type": "DELETE",
"old_path": "cloudbuild/go.yaml",
"new_path": null,
"diff": "-steps:\n-- name: 'gc... | Go | Apache License 2.0 | google/gvisor | Remove stale configurations.
PiperOrigin-RevId: 268947847 |
259,853 | 13.09.2019 21:43:12 | 25,200 | 239a07aabfad8991556b43c85c30270d09353f86 | gvisor: return ENOTDIR from the unlink syscall
ENOTDIR has to be returned when a component used as a directory in
pathname is not, in fact, a directory. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -1126,7 +1126,7 @@ func (d *Dirent) unmount(ctx context.Context, replacement *Dirent) error {\n// Remove removes the given file or symlink. The root dirent is used to\n// resolve name... | Go | Apache License 2.0 | google/gvisor | gvisor: return ENOTDIR from the unlink syscall
ENOTDIR has to be returned when a component used as a directory in
pathname is not, in fact, a directory.
PiperOrigin-RevId: 269037893 |
259,854 | 17.09.2019 11:29:03 | 25,200 | 747320a7aa013f6b987f8f52173f51ff3aedb66c | Update remaining users of LinkEndpoints to not refer to them as an ID. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/sample/tun_tcp_connect/main.go",
"new_path": "pkg/tcpip/sample/tun_tcp_connect/main.go",
"diff": "@@ -138,11 +138,11 @@ func main() {\nlog.Fatal(err)\n}\n- linkID, err := fdbased.New(&fdbased.Options{FDs: []int{fd}, MTU: mtu})\n+ linkEP, err := fdbas... | Go | Apache License 2.0 | google/gvisor | Update remaining users of LinkEndpoints to not refer to them as an ID.
PiperOrigin-RevId: 269614517 |
259,853 | 17.09.2019 12:44:05 | 25,200 | 3b7119a7c91789f69d8637401a1359229a33b213 | platform/ptrace: log exit code for stub processes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/ptrace_unsafe.go",
"new_path": "pkg/sentry/platform/ptrace/ptrace_unsafe.go",
"diff": "@@ -154,3 +154,19 @@ func (t *thread) clone() (*thread, error) {\ncpu: ^uint32(0),\n}, nil\n}\n+\n+// getEventMessage retrieves a message about th... | Go | Apache License 2.0 | google/gvisor | platform/ptrace: log exit code for stub processes
PiperOrigin-RevId: 269631877 |
259,853 | 17.09.2019 17:24:39 | 25,200 | b63d56b0b4430de7273e3b759667a823927c0473 | scripts/build.sh: fix kokoro failure "KOKORO_BUILD_NIGHTLY: unbound variable" | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "@@ -47,7 +47,7 @@ install() {\n# current date. If the current commit happens to correpond to a tag, then we\n# will also move everything into a directory named after the given tag.\nif [[ -v KOKORO_AR... | Go | Apache License 2.0 | google/gvisor | scripts/build.sh: fix kokoro failure "KOKORO_BUILD_NIGHTLY: unbound variable"
PiperOrigin-RevId: 269690988 |
259,858 | 18.09.2019 14:55:55 | 25,200 | 461123ea3510a401423181e8ea8f2cae27fcbc8f | Move the component into the repository structure.
The RELEASE file must be at the top-level for the signed
repository to work correctly. | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "@@ -27,7 +27,7 @@ pkg=$(build -c opt --host_force_python=py2 //runsc:runsc-debian)\n# Build a repository, if the key is available.\nif [[ -v KOKORO_REPO_KEY ]]; then\n- repo=$(tools/make_repository.sh... | Go | Apache License 2.0 | google/gvisor | Move the component into the repository structure.
The RELEASE file must be at the top-level for the signed
repository to work correctly.
PiperOrigin-RevId: 269897109 |
259,974 | 17.09.2019 08:27:01 | 0 | cabe10e603f36d610b7d3858c0911fc2dde26411 | Enable pkg/sentry/hostcpu support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/hostcpu/BUILD",
"new_path": "pkg/sentry/hostcpu/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nname = \"hostcpu\",\nsrcs = [\n\"getcpu_amd64.s\",\n+ \"getcpu_arm64.s\",\n\"hostcpu.go\",\n],\nimportpath = \"gvisor.dev/gvisor/pkg/sentry/hostcpu\",\n"
... | Go | Apache License 2.0 | google/gvisor | Enable pkg/sentry/hostcpu support on arm64.
Signed-off-by: Haibo Xu haibo.xu@arm.com
Change-Id: I333872da9bdf56ddfa8ab2f034dfc1f36a7d3132 |
259,993 | 19.09.2019 12:37:15 | 14,400 | ac38a7ead0870118d27d570a8a98a90a7a225a12 | Place the host UDS mounting behind --fsgofer-host-uds-allowed.
This commit allows the use of the `--fsgofer-host-uds-allowed` flag to
enable mounting sockets and add the appropriate seccomp filters. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -138,6 +138,9 @@ type Config struct {\n// Overlay is whether to wrap the root filesystem in an overlay.\nOverlay bool\n+ // fsGoferHostUDSAllowed enables the gofer to mount a host UDS\n+ FS... | Go | Apache License 2.0 | google/gvisor | Place the host UDS mounting behind --fsgofer-host-uds-allowed.
This commit allows the use of the `--fsgofer-host-uds-allowed` flag to
enable mounting sockets and add the appropriate seccomp filters. |
259,858 | 19.09.2019 13:38:14 | 25,200 | 75781ab3efa7b377c6dc4cf26840323f504d5eb5 | Remove defer from hot path and ensure Atomic is applied consistently. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -415,13 +415,13 @@ func (s *SocketOperations) Read(ctx context.Context, _ *fs.File, dst usermem.IOS\n// WriteTo implements fs.FileOperations.WriteTo.\nfu... | Go | Apache License 2.0 | google/gvisor | Remove defer from hot path and ensure Atomic is applied consistently.
PiperOrigin-RevId: 270114317 |
259,993 | 19.09.2019 17:10:50 | 14,400 | 46beb919121f02d8bd110a54fb8f6de5dfd2891e | Fix documentation, clean up seccomp filter installation, rename helpers.
Filter installation has been streamlined and functions renamed.
Documentation has been fixed to be standards compliant, and missing
documentation added. gofmt has also been applied to modified files. | [
{
"change_type": "MODIFY",
"old_path": "pkg/fd/fd.go",
"new_path": "pkg/fd/fd.go",
"diff": "@@ -17,12 +17,12 @@ package fd\nimport (\n\"fmt\"\n+ \"gvisor.dev/gvisor/pkg/unet\"\n\"io\"\n\"os\"\n\"runtime\"\n\"sync/atomic\"\n\"syscall\"\n- \"gvisor.dev/gvisor/pkg/unet\"\n)\n// ReadWriter implements io... | Go | Apache License 2.0 | google/gvisor | Fix documentation, clean up seccomp filter installation, rename helpers.
Filter installation has been streamlined and functions renamed.
Documentation has been fixed to be standards compliant, and missing
documentation added. gofmt has also been applied to modified files. |
259,993 | 19.09.2019 17:44:46 | 14,400 | e975184bc50944e82a6bf5f4c57bbe970933fdc5 | Update InstallUDSFilters documentation to be accurate to functionality. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/filter.go",
"new_path": "runsc/fsgofer/filter/filter.go",
"diff": "@@ -30,8 +30,8 @@ func Install() error {\nreturn seccomp.Install(allowedSyscalls)\n}\n-// InstallUDSFilters installs the seccomp filters required to let the gofer connect\n... | Go | Apache License 2.0 | google/gvisor | Update InstallUDSFilters documentation to be accurate to functionality. |
259,883 | 05.09.2019 15:03:41 | -28,800 | 329b6653ffbb29b47409a923a7fbb3bd3aff074f | Implement /proc/net/tcp6
Fixes: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -66,7 +66,7 @@ func (p *proc) newNetDir(ctx context.Context, k *kernel.Kernel, msrc *fs.MountSo\nif s.SupportsIPv6() {\ncontents[\"if_inet6\"] = seqfile.NewSeqFileInode(ctx, &ifin... | Go | Apache License 2.0 | google/gvisor | Implement /proc/net/tcp6
Fixes: #829
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com>
Signed-off-by: Jielong Zhou <jielong.zjl@antfin.com> |
259,854 | 20.09.2019 14:08:46 | 25,200 | 002f1d4aaefa9abdd50e3e8906ae828c31d038e6 | Allow waiting for LinkEndpoint worker goroutines to finish.
Previously, the only safe way to use an fdbased endpoint was to leak the FD.
This change makes it possible to safely close the FD.
This is the first step towards having stoppable stacks.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/channel/channel.go",
"new_path": "pkg/tcpip/link/channel/channel.go",
"diff": "@@ -133,3 +133,6 @@ func (e *Endpoint) WritePacket(_ *stack.Route, gso *stack.GSO, hdr buffer.Prepen\nreturn nil\n}\n+\n+// Wait implements stack.LinkEndpoint.Wait.\n... | Go | Apache License 2.0 | google/gvisor | Allow waiting for LinkEndpoint worker goroutines to finish.
Previously, the only safe way to use an fdbased endpoint was to leak the FD.
This change makes it possible to safely close the FD.
This is the first step towards having stoppable stacks.
Updates #837
PiperOrigin-RevId: 270346582 |
259,885 | 20.09.2019 14:23:20 | 25,200 | fb55c2bd0d5d80b240184f643967f214d3dbc259 | Change vfs.Dirent.Off to NextOff.
"d_off is the distance from the start of the directory to the start of the next
linux_dirent." - getdents(2). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/directory.go",
"new_path": "pkg/sentry/fsimpl/ext/directory.go",
"diff": "@@ -193,7 +193,7 @@ func (fd *directoryFD) IterDirents(ctx context.Context, cb vfs.IterDirentsCallba\nName: child.diskDirent.FileName(),\nType: fs.ToDirentType(chil... | Go | Apache License 2.0 | google/gvisor | Change vfs.Dirent.Off to NextOff.
"d_off is the distance from the start of the directory to the start of the next
linux_dirent." - getdents(2).
PiperOrigin-RevId: 270349685 |
259,962 | 23.09.2019 15:59:23 | 25,200 | 9846da5e654fc5649269e4a45fa711d4519c343e | Fix bug in RstCausesPollHUP.
The test is checking the wrong poll_fd for POLLHUP. The only
reason it passed till now was because it was also checking
for POLLIN which was always true on the other fd from the
previous poll! | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"new_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"diff": "@@ -117,7 +117,7 @@ TEST_P(TCPSocketPairTest, RSTCausesPollHUP) {\nstruct pollfd poll_fd3 = {sockets->first_fd(), POLLHUP, 0};\nASSERT_THAT(Retr... | Go | Apache License 2.0 | google/gvisor | Fix bug in RstCausesPollHUP.
The test is checking the wrong poll_fd for POLLHUP. The only
reason it passed till now was because it was also checking
for POLLIN which was always true on the other fd from the
previous poll!
PiperOrigin-RevId: 270780401 |
259,992 | 06.09.2019 16:41:23 | 25,200 | 0261626482865a7445e0b536feefd5ee3355a0da | Add GKE Sandbox to Kubernetes section | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "content/docs/tutorials/_index.md",
"diff": "++++\n+title = \"Tutorials\"\n+weight = 0\n++++\n"
},
{
"change_type": "ADD",
"old_path": "content/docs/tutorials/add-node-pool.png",
"new_path": "content/docs/tutorials/add-node-pool.p... | Go | Apache License 2.0 | google/gvisor | Add GKE Sandbox to Kubernetes section |
259,858 | 23.09.2019 16:43:09 | 25,200 | 6c88f674afb6065995d5758eb8cf288578d21c3d | Add test for concurrent reads and writes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/p9test/client_test.go",
"new_path": "pkg/p9/p9test/client_test.go",
"diff": "@@ -2127,3 +2127,98 @@ func TestConcurrency(t *testing.T) {\n}\n}\n}\n+\n+func TestReadWriteConcurrent(t *testing.T) {\n+ h, c := NewHarness(t)\n+ defer h.Finish()\n+\n+ _, roo... | Go | Apache License 2.0 | google/gvisor | Add test for concurrent reads and writes.
PiperOrigin-RevId: 270789146 |
259,974 | 22.08.2019 09:01:47 | 0 | 2db866c45f44f302d666172aceaad92901db14af | Enable pkg/sleep support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sleep/BUILD",
"new_path": "pkg/sleep/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nname = \"sleep\",\nsrcs = [\n\"commit_amd64.s\",\n+ \"commit_arm64.s\",\n\"commit_asm.go\",\n\"commit_noasm.go\",\n\"sleep_unsafe.go\",\n"
},
{
"change_type": "MODIF... | Go | Apache License 2.0 | google/gvisor | Enable pkg/sleep support on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I9071e698c1f222e0fdf3b567ec4cbd97f0a8dde9 |
259,974 | 20.08.2019 09:44:05 | 0 | a26276b9498843218ee78c956c478ceebb819ad8 | Enable pkg/bits support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/bits/BUILD",
"new_path": "pkg/bits/BUILD",
"diff": "@@ -11,8 +11,9 @@ go_library(\n\"bits.go\",\n\"bits32.go\",\n\"bits64.go\",\n- \"uint64_arch_amd64.go\",\n+ \"uint64_arch.go\",\n\"uint64_arch_amd64_asm.s\",\n+ \"uint64_arch_arm64_asm.s\",\n\"uint64_arch... | Go | Apache License 2.0 | google/gvisor | Enable pkg/bits support on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I490716f0e6204f0b3a43f71931b10d1ca541e128 |
259,858 | 24.09.2019 13:25:25 | 25,200 | 502f8f238ea58c4828e528e563d8dbd419faeea7 | Stub out readahead implementation.
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64.go",
"diff": "@@ -232,7 +232,7 @@ var AMD64 = &kernel.SyscallTable{\n184: syscalls.Error(\"tuxcall\", syserror.ENOSYS, \"Not implemented in Linux.\", nil),\n185: syscalls.Err... | Go | Apache License 2.0 | google/gvisor | Stub out readahead implementation.
Closes #261
PiperOrigin-RevId: 270973347 |
259,993 | 24.09.2019 18:24:10 | 14,400 | 7810b30983ec4d3a706df01163c29814cd21d6ca | Refactor command line options and remove the allowed terminology for uds | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -138,8 +138,8 @@ type Config struct {\n// Overlay is whether to wrap the root filesystem in an overlay.\nOverlay bool\n- // FSGoferHostUDSAllowed enables the gofer to mount a host UDS.\n- F... | Go | Apache License 2.0 | google/gvisor | Refactor command line options and remove the allowed terminology for uds |
259,993 | 24.09.2019 18:37:25 | 14,400 | 9ebd498a55fa87129cdc60cdc3bca66f26c49454 | Remove unecessary seccomp permission.
This removes the F_DUPFD_CLOEXEC support for the gofer, previously
required when depending on the STL net package. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/config.go",
"new_path": "runsc/fsgofer/filter/config.go",
"diff": "@@ -83,10 +83,6 @@ var allowedSyscalls = seccomp.SyscallRules{\nseccomp.AllowAny{},\nseccomp.AllowValue(syscall.F_GETFD),\n},\n- {\n- seccomp.AllowAny{},\n- seccomp.AllowVa... | Go | Apache License 2.0 | google/gvisor | Remove unecessary seccomp permission.
This removes the F_DUPFD_CLOEXEC support for the gofer, previously
required when depending on the STL net package. |
259,853 | 24.09.2019 19:03:26 | 25,200 | 2fb34c8d5ccf13388371437d128cc95d577fbc8a | test: don't use designated initializers
This change fixes compile errors:
pty.cc:1460:7: error: expected primary-expression before '.' token
... | [
{
"change_type": "MODIFY",
"old_path": "scripts/make_tests.sh",
"new_path": "scripts/make_tests.sh",
"diff": "@@ -21,4 +21,5 @@ top_level=$(git rev-parse --show-toplevel 2>/dev/null)\nmake\nmake runsc\n+make BAZEL_OPTIONS=\"build //...\" bazel\nmake bazel-shutdown\n"
},
{
"change_type": "MOD... | Go | Apache License 2.0 | google/gvisor | test: don't use designated initializers
This change fixes compile errors:
pty.cc:1460:7: error: expected primary-expression before '.' token
...
PiperOrigin-RevId: 271033729 |
259,992 | 25.09.2019 14:31:40 | 25,200 | 129c67d68ee2db4aa3a45ab6970e7d26348ce5ef | Fix runsc log collection in kokoro | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -352,7 +352,7 @@ func (s *Sandbox) createSandboxProcess(conf *boot.Config, args *Args, startSyncF\n}\nif conf.DebugLog != \"\" {\ntest := \"\"\n- if len(conf.TestOnlyTestNameEnv) ==... | Go | Apache License 2.0 | google/gvisor | Fix runsc log collection in kokoro
PiperOrigin-RevId: 271207152 |
259,853 | 26.09.2019 14:35:57 | 25,200 | 3221e8372cbd41bbe74d0bef82519de6e2852e13 | kokoro: don't force to use python2
was fixed
and we don't need this hack anymore. | [
{
"change_type": "MODIFY",
"old_path": "scripts/build.sh",
"new_path": "scripts/build.sh",
"diff": "@@ -23,7 +23,7 @@ sudo apt-get update && sudo apt-get install -y dpkg-sig coreutils apt-utils\nrunsc=$(build -c opt //runsc)\n# Build packages.\n-pkg=$(build -c opt --host_force_python=py2 //runsc:run... | Go | Apache License 2.0 | google/gvisor | kokoro: don't force to use python2
https://github.com/bazelbuild/bazel/issues/7899 was fixed
and we don't need this hack anymore.
PiperOrigin-RevId: 271434565 |
259,891 | 26.09.2019 15:07:59 | 25,200 | 543492650dd528c1d837d788dcd3b5138e8dc1c0 | Make raw socket tests pass in environments with or without CAP_NET_RAW. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/provider.go",
"new_path": "pkg/sentry/socket/epsocket/provider.go",
"diff": "@@ -65,7 +65,7 @@ func getTransportProtocol(ctx context.Context, stype linux.SockType, protocol in\n// Raw sockets require CAP_NET_RAW.\ncreds := auth.Crede... | Go | Apache License 2.0 | google/gvisor | Make raw socket tests pass in environments with or without CAP_NET_RAW.
PiperOrigin-RevId: 271442321 |
259,992 | 26.09.2019 18:14:45 | 25,200 | 8337e4f50955863c6aa3a7df70b1446b9dba66ae | Disallow opening of sockets if --fsgofer-host-uds=false
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -136,6 +136,10 @@ func (a *attachPoint) Attach() (p9.File, error) {\na.attachedMu.Lock()\ndefer a.attachedMu.Unlock()\n+ if a.attached {\n+ return nil, fmt.Errorf(\"attach point alr... | Go | Apache License 2.0 | google/gvisor | Disallow opening of sockets if --fsgofer-host-uds=false
Updates #235
PiperOrigin-RevId: 271475319 |
259,853 | 27.09.2019 09:48:46 | 25,200 | fa15fda6c4ea2f4f10ec0c60ccc5af3f66ed87c4 | bazel: use rules_pkg from
BUILD:85:1: in _pkg_deb rule //runsc:runsc-debian: target
'//runsc:runsc-debian' depends on deprecated target
'@bazel_tools//tools/build_defs/pkg:make_deb': The internal version of
make_deb is deprecated. Please use the replacement for pkg_deb from | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -75,6 +75,16 @@ load(\"@bazel_toolchains//rules:rbe_repo.bzl\", \"rbe_autoconfig\")\nrbe_autoconfig(name = \"rbe_default\")\n+http_archive(\n+ name = \"rules_pkg\",\n+ sha256 = \"5bdc04987af79bd27bc5b00fe30f59a8... | Go | Apache License 2.0 | google/gvisor | bazel: use rules_pkg from https://github.com/bazelbuild/
BUILD:85:1: in _pkg_deb rule //runsc:runsc-debian: target
'//runsc:runsc-debian' depends on deprecated target
'@bazel_tools//tools/build_defs/pkg:make_deb': The internal version of
make_deb is deprecated. Please use the replacement for pkg_deb from
https://github.com/bazelbuild/rules_pkg/blob/master/pkg.
PiperOrigin-RevId: 271590386 |
259,881 | 30.09.2019 10:02:14 | 25,200 | 981fc188f0f0250ad59e39d566a56c71430b3287 | Only copy out remaining time on nanosleep success
It looks like the old code attempted to do this, but didn't realize that err !=
nil even in the happy case. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_time.go",
"new_path": "pkg/sentry/syscalls/linux/sys_time.go",
"diff": "package linux\nimport (\n+ \"fmt\"\n\"time\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -228,41 +229,35 @@ func clockNanosleepFor(t *kernel.Task, c ktime.Clock,... | Go | Apache License 2.0 | google/gvisor | Only copy out remaining time on nanosleep success
It looks like the old code attempted to do this, but didn't realize that err !=
nil even in the happy case.
PiperOrigin-RevId: 272005887 |
259,891 | 30.09.2019 13:57:15 | 25,200 | c06cca66780baf81422e56badee2abaf28f017c7 | De-flake SetForegroundProcessGroupDifferentSession. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pty.cc",
"new_path": "test/syscalls/linux/pty.cc",
"diff": "@@ -1527,27 +1527,36 @@ TEST_F(JobControlTest, SetForegroundProcessGroupEmptyProcessGroup) {\nTEST_F(JobControlTest, SetForegroundProcessGroupDifferentSession) {\nASSERT_THAT(ioctl... | Go | Apache License 2.0 | google/gvisor | De-flake SetForegroundProcessGroupDifferentSession.
PiperOrigin-RevId: 272059043 |
259,962 | 30.09.2019 15:51:35 | 25,200 | bcbb3ef317cb029f2553a8cdc03801f517b0fde4 | Add a Stringer implementation to PacketDispatchMode | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -82,7 +82,19 @@ const (\nPacketMMap\n)\n-// An endpoint implements the link-layer using a message-oriented file descriptor.\n+func (p PacketDispatchMode) String(... | Go | Apache License 2.0 | google/gvisor | Add a Stringer implementation to PacketDispatchMode
PiperOrigin-RevId: 272083936 |
259,858 | 30.09.2019 17:23:03 | 25,200 | 20841b98e14dd37aa40886668e337551b18f0fd3 | Update FIXME bug with GitHub issue. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/sighandling/sighandling_unsafe.go",
"new_path": "pkg/sentry/sighandling/sighandling_unsafe.go",
"diff": "@@ -23,7 +23,7 @@ import (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n)\n-// TODO(b/34161764): Move to pkg/abi/linux along with definitions in\n+// F... | Go | Apache License 2.0 | google/gvisor | Update FIXME bug with GitHub issue.
PiperOrigin-RevId: 272101930 |
259,853 | 30.09.2019 17:55:55 | 25,200 | 29a1ba54ea427d4fdd357453d74c93d16f5eca9b | splice: compare inode numbers only if both ends are pipes
It isn't allowed to splice data from and into the same pipe.
But right now this check is broken, because we don't check that both ends are
pipes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"new_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"diff": "@@ -245,14 +245,14 @@ func Splice(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscal\nif inOffset != 0 || outOffset != 0 {\nreturn 0, ni... | Go | Apache License 2.0 | google/gvisor | splice: compare inode numbers only if both ends are pipes
It isn't allowed to splice data from and into the same pipe.
But right now this check is broken, because we don't check that both ends are
pipes.
PiperOrigin-RevId: 272107022 |
259,853 | 30.09.2019 18:22:25 | 25,200 | 7a234f736fe0e91824b50631e408bd07b2c0ed31 | splice: try another fallback option only if the previous one isn't supported
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/splice.go",
"new_path": "pkg/sentry/fs/splice.go",
"diff": "@@ -139,7 +139,7 @@ func Splice(ctx context.Context, dst *File, src *File, opts SpliceOpts) (int64,\n// Attempt to do a WriteTo; this is likely the most efficient.\nn, err := src.FileOpe... | Go | Apache License 2.0 | google/gvisor | splice: try another fallback option only if the previous one isn't supported
Reported-by: syzbot+bb5ed342be51d39b0cbb@syzkaller.appspotmail.com
PiperOrigin-RevId: 272110815 |
259,881 | 01.10.2019 11:29:35 | 25,200 | 53cc72da90f5b5a76b024b47fe4e38a81b495eb4 | Honor X bit on extra anon pages in PT_LOAD segments
Linux changed this behavior in
(v4.11). Previously, extra pages were always mapped RW. Now, those pages will
be executable if the segment specified PF_X. They still must be writeable. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/elf.go",
"new_path": "pkg/sentry/loader/elf.go",
"diff": "@@ -323,6 +323,14 @@ func mapSegment(ctx context.Context, m *mm.MemoryManager, f *fs.File, phdr *elf.\nreturn syserror.ENOEXEC\n}\n+ // N.B. Linux uses vm_brk_flags to map these pages,... | Go | Apache License 2.0 | google/gvisor | Honor X bit on extra anon pages in PT_LOAD segments
Linux changed this behavior in 16e72e9b30986ee15f17fbb68189ca842c32af58
(v4.11). Previously, extra pages were always mapped RW. Now, those pages will
be executable if the segment specified PF_X. They still must be writeable.
PiperOrigin-RevId: 272256280 |
259,992 | 01.10.2019 11:48:24 | 25,200 | 0b02c3d5e5bae87f5cdbf4ae20dad8344bef32c2 | Prevent CAP_NET_RAW from appearing in exec
'docker exec' was getting CAP_NET_RAW even when --net-raw=false
because it was not filtered out from when copying container's
capabilities. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/exec.go",
"new_path": "runsc/cmd/exec.go",
"diff": "@@ -105,11 +105,11 @@ func (ex *Exec) SetFlags(f *flag.FlagSet) {\n// Execute implements subcommands.Command.Execute. It starts a process in an\n// already created container.\nfunc (ex *Exec) Execut... | Go | Apache License 2.0 | google/gvisor | Prevent CAP_NET_RAW from appearing in exec
'docker exec' was getting CAP_NET_RAW even when --net-raw=false
because it was not filtered out from when copying container's
capabilities.
PiperOrigin-RevId: 272260451 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.