author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,992 | 01.10.2019 13:49:35 | 25,200 | 739f53fc17e3e3ed82dc2bc920f49fa91738a437 | Add runsc logs to kokoro artifacts | [
{
"change_type": "MODIFY",
"old_path": "kokoro/docker_tests.cfg",
"new_path": "kokoro/docker_tests.cfg",
"diff": "@@ -5,5 +5,6 @@ action {\nregex: \"**/sponge_log.xml\"\nregex: \"**/sponge_log.log\"\nregex: \"**/outputs.zip\"\n+ regex: \"**/runsc_logs_*.tar.gz\"\n}\n}\n"
},
{
"change_type": ... | Go | Apache License 2.0 | google/gvisor | Add runsc logs to kokoro artifacts
PiperOrigin-RevId: 272286122 |
259,881 | 01.10.2019 15:41:32 | 25,200 | 0d483985c57a2d001039d17bd198e2eca0f4ff7f | Include AT_SECURE in the aux vector
gVisor does not currently implement the functionality that would result in
AT_SECURE = 1, but Linux includes AT_SECURE = 0 in the normal case, so we
should do the same. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_identity.go",
"new_path": "pkg/sentry/kernel/task_identity.go",
"diff": "@@ -465,8 +465,8 @@ func (t *Task) SetKeepCaps(k bool) {\n// disables the features we don't support anyway, is always set. This\n// drastically simplifies this func... | Go | Apache License 2.0 | google/gvisor | Include AT_SECURE in the aux vector
gVisor does not currently implement the functionality that would result in
AT_SECURE = 1, but Linux includes AT_SECURE = 0 in the normal case, so we
should do the same.
PiperOrigin-RevId: 272311488 |
259,853 | 01.10.2019 16:24:19 | 25,200 | 29207cef141983647816b2270fe6419e56630c64 | runsc: remove todo from the build file
b/135475885 was fixed by cl/271434565. | [
{
"change_type": "MODIFY",
"old_path": "runsc/BUILD",
"new_path": "runsc/BUILD",
"diff": "@@ -91,11 +91,6 @@ pkg_deb(\nmaintainer = \"The gVisor Authors <gvisor-dev@googlegroups.com>\",\npackage = \"runsc\",\npostinst = \"debian/postinst.sh\",\n- tags = [\n- # TODO(b/135475885): pkg_deb requires pyt... | Go | Apache License 2.0 | google/gvisor | runsc: remove todo from the build file
b/135475885 was fixed by cl/271434565.
PiperOrigin-RevId: 272320178 |
259,881 | 01.10.2019 16:44:27 | 25,200 | 03ce4dd86c9acd6b6148f68d5d2cf025d8c254bb | Remove extra --rm | [
{
"change_type": "MODIFY",
"old_path": "scripts/dev.sh",
"new_path": "scripts/dev.sh",
"diff": "@@ -58,7 +58,7 @@ if [[ ${REFRESH} -eq 0 ]]; then\necho\necho \"Runtimes ${RUNTIME} and ${RUNTIME}-d (debug enabled) setup.\"\necho \"Use --runtime=\"${RUNTIME}\" with your Docker command.\"\n- echo \" do... | Go | Apache License 2.0 | google/gvisor | Remove extra --rm
PiperOrigin-RevId: 272324038 |
259,881 | 02.10.2019 14:00:32 | 25,200 | 61e40819d9db05aecb8b36a46d529bd8fe425dcf | Sanity test that open(2) on a UDS fails
Spoiler alert: it doesn't. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -333,6 +333,7 @@ cc_binary(\nlinkstatic = 1,\ndeps = [\n\":socket_test_util\",\n+ \"//test/util:file_descriptor\",\n\"//test/util:test_main\",\n\"//test/util:test_util\",\n\"@com_... | Go | Apache License 2.0 | google/gvisor | Sanity test that open(2) on a UDS fails
Spoiler alert: it doesn't.
PiperOrigin-RevId: 272513529 |
259,853 | 03.10.2019 13:35:24 | 25,200 | db218fdfcf16b664c990f02c94ed89ac2c1ad314 | Don't report partialResult errors from sendfile
The input file descriptor is always a regular file, so sendfile can't lose any
data if it will not be able to write them to the output file descriptor.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"new_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"diff": "@@ -159,9 +159,14 @@ func Sendfile(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysc\n}, outFile.Flags().NonBlocking)\n}\n+ // Sendfile c... | Go | Apache License 2.0 | google/gvisor | Don't report partialResult errors from sendfile
The input file descriptor is always a regular file, so sendfile can't lose any
data if it will not be able to write them to the output file descriptor.
Reported-by: syzbot+22d22330a35fa1c02155@syzkaller.appspotmail.com
PiperOrigin-RevId: 272730357 |
259,891 | 04.10.2019 14:19:08 | 25,200 | 7ef1c44a7fe027d60c92b44515655a612d40d034 | Change linux.FileMode from uint to uint16, and update VFS to use FileMode.
In Linux (include/linux/types.h), mode_t is an unsigned short. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -271,7 +271,7 @@ type Statx struct {\n}\n// FileMode represents a mode_t.\n-type FileMode uint\n+type FileMode uint16\n// Permissions returns just the permission bits.\nfunc (m FileMode) ... | Go | Apache License 2.0 | google/gvisor | Change linux.FileMode from uint to uint16, and update VFS to use FileMode.
In Linux (include/linux/types.h), mode_t is an unsigned short.
PiperOrigin-RevId: 272956350 |
259,885 | 04.10.2019 14:55:11 | 25,200 | b941e357615a7b0e04dbf6535cafacfbb4b7e276 | Return EIO from p9 if flipcall.Endpoint.Connect() fails.
Also ensure that all flipcall transport errors not returned by p9 (converted to
EIO by the client, or dropped on the floor by channel server goroutines) are
logged. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/client.go",
"new_path": "pkg/p9/client.go",
"diff": "@@ -505,12 +505,27 @@ func (c *Client) sendRecvChannel(t message, r message) error {\nch.active = false\nc.channelsMu.Unlock()\nc.channelsWg.Done()\n- return err\n+ // Map all transport errors to EIO,... | Go | Apache License 2.0 | google/gvisor | Return EIO from p9 if flipcall.Endpoint.Connect() fails.
Also ensure that all flipcall transport errors not returned by p9 (converted to
EIO by the client, or dropped on the floor by channel server goroutines) are
logged.
PiperOrigin-RevId: 272963663 |
259,884 | 06.10.2019 21:06:53 | 25,200 | 5ac2cc54918c480bd40ec3f05c9ce93a2d7afa99 | Add SECURITY.md.
Adds minimal security policy info to SECURITY.md. This allows Github to
advertise the security policy doc for the repo.
See:
See: | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -133,11 +133,9 @@ The [gvisor-users mailing list][gvisor-users-list] and\n[gvisor-dev mailing list][gvisor-dev-list] are good starting points for\nquestions and discussion.\n-## Security\n+## Security Policy\n-S... | Go | Apache License 2.0 | google/gvisor | Add SECURITY.md.
Adds minimal security policy info to SECURITY.md. This allows Github to
advertise the security policy doc for the repo.
See: https://github.blog/changelog/2019-05-23-security-policy/
See: https://help.github.com/en/articles/adding-a-security-policy-to-your-repository
PiperOrigin-RevId: 273214306 |
259,891 | 07.10.2019 13:39:18 | 25,200 | 6a9823794975d2401ae1bda3937a63de959192ab | Rename epsocket to netstack. | [
{
"change_type": "RENAME",
"old_path": "pkg/sentry/socket/epsocket/BUILD",
"new_path": "pkg/sentry/socket/netstack/BUILD",
"diff": "@@ -3,15 +3,15 @@ package(licenses = [\"notice\"])\nload(\"//tools/go_stateify:defs.bzl\", \"go_library\")\ngo_library(\n- name = \"epsocket\",\n+ name = \"netstack\",\... | Go | Apache License 2.0 | google/gvisor | Rename epsocket to netstack.
PiperOrigin-RevId: 273365058 |
259,884 | 07.10.2019 15:54:13 | 25,200 | da9e18f24dfdd776d58e0d5bf6345449af724923 | Add tests for $HOME
Adds two tests. One to make sure that $HOME is set when starting a container
via 'docker run' and one to make sure that $HOME is set for each container in a
multi-container sandbox.
Issue | [
{
"change_type": "MODIFY",
"old_path": "runsc/criutil/criutil.go",
"new_path": "runsc/criutil/criutil.go",
"diff": "@@ -157,13 +157,55 @@ func (cc *Crictl) RmPod(podID string) error {\nreturn err\n}\n-// StartPodAndContainer pulls an image, then starts a sandbox and container in\n-// that sandbox. I... | Go | Apache License 2.0 | google/gvisor | Add tests for $HOME
Adds two tests. One to make sure that $HOME is set when starting a container
via 'docker run' and one to make sure that $HOME is set for each container in a
multi-container sandbox.
Issue #701
PiperOrigin-RevId: 273395763 |
259,891 | 07.10.2019 18:14:52 | 25,200 | 1de0cf3563502c1460964fc2fc9dca1ee447449a | Remove unnecessary context parameter for new pipes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fs/tmpfs/tmpfs.go",
"diff": "@@ -324,7 +324,7 @@ type Fifo struct {\n// NewFifo creates a new named pipe.\nfunc NewFifo(ctx context.Context, owner fs.FileOwner, perms fs.FilePermissions, msrc *fs.MountSour... | Go | Apache License 2.0 | google/gvisor | Remove unnecessary context parameter for new pipes.
PiperOrigin-RevId: 273421634 |
259,992 | 08.10.2019 13:34:46 | 25,200 | b9cdbc26bc676caeda1fdc1b30956888116a12be | Ignore mount options that are not supported in shared mounts
Options that do not change mount behavior inside the Sentry are
irrelevant and should not be used when looking for possible
incompatibilities between master and slave mounts. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -64,6 +64,9 @@ const (\nnonefs = \"none\"\n)\n+// tmpfs has some extra supported options that we must pass through.\n+var tmpfsAllowedOptions = []string{\"mode\", \"uid\", \"gid\"}\n+\nfunc addOver... | Go | Apache License 2.0 | google/gvisor | Ignore mount options that are not supported in shared mounts
Options that do not change mount behavior inside the Sentry are
irrelevant and should not be used when looking for possible
incompatibilities between master and slave mounts.
PiperOrigin-RevId: 273593486 |
259,974 | 29.08.2019 10:10:26 | 0 | ebbf2b7fbdcda80d158b72276786a4a1dcad664a | Enable pkg/atomicbitops support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/atomicbitops/BUILD",
"new_path": "pkg/atomicbitops/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_library(\nsrcs = [\n\"atomic_bitops.go\",\n\"atomic_bitops_amd64.s\",\n+ \"atomic_bitops_arm64.s\",\n\"atomic_bitops_common.go\",\n],\nimportpath = \"gvisor.dev/gvisor/p... | Go | Apache License 2.0 | google/gvisor | Enable pkg/atomicbitops support on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I1646aaa6f07b5ec31c39c318b70f48693fe59a7c |
259,858 | 10.10.2019 12:45:34 | 25,200 | f8b18593198cf7ca1adfca19d846e66080b07942 | Fix signalfd polling.
The signalfd descriptors otherwise always show as available. This can lead
programs to spin, assuming they are looking to see what signals are pending.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/signalfd/signalfd.go",
"new_path": "pkg/sentry/kernel/signalfd/signalfd.go",
"diff": "@@ -121,7 +121,10 @@ func (s *SignalOperations) Read(ctx context.Context, _ *fs.File, dst usermem.IOS\n// Readiness implements waiter.Waitable.Readiness.\nf... | Go | Apache License 2.0 | google/gvisor | Fix signalfd polling.
The signalfd descriptors otherwise always show as available. This can lead
programs to spin, assuming they are looking to see what signals are pending.
Updates #139
PiperOrigin-RevId: 274017890 |
259,881 | 10.10.2019 13:39:55 | 25,200 | a5170fd825efbea0550137b5979f7bd08398aa55 | Allow rt_sigreturn in runsc gofer
rt_sigreturn is required for signal handling (e.g., SIGSEGV for nil-pointer
dereference). Before this, nil-pointer dereferences cause a syscall violation
instead of a panic. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/config.go",
"new_path": "runsc/fsgofer/filter/config.go",
"diff": "@@ -177,6 +177,7 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_RENAMEAT: {},\nsyscall.SYS_RESTART_SYSCALL: {},\nsyscall.SYS_RT_SIGPROCMASK: {},\n+ syscall.SYS... | Go | Apache License 2.0 | google/gvisor | Allow rt_sigreturn in runsc gofer
rt_sigreturn is required for signal handling (e.g., SIGSEGV for nil-pointer
dereference). Before this, nil-pointer dereferences cause a syscall violation
instead of a panic.
PiperOrigin-RevId: 274028767 |
259,884 | 10.10.2019 14:41:41 | 25,200 | 065339193e4309a8c771ba88058c3b2d96c07e78 | Update TODO for OCI seccomp support. | [
{
"change_type": "MODIFY",
"old_path": "runsc/specutils/specutils.go",
"new_path": "runsc/specutils/specutils.go",
"diff": "@@ -92,7 +92,7 @@ func ValidateSpec(spec *specs.Spec) error {\nlog.Warningf(\"AppArmor profile %q is being ignored\", spec.Process.ApparmorProfile)\n}\n- // TODO(b/72226747): A... | Go | Apache License 2.0 | google/gvisor | Update TODO for OCI seccomp support.
PiperOrigin-RevId: 274042343 |
259,962 | 10.10.2019 15:13:39 | 25,200 | c7e901f47a09eaac56bd4813227edff016fa6bff | Fix bugs in fragment handling.
Strengthen the header.IPv4.IsValid check to correctly check
for IHL/TotalLength fields. Also add a check to make sure
fragmentOffsets + size of the fragment do not cause a wrap
around for the end of the fragment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -142,6 +142,8 @@ var Metrics = tcpip.Stats{\nPacketsDelivered: mustCreateMetric(\"/netstack/ip/packets_delivered\", \"Total number of incoming IP packets... | Go | Apache License 2.0 | google/gvisor | Fix bugs in fragment handling.
Strengthen the header.IPv4.IsValid check to correctly check
for IHL/TotalLength fields. Also add a check to make sure
fragmentOffsets + size of the fragment do not cause a wrap
around for the end of the fragment.
PiperOrigin-RevId: 274049313 |
259,962 | 14.10.2019 12:49:50 | 25,200 | a2964259702cc4ed3f10d2b8e352a36ef26f0215 | Use a different fanoutID for each new fdbased endpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -178,6 +178,14 @@ type Options struct {\nRXChecksumOffload bool\n}\n+// fanoutID is used for AF_PACKET based endpoints to enable PACKET_FANOUT\n+// support in th... | Go | Apache License 2.0 | google/gvisor | Use a different fanoutID for each new fdbased endpoint.
PiperOrigin-RevId: 274638272 |
259,891 | 14.10.2019 15:20:35 | 25,200 | 2302afb53d5d0a6714438649f0ab0a2c020af288 | Reorder BUILD license and load functions in netstack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/BUILD",
"new_path": "pkg/tcpip/BUILD",
"diff": "load(\"@io_bazel_rules_go//go:def.bzl\", \"go_test\")\n+load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\npackage(licenses = [\"notice\"])\n-load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\... | Go | Apache License 2.0 | google/gvisor | Reorder BUILD license and load functions in netstack.
PiperOrigin-RevId: 274672346 |
259,883 | 02.04.2019 17:13:00 | -28,800 | e3d4a6773923a884986aaa4bb272431ce27764e2 | support /proc/net/snmp
This proc file contains statistics according to [1].
[1] | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"bytes\"\n\"fmt\"\n\"io\"\n+ \"reflect\"\n\"time\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -33,6 +34,7 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/socke... | Go | Apache License 2.0 | google/gvisor | support /proc/net/snmp
This proc file contains statistics according to [1].
[1] https://tools.ietf.org/html/rfc2013
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com>
Change-Id: I9662132085edd8a7783d356ce4237d7ac0800d94 |
259,883 | 18.04.2019 11:41:13 | -28,800 | b94505ecc020e63a7e5cab0f1bb5ea898ea05ec5 | support /proc/net/route
This proc file reports routing information to applications inside the
container. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netlink_route.go",
"new_path": "pkg/abi/linux/netlink_route.go",
"diff": "@@ -325,3 +325,9 @@ const (\nRTA_SPORT = 28\nRTA_DPORT = 29\n)\n+\n+// Route flags, from include/uapi/linux/route.h.\n+const (\n+ RTF_GATEWAY = 0x2\n+ RTF_UP = 0x1\n+)\n"
... | Go | Apache License 2.0 | google/gvisor | support /proc/net/route
This proc file reports routing information to applications inside the
container.
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com>
Change-Id: I498e47f8c4c185419befbb42d849d0b099ec71f3 |
259,883 | 16.05.2019 16:21:46 | -28,800 | dd7d1f825d2f6464b61287b3a324c13139b0d661 | hostinet: support /proc/net/snmp and /proc/net/dev
For hostinet, we inherit the data from host procfs. To to that, we
cache the fds for these files for later reads.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/stack.go",
"new_path": "pkg/sentry/socket/hostinet/stack.go",
"diff": "@@ -16,8 +16,11 @@ package hostinet\nimport (\n\"fmt\"\n+ \"io\"\n\"io/ioutil\"\n\"os\"\n+ \"reflect\"\n+ \"strconv\"\n\"strings\"\n\"syscall\"\n@@ -26,6 +29,7 @@... | Go | Apache License 2.0 | google/gvisor | hostinet: support /proc/net/snmp and /proc/net/dev
For hostinet, we inherit the data from host procfs. To to that, we
cache the fds for these files for later reads.
Fixes #506
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com>
Change-Id: I2f81215477455b9c59acf67e33f5b9af28ee0165 |
259,883 | 29.08.2019 16:23:11 | 0 | aee2c93366f451b9cc0a62430185749556fc3900 | netstack: add counters for tcp CurrEstab and EstabResets | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -148,6 +148,8 @@ var Metrics = tcpip.Stats{\nTCP: tcpip.TCPStats{\nActiveConnectionOpenings: mustCreateMetric(\"/netstack/tcp/active_connection_openings\... | Go | Apache License 2.0 | google/gvisor | netstack: add counters for tcp CurrEstab and EstabResets
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com> |
259,883 | 20.05.2019 11:26:10 | 0 | d277bfba2702b319d8336b65429cf8775661ea2f | epsocket: support /proc/net/snmp
Netstack has its own stats, we use this to fill /proc/net/snmp.
Note that some metrics are not recorded in Netstack, which will be shown
as 0 in the proc file. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/stack.go",
"new_path": "pkg/sentry/socket/netstack/stack.go",
"diff": "@@ -144,8 +144,99 @@ func (s *Stack) SetTCPSACKEnabled(enabled bool) error {\n// Statistics implements inet.Stack.Statistics.\nfunc (s *Stack) Statistics(stat int... | Go | Apache License 2.0 | google/gvisor | epsocket: support /proc/net/snmp
Netstack has its own stats, we use this to fill /proc/net/snmp.
Note that some metrics are not recorded in Netstack, which will be shown
as 0 in the proc file.
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com>
Change-Id: Ie0089184507d16f49bc0057b4b0482094417ebe1 |
259,885 | 15.10.2019 18:39:16 | 25,200 | 0457a4c4cb67537b09f47e58764f22434dbeff02 | Minor vfs.FileDescriptionImpl fixes.
Pass context.Context to OnClose().
Pass memmap.MMapOpts to ConfigureMMap() by pointer so that implementations
can actually mutate it as required. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/directory.go",
"new_path": "pkg/sentry/fsimpl/ext/directory.go",
"diff": "@@ -301,8 +301,8 @@ func (fd *directoryFD) Seek(ctx context.Context, offset int64, whence int32) (in\nreturn offset, nil\n}\n-// IterDirents implements vfs.FileDesc... | Go | Apache License 2.0 | google/gvisor | Minor vfs.FileDescriptionImpl fixes.
- Pass context.Context to OnClose().
- Pass memmap.MMapOpts to ConfigureMMap() by pointer so that implementations
can actually mutate it as required.
PiperOrigin-RevId: 274934967 |
259,881 | 16.10.2019 13:23:44 | 25,200 | de9a8e0eb7d66e75c4367be3437c4eb36a080f67 | Remove death from exec test names
These aren't actually death tests in the GUnit sense. i.e., they don't call
EXPECT_EXIT or EXPECT_DEATH. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/exec.cc",
"new_path": "test/syscalls/linux/exec.cc",
"diff": "@@ -140,57 +140,57 @@ void CheckOutput(const std::string& filename, const ExecveArray& argv,\nEXPECT_TRUE(absl::StrContains(output, expect_stderr)) << output;\n}\n-TEST(ExecDeath... | Go | Apache License 2.0 | google/gvisor | Remove death from exec test names
These aren't actually death tests in the GUnit sense. i.e., they don't call
EXPECT_EXIT or EXPECT_DEATH.
PiperOrigin-RevId: 275099957 |
259,881 | 16.10.2019 14:28:21 | 25,200 | bbdcf44ebbf1e001a134c9412719891f150befd6 | Fix syscall changes lost in rebase
These syscalls were changed in the amd64 file around the time the arm64 PR was
sent out, so their changes got lost.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64_arm64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64_arm64.go",
"diff": "@@ -107,10 +107,10 @@ var ARM64 = &kernel.SyscallTable{\n71: syscalls.Supported(\"sendfile\", Sendfile),\n72: syscalls.Supported(\"pselect\", Pselec... | Go | Apache License 2.0 | google/gvisor | Fix syscall changes lost in rebase
These syscalls were changed in the amd64 file around the time the arm64 PR was
sent out, so their changes got lost.
Updates #63
PiperOrigin-RevId: 275114194 |
260,004 | 17.10.2019 13:05:03 | 25,200 | 962aa235de4e614147dd00b55967614e93ba2660 | NDP Neighbor Solicitations sent during DAD must have an IP hop limit of 255
NDP Neighbor Solicitations sent during Duplicate Address Detection must have an
IP hop limit of 255, as all NDP Neighbor Solicitations should have.
Test: Test that DAD messages have the IPv6 hop limit field set to 255. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/icmpv6.go",
"new_path": "pkg/tcpip/header/icmpv6.go",
"diff": "@@ -80,6 +80,13 @@ const (\n// icmpv6SequenceOffset is the offset of the sequence field\n// in a ICMPv6 Echo Request/Reply message.\nicmpv6SequenceOffset = 6\n+\n+ // NDPHopLimit i... | Go | Apache License 2.0 | google/gvisor | NDP Neighbor Solicitations sent during DAD must have an IP hop limit of 255
NDP Neighbor Solicitations sent during Duplicate Address Detection must have an
IP hop limit of 255, as all NDP Neighbor Solicitations should have.
Test: Test that DAD messages have the IPv6 hop limit field set to 255.
PiperOrigin-RevId: 275321680 |
259,891 | 17.10.2019 13:08:27 | 25,200 | dfdbdf14fa101e850bb3361f91da6362b98d11d0 | Refactor pipe to support VFS2.
* Pulls common functionality (IO and locking on open) into pipe_util.go.
* Adds pipe/vfs.go, which implements a subset of vfs.FileDescriptionImpl.
A subsequent change will add support for pipes in memfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/BUILD",
"new_path": "pkg/sentry/kernel/pipe/BUILD",
"diff": "@@ -24,8 +24,10 @@ go_library(\n\"device.go\",\n\"node.go\",\n\"pipe.go\",\n+ \"pipe_util.go\",\n\"reader.go\",\n\"reader_writer.go\",\n+ \"vfs.go\",\n\"writer.go\",\n],\nimpor... | Go | Apache License 2.0 | google/gvisor | Refactor pipe to support VFS2.
* Pulls common functionality (IO and locking on open) into pipe_util.go.
* Adds pipe/vfs.go, which implements a subset of vfs.FileDescriptionImpl.
A subsequent change will add support for pipes in memfs.
PiperOrigin-RevId: 275322385 |
259,858 | 12.09.2019 00:26:09 | 25,200 | 015a1b57d6b701cb8b687fb70aa9a5dbcb1edc25 | Add apt-based instructions. | [
{
"change_type": "DELETE",
"old_path": "content/docs/includes/index.md",
"new_path": null,
"diff": "-+++\n-headless = true\n-+++\n"
},
{
"change_type": "DELETE",
"old_path": "content/docs/includes/install_gvisor.md",
"new_path": null,
"diff": "-The easiest way to get `runsc` is f... | Go | Apache License 2.0 | google/gvisor | Add apt-based instructions. |
259,884 | 18.10.2019 00:32:14 | 14,400 | b5ccc29b9506b2fc4e5dd24a53e589ef4e334280 | Fixed some review issues
Fixed some issues that came up during review.
Update section titles to have a full phrase
Fix ${URL}
Have short install script clean up after itself so it can be re-run.
Small wording changes. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/install.md",
"new_path": "content/docs/user_guide/install.md",
"diff": "@@ -9,7 +9,7 @@ weight = 20\n## Versions\nThe `runsc` binaries and repositories are available in multiple versions and\n-release channels. First, you should pick th... | Go | Apache License 2.0 | google/gvisor | Fixed some review issues
Fixed some issues that came up during review.
- Update section titles to have a full phrase
- Fix ${URL}
- Have short install script clean up after itself so it can be re-run.
- Small wording changes. |
259,853 | 18.10.2019 13:39:12 | 25,200 | 4c7f849b252d43b0d684aeb08e0d54d717fdd7de | test: use a bigger buffer to fill a socket
Otherwise we need to do a lot of system calls and cooperative_save tests work
slow. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_unix_non_stream.cc",
"new_path": "test/syscalls/linux/socket_unix_non_stream.cc",
"diff": "@@ -231,11 +231,21 @@ TEST_P(UnixNonStreamSocketPairTest, SendTimeout) {\nsetsockopt(sockets->first_fd(), SOL_SOCKET, SO_SNDTIMEO, &tv, sizeof... | Go | Apache License 2.0 | google/gvisor | test: use a bigger buffer to fill a socket
Otherwise we need to do a lot of system calls and cooperative_save tests work
slow.
PiperOrigin-RevId: 275536957 |
260,023 | 18.10.2019 15:58:40 | 25,200 | 487d3b2358239254e757f4ce3b0cd31615d80e1b | Fix typo while initializing protocol for UDP endpoints.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -140,7 +140,7 @@ func newEndpoint(s *stack.Stack, netProto tcpip.NetworkProtocolNumber, waiterQue\nstack: s,\nTransportEndpointInfo: stack.TransportEndpointInf... | Go | Apache License 2.0 | google/gvisor | Fix typo while initializing protocol for UDP endpoints.
Fixes #763
PiperOrigin-RevId: 275563222 |
259,992 | 18.10.2019 16:13:04 | 25,200 | 74044f2cca498ed3144baccc5d3b7af534829966 | Add more instructions to test/README.md | [
{
"change_type": "MODIFY",
"old_path": "test/README.md",
"new_path": "test/README.md",
"diff": "@@ -10,9 +10,31 @@ they may need extra setup in the test machine and extra configuration to run.\nfunctionality.\n- **image:** basic end to end test for popular images. These require the same\nsetup as in... | Go | Apache License 2.0 | google/gvisor | Add more instructions to test/README.md
PiperOrigin-RevId: 275565958 |
259,891 | 19.10.2019 11:48:09 | 25,200 | 652f7b1d0fef6f522baaed091d4820a48014092c | Add support for pipes in VFS2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/memfs/BUILD",
"new_path": "pkg/sentry/fsimpl/memfs/BUILD",
"diff": "@@ -24,14 +24,18 @@ go_library(\n\"directory.go\",\n\"filesystem.go\",\n\"memfs.go\",\n+ \"named_pipe.go\",\n\"regular_file.go\",\n\"symlink.go\",\n],\nimportpath = \"gvisor.... | Go | Apache License 2.0 | google/gvisor | Add support for pipes in VFS2.
PiperOrigin-RevId: 275650307 |
259,851 | 20.10.2019 05:19:58 | -19,080 | 53e921eb38e38867363f2203d2f883dadf3b5a2d | spell corrected | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/checkpoint_restore.md",
"new_path": "content/docs/user_guide/checkpoint_restore.md",
"diff": "@@ -19,7 +19,7 @@ the directory path within which the checkpoint state-file will be created. The\nfile will be called `checkpoint.img` and nec... | Go | Apache License 2.0 | google/gvisor | spell corrected |
259,860 | 21.10.2019 14:53:44 | 25,200 | 0b569b7caebc2b7785732ed6cb8248cf0568783f | Add basic implementation of execveat syscall and associated tests.
Allow file descriptors of directories as well as AT_FDCWD. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64_amd64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64_amd64.go",
"diff": "@@ -362,7 +362,7 @@ var AMD64 = &kernel.SyscallTable{\n319: syscalls.Supported(\"memfd_create\", MemfdCreate),\n320: syscalls.CapError(\"kexec_file_... | Go | Apache License 2.0 | google/gvisor | Add basic implementation of execveat syscall and associated tests.
Allow file descriptors of directories as well as AT_FDCWD.
PiperOrigin-RevId: 275929668 |
260,004 | 22.10.2019 13:53:01 | 25,200 | c356fe2ebb4aa2ca2bf0afc88a8af96f3c61bb25 | Respect new PrimaryEndpointBehavior when addresses gets promoted to permanent
This change makes sure that when an address which is already known by a NIC and
has kind = permanentExpired gets promoted to permanent, the new
PrimaryEndpointBehavior is respected. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -73,6 +73,7 @@ go_test(\n\"//pkg/tcpip/transport/icmp\",\n\"//pkg/tcpip/transport/udp\",\n\"//pkg/waiter\",\n+ \"@com_github_google_go-cmp//cmp:go_default_library\",\n],\n)\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Respect new PrimaryEndpointBehavior when addresses gets promoted to permanent
This change makes sure that when an address which is already known by a NIC and
has kind = permanentExpired gets promoted to permanent, the new
PrimaryEndpointBehavior is respected.
PiperOrigin-RevId: 276136317 |
260,004 | 22.10.2019 14:40:27 | 25,200 | 515e0558d4f8f7c890e72bdaf4c8b41b31cd270c | Add a type to represent the NDP Router Advertisement message.
This change is in preparation for NDP Router Discovery where the stack will need
to handle NDP Router Advertisments.
Tests: Test that given an NDP Router Advertisement buffer (body of an ICMPv6
packet, correct values are returned by the field getters). | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/BUILD",
"new_path": "pkg/tcpip/header/BUILD",
"diff": "@@ -19,6 +19,7 @@ go_library(\n\"ndp_neighbor_advert.go\",\n\"ndp_neighbor_solicit.go\",\n\"ndp_options.go\",\n+ \"ndp_router_advert.go\",\n\"tcp.go\",\n\"udp.go\",\n],\n"
},
{
"ch... | Go | Apache License 2.0 | google/gvisor | Add a type to represent the NDP Router Advertisement message.
This change is in preparation for NDP Router Discovery where the stack will need
to handle NDP Router Advertisments.
Tests: Test that given an NDP Router Advertisement buffer (body of an ICMPv6
packet, correct values are returned by the field getters).
PiperOrigin-RevId: 276146817 |
259,853 | 22.10.2019 14:55:54 | 25,200 | e63ff6d923bb7ec74b837e6b00df41e4d805e70a | platform/ptrace: exit without panic if a stub process has been killed by SIGKILL
SIGKILL can be sent only by an user or OOM-killer. In both cases, we don't
need to panic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess.go",
"diff": "@@ -327,6 +327,19 @@ func (t *thread) dumpAndPanic(message string) {\npanic(message)\n}\n+func (t *thread) unexpectedStubExit() {\n+ msg, err := t.getEv... | Go | Apache License 2.0 | google/gvisor | platform/ptrace: exit without panic if a stub process has been killed by SIGKILL
SIGKILL can be sent only by an user or OOM-killer. In both cases, we don't
need to panic.
PiperOrigin-RevId: 276150120 |
259,884 | 22.10.2019 16:14:42 | 25,200 | ebe8001724a6965cc9723604b38f42563d284a6a | Update const names to be Go style. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64.go",
"diff": "package linux\nconst (\n- _LINUX_SYSNAME = \"Linux\"\n- _LINUX_RELEASE = \"4.4.0\"\n- _LINUX_VERSION = \"#1 SMP Sun Jan 10 15:06:54 PST 2016\"\n+ // LinuxSysnam... | Go | Apache License 2.0 | google/gvisor | Update const names to be Go style.
PiperOrigin-RevId: 276165962 |
259,881 | 23.10.2019 12:58:40 | 25,200 | c0065e296f6e840ec1f6797fb0fd55cde0fff785 | Remove comparison between signed and unsigned int
Some compilers don't like the comparison between int and size_t. Remove it.
The other changes are minor style cleanups. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/sendfile_socket.cc",
"new_path": "test/syscalls/linux/sendfile_socket.cc",
"diff": "@@ -185,7 +185,7 @@ TEST_P(SendFileTest, Shutdown) {\n// Create a socket.\nstd::tuple<int, int> fds = ASSERT_NO_ERRNO_AND_VALUE(Sockets());\nconst FileDescr... | Go | Apache License 2.0 | google/gvisor | Remove comparison between signed and unsigned int
Some compilers don't like the comparison between int and size_t. Remove it.
The other changes are minor style cleanups.
PiperOrigin-RevId: 276333450 |
259,958 | 23.10.2019 14:26:23 | 25,200 | fbe6b50d5628bc3d522f87eee2abcc5a923df420 | Keep minimal available fd to accelerate fd allocation
Use fd.next to store the iteration start position, which can be used to accelerate allocating new FDs.
And adding the corresponding gtest benchmark to measure performance.
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/758 from DarcySail:master | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -81,6 +81,9 @@ type FDTable struct {\n// mu protects below.\nmu sync.Mutex `state:\"nosave\"`\n+ // next is start position to find fd.\n+ next int32\n+\n// used contains t... | Go | Apache License 2.0 | google/gvisor | Keep minimal available fd to accelerate fd allocation
Use fd.next to store the iteration start position, which can be used to accelerate allocating new FDs.
And adding the corresponding gtest benchmark to measure performance.
@tanjianfeng
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/758 from DarcySail:master 96685ec7886dfe1a64988406831d3bc002b438cc
PiperOrigin-RevId: 276351250 |
259,891 | 23.10.2019 17:20:07 | 25,200 | 072af49059a1818e0e06188be81fe425363acf55 | Add check for proper settings to AF_PACKET tests.
As in packet_socket_raw.cc, we should check that certain proc files are set
correctly. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/packet_socket.cc",
"new_path": "test/syscalls/linux/packet_socket.cc",
"diff": "@@ -130,6 +130,20 @@ void CookedPacketTest::SetUp() {\nGTEST_SKIP();\n}\n+ if (!IsRunningOnGvisor()) {\n+ FileDescriptor acceptLocal = ASSERT_NO_ERRNO_AND_VALUE... | Go | Apache License 2.0 | google/gvisor | Add check for proper settings to AF_PACKET tests.
As in packet_socket_raw.cc, we should check that certain proc files are set
correctly.
PiperOrigin-RevId: 276384534 |
259,884 | 18.10.2019 02:40:54 | 14,400 | 514f16b290229cc1105cdaf8102fee59b1365aee | Fix links on website. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -63,6 +63,10 @@ compatibility-docs: bin/generate-syscall-docs upstream/gvisor/bazel-bin/runsc/li\n./upstream/gvisor/bazel-bin/runsc/linux_amd64_pure_stripped/runsc help syscalls -o json | ./bin/generate-syscall-do... | Go | Apache License 2.0 | google/gvisor | Fix links on website. |
259,884 | 18.10.2019 03:05:17 | 14,400 | a9a28c9e4de60a4ec355cb51bdac0f618c208ce1 | Add Google Analytics tracking. | [
{
"change_type": "MODIFY",
"old_path": "config.toml",
"new_path": "config.toml",
"diff": "@@ -61,9 +61,7 @@ anchor = \"smart\"\n[services]\n[services.googleAnalytics]\n-# Comment out the next line to disable GA tracking. Also disables the feature described in [params.ui.feedback].\n-# TODO: Add anal... | Go | Apache License 2.0 | google/gvisor | Add Google Analytics tracking. |
259,971 | 24.10.2019 13:43:10 | -39,600 | cf240fdf731ff631a37e1a35e6b4e4f2c4203a2d | Fix install link
Link to install docs is currently missing from the Docker quickstart page. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/quick_start/docker.md",
"new_path": "content/docs/user_guide/quick_start/docker.md",
"diff": "@@ -90,7 +90,7 @@ Next, look at the different options available for gVisor: [platform][platforms],\n[docker]: https://docs.docker.com/install/... | Go | Apache License 2.0 | google/gvisor | Fix install link
Link to install docs is currently missing from the Docker quickstart page. |
259,860 | 23.10.2019 22:21:33 | 25,200 | 7ca50236c42ad1b1aa19951815d03b62c0c722ed | Handle AT_EMPTY_PATH flag in execveat. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64_amd64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64_amd64.go",
"diff": "@@ -362,7 +362,7 @@ var AMD64 = &kernel.SyscallTable{\n319: syscalls.Supported(\"memfd_create\", MemfdCreate),\n320: syscalls.CapError(\"kexec_file_... | Go | Apache License 2.0 | google/gvisor | Handle AT_EMPTY_PATH flag in execveat.
PiperOrigin-RevId: 276419967 |
259,858 | 23.10.2019 22:59:45 | 25,200 | 6b0f111d96b08e8fdc59400c3fe76fedfd57b0c4 | Temporarily remove apt instructions
The built repository is not working. This will be updated when the release file is being generated correctly. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/install.md",
"new_path": "content/docs/user_guide/install.md",
"diff": "@@ -13,9 +13,13 @@ release channels. You should pick the version you'd like to install. For\nexperimentation, the nightly release is recommended. For production use... | Go | Apache License 2.0 | google/gvisor | Temporarily remove apt instructions
The built repository is not working. This will be updated when the release file is being generated correctly. |
259,860 | 24.10.2019 01:44:03 | 25,200 | d9fd5363409facbc5cf04b85b3b0e7dade085dd9 | Handle AT_SYMLINK_NOFOLLOW flag for execveat. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -805,7 +805,7 @@ func (k *Kernel) CreateProcess(args CreateProcessArgs) (*ThreadGroup, ThreadID,\n// Create a fresh task context.\nremainingTraversals = uint(args.MaxSymlinkTr... | Go | Apache License 2.0 | google/gvisor | Handle AT_SYMLINK_NOFOLLOW flag for execveat.
PiperOrigin-RevId: 276441249 |
259,891 | 24.10.2019 14:08:03 | 25,200 | 9d81dd355953f44e6cfdbe1f010bac430171970d | Change tcpdump status to working | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -79,7 +79,7 @@ Most common utilities work. Note that:\n| sshd | Partially working. Job control [in progress](https://github.com/google/... | Go | Apache License 2.0 | google/gvisor | Change tcpdump status to working
https://github.com/google/gvisor/commit/12235d533ae5c8b4b03c6d7f24cae785a2d6ec22 |
260,004 | 24.10.2019 15:18:43 | 25,200 | e50a1f5739adc9bcb74456d365959ae718ff2197 | Remove the amss field from tcpip.tcp.handshake as it was unused
The amss field in the tcpip.tcp.handshake was not used anywhere. Removed it to
not cause confusion with the amss field in the tcpip.tcp.endpoint struct, which
was documented to be used (and is actually being used) for the same purpose. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -78,9 +78,6 @@ type handshake struct {\n// mss is the maximum segment size received from the peer.\nmss uint16\n- // amss is the maximum segment size advertised ... | Go | Apache License 2.0 | google/gvisor | Remove the amss field from tcpip.tcp.handshake as it was unused
The amss field in the tcpip.tcp.handshake was not used anywhere. Removed it to
not cause confusion with the amss field in the tcpip.tcp.endpoint struct, which
was documented to be used (and is actually being used) for the same purpose.
PiperOrigin-RevId: 276577088 |
259,992 | 24.10.2019 16:35:29 | 25,200 | e8ba10c0085d404378ce649e018624b93cf4aa65 | Fix early deletion of rootDir
container.startContainers() cannot be called twice in a test
(e.g. TestMultiContainerLoadSandbox) because the cleanup
function deletes the rootDir, together with information from
all other containers that may exist. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -1548,7 +1548,8 @@ func TestAbbreviatedIDs(t *testing.T) {\n}\ndefer os.RemoveAll(rootDir)\n- conf := testutil.TestConfigWithRoot(rootDir)\n+ conf := testutil.Test... | Go | Apache License 2.0 | google/gvisor | Fix early deletion of rootDir
container.startContainers() cannot be called twice in a test
(e.g. TestMultiContainerLoadSandbox) because the cleanup
function deletes the rootDir, together with information from
all other containers that may exist.
PiperOrigin-RevId: 276591806 |
260,004 | 24.10.2019 16:51:41 | 25,200 | 27e896f2905eea612855b1c92d9b43ebaa09cbf3 | Add a type to represent the NDP Prefix Information option.
This change is in preparation for NDP Prefix Discovery and SLAAC where the stack
will need to handle NDP Prefix Information options.
Tests: Test that given an NDP Prefix Information option buffer, correct values
are returned by the field getters. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ndp_options.go",
"new_path": "pkg/tcpip/header/ndp_options.go",
"diff": "package header\nimport (\n+ \"encoding/binary\"\n+ \"time\"\n+\n\"gvisor.dev/gvisor/pkg/tcpip\"\n)\n@@ -27,6 +30,65 @@ const (\n// Link Layer Option for an Ethernet addre... | Go | Apache License 2.0 | google/gvisor | Add a type to represent the NDP Prefix Information option.
This change is in preparation for NDP Prefix Discovery and SLAAC where the stack
will need to handle NDP Prefix Information options.
Tests: Test that given an NDP Prefix Information option buffer, correct values
are returned by the field getters.
PiperOrigin-RevId: 276594592 |
259,853 | 25.10.2019 10:47:49 | 25,200 | fd598912bee1965c32dee1a5933678ed34e768bc | platform/ptrace: use tgkill instead of kill
The syscall filters don't allow kill, just tgkill. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess.go",
"diff": "@@ -335,7 +335,8 @@ func (t *thread) unexpectedStubExit() {\n// these cases, we don't need to panic. There is no reasons to\n// think that something wro... | Go | Apache License 2.0 | google/gvisor | platform/ptrace: use tgkill instead of kill
The syscall filters don't allow kill, just tgkill.
PiperOrigin-RevId: 276718421 |
259,854 | 25.10.2019 13:14:02 | 25,200 | 8f029b3f823342e43d23e2a238bc599596bdca24 | Convert DelayOption to the newer/faster SockOpt int type.
DelayOption is set on all new endpoints in gVisor. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -281,7 +281,7 @@ type SocketOperations struct {\n// New creates a new endpoint socket.\nfunc New(t *kernel.Task, family int, skType linux.SockType, proto... | Go | Apache License 2.0 | google/gvisor | Convert DelayOption to the newer/faster SockOpt int type.
DelayOption is set on all new endpoints in gVisor.
PiperOrigin-RevId: 276746791 |
260,004 | 25.10.2019 16:05:31 | 25,200 | 5a421058a07477e23f6ca23bb510894419224080 | Validate the checksum for incoming ICMPv6 packets
This change validates the ICMPv6 checksum field before further processing an
ICMPv6 packet.
Tests: Unittests to make sure that only ICMPv6 packets with a valid checksum
are accepted/processed. Existing tests using checker.ICMPv6 now also check the
ICMPv6 checksum field. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/BUILD",
"new_path": "pkg/tcpip/checker/BUILD",
"diff": "@@ -10,6 +10,7 @@ go_library(\nvisibility = [\"//visibility:public\"],\ndeps = [\n\"//pkg/tcpip\",\n+ \"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/seqnum\",\n],\n"
}... | Go | Apache License 2.0 | google/gvisor | Validate the checksum for incoming ICMPv6 packets
This change validates the ICMPv6 checksum field before further processing an
ICMPv6 packet.
Tests: Unittests to make sure that only ICMPv6 packets with a valid checksum
are accepted/processed. Existing tests using checker.ICMPv6 now also check the
ICMPv6 checksum field.
PiperOrigin-RevId: 276779148 |
259,860 | 25.10.2019 22:31:35 | 25,200 | 1c480abc39b9957606ff8bf125a5c253ad8a76cb | Aggregate arguments for loading executables into a single struct.
This change simplifies the function signatures of functions related to loading
executables, such as LoadTaskImage, Load, loadBinary. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -804,8 +804,20 @@ func (k *Kernel) CreateProcess(args CreateProcessArgs) (*ThreadGroup, ThreadID,\n// Create a fresh task context.\nremainingTraversals = uint(args.MaxSymlinkT... | Go | Apache License 2.0 | google/gvisor | Aggregate arguments for loading executables into a single struct.
This change simplifies the function signatures of functions related to loading
executables, such as LoadTaskImage, Load, loadBinary.
PiperOrigin-RevId: 276821187 |
259,884 | 28.10.2019 01:32:30 | 14,400 | c73410c0bda98fa617d82cf423ce96ee5e6af6a4 | Comment out unused references | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/install.md",
"new_path": "content/docs/user_guide/install.md",
"diff": "@@ -164,7 +164,9 @@ optionally automatically configure Docker:\nrunsc install\n```\n+[old-linux]: /docs/user_guide/networking/#gso\n+<!--\n[latest-nightly]: https:/... | Go | Apache License 2.0 | google/gvisor | Comment out unused references |
259,974 | 24.10.2019 03:18:18 | 0 | dec831b4939a6332cac5d186a604ff2cbbcaf7af | Cast the Stat_t.Nlink to uint64 on arm64.
Since the syscall.Stat_t.Nlink is defined as different types on
amd64 and arm64(uint64 and uint32 respectively), we need to cast
them to a unified uint64 type in gVisor code. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/p9.go",
"new_path": "pkg/p9/p9.go",
"diff": "@@ -814,7 +814,7 @@ func StatToAttr(s *syscall.Stat_t, req AttrMask) (Attr, AttrMask) {\nattr.Mode = FileMode(s.Mode)\n}\nif req.NLink {\n- attr.NLink = s.Nlink\n+ attr.NLink = uint64(s.Nlink)\n}\nif req.UID ... | Go | Apache License 2.0 | google/gvisor | Cast the Stat_t.Nlink to uint64 on arm64.
Since the syscall.Stat_t.Nlink is defined as different types on
amd64 and arm64(uint64 and uint32 respectively), we need to cast
them to a unified uint64 type in gVisor code.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I7542b99b195c708f3fc49b1cbe6adebdd2f6e96b |
259,881 | 28.10.2019 10:18:55 | 25,200 | 198f1cddb82d46570ae63cb704b4a1b88cf0de1f | Update comment
FDTable.GetFile doesn't exist. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -709,9 +709,9 @@ func (t *Task) FDTable() *FDTable {\nreturn t.fdTable\n}\n-// GetFile is a convenience wrapper t.FDTable().GetFile.\n+// GetFile is a convenience wrapper t.FDTabl... | Go | Apache License 2.0 | google/gvisor | Update comment
FDTable.GetFile doesn't exist.
PiperOrigin-RevId: 277089842 |
259,992 | 28.10.2019 18:48:35 | 25,200 | dbeaf9d4dbeea4cde670c3d07a78b56a45fa8f21 | Deflake TestCheckpointRestore | [
{
"change_type": "MODIFY",
"old_path": "test/e2e/integration_test.go",
"new_path": "test/e2e/integration_test.go",
"diff": "@@ -175,6 +175,9 @@ func TestCheckpointRestore(t *testing.T) {\nt.Fatal(err)\n}\n+ // TODO(b/143498576): Remove after github.com/moby/moby/issues/38963 is fixed.\n+ time.Sleep(... | Go | Apache License 2.0 | google/gvisor | Deflake TestCheckpointRestore
PiperOrigin-RevId: 277189064 |
259,860 | 29.10.2019 10:03:18 | 25,200 | 29273b03842a85bce8314799348231520ceb6e9c | Disallow execveat on interpreter scripts with fd opened with O_CLOEXEC.
When an interpreter script is opened with O_CLOEXEC and the resulting fd is
passed into execveat, an ENOENT error should occur (the script would otherwise
be inaccessible to the interpreter). This matches the actual behavior of
Linux's execveat. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -812,6 +812,7 @@ func (k *Kernel) CreateProcess(args CreateProcessArgs) (*ThreadGroup, ThreadID,\nResolveFinal: true,\nFilename: args.Filename,\nFile: args.File,\n+ CloseOnExe... | Go | Apache License 2.0 | google/gvisor | Disallow execveat on interpreter scripts with fd opened with O_CLOEXEC.
When an interpreter script is opened with O_CLOEXEC and the resulting fd is
passed into execveat, an ENOENT error should occur (the script would otherwise
be inaccessible to the interpreter). This matches the actual behavior of
Linux's execveat.
PiperOrigin-RevId: 277306680 |
259,854 | 29.10.2019 11:19:04 | 25,200 | 7d80e85835fbe47b2395eedf287cf902ed78599a | Allow waiting for Endpoint worker goroutines to finish.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/registration.go",
"new_path": "pkg/tcpip/stack/registration.go",
"diff": "@@ -67,6 +67,20 @@ type TransportEndpoint interface {\n// HandleControlPacket is called by the stack when new control (e.g.,\n// ICMP) packets arrive to this transport en... | Go | Apache License 2.0 | google/gvisor | Allow waiting for Endpoint worker goroutines to finish.
Updates #837
PiperOrigin-RevId: 277325162 |
259,962 | 29.10.2019 12:15:33 | 25,200 | 392c56149531c82ef3c07e2899939c0d63f0980b | Fix PollWithFullBufferBlocks.
Set the snd/rcv buffer sizes so that the test is deterministic and runs in a
reasonable amount of time. It also ensures that we disable any auto-tuning of
the send/receive buffer which may happen. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tcp_socket.cc",
"new_path": "test/syscalls/linux/tcp_socket.cc",
"diff": "@@ -394,8 +394,15 @@ TEST_P(TcpSocketTest, PollWithFullBufferBlocks) {\nsizeof(tcp_nodelay_flag)),\nSyscallSucceeds());\n+ // Set a 256KB send/receive buffer.\n+ int ... | Go | Apache License 2.0 | google/gvisor | Fix PollWithFullBufferBlocks.
Set the snd/rcv buffer sizes so that the test is deterministic and runs in a
reasonable amount of time. It also ensures that we disable any auto-tuning of
the send/receive buffer which may happen.
PiperOrigin-RevId: 277337232 |
259,860 | 29.10.2019 12:50:03 | 25,200 | 2e00771d5abb3d821703965953c2b21ef7c20911 | Refactor logic for loadExecutable.
Separate the handling of filenames and *fs.File objects in a more explicit way
for the sake of clarity. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/loader.go",
"new_path": "pkg/sentry/loader/loader.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"fmt\"\n\"io\"\n\"path\"\n+ \"strings\"\n\"gvisor.dev/gvisor/pkg/abi\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -99,20 +100,20 @@ func readFull(ctx c... | Go | Apache License 2.0 | google/gvisor | Refactor logic for loadExecutable.
Separate the handling of filenames and *fs.File objects in a more explicit way
for the sake of clarity.
PiperOrigin-RevId: 277344203 |
259,881 | 29.10.2019 13:17:01 | 25,200 | c0b8fd4b6a9fcb595f3200577b93d07737cfaacd | Update build tags to allow Go 1.14
Currently there are no ABI changes. We should check again closer to release. | [
{
"change_type": "MODIFY",
"old_path": "pkg/procid/procid_amd64.s",
"new_path": "pkg/procid/procid_amd64.s",
"diff": "// +build amd64\n// +build go1.8\n-// +build !go1.14\n+// +build !go1.15\n#include \"textflag.h\"\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/procid/procid_arm64.s"... | Go | Apache License 2.0 | google/gvisor | Update build tags to allow Go 1.14
Currently there are no ABI changes. We should check again closer to release.
PiperOrigin-RevId: 277349744 |
259,860 | 29.10.2019 13:58:20 | 25,200 | d7f5e823e24501c33a377ee6c73210b00bf3d89f | Fix grammar in comment.
Missing "for". | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -709,7 +709,7 @@ func (t *Task) FDTable() *FDTable {\nreturn t.fdTable\n}\n-// GetFile is a convenience wrapper t.FDTable().Get.\n+// GetFile is a convenience wrapper for t.FDTabl... | Go | Apache License 2.0 | google/gvisor | Fix grammar in comment.
Missing "for".
PiperOrigin-RevId: 277358513 |
259,854 | 29.10.2019 16:13:43 | 25,200 | a2c51efe3669f0380042b2375eae79e403d3680c | Add endpoint tracking to the stack.
In the future this will replace DanglingEndpoints. DanglingEndpoints must be
kept for now due to issues with save/restore.
This is arguably a cleaner design and allows the stack to know which transport
endpoints might still be using its link endpoints.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/inet/BUILD",
"new_path": "pkg/sentry/inet/BUILD",
"diff": "@@ -13,5 +13,8 @@ go_library(\n\"test_stack.go\",\n],\nimportpath = \"gvisor.dev/gvisor/pkg/sentry/inet\",\n- deps = [\"//pkg/sentry/context\"],\n+ deps = [\n+ \"//pkg/sentry/context\",\n+ \... | Go | Apache License 2.0 | google/gvisor | Add endpoint tracking to the stack.
In the future this will replace DanglingEndpoints. DanglingEndpoints must be
kept for now due to issues with save/restore.
This is arguably a cleaner design and allows the stack to know which transport
endpoints might still be using its link endpoints.
Updates #837
PiperOrigin-RevId: 277386633 |
259,854 | 29.10.2019 17:21:01 | 25,200 | dc21c5ca16dbc43755185ffdf53764c7bb4c3a12 | Add Close and Wait methods to stack.
Link endpoints still don't have a unified way to be requested to stop.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1210,6 +1210,37 @@ func (s *Stack) RestoreCleanupEndpoints(es []TransportEndpoint) {\ns.mu.Unlock()\n}\n+// Close closes all currently registered transport endpoints.\n+//\n+// End... | Go | Apache License 2.0 | google/gvisor | Add Close and Wait methods to stack.
Link endpoints still don't have a unified way to be requested to stop.
Updates #837
PiperOrigin-RevId: 277398952 |
259,974 | 30.10.2019 03:06:34 | 0 | 80d0db274ef88f4c53d2d08df52c0f9c58ca53ac | Enable runsc/fsgofer support on arm64.
newfstatat() syscall is not supported on arm64, so we resort
to use the fstatat() syscall. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/BUILD",
"new_path": "runsc/fsgofer/BUILD",
"diff": "@@ -6,6 +6,8 @@ go_library(\nname = \"fsgofer\",\nsrcs = [\n\"fsgofer.go\",\n+ \"fsgofer_amd64_unsafe.go\",\n+ \"fsgofer_arm64_unsafe.go\",\n\"fsgofer_unsafe.go\",\n],\nimportpath = \"gvisor.dev... | Go | Apache License 2.0 | google/gvisor | Enable runsc/fsgofer support on arm64.
newfstatat() syscall is not supported on arm64, so we resort
to use the fstatat() syscall.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I9e89d46c5ec9ae07db201c9da5b6dda9bfd2eaf0 |
259,860 | 30.10.2019 13:29:56 | 25,200 | 8bc7b8dba2dcc339ab5bd1b05c83f74a6211a7d0 | Clean up typos in test names. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"new_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"diff": "namespace gvisor {\nnamespace testing {\n-TEST_P(TCPSocketPairTest, TcpInfoSucceedes) {\n+TEST_P(TCPSocketPairTest, TcpInfoSucceeds) {\nauto soc... | Go | Apache License 2.0 | google/gvisor | Clean up typos in test names.
PiperOrigin-RevId: 277572791 |
259,853 | 30.10.2019 15:32:20 | 25,200 | db37483cb6acf55b66132d534bb734f09555b1cf | Store endpoints inside multiPortEndpoint in a sorted order
It is required to guarantee the same order of endpoints after save/restore. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/registration.go",
"new_path": "pkg/tcpip/stack/registration.go",
"diff": "@@ -60,6 +60,9 @@ const (\n// TransportEndpoint is the interface that needs to be implemented by transport\n// protocol (e.g., tcp, udp) endpoints that can handle packets... | Go | Apache License 2.0 | google/gvisor | Store endpoints inside multiPortEndpoint in a sorted order
It is required to guarantee the same order of endpoints after save/restore.
PiperOrigin-RevId: 277598665 |
259,847 | 30.10.2019 16:14:30 | 25,200 | df125c986948fbbae2bc30de33213e2095762a86 | Add Kokoro config for new runtime tests | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/runtime_tests.cfg",
"diff": "+build_file: \"repo/scripts/runtime_tests.sh\"\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "scripts/runtime_tests.sh",
"diff": "+#!/bin/bash\n+\n+# Copyright 2019 The gVisor... | Go | Apache License 2.0 | google/gvisor | Add Kokoro config for new runtime tests
PiperOrigin-RevId: 277607217 |
259,891 | 30.10.2019 17:00:29 | 25,200 | 3246040447c6d0a08cc12c5721480c06f77f5dfe | Deep copy dispatcher views.
When VectorisedViews were passed up the stack from packet_dispatchers, we were
passing a sub-slice of the dispatcher's views fields. The dispatchers then
immediately set those views to nil.
This wasn't caught before because every implementer copied the data in these
views before returning. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint_test.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint_test.go",
"diff": "@@ -45,7 +45,7 @@ const (\ntype packetInfo struct {\nraddr tcpip.LinkAddress\nproto tcpip.NetworkProtocolNumber\n- contents buffer.View\n+ contents buffer... | Go | Apache License 2.0 | google/gvisor | Deep copy dispatcher views.
When VectorisedViews were passed up the stack from packet_dispatchers, we were
passing a sub-slice of the dispatcher's views fields. The dispatchers then
immediately set those views to nil.
This wasn't caught before because every implementer copied the data in these
views before returning.
PiperOrigin-RevId: 277615351 |
259,847 | 31.10.2019 11:25:19 | 25,200 | 7dcfcd53e4f3f0e1384ac42eacf2622a57d1b37c | Fix overloaded use of $RUNTIME.
Turns out we use $RUNTIME in scripts/common.sh to give a name to the runsc
runtime used by the tests. | [
{
"change_type": "MODIFY",
"old_path": "scripts/runtime_tests.sh",
"new_path": "scripts/runtime_tests.sh",
"diff": "source $(dirname $0)/common.sh\n-if [ ! -v RUNTIME ]; then\n- echo 'Must set $RUNTIME' >&2\n+if [ ! -v RUNTIME_TEST_NAME ]; then\n+ echo 'Must set $RUNTIME_TEST_NAME' >&2\nexit 1\nfi\n... | Go | Apache License 2.0 | google/gvisor | Fix overloaded use of $RUNTIME.
Turns out we use $RUNTIME in scripts/common.sh to give a name to the runsc
runtime used by the tests.
PiperOrigin-RevId: 277764383 |
259,853 | 31.10.2019 12:27:46 | 25,200 | f7dbddaf77a6059c2f5a441d068a39219fe593bd | platform/kvm: calll sigtimedwait with zero timeout
sigtimedwait is used to check pending signals and
it should not block. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go",
"diff": "@@ -80,13 +80,17 @@ func bluepillHandler(context unsafe.Pointer) {\n// interrupted KVM. Since we're in a signal handler\n// currently, all signals a... | Go | Apache License 2.0 | google/gvisor | platform/kvm: calll sigtimedwait with zero timeout
sigtimedwait is used to check pending signals and
it should not block.
PiperOrigin-RevId: 277777269 |
259,858 | 31.10.2019 12:51:50 | 25,200 | fe2e0764ac600fe19a3d87069a58d7463a5223ab | Add LICENSE and AUTHORS to the go branch.
Also, construct the README directly so that edits can be made. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_branch.sh",
"new_path": "tools/go_branch.sh",
"diff": "set -eo pipefail\n# Discovery the package name from the go.mod file.\n-declare -r gomod=\"$(pwd)/go.mod\"\n-declare -r module=$(cat \"${gomod}\" | grep -E \"^module\" | cut -d' ' -f2)\n-declare -r... | Go | Apache License 2.0 | google/gvisor | Add LICENSE and AUTHORS to the go branch.
Also, construct the README directly so that edits can be made.
PiperOrigin-RevId: 277782095 |
259,884 | 31.10.2019 17:37:54 | 25,200 | 36837c4ad3f3c840791379db81d02b60d918c0f5 | Add systemd-cgroup flag option.
Adds a systemd-cgroup flag option that prints an error letting the user know
that systemd cgroups are not supported and points them to the relevant issue.
Issue | [
{
"change_type": "MODIFY",
"old_path": "runsc/main.go",
"new_path": "runsc/main.go",
"diff": "@@ -46,6 +46,8 @@ var (\nlogFormat = flag.String(\"log-format\", \"text\", \"log format: text (default), json, or json-k8s.\")\ndebug = flag.Bool(\"debug\", false, \"enable debug logging.\")\nshowVersion = ... | Go | Apache License 2.0 | google/gvisor | Add systemd-cgroup flag option.
Adds a systemd-cgroup flag option that prints an error letting the user know
that systemd cgroups are not supported and points them to the relevant issue.
Issue #193
PiperOrigin-RevId: 277837162 |
259,858 | 31.10.2019 18:02:04 | 25,200 | a99d3479a84ca86843e500dbdf58db0af389b536 | Add context to state. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/context/context.go",
"new_path": "pkg/sentry/context/context.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// Package context defines the sentry's Context type.\n+// Package... | Go | Apache License 2.0 | google/gvisor | Add context to state.
PiperOrigin-RevId: 277840416 |
259,853 | 01.11.2019 11:21:06 | 25,200 | af6af2c34131c4ec5e3195be99c1deb6a2669c06 | tests: don't use ASSERT_THAT after fork | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/semaphore.cc",
"new_path": "test/syscalls/linux/semaphore.cc",
"diff": "@@ -447,9 +447,8 @@ TEST(SemaphoreTest, SemCtlGetPidFork) {\nconst pid_t child_pid = fork();\nif (child_pid == 0) {\n- ASSERT_THAT(semctl(sem.get(), 0, SETVAL, 1), Sysc... | Go | Apache License 2.0 | google/gvisor | tests: don't use ASSERT_THAT after fork
PiperOrigin-RevId: 277965624 |
259,885 | 01.11.2019 11:43:33 | 25,200 | 5694bd080e0e95ba18cbf77038f450fe33b9f8df | Don't log "p9.channel.service: flipcall connection shutdown".
This gets quite spammy, especially in tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/flipcall/ctrl_futex.go",
"new_path": "pkg/flipcall/ctrl_futex.go",
"diff": "@@ -113,7 +113,7 @@ func (ep *Endpoint) enterFutexWait() error {\nreturn nil\ncase epsBlocked | epsShutdown:\natomic.AddInt32(&ep.ctrl.state, -epsBlocked)\n- return shutdownError{}... | Go | Apache License 2.0 | google/gvisor | Don't log "p9.channel.service: flipcall connection shutdown".
This gets quite spammy, especially in tests.
PiperOrigin-RevId: 277970468 |
259,881 | 04.11.2019 09:54:14 | 28,800 | 3b4f5445d03f7d2f170d68a8a4969b8acbad773e | Update membarrier bug
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64_amd64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64_amd64.go",
"diff": "@@ -364,7 +364,7 @@ var AMD64 = &kernel.SyscallTable{\n321: syscalls.CapError(\"bpf\", linux.CAP_SYS_ADMIN, \"\", nil),\n322: syscalls.Supported(\"e... | Go | Apache License 2.0 | google/gvisor | Update membarrier bug
Updates #267
PiperOrigin-RevId: 278402684 |
259,891 | 04.11.2019 10:56:13 | 28,800 | 4fdd69d681bb3abb68a043377a2fb0ec8a031d54 | Check that a file is a regular file with open(O_TRUNC).
It was possible to panic the sentry by opening a cache revalidating folder with
O_TRUNC|O_CREAT. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode_operations.go",
"new_path": "pkg/sentry/fs/inode_operations.go",
"diff": "@@ -221,6 +221,8 @@ type InodeOperations interface {\n// sys_ftruncate.\n//\n// Implementations need not check that length >= 0.\n+ //\n+ // Truncate must only be cal... | Go | Apache License 2.0 | google/gvisor | Check that a file is a regular file with open(O_TRUNC).
It was possible to panic the sentry by opening a cache revalidating folder with
O_TRUNC|O_CREAT.
PiperOrigin-RevId: 278417533 |
259,853 | 04.11.2019 15:59:11 | 28,800 | 493334f8b594eb1c2b0f5a6133dbedad4e0ecd32 | kokoro: run KVM syscall tests
We don't know how stable they are, so let's start with warning. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/syscall_kvm_tests.cfg",
"diff": "+build_file: \"repo/scripts/syscall_kvm_tests.sh\"\n+\n+action {\n+ define_artifacts {\n+ regex: \"**/sponge_log.xml\"\n+ regex: \"**/sponge_log.log\"\n+ regex: \"**/outputs.zip\"\n+ }\n+}\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | kokoro: run KVM syscall tests
We don't know how stable they are, so let's start with warning.
PiperOrigin-RevId: 278484186 |
259,853 | 05.11.2019 17:02:15 | 28,800 | 57f6dbc4be5c9c5416c9d3a442eacfb797e57e9c | test/root: check that memory accouting works as expected | [
{
"change_type": "MODIFY",
"old_path": "test/root/cgroup_test.go",
"new_path": "test/root/cgroup_test.go",
"diff": "@@ -24,6 +24,7 @@ import (\n\"strconv\"\n\"strings\"\n\"testing\"\n+ \"time\"\n\"gvisor.dev/gvisor/runsc/cgroup\"\n\"gvisor.dev/gvisor/runsc/dockerutil\"\n@@ -55,6 +56,59 @@ func verif... | Go | Apache License 2.0 | google/gvisor | test/root: check that memory accouting works as expected
PiperOrigin-RevId: 278739427 |
259,962 | 06.11.2019 22:28:41 | 28,800 | 3552691137284525a33d3de7e3c2d170da66c8ac | Fix data race in syscall_test_runner.go
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/syscall_test_runner.go",
"new_path": "test/syscalls/syscall_test_runner.go",
"diff": "@@ -208,14 +208,15 @@ func runRunsc(tc gtest.TestCase, spec *specs.Spec) error {\n}\nlog.Warningf(\"%s: Got signal: %v\", name, s)\ndone := make(chan bool)\n- g... | Go | Apache License 2.0 | google/gvisor | Fix data race in syscall_test_runner.go
Fixes #1140
PiperOrigin-RevId: 279012793 |
259,962 | 06.11.2019 23:50:54 | 28,800 | 2326224a9652201938df2881be055ab352672587 | Fix yet another data race.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/syscall_test_runner.go",
"new_path": "test/syscalls/syscall_test_runner.go",
"diff": "@@ -229,7 +229,7 @@ func runRunsc(tc gtest.TestCase, spec *specs.Spec) error {\ndArgs = append(args, \"debug\",\nfmt.Sprintf(\"--signal=%d\", syscall.SIGTERM),\... | Go | Apache License 2.0 | google/gvisor | Fix yet another data race.
Fixes #1140
PiperOrigin-RevId: 279020846 |
259,853 | 08.11.2019 14:07:34 | 28,800 | 50d6236111485acce0e728794c4f53884097ea7d | Update kokoro images to install junitparser
junitparser will be used to merge junit xml files. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/ubuntu1604/40_kokoro.sh",
"new_path": "kokoro/ubuntu1604/40_kokoro.sh",
"diff": "@@ -23,7 +23,10 @@ declare -r ssh_public_keys=(\n)\n# Install dependencies.\n-apt-get update && apt-get install -y rsync coreutils python-psutil qemu-kvm\n+apt-get update &... | Go | Apache License 2.0 | google/gvisor | Update kokoro images to install junitparser
junitparser will be used to merge junit xml files.
PiperOrigin-RevId: 279387305 |
259,853 | 08.11.2019 15:43:47 | 28,800 | 14f4461f93a4c0014314a35a374ce07eec25636c | kokoro: update images to install zip | [
{
"change_type": "MODIFY",
"old_path": "kokoro/ubuntu1604/40_kokoro.sh",
"new_path": "kokoro/ubuntu1604/40_kokoro.sh",
"diff": "@@ -23,7 +23,7 @@ declare -r ssh_public_keys=(\n)\n# Install dependencies.\n-apt-get update && apt-get install -y rsync coreutils python-psutil qemu-kvm python-pip\n+apt-ge... | Go | Apache License 2.0 | google/gvisor | kokoro: update images to install zip
PiperOrigin-RevId: 279406266 |
259,853 | 08.11.2019 16:39:25 | 28,800 | b91ad8fa0950c752ab08af7d08727d5a97b14b12 | test: merge log files of all shards for each test suite
This significantly speeds up a process of uploading this files
to sponge and resultstore by kokoro. | [
{
"change_type": "MODIFY",
"old_path": "scripts/common_bazel.sh",
"new_path": "scripts/common_bazel.sh",
"diff": "@@ -71,6 +71,13 @@ function run_as_root() {\nfunction collect_logs() {\n# Zip out everything into a convenient form.\nif [[ -v KOKORO_ARTIFACTS_DIR ]] && [[ -e bazel-testlogs ]]; then\n+... | Go | Apache License 2.0 | google/gvisor | test: merge log files of all shards for each test suite
This significantly speeds up a process of uploading this files
to sponge and resultstore by kokoro.
PiperOrigin-RevId: 279416349 |
259,847 | 11.11.2019 14:41:44 | 28,800 | e09e7bf72f3e0208c7f557d9931407ee8729ebb2 | Add more extended features. | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid.go",
"new_path": "pkg/cpuid/cpuid.go",
"diff": "@@ -183,6 +183,33 @@ const (\nX86FeatureAVX512VBMI\nX86FeatureUMIP\nX86FeaturePKU\n+ X86FeatureOSPKE\n+ X86FeatureWAITPKG\n+ X86FeatureAVX512_VBMI2\n+ _ // ecx bit 7 is reserved\n+ X86FeatureGFNI\... | Go | Apache License 2.0 | google/gvisor | Add more extended features.
PiperOrigin-RevId: 279820435 |
259,962 | 11.11.2019 15:49:49 | 28,800 | 2b0e4dc6aa7fb8a3f619220b72537a8fff2f95b4 | Remove obsolete TODO. This is now fixed. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tcp_socket.cc",
"new_path": "test/syscalls/linux/tcp_socket.cc",
"diff": "@@ -425,6 +425,11 @@ TEST_P(TcpSocketTest, PollWithFullBufferBlocks) {\n}\n// The last error should have been EWOULDBLOCK.\nASSERT_EQ(errno, EWOULDBLOCK);\n+\n+ // No... | Go | Apache License 2.0 | google/gvisor | Remove obsolete TODO. This is now fixed.
PiperOrigin-RevId: 279835100 |
259,854 | 11.11.2019 18:34:28 | 28,800 | b82bd24f9495435cadd2713db829b19ce8fcce9d | Update ephemeral port reservation tests.
The existing tests which are disabled on gVisor are failing because we default
to SO_REUSEADDR being enabled for TCP sockets. Update the test comments.
Also add new tests for enabled SO_REUSEADDR. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -1156,9 +1156,8 @@ TEST_P(SocketMultiProtocolInetLoopbackTest, V6OnlyV6AnyReservesV6) {\nsockaddr_storage addr_dual = test_addr_dual.addr;\ncon... | Go | Apache License 2.0 | google/gvisor | Update ephemeral port reservation tests.
The existing tests which are disabled on gVisor are failing because we default
to SO_REUSEADDR being enabled for TCP sockets. Update the test comments.
Also add new tests for enabled SO_REUSEADDR.
PiperOrigin-RevId: 279862275 |
259,853 | 12.11.2019 12:00:16 | 28,800 | 548d65b2b6116beecb2aa782a0b5428fb20f89a0 | kokoro: correct a path to outputs.zip | [
{
"change_type": "MODIFY",
"old_path": "scripts/common_bazel.sh",
"new_path": "scripts/common_bazel.sh",
"diff": "@@ -75,7 +75,7 @@ function collect_logs() {\nfor d in `find -L \"bazel-testlogs\" -name 'shard_*_of_*' | xargs dirname | sort | uniq`; do\njunitparser merge `find $d -name test.xml` $d/t... | Go | Apache License 2.0 | google/gvisor | kokoro: correct a path to outputs.zip
PiperOrigin-RevId: 280021914 |
259,853 | 12.11.2019 15:58:41 | 28,800 | ca9cba66d2062811db9fa2b89a610f8eaa13fe99 | seccomp: introduce the GreaterThan rule type | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp.go",
"new_path": "pkg/seccomp/seccomp.go",
"diff": "@@ -199,6 +199,10 @@ func ruleViolationLabel(ruleSetIdx int, sysno uintptr, idx int) string {\nreturn fmt.Sprintf(\"ruleViolation_%v_%v_%v\", ruleSetIdx, sysno, idx)\n}\n+func ruleLabel(ru... | Go | Apache License 2.0 | google/gvisor | seccomp: introduce the GreaterThan rule type
PiperOrigin-RevId: 280075805 |
259,974 | 11.11.2019 08:20:18 | 0 | 05871a1cdc73e98df58f56841be23a4eac27225c | Enable runsc/boot support on arm64.
This patch also include a minor change to replace syscall.Dup2
with syscall.Dup3 which was missed in a previous commit(ref a25a976). | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp_test_victim.go",
"new_path": "pkg/seccomp/seccomp_test_victim.go",
"diff": "@@ -38,7 +38,7 @@ func main() {\nsyscall.SYS_CLONE: {},\nsyscall.SYS_CLOSE: {},\nsyscall.SYS_DUP: {},\n- syscall.SYS_DUP2: {},\n+ syscall.SYS_DUP3: {},\nsyscall.SYS... | Go | Apache License 2.0 | google/gvisor | Enable runsc/boot support on arm64.
This patch also include a minor change to replace syscall.Dup2
with syscall.Dup3 which was missed in a previous commit(ref a25a976).
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I00beb9cc492e44c762ebaa3750201c63c1f7c2f3 |
259,974 | 11.11.2019 09:15:45 | 0 | c5d9b5b8816e99507661e1d39ec51033fb69e212 | Enable sentry/fs/host support on arm64.
newfstatat() syscall is not supported on arm64, so we resort
to use the fstatat() syscall. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/BUILD",
"new_path": "pkg/sentry/fs/host/BUILD",
"diff": "@@ -21,6 +21,8 @@ go_library(\n\"socket_unsafe.go\",\n\"tty.go\",\n\"util.go\",\n+ \"util_amd64_unsafe.go\",\n+ \"util_arm64_unsafe.go\",\n\"util_unsafe.go\",\n],\nimportpath = \"gviso... | Go | Apache License 2.0 | google/gvisor | Enable sentry/fs/host support on arm64.
newfstatat() syscall is not supported on arm64, so we resort
to use the fstatat() syscall.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: Iea95550ea53bcf85c01f7b3b95da70ad0952177d |
259,974 | 11.11.2019 09:42:04 | 0 | 1d8b7292d72ce93d465e4ded19237fb92c08bc56 | Fix some build errors on arm64.
Initialize the VDSO "os" and "arch" fields explicitly,
or the VDSO load process would failed on arm64 platform. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/ptrace_arm64.go",
"new_path": "pkg/sentry/kernel/ptrace_arm64.go",
"diff": "package kernel\nimport (\n- \"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/sentry/usermem\"\n\"gvisor.dev/gvisor/pkg/syserror\"\n)\n"
},
{
"chan... | Go | Apache License 2.0 | google/gvisor | Fix some build errors on arm64.
Initialize the VDSO "os" and "arch" fields explicitly,
or the VDSO load process would failed on arm64 platform.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: Ic6768df88e43cd7c7956eb630511672ae11ac52f |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.