author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,962 | 13.11.2019 14:27:46 | 28,800 | 6dd4c9ee74828b27cd12ea343756f5625bae683c | Fix flaky behaviour during S/R. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1229,7 +1229,9 @@ func (e *endpoint) protocolMainLoop(handshake bool) *tcpip.Error {\nreturn err\n}\n}\n- if e.state != StateError {\n+ if e.state != StateClose... | Go | Apache License 2.0 | google/gvisor | Fix flaky behaviour during S/R.
PiperOrigin-RevId: 280280156 |
259,853 | 13.11.2019 15:34:47 | 28,800 | 1e55eb3800a60c1a1118b84f2534b78481702f38 | test/syscalls/proc: check an return code of waitid | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -183,7 +183,8 @@ PosixError WithSubprocess(SubprocessCallback const& running,\nsiginfo_t info;\n// Wait until the child process has exited (WEXITED flag) but don't\n// reap th... | Go | Apache License 2.0 | google/gvisor | test/syscalls/proc: check an return code of waitid
PiperOrigin-RevId: 280295208 |
259,884 | 14.11.2019 13:32:40 | 18,000 | b94ef2075a78c3d7c6e479f152e48ab85db0f84e | Added info on styles to README | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -61,6 +61,27 @@ go run main.go\nAccess the site at http://localhost:8080\n+## Updating Styles\n+\n+If you want to update style on the website you can do this by updating\n+templates or CSS for the website. Check... | Go | Apache License 2.0 | google/gvisor | Added info on styles to README |
259,885 | 14.11.2019 14:03:24 | 28,800 | 9ca15dbf14ac6318a34540354020b8a71d789077 | Avoid unnecessary slice allocation in usermem.BytesIO.blocksFromAddrRanges(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/usermem/bytes_io.go",
"new_path": "pkg/sentry/usermem/bytes_io.go",
"diff": "@@ -102,12 +102,18 @@ func (b *BytesIO) rangeCheck(addr Addr, length int) (int, error) {\n}\nfunc (b *BytesIO) blocksFromAddrRanges(ars AddrRangeSeq) (safemem.BlockSeq, err... | Go | Apache License 2.0 | google/gvisor | Avoid unnecessary slice allocation in usermem.BytesIO.blocksFromAddrRanges().
PiperOrigin-RevId: 280507239 |
259,891 | 14.11.2019 15:04:25 | 28,800 | 1e1f5ce08210af6211bcb1c8da293a63a79165fe | Allow all runtime tests for a language to be run via a single command.
This was intended behavior per the README, but running tests without the --test
flag caused an error. Users can now omit the --test flag to run every test for a
runtime. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/images/proctor/proctor.go",
"new_path": "test/runtimes/images/proctor/proctor.go",
"diff": "@@ -41,7 +41,7 @@ type TestRunner interface {\nvar (\nruntime = flag.String(\"runtime\", \"\", \"name of runtime\")\nlist = flag.Bool(\"list\", false, \"l... | Go | Apache License 2.0 | google/gvisor | Allow all runtime tests for a language to be run via a single command.
This was intended behavior per the README, but running tests without the --test
flag caused an error. Users can now omit the --test flag to run every test for a
runtime.
PiperOrigin-RevId: 280522025 |
259,891 | 14.11.2019 15:55:07 | 28,800 | 339536de5eefe782813aabae4aeeb312b3c4dde7 | Check that a file is a regular file with open(O_TRUNC).
It was possible to panic the sentry by opening a cache revalidating folder with
O_TRUNC|O_CREAT.
Avoids breaking php tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode.go",
"new_path": "pkg/sentry/fs/inode.go",
"diff": "@@ -344,6 +344,10 @@ func (i *Inode) SetTimestamps(ctx context.Context, d *Dirent, ts TimeSpec) error\n// Truncate calls i.InodeOperations.Truncate with i as the Inode.\nfunc (i *Inode) Tr... | Go | Apache License 2.0 | google/gvisor | Check that a file is a regular file with open(O_TRUNC).
It was possible to panic the sentry by opening a cache revalidating folder with
O_TRUNC|O_CREAT.
Avoids breaking php tests.
PiperOrigin-RevId: 280533213 |
260,003 | 14.11.2019 17:02:59 | 28,800 | af323eb7c1830053627de6161f8ce73ac5f06d4e | Fix return codes for {get,set}sockopt for some nullptr cases.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"new_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"diff": "@@ -447,17 +447,14 @@ func GetSockOpt(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sy\nreturn 0, nil, syserror.ENOTSOCK\n}\n- // Read the... | Go | Apache License 2.0 | google/gvisor | Fix return codes for {get,set}sockopt for some nullptr cases.
Updates #1092
PiperOrigin-RevId: 280547239 |
259,891 | 14.11.2019 22:54:01 | 28,800 | 23574b1b87ce5aed7b78a53663eac61ae030e9d5 | Fix panic when logging raw packets via sniffer.
Sniffer assumed that outgoing packets have transport headers, but
users can write packets via SOCK_RAW with arbitrary transport headers that
netstack doesn't know about. We now explicitly check for the presence of network
and transport headers before assuming they exist. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sniffer/sniffer.go",
"new_path": "pkg/tcpip/link/sniffer/sniffer.go",
"diff": "@@ -118,7 +118,7 @@ func NewWithFile(lower stack.LinkEndpoint, file *os.File, snapLen uint32) (stack\n// logs the packet before forwarding to the actual dispatcher.\n... | Go | Apache License 2.0 | google/gvisor | Fix panic when logging raw packets via sniffer.
Sniffer assumed that outgoing packets have transport headers, but
users can write packets via SOCK_RAW with arbitrary transport headers that
netstack doesn't know about. We now explicitly check for the presence of network
and transport headers before assuming they exist.
PiperOrigin-RevId: 280594395 |
259,885 | 15.11.2019 11:39:25 | 28,800 | 76039f895995c3fe0deef5958f843868685ecc38 | Do not set finalizer on p9.ClientFile.
Aside from the performance hit, there is no guarantee that p9.ClientFile's
finalizer runs before the associated p9.Client is closed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/client_file.go",
"new_path": "pkg/p9/client_file.go",
"diff": "@@ -17,7 +17,6 @@ package p9\nimport (\n\"fmt\"\n\"io\"\n- \"runtime\"\n\"sync/atomic\"\n\"syscall\"\n@@ -45,15 +44,10 @@ func (c *Client) Attach(name string) (File, error) {\n// newFile ret... | Go | Apache License 2.0 | google/gvisor | Do not set finalizer on p9.ClientFile.
Aside from the performance hit, there is no guarantee that p9.ClientFile's
finalizer runs before the associated p9.Client is closed.
PiperOrigin-RevId: 280702509 |
260,023 | 15.11.2019 11:44:02 | 28,800 | 3e534f2974f469a889534221b83c3bbbd1b0318c | Handle in-flight TCP segments when moving to CLOSE.
As we move to CLOSE state from LAST-ACK or TIME-WAIT,
ensure that we re-match all in-flight segments to any
listening endpoint.
Also fix LISTEN state handling of any ACK segments as per RFC793.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -419,8 +419,8 @@ func (e *endpoint) handleListenSegment(ctx *listenContext, s *segment) {\n// TODO(b/143300739): Use the userMSS of the listening socket\n// for ac... | Go | Apache License 2.0 | google/gvisor | Handle in-flight TCP segments when moving to CLOSE.
As we move to CLOSE state from LAST-ACK or TIME-WAIT,
ensure that we re-match all in-flight segments to any
listening endpoint.
Also fix LISTEN state handling of any ACK segments as per RFC793.
Fixes #1153
PiperOrigin-RevId: 280703556 |
259,858 | 18.11.2019 11:21:18 | 28,800 | 96019436854b0c59ae380a4920381586d05d9c31 | release: fix tag script
The tag script, when not run interactively, will fail without a provided commit
message (since it now uses annotated tags). For now, use a trivial message. In
the future, this could be extended to provide automated release notes. | [
{
"change_type": "MODIFY",
"old_path": "tools/tag_release.sh",
"new_path": "tools/tag_release.sh",
"diff": "@@ -64,5 +64,6 @@ fi\n# Tag the given commit (annotated, to record the committer).\ndeclare -r tag=\"release-${release}\"\n-(git tag -a \"${tag}\" \"${commit}\" && git push origin tag \"${tag}... | Go | Apache License 2.0 | google/gvisor | release: fix tag script
The tag script, when not run interactively, will fail without a provided commit
message (since it now uses annotated tags). For now, use a trivial message. In
the future, this could be extended to provide automated release notes.
PiperOrigin-RevId: 281112651 |
259,853 | 18.11.2019 14:55:30 | 28,800 | 26b3341b9ae08bb72971d5465c77e6c8db82c996 | platform/ptrace: use host.GetCPU instead of the getcpu syscall
This should save ~200ns from switchToApp (on ptrace too). // mpratt | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/BUILD",
"new_path": "pkg/sentry/platform/ptrace/BUILD",
"diff": "@@ -28,6 +28,7 @@ go_library(\n\"//pkg/procid\",\n\"//pkg/seccomp\",\n\"//pkg/sentry/arch\",\n+ \"//pkg/sentry/hostcpu\",\n\"//pkg/sentry/platform\",\n\"//pkg/sentry/pl... | Go | Apache License 2.0 | google/gvisor | platform/ptrace: use host.GetCPU instead of the getcpu syscall
This should save ~200ns from switchToApp (on ptrace too). // mpratt
PiperOrigin-RevId: 281159895 |
259,885 | 18.11.2019 16:25:03 | 28,800 | ef6f93625457c166628fc9de57c15d986ae83159 | Add vfs.GenericParseMountOptions().
Equivalent to fs.GenericMountSourceOptions(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/BUILD",
"new_path": "pkg/sentry/vfs/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_library(\n\"file_description.go\",\n\"file_description_impl_util.go\",\n\"filesystem.go\",\n+ \"filesystem_impl_util.go\",\n\"filesystem_type.go\",\n\"mount.go\",\n\"mount... | Go | Apache License 2.0 | google/gvisor | Add vfs.GenericParseMountOptions().
Equivalent to fs.GenericMountSourceOptions().
PiperOrigin-RevId: 281179287 |
259,884 | 18.10.2019 05:28:45 | 14,400 | d9f1d86286a2a376f554d43a69c9ee849f1b83ab | Added base blog content. | [
{
"change_type": "MODIFY",
"old_path": "config.toml",
"new_path": "config.toml",
"diff": "@@ -35,8 +35,12 @@ pygmentsStyle = \"tango\"\nweight = -100\nurl = \"/docs/\"\n[[menu.main]]\n- name = \"GitHub\"\n+ name = \"Blog\"\nweight = -99\n+ url = \"/blog/\"\n+[[menu.main]]\n+ name = \"GitHub\"\n+ wei... | Go | Apache License 2.0 | google/gvisor | Added base blog content. |
259,884 | 12.11.2019 19:00:30 | 18,000 | a253368f7695c33ce88a2363426c710f0069500e | Add fragment links only on docs pages
Add fragment links only on docs pages and only when there is an 'id'
attribute. | [
{
"change_type": "MODIFY",
"old_path": "layouts/partials/scripts.html",
"new_path": "layouts/partials/scripts.html",
"diff": "{{ partial \"hooks/body-end.html\" . }}\n<script type=\"text/javascript\">\n+ if (location.pathname == \"/docs\" || location.pathname.startsWith(\"/docs/\")) {\n$(\"body.td-p... | Go | Apache License 2.0 | google/gvisor | Add fragment links only on docs pages
Add fragment links only on docs pages and only when there is an 'id'
attribute. |
259,975 | 15.11.2019 10:02:02 | 28,800 | de56e7893445b09c9854ff6f79c4ed187e01be52 | Adding first blog post. | [
{
"change_type": "ADD",
"old_path": "content/blog/1_security_basics/figure1.png",
"new_path": "content/blog/1_security_basics/figure1.png",
"diff": "Binary files /dev/null and b/content/blog/1_security_basics/figure1.png differ\n"
},
{
"change_type": "ADD",
"old_path": "content/blog/1_se... | Go | Apache License 2.0 | google/gvisor | Adding first blog post. |
259,884 | 18.10.2019 01:37:17 | 14,400 | 00471432c45e215081020b0fac54a27f4bcbf565 | Update to Go 1.12 runtime.
Update to the Go 1.12 runtime.
The login option in app.yaml is no longer supported. Check the
X-Appengine-Cron http header instead.
Add a 'stage' make target that allows you to easily stage a change. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -14,7 +14,7 @@ APP_TARGET = $(patsubst cmd/gvisor-website/%,public/%,$(APP_SOURCE))\ndefault: website\n.PHONY: default\n-website: all-upstream app public/static\n+website: all-upstream app static-production\n.PHON... | Go | Apache License 2.0 | google/gvisor | Update to Go 1.12 runtime.
Update to the Go 1.12 runtime.
- The login option in app.yaml is no longer supported. Check the
X-Appengine-Cron http header instead.
- Add a 'stage' make target that allows you to easily stage a change. |
259,858 | 20.11.2019 15:28:02 | 28,800 | b6a00aa375e674617f1914b90db5ddb222b5a04e | Use a GitHub credential for tagging a release. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/release.cfg",
"new_path": "kokoro/release.cfg",
"diff": "build_file: \"repo/scripts/release.sh\"\n+\n+before_action {\n+ fetch_keystore {\n+ keystore_resource {\n+ keystore_config_id: 73898\n+ keyname: \"kokoro-github-access-token\"\n+ }\n+ }\n+}\n+\n+e... | Go | Apache License 2.0 | google/gvisor | Use a GitHub credential for tagging a release.
PiperOrigin-RevId: 281617882 |
259,858 | 05.11.2019 17:55:06 | 18,000 | 4e4d55b9436df5a8e284074c5dda5cffca262005 | Re-add apt-based installation instructions. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/install.md",
"new_path": "content/docs/user_guide/install.md",
"diff": "@@ -13,12 +13,21 @@ release channels. You should pick the version you'd like to install. For\nexperimentation, the nightly release is recommended. For production us... | Go | Apache License 2.0 | google/gvisor | Re-add apt-based installation instructions. |
259,853 | 22.11.2019 10:42:57 | 28,800 | 4e27ba372e12e3186c0d03b32a7829b0d50f7a89 | tests: include sys/socket.h before linux/if_arp.h
This is how it has to be accoding to the man page. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_netlink_util.h",
"new_path": "test/syscalls/linux/socket_netlink_util.h",
"diff": "#ifndef GVISOR_TEST_SYSCALLS_SOCKET_NETLINK_UTIL_H_\n#define GVISOR_TEST_SYSCALLS_SOCKET_NETLINK_UTIL_H_\n+#include <sys/socket.h>\n+// socket.h has t... | Go | Apache License 2.0 | google/gvisor | tests: include sys/socket.h before linux/if_arp.h
This is how it has to be accoding to the man page.
PiperOrigin-RevId: 281998068 |
259,914 | 22.11.2019 11:54:04 | 28,800 | 07635d20d40e1a279c4b063abaaad51048400ed7 | enable ring0/pagetables to support arm64
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/891 from lubinszARM:pr_pagetable | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/pagetables/BUILD",
"new_path": "pkg/sentry/platform/ring0/pagetables/BUILD",
"diff": "-load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\nload(\"@io_bazel_rules_go//go:def.bzl\", \"go_test\")\n+load(\"//tools/go_stateify:defs.bzl... | Go | Apache License 2.0 | google/gvisor | enable ring0/pagetables to support arm64
Signed-off-by: Bin Lu <bin.lu@arm.com>
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/891 from lubinszARM:pr_pagetable 2385de75a8662af3ab1ae289dd74dd0e5dcfaf66
PiperOrigin-RevId: 282013224 |
260,023 | 22.11.2019 12:53:49 | 28,800 | f27f38d13717a25721efb2b37fabadae5c34e374 | Add segment dequeue check while emptying segment queue. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1368,8 +1368,11 @@ func (e *endpoint) protocolMainLoop(handshake bool) *tcpip.Error {\n// unlocks e.mu. Now that no new segments can get enqueued to this\n// en... | Go | Apache License 2.0 | google/gvisor | Add segment dequeue check while emptying segment queue.
PiperOrigin-RevId: 282023891 |
259,854 | 22.11.2019 14:56:54 | 28,800 | 8eb68912e40bc87c932baeb13d151fd590d7d279 | Store SO_BINDTODEVICE state at bind.
This allows us to ensure that the correct port reservation is released.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -243,7 +243,7 @@ func (l *listenContext) createConnectingEndpoint(s *segment, iss seqnum.Value, i\nn.initGSO()\n// Register new endpoint so that packets are routed... | Go | Apache License 2.0 | google/gvisor | Store SO_BINDTODEVICE state at bind.
This allows us to ensure that the correct port reservation is released.
Fixes #1217
PiperOrigin-RevId: 282048155 |
259,891 | 25.11.2019 08:35:09 | 28,800 | 2b1b51f1d7dd96f14b0af3b2663c33bc7ab67f63 | Fix panic in sniffer.
Packets written via SOCK_RAW are guaranteed to have network headers, but not
transport headers. Check first whether there are enough bytes left in the packet
to contain a transport header before attempting to parse it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sniffer/sniffer.go",
"new_path": "pkg/tcpip/link/sniffer/sniffer.go",
"diff": "@@ -49,6 +49,13 @@ var LogPackets uint32 = 1\n// LogPacketsToFile must be accessed atomically.\nvar LogPacketsToFile uint32 = 1\n+var transportProtocolMinSizes map[tc... | Go | Apache License 2.0 | google/gvisor | Fix panic in sniffer.
Packets written via SOCK_RAW are guaranteed to have network headers, but not
transport headers. Check first whether there are enough bytes left in the packet
to contain a transport header before attempting to parse it.
PiperOrigin-RevId: 282363895 |
259,891 | 25.11.2019 09:26:30 | 28,800 | 1641338b14204ea941c547cf4c1a70665922ca05 | Set transport and network headers on outbound packets.
These are necessary for iptables to read and parse headers for packet filtering. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -240,8 +240,11 @@ func (e *endpoint) addIPHeader(r *stack.Route, hdr *buffer.Prependable, payloadS\n// WritePacket writes a packet to the given destination address and p... | Go | Apache License 2.0 | google/gvisor | Set transport and network headers on outbound packets.
These are necessary for iptables to read and parse headers for packet filtering.
PiperOrigin-RevId: 282372811 |
259,992 | 25.11.2019 11:41:39 | 28,800 | 97d2c9a94e802bcb450e50816a913dfc18afc0e3 | Use mount hints to determine FileAccessType | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -465,6 +465,13 @@ func (m *mountHint) checkCompatible(mount specs.Mount) error {\nreturn nil\n}\n+func (m *mountHint) fileAccessType() FileAccessType {\n+ if m.share == container {\n+ return FileAc... | Go | Apache License 2.0 | google/gvisor | Use mount hints to determine FileAccessType
PiperOrigin-RevId: 282401165 |
259,858 | 25.11.2019 13:51:13 | 28,800 | d92dc065fd98b5875a0945ccc062f91fc4d39190 | Fix typo in go_branch.sh script.
With the ticks, the command `master` is actually be run and the output included
(which is nothing). This is confusing, as we actually mean to say "master" in
the description of the Go branch. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_branch.sh",
"new_path": "tools/go_branch.sh",
"diff": "@@ -78,7 +78,7 @@ cat > README.md <<EOF\n# gVisor\nThis branch is a synthetic branch, containing only Go sources, that is\n-compatible with standard Go tools. See the `master` branch for authorita... | Go | Apache License 2.0 | google/gvisor | Fix typo in go_branch.sh script.
With the ticks, the command `master` is actually be run and the output included
(which is nothing). This is confusing, as we actually mean to say "master" in
the description of the Go branch.
PiperOrigin-RevId: 282426081 |
259,992 | 25.11.2019 17:10:10 | 28,800 | 67745b88e0ddcc44dcc7629be0334a7d970d6e09 | Handle any volume type, not only tmpfs | [
{
"change_type": "MODIFY",
"old_path": "pkg/v1/utils/volumes.go",
"new_path": "pkg/v1/utils/volumes.go",
"diff": "@@ -117,10 +117,6 @@ func UpdateVolumeAnnotations(bundle string, s *specs.Spec) error {\nif volumeFieldName(k) != \"type\" {\ncontinue\n}\n- if v != \"tmpfs\" {\n- // Only tmpfs is suppo... | Go | Apache License 2.0 | google/gvisor | Handle any volume type, not only tmpfs (#42) |
259,860 | 26.11.2019 17:01:56 | 28,800 | 519ceabdf90129664fa1f70f49d0472a9106910f | Mark execveat as supported for linux64_arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64_arm64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64_arm64.go",
"diff": "@@ -295,7 +295,7 @@ var ARM64 = &kernel.SyscallTable{\n278: syscalls.Supported(\"getrandom\", GetRandom),\n279: syscalls.Supported(\"memfd_create\",... | Go | Apache License 2.0 | google/gvisor | Mark execveat as supported for linux64_arm64.
PiperOrigin-RevId: 282667122 |
259,881 | 27.11.2019 13:47:44 | 28,800 | 58afb4be695e6804925ba2be5f2d8c245f079cba | Add floating point exception tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/exceptions.cc",
"new_path": "test/syscalls/linux/exceptions.cc",
"diff": "namespace gvisor {\nnamespace testing {\n+// Default value for the x87 FPU control word. See Intel SDM Vol 1, Ch 8.1.5\n+// \"x87 FPU Control Word\".\n+constexpr uint... | Go | Apache License 2.0 | google/gvisor | Add floating point exception tests
PiperOrigin-RevId: 282828273 |
259,860 | 27.11.2019 16:19:35 | 28,800 | 684f757a228f88e5fabe6ebe6ed54f0db20fd63d | Add support for receiving TOS and TCLASS control messages in hostinet.
This involves allowing getsockopt/setsockopt for the corresponding socket
options, as well as allowing hostinet to process control messages received from
the actual recvmsg syscall. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -422,6 +422,15 @@ type ControlMessageRights []int32\n// ControlMessageRights.\nconst SizeOfControlMessageRight = 4\n+// SizeOfControlMessageInq is the size of a TCP_INQ control messag... | Go | Apache License 2.0 | google/gvisor | Add support for receiving TOS and TCLASS control messages in hostinet.
This involves allowing getsockopt/setsockopt for the corresponding socket
options, as well as allowing hostinet to process control messages received from
the actual recvmsg syscall.
PiperOrigin-RevId: 282851425 |
260,004 | 28.11.2019 17:13:46 | 28,800 | 10bbcf97d25b824aa0565af114e3272d3e314d19 | Test handling segments on completed but not yet accepted TCP connections
This change does not introduce any new features, or modify existing ones.
This change tests handling TCP segments right away for connections that were
completed from a listening endpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"diff": "@@ -792,6 +792,82 @@ func TestSendRstOnListenerRxSynAckV6(t *testing.T) {\nchecker.SeqNum(200)))\n}\n+// TestTCPAckBeforeAcceptV4 tests that once the 3-way handsh... | Go | Apache License 2.0 | google/gvisor | Test handling segments on completed but not yet accepted TCP connections
This change does not introduce any new features, or modify existing ones.
This change tests handling TCP segments right away for connections that were
completed from a listening endpoint.
PiperOrigin-RevId: 282986457 |
259,860 | 02.12.2019 08:38:45 | 28,800 | 9194aab2aaada137b377fdfcb812a7c015857d5d | Support sending IP_TOS and IPV6_TCLASS control messages with hostinet sockets.
There are two potential ways of sending a TOS byte with outgoing packets:
including a control message in sendmsg, or setting the IP_TOS/IPV6_TCLASS
socket options (for IPV4 and IPV6 respectively). This change lets hostinet
support the former. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/BUILD",
"new_path": "pkg/sentry/socket/control/BUILD",
"diff": "@@ -17,6 +17,7 @@ go_library(\n\"//pkg/sentry/fs\",\n\"//pkg/sentry/kernel\",\n\"//pkg/sentry/kernel/auth\",\n+ \"//pkg/sentry/socket\",\n\"//pkg/sentry/socket/unix/trans... | Go | Apache License 2.0 | google/gvisor | Support sending IP_TOS and IPV6_TCLASS control messages with hostinet sockets.
There are two potential ways of sending a TOS byte with outgoing packets:
including a control message in sendmsg, or setting the IP_TOS/IPV6_TCLASS
socket options (for IPV4 and IPV6 respectively). This change lets hostinet
support the former.
PiperOrigin-RevId: 283346737 |
259,853 | 02.12.2019 15:35:51 | 28,800 | b41277049c6c6c15581d8698fd9418ef9c2cec8a | test/syscal: Don't skip ClockGettime.CputimeId
We skipped it due to the issue in the golang scheduler
which has been fixed in go1.13. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/clock_gettime.cc",
"new_path": "test/syscalls/linux/clock_gettime.cc",
"diff": "@@ -56,11 +56,6 @@ void spin_ns(int64_t ns) {\n// Test that CLOCK_PROCESS_CPUTIME_ID is a superset of CLOCK_THREAD_CPUTIME_ID.\nTEST(ClockGettime, CputimeId) {\... | Go | Apache License 2.0 | google/gvisor | test/syscal: Don't skip ClockGettime.CputimeId
We skipped it due to the issue in the golang scheduler
which has been fixed in go1.13.
PiperOrigin-RevId: 283432226 |
259,884 | 02.12.2019 17:59:08 | 28,800 | 7ac46c50486eef252ecaa4de1a2fe2581f73f79c | Allow non-unique UIDs in bazel docker containers
Allow non-unique UIDs in the bazel docker container in order to avoid failures
using host UIDs that are already present in the image.
Issue | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -22,7 +22,7 @@ bazel-server-start: docker-build\n--privileged \\\ngvisor-bazel \\\nsh -c \"while :; do sleep 100; done\" && \\\n- docker exec --user 0:0 -i gvisor-bazel sh -c \"groupadd --gid $(GID) --non-unique g... | Go | Apache License 2.0 | google/gvisor | Allow non-unique UIDs in bazel docker containers
Allow non-unique UIDs in the bazel docker container in order to avoid failures
using host UIDs that are already present in the image.
Issue #1267
PiperOrigin-RevId: 283456369 |
259,961 | 02.12.2019 21:13:34 | 18,000 | 1547f2451927d95f9da1a24479e57a47405dc1ed | Add documentation for configuring shim runtime options | [
{
"change_type": "MODIFY",
"old_path": "docs/README.md",
"new_path": "docs/README.md",
"diff": "@@ -5,3 +5,4 @@ Everything you need to know about gvisor-containerd-shim\n- [Untrusted Workload Quick Start (containerd >=1.1)](untrusted-workload-quickstart.md)\n- [Runtime Handler Quick Start (container... | Go | Apache License 2.0 | google/gvisor | Add documentation for configuring shim runtime options (#43) |
259,974 | 18.11.2019 09:07:00 | 0 | 61f2274cb6f05579e4abe1e794182c04a622b58f | Enable runsc compatLog support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nsrcs = [\n\"compat.go\",\n\"compat_amd64.go\",\n+ \"compat_arm64.go\",\n\"config.go\",\n\"controller.go\",\n\"debug.go\",\n"
},
{
"change_type": "MODIFY",
"old... | Go | Apache License 2.0 | google/gvisor | Enable runsc compatLog support on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I3fd5e552f5f03b5144ed52647f75af3b8253b1d6 |
259,974 | 20.11.2019 09:24:41 | 0 | 03760e5623f3ee736252fda7da033fd51144af1e | platform/ptrace: make some operations arch specific
Make the patchSignalInfo/cpuid faulting/initial thread seccomp rules
operations architecture dependent. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess_amd64.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess_amd64.go",
"diff": "@@ -21,6 +21,8 @@ import (\n\"strings\"\n\"syscall\"\n+ \"gvisor.dev/gvisor/pkg/abi/linux\"\n+ \"gvisor.dev/gvisor/pkg/seccomp\"\n\"gvisor.d... | Go | Apache License 2.0 | google/gvisor | platform/ptrace: make some operations arch specific
Make the patchSignalInfo/cpuid faulting/initial thread seccomp rules
operations architecture dependent.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: Iaf692dbe3700d2e01168ec2f1b4beeda9136fd62 |
259,860 | 03.12.2019 08:32:03 | 28,800 | 19b2d997ec702e559bdb5f5e60634a7c5d7d288e | Support IP_TOS and IPV6_TCLASS socket options for hostinet sockets.
There are two potential ways of sending a TOS byte with outgoing packets:
including a control message in sendmsg, or setting the IP_TOS/IPV6_TCLASS
socket options (for IPV4 and IPV6 respectively). This change lets hostinet
support the latter.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -289,12 +289,12 @@ func (s *socketOperations) GetSockOpt(t *kernel.Task, level int, name int, outPt\nswitch level {\ncase linux.SOL_IP:\nswitch name {\n- cas... | Go | Apache License 2.0 | google/gvisor | Support IP_TOS and IPV6_TCLASS socket options for hostinet sockets.
There are two potential ways of sending a TOS byte with outgoing packets:
including a control message in sendmsg, or setting the IP_TOS/IPV6_TCLASS
socket options (for IPV4 and IPV6 respectively). This change lets hostinet
support the latter.
Fixes #1188
PiperOrigin-RevId: 283550925 |
259,975 | 03.12.2019 10:22:01 | 28,800 | 812189664cab0a17ae29095e4029e2f8762a6779 | Remove TODO for obsolete bug. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/syscall_rpc.proto",
"new_path": "pkg/sentry/socket/rpcinet/syscall_rpc.proto",
"diff": "@@ -3,7 +3,6 @@ syntax = \"proto3\";\n// package syscall_rpc is a set of networking related system calls that can be\n// forwarded to a socket gof... | Go | Apache License 2.0 | google/gvisor | Remove TODO for obsolete bug.
PiperOrigin-RevId: 283571456 |
259,881 | 03.12.2019 12:45:43 | 28,800 | d7cc2480cb6e465ce01eb245e7edbad2c68c44d8 | Add RunfilesPath to test_util
A few tests have their own ad-hoc implementations. Add a single common one. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/exec.cc",
"new_path": "test/syscalls/linux/exec.cc",
"diff": "@@ -47,23 +47,14 @@ namespace testing {\nnamespace {\n-constexpr char kBasicWorkload[] = \"exec_basic_workload\";\n-constexpr char kExitScript[] = \"exit_script\";\n-constexpr ch... | Go | Apache License 2.0 | google/gvisor | Add RunfilesPath to test_util
A few tests have their own ad-hoc implementations. Add a single common one.
PiperOrigin-RevId: 283601666 |
259,992 | 03.12.2019 13:31:07 | 28,800 | 3e832bec1b48b95951c3b83eb5a7b70f29b1f10f | Point TODOs to gvisor.dev | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/filesystems.go",
"new_path": "pkg/sentry/fsimpl/proc/filesystems.go",
"diff": "@@ -19,7 +19,7 @@ package proc\n// +stateify savable\ntype filesystemsData struct{}\n-// TODO(b/138862512): Implement vfs.DynamicBytesSource.Generate for\n+//... | Go | Apache License 2.0 | google/gvisor | Point TODOs to gvisor.dev
PiperOrigin-RevId: 283610781 |
259,992 | 03.12.2019 13:42:30 | 28,800 | 154dcdec072ddad9e1c96b56e023d7f77fecf2ad | Remove watchdog TODO
I have not seen a false positive stuck task yet.
Biggest offender was whitelistfs which is going away. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -287,7 +287,9 @@ func (w *Watchdog) runTurn() {\nif !ok {\n// New stuck task detected.\n//\n- // TODO(b/65849403): Tasks blocked doing IO may be considered stuck in ke... | Go | Apache License 2.0 | google/gvisor | Remove watchdog TODO
I have not seen a false positive stuck task yet.
Biggest offender was whitelistfs which is going away.
PiperOrigin-RevId: 283613064 |
259,853 | 03.12.2019 13:46:09 | 28,800 | 43643752f05a0b25259b116558ccd870a539cc05 | strace: don't create a slice with a negative value | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/socket.go",
"new_path": "pkg/sentry/strace/socket.go",
"diff": "@@ -208,6 +208,15 @@ func cmsghdr(t *kernel.Task, addr usermem.Addr, length uint64, maxBytes uint64)\ni += linux.SizeOfControlMessageHeader\nwidth := t.Arch().Width()\nlength := ... | Go | Apache License 2.0 | google/gvisor | strace: don't create a slice with a negative value
PiperOrigin-RevId: 283613824 |
259,975 | 03.12.2019 15:06:18 | 28,800 | 035407153989b189a3ce42df43d6f528fa95444f | Fix printing /proc/[pid]/io for /proc/[pid]/task/[tid]/io. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -639,7 +639,7 @@ func (i *ioData) ReadSeqFileData(ctx context.Context, h seqfile.SeqHandle) ([]se\nio.Accumulate(i.IOUsage())\nvar buf bytes.Buffer\n- fmt.Fprintf(&buf, \"char: ... | Go | Apache License 2.0 | google/gvisor | Fix printing /proc/[pid]/io for /proc/[pid]/task/[tid]/io.
PiperOrigin-RevId: 283630669 |
259,853 | 03.12.2019 16:30:38 | 28,800 | cf7f27c16793eaa41743e96488dad2ddfd1f5d59 | net/udp: return a local route address as the bound-to address
If the socket is bound to ANY and connected to a loopback address,
getsockname() has to return the loopback address. Without this fix,
getsockname() returns ANY. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -1134,9 +1134,14 @@ func (e *endpoint) GetLocalAddress() (tcpip.FullAddress, *tcpip.Error) {\ne.mu.RLock()\ndefer e.mu.RUnlock()\n+ addr := e.ID.LocalAddress\n... | Go | Apache License 2.0 | google/gvisor | net/udp: return a local route address as the bound-to address
If the socket is bound to ANY and connected to a loopback address,
getsockname() has to return the loopback address. Without this fix,
getsockname() returns ANY.
PiperOrigin-RevId: 283647781 |
259,992 | 03.12.2019 17:32:27 | 28,800 | bb641c54035e79e3e4c2752e07e6ac55c620b93f | Point TODO to gvisor.dev | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/aio.cc",
"new_path": "test/syscalls/linux/aio.cc",
"diff": "@@ -129,7 +129,7 @@ TEST_F(AIOTest, BasicWrite) {\n// aio implementation uses aio_ring. gVisor doesn't and returns all zeroes.\n// Linux implements aio_ring, so skip the zeroes che... | Go | Apache License 2.0 | google/gvisor | Point TODO to gvisor.dev
PiperOrigin-RevId: 283657725 |
259,860 | 03.12.2019 19:40:56 | 28,800 | 80b7ba0c9709c0c7f4c3aef5637d23225bcb866b | Clean up readv_socket test suite.
Get rid of the SocketTest class, which is only extended by ReadvSocketTest.
Also, get rid of TCP sockets (which were unused anyway) from readv_socket.cc.
This is a very old test suite that isn't the right place for TCP loopback
tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1795,7 +1795,6 @@ cc_binary(\nname = \"readv_socket_test\",\ntestonly = 1,\nsrcs = [\n- \"file_base.h\",\n\"readv_common.cc\",\n\"readv_common.h\",\n\"readv_socket.cc\",\n"
},
... | Go | Apache License 2.0 | google/gvisor | Clean up readv_socket test suite.
Get rid of the SocketTest class, which is only extended by ReadvSocketTest.
Also, get rid of TCP sockets (which were unused anyway) from readv_socket.cc.
This is a very old test suite that isn't the right place for TCP loopback
tests.
PiperOrigin-RevId: 283672772 |
259,992 | 04.12.2019 13:53:08 | 28,800 | 1eda90d0848658f330e5f37ce18209bd3d069766 | Remove TODO since we don't plan to support debug registers | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/arch_amd64.go",
"new_path": "pkg/sentry/arch/arch_amd64.go",
"diff": "@@ -305,7 +305,7 @@ func (c *context64) PtracePeekUser(addr uintptr) (interface{}, error) {\nbuf := binary.Marshal(nil, usermem.ByteOrder, c.ptraceGetRegs())\nreturn c.Native... | Go | Apache License 2.0 | google/gvisor | Remove TODO since we don't plan to support debug registers
PiperOrigin-RevId: 283828423 |
259,860 | 04.12.2019 23:44:25 | 28,800 | 6ae64d793593eaf3c1364354ef01a555f230a0fe | Allow syscall tests to run with hostinet.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/build_defs.bzl",
"new_path": "test/syscalls/build_defs.bzl",
"diff": "@@ -9,6 +9,7 @@ def syscall_test(\nuse_tmpfs = False,\nadd_overlay = False,\nadd_uds_tree = False,\n+ add_hostinet = False,\ntags = None):\n_syscall_test(\ntest = test,\n@@ -65... | Go | Apache License 2.0 | google/gvisor | Allow syscall tests to run with hostinet.
Fixes #1207
PiperOrigin-RevId: 283914438 |
260,004 | 05.12.2019 10:40:18 | 28,800 | 10f7b109ab98c95783357b82e1934586f338c2b3 | Add a type to represent the NDP Recursive DNS Server option
This change adds a type to represent the NDP Recursive DNS Server option, as
defined by RFC 8106 section 5.1. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/BUILD",
"new_path": "pkg/tcpip/header/BUILD",
"diff": "@@ -55,5 +55,8 @@ go_test(\n\"ndp_test.go\",\n],\nembed = [\":header\"],\n- deps = [\"//pkg/tcpip\"],\n+ deps = [\n+ \"//pkg/tcpip\",\n+ \"@com_github_google_go-cmp//cmp:go_default_library... | Go | Apache License 2.0 | google/gvisor | Add a type to represent the NDP Recursive DNS Server option
This change adds a type to represent the NDP Recursive DNS Server option, as
defined by RFC 8106 section 5.1.
PiperOrigin-RevId: 284005493 |
259,885 | 05.12.2019 12:56:31 | 28,800 | 02258607f97353932d56bfde9274d50dda18e374 | Add vfs.CheckSetStat() and its dependencies. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/permissions.go",
"new_path": "pkg/sentry/vfs/permissions.go",
"diff": "@@ -119,3 +119,65 @@ func MayWriteFileWithOpenFlags(flags uint32) bool {\nreturn false\n}\n}\n+\n+// CheckSetStat checks that creds has permission to change the metadata of a... | Go | Apache License 2.0 | google/gvisor | Add vfs.CheckSetStat() and its dependencies.
PiperOrigin-RevId: 284033820 |
259,975 | 05.12.2019 13:22:31 | 28,800 | 0a32c0235744191947a6bf890031026e06788837 | Create correct file for /proc/[pid]/task/[tid]/io | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -67,7 +67,7 @@ type taskDir struct {\nvar _ fs.InodeOperations = (*taskDir)(nil)\n// newTaskDir creates a new proc task entry.\n-func (p *proc) newTaskDir(t *kernel.Task, msrc *... | Go | Apache License 2.0 | google/gvisor | Create correct file for /proc/[pid]/task/[tid]/io
PiperOrigin-RevId: 284038840 |
259,884 | 06.12.2019 06:39:35 | -32,400 | 757adfa287c17d925aec7976a86986bd5b52229c | Add docs for Kubernetes Runtime Class.
Adds doc to explicitly create the Kubernetes RuntimeClass object needed
to use the shim via the Kubernetes API. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -13,8 +13,8 @@ gvisor-containerd-shim is a containerd shim for [gVisor](https://github.com/goog\n## Installation\n- [Untrusted Workload Quick Start (containerd >=1.1)](docs/untrusted-workload-quickstart.md)\n-- ... | Go | Apache License 2.0 | google/gvisor | Add docs for Kubernetes Runtime Class. (#33)
Adds doc to explicitly create the Kubernetes RuntimeClass object needed
to use the shim via the Kubernetes API. |
259,992 | 05.12.2019 16:36:24 | 28,800 | e83ba107367ac3a25725d8857c2ba3cc9adbeb71 | Make EmptyDir annotations compliant with K8s and OCI
Change annotation from 'gvisor.dev/spec/mount/NAME/share',
which is invalid because it has more than one '/', to
'dev.gvisor.spec.mount.NAME.share'. | [
{
"change_type": "MODIFY",
"old_path": "pkg/v1/utils/volumes.go",
"new_path": "pkg/v1/utils/volumes.go",
"diff": "@@ -29,20 +29,20 @@ import (\n\"github.com/sirupsen/logrus\"\n)\n-const volumeKeyPrefix = \"gvisor.dev/spec/mount/\"\n+const volumeKeyPrefix = \"dev.gvisor.spec.mount.\"\nvar kubeletPods... | Go | Apache License 2.0 | google/gvisor | Make EmptyDir annotations compliant with K8s and OCI (#44)
Change annotation from 'gvisor.dev/spec/mount/NAME/share',
which is invalid because it has more than one '/', to
'dev.gvisor.spec.mount.NAME.share'. |
259,854 | 05.12.2019 17:27:15 | 28,800 | 13f0f6069af4d49e236cbee4f0284c190784db37 | Implement F_GETOWN_EX and F_SETOWN_EX.
Some versions of glibc will convert F_GETOWN fcntl(2) calls into F_GETOWN_EX in
some cases. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fcntl.go",
"new_path": "pkg/abi/linux/fcntl.go",
"diff": "@@ -16,15 +16,17 @@ package linux\n// Commands from linux/fcntl.h.\nconst (\n- F_DUPFD = 0x0\n- F_GETFD = 0x1\n- F_SETFD = 0x2\n- F_GETFL = 0x3\n- F_SETFL = 0x4\n- F_SETLK = 0x6\n- F_SETLK... | Go | Apache License 2.0 | google/gvisor | Implement F_GETOWN_EX and F_SETOWN_EX.
Some versions of glibc will convert F_GETOWN fcntl(2) calls into F_GETOWN_EX in
some cases.
PiperOrigin-RevId: 284089373 |
259,992 | 05.12.2019 17:57:07 | 28,800 | 40035d7d9c18d0467075cdaebe3d26d2dbd2720b | Fix possible race condition destroying container
When the sandbox is destroyed, making URPC calls to destroy the
container will fail. The code was checking if the sandbox was
running before attempting to make the URPC call, but that is racy. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -1004,16 +1004,22 @@ func (s *Sandbox) ChangeLogging(args control.LoggingArgs) error {\n// DestroyContainer destroys the given container. If it is the root container,\n// then the e... | Go | Apache License 2.0 | google/gvisor | Fix possible race condition destroying container
When the sandbox is destroyed, making URPC calls to destroy the
container will fail. The code was checking if the sandbox was
running before attempting to make the URPC call, but that is racy.
PiperOrigin-RevId: 284093764 |
259,881 | 06.12.2019 08:35:18 | 28,800 | f8bb3f79041bf819cdf803c1009a442154692301 | Document ELF PT_LOAD difference from Linux | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/elf.go",
"new_path": "pkg/sentry/loader/elf.go",
"diff": "@@ -408,6 +408,8 @@ func loadParsedELF(ctx context.Context, m *mm.MemoryManager, f *fs.File, info el\nstart = vaddr\n}\nif vaddr < end {\n+ // NOTE(b/37474556): Linux allows out-of-ord... | Go | Apache License 2.0 | google/gvisor | Document ELF PT_LOAD difference from Linux
PiperOrigin-RevId: 284191345 |
259,860 | 06.12.2019 12:12:27 | 28,800 | b0066217ecd830be1d816d2b4d824f89b278c556 | Add hostinet tests for UDP sockets.
We need to skip a subset of the tests, because of features that hostinet does
not currently support.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -669,6 +669,7 @@ syscall_test(test = \"//test/syscalls/linux:udp_bind_test\")\nsyscall_test(\nsize = \"medium\",\n+ add_hostinet = True,\nshard_count = 10,\ntest = \"//test/syscalls/linux:udp... | Go | Apache License 2.0 | google/gvisor | Add hostinet tests for UDP sockets.
We need to skip a subset of the tests, because of features that hostinet does
not currently support.
Fixes #1209
PiperOrigin-RevId: 284235911 |
259,992 | 06.12.2019 13:50:12 | 28,800 | ea7a100202f01601fba613a76f106a9a45c817c8 | Make annotations OCI compliant
Changed annotation to follow the standard defined here: | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -16,7 +16,6 @@ package boot\nimport (\n\"fmt\"\n- \"path\"\n\"path/filepath\"\n\"sort\"\n\"strconv\"\n@@ -52,7 +51,7 @@ const (\nrootDevice = \"9pfs-/\"\n// MountPrefix is the annotation prefix for... | Go | Apache License 2.0 | google/gvisor | Make annotations OCI compliant
Changed annotation to follow the standard defined here:
https://github.com/opencontainers/image-spec/blob/master/annotations.md
PiperOrigin-RevId: 284254847 |
259,858 | 06.12.2019 16:58:28 | 28,800 | 371e210b83c244d8828ad2fa1b3d7cef15fbf463 | Add runtime tracing.
This adds meaningful annotations to the trace generated by the runtime/trace
package. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/pprof.go",
"new_path": "pkg/sentry/control/pprof.go",
"diff": "@@ -22,6 +22,7 @@ import (\n\"sync\"\n\"gvisor.dev/gvisor/pkg/fd\"\n+ \"gvisor.dev/gvisor/pkg/sentry/kernel\"\n\"gvisor.dev/gvisor/pkg/urpc\"\n)\n@@ -56,6 +57,9 @@ type Profile s... | Go | Apache License 2.0 | google/gvisor | Add runtime tracing.
This adds meaningful annotations to the trace generated by the runtime/trace
package.
PiperOrigin-RevId: 284290115 |
260,023 | 06.12.2019 17:15:52 | 28,800 | b1d44be7ad893bd6bdfd164a54a7142f4462414b | Add TCP stats for connection close and keep-alive timeouts.
Fix bugs in updates to TCP CurrentEstablished stat.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -151,6 +151,8 @@ var Metrics = tcpip.Stats{\nPassiveConnectionOpenings: mustCreateMetric(\"/netstack/tcp/passive_connection_openings\", \"Number of conne... | Go | Apache License 2.0 | google/gvisor | Add TCP stats for connection close and keep-alive timeouts.
Fix bugs in updates to TCP CurrentEstablished stat.
Fixes #1277
PiperOrigin-RevId: 284292459 |
259,992 | 06.12.2019 20:11:51 | 28,800 | 3c2e2f7d12285e6093ecc225e0379fe59e8fd93f | Update Kokoro image to install Golang 1.13 | [
{
"change_type": "MODIFY",
"old_path": "kokoro/ubuntu1604/10_core.sh",
"new_path": "kokoro/ubuntu1604/10_core.sh",
"diff": "@@ -21,8 +21,8 @@ apt-get update && apt-get -y install make git-core build-essential linux-headers\n# Install a recent go toolchain.\nif ! [[ -d /usr/local/go ]]; then\n- wget ... | Go | Apache License 2.0 | google/gvisor | Update Kokoro image to install Golang 1.13
PiperOrigin-RevId: 284308422 |
259,992 | 06.12.2019 23:08:39 | 28,800 | 01eadf51ea54b8f478c49b755d712f11fff2b28c | Bump up Go 1.13 as minimum requirement | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/sighandling/sighandling.go",
"new_path": "pkg/sentry/sighandling/sighandling.go",
"diff": "package sighandling\nimport (\n- \"fmt\"\n\"os\"\n\"os/signal\"\n\"reflect\"\n@@ -31,37 +30,25 @@ const numSignals = 32\n// handleSignals listens for incoming... | Go | Apache License 2.0 | google/gvisor | Bump up Go 1.13 as minimum requirement
PiperOrigin-RevId: 284320186 |
259,858 | 09.12.2019 11:21:37 | 28,800 | cf477c86ca8bfd27551c97aa4015364d30b98f2e | Mark runner_test as manual.
Because it is local-only, it should also be marked manual. | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/runner/BUILD",
"new_path": "benchmarks/runner/BUILD",
"diff": "@@ -34,7 +34,10 @@ py_test(\nname = \"runner_test\",\nsrcs = [\"runner_test.py\"],\npython_version = \"PY3\",\n- tags = [\"local\"],\n+ tags = [\n+ \"local\",\n+ \"manual\",\n+ ],\ndeps ... | Go | Apache License 2.0 | google/gvisor | Mark runner_test as manual.
Because it is local-only, it should also be marked manual.
PiperOrigin-RevId: 284596186 |
259,962 | 09.12.2019 12:03:16 | 28,800 | cb5f9b8f863c93bb7e3757c1f4b3e1a64e6acdfb | Mark test as non flaky. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -3272,8 +3272,6 @@ cc_binary(\ntestonly = 1,\nsrcs = [\"tcp_socket.cc\"],\nlinkstatic = 1,\n- # FIXME(b/135470853)\n- tags = [\"flaky\"],\ndeps = [\n\":socket_test_util\",\n\"//te... | Go | Apache License 2.0 | google/gvisor | Mark test as non flaky.
PiperOrigin-RevId: 284606133 |
259,992 | 09.12.2019 12:03:31 | 28,800 | 898dcc2f839a975a9171271824af32176c2e5c27 | Redirect TODOs to gvisor.dev | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/session.go",
"new_path": "pkg/sentry/fs/gofer/session.go",
"diff": "@@ -143,9 +143,9 @@ type session struct {\n// socket files. This allows unix domain sockets to be used with paths that\n// belong to a gofer.\n//\n- // TODO(b/77154739): th... | Go | Apache License 2.0 | google/gvisor | Redirect TODOs to gvisor.dev
PiperOrigin-RevId: 284606233 |
259,854 | 09.12.2019 20:07:14 | 28,800 | 98aafb1334b816596b462ad12fa3e96784703061 | Add test for SO_BINDTODEVICE state bug.
This was accidentally dropped from the change which fixed the bug.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_bind_to_device_sequence.cc",
"new_path": "test/syscalls/linux/socket_bind_to_device_sequence.cc",
"diff": "@@ -97,6 +97,16 @@ class BindToDeviceSequenceTest : public ::testing::TestWithParam<SocketKind> {\nsockets_to_close_.erase(soc... | Go | Apache License 2.0 | google/gvisor | Add test for SO_BINDTODEVICE state bug.
This was accidentally dropped from the change which fixed the bug.
Updates #1217
PiperOrigin-RevId: 284689362 |
259,860 | 10.12.2019 09:32:47 | 28,800 | 4a19ebd431659578c9af0a91ff35d8b6d9de190e | Add hostinet tests for sendmsg and recvmsg with TOS/TCLASS. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/udp_socket_test_cases.cc",
"new_path": "test/syscalls/linux/udp_socket_test_cases.cc",
"diff": "@@ -1345,5 +1345,154 @@ TEST_P(UdpSocketTest, TimestampIoctlPersistence) {\nASSERT_EQ(tv.tv_usec, tv2.tv_usec);\n}\n+// Test that a socket with ... | Go | Apache License 2.0 | google/gvisor | Add hostinet tests for sendmsg and recvmsg with TOS/TCLASS.
PiperOrigin-RevId: 284786069 |
259,860 | 10.12.2019 09:36:52 | 28,800 | aadbf322c63b0aa1d34cd9755dc1266af2e5ac58 | Disable execveat test that is causing files in /bin to be deleted.
Disable until gvisor.dev/issue/1366 is resolved.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/exec.cc",
"new_path": "test/syscalls/linux/exec.cc",
"diff": "@@ -696,15 +696,6 @@ TEST(ExecveatTest, SymlinkNoFollowAndEmptyPath) {\nArgEnvExitStatus(0, 0), absl::StrCat(path, \"\\n\"));\n}\n-TEST(ExecveatTest, SymlinkNoFollowIgnoreSymlink... | Go | Apache License 2.0 | google/gvisor | Disable execveat test that is causing files in /bin to be deleted.
Disable until gvisor.dev/issue/1366 is resolved.
Updates #1366
PiperOrigin-RevId: 284786895 |
259,860 | 10.12.2019 09:59:36 | 28,800 | 30f7316dc4a5fe0346c6e2e8e6854bd48a316a82 | Make comments clearer for control message handling. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/control.go",
"new_path": "pkg/sentry/socket/control/control.go",
"diff": "@@ -195,15 +195,15 @@ func putCmsg(buf []byte, flags int, msgType uint32, align uint, data []int32) ([\n// the available space, we must align down.\n//\n// alig... | Go | Apache License 2.0 | google/gvisor | Make comments clearer for control message handling.
PiperOrigin-RevId: 284791600 |
259,860 | 10.12.2019 10:55:08 | 28,800 | f47eaffd5c59445b8cafda1b7a51e7f4be5d254a | Do not consider symlinks as directories in fs utils.
IsDirectory() is used in RecursivelyDelete(), which should not follow symlinks.
The only other use (syscalls/linux/rename.cc) is not affected by this change.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/util/fs_util.cc",
"new_path": "test/util/fs_util.cc",
"diff": "@@ -105,6 +105,15 @@ PosixErrorOr<struct stat> Stat(absl::string_view path) {\nreturn stat_buf;\n}\n+PosixErrorOr<struct stat> Lstat(absl::string_view path) {\n+ struct stat stat_buf;\n+ int r... | Go | Apache License 2.0 | google/gvisor | Do not consider symlinks as directories in fs utils.
IsDirectory() is used in RecursivelyDelete(), which should not follow symlinks.
The only other use (syscalls/linux/rename.cc) is not affected by this change.
Updates #1366.
PiperOrigin-RevId: 284803968 |
259,860 | 10.12.2019 10:56:51 | 28,800 | f6e87be82f189d7d2176dc2ca4a2d261481a032a | Let socket.ControlMessages Release() the underlying transport.ControlMessages. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/socket.go",
"new_path": "pkg/sentry/socket/socket.go",
"diff": "@@ -43,6 +43,11 @@ type ControlMessages struct {\nIP tcpip.ControlMessages\n}\n+// Release releases Unix domain socket credentials and rights.\n+func (c *ControlMessages) Release... | Go | Apache License 2.0 | google/gvisor | Let socket.ControlMessages Release() the underlying transport.ControlMessages.
PiperOrigin-RevId: 284804370 |
259,860 | 10.12.2019 11:40:29 | 28,800 | 769e1cdcbe539ca2347ad5ccd2706ae17777aed9 | Re-enable execveat test that was causing files in /bin to be deleted.
Test now no longer deletes files incorrectly, due to a fix in fs utils
used by TempPath (github.com/google/gvisor/pull/1368).
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/exec.cc",
"new_path": "test/syscalls/linux/exec.cc",
"diff": "@@ -696,6 +696,15 @@ TEST(ExecveatTest, SymlinkNoFollowAndEmptyPath) {\nArgEnvExitStatus(0, 0), absl::StrCat(path, \"\\n\"));\n}\n+TEST(ExecveatTest, SymlinkNoFollowIgnoreSymlink... | Go | Apache License 2.0 | google/gvisor | Re-enable execveat test that was causing files in /bin to be deleted.
Test now no longer deletes files incorrectly, due to a fix in fs utils
used by TempPath (github.com/google/gvisor/pull/1368).
Fixes #1366
PiperOrigin-RevId: 284814605 |
259,860 | 10.12.2019 13:04:32 | 28,800 | 39386d78bb9636e52d6a0487d5fa7bff6beab64e | Format fd_set parameters in select(2)/pselect(2) for strace.
I1202 14:55:06.835076 7991 x:0] [ 1] select_test E
select(0xa, 0x7fc6ce924c28 [0 1], null, null, 0x7fc6ce924c08 {sec=0 usec=0})
I1202 14:55:06.835102 7991 x:0] [ 1] select_test X
select(0xa, 0x7fc6ce924c28 [0 1], null, null, 0x7fc6ce924c08 {sec=0 usec=0}) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/BUILD",
"new_path": "pkg/sentry/strace/BUILD",
"diff": "@@ -14,6 +14,7 @@ go_library(\n\"open.go\",\n\"poll.go\",\n\"ptrace.go\",\n+ \"select.go\",\n\"signal.go\",\n\"socket.go\",\n\"strace.go\",\n"
},
{
"change_type": "MODIFY",
"... | Go | Apache License 2.0 | google/gvisor | Format fd_set parameters in select(2)/pselect(2) for strace.
I1202 14:55:06.835076 7991 x:0] [ 1] select_test E
select(0xa, 0x7fc6ce924c28 [0 1], null, null, 0x7fc6ce924c08 {sec=0 usec=0})
I1202 14:55:06.835102 7991 x:0] [ 1] select_test X
select(0xa, 0x7fc6ce924c28 [0 1], null, null, 0x7fc6ce924c08 {sec=0 usec=0})
PiperOrigin-RevId: 284831805 |
259,847 | 10.12.2019 13:24:11 | 28,800 | 87337e92e3a65e69f6bfc6ac7d162c1b6ed18048 | Add Kokoro configs for publishing Kythe xrefs. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/kythe/generate_xrefs.cfg",
"diff": "+build_file: \"gvisor/kokoro/kythe/generate_xrefs.sh\"\n+\n+before_action {\n+ fetch_keystore {\n+ keystore_resource {\n+ keystore_config_id: 73898\n+ keyname: \"kokoro-rbe-service-account\"\n+ }\n+ }\n... | Go | Apache License 2.0 | google/gvisor | Add Kokoro configs for publishing Kythe xrefs.
PiperOrigin-RevId: 284835614 |
259,847 | 10.12.2019 14:54:04 | 28,800 | a0aa784ecfb0d5ef94decf3c2be3e1cd44b6cbc6 | Remove pyenv calls but log the python 3 version in use.
Apparently our Kokoro VM images don't have pyenv -- I previously tested this on
the Kokoro QA shared pool. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/kythe/generate_xrefs.sh",
"new_path": "kokoro/kythe/generate_xrefs.sh",
"diff": "@@ -23,11 +23,7 @@ if command -v use_bazel.sh >/dev/null; then\nfi\nbazel version\n-# We need to use python 3.6 (the Kokoro PY3 default is 3.4) to compile `//...`\n-# becau... | Go | Apache License 2.0 | google/gvisor | Remove pyenv calls but log the python 3 version in use.
Apparently our Kokoro VM images don't have pyenv -- I previously tested this on
the Kokoro QA shared pool.
PiperOrigin-RevId: 284855160 |
259,860 | 10.12.2019 19:14:05 | 28,800 | 2e3b9b0a68d8f191d061008feda6e4a4ce202a78 | Deduplicate and simplify control message processing for recvmsg and sendmsg.
Also, improve performance by calculating how much space is needed before making
an allocation for sendmsg in hostinet. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/control.go",
"new_path": "pkg/sentry/socket/control/control.go",
"diff": "@@ -348,43 +348,62 @@ func PackTClass(t *kernel.Task, tClass int32, buf []byte) []byte {\n)\n}\n-func addSpaceForCmsg(cmsgDataLen int, buf []byte) []byte {\n- n... | Go | Apache License 2.0 | google/gvisor | Deduplicate and simplify control message processing for recvmsg and sendmsg.
Also, improve performance by calculating how much space is needed before making
an allocation for sendmsg in hostinet.
PiperOrigin-RevId: 284898581 |
259,860 | 11.12.2019 10:23:54 | 28,800 | 1643224af0f099d55d7ae7934606ec1987658dfc | Finish incomplete comment. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -199,6 +199,7 @@ func (a *attachPoint) makeQID(stat syscall.Stat_t) p9.QID {\n// The reason that the file is not opened initially as read-write is for better\n// performance with 'o... | Go | Apache License 2.0 | google/gvisor | Finish incomplete comment.
PiperOrigin-RevId: 285012278 |
259,885 | 11.12.2019 13:40:57 | 28,800 | 481dbfa5ab24ec2c0752b9e748d3617285603c4e | Add vfs.Pathname{WithDeleted,ForGetcwd}.
The former is needed for vfs.FileDescription to implement
memmap.MappingIdentity, and the latter is needed to implement getcwd(2). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/BUILD",
"new_path": "pkg/sentry/fsimpl/ext/BUILD",
"diff": "@@ -38,6 +38,7 @@ go_library(\n\"//pkg/abi/linux\",\n\"//pkg/binary\",\n\"//pkg/fd\",\n+ \"//pkg/fspath\",\n\"//pkg/log\",\n\"//pkg/sentry/arch\",\n\"//pkg/sentry/context\",\n"
... | Go | Apache License 2.0 | google/gvisor | Add vfs.Pathname{WithDeleted,ForGetcwd}.
The former is needed for vfs.FileDescription to implement
memmap.MappingIdentity, and the latter is needed to implement getcwd(2).
PiperOrigin-RevId: 285051855 |
259,860 | 11.12.2019 16:39:58 | 28,800 | 1601e78a52e9181d1ea8a3ff36399575e95ad0bf | Add syscall tests for getxattr and setxattr.
Support for getxattr and setxattr are in subsequent commits. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -717,6 +717,11 @@ syscall_test(test = \"//test/syscalls/linux:proc_net_tcp_test\")\nsyscall_test(test = \"//test/syscalls/linux:proc_net_udp_test\")\n+syscall_test(\n+ add_overlay = True,\n+ ... | Go | Apache License 2.0 | google/gvisor | Add syscall tests for getxattr and setxattr.
Support for getxattr and setxattr are in subsequent commits.
PiperOrigin-RevId: 285088817 |
259,962 | 11.12.2019 19:12:51 | 28,800 | b9aa62b9f907e8de5244ac7cdb518960faafa307 | Enable IPv6 in runsc
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/network.go",
"new_path": "runsc/boot/network.go",
"diff": "@@ -80,7 +80,8 @@ type CreateLinksAndRoutesArgs struct {\nLoopbackLinks []LoopbackLink\nFDBasedLinks []FDBasedLink\n- DefaultGateway DefaultRoute\n+ Defaultv4Gateway DefaultRoute\n+ Defaultv... | Go | Apache License 2.0 | google/gvisor | Enable IPv6 in runsc
Fixes #1341
PiperOrigin-RevId: 285108973 |
259,853 | 12.12.2019 11:07:25 | 28,800 | 378d6c1f3697b8b939e6632e980562bfc8fb2781 | unix: allow to bind unix sockets only to AF_UNIX addresses
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -326,7 +326,7 @@ func AddressAndFamily(sfamily int, addr []byte, strict bool) (tcpip.FullAddress,\n}\nfamily := usermem.ByteOrder.Uint16(addr)\n- if fami... | Go | Apache License 2.0 | google/gvisor | unix: allow to bind unix sockets only to AF_UNIX addresses
Reported-by: syzbot+2c0bcfd87fb4e8b7b009@syzkaller.appspotmail.com
PiperOrigin-RevId: 285228312 |
259,885 | 12.12.2019 13:17:47 | 28,800 | 93d429d5b1e3801fb4c29568bcd40d6854c9fe94 | Implement memmap.MappingIdentity for vfs.FileDescription. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/memmap/BUILD",
"new_path": "pkg/sentry/memmap/BUILD",
"diff": "@@ -41,7 +41,6 @@ go_library(\nvisibility = [\"//pkg/sentry:internal\"],\ndeps = [\n\"//pkg/log\",\n- \"//pkg/refs\",\n\"//pkg/sentry/context\",\n\"//pkg/sentry/platform\",\n\"//pkg/sent... | Go | Apache License 2.0 | google/gvisor | Implement memmap.MappingIdentity for vfs.FileDescription.
PiperOrigin-RevId: 285255855 |
260,004 | 13.12.2019 16:26:06 | 28,800 | ad80dcf47077a1938631fe36f6b406256f3f3f4f | Properly generate the EUI64 interface identifier from an Ethernet address
Fixed a bug where the interface identifier was not properly generated from an
Ethernet address.
Tests: Unittests to make sure the functions generating the EUI64 interface
identifier are correct. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/BUILD",
"new_path": "pkg/tcpip/header/BUILD",
"diff": "@@ -38,12 +38,15 @@ go_test(\nsize = \"small\",\nsrcs = [\n\"checksum_test.go\",\n+ \"ipv6_test.go\",\n\"ipversion_test.go\",\n\"tcp_test.go\",\n],\ndeps = [\n\":header\",\n+ \"//pkg/tcpip... | Go | Apache License 2.0 | google/gvisor | Properly generate the EUI64 interface identifier from an Ethernet address
Fixed a bug where the interface identifier was not properly generated from an
Ethernet address.
Tests: Unittests to make sure the functions generating the EUI64 interface
identifier are correct.
PiperOrigin-RevId: 285494562 |
259,887 | 15.12.2019 20:57:23 | -10,800 | 8782f0e287df2a2fd9f9dfb3f0e1589cc15a4f91 | Set CPU number to CPU quota
When application is not cgroups-aware, it can spawn excessive threads
which often defaults to CPU number.
Introduce a opt-in flag that will set CPU number accordingly to CPU
quota (if available).
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -250,6 +250,12 @@ type Config struct {\n// multiple tests are run in parallel, since there is no way to pass\n// parameters to the runtime from docker.\nTestOnlyTestNameEnv string\n+\n+ // ... | Go | Apache License 2.0 | google/gvisor | Set CPU number to CPU quota
When application is not cgroups-aware, it can spawn excessive threads
which often defaults to CPU number.
Introduce a opt-in flag that will set CPU number accordingly to CPU
quota (if available).
Fixes #1391 |
259,860 | 16.12.2019 14:40:01 | 28,800 | 3193b2fff8149fe43a3a59c266359e7f443a1563 | Drop unnecessary cast.
Bitshift operators with signed int is supported in Go 1.13. | [
{
"change_type": "MODIFY",
"old_path": "go.mod",
"new_path": "go.mod",
"diff": "module gvisor.dev/gvisor\n-go 1.12\n+go 1.13\nrequire (\ngithub.com/cenkalti/backoff v0.0.0-20190506075156-2146c9339422\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/select.go",
"new_pat... | Go | Apache License 2.0 | google/gvisor | Drop unnecessary cast.
Bitshift operators with signed int is supported in Go 1.13.
PiperOrigin-RevId: 285853622 |
259,887 | 17.12.2019 20:41:02 | -10,800 | 67f678be27b3f4545d41539bd6855527da53a250 | Leave minimum CPU number as a constant
Remove introduced CPUNumMin config and hard-code it as 2. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -256,12 +256,6 @@ type Config struct {\n//\n// E.g. 0.2 CPU quota will result in 1, and 1.9 in 2.\nCPUNumFromQuota bool\n-\n- // CPUNumMin is minimum value of CPU number setting when CPUNum... | Go | Apache License 2.0 | google/gvisor | Leave minimum CPU number as a constant
Remove introduced CPUNumMin config and hard-code it as 2. |
259,881 | 17.12.2019 13:57:39 | 28,800 | 91f1ac731933ac1fe0f9ef30f4c9d06fa4031021 | Mark enableCpuidFault nosplit
This is called after fork, so it must be nosplit.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess_amd64.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess_amd64.go",
"diff": "@@ -167,8 +167,14 @@ func patchSignalInfo(regs *syscall.PtraceRegs, signalInfo *arch.SignalInfo) {\n}\n}\n-// enableCpuidFault enable cpuid-... | Go | Apache License 2.0 | google/gvisor | Mark enableCpuidFault nosplit
This is called after fork, so it must be nosplit.
Updates #1408
PiperOrigin-RevId: 286053054 |
259,974 | 18.11.2019 09:34:02 | 0 | cb533f18cbb93e3f236ba191d1693e93716313b5 | Enable pkg/sentry/strace support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/BUILD",
"new_path": "pkg/sentry/strace/BUILD",
"diff": "@@ -10,7 +10,8 @@ go_library(\n\"capability.go\",\n\"clone.go\",\n\"futex.go\",\n- \"linux64.go\",\n+ \"linux64_amd64.go\",\n+ \"linux64_arm64.go\",\n\"open.go\",\n\"poll.go\",\n\"ptrace... | Go | Apache License 2.0 | google/gvisor | Enable pkg/sentry/strace support on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I006a1845b6aab2c2fdb9d80fffc1868a6a132ecd |
259,881 | 18.12.2019 12:20:16 | 28,800 | 803437c96bb4b212dba425f0378ce4f6c0c9fff9 | Upgrade to Python 3
Python 3 tools must be listed in exec_tools for genrules. | [
{
"change_type": "MODIFY",
"old_path": "vdso/BUILD",
"new_path": "vdso/BUILD",
"diff": "@@ -68,14 +68,14 @@ genrule(\n\"&& $(location :check_vdso) \" +\n\"--check-data \" +\n\"--vdso $(location vdso.so) \",\n+ exec_tools = [\n+ \":check_vdso\",\n+ ],\nfeatures = [\"-pie\"],\ntoolchains = [\n\"@bazel... | Go | Apache License 2.0 | google/gvisor | Upgrade to Python 3
Python 3 tools must be listed in exec_tools for genrules.
PiperOrigin-RevId: 286241702 |
259,881 | 18.12.2019 12:59:32 | 28,800 | 334a513f11f0ecc260abcce549b1f1a74edc2c51 | Add Mems_allowed to /proc/PID/status | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -604,6 +604,10 @@ func (s *statusData) ReadSeqFileData(ctx context.Context, h seqfile.SeqHandle) (\nfmt.Fprintf(&buf, \"CapEff:\\t%016x\\n\", creds.EffectiveCaps)\nfmt.Fprintf(&... | Go | Apache License 2.0 | google/gvisor | Add Mems_allowed to /proc/PID/status
PiperOrigin-RevId: 286248378 |
259,885 | 18.12.2019 15:47:24 | 28,800 | 744401297a8c93ce5992ba99aa84f3dcdc19ae9e | Add VFS2 plumbing for extended attributes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/filesystem.go",
"new_path": "pkg/sentry/fsimpl/ext/filesystem.go",
"diff": "@@ -443,6 +443,42 @@ func (fs *filesystem) UnlinkAt(ctx context.Context, rp *vfs.ResolvingPath) error\nreturn syserror.EROFS\n}\n+// ListxattrAt implements vfs.Fi... | Go | Apache License 2.0 | google/gvisor | Add VFS2 plumbing for extended attributes.
PiperOrigin-RevId: 286281274 |
259,992 | 18.12.2019 17:09:08 | 28,800 | 0d475cdb019e659c84e767a7d89452cd12332257 | Increase waitForProcessList timeout
It can take more than 10 seconds when running under --race. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -60,7 +60,7 @@ func waitForProcessList(cont *Container, want []*control.Process) error {\nreturn nil\n}\n// Gives plenty of time as tests can run slow under --race... | Go | Apache License 2.0 | google/gvisor | Increase waitForProcessList timeout
It can take more than 10 seconds when running under --race.
PiperOrigin-RevId: 286296060 |
259,853 | 18.12.2019 18:22:50 | 28,800 | 57ce26c0b465dce332a59c9fabb05f737ff4241d | net/tcp: allow to call listen without bind
When listen(2) is called on an unbound socket, the socket is
automatically bound to a random free port with the local address
set to INADDR_ANY. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1974,6 +1974,15 @@ func (e *endpoint) listen(backlog int) *tcpip.Error {\nreturn nil\n}\n+ if e.state == StateInitial {\n+ // The listen is called on an unbou... | Go | Apache License 2.0 | google/gvisor | net/tcp: allow to call listen without bind
When listen(2) is called on an unbound socket, the socket is
automatically bound to a random free port with the local address
set to INADDR_ANY.
PiperOrigin-RevId: 286305906 |
259,847 | 19.12.2019 15:24:15 | 28,800 | 80c8aecd51c8cda02fe36ed663d09e5b71a5b682 | Install python2 in the Dockerfile.
Without it, we get a build failure (inside the container) when trying to build
//runsc. | [
{
"change_type": "MODIFY",
"old_path": "Dockerfile",
"new_path": "Dockerfile",
"diff": "FROM ubuntu:bionic\n-RUN apt-get update && apt-get install -y curl gnupg2 git python3 python3-distutils python3-pip\n+RUN apt-get update && apt-get install -y curl gnupg2 git python python3 python3-distutils pyth... | Go | Apache License 2.0 | google/gvisor | Install python2 in the Dockerfile.
Without it, we get a build failure (inside the container) when trying to build
//runsc.
PiperOrigin-RevId: 286474518 |
259,860 | 19.12.2019 16:05:35 | 28,800 | 7419e0e5d74621b2be60e9b18e4e2d7bb2a65cc3 | Parameterize mmap tests.
This test suite has existed for quite a while and has become kind of messy.
Various tests can be joined together by parameterizing. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mmap.cc",
"new_path": "test/syscalls/linux/mmap.cc",
"diff": "@@ -814,22 +814,26 @@ class MMapFileTest : public MMapTest {\n}\n};\n+class MMapFileParamTest\n+ : public MMapFileTest,\n+ public ::testing::WithParamInterface<std::tuple<int, in... | Go | Apache License 2.0 | google/gvisor | Parameterize mmap tests.
This test suite has existed for quite a while and has become kind of messy.
Various tests can be joined together by parameterizing.
PiperOrigin-RevId: 286482240 |
259,860 | 20.12.2019 08:43:15 | 28,800 | 822d847ccaa1e6016b818bee289b5e33335f9fee | Check for valid nfds before copying in an fd set.
Otherwise, CopyInFDSet will try to allocate a negative-length slice. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/select.go",
"new_path": "pkg/sentry/strace/select.go",
"diff": "@@ -36,6 +36,9 @@ func fdsFromSet(t *kernel.Task, set []byte) []int {\n}\nfunc fdSet(t *kernel.Task, nfds int, addr usermem.Addr) string {\n+ if nfds < 0 {\n+ return fmt.Sprintf(... | Go | Apache License 2.0 | google/gvisor | Check for valid nfds before copying in an fd set.
Otherwise, CopyInFDSet will try to allocate a negative-length slice.
PiperOrigin-RevId: 286584907 |
259,885 | 20.12.2019 11:52:24 | 28,800 | 3eb489ed6c67b069bc135ab92cb031ce80b40d8f | Move VFS2 file description status flags to vfs.FileDescription. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/file_description.go",
"new_path": "pkg/sentry/fsimpl/ext/file_description.go",
"diff": "@@ -26,13 +26,6 @@ import (\ntype fileDescription struct {\nvfsfd vfs.FileDescription\nvfs.FileDescriptionDefaultImpl\n-\n- // flags is the same as vf... | Go | Apache License 2.0 | google/gvisor | Move VFS2 file description status flags to vfs.FileDescription.
PiperOrigin-RevId: 286616668 |
259,891 | 20.12.2019 14:17:57 | 28,800 | 08c39e25870821f84f6da1915ceefe13b3196e02 | Change TODO to track correct bug. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ipv6.go",
"new_path": "pkg/tcpip/network/ipv6/ipv6.go",
"diff": "@@ -162,7 +162,7 @@ func (e *endpoint) WritePackets(r *stack.Route, gso *stack.GSO, pkts []tcpip.Pac\n// WriteHeaderIncludedPacker implements stack.NetworkEndpoint. It is n... | Go | Apache License 2.0 | google/gvisor | Change TODO to track correct bug.
PiperOrigin-RevId: 286639163 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.