author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,885 | 20.12.2019 16:43:34 | 28,800 | 21a14e9532365fc5eb51a5796ab66cf7f007ede3 | Add vfs.Dentry.Children(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/dentry.go",
"new_path": "pkg/sentry/vfs/dentry.go",
"diff": "@@ -85,12 +85,12 @@ type Dentry struct {\n// mounts is accessed using atomic memory operations.\nmounts uint32\n- // mu synchronizes disowning and mounting over this Dentry.\n- mu sync... | Go | Apache License 2.0 | google/gvisor | Add vfs.Dentry.Children().
PiperOrigin-RevId: 286660774 |
259,885 | 20.12.2019 17:40:18 | 28,800 | 818eb22b11d6e0c056af6d4605e8cd246e622231 | Add vfs.ResolvingPath.HandleJump(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/resolving_path.go",
"new_path": "pkg/sentry/vfs/resolving_path.go",
"diff": "@@ -85,11 +85,11 @@ func init() {\n// so error \"constants\" are really mutable vars, necessitating somewhat\n// expensive interface object comparisons.\n-type resolveM... | Go | Apache License 2.0 | google/gvisor | Add vfs.ResolvingPath.HandleJump().
PiperOrigin-RevId: 286666533 |
259,975 | 23.12.2019 11:48:03 | 28,800 | e548ce18051398fb3fe379326080411f59fda379 | Add python3-pip as dependency for Kokoro VM images.
bm-tools requires python3 and pip3 in order to run
tests. Add pip3 so that dependencies correctly install
for Kokoro runs with bazel. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/ubuntu1604/40_kokoro.sh",
"new_path": "kokoro/ubuntu1604/40_kokoro.sh",
"diff": "@@ -23,7 +23,7 @@ declare -r ssh_public_keys=(\n)\n# Install dependencies.\n-apt-get update && apt-get install -y rsync coreutils python-psutil qemu-kvm python-pip zip\n+ap... | Go | Apache License 2.0 | google/gvisor | Add python3-pip as dependency for Kokoro VM images.
bm-tools requires python3 and pip3 in order to run
tests. Add pip3 so that dependencies correctly install
for Kokoro runs with bazel.
PiperOrigin-RevId: 286923840 |
259,992 | 23.12.2019 17:31:20 | 28,800 | 574e988f2bc6060078a17f37a377441703c52a22 | Fix deadlock in kernfs.Filesystem.revalidateChildLocked
It was calling Dentry.InsertChild with the dentry's mutex
already locked.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -122,7 +122,7 @@ func (fs *Filesystem) revalidateChildLocked(ctx context.Context, vfsObj *vfs.Vir\nreturn nil, err\n}\n// Reference on childVFSD dropped ... | Go | Apache License 2.0 | google/gvisor | Fix deadlock in kernfs.Filesystem.revalidateChildLocked
It was calling Dentry.InsertChild with the dentry's mutex
already locked.
Updates #1035
PiperOrigin-RevId: 286962742 |
259,885 | 27.12.2019 00:12:14 | 28,800 | 796f53c0befc21570b185811e26b74e71950dfc3 | Add VFS2 support for /proc/filesystems.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/benchmark/benchmark_test.go",
"new_path": "pkg/sentry/fsimpl/ext/benchmark/benchmark_test.go",
"diff": "@@ -50,7 +50,9 @@ func setUp(b *testing.B, imagePath string) (context.Context, *vfs.VirtualFilesys\n// Create VFS.\nvfsObj := vfs.New(... | Go | Apache License 2.0 | google/gvisor | Add VFS2 support for /proc/filesystems.
Updates #1195
PiperOrigin-RevId: 287269106 |
259,885 | 30.12.2019 11:35:06 | 28,800 | 1f384ac42b9ee8b52000dc2bff79d975853519ed | Add VFS2 support for device special files.
Add FileDescriptionOptions.UseDentryMetadata, which reduces the amount of
boilerplate needed for device FDs and the like between filesystems.
Switch back to having FileDescription.Init() take references on the Mount and
Dentry; otherwise managing refcounts around failed calls to
OpenDeviceSpecialFile() / Device.Open() is tricky. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/inode.go",
"new_path": "pkg/sentry/fsimpl/ext/inode.go",
"diff": "@@ -157,8 +157,6 @@ func (in *inode) open(rp *vfs.ResolvingPath, vfsd *vfs.Dentry, flags uint32) (*v\nswitch in.impl.(type) {\ncase *regularFile:\nvar fd regularFileFD\n- m... | Go | Apache License 2.0 | google/gvisor | Add VFS2 support for device special files.
- Add FileDescriptionOptions.UseDentryMetadata, which reduces the amount of
boilerplate needed for device FDs and the like between filesystems.
- Switch back to having FileDescription.Init() take references on the Mount and
Dentry; otherwise managing refcounts around failed calls to
OpenDeviceSpecialFile() / Device.Open() is tricky.
PiperOrigin-RevId: 287575574 |
259,865 | 31.12.2019 16:49:30 | -3,600 | 200cf245c4ed43d8e2a37484cdbc36f5fbfa1ac9 | netstack: minor fix typo in "if err" handler | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/sample/tun_tcp_connect/main.go",
"new_path": "pkg/tcpip/sample/tun_tcp_connect/main.go",
"diff": "@@ -164,7 +164,7 @@ func main() {\n// Create TCP endpoint.\nvar wq waiter.Queue\nep, e := s.NewEndpoint(tcp.ProtocolNumber, ipv4.ProtocolNumber, &wq)\n-... | Go | Apache License 2.0 | google/gvisor | netstack: minor fix typo in "if err" handler |
259,975 | 03.01.2020 17:46:04 | 28,800 | bf53d325ddcd533d202efcab40047535078a02f3 | Remove FIXME comments to close old bug. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/procfs.go",
"new_path": "pkg/sentry/mm/procfs.go",
"diff": "@@ -66,8 +66,6 @@ func (mm *MemoryManager) ReadMapsDataInto(ctx context.Context, buf *bytes.Buffer\nvar start usermem.Addr\nfor vseg := mm.vmas.LowerBoundSegment(start); vseg.Ok(); vseg ... | Go | Apache License 2.0 | google/gvisor | Remove FIXME comments to close old bug.
PiperOrigin-RevId: 288075400 |
259,974 | 31.12.2019 08:44:06 | 0 | de0d127ae61df783745880871a199ff86a720035 | Make some of the fcntl flags arch specific..
Some of the flags in the file system related system call
are architecture specific(O_NOFOLLOW/O_DIRECT..). Ref to
the fcntl.h file in the Linux src codes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -36,10 +36,6 @@ const (\nO_NONBLOCK = 000004000\nO_DSYNC = 000010000\nO_ASYNC = 000020000\n- O_DIRECT = 000040000\n- O_LARGEFILE = 000100000\n- O_DIRECTORY = 000200000\n- O_NOFOLLOW = 000... | Go | Apache License 2.0 | google/gvisor | Make some of the fcntl flags arch specific..
Some of the flags in the file system related system call
are architecture specific(O_NOFOLLOW/O_DIRECT..). Ref to
the fcntl.h file in the Linux src codes.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I354d988073bfd0c9ff5371d4e0be9da2b8fd019f |
260,004 | 07.01.2020 10:07:59 | 28,800 | 2031cc4701d5bfd21b34d7b0f7dc86920a553385 | Disable auto-generation of IPv6 link-local addresses for loopback NICs
Test: Test that an IPv6 link-local address is not auto-generated for loopback
NICs, even when it is enabled for non-loopback NICS. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -174,7 +174,8 @@ func (n *NIC) enable() *tcpip.Error {\nreturn err\n}\n- if !n.stack.autoGenIPv6LinkLocal {\n+ // Do not auto-generate an IPv6 link-local address for loopback devices.\n... | Go | Apache License 2.0 | google/gvisor | Disable auto-generation of IPv6 link-local addresses for loopback NICs
Test: Test that an IPv6 link-local address is not auto-generated for loopback
NICs, even when it is enabled for non-loopback NICS.
PiperOrigin-RevId: 288519591 |
259,858 | 07.01.2020 17:25:18 | 28,800 | e77ad574233b779519a253c6f58197c339e9100a | Fix partial_bad_buffer write tests.
The write tests are fitted to Linux-specific behavior, but it is not
well-specified. Tweak the tests to allow for both acceptable outcomes. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/partial_bad_buffer.cc",
"new_path": "test/syscalls/linux/partial_bad_buffer.cc",
"diff": "#include <netinet/tcp.h>\n#include <sys/mman.h>\n#include <sys/socket.h>\n+#include <sys/stat.h>\n#include <sys/syscall.h>\n+#include <sys/types.h>\n#... | Go | Apache License 2.0 | google/gvisor | Fix partial_bad_buffer write tests.
The write tests are fitted to Linux-specific behavior, but it is not
well-specified. Tweak the tests to allow for both acceptable outcomes.
PiperOrigin-RevId: 288606386 |
259,853 | 07.01.2020 23:52:59 | 28,800 | a53ac7307abfeb7172e67f48d0a7aaa4b5c3f31e | fs/splice: don't report a partialResult error if there is no data loss | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/file.go",
"new_path": "pkg/sentry/fs/file.go",
"diff": "@@ -555,6 +555,10 @@ type lockedWriter struct {\n//\n// This applies only to Write, not WriteAt.\nOffset int64\n+\n+ // Err contains the first error encountered while copying. This is\n+ // ... | Go | Apache License 2.0 | google/gvisor | fs/splice: don't report a partialResult error if there is no data loss
PiperOrigin-RevId: 288642552 |
259,942 | 08.01.2020 09:28:53 | 28,800 | 0cc1e74b57e539e66c1a421c047a08635c0008e8 | Add NIC.isLoopback()
...enabling us to remove the "CreateNamedLoopbackNIC" variant of
CreateNIC and all the plumbing to connect it through to where the value
is read in FindRoute. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -31,7 +31,6 @@ type NIC struct {\nid tcpip.NICID\nname string\nlinkEP LinkEndpoint\n- loopback bool\nmu sync.RWMutex\nspoofing bool\n@@ -85,7 +84,7 @@ const (\n)\n// newNIC returns a ne... | Go | Apache License 2.0 | google/gvisor | Add NIC.isLoopback()
...enabling us to remove the "CreateNamedLoopbackNIC" variant of
CreateNIC and all the plumbing to connect it through to where the value
is read in FindRoute.
PiperOrigin-RevId: 288713093 |
259,992 | 08.01.2020 10:30:50 | 28,800 | db376e13924be59182ed4df95762328febf26298 | Make /proc/[pid] offset start at TGID_OFFSET
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/tasks.go",
"new_path": "pkg/sentry/fsimpl/proc/tasks.go",
"diff": "@@ -27,7 +27,11 @@ import (\n\"gvisor.dev/gvisor/pkg/syserror\"\n)\n-const defaultPermission = 0444\n+const (\n+ defaultPermission = 0444\n+ selfName = \"self\"\n+ thread... | Go | Apache License 2.0 | google/gvisor | Make /proc/[pid] offset start at TGID_OFFSET
Updates #1195
PiperOrigin-RevId: 288725745 |
259,891 | 08.01.2020 11:15:46 | 28,800 | 1e1921e2acdb7357972257219fdffb9edf17bf55 | Minor fixes to comments and logging | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -157,9 +157,7 @@ func convertNetstackToBinary(name string, table iptables.Table) (linux.KernelIPT\nmeta.HookEntry[hook] = entries.Size\n}\n}\n- // Is... | Go | Apache License 2.0 | google/gvisor | Minor fixes to comments and logging |
259,891 | 08.01.2020 12:43:46 | 28,800 | 7cebd77806d164a3baec52eaeb05662e8c404967 | First commit -- re-adding DROP | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -410,10 +410,7 @@ func parseTarget(optVal []byte) (iptables.Target, uint32, *syserr.Error) {\ncase iptables.Accept:\nreturn iptables.UnconditionalAcc... | Go | Apache License 2.0 | google/gvisor | First commit -- re-adding DROP |
259,891 | 08.01.2020 12:48:17 | 28,800 | 447f64c561e6b5893c1bbae7d641187b7aca64ac | Added test for unconditional DROP on the filter INPUT chain | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/filter_input.go",
"new_path": "test/iptables/filter_input.go",
"diff": "@@ -31,6 +31,7 @@ func init() {\nRegisterTestCase(FilterInputDropUDP{})\nRegisterTestCase(FilterInputDropUDPPort{})\nRegisterTestCase(FilterInputDropDifferentUDPPort{})\n+ Re... | Go | Apache License 2.0 | google/gvisor | Added test for unconditional DROP on the filter INPUT chain |
259,891 | 08.01.2020 14:48:47 | 28,800 | b2a881784c8e525c1fea71c6f23663413d107f05 | Built dead-simple traversal, but now getting depedency cycle error :'( | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -368,6 +368,10 @@ func SetEntries(stack *stack.Stack, optVal []byte) *syserr.Error {\n}\n}\n+ // TODO(gvisor.dev/issue/170): Check the following cond... | Go | Apache License 2.0 | google/gvisor | Built dead-simple traversal, but now getting depedency cycle error :'( |
259,942 | 08.01.2020 14:49:12 | 28,800 | e21c5840569155d39e8e11ac18cee99bc6d67469 | Combine various Create*NIC methods into CreateNICWithOptions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/ndp_test.go",
"new_path": "pkg/tcpip/stack/ndp_test.go",
"diff": "@@ -2500,9 +2500,9 @@ func TestAutoGenAddrWithOpaqueIID(t *testing.T) {\nSecretKey: secretKey,\n},\n})\n-\n- if err := s.CreateNamedNIC(nicID, nicName, e); err != nil {\n- t.Fata... | Go | Apache License 2.0 | google/gvisor | Combine various Create*NIC methods into CreateNICWithOptions.
PiperOrigin-RevId: 288779416 |
259,891 | 08.01.2020 15:57:25 | 28,800 | 0999ae8b34d83a4b2ea8342d0459c8131c35d6e1 | Getting a panic when running tests. For some reason the filter table is
ending up with the wrong chains and is indexing -1 into rules. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -25,7 +25,6 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/kernel\"\n\"gvisor.dev/gvisor/pkg/sentry/usermem\"\n\"gvisor.dev/gvisor/pkg/syserr\"\n- \"gvi... | Go | Apache License 2.0 | google/gvisor | Getting a panic when running tests. For some reason the filter table is
ending up with the wrong chains and is indexing -1 into rules. |
259,992 | 08.01.2020 15:40:00 | 28,800 | 1c2420146777de5b5727f69331b50be1b57a3351 | Github bug reviver
For everyone's joy, this is a tool that reopens issues that
have been closed, but are still referenced by TODOs in the
code. The idea is to run it in Kokoro nightly. Kokoro changes
are coming up next. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -290,6 +290,27 @@ go_repository(\nversion = \"v1.3.1\",\n)\n+go_repository(\n+ name = \"com_github_google_go-github\",\n+ importpath = \"github.com/google/go-github\",\n+ sum = \"h1:N0LgJ1j65A7kfXrZnUDaYCs/Sf4rE... | Go | Apache License 2.0 | google/gvisor | Github bug reviver
For everyone's joy, this is a tool that reopens issues that
have been closed, but are still referenced by TODOs in the
code. The idea is to run it in Kokoro nightly. Kokoro changes
are coming up next.
PiperOrigin-RevId: 288789560 |
260,003 | 08.01.2020 16:29:12 | 28,800 | b3ae8a62cfdf13821d35467d4150ed983ac556f1 | Fix slice bounds out of range panic in parsing socket control message.
Panic found by syzakller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/control.go",
"new_path": "pkg/sentry/socket/control/control.go",
"diff": "@@ -471,6 +471,9 @@ func Parse(t *kernel.Task, socketOrEndpoint interface{}, buf []byte) (socket.Con\ncase linux.SOL_IP:\nswitch h.Type {\ncase linux.IP_TOS:\n+... | Go | Apache License 2.0 | google/gvisor | Fix slice bounds out of range panic in parsing socket control message.
Panic found by syzakller.
PiperOrigin-RevId: 288799046 |
259,891 | 08.01.2020 16:35:01 | 28,800 | f26a576984052a235b63ec79081a8c4a8c8ffc00 | Addressed GH comments | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -298,6 +298,7 @@ type IPTReplace struct {\n// Entries [0]IPTEntry\n}\n+// KernelIPTEntry is identical to IPTReplace, but includes the Entries field.\ntype KernelIPTReplace struc... | Go | Apache License 2.0 | google/gvisor | Addressed GH comments |
259,860 | 08.01.2020 16:32:50 | 28,800 | 565b64148314018e1234196182b55c4f01772e77 | Define sizes for extent headers and entries separately to improve clarity. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/disklayout/extent.go",
"new_path": "pkg/sentry/fsimpl/ext/disklayout/extent.go",
"diff": "@@ -29,8 +29,12 @@ package disklayout\n// byte (i * sb.BlockSize()) to ((i+1) * sb.BlockSize()).\nconst (\n- // ExtentStructsSize is the size of all... | Go | Apache License 2.0 | google/gvisor | Define sizes for extent headers and entries separately to improve clarity.
PiperOrigin-RevId: 288799694 |
259,884 | 08.01.2020 16:35:43 | 28,800 | fbb2c008e26a7e9d860f6cbf796ea7c375858502 | Return correct length with MSG_TRUNC for unix sockets.
This change calls a new Truncate method on the EndpointReader in RecvMsg for
both netlink and unix sockets. This allows readers such as sockets to peek at
the length of data without actually reading it to a buffer.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netlink/BUILD",
"new_path": "pkg/sentry/socket/netlink/BUILD",
"diff": "@@ -22,7 +22,6 @@ go_library(\n\"//pkg/sentry/kernel\",\n\"//pkg/sentry/kernel/auth\",\n\"//pkg/sentry/kernel/time\",\n- \"//pkg/sentry/safemem\",\n\"//pkg/sentry/socket\... | Go | Apache License 2.0 | google/gvisor | Return correct length with MSG_TRUNC for unix sockets.
This change calls a new Truncate method on the EndpointReader in RecvMsg for
both netlink and unix sockets. This allows readers such as sockets to peek at
the length of data without actually reading it to a buffer.
Fixes #993 #1240
PiperOrigin-RevId: 288800167 |
259,891 | 08.01.2020 17:30:08 | 28,800 | ae060a63d9ad1bfb65b84a2ccbaf2893c5a50b76 | More GH comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -298,7 +298,7 @@ type IPTReplace struct {\n// Entries [0]IPTEntry\n}\n-// KernelIPTEntry is identical to IPTReplace, but includes the Entries field.\n+// KernelIPTReplace is ide... | Go | Apache License 2.0 | google/gvisor | More GH comments. |
259,891 | 08.01.2020 21:39:13 | 28,800 | 781a68eeb65b4db09ae6591a4273e27a2bf60999 | It works! It drops some packets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -52,7 +52,7 @@ func GetInfo(t *kernel.Task, stack *stack.Stack, outPtr usermem.Addr) (linux.IPT\n}\n// Find the appropriate table.\n- table, err := f... | Go | Apache License 2.0 | google/gvisor | It works! It drops some packets. |
259,891 | 08.01.2020 22:10:35 | 28,800 | aeb3a4017b9bc038ebe5630fe270d5ea8691d141 | Working on filtering by protocol. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/iptables/types.go",
"new_path": "pkg/tcpip/iptables/types.go",
"diff": "@@ -151,6 +151,9 @@ func (table *Table) SetMetadata(metadata interface{}) {\n// packets this rule applies to. If there are no matchers in the rule, it\n// applies to any packet.\... | Go | Apache License 2.0 | google/gvisor | Working on filtering by protocol. |
259,857 | 09.01.2020 09:01:17 | 0 | fdfa05ff2c99b4a2f7c0b22fc491a268f1f2e164 | Avoid panic when c.PCIDs is nil
When PCID is disabled, there would throw a panic
when dropPageTables() access to c.PCID without check. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"diff": "@@ -90,9 +90,11 @@ func (m *machine) dropPageTables(pt *pagetables.PageTables) {\n// Clear from all PCIDs.\nfor _, c := range m.vCPUs {\n+ if c.PCIDs !=... | Go | Apache License 2.0 | google/gvisor | Avoid panic when c.PCIDs is nil
When PCID is disabled, there would throw a panic
when dropPageTables() access to c.PCID without check.
Signed-off-by: Lai Jiangshan <eag0628@gmail.com> |
259,881 | 08.01.2020 16:58:30 | 28,800 | afbd4a130b3b49224b8c25a50d2bf1cfadd49ed3 | Use question marks for questions | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/FAQ.md",
"new_path": "content/docs/user_guide/FAQ.md",
"diff": "@@ -23,11 +23,11 @@ gVisor supports Linux\nBinaries run in gVisor should be built for the\n[AMD64](https://en.wikipedia.org/wiki/X86-64) CPU architecture.\n-### Can I run D... | Go | Apache License 2.0 | google/gvisor | Use question marks for questions |
259,992 | 09.01.2020 10:16:02 | 28,800 | 290908fa8ae2363c3d2a7af7cef8d5dda622cde7 | Configure issue reviver to run with Kokoro | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/issue_reviver.cfg",
"diff": "+build_file: \"repo/scripts/issue_reviver.sh\"\n+\n+before_action {\n+ fetch_keystore {\n+ keystore_resource {\n+ keystore_config_id: 73898\n+ keyname: \"kokoro-github-access-token\"\n+ }\n+ }\n+}\n+\n+env_var... | Go | Apache License 2.0 | google/gvisor | Configure issue reviver to run with Kokoro
PiperOrigin-RevId: 288921032 |
259,896 | 09.01.2020 10:03:22 | 28,800 | 6cc8e2d814f99439e01c308e16f6631d75578ec0 | Add test to check iptables redirect port rule | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/filter_input.go",
"new_path": "test/iptables/filter_input.go",
"diff": "@@ -23,6 +23,7 @@ import (\nconst (\ndropPort = 2401\nacceptPort = 2402\n+ redirectPort = 42\nsendloopDuration = 2 * time.Second\nnetwork = \"udp4\"\n)\n@@ -31,6 +32,7 @@ fun... | Go | Apache License 2.0 | google/gvisor | Add test to check iptables redirect port rule |
259,942 | 09.01.2020 10:34:30 | 28,800 | e752ddbb72d89b19863a6b50d99814149a08d5fe | Allow clients to store an opaque NICContext with NICs
...retrievable later via stack.NICInfo().
Clients of this library can use it to add metadata that should be tracked
alongside a NIC, to avoid having to keep a map[tcpip.NICID]metadata mirroring
stack.Stack's nic map. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -31,6 +31,7 @@ type NIC struct {\nid tcpip.NICID\nname string\nlinkEP LinkEndpoint\n+ context NICContext\nmu sync.RWMutex\nspoofing bool\n@@ -84,7 +85,7 @@ const (\n)\n// newNIC returns... | Go | Apache License 2.0 | google/gvisor | Allow clients to store an opaque NICContext with NICs
...retrievable later via stack.NICInfo().
Clients of this library can use it to add metadata that should be tracked
alongside a NIC, to avoid having to keep a map[tcpip.NICID]metadata mirroring
stack.Stack's nic map.
PiperOrigin-RevId: 288924900 |
259,972 | 09.01.2020 13:06:24 | 28,800 | 8643933d6e58492cbe9d5c78124873ab40f65feb | Change BindToDeviceOption to store NICID
This makes it possible to call the sockopt from go even when the NIC has no
name. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -985,13 +985,23 @@ func getSockOptSocket(t *kernel.Task, s socket.Socket, ep commonEndpoint, family\nif err := ep.GetSockOpt(&v); err != nil {\nreturn ni... | Go | Apache License 2.0 | google/gvisor | Change BindToDeviceOption to store NICID
This makes it possible to call the sockopt from go even when the NIC has no
name.
PiperOrigin-RevId: 288955236 |
259,891 | 09.01.2020 13:41:52 | 28,800 | 89d11b4d96b0c40e373f14ba72d570c9b894f976 | Added a test that we don't pass yet | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -323,10 +323,9 @@ func SetEntries(stack *stack.Stack, optVal []byte) *syserr.Error {\n// TODO(gvisor.dev/issue/170): We should support IPTIP\n// filt... | Go | Apache License 2.0 | google/gvisor | Added a test that we don't pass yet |
259,891 | 09.01.2020 15:38:21 | 28,800 | ff719159befaee7d2abcfeb88905a7486cd34845 | Confirmed that it works if I hardcode 17 in for pkt.Protocol. Need to address parsing the packet early :( | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/iptables/iptables.go",
"new_path": "pkg/tcpip/iptables/iptables.go",
"diff": "@@ -188,9 +188,9 @@ func (it *IPTables) checkRule(hook Hook, pkt tcpip.PacketBuffer, table Table, ru\n// First check whether the packet matches the IP header filter.\n// TO... | Go | Apache License 2.0 | google/gvisor | Confirmed that it works if I hardcode 17 in for pkt.Protocol. Need to address parsing the packet early :( |
259,896 | 09.01.2020 15:38:28 | 28,800 | 04abc9cf558930472605bf740a4333d6fafe5930 | Add test for redirect port
Fix the indentation and print statements.
Moved the NAT redirect tests to new file.
Added negative test to check redirect rule on ports other than
redirected port. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/BUILD",
"new_path": "test/iptables/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_library(\n\"filter_input.go\",\n\"iptables.go\",\n\"iptables_util.go\",\n+ \"nat.go\",\n],\nimportpath = \"gvisor.dev/gvisor/test/iptables\",\nvisibility = [\"//test/iptables:... | Go | Apache License 2.0 | google/gvisor | Add test for redirect port
Fix the indentation and print statements.
Moved the NAT redirect tests to new file.
Added negative test to check redirect rule on ports other than
redirected port. |
260,004 | 09.01.2020 15:55:24 | 28,800 | 8fafd3142e85175fe56bc3333d859f1a8cfbb878 | Separate NDP tests into its own package
Internal tools timeout after 60s during tests that are required to pass before
changes can be submitted. Separate out NDP tests into its own package to help
prevent timeouts when testing. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -52,7 +52,6 @@ go_test(\nname = \"stack_x_test\",\nsize = \"small\",\nsrcs = [\n- \"ndp_test.go\",\n\"stack_test.go\",\n\"transport_demuxer_test.go\",\n\"transport_test.go\",\n@@ -62,14 +... | Go | Apache License 2.0 | google/gvisor | Separate NDP tests into its own package
Internal tools timeout after 60s during tests that are required to pass before
changes can be submitted. Separate out NDP tests into its own package to help
prevent timeouts when testing.
PiperOrigin-RevId: 288990597 |
259,962 | 09.01.2020 17:56:58 | 28,800 | 356d81146bafc4b4548163eb87e886c851b49e12 | Deflake a couple of TCP syscall tests when run under gotsan. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_bind_to_device_distribution.cc",
"new_path": "test/syscalls/linux/socket_bind_to_device_distribution.cc",
"diff": "@@ -183,7 +183,14 @@ TEST_P(BindToDeviceDistributionTest, Tcp) {\n}\n// Receive some data from a socket to be sure tha... | Go | Apache License 2.0 | google/gvisor | Deflake a couple of TCP syscall tests when run under gotsan.
PiperOrigin-RevId: 289010316 |
259,962 | 10.01.2020 06:01:10 | 28,800 | dacd349d6fb4fc7453b1fbf694158fd25496ed42 | panic fix in retransmitTimerExpired.
This is a band-aid fix for now to prevent panics. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -442,6 +442,13 @@ func (s *sender) retransmitTimerExpired() bool {\nreturn true\n}\n+ // TODO(b/147297758): Band-aid fix, retransmitTimer can fire in some edge cases\n+ ... | Go | Apache License 2.0 | google/gvisor | panic fix in retransmitTimerExpired.
This is a band-aid fix for now to prevent panics.
PiperOrigin-RevId: 289078453 |
259,896 | 10.01.2020 09:05:25 | 28,800 | 9aeb053bbaf834aab5b716b8645996943262b525 | Add tests for redirect port
Fix indentation and change function names. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/iptables_test.go",
"new_path": "test/iptables/iptables_test.go",
"diff": "@@ -178,14 +178,14 @@ func TestFilterInputDropDifferentUDPPort(t *testing.T) {\n}\n}\n-func TestFilterNATRedirectUDPPort(t *testing.T) {\n- if err := singleTest(FilterNATRe... | Go | Apache License 2.0 | google/gvisor | Add tests for redirect port
Fix indentation and change function names. |
259,854 | 10.01.2020 13:33:12 | 28,800 | 6b83111499e9a8f42b6aa3998839922ba70eefdc | goid: new package
Allows retrieving the goroutine ID for concurrency testing when the race
detector is enabled.
Updates | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/goid/BUILD",
"diff": "+load(\"//tools/go_stateify:defs.bzl\", \"go_library\")\n+load(\"@io_bazel_rules_go//go:def.bzl\", \"go_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"goid\",\n+ srcs = [\n+ \"goid.go\",\n+ \... | Go | Apache License 2.0 | google/gvisor | goid: new package
Allows retrieving the goroutine ID for concurrency testing when the race
detector is enabled.
Updates #1472
PiperOrigin-RevId: 289155308 |
260,004 | 10.01.2020 14:30:33 | 28,800 | bcedf6a8e48b958e39ad7a7dba908354620a0d09 | Put CancellableTimer tests in the tcpip_test package
CancellableTimer tests were in a timer_test package but lived within the
tcpip directory. This caused issues with go tools. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/BUILD",
"new_path": "pkg/tcpip/BUILD",
"diff": "@@ -30,7 +30,7 @@ go_test(\n)\ngo_test(\n- name = \"timer_test\",\n+ name = \"tcpip_x_test\",\nsize = \"small\",\nsrcs = [\"timer_test.go\"],\ndeps = [\":tcpip\"],\n"
},
{
"change_type": "MODIFY... | Go | Apache License 2.0 | google/gvisor | Put CancellableTimer tests in the tcpip_test package
CancellableTimer tests were in a timer_test package but lived within the
tcpip directory. This caused issues with go tools.
PiperOrigin-RevId: 289166345 |
259,847 | 10.01.2020 16:34:59 | 28,800 | bf6429b944aed6de073c62ceb446cfaed5042dbc | Don't set RWF_HIPRI on InvalidOffset test.
This test fails on ubuntu 18.04 because preadv2 for some reason returns
EOPNOTSUPP instead of EINVAL. Instead of root-causing the failure, I'm dropping
the flag in the preadv2 call since it isn't under test in this scenario. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/preadv2.cc",
"new_path": "test/syscalls/linux/preadv2.cc",
"diff": "@@ -202,7 +202,7 @@ TEST(Preadv2Test, TestInvalidOffset) {\niov[0].iov_len = 0;\nEXPECT_THAT(preadv2(fd.get(), iov.get(), /*iovcnt=*/1, /*offset=*/-8,\n- /*flags=*/RWF_HIPR... | Go | Apache License 2.0 | google/gvisor | Don't set RWF_HIPRI on InvalidOffset test.
This test fails on ubuntu 18.04 because preadv2 for some reason returns
EOPNOTSUPP instead of EINVAL. Instead of root-causing the failure, I'm dropping
the flag in the preadv2 call since it isn't under test in this scenario.
PiperOrigin-RevId: 289188358 |
259,891 | 10.01.2020 18:07:15 | 28,800 | d793677cd424fef10ac0b080871d181db0bcdec0 | I think INPUT works with protocol | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -25,6 +25,7 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/kernel\"\n\"gvisor.dev/gvisor/pkg/sentry/usermem\"\n\"gvisor.dev/gvisor/pkg/syserr\"\n+ \"gvi... | Go | Apache License 2.0 | google/gvisor | I think INPUT works with protocol |
259,896 | 13.01.2020 09:11:40 | 28,800 | 98327a94cce7597589ac22b8557c5d9a2a03464d | Add test for iptables TCP rule
Added tests for tcp protocol with input and output rules including options sport and dport
Increased timeout in iptables_test as TCP tests were timing out with existing value. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/BUILD",
"new_path": "test/iptables/BUILD",
"diff": "@@ -6,6 +6,7 @@ go_library(\nname = \"iptables\",\nsrcs = [\n\"filter_input.go\",\n+ \"filter_output.go\",\n\"iptables.go\",\n\"iptables_util.go\",\n\"nat.go\",\n"
},
{
"change_type": "M... | Go | Apache License 2.0 | google/gvisor | Add test for iptables TCP rule
Added tests for tcp protocol with input and output rules including options sport and dport
Increased timeout in iptables_test as TCP tests were timing out with existing value. |
259,853 | 13.01.2020 10:14:30 | 28,800 | f54b9c0ee6e02f9c8bf32aa268c9028ff741bf7c | tests: fix errors detected by asan. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/inotify.cc",
"new_path": "test/syscalls/linux/inotify.cc",
"diff": "@@ -977,7 +977,7 @@ TEST(Inotify, WatchOnRelativePath) {\nASSERT_NO_ERRNO_AND_VALUE(Open(file1.path(), O_RDONLY));\n// Change working directory to root.\n- const char* old_... | Go | Apache License 2.0 | google/gvisor | tests: fix errors detected by asan.
PiperOrigin-RevId: 289467083 |
259,853 | 13.01.2020 13:08:36 | 28,800 | fff04769518b279a364c928307a71055eaa6166d | benchmarks/tcp: set a number of channels to GOMAXPROCS
Updates | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/tcp/tcp_benchmark.sh",
"new_path": "benchmarks/tcp/tcp_benchmark.sh",
"diff": "@@ -41,6 +41,8 @@ duplicate=0.1 # 0.1% means duplicates are 1/10x as frequent as losses.\nduration=30 # 30s is enough time to consistent results (experimentally).\nhelper... | Go | Apache License 2.0 | google/gvisor | benchmarks/tcp: set a number of channels to GOMAXPROCS
Updates #231
PiperOrigin-RevId: 289502669 |
259,891 | 13.01.2020 14:14:49 | 28,800 | 36641a21953b72d64d4378d4974ef467e901a5fe | Only allow INPUT modifications. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -365,9 +365,22 @@ func SetEntries(stack *stack.Stack, optVal []byte) *syserr.Error {\n}\n}\n+ // TODO(gvisor.dev/issue/170): Support other chains.\n+... | Go | Apache License 2.0 | google/gvisor | Only allow INPUT modifications. |
259,891 | 13.01.2020 14:54:32 | 28,800 | 1c3d3c70b93d483894dd49fb444171347f0ca250 | Fix test building. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ip_test.go",
"new_path": "pkg/tcpip/network/ip_test.go",
"diff": "@@ -212,10 +212,17 @@ func buildIPv6Route(local, remote tcpip.Address) (stack.Route, *tcpip.Error) {\nreturn s.FindRoute(1, local, remote, ipv6.ProtocolNumber, false /* multica... | Go | Apache License 2.0 | google/gvisor | Fix test building. |
259,891 | 13.01.2020 16:10:00 | 28,800 | bd292894097ffdf316bc78d81aebd0a2988124f3 | Protocol filtering works. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/iptables/iptables.go",
"new_path": "pkg/tcpip/iptables/iptables.go",
"diff": "@@ -187,7 +187,7 @@ func (it *IPTables) checkRule(hook Hook, pkt tcpip.PacketBuffer, table Table, ru\n// First check whether the packet matches the IP header filter.\n// TO... | Go | Apache License 2.0 | google/gvisor | Protocol filtering works. |
259,884 | 05.12.2019 20:54:13 | 18,000 | eef069778b020e02d36c546ce9c92894254a75aa | Build runsc in Docker container
This removes the build dependency on Bazel. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -58,7 +58,17 @@ node_modules: package.json package-lock.json\n$(NPM) ci\nupstream/gvisor/bazel-bin/runsc/linux_amd64_pure_stripped/runsc: upstream-gvisor\n- cd upstream/gvisor && bazel build runsc\n+ mkdir -p /tmp... | Go | Apache License 2.0 | google/gvisor | Build runsc in Docker container
This removes the build dependency on Bazel. |
259,884 | 05.12.2019 20:55:19 | 18,000 | 89ac3bdc31d85412a9ce2073e96313588f6fb636 | Run npm in Docker image.
This partially removes the build dependency on node.js. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "HUGO := hugo\nHUGO_VERSION := 0.53\nHTMLPROOFER_VERSION := 3.10.2\n-NPM := npm\nGCLOUD := gcloud\nGCP_PROJECT := gvisor-website\n@@ -55,7 +54,14 @@ static-staging: compatibility-docs node_modules config.toml $(shell ... | Go | Apache License 2.0 | google/gvisor | Run npm in Docker image.
This partially removes the build dependency on node.js. |
259,884 | 06.12.2019 08:37:19 | 18,000 | 6e5080f5dc3527b2382bd2a91f7d5eace4793b17 | Use hugo Docker image in Makefile
Removes the local dependency on hugo for building. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "-HUGO := hugo\nHUGO_VERSION := 0.53\nHTMLPROOFER_VERSION := 3.10.2\nGCLOUD := gcloud\n@@ -43,12 +42,29 @@ content/docs/community/sigs: upstream/community $(wildcard upstream/community/si\n$(APP_TARGET): public $(APP_... | Go | Apache License 2.0 | google/gvisor | Use hugo Docker image in Makefile
Removes the local dependency on hugo for building. |
259,884 | 06.12.2019 09:05:46 | 18,000 | 2274c9929a0feff9dab29b72a8f0395077e15ad8 | Add --rm to docker run commands. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -44,6 +44,7 @@ $(APP_TARGET): public $(APP_SOURCE)\nstatic-production: hugo-docker-image compatibility-docs node_modules config.toml $(shell find archetypes assets content themes -type f | sed 's/ /\\\\ /g')\ndock... | Go | Apache License 2.0 | google/gvisor | Add --rm to docker run commands. |
259,884 | 06.12.2019 09:14:33 | 18,000 | 039f309bc9ef9a70e0fe9f6c0372ced57b173a93 | Update readme with new docs.
Rearrange the docs into sections on using Github or Git locally.
Remove the troubleshooting FAQ since we build using Docker. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -4,24 +4,14 @@ This repository holds the content for the gVisor website. It uses\n[hugo](https://gohugo.io/) to generate the website and\n[Docsy](https://github.com/google/docsy) as the theme.\n-## Requirements\... | Go | Apache License 2.0 | google/gvisor | Update readme with new docs.
- Rearrange the docs into sections on using Github or Git locally.
- Remove the troubleshooting FAQ since we build using Docker. |
259,884 | 14.01.2020 17:06:53 | -32,400 | 80111fc68ba57e5b7c7e694f12813283db2a8c80 | Remove troubleshooting section
Remove troubleshooting section that was added back in merge. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -77,11 +77,3 @@ Custom CSS styles should go into the\nIf you need to override or create variables used in scss styles, update the\n[_variables_project.scss](assets/scss/_variables_project.scss) file.\n-\n-## Tro... | Go | Apache License 2.0 | google/gvisor | Remove troubleshooting section
Remove troubleshooting section that was added back in merge. |
259,884 | 21.12.2019 02:59:04 | 18,000 | eae7c2f6bd27f7553d77e60842a4bddc09cac5c5 | Add a tutorial on CNI | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "content/docs/tutorials/cni.md",
"diff": "++++\n+title = \"Using CNI\"\n+weight = 1\n++++\n+\n+This tutorial will show you how to set up networking for a gVisor sandbox using\n+the [Container Networking Interface (CNI)](https://github.com/contain... | Go | Apache License 2.0 | google/gvisor | Add a tutorial on CNI |
259,891 | 14.01.2020 17:54:02 | 28,800 | 95e9de31d20ee1c7262fe5870e10485a369e6497 | Address Nic's comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/iptables/iptables.go",
"new_path": "pkg/tcpip/iptables/iptables.go",
"diff": "@@ -153,6 +153,8 @@ func (it *IPTables) Check(hook Hook, pkt tcpip.PacketBuffer) bool {\nreturn false\ncase Stolen, Queue, Repeat, None, Jump, Return, Continue:\npanic(fmt.... | Go | Apache License 2.0 | google/gvisor | Address Nic's comments. |
259,962 | 15.01.2020 11:17:25 | 28,800 | f874723e64bd8a2e747bb336e0b6b8f0da1f044a | Bump SO_SNDBUF for fdbased endpoint used by runsc.
Updates | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/tcp/tcp_proxy.go",
"new_path": "benchmarks/tcp/tcp_proxy.go",
"diff": "@@ -85,7 +85,7 @@ func (netImpl) printStats() {\nconst (\nnicID = 1 // Fixed.\n- rcvBufSize = 4 << 20 // 1MB.\n+ bufSize = 4 << 20 // 4MB.\n)\ntype netstackImpl struct {\n@@ -125... | Go | Apache License 2.0 | google/gvisor | Bump SO_SNDBUF for fdbased endpoint used by runsc.
Updates #231
PiperOrigin-RevId: 289897881 |
259,974 | 16.01.2020 10:26:23 | 28,800 | 420d335fc9495ec18a20f710869770d0708d9a49 | Enable clone syscall support on arm64.
sys_clone has many flavors in Linux, and amd64 chose
a different one from x86(different arguments order).
Ref kernel/fork.c for more info.
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/1545 from xiaobo55x:clone | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/BUILD",
"new_path": "pkg/sentry/syscalls/linux/BUILD",
"diff": "@@ -13,6 +13,8 @@ go_library(\n\"sigset.go\",\n\"sys_aio.go\",\n\"sys_capability.go\",\n+ \"sys_clone_amd64.go\",\n+ \"sys_clone_arm64.go\",\n\"sys_epoll.go\",\n\"sys_eve... | Go | Apache License 2.0 | google/gvisor | Enable clone syscall support on arm64.
sys_clone has many flavors in Linux, and amd64 chose
a different one from x86(different arguments order).
Ref kernel/fork.c for more info.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I6c8cbc685f4a6e786b171715ab68292fc95cbf48
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/1545 from xiaobo55x:clone 156bd2dfbc63ef5291627b0578ddea77997393b2
PiperOrigin-RevId: 290093953 |
259,975 | 16.01.2020 13:00:58 | 28,800 | 94be30a18dc7c75dc70716ce1ede74a7fb1352fb | Add run-gcp command.
Add command to run benchmarks on GCP backed machines
using the gcloud producer.
Run with:
`bazel run :benchmarks -- run-gcp [BENCHMARK_NAME]`
Tested with the startup benchmark. | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/harness/__init__.py",
"new_path": "benchmarks/harness/__init__.py",
"diff": "# limitations under the License.\n\"\"\"Core benchmark utilities.\"\"\"\n+import getpass\nimport os\n# LOCAL_WORKLOADS_PATH defines the path to use for local workloads. Thi... | Go | Apache License 2.0 | google/gvisor | Add run-gcp command.
Add command to run benchmarks on GCP backed machines
using the gcloud producer.
Run with:
`bazel run :benchmarks -- run-gcp [BENCHMARK_NAME]`
Tested with the startup benchmark.
PiperOrigin-RevId: 290126444 |
259,860 | 16.01.2020 14:25:56 | 28,800 | 1e7f0c822b3a7c643d532d40a14ab79eb1df85c6 | Bump p9 version, adding corresponding checks to client_file.go. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/client_file.go",
"new_path": "pkg/p9/client_file.go",
"diff": "@@ -170,6 +170,9 @@ func (c *clientFile) GetXattr(name string, size uint64) (string, error) {\nif atomic.LoadUint32(&c.closed) != 0 {\nreturn \"\", syscall.EBADF\n}\n+ if !versionSupportsGet... | Go | Apache License 2.0 | google/gvisor | Bump p9 version, adding corresponding checks to client_file.go.
PiperOrigin-RevId: 290145451 |
259,860 | 16.01.2020 18:13:27 | 28,800 | 7a45ae7e67438697296fc12345202e3c76304096 | Implement setxattr for overlays. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode.go",
"new_path": "pkg/sentry/fs/inode.go",
"diff": "@@ -270,9 +270,9 @@ func (i *Inode) GetXattr(ctx context.Context, name string, size uint64) (string,\n}\n// SetXattr calls i.InodeOperations.SetXattr with i as the Inode.\n-func (i *Inode)... | Go | Apache License 2.0 | google/gvisor | Implement setxattr for overlays.
PiperOrigin-RevId: 290186303 |
259,884 | 17.01.2020 02:13:07 | 18,000 | 10ec43c775afaa49ca638cd2d411e975e06dbe78 | Clean up markdown lists | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/checkpoint_restore.md",
"new_path": "content/docs/user_guide/checkpoint_restore.md",
"diff": "@@ -83,17 +83,17 @@ docker start --checkpoint --checkpoint-dir=<directory> <container>\n### Issues Preventing Compatibility with Docker\n-* **... | Go | Apache License 2.0 | google/gvisor | Clean up markdown lists |
259,884 | 17.01.2020 02:27:50 | 18,000 | fd0628b5f565f24cf4145065e404bf5f40aa265f | Dedup check command | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -106,9 +106,6 @@ compatibility-docs: bin/generate-syscall-docs upstream/gvisor/bazel-bin/runsc/li\n.PHONY: compatibility-docs\ncheck: check-markdown check-html\n- docker run \\\n- -v $(shell pwd)/public:/public gc... | Go | Apache License 2.0 | google/gvisor | Dedup check command |
259,974 | 06.12.2019 06:29:24 | 0 | 82ae857877fdf3492f40bca87657a07892c3f59b | Enable build of test/syscall tests on arm64. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -19,6 +19,16 @@ exports_files(\nvisibility = [\"//:sandbox\"],\n)\n+config_setting(\n+ name = \"x86_64\",\n+ constraint_values = [\"@bazel_tools//platforms:x86_64\"],\n+)\n+\n+con... | Go | Apache License 2.0 | google/gvisor | Enable build of test/syscall tests on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I277d6c708bbf5c3edd7c3568941cfd01dc122e17 |
259,884 | 17.01.2020 02:40:46 | 18,000 | 3bdcdb0097d4a1d499d78c9e5a50dab2e1a01e0a | Dedup remark config | [
{
"change_type": "DELETE",
"old_path": "content/.remarkrc",
"new_path": null,
"diff": "-{\n- \"settings\": {\n- \"footnotes\": true\n- },\n- \"plugins\": [\n- \"remark-preset-lint-recommended\",\n- [\"remark-lint-list-item-indent\", false]\n- ]\n-}\n"
},
{
"change_type": "MODIFY",
"old_p... | Go | Apache License 2.0 | google/gvisor | Dedup remark config |
259,860 | 17.01.2020 08:10:14 | 28,800 | 345df7cab48ac79bccf2620900cd972b3026296d | Add explanation for implementation of BSD full file locks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/lock/lock.go",
"new_path": "pkg/sentry/fs/lock/lock.go",
"diff": "@@ -78,6 +78,9 @@ const (\n)\n// LockEOF is the maximal possible end of a regional file lock.\n+//\n+// A BSD-style full file lock can be represented as a regional file lock from\n... | Go | Apache License 2.0 | google/gvisor | Add explanation for implementation of BSD full file locks.
PiperOrigin-RevId: 290272560 |
259,974 | 17.01.2020 08:22:21 | 28,800 | acf2d6dcc34501d2573f9c3f2b6da80308f3267e | Enable stat syscall support on arm64.
x86 and arm64 use a different stat struct in Linux
kernel, so the stat() syscall implementation has
to handle the file stat data separately.
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/1493 from xiaobo55x:stat | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/BUILD",
"new_path": "pkg/sentry/syscalls/linux/BUILD",
"diff": "@@ -42,6 +42,8 @@ go_library(\n\"sys_socket.go\",\n\"sys_splice.go\",\n\"sys_stat.go\",\n+ \"sys_stat_amd64.go\",\n+ \"sys_stat_arm64.go\",\n\"sys_sync.go\",\n\"sys_sysin... | Go | Apache License 2.0 | google/gvisor | Enable stat syscall support on arm64.
x86 and arm64 use a different stat struct in Linux
kernel, so the stat() syscall implementation has
to handle the file stat data separately.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: If3986e915a667362257a54e7fbbcc1fe18951015
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/1493 from xiaobo55x:stat f15a216d9297eb9a96d2c483d396a9919145d7fa
PiperOrigin-RevId: 290274287 |
259,992 | 17.01.2020 09:33:14 | 28,800 | ff9960985848a48863c01f91acd5b34d3e83a9c5 | Add /proc/net/* files
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/BUILD",
"new_path": "pkg/sentry/fsimpl/proc/BUILD",
"diff": "@@ -18,7 +18,6 @@ go_library(\nimportpath = \"gvisor.dev/gvisor/pkg/sentry/fsimpl/proc\",\ndeps = [\n\"//pkg/abi/linux\",\n- \"//pkg/binary\",\n\"//pkg/log\",\n\"//pkg/sentry/c... | Go | Apache License 2.0 | google/gvisor | Add /proc/net/* files
Updates #1195
PiperOrigin-RevId: 290285420 |
259,992 | 17.01.2020 10:39:24 | 28,800 | 8e8d0f96f651ce161dfe6003d738dbda28f7cb0e | Add /proc/[pid]/cgroups file
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/filesystem.go",
"new_path": "pkg/sentry/fsimpl/proc/filesystem.go",
"diff": "@@ -47,7 +47,12 @@ func (ft *procFSType) GetFilesystem(ctx context.Context, vfsObj *vfs.VirtualFile\nprocfs := &kernfs.Filesystem{}\nprocfs.VFSFilesystem().Init... | Go | Apache License 2.0 | google/gvisor | Add /proc/[pid]/cgroups file
Updates #1195
PiperOrigin-RevId: 290298266 |
259,853 | 17.01.2020 13:31:26 | 28,800 | 9073521098ee52cdda74a193565b7bbe75d8c35a | Convert EventMask to uint64
It is used for signalfd where the maximum signal is 64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/waiter/waiter.go",
"new_path": "pkg/waiter/waiter.go",
"diff": "@@ -62,7 +62,7 @@ import (\n)\n// EventMask represents io events as used in the poll() syscall.\n-type EventMask uint16\n+type EventMask uint64\n// Events that waiters can wait on. The meaning... | Go | Apache License 2.0 | google/gvisor | Convert EventMask to uint64
It is used for signalfd where the maximum signal is 64.
PiperOrigin-RevId: 290331008 |
259,972 | 17.01.2020 18:24:39 | 28,800 | 47d85257d3d015f0b9f7739c81af0ee9f510aaf5 | Filter out received packets with a local source IP address.
CERT Advisory CA-96.21 III. Solution advises that devices drop packets which
could not have correctly arrived on the wire, such as receiving a packet where
the source IP address is owned by the device that sent it.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -139,7 +139,8 @@ var Metrics = tcpip.Stats{\n},\nIP: tcpip.IPStats{\nPacketsReceived: mustCreateMetric(\"/netstack/ip/packets_received\", \"Total number ... | Go | Apache License 2.0 | google/gvisor | Filter out received packets with a local source IP address.
CERT Advisory CA-96.21 III. Solution advises that devices drop packets which
could not have correctly arrived on the wire, such as receiving a packet where
the source IP address is owned by the device that sent it.
Fixes #1507
PiperOrigin-RevId: 290378240 |
259,974 | 20.12.2019 06:00:30 | 0 | c0e39a8271198f10407009ec1994e5d9efac796c | Enable uname syscall support on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_utsname.go",
"new_path": "pkg/sentry/syscalls/linux/sys_utsname.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// +build amd64\n+// +build amd64 arm64\npac... | Go | Apache License 2.0 | google/gvisor | Enable uname syscall support on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I206f38416a64d7c6a8531d8eb305c6ea239616b8 |
259,860 | 21.01.2020 12:41:50 | 28,800 | 2ba6198851dc1e293295d7cadf8c0ae456b68beb | Add syscalls for lgetxattr, fgetxattr, lsetxattr, and fsetxattr.
Note that these simply will use the same logic as getxattr and setxattr, which
is not yet implemented for most filesystems. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64_amd64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64_amd64.go",
"diff": "@@ -229,11 +229,11 @@ var AMD64 = &kernel.SyscallTable{\n186: syscalls.Supported(\"gettid\", Gettid),\n187: syscalls.Supported(\"readahead\", Readah... | Go | Apache License 2.0 | google/gvisor | Add syscalls for lgetxattr, fgetxattr, lsetxattr, and fsetxattr.
Note that these simply will use the same logic as getxattr and setxattr, which
is not yet implemented for most filesystems.
PiperOrigin-RevId: 290800960 |
259,992 | 21.01.2020 13:26:50 | 28,800 | d46c397a1cd38f1e2aa5c864c1bb8594fb87bb63 | Add line break to /proc/net files
Some files were missing the last line break. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -52,17 +52,17 @@ func (p *proc) newNetDir(ctx context.Context, k *kernel.Kernel, msrc *fs.MountSo\n// implemented in netstack, if the file contains a\n// header the stub is just t... | Go | Apache License 2.0 | google/gvisor | Add line break to /proc/net files
Some files were missing the last line break.
PiperOrigin-RevId: 290808898 |
259,928 | 21.01.2020 14:15:01 | 28,800 | cbc0a92276b75e744511a43a9c0b78fc64946ec6 | Correct todos referencing IPV6_RECVTCLASS
Bug was revived because TODOs referenced the IP_RECVTOS bug instead
of the IPV6_RECVTCLASS bug. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/udp_socket_test_cases.cc",
"new_path": "test/syscalls/linux/udp_socket_test_cases.cc",
"diff": "@@ -1349,7 +1349,7 @@ TEST_P(UdpSocketTest, TimestampIoctlPersistence) {\n// outgoing packets, and that a receiving socket with IP_RECVTOS or\n/... | Go | Apache License 2.0 | google/gvisor | Correct todos referencing IPV6_RECVTCLASS
Bug 68320120 was revived because TODOs referenced the IP_RECVTOS bug instead
of the IPV6_RECVTCLASS bug.
PiperOrigin-RevId: 290820178 |
259,891 | 21.01.2020 14:47:17 | 28,800 | 9143fcd7fd38243dd40f927dafaeb75f6ef8ef49 | Add UDP matchers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -340,3 +340,95 @@ func goString(cstring []byte) string {\n}\nreturn string(cstring)\n}\n+\n+// XTTCP holds data for matching TCP packets. It corresponds to struct xt_tcp\n+// in... | Go | Apache License 2.0 | google/gvisor | Add UDP matchers. |
259,891 | 21.01.2020 14:51:28 | 28,800 | 2661101ad470548cb15dce0afc694296668d780a | Removed TCP work (saved in ipt-tcp-match). | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -341,58 +341,6 @@ func goString(cstring []byte) string {\nreturn string(cstring)\n}\n-// XTTCP holds data for matching TCP packets. It corresponds to struct xt_tcp\n-// in inclu... | Go | Apache License 2.0 | google/gvisor | Removed TCP work (saved in ipt-tcp-match). |
259,985 | 21.01.2020 14:25:14 | 28,800 | ad1968ed5665c7541d6920edbd7c7492b7db3046 | Implement sysfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -180,6 +180,19 @@ const (\nDT_WHT = 14\n)\n+// DirentType are the friendly strings for linux_dirent64.d_type.\n+var DirentType = abi.ValueSet{\n+ DT_UNKNOWN: \"DT_UNKNOWN\",\n+ DT_FIFO: \... | Go | Apache License 2.0 | google/gvisor | Implement sysfs.
PiperOrigin-RevId: 290822487 |
260,023 | 21.01.2020 14:47:04 | 28,800 | 7e6fbc6afe797752efe066a8aa86f9eca973f3a4 | Add a new TCP stat for current open connections.
Such a stat accounts for all connections that are currently
established and not yet transitioned to close state.
Also fix bug in double increment of CurrentEstablished stat.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -150,7 +150,8 @@ var Metrics = tcpip.Stats{\nTCP: tcpip.TCPStats{\nActiveConnectionOpenings: mustCreateMetric(\"/netstack/tcp/active_connection_openings\... | Go | Apache License 2.0 | google/gvisor | Add a new TCP stat for current open connections.
Such a stat accounts for all connections that are currently
established and not yet transitioned to close state.
Also fix bug in double increment of CurrentEstablished stat.
Fixes #1579
PiperOrigin-RevId: 290827365 |
259,891 | 21.01.2020 16:51:17 | 28,800 | 538053538dfb378aa8bc512d484ea305177e617b | Adding serialization. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -196,7 +196,9 @@ func convertNetstackToBinary(tablename string, table iptables.Table) (linux.Kern\n}\nfunc marshalMatcher(matcher iptables.Matcher) [... | Go | Apache License 2.0 | google/gvisor | Adding serialization. |
259,854 | 21.01.2020 16:59:24 | 28,800 | 1effdc091b441c4b1ada4327c1422cd360f80f98 | TMutex based on sync.Mutex.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/BUILD",
"new_path": "pkg/sync/BUILD",
"diff": "@@ -38,6 +38,7 @@ go_library(\n\"race_unsafe.go\",\n\"seqcount.go\",\n\"syncutil.go\",\n+ \"tmutex_unsafe.go\",\n],\nimportpath = \"gvisor.dev/gvisor/pkg/sync\",\n)\n@@ -48,6 +49,7 @@ go_test(\nsrcs = [\n... | Go | Apache License 2.0 | google/gvisor | TMutex based on sync.Mutex.
Updates #231
PiperOrigin-RevId: 290854399 |
259,854 | 21.01.2020 18:34:24 | 28,800 | d0e75f2bef4e16356693987db6ae6bbdce749618 | Add trylock support to DowngradableRWMutex.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/downgradable_rwmutex_test.go",
"new_path": "pkg/sync/downgradable_rwmutex_test.go",
"diff": "@@ -148,3 +148,58 @@ func TestDowngradableRWMutex(t *testing.T) {\nHammerDowngradableRWMutex(10, 10, n)\nHammerDowngradableRWMutex(10, 5, n)\n}\n+\n+func Test... | Go | Apache License 2.0 | google/gvisor | Add trylock support to DowngradableRWMutex.
Updates #231
PiperOrigin-RevId: 290868875 |
259,854 | 21.01.2020 19:23:26 | 28,800 | 6a59e7f510a7b12f8b3bd768dfe569033ef07d30 | Rename DowngradableRWMutex to RWmutex.
Also renames TMutex to Mutex.
These custom mutexes aren't any worse than the standard library versions (same
code), so having both seems redundant. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/overlay.go",
"new_path": "pkg/sentry/fs/overlay.go",
"diff": "@@ -198,7 +198,7 @@ type overlayEntry struct {\nupper *Inode\n// dirCacheMu protects dirCache.\n- dirCacheMu sync.DowngradableRWMutex `state:\"nosave\"`\n+ dirCacheMu sync.RWMutex `sta... | Go | Apache License 2.0 | google/gvisor | Rename DowngradableRWMutex to RWmutex.
Also renames TMutex to Mutex.
These custom mutexes aren't any worse than the standard library versions (same
code), so having both seems redundant.
PiperOrigin-RevId: 290873587 |
259,974 | 22.01.2020 05:51:57 | 0 | d59a3cc959cb14b0bed14b62e33ee4178b89b346 | Enable fault() syscall test on arm64. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/fault.cc",
"new_path": "test/syscalls/linux/fault.cc",
"diff": "@@ -37,6 +37,9 @@ int GetPcFromUcontext(ucontext_t* uc, uintptr_t* pc) {\n#elif defined(__i386__)\n*pc = uc->uc_mcontext.gregs[REG_EIP];\nreturn 1;\n+#elif defined(__aarch64__)... | Go | Apache License 2.0 | google/gvisor | Enable fault() syscall test on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I9b2b2e0d84946c10cf136abeef6c60642fa3b6ec |
259,884 | 22.01.2020 11:31:11 | -32,400 | 639b25ed4b66ba7c80e20d698bc32b2b40ba350f | Fix typo: 'hte' -> 'the' | [
{
"change_type": "MODIFY",
"old_path": "content/docs/tutorials/cni.md",
"new_path": "content/docs/tutorials/cni.md",
"diff": "@@ -93,7 +93,7 @@ sudo ip netns add ${CNI_CONTAINERID}\nNext, run the bridge and loopback plugins to apply the configuration that was\ncreated earlier to the namespace. Each ... | Go | Apache License 2.0 | google/gvisor | Fix typo: 'hte' -> 'the' |
259,891 | 22.01.2020 10:23:44 | 28,800 | 747137c120bca27aeb259817d30ef60e01521621 | Address GitHub comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/iptables/types.go",
"new_path": "pkg/tcpip/iptables/types.go",
"diff": "@@ -153,7 +153,7 @@ func (table *Table) SetMetadata(metadata interface{}) {\n// packets this rule applies to. If there are no matchers in the rule, it\n// applies to any packet.\... | Go | Apache License 2.0 | google/gvisor | Address GitHub comments. |
259,885 | 22.01.2020 12:27:16 | 28,800 | 5ab1213a6c405071546c783d6d93b4e9af52842e | Move VFS2 handling of FD readability/writability to vfs.FileDescription. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/inode.go",
"new_path": "pkg/sentry/fsimpl/ext/inode.go",
"diff": "@@ -157,7 +157,9 @@ func (in *inode) open(rp *vfs.ResolvingPath, vfsd *vfs.Dentry, flags uint32) (*v\nswitch in.impl.(type) {\ncase *regularFile:\nvar fd regularFileFD\n- f... | Go | Apache License 2.0 | google/gvisor | Move VFS2 handling of FD readability/writability to vfs.FileDescription.
PiperOrigin-RevId: 291006713 |
259,974 | 22.01.2020 06:22:18 | 0 | 49e84b10e5ed7f94e6cbe003b9f7268e8235bb08 | Unify the kOLargeFile definition in syscall tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/fcntl.cc",
"new_path": "test/syscalls/linux/fcntl.cc",
"diff": "#include \"test/syscalls/linux/socket_test_util.h\"\n#include \"test/util/cleanup.h\"\n#include \"test/util/eventfd_util.h\"\n+#include \"test/util/fs_util.h\"\n#include \"test... | Go | Apache License 2.0 | google/gvisor | Unify the kOLargeFile definition in syscall tests.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: Id9d6ae98305a4057d55d622ea4c3ac2228fea212 |
259,847 | 23.01.2020 10:58:18 | 28,800 | 98e83c444fa58669d45ecf162cf4bf48dce790d1 | Try running kythe build on RBE.
Also add our RBE project/instance to the --config=remote defaults. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -20,6 +20,13 @@ build --stamp --workspace_status_command tools/workspace_status.sh\n# Enable remote execution so actions are performed on the remote systems.\nbuild:remote --remote_executor=grpcs://remotebuildexec... | Go | Apache License 2.0 | google/gvisor | Try running kythe build on RBE.
Also add our RBE project/instance to the --config=remote defaults.
PiperOrigin-RevId: 291201426 |
259,881 | 23.01.2020 11:47:30 | 28,800 | 7a79715504e92be9fc9aebc12fbd65aa46049054 | Check for EINTR from KVM_CREATE_VM
The kernel may return EINTR from:
kvm_create_vm
kvm_init_mmu_notifier
mmu_notifier_register
do_mmu_notifier_register
mm_take_all_locks
Go 1.14's preemptive scheduling signals make hitting this much more likely. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm.go",
"new_path": "pkg/sentry/platform/kvm/kvm.go",
"diff": "@@ -62,10 +62,20 @@ func New(deviceFile *os.File) (*KVM, error) {\n}\n// Create a new VM fd.\n- vm, _, errno := syscall.RawSyscall(syscall.SYS_IOCTL, fd, _KVM_CREATE_VM, 0)... | Go | Apache License 2.0 | google/gvisor | Check for EINTR from KVM_CREATE_VM
The kernel may return EINTR from:
kvm_create_vm
kvm_init_mmu_notifier
mmu_notifier_register
do_mmu_notifier_register
mm_take_all_locks
Go 1.14's preemptive scheduling signals make hitting this much more likely.
PiperOrigin-RevId: 291212669 |
259,847 | 24.01.2020 11:44:31 | 28,800 | 24cfbf4b981a76e46cab47650ef514835990b72e | Fix corpus_name to match our ingestion config[1]. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/kythe/generate_xrefs.sh",
"new_path": "kokoro/kythe/generate_xrefs.sh",
"diff": "set -ex\n-# Install the latest version of Bazel. The default on Kokoro images is out of\n-# date.\nif command -v use_bazel.sh >/dev/null; then\nuse_bazel.sh latest\nfi\n@@ ... | Go | Apache License 2.0 | google/gvisor | Fix corpus_name to match our ingestion config[1].
PiperOrigin-RevId: 291412676 |
259,885 | 24.01.2020 12:53:29 | 28,800 | d135b5abf6eafa92d2745dc98d48ef39d2f90e75 | Add anonymous device number allocation to VFS2.
Note that in VFS2, filesystem device numbers are per-vfs.FilesystemImpl rather
than global, avoiding the need for a "registry" type to handle save/restore.
(This is more consistent with Linux anyway: compare e.g.
mm/shmem.c:shmem_mount() => fs/super.c:mount_nodev() => (indirectly)
set_anon_super().) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/device.go",
"new_path": "pkg/sentry/vfs/device.go",
"diff": "@@ -98,3 +98,32 @@ func (vfs *VirtualFilesystem) OpenDeviceSpecialFile(ctx context.Context, mnt *Mo\n}\nreturn rd.dev.Open(ctx, mnt, d, *opts)\n}\n+\n+// GetAnonBlockDevMinor allocates... | Go | Apache License 2.0 | google/gvisor | Add anonymous device number allocation to VFS2.
Note that in VFS2, filesystem device numbers are per-vfs.FilesystemImpl rather
than global, avoiding the need for a "registry" type to handle save/restore.
(This is more consistent with Linux anyway: compare e.g.
mm/shmem.c:shmem_mount() => fs/super.c:mount_nodev() => (indirectly)
set_anon_super().)
PiperOrigin-RevId: 291425193 |
260,004 | 24.01.2020 13:02:01 | 28,800 | 878bda6e19a0d55525ea6b1600f3413e0c5d6a84 | Lock the NIC when checking if an address is tentative | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -1208,6 +1208,9 @@ func (n *NIC) Stack() *Stack {\n// false. It will only return true if the address is associated with the NIC\n// AND it is tentative.\nfunc (n *NIC) isAddrTentative(a... | Go | Apache License 2.0 | google/gvisor | Lock the NIC when checking if an address is tentative
PiperOrigin-RevId: 291426657 |
259,885 | 24.01.2020 17:06:30 | 28,800 | 18a7e1309decb9bc09879e337adbc00f81d420c5 | Add support for device special files to VFS2 tmpfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/BUILD",
"new_path": "pkg/sentry/fsimpl/tmpfs/BUILD",
"diff": "@@ -20,6 +20,7 @@ go_library(\nname = \"tmpfs\",\nsrcs = [\n\"dentry_list.go\",\n+ \"device_file.go\",\n\"directory.go\",\n\"filesystem.go\",\n\"named_pipe.go\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Add support for device special files to VFS2 tmpfs.
PiperOrigin-RevId: 291471892 |
259,891 | 24.01.2020 17:12:03 | 28,800 | 2946fe81627afa223853769ed736e2a56e0144b7 | We can now actually write out the udp matcher. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -36,7 +36,7 @@ const errorTargetName = \"ERROR\"\n// metadata is opaque to netstack. It holds data that we need to translate\n// between Linux's and ... | Go | Apache License 2.0 | google/gvisor | We can now actually write out the udp matcher. |
259,962 | 27.01.2020 05:33:03 | 28,800 | 6b43cf791a74a746443f70f98d859c1246f87e2a | Replace calculateChecksum w/ the unrolled version.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/checksum.go",
"new_path": "pkg/tcpip/header/checksum.go",
"diff": "@@ -160,20 +160,23 @@ func unrolledCalculateChecksum(buf []byte, odd bool, initial uint32) (uint16, bo\nreturn ChecksumCombine(uint16(v), uint16(v>>16)), odd\n}\n-// Checksum c... | Go | Apache License 2.0 | google/gvisor | Replace calculateChecksum w/ the unrolled version.
Fixes #1656
PiperOrigin-RevId: 291703760 |
259,865 | 22.01.2020 12:50:28 | 0 | 45398b160f4ccc3148644dde5eb5e4610e6a2d9b | Expose gonet.NewPacketConn, for parity with gonet.NewConn API
gonet.Conn can be created with both gonet.NewConn and gonet.Dial.
gonet.PacketConn was created only by gonet.DialUDP. This prevented
us from being able to use PacketConn in udp.NewForwarder() context.
This simple constructor - NewPacketConn, allows user to create
correct structure from that context. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet.go",
"diff": "@@ -556,6 +556,17 @@ type PacketConn struct {\nwq *waiter.Queue\n}\n+// NewPacketConn creates a new PacketConn.\n+func NewPacketConn(s *stack.Stack, wq *waiter.Queue,... | Go | Apache License 2.0 | google/gvisor | Expose gonet.NewPacketConn, for parity with gonet.NewConn API
gonet.Conn can be created with both gonet.NewConn and gonet.Dial.
gonet.PacketConn was created only by gonet.DialUDP. This prevented
us from being able to use PacketConn in udp.NewForwarder() context.
This simple constructor - NewPacketConn, allows user to create
correct structure from that context. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.