author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,891 | 27.01.2020 12:27:04 | 28,800 | 29316e66adfc49c158425554761e34c12338f1d9 | Cleanup for GH review. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -198,6 +198,8 @@ type XTEntryMatch struct {\n// SizeOfXTEntryMatch is the size of an XTEntryMatch.\nconst SizeOfXTEntryMatch = 32\n+// KernelXTEntryMatch is identical to XTEntry... | Go | Apache License 2.0 | google/gvisor | Cleanup for GH review. |
260,003 | 27.01.2020 10:08:18 | 28,800 | 6b14be4246e8ed3779bf69dbd59e669caf3f5704 | Refactor to hide C from channel.Endpoint.
This is to aid later implementation for /dev/net/tun device. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/channel/channel.go",
"new_path": "pkg/tcpip/link/channel/channel.go",
"diff": "package channel\nimport (\n+ \"context\"\n+\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/tcpip/buffer\"\n\"gvisor.dev/gvisor/pkg/tcpip/stack\"\n@@ -38,25... | Go | Apache License 2.0 | google/gvisor | Refactor to hide C from channel.Endpoint.
This is to aid later implementation for /dev/net/tun device.
PiperOrigin-RevId: 291746025 |
259,860 | 27.01.2020 12:19:20 | 28,800 | 13c1f38dfa215ab3e3cc70642721f55ab226d5b7 | Update bug number for supporting extended attribute namespaces. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_xattr.go",
"new_path": "pkg/sentry/syscalls/linux/sys_xattr.go",
"diff": "@@ -103,6 +103,7 @@ func getXattr(t *kernel.Task, d *fs.Dirent, nameAddr usermem.Addr, size uint64)\nreturn 0, \"\", err\n}\n+ // TODO(b/148380782): Support... | Go | Apache License 2.0 | google/gvisor | Update bug number for supporting extended attribute namespaces.
PiperOrigin-RevId: 291774815 |
259,962 | 27.01.2020 12:32:07 | 28,800 | fbfcfcf5b03b4fddb4f00a3e8721cba07fc5343f | Update ChecksumVVWithoffset to use unrolled version.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/checksum.go",
"new_path": "pkg/tcpip/header/checksum.go",
"diff": "@@ -213,7 +213,7 @@ func ChecksumVVWithOffset(vv buffer.VectorisedView, initial uint16, off int, siz\n}\nv = v[:l]\n- sum, odd = calculateChecksum(v, odd, uint32(sum))\n+ sum, ... | Go | Apache License 2.0 | google/gvisor | Update ChecksumVVWithoffset to use unrolled version.
Fixes #1656
PiperOrigin-RevId: 291777279 |
259,858 | 27.01.2020 13:22:50 | 28,800 | 90ec5961667a1c4a21702e64adb383403af8ad25 | Fix licenses.
The preferred Copyright holder is "The gVisor Authors". | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "-// Copyright 2018 Google LLC\n+// Copyright 2018 The gVisor Authors.\n//\n// Licensed under the Apache License, Version 2.0 (the \"License\");\n// you may not use this file ... | Go | Apache License 2.0 | google/gvisor | Fix licenses.
The preferred Copyright holder is "The gVisor Authors".
PiperOrigin-RevId: 291786657 |
259,858 | 27.01.2020 18:26:26 | 28,800 | 5776a7b6f6b52faf6e0735c3f4a892639c1bd773 | Fix header ordering and format all C++ code. | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -36,7 +36,8 @@ directory tree.\nAll Go code should conform to the [Go style guidelines][gostyle]. C++ code\nshould conform to the [Google C++ Style Guide][cppstyle] and the guidelines\n-described for... | Go | Apache License 2.0 | google/gvisor | Fix header ordering and format all C++ code.
PiperOrigin-RevId: 291844200 |
260,004 | 27.01.2020 20:28:14 | 28,800 | 2a2da5be31ea3c32e66f0c0ff61ef189848f5258 | Add a type to represent the NDP Source Link Layer Address option
Tests:
header.TestNDPSourceLinkLayerAddressOptionEthernetAddress
header.TestNDPSourceLinkLayerAddressOptionSerialize
header.TestNDPOptionsIterCheck
header.TestNDPOptionsIter | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/icmpv6.go",
"new_path": "pkg/tcpip/header/icmpv6.go",
"diff": "@@ -52,7 +52,7 @@ const (\n// ICMPv6NeighborAdvertSize is size of a neighbor advertisement\n// including the NDP Target Link Layer option for an Ethernet\n// address.\n- ICMPv6Neig... | Go | Apache License 2.0 | google/gvisor | Add a type to represent the NDP Source Link Layer Address option
Tests:
- header.TestNDPSourceLinkLayerAddressOptionEthernetAddress
- header.TestNDPSourceLinkLayerAddressOptionSerialize
- header.TestNDPOptionsIterCheck
- header.TestNDPOptionsIter
PiperOrigin-RevId: 291856429 |
259,858 | 27.01.2020 22:27:57 | 28,800 | 5d569408ef94c753b7aae9392b5e4ebf7e5ea50d | Create platform_util for tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/32bit.cc",
"new_path": "test/syscalls/linux/32bit.cc",
"diff": "#include <string.h>\n#include <sys/mman.h>\n+#include \"gtest/gtest.h\"\n+#include \"absl/base/macros.h\"\n#include \"test/util/memory_util.h\"\n+#include \"test/util/platform_... | Go | Apache License 2.0 | google/gvisor | Create platform_util for tests.
PiperOrigin-RevId: 291869423 |
259,881 | 28.01.2020 11:12:01 | 28,800 | 76483b8b1ec4ee1fb6b6efb6bdcfaf6dba7be4ce | Check sigsetsize in rt_sigaction
This isn't in the libc wrapper, but it is in the syscall itself.
Discovered by in | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64_amd64.go",
"new_path": "pkg/sentry/strace/linux64_amd64.go",
"diff": "@@ -37,7 +37,7 @@ var linuxAMD64 = SyscallMap{\n10: makeSyscallInfo(\"mprotect\", Hex, Hex, Hex),\n11: makeSyscallInfo(\"munmap\", Hex, Hex),\n12: makeSyscallInfo(\... | Go | Apache License 2.0 | google/gvisor | Check sigsetsize in rt_sigaction
This isn't in the libc wrapper, but it is in the syscall itself.
Discovered by @xiaobo55x in #1625.
PiperOrigin-RevId: 291973931 |
259,885 | 28.01.2020 12:06:58 | 28,800 | 1119644080ae57c206b9b0d8d127cf48423af7f2 | Implement an anon_inode equivalent for VFS2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/BUILD",
"new_path": "pkg/sentry/vfs/BUILD",
"diff": "@@ -5,6 +5,7 @@ licenses([\"notice\"])\ngo_library(\nname = \"vfs\",\nsrcs = [\n+ \"anonfs.go\",\n\"context.go\",\n\"debug.go\",\n\"dentry.go\",\n@@ -20,7 +21,6 @@ go_library(\n\"pathname.go\"... | Go | Apache License 2.0 | google/gvisor | Implement an anon_inode equivalent for VFS2.
PiperOrigin-RevId: 291986033 |
259,883 | 28.01.2020 12:31:58 | 28,800 | d99329e58492ef91b44a0bac346f757e8af2a7ec | netlink: add support for RTM_F_LOOKUP_TABLE
Test command:
$ ip route get 1.1.1.1
Fixes:
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/1121 from tanjianfeng:fix-1099 | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netlink_route.go",
"new_path": "pkg/abi/linux/netlink_route.go",
"diff": "@@ -205,6 +205,9 @@ type RouteMessage struct {\nFlags uint32\n}\n+// SizeOfRouteMessage is the size of RouteMessage.\n+const SizeOfRouteMessage = 12\n+\n// Route types, fro... | Go | Apache License 2.0 | google/gvisor | netlink: add support for RTM_F_LOOKUP_TABLE
Test command:
$ ip route get 1.1.1.1
Fixes: #1099
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com>
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/1121 from tanjianfeng:fix-1099 e6919f3d4ede5aa51a48b3d2be0d7a4b482dd53d
PiperOrigin-RevId: 291990716 |
259,885 | 28.01.2020 13:10:41 | 28,800 | 34fbd8446c386fb0136dad31ab6b173f17049a58 | Add VFS2 support for epoll. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/epoll.go",
"new_path": "pkg/abi/linux/epoll.go",
"diff": "@@ -38,8 +38,14 @@ const (\n// Per-file descriptor flags.\nconst (\n- EPOLLET = 0x80000000\n- EPOLLONESHOT = 0x40000000\n+ EPOLLEXCLUSIVE = 1 << 28\n+ EPOLLWAKEUP = 1 << 29\n+ EPOLLONESHOT... | Go | Apache License 2.0 | google/gvisor | Add VFS2 support for epoll.
PiperOrigin-RevId: 291997879 |
259,853 | 28.01.2020 13:36:16 | 28,800 | f263801a74d4ccac042b068d0928c8738e40af5b | fs/splice: don't report partial errors for special files
Special files can have additional requirements for granularity.
For example, read from eventfd returns EINVAL if a size is less 8 bytes.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/attr.go",
"new_path": "pkg/sentry/fs/attr.go",
"diff": "@@ -206,6 +206,11 @@ func IsPipe(s StableAttr) bool {\nreturn s.Type == Pipe\n}\n+// IsAnonymous returns true if StableAttr.Type matches any type of anonymous.\n+func IsAnonymous(s StableAtt... | Go | Apache License 2.0 | google/gvisor | fs/splice: don't report partial errors for special files
Special files can have additional requirements for granularity.
For example, read from eventfd returns EINVAL if a size is less 8 bytes.
Reported-by: syzbot+3905f5493bec08eb7b02@syzkaller.appspotmail.com
PiperOrigin-RevId: 292002926 |
260,004 | 28.01.2020 13:37:10 | 28,800 | ce0bac4be9d808877248c328fac07ff0d66b9607 | Include the NDP Source Link Layer option when sending DAD messages
Test: stack_test.TestDADResolve | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/checker.go",
"new_path": "pkg/tcpip/checker/checker.go",
"diff": "@@ -771,6 +771,56 @@ func NDPNSTargetAddress(want tcpip.Address) TransportChecker {\n}\n}\n+// NDPNSOptions creates a checker that checks that the packet contains the\n+// prov... | Go | Apache License 2.0 | google/gvisor | Include the NDP Source Link Layer option when sending DAD messages
Test: stack_test.TestDADResolve
PiperOrigin-RevId: 292003124 |
259,885 | 28.01.2020 15:04:34 | 28,800 | 2862b0b1be9ce821e86877802b9608aad3102916 | Add //pkg/sentry/fsimpl/devtmpfs. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/fsimpl/devtmpfs/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+\n+licenses([\"notice\"])\n+\n+go_library(\n+ name = \"devtmpfs\",\n+ srcs = [\"devtmpfs.go\"],\n+ visibility = [\"//pkg/sentry:internal\"],\n... | Go | Apache License 2.0 | google/gvisor | Add //pkg/sentry/fsimpl/devtmpfs.
PiperOrigin-RevId: 292021389 |
260,004 | 28.01.2020 15:39:48 | 28,800 | 431ff52768c2300e15cba609c2be4f507fd30d5b | Update link address for senders of Neighbor Solicitations
Update link address for senders of NDP Neighbor Solicitations when the NS
contains an NDP Source Link Layer Address option.
Tests:
ipv6.TestNeighorSolicitationWithSourceLinkLayerOption
ipv6.TestNeighorSolicitationWithInvalidSourceLinkLayerOption | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "@@ -137,21 +137,24 @@ func (e *endpoint) handleICMP(r *stack.Route, netHeader buffer.View, pkt tcpip.P\n}\nns := header.NDPNeighborSolicit(h.NDPPayload())\n+ it, err := ns.... | Go | Apache License 2.0 | google/gvisor | Update link address for senders of Neighbor Solicitations
Update link address for senders of NDP Neighbor Solicitations when the NS
contains an NDP Source Link Layer Address option.
Tests:
- ipv6.TestNeighorSolicitationWithSourceLinkLayerOption
- ipv6.TestNeighorSolicitationWithInvalidSourceLinkLayerOption
PiperOrigin-RevId: 292028553 |
259,992 | 28.01.2020 16:42:05 | 28,800 | 3d046fef06ece6ba20770fa62e0a21569226adaa | Changes missing in last submit
Updates
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "package kernel\nimport (\n- \"bytes\"\n\"fmt\"\n\"math\"\n+ \"strings\"\n\"sync/atomic\"\n\"syscall\"\n@@ -221,24 +221,24 @@ func (f *FDTable) forEach(fn func(fd int32, file ... | Go | Apache License 2.0 | google/gvisor | Changes missing in last submit
Updates #1487
Updates #1623
PiperOrigin-RevId: 292040835 |
259,992 | 28.01.2020 18:30:36 | 28,800 | 396c574db276ae1424af7098b5cd917e2bed9921 | Add support for WritableSource in DynamicBytesFileDescriptionImpl
WritableSource is a convenience interface used for files that can
be written to, e.g. /proc/net/ipv4/tpc_sack. It reads max of 4KB
and only from offset 0 which should cover most cases. It can be
extended as neeed.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go",
"new_path": "pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go",
"diff": "@@ -108,12 +108,12 @@ func (fd *DynamicBytesFD) PRead(ctx context.Context, dst usermem.IOSequence, off\n// Write implements vfs.FileDescript... | Go | Apache License 2.0 | google/gvisor | Add support for WritableSource in DynamicBytesFileDescriptionImpl
WritableSource is a convenience interface used for files that can
be written to, e.g. /proc/net/ipv4/tpc_sack. It reads max of 4KB
and only from offset 0 which should cover most cases. It can be
extended as neeed.
Updates #1195
PiperOrigin-RevId: 292056924 |
259,885 | 29.01.2020 10:08:25 | 28,800 | 8dcedc953a610b97efe9f68ac8fecf5e15a7e26b | Add //pkg/sentry/devices/memdev. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/dev.go",
"new_path": "pkg/abi/linux/dev.go",
"diff": "@@ -36,6 +36,9 @@ func DecodeDeviceID(rdev uint32) (uint16, uint32) {\n//\n// See Documentations/devices.txt and uapi/linux/major.h.\nconst (\n+ // MEM_MAJOR is the major device number for \"m... | Go | Apache License 2.0 | google/gvisor | Add //pkg/sentry/devices/memdev.
PiperOrigin-RevId: 292165063 |
259,884 | 29.01.2020 18:40:04 | -32,400 | f4a0d6af97f749cd2b15c56975e913e89e85af56 | Add additional error message to FAQ | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/FAQ.md",
"new_path": "content/docs/user_guide/FAQ.md",
"diff": "@@ -69,7 +69,7 @@ Note that `kubectl cp` works because it does the copy by exec'ing inside the\nsandbox, and thus gVisor's internal cache is made aware of the new files and... | Go | Apache License 2.0 | google/gvisor | Add additional error message to FAQ |
259,853 | 29.01.2020 10:35:32 | 28,800 | 37bb502670caefd4113da062495b4e318ea0f72e | sentry: rename SetRSEQInterruptedIP to SetOldRSeqInterruptedIP for arm64
For amd64, this has been done on cl/288342928. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/arch_arm64.go",
"new_path": "pkg/sentry/arch/arch_arm64.go",
"diff": "@@ -137,8 +137,8 @@ func (c *context64) SetTLS(value uintptr) bool {\nreturn false\n}\n-// SetRSEQInterruptedIP implements Context.SetRSEQInterruptedIP.\n-func (c *context64)... | Go | Apache License 2.0 | google/gvisor | sentry: rename SetRSEQInterruptedIP to SetOldRSeqInterruptedIP for arm64
For amd64, this has been done on cl/288342928.
PiperOrigin-RevId: 292170856 |
259,860 | 29.01.2020 11:15:59 | 28,800 | 148fda60e8dee29f2df85e3104e3d5de1a225bcf | Add plumbing for file locks in VFS2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/BUILD",
"new_path": "pkg/sentry/vfs/BUILD",
"diff": "@@ -44,6 +44,7 @@ go_library(\n\"//pkg/context\",\n\"//pkg/fspath\",\n\"//pkg/sentry/arch\",\n+ \"//pkg/sentry/fs/lock\",\n\"//pkg/sentry/kernel/auth\",\n\"//pkg/sentry/memmap\",\n\"//pkg/sync... | Go | Apache License 2.0 | google/gvisor | Add plumbing for file locks in VFS2.
Updates #1480
PiperOrigin-RevId: 292180192 |
259,962 | 29.01.2020 15:41:51 | 28,800 | 51b783505b1ec164b02b48a0fd234509fba01a73 | Add support for TCP_DEFER_ACCEPT. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1260,6 +1260,18 @@ func getSockOptTCP(t *kernel.Task, ep commonEndpoint, name, outLen int) (interfa\nreturn int32(time.Duration(v) / time.Second), nil\n... | Go | Apache License 2.0 | google/gvisor | Add support for TCP_DEFER_ACCEPT.
PiperOrigin-RevId: 292233574 |
259,891 | 29.01.2020 16:26:28 | 28,800 | 0ade523f061d25c2b4abeba9c74e879aae2ce376 | Fix iptables tests that were broken by rename.
The name of the runner binary target changed from "runner" to "runner-image",
causing iptables tests to fail. | [
{
"change_type": "MODIFY",
"old_path": "scripts/iptables_tests.sh",
"new_path": "scripts/iptables_tests.sh",
"diff": "@@ -19,9 +19,9 @@ source $(dirname $0)/common.sh\ninstall_runsc_for_test iptables\n# Build the docker image for the test.\n-run //test/iptables/runner --norun\n+run //test/iptables/r... | Go | Apache License 2.0 | google/gvisor | Fix iptables tests that were broken by rename.
The name of the runner binary target changed from "runner" to "runner-image",
causing iptables tests to fail.
PiperOrigin-RevId: 292242263 |
260,004 | 29.01.2020 19:54:11 | 28,800 | 6f841c304d7bd9af6167d7d049bd5c594358a1b9 | Do not spawn a goroutine when calling stack.NDPDispatcher's methods
Do not start a new goroutine when calling
stack.NDPDispatcher.OnDuplicateAddressDetectionStatus. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/ndp.go",
"new_path": "pkg/tcpip/stack/ndp.go",
"diff": "@@ -167,8 +167,8 @@ type NDPDispatcher interface {\n// reason, such as the address being removed). If an error occured\n// during DAD, err will be set and resolved must be ignored.\n//\n- ... | Go | Apache License 2.0 | google/gvisor | Do not spawn a goroutine when calling stack.NDPDispatcher's methods
Do not start a new goroutine when calling
stack.NDPDispatcher.OnDuplicateAddressDetectionStatus.
PiperOrigin-RevId: 292268574 |
260,004 | 30.01.2020 07:12:04 | 28,800 | ec0679737e8f9ab31ef6c7c3adb5a0005586b5a7 | Do not include the Source Link Layer option with an unspecified source address
When sending NDP messages with an unspecified source address, the Source
Link Layer address must not be included.
Test: stack_test.TestDADResolve | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/ndp.go",
"new_path": "pkg/tcpip/stack/ndp.go",
"diff": "@@ -538,29 +538,11 @@ func (ndp *ndpState) sendDADPacket(addr tcpip.Address) *tcpip.Error {\nr := makeRoute(header.IPv6ProtocolNumber, header.IPv6Any, snmc, ndp.nic.linkEP.LinkAddress(), r... | Go | Apache License 2.0 | google/gvisor | Do not include the Source Link Layer option with an unspecified source address
When sending NDP messages with an unspecified source address, the Source
Link Layer address must not be included.
Test: stack_test.TestDADResolve
PiperOrigin-RevId: 292341334 |
259,881 | 30.01.2020 09:13:36 | 28,800 | ede8dfab3760afc8063c3418f217e52f7ec70d42 | Enforce splice offset limits
Splice must not allow negative offsets. Writes also must not allow offset +
size to overflow int64. Reads are similarly broken, but not just in splice
(b/148095030).
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tmpfs/inode_file.go",
"new_path": "pkg/sentry/fs/tmpfs/inode_file.go",
"diff": "@@ -17,6 +17,7 @@ package tmpfs\nimport (\n\"fmt\"\n\"io\"\n+ \"math\"\n\"time\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -444,10 +445,15 @@ func (rw *fileReadWriter)... | Go | Apache License 2.0 | google/gvisor | Enforce splice offset limits
Splice must not allow negative offsets. Writes also must not allow offset +
size to overflow int64. Reads are similarly broken, but not just in splice
(b/148095030).
Reported-by: syzbot+0e1ff0b95fb2859b4190@syzkaller.appspotmail.com
PiperOrigin-RevId: 292361208 |
260,003 | 31.01.2020 09:55:51 | 28,800 | 7c118f7e192d403e716807c0f75f3f6d077a31ba | KVM platform does not support 32bit.
Fixes: //test/syscalls:32bit_test_runsc_kvm
Ref change: | [
{
"change_type": "MODIFY",
"old_path": "test/util/platform_util.cc",
"new_path": "test/util/platform_util.cc",
"diff": "@@ -20,10 +20,9 @@ namespace gvisor {\nnamespace testing {\nPlatformSupport PlatformSupport32Bit() {\n- if (GvisorPlatform() == Platform::kPtrace) {\n+ if (GvisorPlatform() == Plat... | Go | Apache License 2.0 | google/gvisor | KVM platform does not support 32bit.
Fixes: //test/syscalls:32bit_test_runsc_kvm
Ref change: 5d569408ef94c753b7aae9392b5e4ebf7e5ea50d
PiperOrigin-RevId: 292563926 |
260,004 | 31.01.2020 13:24:48 | 28,800 | 528dd1ec72fee1dd63c734fe92d1b972b5735b8f | Extract multicast IP to Ethernet address mapping
Test: header.TestEthernetAddressFromMulticastIPAddress | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/eth.go",
"new_path": "pkg/tcpip/header/eth.go",
"diff": "@@ -134,3 +134,44 @@ func IsValidUnicastEthernetAddress(addr tcpip.LinkAddress) bool {\n// addr is a valid unicast ethernet address.\nreturn true\n}\n+\n+// EthernetAddressFromMulticastI... | Go | Apache License 2.0 | google/gvisor | Extract multicast IP to Ethernet address mapping
Test: header.TestEthernetAddressFromMulticastIPAddress
PiperOrigin-RevId: 292604649 |
260,004 | 31.01.2020 13:54:57 | 28,800 | 77bf586db75b3dbd9dcb14c349bde8372d26425c | Use multicast Ethernet address for multicast NDP
As per RFC 2464 section 7, an IPv6 packet with a multicast destination
address is transmitted to the mapped Ethernet multicast address.
Test:
ipv6.TestLinkResolution
stack_test.TestDADResolve
stack_test.TestRouterSolicitation | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6_test.go",
"new_path": "pkg/tcpip/header/ipv6_test.go",
"diff": "@@ -17,6 +17,7 @@ package header_test\nimport (\n\"bytes\"\n\"crypto/sha256\"\n+ \"fmt\"\n\"testing\"\n\"github.com/google/go-cmp/cmp\"\n@@ -300,3 +301,31 @@ func TestScopeFo... | Go | Apache License 2.0 | google/gvisor | Use multicast Ethernet address for multicast NDP
As per RFC 2464 section 7, an IPv6 packet with a multicast destination
address is transmitted to the mapped Ethernet multicast address.
Test:
- ipv6.TestLinkResolution
- stack_test.TestDADResolve
- stack_test.TestRouterSolicitation
PiperOrigin-RevId: 292610529 |
259,860 | 31.01.2020 14:14:52 | 28,800 | 6c3072243dfbf70062de5f610e14fd6ed2ce5f32 | Implement file locks for regular tmpfs files in VFSv2.
Add a file lock implementation that can be embedded into various filesystem
implementations.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/BUILD",
"new_path": "pkg/sentry/fsimpl/tmpfs/BUILD",
"diff": "@@ -38,6 +38,7 @@ go_library(\n\"//pkg/sentry/arch\",\n\"//pkg/sentry/fs\",\n\"//pkg/sentry/fs/fsutil\",\n+ \"//pkg/sentry/fs/lock\",\n\"//pkg/sentry/kernel\",\n\"//pkg/sentr... | Go | Apache License 2.0 | google/gvisor | Implement file locks for regular tmpfs files in VFSv2.
Add a file lock implementation that can be embedded into various filesystem
implementations.
Updates #1480
PiperOrigin-RevId: 292614758 |
259,858 | 31.01.2020 14:44:50 | 28,800 | 04cccaaeeed22a28a42fc4c1406b43a966a5d886 | Fix logic around AMD/Intel cases.
If the support is Ignored, then the call is still executed. We
simply rely on it to fall through to the int3. Therefore, we
must also bail on the vendor check. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/32bit.cc",
"new_path": "test/syscalls/linux/32bit.cc",
"diff": "@@ -102,7 +102,8 @@ TEST(Syscall32Bit, Int80) {\n}\nTEST(Syscall32Bit, Sysenter) {\n- if (PlatformSupport32Bit() == PlatformSupport::Allowed &&\n+ if ((PlatformSupport32Bit() =... | Go | Apache License 2.0 | google/gvisor | Fix logic around AMD/Intel cases.
If the support is Ignored, then the call is still executed. We
simply rely on it to fall through to the int3. Therefore, we
must also bail on the vendor check.
PiperOrigin-RevId: 292620558 |
259,854 | 31.01.2020 15:08:17 | 28,800 | 02997af5abd62d778fca4d01b047a6bdebab2090 | Fix method comment to match method name. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -271,8 +271,8 @@ func (l *listenContext) createConnectingEndpoint(s *segment, iss seqnum.Value, i\nreturn n, nil\n}\n-// createEndpoint creates a new endpoint in c... | Go | Apache License 2.0 | google/gvisor | Fix method comment to match method name.
PiperOrigin-RevId: 292624867 |
259,881 | 03.02.2020 11:39:01 | 28,800 | 4d1a648c7c5db8a51416bff647260a1be3b5c12e | Allow mlock in system call filters
Go 1.14 has a workaround for a Linux 5.2-5.4 bug which requires mlock'ing the g
stack to prevent register corruption. We need to allow this syscall until it is
removed from Go. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -174,6 +174,18 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_LSEEK: {},\nsyscall.SYS_MADVISE: {},\nsyscall.SYS_MINCORE: {},\n+ // Used by the Go runtime as a tem... | Go | Apache License 2.0 | google/gvisor | Allow mlock in system call filters
Go 1.14 has a workaround for a Linux 5.2-5.4 bug which requires mlock'ing the g
stack to prevent register corruption. We need to allow this syscall until it is
removed from Go.
PiperOrigin-RevId: 292967478 |
259,972 | 03.02.2020 12:03:38 | 28,800 | 9742daf3c201771d257c0d043347f4eebf3088e0 | Add packetdrill tests that use docker. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "test/packetdrill/BUILD",
"diff": "+load(\"defs.bzl\", \"packetdrill_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+packetdrill_test(\n+ name = \"fin_wait2_timeout\",\n+ scripts = [\"fin_wait2_timeout.pkt\"],\n+)\n"
},
{
"change_type"... | Go | Apache License 2.0 | google/gvisor | Add packetdrill tests that use docker.
PiperOrigin-RevId: 292973224 |
260,003 | 03.02.2020 15:30:28 | 28,800 | e7846e50f2df070a15dd33235b334e2223f715f3 | Reduce run time for //test/syscalls:socket_inet_loopback_test_runsc_ptrace.
* Tests are picked for a shard differently. It now picks one test from each
block, instead of picking the whole block. This makes the same kind of tests
spreads across different shards.
* Reduce the number of connect() calls in TCPListenClose. | [
{
"change_type": "MODIFY",
"old_path": "runsc/testutil/testutil.go",
"new_path": "runsc/testutil/testutil.go",
"diff": "@@ -434,43 +434,40 @@ func IsStatic(filename string) (bool, error) {\nreturn true, nil\n}\n-// TestBoundsForShard calculates the beginning and end indices for the test\n-// based o... | Go | Apache License 2.0 | google/gvisor | Reduce run time for //test/syscalls:socket_inet_loopback_test_runsc_ptrace.
* Tests are picked for a shard differently. It now picks one test from each
block, instead of picking the whole block. This makes the same kind of tests
spreads across different shards.
* Reduce the number of connect() calls in TCPListenClose.
PiperOrigin-RevId: 293019281 |
259,847 | 03.02.2020 15:30:42 | 28,800 | 6cd7901d7d5f9639e95fff3d8927ba8856a83f91 | Add 1 Kokoro job per runtime test. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/runtime_tests/go1.12.cfg",
"diff": "+build_file: \"github/kokoro/runtime_tests/runtime_tests.sh\"\n+\n+env_vars {\n+ key: \"RUNTIME_TEST_NAME\"\n+ value: \"go1.12\"\n+}\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
... | Go | Apache License 2.0 | google/gvisor | Add 1 Kokoro job per runtime test.
PiperOrigin-RevId: 293019326 |
259,853 | 03.02.2020 16:15:16 | 28,800 | f37e913a358820ea98013772dd2880cc8a3c9218 | seccomp: allow to filter syscalls by instruction pointer | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp.go",
"new_path": "pkg/seccomp/seccomp.go",
"diff": "@@ -219,24 +219,36 @@ func addSyscallArgsCheck(p *bpf.ProgramBuilder, rules []Rule, action linux.BPFAc\nswitch a := arg.(type) {\ncase AllowAny:\ncase AllowValue:\n+ dataOffsetLow := secco... | Go | Apache License 2.0 | google/gvisor | seccomp: allow to filter syscalls by instruction pointer
PiperOrigin-RevId: 293029446 |
259,992 | 04.02.2020 08:20:10 | 28,800 | d7cd484091543827678f1548b8e5668a7a86e13f | Add support for sentry internal pipe for gofer mounts
Internal pipes are supported similarly to how internal UDS is done.
It is also controlled by the same flag.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/BUILD",
"new_path": "pkg/sentry/fs/gofer/BUILD",
"diff": "@@ -9,6 +9,7 @@ go_library(\n\"cache_policy.go\",\n\"context_file.go\",\n\"device.go\",\n+ \"fifo.go\",\n\"file.go\",\n\"file_state.go\",\n\"fs.go\",\n@@ -38,6 +39,7 @@ go_library(\n... | Go | Apache License 2.0 | google/gvisor | Add support for sentry internal pipe for gofer mounts
Internal pipes are supported similarly to how internal UDS is done.
It is also controlled by the same flag.
Fixes #1102
PiperOrigin-RevId: 293150045 |
259,992 | 04.02.2020 11:47:41 | 28,800 | dcffddf0cae026411e7e678744a1e39dc2b513cf | Remove argument from vfs.MountNamespace.DecRef()
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devtmpfs/devtmpfs.go",
"new_path": "pkg/sentry/fsimpl/devtmpfs/devtmpfs.go",
"diff": "@@ -86,7 +86,7 @@ func NewAccessor(ctx context.Context, vfsObj *vfs.VirtualFilesystem, creds *auth\n// Release must be called when a is no longer in use.\nf... | Go | Apache License 2.0 | google/gvisor | Remove argument from vfs.MountNamespace.DecRef()
Updates #1035
PiperOrigin-RevId: 293194631 |
259,858 | 04.02.2020 12:39:58 | 28,800 | f5072caaf85b9f067d737a874804c04e2b9039b8 | Fix safecopy test.
This is failing in Go1.14 due to new checkptr constraints. This version
should avoid hitting this constraints by doing "dangerous" pointer math
less dangerously? | [
{
"change_type": "MODIFY",
"old_path": "pkg/safecopy/safecopy_test.go",
"new_path": "pkg/safecopy/safecopy_test.go",
"diff": "@@ -138,10 +138,14 @@ func TestSwapUint32Success(t *testing.T) {\nfunc TestSwapUint32AlignmentError(t *testing.T) {\n// Test that SwapUint32 returns an AlignmentError when pa... | Go | Apache License 2.0 | google/gvisor | Fix safecopy test.
This is failing in Go1.14 due to new checkptr constraints. This version
should avoid hitting this constraints by doing "dangerous" pointer math
less dangerously?
PiperOrigin-RevId: 293205764 |
259,881 | 04.02.2020 13:05:30 | 28,800 | 6823b5e244a5748032130574ae3a25a0a36bbbf5 | timer_create(2) should return 0 on success
The timer ID is copied out to the argument.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_timer.go",
"new_path": "pkg/sentry/syscalls/linux/sys_timer.go",
"diff": "@@ -146,7 +146,7 @@ func TimerCreate(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.S\nreturn 0, nil, err\n}\n- return uintptr(id), nil, nil\... | Go | Apache License 2.0 | google/gvisor | timer_create(2) should return 0 on success
The timer ID is copied out to the argument.
Fixes #1738
PiperOrigin-RevId: 293210801 |
259,992 | 04.02.2020 13:15:05 | 28,800 | 6d8bf405bc5e887247534172713bf7d2f5252734 | Allow mlock in fsgofer system call filters
Go 1.14 has a workaround for a Linux 5.2-5.4 bug which requires mlock'ing the g
stack to prevent register corruption. We need to allow this syscall until it is
removed from Go. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/config.go",
"new_path": "runsc/fsgofer/filter/config.go",
"diff": "@@ -128,6 +128,18 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_MADVISE: {},\nunix.SYS_MEMFD_CREATE: {}, /// Used by flipcall.PacketWindowAllocator.Init().\ns... | Go | Apache License 2.0 | google/gvisor | Allow mlock in fsgofer system call filters
Go 1.14 has a workaround for a Linux 5.2-5.4 bug which requires mlock'ing the g
stack to prevent register corruption. We need to allow this syscall until it is
removed from Go.
PiperOrigin-RevId: 293212935 |
259,858 | 04.02.2020 14:36:43 | 28,800 | 95ce8bb4c7ecb23e47e68c60b1de0b99ad8a856d | Automatically propagate tags for stateify and marshal.
Note that files will need to be appropriately segmented in order for the
mechanism to work, in suffixes implying special tags. This only needs to happen
for cases where marshal or state structures are defined, which should be rare
and mostly architecture specific. | [
{
"change_type": "MODIFY",
"old_path": "tools/build/defs.bzl",
"new_path": "tools/build/defs.bzl",
"diff": "@@ -8,6 +8,7 @@ load(\"@rules_pkg//:pkg.bzl\", _pkg_deb = \"pkg_deb\", _pkg_tar = \"pkg_tar\")\nload(\"@io_bazel_rules_docker//go:image.bzl\", _go_image = \"go_image\")\nload(\"@io_bazel_rules... | Go | Apache License 2.0 | google/gvisor | Automatically propagate tags for stateify and marshal.
Note that files will need to be appropriately segmented in order for the
mechanism to work, in suffixes implying special tags. This only needs to happen
for cases where marshal or state structures are defined, which should be rare
and mostly architecture specific.
PiperOrigin-RevId: 293231579 |
259,854 | 04.02.2020 15:20:30 | 28,800 | a26a954946ad2e7910d3ad7578960a93b73a1f9b | Add socket connection stress test.
Tests 65k connection attempts on common types of sockets to check for port
leaks.
Also fixes a bug where dual-stack sockets wouldn't properly re-queue
segments received while closing. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -989,6 +989,10 @@ func (e *endpoint) transitionToStateCloseLocked() {\n// to any other listening endpoint. We reply with RST if we cannot find one.\nfunc (e *end... | Go | Apache License 2.0 | google/gvisor | Add socket connection stress test.
Tests 65k connection attempts on common types of sockets to check for port
leaks.
Also fixes a bug where dual-stack sockets wouldn't properly re-queue
segments received while closing.
PiperOrigin-RevId: 293241166 |
259,972 | 05.02.2020 11:17:14 | 28,800 | 37abbbc547d9d78e0bf42f192403c8eca30593d8 | Add packetdrill tests to presubmit and CI testing | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/packetdrill_tests.cfg",
"diff": "+build_file: \"repo/scripts/packetdrill_tests.sh\"\n+\n+action {\n+ define_artifacts {\n+ regex: \"**/sponge_log.xml\"\n+ regex: \"**/sponge_log.log\"\n+ regex: \"**/outputs.zip\"\n+ }\n+}\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Add packetdrill tests to presubmit and CI testing
PiperOrigin-RevId: 293409718 |
259,847 | 05.02.2020 11:33:48 | 28,800 | f2d3efca1deded31a2929ea77c0eecf476764660 | Fix undeclared variable error in common_build.sh. | [
{
"change_type": "MODIFY",
"old_path": "scripts/common_build.sh",
"new_path": "scripts/common_build.sh",
"diff": "@@ -32,21 +32,21 @@ declare -r BAZEL_FLAGS=(\n\"--keep_going\"\n\"--verbose_failures=true\"\n)\n+BAZEL_RBE_AUTH_FLAGS=\"\"\n+BAZEL_RBE_FLAGS=\"\"\nif [[ -v KOKORO_BAZEL_AUTH_CREDENTIAL ]... | Go | Apache License 2.0 | google/gvisor | Fix undeclared variable error in common_build.sh.
PiperOrigin-RevId: 293413711 |
259,972 | 05.02.2020 17:56:00 | 28,800 | f3d95607036b8a502c65aa7b3e8145227274dbbc | recv() on a closed TCP socket returns ENOTCONN
From RFC 793 s3.9 p58 Event Processing:
If RECEIVE Call arrives in CLOSED state and the user has access to such a
connection, the return should be "error: connection does not exist"
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -2229,11 +2229,16 @@ func (s *SocketOperations) coalescingRead(ctx context.Context, dst usermem.IOSeq\nvar copied int\n// Copy as many views as possible ... | Go | Apache License 2.0 | google/gvisor | recv() on a closed TCP socket returns ENOTCONN
From RFC 793 s3.9 p58 Event Processing:
If RECEIVE Call arrives in CLOSED state and the user has access to such a
connection, the return should be "error: connection does not exist"
Fixes #1598
PiperOrigin-RevId: 293494287 |
259,853 | 06.02.2020 10:06:56 | 28,800 | 5ff780891e229dbde00d9a37c2f8b6681e592fdb | Move p9.pool to a separate package | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/BUILD",
"new_path": "pkg/p9/BUILD",
"diff": "@@ -16,7 +16,6 @@ go_library(\n\"messages.go\",\n\"p9.go\",\n\"path_tree.go\",\n- \"pool.go\",\n\"server.go\",\n\"transport.go\",\n\"transport_flipcall.go\",\n@@ -27,6 +26,7 @@ go_library(\n\"//pkg/fdchannel\... | Go | Apache License 2.0 | google/gvisor | Move p9.pool to a separate package
PiperOrigin-RevId: 293617493 |
259,858 | 06.02.2020 10:11:15 | 28,800 | 0e96fcafd4404e1418c84b7830b9455867e174bb | Fix test case on AMD.
When ignored, the trap should be executed which generates
a SIGSEGV as in the above case. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/32bit.cc",
"new_path": "test/syscalls/linux/32bit.cc",
"diff": "@@ -155,7 +155,7 @@ TEST(Syscall32Bit, Syscall) {\ncase PlatformSupport::Ignored:\n// See above.\nEXPECT_EXIT(ExitGroup32(kSyscall, kExitCode),\n- ::testing::KilledBySignal(SIG... | Go | Apache License 2.0 | google/gvisor | Fix test case on AMD.
When ignored, the trap should be executed which generates
a SIGSEGV as in the above case.
PiperOrigin-RevId: 293618489 |
260,004 | 06.02.2020 11:12:41 | 28,800 | 6bd59b4e08893281468e8af5aebb5fab0f7a8c0d | Update link address for targets of Neighbor Adverts
Get the link address for the target of an NDP Neighbor Advertisement
from the NDP Target Link Layer Address option.
Tests:
ipv6.TestNeighorAdvertisementWithTargetLinkLayerOption
ipv6.TestNeighorAdvertisementWithInvalidTargetLinkLayerOption | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "package ipv6\nimport (\n+ \"log\"\n+\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/tcpip/buffer\"\n\"gvisor.dev/gvisor/pkg/tcpip/header\"\n@@ -194,7 +196,11 @@ ... | Go | Apache License 2.0 | google/gvisor | Update link address for targets of Neighbor Adverts
Get the link address for the target of an NDP Neighbor Advertisement
from the NDP Target Link Layer Address option.
Tests:
- ipv6.TestNeighorAdvertisementWithTargetLinkLayerOption
- ipv6.TestNeighorAdvertisementWithInvalidTargetLinkLayerOption
PiperOrigin-RevId: 293632609 |
259,853 | 06.02.2020 14:01:45 | 28,800 | 615d66111214f5ae9b41fb2a89bb3549c03fc7af | runsc/container_test: hide host /etc in test containers
The host /etc can contain config files which affect tests.
For example, bash reads /etc/passwd and if it is too big
a test can fail by timeout. | [
{
"change_type": "MODIFY",
"old_path": "runsc/testutil/testutil.go",
"new_path": "runsc/testutil/testutil.go",
"diff": "@@ -119,6 +119,13 @@ func NewSpecWithArgs(args ...string) *specs.Spec {\nCapabilities: specutils.AllCapabilities(),\n},\nMounts: []specs.Mount{\n+ // Hide the host /etc to avoid an... | Go | Apache License 2.0 | google/gvisor | runsc/container_test: hide host /etc in test containers
The host /etc can contain config files which affect tests.
For example, bash reads /etc/passwd and if it is too big
a test can fail by timeout.
PiperOrigin-RevId: 293670637 |
259,891 | 06.02.2020 14:26:41 | 28,800 | bfa4a235f401599492a2cf39471df62715f9f1cf | Fix `bazel run` target in docs. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/README.md",
"new_path": "test/iptables/README.md",
"diff": "@@ -28,7 +28,7 @@ Your test is now runnable with bazel!\nBuild the testing Docker container:\n```bash\n-$ bazel run //test/iptables/runner-image -- --norun\n+$ bazel run //test/iptables/... | Go | Apache License 2.0 | google/gvisor | Fix `bazel run` target in docs.
PiperOrigin-RevId: 293676954 |
260,004 | 06.02.2020 15:57:34 | 28,800 | 940d255971c38af9f91ceed1345fd973f8fdb41d | Perform DAD on IPv6 addresses when enabling a NIC
Addresses may be added before a NIC is enabled. Make sure DAD is
performed on the permanent IPv6 addresses when they get enabled.
Test:
stack_test.TestDoDADWhenNICEnabled
stack.TestDisabledRxStatsWhenNICDisabled | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -78,11 +78,15 @@ go_test(\ngo_test(\nname = \"stack_test\",\nsize = \"small\",\n- srcs = [\"linkaddrcache_test.go\"],\n+ srcs = [\n+ \"linkaddrcache_test.go\",\n+ \"nic_test.go\",\n+ ],\n... | Go | Apache License 2.0 | google/gvisor | Perform DAD on IPv6 addresses when enabling a NIC
Addresses may be added before a NIC is enabled. Make sure DAD is
performed on the permanent IPv6 addresses when they get enabled.
Test:
- stack_test.TestDoDADWhenNICEnabled
- stack.TestDisabledRxStatsWhenNICDisabled
PiperOrigin-RevId: 293697429 |
259,854 | 07.02.2020 14:00:50 | 28,800 | e1587a28876f8aac689a2cd1b7630f1637655b58 | Log level, optname, optval and optlen in getsockopt/setsockopt in strace.
Log 8, 16, and 32 int optvals and dump the memory of other sizes.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64_amd64.go",
"new_path": "pkg/sentry/strace/linux64_amd64.go",
"diff": "@@ -78,8 +78,8 @@ var linuxAMD64 = SyscallMap{\n51: makeSyscallInfo(\"getsockname\", FD, PostSockAddr, SockLen),\n52: makeSyscallInfo(\"getpeername\", FD, PostSockA... | Go | Apache License 2.0 | google/gvisor | Log level, optname, optval and optlen in getsockopt/setsockopt in strace.
Log 8, 16, and 32 int optvals and dump the memory of other sizes.
Updates #1782
PiperOrigin-RevId: 293889388 |
259,891 | 10.02.2020 11:08:24 | 28,800 | 31f2182cd3fc2a6fdb1aecf1c56f1302f16f6453 | iptables: add instructions for runsc building.
The readme didn't mention that users need to:
`bazel build` when working on iptables tests
enable raw sockets in /etc/docker/daemon.json. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/README.md",
"new_path": "test/iptables/README.md",
"diff": "iptables tests are run via `scripts/iptables_test.sh`.\n+iptables requires raw socket support, so you must add the `--net-raw=true` flag\n+to `/etc/docker/daemon.json` in order to use it... | Go | Apache License 2.0 | google/gvisor | iptables: add instructions for runsc building.
The readme didn't mention that users need to:
- `bazel build` when working on iptables tests
- enable raw sockets in /etc/docker/daemon.json.
PiperOrigin-RevId: 294260169 |
259,847 | 10.02.2020 11:57:31 | 28,800 | 20840bfec087d45853e81d1ac34940f3b2fb920a | Move x86 state definition to its own file. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/BUILD",
"new_path": "pkg/sentry/arch/BUILD",
"diff": "@@ -14,6 +14,7 @@ go_library(\n\"arch_state_aarch64.go\",\n\"arch_state_x86.go\",\n\"arch_x86.go\",\n+ \"arch_x86_impl.go\",\n\"auxv.go\",\n\"signal.go\",\n\"signal_act.go\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Move x86 state definition to its own file.
PiperOrigin-RevId: 294271541 |
259,992 | 10.02.2020 12:02:47 | 28,800 | bfa0bba72abb69cbc7f4da27d3b4b116c3784495 | Redirect FIXME to gvisor.dev | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -111,10 +111,10 @@ func (fs *Filesystem) revalidateChildLocked(ctx context.Context, vfsObj *vfs.Vir\n// Dentry isn't cached; it either doesn't exist or f... | Go | Apache License 2.0 | google/gvisor | Redirect FIXME to gvisor.dev
PiperOrigin-RevId: 294272755 |
259,858 | 10.02.2020 12:06:06 | 28,800 | c9a18b16ade6ec0bc90fc75d0a4ab0621f9d01d6 | Document MinimumTotalMemoryBytes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/usage/memory.go",
"new_path": "pkg/sentry/usage/memory.go",
"diff": "@@ -253,6 +253,10 @@ func (m *MemoryLocked) Copy() (MemoryStats, uint64) {\n}\n// MinimumTotalMemoryBytes is the minimum reported total system memory.\n+//\n+// This can be configu... | Go | Apache License 2.0 | google/gvisor | Document MinimumTotalMemoryBytes.
PiperOrigin-RevId: 294273559 |
259,858 | 10.02.2020 13:04:29 | 28,800 | 4d4d47f0c0a21d3404d2edae527b187d62daa3c8 | Add contextual note. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/directory.go",
"new_path": "pkg/sentry/fsimpl/gofer/directory.go",
"diff": "@@ -87,6 +87,10 @@ func (d *dentry) getDirents(ctx context.Context) ([]vfs.Dirent, error) {\n// to assume that directory fids have the correct semantics, and tr... | Go | Apache License 2.0 | google/gvisor | Add contextual note.
PiperOrigin-RevId: 294285723 |
259,847 | 10.02.2020 13:06:57 | 28,800 | bc504d52026790b7deed6506371ebc6d5d17c948 | Fix build_file in runtimes_tests. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/runtime_tests/go1.12.cfg",
"new_path": "kokoro/runtime_tests/go1.12.cfg",
"diff": "-build_file: \"github/kokoro/runtime_tests/runtime_tests.sh\"\n+build_file: \"github/github/kokoro/runtime_tests/runtime_tests.sh\"\nenv_vars {\nkey: \"RUNTIME_TEST_NAME\... | Go | Apache License 2.0 | google/gvisor | Fix build_file in runtimes_tests.
PiperOrigin-RevId: 294286242 |
259,858 | 10.02.2020 13:20:44 | 28,800 | bb22ebd7fbfc66556b38df669be5c6372daba018 | Add contextual comment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/benchmark/benchmark_test.go",
"new_path": "pkg/sentry/fsimpl/ext/benchmark/benchmark_test.go",
"diff": "// These benchmarks emulate memfs benchmarks. Ext4 images must be created\n// before this benchmark is run using the `make_deep_ext4.s... | Go | Apache License 2.0 | google/gvisor | Add contextual comment.
PiperOrigin-RevId: 294289066 |
259,858 | 10.02.2020 13:51:26 | 28,800 | a6f9361c2f7c5b46a200de1dc891a0ce059ad90e | Add context to comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/attr.go",
"new_path": "pkg/sentry/fs/gofer/attr.go",
"diff": "@@ -88,8 +88,9 @@ func bsize(pattr p9.Attr) int64 {\nif pattr.BlockSize > 0 {\nreturn int64(pattr.BlockSize)\n}\n- // Some files may have no clue of their block size. Better not ... | Go | Apache License 2.0 | google/gvisor | Add context to comments.
PiperOrigin-RevId: 294295852 |
259,858 | 10.02.2020 14:11:04 | 28,800 | afcab8fe9f6fb3504ebdbb95d35299277c2d67ca | Clean-up comments in runsc/BUILD and CONTRIBUTING.md. | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -47,7 +47,7 @@ Definitions for the rules below:\n`core`:\n* `//pkg/sentry/...`\n-* Transitive dependencies in `//pkg/...`, `//third_party/...`.\n+* Transitive dependencies in `//pkg/...`, etc.\n`runs... | Go | Apache License 2.0 | google/gvisor | Clean-up comments in runsc/BUILD and CONTRIBUTING.md.
PiperOrigin-RevId: 294300437 |
259,860 | 10.02.2020 14:47:00 | 28,800 | 475316e87dac806d69bcb06ea4065f3c138bb47e | Refactor getxattr.
Put most of the logic for getxattr in one place for clarity. This simplifies
FGetXattr and getXattrFromPath, which are just wrappers for getXattr. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_xattr.go",
"new_path": "pkg/sentry/syscalls/linux/sys_xattr.go",
"diff": "@@ -49,14 +49,11 @@ func FGetXattr(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sys\n}\ndefer f.DecRef()\n- n, value, err := getXattr(t, f.... | Go | Apache License 2.0 | google/gvisor | Refactor getxattr.
Put most of the logic for getxattr in one place for clarity. This simplifies
FGetXattr and getXattrFromPath, which are just wrappers for getXattr.
PiperOrigin-RevId: 294308332 |
259,858 | 10.02.2020 15:43:36 | 28,800 | dc5a8e52d7004e3796feaadb0a0b0960f7289884 | Rename build to builddefs and minor build clean-up.
The name 'bazel' also doesn't work because bazel will treat it specially.
Fixes | [
{
"change_type": "RENAME",
"old_path": "tools/build/BUILD",
"new_path": "tools/bazeldefs/BUILD",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "tools/build/defs.bzl",
"new_path": "tools/bazeldefs/defs.bzl",
"diff": "@@ -8,7 +8,7 @@ load(\"@rules_pkg//:pkg.bzl\", _pkg_deb =... | Go | Apache License 2.0 | google/gvisor | Rename build to builddefs and minor build clean-up.
The name 'bazel' also doesn't work because bazel will treat it specially.
Fixes #1807
PiperOrigin-RevId: 294321221 |
259,858 | 10.02.2020 17:12:03 | 28,800 | 71af006b6fe4504fccb86f0222a8a1864d33fb7d | Cleanup internal package group. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/BUILD",
"new_path": "pkg/sentry/BUILD",
"diff": "-# This BUILD file defines a package_group that allows for interdependencies for\n-# sentry-internal packages.\n-\npackage(licenses = [\"notice\"])\n+# The \"internal\" package_group should be used as... | Go | Apache License 2.0 | google/gvisor | Cleanup internal package group.
PiperOrigin-RevId: 294339229 |
259,858 | 11.02.2020 11:37:12 | 28,800 | 115898e368e4afe5418a7290d9545fafc7f6f25e | Prevent DATA RACE in UnstableAttr.
The slaveInodeOperations is currently copying the object when
truncate is called (which is a no-op). This may result in a
(unconsequential) data race when being modified concurrently. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tty/slave.go",
"new_path": "pkg/sentry/fs/tty/slave.go",
"diff": "@@ -73,7 +73,7 @@ func (si *slaveInodeOperations) Release(ctx context.Context) {\n}\n// Truncate implements fs.InodeOperations.Truncate.\n-func (slaveInodeOperations) Truncate(cont... | Go | Apache License 2.0 | google/gvisor | Prevent DATA RACE in UnstableAttr.
The slaveInodeOperations is currently copying the object when
truncate is called (which is a no-op). This may result in a
(unconsequential) data race when being modified concurrently.
PiperOrigin-RevId: 294484276 |
259,891 | 07.02.2020 11:21:07 | 28,800 | 6fdf2c53a1d084b70602170b660242036fd8fe4f | iptables: User chains
Adds creation of user chains via `-N <chainname>`
Adds `-j RETURN` support for built-in chains, which triggers the
chain's underflow rule (usually the default policy).
Adds tests for chain creation, default policies, and `-j RETURN' from
built-in chains. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -50,7 +50,9 @@ type metadata struct {\n// nflog logs messages related to the writing and reading of iptables.\nfunc nflog(format string, args ...inte... | Go | Apache License 2.0 | google/gvisor | iptables: User chains
- Adds creation of user chains via `-N <chainname>`
- Adds `-j RETURN` support for built-in chains, which triggers the
chain's underflow rule (usually the default policy).
- Adds tests for chain creation, default policies, and `-j RETURN' from
built-in chains. |
259,974 | 11.02.2020 00:52:23 | 0 | d30a884775556474f1a893fd30460a6edf0a3039 | Add definition of arch.ARMTrapFlag.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/arch_aarch64.go",
"new_path": "pkg/sentry/arch/arch_aarch64.go",
"diff": "@@ -34,6 +34,9 @@ const (\nSyscallWidth = 4\n)\n+// ARMTrapFlag is the mask for the trap flag.\n+const ARMTrapFlag = uint64(1) << 21\n+\n// aarch64FPState is aarch64 floa... | Go | Apache License 2.0 | google/gvisor | Add definition of arch.ARMTrapFlag.
Fixes #1708
Signed-off-by: Haibo Xu haibo.xu@arm.com
Change-Id: Ib15768692ead17c81c06f7666ca3f0a14064c3a0 |
259,891 | 12.02.2020 16:19:06 | 28,800 | 6ef63cd7da107d487fda7c48af50fa9802913cd9 | We can now create and jump in iptables. For example:
$ iptables -N foochain
$ iptables -A INPUT -j foochain | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -225,11 +225,14 @@ type XTEntryTarget struct {\n// SizeOfXTEntryTarget is the size of an XTEntryTarget.\nconst SizeOfXTEntryTarget = 32\n-// XTStandardTarget is a builtin target... | Go | Apache License 2.0 | google/gvisor | We can now create and jump in iptables. For example:
$ iptables -N foochain
$ iptables -A INPUT -j foochain |
259,955 | 18.02.2020 16:03:32 | -28,800 | 03cee0656c9fd8cf9509c3a91baf72db4a8f6d28 | scope.add should only record the first position | [
{
"change_type": "MODIFY",
"old_path": "tools/go_generics/globals/scope.go",
"new_path": "tools/go_generics/globals/scope.go",
"diff": "@@ -72,6 +72,10 @@ func (s *scope) deepLookup(n string) *symbol {\n}\nfunc (s *scope) add(name string, kind SymKind, pos token.Pos) {\n+ if s.syms[name] != nil {\n+... | Go | Apache License 2.0 | google/gvisor | scope.add should only record the first position |
259,896 | 18.02.2020 11:30:42 | 28,800 | b30b7f3422202232ad1c385a7ac0d775151fee2f | Add nat table support for iptables.
Add nat table support for Prerouting hook with Redirect option.
Add tests to check redirect of ports. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -250,6 +250,33 @@ type XTErrorTarget struct {\n// SizeOfXTErrorTarget is the size of an XTErrorTarget.\nconst SizeOfXTErrorTarget = 64\n+// NfNATIPV4Range. It corresponds to str... | Go | Apache License 2.0 | google/gvisor | Add nat table support for iptables.
Add nat table support for Prerouting hook with Redirect option.
Add tests to check redirect of ports. |
259,891 | 18.02.2020 21:20:41 | 28,800 | 92d2d78876a938871327685e1104d7b4ff46986e | Fix mis-named comment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/registration.go",
"new_path": "pkg/tcpip/stack/registration.go",
"diff": "@@ -277,7 +277,7 @@ type NetworkProtocol interface {\n// DefaultPrefixLen returns the protocol's default prefix length.\nDefaultPrefixLen() int\n- // ParsePorts returns t... | Go | Apache License 2.0 | google/gvisor | Fix mis-named comment. |
259,858 | 19.02.2020 18:27:48 | 28,800 | ec5630527bc4473081048d2d13d1dcfadc6c7cdd | Add statefile command to runsc. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/BUILD",
"new_path": "runsc/cmd/BUILD",
"diff": "@@ -31,6 +31,7 @@ go_library(\n\"spec.go\",\n\"start.go\",\n\"state.go\",\n+ \"statefile.go\",\n\"syscalls.go\",\n\"wait.go\",\n],\n@@ -43,6 +44,8 @@ go_library(\n\"//pkg/sentry/control\",\n\"//pkg/sent... | Go | Apache License 2.0 | google/gvisor | Add statefile command to runsc.
PiperOrigin-RevId: 296105337 |
259,858 | 20.02.2020 12:32:31 | 28,800 | 72187fa7a9e1f3ee9d021681f4465777f91c13fe | Import tags.bzl directly from tools/defs.bzl.
This simplifies the script slightly. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazeldefs/defs.bzl",
"new_path": "tools/bazeldefs/defs.bzl",
"diff": "@@ -8,7 +8,6 @@ load(\"@rules_pkg//:pkg.bzl\", _pkg_deb = \"pkg_deb\", _pkg_tar = \"pkg_tar\")\nload(\"@io_bazel_rules_docker//go:image.bzl\", _go_image = \"go_image\")\nload(\"@io_baz... | Go | Apache License 2.0 | google/gvisor | Import tags.bzl directly from tools/defs.bzl.
This simplifies the script slightly.
PiperOrigin-RevId: 296272077 |
259,974 | 19.02.2020 08:09:16 | 0 | 5d711c329a7973dae37b654528949d62a131319a | Force downloading new version of org_golang_x_sys.
ARM64 PTRACE_SYSEMU support was added to Linux kernal from
v5.3 and the corresponding support in golang is also enabled
in the latest org.golang/x/sys repository.
Updates | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -33,6 +33,20 @@ load(\"@bazel_gazelle//:deps.bzl\", \"gazelle_dependencies\", \"go_repository\")\ngazelle_dependencies()\n+# TODO(gvisor.dev/issue/1876): Move the statement to \"External repositories\"\n+# block... | Go | Apache License 2.0 | google/gvisor | Force downloading new version of org_golang_x_sys.
ARM64 PTRACE_SYSEMU support was added to Linux kernal from
v5.3 and the corresponding support in golang is also enabled
in the latest org.golang/x/sys repository.
Updates #1876
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I10750c4c8b68f6f68d0a4d828e266966434c92fe |
260,004 | 21.02.2020 09:53:56 | 28,800 | 97c07242c37e56f6cfdc52036d554052ba95f2ae | Use Route.MaxHeaderLength when constructing NDP RS
Test: stack_test.TestRouterSolicitation | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/ndp.go",
"new_path": "pkg/tcpip/stack/ndp.go",
"diff": "@@ -1235,7 +1235,7 @@ func (ndp *ndpState) startSolicitingRouters() {\n}\npayloadSize := header.ICMPv6HeaderSize + header.NDPRSMinimumSize\n- hdr := buffer.NewPrependable(header.IPv6Minimu... | Go | Apache License 2.0 | google/gvisor | Use Route.MaxHeaderLength when constructing NDP RS
Test: stack_test.TestRouterSolicitation
PiperOrigin-RevId: 296454766 |
260,004 | 21.02.2020 11:20:15 | 28,800 | a155a23480abfafe096ff50f2c4aaf2c215b6c44 | Attach LinkEndpoint to NetworkDispatcher immediately
Tests: stack_test.TestAttachToLinkEndpointImmediately | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -45,7 +45,6 @@ type NIC struct {\ncontext NICContext\nstats NICStats\n- attach sync.Once\nmu struct {\nsync.RWMutex\n@@ -141,6 +140,8 @@ func newNIC(stack *Stack, id tcpip.NICID, name s... | Go | Apache License 2.0 | google/gvisor | Attach LinkEndpoint to NetworkDispatcher immediately
Tests: stack_test.TestAttachToLinkEndpointImmediately
PiperOrigin-RevId: 296474068 |
259,975 | 21.02.2020 13:17:44 | 28,800 | 3733499952c056cc8496beb01c72dcf53177048e | Fix master installer.
Sometimes, when we start a new instance, the file
lock on "apt" is locked. Add a loop to the master
installer.
In addition, the "apt-get install" fails to register
runsc in docker, so run the appropriate scripts to
get that to happen.
Also, add some helpful log messages. | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/harness/machine.py",
"new_path": "benchmarks/harness/machine.py",
"diff": "@@ -43,6 +43,8 @@ from benchmarks.harness import machine_mocks\nfrom benchmarks.harness import ssh_connection\nfrom benchmarks.harness import tunnel_dispatcher\n+log = loggin... | Go | Apache License 2.0 | google/gvisor | Fix master installer.
Sometimes, when we start a new instance, the file
lock on "apt" is locked. Add a loop to the master
installer.
In addition, the "apt-get install" fails to register
runsc in docker, so run the appropriate scripts to
get that to happen.
Also, add some helpful log messages.
PiperOrigin-RevId: 296497357 |
259,858 | 21.02.2020 15:05:20 | 28,800 | 10aa4d3b343255db45f5ca4ff7b51f21a309e10b | Factor platform tags. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "\"\"\"Defines a rule for syscall test targets.\"\"\"\n-load(\"//tools:defs.bzl\", \"loopback\")\n+load(\"//tools:defs.bzl\", \"default_platform\", \"loopback\", \"platforms\")\ndef _runner_tes... | Go | Apache License 2.0 | google/gvisor | Factor platform tags.
PiperOrigin-RevId: 296519566 |
259,858 | 24.02.2020 17:28:27 | 28,800 | 160d5751ab6a06c22aed7d829a17c88344cc7cf2 | Add default behavior for gtest runner. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -29,7 +29,7 @@ syscall_test(\n)\nsyscall_test(\n- size = \"large\",\n+ size = \"enormous\",\ntest = \"//test/perf/linux:getdents_benchmark\",\n)\n@@ -39,7 +39,7 @@ syscall_test(\n)\nsyscall_test(\n- ... | Go | Apache License 2.0 | google/gvisor | Add default behavior for gtest runner.
PiperOrigin-RevId: 297009116 |
259,974 | 21.02.2020 10:28:16 | 0 | 93e0c3752981b6a1c5b745faec6506c17480b84b | Enable bluepill dieTrampoline operation on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_arm64_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_arm64_unsafe.go",
"diff": "@@ -18,9 +18,30 @@ package kvm\nimport (\n\"gvisor.dev/gvisor/pkg/sentry/arch\"\n+ \"gvisor.dev/gvisor/pkg/sentry/platform/ring0\"\n)\n+... | Go | Apache License 2.0 | google/gvisor | Enable bluepill dieTrampoline operation on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I9e1bf2513c23bdd8c387e5b3c874c6ad3ca9aab0 |
259,992 | 25.02.2020 11:13:29 | 28,800 | 4d7db46123f020df77cea5c00df4114b7b073845 | Add log during process wait in tests
TestMultiContainerKillAll timed out under --race. Without logging,
we cannot tell if the process list is still increasing, but slowly,
or is stuck. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -71,6 +71,7 @@ func waitForProcessCount(cont *Container, want int) error {\nreturn &backoff.PermanentError{Err: err}\n}\nif got := len(pss); got != want {\n+ log.I... | Go | Apache License 2.0 | google/gvisor | Add log during process wait in tests
TestMultiContainerKillAll timed out under --race. Without logging,
we cannot tell if the process list is still increasing, but slowly,
or is stuck.
PiperOrigin-RevId: 297158834 |
259,858 | 25.02.2020 12:21:27 | 28,800 | 98b693e61b37a62f7b29ce1cab8b4c4c54fa044e | Don't acquire contended lock with the OS thread locked.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -329,10 +329,12 @@ func (m *machine) Destroy() {\n}\n// Get gets an available vCPU.\n+//\n+// This will return with the OS thread locked.\nfunc (m *machine) Get(... | Go | Apache License 2.0 | google/gvisor | Don't acquire contended lock with the OS thread locked.
Fixes #1049
PiperOrigin-RevId: 297175164 |
259,858 | 25.02.2020 12:22:09 | 28,800 | 6def8ea6ac601daa9256a31f818db9f7eb532168 | Fix nested logging. | [
{
"change_type": "MODIFY",
"old_path": "pkg/log/glog.go",
"new_path": "pkg/log/glog.go",
"diff": "@@ -46,7 +46,7 @@ var pid = os.Getpid()\n// line The line number\n// msg The user-supplied message\n//\n-func (g *GoogleEmitter) Emit(level Level, timestamp time.Time, format string, args ...interface{}... | Go | Apache License 2.0 | google/gvisor | Fix nested logging.
PiperOrigin-RevId: 297175316 |
259,992 | 25.02.2020 13:42:34 | 28,800 | 72e3f3a3eef3a1dc02db0ff71f98a5d7fe89a6e3 | Add option to skip stuck tasks waiting for address space | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -247,6 +247,10 @@ type Kernel struct {\n// VFS keeps the filesystem state used across the kernel.\nvfs vfs.VirtualFilesystem\n+\n+ // If set to true, report address space acti... | Go | Apache License 2.0 | google/gvisor | Add option to skip stuck tasks waiting for address space
PiperOrigin-RevId: 297192390 |
259,896 | 25.02.2020 15:03:51 | 28,800 | acc405ba60834f5dce9ce04cd762d5cda02224cb | Add nat table support for iptables.
commit the changes for the comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -250,8 +250,24 @@ type XTErrorTarget struct {\n// SizeOfXTErrorTarget is the size of an XTErrorTarget.\nconst SizeOfXTErrorTarget = 64\n+// Flag values for NfNATIPV4Range. The v... | Go | Apache License 2.0 | google/gvisor | Add nat table support for iptables.
- commit the changes for the comments. |
260,004 | 25.02.2020 15:15:28 | 28,800 | 5f1f9dd9d23d2b805c77b5c38d5900d13e6a29fe | Use link-local source address for link-local multicast
Tests:
header_test.TestIsV6LinkLocalMulticastAddress
header_test.TestScopeForIPv6Address
stack_test.TestIPv6SourceAddressSelectionScopeAndSameAddress | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6.go",
"new_path": "pkg/tcpip/header/ipv6.go",
"diff": "@@ -115,6 +115,19 @@ const (\n// for the secret key used to generate an opaque interface identifier as\n// outlined by RFC 7217.\nOpaqueIIDSecretKeyMinBytes = 16\n+\n+ // ipv6Multicast... | Go | Apache License 2.0 | google/gvisor | Use link-local source address for link-local multicast
Tests:
- header_test.TestIsV6LinkLocalMulticastAddress
- header_test.TestScopeForIPv6Address
- stack_test.TestIPv6SourceAddressSelectionScopeAndSameAddress
PiperOrigin-RevId: 297215576 |
259,854 | 25.02.2020 15:34:20 | 28,800 | 87288b26a1c40776da31c1edcbe9b1f3a6f5c1ed | Add netlink sockopt logging to strace. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/socket.go",
"new_path": "pkg/sentry/strace/socket.go",
"diff": "@@ -632,4 +632,13 @@ var sockOptNames = map[uint64]abi.ValueSet{\nlinux.MCAST_MSFILTER: \"MCAST_MSFILTER\",\nlinux.IPV6_ADDRFORM: \"IPV6_ADDRFORM\",\n},\n+ linux.SOL_NETLINK: {\n... | Go | Apache License 2.0 | google/gvisor | Add netlink sockopt logging to strace.
PiperOrigin-RevId: 297220008 |
259,845 | 25.02.2020 16:03:22 | -32,400 | 6eb4ea30088a19428d6dfde965985e844b7a9a2a | user_guide: modify debug option | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/debugging.md",
"new_path": "content/docs/user_guide/debugging.md",
"diff": "@@ -107,7 +107,7 @@ execute `runsc debug` to collect profile information and save to a file. Here ar\nthe options available:\n* **--profile-heap:** Generates he... | Go | Apache License 2.0 | google/gvisor | user_guide: modify debug option |
259,974 | 25.02.2020 07:30:12 | 0 | 73201f4c5700ce7af404b968698b86d80989ab1e | Code Clean: Move arch independent codes to common file in kvm pkg. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm.go",
"new_path": "pkg/sentry/platform/kvm/kvm.go",
"diff": "@@ -27,6 +27,38 @@ import (\n\"gvisor.dev/gvisor/pkg/usermem\"\n)\n+// userMemoryRegion is a region of physical memory.\n+//\n+// This mirrors kvm_memory_region.\n+type use... | Go | Apache License 2.0 | google/gvisor | Code Clean: Move arch independent codes to common file in kvm pkg.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: Iefbdf53e8e8d6d23ae75d8a2ff0d2a6e71f414d8 |
259,858 | 25.02.2020 19:03:23 | 28,800 | fba479b3c78621cb122af20d1d677fe9193a971c | Fix DATA RACE in fs.MayDelete.
MayDelete must lock the directory also, otherwise concurrent renames may
race. Note that this also changes the methods to be aligned with the actual
Remove and RemoveDirectory methods to minimize confusion when reading the
code. (It was hard to see that resolution was correct.) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -1438,8 +1438,8 @@ func lockForRename(oldParent *Dirent, oldName string, newParent *Dirent, newName\n}, nil\n}\n-func checkSticky(ctx context.Context, dir *Dirent, victim *Dirent) err... | Go | Apache License 2.0 | google/gvisor | Fix DATA RACE in fs.MayDelete.
MayDelete must lock the directory also, otherwise concurrent renames may
race. Note that this also changes the methods to be aligned with the actual
Remove and RemoveDirectory methods to minimize confusion when reading the
code. (It was hard to see that resolution was correct.)
PiperOrigin-RevId: 297258304 |
259,885 | 25.02.2020 19:12:22 | 28,800 | a92087f0f8fe82ce99414ec99ffe33e514cb21f6 | Add VFS.NewDisconnectedMount().
Analogous to Linux's kern_mount(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -139,6 +139,23 @@ func (vfs *VirtualFilesystem) NewMountNamespace(ctx context.Context, creds *auth\nreturn mntns, nil\n}\n+// NewDisconnectedMount returns a Mount representing fs with... | Go | Apache License 2.0 | google/gvisor | Add VFS.NewDisconnectedMount().
Analogous to Linux's kern_mount().
PiperOrigin-RevId: 297259580 |
259,891 | 14.02.2020 17:19:32 | 28,800 | 408979e619c4b5df74503c7a887aaaa06fd0d730 | iptables: filter by IP address (and range)
Enables commands such as:
$ iptables -A INPUT -d 127.0.0.1 -j ACCEPT
$ iptables -t nat -A PREROUTING ! -d 127.0.0.1 -j REDIRECT
Also adds a bunch of REDIRECT+destination tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -158,10 +158,36 @@ type IPTIP struct {\n// Flags define matching behavior for the IP header.\nFlags uint8\n- // InverseFlags invert the meaning of fields in struct IPTIP.\n+ // ... | Go | Apache License 2.0 | google/gvisor | iptables: filter by IP address (and range)
Enables commands such as:
$ iptables -A INPUT -d 127.0.0.1 -j ACCEPT
$ iptables -t nat -A PREROUTING ! -d 127.0.0.1 -j REDIRECT
Also adds a bunch of REDIRECT+destination tests. |
259,985 | 26.02.2020 19:28:20 | 28,800 | 8fb84f78adfc0dba964ebe97edb51ebf8a80f752 | Fix construct of linux.Stat for arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/BUILD",
"new_path": "pkg/sentry/syscalls/linux/BUILD",
"diff": "@@ -42,6 +42,8 @@ go_library(\n\"sys_socket.go\",\n\"sys_splice.go\",\n\"sys_stat.go\",\n+ \"sys_stat_amd64.go\",\n+ \"sys_stat_arm64.go\",\n\"sys_sync.go\",\n\"sys_sysin... | Go | Apache License 2.0 | google/gvisor | Fix construct of linux.Stat for arm64.
PiperOrigin-RevId: 297494373 |
259,858 | 27.02.2020 10:21:33 | 28,800 | 8e2b14fecf204b35fe258816792bdc03a1ca0912 | Use automated release notes, if available. | [
{
"change_type": "MODIFY",
"old_path": "scripts/release.sh",
"new_path": "scripts/release.sh",
"diff": "@@ -25,6 +25,14 @@ if ! [[ -v KOKORO_RELEASE_TAG ]]; then\necho \"No KOKORO_RELEASE_TAG provided.\" >&2\nexit 1\nfi\n+if ! [[ -v KOKORO_RELNOTES ]]; then\n+ echo \"No KOKORO_RELNOTES provided.\" >... | Go | Apache License 2.0 | google/gvisor | Use automated release notes, if available.
PiperOrigin-RevId: 297628615 |
259,992 | 27.02.2020 14:58:16 | 28,800 | 88f73699225bd50102bbacb6f78052338f205cdd | Log oom_score_adj value on error
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -17,6 +17,7 @@ package container\nimport (\n\"context\"\n+ \"errors\"\n\"fmt\"\n\"io/ioutil\"\n\"os\"\n@@ -1066,19 +1067,11 @@ func runInCgroup(cg *cgroup.Cgroup, fn func() ... | Go | Apache License 2.0 | google/gvisor | Log oom_score_adj value on error
Updates #1873
PiperOrigin-RevId: 297695241 |
259,896 | 28.02.2020 10:00:38 | 28,800 | af6fab651406c411ef848c360b017713de385880 | Add nat table support for iptables.
Fix review comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -670,15 +670,21 @@ func parseTarget(filter iptables.IPHeaderFilter, optVal []byte) (iptables.Target\n// TODO(gvisor.dev/issue/170): Check if the flag... | Go | Apache License 2.0 | google/gvisor | Add nat table support for iptables.
- Fix review comments. |
259,992 | 28.02.2020 10:13:59 | 28,800 | 0f8a9e362337ee684042331c5bf24a3cb43d6fc4 | Change dup2 call to dup3
We changed syscalls to allow dup3 for ARM64.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -1045,13 +1045,13 @@ func (d *dentry) ensureSharedHandle(ctx context.Context, read, write, trunc bool\n// using the old file descriptor, preventing us from safely\n/... | Go | Apache License 2.0 | google/gvisor | Change dup2 call to dup3
We changed syscalls to allow dup3 for ARM64.
Updates #1198
PiperOrigin-RevId: 297870816 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.