author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,858 | 11.02.2020 16:01:42 | 28,800 | e5d9a4010bdbea10320348b022ee5b761c1eba07 | Add ability to execute go.mod in gopath context. | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -32,6 +32,9 @@ will need to be added to the appropriate `BUILD` files, and the `:gopath` target\nwill need to be re-run to generate appropriate symlinks in the `GOPATH`\ndirectory tree.\n+Dependencie... | Go | Apache License 2.0 | google/gvisor | Add ability to execute go.mod in gopath context. |
260,003 | 28.02.2020 10:37:52 | 28,800 | 6b4d36e3253238dd72d0861ac1220d147e1de8dd | Hide /dev/net/tun when using hostinet.
/dev/net/tun does not currently work with hostinet. This has caused some
program starts failing because it thinks the feature exists. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dev/BUILD",
"new_path": "pkg/sentry/fs/dev/BUILD",
"diff": "@@ -26,6 +26,7 @@ go_library(\n\"//pkg/sentry/fs/fsutil\",\n\"//pkg/sentry/fs/ramfs\",\n\"//pkg/sentry/fs/tmpfs\",\n+ \"//pkg/sentry/inet\",\n\"//pkg/sentry/kernel\",\n\"//pkg/sentry/mem... | Go | Apache License 2.0 | google/gvisor | Hide /dev/net/tun when using hostinet.
/dev/net/tun does not currently work with hostinet. This has caused some
program starts failing because it thinks the feature exists.
PiperOrigin-RevId: 297876196 |
259,975 | 28.02.2020 13:21:33 | 28,800 | df8740b8a7fb8fa05d7a0387749b61d57a74c06c | Mark gettid and getdents as nogotsan | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -30,6 +30,7 @@ syscall_test(\nsyscall_test(\nsize = \"enormous\",\n+ tags = [\"nogotsan\"],\ntest = \"//test/perf/linux:getdents_benchmark\",\n)\n@@ -40,6 +41,7 @@ syscall_test(\nsyscall_test(\nsize ... | Go | Apache License 2.0 | google/gvisor | Mark gettid and getdents as nogotsan
PiperOrigin-RevId: 297915815 |
259,853 | 28.02.2020 17:53:25 | 28,800 | ab7ecdd66d2aa4835bbe655ba672bd30813a2a88 | watchdog: print panic error message before other messages
This is needed for syzkaller to proper classify issues.
Right now, all watchdog issues are duped to one with the
subject "panic: Sentry detected stuck task(s). See stack
trace and message above for more details". | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -221,7 +221,7 @@ func (w *Watchdog) waitForStart() {\nreturn\n}\nvar buf bytes.Buffer\n- buf.WriteString(\"Watchdog.Start() not called within %s:\\n\")\n+ buf.WriteStr... | Go | Apache License 2.0 | google/gvisor | watchdog: print panic error message before other messages
This is needed for syzkaller to proper classify issues.
Right now, all watchdog issues are duped to one with the
subject "panic: Sentry detected stuck task(s). See stack
trace and message above for more details".
PiperOrigin-RevId: 297975363 |
259,974 | 02.03.2020 07:13:47 | 0 | 36b193b1db60cad3c1c65ce3abef03a6a0594e3e | Fix syscall test build error on arm64.
The error was introduced in the merge of PR
Some codes are missing when adding bazel select_arch
command to the test/syscall/linux/BUILD file. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -608,7 +608,10 @@ cc_binary(\ncc_binary(\nname = \"exceptions_test\",\ntestonly = 1,\n- srcs = [\"exceptions.cc\"],\n+ srcs = select_arch(\n+ amd64 = [\"exceptions.cc\"],\n+ arm64... | Go | Apache License 2.0 | google/gvisor | Fix syscall test build error on arm64.
The error was introduced in the merge of PR #1471.
Some codes are missing when adding bazel select_arch
command to the test/syscall/linux/BUILD file.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I8cae3f4ae78c2e14671f3ac6e7361dc2806d9305 |
259,881 | 02.03.2020 10:05:52 | 28,800 | 62bd3ca8a37543c060292ca86669e537b9ebf36d | Take write lock when removing xattr | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/inode.go",
"new_path": "pkg/sentry/fs/fsutil/inode.go",
"diff": "@@ -259,8 +259,8 @@ func (i *InodeSimpleExtendedAttributes) ListXattr(context.Context, *fs.Inode, ui\n// RemoveXattr implements fs.InodeOperations.RemoveXattr.\nfunc (i *Inod... | Go | Apache License 2.0 | google/gvisor | Take write lock when removing xattr
PiperOrigin-RevId: 298380654 |
259,962 | 02.03.2020 14:43:52 | 28,800 | 33101752501fafea99d77f34bbd65f3e0083d22e | Fix data-race when reading/writing e.amss. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -295,6 +295,7 @@ func (h *handshake) synSentState(s *segment) *tcpip.Error {\nh.state = handshakeSynRcvd\nh.ep.mu.Lock()\nttl := h.ep.ttl\n+ amss := h.ep.amss\nh... | Go | Apache License 2.0 | google/gvisor | Fix data-race when reading/writing e.amss.
PiperOrigin-RevId: 298451319 |
259,896 | 02.03.2020 16:30:51 | 28,800 | 43abb24657e737dee1108ff0d512b2e1b6d8a3f6 | Fix panic caused by invalid address for Bind in packet sockets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -712,6 +712,10 @@ func (s *SocketOperations) Connect(t *kernel.Task, sockaddr []byte, blocking boo\n// Bind implements the linux syscall bind(2) for sock... | Go | Apache License 2.0 | google/gvisor | Fix panic caused by invalid address for Bind in packet sockets.
PiperOrigin-RevId: 298476533 |
259,858 | 03.03.2020 12:36:37 | 28,800 | b3c549d8391e7cadd82a5ab9280bc63bb372aa97 | Move temp_umask to test/util. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -166,11 +166,6 @@ cc_library(\n],\n)\n-cc_library(\n- name = \"temp_umask\",\n- hdrs = [\"temp_umask.h\"],\n-)\n-\ncc_library(\nname = \"unix_domain_socket_test_util\",\ntestonly ... | Go | Apache License 2.0 | google/gvisor | Move temp_umask to test/util.
PiperOrigin-RevId: 298667595 |
259,853 | 03.03.2020 14:34:36 | 28,800 | 277a0d5a1fbe8272d4729c01ee4c6e374d047ebc | platform/ptrace: don't call probeSeccomp on arm64
The support of PTRACE_SYSEMU on arm64 was added in the 5.3 kernel,
so we can be sure that the current version is higher that 5.3.
And this change moves vsyscall seccomp rules to the arch specific file,
because vsyscall isn't supported on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/subprocess_amd64.go",
"new_path": "pkg/sentry/platform/ptrace/subprocess_amd64.go",
"diff": "@@ -21,6 +21,7 @@ import (\n\"strings\"\n\"syscall\"\n+ \"golang.org/x/sys/unix\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/... | Go | Apache License 2.0 | google/gvisor | platform/ptrace: don't call probeSeccomp on arm64
The support of PTRACE_SYSEMU on arm64 was added in the 5.3 kernel,
so we can be sure that the current version is higher that 5.3.
And this change moves vsyscall seccomp rules to the arch specific file,
because vsyscall isn't supported on arm64.
PiperOrigin-RevId: 298696493 |
259,992 | 03.03.2020 15:27:23 | 28,800 | 122d47aed17abf4301596e19fc8ac9cdad8118d9 | Update cached file size when cache is skipped
gofer.dentryReadWriter.WriteFromBlocks was not updating
gofer.dentry.size after a write operation that skips the
cache.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -361,8 +361,15 @@ func (rw *dentryReadWriter) WriteFromBlocks(srcs safemem.BlockSeq) (uint64, erro\nrw.d.handleMu.RLock()\nif (rw.d.handle.fd >= 0 && !... | Go | Apache License 2.0 | google/gvisor | Update cached file size when cache is skipped
gofer.dentryReadWriter.WriteFromBlocks was not updating
gofer.dentry.size after a write operation that skips the
cache.
Updates #1198
PiperOrigin-RevId: 298708646 |
259,846 | 03.03.2020 16:53:53 | 28,800 | fa5f99187bb28a0f363ddce82cefe92a002edc0f | Gather and return real statistics in Stats() | [
{
"change_type": "MODIFY",
"old_path": "pkg/v2/service.go",
"new_path": "pkg/v2/service.go",
"diff": "@@ -565,8 +565,77 @@ func (s *service) Shutdown(ctx context.Context, r *taskAPI.ShutdownRequest) (*pt\n}\nfunc (s *service) Stats(ctx context.Context, r *taskAPI.StatsRequest) (*taskAPI.StatsRespons... | Go | Apache License 2.0 | google/gvisor | Gather and return real statistics in Stats() (#50) |
259,972 | 04.03.2020 00:14:41 | 28,800 | ef1219c1451a75916693a54ddad39d04cf763d90 | Use shuf instead of $RANDOM everywhere.
$RANDOM can cause collisions but shuf uses /dev/urandom so it ought to cause
fewer. | [
{
"change_type": "MODIFY",
"old_path": "test/packetdrill/packetdrill_test.sh",
"new_path": "test/packetdrill/packetdrill_test.sh",
"diff": "@@ -91,8 +91,8 @@ fi\n# Variables specific to the test runner start with TEST_RUNNER_.\ndeclare -r PACKETDRILL=\"/packetdrill/gtests/net/packetdrill/packetdrill... | Go | Apache License 2.0 | google/gvisor | Use shuf instead of $RANDOM everywhere.
$RANDOM can cause collisions but shuf uses /dev/urandom so it ought to cause
fewer.
PiperOrigin-RevId: 298786344 |
259,885 | 04.03.2020 14:29:11 | 28,800 | a690b5762480ae80ef4264402fcfa8d84b57339a | Ensure that safemem.BlockSeqOf(safemem.Block{}) produces an empty BlockSeq. | [
{
"change_type": "MODIFY",
"old_path": "pkg/safemem/seq_test.go",
"new_path": "pkg/safemem/seq_test.go",
"diff": "@@ -20,6 +20,27 @@ import (\n\"testing\"\n)\n+func TestBlockSeqOfEmptyBlock(t *testing.T) {\n+ bs := BlockSeqOf(Block{})\n+ if !bs.IsEmpty() {\n+ t.Errorf(\"BlockSeqOf(Block{}).IsEmpty()... | Go | Apache License 2.0 | google/gvisor | Ensure that safemem.BlockSeqOf(safemem.Block{}) produces an empty BlockSeq.
PiperOrigin-RevId: 298941855 |
259,854 | 05.03.2020 15:55:40 | 28,800 | 9b3aad33c4470908953b7b548b12cba77799f342 | Use a pool of arrays to avoid slice headers from escaping in TCP options pool.
By putting slices into the pool, the slice header escapes. This can be avoided
by not putting the slice header into the pool.
This removes an allocation from the TCP segment send path. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/BUILD",
"new_path": "pkg/tcpip/transport/tcp/BUILD",
"diff": "@@ -32,6 +32,7 @@ go_library(\nsrcs = [\n\"accept.go\",\n\"connect.go\",\n+ \"connect_unsafe.go\",\n\"cubic.go\",\n\"cubic_state.go\",\n\"dispatcher.go\",\n"
},
{
"ch... | Go | Apache License 2.0 | google/gvisor | Use a pool of arrays to avoid slice headers from escaping in TCP options pool.
By putting slices into the pool, the slice header escapes. This can be avoided
by not putting the slice header into the pool.
This removes an allocation from the TCP segment send path.
PiperOrigin-RevId: 299215480 |
260,003 | 05.03.2020 17:39:11 | 28,800 | 9b64b658c1b9a4986bc5a4ebd9e5ddeb9f52dfa3 | Fix S/R on inet.Namespace. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/inet/namespace.go",
"new_path": "pkg/sentry/inet/namespace.go",
"diff": "@@ -23,7 +23,10 @@ type Namespace struct {\n// creator allows kernel to create new network stack for network namespaces.\n// If nil, no networking will function if network is n... | Go | Apache License 2.0 | google/gvisor | Fix S/R on inet.Namespace.
PiperOrigin-RevId: 299238067 |
259,884 | 05.03.2020 18:21:39 | 28,800 | da48fc6cca23a38faef51c5b5f8ae609940773a0 | Stub oom_score_adj and oom_score.
Adds an oom_score_adj and oom_score proc file stub. oom_score_adj accepts
writes of values -1000 to 1000 and persists the value with the task. New tasks
inherit the parent's oom_score_adj.
oom_score is a read-only stub that always returns the value '0'.
Issue | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -85,6 +85,8 @@ func (p *proc) newTaskDir(t *kernel.Task, msrc *fs.MountSource, isThreadGroup bo\n\"mountinfo\": seqfile.NewSeqFileInode(t, &mountInfoFile{t: t}, msrc),\n\"mounts... | Go | Apache License 2.0 | google/gvisor | Stub oom_score_adj and oom_score.
Adds an oom_score_adj and oom_score proc file stub. oom_score_adj accepts
writes of values -1000 to 1000 and persists the value with the task. New tasks
inherit the parent's oom_score_adj.
oom_score is a read-only stub that always returns the value '0'.
Issue #202
PiperOrigin-RevId: 299245355 |
260,004 | 06.03.2020 08:01:45 | 28,800 | d6f5e71df2c8ff3d763cba703786af68af1f9841 | Get strings for stack.DHCPv6ConfigurationFromNDPRA
Useful for logs to print the string representation of the value
instead of the integer value. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -18,6 +18,7 @@ go_template_instance(\ngo_library(\nname = \"stack\",\nsrcs = [\n+ \"dhcpv6configurationfromndpra_string.go\",\n\"icmp_rate_limit.go\",\n\"linkaddrcache.go\",\n\"linkaddren... | Go | Apache License 2.0 | google/gvisor | Get strings for stack.DHCPv6ConfigurationFromNDPRA
Useful for logs to print the string representation of the value
instead of the integer value.
PiperOrigin-RevId: 299356847 |
259,896 | 06.03.2020 09:25:32 | 28,800 | 1e8c0bcedb265d3149e5d2ab1181628d013539c4 | Add nat table support for iptables. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/iptables/targets.go",
"new_path": "pkg/tcpip/iptables/targets.go",
"diff": "@@ -69,7 +69,7 @@ func (ReturnTarget) Action(tcpip.PacketBuffer) (RuleVerdict, int) {\n// Min and Max values for IP and Ports in the struct indicate the range of\n// values w... | Go | Apache License 2.0 | google/gvisor | Add nat table support for iptables. |
259,972 | 06.03.2020 11:22:55 | 28,800 | 20170d4fd5c26def584664762f4e639f0b43ff6e | Move packetdrill tests to open-source | [
{
"change_type": "MODIFY",
"old_path": "test/packetdrill/BUILD",
"new_path": "test/packetdrill/BUILD",
"diff": "-load(\"defs.bzl\", \"packetdrill_test\")\n+load(\"defs.bzl\", \"packetdrill_linux_test\", \"packetdrill_netstack_test\", \"packetdrill_test\")\npackage(licenses = [\"notice\"])\npacketdri... | Go | Apache License 2.0 | google/gvisor | Move packetdrill tests to open-source
PiperOrigin-RevId: 299396286 |
260,004 | 06.03.2020 11:32:13 | 28,800 | f50d9a31e9e734a02e0191f6bc91b387bb21f9ab | Specify the source of outgoing NDP RS
If the NIC has a valid IPv6 address assigned, use it as the
source address for outgoing NDP Router Solicitation packets.
Test: stack_test.TestRouterSolicitation | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/checker.go",
"new_path": "pkg/tcpip/checker/checker.go",
"diff": "@@ -785,26 +785,23 @@ func NDPNSTargetAddress(want tcpip.Address) TransportChecker {\n}\n}\n-// NDPNSOptions creates a checker that checks that the packet contains the\n-// pro... | Go | Apache License 2.0 | google/gvisor | Specify the source of outgoing NDP RS
If the NIC has a valid IPv6 address assigned, use it as the
source address for outgoing NDP Router Solicitation packets.
Test: stack_test.TestRouterSolicitation
PiperOrigin-RevId: 299398763 |
259,972 | 06.03.2020 11:41:10 | 28,800 | d5dbe366bf7c9f5b648b8114a9dc7f45589899b1 | shutdown(s, SHUT_WR) in TIME-WAIT returns ENOTCONN
From RFC 793 s3.9 p61 Event Processing:
CLOSE Call during TIME-WAIT: return with "error: connection closing"
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -2117,10 +2117,13 @@ func (e *endpoint) Shutdown(flags tcpip.ShutdownFlags) *tcpip.Error {\n// Close for write.\nif (e.shutdownFlags & tcpip.ShutdownWrite) != ... | Go | Apache License 2.0 | google/gvisor | shutdown(s, SHUT_WR) in TIME-WAIT returns ENOTCONN
From RFC 793 s3.9 p61 Event Processing:
CLOSE Call during TIME-WAIT: return with "error: connection closing"
Fixes #1603
PiperOrigin-RevId: 299401353 |
259,860 | 06.03.2020 15:22:30 | 28,800 | 228813fd26aadea012cd8c39e084e4b0fb23d273 | Update comments and debug level for profiling options. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/pprof.go",
"new_path": "pkg/sentry/control/pprof.go",
"diff": "@@ -117,15 +117,15 @@ func (p *Profile) HeapProfile(o *ProfileOpts, _ *struct{}) error {\nreturn nil\n}\n-// GoroutineProfile is an RPC stub which dumps out the stack trace for a... | Go | Apache License 2.0 | google/gvisor | Update comments and debug level for profiling options.
PiperOrigin-RevId: 299448307 |
259,974 | 13.01.2020 07:44:58 | 0 | c04958e2fa456587277baef361868bddc0df9e49 | Enable thread local storage support on arm64.
Linux use the task.thread.uw.tp_value field to store the
TLS pointer on arm64 platform, and we use a similar way
in gvisor to store it in the arch/State struct. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/elf.go",
"new_path": "pkg/abi/linux/elf.go",
"diff": "@@ -102,4 +102,7 @@ const (\n// NT_X86_XSTATE is for x86 extended state using xsave.\nNT_X86_XSTATE = 0x202\n+\n+ // NT_ARM_TLS is for ARM TLS register.\n+ NT_ARM_TLS = 0x401\n)\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Enable thread local storage support on arm64.
Linux use the task.thread.uw.tp_value field to store the
TLS pointer on arm64 platform, and we use a similar way
in gvisor to store it in the arch/State struct.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: Ie76b5c6d109bc27ccfd594008a96753806db7764 |
259,853 | 09.03.2020 11:52:32 | 25,200 | 2446161b3faa352bf28dc83e338f10967f0224c2 | perf/signal: rewrite code in assembly to avoid compiler optimizations
Without this change, the assembly code of this test compiled without
optimizations:
mov -0x150(%rbp),%rax
movl $0x77777777,(%rax)
lea -0x128(%rbp),%rax
with optimizations:
movl $0x77777777,0x0
This code doesn't work properly, because the test changes rax in the segv
handler. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/linux/signal_benchmark.cc",
"new_path": "test/perf/linux/signal_benchmark.cc",
"diff": "@@ -43,11 +43,13 @@ void BM_FaultSignalFixup(benchmark::State& state) {\n// Fault, fault, fault.\nfor (auto _ : state) {\n- register volatile unsigned int* ptr as... | Go | Apache License 2.0 | google/gvisor | perf/signal: rewrite code in assembly to avoid compiler optimizations
Without this change, the assembly code of this test compiled without
optimizations:
mov -0x150(%rbp),%rax
movl $0x77777777,(%rax)
lea -0x128(%rbp),%rax
with optimizations:
movl $0x77777777,0x0
This code doesn't work properly, because the test changes rax in the segv
handler.
PiperOrigin-RevId: 299896117 |
260,003 | 09.03.2020 19:57:35 | 25,200 | b36de6e7be0542b410901d3cbcd1b3c0fc493cf5 | Move /proc/net to /proc/PID/net, and make /proc/net -> /proc/self/net.
Issue | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -40,47 +40,48 @@ import (\n// LINT.IfChange\n-// newNet creates a new proc net entry.\n-func (p *proc) newNetDir(ctx context.Context, k *kernel.Kernel, msrc *fs.MountSource) *fs.I... | Go | Apache License 2.0 | google/gvisor | Move /proc/net to /proc/PID/net, and make /proc/net -> /proc/self/net.
Issue #1833
PiperOrigin-RevId: 299998105 |
259,884 | 10.03.2020 13:58:27 | 25,200 | 0990ef7517236228f575f222ae639d375badec15 | Make checkpoint/restore e2e test less flaky | [
{
"change_type": "MODIFY",
"old_path": "test/e2e/integration_test.go",
"new_path": "test/e2e/integration_test.go",
"diff": "@@ -175,10 +175,8 @@ func TestCheckpointRestore(t *testing.T) {\nt.Fatal(err)\n}\n- // TODO(b/143498576): Remove after github.com/moby/moby/issues/38963 is fixed.\n- time.Sleep... | Go | Apache License 2.0 | google/gvisor | Make checkpoint/restore e2e test less flaky
PiperOrigin-RevId: 300171916 |
259,884 | 30.01.2020 23:32:12 | 18,000 | 5f723ac601e8ea6eb3216f60fce49b771ef87e0a | Fix corrupted bazel install errors.
Previously /tmp/gvisor-website was used for the bazel output_user_root
but the host could delete a subset of the files under /tmp causing it to
become corrupted.
This commit updates the Makefile to use the bazel_user_root directory
under the repository root directory for caching bazel packages. | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": "bin/\n+bazel_user_root/\npublic/\nresources/\nnode_modules/\n"
},
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -83,26 +83,24 @@ node_modules: package.... | Go | Apache License 2.0 | google/gvisor | Fix corrupted bazel install errors.
Previously /tmp/gvisor-website was used for the bazel output_user_root
but the host could delete a subset of the files under /tmp causing it to
become corrupted.
This commit updates the Makefile to use the bazel_user_root directory
under the repository root directory for caching bazel packages. |
259,884 | 21.12.2019 03:27:52 | 18,000 | 7a3048954a537b82f2dfd5cf81600585820ffd3a | Add note on nested virtualization | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/platforms.md",
"new_path": "content/docs/user_guide/platforms.md",
"diff": "@@ -63,6 +63,11 @@ nested virtualization in several popular environments:\n* VirtualBox: [Nested Virtualization][nested-virtualbox]\n* KVM: [Nested Guests][nest... | Go | Apache License 2.0 | google/gvisor | Add note on nested virtualization |
260,004 | 10.03.2020 17:50:47 | 25,200 | f56fe66b13b979f2ac96e8fce6fb0a5dec9a32e0 | Honour the link's MaxHeaderLength when forwarding
This change also updates where the IP packet buffer is held in an
outbound tcpip.PacketBuffer from Header to Data. This change removes
unncessary copying of the IP packet buffer when forwarding.
Test: stack_test.TestNICForwarding | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/packet_buffer.go",
"new_path": "pkg/tcpip/packet_buffer.go",
"diff": "@@ -39,8 +39,12 @@ type PacketBuffer struct {\n// payload.\nDataSize int\n- // Header holds the headers of outbound packets. As a packet is passed\n- // down the stack, each layer ... | Go | Apache License 2.0 | google/gvisor | Honour the link's MaxHeaderLength when forwarding
This change also updates where the IP packet buffer is held in an
outbound tcpip.PacketBuffer from Header to Data. This change removes
unncessary copying of the IP packet buffer when forwarding.
Test: stack_test.TestNICForwarding
PiperOrigin-RevId: 300217972 |
259,884 | 10.03.2020 18:24:00 | 14,400 | 95535eca245cfa6de69c42a04a6f6b265f22e014 | Update tool compatibility. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/compatibility/_index.md",
"new_path": "content/docs/user_guide/compatibility/_index.md",
"diff": "@@ -62,24 +62,24 @@ Most common utilities work. Note that:\n| gdb | Working |\n| gosu | Working |\n| grep | Working (unless stdin is a pip... | Go | Apache License 2.0 | google/gvisor | Update tool compatibility. |
259,853 | 11.03.2020 11:44:27 | 25,200 | d3fa741fb539d16b271f1bed2bcd93e382b0b2e2 | runsc: Set asyncpreemptoff for the kvm platform
The asynchronous goroutine preemption is a new feature of Go 1.14.
When we switched to go 1.14 (cl/297915917) in the bazel config,
the kokoro syscall-kvm job started permanently failing. Lets
temporary set asyncpreemptoff for the kvm platform to unblock tests. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -444,6 +444,12 @@ func (s *Sandbox) createSandboxProcess(conf *boot.Config, args *Args, startSyncF\nnextFD++\n}\n+ // TODO(b/151157106): syscall tests fail by timeout if asyncpreemp... | Go | Apache License 2.0 | google/gvisor | runsc: Set asyncpreemptoff for the kvm platform
The asynchronous goroutine preemption is a new feature of Go 1.14.
When we switched to go 1.14 (cl/297915917) in the bazel config,
the kokoro syscall-kvm job started permanently failing. Lets
temporary set asyncpreemptoff for the kvm platform to unblock tests.
PiperOrigin-RevId: 300372387 |
259,881 | 11.03.2020 14:38:04 | 25,200 | 5ee9bbb15d90b5f116d9482e932e0823cffd9f6e | Upgrade Kythe | [
{
"change_type": "MODIFY",
"old_path": "kokoro/kythe/generate_xrefs.sh",
"new_path": "kokoro/kythe/generate_xrefs.sh",
"diff": "@@ -23,7 +23,7 @@ bazel version\npython3 -V\n-readonly KYTHE_VERSION='v0.0.41'\n+readonly KYTHE_VERSION='v0.0.43'\nreadonly WORKDIR=\"$(mktemp -d)\"\nreadonly KYTHE_DIR=\"$... | Go | Apache License 2.0 | google/gvisor | Upgrade Kythe
PiperOrigin-RevId: 300409401 |
259,891 | 09.03.2020 17:40:13 | 25,200 | 4054b021f05cb0902e9877ba82403978fd8d6405 | iptables: ready tests to be enabled in kokoro
Fixed flakes (tested via --runs_per_test=100) and added skips for
not-yet-implemented features. Once submitted, the iptables tests will be
ready to enable in kokoro. | [
{
"change_type": "MODIFY",
"old_path": "scripts/iptables_tests.sh",
"new_path": "scripts/iptables_tests.sh",
"diff": "@@ -19,9 +19,12 @@ source $(dirname $0)/common.sh\ninstall_runsc_for_test iptables\n# Build the docker image for the test.\n-run //test/iptables/runner-image --norun\n+run //test/ipt... | Go | Apache License 2.0 | google/gvisor | iptables: ready tests to be enabled in kokoro
Fixed flakes (tested via --runs_per_test=100) and added skips for
not-yet-implemented features. Once submitted, the iptables tests will be
ready to enable in kokoro. |
260,003 | 12.03.2020 14:34:16 | 25,200 | bbf86003bfd2a7547744b89c72e1cd06e9385e66 | Remove flaky network namespace test that uses clone(). | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -3707,11 +3707,10 @@ cc_binary(\n\":socket_test_util\",\ngtest,\n\"//test/util:capability_util\",\n- \"//test/util:memory_util\",\n+ \"//test/util:posix_error\",\n\"//test/util:te... | Go | Apache License 2.0 | google/gvisor | Remove flaky network namespace test that uses clone().
PiperOrigin-RevId: 300626011 |
259,884 | 12.03.2020 18:14:31 | 14,400 | 14c1917b70a513ae71191c7fa7f24be62b1789a9 | Fix grammar mistake in Performance Guide
Fixes | [
{
"change_type": "MODIFY",
"old_path": "content/docs/architecture_guide/performance.md",
"new_path": "content/docs/architecture_guide/performance.md",
"diff": "@@ -25,9 +25,9 @@ Second, as gVisor is an independent implementation of the system call surface,\nmany of the subsystems or specific calls a... | Go | Apache License 2.0 | google/gvisor | Fix grammar mistake in Performance Guide
Fixes #147 |
259,972 | 12.03.2020 18:38:41 | 25,200 | f693e1334b6fd0bea26fad770dfec3aa7e03c59a | Clarify comments about IHL in ipv4.go. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv4.go",
"new_path": "pkg/tcpip/header/ipv4.go",
"diff": "@@ -38,7 +38,8 @@ const (\n// IPv4Fields contains the fields of an IPv4 packet. It is used to describe the\n// fields of a packet that needs to be encoded.\ntype IPv4Fields struct {\n-... | Go | Apache License 2.0 | google/gvisor | Clarify comments about IHL in ipv4.go.
PiperOrigin-RevId: 300668506 |
259,974 | 13.03.2020 03:02:26 | 0 | 333b74dc288357e192dbd86f6d0732be5ea7df64 | Enable syscall seccomp test on arm64. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/seccomp.cc",
"new_path": "test/syscalls/linux/seccomp.cc",
"diff": "@@ -72,8 +72,15 @@ void ApplySeccompFilter(uint32_t sysno, uint32_t filtered_result,\nstruct sock_filter filter[] = {\n// A = seccomp_data.arch\nBPF_STMT(BPF_LD | BPF_ABS |... | Go | Apache License 2.0 | google/gvisor | Enable syscall seccomp test on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: Ibc926c917d98b31fc92bbf8d82d6818c39b0f93c |
259,992 | 13.03.2020 08:56:47 | 25,200 | 8f8f16efafd48da3c5e4db329a90bb76620b2324 | Add support for mount flags
Plumbs MS_NOEXEC and MS_RDONLY. Others are TODO.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsbridge/vfs.go",
"new_path": "pkg/sentry/fsbridge/vfs.go",
"diff": "@@ -115,8 +115,6 @@ func NewVFSLookup(mntns *vfs.MountNamespace, root, workingDir vfs.VirtualDentry)\n//\n// remainingTraversals is not configurable in VFS2, all callers are using ... | Go | Apache License 2.0 | google/gvisor | Add support for mount flags
Plumbs MS_NOEXEC and MS_RDONLY. Others are TODO.
Updates #1623 #1193
PiperOrigin-RevId: 300764669 |
260,004 | 13.03.2020 10:43:09 | 25,200 | 28d26d2c4f231c447a10bcbcfb8223a804c9d8bc | Honour the link's MaxHeaderLength when forwarding
LinkEndpoints may expect/assume that the a tcpip.PacketBuffer's Header
has enough capacity for its own headers, as per documentation for
LinkEndpoint.MaxHeaderLength.
Test: stack_test.TestNICForwarding | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "package stack\nimport (\n+ \"fmt\"\n\"log\"\n\"reflect\"\n\"sort\"\n@@ -1259,9 +1260,24 @@ func (n *NIC) DeliverNetworkPacket(linkEP LinkEndpoint, remote, local tcpip.Link\nfunc (n *NIC) f... | Go | Apache License 2.0 | google/gvisor | Honour the link's MaxHeaderLength when forwarding
LinkEndpoints may expect/assume that the a tcpip.PacketBuffer's Header
has enough capacity for its own headers, as per documentation for
LinkEndpoint.MaxHeaderLength.
Test: stack_test.TestNICForwarding
PiperOrigin-RevId: 300784192 |
260,003 | 13.03.2020 11:25:49 | 25,200 | f458a325e9b6aecf2ee198de19063505c48a14d7 | Fix "application exiting with {Code:0 Signo:27}" during boot.
skips SIGURG, but later code expects
the sigchans array contains consecutive signal numbers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/sighandling/sighandling.go",
"new_path": "pkg/sentry/sighandling/sighandling.go",
"diff": "@@ -83,12 +83,13 @@ func StartSignalForwarding(handler func(linux.Signal)) func() {\n// for their handling.\nvar sigchans []chan os.Signal\nfor sig := 1; sig ... | Go | Apache License 2.0 | google/gvisor | Fix "application exiting with {Code:0 Signo:27}" during boot.
2aa9514a06a5e34894e606d508ac2df53b082c74 skips SIGURG, but later code expects
the sigchans array contains consecutive signal numbers.
PiperOrigin-RevId: 300793450 |
259,975 | 13.03.2020 11:50:30 | 25,200 | b8fda7f34f7e9629629bb0cdf7f7e72c7efdace9 | Run "startup" benchmark in Kokoro benchmark job. | [
{
"change_type": "MODIFY",
"old_path": "scripts/benchmark.sh",
"new_path": "scripts/benchmark.sh",
"diff": "# See the License for the specific language governing permissions and\n# limitations under the License.\n-# Run in the root of the repo.\n-cd \"$(dirname \"$0\")\"\n+source $(dirname $0)/commo... | Go | Apache License 2.0 | google/gvisor | Run "startup" benchmark in Kokoro benchmark job.
PiperOrigin-RevId: 300798423 |
259,992 | 13.03.2020 12:09:58 | 25,200 | 722abdd8339f1df515beae0ad5272c8c2b2cfed0 | Skip process if it has exited | [
{
"change_type": "MODIFY",
"old_path": "test/root/runsc_test.go",
"new_path": "test/root/runsc_test.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"bytes\"\n\"fmt\"\n\"io/ioutil\"\n+ \"os\"\n\"os/exec\"\n\"path/filepath\"\n\"strconv\"\n@@ -117,6 +118,10 @@ func sandboxPid(pid int) (int, error) {\ncmdlin... | Go | Apache License 2.0 | google/gvisor | Skip process if it has exited
PiperOrigin-RevId: 300802159 |
259,885 | 13.03.2020 12:16:59 | 25,200 | b78cee3bae142eb5c602d51874d0cbad274777e2 | Fix lock recursion in kernel.ProcessGroup.SendSignal(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/sessions.go",
"new_path": "pkg/sentry/kernel/sessions.go",
"diff": "@@ -246,7 +246,7 @@ func (pg *ProcessGroup) SendSignal(info *arch.SignalInfo) error {\nvar lastErr error\nfor tg := range tasks.Root.tgids {\n- if tg.ProcessGroup() == pg {\n... | Go | Apache License 2.0 | google/gvisor | Fix lock recursion in kernel.ProcessGroup.SendSignal().
PiperOrigin-RevId: 300803515 |
259,885 | 13.03.2020 13:17:59 | 25,200 | 1c0535297067179a822ba2dd9a6fe13a8be5a666 | Fix oom_score_adj.
Make oomScoreAdj a ThreadGroup field (Linux: signal_struct::oom_score_adj).
Avoid deadlock caused by Task.OOMScoreAdj()/SetOOMScoreAdj() locking Task.mu
and TaskSet.mu in the wrong order (via Task.ExitState()). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -853,15 +853,15 @@ func (o *oomScoreAdj) GetFile(ctx context.Context, dirent *fs.Dirent, flags fs.F\n// Read implements fs.FileOperations.Read.\nfunc (f *oomScoreAdjFile) Read(c... | Go | Apache License 2.0 | google/gvisor | Fix oom_score_adj.
- Make oomScoreAdj a ThreadGroup field (Linux: signal_struct::oom_score_adj).
- Avoid deadlock caused by Task.OOMScoreAdj()/SetOOMScoreAdj() locking Task.mu
and TaskSet.mu in the wrong order (via Task.ExitState()).
PiperOrigin-RevId: 300814698 |
259,885 | 13.03.2020 16:08:06 | 25,200 | b0f2c3e7646df603156f1b8e8b3382f33353eb04 | Fix infinite loop in semaphore.sem.wakeWaiters(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "@@ -554,6 +554,7 @@ func (s *sem) wakeWaiters() {\nfor w := s.waiters.Front(); w != nil; {\nif s.value < w.value {\n// Still blocked, skip it.\n+ w = w.... | Go | Apache License 2.0 | google/gvisor | Fix infinite loop in semaphore.sem.wakeWaiters().
PiperOrigin-RevId: 300845134 |
259,992 | 13.03.2020 17:16:59 | 25,200 | 829beebf0b67e20e50dd5ec4a5030636e38cc576 | Panic if file in FDTable has been destroyed
This will give more information about the file to
identify where possibly the extra DecRef()
would be. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -195,6 +195,8 @@ func (f *FDTable) Size() int {\n//\n// It is the caller's responsibility to acquire an appropriate lock.\nfunc (f *FDTable) forEach(fn func(fd int32, file... | Go | Apache License 2.0 | google/gvisor | Panic if file in FDTable has been destroyed
This will give more information about the file to
identify where possibly the extra DecRef()
would be.
PiperOrigin-RevId: 300855874 |
259,992 | 14.03.2020 13:46:55 | 25,200 | 97127750289b49dd5e29f8ddb4209137e47fe52d | Disallow kernfs.Inode.SetStat for readonly inodes
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go",
"new_path": "pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go",
"diff": "@@ -61,9 +61,10 @@ func (f *DynamicBytesFile) Open(rp *vfs.ResolvingPath, vfsd *vfs.Dentry, opts vf\nreturn &fd.vfsfd, nil\n}\n-// SetStat i... | Go | Apache License 2.0 | google/gvisor | Disallow kernfs.Inode.SetStat for readonly inodes
Updates #1195, #1193
PiperOrigin-RevId: 300950993 |
259,884 | 12.03.2020 18:10:13 | 14,400 | e024f8fa560c1420039f8e29b601f30b1bb233e5 | Add FAQ to website for Kernel bug issue. | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/FAQ.md",
"new_path": "content/docs/user_guide/FAQ.md",
"diff": "@@ -78,6 +78,18 @@ sudo chown root:root /usr/local/bin/runsc\nsudo chmod 0755 /usr/local/bin/runsc\n```\n+### I'm getting an error like `mount submount \"/etc/hostname\": c... | Go | Apache License 2.0 | google/gvisor | Add FAQ to website for Kernel bug issue.
https://github.com/google/gvisor/issues/1765 |
259,962 | 16.03.2020 08:02:05 | 25,200 | 52758e16e0d1e67b3cdd56e04abfce663607ac42 | Prevent vnetHdr from escaping in WritePacket. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -407,7 +407,6 @@ func (e *endpoint) WritePacket(r *stack.Route, gso *stack.GSO, protocol tcpip.Ne\nif e.Capabilities()&stack.CapabilityHardwareGSO != 0 {\nvnetHd... | Go | Apache License 2.0 | google/gvisor | Prevent vnetHdr from escaping in WritePacket.
PiperOrigin-RevId: 301157950 |
260,003 | 16.03.2020 12:02:33 | 25,200 | 69da42885aff9371fd53227583a546df914de02b | Enable ARP resolution in TAP devices. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/tun/device.go",
"new_path": "pkg/tcpip/link/tun/device.go",
"diff": "@@ -98,7 +98,12 @@ func (d *Device) SetIff(s *stack.Stack, name string, flags uint16) error {\nprefix = \"tap\"\n}\n- endpoint, err := attachOrCreateNIC(s, name, prefix)\n+ lin... | Go | Apache License 2.0 | google/gvisor | Enable ARP resolution in TAP devices.
PiperOrigin-RevId: 301208471 |
259,992 | 16.03.2020 13:28:00 | 25,200 | 0f60799a4f8c3db567973574147370fc900df55f | Add calls to vfs.CheckSetStat to fsimpls
Only gofer filesystem was calling vfs.CheckSetStat for
vfs.FilesystemImpl.SetStatAt and vfs.FileDescriptionImpl.SetStat.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -114,7 +114,8 @@ type inode struct {\nino uint64\n// mu protects the inode metadata below.\n- mu sync.Mutex\n+ // TODO(gvisor.dev/issue/1672): actually protect fields be... | Go | Apache License 2.0 | google/gvisor | Add calls to vfs.CheckSetStat to fsimpls
Only gofer filesystem was calling vfs.CheckSetStat for
vfs.FilesystemImpl.SetStatAt and vfs.FileDescriptionImpl.SetStat.
Updates #1193, #1672, #1197
PiperOrigin-RevId: 301226522 |
259,853 | 16.03.2020 18:28:29 | 25,200 | b55f0e5d40c17cadf68d6238564d675ed12f8f49 | fdtable: don't try to zap fdtable entry if close is called for non-existing fd
FDTable.setAll is used to zap entries, but it grows the table up to
a specified fd.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -536,7 +536,9 @@ func (f *FDTable) Remove(fd int32) (*fs.File, *vfs.FileDescription) {\ncase orig2 != nil:\norig2.IncRef()\n}\n+ if orig != nil || orig2 != nil {\nf.setAll... | Go | Apache License 2.0 | google/gvisor | fdtable: don't try to zap fdtable entry if close is called for non-existing fd
FDTable.setAll is used to zap entries, but it grows the table up to
a specified fd.
Reported-by: syzbot+9e281b0750d2d4caa190@syzkaller.appspotmail.com
PiperOrigin-RevId: 301280000 |
259,891 | 17.03.2020 16:21:36 | 25,200 | 1cc5a71a0e2100c89c97ffd12a38143907b33630 | iptables: fix type in script name, mark some new tests as skipped | [
{
"change_type": "MODIFY",
"old_path": "kokoro/iptables_tests.cfg",
"new_path": "kokoro/iptables_tests.cfg",
"diff": "-build_file: \"repo/scripts/iptables_test.sh\"\n+build_file: \"repo/scripts/iptables_tests.sh\"\naction {\ndefine_artifacts {\n"
},
{
"change_type": "MODIFY",
"old_path":... | Go | Apache License 2.0 | google/gvisor | iptables: fix type in script name, mark some new tests as skipped
PiperOrigin-RevId: 301476456 |
259,974 | 11.03.2020 09:55:07 | 0 | 9c35d7eb1f96f12207f78b94722f0e8b778b5af3 | Enable syscall sysret_test on arm64.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -3336,10 +3336,7 @@ cc_binary(\ncc_binary(\nname = \"sysret_test\",\ntestonly = 1,\n- srcs = select_arch(\n- amd64 = [\"sysret.cc\"],\n- arm64 = [],\n- ),\n+ srcs = [\"sysret.cc\"... | Go | Apache License 2.0 | google/gvisor | Enable syscall sysret_test on arm64.
Fixes #2058
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I05750d238a6425d3a47fae15720901f4dd924a32 |
259,992 | 18.03.2020 15:12:11 | 25,200 | f1d1af2a4ad35dd20a7c56bd9e842e347b126c31 | Fix FDTable.NewFDVFS2
It was looking at VFS1 table to determine where to
allocate the next FD from.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -338,7 +338,7 @@ func (f *FDTable) NewFDVFS2(ctx context.Context, minfd int32, file *vfs.FileDesc\nfd = f.next\n}\nfor fd < end {\n- if d, _, _ := f.get(fd); d == nil {\n+... | Go | Apache License 2.0 | google/gvisor | Fix FDTable.NewFDVFS2
It was looking at VFS1 table to determine where to
allocate the next FD from.
Updates #1035
PiperOrigin-RevId: 301678858 |
259,891 | 18.03.2020 15:51:36 | 25,200 | b5ea65c07c29cbc894e9f879796eed816696d042 | iptables: skip tests for not-yet-supported features | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/iptables_test.go",
"new_path": "test/iptables/iptables_test.go",
"diff": "@@ -191,6 +191,7 @@ func TestFilterInputDropOnlyUDP(t *testing.T) {\n}\nfunc TestNATRedirectUDPPort(t *testing.T) {\n+ // TODO(gvisor.dev/issue/170): Enable when supported.... | Go | Apache License 2.0 | google/gvisor | iptables: skip tests for not-yet-supported features
PiperOrigin-RevId: 301686266 |
259,854 | 18.03.2020 16:25:20 | 25,200 | 92a00ca91affab8564b8875387758914ddc9785b | Store segment transmit count.
This will aid in segment reordering detection.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/segment.go",
"new_path": "pkg/tcpip/transport/tcp/segment.go",
"diff": "@@ -56,9 +56,9 @@ type segment struct {\noptions []byte `state:\".([]byte)\"`\nhasNewSACKInfo bool\nrcvdTime time.Time `state:\".(unixTime)\"`\n- // xmitTime is the... | Go | Apache License 2.0 | google/gvisor | Store segment transmit count.
This will aid in segment reordering detection.
Updates #691
PiperOrigin-RevId: 301692638 |
259,853 | 18.03.2020 17:41:06 | 25,200 | c3cee7f5a433708a394cee4e89c223f80036f5d9 | Deflake third_party/gvisor/pkg/gate/gate_test
TestConcurrentAll executes 1000 goroutines which never sleep,
so they are not preempted by Go's runtime. In Go 1.14, async preemption
has been added, but the added runtime.Gosched() call will do nothing
wrong in this case too. | [
{
"change_type": "MODIFY",
"old_path": "pkg/gate/gate_test.go",
"new_path": "pkg/gate/gate_test.go",
"diff": "package gate_test\nimport (\n+ \"runtime\"\n\"testing\"\n\"time\"\n@@ -165,6 +166,8 @@ func worker(g *gate.Gate, done *sync.WaitGroup) {\nif !g.Enter() {\nbreak\n}\n+ // Golang before v1.14 ... | Go | Apache License 2.0 | google/gvisor | Deflake third_party/gvisor/pkg/gate/gate_test
TestConcurrentAll executes 1000 goroutines which never sleep,
so they are not preempted by Go's runtime. In Go 1.14, async preemption
has been added, but the added runtime.Gosched() call will do nothing
wrong in this case too.
PiperOrigin-RevId: 301705712 |
259,891 | 18.03.2020 14:44:56 | 25,200 | a8f9cc87989979b6d8bc3759e64bdd1b76329b64 | iptables: deflake DropTCP*Port tests
These tests could timeout because net.DialTCP didn't respect the
timeout. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/filter_input.go",
"new_path": "test/iptables/filter_input.go",
"diff": "@@ -194,8 +194,14 @@ func (FilterInputDropTCPDestPort) ContainerAction(ip net.IP) error {\n// LocalAction implements TestCase.LocalAction.\nfunc (FilterInputDropTCPDestPort) ... | Go | Apache License 2.0 | google/gvisor | iptables: deflake DropTCP*Port tests
These tests could timeout because net.DialTCP didn't respect the
timeout. |
259,962 | 19.03.2020 09:41:56 | 25,200 | fd27a917ef068a4e17cddbe3f671b59f52e6e030 | Address comments on workMu removal change.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -420,7 +420,7 @@ func (e *endpoint) handleSynSegment(ctx *listenContext, s *segment, opts *header\n}\nfunc (e *endpoint) incSynRcvdCount() bool {\n- if e.synRcvdCo... | Go | Apache License 2.0 | google/gvisor | Address comments on workMu removal change.
Updates #231, #357
PiperOrigin-RevId: 301833669 |
259,962 | 19.03.2020 09:59:21 | 25,200 | 3a37f6791745a26d38b69fbe9d4090f8fd0c7827 | Change SocketOperations.readMu to an RWMutex.
Also get rid of the readViewHasData as it's not required anymore.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -29,7 +29,6 @@ import (\n\"io\"\n\"math\"\n\"reflect\"\n- \"sync/atomic\"\n\"syscall\"\n\"time\"\n@@ -265,14 +264,8 @@ type SocketOperations struct {\nsk... | Go | Apache License 2.0 | google/gvisor | Change SocketOperations.readMu to an RWMutex.
Also get rid of the readViewHasData as it's not required anymore.
Updates #231, #357
PiperOrigin-RevId: 301837227 |
259,972 | 19.03.2020 12:32:15 | 25,200 | e0fbcdcb7f8a3e18946ccd5d5b98ea3adadee5ba | Add packetimpact tests to presubmit and CI testing | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "kokoro/packetimpact_tests.cfg",
"diff": "+build_file: \"repo/scripts/packetimpact_tests.sh\"\n+\n+action {\n+ define_artifacts {\n+ regex: \"**/sponge_log.xml\"\n+ regex: \"**/sponge_log.log\"\n+ regex: \"**/outputs.zip\"\n+ }\n+}\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Add packetimpact tests to presubmit and CI testing
PiperOrigin-RevId: 301872161 |
259,975 | 19.03.2020 15:28:52 | 25,200 | 57d9bd922b4eff922d1a5185529fe5446249d592 | Remove the "frozen" bit from dirents.
Frozen was to lock down changes to the host filesystem
for hostFS. Now that hostFS is gone, it can be removed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -17,7 +17,6 @@ package fs\nimport (\n\"fmt\"\n\"path\"\n- \"sort\"\n\"sync/atomic\"\n\"syscall\"\n@@ -121,9 +120,6 @@ type Dirent struct {\n// deleted may be set atomically when remov... | Go | Apache License 2.0 | google/gvisor | Remove the "frozen" bit from dirents.
Frozen was to lock down changes to the host filesystem
for hostFS. Now that hostFS is gone, it can be removed.
PiperOrigin-RevId: 301907923 |
259,975 | 19.03.2020 16:05:52 | 25,200 | b9210b285566acd72d0820b42c1a330ba56a1ad0 | Fix bm-tools to run on bazel.
Fixes random stuff that is broken on bazel/kokoro.
random output coming back as "bytes" object instead of str
missed syntax error in bazel
a flag is missing in the version of gcloud on kokoro | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/harness/machine_producers/gcloud_producer.py",
"new_path": "benchmarks/harness/machine_producers/gcloud_producer.py",
"diff": "@@ -168,7 +168,9 @@ class GCloudProducer(machine_producer.MachineProducer):\ncmd.append(\"--zone=\" + self.zone)\ncmd.appe... | Go | Apache License 2.0 | google/gvisor | Fix bm-tools to run on bazel.
Fixes random stuff that is broken on bazel/kokoro.
- random output coming back as "bytes" object instead of str
- missed syntax error in bazel
- a flag is missing in the version of gcloud on kokoro
PiperOrigin-RevId: 301915289 |
259,992 | 19.03.2020 20:17:03 | 25,200 | 069f1edbe42ebd91800f9b35e8724babc4081613 | Improve error message when pivot_root fails | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/chroot.go",
"new_path": "runsc/cmd/chroot.go",
"diff": "@@ -50,7 +50,7 @@ func pivotRoot(root string) error {\n// new_root, so after umounting the old_root, we will see only\n// the new_root in \"/\".\nif err := syscall.PivotRoot(\".\", \".\"); err !... | Go | Apache License 2.0 | google/gvisor | Improve error message when pivot_root fails
PiperOrigin-RevId: 301949722 |
259,860 | 19.03.2020 23:29:15 | 25,200 | 248e46f320525704da917e148a8f69d9b74671a0 | Whitelist utimensat(2).
utimensat is used by hostfs for setting timestamps on imported fds. Previously,
this would crash the sandbox since utimensat was not allowed.
Correct the VFS2 version of hostfs to match the call in VFS1. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/BUILD",
"new_path": "pkg/sentry/fsimpl/host/BUILD",
"diff": "@@ -9,6 +9,7 @@ go_library(\n\"ioctl_unsafe.go\",\n\"tty.go\",\n\"util.go\",\n+ \"util_unsafe.go\",\n],\nvisibility = [\"//pkg/sentry:internal\"],\ndeps = [\n"
},
{
"ch... | Go | Apache License 2.0 | google/gvisor | Whitelist utimensat(2).
utimensat is used by hostfs for setting timestamps on imported fds. Previously,
this would crash the sandbox since utimensat was not allowed.
Correct the VFS2 version of hostfs to match the call in VFS1.
PiperOrigin-RevId: 301970121 |
260,003 | 20.03.2020 15:24:00 | 25,200 | 49aef9cee70d111f6c3e1a6b04430bbe414a6c1e | Remove unused variable `sndNxtList`. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -878,7 +878,6 @@ func (e *endpoint) handleWrite() *tcpip.Error {\nfirst := e.sndQueue.Front()\nif first != nil {\ne.snd.writeList.PushBackList(&e.sndQueue)\n- e.... | Go | Apache License 2.0 | google/gvisor | Remove unused variable `sndNxtList`.
PiperOrigin-RevId: 302110328 |
259,962 | 20.03.2020 17:00:55 | 25,200 | 1bf2e52bdb5f366b397cb887d4cbdb91dd5e3213 | Actually wrap rand.Reader in bufio.Reader.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/rand/rand_linux.go",
"new_path": "pkg/rand/rand_linux.go",
"diff": "package rand\nimport (\n+ \"bufio\"\n\"crypto/rand\"\n\"io\"\n@@ -45,8 +46,22 @@ func (r *reader) Read(p []byte) (int, error) {\nreturn rand.Read(p)\n}\n+// bufferedReader implements a thr... | Go | Apache License 2.0 | google/gvisor | Actually wrap rand.Reader in bufio.Reader.
Updates #231
PiperOrigin-RevId: 302127697 |
259,972 | 20.03.2020 18:22:49 | 25,200 | fed59953aad40d89730ebfc6f33b17116c42abcf | Statically link libpthread for static c++ binaries.
The posix_server works fine when run in locally or in docker but fails in the
kokoro GCP build environment. Linking libpthread statically fixes it. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazeldefs/defs.bzl",
"new_path": "tools/bazeldefs/defs.bzl",
"diff": "@@ -65,10 +65,17 @@ def cc_binary(name, static = False, **kwargs):\n**kwargs: the rest of the args.\n\"\"\"\nif static:\n- if \"linkopts\" in kwargs:\n- kwargs[\"linkopts\"] += [\"-sta... | Go | Apache License 2.0 | google/gvisor | Statically link libpthread for static c++ binaries.
The posix_server works fine when run in locally or in docker but fails in the
kokoro GCP build environment. Linking libpthread statically fixes it.
PiperOrigin-RevId: 302139082 |
259,860 | 23.03.2020 14:32:05 | 25,200 | 6eebaea94936ffefd3603ff16ad2225856313fa3 | Correctly release taskPathOperation for accessAt. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/stat.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/stat.go",
"diff": "@@ -272,6 +272,7 @@ func accessAt(t *kernel.Task, dirfd int32, pathAddr usermem.Addr, mode uint) err\nif err != nil {\nreturn err\n}\n+ defer tpop.Release()... | Go | Apache License 2.0 | google/gvisor | Correctly release taskPathOperation for accessAt.
PiperOrigin-RevId: 302518924 |
259,962 | 23.03.2020 16:05:29 | 25,200 | 369cf38bd7186da97e134538cd4839a8a4d1aa2c | Fix data race in SetSockOpt. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -2382,9 +2382,9 @@ func (s *SocketOperations) nonBlockingRead(ctx context.Context, dst usermem.IOSe\n// caller-supplied buffer.\ns.readMu.Lock()\nn, err ... | Go | Apache License 2.0 | google/gvisor | Fix data race in SetSockOpt.
PiperOrigin-RevId: 302539171 |
259,884 | 23.03.2020 16:11:37 | 25,200 | a730d74b3230fb32181b9a940c07b61338222874 | Support basic /proc/net/dev metrics for netstack
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/stack.go",
"new_path": "pkg/sentry/socket/netstack/stack.go",
"diff": "@@ -200,36 +200,66 @@ func (s *Stack) SetTCPSACKEnabled(enabled bool) error {\n// Statistics implements inet.Stack.Statistics.\nfunc (s *Stack) Statistics(stat in... | Go | Apache License 2.0 | google/gvisor | Support basic /proc/net/dev metrics for netstack
Fixes #506
PiperOrigin-RevId: 302540404 |
259,962 | 24.03.2020 15:33:16 | 25,200 | c8eeedcc1d6b1ee25532ae630a7efd7aa4656bdc | Add support for setting TCP segment hash.
This allows the link layer endpoints to consistenly hash a TCP
segment to a single underlying queue in case a link layer endpoint
does support multiple underlying queues.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -405,6 +405,7 @@ func (e *endpoint) WritePacket(r *stack.Route, gso *stack.GSO, protocol tcpip.Ne\neth.Encode(ethHdr)\n}\n+ fd := e.fds[pkt.Hash%uint32(len(e.fds... | Go | Apache License 2.0 | google/gvisor | Add support for setting TCP segment hash.
This allows the link layer endpoints to consistenly hash a TCP
segment to a single underlying queue in case a link layer endpoint
does support multiple underlying queues.
Updates #231
PiperOrigin-RevId: 302760664 |
259,884 | 25.03.2020 08:28:24 | -32,400 | 8fbf811f79d611dd55355734736265dfec20b73f | Updated e2e tests on travis
* Updated e2e tests on travis
Updated tests to run using Go 1.14
Added test for containerd 1.3
Updated release of runsc to test
* Fix release downloading in e2e tests
* Fix test targets
* Update to using Ubuntu bionic in travis tests | [
{
"change_type": "MODIFY",
"old_path": ".travis.yml",
"new_path": ".travis.yml",
"diff": "-dist: trusty\n+dist: bionic\nsudo: required\nlanguage: go\n-go: \"1.12.x\"\n+go: \"1.14.x\"\nenv:\n- - GO111MODULE=on CONTAINERD_VERSION=1.1.5 RUNSC_VERSION=2019-08-06 TEST=untrusted-workload\n- - GO111MODULE=... | Go | Apache License 2.0 | google/gvisor | Updated e2e tests on travis (#53)
* Updated e2e tests on travis
- Updated tests to run using Go 1.14
- Added test for containerd 1.3
- Updated release of runsc to test
* Fix release downloading in e2e tests
* Fix test targets
* Update to using Ubuntu bionic in travis tests |
259,962 | 25.03.2020 10:54:19 | 25,200 | d04adebaab86ac30aca463b06528fc22430598ac | Fix data-race in endpoint.Readiness | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/aliases.go",
"new_path": "pkg/sync/aliases.go",
"diff": "@@ -29,3 +29,8 @@ type (\n// Map is an alias of sync.Map.\nMap = sync.Map\n)\n+\n+// NewCond is a wrapper around sync.NewCond.\n+func NewCond(l Locker) *Cond {\n+ return sync.NewCond(l)\n+}\n"
... | Go | Apache License 2.0 | google/gvisor | Fix data-race in endpoint.Readiness
PiperOrigin-RevId: 302924789 |
259,853 | 25.03.2020 11:20:24 | 25,200 | 2e09f2bdce11d5f303333c68af4272abb62b7885 | travis: exclude copybara branches
When copybara migrates changes, it creates a new branch and then creates a
pull-requests which is based on this branch. In this case, travis-ci
triggers build twice for the branch and for the pull-request. | [
{
"change_type": "MODIFY",
"old_path": ".travis.yml",
"new_path": ".travis.yml",
"diff": "@@ -17,3 +17,7 @@ matrix:\nscript:\n- uname -a\n- make DOCKER_RUN_OPTIONS=\"\" BAZEL_OPTIONS=\"build runsc:runsc\" bazel && $RUNSC_PATH --alsologtostderr --network none --debug --TESTONLY-unsafe-nonroot=true --... | Go | Apache License 2.0 | google/gvisor | travis: exclude copybara branches
When copybara migrates changes, it creates a new branch and then creates a
pull-requests which is based on this branch. In this case, travis-ci
triggers build twice for the branch and for the pull-request.
PiperOrigin-RevId: 302930634 |
259,992 | 25.03.2020 14:44:18 | 25,200 | c7f5673529af758c9f7c95523535174c7929dab5 | Set file mode and type to attribute
Makes less error prone to find file type.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/device_file.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/device_file.go",
"diff": "package tmpfs\nimport (\n+ \"fmt\"\n+\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel/auth\"\n\"gvisor.dev/gvisor/pkg/sentry/vfs... | Go | Apache License 2.0 | google/gvisor | Set file mode and type to attribute
Makes less error prone to find file type.
Updates #1197
PiperOrigin-RevId: 302974244 |
259,992 | 25.03.2020 14:54:10 | 25,200 | e541ebec2fdb5b29209cb3fc8235b77edcaebb6a | Misc fixes to make stat_test pass (almost)
The only test failing now requires socket which is not
available in VFS2 yet.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/bits/bits_template.go",
"new_path": "pkg/bits/bits_template.go",
"diff": "@@ -42,3 +42,11 @@ func Mask(is ...int) T {\nfunc MaskOf(i int) T {\nreturn T(1) << T(i)\n}\n+\n+// IsPowerOfTwo returns true if v is power of 2.\n+func IsPowerOfTwo(v T) bool {\n+ i... | Go | Apache License 2.0 | google/gvisor | Misc fixes to make stat_test pass (almost)
The only test failing now requires socket which is not
available in VFS2 yet.
Updates #1198
PiperOrigin-RevId: 302976572 |
259,992 | 25.03.2020 15:23:48 | 25,200 | f2eba940159b4ed55359f99a3422ad899a8647ee | Remove TODO to push down exec permission check
Pushing it down requires all implementation to check for
exec individualy which is not maintanable. Making it part
of GenericCheckPermissions add extra cost to everyone that
calls it. So it's better to keep is in
VirtualFilesystem.OpenAt.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/vfs.go",
"new_path": "pkg/sentry/vfs/vfs.go",
"diff": "@@ -402,8 +402,6 @@ func (vfs *VirtualFilesystem) OpenAt(ctx context.Context, creds *auth.Credential\nif err == nil {\nvfs.putResolvingPath(rp)\n- // TODO(gvisor.dev/issue/1193): Move inside... | Go | Apache License 2.0 | google/gvisor | Remove TODO to push down exec permission check
Pushing it down requires all implementation to check for
exec individualy which is not maintanable. Making it part
of GenericCheckPermissions add extra cost to everyone that
calls it. So it's better to keep is in
VirtualFilesystem.OpenAt.
Updates #1193
PiperOrigin-RevId: 302982993 |
259,992 | 25.03.2020 15:38:38 | 25,200 | 5f03dca5227e4f2e7aa472ad40d421d4623c9f72 | Fix race in TestRunEnvHasHome
It's possible to execute the command that checks user's
$HOME dir before the user is created. Move the code that
creates the user inside exec so it can be serialized. | [
{
"change_type": "MODIFY",
"old_path": "test/e2e/exec_test.go",
"new_path": "test/e2e/exec_test.go",
"diff": "@@ -240,17 +240,7 @@ func TestExecEnvHasHome(t *testing.T) {\n}\nd := dockerutil.MakeDocker(\"exec-env-home-test\")\n- // We will check that HOME is set for root user, and also for a new\n- ... | Go | Apache License 2.0 | google/gvisor | Fix race in TestRunEnvHasHome
It's possible to execute the command that checks user's
$HOME dir before the user is created. Move the code that
creates the user inside exec so it can be serialized.
PiperOrigin-RevId: 302986184 |
259,858 | 28.02.2020 18:01:21 | 28,800 | d440fe0613a3b8fec75d33aff36ebada220106b0 | Fix go_marshal Example name.
There is a canonical naming convention for Examples, which are checked
by analyzers. This must be fixed since adding exceptions for generated
code will be more challenging. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/gomarshal/generator.go",
"new_path": "tools/go_marshal/gomarshal/generator.go",
"diff": "@@ -413,7 +413,7 @@ func (g *Generator) writeTests(ts []*testGenerator) error {\n// empty example instead.\nif len(ts) == 0 {\nb.reset()\n- b.emit(\"func ... | Go | Apache License 2.0 | google/gvisor | Fix go_marshal Example name.
There is a canonical naming convention for Examples, which are checked
by analyzers. This must be fixed since adding exceptions for generated
code will be more challenging. |
259,858 | 04.10.2019 19:03:07 | 25,200 | 882ed330e6e7761f482f9bfa771cc6693e0f8008 | nogo: enable sanitizers.
This enables all relevant santizers (though most analyzers will not find
much, it will prevent instances from creeping in), and codifies existing
exceptions in tools/nogo.js to be fixed. | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -49,10 +49,31 @@ gazelle(name = \"gazelle\")\n# live in the tools subdirectory (unless they are standard).\nnogo(\nname = \"nogo\",\n- config = \"//tools:nogo.js\",\n+ config = \"//tools:nogo.json\",\nvisibility = [\"//... | Go | Apache License 2.0 | google/gvisor | nogo: enable sanitizers.
This enables all relevant santizers (though most analyzers will not find
much, it will prevent instances from creeping in), and codifies existing
exceptions in tools/nogo.js to be fixed. |
259,891 | 25.03.2020 18:55:19 | 25,200 | 4f374da60cb0c39ed862518e5b7524cb86ec96db | iptable: fix tests timeouts
Tests were run assuming a runtime of "runsc" was present, and did not
have --net-raw enabled. | [
{
"change_type": "MODIFY",
"old_path": "scripts/iptables_tests.sh",
"new_path": "scripts/iptables_tests.sh",
"diff": "source $(dirname $0)/common.sh\n-install_runsc_for_test iptables\n+install_runsc_for_test iptables --net-raw\n# Build the docker image for the test.\nrun //test/iptables/runner:runne... | Go | Apache License 2.0 | google/gvisor | iptable: fix tests timeouts
Tests were run assuming a runtime of "runsc" was present, and did not
have --net-raw enabled. |
259,992 | 25.03.2020 19:12:25 | 25,200 | de694e5484502d53166d70b36141e62fcdf07803 | Combine file mode and isDir arguments
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -287,6 +287,11 @@ func (m FileMode) ExtraBits() FileMode {\nreturn m &^ (PermissionsMask | FileTypeMask)\n}\n+// IsDir returns true if file type represents a directory.\n+func (m FileMode... | Go | Apache License 2.0 | google/gvisor | Combine file mode and isDir arguments
Updates #1035
PiperOrigin-RevId: 303021328 |
259,891 | 26.03.2020 10:46:47 | 25,200 | bc3def43c3c30ccde6577a0af213d13e4fd17e1e | Check error in DropTCP*Port tests and fix comment. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/filter_input.go",
"new_path": "test/iptables/filter_input.go",
"diff": "@@ -194,14 +194,11 @@ func (FilterInputDropTCPDestPort) ContainerAction(ip net.IP) error {\n// LocalAction implements TestCase.LocalAction.\nfunc (FilterInputDropTCPDestPort)... | Go | Apache License 2.0 | google/gvisor | Check error in DropTCP*Port tests and fix comment.
PiperOrigin-RevId: 303147253 |
259,858 | 26.03.2020 12:29:14 | 25,200 | a5742f177af1758d9e7b65bfbf11af297960817b | Add nogo exemption for machine_arm64_unsafe.go | [
{
"change_type": "MODIFY",
"old_path": "tools/nogo.json",
"new_path": "tools/nogo.json",
"diff": "\"/pkg/gohacks/gohacks_unsafe.go\": \"allowed: special case\",\n\"/pkg/sentry/fs/fsutil/host_file_mapper_unsafe.go\": \"allowed: special case\",\n\"/pkg/sentry/platform/kvm/(bluepill|machine)_unsafe.go\... | Go | Apache License 2.0 | google/gvisor | Add nogo exemption for machine_arm64_unsafe.go |
260,004 | 26.03.2020 15:59:41 | 25,200 | edc3c049eb553fcbf32f4a6b515141a26c5609d4 | Use panic instead of log.Fatalf | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "package ipv6\nimport (\n- \"log\"\n+ \"fmt\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/tcpip/buffer\"\n@@ -199,7 +199,7 @@ func (e *endpoint) handleICMP(r *... | Go | Apache License 2.0 | google/gvisor | Use panic instead of log.Fatalf
PiperOrigin-RevId: 303212189 |
259,860 | 26.03.2020 21:47:46 | 25,200 | 76a7ace751bfd4b16411edbc0a2b06d0308b8832 | Add BoundEndpointAt filesystem operation.
BoundEndpointAt() is needed to support Unix sockets bound at a
file path, corresponding to BoundEndpoint() in VFS1.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/BUILD",
"new_path": "pkg/sentry/fsimpl/ext/BUILD",
"diff": "@@ -45,6 +45,7 @@ go_library(\n\"//pkg/sentry/fsimpl/ext/disklayout\",\n\"//pkg/sentry/kernel/auth\",\n\"//pkg/sentry/memmap\",\n+ \"//pkg/sentry/socket/unix/transport\",\n\"//pk... | Go | Apache License 2.0 | google/gvisor | Add BoundEndpointAt filesystem operation.
BoundEndpointAt() is needed to support Unix sockets bound at a
file path, corresponding to BoundEndpoint() in VFS1.
Updates #1476.
PiperOrigin-RevId: 303258251 |
259,884 | 26.03.2020 19:03:47 | 14,400 | 4b0eaecb71c65465d5df39ac4bcadbe5a501c550 | Added FAQ redirect | [
{
"change_type": "MODIFY",
"old_path": "cmd/gvisor-website/main.go",
"new_path": "cmd/gvisor-website/main.go",
"diff": "@@ -30,11 +30,15 @@ import (\n)\nvar redirects = map[string]string{\n+ // Github redirects\n\"/change\": \"https://github.com/google/gvisor\",\n\"/issue\": \"https://github.com/goo... | Go | Apache License 2.0 | google/gvisor | Added FAQ redirect |
259,884 | 26.03.2020 20:27:48 | 14,400 | 2c352437734f17e1c051a7a801e501a302635db2 | Updated custom header ids | [
{
"change_type": "MODIFY",
"old_path": "content/docs/user_guide/FAQ.md",
"new_path": "content/docs/user_guide/FAQ.md",
"diff": "@@ -7,7 +7,7 @@ weight = 1000\ngVisor requires Linux {{< required_linux >}} ([older Linux][old-linux]).\n-### What CPU architectures are supported? {#supported-cpu}\n+### W... | Go | Apache License 2.0 | google/gvisor | Updated custom header ids |
259,885 | 27.03.2020 16:54:45 | 25,200 | f6e4daa67ad5f07ac1bcff33476b4d13f49a69bc | Add vfs.PathnameReachable().
/proc/[pid]/mount* omit mounts whose mount point is outside the chroot, which
is checked (indirectly) via __d_path(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/pathname.go",
"new_path": "pkg/sentry/vfs/pathname.go",
"diff": "@@ -90,6 +90,49 @@ loop:\nreturn b.String(), nil\n}\n+// PathnameReachable returns an absolute pathname to vd, consistent with\n+// Linux's __d_path() (as used by seq_path_root()).... | Go | Apache License 2.0 | google/gvisor | Add vfs.PathnameReachable().
/proc/[pid]/mount* omit mounts whose mount point is outside the chroot, which
is checked (indirectly) via __d_path().
PiperOrigin-RevId: 303434226 |
259,858 | 30.03.2020 12:36:30 | 25,200 | 3fac85da951f9f56d0232718ea7584250cf11f31 | kvm: handle exit reasons even under EINTR.
In the case of other signals (preemption), inject a normal bounce and
defer the signal until the vCPU has been returned from guest mode. | [
{
"change_type": "MODIFY",
"old_path": "pkg/atomicbitops/atomicbitops_noasm.go",
"new_path": "pkg/atomicbitops/atomicbitops_noasm.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"sync/atomic\"\n)\n+//go:nosplit\nfunc AndUint32(addr *uint32, val uint32) {\nfor {\no := atomic.LoadUint32(addr)\n@@ -30,6 +31... | Go | Apache License 2.0 | google/gvisor | kvm: handle exit reasons even under EINTR.
In the case of other signals (preemption), inject a normal bounce and
defer the signal until the vCPU has been returned from guest mode.
PiperOrigin-RevId: 303799678 |
259,975 | 30.03.2020 13:04:44 | 25,200 | e36eccc4b18676e2cb441380d0e4e46f038f638e | BigQuery schema for benchmark-tools dashboard. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -386,6 +386,49 @@ go_repository(\nversion = \"v1.0.0\",\n)\n+go_repository(\n+ name = \"com_google_cloud_go_bigquery\",\n+ importpath = \"cloud.google.com/go/bigquery\",\n+ sum = \"h1:K2NyuHRuv15ku6eUpe0DQk5ZykP... | Go | Apache License 2.0 | google/gvisor | BigQuery schema for benchmark-tools dashboard.
PiperOrigin-RevId: 303805784 |
259,881 | 30.03.2020 14:37:17 | 25,200 | 32a133537e61bbceb6a0a16c95815495d8f17a35 | Add AMD Rome CPUID flag.
This flag is set on Rome CPUs, but it is not documented. | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid_x86.go",
"new_path": "pkg/cpuid/cpuid_x86.go",
"diff": "@@ -235,7 +235,9 @@ const (\nX86FeaturePERFCTR_TSC\nX86FeaturePERFCTR_LLC\nX86FeatureMWAITX\n- // ECX[31:30] are reserved.\n+ // TODO(b/152776797): Some CPUs set this but it is not documen... | Go | Apache License 2.0 | google/gvisor | Add AMD Rome CPUID flag.
This flag is set on Rome CPUs, but it is not documented.
PiperOrigin-RevId: 303825532 |
259,974 | 20.03.2020 08:45:07 | 0 | 8ce5b569714351f9f2f7fc48b0ff0bebbdb018ee | Cleanup for syscall tests on arm64. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/getrandom.cc",
"new_path": "test/syscalls/linux/getrandom.cc",
"diff": "@@ -29,6 +29,8 @@ namespace {\n#define SYS_getrandom 318\n#elif defined(__i386__)\n#define SYS_getrandom 355\n+#elif defined(__aarch64__)\n+#define SYS_getrandom 278\n#... | Go | Apache License 2.0 | google/gvisor | Cleanup for syscall tests on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I8008c0375fc7e23225a21026f359e78e691729e5 |
259,975 | 31.03.2020 16:16:45 | 25,200 | 57e67e32b59a30365a79f6dceb3e0cb772407029 | Debug script issues on Kokoro. | [
{
"change_type": "MODIFY",
"old_path": "scripts/benchmark.sh",
"new_path": "scripts/benchmark.sh",
"diff": "@@ -20,6 +20,8 @@ source $(dirname $0)/common.sh\n# variable for authentication.\nexport GOOGLE_APPLICATION_CREDENTIALS=\"${KOKORO_KEYSTORE_DIR}/${GCLOUD_CREDENTIALS}\"\n+which gcloud\n+\ngclo... | Go | Apache License 2.0 | google/gvisor | Debug script issues on Kokoro.
PiperOrigin-RevId: 304068950 |
259,974 | 28.02.2020 09:14:57 | 0 | c71e97784cfc57a0664a07cb798aca3d39d6bb11 | Enable rseq syscall test on arm64. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/rseq/BUILD",
"new_path": "test/syscalls/linux/rseq/BUILD",
"diff": "# This package contains a standalone rseq test binary. This binary must not\n# depend on libc, which might use rseq itself.\n-load(\"//tools:defs.bzl\", \"cc_flags_supplier... | Go | Apache License 2.0 | google/gvisor | Enable rseq syscall test on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: If30154a2d73e98f211cfe589853b232019b9e130 |
259,860 | 31.03.2020 19:15:55 | 25,200 | 639d94f9f71b43e86320a6e9157c932f5d7936a7 | Add socket filesystem and global disconnected socket mount for VFS2.
A socket mount where anonymous sockets will reside is added to the
VirtualFilesystem. Socketfs is built on top of kernfs.
Updates | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/fsimpl/sockfs/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\")\n+\n+licenses([\"notice\"])\n+\n+go_library(\n+ name = \"sockfs\",\n+ srcs = [\"sockfs.go\"],\n+ visibility = [\"//pkg/sentry:internal\"],\n+ deps = [\n+ \"//p... | Go | Apache License 2.0 | google/gvisor | Add socket filesystem and global disconnected socket mount for VFS2.
A socket mount where anonymous sockets will reside is added to the
VirtualFilesystem. Socketfs is built on top of kernfs.
Updates #1476, #1478, #1484, #1485.
PiperOrigin-RevId: 304095251 |
259,860 | 01.04.2020 07:56:05 | 25,200 | d01a8ca3473bfbc7a5eb8da5ea662925e5f2673d | Add FileDescription interface for socket files.
Refactor the existing socket interface to share methods between VFS1 and VFS2.
The method signatures do not contain anything filesystem-related, so they don't
need to be re-defined for VFS2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/BUILD",
"new_path": "pkg/sentry/socket/BUILD",
"diff": "@@ -16,6 +16,7 @@ go_library(\n\"//pkg/sentry/kernel\",\n\"//pkg/sentry/kernel/time\",\n\"//pkg/sentry/socket/unix/transport\",\n+ \"//pkg/sentry/vfs\",\n\"//pkg/syserr\",\n\"//pkg/tcpip... | Go | Apache License 2.0 | google/gvisor | Add FileDescription interface for socket files.
Refactor the existing socket interface to share methods between VFS1 and VFS2.
The method signatures do not contain anything filesystem-related, so they don't
need to be re-defined for VFS2.
Updates #1476, #1478, #1484, #1485.
PiperOrigin-RevId: 304184545 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.