author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,881 | 01.04.2020 09:58:51 | 25,200 | db7917556a7e4bd2cd6d183c68f04a4787dec493 | Fix 386 build tags
The build tag for 32-bit x86 is 386, not i386.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid_parse_x86_test.go",
"new_path": "pkg/cpuid/cpuid_parse_x86_test.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// +build i386 amd64\n+// +build 386 amd64\npackage cpuid\... | Go | Apache License 2.0 | google/gvisor | Fix 386 build tags
The build tag for 32-bit x86 is 386, not i386.
Updates #2298
PiperOrigin-RevId: 304206373 |
259,972 | 01.04.2020 11:25:43 | 25,200 | 38f4501c995d7d915bcd168d58655e67e2b34566 | Add context.Context argument to XxxWithErrno functions
This allows control over the gRPC timeouts as needed. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/dut.go",
"new_path": "test/packetimpact/testbench/dut.go",
"diff": "@@ -143,13 +143,12 @@ func (dut *DUT) protoToSockaddr(sa *pb.Sockaddr) unix.Sockaddr {\n}\n// BindWithErrno calls bind on the DUT.\n-func (dut *DUT) BindWithErrno(f... | Go | Apache License 2.0 | google/gvisor | Add context.Context argument to XxxWithErrno functions
This allows control over the gRPC timeouts as needed.
PiperOrigin-RevId: 304225713 |
259,975 | 01.04.2020 17:39:12 | 25,200 | 37025990d6ed1f1160937c640855070d9a559cb0 | Add "/snap/bin" to PATH.
"gcloud" may be installed as a snap, under "/snap/bin". Make
sure this is in our PATH so that we can use gcloud. | [
{
"change_type": "MODIFY",
"old_path": "scripts/benchmark.sh",
"new_path": "scripts/benchmark.sh",
"diff": "source $(dirname $0)/common.sh\n+# gcloud may be installed as a \"snap\". If it is, include it in PATH.\n+declare -r snap=\"/snap/bin\"\n+if [[ -d \"-d ${snap}\" ]]; then\n+ export PATH=\"${PA... | Go | Apache License 2.0 | google/gvisor | Add "/snap/bin" to PATH.
"gcloud" may be installed as a snap, under "/snap/bin". Make
sure this is in our PATH so that we can use gcloud.
PiperOrigin-RevId: 304297180 |
259,962 | 02.04.2020 10:39:56 | 25,200 | c6d5742c21c19f9cf8b964b49b8df935c1303417 | Fix flaky TCPLinger2TimeoutAfterClose test.
The test is flaky in cooperative S/R mode because TCP timers are not restored
across a S/R. This can cause the TCPLinger2 timer to not fire. This change
disables S/R before setting the TCP_LINGER2 timeout. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -605,6 +605,10 @@ TEST_P(SocketInetLoopbackTest, TCPLinger2TimeoutAfterClose_NoRandomSave) {\n&conn_addrlen),\nSyscallSucceeds());\n+ // Disabl... | Go | Apache License 2.0 | google/gvisor | Fix flaky TCPLinger2TimeoutAfterClose test.
The test is flaky in cooperative S/R mode because TCP timers are not restored
across a S/R. This can cause the TCPLinger2 timer to not fire. This change
disables S/R before setting the TCP_LINGER2 timeout.
PiperOrigin-RevId: 304430536 |
259,975 | 02.04.2020 11:24:04 | 25,200 | 035836193e6d9e1fc9cce6a0161cb3907fbc2ef5 | Fix typo in benchmarks.sh | [
{
"change_type": "MODIFY",
"old_path": "scripts/benchmark.sh",
"new_path": "scripts/benchmark.sh",
"diff": "@@ -18,11 +18,11 @@ source $(dirname $0)/common.sh\n# gcloud may be installed as a \"snap\". If it is, include it in PATH.\ndeclare -r snap=\"/snap/bin\"\n-if [[ -d \"-d ${snap}\" ]]; then\n+i... | Go | Apache License 2.0 | google/gvisor | Fix typo in benchmarks.sh
PiperOrigin-RevId: 304440599 |
259,885 | 02.04.2020 11:55:55 | 25,200 | 30388ff5919df33e7184719dfc6c0d9cb110b2e2 | Rename files in //pkg/sync to better reflect what they contain. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/BUILD",
"new_path": "pkg/sync/BUILD",
"diff": "@@ -31,13 +31,13 @@ go_library(\nname = \"sync\",\nsrcs = [\n\"aliases.go\",\n- \"downgradable_rwmutex_unsafe.go\",\n\"memmove_unsafe.go\",\n+ \"mutex_unsafe.go\",\n\"norace_unsafe.go\",\n\"race_unsafe.go... | Go | Apache License 2.0 | google/gvisor | Rename files in //pkg/sync to better reflect what they contain.
PiperOrigin-RevId: 304447031 |
260,004 | 02.04.2020 15:58:38 | 25,200 | ecc3d01d181a6ae6d3cc72531542d9ea5fe3e376 | Increment NDP message RX stats before validation
Tests:
ipv6_test.TestHopLimitValidation
ipv6_test.TestRouterAdvertValidation | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "@@ -86,25 +86,12 @@ func (e *endpoint) handleICMP(r *stack.Route, netHeader buffer.View, pkt stack.P\nreturn\n}\n+ isNDPValid := func() bool {\n// As per RFC 4861 sections ... | Go | Apache License 2.0 | google/gvisor | Increment NDP message RX stats before validation
Tests:
- ipv6_test.TestHopLimitValidation
- ipv6_test.TestRouterAdvertValidation
PiperOrigin-RevId: 304495723 |
259,860 | 02.04.2020 17:06:19 | 25,200 | 5b2396d244ed6283d928a72bdd4cc58d78ef3175 | Fix typo in TODO comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/mounts.go",
"new_path": "pkg/sentry/fs/proc/mounts.go",
"diff": "@@ -170,7 +170,8 @@ func superBlockOpts(mountPath string, msrc *fs.MountSource) string {\n// NOTE(b/147673608): If the mount is a cgroup, we also need to include\n// the cgroup... | Go | Apache License 2.0 | google/gvisor | Fix typo in TODO comments.
PiperOrigin-RevId: 304508083 |
259,884 | 25.03.2020 01:38:37 | 14,400 | 3685fa4886d0b01a16a654e600305389f43cd156 | Added second blog post on networking. | [
{
"change_type": "MODIFY",
"old_path": "content/blog/1_security_basics/index.md",
"new_path": "content/blog/1_security_basics/index.md",
"diff": "@@ -43,11 +43,13 @@ In general, Design Principles outline good engineering practices, but in the cas\nA simplified version of the design is below ([more d... | Go | Apache License 2.0 | google/gvisor | Added second blog post on networking. |
259,884 | 02.04.2020 19:24:41 | 14,400 | 4421f4ad9a5b97cbfa064bbbe8cb8a49ab915f5f | Capitalize Netstack. | [
{
"change_type": "MODIFY",
"old_path": "content/blog/2_networking_security/index.md",
"new_path": "content/blog/2_networking_security/index.md",
"diff": "@@ -25,7 +25,7 @@ gVisor manifests these principles as a multi-layered system. An application runn\ngVisor's multi-layered design provides Defense... | Go | Apache License 2.0 | google/gvisor | Capitalize Netstack. |
259,884 | 02.04.2020 19:26:22 | 14,400 | c6be49273b7fccc6ee53ede4ca87af4dac1c2474 | Add header for final paragraph | [
{
"change_type": "MODIFY",
"old_path": "content/blog/2_networking_security/index.md",
"new_path": "content/blog/2_networking_security/index.md",
"diff": "@@ -59,4 +59,6 @@ The goal of the Secure by Default principle is to make it easy to securely sandb\nAnother way in which gVisor makes it easy to s... | Go | Apache License 2.0 | google/gvisor | Add header for final paragraph |
260,004 | 02.04.2020 18:29:09 | 25,200 | 4582a2f188953d34591aef1a479d19d9be8f640f | Drop NDP messages with fragment extension header
As per RFC 6980 section 5, nodes MUST silently ignore NDP messages if
the packet carrying them include an IPv6 Fragmentation Header.
Test: ipv6_test.TestNDPValidation | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"new_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"diff": "@@ -62,6 +62,10 @@ const (\n// within an IPv6RoutingExtHdr.\nipv6RoutingExtHdrSegmentsLeftIdx = 1\n+ // IPv6FragmentExtHdrLength is the length of an... | Go | Apache License 2.0 | google/gvisor | Drop NDP messages with fragment extension header
As per RFC 6980 section 5, nodes MUST silently ignore NDP messages if
the packet carrying them include an IPv6 Fragmentation Header.
Test: ipv6_test.TestNDPValidation
PiperOrigin-RevId: 304519379 |
259,980 | 02.04.2020 22:01:57 | 25,200 | d151693530db68db43188ce0fbc9f81aa5f27e2e | Avoid sending a partial dirent when the Rreaddir response exceeds message limit. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/messages.go",
"new_path": "pkg/p9/messages.go",
"diff": "@@ -1926,19 +1926,17 @@ func (r *Rreaddir) decode(b *buffer) {\n// encode implements encoder.encode.\nfunc (r *Rreaddir) encode(b *buffer) {\nentriesBuf := buffer{}\n+ payloadSize := 0\nfor _, d :... | Go | Apache License 2.0 | google/gvisor | Avoid sending a partial dirent when the Rreaddir response exceeds message limit.
PiperOrigin-RevId: 304542967 |
259,858 | 03.04.2020 13:39:45 | 25,200 | a94309628ebbc2e6c4997890f1b966fa7a16be20 | Ensure EOF is handled propertly during splice. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/pipe.go",
"new_path": "pkg/sentry/kernel/pipe/pipe.go",
"diff": "@@ -255,7 +255,8 @@ func (p *Pipe) write(ctx context.Context, ops writeOps) (int64, error) {\n// POSIX requires that a write smaller than atomicIOBytes (PIPE_BUF) be\n// at... | Go | Apache License 2.0 | google/gvisor | Ensure EOF is handled propertly during splice.
PiperOrigin-RevId: 304684417 |
259,860 | 04.04.2020 21:01:42 | 25,200 | 24bee1c1813a691072cff5bad7a528690a99eb5e | Record VFS2 sockets in global socket map.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/BUILD",
"new_path": "pkg/sentry/fsimpl/proc/BUILD",
"diff": "@@ -22,7 +22,6 @@ go_library(\n\"//pkg/log\",\n\"//pkg/refs\",\n\"//pkg/safemem\",\n- \"//pkg/sentry/fs\",\n\"//pkg/sentry/fsbridge\",\n\"//pkg/sentry/fsimpl/kernfs\",\n\"//pkg... | Go | Apache License 2.0 | google/gvisor | Record VFS2 sockets in global socket map.
Updates #1476, #1478, #1484, #1485.
PiperOrigin-RevId: 304845354 |
259,860 | 06.04.2020 07:30:20 | 25,200 | 00d9776a4bb1cc1d7125af7d3e54a939a4f3847a | Add socket files to tmpfs VFS2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/BUILD",
"new_path": "pkg/sentry/fsimpl/tmpfs/BUILD",
"diff": "@@ -24,6 +24,7 @@ go_library(\n\"filesystem.go\",\n\"named_pipe.go\",\n\"regular_file.go\",\n+ \"socket_file.go\",\n\"symlink.go\",\n\"tmpfs.go\",\n],\n"
},
{
"change... | Go | Apache License 2.0 | google/gvisor | Add socket files to tmpfs VFS2.
Updates #1476.
PiperOrigin-RevId: 305024274 |
259,860 | 06.04.2020 09:50:13 | 25,200 | 4baa7e70795edbb350d55a9365807341515d3af4 | Bump up acceptable sample count for flaky itimer test.
Running the test 1000x almost always produces 1+ test failures where
the sample count is slightly more than 60. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/itimer.cc",
"new_path": "test/syscalls/linux/itimer.cc",
"diff": "@@ -246,7 +246,7 @@ int TestSIGPROFFairness(absl::Duration sleep) {\n// The number of samples on the main thread should be very low as it did\n// nothing.\n- TEST_CHECK(resul... | Go | Apache License 2.0 | google/gvisor | Bump up acceptable sample count for flaky itimer test.
Running the test 1000x almost always produces 1+ test failures where
the sample count is slightly more than 60.
PiperOrigin-RevId: 305051754 |
259,885 | 06.04.2020 16:31:27 | 25,200 | dd98fdd5beb7f02e7c7b3aeb4f07f5d00ffc41e7 | Correctly implement magic symlinks in VFS2 procfs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsbridge/vfs.go",
"new_path": "pkg/sentry/fsbridge/vfs.go",
"diff": "@@ -26,22 +26,22 @@ import (\n\"gvisor.dev/gvisor/pkg/usermem\"\n)\n-// fsFile implements File interface over vfs.FileDescription.\n+// VFSFile implements File interface over vfs.F... | Go | Apache License 2.0 | google/gvisor | Correctly implement magic symlinks in VFS2 procfs.
Updates #1195
PiperOrigin-RevId: 305143567 |
259,972 | 06.04.2020 17:52:25 | 25,200 | 32fc11ee3e39b7ef1152825090112f4b239887c4 | Sort posix service functions | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/dut/posix_server.cc",
"new_path": "test/packetimpact/dut/posix_server.cc",
"diff": "}\nclass PosixImpl final : public posix_server::Posix::Service {\n- ::grpc::Status Socket(grpc_impl::ServerContext *context,\n- const ::posix_server::SocketRe... | Go | Apache License 2.0 | google/gvisor | Sort posix service functions
PiperOrigin-RevId: 305157179 |
259,860 | 06.04.2020 20:07:32 | 25,200 | 51e461cf9c49f6ad5a9a68d93c5928647aae11d8 | Add concurrency guarantees to p9 extended attribute methods. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/file.go",
"new_path": "pkg/p9/file.go",
"diff": "@@ -97,12 +97,12 @@ type File interface {\n// free to ignore the hint entirely (i.e. the value returned may be larger\n// than size). All size checking is done independently at the syscall layer.\n//\n- /... | Go | Apache License 2.0 | google/gvisor | Add concurrency guarantees to p9 extended attribute methods.
PiperOrigin-RevId: 305171772 |
259,992 | 07.04.2020 09:40:38 | 25,200 | 94319a8241cb299edc812024d6132b7a3819a4dc | Make gofer.dentry.destroyLocked idempotent
gofer operations accumulate dentries touched in a slice to call
checkCachingLocked on them when the operation is over. In case
the same dentry is touched multiple times during the operation,
checkCachingLocked, and consequently destroyLocked, may be called
more than once for the same dentry.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/BUILD",
"new_path": "pkg/sentry/fsimpl/gofer/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\nload(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\nlicen... | Go | Apache License 2.0 | google/gvisor | Make gofer.dentry.destroyLocked idempotent
gofer operations accumulate dentries touched in a slice to call
checkCachingLocked on them when the operation is over. In case
the same dentry is touched multiple times during the operation,
checkCachingLocked, and consequently destroyLocked, may be called
more than once for the same dentry.
Updates #1198
PiperOrigin-RevId: 305276819 |
259,854 | 06.04.2020 16:27:38 | 25,200 | dc2f198866c5fd8162a79978eb3633975d3ba11f | Update networking security blog post | [
{
"change_type": "MODIFY",
"old_path": "content/blog/2_networking_security/index.md",
"new_path": "content/blog/2_networking_security/index.md",
"diff": "@@ -37,7 +37,7 @@ Figure 1: Netstack and gVisor\n## Writing a network stack\n-Netstack was written from scratch specifically for gVisor. There are... | Go | Apache License 2.0 | google/gvisor | Update networking security blog post |
260,003 | 07.04.2020 13:27:26 | 25,200 | 71770e56629339c9853466e994b78b172bc668a9 | mkdir test: Address TODOs and re-enable a test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mkdir.cc",
"new_path": "test/syscalls/linux/mkdir.cc",
"diff": "@@ -36,21 +36,12 @@ class MkdirTest : public ::testing::Test {\n// TearDown unlinks created files.\nvoid TearDown() override {\n- // FIXME(edahlgren): We don't currently implem... | Go | Apache License 2.0 | google/gvisor | mkdir test: Address TODOs and re-enable a test.
PiperOrigin-RevId: 305328184 |
260,004 | 07.04.2020 13:35:58 | 25,200 | 6db55a5bd8933b217d285018ed2187812ebae6ef | Require that IPv6 headers be in the first fragment
Test:
header_test.TestIPv6ExtHdrIter
ipv6_test.TestReceiveIPv6Fragments
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"new_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"diff": "@@ -395,18 +395,25 @@ func MakeIPv6PayloadIterator(nextHdrIdentifier IPv6ExtensionHeaderIdentifier, pa\n}\n// AsRawHeader returns the remaining payl... | Go | Apache License 2.0 | google/gvisor | Require that IPv6 headers be in the first fragment
Test:
- header_test.TestIPv6ExtHdrIter
- ipv6_test.TestReceiveIPv6Fragments
Updates #2197, #2333
PiperOrigin-RevId: 305330178 |
260,003 | 07.04.2020 14:32:24 | 25,200 | d5ddb5365086b13c0688c40fc74fa4cc4c5528db | Remove out-of-date TODOs.
We already have network namespace for netstack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/provider.go",
"new_path": "pkg/sentry/socket/netstack/provider.go",
"diff": "@@ -62,10 +62,6 @@ func getTransportProtocol(ctx context.Context, stype linux.SockType, protocol in\n}\ncase linux.SOCK_RAW:\n- // TODO(b/142504697): \"In o... | Go | Apache License 2.0 | google/gvisor | Remove out-of-date TODOs.
We already have network namespace for netstack.
PiperOrigin-RevId: 305341954 |
259,860 | 07.04.2020 14:47:16 | 25,200 | fc72eb3595a7c4e2fa83caa39a9bb4171875c208 | Remove TODOs for local gofer extended attributes. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -767,22 +767,18 @@ func (l *localFile) SetAttr(valid p9.SetAttrMask, attr p9.SetAttr) error {\nreturn err\n}\n-// TODO(b/127675828): support getxattr.\nfunc (*localFile) GetXattr(st... | Go | Apache License 2.0 | google/gvisor | Remove TODOs for local gofer extended attributes.
PiperOrigin-RevId: 305344989 |
259,860 | 07.04.2020 16:16:31 | 25,200 | 693b6bdda9206a5910c552a3997b2df5480d6947 | Correctly distinguish between seekable and non-seekable host fds.
Check whether an fd is seekable by calling the seek syscall and
examining the return value, instead of checking the file type,
which is inaccurate. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -74,31 +74,34 @@ func ImportFD(mnt *vfs.Mount, hostFD int, isTTY bool) (*vfs.FileDescription, err\n}\n// Retrieve metadata.\n- var s syscall.Stat_t\n- if err := syscall.... | Go | Apache License 2.0 | google/gvisor | Correctly distinguish between seekable and non-seekable host fds.
Check whether an fd is seekable by calling the seek syscall and
examining the return value, instead of checking the file type,
which is inaccurate.
PiperOrigin-RevId: 305361593 |
259,853 | 07.04.2020 16:44:43 | 25,200 | acf0259255bae190759e39fbff3bac6c94122734 | Don't map the 0 uid into a sandbox user namespace
Starting with go1.13, we can specify ambient capabilities when we execute a new
process with os/exe.Cmd. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -588,44 +588,31 @@ func (s *Sandbox) createSandboxProcess(conf *boot.Config, args *Args, startSyncF\nnss = append(nss, specs.LinuxNamespace{Type: specs.UserNamespace})\ncmd.Args = a... | Go | Apache License 2.0 | google/gvisor | Don't map the 0 uid into a sandbox user namespace
Starting with go1.13, we can specify ambient capabilities when we execute a new
process with os/exe.Cmd.
PiperOrigin-RevId: 305366706 |
259,992 | 07.04.2020 18:26:34 | 25,200 | 5a1324625f1d0d9ea2d4874f9d6d1008ec12f45e | Make unlink tests pass with goferfs
Required directory checks were being skipped when there was
no child cached. Now the code always loads the child file
before unlinking it.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -437,14 +437,19 @@ func (fs *filesystem) unlinkAt(ctx context.Context, rp *vfs.ResolvingPath, dir b\nflags := uint32(0)\nif dir {\nif child != nil && !chil... | Go | Apache License 2.0 | google/gvisor | Make unlink tests pass with goferfs
Required directory checks were being skipped when there was
no child cached. Now the code always loads the child file
before unlinking it.
Updates #1198
PiperOrigin-RevId: 305382323 |
259,884 | 07.04.2020 18:38:13 | 25,200 | 5802051b3d60a802713fabbd805614f22c9291ea | Update TODO to
Move TODO to so that proper synchronization of operations is handled
when we create the urpc client.
Issue
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -1077,9 +1077,9 @@ func (c *Container) adjustGoferOOMScoreAdj() error {\n// oom_score_adj is set to the lowest oom_score_adj among the containers\n// running in the sandbox.... | Go | Apache License 2.0 | google/gvisor | Update TODO to #238
Move TODO to #238 so that proper synchronization of operations is handled
when we create the urpc client.
Issue #238
Fixes #512
PiperOrigin-RevId: 305383924 |
259,974 | 04.03.2020 05:44:46 | 0 | b574c715a799e476ac788e5f5b2c68f1a00b3538 | Move pagetables.limitPCID to arch-specific file.
X86 provide 12 bits for PCID while arm64 support
8/16 bits ASID. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/pagetables/BUILD",
"new_path": "pkg/sentry/platform/ring0/pagetables/BUILD",
"diff": "@@ -81,6 +81,9 @@ go_library(\n\"pagetables_arm64.go\",\n\"pagetables_x86.go\",\n\"pcids.go\",\n+ \"pcids_aarch64.go\",\n+ \"pcids_aarch64.s\",\n+ \... | Go | Apache License 2.0 | google/gvisor | Move pagetables.limitPCID to arch-specific file.
X86 provide 12 bits for PCID while arm64 support
8/16 bits ASID.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I0bd9236e44e6b6c4c88eb6e9adc5ac27b918bf6c |
259,884 | 07.04.2020 18:49:52 | 25,200 | 56054fc1fb0b92cb985f96467f9059e202d8095c | Add friendlier messages for frequently encountered errors.
Issue
Issue | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -824,7 +824,20 @@ func (c *containerMounter) mountSubmount(ctx context.Context, conf *Config, mns\ninode, err := filesystem.Mount(ctx, mountDevice(m), mf, strings.Join(opts, \",\"), nil)\nif err !=... | Go | Apache License 2.0 | google/gvisor | Add friendlier messages for frequently encountered errors.
Issue #2270
Issue #1765
PiperOrigin-RevId: 305385436 |
259,853 | 08.04.2020 00:25:16 | 25,200 | c7d841ac6e0be2aaacd6a3a81786508be797f667 | tests: Specify NoRandomSave for PortReuse tests
SO_REUSEPORT is not properly restored: | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -1157,7 +1157,7 @@ TEST_P(SocketInetReusePortTest, TcpPortReuseMultiThread_NoRandomSave) {\nEquivalentWithin((kConnectAttempts / kThreadCount),... | Go | Apache License 2.0 | google/gvisor | tests: Specify NoRandomSave for PortReuse tests
SO_REUSEPORT is not properly restored:
https://github.com/google/gvisor/issues/873
PiperOrigin-RevId: 305422775 |
259,972 | 08.04.2020 06:41:52 | 25,200 | 71c7e24e5cb8641f4cb98b5fc848ae2033b29eac | Return all packets when Expect fails. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -21,6 +21,7 @@ import (\n\"fmt\"\n\"math/rand\"\n\"net\"\n+ \"strings\"\n\"testing\"\n\"time\"\n@@ -233,19 +234,23 @@ func (conn *TCPIPv4) RecvFr... | Go | Apache License 2.0 | google/gvisor | Return all packets when Expect fails.
PiperOrigin-RevId: 305466309 |
259,858 | 25.03.2020 16:57:37 | 25,200 | f888b9ce83c202bb77c1e29c3ee60cc485906536 | Fix unused result errors.
This fixes a bug in the proc net directory.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/task_net.go",
"new_path": "pkg/sentry/fsimpl/proc/task_net.go",
"diff": "@@ -688,9 +688,9 @@ func (d *netSnmpData) Generate(ctx context.Context, buf *bytes.Buffer) error {\nif line.prefix == \"Tcp\" {\ntcp := stat.(*inet.StatSNMPTCP)\n//... | Go | Apache License 2.0 | google/gvisor | Fix unused result errors.
This fixes a bug in the proc net directory.
Updates #2243 |
259,858 | 25.03.2020 17:20:16 | 25,200 | 867eeb18d8c65019fb755194d5bdf768837f07a8 | Remove lostcancel warnings.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/arp_test.go",
"new_path": "pkg/tcpip/network/arp/arp_test.go",
"diff": "@@ -138,7 +138,8 @@ func TestDirectRequest(t *testing.T) {\n// Sleep tests are gross, but this will only potentially flake\n// if there's a bug. If there is no bug th... | Go | Apache License 2.0 | google/gvisor | Remove lostcancel warnings.
Updates #2243 |
259,992 | 08.04.2020 13:33:44 | 25,200 | b30130567d81157e39b692e0116f86015f0bcc71 | Enable SubprocessExited and SubprocessZombie for gVisor
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -57,6 +57,16 @@ func getTaskMM(t *kernel.Task) (*mm.MemoryManager, error) {\nreturn m, nil\n}\n+func checkTaskState(t *kernel.Task) error {\n+ switch t.ExitState() {\n+ case ker... | Go | Apache License 2.0 | google/gvisor | Enable SubprocessExited and SubprocessZombie for gVisor
Updates #164
PiperOrigin-RevId: 305544029 |
260,003 | 08.04.2020 13:46:51 | 25,200 | 2907e6da5e9fc7eeda51644db7bec4d15691b384 | file test: Remove FIXME about FIFO. It is already tested in mknod test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/file_base.h",
"new_path": "test/syscalls/linux/file_base.h",
"diff": "@@ -52,17 +52,6 @@ class FileTest : public ::testing::Test {\ntest_file_fd_ = ASSERT_NO_ERRNO_AND_VALUE(\nOpen(test_file_name_, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR));\n- ... | Go | Apache License 2.0 | google/gvisor | file test: Remove FIXME about FIFO. It is already tested in mknod test.
PiperOrigin-RevId: 305546584 |
259,860 | 08.04.2020 14:38:09 | 25,200 | 357f136e42de81b033b65b7f39a4a555275a17e3 | Handle utimes correctly for shared gofer filesystems.
Determine system time from within the sentry rather than relying on the remote
filesystem to prevent inconsistencies.
Resolve related TODOs; the time discrepancies in question don't exist anymore. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/util.go",
"new_path": "pkg/sentry/fs/gofer/util.go",
"diff": "@@ -20,17 +20,29 @@ import (\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/p9\"\n\"gvisor.dev/gvisor/pkg/sentry/fs\"\n+ ktime \"gvisor.dev/gvisor/pkg/sentry/kernel/... | Go | Apache License 2.0 | google/gvisor | Handle utimes correctly for shared gofer filesystems.
Determine system time from within the sentry rather than relying on the remote
filesystem to prevent inconsistencies.
Resolve related TODOs; the time discrepancies in question don't exist anymore.
PiperOrigin-RevId: 305557099 |
259,860 | 08.04.2020 17:32:57 | 25,200 | 981a587476e11e49cf49edb31705d8727b0db556 | Remove InodeOperations FIXMEs that will be obsoleted by VFS2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/inode.go",
"new_path": "pkg/sentry/fs/gofer/inode.go",
"diff": "@@ -710,13 +710,10 @@ func init() {\n}\n// AddLink implements InodeOperations.AddLink, but is currently a noop.\n-// FIXME(b/63117438): Remove this from InodeOperations altoget... | Go | Apache License 2.0 | google/gvisor | Remove InodeOperations FIXMEs that will be obsoleted by VFS2.
PiperOrigin-RevId: 305588941 |
259,885 | 08.04.2020 18:40:46 | 25,200 | 0f75f7273d8c4ace73d93b6b00f81d53a5cf76ea | Don't call platform.AddressSpace.MapFile with no permissions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/address_space.go",
"new_path": "pkg/sentry/mm/address_space.go",
"diff": "@@ -201,9 +201,11 @@ func (mm *MemoryManager) mapASLocked(pseg pmaIterator, ar usermem.AddrRange, pre\nif pma.needCOW {\nperms.Write = false\n}\n+ if perms.Any() { // MapFi... | Go | Apache License 2.0 | google/gvisor | Don't call platform.AddressSpace.MapFile with no permissions.
PiperOrigin-RevId: 305598136 |
259,885 | 08.04.2020 19:40:15 | 25,200 | 7297fd7238e17803e073fb5a5ef85edf992bdf6b | Bump proc_test's kRSSTolerance to 10MB. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -994,7 +994,7 @@ constexpr uint64_t kMappingSize = 100 << 20;\n// Tolerance on RSS comparisons to account for background thread mappings,\n// reclaimed pages, newly faulted pa... | Go | Apache License 2.0 | google/gvisor | Bump proc_test's kRSSTolerance to 10MB.
PiperOrigin-RevId: 305604557 |
259,853 | 08.04.2020 23:02:09 | 25,200 | a10389e783aab5f530641394ef44c8a1dede9372 | splice: cap splice calls to MAX_RW_COUNT
The Linux does the same.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"new_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"diff": "@@ -29,6 +29,10 @@ func doSplice(t *kernel.Task, outFile, inFile *fs.File, opts fs.SpliceOpts, nonB\nreturn 0, syserror.EINVAL\n}\n+ if opts.Length > int6... | Go | Apache License 2.0 | google/gvisor | splice: cap splice calls to MAX_RW_COUNT
The Linux does the same.
Reported-by: syzbot+e81716e8956e92e9d56b@syzkaller.appspotmail.com
PiperOrigin-RevId: 305625439 |
259,853 | 09.04.2020 01:11:20 | 25,200 | 1ebfdcc86c1b066a044a64e1f34b679f327a1f36 | kokoro: fix handling of apt-get errors
When a command is called as if expression, its error
code can be get only in this if block.
For example, the next script prints 0:
if ( false ); then
true
fi
echo $? | [
{
"change_type": "MODIFY",
"old_path": "scripts/common.sh",
"new_path": "scripts/common.sh",
"diff": "@@ -89,12 +89,20 @@ function install_runsc() {\n# be correct, otherwise this may result in a loop that spins until time out.\nfunction apt_install() {\nwhile true; do\n- if (sudo apt-get update && s... | Go | Apache License 2.0 | google/gvisor | kokoro: fix handling of apt-get errors
When a command is called as if expression, its error
code can be get only in this if block.
For example, the next script prints 0:
if ( false ); then
true
fi
echo $?
PiperOrigin-RevId: 305638629 |
259,860 | 09.04.2020 11:15:42 | 25,200 | 2b4687a46bffc0999f1d5730397c13daba6ae4a9 | Handle os.LinkError in p9/handlers.go. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/handlers.go",
"new_path": "pkg/p9/handlers.go",
"diff": "@@ -48,6 +48,8 @@ func ExtractErrno(err error) syscall.Errno {\nreturn ExtractErrno(e.Err)\ncase *os.SyscallError:\nreturn ExtractErrno(e.Err)\n+ case *os.LinkError:\n+ return ExtractErrno(e.Err)\... | Go | Apache License 2.0 | google/gvisor | Handle os.LinkError in p9/handlers.go.
PiperOrigin-RevId: 305721329 |
260,003 | 09.04.2020 13:33:18 | 25,200 | 64c2b490671852aaa024a4bb4757eef309fadf18 | Dedup netlink utility functions in tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -138,7 +138,6 @@ cc_library(\nhdrs = [\"socket_netlink_route_util.h\"],\ndeps = [\n\":socket_netlink_util\",\n- \"@com_google_absl//absl/types:optional\",\n],\n)\n@@ -2804,13 +280... | Go | Apache License 2.0 | google/gvisor | Dedup netlink utility functions in tests.
PiperOrigin-RevId: 305749697 |
260,003 | 09.04.2020 16:21:02 | 25,200 | ace90f823cf33d1c1180dcd0d2061c702270a0d6 | Make some functions in IfAddrHelper const. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/ip_socket_test_util.cc",
"new_path": "test/syscalls/linux/ip_socket_test_util.cc",
"diff": "@@ -177,17 +177,17 @@ SocketKind IPv6TCPUnboundSocket(int type) {\nPosixError IfAddrHelper::Load() {\nRelease();\nRETURN_ERROR_IF_SYSCALL_FAIL(getif... | Go | Apache License 2.0 | google/gvisor | Make some functions in IfAddrHelper const.
PiperOrigin-RevId: 305782490 |
259,992 | 09.04.2020 16:40:12 | 25,200 | 9f87502b4619b60779ce19c41ea0e6bd6582e8e4 | Remove TODOs from Async IO
Block and drain requests in io_destroy(2).
Note the reason to create read-only mapping. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/aio_context.go",
"new_path": "pkg/sentry/mm/aio_context.go",
"diff": "@@ -59,25 +59,27 @@ func (a *aioManager) newAIOContext(events uint32, id uint64) bool {\n}\na.contexts[id] = &AIOContext{\n- done: make(chan struct{}, 1),\n+ requestReady: make... | Go | Apache License 2.0 | google/gvisor | Remove TODOs from Async IO
Block and drain requests in io_destroy(2).
Note the reason to create read-only mapping.
PiperOrigin-RevId: 305786312 |
259,992 | 09.04.2020 17:19:08 | 25,200 | 2a28e3e9c3463cf68cfa639425cfdcc298ad357a | Don't unconditionally set --panic-signal
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -402,8 +402,6 @@ func (s *Sandbox) createSandboxProcess(conf *boot.Config, args *Args, startSyncF\nnextFD++\n}\n- cmd.Args = append(cmd.Args, \"--panic-signal=\"+strconv.Itoa(int(sy... | Go | Apache License 2.0 | google/gvisor | Don't unconditionally set --panic-signal
Closes #2393
PiperOrigin-RevId: 305793027 |
259,885 | 09.04.2020 17:29:43 | 25,200 | 257225c34b81ff0d0b5ce8ae333f5905f9e86cce | Downgrade VFS1-specific FIXME to a NOTE. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -312,9 +312,9 @@ func (d *Dirent) SyncAll(ctx context.Context) {\n// There is nothing to sync for a read-only filesystem.\nif !d.Inode.MountSource.Flags.ReadOnly {\n- // FIXME(b/34856... | Go | Apache License 2.0 | google/gvisor | Downgrade VFS1-specific FIXME to a NOTE.
PiperOrigin-RevId: 305794509 |
260,003 | 09.04.2020 17:59:30 | 25,200 | c9195349c9ac24ccb538e92b308225dfa4184c42 | Replace type assertion with TaskFromContext.
This should fix panic at aio callback. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -535,7 +535,7 @@ func (s *SocketOperations) Write(ctx context.Context, _ *fs.File, src usermem.IO\n}\nif resCh != nil {\n- t := ctx.(*kernel.Task)\n+ t :... | Go | Apache License 2.0 | google/gvisor | Replace type assertion with TaskFromContext.
This should fix panic at aio callback.
PiperOrigin-RevId: 305798549 |
259,974 | 17.03.2020 06:59:54 | 0 | 35e6b6bf1aeb909a12fb80cc99d5695408a9eaa5 | Enable syscall fork_test on arm64. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/fork.cc",
"new_path": "test/syscalls/linux/fork.cc",
"diff": "@@ -431,7 +431,6 @@ TEST(CloneTest, NewUserNamespacePermitsAllOtherNamespaces) {\n<< \"status = \" << status;\n}\n-#ifdef __x86_64__\n// Clone with CLONE_SETTLS and a non-canonic... | Go | Apache License 2.0 | google/gvisor | Enable syscall fork_test on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I033692bcf4f8139df29e369a12b150d10fccbe32 |
259,974 | 11.03.2020 03:21:34 | 0 | 7aa5caae71c29b0be9047a7c156a9daaa435ebb8 | Enable syscall ptrace test on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/arch.go",
"new_path": "pkg/sentry/arch/arch.go",
"diff": "@@ -88,6 +88,9 @@ type Context interface {\n// SyscallNo returns the syscall number.\nSyscallNo() uintptr\n+ // SyscallSaveOrig save orignal register value.\n+ SyscallSaveOrig()\n+\n// S... | Go | Apache License 2.0 | google/gvisor | Enable syscall ptrace test on arm64.
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I5bb8fa7d580d173b1438d6465e1adb442216c8fa |
259,853 | 10.04.2020 07:13:16 | 25,200 | 935007937cee1e2867cc4fc5c00b7f370864e241 | test: remove 1s delay after non-blocking socket pair accept
It was added in cl/201419897 to deflake
socket_ip_tcp_loopback_non_blocking_test_gvisor.
It seems we don't need this hack, because the origin issue isn't
reproducible without this hack. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_test_util.cc",
"new_path": "test/syscalls/linux/socket_test_util.cc",
"diff": "@@ -364,11 +364,6 @@ CreateTCPConnectAcceptSocketPair(int bound, int connected, int type,\n}\nMaybeSave(); // Successful accept.\n- // FIXME(b/110484944)\... | Go | Apache License 2.0 | google/gvisor | test: remove 1s delay after non-blocking socket pair accept
It was added in cl/201419897 to deflake
socket_ip_tcp_loopback_non_blocking_test_gvisor.
It seems we don't need this hack, because the origin issue isn't
reproducible without this hack.
PiperOrigin-RevId: 305871748 |
259,972 | 10.04.2020 08:20:56 | 25,200 | 12b00c815638a28943c23d3be6ef09b955c6149e | Test that RST is sent after ABORT in ESTABLISHED TCP state. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/BUILD",
"new_path": "test/packetimpact/tests/BUILD",
"diff": "@@ -40,6 +40,18 @@ packetimpact_go_test(\n],\n)\n+packetimpact_go_test(\n+ name = \"tcp_noaccept_close_rst\",\n+ srcs = [\"tcp_noaccept_close_rst_test.go\"],\n+ # TODO(b/1533... | Go | Apache License 2.0 | google/gvisor | Test that RST is sent after ABORT in ESTABLISHED TCP state.
PiperOrigin-RevId: 305879441 |
259,992 | 10.04.2020 11:17:59 | 25,200 | 1798d6cbee3360b09d3736069e15fd746e863bd2 | Remove TODO from kernel.Stracer
The dependency strace=>kernel grew over time. strace also depends on
task's FD table and FSContext. It could be fixed with some interfaces
the other way, but then we're trading an interface for another, and
kernel.Stracer is likely cleaner.
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/syscalls.go",
"new_path": "pkg/sentry/kernel/syscalls.go",
"diff": "@@ -209,9 +209,6 @@ type Stracer interface {\n// SyscallEnter is called on syscall entry.\n//\n// The returned private data is passed to SyscallExit.\n- //\n- // TODO(gvisor.... | Go | Apache License 2.0 | google/gvisor | Remove TODO from kernel.Stracer
The dependency strace=>kernel grew over time. strace also depends on
task's FD table and FSContext. It could be fixed with some interfaces
the other way, but then we're trading an interface for another, and
kernel.Stracer is likely cleaner.
Closes #155
PiperOrigin-RevId: 305909678 |
259,860 | 10.04.2020 11:35:38 | 25,200 | 8bb8027d55d59c9c08e4b7896cf688c0225a1244 | Return EIO from p9 if sending/receiving fails.
Continues the modifications in cl/272963663. This prevents non-syscall errors
from being propogated to kernel/task_syscall.go:ExtractErrno(), which causes a
sentry panic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/client.go",
"new_path": "pkg/p9/client.go",
"diff": "@@ -174,7 +174,7 @@ func NewClient(socket *unet.Socket, messageSize uint32, version string) (*Client\n// our sendRecv function to use that functionality. Otherwise,\n// we stick to sendRecvLegacy.\nrv... | Go | Apache License 2.0 | google/gvisor | Return EIO from p9 if sending/receiving fails.
Continues the modifications in cl/272963663. This prevents non-syscall errors
from being propogated to kernel/task_syscall.go:ExtractErrno(), which causes a
sentry panic.
PiperOrigin-RevId: 305913127 |
259,992 | 10.04.2020 15:46:16 | 25,200 | 96f914295920404e7c5c97553771e09b31f6900a | Use O_CLOEXEC when dup'ing FDs
The sentry doesn't allow execve, but it's a good defense
in-depth measure. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/inode.go",
"new_path": "pkg/sentry/fs/gofer/inode.go",
"diff": "@@ -273,7 +273,7 @@ func (i *inodeFileState) recreateReadHandles(ctx context.Context, writer *handle\n// operations on the old will see the new data. Then, make the new handle ... | Go | Apache License 2.0 | google/gvisor | Use O_CLOEXEC when dup'ing FDs
The sentry doesn't allow execve, but it's a good defense
in-depth measure.
PiperOrigin-RevId: 305958737 |
259,884 | 10.04.2020 20:31:07 | 25,200 | daf3322498b698518a3c8545ad05f790deb3848c | Add logging message for noNewPrivileges OCI option.
noNewPrivileges is ignored if set to false since gVisor assumes that
PR_SET_NO_NEW_PRIVS is always enabled. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_identity.go",
"new_path": "pkg/sentry/kernel/task_identity.go",
"diff": "@@ -455,7 +455,7 @@ func (t *Task) SetKeepCaps(k bool) {\nt.creds.Store(creds)\n}\n-// updateCredsForExec updates t.creds to reflect an execve().\n+// updateCredsFo... | Go | Apache License 2.0 | google/gvisor | Add logging message for noNewPrivileges OCI option.
noNewPrivileges is ignored if set to false since gVisor assumes that
PR_SET_NO_NEW_PRIVS is always enabled.
PiperOrigin-RevId: 305991947 |
259,972 | 11.04.2020 06:45:15 | 25,200 | 20203494680f869669ab5318b36e9470ad4b3e7b | Improve error messages when parsing headers.
Tested:
Looked at output of failing tests. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -213,7 +213,7 @@ func (conn *TCPIPv4) RecvFrame(timeout time.Duration) Layers {\n}\nlayers, err := ParseEther(b)\nif err != nil {\n- conn.t.Logf(... | Go | Apache License 2.0 | google/gvisor | Improve error messages when parsing headers.
Tested:
Looked at output of failing tests.
PiperOrigin-RevId: 306031407 |
259,972 | 12.04.2020 18:32:18 | 25,200 | ef0b5584e5389cc392e03d20976a15974f277251 | Refactor parser to use a for loop instead of recursion.
This makes the code shorter and less repetitive.
TESTED:
All unit tests still pass. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -211,11 +211,7 @@ func (conn *TCPIPv4) RecvFrame(timeout time.Duration) Layers {\nif b == nil {\nbreak\n}\n- layers, err := ParseEther(b)\n- if e... | Go | Apache License 2.0 | google/gvisor | Refactor parser to use a for loop instead of recursion.
This makes the code shorter and less repetitive.
TESTED:
All unit tests still pass.
PiperOrigin-RevId: 306161475 |
259,885 | 13.04.2020 10:51:08 | 25,200 | 445c366581637b64336a18d69519faee5a444f5d | Fix VFS2 getdents()/getdents64() alignment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/getdents.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/getdents.go",
"diff": "@@ -97,6 +97,7 @@ func (cb *getdentsCallback) Handle(dirent vfs.Dirent) error {\n// char d_name[]; /* Filename (null-terminated) */\n// };\nsize := ... | Go | Apache License 2.0 | google/gvisor | Fix VFS2 getdents()/getdents64() alignment.
PiperOrigin-RevId: 306263615 |
259,945 | 13.04.2020 11:01:02 | 25,200 | 6a4d17a31dc209afbbca66e871a7c6dc299c167b | Remove obsolete TODOs for b/38173783
The comments in the ticket indicate that this behavior
is fine and that the ticket should be closed, so we shouldn't
need pointers to the ticket. | [
{
"change_type": "MODIFY",
"old_path": "pkg/context/context.go",
"new_path": "pkg/context/context.go",
"diff": "@@ -127,10 +127,6 @@ func (logContext) Value(key interface{}) interface{} {\nvar bgContext = &logContext{Logger: log.Log()}\n// Background returns an empty context using the default logger... | Go | Apache License 2.0 | google/gvisor | Remove obsolete TODOs for b/38173783
The comments in the ticket indicate that this behavior
is fine and that the ticket should be closed, so we shouldn't
need pointers to the ticket.
PiperOrigin-RevId: 306266071 |
259,858 | 13.04.2020 12:47:32 | 25,200 | aa75a3da5188d8f62d00fc6590708ca4886526b4 | Fix build.sh and VM targets. | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/runner/__init__.py",
"new_path": "benchmarks/runner/__init__.py",
"diff": "@@ -19,6 +19,7 @@ import logging\nimport pkgutil\nimport pydoc\nimport re\n+import subprocess\nimport sys\nimport types\nfrom typing import List\n@@ -125,9 +126,8 @@ def run_... | Go | Apache License 2.0 | google/gvisor | Fix build.sh and VM targets.
PiperOrigin-RevId: 306289643 |
259,885 | 14.04.2020 13:36:36 | 25,200 | 52b4b19249adfeba65fe6f0ef27111f2ed887888 | Pass O_LARGEFILE in syscalls/linux/vfs2.openat.
Needed for PipeTest_Flags: files opened by open() and openat() get O_LARGEFILE
(on architectures with 64-bit off_t), but not FDs created by other syscalls
such as pipe().
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/filesystem.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/filesystem.go",
"diff": "@@ -172,7 +172,7 @@ func openat(t *kernel.Task, dirfd int32, pathAddr usermem.Addr, flags uint32, mo\ndefer tpop.Release()\nfile, err := t.Kerne... | Go | Apache License 2.0 | google/gvisor | Pass O_LARGEFILE in syscalls/linux/vfs2.openat.
Needed for PipeTest_Flags: files opened by open() and openat() get O_LARGEFILE
(on architectures with 64-bit off_t), but not FDs created by other syscalls
such as pipe().
Updates #1035
PiperOrigin-RevId: 306504788 |
260,023 | 15.04.2020 01:10:38 | 25,200 | 9c918340e4e6126cca1dfedbf28fec8c8f836e1a | Reset pending connections on listener close
Attempt to redeliver TCP segments that are enqueued into a closing
TCP endpoint. This was being done for Established endpoints but not
for those that are listening or performing connection handshake.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -330,6 +330,9 @@ func (l *listenContext) createEndpointAndPerformHandshake(s *segment, opts *head\nif l.listenEP != nil {\nl.removePendingEndpoint(ep)\n}\n+\n+ ep.... | Go | Apache License 2.0 | google/gvisor | Reset pending connections on listener close
Attempt to redeliver TCP segments that are enqueued into a closing
TCP endpoint. This was being done for Established endpoints but not
for those that are listening or performing connection handshake.
Fixes #2417
PiperOrigin-RevId: 306598155 |
260,003 | 15.04.2020 14:30:20 | 25,200 | ea5b8e9633cd2731bb5656dea523beaf3d643472 | Use if_nametoindex to get interface index.
Removed the TODO to use netlink. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/ip_socket_test_util.cc",
"new_path": "test/syscalls/linux/ip_socket_test_util.cc",
"diff": "#include <net/if.h>\n#include <netinet/in.h>\n-#include <sys/ioctl.h>\n#include <sys/socket.h>\n#include <cstring>\n@@ -35,12 +34,11 @@ uint16_t Por... | Go | Apache License 2.0 | google/gvisor | Use if_nametoindex to get interface index.
Removed the TODO to use netlink.
PiperOrigin-RevId: 306721468 |
259,972 | 15.04.2020 14:57:56 | 25,200 | 3d3bf9603d9a933b4bf19c38190c583894b75d66 | Use hex.Dump for Layer.String() of byte slices. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/layers.go",
"new_path": "test/packetimpact/testbench/layers.go",
"diff": "package testbench\nimport (\n+ \"encoding/hex\"\n\"fmt\"\n\"reflect\"\n\"strings\"\n@@ -133,7 +134,12 @@ func stringLayer(l Layer) string {\nif v.IsNil() {\nc... | Go | Apache License 2.0 | google/gvisor | Use hex.Dump for Layer.String() of byte slices.
PiperOrigin-RevId: 306726587 |
259,972 | 15.04.2020 19:36:03 | 25,200 | 09c7e3f6e497f4ae267772e7357763ac7c18659f | Add tests for segments outside the receive window.
The tests are based on RFC 793 page 69.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -577,13 +577,27 @@ func (conn *TCPIPv4) Expect(tcp TCP, timeout time.Duration) (*TCP, error) {\nreturn gotTCP, err\n}\n-// RemoteSeqNum returns t... | Go | Apache License 2.0 | google/gvisor | Add tests for segments outside the receive window.
The tests are based on RFC 793 page 69.
Updates #1607
PiperOrigin-RevId: 306768847 |
259,992 | 16.04.2020 11:48:14 | 25,200 | 28399818fc1e5d294cc93ddd4a1ac7e31c375fbf | Make ExtractErrno a function | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_run.go",
"new_path": "pkg/sentry/kernel/task_run.go",
"diff": "@@ -353,7 +353,7 @@ func (app *runApp) execute(t *Task) taskRunState {\ndefault:\n// What happened? Can't continue.\nt.Warningf(\"Unexpected SwitchToApp error: %v\", err)\n- ... | Go | Apache License 2.0 | google/gvisor | Make ExtractErrno a function
PiperOrigin-RevId: 306891171 |
259,992 | 16.04.2020 13:15:47 | 25,200 | 5a8ee1beee364559bac37376949de1ea01d00ae2 | Preserve log FD after execve | [
{
"change_type": "MODIFY",
"old_path": "runsc/main.go",
"new_path": "runsc/main.go",
"diff": "@@ -291,7 +291,7 @@ func main() {\n// want with them. Since Docker and Containerd both eat boot's stderr, we\n// dup our stderr to the provided log FD so that panics will appear in the\n// logs, rather than... | Go | Apache License 2.0 | google/gvisor | Preserve log FD after execve
PiperOrigin-RevId: 306908296 |
259,972 | 16.04.2020 15:14:44 | 25,200 | 75e864fc7529bf71484ecabbb2ce2264e96399cf | Use multierr in packetimpact Connection.Close() | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -400,6 +400,20 @@ go_repository(\nversion = \"v0.20.0\",\n)\n+go_repository(\n+ name = \"org_uber_go_atomic\",\n+ importpath = \"go.uber.org/atomic\",\n+ version = \"v1.6.0\",\n+ sum = \"h1:Ezj3JGmsOnG1MoRWQkPBs... | Go | Apache License 2.0 | google/gvisor | Use multierr in packetimpact Connection.Close()
PiperOrigin-RevId: 306930652 |
260,004 | 16.04.2020 17:26:12 | 25,200 | b33c3bb4a73974bbae4274da5100a3cd3f5deef8 | Return detailed errors when iterating NDP options
Test: header_test.TestNDPOptionsIterCheck | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/BUILD",
"new_path": "pkg/tcpip/header/BUILD",
"diff": "@@ -21,6 +21,7 @@ go_library(\n\"ndp_options.go\",\n\"ndp_router_advert.go\",\n\"ndp_router_solicit.go\",\n+ \"ndpoptionidentifier_string.go\",\n\"tcp.go\",\n\"udp.go\",\n],\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Return detailed errors when iterating NDP options
Test: header_test.TestNDPOptionsIterCheck
PiperOrigin-RevId: 306953867 |
260,023 | 16.04.2020 17:57:06 | 25,200 | 3b05f576d73be644daa17203d9ed64481c45b4a8 | Reset pending connections on listener shutdown.
When the listening socket is read shutdown, we need to reset all pending
and incoming connections. Ensure that the endpoint is not cleaned up
from the demuxer and subsequent bind to same port does not go through. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -26,7 +26,6 @@ import (\n\"gvisor.dev/gvisor/pkg/sleep\"\n\"gvisor.dev/gvisor/pkg/sync\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n- \"gvisor.dev/gvisor/pkg/tcpip/buffer\"... | Go | Apache License 2.0 | google/gvisor | Reset pending connections on listener shutdown.
When the listening socket is read shutdown, we need to reset all pending
and incoming connections. Ensure that the endpoint is not cleaned up
from the demuxer and subsequent bind to same port does not go through.
PiperOrigin-RevId: 306958038 |
260,004 | 16.04.2020 18:32:15 | 25,200 | f367cf8e67818b0ca3be6fb15b8be481635c2575 | Drop invalid NDP NA messages
Better validate NDP NAs options before updating the link address cache.
Test: stack_test.TestNeighorAdvertisementWithTargetLinkLayerOption | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "@@ -301,40 +301,38 @@ func (e *endpoint) handleICMP(r *stack.Route, netHeader buffer.View, pkt stack.P\ntargetAddr := na.TargetAddress()\nstack := r.Stack()\n- rxNICID := r... | Go | Apache License 2.0 | google/gvisor | Drop invalid NDP NA messages
Better validate NDP NAs options before updating the link address cache.
Test: stack_test.TestNeighorAdvertisementWithTargetLinkLayerOption
PiperOrigin-RevId: 306962924 |
259,885 | 16.04.2020 19:26:02 | 25,200 | f03996c5e9803934226e4b3a10827501cb936ab9 | Implement pipe(2) and pipe2(2) for VFS2.
Updates | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/fsimpl/pipefs/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\")\n+\n+licenses([\"notice\"])\n+\n+go_library(\n+ name = \"pipefs\",\n+ srcs = [\"pipefs.go\"],\n+ visibility = [\"//pkg/sentry:internal\"],\n+ deps = [\n+ \"//p... | Go | Apache License 2.0 | google/gvisor | Implement pipe(2) and pipe2(2) for VFS2.
Updates #1035
PiperOrigin-RevId: 306968644 |
260,003 | 17.04.2020 10:33:54 | 25,200 | 4a818d64378f16f3738ba51c7804cff90f753b1d | proc net test: Annotate disable-save test with NoRandomSave. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc_net.cc",
"new_path": "test/syscalls/linux/proc_net.cc",
"diff": "@@ -353,7 +353,7 @@ TEST(ProcNetSnmp, UdpNoPorts_NoRandomSave) {\nEXPECT_EQ(oldNoPorts, newNoPorts - 1);\n}\n-TEST(ProcNetSnmp, UdpIn) {\n+TEST(ProcNetSnmp, UdpIn_NoRando... | Go | Apache License 2.0 | google/gvisor | proc net test: Annotate disable-save test with NoRandomSave.
PiperOrigin-RevId: 307069884 |
259,975 | 17.04.2020 10:38:04 | 25,200 | 12bde95635ac266aab8087b4705372bb177638f3 | Get /bin/true to run on VFS2
Included:
loader_test.go RunTest and TestStartSignal VFS2
container_test.go TestAppExitStatus on VFS2
experimental flag added to runsc to turn on VFS2
Note: shared mounts are not yet supported. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/syscalls.go",
"new_path": "pkg/sentry/kernel/syscalls.go",
"diff": "@@ -326,6 +326,13 @@ func RegisterSyscallTable(s *SyscallTable) {\nallSyscallTables = append(allSyscallTables, s)\n}\n+// FlushSyscallTablesTestOnly flushes the syscall table... | Go | Apache License 2.0 | google/gvisor | Get /bin/true to run on VFS2
Included:
- loader_test.go RunTest and TestStartSignal VFS2
- container_test.go TestAppExitStatus on VFS2
- experimental flag added to runsc to turn on VFS2
Note: shared mounts are not yet supported.
PiperOrigin-RevId: 307070753 |
259,992 | 17.04.2020 13:27:35 | 25,200 | a80cd4302337f1c3a807e127f5a6edc2f014f431 | Add test name to boot and gofer log files
This is to make easier to find corresponding logs in
case test fails. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/capability_test.go",
"new_path": "runsc/cmd/capability_test.go",
"diff": "@@ -85,7 +85,7 @@ func TestCapabilities(t *testing.T) {\nInheritable: caps,\n}\n- conf := testutil.TestConfig()\n+ conf := testutil.TestConfig(t)\n// Use --network=host to make... | Go | Apache License 2.0 | google/gvisor | Add test name to boot and gofer log files
This is to make easier to find corresponding logs in
case test fails.
PiperOrigin-RevId: 307104283 |
259,858 | 17.04.2020 22:18:36 | 25,200 | 9a233c94f1bd54c7c3c11f7166a09e2eacd179c5 | Fix watchdog skipStack: the meaning was reversed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -319,8 +319,8 @@ func (w *Watchdog) report(offenders map[*kernel.Task]*offender, newTaskFound boo\n// Dump stack only if a new task is detected or if it sometime has\n... | Go | Apache License 2.0 | google/gvisor | Fix watchdog skipStack: the meaning was reversed.
PiperOrigin-RevId: 307166317 |
259,972 | 19.04.2020 20:47:55 | 25,200 | 08b2fd9bc2a963ea15821b782cf6d80c15dbdf42 | Convert tcp_user_timeout test from packetdrill to packetimpact. | [
{
"change_type": "MODIFY",
"old_path": "test/packetdrill/BUILD",
"new_path": "test/packetdrill/BUILD",
"diff": "-load(\"defs.bzl\", \"packetdrill_linux_test\", \"packetdrill_netstack_test\", \"packetdrill_test\")\n+load(\"defs.bzl\", \"packetdrill_test\")\npackage(licenses = [\"notice\"])\n@@ -17,16... | Go | Apache License 2.0 | google/gvisor | Convert tcp_user_timeout test from packetdrill to packetimpact.
PiperOrigin-RevId: 307328289 |
259,972 | 19.04.2020 22:14:53 | 25,200 | db2a60be67f0e869a58eb12d253a0d7fe13ebfa3 | Don't accept segments outside the receive window
Fixed to match RFC 793 page 69.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/seqnum/seqnum.go",
"new_path": "pkg/tcpip/seqnum/seqnum.go",
"diff": "@@ -46,11 +46,6 @@ func (v Value) InWindow(first Value, size Size) bool {\nreturn v.InRange(first, first.Add(size))\n}\n-// Overlap checks if the window [a,a+b) overlaps with the w... | Go | Apache License 2.0 | google/gvisor | Don't accept segments outside the receive window
Fixed to match RFC 793 page 69.
Fixes #1607
PiperOrigin-RevId: 307334892 |
259,860 | 20.04.2020 08:50:27 | 25,200 | 1a940f2b6c834693d9f85e3b648a3be3d986129d | Resolve issue with file mode for host fds.
Instead of plumbing error through kernfs.Inode.Mode, panic if err != nil.
The errors that can result from an fstat syscall all indicate that something
is fundamentally wrong, and panicking should be acceptable. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -94,7 +94,6 @@ func ImportFD(mnt *vfs.Mount, hostFD int, isTTY bool) (*vfs.FileDescription, err\nisTTY: isTTY,\ncanMap: canMap(uint32(fileType)),\nino: fs.NextIno(),\n- ... | Go | Apache License 2.0 | google/gvisor | Resolve issue with file mode for host fds.
Instead of plumbing error through kernfs.Inode.Mode, panic if err != nil.
The errors that can result from an fstat syscall all indicate that something
is fundamentally wrong, and panicking should be acceptable.
PiperOrigin-RevId: 307406847 |
259,885 | 20.04.2020 10:09:23 | 25,200 | e72ce8cce46ed48af306df50d252853c8790924d | Change lingering uses of "memfs" in fsimpl/tmpfs to "tmpfs". | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/benchmark_test.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/benchmark_test.go",
"diff": "@@ -168,7 +168,7 @@ func BenchmarkVFS1TmpfsStat(b *testing.B) {\n}\n}\n-func BenchmarkVFS2MemfsStat(b *testing.B) {\n+func BenchmarkVFS2TmpfsStat(b *t... | Go | Apache License 2.0 | google/gvisor | Change lingering uses of "memfs" in fsimpl/tmpfs to "tmpfs".
PiperOrigin-RevId: 307422746 |
259,858 | 20.04.2020 11:08:01 | 25,200 | 9ba3086d9dfc7e9a4a957446f443786b179cd84e | Move runtime_tests.sh to align with other scripts. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/runtime_tests/go1.12.cfg",
"new_path": "kokoro/runtime_tests/go1.12.cfg",
"diff": "-build_file: \"github/github/kokoro/runtime_tests/runtime_tests.sh\"\n+build_file: \"github/github/scripts/runtime_tests.sh\"\nenv_vars {\nkey: \"RUNTIME_TEST_NAME\"\n"
... | Go | Apache License 2.0 | google/gvisor | Move runtime_tests.sh to align with other scripts.
PiperOrigin-RevId: 307435879 |
260,003 | 20.04.2020 12:57:18 | 25,200 | 470633d7e916e7956f4ebd75559f92cf12067cbf | Fix release.sh. git commands need to be run in git repo. | [
{
"change_type": "MODIFY",
"old_path": "scripts/release.sh",
"new_path": "scripts/release.sh",
"diff": "# See the License for the specific language governing permissions and\n# limitations under the License.\n-source $(dirname $0)/common.sh\n+cd $(dirname $0)/..\n+source scripts/common.sh\n# Tag a r... | Go | Apache License 2.0 | google/gvisor | Fix release.sh. git commands need to be run in git repo.
PiperOrigin-RevId: 307458938 |
259,943 | 21.04.2020 09:34:42 | 25,200 | 7c0f3bc8576addbec001095d754a756691d26df3 | Sentry metrics updates.
Sentry metrics with nanoseconds units are labeled as such, and non-cumulative
sentry metrics are supported. | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -39,16 +39,11 @@ var (\n// Uint64Metric encapsulates a uint64 that represents some kind of metric to be\n// monitored.\n//\n-// All metrics must be cumulative, meaning that their values wil... | Go | Apache License 2.0 | google/gvisor | Sentry metrics updates.
Sentry metrics with nanoseconds units are labeled as such, and non-cumulative
sentry metrics are supported.
PiperOrigin-RevId: 307621080 |
259,891 | 21.04.2020 10:56:04 | 25,200 | 639c8dd80870133f61465588e717b725417a0c41 | Restore euid upon test finish | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/uidgid.cc",
"new_path": "test/syscalls/linux/uidgid.cc",
"diff": "@@ -253,12 +253,21 @@ TEST(UidGidRootTest, Setgroups) {\nTEST(UidGidRootTest, Setuid_prlimit) {\nSKIP_IF(!ASSERT_NO_ERRNO_AND_VALUE(IsRoot()));\n- // Change our UID.\n- EXPEC... | Go | Apache License 2.0 | google/gvisor | Restore euid upon test finish
PiperOrigin-RevId: 307638329 |
259,881 | 21.04.2020 15:52:42 | 14,400 | a4711053672ae6732583f4eae54596783ec47547 | benchmarks: use absolute bazel target
bazel run :benchmarks only works from the benchmarks directory.
bazel run //benchmarks works from anywhere in the workspace.
Also fix help commands, which should be a multiline code section. | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/README.md",
"new_path": "benchmarks/README.md",
"diff": "@@ -10,7 +10,7 @@ The scripts assume the following:\n(controller) and one or more machines on which docker containers will be run\n(environment).\n* The controller machine must have bazel inst... | Go | Apache License 2.0 | google/gvisor | benchmarks: use absolute bazel target
bazel run :benchmarks only works from the benchmarks directory.
bazel run //benchmarks works from anywhere in the workspace.
Also fix help commands, which should be a multiline code section. |
259,858 | 21.04.2020 13:12:38 | 25,200 | 89822a446161f1ccb3b84d53f8528bc8b0a28053 | Move to GitHub's new issue templates.
This allows us to specify a richer configuration for the issue template, that
effectively moves a lot of the "metadata" from the template itself to the main
issue page. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".github/ISSUE_TEMPLATE/bug_report.md",
"diff": "+---\n+name: Bug report\n+about: Create a bug report to help us improve\n+title:\n+labels:\n+ - 'type: bug'\n+assignees: ''\n+---\n+\n+**Description**\n+\n+A clear description of what the bug is. I... | Go | Apache License 2.0 | google/gvisor | Move to GitHub's new issue templates.
This allows us to specify a richer configuration for the issue template, that
effectively moves a lot of the "metadata" from the template itself to the main
issue page.
PiperOrigin-RevId: 307666509 |
259,992 | 21.04.2020 16:30:26 | 25,200 | 37e01fd2ea6a0e67637975863317be9aae1b02f0 | Misc VFS2 fixes
Fix defer operation ordering in kernfs.Filesystem.AccessAt()
Add AT_NULL entry in proc/pid/auvx
Fix line padding in /proc/pid/maps
Fix linux_dirent serialization for getdents(2)
Remove file creation flags from vfs.FileDescription.statusFlags()
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -74,7 +74,6 @@ type taskDir struct {\nramfs.Dir\nt *kernel.Task\n- pidns *kernel.PIDNamespace\n}\nvar _ fs.InodeOperations = (*taskDir)(nil)\n"
},
{
"change_type": "MODI... | Go | Apache License 2.0 | google/gvisor | Misc VFS2 fixes
- Fix defer operation ordering in kernfs.Filesystem.AccessAt()
- Add AT_NULL entry in proc/pid/auvx
- Fix line padding in /proc/pid/maps
- Fix linux_dirent serialization for getdents(2)
- Remove file creation flags from vfs.FileDescription.statusFlags()
Updates #1193, #1035
PiperOrigin-RevId: 307704159 |
259,860 | 21.04.2020 17:58:43 | 25,200 | 80d0a958199cc6095e2d580e403d50ac1c3b5206 | Update gofer.filesystem.BoundEndpointAt() to allow path resolution.
Even though BoundEndpointAt is not yet implemented for gofer fs, allow path
resolution errors to be returned so that we can jump to tmpfs, where it is
implemented.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1089,9 +1089,15 @@ func (fs *filesystem) UnlinkAt(ctx context.Context, rp *vfs.ResolvingPath) error\n}\n// BoundEndpointAt implements FilesystemImpl.Bound... | Go | Apache License 2.0 | google/gvisor | Update gofer.filesystem.BoundEndpointAt() to allow path resolution.
Even though BoundEndpointAt is not yet implemented for gofer fs, allow path
resolution errors to be returned so that we can jump to tmpfs, where it is
implemented.
Updates #1476.
PiperOrigin-RevId: 307718335 |
259,860 | 21.04.2020 19:01:51 | 25,200 | 5e3596a6b8abb4c7ee8253be447b86a7b0fad7ad | Fix set/getsockopt in vfs2 override.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/linux64_override_amd64.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/linux64_override_amd64.go",
"diff": "@@ -58,8 +58,8 @@ func Override(table map[uintptr]kernel.Syscall) {\ntable[51] = syscalls.PartiallySupported(\"getsockna... | Go | Apache License 2.0 | google/gvisor | Fix set/getsockopt in vfs2 override.
Updates #1476.
PiperOrigin-RevId: 307726055 |
259,972 | 22.04.2020 07:27:34 | 25,200 | 6d23673e10bca2fb573809ff78506fc0566817dd | Add comments about deepcopy in Layer.incoming() | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -72,7 +72,8 @@ type layerState interface {\n// incoming creates an expected Layer for comparing against a received Layer.\n// Because the expecta... | Go | Apache License 2.0 | google/gvisor | Add comments about deepcopy in Layer.incoming()
PiperOrigin-RevId: 307812340 |
259,858 | 22.04.2020 12:11:38 | 25,200 | c31641150d9ee0e4b9c7cf1210c4e89a030a6bd7 | Add GitHub pull request template.
This just provides some sane reminders and ticks a box on the GitHub UI. This
change also cleans up the issue template, as there is already an automatic
link to the repository's security disclosure policy. | [
{
"change_type": "MODIFY",
"old_path": ".github/ISSUE_TEMPLATE/config.yml",
"new_path": ".github/ISSUE_TEMPLATE/config.yml",
"diff": "@@ -8,7 +8,4 @@ contact_links:\nabout: Please see our documentation for debugging tips.\n- name: gVisor User Forum\nurl: https://groups.google.com/g/gvisor-users\n- a... | Go | Apache License 2.0 | google/gvisor | Add GitHub pull request template.
This just provides some sane reminders and ticks a box on the GitHub UI. This
change also cleans up the issue template, as there is already an automatic
link to the repository's security disclosure policy.
PiperOrigin-RevId: 307868833 |
259,853 | 22.04.2020 14:15:33 | 25,200 | 37f863f62813f76b05979494c1bc2fe102629321 | tcp: handle listen after shutdown properly
Right now, sentry panics in this case:
panic: close of nil channel
goroutine 67 [running]:
pkg/tcpip/transport/tcp/tcp.(*endpoint).listen(0xc0000ce000, 0x9, 0x0)
pkg/tcpip/transport/tcp/endpoint.go:2208 +0x170
pkg/tcpip/transport/tcp/tcp.(*endpoint).Listen(0xc0000ce000, 0x9, 0xc0003a1ad0)
pkg/tcpip/transport/tcp/endpoint.go:2179 +0x50
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -2158,8 +2158,6 @@ func (e *endpoint) shutdownLocked(flags tcpip.ShutdownFlags) *tcpip.Error {\n//\n// By not removing this endpoint from the demuxer mapping, ... | Go | Apache License 2.0 | google/gvisor | tcp: handle listen after shutdown properly
Right now, sentry panics in this case:
panic: close of nil channel
goroutine 67 [running]:
pkg/tcpip/transport/tcp/tcp.(*endpoint).listen(0xc0000ce000, 0x9, 0x0)
pkg/tcpip/transport/tcp/endpoint.go:2208 +0x170
pkg/tcpip/transport/tcp/tcp.(*endpoint).Listen(0xc0000ce000, 0x9, 0xc0003a1ad0)
pkg/tcpip/transport/tcp/endpoint.go:2179 +0x50
Fixes #2468
PiperOrigin-RevId: 307896725 |
259,853 | 22.04.2020 17:48:59 | 25,200 | 0c586946ea26610b87c4ff7bda783a5a9ca11ec0 | Specify a memory file in platform.New(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -10,6 +10,7 @@ go_library(\nname = \"linux\",\nsrcs = [\n\"aio.go\",\n+ \"arch_amd64.go\",\n\"audit.go\",\n\"bpf.go\",\n\"capability.go\",\n"
},
{
"change_type": "ADD",
"old_path"... | Go | Apache License 2.0 | google/gvisor | Specify a memory file in platform.New().
PiperOrigin-RevId: 307941984 |
259,972 | 23.04.2020 08:34:42 | 25,200 | a2925a079fa04ff4c891016a0eea1818bdb2cf4b | Run failing packetimpact test and expect failure.
This will make it easier to notice if a code change causes an existing test to
pass. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/defs.bzl",
"new_path": "test/packetimpact/tests/defs.bzl",
"diff": "@@ -59,7 +59,11 @@ _packetimpact_test = rule(\nPACKETIMPACT_TAGS = [\"local\", \"manual\"]\n-def packetimpact_linux_test(name, testbench_binary, **kwargs):\n+def packet... | Go | Apache License 2.0 | google/gvisor | Run failing packetimpact test and expect failure.
This will make it easier to notice if a code change causes an existing test to
pass.
PiperOrigin-RevId: 308057978 |
259,992 | 23.04.2020 10:19:23 | 25,200 | 7d1b7daf7e89c99899fc46187bcb1f3a3bcab7fb | Disable nogo because it breaks Go 1.13
Even though the default build option is to use 1.14, we want to be
want to keep the ability to target different Go versions for testing
and in case the new release has bugs. | [
{
"change_type": "MODIFY",
"old_path": "tools/defs.bzl",
"new_path": "tools/defs.bzl",
"diff": "@@ -92,7 +92,7 @@ def go_imports(name, src, out):\ncmd = (\"$(location @org_golang_x_tools//cmd/goimports:goimports) $(SRCS) > $@\"),\n)\n-def go_library(name, srcs, deps = [], imports = [], stateify = Tr... | Go | Apache License 2.0 | google/gvisor | Disable nogo because it breaks Go 1.13
Even though the default build option is to use 1.14, we want to be
want to keep the ability to target different Go versions for testing
and in case the new release has bugs.
PiperOrigin-RevId: 308078876 |
259,885 | 23.04.2020 11:06:59 | 25,200 | e0c67014cb2200ad58cd28b12fddb3f55652a21b | Factor fsimpl/gofer.host{Preadv,Pwritev} out of fsimpl/gofer.
Also fix returning EOF when 0 bytes are read. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/BUILD",
"new_path": "pkg/sentry/fsimpl/gofer/BUILD",
"diff": "@@ -35,7 +35,6 @@ go_library(\n\"fstree.go\",\n\"gofer.go\",\n\"handle.go\",\n- \"handle_unsafe.go\",\n\"p9file.go\",\n\"pagemath.go\",\n\"regular_file.go\",\n@@ -53,6 +52,7 ... | Go | Apache License 2.0 | google/gvisor | Factor fsimpl/gofer.host{Preadv,Pwritev} out of fsimpl/gofer.
Also fix returning EOF when 0 bytes are read.
PiperOrigin-RevId: 308089875 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.