author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,858 | 23.04.2020 13:00:34 | 25,200 | 2e8c35b506654172243ea46918d27c897fca568c | Add basic GitHub labeler workflow.
This is the first automated GitHub actions workflow, and it simply applies
labels to pull request in a best-effort fashion. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".github/labeler.yml",
"diff": "+\"arch: arm\":\n+ - \"**/*_arm64.*\"\n+ - \"**/*_aarch64.*\"\n+\"arch: x86_64\":\n+ - \"**/*_amd64.*\"\n+ - \"**/*_x86.*\"\n+\"area: bazel\":\n+ - \"**/BUILD\"\n+ - \"**/*.bzl\"\n+\"area: docs\":\n+ - \"**/g3doc/*... | Go | Apache License 2.0 | google/gvisor | Add basic GitHub labeler workflow.
This is the first automated GitHub actions workflow, and it simply applies
labels to pull request in a best-effort fashion.
PiperOrigin-RevId: 308112191 |
259,972 | 23.04.2020 13:11:23 | 25,200 | cc5de905e628c5e9aca7e7a333d6dd9638719b6a | Fix test output so that filenames have the correct path.
Tested:
Intentionally introduce an error and then run:
blaze test --test_output=streamed //third_party/gvisor/test/packetimpact/tests:tcp_outside_the_window_linux_test | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/test_runner.sh",
"new_path": "test/packetimpact/tests/test_runner.sh",
"diff": "@@ -262,7 +262,10 @@ sleep 3\n# Start a packetimpact test on the test bench. The packetimpact test sends and\n# receives packets and also sends POSIX socket... | Go | Apache License 2.0 | google/gvisor | Fix test output so that filenames have the correct path.
Tested:
Intentionally introduce an error and then run:
blaze test --test_output=streamed //third_party/gvisor/test/packetimpact/tests:tcp_outside_the_window_linux_test
PiperOrigin-RevId: 308114194 |
259,985 | 23.04.2020 15:47:59 | 25,200 | 93dd47146185ec7004f514e23bad9f225f55efb1 | Enable automated marshalling for epoll events.
Ensure we use the correct architecture-specific defintion of epoll
event, and use go-marshal for serialization. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/epoll_amd64.go",
"new_path": "pkg/abi/linux/epoll_amd64.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n+// +build amd64\n+\npackage linux\n// EpollEvent is equivalent to st... | Go | Apache License 2.0 | google/gvisor | Enable automated marshalling for epoll events.
Ensure we use the correct architecture-specific defintion of epoll
event, and use go-marshal for serialization.
PiperOrigin-RevId: 308145677 |
259,985 | 23.04.2020 18:18:54 | 25,200 | f01f2132d8d3e551579cba9a1b942b4b70d83f21 | Enable automated marshalling for mempolicy syscalls. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/mm.go",
"new_path": "pkg/abi/linux/mm.go",
"diff": "@@ -90,14 +90,19 @@ const (\nMS_SYNC = 1 << 2\n)\n+// NumaPolicy is the NUMA memory policy for a memory range. See numa(7).\n+//\n+// +marshal\n+type NumaPolicy int32\n+\n// Policies for get_mem... | Go | Apache License 2.0 | google/gvisor | Enable automated marshalling for mempolicy syscalls.
PiperOrigin-RevId: 308170679 |
259,972 | 23.04.2020 18:20:43 | 25,200 | 79542417fe97a62ee86aa211ac559bcc5cac5e5e | Fix Layer merge and add unit tests
mergo was improperly merging nil and empty strings | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -188,13 +188,6 @@ go_repository(\nversion = \"v0.0.0-20171129191014-dec09d789f3d\",\n)\n-go_repository(\n- name = \"com_github_imdario_mergo\",\n- importpath = \"github.com/imdario/mergo\",\n- sum = \"h1:CGgOkSJ... | Go | Apache License 2.0 | google/gvisor | Fix Layer merge and add unit tests
mergo was improperly merging nil and empty strings
PiperOrigin-RevId: 308170862 |
259,860 | 24.04.2020 08:19:11 | 25,200 | 40a712c57cd78c51c9875ae04b5e795113c75e62 | Refactor syscall.Fstat calls in hostfs.
Just call syscall.Fstat directly each time mode/file owner are needed. This
feels more natural than using i.getPermissions(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -169,31 +169,22 @@ func fileFlagsFromHostFD(fd int) (int, error) {\n// CheckPermissions implements kernfs.Inode.\nfunc (i *inode) CheckPermissions(ctx context.Context, c... | Go | Apache License 2.0 | google/gvisor | Refactor syscall.Fstat calls in hostfs.
Just call syscall.Fstat directly each time mode/file owner are needed. This
feels more natural than using i.getPermissions().
PiperOrigin-RevId: 308257405 |
259,992 | 24.04.2020 11:43:49 | 25,200 | 2cc0fd42f462f3942230c4b33ca2825e2a28765d | Fixes for procfs
Return ENOENT for /proc/[pid]/task if task is zoombied or terminated
Allow directory to be Seek() to the end
Construct synthetic files for /proc/[pid]/ns/*
Changed GenericDirectoryFD.Init to not register with FileDescription,
otherwise other implementation cannot change behavior.
Updates #1195,1193 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devpts/devpts.go",
"new_path": "pkg/sentry/fsimpl/devpts/devpts.go",
"diff": "@@ -161,8 +161,10 @@ func (i *rootInode) masterClose(t *Terminal) {\n// Open implements kernfs.Inode.Open.\nfunc (i *rootInode) Open(rp *vfs.ResolvingPath, vfsd *vf... | Go | Apache License 2.0 | google/gvisor | Fixes for procfs
- Return ENOENT for /proc/[pid]/task if task is zoombied or terminated
- Allow directory to be Seek() to the end
- Construct synthetic files for /proc/[pid]/ns/*
- Changed GenericDirectoryFD.Init to not register with FileDescription,
otherwise other implementation cannot change behavior.
Updates #1195,1193
PiperOrigin-RevId: 308294649 |
260,004 | 24.04.2020 12:45:33 | 25,200 | 1ceee045294a6059093851645968f5a7e00a58f3 | Do not copy tcpip.CancellableTimer
A CancellableTimer's AfterFunc timer instance creates a closure over the
CancellableTimer's address. This closure makes a CancellableTimer unsafe
to copy.
No behaviour change, existing tests pass. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/ndp.go",
"new_path": "pkg/tcpip/stack/ndp.go",
"diff": "@@ -412,20 +412,33 @@ type dadState struct {\n// defaultRouterState holds data associated with a default router discovered by\n// a Router Advertisement (RA).\ntype defaultRouterState stru... | Go | Apache License 2.0 | google/gvisor | Do not copy tcpip.CancellableTimer
A CancellableTimer's AfterFunc timer instance creates a closure over the
CancellableTimer's address. This closure makes a CancellableTimer unsafe
to copy.
No behaviour change, existing tests pass.
PiperOrigin-RevId: 308306664 |
259,853 | 24.04.2020 12:51:37 | 25,200 | f87964e829f438175edcc0264adc7ce7b3d83842 | kokoro: save all files from test.outputs/
If a test fails by timeout, bazel doesn't generate outputs.zip. | [
{
"change_type": "MODIFY",
"old_path": "scripts/common_build.sh",
"new_path": "scripts/common_build.sh",
"diff": "@@ -70,8 +70,8 @@ function collect_logs() {\nfor d in `find -L \"bazel-testlogs\" -name 'shard_*_of_*' | xargs dirname | sort | uniq`; do\njunitparser merge `find $d -name test.xml` $d/t... | Go | Apache License 2.0 | google/gvisor | kokoro: save all files from test.outputs/
If a test fails by timeout, bazel doesn't generate outputs.zip.
PiperOrigin-RevId: 308307815 |
259,860 | 24.04.2020 13:45:31 | 25,200 | f13f26d17da56d585fd9857a81175bbd0be8ce60 | Port SCM Rights to VFS2.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/control.go",
"new_path": "pkg/sentry/fs/host/control.go",
"diff": "@@ -23,6 +23,8 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/socket/unix/transport\"\n)\n+// LINT.IfChange\n+\ntype scmRights struct {\nfds []int\n}\n@@ -32,8 +34,6 @@ func new... | Go | Apache License 2.0 | google/gvisor | Port SCM Rights to VFS2.
Fixes #1477.
PiperOrigin-RevId: 308317511 |
259,972 | 24.04.2020 14:41:33 | 25,200 | d5776be3fbcc9e71c449b7b41786929734ce47e2 | Improve and update packetimpact README.md | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/README.md",
"new_path": "test/packetimpact/README.md",
"diff": "@@ -30,8 +30,8 @@ There are a few ways to write networking tests for gVisor currently:\nThe right choice depends on the needs of the test.\nFeature | Go unit test | syscall test ... | Go | Apache License 2.0 | google/gvisor | Improve and update packetimpact README.md
PiperOrigin-RevId: 308328860 |
259,972 | 24.04.2020 15:02:33 | 25,200 | 3d860530a904004aea5bc95e6331b3b11cec1877 | Better error message from ExpectFrame
Display the errors as diffs between the expected and wanted frame. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -21,7 +21,6 @@ import (\n\"fmt\"\n\"math/rand\"\n\"net\"\n- \"strings\"\n\"testing\"\n\"time\"\n@@ -66,14 +65,16 @@ func pickPort() (int, uint16,... | Go | Apache License 2.0 | google/gvisor | Better error message from ExpectFrame
Display the errors as diffs between the expected and wanted frame.
PiperOrigin-RevId: 308333271 |
259,972 | 24.04.2020 15:55:11 | 25,200 | dfff265fe422499af3bbe7d58e8db35ba32304f5 | Add ICMP6 param problem test
Tested:
When run on Linux, a correct ICMPv6 response is received. On netstack, no
ICMPv6 response is received. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6.go",
"new_path": "pkg/tcpip/header/ipv6.go",
"diff": "@@ -27,7 +27,9 @@ const (\n// IPv6PayloadLenOffset is the offset of the PayloadLength field in\n// IPv6 header.\nIPv6PayloadLenOffset = 4\n- nextHdr = 6\n+ // IPv6NextHeaderOffset is t... | Go | Apache License 2.0 | google/gvisor | Add ICMP6 param problem test
Tested:
When run on Linux, a correct ICMPv6 response is received. On netstack, no
ICMPv6 response is received.
PiperOrigin-RevId: 308343113 |
259,992 | 24.04.2020 18:15:26 | 25,200 | 4af39dd1c522f7852312ecbfd3678892fc656322 | Propagate PID limit from OCI to sandbox cgroup
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -45,13 +45,13 @@ var controllers = map[string]controller{\n\"memory\": &memory{},\n\"net_cls\": &networkClass{},\n\"net_prio\": &networkPrio{},\n+ \"pids\": &pids{},\n// These controlle... | Go | Apache License 2.0 | google/gvisor | Propagate PID limit from OCI to sandbox cgroup
Closes #2489
PiperOrigin-RevId: 308362434 |
259,972 | 24.04.2020 19:59:05 | 25,200 | c9199bab927e901947c1647de248433aa3d439fb | More descriptive error message for missing docker image.
Tested:
Ran a packetimpact test after `docker image rm` and examined the message. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/dockerutil.go",
"new_path": "pkg/test/dockerutil/dockerutil.go",
"diff": "@@ -353,7 +353,10 @@ func (d *Docker) run(r RunOpts, command string, p ...string) (string, error) {\n// Create calls 'docker create' with the arguments provided.\nfun... | Go | Apache License 2.0 | google/gvisor | More descriptive error message for missing docker image.
Tested:
Ran a packetimpact test after `docker image rm` and examined the message.
PiperOrigin-RevId: 308370603 |
259,845 | 20.04.2020 16:46:22 | -32,400 | 93e510e26fca90a90e10a550ce6ca8d7dfa0b55c | fix behavior of `getMountNameAndOptions` when options include either bind or rbind | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -756,6 +756,15 @@ func (c *containerMounter) createRootMount(ctx context.Context, conf *Config) (*\nreturn rootInode, nil\n}\n+func (c *containerMounter) getBindMountNameAndOptions(conf *Config, m ... | Go | Apache License 2.0 | google/gvisor | fix behavior of `getMountNameAndOptions` when options include either bind or rbind
Signed-off-by: moricho <ikeda.morito@gmail.com> |
259,845 | 20.04.2020 17:03:00 | -32,400 | 0b3166f6243472fbb72cc749c57d3a59aa481979 | add bind/rbind options for mount | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/filesystems.go",
"new_path": "pkg/sentry/fs/filesystems.go",
"diff": "@@ -144,6 +144,10 @@ type MountSourceFlags struct {\n// NoExec corresponds to mount(2)'s \"MS_NOEXEC\" and indicates that\n// binaries from this file system can't be executed.\... | Go | Apache License 2.0 | google/gvisor | add bind/rbind options for mount
Signed-off-by: moricho <ikeda.morito@gmail.com> |
259,845 | 22.04.2020 15:04:18 | -32,400 | fc53d6436776d5de052075e98f44417f04ced7e7 | refactor and add test for bindmount | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/filesystems.go",
"new_path": "pkg/sentry/fs/filesystems.go",
"diff": "@@ -144,10 +144,6 @@ type MountSourceFlags struct {\n// NoExec corresponds to mount(2)'s \"MS_NOEXEC\" and indicates that\n// binaries from this file system can't be executed.\... | Go | Apache License 2.0 | google/gvisor | refactor and add test for bindmount
Signed-off-by: moricho <ikeda.morito@gmail.com> |
259,885 | 27.04.2020 07:37:45 | 25,200 | 292f3f99b73fb901ffdd3ad8ac682718e1e8960a | Don't leak vfs.MountNamespace reference if kernel.TaskSet.NewTask fails. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_start.go",
"new_path": "pkg/sentry/kernel/task_start.go",
"diff": "@@ -104,6 +104,9 @@ func (ts *TaskSet) NewTask(cfg *TaskConfig) (*Task, error) {\ncfg.TaskContext.release()\ncfg.FSContext.DecRef()\ncfg.FDTable.DecRef()\n+ if cfg.MountN... | Go | Apache License 2.0 | google/gvisor | Don't leak vfs.MountNamespace reference if kernel.TaskSet.NewTask fails.
PiperOrigin-RevId: 308617610 |
259,881 | 27.04.2020 11:51:48 | 14,400 | b15d49a1378e1ccdb821570a111f228532b85ced | container: use sighandling package
Use the sighandling package for Container.ForwardSignals, for
consistency with other signal forwarding.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/BUILD",
"new_path": "runsc/container/BUILD",
"diff": "@@ -15,8 +15,10 @@ go_library(\n\"//test:__subpackages__\",\n],\ndeps = [\n+ \"//pkg/abi/linux\",\n\"//pkg/log\",\n\"//pkg/sentry/control\",\n+ \"//pkg/sentry/sighandling\",\n\"//pkg/sync\",... | Go | Apache License 2.0 | google/gvisor | container: use sighandling package
Use the sighandling package for Container.ForwardSignals, for
consistency with other signal forwarding.
Fixes #2546 |
259,992 | 27.04.2020 12:25:57 | 25,200 | 003e79a6d11b17caed480c1ba556de5cb713abb3 | Dump stack for stuck start and stuck watchdog
The meaning for skipDump was reversed, but not all callers
were updated. Change the meaning once again to forceDump, so
that the period between stack dump is respected from all
callers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -255,7 +255,7 @@ func (w *Watchdog) runTurn() {\ncase <-done:\ncase <-time.After(w.TaskTimeout):\n// Report if the watchdog is not making progress.\n- // No one is wat... | Go | Apache License 2.0 | google/gvisor | Dump stack for stuck start and stuck watchdog
The meaning for skipDump was reversed, but not all callers
were updated. Change the meaning once again to forceDump, so
that the period between stack dump is respected from all
callers.
PiperOrigin-RevId: 308674373 |
259,884 | 28.04.2020 07:03:12 | -32,400 | a9b3046791e7044fb519ce611c74961d29f9fd23 | Capture and publish OOM events
* Capture and publish OOM events
We use oom notifiers on the cgroup to publish oom events to containerd.
This is passed back via CRI to Kubernetes etc. for more helpful error
reporting.
Fixes | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/v2/epoll.go",
"diff": "+// +build linux\n+\n+/*\n+ Copyright The containerd Authors.\n+\n+ Licensed under the Apache License, Version 2.0 (the \"License\");\n+ you may not use this file except in compliance with the License.\n+ You may obtai... | Go | Apache License 2.0 | google/gvisor | Capture and publish OOM events (#57)
* Capture and publish OOM events
We use oom notifiers on the cgroup to publish oom events to containerd.
This is passed back via CRI to Kubernetes etc. for more helpful error
reporting.
Fixes #56 |
259,962 | 27.04.2020 15:40:00 | 25,200 | 8f42cbfd0815ea34fdfe76c07f76966952d09bb7 | Reduce flakiness in tcp_test.
Poll for metric updates as immediately trying to read them can sometimes be
flaky if due to goroutine scheduling the check happens before the sender has got
a chance to update the corresponding sent metric. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_sack_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_sack_test.go",
"diff": "@@ -28,6 +28,7 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip/stack\"\n\"gvisor.dev/gvisor/pkg/tcpip/transport/tcp\"\n\"gvisor.dev/gvisor/pkg/tcpip/transpor... | Go | Apache License 2.0 | google/gvisor | Reduce flakiness in tcp_test.
Poll for metric updates as immediately trying to read them can sometimes be
flaky if due to goroutine scheduling the check happens before the sender has got
a chance to update the corresponding sent metric.
PiperOrigin-RevId: 308712817 |
259,858 | 28.04.2020 14:45:06 | 25,200 | 64723470a6f0b62ec6223ff66e9c9ca70d248b61 | Use existing bazeldefs with top-level BUILD file. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -30,10 +30,10 @@ build:remote --auth_scope=\"https://www.googleapis.com/auth/cloud-source-tools\"\n# Add a custom platform and toolchain that builds in a privileged docker\n# container, which is required by our sy... | Go | Apache License 2.0 | google/gvisor | Use existing bazeldefs with top-level BUILD file.
PiperOrigin-RevId: 308901116 |
259,860 | 28.04.2020 17:42:11 | 25,200 | f93f2fda74f31246e8866783f6c4be2318bdedd6 | Deduplicate unix socket Release() method. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/unix.go",
"new_path": "pkg/sentry/socket/unix/unix.go",
"diff": "@@ -103,7 +103,7 @@ func (s *socketOpsCommon) DecRef() {\n}\n// Release implemements fs.FileOperations.Release.\n-func (s *SocketOperations) Release() {\n+func (s *socketOp... | Go | Apache License 2.0 | google/gvisor | Deduplicate unix socket Release() method.
PiperOrigin-RevId: 308932254 |
259,860 | 28.04.2020 20:11:43 | 25,200 | ce19497c1c0829af6ba56f0cc68e3a4cb33cf1c8 | Fix Unix socket permissions.
Enforce write permission checks in BoundEndpointAt, which corresponds to the
permission checks in Linux (net/unix/af_unix.c:unix_find_other).
Also, create bound socket files with the correct permissions in VFS2.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/filesystem.go",
"new_path": "pkg/sentry/fsimpl/ext/filesystem.go",
"diff": "@@ -486,10 +486,13 @@ func (fs *filesystem) UnlinkAt(ctx context.Context, rp *vfs.ResolvingPath) error\n// BoundEndpointAt implements FilesystemImpl.BoundEndpoint... | Go | Apache License 2.0 | google/gvisor | Fix Unix socket permissions.
Enforce write permission checks in BoundEndpointAt, which corresponds to the
permission checks in Linux (net/unix/af_unix.c:unix_find_other).
Also, create bound socket files with the correct permissions in VFS2.
Fixes #2324.
PiperOrigin-RevId: 308949084 |
259,891 | 29.04.2020 13:36:29 | 25,200 | a105d185ff9fc24f5bf0c1ca28cbc0f7ec7c4ea5 | iptables: don't pollute logs
The netfilter package uses logs to make debugging the (de)serialization of
structs easier. This generates a lot of (usually irrelevant) logs. Logging is
now hidden behind a debug flag. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -53,9 +53,14 @@ type metadata struct {\nSize uint32\n}\n+// enableLogging controls whether to log the (de)serialization of netfilter\n+// structs bet... | Go | Apache License 2.0 | google/gvisor | iptables: don't pollute logs
The netfilter package uses logs to make debugging the (de)serialization of
structs easier. This generates a lot of (usually irrelevant) logs. Logging is
now hidden behind a debug flag.
PiperOrigin-RevId: 309087115 |
259,860 | 29.04.2020 14:34:28 | 25,200 | ef94401955bbcfb5296daa29ab373423cdd289db | Add read/write timeouts for VFS2 socket files.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/read_write.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/read_write.go",
"diff": "package vfs2\nimport (\n+ \"time\"\n+\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/sentry/arch\"\n\"gvisor.dev/gvisor/pkg/sentr... | Go | Apache License 2.0 | google/gvisor | Add read/write timeouts for VFS2 socket files.
Updates #1476
PiperOrigin-RevId: 309098590 |
259,853 | 30.04.2020 00:32:58 | 25,200 | 44a57646d88b0a03545f97defb12f5bde54a55bf | make_repository.sh has to print only the repo path on stdout | [
{
"change_type": "MODIFY",
"old_path": "tools/make_repository.sh",
"new_path": "tools/make_repository.sh",
"diff": "# See the License for the specific language governing permissions and\n# limitations under the License.\n+# We need to be sure that only a repo path is printed on stdout.\n+exec 50<&1\... | Go | Apache License 2.0 | google/gvisor | make_repository.sh has to print only the repo path on stdout
PiperOrigin-RevId: 309176385 |
259,860 | 30.04.2020 09:46:36 | 25,200 | 442fde405d86c555ac09994772c85ca15a3b4fc7 | Fix proc net bugs in VFS2.
The /proc/net/udp header was missing, and /proc/sys/net was set up as
/proc/sys/net/net. Discovered while trying to run networking tests for VFS2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/task_net.go",
"new_path": "pkg/sentry/fsimpl/proc/task_net.go",
"diff": "@@ -511,6 +511,8 @@ func (d *netUDPData) Generate(ctx context.Context, buf *bytes.Buffer) error {\n// degrade gracefully and retrieve what we can.\nt := kernel.Task... | Go | Apache License 2.0 | google/gvisor | Fix proc net bugs in VFS2.
The /proc/net/udp header was missing, and /proc/sys/net was set up as
/proc/sys/net/net. Discovered while trying to run networking tests for VFS2.
PiperOrigin-RevId: 309243758 |
260,004 | 30.04.2020 10:21:57 | 25,200 | 043b7d83bd76c616fa32b815528eec77f2aad5ff | Prefer temporary addresses
Implement rule 7 of Source Address Selection RFC 6724 section 5. This
makes temporary (short-lived) addresses preferred over non-temporary
addresses when earlier rules are equal.
Test: stack_test.TestIPv6SourceAddressSelectionScopeAndSameAddress | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -452,7 +452,7 @@ type ipv6AddrCandidate struct {\n// primaryIPv6Endpoint returns an IPv6 endpoint following Source Address\n// Selection (RFC 6724 section 5).\n//\n-// Note, only rules ... | Go | Apache License 2.0 | google/gvisor | Prefer temporary addresses
Implement rule 7 of Source Address Selection RFC 6724 section 5. This
makes temporary (short-lived) addresses preferred over non-temporary
addresses when earlier rules are equal.
Test: stack_test.TestIPv6SourceAddressSelectionScopeAndSameAddress
PiperOrigin-RevId: 309250975 |
259,853 | 30.04.2020 11:31:37 | 25,200 | c01e103256a75de4488f50fd34506222c058c151 | Allow to run kvm syscall tests on the RBE cluster | [
{
"change_type": "MODIFY",
"old_path": "scripts/syscall_kvm_tests.sh",
"new_path": "scripts/syscall_kvm_tests.sh",
"diff": "source $(dirname $0)/common.sh\n-# TODO(b/112165693): \"test --test_tag_filters=runsc_kvm\" can be used\n-# when the \"manual\" tag will be removed for kvm tests.\n-test `bazel... | Go | Apache License 2.0 | google/gvisor | Allow to run kvm syscall tests on the RBE cluster
PiperOrigin-RevId: 309265978 |
259,885 | 30.04.2020 16:03:04 | 25,200 | 01beec3bb457a2a3a7313c7fe6dc795817f47746 | Add gofer.InternalFilesystemOptions.LeakConnection. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -73,6 +73,7 @@ type filesystem struct {\n// Immutable options.\nopts filesystemOptions\n+ iopts InternalFilesystemOptions\n// client is the client used by this files... | Go | Apache License 2.0 | google/gvisor | Add gofer.InternalFilesystemOptions.LeakConnection.
PiperOrigin-RevId: 309317605 |
259,858 | 01.05.2020 18:01:58 | 25,200 | 56c64e4bb9dc75659799f3e5df9daddf10d810e1 | Fix include type. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/dut/posix_server.cc",
"new_path": "test/packetimpact/dut/posix_server.cc",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n+#include <arpa/inet.h>\n#include <fcntl.h>\n#inclu... | Go | Apache License 2.0 | google/gvisor | Fix include type.
PiperOrigin-RevId: 309506957 |
259,858 | 04.05.2020 10:39:36 | 25,200 | 2c986870e35f967c88ebc1b7df7b576aad2c46d4 | Fix flaky monotonic time.
This change ensures that even platforms with some TSC issues (e.g. KVM),
can get reliable monotonic time by applied a lower bound on each read. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/timekeeper.go",
"new_path": "pkg/sentry/kernel/timekeeper.go",
"diff": "@@ -16,6 +16,7 @@ package kernel\nimport (\n\"fmt\"\n+ \"sync/atomic\"\n\"time\"\n\"gvisor.dev/gvisor/pkg/log\"\n@@ -48,6 +49,9 @@ type Timekeeper struct {\n// It is set ... | Go | Apache License 2.0 | google/gvisor | Fix flaky monotonic time.
This change ensures that even platforms with some TSC issues (e.g. KVM),
can get reliable monotonic time by applied a lower bound on each read.
PiperOrigin-RevId: 309773801 |
259,992 | 04.05.2020 11:41:38 | 25,200 | 0a307d00726af987793204ef84ac89df064257e6 | Mount VSFS2 filesystem using root credentials | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader_test.go",
"new_path": "runsc/boot/loader_test.go",
"diff": "@@ -438,7 +438,6 @@ func createMountTestcases(vfs2 bool) []*CreateMountTestcase {\n// Test that MountNamespace can be created with various specs.\nfunc TestCreateMountNamespace(t *te... | Go | Apache License 2.0 | google/gvisor | Mount VSFS2 filesystem using root credentials
PiperOrigin-RevId: 309787938 |
259,992 | 04.05.2020 12:27:38 | 25,200 | e2b0e0e272cda5174e17263763f4b78c70a2d927 | Enable TestRunNonRoot on VFS2
Also added back the default test dimension back which was
dropped in a previous refactor. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -256,6 +256,8 @@ var (\nfunc configs(t *testing.T, opts ...configOption) map[string]*boot.Config {\n// Always load the default config.\ncs := make(map[string]*boot... | Go | Apache License 2.0 | google/gvisor | Enable TestRunNonRoot on VFS2
Also added back the default test dimension back which was
dropped in a previous refactor.
PiperOrigin-RevId: 309797327 |
259,853 | 04.05.2020 12:57:04 | 25,200 | 006f9788291359fc871b2fa7b82338912af7abb7 | Deflake //third_party/gvisor/test/syscalls:proc_test_native
There is the known issue of the linux procfs, that two consequent calls of
readdir can return the same entry twice if between these calls one or more
entries have been removed from this directory. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -1939,7 +1939,16 @@ TEST(ProcSelfMounts, RequiredFieldsArePresent) {\n}\nvoid CheckDuplicatesRecursively(std::string path) {\n+ std::vector<std::string> child_dirs;\n+\n+ // T... | Go | Apache License 2.0 | google/gvisor | Deflake //third_party/gvisor/test/syscalls:proc_test_native
There is the known issue of the linux procfs, that two consequent calls of
readdir can return the same entry twice if between these calls one or more
entries have been removed from this directory.
PiperOrigin-RevId: 309803066 |
259,992 | 04.05.2020 13:39:15 | 25,200 | 57dbd7f3624528a416664a618ce9edd4c9096d8d | Remove kernfs.Filesystem cast from GenericDirectoryFD
This allows for kerfs.Filesystem to be overridden by
different implementations.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/fd_impl_util.go",
"new_path": "pkg/sentry/fsimpl/kernfs/fd_impl_util.go",
"diff": "@@ -22,6 +22,7 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/kernel/auth\"\n\"gvisor.dev/gvisor/pkg/sentry/memmap\"\n\"gvisor.dev/gvisor/pkg/sentry/vfs\"\... | Go | Apache License 2.0 | google/gvisor | Remove kernfs.Filesystem cast from GenericDirectoryFD
This allows for kerfs.Filesystem to be overridden by
different implementations.
Updates #1672
PiperOrigin-RevId: 309809321 |
259,992 | 05.05.2020 09:18:21 | 25,200 | b3bd41434c17a95a87d67490f2b9bfd71e1ad705 | Return correct name for imported host files
Implement PrependPath() in host.filesystem to correctly format
name for host files.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devpts/devpts.go",
"new_path": "pkg/sentry/fsimpl/devpts/devpts.go",
"diff": "@@ -59,7 +59,7 @@ func (fstype FilesystemType) GetFilesystem(ctx context.Context, vfsObj *vfs.Virt\n// master inode. It returns the filesystem and root Dentry.\nfun... | Go | Apache License 2.0 | google/gvisor | Return correct name for imported host files
Implement PrependPath() in host.filesystem to correctly format
name for host files.
Updates #1672
PiperOrigin-RevId: 309959135 |
259,860 | 05.05.2020 10:00:02 | 25,200 | a6dbf9596de58f1a264c236bf5afb8dfcfe78174 | Update comments for synthetic gofer files in vfs2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -686,6 +686,8 @@ func (fs *filesystem) MknodAt(ctx context.Context, rp *vfs.ResolvingPath, opts v\nreturn fs.doCreateAt(ctx, rp, false /* dir */, func(pare... | Go | Apache License 2.0 | google/gvisor | Update comments for synthetic gofer files in vfs2.
PiperOrigin-RevId: 309966538 |
259,860 | 05.05.2020 12:09:39 | 25,200 | faf89dd31a44b8409b32919d7193834e194ecc56 | Update vfs2 socket TODOs.
Three updates:
Mark all vfs2 socket syscalls as supported.
Use the same dev number and ino number generator for all types of sockets,
unlike in VFS1.
Do not use host fd for hostinet metadata.
Fixes 1485, | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/sockfs/sockfs.go",
"new_path": "pkg/sentry/fsimpl/sockfs/sockfs.go",
"diff": "@@ -53,9 +53,7 @@ func NewFilesystem(vfsObj *vfs.VirtualFilesystem) *vfs.Filesystem {\n// inode implements kernfs.Inode.\n//\n-// TODO(gvisor.dev/issue/1476): Add d... | Go | Apache License 2.0 | google/gvisor | Update vfs2 socket TODOs.
Three updates:
- Mark all vfs2 socket syscalls as supported.
- Use the same dev number and ino number generator for all types of sockets,
unlike in VFS1.
- Do not use host fd for hostinet metadata.
Fixes #1476, #1478, #1484, 1485, #2017.
PiperOrigin-RevId: 309994579 |
259,853 | 05.05.2020 15:59:27 | 25,200 | 9509c0b3886f29b488a62d0cc8edde9ccdefa335 | gvisor/test: use RetryEINTR for connect()
connect() returns EINTR after S/R and usually we
use RetryEINTR to workaround this. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -162,7 +162,7 @@ TEST_P(DualStackSocketTest, AddressOperations) {\nASSERT_NO_ERRNO(SetAddrPort(\naddr.family(), const_cast<sockaddr_storage*>(&... | Go | Apache License 2.0 | google/gvisor | gvisor/test: use RetryEINTR for connect()
connect() returns EINTR after S/R and usually we
use RetryEINTR to workaround this.
PiperOrigin-RevId: 310038525 |
259,891 | 06.05.2020 13:36:48 | 25,200 | b08222cf3a80a57e77ac4af7a410f188ba01e0f4 | sniffer: fix accidental logging of good packets as bad
We need to check vv.Size() instead of len(tcp), as tcp will always be 20 bytes
long. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sniffer/sniffer.go",
"new_path": "pkg/tcpip/link/sniffer/sniffer.go",
"diff": "@@ -391,7 +391,7 @@ func logPacket(prefix string, protocol tcpip.NetworkProtocolNumber, pkt *stack.P\nbreak\n}\nudp := header.UDP(hdr)\n- if fragmentOffset == 0 && le... | Go | Apache License 2.0 | google/gvisor | sniffer: fix accidental logging of good packets as bad
We need to check vv.Size() instead of len(tcp), as tcp will always be 20 bytes
long.
PiperOrigin-RevId: 310218351 |
259,858 | 26.02.2020 22:44:50 | 28,800 | 1e943dcc9eed420731935e0c8aa1f25788584f95 | Add governance and security policies. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "GOVERNANCE.md",
"diff": "+# Governance\n+\n+## Projects\n+\n+A *project* is the primary unit of collaboration. Each project may have its own\n+repository and contribution process.\n+\n+All projects are covered by the [Code of Conduct](CODE_OF_CO... | Go | Apache License 2.0 | google/gvisor | Add governance and security policies. |
259,858 | 21.04.2020 12:49:43 | 25,200 | 228c6ad7ccbf9c61bcf05155c4ab75102b4303c7 | Move new post image. | [
{
"change_type": "MODIFY",
"old_path": "website/content/_posts/2019-11-18-security-basics.md",
"new_path": "website/content/_posts/2019-11-18-security-basics.md",
"diff": "@@ -46,7 +46,7 @@ A simplified version of the design is below ([more detailed version](https://gvi\n----\n-![Figure 1](./2019-11... | Go | Apache License 2.0 | google/gvisor | Move new post image. |
259,858 | 21.04.2020 12:50:18 | 25,200 | 8cb33ce5ded7d417710e7e749524b895deb20397 | Fix cache permissions. | [
{
"change_type": "MODIFY",
"old_path": "website/Makefile",
"new_path": "website/Makefile",
"diff": "# See the License for the specific language governing permissions and\n# limitations under the License.\n-build:\n+build: content/.jekyll-cache\n@bazel run //runsc -- help syscalls -format json -filen... | Go | Apache License 2.0 | google/gvisor | Fix cache permissions. |
259,858 | 28.04.2020 00:39:29 | 25,200 | b6ba247fa665099fabdf845947a4e1eedb8cce13 | Update main landing page. | [
{
"change_type": "MODIFY",
"old_path": "website/_sass/front.scss",
"new_path": "website/_sass/front.scss",
"diff": "background-position: center;\nbackground-repeat: no-repeat;\nbackground-size: cover;\n+ background-blend-mode: darken;\n+ background-color: rgba(0,0,0,0.1);\np {\n- color: #eeeeee;\n+ ... | Go | Apache License 2.0 | google/gvisor | Update main landing page. |
259,858 | 28.04.2020 12:47:28 | 25,200 | f126de6a28b9d64abcab37392cde812957eb9a82 | Add resource model. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/BUILD",
"new_path": "g3doc/BUILD",
"diff": "@@ -8,6 +8,7 @@ package(\ndoc(\nname = \"index\",\nsrc = \"README.md\",\n+ category = \"Project\",\npermalink = \"/docs/\",\nweight = \"0\",\n)\n@@ -20,13 +21,6 @@ doc(\nweight = \"10\",\n)\n-doc(\n- name = \"b... | Go | Apache License 2.0 | google/gvisor | Add resource model. |
259,858 | 28.04.2020 12:51:24 | 25,200 | 3cb00c97e953df3d1970e1462d8dbcd47d496d61 | Add note about AArch64 support. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/FAQ.md",
"new_path": "g3doc/user_guide/FAQ.md",
"diff": "@@ -7,7 +7,8 @@ Today, gVisor requires Linux.\n### What CPU architectures are supported? {#supported-cpus}\ngVisor currently supports [x86_64/AMD64](https://en.wikipedia.org/wiki/X86-64)... | Go | Apache License 2.0 | google/gvisor | Add note about AArch64 support. |
259,858 | 28.04.2020 18:18:04 | 25,200 | d3c43401a7277e0a7e7f2d28392e2e196d7ea74c | Fixup link in CODE_OF_CONDUCT.md. | [
{
"change_type": "MODIFY",
"old_path": "CODE_OF_CONDUCT.md",
"new_path": "CODE_OF_CONDUCT.md",
"diff": "@@ -87,6 +87,5 @@ harassment or threats to anyone's safety, we may take action without notice.\n## Attribution\n-This Code of Conduct is adapted from the Contributor Covenant, version 1.4,\n-avail... | Go | Apache License 2.0 | google/gvisor | Fixup link in CODE_OF_CONDUCT.md. |
259,858 | 29.04.2020 10:53:25 | 25,200 | cf86ec5e40bd1abf5be45fabbc7591a0452747ea | Add powered by gVisor logo. | [
{
"change_type": "MODIFY",
"old_path": "website/_includes/footer-links.html",
"new_path": "website/_includes/footer-links.html",
"diff": "<div class=\"container\">\n<div class=\"row\">\n- <div class=\"col-sm-4 col-md-2\">\n+ <div class=\"col-sm-3 col-md-2\">\n<p>About</p>\n<ul class=\"list-unstyled\... | Go | Apache License 2.0 | google/gvisor | Add powered by gVisor logo. |
259,858 | 29.04.2020 11:45:04 | 25,200 | 7de6fb18f9a284b8f70191effd442a48c232603b | Clean-up documentation. | [
{
"change_type": "MODIFY",
"old_path": "website/index.md",
"new_path": "website/index.md",
"diff": "@@ -8,7 +8,7 @@ layout: base\n<div class=\"col-md-6\">\n<p>gVisor is an <b>application kernel</b> and <b>container runtime</b> providing defense-in-depth for containers <em>anywhere</em>.</p>\n<p styl... | Go | Apache License 2.0 | google/gvisor | Clean-up documentation. |
259,858 | 29.04.2020 18:00:21 | 25,200 | a10d5ed9691d341c60dc8590d19302332120d365 | Add atom feed (at previous URL). | [
{
"change_type": "MODIFY",
"old_path": "images/jekyll/Dockerfile",
"new_path": "images/jekyll/Dockerfile",
"diff": "@@ -7,5 +7,6 @@ RUN gem install \\\njekyll-inline-svg:1.1.4 \\\njekyll-paginate:1.1.0 \\\nkramdown-parser-gfm:1.1.0 \\\n- jekyll-relative-links:0.6.1\n+ jekyll-relative-links:0.6.1 \\\... | Go | Apache License 2.0 | google/gvisor | Add atom feed (at previous URL). |
259,858 | 29.04.2020 18:54:48 | 25,200 | 5f3a256425f4fa99fd3e5363418c5978659cecf3 | Add support for kramdown TOC. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/architecture_guide/performance.md",
"new_path": "g3doc/architecture_guide/performance.md",
"diff": "# Performance Guide\n+[TOC]\n+\ngVisor is designed to provide a secure, virtualized environment while preserving\nkey benefits of containerization, such a... | Go | Apache License 2.0 | google/gvisor | Add support for kramdown TOC. |
260,004 | 06.05.2020 15:57:42 | 25,200 | 485ca36adf18fbb587df9f34a2deea730882fb36 | Do not assume no DHCPv6 configurations
Do not assume that networks need any DHCPv6 configurations. Instead,
notify the NDP dispatcher in response to the first NDP RA's DHCPv6
flags, even if the flags indicate no DHCPv6 configurations are
available. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/dhcpv6configurationfromndpra_string.go",
"new_path": "pkg/tcpip/stack/dhcpv6configurationfromndpra_string.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// Code generate... | Go | Apache License 2.0 | google/gvisor | Do not assume no DHCPv6 configurations
Do not assume that networks need any DHCPv6 configurations. Instead,
notify the NDP dispatcher in response to the first NDP RA's DHCPv6
flags, even if the flags indicate no DHCPv6 configurations are
available.
PiperOrigin-RevId: 310245068 |
259,885 | 06.05.2020 16:06:49 | 25,200 | 7cd54c1f1437dccdf1840e8f893de06f9d1e70e6 | Remove vfs.FileDescriptionOptions.InvalidWrite.
Compare: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/timerfd.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/timerfd.go",
"diff": "@@ -46,7 +46,10 @@ func TimerfdCreate(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel\ndefault:\nreturn 0, nil, syserror.EINVAL\n}\n- fi... | Go | Apache License 2.0 | google/gvisor | Remove vfs.FileDescriptionOptions.InvalidWrite.
Compare:
https://elixir.bootlin.com/linux/v5.6/source/fs/timerfd.c#L431
PiperOrigin-RevId: 310246908 |
259,891 | 06.05.2020 22:23:41 | 25,200 | 763b5ad5968532249c69f29c997a1f6ec291db8b | Add basic incoming ipv4 fragment tests
Based on ipv6's TestReceiveIPv6Fragments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/BUILD",
"new_path": "pkg/tcpip/network/ipv4/BUILD",
"diff": "@@ -34,5 +34,6 @@ go_test(\n\"//pkg/tcpip/transport/tcp\",\n\"//pkg/tcpip/transport/udp\",\n\"//pkg/waiter\",\n+ \"@com_github_google_go-cmp//cmp:go_default_library\",\n],\n)\n... | Go | Apache License 2.0 | google/gvisor | Add basic incoming ipv4 fragment tests
Based on ipv6's TestReceiveIPv6Fragments. |
259,860 | 07.05.2020 09:52:39 | 25,200 | e0089a20e4830d6b6659414e393905e0fd6a2e66 | Remove outdated TODO for VFS2 AccessAt.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/anonfs.go",
"new_path": "pkg/sentry/vfs/anonfs.go",
"diff": "@@ -91,8 +91,6 @@ func (fs *anonFilesystem) Sync(ctx context.Context) error {\n}\n// AccessAt implements vfs.Filesystem.Impl.AccessAt.\n-//\n-// TODO(gvisor.dev/issue/1965): Implement ... | Go | Apache License 2.0 | google/gvisor | Remove outdated TODO for VFS2 AccessAt.
Fixes #1965.
PiperOrigin-RevId: 310380433 |
259,860 | 07.05.2020 10:19:11 | 25,200 | 16da7e790f570d9743fb47e50c304e6a24834772 | Update privateunixsocket TODOs.
Synthetic sockets do not have the race condition issue in VFS2, and we will
get rid of privateunixsocket as well.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/session.go",
"new_path": "pkg/sentry/fs/gofer/session.go",
"diff": "@@ -190,9 +190,9 @@ type session struct {\n// be socket/pipe files. This allows unix domain sockets and named pipes to\n// be used with paths that belong to a gofer.\n//\n-... | Go | Apache License 2.0 | google/gvisor | Update privateunixsocket TODOs.
Synthetic sockets do not have the race condition issue in VFS2, and we will
get rid of privateunixsocket as well.
Fixes #1200.
PiperOrigin-RevId: 310386474 |
259,858 | 07.05.2020 13:17:33 | 25,200 | 1f4087e7cd6c3cc696e6b26446abd6c5214cfd67 | Fix tags used for determining file sets.
Updates
Updates | [
{
"change_type": "MODIFY",
"old_path": "tools/bazeldefs/tags.bzl",
"new_path": "tools/bazeldefs/tags.bzl",
"diff": "\"\"\"List of special Go suffixes.\"\"\"\n-go_suffixes = [\n+def explode(tagset, suffixes):\n+ \"\"\"explode combines tagset and suffixes in all ways.\n+\n+ Args:\n+ tagset: Original s... | Go | Apache License 2.0 | google/gvisor | Fix tags used for determining file sets.
Updates #2569
Updates #2298
PiperOrigin-RevId: 310423629 |
259,858 | 07.05.2020 15:17:09 | 25,200 | 7b4a913f36e2fededca9b1d2f73588eca9c4b683 | Fix ARM64 build.
The common syscall definitions mean that ARM64-exclusive files need stubs in
the ARM64 build. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/BUILD",
"new_path": "pkg/sentry/syscalls/linux/BUILD",
"diff": "@@ -49,7 +49,8 @@ go_library(\n\"sys_time.go\",\n\"sys_timer.go\",\n\"sys_timerfd.go\",\n- \"sys_tls.go\",\n+ \"sys_tls_amd64.go\",\n+ \"sys_tls_arm64.go\",\n\"sys_utsnam... | Go | Apache License 2.0 | google/gvisor | Fix ARM64 build.
The common syscall definitions mean that ARM64-exclusive files need stubs in
the ARM64 build.
PiperOrigin-RevId: 310446698 |
259,898 | 08.05.2020 11:21:40 | 25,200 | 5d7d5ed7d6ffd8d420f042a22b22e0527e78d441 | Send ACK to OTW SEQs/unacc ACKs in CLOSE_WAIT
This fixed the corresponding packetimpact test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/tcp.go",
"new_path": "pkg/tcpip/header/tcp.go",
"diff": "@@ -609,5 +609,8 @@ func Acceptable(segSeq seqnum.Value, segLen seqnum.Size, rcvNxt, rcvAcc seqnum.V\n}\n// Page 70 of RFC 793 allows packets that can be made \"acceptable\" by trimming\... | Go | Apache License 2.0 | google/gvisor | Send ACK to OTW SEQs/unacc ACKs in CLOSE_WAIT
This fixed the corresponding packetimpact test.
PiperOrigin-RevId: 310593470 |
259,885 | 08.05.2020 11:34:15 | 25,200 | 21b71395a6aa2eafbc4c59222574d56c2db2e23b | Pass flags to fsimpl/host.inode.open().
This has two effects: It makes flags passed to open("/proc/[pid]/fd/[hostfd]")
effective, and it prevents imported pipes/sockets/character devices from being
opened with O_NONBLOCK unconditionally (because the underlying host FD was set
to non-blocking in ImportFD()). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -53,13 +53,19 @@ func ImportFD(ctx context.Context, mnt *vfs.Mount, hostFD int, isTTY bool) (*vfs\nreturn nil, err\n}\n+ // Get flags for the imported FD.\n+ flags, err ... | Go | Apache License 2.0 | google/gvisor | Pass flags to fsimpl/host.inode.open().
This has two effects: It makes flags passed to open("/proc/[pid]/fd/[hostfd]")
effective, and it prevents imported pipes/sockets/character devices from being
opened with O_NONBLOCK unconditionally (because the underlying host FD was set
to non-blocking in ImportFD()).
PiperOrigin-RevId: 310596062 |
259,962 | 08.05.2020 15:38:42 | 25,200 | e4d2d21f6b1b93146378ed5edc0c55d2ae4fb3af | Add UDP send/recv packetimpact tests.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -841,6 +841,7 @@ func (conn *UDPIPv4) SendIP(additionalLayers ...Layer) {\n// Expect expects a frame with the UDP layer matching the provided UDP... | Go | Apache License 2.0 | google/gvisor | Add UDP send/recv packetimpact tests.
Fixes #2654
PiperOrigin-RevId: 310642216 |
259,885 | 11.05.2020 16:13:14 | 25,200 | 15de8cc9e0e7789c3d55595171b3272ec726931f | Add fsimpl/gofer.InternalFilesystemOptions.OpenSocketsByConnecting. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -21,6 +21,8 @@ import (\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/fspath\"\n\"gvisor.dev/gvisor/pkg/p9\"\n+ \"gvisor.dev/gvisor/pkg/sentr... | Go | Apache License 2.0 | google/gvisor | Add fsimpl/gofer.InternalFilesystemOptions.OpenSocketsByConnecting.
PiperOrigin-RevId: 311014995 |
259,891 | 23.03.2020 14:33:20 | 25,200 | 87225fad2a468e1516784f13abe8bb946d0172c6 | iptables: check for truly unconditional rules
We weren't properly checking whether the inserted default rule was
unconditional. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -59,6 +59,13 @@ type metadata struct {\n// developing iptables, but can pollute sentry logs otherwise.\nconst enableLogging = false\n+// emptyFilter ... | Go | Apache License 2.0 | google/gvisor | iptables: check for truly unconditional rules
We weren't properly checking whether the inserted default rule was
unconditional. |
259,885 | 12.05.2020 12:24:23 | 25,200 | 8dd1d5b75a95100e747b1a88e9e557d5d2c30b64 | Don't call kernel.Task.Block() from netstack.SocketOperations.Write().
kernel.Task.Block() requires that the caller is running on the task goroutine.
netstack.SocketOperations.Write() uses kernel.TaskFromContext() to call
kernel.Task.Block() even if it's not running on the task goroutine. Stop doing
that. | [
{
"change_type": "MODIFY",
"old_path": "pkg/amutex/BUILD",
"new_path": "pkg/amutex/BUILD",
"diff": "@@ -6,6 +6,7 @@ go_library(\nname = \"amutex\",\nsrcs = [\"amutex.go\"],\nvisibility = [\"//:sandbox\"],\n+ deps = [\"//pkg/syserror\"],\n)\ngo_test(\n"
},
{
"change_type": "MODIFY",
"old_... | Go | Apache License 2.0 | google/gvisor | Don't call kernel.Task.Block() from netstack.SocketOperations.Write().
kernel.Task.Block() requires that the caller is running on the task goroutine.
netstack.SocketOperations.Write() uses kernel.TaskFromContext() to call
kernel.Task.Block() even if it's not running on the task goroutine. Stop doing
that.
PiperOrigin-RevId: 311178335 |
259,992 | 12.05.2020 17:24:46 | 25,200 | 305f786e51ea2092c633d97b06818e59c5f40552 | Adjust a few log messages | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/vfs.go",
"new_path": "runsc/boot/vfs.go",
"diff": "@@ -245,7 +245,6 @@ func (c *containerMounter) mountSubmountVFS2(ctx context.Context, conf *Config,\nif err := c.makeSyntheticMount(ctx, submount.Destination, root, creds); err != nil {\nreturn err\... | Go | Apache License 2.0 | google/gvisor | Adjust a few log messages
PiperOrigin-RevId: 311234146 |
259,992 | 13.05.2020 10:30:00 | 25,200 | 18cb3d24cb3b59da11ebeac444021346495c95e4 | Use VFS2 mount names
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -37,6 +37,12 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/fs\"\n\"gvisor.dev/gvisor/pkg/sentry/fs/gofer\"\n\"gvisor.dev/gvisor/pkg/sentry/fs/ramfs\"\n+ \"gvisor.dev/gvisor/pkg/sentry/fsimpl/devpts\"... | Go | Apache License 2.0 | google/gvisor | Use VFS2 mount names
Updates #1487
PiperOrigin-RevId: 311356385 |
259,885 | 13.05.2020 18:16:45 | 25,200 | 64afaf0e9bb712938f3621b8588840b5398b883c | Fix runsc association of gofers and FDs on VFS2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -770,14 +770,8 @@ func (c *containerMounter) getMountNameAndOptions(conf *Config, m specs.Mount) (\nuseOverlay bool\n)\n- for _, opt := range m.Options {\n- // When options include either \"bind\" ... | Go | Apache License 2.0 | google/gvisor | Fix runsc association of gofers and FDs on VFS2.
Updates #1487
PiperOrigin-RevId: 311443628 |
259,962 | 13.05.2020 19:47:42 | 25,200 | 8b8774d7152eb61fc6273bbae679e80c34188517 | Stub support for TCP_SYNCNT and TCP_WINDOW_CLAMP.
This change adds support for TCP_SYNCNT and TCP_WINDOW_CLAMP options
in GetSockOpt/SetSockOpt. This change does not really change any
behaviour in Netstack and only stores/returns the stored value.
Actual honoring of these options will be added as required.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1321,6 +1321,29 @@ func getSockOptTCP(t *kernel.Task, ep commonEndpoint, name, outLen int) (interfa\nreturn int32(time.Duration(v) / time.Second), nil\n... | Go | Apache License 2.0 | google/gvisor | Stub support for TCP_SYNCNT and TCP_WINDOW_CLAMP.
This change adds support for TCP_SYNCNT and TCP_WINDOW_CLAMP options
in GetSockOpt/SetSockOpt. This change does not really change any
behaviour in Netstack and only stores/returns the stored value.
Actual honoring of these options will be added as required.
Fixes #2626, #2625
PiperOrigin-RevId: 311453777 |
259,858 | 14.05.2020 14:00:52 | 25,200 | f589a85889c815cebac624122aebe14c8263a574 | Run issue_reviver via GitHub. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".github/workflows/issue_reviver.yml",
"diff": "+name: \"Issue reviver\"\n+on:\n+ schedule:\n+ - cron: '0 0 * * *'\n+\n+jobs:\n+ label:\n+ runs-on: ubuntu-latest\n+ steps:\n+ - uses: actions/checkout@v2\n+ - run: make run TARGETS=\"//tools/issue_... | Go | Apache License 2.0 | google/gvisor | Run issue_reviver via GitHub.
PiperOrigin-RevId: 311600872 |
259,885 | 14.05.2020 20:08:25 | 25,200 | fb7e5f1676ad9e6e7e83312e09fe55f91ade41bc | Make utimes_test pass on VFS2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -869,8 +869,8 @@ func (d *dentry) setStat(ctx context.Context, creds *auth.Credentials, stat *lin\nSize: stat.Mask&linux.STATX_SIZE != 0,\nATime: stat.Mask&linux.STA... | Go | Apache License 2.0 | google/gvisor | Make utimes_test pass on VFS2.
PiperOrigin-RevId: 311657502 |
259,858 | 14.05.2020 20:21:03 | 25,200 | 4502b73d008e7696adbf035926092590f2077706 | Update Kokoro images to include newer gcloud. | [
{
"change_type": "MODIFY",
"old_path": "tools/vm/build.sh",
"new_path": "tools/vm/build.sh",
"diff": "@@ -64,7 +64,7 @@ function cleanup {\ntrap cleanup EXIT\n# Wait for the instance to become available (up to 5 minutes).\n-echo -n \"Waiting for ${INSTANCE_NAME}\"\n+echo -n \"Waiting for ${INSTANCE_... | Go | Apache License 2.0 | google/gvisor | Update Kokoro images to include newer gcloud.
PiperOrigin-RevId: 311658774 |
259,858 | 15.05.2020 09:29:52 | 25,200 | 1847165a8c034e82cb35a0dc23878921cab30b5d | Minor text updates and jquery ordering. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/architecture_guide/README.md",
"new_path": "g3doc/architecture_guide/README.md",
"diff": "@@ -71,6 +71,9 @@ race detector. (The use of Go has its challenges too, and isn't free.)\n<a name=\"gofer\"></a> <!-- For deep linking. -->\n+Gofers mediate file sy... | Go | Apache License 2.0 | google/gvisor | Minor text updates and jquery ordering.
PiperOrigin-RevId: 311744091 |
259,858 | 15.05.2020 10:08:31 | 25,200 | c5a939d76c69c440b89045768c3acd8ffc5246b4 | Update vm scripts to handle existing kbuilder user. | [
{
"change_type": "MODIFY",
"old_path": "tools/vm/build.sh",
"new_path": "tools/vm/build.sh",
"diff": "@@ -71,7 +71,7 @@ declare internal=\"\"\ndeclare -r start=$(date +%s)\ndeclare -r end=$((${start}+${timeout}))\nwhile [[ \"$(date +%s)\" -lt \"${end}\" ]] && [[ \"${success}\" -lt 3 ]]; do\n- echo -... | Go | Apache License 2.0 | google/gvisor | Update vm scripts to handle existing kbuilder user.
PiperOrigin-RevId: 311751972 |
259,962 | 15.05.2020 15:04:33 | 25,200 | 679fd2527bdcaf2ca4dd05dad48a75ffc9400973 | Remove debug log left behind by mistake. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"new_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"diff": "@@ -16,7 +16,6 @@ package linux\nimport (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n- \"gvisor.dev/gvisor/pkg/log\"\n\"gvisor.dev/gvisor/pkg/sentry/arch\"\n\"... | Go | Apache License 2.0 | google/gvisor | Remove debug log left behind by mistake.
PiperOrigin-RevId: 311808460 |
259,858 | 18.05.2020 09:48:13 | 25,200 | c27e334f260f6d1b2a380c8f105028a8140b7acd | Fix typo a => an.
Always happens. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "## What is gVisor?\n-**gVisor** is a application kernel, written in Go, that implements a substantial\n-portion of the Linux system surface. It includes an\n+**gVisor** is an application kernel, written in Go, that... | Go | Apache License 2.0 | google/gvisor | Fix typo a => an.
Always happens.
PiperOrigin-RevId: 312097591 |
259,992 | 18.05.2020 10:21:43 | 25,200 | 32ab382c80306d7dab499e983af2bfaea7770d1d | Improve unsupported syscall message | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/compat.go",
"new_path": "runsc/boot/compat.go",
"diff": "@@ -119,7 +119,13 @@ func (c *compatEmitter) emitUnimplementedSyscall(us *spb.UnimplementedSyscall) {\n}\nif tr.shouldReport(regs) {\n- c.sink.Infof(\"Unsupported syscall: %s, regs: %+v\", c.n... | Go | Apache License 2.0 | google/gvisor | Improve unsupported syscall message
PiperOrigin-RevId: 312104899 |
259,898 | 18.05.2020 11:30:04 | 25,200 | 99a18ec8b4cc98694b8bc61a35b360d5fca1a075 | Support TCP options for packetimpact | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/BUILD",
"new_path": "test/packetimpact/testbench/BUILD",
"diff": "@@ -39,6 +39,7 @@ go_test(\nlibrary = \":testbench\",\ndeps = [\n\"//pkg/tcpip\",\n+ \"//pkg/tcpip/header\",\n\"@com_github_mohae_deepcopy//:go_default_library\",\n],... | Go | Apache License 2.0 | google/gvisor | Support TCP options for packetimpact
PiperOrigin-RevId: 312119730 |
259,992 | 18.05.2020 14:24:47 | 25,200 | 20e6efd302746554c485028f9fc1f2fbf88b234e | Remove IfChange/ThenChange lint from VFS2
As new functionality is added to VFS2, corresponding files in VFS1
don't need to be changed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devpts/line_discipline.go",
"new_path": "pkg/sentry/fsimpl/devpts/line_discipline.go",
"diff": "@@ -27,8 +27,6 @@ import (\n\"gvisor.dev/gvisor/pkg/waiter\"\n)\n-// LINT.IfChange\n-\nconst (\n// canonMaxBytes is the number of bytes that fit i... | Go | Apache License 2.0 | google/gvisor | Remove IfChange/ThenChange lint from VFS2
As new functionality is added to VFS2, corresponding files in VFS1
don't need to be changed.
PiperOrigin-RevId: 312153799 |
259,858 | 18.05.2020 14:34:49 | 25,200 | cbfb55869e4d00ddd1ede096ba01adf2713e08b1 | Implement Go branch updater with GitHub actions. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".github/workflows/go.yml",
"diff": "+name: \"Go\"\n+on:\n+ push:\n+ branches:\n+ - master\n+ pull_request:\n+ branches:\n+ - master\n+\n+jobs:\n+ generate:\n+ runs-on: ubuntu-latest\n+ steps:\n+ - run: |\n+ jq -nc '{\"state\": \"pending\", \"con... | Go | Apache License 2.0 | google/gvisor | Implement Go branch updater with GitHub actions.
PiperOrigin-RevId: 312155686 |
259,858 | 18.05.2020 14:51:53 | 25,200 | f2f2dec7280e37696550185f291d51cf9e47e281 | Add simplified badge and Build workflow. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".github/workflows/build.yml",
"diff": "+name: \"Build\"\n+on:\n+ push:\n+ branches:\n+ - master\n+ pull_request:\n+ branches:\n+ - master\n+\n+jobs:\n+ default:\n+ runs-on: ubuntu-latest\n+ steps:\n+ - uses: actions/checkout@v2\n+ - uses: action... | Go | Apache License 2.0 | google/gvisor | Add simplified badge and Build workflow.
PiperOrigin-RevId: 312159017 |
259,860 | 19.05.2020 13:45:23 | 25,200 | 05c89af6edde6158844d4debfe68bc598fec4418 | Implement mmap for host fs in vfs2.
In VFS1, both fs/host and fs/gofer used the same utils for host file mappings.
Refactor parts of fsimpl/gofer to create similar utils to share with
fsimpl/host (memory accounting code moved to fsutil, page rounding arithmetic
moved to usermem).
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/frame_ref_set.go",
"new_path": "pkg/sentry/fs/fsutil/frame_ref_set.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"math\"\n\"gvisor.dev/gvisor/pkg/sentry/platform\"\n+ \"gvisor.dev/gvisor/pkg/sentry/usage\"\n)\n// FrameRefSetFunctions implemen... | Go | Apache License 2.0 | google/gvisor | Implement mmap for host fs in vfs2.
In VFS1, both fs/host and fs/gofer used the same utils for host file mappings.
Refactor parts of fsimpl/gofer to create similar utils to share with
fsimpl/host (memory accounting code moved to fsutil, page rounding arithmetic
moved to usermem).
Updates #1476.
PiperOrigin-RevId: 312345090 |
259,858 | 20.05.2020 11:19:04 | 25,200 | 5bf33a386348a3b07cfc60c3738bc0f9af7eabae | Unbreak permalink.
The permalink should be "linux" not "Linux. | [
{
"change_type": "MODIFY",
"old_path": "website/cmd/syscalldocs/main.go",
"new_path": "website/cmd/syscalldocs/main.go",
"diff": "@@ -46,7 +46,7 @@ type SyscallDoc struct {\n}\nvar mdTemplate = template.Must(template.New(\"out\").Parse(`---\n-title: {{.OS}}/{{.Arch}}\n+title: {{.Title}}\ndescription... | Go | Apache License 2.0 | google/gvisor | Unbreak permalink.
The permalink should be "linux" not "Linux.
PiperOrigin-RevId: 312518858 |
259,992 | 20.05.2020 14:47:31 | 25,200 | 10abad0040c47baa9f629a01fb43888c3407d8bc | Add hugetlb and rdma cgroups to runsc
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -19,6 +19,7 @@ package cgroup\nimport (\n\"bufio\"\n\"context\"\n+ \"errors\"\n\"fmt\"\n\"io/ioutil\"\n\"os\"\n@@ -38,21 +39,23 @@ const (\ncgroupRoot = \"/sys/fs/cgroup\"\n)\n-var cont... | Go | Apache License 2.0 | google/gvisor | Add hugetlb and rdma cgroups to runsc
Updates #2713
PiperOrigin-RevId: 312559463 |
259,860 | 20.05.2020 14:49:40 | 25,200 | 76369b6480b69bb7bf680db36ce8787fb324911c | Move fsimpl/host file offset from inode to fileDescription. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -90,9 +90,6 @@ func NewFD(ctx context.Context, mnt *vfs.Mount, hostFD int, opts *NewFDOptions)\nisTTY: opts.IsTTY,\nwouldBlock: wouldBlock(uint32(fileType)),\nseekable: ... | Go | Apache License 2.0 | google/gvisor | Move fsimpl/host file offset from inode to fileDescription.
PiperOrigin-RevId: 312559861 |
259,884 | 20.05.2020 16:04:16 | 25,200 | 61e68798828b500f093c4c129cb87361c2fe4a4f | Update the Docker quickstart to use 'runsc install' | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/install.md",
"new_path": "g3doc/user_guide/install.md",
"diff": "@@ -150,11 +150,8 @@ users, and ensure it is executable by all users**, since `runsc` executes itself\nas user `nobody` to avoid unnecessary privileges. The `/usr/local/bin` dire... | Go | Apache License 2.0 | google/gvisor | Update the Docker quickstart to use 'runsc install'
PiperOrigin-RevId: 312573487 |
259,898 | 20.05.2020 17:52:05 | 25,200 | 5f3eeb47286cf9696154f3d9569b655b84ac7d0c | Test that we have PAWS mechanism
If there is a Timestamps option in the arriving segment and SEG.TSval
< TS.Recent and if TS.Recent is valid, then treat the arriving segment
as not acceptable: Send an acknowledgement in reply as specified in
page 69 and drop the segment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/tcp.go",
"new_path": "pkg/tcpip/header/tcp.go",
"diff": "@@ -66,6 +66,14 @@ const (\nTCPOptionSACK = 5\n)\n+// Option Lengths.\n+const (\n+ TCPOptionMSSLength = 4\n+ TCPOptionTSLength = 10\n+ TCPOptionWSLength = 3\n+ TCPOptionSackPermittedLeng... | Go | Apache License 2.0 | google/gvisor | Test that we have PAWS mechanism
If there is a Timestamps option in the arriving segment and SEG.TSval
< TS.Recent and if TS.Recent is valid, then treat the arriving segment
as not acceptable: Send an acknowledgement in reply as specified in
RFC-793 page 69 and drop the segment.
https://tools.ietf.org/html/rfc1323#page-19
PiperOrigin-RevId: 312590678 |
259,985 | 20.05.2020 18:33:51 | 25,200 | 49d2cf287db08b1f09f1246096cabf9c9a951039 | Remove implicit dependencies for leaf packages.
These packages don't actually use go_stateify or go_marshal, but end
up implicitly dependent on the respective packages due to our build
rules.
These unnecessary dependencies make them unusuable in certain contexts
due to circular dependency. | [
{
"change_type": "MODIFY",
"old_path": "pkg/linewriter/BUILD",
"new_path": "pkg/linewriter/BUILD",
"diff": "@@ -5,6 +5,8 @@ package(licenses = [\"notice\"])\ngo_library(\nname = \"linewriter\",\nsrcs = [\"linewriter.go\"],\n+ marshal = False,\n+ stateify = False,\nvisibility = [\"//visibility:public... | Go | Apache License 2.0 | google/gvisor | Remove implicit dependencies for leaf packages.
These packages don't actually use go_stateify or go_marshal, but end
up implicitly dependent on the respective packages due to our build
rules.
These unnecessary dependencies make them unusuable in certain contexts
due to circular dependency.
PiperOrigin-RevId: 312595738 |
259,858 | 20.05.2020 22:22:00 | 25,200 | 8437ef752d3c8e90327edad0164f3e4d003821c8 | Normalize permissions in the go branch.
Fixes | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -17,6 +17,7 @@ jobs:\n-H \"Content-Type: application/json\" \\\n-H \"Authorization: token ${{ secrets.GITHUB_TOKEN }}\" \\\n\"${{ github.event.pull_request.statuses_url }}\"\n+ if: ... | Go | Apache License 2.0 | google/gvisor | Normalize permissions in the go branch.
Fixes #2722 |
259,992 | 21.05.2020 10:46:45 | 25,200 | 7bde26934ae6d39649a31f6c77a4bc210277085a | Add IsRunningWithVFS1 to test util
VFS2 is adding more functionality than VFS1. In order to test
new functionality, it's required to skip some tests with VFS1.
To skip tests, use:
SKIP_IF(IsRunningWithVFS1());
The test will run in Linux and gVisor with VFS2 enabled.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/util/test_util.cc",
"new_path": "test/util/test_util.cc",
"diff": "@@ -42,12 +42,13 @@ namespace testing {\n#define TEST_ON_GVISOR \"TEST_ON_GVISOR\"\n#define GVISOR_NETWORK \"GVISOR_NETWORK\"\n+#define GVISOR_VFS \"GVISOR_VFS\"\nbool IsRunningOnGvisor() ... | Go | Apache License 2.0 | google/gvisor | Add IsRunningWithVFS1 to test util
VFS2 is adding more functionality than VFS1. In order to test
new functionality, it's required to skip some tests with VFS1.
To skip tests, use:
SKIP_IF(IsRunningWithVFS1());
The test will run in Linux and gVisor with VFS2 enabled.
Updates #1035
PiperOrigin-RevId: 312698616 |
259,992 | 21.05.2020 11:06:28 | 25,200 | cdf48e851670f8f333f61e7621e0aa7d495d98fe | Fix TestTmpFile
Split check for file in /tmp from working directory test.
Fix readonly case which should not fail to create working
dir. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/tmpfile/Dockerfile",
"diff": "+# Create file under /tmp to ensure files inside '/tmp' are not overridden.\n+FROM alpine:3.11.5\n+RUN mkdir -p /tmp/foo \\\n+ && echo 123 > /tmp/foo/file.txt\n"
},
{
"change_type": "MODIFY",
"old... | Go | Apache License 2.0 | google/gvisor | Fix TestTmpFile
Split check for file in /tmp from working directory test.
Fix readonly case which should not fail to create working
dir.
PiperOrigin-RevId: 312702930 |
259,885 | 21.05.2020 14:01:26 | 25,200 | 198642df7689852062be9e3847a98e02d1bcbfd9 | Fix IsRunningWithVFS1() on the runsc-based test runner.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/runner/runner.go",
"new_path": "test/runner/runner.go",
"diff": "@@ -341,11 +341,13 @@ func runTestCaseRunsc(testBin string, tc gtest.TestCase, t *testing.T) {\n}\n}\n- // Set environment variables that indicate we are\n- // running in gVisor with the giv... | Go | Apache License 2.0 | google/gvisor | Fix IsRunningWithVFS1() on the runsc-based test runner.
Updates #1035
PiperOrigin-RevId: 312736450 |
259,860 | 21.05.2020 16:31:13 | 25,200 | ba2bf9fc13c204ad05d9fbb7199b890e6faf1d76 | Skip socket tests only if running on vfs1. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket.cc",
"new_path": "test/syscalls/linux/socket.cc",
"diff": "@@ -62,9 +62,7 @@ TEST(SocketTest, ProtocolInet) {\n}\nTEST(SocketTest, UnixSocketStat) {\n- // TODO(gvisor.dev/issue/1624): Re-enable this test once VFS1 is deleted. It\n- /... | Go | Apache License 2.0 | google/gvisor | Skip socket tests only if running on vfs1.
PiperOrigin-RevId: 312763249 |
259,869 | 23.05.2020 11:00:27 | 0 | 76d0aa47f48dfbc1bb5a9d4bd17a1de367946e22 | Fix typo in 'make tests' recipe
test_tag_filter => test_tag_filters
Ref: | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -116,7 +116,7 @@ unit-tests: ## Runs all unit tests in pkg runsc and tools.\n.PHONY: unit-tests\ntests: ## Runs all local ptrace system call tests.\n- @$(MAKE) test OPTIONS=\"--test_tag_filter runsc_ptrace test/sy... | Go | Apache License 2.0 | google/gvisor | Fix typo in 'make tests' recipe
test_tag_filter => test_tag_filters
Ref: https://docs.bazel.build/versions/master/command-line-reference.html#flag--test_tag_filters |
259,994 | 24.05.2020 17:29:25 | 10,800 | 9e8000e9fb0c61e1ffaf455a065c527959d66932 | Add cwd option to spec cmd | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/spec.go",
"new_path": "runsc/cmd/spec.go",
"diff": "@@ -16,6 +16,7 @@ package cmd\nimport (\n\"context\"\n+ \"fmt\"\n\"io/ioutil\"\n\"os\"\n\"path/filepath\"\n@@ -24,7 +25,8 @@ import (\n\"gvisor.dev/gvisor/runsc/flag\"\n)\n-var specTemplate = []byte... | Go | Apache License 2.0 | google/gvisor | Add cwd option to spec cmd |
259,985 | 13.05.2020 19:57:27 | 14,400 | 7938d8734870404c083379d2a73f7cd37fd2eda8 | Write initial design doc for FUSE. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/fs/g3doc/.gitignore",
"diff": "+*.html\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sentry/fs/g3doc/fuse.md",
"diff": "+# Foreword\n+\n+This document describes an on-going project to support FUS... | Go | Apache License 2.0 | google/gvisor | Write initial design doc for FUSE. |
259,885 | 26.05.2020 22:42:54 | 25,200 | e028714a0dd390b2321c4beeac62c5b2904cd917 | Support dfltuid and dfltgid mount options in the VFS2 gofer client. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -84,12 +84,6 @@ type filesystem struct {\n// devMinor is the filesystem's minor device number. devMinor is immutable.\ndevMinor uint32\n- // uid and gid are the effe... | Go | Apache License 2.0 | google/gvisor | Support dfltuid and dfltgid mount options in the VFS2 gofer client.
PiperOrigin-RevId: 313332542 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.