author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,853 | 27.05.2020 10:16:09 | 25,200 | 17d500f907c7bfc4d8365cceb4b305e9e3e6733c | g3doc/fuse: add more references | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/g3doc/fuse.md",
"new_path": "pkg/sentry/fs/g3doc/fuse.md",
"diff": "@@ -99,7 +99,7 @@ ops can be implemented in parallel.\n## FUSE Protocol\nThe FUSE protocol is a request-response protocol. All requests are initiated by\n-the client. The wire-fo... | Go | Apache License 2.0 | google/gvisor | g3doc/fuse: add more references |
259,858 | 27.05.2020 10:47:42 | 25,200 | 0bc022b7f3c13bb7c5c8d47d1781820161e7b1ad | Fix push for Go branch. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -19,6 +19,12 @@ jobs:\n\"${{ github.event.pull_request.statuses_url }}\"\nif: github.event_name == 'pull_request'\n- uses: actions/checkout@v2\n+ if: github.event_name == 'push'\n+ ... | Go | Apache License 2.0 | google/gvisor | Fix push for Go branch.
PiperOrigin-RevId: 313419745 |
259,858 | 27.05.2020 15:46:07 | 25,200 | 26bbecf00f51e8dca60ce8b1d33f7ebbbf92d268 | Ensure sitemap is generated. | [
{
"change_type": "MODIFY",
"old_path": "images/jekyll/Dockerfile",
"new_path": "images/jekyll/Dockerfile",
"diff": "@@ -8,5 +8,6 @@ RUN gem install \\\njekyll-paginate:1.1.0 \\\nkramdown-parser-gfm:1.1.0 \\\njekyll-relative-links:0.6.1 \\\n- jekyll-feed:0.13.0\n+ jekyll-feed:0.13.0 \\\n+ jekyll-site... | Go | Apache License 2.0 | google/gvisor | Ensure sitemap is generated.
PiperOrigin-RevId: 313478820 |
259,854 | 28.05.2020 14:42:01 | 25,200 | 7b79370c105b28a1cffa2d12d81898fc6b278728 | Add pcap logging to pcaketimpact.
This makes debugging packetimpact tests much easier. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/packetimpact_test.go",
"new_path": "test/packetimpact/runner/packetimpact_test.go",
"diff": "@@ -18,9 +18,12 @@ package packetimpact_test\nimport (\n\"flag\"\n\"fmt\"\n+ \"io/ioutil\"\n\"log\"\n\"math/rand\"\n\"net\"\n+ \"os\"\n+ \"os/... | Go | Apache License 2.0 | google/gvisor | Add pcap logging to pcaketimpact.
This makes debugging packetimpact tests much easier.
PiperOrigin-RevId: 313662654 |
259,992 | 28.05.2020 14:45:52 | 25,200 | f7418e21590e271302a3c375323950c209ce5ced | Move Cleanup to its own package | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/cleanup/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"cleanup\",\n+ srcs = [\"cleanup.go\"],\n+ visibility = [\"//:sandbox\"],\n+ deps = [\n+ ],\n... | Go | Apache License 2.0 | google/gvisor | Move Cleanup to its own package
PiperOrigin-RevId: 313663382 |
259,891 | 28.05.2020 16:44:15 | 25,200 | c55b84e16aeb4481106661e3877c50edbf281762 | Enable iptables source filtering (-s/--source) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -64,6 +64,8 @@ const enableLogging = false\nvar emptyFilter = stack.IPHeaderFilter{\nDst: \"\\x00\\x00\\x00\\x00\",\nDstMask: \"\\x00\\x00\\x00\\x00\... | Go | Apache License 2.0 | google/gvisor | Enable iptables source filtering (-s/--source) |
259,860 | 29.05.2020 11:27:00 | 25,200 | 9ada8c972e43e0c3e144b432fe57d95f823a1847 | Fix the smallest of typos. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/kernfs.go",
"new_path": "pkg/sentry/fsimpl/kernfs/kernfs.go",
"diff": "@@ -239,7 +239,7 @@ func (d *Dentry) Watches() *vfs.Watches {\n// InsertChild inserts child into the vfs dentry cache with the given name under\n// this dentry. Thi... | Go | Apache License 2.0 | google/gvisor | Fix the smallest of typos.
PiperOrigin-RevId: 313817646 |
259,860 | 29.05.2020 12:27:15 | 25,200 | ccf69bdd7e05a4e5f404fbef89a7f49f218645e2 | Implement IN_EXCL_UNLINK inotify option in vfs2.
Limited to tmpfs. Inotify support in other filesystem implementations to
follow.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/dentry.go",
"new_path": "pkg/sentry/fsimpl/ext/dentry.go",
"diff": "@@ -64,7 +64,7 @@ func (d *dentry) DecRef() {\n// InotifyWithParent implements vfs.DentryImpl.InotifyWithParent.\n//\n// TODO(gvisor.dev/issue/1479): Implement inotify.\n... | Go | Apache License 2.0 | google/gvisor | Implement IN_EXCL_UNLINK inotify option in vfs2.
Limited to tmpfs. Inotify support in other filesystem implementations to
follow.
Updates #1479
PiperOrigin-RevId: 313828648 |
260,023 | 29.05.2020 12:27:55 | 25,200 | 089c88f2e87fb14cead02caea7f9dba0a5957395 | Move TCP to CLOSED from SYN-RCVD on RST.
RST handling is broken when the TCP state transitions
from SYN-SENT to SYN-RCVD in case of simultaneous open.
An incoming RST should trigger cleanup of the endpoint.
RFC793, section 3.9, page 70.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1347,6 +1347,7 @@ func (e *endpoint) protocolMainLoop(handshake bool, wakerInitDone chan<- struct{\ne.setEndpointState(StateError)\ne.HardError = err\n+ e.worke... | Go | Apache License 2.0 | google/gvisor | Move TCP to CLOSED from SYN-RCVD on RST.
RST handling is broken when the TCP state transitions
from SYN-SENT to SYN-RCVD in case of simultaneous open.
An incoming RST should trigger cleanup of the endpoint.
RFC793, section 3.9, page 70.
Fixes #2814
PiperOrigin-RevId: 313828777 |
260,003 | 29.05.2020 12:58:50 | 25,200 | 341be65421edff16fd9eeb593301ce1d66148772 | Update WritePacket* API to take ownership of packets to be written.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -1304,13 +1304,16 @@ func (n *NIC) forwardPacket(r *Route, protocol tcpip.NetworkProtocolNumber, pkt\npkt.Header = buffer.NewPrependable(linkHeaderLen)\n}\n+ // WritePacket takes owners... | Go | Apache License 2.0 | google/gvisor | Update WritePacket* API to take ownership of packets to be written.
Updates #2404.
PiperOrigin-RevId: 313834784 |
259,858 | 29.05.2020 13:19:53 | 25,200 | c017ca8138e0f271b99f68a494cb37bfaeba5a54 | Fix issue with make copy targets. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -173,7 +173,8 @@ $(RELEASE_KEY):\nrelease: $(RELEASE_KEY) ## Builds a release.\n@mkdir -p $(RELEASE_ROOT)\n@T=$$(mktemp -d /tmp/release.XXXXXX); \\\n- $(MAKE) copy TARGETS=\"runsc runsc:runsc-debian\" DESTINATION=... | Go | Apache License 2.0 | google/gvisor | Fix issue with make copy targets.
PiperOrigin-RevId: 313838809 |
259,891 | 29.05.2020 15:37:34 | 25,200 | 790811f75783cd3cb82b6aba5e8152129b2d1d4d | Fix copied comment mistakes. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/filter_input.go",
"new_path": "test/iptables/filter_input.go",
"diff": "@@ -670,7 +670,7 @@ func (FilterInputInvertDestination) LocalAction(ip net.IP) error {\nreturn sendUDPLoop(ip, acceptPort, sendloopDuration)\n}\n-// FilterInputSource verifie... | Go | Apache License 2.0 | google/gvisor | Fix copied comment mistakes.
PiperOrigin-RevId: 313862843 |
259,881 | 29.05.2020 15:40:06 | 25,200 | 65569cfca08a99e3700108cec64f3aa443c357b0 | Update Go version build tags
None of the dependencies have changed in 1.15. It may be possible to simplify
some of the wrappers in rawfile following 1.13, but that can come in a later
change. | [
{
"change_type": "MODIFY",
"old_path": "pkg/procid/procid_amd64.s",
"new_path": "pkg/procid/procid_amd64.s",
"diff": "// +build amd64\n// +build go1.8\n-// +build !go1.15\n+// +build !go1.16\n#include \"textflag.h\"\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/procid/procid_arm64.s"... | Go | Apache License 2.0 | google/gvisor | Update Go version build tags
None of the dependencies have changed in 1.15. It may be possible to simplify
some of the wrappers in rawfile following 1.13, but that can come in a later
change.
PiperOrigin-RevId: 313863264 |
259,898 | 29.05.2020 17:22:56 | 25,200 | a9b47390c821942d60784e308f681f213645049c | Test TCP should queue RECEIVE request in SYN-SENT | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/dut/posix_server.cc",
"new_path": "test/packetimpact/dut/posix_server.cc",
"diff": "@@ -158,6 +158,14 @@ class PosixImpl final : public posix_server::Posix::Service {\nreturn ::grpc::Status::OK;\n}\n+ ::grpc::Status Fcntl(grpc_impl::ServerCon... | Go | Apache License 2.0 | google/gvisor | Test TCP should queue RECEIVE request in SYN-SENT
PiperOrigin-RevId: 313878910 |
259,962 | 01.06.2020 09:56:52 | 25,200 | 839208f118793c665f48a057d1f35d74979b7916 | Enable TCP Receive buffer moderation in gonet and benchmark.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/tcp/tcp_benchmark.sh",
"new_path": "benchmarks/tcp/tcp_benchmark.sh",
"diff": "@@ -94,6 +94,9 @@ while [ $# -gt 0 ]; do\n--cubic)\nnetstack_opts=\"${netstack_opts} -cubic\"\n;;\n+ --moderate-recv-buf)\n+ netstack_opts=\"${netstack_opts} -moderate_re... | Go | Apache License 2.0 | google/gvisor | Enable TCP Receive buffer moderation in gonet and benchmark.
Fixes #1666
PiperOrigin-RevId: 314148384 |
259,858 | 01.06.2020 10:27:59 | 25,200 | 2c6c4365ea3ad23166353aa03643fc009669ee93 | Move to make for tag release workflow.
This will make tag & release workflows idempotent. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -158,10 +158,16 @@ website-deploy: website-push ## Deploy a new version of the website.\n## RELEASE_ROOT - The repository root (default: \"repo\" directory).\n## RELEASE_KEY - The repository GPG private key file (... | Go | Apache License 2.0 | google/gvisor | Move to make for tag release workflow.
This will make tag & release workflows idempotent.
PiperOrigin-RevId: 314154888 |
259,992 | 01.06.2020 11:43:05 | 25,200 | 16100d18cbe27f01e1f0c147f91a694518ddc160 | Make gofer mount readonly when overlay is enabled
No writes are expected to the underlying filesystem when
using --overlay. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -168,7 +168,7 @@ func (g *Gofer) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\n// Start with root mount, then add any other additional mount as needed.\nats := make([]p9.Att... | Go | Apache License 2.0 | google/gvisor | Make gofer mount readonly when overlay is enabled
No writes are expected to the underlying filesystem when
using --overlay.
PiperOrigin-RevId: 314171457 |
259,860 | 01.06.2020 13:28:49 | 25,200 | 07c3b1dc5561f8ceb376cba1d79a41cd4b7a2533 | Skip proc/pid/fd socket test for VFS1 only. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_unix.cc",
"new_path": "test/syscalls/linux/socket_unix.cc",
"diff": "@@ -256,10 +256,9 @@ TEST_P(UnixSocketPairTest, ShutdownWrite) {\n}\nTEST_P(UnixSocketPairTest, SocketReopenFromProcfs) {\n- // TODO(b/122310852): We should be retu... | Go | Apache License 2.0 | google/gvisor | Skip proc/pid/fd socket test for VFS1 only.
PiperOrigin-RevId: 314192359 |
259,860 | 01.06.2020 13:29:17 | 25,200 | 35a3f462d9ccc5237f0200fcbeafaebb110b5134 | Fix inotify test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/inotify.cc",
"new_path": "test/syscalls/linux/inotify.cc",
"diff": "@@ -593,12 +593,12 @@ TEST(Inotify, SizeZeroReadWriteGeneratesNothing) {\nTEST(Inotify, FailedFileCreationGeneratesNoEvents) {\nconst TempPath dir = ASSERT_NO_ERRNO_AND_VAL... | Go | Apache License 2.0 | google/gvisor | Fix inotify test.
PiperOrigin-RevId: 314192441 |
259,885 | 01.06.2020 15:31:59 | 25,200 | 3a987160aa09f814a8459ed3f6192ce741b701a3 | Handle gofer blocking opens of host named pipes in VFS2.
Using tee instead of read to detect when a O_RDONLY|O_NONBLOCK pipe FD has a
writer circumvents the problem of what to do with the byte read from the pipe,
avoiding much of the complexity of the fdpipe package. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/BUILD",
"new_path": "pkg/sentry/fsimpl/gofer/BUILD",
"diff": "@@ -35,6 +35,7 @@ go_library(\n\"fstree.go\",\n\"gofer.go\",\n\"handle.go\",\n+ \"host_named_pipe.go\",\n\"p9file.go\",\n\"regular_file.go\",\n\"socket.go\",\n@@ -47,6 +48,7 ... | Go | Apache License 2.0 | google/gvisor | Handle gofer blocking opens of host named pipes in VFS2.
Using tee instead of read to detect when a O_RDONLY|O_NONBLOCK pipe FD has a
writer circumvents the problem of what to do with the byte read from the pipe,
avoiding much of the complexity of the fdpipe package.
PiperOrigin-RevId: 314216146 |
259,885 | 01.06.2020 18:11:35 | 25,200 | 49a9b78f74fca28cc9312dfb29ccbe70e3b5fcc3 | Fix VFS2 gofer open(O_CREAT) reference leak.
gofer.filesystem.createAndOpenChildLocked() doesn't need to take a reference on
the new dentry since vfs.FileDescription.Init() will do so. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -760,7 +760,7 @@ afterTrailingSymlink:\nparent.dirMu.Unlock()\nreturn nil, syserror.EPERM\n}\n- fd, err := parent.createAndOpenChildLocked(ctx, rp, &opts)\... | Go | Apache License 2.0 | google/gvisor | Fix VFS2 gofer open(O_CREAT) reference leak.
gofer.filesystem.createAndOpenChildLocked() doesn't need to take a reference on
the new dentry since vfs.FileDescription.Init() will do so.
PiperOrigin-RevId: 314242127 |
259,860 | 01.06.2020 18:30:09 | 25,200 | 050d8e6e331e01d732471e4641dc51346e7a7d3b | Add inotify events for extended attributes and splice.
Splice, setxattr and removexattr should generate events. Note that VFS2 already
generates events for extended attributes.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"new_path": "pkg/sentry/syscalls/linux/sys_splice.go",
"diff": "@@ -80,6 +80,12 @@ func doSplice(t *kernel.Task, outFile, inFile *fs.File, opts fs.SpliceOpts, nonB\n}\n}\n+ if total > 0 {\n+ // On Linux, inotify behavi... | Go | Apache License 2.0 | google/gvisor | Add inotify events for extended attributes and splice.
Splice, setxattr and removexattr should generate events. Note that VFS2 already
generates events for extended attributes.
Updates #1479.
PiperOrigin-RevId: 314244261 |
259,992 | 01.06.2020 21:30:28 | 25,200 | ca5912d13c63dcaff72bf6eb6d49bde8fc4e3f73 | More runsc changes for VFS2
Add /tmp handling
Apply mount options
Enable more container_test tests
Forward signals to child process when test respaws process
to run as root inside namespace.
Updates | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -217,6 +217,7 @@ dev: ## Installs a set of local runtimes. Requires sudo.\n@$(MAKE) configure RUNTIME=\"$(RUNTIME)\" ARGS=\"--net-raw\"\n@$(MAKE) configure RUNTIME=\"$(RUNTIME)-d\" ARGS=\"--net-raw --debug --strac... | Go | Apache License 2.0 | google/gvisor | More runsc changes for VFS2
- Add /tmp handling
- Apply mount options
- Enable more container_test tests
- Forward signals to child process when test respaws process
to run as root inside namespace.
Updates #1487
PiperOrigin-RevId: 314263281 |
259,992 | 01.06.2020 23:01:35 | 25,200 | 4b5eae39f201ffbe7f4a0e08a28380099469efe8 | Enable VFS2 to runsc syscall tests
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -60,7 +60,8 @@ def _syscall_test(\nnetwork = \"none\",\nfile_access = \"exclusive\",\noverlay = False,\n- add_uds_tree = False):\n+ add_uds_tree = False,\n+ vfs2 = False):\n# Prepend \"runs... | Go | Apache License 2.0 | google/gvisor | Enable VFS2 to runsc syscall tests
Updates #1487
PiperOrigin-RevId: 314271995 |
260,022 | 02.06.2020 22:08:23 | 0 | 5173c960212a2d78d69e94f028629cbcac8c04f9 | Add some detail to milestone
This change adds more information about what needs to be done
to implement `/dev/fuse` | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/g3doc/fuse.md",
"new_path": "pkg/sentry/fs/g3doc/fuse.md",
"diff": "@@ -76,7 +76,8 @@ ops can be implemented in parallel.\n#### Minimal client that can mount a trivial FUSE filesystem.\n-- Implement `/dev/fuse`.\n+- Implement `/dev/fuse` - a char... | Go | Apache License 2.0 | google/gvisor | Add some detail to milestone #1
This change adds more information about what needs to be done
to implement `/dev/fuse` |
259,853 | 02.06.2020 19:17:53 | 25,200 | e6334e81ca8d951e56f03d8ea0629e3c85556cf1 | Check that two sockets with different types can't be connected to each other | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/connectioned.go",
"new_path": "pkg/sentry/socket/unix/transport/connectioned.go",
"diff": "@@ -252,7 +252,7 @@ func (e *connectionedEndpoint) Close() {\n// BidirectionalConnect implements BoundEndpoint.BidirectionalConnect.\nfu... | Go | Apache License 2.0 | google/gvisor | Check that two sockets with different types can't be connected to each other
PiperOrigin-RevId: 314450191 |
260,023 | 03.06.2020 08:48:23 | 25,200 | 162848e129e50e25c3bb9c5fdc337584b3531da0 | Avoid TCP segment split when out of sender window.
If the entire segment cannot be accommodated in the receiver advertised
window and if there are still unacknowledged pending segments, skip
splitting the segment. The segment transmit would get retried by the
retransmit handler. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -816,6 +816,25 @@ func (s *sender) maybeSendSegment(seg *segment, limit int, end seqnum.Value) (se\npanic(\"Netstack queues FIN segments without data.\")\n}\n+ segEnd = ... | Go | Apache License 2.0 | google/gvisor | Avoid TCP segment split when out of sender window.
If the entire segment cannot be accommodated in the receiver advertised
window and if there are still unacknowledged pending segments, skip
splitting the segment. The segment transmit would get retried by the
retransmit handler.
PiperOrigin-RevId: 314538523 |
259,885 | 03.06.2020 11:01:34 | 25,200 | c8e79683891db9e780449112f78ee4004a2de833 | Take Mount reference in VFS.connectLocked.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/README.md",
"new_path": "pkg/sentry/vfs/README.md",
"diff": "@@ -39,8 +39,8 @@ Mount references are held by:\n- Mount: Each referenced Mount holds a reference on its parent, which is the\nmount containing its mount point.\n-- VirtualFilesystem: ... | Go | Apache License 2.0 | google/gvisor | Take Mount reference in VFS.connectLocked.
Updates #179
PiperOrigin-RevId: 314563830 |
259,858 | 03.06.2020 11:30:49 | 25,200 | fa9c9055053172ba8653c9543e4195e0207c7543 | Fix test release commands to work with older GPG.
The --quick-generate-key command wasn't added until recently. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -171,12 +171,20 @@ RELEASE_COMMIT :=\nRELEASE_NAME :=\nRELEASE_NOTES :=\n+GPG_TEST_OPTIONS := $(shell if gpg --pinentry-mode loopback --version >/dev/null 2>&1; then echo --pinentry-mode loopback; fi)\n$(RELEASE_K... | Go | Apache License 2.0 | google/gvisor | Fix test release commands to work with older GPG.
The --quick-generate-key command wasn't added until recently.
PiperOrigin-RevId: 314570297 |
259,881 | 03.06.2020 11:33:39 | 25,200 | b2e2a081a8a180764677111ae3c0b6179be81d31 | Add metric for startup watchdog timeout | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -77,7 +77,10 @@ var DefaultOpts = Opts{\n// trigger it.\nconst descheduleThreshold = 1 * time.Second\n-var stuckTasks = metric.MustCreateNewUint64Metric(\"/watchdog/st... | Go | Apache License 2.0 | google/gvisor | Add metric for startup watchdog timeout
PiperOrigin-RevId: 314570894 |
259,975 | 03.06.2020 14:54:46 | 25,200 | d8d86f0f3afdf0d46a556e7925ed54c5f4dc0bbf | Add test for O_TRUNC
b/36576592 calls out an edge case previously not supported
by HostFS. HostFS is currently being removed, meaning gVisor
supports this feature. Simply add the test to open_test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/open.cc",
"new_path": "test/syscalls/linux/open.cc",
"diff": "@@ -416,6 +416,29 @@ TEST_F(OpenTest, CanTruncateWriteOnlyNoReadPermission_NoRandomSave) {\nEXPECT_EQ(stat.st_size, 0);\n}\n+TEST_F(OpenTest, CanTruncateWithStrangePermissions) {... | Go | Apache License 2.0 | google/gvisor | Add test for O_TRUNC
b/36576592 calls out an edge case previously not supported
by HostFS. HostFS is currently being removed, meaning gVisor
supports this feature. Simply add the test to open_test.
PiperOrigin-RevId: 314610226 |
259,853 | 04.06.2020 17:16:57 | 25,200 | 9e66ac4c20dcfa2f4aaa4b149736f34f6b2bc451 | test/syscall: run hostnet tests in separate network namespaces
A few tests use hard coded port numbers, so we need to guruantee that
these ports will not be used for somthing else. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -93,6 +93,7 @@ def _syscall_test(\n# we figure out how to request ipv4 sockets on Guitar machines.\nif network == \"host\":\ntags.append(\"noguitar\")\n+ tags.append(\"block-network\")\n# D... | Go | Apache License 2.0 | google/gvisor | test/syscall: run hostnet tests in separate network namespaces
A few tests use hard coded port numbers, so we need to guruantee that
these ports will not be used for somthing else. |
259,853 | 04.06.2020 12:01:22 | 25,200 | d61e88e342d74d306a654b85d5ed791078f96f0a | Remove gvisor/pkg/tmutex
It isn't used. | [
{
"change_type": "DELETE",
"old_path": "pkg/tmutex/BUILD",
"new_path": null,
"diff": "-load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n-\n-package(licenses = [\"notice\"])\n-\n-go_library(\n- name = \"tmutex\",\n- srcs = [\"tmutex.go\"],\n- visibility = [\"//:sandbox\"],\n-)\n-\n-go_test(\n... | Go | Apache License 2.0 | google/gvisor | Remove gvisor/pkg/tmutex
It isn't used.
PiperOrigin-RevId: 314775492 |
260,003 | 04.06.2020 15:38:33 | 25,200 | 41da7a568b1e4f46b3bc09724996556fb18b4d16 | Fix copylocks error about copying IPTables.
IPTables.connections contains a sync.RWMutex. Copying it will trigger copylocks
analysis. Tested by manually enabling nogo tests.
sync.RWMutex is added to IPTables for the additional race condition discovered. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -144,31 +144,27 @@ func GetEntries(t *kernel.Task, stack *stack.Stack, outPtr usermem.Addr, outLen\n}\nfunc findTable(stk *stack.Stack, tablename lin... | Go | Apache License 2.0 | google/gvisor | Fix copylocks error about copying IPTables.
IPTables.connections contains a sync.RWMutex. Copying it will trigger copylocks
analysis. Tested by manually enabling nogo tests.
sync.RWMutex is added to IPTables for the additional race condition discovered.
PiperOrigin-RevId: 314817019 |
259,985 | 05.06.2020 14:26:16 | 25,200 | 6d9a68ca41eb8470dd492624916fcf50382050fa | Centralize the categories of endpoint states. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -63,7 +63,8 @@ const (\nStateClosing\n)\n-// connected is the set of states where an endpoint is connected to a peer.\n+// connected returns true when s is one... | Go | Apache License 2.0 | google/gvisor | Centralize the categories of endpoint states.
PiperOrigin-RevId: 314996457 |
259,853 | 05.06.2020 14:43:56 | 25,200 | 8c1f5b5cd8b634a5e7255944f42e82c5c9de3149 | Unshare files on exec
The current task can share its fdtable with a few other tasks,
but after exec, this should be a completely separate process. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_exec.go",
"new_path": "pkg/sentry/kernel/task_exec.go",
"diff": "@@ -198,6 +198,10 @@ func (r *runSyscallAfterExecStop) execute(t *Task) taskRunState {\nt.tg.oldRSeqCritical.Store(&OldRSeqCriticalRegion{})\nt.tg.pidns.owner.mu.Unlock()\n... | Go | Apache License 2.0 | google/gvisor | Unshare files on exec
The current task can share its fdtable with a few other tasks,
but after exec, this should be a completely separate process.
PiperOrigin-RevId: 314999565 |
259,858 | 05.06.2020 16:37:24 | 25,200 | f385e581a51e7f9800fe7b41835d58e45e29aefa | Drop flaky tag. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/BUILD",
"new_path": "pkg/tcpip/adapters/gonet/BUILD",
"diff": "@@ -22,7 +22,6 @@ go_test(\nsize = \"small\",\nsrcs = [\"gonet_test.go\"],\nlibrary = \":gonet\",\n- tags = [\"flaky\"],\ndeps = [\n\"//pkg/tcpip\",\n\"//pkg/tcpip/header\"... | Go | Apache License 2.0 | google/gvisor | Drop flaky tag.
PiperOrigin-RevId: 315018295 |
259,891 | 03.06.2020 19:57:39 | 25,200 | 74a7d76c9777820fcd7bd6002481eb959f58e247 | iptables: loopback traffic skips prerouting chain
Loopback traffic is not affected by rules in the PREROUTING chain.
This change is also necessary for istio's envoy to talk to other
components in the same pod. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -258,38 +258,24 @@ func (e *endpoint) WritePacket(r *stack.Route, gso *stack.GSO, params stack.Netw\nreturn nil\n}\n- if pkt.NatDone {\n// If the packet is manipulated a... | Go | Apache License 2.0 | google/gvisor | iptables: loopback traffic skips prerouting chain
Loopback traffic is not affected by rules in the PREROUTING chain.
This change is also necessary for istio's envoy to talk to other
components in the same pod. |
259,858 | 05.06.2020 16:50:47 | 25,200 | 8d8dce418f7e4053f80b035ff257743b431859d9 | Add stale issue & PR cleanup. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".github/workflows/stale.yml",
"diff": "+name: \"Close stale issues\"\n+on:\n+ schedule:\n+ - cron: \"0 0 * * *\"\n+\n+jobs:\n+ stale:\n+ runs-on: ubuntu-latest\n+ steps:\n+ - uses: actions/stale@v3\n+ with:\n+ repo-token: ${{ secrets.GITHUB_TOKE... | Go | Apache License 2.0 | google/gvisor | Add stale issue & PR cleanup.
PiperOrigin-RevId: 315020368 |
259,858 | 05.06.2020 17:24:12 | 25,200 | 527d08f6afdea1e142c76b8abb2266525a98c2ea | Add +checkescape annotations to kvm/ring0.
This analysis also catches a potential bug, which is a split on mapPhysical.
This would have led to potential guest-exit during Mapping (although this
would have been handled by the now-unecessary retryInGuest loop). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/BUILD",
"new_path": "pkg/sentry/platform/kvm/BUILD",
"diff": "@@ -6,8 +6,8 @@ go_library(\nname = \"kvm\",\nsrcs = [\n\"address_space.go\",\n- \"allocator.go\",\n\"bluepill.go\",\n+ \"bluepill_allocator.go\",\n\"bluepill_amd64.go\",\n\"... | Go | Apache License 2.0 | google/gvisor | Add +checkescape annotations to kvm/ring0.
This analysis also catches a potential bug, which is a split on mapPhysical.
This would have led to potential guest-exit during Mapping (although this
would have been handled by the now-unecessary retryInGuest loop).
PiperOrigin-RevId: 315025106 |
259,885 | 08.06.2020 13:27:06 | 25,200 | dc029b4b96e92719b2850e9d5556f68837737997 | Implement VFS2 tmpfs mount options.
As in VFS1, the mode, uid, and gid options are supported.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/device_file.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/device_file.go",
"diff": "@@ -29,7 +29,7 @@ type deviceFile struct {\nminor uint32\n}\n-func (fs *filesystem) newDeviceFile(creds *auth.Credentials, mode linux.FileMode, kind vfs.Dev... | Go | Apache License 2.0 | google/gvisor | Implement VFS2 tmpfs mount options.
As in VFS1, the mode, uid, and gid options are supported.
Updates #1197
PiperOrigin-RevId: 315340510 |
259,992 | 08.06.2020 23:06:50 | 25,200 | 4e96b94915633cc06bf04bd680f4eeba6a764dc9 | Combine executable lookup code
Run vs. exec, VFS1 vs. VFS2 were executable lookup were
slightly different from each other. Combine them all
into the same logic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/BUILD",
"new_path": "pkg/sentry/control/BUILD",
"diff": "@@ -16,15 +16,12 @@ go_library(\n],\ndeps = [\n\"//pkg/abi/linux\",\n- \"//pkg/context\",\n\"//pkg/fd\",\n- \"//pkg/fspath\",\n\"//pkg/log\",\n\"//pkg/sentry/fdimport\",\n\"//pkg/sentr... | Go | Apache License 2.0 | google/gvisor | Combine executable lookup code
Run vs. exec, VFS1 vs. VFS2 were executable lookup were
slightly different from each other. Combine them all
into the same logic.
PiperOrigin-RevId: 315426443 |
259,891 | 09.06.2020 10:45:31 | 25,200 | 20afd66e019bf0aaaf66e854135cd2c0fe0dfd92 | Invoke bazel query via bash function. | [
{
"change_type": "MODIFY",
"old_path": "scripts/common_build.sh",
"new_path": "scripts/common_build.sh",
"diff": "@@ -63,6 +63,10 @@ function run_as_root() {\nbazel run --run_under=\"sudo\" \"${binary}\" -- \"$@\"\n}\n+function query() {\n+ QUERY_RESULT=$(bazel query \"$@\")\n+}\n+\nfunction collect... | Go | Apache License 2.0 | google/gvisor | Invoke bazel query via bash function.
PiperOrigin-RevId: 315514034 |
259,885 | 09.06.2020 11:14:24 | 25,200 | ecff24930cb2dd5b0910da859d6e712f2f1d32c4 | Ensure pgalloc.MemoryFile.fileSize is always chunk-aligned.
findAvailableLocked() may return a non-aligned FileRange.End after expansion
since it may round FileRange.Start down to a hugepage boundary. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/pgalloc/pgalloc.go",
"new_path": "pkg/sentry/pgalloc/pgalloc.go",
"diff": "@@ -393,16 +393,17 @@ func (f *MemoryFile) Allocate(length uint64, kind usage.MemoryKind) (platform.Fi\nreturn platform.FileRange{}, syserror.ENOMEM\n}\n- // Expand the file ... | Go | Apache License 2.0 | google/gvisor | Ensure pgalloc.MemoryFile.fileSize is always chunk-aligned.
findAvailableLocked() may return a non-aligned FileRange.End after expansion
since it may round FileRange.Start down to a hugepage boundary.
PiperOrigin-RevId: 315520321 |
259,992 | 09.06.2020 16:28:58 | 25,200 | 0ae5bd24d72a6809a8ffb9c6a31fd2621180e3df | Mount root and volumes as read-only if --overlay is enabled | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -306,7 +306,7 @@ func setupRootFS(spec *specs.Spec, conf *boot.Config) error {\n}\n// Replace the current spec, with the clean spec with symlinks resolved.\n- if err := setupMounts(spec.Mounts,... | Go | Apache License 2.0 | google/gvisor | Mount root and volumes as read-only if --overlay is enabled
PiperOrigin-RevId: 315583963 |
259,992 | 09.06.2020 16:34:42 | 25,200 | 6722b1e56fa63f3409f222a63241705aa3f3ace4 | Don't WriteOut to readonly mounts
When the file closes, it attempts to write dirty cached
attributes to the file. This should not be done when the
mount is readonly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/inode.go",
"new_path": "pkg/sentry/fs/gofer/inode.go",
"diff": "@@ -640,7 +640,7 @@ func (i *inodeOperations) Allocate(ctx context.Context, inode *fs.Inode, offset,\n// WriteOut implements fs.InodeOperations.WriteOut.\nfunc (i *inodeOperati... | Go | Apache License 2.0 | google/gvisor | Don't WriteOut to readonly mounts
When the file closes, it attempts to write dirty cached
attributes to the file. This should not be done when the
mount is readonly.
PiperOrigin-RevId: 315585058 |
259,992 | 10.06.2020 06:50:10 | 25,200 | 203dc121f6fb3122e3bc0f234f4b4e4b276fb3b0 | Redirect TODOs to more specific issues
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/vdso.go",
"new_path": "pkg/sentry/loader/vdso.go",
"diff": "@@ -75,7 +75,7 @@ var _ fs.FileOperations = (*byteReader)(nil)\n// newByteReaderFile creates a fake file to read data from.\n//\n-// TODO(gvisor.dev/issue/1623): Convert to VFS2.\n+/... | Go | Apache License 2.0 | google/gvisor | Redirect TODOs to more specific issues
Closes #1623
PiperOrigin-RevId: 315681993 |
259,881 | 10.06.2020 12:37:01 | 25,200 | fadbfd83d9e7f7b00fcffdaf8532e006327c74ad | Include panic message in log | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/server.go",
"new_path": "pkg/p9/server.go",
"diff": "@@ -482,10 +482,10 @@ func (cs *connState) handle(m message) (r message) {\ndefer func() {\nif r == nil {\n// Don't allow a panic to propagate.\n- recover()\n+ err := recover()\n// Include a useful lo... | Go | Apache License 2.0 | google/gvisor | Include panic message in log
PiperOrigin-RevId: 315745386 |
259,853 | 10.06.2020 13:25:17 | 25,200 | a5a4f804879f8d1b5e6de6005aef6d3e14e7dca2 | socket/unix: handle sendto address argument for connected sockets
In case of SOCK_SEQPACKET, it has to be ignored.
In case of SOCK_STREAM, EISCONN or EOPNOTSUPP has to be returned. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/unix.go",
"new_path": "pkg/sentry/socket/unix/unix.go",
"diff": "@@ -459,6 +459,15 @@ func (s *socketOpsCommon) SendMsg(t *kernel.Task, src usermem.IOSequence, to []b\nTo: nil,\n}\nif len(to) > 0 {\n+ switch s.stype {\n+ case linux.SOCK_... | Go | Apache License 2.0 | google/gvisor | socket/unix: handle sendto address argument for connected sockets
In case of SOCK_SEQPACKET, it has to be ignored.
In case of SOCK_STREAM, EISCONN or EOPNOTSUPP has to be returned.
PiperOrigin-RevId: 315755972 |
259,896 | 10.06.2020 13:36:02 | 25,200 | 4b9652d63b319414e764696f1b77ee39cd36d96d | {S,G}etsockopt for TCP_KEEPCNT option.
TCP_KEEPCNT is used to set the maximum keepalive probes to be
sent before dropping the connection.
WANT_LGTM=jchacon | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/tcp.go",
"new_path": "pkg/abi/linux/tcp.go",
"diff": "@@ -57,4 +57,5 @@ const (\nconst (\nMAX_TCP_KEEPIDLE = 32767\nMAX_TCP_KEEPINTVL = 32767\n+ MAX_TCP_KEEPCNT = 127\n)\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/... | Go | Apache License 2.0 | google/gvisor | {S,G}etsockopt for TCP_KEEPCNT option.
TCP_KEEPCNT is used to set the maximum keepalive probes to be
sent before dropping the connection.
WANT_LGTM=jchacon
PiperOrigin-RevId: 315758094 |
259,896 | 10.06.2020 15:05:20 | 25,200 | 9338854ea31059d6b6b5bf59a12512455b632f49 | Fix the error code for syscall test with null TOS.
The setsockopt with nullptr can fail with either EFAULT or zero. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_unbound.cc",
"new_path": "test/syscalls/linux/socket_ip_unbound.cc",
"diff": "@@ -377,8 +377,11 @@ TEST_P(IPUnboundSocketTest, NullTOS) {\n//\n// Linux's implementation would need fixing as passing a nullptr as optval\n// and non-... | Go | Apache License 2.0 | google/gvisor | Fix the error code for syscall test with null TOS.
The setsockopt with nullptr can fail with either EFAULT or zero.
PiperOrigin-RevId: 315777107 |
259,992 | 10.06.2020 16:28:20 | 25,200 | 41d9e536d559a2066ed6c92ed30aa2757d3596bb | Skip pids.max if value is zero
LinuxPids.Limit is the only optional cgroup field in OCI that
is not a pointer. If value is 0 or negative it should be
skipped. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -545,7 +545,7 @@ func (*networkPrio) set(spec *specs.LinuxResources, path string) error {\ntype pids struct{}\nfunc (*pids) set(spec *specs.LinuxResources, path string) error {\n- if sp... | Go | Apache License 2.0 | google/gvisor | Skip pids.max if value is zero
LinuxPids.Limit is the only optional cgroup field in OCI that
is not a pointer. If value is 0 or negative it should be
skipped.
PiperOrigin-RevId: 315791909 |
259,992 | 10.06.2020 17:03:38 | 25,200 | ab4c85189313097dbac5d5531f9ff6a08d9ba289 | Cgroup fixes
Set hugetlb related fields
Add realtime scheduler related fields
Beef up unit tests
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/BUILD",
"new_path": "runsc/cgroup/BUILD",
"diff": "@@ -20,4 +20,8 @@ go_test(\nsrcs = [\"cgroup_test.go\"],\nlibrary = \":cgroup\",\ntags = [\"local\"],\n+ deps = [\n+ \"//pkg/test/testutil\",\n+ \"@com_github_opencontainers_runtime-spec//specs-go... | Go | Apache License 2.0 | google/gvisor | Cgroup fixes
- Set hugetlb related fields
- Add realtime scheduler related fields
- Beef up unit tests
Updates #2713
PiperOrigin-RevId: 315797979 |
259,881 | 11.06.2020 09:11:44 | 25,200 | 0c7a5bc69c19de59c426045d10a56613f992f0dd | Add nogo TODO. | [
{
"change_type": "MODIFY",
"old_path": "tools/defs.bzl",
"new_path": "tools/defs.bzl",
"diff": "@@ -96,6 +96,7 @@ def go_imports(name, src, out):\ncmd = (\"$(location @org_golang_x_tools//cmd/goimports:goimports) $(SRCS) > $@\"),\n)\n+# TODO(b/158696872): Enable nogo by default.\ndef go_library(name... | Go | Apache License 2.0 | google/gvisor | Add nogo TODO.
PiperOrigin-RevId: 315911025 |
259,992 | 11.06.2020 14:55:04 | 25,200 | d58d57606a460d49b8870d2c48cb75f662f65fda | Don't copy structs with sync.Mutex during initialization
During inititalization inode struct was copied around, but
it isn't great pratice to copy it around since it contains
ref count and sync.Mutex.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/ext/block_map_file.go",
"new_path": "pkg/sentry/fsimpl/ext/block_map_file.go",
"diff": "@@ -58,15 +58,16 @@ var _ io.ReaderAt = (*blockMapFile)(nil)\n// newBlockMapFile is the blockMapFile constructor. It initializes the file to\n// physical ... | Go | Apache License 2.0 | google/gvisor | Don't copy structs with sync.Mutex during initialization
During inititalization inode struct was copied around, but
it isn't great pratice to copy it around since it contains
ref count and sync.Mutex.
Updates #1480
PiperOrigin-RevId: 315983788 |
260,004 | 11.06.2020 16:08:06 | 25,200 | 4c0a8bdaf5e21ac85a4275e9008e5cd4294f45f3 | Do not use tentative addresses for routes
Tentative addresses should not be used when finding a route. This change
fixes a bug where a tentative address may have been used.
Test: stack_test.TestDADResolve | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/ndp_test.go",
"new_path": "pkg/tcpip/stack/ndp_test.go",
"diff": "@@ -421,28 +421,52 @@ func TestDADResolve(t *testing.T) {\nt.Fatalf(\"CreateNIC(%d, _) = %s\", nicID, err)\n}\n+ // We add a default route so the call to FindRoute below will suc... | Go | Apache License 2.0 | google/gvisor | Do not use tentative addresses for routes
Tentative addresses should not be used when finding a route. This change
fixes a bug where a tentative address may have been used.
Test: stack_test.TestDADResolve
PiperOrigin-RevId: 315997624 |
259,992 | 11.06.2020 17:32:42 | 25,200 | fbe41987c999729ceec6851ff64acc9013a0c602 | Enable nogo again | [
{
"change_type": "MODIFY",
"old_path": "tools/defs.bzl",
"new_path": "tools/defs.bzl",
"diff": "@@ -96,8 +96,7 @@ def go_imports(name, src, out):\ncmd = (\"$(location @org_golang_x_tools//cmd/goimports:goimports) $(SRCS) > $@\"),\n)\n-# TODO(b/158696872): Enable nogo by default.\n-def go_library(nam... | Go | Apache License 2.0 | google/gvisor | Enable nogo again
PiperOrigin-RevId: 316011323 |
259,854 | 11.06.2020 18:02:58 | 25,200 | dc4e0157ef09632a25575810a70846ea81c4dd6b | Add test for reordering.
Tests the effect of reordering on retransmission and window size.
Test covers the expected behavior of both Linux and netstack, however, netstack
does not behave as expected. Further, the current expected behavior of netstack
is not ideal and should be adjusted in the future. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/proto/posix_server.proto",
"new_path": "test/packetimpact/proto/posix_server.proto",
"diff": "@@ -150,7 +150,7 @@ message SendRequest {\nmessage SendResponse {\nint32 ret = 1;\n- int32 errno_ = 2;\n+ int32 errno_ = 2; // \"errno\" may fail to... | Go | Apache License 2.0 | google/gvisor | Add test for reordering.
Tests the effect of reordering on retransmission and window size.
Test covers the expected behavior of both Linux and netstack, however, netstack
does not behave as expected. Further, the current expected behavior of netstack
is not ideal and should be adjusted in the future.
PiperOrigin-RevId: 316015184 |
259,858 | 11.06.2020 19:03:46 | 25,200 | 5a894e35a090232085fbb20c71d1787c266bd995 | Remove generated logs when test succeeds. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/runner.go",
"new_path": "test/runner/runner.go",
"diff": "@@ -160,8 +160,9 @@ func runRunsc(tc gtest.TestCase, spec *specs.Spec) error {\nargs = append(args, \"-fsgofer-host-uds\")\n}\n- if outDir, ok := syscall.Getenv(\"TEST_UNDECLARED_OUTPUTS_DIR... | Go | Apache License 2.0 | google/gvisor | Remove generated logs when test succeeds.
PiperOrigin-RevId: 316022884 |
259,884 | 11.06.2020 19:29:34 | 25,200 | 8ea99d58ffd708aa7a26be58d89cb817d8eceec6 | Set the HOME environment variable for sub-containers.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/criutil/criutil.go",
"new_path": "pkg/test/criutil/criutil.go",
"diff": "@@ -113,6 +113,17 @@ func (cc *Crictl) Exec(contID string, args ...string) (string, error) {\nreturn output, nil\n}\n+// Logs retrieves the container logs. It corresponds to `cri... | Go | Apache License 2.0 | google/gvisor | Set the HOME environment variable for sub-containers.
Fixes #701
PiperOrigin-RevId: 316025635 |
260,023 | 11.06.2020 19:45:06 | 25,200 | 61d6c059ac3434ddf0c206975a116a09d0838338 | Replace use of %v in packetimpact tests | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/ipv4_id_uniqueness_test.go",
"new_path": "test/packetimpact/tests/ipv4_id_uniqueness_test.go",
"diff": "@@ -37,7 +37,7 @@ func recvTCPSegment(conn *testbench.TCPIPv4, expect *testbench.TCP, expectPayloa\nreturn 0, fmt.Errorf(\"failed to... | Go | Apache License 2.0 | google/gvisor | Replace use of %v in packetimpact tests
PiperOrigin-RevId: 316027588 |
259,853 | 12.06.2020 11:56:43 | 25,200 | 6ec9d60403fdf7a33072eaa023e62bfd56ed9f5c | vfs2: implement fcntl(fd, F_SETFL, flags) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -458,6 +458,29 @@ func (f *FDTable) SetFlags(fd int32, flags FDFlags) error {\nreturn nil\n}\n+// SetFlagsVFS2 sets the flags for the given file descriptor.\n+//\n+// True... | Go | Apache License 2.0 | google/gvisor | vfs2: implement fcntl(fd, F_SETFL, flags)
PiperOrigin-RevId: 316148074 |
259,854 | 12.06.2020 20:47:28 | 25,200 | 3b5eaad3c8b49367d1812dbaf4182fc7282b7f00 | Allow reading IP_MULTICAST_LOOP and IP_MULTICAST_TTL on TCP sockets.
I am not really sure what the point of this is, but someone filed a bug about
it, so I assume something relies on it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1855,6 +1855,9 @@ func (e *endpoint) GetSockOptBool(opt tcpip.SockOptBool) (bool, *tcpip.Error) {\nreturn v, nil\n+ case tcpip.MulticastLoopOption:\n+ return ... | Go | Apache License 2.0 | google/gvisor | Allow reading IP_MULTICAST_LOOP and IP_MULTICAST_TTL on TCP sockets.
I am not really sure what the point of this is, but someone filed a bug about
it, so I assume something relies on it.
PiperOrigin-RevId: 316225127 |
259,985 | 15.06.2020 01:08:00 | 25,200 | f23f62c2c2bcfb3196b67e64b4a73f820f150caa | Correctly set the test VFS environment variable.
Also fix test bugs uncovered now that they aren't silently skipped on
VFS2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/runner/runner.go",
"new_path": "test/runner/runner.go",
"diff": "@@ -352,11 +352,15 @@ func runTestCaseRunsc(testBin string, tc gtest.TestCase, t *testing.T) {\n// Set environment variables that indicate we are running in gVisor with\n// the given platfor... | Go | Apache License 2.0 | google/gvisor | Correctly set the test VFS environment variable.
Also fix test bugs uncovered now that they aren't silently skipped on
VFS2.
Updates #1487.
PiperOrigin-RevId: 316415807 |
259,881 | 15.06.2020 13:34:33 | 25,200 | 885605c5e412f9ced42766094368c86be1002cff | Remove blacklist from //test/runtimes
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/BUILD",
"new_path": "test/runtimes/BUILD",
"diff": "@@ -4,30 +4,30 @@ package(licenses = [\"notice\"])\nruntime_test(\nname = \"go1.12\",\n- blacklist_file = \"blacklist_go1.12.csv\",\n+ exclude_file = \"exclude_go1.12.csv\",\nlang = \"go\",\n)\n... | Go | Apache License 2.0 | google/gvisor | Remove blacklist from //test/runtimes
Updates #2972
PiperOrigin-RevId: 316534165 |
259,885 | 16.06.2020 00:14:07 | 25,200 | 3b0b1f104d963a1d11973c444934e6744ab7e79b | Miscellaneous VFS2 fixes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -835,6 +835,14 @@ func (d *dentry) statTo(stat *linux.Statx) {\nstat.Mask = linux.STATX_TYPE | linux.STATX_MODE | linux.STATX_NLINK | linux.STATX_UID | linux.STATX_G... | Go | Apache License 2.0 | google/gvisor | Miscellaneous VFS2 fixes.
PiperOrigin-RevId: 316627764 |
259,992 | 16.06.2020 10:50:29 | 25,200 | bae1475603b03a38726da743430c761fb36ee338 | Print spec as json when --debug is enabled
The previous format skipped many important structs that
are pointers, especially for cgroups. Change to print
as json, removing parts of the spec that are not relevant.
Also removed debug message from gofer that can be very
noisy when directories are large. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -175,8 +175,6 @@ func (a *attachPoint) makeQID(stat syscall.Stat_t) p9.QID {\nlog.Warningf(\"first 8 bytes of host inode id %x will be truncated to construct virtual inode id\", sta... | Go | Apache License 2.0 | google/gvisor | Print spec as json when --debug is enabled
The previous format skipped many important structs that
are pointers, especially for cgroups. Change to print
as json, removing parts of the spec that are not relevant.
Also removed debug message from gofer that can be very
noisy when directories are large.
PiperOrigin-RevId: 316713267 |
259,885 | 16.06.2020 16:14:26 | 25,200 | e61acfb5eaec4450587116573f708284a0fe7849 | Correctly handle multiple resizings in pgalloc.findAvailableRange(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/pgalloc/pgalloc.go",
"new_path": "pkg/sentry/pgalloc/pgalloc.go",
"diff": "@@ -441,53 +441,61 @@ func (f *MemoryFile) Allocate(length uint64, kind usage.MemoryKind) (platform.Fi\n// Precondition: alignment must be a power of 2.\nfunc findAvailableRa... | Go | Apache License 2.0 | google/gvisor | Correctly handle multiple resizings in pgalloc.findAvailableRange().
PiperOrigin-RevId: 316778032 |
260,023 | 17.06.2020 10:45:03 | 25,200 | 50afec55c75dfd5bb88d100f77e17048dfbb3322 | TCP stat fixes
Ensure that CurrentConnected stat is updated on any errors and cleanups
during connected state processing.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1516,6 +1516,7 @@ func (e *endpoint) protocolMainLoop(handshake bool, wakerInitDone chan<- struct{\n// Main loop. Handle segments until both send and receive en... | Go | Apache License 2.0 | google/gvisor | TCP stat fixes
Ensure that CurrentConnected stat is updated on any errors and cleanups
during connected state processing.
Fixes #2968
PiperOrigin-RevId: 316919426 |
259,860 | 17.06.2020 11:32:23 | 25,200 | e5d97cbcc1e64185b8fab1cf563c8754edd2e52e | Refactor host.canMap.
Simplify the canMap check. We do not have plans to allow mmap for anything
beyond regular files, so we can just inline canMap() as a simple file mode
check.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -91,7 +91,9 @@ func NewFD(ctx context.Context, mnt *vfs.Mount, hostFD int, opts *NewFDOptions)\nisTTY: opts.IsTTY,\nwouldBlock: wouldBlock(uint32(fileType)),\nseekable: ... | Go | Apache License 2.0 | google/gvisor | Refactor host.canMap.
Simplify the canMap check. We do not have plans to allow mmap for anything
beyond regular files, so we can just inline canMap() as a simple file mode
check.
Updates #1672.
PiperOrigin-RevId: 316929654 |
259,881 | 17.06.2020 12:32:59 | 25,200 | 6d806ee7198422973a2e4efa9b539de7792b933f | Remove various uses of 'blacklist'
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/tty.go",
"new_path": "pkg/sentry/fs/host/tty.go",
"diff": "@@ -308,9 +308,9 @@ func (t *TTYFileOperations) checkChange(ctx context.Context, sig linux.Signal) e\ntask := kernel.TaskFromContext(ctx)\nif task == nil {\n// No task? Linux does no... | Go | Apache License 2.0 | google/gvisor | Remove various uses of 'blacklist'
Updates #2972
PiperOrigin-RevId: 316942245 |
259,962 | 17.06.2020 14:07:27 | 25,200 | 505e8f4e3d72400194a69c220ce2f4288e957c4c | Fix TtlDefault test on linux.
Different flavors of linux seem to use different defaults we accept 64
or 127 as the TtlDefault in the test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_unbound.cc",
"new_path": "test/syscalls/linux/socket_ip_unbound.cc",
"diff": "@@ -40,7 +40,7 @@ TEST_P(IPUnboundSocketTest, TtlDefault) {\nsocklen_t get_sz = sizeof(get);\nEXPECT_THAT(getsockopt(socket->get(), IPPROTO_IP, IP_TTL, ... | Go | Apache License 2.0 | google/gvisor | Fix TtlDefault test on linux.
Different flavors of linux seem to use different defaults we accept 64
or 127 as the TtlDefault in the test.
PiperOrigin-RevId: 316961150 |
259,854 | 17.06.2020 15:14:17 | 25,200 | 02072fd243a1e88b635dd6a24dd512608fbfce5f | Add test for stat("/proc/net/snmp"). | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc_net.cc",
"new_path": "test/syscalls/linux/proc_net.cc",
"diff": "@@ -441,6 +441,11 @@ TEST(ProcNetSnmp, CheckNetStat) {\nEXPECT_EQ(value_count, 4);\n}\n+TEST(ProcNetSnmp, Stat) {\n+ struct stat st = {};\n+ ASSERT_THAT(stat(\"/proc/net/... | Go | Apache License 2.0 | google/gvisor | Add test for stat("/proc/net/snmp").
PiperOrigin-RevId: 316974863 |
260,004 | 17.06.2020 17:21:19 | 25,200 | 57286eb642b9becc566f8e9c1dcbe24619f7772b | Increase timeouts for NDP tests
... to help reduce flakes.
When waiting for an event to occur, use a timeout of 10s. When waiting
for an event to not occur, use a timeout of 1s.
Test: Ran test locally w/ run count of 1000 with and without gotsan. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/ndp_test.go",
"new_path": "pkg/tcpip/stack/ndp_test.go",
"diff": "@@ -43,8 +43,17 @@ const (\nlinkAddr2 = tcpip.LinkAddress(\"\\x02\\x02\\x03\\x04\\x05\\x07\")\nlinkAddr3 = tcpip.LinkAddress(\"\\x02\\x02\\x03\\x04\\x05\\x08\")\nlinkAddr4 = tcpi... | Go | Apache License 2.0 | google/gvisor | Increase timeouts for NDP tests
... to help reduce flakes.
When waiting for an event to occur, use a timeout of 10s. When waiting
for an event to not occur, use a timeout of 1s.
Test: Ran test locally w/ run count of 1000 with and without gotsan.
PiperOrigin-RevId: 316998128 |
259,992 | 17.06.2020 18:41:55 | 25,200 | 97f6b20e89d99c4d92d6491ef3fad0933c9ba53d | Move mount configutation to RunOpts
Separate mount configuration from links and move it to
RunOpts, like the other options. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/dockerutil.go",
"new_path": "pkg/test/dockerutil/dockerutil.go",
"diff": "@@ -210,7 +210,6 @@ type Docker struct {\nRuntime string\nName string\ncopyErr error\n- mounts []string\ncleanups []func()\n}\n@@ -229,13 +228,8 @@ func MakeDocker(lo... | Go | Apache License 2.0 | google/gvisor | Move mount configutation to RunOpts
Separate mount configuration from links and move it to
RunOpts, like the other options.
PiperOrigin-RevId: 317010158 |
259,992 | 17.06.2020 19:08:14 | 25,200 | 22b0bb21383614f6258dee27f4a254d2da97b586 | Add TempTmpMount test
This currently doesn't work with VSF2. Add test to ensure
it's not missed.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/e2e/integration_test.go",
"new_path": "test/e2e/integration_test.go",
"diff": "@@ -24,10 +24,12 @@ package integration\nimport (\n\"flag\"\n\"fmt\"\n+ \"io/ioutil\"\n\"net\"\n\"net/http\"\n\"os\"\n\"os/exec\"\n+ \"path/filepath\"\n\"strconv\"\n\"strings\"... | Go | Apache License 2.0 | google/gvisor | Add TempTmpMount test
This currently doesn't work with VSF2. Add test to ensure
it's not missed.
Updates #1487
PiperOrigin-RevId: 317013792 |
259,992 | 17.06.2020 21:21:08 | 25,200 | 6e0c170522279ca72119b17c41e2e1dc93c49d6a | Implement Sync() to directories
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/directory.go",
"new_path": "pkg/sentry/fsimpl/gofer/directory.go",
"diff": "@@ -299,3 +299,8 @@ func (fd *directoryFD) Seek(ctx context.Context, offset int64, whence int32) (in\nreturn 0, syserror.EINVAL\n}\n}\n+\n+// Sync implements vf... | Go | Apache License 2.0 | google/gvisor | Implement Sync() to directories
Updates #1035, #1199
PiperOrigin-RevId: 317028108 |
260,004 | 18.06.2020 00:08:55 | 25,200 | 09b2fca40c61f9ec8d6745f422f6f45b399e8f94 | Cleanup tcp.timer and tcpip.Route
When a tcp.timer or tcpip.Route is no longer used, clean up its
resources so that unused memory may be released. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1033,14 +1033,14 @@ func (s *Stack) removeNICLocked(id tcpip.NICID) *tcpip.Error {\n// Remove routes in-place. n tracks the number of routes written.\nn := 0\nfor i, r := range s.r... | Go | Apache License 2.0 | google/gvisor | Cleanup tcp.timer and tcpip.Route
When a tcp.timer or tcpip.Route is no longer used, clean up its
resources so that unused memory may be released.
PiperOrigin-RevId: 317046582 |
259,881 | 18.06.2020 09:02:14 | 25,200 | 3970c127434817304f67a2ad192cbe8094ad3353 | Remove various uses of 'whitelist'
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/bpf/interpreter_test.go",
"new_path": "pkg/bpf/interpreter_test.go",
"diff": "@@ -767,7 +767,7 @@ func TestSimpleFilter(t *testing.T) {\nexpectedRet: 0,\n},\n{\n- desc: \"Whitelisted syscall is allowed\",\n+ desc: \"Allowed syscall is indeed allowed\",\nse... | Go | Apache License 2.0 | google/gvisor | Remove various uses of 'whitelist'
Updates #2972
PiperOrigin-RevId: 317113059 |
259,891 | 18.06.2020 13:05:14 | 25,200 | f1aa919181c066039a3022499de8076e523e3e7d | Ensure ip6tables module installed
This module isn't always loaded automatically. | [
{
"change_type": "MODIFY",
"old_path": "scripts/iptables_tests.sh",
"new_path": "scripts/iptables_tests.sh",
"diff": "@@ -18,6 +18,9 @@ source $(dirname $0)/common.sh\nmake load-iptables\n+# Needed by ip6tables.\n+sudo modprobe ip6table_filter\n+\ninstall_runsc_for_test iptables --net-raw\ntest //te... | Go | Apache License 2.0 | google/gvisor | Ensure ip6tables module installed
This module isn't always loaded automatically.
PiperOrigin-RevId: 317164471 |
260,003 | 18.06.2020 14:28:06 | 25,200 | f97122f44c5c4218bb2239686cd323358c661d60 | Acquire lock when accessing MultiDevice's cache in String(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/device/device.go",
"new_path": "pkg/sentry/device/device.go",
"diff": "@@ -188,6 +188,9 @@ type MultiDevice struct {\n// String stringifies MultiDevice.\nfunc (m *MultiDevice) String() string {\n+ m.mu.Lock()\n+ defer m.mu.Unlock()\n+\nbuf := bytes.... | Go | Apache License 2.0 | google/gvisor | Acquire lock when accessing MultiDevice's cache in String().
PiperOrigin-RevId: 317180925 |
259,992 | 18.06.2020 14:51:07 | 25,200 | 878050b5cf924b1f314965e5bfe21248a55616c4 | Enable more VFS2 syscall tests
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -33,6 +33,7 @@ syscall_test(\nsyscall_test(\nadd_overlay = True,\ntest = \"//test/syscalls/linux:aio_test\",\n+ vfs2 = \"True\",\n)\nsyscall_test(\n@@ -106,6 +107,7 @@ syscall_test(\nsyscall_... | Go | Apache License 2.0 | google/gvisor | Enable more VFS2 syscall tests
Updates #2923
PiperOrigin-RevId: 317185798 |
259,891 | 18.06.2020 17:00:47 | 25,200 | 28b8a5cc3ac538333756084da28d7f13f13b5c87 | iptables: remove metadata struct
Metadata was useful for debugging and safety, but enough tests exist that we
should see failures when (de)serialization is broken. It made stack
initialization more cumbersome and it's also getting in the way of ip6tables. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -41,19 +41,6 @@ const errorTargetName = \"ERROR\"\n// change the destination port/destination IP for packets.\nconst redirectTargetName = \"REDIRECT\... | Go | Apache License 2.0 | google/gvisor | iptables: remove metadata struct
Metadata was useful for debugging and safety, but enough tests exist that we
should see failures when (de)serialization is broken. It made stack
initialization more cumbersome and it's also getting in the way of ip6tables.
PiperOrigin-RevId: 317210653 |
259,891 | 18.06.2020 19:45:13 | 25,200 | 0c169b6ad598200a57db7bf0f679da1d6cb395c4 | iptables: skip iptables if no rules are set
Users that never set iptables rules shouldn't incur the iptables performance
cost. Suggested by Ian (@iangudger). | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -170,6 +170,7 @@ func (it *IPTables) GetTable(name string) (Table, bool) {\nfunc (it *IPTables) ReplaceTable(name string, table Table) {\nit.mu.Lock()\ndefer it.mu.Unlock()\n+... | Go | Apache License 2.0 | google/gvisor | iptables: skip iptables if no rules are set
Users that never set iptables rules shouldn't incur the iptables performance
cost. Suggested by Ian (@iangudger).
PiperOrigin-RevId: 317232921 |
259,860 | 18.06.2020 22:00:56 | 25,200 | 408f3d2cd64cae6b2f76a940c76236e9841c095f | Fix vfs2 tmpfs link permission checks.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -237,18 +237,22 @@ func (fs *filesystem) LinkAt(ctx context.Context, rp *vfs.ResolvingPath, vd vfs.\nreturn syserror.EXDEV\n}\nd := vd.Dentry().Impl().(*de... | Go | Apache License 2.0 | google/gvisor | Fix vfs2 tmpfs link permission checks.
Updates #2923.
PiperOrigin-RevId: 317246916 |
259,860 | 19.06.2020 05:55:35 | 25,200 | 46957ed24f21396683cf9aff13fa0cd3086ea466 | Fix synthetic file bugs in gofer fs.
Always check if a synthetic file already exists at a location before creating a
file there, and do not try to delete synthetic gofer files from the remote fs.
This fixes runsc_ptrace socket tests that create/unlink synthetic, named socket
files.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -374,13 +374,16 @@ func (fs *filesystem) doCreateAt(ctx context.Context, rp *vfs.ResolvingPath, dir\nreturn nil\n}\nif fs.opts.interop == InteropModeShared... | Go | Apache License 2.0 | google/gvisor | Fix synthetic file bugs in gofer fs.
Always check if a synthetic file already exists at a location before creating a
file there, and do not try to delete synthetic gofer files from the remote fs.
This fixes runsc_ptrace socket tests that create/unlink synthetic, named socket
files.
Updates #2923.
PiperOrigin-RevId: 317293648 |
259,860 | 19.06.2020 06:37:40 | 25,200 | 6b69b955d7613ff391984661a7269eabc86020e3 | Support all seek options in gofer specialFileFD.Seek.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -489,15 +489,24 @@ func (d *dentry) writeback(ctx context.Context, offset, size int64) error {\nfunc (fd *regularFileFD) Seek(ctx context.Context, offs... | Go | Apache License 2.0 | google/gvisor | Support all seek options in gofer specialFileFD.Seek.
Updates #2923.
PiperOrigin-RevId: 317298186 |
259,860 | 19.06.2020 08:44:26 | 25,200 | f40d023ad6f8c19898ca105842a88961b3c2994c | Don't adjust parent link count if we replace a child dir with another.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1196,7 +1196,8 @@ func (fs *filesystem) RenameAt(ctx context.Context, rp *vfs.ResolvingPath, oldPa\nif newParent.cachedMetadataAuthoritative() {\nnewParen... | Go | Apache License 2.0 | google/gvisor | Don't adjust parent link count if we replace a child dir with another.
Updates #2923.
PiperOrigin-RevId: 317314460 |
259,860 | 19.06.2020 10:18:35 | 25,200 | a609fff9d1516a095341c2016ec36f952550a46f | Fix vfs2 handling of preadv2/pwritev2 flags.
Check for unsupported flags, and silently support RWF_HIPRI by doing nothing.
From pkg/abi/linux/file.go: "gVisor does not implement the RWF_HIPRI feature,
but the flag is accepted as a valid flag argument for preadv2/pwritev2."
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -72,7 +72,9 @@ func (fd *regularFileFD) PRead(ctx context.Context, dst usermem.IOSequence, offs\nif offset < 0 {\nreturn 0, syserror.EINVAL\n}\n- if op... | Go | Apache License 2.0 | google/gvisor | Fix vfs2 handling of preadv2/pwritev2 flags.
Check for unsupported flags, and silently support RWF_HIPRI by doing nothing.
From pkg/abi/linux/file.go: "gVisor does not implement the RWF_HIPRI feature,
but the flag is accepted as a valid flag argument for preadv2/pwritev2."
Updates #2923.
PiperOrigin-RevId: 317330631 |
259,860 | 19.06.2020 11:48:24 | 25,200 | 7db196c4dbb33562dbfaa28a9476c590f356b2b5 | Port fadvise64 to vfs2.
Like vfs1, we have a trivial implementation that ignores all valid advice.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -23,6 +23,7 @@ go_library(\n\"errors.go\",\n\"eventfd.go\",\n\"exec.go\",\n+ \"fadvise.go\",\n\"fcntl.go\",\n\"file.go\",\n\"file_amd64.go\",\n"
},
{
"change_type": "ADD",
"old_pa... | Go | Apache License 2.0 | google/gvisor | Port fadvise64 to vfs2.
Like vfs1, we have a trivial implementation that ignores all valid advice.
Updates #2923.
PiperOrigin-RevId: 317349505 |
259,860 | 19.06.2020 13:35:02 | 25,200 | 8655fb72482e179923987759f378543b2f489f08 | Fix vfs2 proc/self/fd dirent iteration.
Make proc/self/fd iteration work properly. Also, the comment on
kernfs.Inode.IterDirents did not accurately reflect how parameters should be
used/were used in kernfs.Inode impls other than fdDir.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/kernfs.go",
"new_path": "pkg/sentry/fsimpl/kernfs/kernfs.go",
"diff": "@@ -425,10 +425,10 @@ type inodeDynamicLookup interface {\n// IterDirents is used to iterate over dynamically created entries. It invokes\n// cb on each entry in th... | Go | Apache License 2.0 | google/gvisor | Fix vfs2 proc/self/fd dirent iteration.
Make proc/self/fd iteration work properly. Also, the comment on
kernfs.Inode.IterDirents did not accurately reflect how parameters should be
used/were used in kernfs.Inode impls other than fdDir.
Updates #2923.
PiperOrigin-RevId: 317370325 |
259,860 | 19.06.2020 14:39:31 | 25,200 | ad9f4691741cfada0ae09f73053d6195d43465ae | Fix bugs in vfs2 to make symlink tests pass.
Return ENOENT if target path is empty.
Make sure open(2) with O_CREAT|O_EXCL returns EEXIST when necessary.
Correctly update atime in tmpfs using touchATime().
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -79,7 +79,7 @@ afterSymlink:\n}\nif symlink, ok := child.inode.impl.(*symlink); ok && rp.ShouldFollowSymlink() {\n// Symlink traversal updates access time.... | Go | Apache License 2.0 | google/gvisor | Fix bugs in vfs2 to make symlink tests pass.
- Return ENOENT if target path is empty.
- Make sure open(2) with O_CREAT|O_EXCL returns EEXIST when necessary.
- Correctly update atime in tmpfs using touchATime().
Updates #2923.
PiperOrigin-RevId: 317382655 |
259,860 | 19.06.2020 18:26:04 | 25,200 | f46f4a2af98a2a5cf5dd54e71a1a2dc999d4b4b1 | Enable passing vfs2 tests.
I forgot to update getdents earlier. Several thousand runs of the fsync and
proc_net_unix tests all passed as well.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -240,6 +240,7 @@ syscall_test(\nsyscall_test(\nadd_overlay = True,\ntest = \"//test/syscalls/linux:fsync_test\",\n+ vfs2 = \"True\",\n)\nsyscall_test(\n@@ -262,6 +263,7 @@ syscall_test(\nsysc... | Go | Apache License 2.0 | google/gvisor | Enable passing vfs2 tests.
I forgot to update getdents earlier. Several thousand runs of the fsync and
proc_net_unix tests all passed as well.
Updates #2923.
PiperOrigin-RevId: 317415488 |
259,860 | 21.06.2020 21:46:57 | 25,200 | 00928d142dd580c44a392e8e51246b543dc4f957 | Fix vfs2 extended attributes.
Correct behavior when given zero size arguments and trying to set user.* xattrs
on files other than regular files or directories.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -1206,7 +1206,7 @@ func (d *dentry) setDeleted() {\n// We only support xattrs prefixed with \"user.\" (see b/148380782). Currently,\n// there is no need to expose an... | Go | Apache License 2.0 | google/gvisor | Fix vfs2 extended attributes.
Correct behavior when given zero size arguments and trying to set user.* xattrs
on files other than regular files or directories.
Updates #2923.
PiperOrigin-RevId: 317590409 |
259,927 | 22.06.2020 10:30:21 | 25,200 | 282a6aea1b375d447fdf502c6660e92eb5e19cd4 | Extract common nested LinkEndpoint pattern
... and unify logic for detached netsted endpoints.
sniffer.go caused crashes if a packet delivery is attempted when the dispatcher
is nil.
Extracted the endpoint nesting logic into a common composable type so it can be
used by the Fuchsia Netstack (the pattern is widespread there). | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/tcpip/link/nested/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"nested\",\n+ srcs = [\n+ \"nested.go\",\n+ ],\n+ visibility = [\"//visibility:publ... | Go | Apache License 2.0 | google/gvisor | Extract common nested LinkEndpoint pattern
... and unify logic for detached netsted endpoints.
sniffer.go caused crashes if a packet delivery is attempted when the dispatcher
is nil.
Extracted the endpoint nesting logic into a common composable type so it can be
used by the Fuchsia Netstack (the pattern is widespread there).
PiperOrigin-RevId: 317682842 |
259,860 | 22.06.2020 11:38:25 | 25,200 | 4573e7d863d59d59c6a4f72f396f72b0f6458cb2 | Check for invalid trailing / when traversing path in gofer OpenAt.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -767,15 +767,17 @@ afterTrailingSymlink:\nparent.dirMu.Unlock()\nreturn fd, err\n}\n- if err != nil {\nparent.dirMu.Unlock()\n+ if err != nil {\nreturn nil... | Go | Apache License 2.0 | google/gvisor | Check for invalid trailing / when traversing path in gofer OpenAt.
Updates #2923.
PiperOrigin-RevId: 317700049 |
259,860 | 22.06.2020 21:29:31 | 25,200 | 38d7b2fe5630a8f3169cfef7703921c4bc4056c2 | Only allow regular files, sockets, pipes, and char devices to be imported. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -462,7 +462,8 @@ func (i *inode) open(ctx context.Context, d *vfs.Dentry, mnt *vfs.Mount, flags u\n// TODO(gvisor.dev/issue/1672): implement behavior corresponding to th... | Go | Apache License 2.0 | google/gvisor | Only allow regular files, sockets, pipes, and char devices to be imported.
PiperOrigin-RevId: 317796028 |
260,003 | 23.06.2020 16:05:39 | 25,200 | 793edf4cb4597751b7f2b7b913a5ab7fa3d50373 | Deflake proc test: Don't fail on DT_UNKNOWN.
Per manual page:
"All applications must properly handle a return of DT_UNKNOWN." | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -1998,8 +1998,6 @@ void CheckDuplicatesRecursively(std::string path) {\n}\nchildren.insert(std::string(dp->d_name));\n- ASSERT_NE(dp->d_type, DT_UNKNOWN);\n-\nif (dp->d_type =... | Go | Apache License 2.0 | google/gvisor | Deflake proc test: Don't fail on DT_UNKNOWN.
Per manual page:
"All applications must properly handle a return of DT_UNKNOWN."
PiperOrigin-RevId: 317957013 |
260,003 | 23.06.2020 17:43:02 | 25,200 | acf519a77b480e8d974186568bd66eaa89bac024 | Nit fix: Create and use a std::string object for `const char*`. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -1982,24 +1982,26 @@ void CheckDuplicatesRecursively(std::string path) {\nbreak; // We're done.\n}\n- if (strcmp(dp->d_name, \".\") == 0 || strcmp(dp->d_name, \"..\") == 0) {\... | Go | Apache License 2.0 | google/gvisor | Nit fix: Create and use a std::string object for `const char*`.
PiperOrigin-RevId: 317973144 |
259,860 | 23.06.2020 18:31:53 | 25,200 | 65a587dedf1a30b3614a66532d2b448026b9c540 | Complete inotify IN_EXCL_UNLINK implementation in VFS2.
Events were only skipped on parent directories after their children were
unlinked; events on the unlinked file itself need to be skipped as well.
As a result, all Watches.Notify() calls need to know whether the dentry where
the call came from was unlinked.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -375,7 +375,7 @@ func (fs *filesystem) doCreateAt(ctx context.Context, rp *vfs.ResolvingPath, dir\nif dir {\nev |= linux.IN_ISDIR\n}\n- parent.watches.Noti... | Go | Apache License 2.0 | google/gvisor | Complete inotify IN_EXCL_UNLINK implementation in VFS2.
Events were only skipped on parent directories after their children were
unlinked; events on the unlinked file itself need to be skipped as well.
As a result, all Watches.Notify() calls need to know whether the dentry where
the call came from was unlinked.
Updates #1479.
PiperOrigin-RevId: 317979476 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.