author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,860 | 23.06.2020 20:04:15 | 25,200 | 399c52888db609296fd1341ed0daa994ad2d02b0 | Resolve remaining inotify TODOs.
Also refactor HandleDeletion().
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/kernfs.go",
"new_path": "pkg/sentry/fsimpl/kernfs/kernfs.go",
"diff": "@@ -227,19 +227,17 @@ func (d *Dentry) destroy() {\n// InotifyWithParent implements vfs.DentryImpl.InotifyWithParent.\n//\n-// TODO(gvisor.dev/issue/1479): Implemen... | Go | Apache License 2.0 | google/gvisor | Resolve remaining inotify TODOs.
Also refactor HandleDeletion().
Updates #1479.
PiperOrigin-RevId: 317989000 |
259,860 | 24.06.2020 19:20:58 | 25,200 | b5e814445a4db5df7f4f58027422a5dba97ea766 | Fix procfs bugs in vfs2.
Support writing on proc/[pid]/{uid,gid}map
Return EIO for writing to static files.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go",
"new_path": "pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go",
"diff": "@@ -101,12 +101,12 @@ func (fd *DynamicBytesFD) Seek(ctx context.Context, offset int64, whence int32)\nreturn fd.DynamicBytesFileDescription... | Go | Apache License 2.0 | google/gvisor | Fix procfs bugs in vfs2.
- Support writing on proc/[pid]/{uid,gid}map
- Return EIO for writing to static files.
Updates #2923.
PiperOrigin-RevId: 318188503 |
259,858 | 25.06.2020 09:17:17 | 25,200 | 00ee5abaa70965b1baad996f53d3dc2a17805fcf | Drop unused markdown links. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -113,7 +113,6 @@ See [SECURITY.md](SECURITY.md).\nSee [Contributing.md](CONTRIBUTING.md).\n[bazel]: https://bazel.build\n-[community]: https://gvisor.googlesource.com/community\n[docker]: https://www.docker.com\... | Go | Apache License 2.0 | google/gvisor | Drop unused markdown links.
PiperOrigin-RevId: 318284693 |
260,022 | 17.06.2020 16:23:27 | 14,400 | a63db7d90303280de9431f369e5a9c8db351a9e8 | Moved FUSE device under the fuse directory | [
{
"change_type": "DELETE",
"old_path": "pkg/sentry/devices/miscdev/miscdev.go",
"new_path": null,
"diff": "-// Copyright 2020 The gVisor Authors.\n-//\n-// Licensed under the Apache License, Version 2.0 (the \"License\");\n-// you may not use this file except in compliance with the License.\n-// You... | Go | Apache License 2.0 | google/gvisor | Moved FUSE device under the fuse directory |
260,022 | 23.06.2020 14:25:38 | 14,400 | 2828806fb015bbbec0f4a48670d1eb048f21099a | Test that the fuse device can be opened | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/vfs.go",
"new_path": "runsc/boot/vfs.go",
"diff": "@@ -80,9 +80,10 @@ func registerFilesystems(ctx context.Context, vfsObj *vfs.VirtualFilesystem, cre\n}\nif err := ttydev.Register(vfsObj); err != nil {\nreturn fmt.Errorf(\"registering ttydev: %w\",... | Go | Apache License 2.0 | google/gvisor | Test that the fuse device can be opened |
259,860 | 26.06.2020 13:46:01 | 25,200 | 54a31e219ca9d6086a367213a92d2a72ce3af07b | Support inotify IN_ONESHOT.
Also, while we're here, make sure that gofer inotify events are generated when
files are created in remote revalidating mode.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -389,7 +389,15 @@ func (fs *filesystem) doCreateAt(ctx context.Context, rp *vfs.ResolvingPath, dir\n// RPC will fail with EEXIST like we would have. If the... | Go | Apache License 2.0 | google/gvisor | Support inotify IN_ONESHOT.
Also, while we're here, make sure that gofer inotify events are generated when
files are created in remote revalidating mode.
Updates #1479.
PiperOrigin-RevId: 318536354 |
259,898 | 26.06.2020 15:07:35 | 25,200 | e6a90baef1e6921c560c939f4b591163004613b9 | Support IPv6 extension headers in packetimpact tests.
IPv6 HopByHop Options Extension Header
IPv6 Destination Options Extension Header | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/layers.go",
"new_path": "test/packetimpact/testbench/layers.go",
"diff": "@@ -477,6 +477,10 @@ func (l *IPv6) ToBytes() ([]byte, error) {\nfields.NextHeader = uint8(header.UDPProtocolNumber)\ncase *ICMPv6:\nfields.NextHeader = uint8... | Go | Apache License 2.0 | google/gvisor | Support IPv6 extension headers in packetimpact tests.
- IPv6 HopByHop Options Extension Header
- IPv6 Destination Options Extension Header
PiperOrigin-RevId: 318551425 |
259,891 | 26.06.2020 16:23:15 | 25,200 | 9cfc15497581824f1c6ba2b9f9ee653d0be0bc5a | Require CAP_SYS_ADMIN in the root user namespace for TTY theft | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/thread_group.go",
"new_path": "pkg/sentry/kernel/thread_group.go",
"diff": "@@ -366,7 +366,8 @@ func (tg *ThreadGroup) SetControllingTTY(tty *TTY, arg int32) error {\n// terminal is stolen, and all processes that had it as controlling\n// ter... | Go | Apache License 2.0 | google/gvisor | Require CAP_SYS_ADMIN in the root user namespace for TTY theft
PiperOrigin-RevId: 318563543 |
259,891 | 26.06.2020 19:04:59 | 25,200 | 66d1665441461a5226ba0c884e22888d58f393b6 | IPv6 raw sockets. Needed for ip6tables.
IPv6 raw sockets never include the IPv6 header. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -94,7 +94,7 @@ func NewEndpoint(stack *stack.Stack, netProto tcpip.NetworkProtocolNumber, trans\n}\nfunc newEndpoint(s *stack.Stack, netProto tcpip.NetworkProt... | Go | Apache License 2.0 | google/gvisor | IPv6 raw sockets. Needed for ip6tables.
IPv6 raw sockets never include the IPv6 header.
PiperOrigin-RevId: 318582989 |
259,860 | 26.06.2020 19:40:52 | 25,200 | 85be13d9a3faae27d0991b55cfb7944c9f1e1284 | Add tests for eventfd/timerfd/inotify operations that should return ESPIPE. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/eventfd.cc",
"new_path": "test/syscalls/linux/eventfd.cc",
"diff": "@@ -100,20 +100,21 @@ TEST(EventfdTest, SmallRead) {\nASSERT_THAT(read(efd.get(), &l, 4), SyscallFailsWithErrno(EINVAL));\n}\n-TEST(EventfdTest, PreadIllegalSeek) {\n- File... | Go | Apache License 2.0 | google/gvisor | Add tests for eventfd/timerfd/inotify operations that should return ESPIPE.
PiperOrigin-RevId: 318585377 |
259,854 | 26.06.2020 21:09:25 | 25,200 | bab3c36efb5486fdfbfa52d8baf810c7a7c7efd8 | Add style guide. | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -37,10 +37,8 @@ Dependencies can be added by using `go mod get`. In order to keep the\n### Coding Guidelines\n-All Go code should conform to the [Go style guidelines][gostyle]. C++ code\n-should conf... | Go | Apache License 2.0 | google/gvisor | Add style guide.
PiperOrigin-RevId: 318591900 |
259,860 | 27.06.2020 14:38:20 | 25,200 | 02d552d07c4415978d2ce418fb16baf238d0ff78 | Support sticky bit in vfs2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -16,6 +16,7 @@ package gofer\nimport (\n\"sync\"\n+ \"sync/atomic\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n@@ -464,21 +46... | Go | Apache License 2.0 | google/gvisor | Support sticky bit in vfs2.
Updates #2923.
PiperOrigin-RevId: 318648128 |
259,860 | 27.06.2020 21:32:16 | 25,200 | e8f1a5c1f652ba7abb8c4bd842d6afdcab03865a | Port GETOWN, SETOWN fcntls to vfs2.
Also make some fixes to vfs1's F_SETOWN. The fcntl test now entirely passes
on vfs2.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fcntl.go",
"new_path": "pkg/abi/linux/fcntl.go",
"diff": "@@ -55,7 +55,7 @@ type Flock struct {\n_ [4]byte\n}\n-// Flags for F_SETOWN_EX and F_GETOWN_EX.\n+// Owner types for F_SETOWN_EX and F_GETOWN_EX.\nconst (\nF_OWNER_TID = 0\nF_OWNER_PID = 1... | Go | Apache License 2.0 | google/gvisor | Port GETOWN, SETOWN fcntls to vfs2.
Also make some fixes to vfs1's F_SETOWN. The fcntl test now entirely passes
on vfs2.
Fixes #2920.
PiperOrigin-RevId: 318669529 |
259,983 | 30.06.2020 09:03:14 | 25,200 | 09b7791e89d9d487d03cf03cf2ba2d0fb1c9386a | Add missing ICRNL flag in master termios test
Closes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pty.cc",
"new_path": "test/syscalls/linux/pty.cc",
"diff": "@@ -634,6 +634,11 @@ TEST_F(PtyTest, TermiosAffectsSlave) {\n// Verify this by setting ICRNL (which rewrites input \\r to \\n) and verify that\n// it has no effect on the master.\n... | Go | Apache License 2.0 | google/gvisor | Add missing ICRNL flag in master termios test
Closes #2768 |
259,860 | 30.06.2020 15:28:06 | 25,200 | 44071cc7fae8a7143b0cd386b402375aafecd979 | Remove struct packing to fix compiler warning.
Waddress-of-packed-member warns on inet_aton() being used with a packed struct
member. This was added in cl/291990716. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_netlink_route.cc",
"new_path": "test/syscalls/linux/socket_netlink_route.cc",
"diff": "@@ -595,7 +595,7 @@ TEST(NetlinkRouteTest, GetRouteRequest) {\nASSERT_NO_ERRNO_AND_VALUE(NetlinkBoundSocket(NETLINK_ROUTE));\nuint32_t port = ASSE... | Go | Apache License 2.0 | google/gvisor | Remove struct packing to fix compiler warning.
-Waddress-of-packed-member warns on inet_aton() being used with a packed struct
member. This was added in cl/291990716.
PiperOrigin-RevId: 319111253 |
259,962 | 30.06.2020 19:00:13 | 25,200 | c4bdd0118f5dc9090979697e31a18731968b4066 | Add missing newline in /sys/devices/systen/cpu/onine | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/sys/sys.go",
"new_path": "pkg/sentry/fsimpl/sys/sys.go",
"diff": "@@ -138,7 +138,7 @@ type cpuFile struct {\n// Generate implements vfs.DynamicBytesSource.Generate.\nfunc (c *cpuFile) Generate(ctx context.Context, buf *bytes.Buffer) error {\n... | Go | Apache License 2.0 | google/gvisor | Add missing newline in /sys/devices/systen/cpu/onine
PiperOrigin-RevId: 319143410 |
259,860 | 30.06.2020 20:47:02 | 25,200 | 20d571b0c181023cc02521ad746a2b6d91e6794d | Allow O_DIRECT on vfs2 tmpfs files.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -407,7 +407,7 @@ func (d *dentry) open(ctx context.Context, rp *vfs.ResolvingPath, opts *vfs.Open\ncase *regularFile:\nvar fd regularFileFD\nfd.LockFD.Init... | Go | Apache License 2.0 | google/gvisor | Allow O_DIRECT on vfs2 tmpfs files.
Updates #2923.
PiperOrigin-RevId: 319153792 |
259,860 | 30.06.2020 20:59:32 | 25,200 | 43f5dd95a1c58a6e3260c31093bfc3f97885f4b0 | Fix index calculation for /proc/[pid]/cmdline.
We were truncating buf using a index relative to the middle of the slice (i.e.
where envv begins), but we need to calculate the index relative to the entire
slice.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/task_files.go",
"new_path": "pkg/sentry/fsimpl/proc/task_files.go",
"diff": "@@ -231,8 +231,9 @@ func (d *cmdlineData) Generate(ctx context.Context, buf *bytes.Buffer) error {\n// Linux will return envp up to and including the first NULL... | Go | Apache License 2.0 | google/gvisor | Fix index calculation for /proc/[pid]/cmdline.
We were truncating buf using a index relative to the middle of the slice (i.e.
where envv begins), but we need to calculate the index relative to the entire
slice.
Updates #2923.
PiperOrigin-RevId: 319154950 |
259,962 | 01.07.2020 06:57:38 | 25,200 | b8f165ab1cb4d4345d8a25f95a5bc0fece2d49c7 | Fix HTTPD benchmarks to correctly serve files from /tmp.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "benchmarks/workloads/httpd/BUILD",
"new_path": "benchmarks/workloads/httpd/BUILD",
"diff": "@@ -9,5 +9,6 @@ pkg_tar(\nname = \"tar\",\nsrcs = [\n\"Dockerfile\",\n+ \"apache2-tmpdir.conf\",\n],\n)\n"
},
{
"change_type": "MODIFY",
"old_path": "benchm... | Go | Apache License 2.0 | google/gvisor | Fix HTTPD benchmarks to correctly serve files from /tmp.
Fixes #3113
PiperOrigin-RevId: 319216671 |
259,860 | 01.07.2020 08:40:31 | 25,200 | cda2979b63fad37a33706f8aa430664a9c4d0b3b | Complete async signal delivery support in vfs2.
Support FIOASYNC, FIO{SET,GET}OWN, SIOC{G,S}PGRP (refactor getting/setting
owner in the process).
Unset signal recipient when setting owner with pid == 0 and
valid owner type.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fasync/fasync.go",
"new_path": "pkg/sentry/kernel/fasync/fasync.go",
"diff": "@@ -176,3 +176,13 @@ func (a *FileAsync) SetOwnerProcessGroup(requester *kernel.Task, recipient *kern\na.recipientTG = nil\na.recipientPG = recipient\n}\n+\n+// Cle... | Go | Apache License 2.0 | google/gvisor | Complete async signal delivery support in vfs2.
- Support FIOASYNC, FIO{SET,GET}OWN, SIOC{G,S}PGRP (refactor getting/setting
owner in the process).
- Unset signal recipient when setting owner with pid == 0 and
valid owner type.
Updates #2923.
PiperOrigin-RevId: 319231420 |
259,881 | 01.07.2020 08:51:57 | 25,200 | 068716ddf36f4dcb3d88e92b90774dcba2fe4db8 | Fix FAQ URL
The existing gvisor.dev/faq link returns 404 because the full URL has
mistakenly been capitalized. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/BUILD",
"new_path": "g3doc/user_guide/BUILD",
"diff": "@@ -33,7 +33,7 @@ doc(\nname = \"FAQ\",\nsrc = \"FAQ.md\",\ncategory = \"User Guide\",\n- permalink = \"/docs/user_guide/FAQ/\",\n+ permalink = \"/docs/user_guide/faq/\",\nweight = \"90\",... | Go | Apache License 2.0 | google/gvisor | Fix FAQ URL
The existing gvisor.dev/faq link returns 404 because the full URL has
mistakenly been capitalized.
PiperOrigin-RevId: 319233173 |
259,975 | 01.07.2020 13:13:04 | 25,200 | 6a90c88b97481a6d81b05f09d5c8ed7158225dd5 | Port fallocate to VFS2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/p9.go",
"new_path": "pkg/p9/p9.go",
"diff": "@@ -1091,6 +1091,19 @@ type AllocateMode struct {\nUnshare bool\n}\n+// ToAllocateMode returns an AllocateMode from a fallocate(2) mode.\n+func ToAllocateMode(mode uint64) AllocateMode {\n+ return AllocateMod... | Go | Apache License 2.0 | google/gvisor | Port fallocate to VFS2.
PiperOrigin-RevId: 319283715 |
259,860 | 01.07.2020 15:17:39 | 25,200 | e4b2087602a9217098559347d82d316a8cef8140 | Use directory fds in sticky test to avoid permission issues.
After we change credentials, it is possible that we no longer have access to
the sticky directory where we are trying to delete files. Use an open fd so
this is not an issue. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/sticky.cc",
"new_path": "test/syscalls/linux/sticky.cc",
"diff": "@@ -42,12 +42,15 @@ TEST(StickyTest, StickyBitPermDenied) {\nconst TempPath parent = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateDir());\nEXPECT_THAT(chmod(parent.path().c_str(... | Go | Apache License 2.0 | google/gvisor | Use directory fds in sticky test to avoid permission issues.
After we change credentials, it is possible that we no longer have access to
the sticky directory where we are trying to delete files. Use an open fd so
this is not an issue.
PiperOrigin-RevId: 319306255 |
260,023 | 01.07.2020 15:46:02 | 25,200 | 31b27adf9b63dcefd0a753908bf984aa1f78b394 | TCP receive should block when in SYN-SENT state.
The application can choose to initiate a non-blocking connect and
later block on a read, when the endpoint is still in SYN-SENT state. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1212,6 +1212,16 @@ func (e *endpoint) SetOwner(owner tcpip.PacketOwner) {\n// Read reads data from the endpoint.\nfunc (e *endpoint) Read(*tcpip.FullAddress) ... | Go | Apache License 2.0 | google/gvisor | TCP receive should block when in SYN-SENT state.
The application can choose to initiate a non-blocking connect and
later block on a read, when the endpoint is still in SYN-SENT state.
PiperOrigin-RevId: 319311016 |
259,860 | 01.07.2020 17:09:26 | 25,200 | 65d99855583a21b6ea511ea74aa52318d0a1e5b2 | Port vfs1 implementation of sync_file_range to vfs2.
Currently, we always perform a full-file sync which could be extremely
expensive for some applications. Although vfs1 did not fully support
sync_file_range, there were some optimizations that allowed us skip some
unnecessary write-outs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"diff": "@@ -235,8 +235,5 @@ func (fd *specialFileFD) Seek(ctx context.Context, offset int64, whence int32) (\n// Sync implements vfs.FileDescriptionImpl.Sync.\nfu... | Go | Apache License 2.0 | google/gvisor | Port vfs1 implementation of sync_file_range to vfs2.
Currently, we always perform a full-file sync which could be extremely
expensive for some applications. Although vfs1 did not fully support
sync_file_range, there were some optimizations that allowed us skip some
unnecessary write-outs.
Updates #2923, #1897.
PiperOrigin-RevId: 319324213 |
259,860 | 01.07.2020 17:39:07 | 25,200 | 3b26d2121e3afbbc005b5e919000d55a235b4bbe | Remove maxSendBufferSize from vfs2.
Complements cl/315991648. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/socket.go",
"new_path": "pkg/sentry/fsimpl/host/socket.go",
"diff": "@@ -47,11 +47,6 @@ func newEndpoint(ctx context.Context, hostFD int, queue *waiter.Queue) (transpor\nreturn ep, nil\n}\n-// maxSendBufferSize is the maximum host send b... | Go | Apache License 2.0 | google/gvisor | Remove maxSendBufferSize from vfs2.
Complements cl/315991648.
PiperOrigin-RevId: 319327853 |
259,907 | 01.07.2020 19:47:51 | 25,200 | 52b44719d6e14ec299d0d953b4dc07a712b897fa | [vfs2][gofer] Update file size to 0 on O_TRUNC
Some Open:TruncateXxx syscall tests were failing because the file size was
not being updated when the file was opened with O_TRUNC.
Fixes Truncate tests in test/syscalls:open_test_runsc_ptrace_vfs2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -869,11 +869,22 @@ func (d *dentry) openLocked(ctx context.Context, rp *vfs.ResolvingPath, opts *vf\nif err := d.checkPermissions(rp.Credentials(), ats); e... | Go | Apache License 2.0 | google/gvisor | [vfs2][gofer] Update file size to 0 on O_TRUNC
Some Open:TruncateXxx syscall tests were failing because the file size was
not being updated when the file was opened with O_TRUNC.
Fixes Truncate tests in test/syscalls:open_test_runsc_ptrace_vfs2.
Updates #2923
PiperOrigin-RevId: 319340127 |
259,907 | 01.07.2020 21:04:43 | 25,200 | 514955c1a8f3927c928a57935d511ffbbf9c6f01 | [vfs2][gofer] Fix mmap syscall test.
We were not invalidating mappings when the file size changed in shared mode.
Enabled the syscall test for vfs2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -900,6 +900,12 @@ func (d *dentry) setStat(ctx context.Context, creds *auth.Credentials, stat *lin\n}\nd.metadataMu.Lock()\ndefer d.metadataMu.Unlock()\n+ if stat.Ma... | Go | Apache License 2.0 | google/gvisor | [vfs2][gofer] Fix mmap syscall test.
We were not invalidating mappings when the file size changed in shared mode.
Enabled the syscall test for vfs2.
Updates #2923
PiperOrigin-RevId: 319346569 |
259,883 | 06.07.2020 20:53:51 | -28,800 | 057a2666fa50ac0d0f3b0472a6e1f3d909cc7a12 | hostinet: fix not specifying family field
Creating sockets by hostinet with VFS2 fails due to triggerring a
seccomp violation. In essence, we fails to pass down the field of
family.
We fix this by passing down this field, family.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -708,6 +708,6 @@ func (p *socketProvider) Pair(t *kernel.Task, stype linux.SockType, protocol int\nfunc init() {\nfor _, family := range []int{syscall.AF_INE... | Go | Apache License 2.0 | google/gvisor | hostinet: fix not specifying family field
Creating sockets by hostinet with VFS2 fails due to triggerring a
seccomp violation. In essence, we fails to pass down the field of
family.
We fix this by passing down this field, family.
Fixes #3141
Signed-off-by: Jianfeng Tan <henry.tjf@antfin.com> |
260,003 | 06.07.2020 12:09:03 | 25,200 | 1e5b0a973293d9a6bf7b60349763ee3e71343dea | Shard some slow tests.
stack_x_test: 2m -> 20s
tcp_x_test: 80s -> 25s | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -79,6 +79,7 @@ go_test(\n\"transport_demuxer_test.go\",\n\"transport_test.go\",\n],\n+ shard_count = 20,\ndeps = [\n\":stack\",\n\"//pkg/rand\",\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | Shard some slow tests.
stack_x_test: 2m -> 20s
tcp_x_test: 80s -> 25s
PiperOrigin-RevId: 319828101 |
259,992 | 06.07.2020 15:38:51 | 25,200 | bd43368f491a02b050cd9f87f69185dc74386f2b | Add inode number to synthetic dentries
Reserve the MSB from ino for synthetic dentries to prevent
conflict with regular dentries. Log warning in case MSB is
set for regular dentries.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/directory.go",
"new_path": "pkg/sentry/fsimpl/gofer/directory.go",
"diff": "@@ -85,6 +85,7 @@ func (d *dentry) createSyntheticChildLocked(opts *createSyntheticOpts) {\nd2 := &dentry{\nrefs: 1, // held by d\nfs: d.fs,\n+ ino: d.fs.nextSy... | Go | Apache License 2.0 | google/gvisor | Add inode number to synthetic dentries
Reserve the MSB from ino for synthetic dentries to prevent
conflict with regular dentries. Log warning in case MSB is
set for regular dentries.
Updates #1487
PiperOrigin-RevId: 319869858 |
260,003 | 06.07.2020 16:46:27 | 25,200 | 15c56d92d8b12b7a7bc72aa8a7d1751682e68302 | Fix NonBlockingWrite3 not writing b3 if b2 is zero-length. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/rawfile/rawfile_unsafe.go",
"new_path": "pkg/tcpip/link/rawfile/rawfile_unsafe.go",
"diff": "@@ -69,13 +69,12 @@ func NonBlockingWrite(fd int, buf []byte) *tcpip.Error {\n// NonBlockingWrite3 writes up to three byte slices to a file descriptor i... | Go | Apache License 2.0 | google/gvisor | Fix NonBlockingWrite3 not writing b3 if b2 is zero-length.
PiperOrigin-RevId: 319882171 |
259,962 | 06.07.2020 17:21:03 | 25,200 | b0f656184ef249182882dc323babf9e7c8ac3fc0 | Add support for SO_RCVBUF/SO_SNDBUF for AF_PACKET sockets.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/packet/endpoint.go",
"new_path": "pkg/tcpip/transport/packet/endpoint.go",
"diff": "package packet\nimport (\n+ \"fmt\"\n+\n\"gvisor.dev/gvisor/pkg/sync\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/tcpip/buffer\"\n@@ -73,6 +7... | Go | Apache License 2.0 | google/gvisor | Add support for SO_RCVBUF/SO_SNDBUF for AF_PACKET sockets.
Updates #2746
PiperOrigin-RevId: 319887810 |
259,992 | 06.07.2020 17:24:25 | 25,200 | 937912a4847cb1fd2acb79c0dd8fbc4b27695156 | Ensure sync is called for readonly file
Calling sync on a readonly file flushes metadata that
may have been modified, like last access time.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/handle.go",
"new_path": "pkg/sentry/fsimpl/gofer/handle.go",
"diff": "@@ -126,11 +126,16 @@ func (h *handle) writeFromBlocksAt(ctx context.Context, srcs safemem.BlockSeq, o\n}\nfunc (h *handle) sync(ctx context.Context) error {\n+ // Ha... | Go | Apache License 2.0 | google/gvisor | Ensure sync is called for readonly file
Calling sync on a readonly file flushes metadata that
may have been modified, like last access time.
Updates #1198
PiperOrigin-RevId: 319888290 |
259,867 | 07.07.2020 16:32:15 | -7,200 | c0ea7d9e9e6403db4718eac79ac480ef55b9073c | README.md: Commpatibility > Compatibility | [
{
"change_type": "MODIFY",
"old_path": "g3doc/README.md",
"new_path": "g3doc/README.md",
"diff": "@@ -152,7 +152,7 @@ The application is a normal Linux binary provided to gVisor in an OCI runtime\nbundle. gVisor aims to provide an environment equivalent to Linux v4.4, so\napplications should be able... | Go | Apache License 2.0 | google/gvisor | README.md: Commpatibility > Compatibility |
259,907 | 07.07.2020 15:33:32 | 25,200 | 10930189c3cd938e7526c55188ba2d814a7b8a43 | Fix mknod and inotify syscall test
This change fixes a few things:
creating sockets using mknod(2) is supported via vfs2
fsgofer can create regular files via mknod(2)
mode = 0 for mknod(2) will be interpreted as regular file in vfs2 as well
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -277,7 +277,7 @@ func (fs *filesystem) MknodAt(ctx context.Context, rp *vfs.ResolvingPath, opts v\ncreds := rp.Credentials()\nvar childInode *inode\nswitch... | Go | Apache License 2.0 | google/gvisor | Fix mknod and inotify syscall test
This change fixes a few things:
- creating sockets using mknod(2) is supported via vfs2
- fsgofer can create regular files via mknod(2)
- mode = 0 for mknod(2) will be interpreted as regular file in vfs2 as well
Updates #2923
PiperOrigin-RevId: 320074267 |
260,003 | 07.07.2020 15:55:40 | 25,200 | 7e4d2d63eef3f643222181b3a227bfc7ebe44db2 | icmp: When setting TransportHeader, remove from the Data portion.
The current convention is when a header is set to pkt.XxxHeader field, it
gets removed from pkt.Data. ICMP does not currently follow this convention. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -1358,16 +1358,19 @@ func (n *NIC) DeliverTransportPacket(r *Route, protocol tcpip.TransportProtocolN\n// TransportHeader is nil only when pkt is an ICMP packet or was reassembled\n// f... | Go | Apache License 2.0 | google/gvisor | icmp: When setting TransportHeader, remove from the Data portion.
The current convention is when a header is set to pkt.XxxHeader field, it
gets removed from pkt.Data. ICMP does not currently follow this convention.
PiperOrigin-RevId: 320078606 |
259,907 | 07.07.2020 21:35:47 | 25,200 | efa2615eb008a642dc542176759dc560c5f48a2d | [vfs2] Remove VFS1 usage in VDSO.
Removed VDSO dependency on VFS1.
Resolves | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"new_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"diff": "@@ -73,7 +73,7 @@ func Boot() (*kernel.Kernel, error) {\nk.SetMemoryFile(mf)\n// Pass k as the platform since it is savable, unlike the actual platform.\n- vdso... | Go | Apache License 2.0 | google/gvisor | [vfs2] Remove VFS1 usage in VDSO.
Removed VDSO dependency on VFS1.
Resolves #2921
PiperOrigin-RevId: 320122176 |
259,907 | 08.07.2020 12:03:28 | 25,200 | e3db9bda60580df127ea445fc1f862864c5451f9 | Enable shards in runtime test runner.
Fixed an issue with the runtime test runner which enables us to run tests in
shards. We had to touch the status file as indicated by an env var. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/testutil/testutil.go",
"new_path": "pkg/test/testutil/testutil.go",
"diff": "@@ -482,6 +482,21 @@ func IsStatic(filename string) (bool, error) {\nreturn true, nil\n}\n+// TouchShardStatusFile indicates to Bazel that the test runner supports\n+// shard... | Go | Apache License 2.0 | google/gvisor | Enable shards in runtime test runner.
Fixed an issue with the runtime test runner which enables us to run tests in
shards. We had to touch the status file as indicated by an env var.
PiperOrigin-RevId: 320236205 |
259,891 | 08.07.2020 10:54:23 | 25,200 | 14ff2ea9bfc83fb37afe8a5e17e8b8173f85eb68 | ip6tables: handle both IPv4 and v6 addresses
Enabling IPv6 in Docker caused IPv4 tests to fail because localAddrs
didn't distinguish between address types. Example failure: | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/filter_input.go",
"new_path": "test/iptables/filter_input.go",
"diff": "@@ -618,7 +618,7 @@ func (FilterInputDestination) Name() string {\n// ContainerAction implements TestCase.ContainerAction.\nfunc (FilterInputDestination) ContainerAction(ip n... | Go | Apache License 2.0 | google/gvisor | ip6tables: handle both IPv4 and v6 addresses
Enabling IPv6 in Docker caused IPv4 tests to fail because localAddrs
didn't distinguish between address types. Example failure:
https://source.cloud.google.com/results/invocations/203b2401-3333-4bec-9a56-72cc53d68ddd/log |
259,881 | 08.07.2020 15:46:25 | 25,200 | a75d9f7bee72b9d7611cb015e473ac0bed3d9b02 | Drop empty line | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/network.go",
"new_path": "runsc/sandbox/network.go",
"diff": "@@ -134,7 +134,6 @@ func createInterfacesAndRoutesFromNS(conn *urpc.Client, nsPath string, hardwareG\nreturn err\n}\nif isRoot {\n-\nreturn fmt.Errorf(\"cannot run with network enabled... | Go | Apache License 2.0 | google/gvisor | Drop empty line
PiperOrigin-RevId: 320281516 |
259,992 | 08.07.2020 17:10:35 | 25,200 | c4815af9475cc4680c6d598d9c930de892c98aae | Add shared mount hints to VFS2
Container restart test is disabled for VFS2 for now.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"new_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"diff": "@@ -62,6 +62,7 @@ func Boot() (*kernel.Kernel, error) {\nreturn nil, fmt.Errorf(\"creating platform: %v\", err)\n}\n+ kernel.VFS2Enabled = true\nk := &kernel.Ke... | Go | Apache License 2.0 | google/gvisor | Add shared mount hints to VFS2
Container restart test is disabled for VFS2 for now.
Updates #1487
PiperOrigin-RevId: 320296401 |
260,022 | 07.07.2020 21:48:25 | 14,400 | abffebde7be2dcdb4564e45f845d7c150ced0ccb | Gate FUSE behind a runsc flag
This change gates all FUSE commands (by gating /dev/fuse) behind a runsc
flag. In order to use FUSE commands, use the --fuse flag with the --vfs2
flag. Check if FUSE is enabled by running dmesg in the sandbox. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/BUILD",
"new_path": "pkg/sentry/fsimpl/fuse/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_library(\n\"//pkg/abi/linux\",\n\"//pkg/context\",\n\"//pkg/sentry/fsimpl/devtmpfs\",\n+ \"//pkg/sentry/kernel\",\n\"//pkg/sentry/vfs\",\n\"//pkg/syserror\... | Go | Apache License 2.0 | google/gvisor | Gate FUSE behind a runsc flag
This change gates all FUSE commands (by gating /dev/fuse) behind a runsc
flag. In order to use FUSE commands, use the --fuse flag with the --vfs2
flag. Check if FUSE is enabled by running dmesg in the sandbox. |
259,881 | 09.07.2020 09:03:14 | 25,200 | 8d2910a04dec5ef2c79034d35fce68e9f414d144 | Explain how to bypass the Docker proxy
Neither myself nor bhaskerh@ can consistently remember how to do this. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/debugging.md",
"new_path": "g3doc/user_guide/debugging.md",
"diff": "@@ -129,3 +129,13 @@ go tool pprof -top /usr/local/bin/runsc /tmp/cpu.prof\n```\n[pprof]: https://github.com/google/pprof/blob/master/doc/README.md\n+\n+### Docker Proxy\n+\n... | Go | Apache License 2.0 | google/gvisor | Explain how to bypass the Docker proxy
Neither myself nor bhaskerh@ can consistently remember how to do this.
PiperOrigin-RevId: 320407005 |
259,962 | 09.07.2020 16:24:43 | 25,200 | 5946f111827fa4e342a2e6e9c043c198d2e5cb03 | Add support for IP_HDRINCL IP option for raw sockets.
Updates
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -2112,13 +2112,22 @@ func setSockOptIP(t *kernel.Task, ep commonEndpoint, name int, optVal []byte) *s\n}\nreturn syserr.TranslateNetstackError(ep.SetSock... | Go | Apache License 2.0 | google/gvisor | Add support for IP_HDRINCL IP option for raw sockets.
Updates #2746
Fixes #3158
PiperOrigin-RevId: 320497190 |
259,858 | 05.05.2020 18:11:56 | 25,200 | 60e19587cebc3cbc781088cc01080c71ad7900a0 | Update canonical paths. | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/v1/proc/exec.go",
"new_path": "pkg/shim/v1/proc/exec.go",
"diff": "@@ -34,7 +34,7 @@ import (\n\"github.com/pkg/errors\"\n\"golang.org/x/sys/unix\"\n- runsc \"github.com/google/gvisor-containerd-shim/pkg/go-runsc\"\n+ \"gvisor.dev/gvisor/pkg/shim/runs... | Go | Apache License 2.0 | google/gvisor | Update canonical paths. |
259,858 | 19.05.2020 21:01:23 | 25,200 | 2f24ab339736315659f26699ab50aa2982d7e890 | Allow arbitrary Go commands for go_mod.sh. | [
{
"change_type": "RENAME",
"old_path": "tools/go_mod.sh",
"new_path": "tools/go.sh",
"diff": "set -eo pipefail\n# Build the :gopath target.\n-bazel build //:gopath\n+make build TARGETS=\":gopath\"\ndeclare -r gopathdir=\"bazel-bin/gopath/src/gvisor.dev/gvisor/\"\n# Copy go.mod and execute the comman... | Go | Apache License 2.0 | google/gvisor | Allow arbitrary Go commands for go_mod.sh. |
259,962 | 11.07.2020 06:21:34 | 25,200 | 216dcebc066c82907b0de790a77a3deb6a734805 | Stub out SO_DETACH_FILTER.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1754,6 +1754,11 @@ func setSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, nam\nreturn nil\n+ case linux.SO_DETACH_FILTER:\n+ // op... | Go | Apache License 2.0 | google/gvisor | Stub out SO_DETACH_FILTER.
Updates #2746
PiperOrigin-RevId: 320757963 |
260,004 | 12.07.2020 17:20:50 | 25,200 | 9c32fd3f4d8f6e63d922c1c58b7d1f1f504fa2bc | Do not copy sleep.Waker
sleep.Waker's fields are modified as values. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sleep/BUILD",
"new_path": "pkg/sleep/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_library(\n\"sleep_unsafe.go\",\n],\nvisibility = [\"//:sandbox\"],\n+ deps = [\"//pkg/sync\"],\n)\ngo_test(\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/sleep/sleep... | Go | Apache License 2.0 | google/gvisor | Do not copy sleep.Waker
sleep.Waker's fields are modified as values.
PiperOrigin-RevId: 320873451 |
259,858 | 13.07.2020 09:37:47 | 25,200 | 7ff4649b3c61bbf70ea8d76b509a7ae620a45ac7 | Use host networking for build container.
This will allow the use of default credentials. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -70,6 +70,7 @@ bazel-server-start: load-default ## Starts the bazel server.\n-v \"$(CURDIR):$(CURDIR)\" \\\n--workdir \"$(CURDIR)\" \\\n--entrypoint \"\" \\\n+ --network=host \\\n$(FULL_DOCKER_RUN_OPTI... | Go | Apache License 2.0 | google/gvisor | Use host networking for build container.
This will allow the use of default credentials.
PiperOrigin-RevId: 320972241 |
259,891 | 13.07.2020 11:59:26 | 25,200 | 43c209f48e0aa9024705583cc6f0fafa7d6380ca | garbage collect connections
As in Linux, we must periodically clean up unused connections. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -27,6 +27,18 @@ go_template_instance(\n},\n)\n+go_template_instance(\n+ name = \"tuple_list\",\n+ out = \"tuple_list.go\",\n+ package = \"stack\",\n+ prefix = \"tuple\",\n+ template = \"/... | Go | Apache License 2.0 | google/gvisor | garbage collect connections
As in Linux, we must periodically clean up unused connections.
PiperOrigin-RevId: 321003353 |
259,992 | 13.07.2020 12:22:01 | 25,200 | b7e8ce93de54a0f897832877255bed7005b08f14 | Add ReadAllFd to test util | [
{
"change_type": "MODIFY",
"old_path": "test/util/test_util.h",
"new_path": "test/util/test_util.h",
"diff": "@@ -567,6 +567,25 @@ ssize_t ApplyFileIoSyscall(F const& f, size_t const count) {\n} // namespace internal\n+inline PosixErrorOr<std::string> ReadAllFd(int fd) {\n+ std::string all;\n+ all.r... | Go | Apache License 2.0 | google/gvisor | Add ReadAllFd to test util
PiperOrigin-RevId: 321008185 |
259,907 | 13.07.2020 13:33:09 | 25,200 | 6994f4d5912ce9dc9233aebe9902892824904b71 | [vfs2] Make gofer metadata atomics consistent
For accessing metadata fields:
If metadataMu is locked, we can access without atomics
If metadataMu is unlocked, we should use atomics
For mutating metadata fields:
Always lock metadataMu and use atomics.
There were some instances of inconsistencies which have been fixed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -602,8 +602,14 @@ type dentry struct {\n// returned by the server. dirents is protected by dirMu.\ndirents []vfs.Dirent\n- // Cached metadata; protected by metadataM... | Go | Apache License 2.0 | google/gvisor | [vfs2] Make gofer metadata atomics consistent
For accessing metadata fields:
- If metadataMu is locked, we can access without atomics
- If metadataMu is unlocked, we should use atomics
For mutating metadata fields:
- Always lock metadataMu and use atomics.
There were some instances of inconsistencies which have been fixed.
PiperOrigin-RevId: 321022895 |
259,891 | 13.07.2020 13:53:42 | 25,200 | 3fe9be138c65d7291aa30f67a55eca316945bf87 | iptables: remove useless ip6tables VM rules
This rule isn't restored when the Kokoro VM is restarted, so it's not doing
anything. And the problem it was meant to solved is instead addressed by | [
{
"change_type": "MODIFY",
"old_path": "tools/vm/ubuntu1604/25_docker.sh",
"new_path": "tools/vm/ubuntu1604/25_docker.sh",
"diff": "@@ -60,6 +60,3 @@ cat > /etc/docker/daemon.json <<EOF\n\"ipv6\": true\n}\nEOF\n-# Docker's IPv6 support is lacking and does not work the same way as IPv4. We\n-# can us... | Go | Apache License 2.0 | google/gvisor | iptables: remove useless ip6tables VM rules
This rule isn't restored when the Kokoro VM is restarted, so it's not doing
anything. And the problem it was meant to solved is instead addressed by
https://github.com/google/gvisor/pull/3207.
PiperOrigin-RevId: 321026846 |
259,860 | 13.07.2020 14:00:21 | 25,200 | cf0826653c436021a1b808d1f0aea082c9a0fc1b | Clean up inotify comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/inotify.go",
"new_path": "pkg/sentry/vfs/inotify.go",
"diff": "@@ -179,12 +179,12 @@ func (i *Inotify) Readiness(mask waiter.EventMask) waiter.EventMask {\nreturn mask & ready\n}\n-// PRead implements FileDescriptionImpl.\n+// PRead implements F... | Go | Apache License 2.0 | google/gvisor | Clean up inotify comments.
PiperOrigin-RevId: 321028238 |
260,003 | 13.07.2020 14:35:11 | 25,200 | a287309d9ff0461842de1c487348c3032e5fdee4 | Fix recvMMsgDispatcher not slicing link header correctly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint_test.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint_test.go",
"diff": "@@ -500,3 +500,76 @@ func TestRecvMMsgDispatcherCapLength(t *testing.T) {\n}\n}\n+\n+// fakeNetworkDispatcher delivers packets to pkts.\n+type fakeNetwork... | Go | Apache License 2.0 | google/gvisor | Fix recvMMsgDispatcher not slicing link header correctly.
PiperOrigin-RevId: 321035635 |
259,884 | 13.07.2020 15:05:27 | 25,200 | 74df310ac09f9f27bc88a9b7eda0fa1659e499a4 | Don't run issue reviver on forks.
Add a conditional to avoid running the issue reviver on forks. It will
always cause errors since bug references in the source code don't match
issue IDs in forked repos. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/issue_reviver.yml",
"new_path": ".github/workflows/issue_reviver.yml",
"diff": "@@ -4,11 +4,13 @@ on:\n- cron: '0 0 * * *'\njobs:\n- label:\n+ issue_reviver:\nruns-on: ubuntu-latest\nsteps:\n- uses: actions/checkout@v2\n+ if: github.repositor... | Go | Apache License 2.0 | google/gvisor | Don't run issue reviver on forks.
Add a conditional to avoid running the issue reviver on forks. It will
always cause errors since bug references in the source code don't match
issue IDs in forked repos.
PiperOrigin-RevId: 321042060 |
260,003 | 13.07.2020 17:01:04 | 25,200 | 87c33be9af4ab8d80cd20dc58fe843e2eb5e4136 | Enable experimental features in docker. | [
{
"change_type": "MODIFY",
"old_path": "tools/vm/ubuntu1604/30_docker.sh",
"new_path": "tools/vm/ubuntu1604/30_docker.sh",
"diff": "@@ -53,9 +53,11 @@ while true; do\nfi\ndone\n+# Enable experimental features, for cross-building aarch64 images.\n# Enable Docker IPv6.\ncat > /etc/docker/daemon.json <... | Go | Apache License 2.0 | google/gvisor | Enable experimental features in docker.
PiperOrigin-RevId: 321062975 |
259,992 | 14.07.2020 11:59:41 | 25,200 | 1bfb556ccdaee28ffea0cbdc37007edb10fa22c4 | Prepare boot.Loader to support multi-container TTY
Combine process creation code that is shared between
root and subcontainer processes
Move root container information into a struct for
clarity
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -155,7 +155,7 @@ func newController(fd int, l *Loader) (*controller, error) {\nsrv.Register(&debug{})\nsrv.Register(&control.Logging{})\n- if l.conf.ProfileEnable {\n+ if l.root.con... | Go | Apache License 2.0 | google/gvisor | Prepare boot.Loader to support multi-container TTY
- Combine process creation code that is shared between
root and subcontainer processes
- Move root container information into a struct for
clarity
Updates #2714
PiperOrigin-RevId: 321204798 |
259,898 | 14.07.2020 12:27:17 | 25,200 | 221e1da947f8f892e29d1ff0a382b7a171ab0437 | Test IPv6 fragment reassembly
A packetimpact test for: "A node must be able to accept a fragmented packet
that, after reassembly, is as large as 1500 octets." | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/layers.go",
"new_path": "test/packetimpact/testbench/layers.go",
"diff": "package testbench\nimport (\n+ \"encoding/binary\"\n\"encoding/hex\"\n\"fmt\"\n\"reflect\"\n@@ -470,21 +471,11 @@ func (l *IPv6) ToBytes() ([]byte, error) {\n... | Go | Apache License 2.0 | google/gvisor | Test IPv6 fragment reassembly
A packetimpact test for: "A node must be able to accept a fragmented packet
that, after reassembly, is as large as 1500 octets."
PiperOrigin-RevId: 321210729 |
259,891 | 14.07.2020 13:46:55 | 25,200 | 8a0082f5f3aaad053873800feae8d0fb8b504c50 | remove IPv6 docker
Will re-submit when ICMP dest unreachable is handled correctly and it can be
turned back on. | [
{
"change_type": "MODIFY",
"old_path": "tools/vm/ubuntu1604/30_docker.sh",
"new_path": "tools/vm/ubuntu1604/30_docker.sh",
"diff": "@@ -54,11 +54,8 @@ while true; do\ndone\n# Enable experimental features, for cross-building aarch64 images.\n-# Enable Docker IPv6.\ncat > /etc/docker/daemon.json <<EOF... | Go | Apache License 2.0 | google/gvisor | remove IPv6 docker
Will re-submit when ICMP dest unreachable is handled correctly and it can be
turned back on.
PiperOrigin-RevId: 321227330 |
259,860 | 14.07.2020 17:29:53 | 25,200 | 1b9965e06a966977a99569484da139d64d1db95e | Update special file option name in comment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"diff": "@@ -28,9 +28,9 @@ import (\n)\n// specialFileFD implements vfs.FileDescriptionImpl for pipes, sockets, device\n-// special files, and (when filesystemOpti... | Go | Apache License 2.0 | google/gvisor | Update special file option name in comment.
PiperOrigin-RevId: 321269281 |
259,905 | 15.07.2020 22:02:26 | -28,800 | 505bebae43183a68ee8873764817d282a6c49ec6 | hostinet: fix fd leak in fdnotifier for VFS2
When we failed to create the new socket after adding the fd to
fdnotifier, we should remove the fd from fdnotifier, because we
are going to close the fd directly.
Fixes: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket_vfs2.go",
"new_path": "pkg/sentry/socket/hostinet/socket_vfs2.go",
"diff": "@@ -71,6 +71,7 @@ func newVFS2Socket(t *kernel.Task, family int, stype linux.SockType, protocol in\nDenyPWrite: true,\nUseDentryMetadata: true,\n}); e... | Go | Apache License 2.0 | google/gvisor | hostinet: fix fd leak in fdnotifier for VFS2
When we failed to create the new socket after adding the fd to
fdnotifier, we should remove the fd from fdnotifier, because we
are going to close the fd directly.
Fixes: #3241
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> |
259,881 | 18.06.2020 14:29:39 | 14,400 | 1481673178494def3dd335ff240c8cd9219374ce | Apply pdeathsig to gofer for runsc run/do
Much like the boot process, apply pdeathsig to the gofer for cases where
the sandbox lifecycle is attached to the parent (runsc run/do).
This isn't strictly necessary, as the gofer normally exits once the
sentry disappears, but this makes that extra reliable. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -324,7 +324,7 @@ func New(conf *boot.Config, args Args) (*Container, error) {\n}\n}\nif err := runInCgroup(cg, func() error {\n- ioFiles, specFile, err := c.createGoferProce... | Go | Apache License 2.0 | google/gvisor | Apply pdeathsig to gofer for runsc run/do
Much like the boot process, apply pdeathsig to the gofer for cases where
the sandbox lifecycle is attached to the parent (runsc run/do).
This isn't strictly necessary, as the gofer normally exits once the
sentry disappears, but this makes that extra reliable. |
260,003 | 15.07.2020 12:15:11 | 25,200 | 1d11c403787b360140dd08be3a25c5689a89c7a0 | Fix errors not getting caught when building vm image.
`set -e` does not catch errors in bash command substituions like
`echo $(bad cmd)` so bazel thinks it succeeded and cached the result. | [
{
"change_type": "MODIFY",
"old_path": "tools/vm/README.md",
"new_path": "tools/vm/README.md",
"diff": "@@ -25,6 +25,12 @@ vm_image(\nThese images can be built manually by executing the target. The output on\n`stdout` will be the image id (in the current project).\n+For example:\n+\n+```\n+$ bazel b... | Go | Apache License 2.0 | google/gvisor | Fix errors not getting caught when building vm image.
`set -e` does not catch errors in bash command substituions like
`echo $(bad cmd)` so bazel thinks it succeeded and cached the result.
PiperOrigin-RevId: 321412327 |
259,962 | 15.07.2020 14:55:12 | 25,200 | 857d03f258ffafb815698917f2a1ee9e7e265464 | Add support for SO_ERROR to packet sockets.
Packet sockets also seem to allow double binding and do not return an error on
linux. This was tested by running the syscall test in a linux namespace as root
and the current test DoubleBind fails@HEAD.
Passes after this change.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/syserr/netstack.go",
"new_path": "pkg/syserr/netstack.go",
"diff": "@@ -22,7 +22,7 @@ import (\n// Mapping for tcpip.Error types.\nvar (\nErrUnknownProtocol = New(tcpip.ErrUnknownProtocol.String(), linux.EINVAL)\n- ErrUnknownNICID = New(tcpip.ErrUnknownNIC... | Go | Apache License 2.0 | google/gvisor | Add support for SO_ERROR to packet sockets.
Packet sockets also seem to allow double binding and do not return an error on
linux. This was tested by running the syscall test in a linux namespace as root
and the current test DoubleBind fails@HEAD.
Passes after this change.
Updates #173
PiperOrigin-RevId: 321445137 |
259,891 | 15.07.2020 16:33:46 | 25,200 | e92f38ff0cd2e490637df2081fc8f75ddaf32937 | iptables: remove check for NetworkHeader
This is no longer necessary, as we always set NetworkHeader before calling
iptables.Check. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -292,10 +292,9 @@ func (it *IPTables) startReaper(interval time.Duration) {\n// CheckPackets runs pkts through the rules for hook and returns a map of packets that\n// should ... | Go | Apache License 2.0 | google/gvisor | iptables: remove check for NetworkHeader
This is no longer necessary, as we always set NetworkHeader before calling
iptables.Check.
PiperOrigin-RevId: 321461978 |
259,975 | 15.07.2020 18:19:52 | 25,200 | 5c8c0d65b9062dcbe195e7131a6a3c3fb8ba9583 | Port httpd benchmark | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/ab/Dockerfile",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y \\\n+ apache2-utils \\\n+ && rm -rf /var/lib/apt/lists/*\n"
},
{
"change_type": "ADD",
"old_path": null... | Go | Apache License 2.0 | google/gvisor | Port httpd benchmark
PiperOrigin-RevId: 321478001 |
260,004 | 16.07.2020 12:25:02 | 25,200 | c66991ad7de68fd629a1620acad0c8eec2744bac | Add ethernet broadcast address constant | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/eth.go",
"new_path": "pkg/tcpip/header/eth.go",
"diff": "@@ -53,6 +53,10 @@ const (\n// (all bits set to 0).\nunspecifiedEthernetAddress = tcpip.LinkAddress(\"\\x00\\x00\\x00\\x00\\x00\\x00\")\n+ // EthernetBroadcastAddress is an ethernet addr... | Go | Apache License 2.0 | google/gvisor | Add ethernet broadcast address constant
PiperOrigin-RevId: 321620517 |
259,907 | 16.07.2020 14:35:39 | 25,200 | e6894cb99fe4c6e8599354bf5bc6a72a79b63fd3 | Port runtime tests to use go_test | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/BUILD",
"new_path": "test/runtimes/BUILD",
"diff": "-load(\"//test/runtimes:defs.bzl\", \"runtime_test\")\n+load(\"//test/runtimes:defs.bzl\", \"exclude_test\", \"runtime_test\")\npackage(licenses = [\"notice\"])\n+go_binary(\n+ name = \"runner\"... | Go | Apache License 2.0 | google/gvisor | Port runtime tests to use go_test
PiperOrigin-RevId: 321647645 |
259,962 | 16.07.2020 18:38:28 | 25,200 | dcf6ddc2772b8fcf824f1f48e0281e1cc80b93ea | Add support to return protocol in recvmsg for AF_PACKET.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -299,6 +299,7 @@ type socketOpsCommon struct {\n// from Endpoint.\nreadCM tcpip.ControlMessages\nsender tcpip.FullAddress\n+ linkPacketInfo tcpip.LinkPac... | Go | Apache License 2.0 | google/gvisor | Add support to return protocol in recvmsg for AF_PACKET.
Updates #173
PiperOrigin-RevId: 321690756 |
259,907 | 17.07.2020 13:06:34 | 25,200 | 03c30ec634e529eb0f0051b0de03d4811706fe72 | Runtime tests: Download language runtime image | [
{
"change_type": "MODIFY",
"old_path": "scripts/runtime_tests.sh",
"new_path": "scripts/runtime_tests.sh",
"diff": "@@ -22,5 +22,8 @@ if [ ! -v RUNTIME_TEST_NAME ]; then\nexit 1\nfi\n+# Download language runtime image.\n+make -C images/ \"load-runtimes_${RUNTIME_TEST_NAME}\"\n+\ninstall_runsc_for_te... | Go | Apache License 2.0 | google/gvisor | Runtime tests: Download language runtime image
PiperOrigin-RevId: 321839398 |
259,975 | 17.07.2020 16:13:44 | 25,200 | e3c2bd51a1a970991cce71d6994bb053c546e538 | Move main methods for benchmark packages main package file. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/fs/BUILD",
"new_path": "test/benchmarks/fs/BUILD",
"diff": "@@ -4,7 +4,9 @@ package(licenses = [\"notice\"])\ngo_library(\nname = \"fs\",\n+ testonly = 1,\nsrcs = [\"fs.go\"],\n+ deps = [\"//test/benchmarks/harness\"],\n)\ngo_test(\n@@ -17,8 +1... | Go | Apache License 2.0 | google/gvisor | Move main methods for benchmark packages main package file.
PiperOrigin-RevId: 321875119 |
260,003 | 17.07.2020 17:43:32 | 25,200 | 5593320bee3e4ab215f501a723ef3ea92b20cf85 | Update README on cross-building images. | [
{
"change_type": "MODIFY",
"old_path": "images/README.md",
"new_path": "images/README.md",
"diff": "@@ -59,3 +59,12 @@ project.\nThe continuous integration system can either take fine-grained dependencies on\nindividual `push` targets, or ensure all images are up-to-date with a single\n`push-all-ima... | Go | Apache License 2.0 | google/gvisor | Update README on cross-building images.
PiperOrigin-RevId: 321887956 |
259,884 | 17.07.2020 18:26:08 | 25,200 | feb1d3d5a7d9c26ab1533b350a9d6088148641aa | Clean up html on the website.
Fixes some html validation issues.
Fixes links on security basics blog post.
Adds rel=noopener to links with target=_blank and adds a check to
htmlproofer.
Add favicon check to htmlproofer.
Fixes
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/README.md",
"new_path": "g3doc/README.md",
"diff": "@@ -117,9 +117,7 @@ for more information on filesystem bundles. `runsc` implements multiple commands\nthat perform various functions such as starting, stopping, listing, and querying\nthe status of cont... | Go | Apache License 2.0 | google/gvisor | Clean up html on the website.
- Fixes some html validation issues.
- Fixes links on security basics blog post.
- Adds rel=noopener to links with target=_blank and adds a check to
htmlproofer.
- Add favicon check to htmlproofer.
Fixes #3286
Fixes #3284
PiperOrigin-RevId: 321892602 |
259,858 | 20.07.2020 18:03:04 | 25,200 | e1a04f84e864b9a5c8a51a7cdd32f8db5377aff1 | Add standard entrypoints for test targets. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "# See the License for the specific language governing permissions and\n# limitations under the License.\n+# Helpful pretty-printer.\n+MAKEBANNER := \\033[1;34mmake\\033[0m\n+submake = echo -e '$(MAKEBANNER) $1' >&2; ... | Go | Apache License 2.0 | google/gvisor | Add standard entrypoints for test targets.
PiperOrigin-RevId: 322265513 |
260,025 | 21.07.2020 19:42:04 | -3,600 | 033fe6d70aa2c6bb64b33668c07eb5db522f9957 | p9: fix `registry.get` ob1 bug | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/messages.go",
"new_path": "pkg/p9/messages.go",
"diff": "@@ -2506,7 +2506,7 @@ type msgFactory struct {\nvar msgRegistry registry\ntype registry struct {\n- factories [math.MaxUint8]msgFactory\n+ factories [math.MaxUint8 + 1]msgFactory\n// largestFixedS... | Go | Apache License 2.0 | google/gvisor | p9: fix `registry.get` ob1 bug |
259,860 | 22.07.2020 15:10:17 | 25,200 | 13c0cca50e061c9b9a3ae8e13e8baa0f29909370 | Skip RawHDRINCL tests that are blocking presubmits/releases.
Temporarily skip these, on bhaskherh@'s advice. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/raw_socket_hdrincl.cc",
"new_path": "test/syscalls/linux/raw_socket_hdrincl.cc",
"diff": "@@ -178,6 +178,9 @@ TEST_F(RawHDRINCL, ConnectToLoopback) {\n}\nTEST_F(RawHDRINCL, SendWithoutConnectSucceeds) {\n+ // FIXME(github.dev/issue/3159): T... | Go | Apache License 2.0 | google/gvisor | Skip RawHDRINCL tests that are blocking presubmits/releases.
Temporarily skip these, on bhaskherh@'s advice.
PiperOrigin-RevId: 322664955 |
259,907 | 22.07.2020 15:40:44 | 25,200 | 39525d64cbd5901ea80651e323c8554af132f4dd | Add O_APPEND support in vfs2 gofer.
Helps in fixing open syscall tests: AppendConcurrentWrite and AppendOnly.
We also now update the file size for seekable special files (regular files)
which we were not doing earlier.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -155,26 +155,53 @@ func (fd *regularFileFD) Read(ctx context.Context, dst usermem.IOSequence, opts\n// PWrite implements vfs.FileDescriptionImpl.PWrite... | Go | Apache License 2.0 | google/gvisor | Add O_APPEND support in vfs2 gofer.
Helps in fixing open syscall tests: AppendConcurrentWrite and AppendOnly.
We also now update the file size for seekable special files (regular files)
which we were not doing earlier.
Updates #2923
PiperOrigin-RevId: 322670843 |
259,907 | 22.07.2020 15:44:08 | 25,200 | 9654bf04acad7300e0bf964183f7860bd553f563 | [vfs2][tmpfs] Implement O_APPEND
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"diff": "@@ -325,8 +325,15 @@ func (fd *regularFileFD) Read(ctx context.Context, dst usermem.IOSequence, opts\n// PWrite implements vfs.FileDescriptionImpl.PWrite.... | Go | Apache License 2.0 | google/gvisor | [vfs2][tmpfs] Implement O_APPEND
Updates #2923
PiperOrigin-RevId: 322671489 |
259,891 | 22.07.2020 16:22:06 | 25,200 | bd98f820141208d9f19b0e12dee93f6f6de3ac97 | iptables: replace maps with arrays
For iptables users, Check() is a hot path called for every packet one or more
times. Let's avoid a bunch of map lookups. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -342,10 +342,10 @@ func SetEntries(stk *stack.Stack, optVal []byte) *syserr.Error {\n// TODO(gvisor.dev/issue/170): Support other tables.\nvar table ... | Go | Apache License 2.0 | google/gvisor | iptables: replace maps with arrays
For iptables users, Check() is a hot path called for every packet one or more
times. Let's avoid a bunch of map lookups.
PiperOrigin-RevId: 322678699 |
259,907 | 23.07.2020 09:43:05 | 25,200 | 4fbd0728ac5e0aa33a7f5e2c5189751b4baa94b5 | [vfs2][gofer] Fix update attributes race condition.
We were getting the file attributes before locking the metadataMu which was
causing stale updates to the file attributes.
Fixes OpenTest_AppendConcurrentWrite.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -150,11 +150,9 @@ afterSymlink:\nreturn nil, err\n}\nif d != d.parent && !d.cachedMetadataAuthoritative() {\n- _, attrMask, attr, err := d.parent.file.getA... | Go | Apache License 2.0 | google/gvisor | [vfs2][gofer] Fix update attributes race condition.
We were getting the file attributes before locking the metadataMu which was
causing stale updates to the file attributes.
Fixes OpenTest_AppendConcurrentWrite.
Updates #2923
PiperOrigin-RevId: 322804438 |
259,992 | 23.07.2020 11:00:35 | 25,200 | 384369e01e653e0a2ea976d2063ba19a9c2cbbc8 | Fix fsgofer Open() when control file is using O_PATH
Open tries to reuse the control file to save syscalls and
file descriptors when opening a file. However, when the
control file was opened using O_PATH (e.g. no file permission
to open readonly), Open() would not check for it. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/BUILD",
"new_path": "runsc/fsgofer/BUILD",
"diff": "@@ -31,5 +31,6 @@ go_test(\ndeps = [\n\"//pkg/log\",\n\"//pkg/p9\",\n+ \"//pkg/test/testutil\",\n],\n)\n"
},
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"n... | Go | Apache License 2.0 | google/gvisor | Fix fsgofer Open() when control file is using O_PATH
Open tries to reuse the control file to save syscalls and
file descriptors when opening a file. However, when the
control file was opened using O_PATH (e.g. no file permission
to open readonly), Open() would not check for it.
PiperOrigin-RevId: 322821729 |
259,962 | 23.07.2020 12:52:18 | 25,200 | 20b556e625354dd8330e30e4075ad06eedc6a2ce | Fix wildcard bind for raw socket.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -456,7 +456,7 @@ func (e *endpoint) Bind(addr tcpip.FullAddress) *tcpip.Error {\ndefer e.mu.Unlock()\n// If a local address was specified, verify that it's val... | Go | Apache License 2.0 | google/gvisor | Fix wildcard bind for raw socket.
Fixes #3334
PiperOrigin-RevId: 322846384 |
260,022 | 09.06.2020 12:35:39 | 14,400 | 3e0e3b9b11fee58835a0a492d66e72b354459e27 | Added stub FUSE filesystem
Allow FUSE filesystems to be mounted using libfuse.
The appropriate flags and mount options are parsed and
understood by fusefs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/BUILD",
"new_path": "pkg/sentry/fsimpl/fuse/BUILD",
"diff": "@@ -6,15 +6,20 @@ go_library(\nname = \"fuse\",\nsrcs = [\n\"dev.go\",\n+ \"fusefs.go\",\n],\nvisibility = [\"//pkg/sentry:internal\"],\ndeps = [\n\"//pkg/abi/linux\",\n\"//pkg... | Go | Apache License 2.0 | google/gvisor | Added stub FUSE filesystem
Allow FUSE filesystems to be mounted using libfuse.
The appropriate flags and mount options are parsed and
understood by fusefs. |
260,022 | 20.07.2020 16:24:27 | 14,400 | 2f78c487f17e12dfee08214311c500073cb03fde | Use mode supplied by the mount options | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/BUILD",
"new_path": "pkg/sentry/fsimpl/fuse/BUILD",
"diff": "@@ -20,6 +20,5 @@ go_library(\n\"//pkg/sentry/vfs\",\n\"//pkg/syserror\",\n\"//pkg/usermem\",\n- \"@org_golang_x_sys//unix:go_default_library\",\n],\n)\n"
},
{
"change_... | Go | Apache License 2.0 | google/gvisor | Use mode supplied by the mount options |
259,891 | 23.07.2020 15:44:09 | 25,200 | dd530eeeff09128d4c2428e1d6f24205a29e661e | iptables: use keyed array literals | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -58,8 +58,7 @@ const reaperDelay = 5 * time.Second\nfunc DefaultTables() *IPTables {\nreturn &IPTables{\ntables: [numTables]Table{\n- // NAT table.\n- Table{\n+ natID: Table{\... | Go | Apache License 2.0 | google/gvisor | iptables: use keyed array literals
PiperOrigin-RevId: 322882426 |
259,914 | 23.07.2020 16:06:46 | 25,200 | 4eb3c8c7e59b1f3dd0c0bfc253cd5c8c6067d05d | kvm-tls-2:add the preservation of user-TLS in the Arm64 kvm platform
This patch load/save TLS for the container application.
Related issue: full context-switch supporting for Arm64
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/2761 from lubinszARM:pr_tls_2 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/arch_aarch64.go",
"new_path": "pkg/sentry/arch/arch_aarch64.go",
"diff": "@@ -28,7 +28,14 @@ import (\n)\n// Registers represents the CPU registers for this architecture.\n-type Registers = linux.PtraceRegs\n+//\n+// +stateify savable\n+type Re... | Go | Apache License 2.0 | google/gvisor | kvm-tls-2:add the preservation of user-TLS in the Arm64 kvm platform
This patch load/save TLS for the container application.
Related issue: full context-switch supporting for Arm64 #1238
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/2761 from lubinszARM:pr_tls_2 cb5dbca1c9c3f378002406da7a58887f9b5032b3
PiperOrigin-RevId: 322887044 |
259,860 | 23.07.2020 18:43:20 | 25,200 | bac4ebaabfac95f7b467b9c777a890fcf31a42ae | FileDescription is hard to spell.
Fix typos. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devpts/slave.go",
"new_path": "pkg/sentry/fsimpl/devpts/slave.go",
"diff": "@@ -132,7 +132,7 @@ func (sfd *slaveFileDescription) Write(ctx context.Context, src usermem.IOSequen\nreturn sfd.inode.t.ld.outputQueueWrite(ctx, src)\n}\n-// Ioctl i... | Go | Apache License 2.0 | google/gvisor | FileDescription is hard to spell.
Fix typos.
PiperOrigin-RevId: 322913282 |
259,907 | 24.07.2020 01:14:32 | 25,200 | c59b792f53f3aa4c24d1ca9442ffc44f6d4932df | [go-marshal] Update API
All Marshal* and Unmarshal* methods now require buffers to be correctly sized
Only the Copy{In/Out} variants can handle smaller buffers (or address spaces) | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/gomarshal/generator.go",
"new_path": "tools/go_marshal/gomarshal/generator.go",
"diff": "@@ -413,13 +413,13 @@ func (g *Generator) Run() error {\nfor _, t := range g.collectMarshallableTypes(a, fsets[i]) {\nimpl := g.generateOne(t, fsets[i])\n... | Go | Apache License 2.0 | google/gvisor | [go-marshal] Update API
- All Marshal* and Unmarshal* methods now require buffers to be correctly sized
- Only the Copy{In/Out} variants can handle smaller buffers (or address spaces)
PiperOrigin-RevId: 322953881 |
259,907 | 24.07.2020 01:24:16 | 25,200 | e2c70ee9814f0f76ab5c30478748e4c697e91f33 | Enable automated marshalling for netstack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netdevice.go",
"new_path": "pkg/abi/linux/netdevice.go",
"diff": "@@ -22,6 +22,8 @@ const (\n)\n// IFReq is an interface request.\n+//\n+// +marshal\ntype IFReq struct {\n// IFName is an encoded name, normally null-terminated. This should be\n// ... | Go | Apache License 2.0 | google/gvisor | Enable automated marshalling for netstack.
PiperOrigin-RevId: 322954792 |
259,891 | 24.07.2020 15:03:13 | 25,200 | da631a3ef21ccace88803a9d8dcf05e285167e3f | Speed up some iptables tests
Sending UDP packets in a loop can be done in a separate goroutine. We
can't do this in ContainerAction because the container will terminate
early.
Locally, scripts/iptables_tests.sh runs ~40 seconds faster. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/filter_input.go",
"new_path": "test/iptables/filter_input.go",
"diff": "@@ -81,7 +81,7 @@ func (FilterInputDropUDP) ContainerAction(ip net.IP) error {\n// LocalAction implements TestCase.LocalAction.\nfunc (FilterInputDropUDP) LocalAction(ip net.... | Go | Apache License 2.0 | google/gvisor | Speed up some iptables tests
Sending UDP packets in a loop can be done in a separate goroutine. We
can't do this in ContainerAction because the container will terminate
early.
Locally, scripts/iptables_tests.sh runs ~40 seconds faster. |
259,891 | 24.07.2020 17:27:11 | 25,200 | 91a47a40a8490aaeceb5a8162eb47b758ca738a1 | Bugfix: non-native tests were tagged as native
Copy the list of tags when passing it to _syscall_test. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -157,7 +157,7 @@ def syscall_test(\nplatform = \"native\",\nuse_tmpfs = False,\nadd_uds_tree = add_uds_tree,\n- tags = tags,\n+ tags = list(tags),\n)\nfor (platform, platform_tags) in platf... | Go | Apache License 2.0 | google/gvisor | Bugfix: non-native tests were tagged as native
Copy the list of tags when passing it to _syscall_test. |
259,853 | 24.07.2020 17:29:09 | 25,200 | ad97134ce2deaae7ffded0ce1b78920fe960465d | travis: run only arm64 builds
The travis capacity is limited, but we build and test amd64 on kokoro. | [
{
"change_type": "MODIFY",
"old_path": ".travis.yml",
"new_path": ".travis.yml",
"diff": "@@ -30,8 +30,10 @@ services:\n- docker\njobs:\ninclude:\n- - os: linux\n- arch: amd64\n+ # AMD64 builds are tested on kokoro, so don't run them in travis to save\n+ # capacity for arm64 builds.\n+ # - os: linux... | Go | Apache License 2.0 | google/gvisor | travis: run only arm64 builds
The travis capacity is limited, but we build and test amd64 on kokoro.
PiperOrigin-RevId: 323103934 |
259,907 | 24.07.2020 17:46:55 | 25,200 | 7dd8d87c9626af792efdb5bb9621c7814db887d7 | Fix make dev
The "dev" target had been failing. The failure was being caused due to variable
overload of "RUNTIME". | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -336,10 +336,10 @@ RUNTIME_LOGS := $(RUNTIME_LOG_DIR)/runsc.log.%TEST%.%TIMESTAMP%.%COMMAND%\ndev: ## Installs a set of local runtimes. Requires sudo.\n@$(call submake,refresh ARGS=\"--net-raw\")\n- @$(call submak... | Go | Apache License 2.0 | google/gvisor | Fix make dev
The "dev" target had been failing. The failure was being caused due to variable
overload of "RUNTIME".
PiperOrigin-RevId: 323106040 |
259,975 | 26.07.2020 21:42:17 | 25,200 | b38bae00885ef1bc97ff2798917e286bc14ca2f0 | Mark Passing Integration Tests for VFS2.
Mark the currently passing integration/image tests for
VFS2. Bugs will be filed for remaining failing tests.
Updates | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -166,11 +166,14 @@ do-tests: runsc\nsimple-tests: unit-tests # Compatibility target.\n.PHONY: simple-tests\n+IMAGE_FILTER := HelloWorld\\|Httpd\\|Ruby\\|Stdio\n+INTEGRATION_FILTER := Life\\|Pause\\|Connect\\|JobCo... | Go | Apache License 2.0 | google/gvisor | Mark Passing Integration Tests for VFS2.
Mark the currently passing integration/image tests for
VFS2. Bugs will be filed for remaining failing tests.
Updates #1487
PiperOrigin-RevId: 323297260 |
259,975 | 27.07.2020 10:00:17 | 25,200 | 29e5609b228363bcc435a8828f9b6ee19018a525 | Port redis benchmark | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/redis/Dockerfile",
"diff": "+FROM redis:5.0.4\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "test/benchmarks/database/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n... | Go | Apache License 2.0 | google/gvisor | Port redis benchmark
PiperOrigin-RevId: 323381964 |
259,975 | 27.07.2020 10:06:07 | 25,200 | 77552f1c770da7413c3c8212443328c9081901c0 | Port ffmpeg benchmark | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/ffmpeg/Dockerfile",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y \\\n+ ffmpeg \\\n+ && rm -rf /var/lib/apt/lists/*\n+WORKDIR /media\n+ADD https://samples.ffmpeg.org/MPEG-4/vide... | Go | Apache License 2.0 | google/gvisor | Port ffmpeg benchmark
PiperOrigin-RevId: 323383320 |
259,858 | 27.07.2020 10:38:24 | 25,200 | d0fd97541ad767975092d4ac3ecf3814797e931c | Clean-up bazel wrapper.
The bazel server was being started as the wrong user, leading to issues
where the container would suddenly exit during a build.
We can also simplify the waiting logic by starting the container in two
separate steps: those that must complete first, then the asynchronous bit. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -643,7 +643,9 @@ func TestExec(t *testing.T) {\nif err != nil {\nt.Fatalf(\"error creating temporary directory: %v\", err)\n}\n- cmd := fmt.Sprintf(\"ln -s /bin/tr... | Go | Apache License 2.0 | google/gvisor | Clean-up bazel wrapper.
The bazel server was being started as the wrong user, leading to issues
where the container would suddenly exit during a build.
We can also simplify the waiting logic by starting the container in two
separate steps: those that must complete first, then the asynchronous bit.
PiperOrigin-RevId: 323391161 |
259,985 | 27.07.2020 13:19:25 | 25,200 | c8fa685cb6b562e4d8fc05c7d01968e4e12234aa | Fix when FUSE tests need to be skipped due to sentry configuration. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mount.cc",
"new_path": "test/syscalls/linux/mount.cc",
"diff": "@@ -323,10 +323,7 @@ TEST(MountTest, RenameRemoveMountPoint) {\nTEST(MountTest, MountFuseFilesystemNoDevice) {\nSKIP_IF(!ASSERT_NO_ERRNO_AND_VALUE(HaveCapability(CAP_SYS_ADMIN)... | Go | Apache License 2.0 | google/gvisor | Fix when FUSE tests need to be skipped due to sentry configuration.
PiperOrigin-RevId: 323426851 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.