author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,858 | 27.07.2020 15:34:25 | 25,200 | 4b336f16b8fc85807cc852494ef1e105361135c6 | Enable RBE for standard-tests. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "# See the License for the specific language governing permissions and\n# limitations under the License.\n+# RBE requires a strong hash function, such as SHA256.\n+startup --host_jvm_args=-Dbazel.DigestFunction=SHA256... | Go | Apache License 2.0 | google/gvisor | Enable RBE for standard-tests.
PiperOrigin-RevId: 323454998 |
259,885 | 27.07.2020 19:25:31 | 25,200 | 18c246359663ae7e424f94225f11f87cc63eccd9 | Fix strace for epoll event arrays. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/epoll.go",
"new_path": "pkg/sentry/strace/epoll.go",
"diff": "@@ -50,10 +50,10 @@ func epollEvents(t *kernel.Task, eventsAddr usermem.Addr, numEvents, maxBytes ui\nsb.WriteString(\"...\")\nbreak\n}\n- if _, ok := addr.AddLength(uint64(linux.S... | Go | Apache License 2.0 | google/gvisor | Fix strace for epoll event arrays.
PiperOrigin-RevId: 323491461 |
259,858 | 28.07.2020 09:39:08 | 25,200 | a05ea20ef1107cc0a4ace94d6dffd7c7e590b264 | Don't attempt to use the secret if it does not exist.
Fixes | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -11,7 +11,13 @@ jobs:\ngenerate:\nruns-on: ubuntu-latest\nsteps:\n- - run: |\n+ - id: setup\n+ run: |\n+ if ! [[ -z \"${{ secrets.GO_TOKEN }}\" ]]; then\n+ echo ::set-output has_tok... | Go | Apache License 2.0 | google/gvisor | Don't attempt to use the secret if it does not exist.
Fixes #3326
PiperOrigin-RevId: 323589669 |
259,975 | 28.07.2020 12:51:54 | 25,200 | 5873b0f43f5ff4d811f951baaacb7bbe8b1a486c | Port tensorflow benchmark. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/tensorflow/Dockerfile",
"diff": "+FROM tensorflow/tensorflow:1.13.2\n+\n+RUN apt-get update \\\n+ && apt-get install -y git\n+RUN git clone --depth 1 https://github.com/aymericdamien/TensorFlow-Examples.git\n+RUN python -m pip ... | Go | Apache License 2.0 | google/gvisor | Port tensorflow benchmark.
PiperOrigin-RevId: 323633737 |
259,858 | 28.07.2020 13:51:38 | 25,200 | 7881610a3f9ac7382221ee17da908ff8f86053b5 | Use the appropriate remote configuration. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -23,10 +23,16 @@ build --stamp --workspace_status_command tools/workspace_status.sh\n# Enable remote execution so actions are performed on the remote systems.\nbuild:remote --remote_executor=grpcs://remotebuildexe... | Go | Apache License 2.0 | google/gvisor | Use the appropriate remote configuration.
PiperOrigin-RevId: 323646156 |
259,858 | 28.07.2020 16:04:34 | 25,200 | eca2fcce94de90a652b7924ef1ce971a9e0fe327 | Add MIT license to top-level LICENSE file.
This is needed for e.g. pkg/safecopy/memcpy_amd64.s. | [
{
"change_type": "MODIFY",
"old_path": "LICENSE",
"new_path": "LICENSE",
"diff": "WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\nSee the License for the specific language governing permissions and\nlimitations under the License.\n+\n+------------------\n+\n+Some files carr... | Go | Apache License 2.0 | google/gvisor | Add MIT license to top-level LICENSE file.
This is needed for e.g. pkg/safecopy/memcpy_amd64.s.
PiperOrigin-RevId: 323673052 |
259,858 | 28.07.2020 16:21:41 | 25,200 | c1c643abe7be45991c8004d0de2b31716702d527 | Delete unused script. | [
{
"change_type": "DELETE",
"old_path": "scripts/issue_reviver.sh",
"new_path": null,
"diff": "-#!/bin/bash\n-\n-# Copyright 2019 The gVisor Authors.\n-#\n-# Licensed under the Apache License, Version 2.0 (the \"License\");\n-# you may not use this file except in compliance with the License.\n-# You ... | Go | Apache License 2.0 | google/gvisor | Delete unused script.
PiperOrigin-RevId: 323676189 |
259,992 | 28.07.2020 21:22:52 | 25,200 | f82dd8ddb477b8923d1db12654a62d55d613019c | Redirect TODO to GitHub issues | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -423,7 +423,7 @@ func AddressAndFamily(addr []byte) (tcpip.FullAddress, uint16, *syserr.Error) {\nreturn tcpip.FullAddress{}, family, syserr.ErrInvalidAr... | Go | Apache License 2.0 | google/gvisor | Redirect TODO to GitHub issues
PiperOrigin-RevId: 323715260 |
259,975 | 29.07.2020 10:03:57 | 25,200 | 6b4e11ab5074d41044e63337973ac2438ce2278e | Port node benchmark. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/hey/Dockerfile",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y \\\n+ wget \\\n+ && rm -rf /var/lib/apt/lists/*\n+\n+RUN wget https://storage.googleapis.com/hey-release/hey_linux... | Go | Apache License 2.0 | google/gvisor | Port node benchmark.
PiperOrigin-RevId: 323810235 |
259,975 | 29.07.2020 10:05:46 | 25,200 | 1715896fc81fce0302e790186302d7460838a918 | Port fio benchmark | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/fio/Dockerfile",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y \\\n+ fio \\\n+ && rm -rf /var/lib/apt/lists/*\n"
},
{
"change_type": "MODIFY",
"old_path": "test/benc... | Go | Apache License 2.0 | google/gvisor | Port fio benchmark
PiperOrigin-RevId: 323810654 |
259,885 | 29.07.2020 14:56:14 | 25,200 | 4cd4759238655e35c8dc63723f4e55014b5ea9ea | Force registration for EPOLLHUP, not EPOLLRDHUP, in vfs2's epoll.
Compare Linux's fs/eventpoll.c:do_epoll_ctl(). I don't know where EPOLLRDHUP
came from. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/epoll.go",
"new_path": "pkg/sentry/vfs/epoll.go",
"diff": "@@ -186,7 +186,7 @@ func (ep *EpollInstance) AddInterest(file *FileDescription, num int32, event lin\n}\n// Register interest in file.\n- mask := event.Events | linux.EPOLLERR | linux.EP... | Go | Apache License 2.0 | google/gvisor | Force registration for EPOLLHUP, not EPOLLRDHUP, in vfs2's epoll.
Compare Linux's fs/eventpoll.c:do_epoll_ctl(). I don't know where EPOLLRDHUP
came from.
PiperOrigin-RevId: 323874419 |
259,858 | 30.07.2020 09:23:44 | 25,200 | 84496b3a619def2db0e25ab41f029823621bc713 | Disable consistently failing test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback_nogotsan.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback_nogotsan.cc",
"diff": "@@ -82,8 +82,11 @@ using SocketInetLoopbackTest = ::testing::TestWithParam<TestParam>;\n// This test verifies that connect retur... | Go | Apache License 2.0 | google/gvisor | Disable consistently failing test.
PiperOrigin-RevId: 324017310 |
259,858 | 30.07.2020 09:49:19 | 25,200 | 0d7c87ad014aa8eb931a5dcb970d736ce00d4b32 | Double the number of jobs used by RBE. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -50,14 +50,14 @@ build:remote --extra_toolchains=//tools/bazeldefs:cc-toolchain-clang-x86_64-defa\nbuild:remote --extra_execution_platforms=//tools/bazeldefs:rbe_ubuntu1604\nbuild:remote --platforms=//tools/bazeld... | Go | Apache License 2.0 | google/gvisor | Double the number of jobs used by RBE.
PiperOrigin-RevId: 324022546 |
259,858 | 30.07.2020 09:53:52 | 25,200 | 61b3e05f404a06995cb5da6187958f38af864ff6 | Drop complex awk step. | [
{
"change_type": "MODIFY",
"old_path": "tools/make_release.sh",
"new_path": "tools/make_release.sh",
"diff": "@@ -43,8 +43,7 @@ install_raw() {\n# Copy the raw file & generate a sha512sum.\nname=$(basename \"${binary}\")\ncp -f \"${binary}\" \"${root}/$1\"\n- sha512sum \"${root}/$1/${name}\" | \\\n-... | Go | Apache License 2.0 | google/gvisor | Drop complex awk step.
PiperOrigin-RevId: 324023425 |
259,858 | 30.07.2020 09:57:02 | 25,200 | cb1a3ba63a4a44cf929bb7a1449e76e7664923ff | Fix merge flow for Go branch. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -18,6 +18,7 @@ jobs:\nelse\necho ::set-output has_token=false\nfi\n+ - run: |\njq -nc '{\"state\": \"pending\", \"context\": \"go tests\"}' | \\\ncurl -sL -X POST -d @- \\\n-H \"Con... | Go | Apache License 2.0 | google/gvisor | Fix merge flow for Go branch.
PiperOrigin-RevId: 324024075 |
259,858 | 30.07.2020 10:05:53 | 25,200 | 6a59e765c32f151a549de967f6b010613a5b9aa0 | Override the test timeout for runtimes. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -155,7 +155,7 @@ syscall-tests: syscall-ptrace-tests syscall-kvm-tests syscall-native-tests\n%-runtime-tests: load-runtimes_%\n@$(call submake,install-test-runtime)\n- @$(call submake,test-runtime TARGETS=\"//test... | Go | Apache License 2.0 | google/gvisor | Override the test timeout for runtimes.
PiperOrigin-RevId: 324026021 |
259,975 | 30.07.2020 10:16:06 | 25,200 | 2775ecd931ec67a8ba68f743b684d88c19d45d44 | Update call in Node benchmark. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/network/node_test.go",
"new_path": "test/benchmarks/network/node_test.go",
"diff": "@@ -73,7 +73,7 @@ func runNode(b *testing.B, requests, concurrency int) {\nif out, err := redis.WaitForOutput(ctx, \"Ready to accept connections\", 3*time.Secon... | Go | Apache License 2.0 | google/gvisor | Update call in Node benchmark.
PiperOrigin-RevId: 324028183 |
259,860 | 30.07.2020 10:21:12 | 25,200 | c43305731e04ce8d4f2c9b2949c326abc9c2b77e | Fix SETOWN_EX return value.
Return on success should be 0, not size of the struct copied out. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_file.go",
"new_path": "pkg/sentry/syscalls/linux/sys_file.go",
"diff": "@@ -1057,7 +1057,7 @@ func Fcntl(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall\ncase linux.F_SETOWN_EX:\naddr := args[2].Pointer()\nva... | Go | Apache License 2.0 | google/gvisor | Fix SETOWN_EX return value.
Return on success should be 0, not size of the struct copied out.
PiperOrigin-RevId: 324029193 |
259,891 | 30.07.2020 11:27:47 | 25,200 | bc8201d01bc98e9db4009d250454c5fe73c5d2b4 | Have dockerutil.Wait* respect the context deadline | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/container.go",
"new_path": "pkg/test/dockerutil/container.go",
"diff": "@@ -454,15 +454,19 @@ func (c *Container) Wait(ctx context.Context) error {\n// WaitTimeout waits for the container to exit with a timeout.\nfunc (c *Container) WaitTim... | Go | Apache License 2.0 | google/gvisor | Have dockerutil.Wait* respect the context deadline
PiperOrigin-RevId: 324044634 |
260,004 | 30.07.2020 12:48:18 | 25,200 | b00858d075fbc39c6fb2db9f903ac14f197566bd | Use brodcast MAC for broadcast IPv4 packets
When sending packets to a known network's broadcast address, use the
broadcast MAC address.
Test:
stack_test.TestOutgoingSubnetBroadcast
udp_test.TestOutgoingSubnetBroadcast | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -110,6 +110,7 @@ go_test(\n\"//pkg/tcpip/transport/udp\",\n\"//pkg/waiter\",\n\"@com_github_google_go_cmp//cmp:go_default_library\",\n+ \"@com_github_google_go_cmp//cmp/cmpopts:go_default... | Go | Apache License 2.0 | google/gvisor | Use brodcast MAC for broadcast IPv4 packets
When sending packets to a known network's broadcast address, use the
broadcast MAC address.
Test:
- stack_test.TestOutgoingSubnetBroadcast
- udp_test.TestOutgoingSubnetBroadcast
PiperOrigin-RevId: 324062407 |
259,975 | 30.07.2020 13:31:05 | 25,200 | 78f1a18ab31fdc15155dd83d3ca96129b5031711 | Add runsc build benchmark. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/runsc/Dockerfile",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y \\\n+ wget \\\n+ git \\\n+ pkg-config \\\n+ zip \\\n+ g++ \\\n+ zlib1g-dev \\\n+ unzip \\\n+ python-minimal \\\n... | Go | Apache License 2.0 | google/gvisor | Add runsc build benchmark.
PiperOrigin-RevId: 324071377 |
259,858 | 30.07.2020 14:09:06 | 25,200 | 877fac48643772d3549b32d50b6d5f560770beb3 | Allocate a pseudo-tty for exec.
Otherwise Ctrl-C will kill the 'docker exec' as opposed to killing
the bazel command being run inside the container. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -48,7 +48,10 @@ FULL_DOCKER_RUN_OPTIONS += -v \"$(BAZEL_CACHE):$(BAZEL_CACHE)\"\nFULL_DOCKER_RUN_OPTIONS += -v \"$(GCLOUD_CONFIG):$(GCLOUD_CONFIG)\"\nFULL_DOCKER_RUN_OPTIONS += -v \"/tmp:/tmp\"\nFULL_D... | Go | Apache License 2.0 | google/gvisor | Allocate a pseudo-tty for exec.
Otherwise Ctrl-C will kill the 'docker exec' as opposed to killing
the bazel command being run inside the container.
PiperOrigin-RevId: 324079339 |
259,885 | 30.07.2020 14:13:11 | 25,200 | 3c70b4c986a2a6bb9b26f96e88f7fee878f29326 | Implement overlayfs_stale_read for vfs2. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/vfs.go",
"new_path": "runsc/boot/vfs.go",
"diff": "@@ -171,10 +171,19 @@ func (c *containerMounter) setupVFS2(ctx context.Context, conf *Config, procArgs\nfunc (c *containerMounter) createMountNamespaceVFS2(ctx context.Context, conf *Config, creds *... | Go | Apache License 2.0 | google/gvisor | Implement overlayfs_stale_read for vfs2.
PiperOrigin-RevId: 324080111 |
260,004 | 30.07.2020 14:19:38 | 25,200 | 9960a816a9ad65a4a6620eee5a66e5cc071b60cb | Enforce fragment block size and validate args
Allow configuring fragmentation.Fragmentation with a fragment
block size which will be enforced when processing fragments. Also
validate arguments when processing fragments.
Test:
- fragmentation.TestErrors
- ipv6_test.TestReceiveIPv6Fragments
- ipv4_test.TestReceiveIPv6Fragments | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/fragmentation/fragmentation.go",
"new_path": "pkg/tcpip/network/fragmentation/fragmentation.go",
"diff": "package fragmentation\nimport (\n+ \"errors\"\n\"fmt\"\n\"log\"\n\"time\"\n@@ -25,20 +26,31 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip/b... | Go | Apache License 2.0 | google/gvisor | Enforce fragment block size and validate args
Allow configuring fragmentation.Fragmentation with a fragment
block size which will be enforced when processing fragments. Also
validate arguments when processing fragments.
Test:
- fragmentation.TestErrors
- ipv6_test.TestReceiveIPv6Fragments
- ipv4_test.TestReceiveIPv6Fragments
PiperOrigin-RevId: 324081521 |
260,023 | 30.07.2020 22:47:37 | 25,200 | ad8164bb50dd01bfd59c9a6c72d9cbb0d4710f15 | Fix TCP CurrentConnected counter updates.
CurrentConnected counter is incorrectly decremented on close of an
endpoint which is still not connected.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1024,14 +1024,19 @@ func (e *endpoint) transitionToStateEstablishedLocked(h *handshake) {\n// delivered to this endpoint from the demuxer when the endpoint\n// ... | Go | Apache License 2.0 | google/gvisor | Fix TCP CurrentConnected counter updates.
CurrentConnected counter is incorrectly decremented on close of an
endpoint which is still not connected.
Fixes #3443
PiperOrigin-RevId: 324155171 |
259,860 | 31.07.2020 00:38:57 | 25,200 | 68a7da9549ac4f6290fe85d2dab550e11f16b209 | Clean up vfs2 fallocate.
Move to setstat.go and add a FileDescription wrapper method. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/filesystem.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/filesystem.go",
"diff": "@@ -18,7 +18,6 @@ import (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/sentry/arch\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel\"\... | Go | Apache License 2.0 | google/gvisor | Clean up vfs2 fallocate.
Move to setstat.go and add a FileDescription wrapper method.
PiperOrigin-RevId: 324165277 |
259,891 | 11.06.2020 20:33:56 | 25,200 | 2a7b2a61e3ea32129c26eeaa6fab3d81a5d8ad6e | iptables: support SO_ORIGINAL_DST
Envoy uses this to get the original destination of redirected
packets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -59,7 +59,7 @@ var VerdictStrings = map[int32]string{\nNF_RETURN: \"RETURN\",\n}\n-// Socket options. These correspond to values in\n+// Socket options for SOL_SOCKET. These cor... | Go | Apache License 2.0 | google/gvisor | iptables: support SO_ORIGINAL_DST
Envoy (#170) uses this to get the original destination of redirected
packets. |
259,858 | 31.07.2020 16:06:13 | 25,200 | a7d9aa6d5bfbed11c94578c6a2eb04ce75cbdbe5 | Use proper set-output syntax. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -14,9 +14,9 @@ jobs:\n- id: setup\nrun: |\nif ! [[ -z \"${{ secrets.GO_TOKEN }}\" ]]; then\n- echo ::set-output has_token=true\n+ echo ::set-output name=has_token::true\nelse\n- ech... | Go | Apache License 2.0 | google/gvisor | Use proper set-output syntax.
PiperOrigin-RevId: 324302828 |
259,853 | 31.07.2020 16:10:24 | 25,200 | fd5f4ffed1e425ec29d29477dc4e2a61420c1cf6 | test/socket_netlink_route: check that there is a route on local or main tables
A new network namespace has only the local route table. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_netlink_route.cc",
"new_path": "test/syscalls/linux/socket_netlink_route.cc",
"diff": "@@ -577,7 +577,10 @@ TEST(NetlinkRouteTest, GetRouteDump) {\nstd::cout << std::endl;\n- if (msg->rtm_table == RT_TABLE_MAIN) {\n+ // If the test i... | Go | Apache License 2.0 | google/gvisor | test/socket_netlink_route: check that there is a route on local or main tables
A new network namespace has only the local route table.
PiperOrigin-RevId: 324303629 |
259,983 | 31.07.2020 15:56:18 | 25,200 | e76c3c1064e2cb6ef79ea010705230a646369c49 | Fix MountFuseFilesystem tests failing
Before kernel version 4.16-rc6, fuse mount is protected by
capable(CAP_SYS_ADMIN). After this version, it uses
ns_capable(CAP_SYS_ADMIN) to protect. Before the 4.16 kernel,
it was not allowed to mount fuse file systems without the
global CAP_SYS_ADMIN.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mount.cc",
"new_path": "test/syscalls/linux/mount.cc",
"diff": "@@ -326,6 +326,14 @@ TEST(MountTest, MountFuseFilesystemNoDevice) {\nSKIP_IF(IsRunningOnGvisor() && !IsFUSEEnabled());\nauto const dir = ASSERT_NO_ERRNO_AND_VALUE(TempPath::Cre... | Go | Apache License 2.0 | google/gvisor | Fix MountFuseFilesystem tests failing
Before kernel version 4.16-rc6, fuse mount is protected by
capable(CAP_SYS_ADMIN). After this version, it uses
ns_capable(CAP_SYS_ADMIN) to protect. Before the 4.16 kernel,
it was not allowed to mount fuse file systems without the
global CAP_SYS_ADMIN.
Fixes #3360 |
259,891 | 31.07.2020 16:18:23 | 25,200 | fcc88a8b27ba1f7e572ebff00cf13460bdd4586b | Fix PHONY target typos | [
{
"change_type": "MODIFY",
"old_path": ".travis.yml",
"new_path": ".travis.yml",
"diff": "@@ -40,7 +40,7 @@ script:\n# On arm64, we need to create our own pipes for stderr and stdout,\n# otherwise we will not be able to open /dev/stderr. This is probably\n# due to AppArmor rules.\n- - bash -xeo pipe... | Go | Apache License 2.0 | google/gvisor | Fix PHONY target typos
PiperOrigin-RevId: 324305107 |
259,858 | 03.08.2020 09:07:43 | 25,200 | 10f6c41bbd5dbc84c57aedb4cb86e7dfd59a8114 | Include shim binaries in the Go branch. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -49,7 +49,9 @@ jobs:\nkey: ${{ runner.os }}-bazel-${{ hashFiles('WORKSPACE') }}\nrestore-keys: |\n${{ runner.os }}-bazel-\n- - run: make build TARGETS=\"//:gopath\"\n+ - run: |\n+ r... | Go | Apache License 2.0 | google/gvisor | Include shim binaries in the Go branch.
PiperOrigin-RevId: 324615016 |
259,858 | 03.08.2020 11:20:31 | 25,200 | e3c349d21957edbc124647e122f5d07e2e853690 | Fix syntax error in issue_reviver. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/issue_reviver.yml",
"new_path": ".github/workflows/issue_reviver.yml",
"diff": "@@ -8,9 +8,9 @@ jobs:\nruns-on: ubuntu-latest\nsteps:\n- uses: actions/checkout@v2\n- if: github.repository == \"google/gvisor\"\n+ if: github.repository == 'goog... | Go | Apache License 2.0 | google/gvisor | Fix syntax error in issue_reviver.
PiperOrigin-RevId: 324642975 |
259,860 | 03.08.2020 12:30:23 | 25,200 | 1fbbc795ef8918006214032d96fa88b8a21e5e0a | Add inotify events for fallocate and tests for fallocate/sendfile.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/setstat.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/setstat.go",
"diff": "@@ -254,11 +254,12 @@ func Fallocate(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sys\nreturn 0, nil, syserror.EFBIG\n}\n- return 0, ... | Go | Apache License 2.0 | google/gvisor | Add inotify events for fallocate and tests for fallocate/sendfile.
Updates #1479, #2923.
PiperOrigin-RevId: 324658826 |
259,860 | 03.08.2020 15:23:05 | 25,200 | 5626ccf61f718d80d46049e11d040a3a8fc72fb9 | Remove old TODO.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/fd.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/fd.go",
"diff": "@@ -208,7 +208,7 @@ func Fcntl(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall\ncase linux.F_SETLK, linux.F_SETLKW:\nreturn 0, nil, posixL... | Go | Apache License 2.0 | google/gvisor | Remove old TODO.
Fixes #2920.
PiperOrigin-RevId: 324695118 |
259,907 | 03.08.2020 18:15:11 | 25,200 | ad7c9fc4c3c027ea7ed211a6bdb35c38156280e6 | [vfs2] Implement /sys/devices/system/cpu/cpuX.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/sys/sys.go",
"new_path": "pkg/sentry/fsimpl/sys/sys.go",
"diff": "@@ -30,6 +30,7 @@ import (\n// Name is the default filesystem name.\nconst Name = \"sysfs\"\n+const defaultSysDirMode = linux.FileMode(0755)\n// FilesystemType implements vfs.F... | Go | Apache License 2.0 | google/gvisor | [vfs2] Implement /sys/devices/system/cpu/cpuX.
Fixes #3364
PiperOrigin-RevId: 324724614 |
259,884 | 04.08.2020 01:05:42 | 25,200 | a02b7534f21d4f963ace890e80d7bf17e0d5d10f | Fix grouping and ordering of website menus
Groups subcategories and sorts their pages by weight properly. Subcategories
are sorted by name. Pages within subcategories are sorted by weight. | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -30,7 +30,7 @@ doc(\npermalink = \"/community/governance/\",\nsubcategory = \"Community\",\nvisibility = [\"//website:__pkg__\"],\n- weight = \"91\",\n+ weight = \"20\",\n)\ndoc(\n"
},
{
"change_type": "MODIFY",... | Go | Apache License 2.0 | google/gvisor | Fix grouping and ordering of website menus
Groups subcategories and sorts their pages by weight properly. Subcategories
are sorted by name. Pages within subcategories are sorted by weight.
PiperOrigin-RevId: 324766128 |
259,962 | 04.08.2020 09:04:53 | 25,200 | 1bdadbc4f84bf5aacd63d1f486d4c4610dea4110 | Fix broken httpd_test. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/network/httpd_test.go",
"new_path": "test/benchmarks/network/httpd_test.go",
"diff": "@@ -68,13 +68,13 @@ func BenchmarkHttpdConcurrency(b *testing.B) {\n// BenchmarkHttpdDocSize iterates over different sized payloads, testing how\n// well the ... | Go | Apache License 2.0 | google/gvisor | Fix broken httpd_test.
PiperOrigin-RevId: 324822613 |
259,907 | 04.08.2020 09:49:33 | 25,200 | 7dfcf727a5730b15020f136282a1ede15144a268 | [runtime tests] Fix nodejs runtime tests.
Exclude flaky tests.
Bump timeout.
Un-exclude passing tests to increase testing surface.
Create/Update bugs for tests that pass on runc but fail on runsc. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude_nodejs12.4.0.csv",
"new_path": "test/runtimes/exclude_nodejs12.4.0.csv",
"diff": "test name,bug id,comment\nbenchmark/test-benchmark-fs.js,,\n-benchmark/test-benchmark-module.js,,\nbenchmark/test-benchmark-napi.js,,\ndoctool/test-make-doc... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Fix nodejs runtime tests.
- Exclude flaky tests.
- Bump timeout.
- Un-exclude passing tests to increase testing surface.
- Create/Update bugs for tests that pass on runc but fail on runsc.
PiperOrigin-RevId: 324830840 |
259,891 | 04.08.2020 10:01:05 | 25,200 | 12c2c6ae303c97be5ad8e62b67ca265e2c4e0ba6 | docs: tools/images.mk does not exist. | [
{
"change_type": "MODIFY",
"old_path": "images/README.md",
"new_path": "images/README.md",
"diff": "@@ -7,7 +7,7 @@ Note that all these images must be pushed to the testing project hosted on\ncontinuous integration. This will speed up loading as images will not need to be\nbuilt from scratch for eac... | Go | Apache License 2.0 | google/gvisor | docs: tools/images.mk does not exist.
PiperOrigin-RevId: 324833018 |
259,983 | 04.08.2020 12:27:55 | 25,200 | 21d0334e7f4a98ec49e7f46cacf2d51258eaec33 | Add FUSE integration test
This commit adds an integration test framework for FUSE support. Please
refer to the test example and test/fuse/README.md for further details.
Fixes | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "scripts/fuse_tests.sh",
"diff": "+#!/bin/bash\n+\n+# Copyright 2020 The gVisor Authors.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may ob... | Go | Apache License 2.0 | google/gvisor | Add FUSE integration test
This commit adds an integration test framework for FUSE support. Please
refer to the test example and test/fuse/README.md for further details.
Fixes #3098 |
260,004 | 04.08.2020 16:25:15 | 25,200 | 00993130e5a9c05aaa88c5a860407b079093a024 | Use 1 fragmentation component per IP stack
This will help manage memory consumption by IP reassembly when
receiving IP fragments on multiple network endpoints. Previously,
each endpoint would cap memory consumption at 4MB, but with this
change, each IP stack will cap memory consumption at 4MB.
No behaviour changes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -57,7 +57,6 @@ type endpoint struct {\nprefixLen int\nlinkEP stack.LinkEndpoint\ndispatcher stack.TransportDispatcher\n- fragmentation *fragmentation.Fragmentation\nprot... | Go | Apache License 2.0 | google/gvisor | Use 1 fragmentation component per IP stack
This will help manage memory consumption by IP reassembly when
receiving IP fragments on multiple network endpoints. Previously,
each endpoint would cap memory consumption at 4MB, but with this
change, each IP stack will cap memory consumption at 4MB.
No behaviour changes.
PiperOrigin-RevId: 324913904 |
259,975 | 04.08.2020 16:48:40 | 25,200 | be7079578e0907fd3f35f91e9716246c179e17e9 | Port sysbench benchmark. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/sysbench/Dockerfile",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y \\\n+ sysbench \\\n+ && rm -rf /var/lib/apt/lists/*\n"
},
{
"change_type": "ADD",
"old_path": nul... | Go | Apache License 2.0 | google/gvisor | Port sysbench benchmark.
PiperOrigin-RevId: 324918229 |
259,907 | 04.08.2020 17:18:48 | 25,200 | 338f96b36c778748ff27f5ae73cc73b222c5a90e | [runtime tests] Exclude flaky tests. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude_nodejs12.4.0.csv",
"new_path": "test/runtimes/exclude_nodejs12.4.0.csv",
"diff": "@@ -16,8 +16,11 @@ parallel/test-http-writable-true-after-close.js,,Flaky - Mismatched <anonymous>\nparallel/test-os.js,b/63997097,\nparallel/test-process-u... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Exclude flaky tests.
PiperOrigin-RevId: 324923599 |
259,992 | 04.08.2020 19:04:12 | 25,200 | 102735bfb45820dd840df14827b42744da77c9a0 | Inline gofer.regularFileFD.pwriteLocked
Go compiler barely inlines anything, so inline by hand
pwriteLocked since it's called from a single place. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -184,6 +184,7 @@ func (fd *regularFileFD) pwrite(ctx context.Context, src usermem.IOSequence, off\nd.metadataMu.Lock()\ndefer d.metadataMu.Unlock()\n+\... | Go | Apache License 2.0 | google/gvisor | Inline gofer.regularFileFD.pwriteLocked
Go compiler barely inlines anything, so inline by hand
pwriteLocked since it's called from a single place.
PiperOrigin-RevId: 324937734 |
259,860 | 04.08.2020 19:10:28 | 25,200 | 87ee3898f78cb7d520281ead600036052d6a2049 | Handle EOF in vfs2 sendfile.
Discovered by syzkaller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/splice.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/splice.go",
"diff": "@@ -347,6 +347,11 @@ func Sendfile(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysc\n} else {\nspliceN, err = inFile.Read(t, outPipeFD... | Go | Apache License 2.0 | google/gvisor | Handle EOF in vfs2 sendfile.
Discovered by syzkaller.
PiperOrigin-RevId: 324938438 |
259,858 | 04.08.2020 20:49:00 | 25,200 | c5f5806fe69e8d4be99341318f20ce0acfd7be2a | Enable "make packetimpact-tests" to work.
This required minor fixes to the bazel wrapper. The "dut_platform" is
also changed to "native" to line-up with the system call tests and
remove the hard-coded "linux" and "netstack" strings. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -185,7 +185,6 @@ swgso-tests: load-basic-images\n@$(call submake,install-test-runtime RUNTIME=\"swgso\" ARGS=\"--software-gso=true --gso=false\")\n@$(call submake,test-runtime RUNTIME=\"swgso\" TARGETS=\"$(INTEGRA... | Go | Apache License 2.0 | google/gvisor | Enable "make packetimpact-tests" to work.
This required minor fixes to the bazel wrapper. The "dut_platform" is
also changed to "native" to line-up with the system call tests and
remove the hard-coded "linux" and "netstack" strings. |
259,896 | 04.08.2020 20:57:28 | 25,200 | 0e6f7a12c29efa52581c38ca30637b133556a6cf | Update variables for implementation of RACK in TCP
RACK (Recent Acknowledgement) is a new loss detection
algorithm in TCP. These are the fields which should be
stored on connections to implement RACK algorithm. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -73,6 +73,16 @@ type TCPCubicState struct {\nWEst float64\n}\n+// TCPRACKState is used to hold a copy of the internal RACK state when the\n+// TCPProbeFunc is invoked.\n+type TCPRAC... | Go | Apache License 2.0 | google/gvisor | Update variables for implementation of RACK in TCP
RACK (Recent Acknowledgement) is a new loss detection
algorithm in TCP. These are the fields which should be
stored on connections to implement RACK algorithm.
PiperOrigin-RevId: 324948703 |
259,857 | 24.03.2020 12:40:52 | 0 | 6ce10c3c2ff516aabdef8b4d198690e7e7a87ca4 | amd64: introduce kernelEntry
kernelEntry is split from CPU that contains minimal CPU-specific
arch state that can be mapped at the upper of the address space.
It is prepared for KPTI for gvisor. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"diff": "@@ -144,6 +144,7 @@ func (c *vCPU) initArchState() error {\n// Set the entrypoint for the kernel.\nkernelUserRegs.RIP = uint64(reflect.ValueOf(ring0.Sta... | Go | Apache License 2.0 | google/gvisor | amd64: introduce kernelEntry
kernelEntry is split from CPU that contains minimal CPU-specific
arch state that can be mapped at the upper of the address space.
It is prepared for KPTI for gvisor.
Signed-off-by: Lai Jiangshan <jiangshan.ljs@antfin.com>
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com> |
259,860 | 05.08.2020 08:33:52 | 25,200 | a2e129b540e530c56cb7648ae7e04325c6e763b1 | Add missing case in tmpfs.inode.direntType.
This was discovered by syzkaller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"diff": "@@ -558,6 +558,8 @@ func (i *inode) direntType() uint8 {\nreturn linux.DT_LNK\ncase *socketFile:\nreturn linux.DT_SOCK\n+ case *namedPipe:\n+ return linux.DT_FIFO\ncase... | Go | Apache License 2.0 | google/gvisor | Add missing case in tmpfs.inode.direntType.
This was discovered by syzkaller.
PiperOrigin-RevId: 325025193 |
259,907 | 05.08.2020 10:21:17 | 25,200 | d0127b23f26d546db0d525201f0ad3f43d5b8d24 | [runtime tests] Update bugs and un-exclude passing tests. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude_nodejs12.4.0.csv",
"new_path": "test/runtimes/exclude_nodejs12.4.0.csv",
"diff": "@@ -11,6 +11,7 @@ parallel/test-dgram-socket-buffer-size.js,b/68847921,\nparallel/test-dns-channel-timeout.js,b/161893056,\nparallel/test-fs-access.js,,\npa... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Update bugs and un-exclude passing tests.
PiperOrigin-RevId: 325045486 |
259,992 | 05.08.2020 11:28:15 | 25,200 | 190b1e6bd4aae56eff3ff846efea38629361b3a9 | Stop profiling when the sentry exits
Also removes `--profile-goroutine` because it's equivalent
to `debug --stacks`. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/pprof.go",
"new_path": "pkg/sentry/control/pprof.go",
"diff": "@@ -49,6 +49,9 @@ type ProfileOpts struct {\n// - dump out the stack trace of current go routines.\n// sentryctl -pid <pid> pprof-goroutine\ntype Profile struct {\n+ // Kernel is... | Go | Apache License 2.0 | google/gvisor | Stop profiling when the sentry exits
Also removes `--profile-goroutine` because it's equivalent
to `debug --stacks`.
PiperOrigin-RevId: 325061502 |
259,962 | 05.08.2020 14:09:26 | 25,200 | e7b232a5b881c8930db968a7709ebd93cb2cab04 | Prefer RLock over Lock in functions that don't need Lock().
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1985,8 +1985,8 @@ func generateRandInt64() int64 {\n// FindNetworkEndpoint returns the network endpoint for the given address.\nfunc (s *Stack) FindNetworkEndpoint(netProto tcpip.N... | Go | Apache License 2.0 | google/gvisor | Prefer RLock over Lock in functions that don't need Lock().
Updates #231
PiperOrigin-RevId: 325097683 |
259,860 | 05.08.2020 16:14:40 | 25,200 | 1403a88c67ccc87af383f5e54fd2f77c673eebe7 | Release extra memfd reference. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/memfd.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/memfd.go",
"diff": "@@ -51,6 +51,7 @@ func MemfdCreate(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.S\nif err != nil {\nreturn 0, nil, err\n}\n+ defer file.D... | Go | Apache License 2.0 | google/gvisor | Release extra memfd reference.
PiperOrigin-RevId: 325122849 |
260,004 | 05.08.2020 17:30:39 | 25,200 | 90a2d4e8238a9a92b77d363439485d3e8b2211ac | Support receiving broadcast IPv4 packets
Test: integration_test.TestIncomingSubnetBroadcast | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -609,6 +609,9 @@ func (n *NIC) findEndpoint(protocol tcpip.NetworkProtocolNumber, address tcpip.A\n// If none exists a temporary one may be created if we are in promiscuous mode\n// or ... | Go | Apache License 2.0 | google/gvisor | Support receiving broadcast IPv4 packets
Test: integration_test.TestIncomingSubnetBroadcast
PiperOrigin-RevId: 325135617 |
259,907 | 05.08.2020 17:46:13 | 25,200 | ce463c027b0d3cbcf3b9d3e2a5ad598c0249212f | [runtime tests] Update python tests.
un-exclude passing tests to increase testing surface.
create/update bugs for tests that fail on runsc but pass on runc. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude_python3.7.3.csv",
"new_path": "test/runtimes/exclude_python3.7.3.csv",
"diff": "test name,bug id,comment\n-test_asynchat,b/76031995,SO_REUSEADDR\ntest_asyncio,,Fails on Docker.\n-test_asyncore,b/76031995,SO_REUSEADDR\n-test_epoll,,\n-test... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Update python tests.
- un-exclude passing tests to increase testing surface.
- create/update bugs for tests that fail on runsc but pass on runc.
PiperOrigin-RevId: 325137657 |
259,860 | 05.08.2020 18:15:01 | 25,200 | 7ed4b2b5a6928b3a4a88d0117a764dd4795be61a | Correctly decrement link counts in tmpfs rename operations.
When a directory is replaced by a rename operation, its link count should
reach zero. We were missing the link from `dir/.` | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -566,7 +566,9 @@ func (fs *filesystem) RenameAt(ctx context.Context, rp *vfs.ResolvingPath, oldPa\nif replaced != nil {\nnewParentDir.removeChildLocked(rep... | Go | Apache License 2.0 | google/gvisor | Correctly decrement link counts in tmpfs rename operations.
When a directory is replaced by a rename operation, its link count should
reach zero. We were missing the link from `dir/.`
PiperOrigin-RevId: 325141730 |
259,896 | 05.08.2020 20:45:02 | 25,200 | 35312a95c4c8626365b4ece5ffb0bcab44b4bede | Add loss recovery option for TCP.
/proc/sys/net/ipv4/tcp_recovery is used to enable RACK loss
recovery in TCP. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/sys_net.go",
"new_path": "pkg/sentry/fs/proc/sys_net.go",
"diff": "@@ -272,6 +272,96 @@ func (f *tcpSackFile) Write(ctx context.Context, _ *fs.File, src usermem.IOSeque\nreturn n, f.tcpSack.stack.SetTCPSACKEnabled(*f.tcpSack.enabled)\n}\n+//... | Go | Apache License 2.0 | google/gvisor | Add loss recovery option for TCP.
/proc/sys/net/ipv4/tcp_recovery is used to enable RACK loss
recovery in TCP.
PiperOrigin-RevId: 325157807 |
260,004 | 06.08.2020 01:29:32 | 25,200 | fc4dd3ef455975a033714052b12ebebc85e937d5 | Join IPv4 all-systems group on NIC enable
Test:
stack_test.TestJoinLeaveMulticastOnNICEnableDisable
integration_test.TestIncomingMulticastAndBroadcast | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv4.go",
"new_path": "pkg/tcpip/header/ipv4.go",
"diff": "@@ -101,6 +101,11 @@ const (\n// IPv4Version is the version of the ipv4 protocol.\nIPv4Version = 4\n+ // IPv4AllSystems is the all systems IPv4 multicast address as per\n+ // IANA's IP... | Go | Apache License 2.0 | google/gvisor | Join IPv4 all-systems group on NIC enable
Test:
- stack_test.TestJoinLeaveMulticastOnNICEnableDisable
- integration_test.TestIncomingMulticastAndBroadcast
PiperOrigin-RevId: 325185259 |
259,860 | 06.08.2020 11:01:13 | 25,200 | 63447e5afae62dab64940054372166dab45a057c | Only register /dev/net/tun if supported. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/devices/tundev/tundev.go",
"new_path": "pkg/sentry/devices/tundev/tundev.go",
"diff": "@@ -160,8 +160,8 @@ func (fd *tunFD) EventUnregister(e *waiter.Entry) {\nfd.device.EventUnregister(e)\n}\n-// isNetTunSupported returns whether /dev/net/tun devic... | Go | Apache License 2.0 | google/gvisor | Only register /dev/net/tun if supported.
PiperOrigin-RevId: 325266487 |
259,984 | 05.08.2020 18:29:59 | 0 | 92c06435874434836973d478ba469bc8f5aca356 | add stub go marshallable implementation | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/marshal/BUILD",
"new_path": "tools/go_marshal/marshal/BUILD",
"diff": "@@ -6,6 +6,7 @@ go_library(\nname = \"marshal\",\nsrcs = [\n\"marshal.go\",\n+ \"marshal_impl_util.go\",\n],\nvisibility = [\n\"//:sandbox\",\n"
},
{
"change_type":... | Go | Apache License 2.0 | google/gvisor | add stub go marshallable implementation |
259,992 | 06.08.2020 18:13:55 | 25,200 | f20e63e31b56784c596897e86f03441f9d05f567 | Add LinkAt support to gofer
Updates | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/basic/linktest/Dockerfile",
"diff": "+FROM ubuntu:bionic\n+\n+WORKDIR /root\n+COPY . .\n+\n+RUN apt-get update && apt-get install -y gcc\n+RUN gcc -O2 -o link_test link_test.c\n"
},
{
"change_type": "ADD",
"old_path": null,
... | Go | Apache License 2.0 | google/gvisor | Add LinkAt support to gofer
Updates #1198
PiperOrigin-RevId: 325350818 |
259,885 | 07.08.2020 00:10:35 | 25,200 | 4fa1c304a133297bc6895729d74aa35a015e759e | Try to update atime and mtime on VFS2 gofer files on dentry eviction. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -192,10 +192,14 @@ const (\n//\n// - File timestamps are based on client clocks. This ensures that users of\n// the client observe timestamps that are coherent with ... | Go | Apache License 2.0 | google/gvisor | Try to update atime and mtime on VFS2 gofer files on dentry eviction.
PiperOrigin-RevId: 325388385 |
259,885 | 07.08.2020 11:24:09 | 25,200 | 8c1573ebab260a2a40c41265918df3533bd93b3d | Tolerate EINTR from fallocate() in inotify test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/inotify.cc",
"new_path": "test/syscalls/linux/inotify.cc",
"diff": "@@ -1693,7 +1693,7 @@ TEST(Inotify, Fallocate) {\nInotifyAddWatch(inotify_fd.get(), file.path(), IN_ALL_EVENTS));\n// Do an arbitrary modification with fallocate.\n- ASSERT... | Go | Apache License 2.0 | google/gvisor | Tolerate EINTR from fallocate() in inotify test.
PiperOrigin-RevId: 325472312 |
259,853 | 07.08.2020 13:08:51 | 25,200 | 10c13bccaf5ec963b78f5e61629b4528ed9e9c6b | tcp: change the limit of TCP_LINGER2
It was changed in the Linux kernel:
commit
Date: Fri Apr 24 16:06:16 2020 +0800
net: Replace the limit of TCP_LINGER2 with TCP_FIN_TIMEOUT_MAX | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1777,15 +1777,8 @@ func (e *endpoint) SetSockOpt(opt interface{}) *tcpip.Error {\n// Same as effectively disabling TCPLinger timeout.\nv = 0\n}\n- var stkTCPL... | Go | Apache License 2.0 | google/gvisor | tcp: change the limit of TCP_LINGER2
It was changed in the Linux kernel:
commit f0628c524fd188c3f9418e12478dfdfadacba815
Date: Fri Apr 24 16:06:16 2020 +0800
net: Replace the limit of TCP_LINGER2 with TCP_FIN_TIMEOUT_MAX
PiperOrigin-RevId: 325493859 |
259,975 | 07.08.2020 13:28:11 | 25,200 | a7bd0a701289f8d808f93eaded266f6a1bab03ea | Port Startup and Density Benchmarks. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/alpine/Dockerfile",
"diff": "+FROM alpine:latest\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/util/Dockerfile",
"diff": "+FROM ubuntu:bionic\n+\n+RUN apt-get update && apt-g... | Go | Apache License 2.0 | google/gvisor | Port Startup and Density Benchmarks.
PiperOrigin-RevId: 325497346 |
259,975 | 07.08.2020 13:47:03 | 25,200 | 7b9bfc0ce094b0fd0cb3beec665a7b64c4ec552e | Port Ruby benchmark. | [
{
"change_type": "MODIFY",
"old_path": "images/Makefile",
"new_path": "images/Makefile",
"diff": "@@ -59,9 +59,9 @@ local_image = $(LOCAL_IMAGE_PREFIX)/$(subst _,/,$(1))\n# we need to explicitly repull the base layer in order to ensure that the\n# architecture is correct. Note that we use the term \... | Go | Apache License 2.0 | google/gvisor | Port Ruby benchmark.
PiperOrigin-RevId: 325500772 |
259,885 | 07.08.2020 16:33:37 | 25,200 | 0b7cd1e751f70cf6b335754d2b173d9c12b674c7 | Mark dropped pages unevictable in fsimpl/gofer.dentry.destroyLocked. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -1264,8 +1264,11 @@ func (d *dentry) destroyLocked(ctx context.Context) {\n}\n}\n// Discard cached data.\n+ if !d.cache.IsEmpty() {\n+ mf.MarkAllUnevictable(d)\nd.ca... | Go | Apache License 2.0 | google/gvisor | Mark dropped pages unevictable in fsimpl/gofer.dentry.destroyLocked.
PiperOrigin-RevId: 325531657 |
259,853 | 07.08.2020 17:59:07 | 25,200 | b7a97fe33541fa400cc2b949baf0b31634d2410c | Remove doc rules for non-existent files
These files have been deleted by cl/324775563. | [
{
"change_type": "MODIFY",
"old_path": "shim/v1/BUILD",
"new_path": "shim/v1/BUILD",
"diff": "load(\"//tools:defs.bzl\", \"go_binary\")\n-load(\"//website:defs.bzl\", \"doc\")\npackage(licenses = [\"notice\"])\n@@ -29,13 +28,3 @@ go_binary(\n\"@org_golang_x_sys//unix:go_default_library\",\n],\n)\n-\... | Go | Apache License 2.0 | google/gvisor | Remove doc rules for non-existent files
These files have been deleted by cl/324775563.
PiperOrigin-RevId: 325543067 |
259,885 | 07.08.2020 18:32:03 | 25,200 | 343661770aa96efe3b539a82addff13df235413f | Don't hold gofer.filesystem.renameMu during dentry destruction. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -1158,7 +1158,8 @@ func (d *dentry) OnZeroWatches(ctx context.Context) {\n// operation. One of the calls may destroy the dentry, so subsequent calls will\n// do noth... | Go | Apache License 2.0 | google/gvisor | Don't hold gofer.filesystem.renameMu during dentry destruction.
PiperOrigin-RevId: 325546629 |
259,853 | 07.08.2020 22:47:55 | 25,200 | 13a8ae81b2361cd32f8e73d14ca5b9bca9569b1a | Add context.FullStateChanged()
It indicates that the Sentry has changed the state of the thread and
next calls of PullFullState() has to do nothing. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/ptrace.go",
"new_path": "pkg/sentry/kernel/ptrace.go",
"diff": "@@ -1063,7 +1063,7 @@ func (t *Task) Ptrace(req int64, pid ThreadID, addr, data usermem.Addr) error {\nif err != nil {\nreturn err\n}\n- t.p.FloatingPointStateChanged()\n+ t.p.Fu... | Go | Apache License 2.0 | google/gvisor | Add context.FullStateChanged()
It indicates that the Sentry has changed the state of the thread and
next calls of PullFullState() has to do nothing.
PiperOrigin-RevId: 325567415 |
260,004 | 08.08.2020 17:43:15 | 25,200 | b404b5c255214a37d7f787f9fe24bb8e22509eb4 | Use unicast source for ICMP echo replies
Packets MUST NOT use a non-unicast source address for ICMP
Echo Replies.
Test: integration_test.TestPingMulticastBroadcast | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/icmp.go",
"new_path": "pkg/tcpip/network/ipv4/icmp.go",
"diff": "@@ -96,6 +96,26 @@ func (e *endpoint) handleICMP(r *stack.Route, pkt *stack.PacketBuffer) {\nNetworkHeader: append(buffer.View(nil), pkt.NetworkHeader...),\n})\n+ remoteLin... | Go | Apache License 2.0 | google/gvisor | Use unicast source for ICMP echo replies
Packets MUST NOT use a non-unicast source address for ICMP
Echo Replies.
Test: integration_test.TestPingMulticastBroadcast
PiperOrigin-RevId: 325634380 |
259,975 | 10.08.2020 12:25:48 | 25,200 | 9ac71dc78fd1a2487780686332e54c21a1cb2cd3 | Mark DirCreation/tmp tests as passing. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -166,8 +166,9 @@ do-tests: runsc\nsimple-tests: unit-tests # Compatibility target.\n.PHONY: simple-tests\n+# Keep these in sync with //scripts/docker_tests.sh.\nIMAGE_FILTER := HelloWorld\\|Httpd\\|Ruby\\|Stdio\n-... | Go | Apache License 2.0 | google/gvisor | Mark DirCreation/tmp tests as passing.
PiperOrigin-RevId: 325861904 |
259,891 | 10.08.2020 13:49:51 | 25,200 | 7ba5e3558aace529f9a0553015cc5074705e7a79 | ip6tables: move target-specific code to targets.go
This is purely moving code, no changes. netfilter.go is cluttered and targets.go
is a good place for this. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -32,15 +32,6 @@ import (\n\"gvisor.dev/gvisor/pkg/usermem\"\n)\n-// errorTargetName is used to mark targets as error targets. Error targets\n-// shou... | Go | Apache License 2.0 | google/gvisor | ip6tables: move target-specific code to targets.go
This is purely moving code, no changes. netfilter.go is cluttered and targets.go
is a good place for this.
#3549
PiperOrigin-RevId: 325879965 |
259,975 | 10.08.2020 14:51:07 | 25,200 | a88cf5a2e18869acb636f696700ecce2781be818 | Add benchmarks to continuous build. | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -57,6 +57,12 @@ build_test(\n\"//test/e2e:integration_test\",\n\"//test/image:image_test\",\n\"//test/root:root_test\",\n+ \"//test/benchmarks/base:base_test\",\n+ \"//test/benchmarks/database:database_test\",\n+ \"//te... | Go | Apache License 2.0 | google/gvisor | Add benchmarks to continuous build.
PiperOrigin-RevId: 325892974 |
259,907 | 10.08.2020 15:48:24 | 25,200 | a1af46c20ade5566ca8c2583f10c17765a5dc3ad | Enable VFS2 by default for all syscall tests.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -132,7 +132,7 @@ def syscall_test(\nadd_overlay = False,\nadd_uds_tree = False,\nadd_hostinet = False,\n- vfs2 = False,\n+ vfs2 = True,\nfuse = False,\ntags = None):\n\"\"\"syscall_test is ... | Go | Apache License 2.0 | google/gvisor | Enable VFS2 by default for all syscall tests.
Fixes #2923
PiperOrigin-RevId: 325904734 |
260,004 | 10.08.2020 16:20:39 | 25,200 | 0a8ae4b32f0dbc0b2a84c3f07c8c98e855a8f5fa | Populate IPPacketInfo with destination address
IPPacketInfo.DestinationAddr should hold the destination of the IP
packet, not the source. This change fixes that bug. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/BUILD",
"new_path": "pkg/tcpip/checker/BUILD",
"diff": "@@ -12,5 +12,6 @@ go_library(\n\"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/seqnum\",\n+ \"@com_github_google_go_cmp//cmp:go_default_library\",\n],\n)\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Populate IPPacketInfo with destination address
IPPacketInfo.DestinationAddr should hold the destination of the IP
packet, not the source. This change fixes that bug.
PiperOrigin-RevId: 325910766 |
259,983 | 10.08.2020 18:15:32 | 25,200 | 51e64d2fc590b0271d4e0cbbc75882cf81ada182 | Implement FUSE_GETATTR
FUSE_GETATTR is called when a stat(2), fstat(2), or lstat(2) is issued
from VFS2 layer to a FUSE filesystem.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -246,3 +246,58 @@ type FUSEInitOut struct {\n_ [8]uint32\n}\n+\n+// FUSEGetAttrIn is the request sent by the kernel to the daemon,\n+// to get the attribute of a inode.\n+//\n+// +marshal... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_GETATTR
FUSE_GETATTR is called when a stat(2), fstat(2), or lstat(2) is issued
from VFS2 layer to a FUSE filesystem.
Fixes #3175 |
259,891 | 10.08.2020 19:32:48 | 25,200 | 8e31f0dc57d44fb463441f6156fba5c240369dfe | Set the NetworkProtocolNumber of all PacketBuffers.
NetworkEndpoints set the number on outgoing packets in Write() and
NetworkProtocols set them on incoming packets in Parse().
Needed for | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -176,6 +176,7 @@ func (e *endpoint) writePacketFragments(r *stack.Route, gso *stack.GSO, mtu int,\nHeader: pkt.Header,\nData: newPayload,\nNetworkHeader: buffer.View(h),... | Go | Apache License 2.0 | google/gvisor | Set the NetworkProtocolNumber of all PacketBuffers.
NetworkEndpoints set the number on outgoing packets in Write() and
NetworkProtocols set them on incoming packets in Parse().
Needed for #3549.
PiperOrigin-RevId: 325938745 |
259,975 | 11.08.2020 10:35:46 | 25,200 | 89f3197fc368702cbe1842932d9cfbede250269f | Mark integration tests as passing in VFS2 except CheckpointRestore.
Mark all tests passing for VFS2 in:
image_test
integration_test
There's no way to do negative look ahead/behind in golang test regex,
so check if the tests uses VFS2 and skip CheckPointRestore if it does. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -166,15 +166,11 @@ do-tests: runsc\nsimple-tests: unit-tests # Compatibility target.\n.PHONY: simple-tests\n-# Keep these in sync with //scripts/docker_tests.sh.\n-IMAGE_FILTER := HelloWorld\\|Httpd\\|Ruby\\|Stdio... | Go | Apache License 2.0 | google/gvisor | Mark integration tests as passing in VFS2 except CheckpointRestore.
Mark all tests passing for VFS2 in:
image_test
integration_test
There's no way to do negative look ahead/behind in golang test regex,
so check if the tests uses VFS2 and skip CheckPointRestore if it does.
PiperOrigin-RevId: 326050915 |
259,858 | 11.08.2020 16:48:22 | 25,200 | c92242c89a47e75cc8a0aa40bcb2b105ce795b90 | Fix-up issue comment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/qdisc/fifo/endpoint.go",
"new_path": "pkg/tcpip/link/qdisc/fifo/endpoint.go",
"diff": "@@ -199,7 +199,7 @@ func (e *endpoint) WritePackets(_ *stack.Route, _ *stack.GSO, pkts stack.PacketB\n// WriteRawPacket implements stack.LinkEndpoint.WriteRaw... | Go | Apache License 2.0 | google/gvisor | Fix-up issue comment.
PiperOrigin-RevId: 326129258 |
259,992 | 12.08.2020 11:12:12 | 25,200 | 776c5f633edc993652bc8e95418729e0420c6324 | Fix race in vfs.FileDescription.statusFlag | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/file_description.go",
"new_path": "pkg/sentry/vfs/file_description.go",
"diff": "@@ -289,7 +289,7 @@ func (fd *FileDescription) SetStatusFlags(ctx context.Context, creds *auth.Crede\nif flags&linux.O_DIRECT != 0 && !fd.opts.AllowDirectIO {\nretu... | Go | Apache License 2.0 | google/gvisor | Fix race in vfs.FileDescription.statusFlag
PiperOrigin-RevId: 326270643 |
259,860 | 12.08.2020 13:03:14 | 25,200 | c5ed390162930b51719ff45956d7ac1bc963c8e7 | Release fd references on aio callback cancellation.
Discovered by reference leak checker on tmpfs.inode. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/aio.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/aio.go",
"diff": "@@ -144,6 +144,12 @@ func submitCallback(t *kernel.Task, id uint64, cb *linux.IOCallback, cbAddr user\nfunc getAIOCallback(t *kernel.Task, fd, eventFD *vfs.Fi... | Go | Apache License 2.0 | google/gvisor | Release fd references on aio callback cancellation.
Discovered by reference leak checker on tmpfs.inode.
PiperOrigin-RevId: 326294755 |
259,992 | 12.08.2020 13:12:05 | 25,200 | d797f2666629737920b39a2fbac369ce5853dc35 | Redirect TODO
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -552,7 +552,7 @@ func (f *fileDescription) Allocate(ctx context.Context, mode, offset, length uin\nreturn syserror.ESPIPE\n}\n- // TODO(gvisor.dev/issue/2923): Implement... | Go | Apache License 2.0 | google/gvisor | Redirect TODO
Fixes #2923
PiperOrigin-RevId: 326296589 |
259,891 | 12.08.2020 15:43:38 | 25,200 | d50f2e2c7639084bbccac35fcc5f55e3f83f646a | ip6tables: ABI structs and constants
Part of | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -41,6 +41,7 @@ go_library(\n\"mm.go\",\n\"netdevice.go\",\n\"netfilter.go\",\n+ \"netfilter_ipv6.go\",\n\"netlink.go\",\n\"netlink_route.go\",\n\"poll.go\",\n"
},
{
"change_type": "MO... | Go | Apache License 2.0 | google/gvisor | ip6tables: ABI structs and constants
Part of #3549.
PiperOrigin-RevId: 326329028 |
259,907 | 12.08.2020 17:17:17 | 25,200 | 42b610d56750b4bb8e3d69b680e4fb538f8fb554 | [vfs2][gofer] Return appropriate errors when opening and creating files.
Fixes php test ext/standard/tests/file/touch_variation5.phpt on vfs2.
Updates
Also spotted a bug with O_EXCL, where we did not return EEXIST when we tried
to open the root of the filesystem with O_EXCL | O_CREAT.
Added some more tests for open() corner cases. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -844,6 +844,13 @@ func (fs *filesystem) OpenAt(ctx context.Context, rp *vfs.ResolvingPath, opts vf\n}\n}\nif rp.Done() {\n+ // Reject attempts to open moun... | Go | Apache License 2.0 | google/gvisor | [vfs2][gofer] Return appropriate errors when opening and creating files.
Fixes php test ext/standard/tests/file/touch_variation5.phpt on vfs2.
Updates #3516
Also spotted a bug with O_EXCL, where we did not return EEXIST when we tried
to open the root of the filesystem with O_EXCL | O_CREAT.
Added some more tests for open() corner cases.
PiperOrigin-RevId: 326346863 |
259,860 | 12.08.2020 18:09:34 | 25,200 | 36134667b289a3e96e90abf9e18e1c2137069d6b | Add reference leak checking to vfs2 tmpfs.inode.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs_vfs2/refs_template.go",
"new_path": "pkg/refs_vfs2/refs_template.go",
"diff": "@@ -59,7 +59,7 @@ func (r *Refs) finalize() {\nnote = \"(Leak checker uninitialized): \"\n}\nif n := r.ReadRefs(); n != 0 {\n- log.Warningf(\"%sAtomicRefCount %p owned by %... | Go | Apache License 2.0 | google/gvisor | Add reference leak checking to vfs2 tmpfs.inode.
Updates #1486.
PiperOrigin-RevId: 326354750 |
259,907 | 13.08.2020 16:56:39 | 25,200 | 5036f135e4370c84dd4afe1c43c14275b170c364 | Disable vfs2 for socket_stress_test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -69,6 +69,7 @@ syscall_test(\n# involve much concurrency, TSAN's usefulness here is limited anyway.\ntags = [\"nogotsan\"],\ntest = \"//test/syscalls/linux:socket_stress_test\",\n+ vfs2 = Fal... | Go | Apache License 2.0 | google/gvisor | Disable vfs2 for socket_stress_test.
PiperOrigin-RevId: 326553620 |
260,024 | 14.08.2020 02:05:23 | 25,200 | 190634e0fcf4cf25a449e1bd39533ca2ddad66e6 | Give the ICMP Code its own type
This is a preparatory commit for a larger commit working on
ICMP generation in error cases.
This is removal of technical debt and cleanup in the gvisor code
as part of gvisor issue 2211.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/checker.go",
"new_path": "pkg/tcpip/checker/checker.go",
"diff": "@@ -699,7 +699,7 @@ func ICMPv4Type(want header.ICMPv4Type) TransportChecker {\n}\n// ICMPv4Code creates a checker that checks the ICMPv4 Code field.\n-func ICMPv4Code(want byt... | Go | Apache License 2.0 | google/gvisor | Give the ICMP Code its own type
This is a preparatory commit for a larger commit working on
ICMP generation in error cases.
This is removal of technical debt and cleanup in the gvisor code
as part of gvisor issue 2211.
Updates #2211.
PiperOrigin-RevId: 326615389 |
259,975 | 14.08.2020 10:51:12 | 25,200 | e6ea59203ba6e9c0431999463795a2c14036053f | Skip UDPMulticast Tests when net interfaces aren't found. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ipv4_udp_unbound_external_networking.cc",
"new_path": "test/syscalls/linux/socket_ipv4_udp_unbound_external_networking.cc",
"diff": "@@ -42,7 +42,9 @@ TestAddress V4EmptyAddress() {\n}\nvoid IPv4UDPUnboundExternalNetworkingSocketTest... | Go | Apache License 2.0 | google/gvisor | Skip UDPMulticast Tests when net interfaces aren't found.
PiperOrigin-RevId: 326686761 |
259,896 | 14.08.2020 14:47:19 | 25,200 | af433e159dbf07b084c0f05e65ec646c056033a7 | Update README for packetimpact | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/README.md",
"new_path": "test/packetimpact/README.md",
"diff": "@@ -30,7 +30,7 @@ $ make load-packetimpact\nRun a test, e.g. `fin_wait2_timeout`, against Linux:\n```bash\n-$ bazel test //test/packetimpact/tests:fin_wait2_timeout_linux_test\n+... | Go | Apache License 2.0 | google/gvisor | Update README for packetimpact
PiperOrigin-RevId: 326733912 |
259,884 | 14.08.2020 16:21:29 | 25,200 | 3f523b3bbcf5ef7f37bb247bd4c5727711c70ba9 | Handle URLs better in issue reviver
Handle urls ending in /
Add some url parsing tests | [
{
"change_type": "MODIFY",
"old_path": "tools/issue_reviver/github/BUILD",
"new_path": "tools/issue_reviver/github/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\npackage(licenses = [\"notice\"])\n@@ -15,3 +15,10 @@ go_library(\... | Go | Apache License 2.0 | google/gvisor | Handle URLs better in issue reviver
- Handle urls ending in /
- Add some url parsing tests
PiperOrigin-RevId: 326750183 |
260,004 | 15.08.2020 00:04:30 | 25,200 | 9a7b5830aa063895f67ca0fdf653a46906374613 | Don't support address ranges
Previously the netstack supported assignment of a range of addresses.
This feature is not used so remove it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -56,7 +56,6 @@ type NIC struct {\npromiscuous bool\nprimary map[tcpip.NetworkProtocolNumber][]*referencedNetworkEndpoint\nendpoints map[NetworkEndpointID]*referencedNetworkEndpoint\n- a... | Go | Apache License 2.0 | google/gvisor | Don't support address ranges
Previously the netstack supported assignment of a range of addresses.
This feature is not used so remove it.
PiperOrigin-RevId: 326791119 |
259,907 | 17.08.2020 10:03:38 | 25,200 | 97263e505324b7d1c58a3daaac7175241921998f | [vfs] Return EIO when opening /dev/tty.
This is in compliance with VFS1. See pkg/sentry/fs/dev/tty.go in the struct
ttyInodeOperations.
Fixes the failure of python runtime test_ioctl.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/devices/ttydev/BUILD",
"new_path": "pkg/sentry/devices/ttydev/BUILD",
"diff": "@@ -11,6 +11,6 @@ go_library(\n\"//pkg/context\",\n\"//pkg/sentry/fsimpl/devtmpfs\",\n\"//pkg/sentry/vfs\",\n- \"//pkg/usermem\",\n+ \"//pkg/syserror\",\n],\n)\n"
},
... | Go | Apache License 2.0 | google/gvisor | [vfs] Return EIO when opening /dev/tty.
This is in compliance with VFS1. See pkg/sentry/fs/dev/tty.go in the struct
ttyInodeOperations.
Fixes the failure of python runtime test_ioctl.
Updates #3515
PiperOrigin-RevId: 327042758 |
259,951 | 17.08.2020 10:04:03 | 25,200 | 58154194b3e472cf476be6bf0530bf271d1d29f8 | Add a unit test for out of order IP reassembly | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"diff": "@@ -627,6 +627,28 @@ func TestReceiveFragments(t *testing.T) {\n},\nexpectedPayloads: [][]byte{udpPayload1Addr1ToAddr2},\n},\n+ {\n+ name: \"Two fragments out of ... | Go | Apache License 2.0 | google/gvisor | Add a unit test for out of order IP reassembly
PiperOrigin-RevId: 327042869 |
259,860 | 17.08.2020 11:40:08 | 25,200 | 3bd066d5032c297e501f5c71be301ffa2fe9ed34 | Remove weak references from unix sockets.
The abstract socket namespace no longer holds any references on sockets.
Instead, TryIncRef() is used when a socket is being retrieved in
BoundEndpoint(). Abstract sockets are now responsible for removing themselves
from the namespace they are in, when they are destroyed.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs_vfs2/BUILD",
"new_path": "pkg/refs_vfs2/BUILD",
"diff": "@@ -19,10 +19,8 @@ go_template(\n)\ngo_library(\n- name = \"refs\",\n- srcs = [\n- \"refs.go\",\n- ],\n+ name = \"refs_vfs2\",\n+ srcs = [\"refs.go\"],\nvisibility = [\"//pkg/sentry:internal\"],... | Go | Apache License 2.0 | google/gvisor | Remove weak references from unix sockets.
The abstract socket namespace no longer holds any references on sockets.
Instead, TryIncRef() is used when a socket is being retrieved in
BoundEndpoint(). Abstract sockets are now responsible for removing themselves
from the namespace they are in, when they are destroyed.
Updates #1486.
PiperOrigin-RevId: 327064173 |
260,004 | 17.08.2020 12:27:59 | 25,200 | e3c4bbd10a93ac824af3204c520437f3d5ff470c | Remove address range functions
Should have been removed in cl/326791119 | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -19,7 +19,6 @@ import (\n\"math/rand\"\n\"reflect\"\n\"sort\"\n- \"strings\"\n\"sync/atomic\"\n\"gvisor.dev/gvisor/pkg/sync\"\n@@ -962,23 +961,6 @@ func (n *NIC) primaryAddress(proto tc... | Go | Apache License 2.0 | google/gvisor | Remove address range functions
Should have been removed in cl/326791119
https://github.com/google/gvisor/commit/9a7b5830aa063895f67ca0fdf653a46906374613
PiperOrigin-RevId: 327074156 |
259,975 | 17.08.2020 14:01:38 | 25,200 | 988ab27058829fd2ccb550560a7651511d7b872a | Fix AllSocketPairTest for open source.
Setting timeouts for sockets on GCP images (debian) for usecs only
respects multiples of 4K. Set the test with a multiple of 4K with a comment. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_generic.cc",
"new_path": "test/syscalls/linux/socket_generic.cc",
"diff": "@@ -462,6 +462,7 @@ TEST_P(AllSocketPairTest, SendTimeoutDefault) {\nTEST_P(AllSocketPairTest, SetGetSendTimeout) {\nauto sockets = ASSERT_NO_ERRNO_AND_VALUE(... | Go | Apache License 2.0 | google/gvisor | Fix AllSocketPairTest for open source.
Setting timeouts for sockets on GCP images (debian) for usecs only
respects multiples of 4K. Set the test with a multiple of 4K with a comment.
PiperOrigin-RevId: 327093848 |
259,975 | 18.08.2020 09:52:53 | 25,200 | da5c2ea6dc4ea01c667bff88aa37f5efb39b704a | Fix return value for MMap Tests in OpenSource
Some systems return 128 + errno instead of just errno, which is the case
here. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mmap.cc",
"new_path": "test/syscalls/linux/mmap.cc",
"diff": "#include \"test/util/temp_path.h\"\n#include \"test/util/test_util.h\"\n+using ::testing::AnyOf;\n+using ::testing::Eq;\nusing ::testing::Gt;\nnamespace gvisor {\n@@ -296,7 +298,... | Go | Apache License 2.0 | google/gvisor | Fix return value for MMap Tests in OpenSource
Some systems return 128 + errno instead of just errno, which is the case
here.
PiperOrigin-RevId: 327247836 |
259,975 | 18.08.2020 09:53:47 | 25,200 | 673b6cc7fc4a99c8fb20f7becb91288ce98ae593 | Fix readahead test for opensource.
Skip InvalidOffset and InvalidLength for Linux as the test is invalid for
later Kernel versions.
Add UnsupportedFile test as this check is in all kernel versions. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1862,6 +1862,7 @@ cc_binary(\nsrcs = [\"readahead.cc\"],\nlinkstatic = 1,\ndeps = [\n+ \":socket_test_util\",\n\"//test/util:file_descriptor\",\ngtest,\n\"//test/util:temp_path\"... | Go | Apache License 2.0 | google/gvisor | Fix readahead test for opensource.
Skip InvalidOffset and InvalidLength for Linux as the test is invalid for
later Kernel versions.
Add UnsupportedFile test as this check is in all kernel versions.
PiperOrigin-RevId: 327248035 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.