author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,907 | 18.08.2020 10:20:17 | 25,200 | b9d87ae7af7b86e5480ef66d2a4d674646922ed7 | [vfs2] Implement /proc/sys/net/ipv4/tcp_rmem and /proc/sys/net/ipv4/tcp_wmem.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/BUILD",
"new_path": "pkg/sentry/fsimpl/proc/BUILD",
"diff": "@@ -36,6 +36,7 @@ go_library(\n\"//pkg/sentry/socket/unix/transport\",\n\"//pkg/sentry/usage\",\n\"//pkg/sentry/vfs\",\n+ \"//pkg/sync\",\n\"//pkg/syserror\",\n\"//pkg/tcpip/he... | Go | Apache License 2.0 | google/gvisor | [vfs2] Implement /proc/sys/net/ipv4/tcp_rmem and /proc/sys/net/ipv4/tcp_wmem.
Updates #1035
PiperOrigin-RevId: 327253907 |
259,885 | 18.08.2020 12:30:10 | 25,200 | b3141b680ffc0e4ad87b3cba5ca28e3e8d5b1db1 | Wait for all p9 handlers to complete before server shutdown.
... including those invoked via flipcall. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/server.go",
"new_path": "pkg/p9/server.go",
"diff": "@@ -87,6 +87,9 @@ type connState struct {\n// version 0 implies 9P2000.L.\nversion uint32\n+ // pendingWg counts requests that are still being handled.\n+ pendingWg sync.WaitGroup\n+\n// -- below rela... | Go | Apache License 2.0 | google/gvisor | Wait for all p9 handlers to complete before server shutdown.
... including those invoked via flipcall.
PiperOrigin-RevId: 327283194 |
259,975 | 18.08.2020 12:55:06 | 25,200 | 4141dc0d2c8c46b14dbae83aab304fa338ebafc5 | Fix timeval for Socket test
tv_usec field should be a multiple of 4K to pass
in open source on linux/native, so make it one. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_generic.cc",
"new_path": "test/syscalls/linux/socket_generic.cc",
"diff": "@@ -463,7 +463,7 @@ TEST_P(AllSocketPairTest, SetGetSendTimeout) {\nauto sockets = ASSERT_NO_ERRNO_AND_VALUE(NewSocketPair());\n// tv_usec should be a multipl... | Go | Apache License 2.0 | google/gvisor | Fix timeval for Socket test
tv_usec field should be a multiple of 4K to pass
in open source on linux/native, so make it one.
PiperOrigin-RevId: 327288405 |
259,992 | 18.08.2020 13:57:03 | 25,200 | 760c131da17250b6adbb8d08dd52e9a3d652b2c1 | Return EROFS if mount is read-only | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -46,6 +46,8 @@ const (\ninvalidMode = p9.OpenFlags(math.MaxUint32)\nopenFlags = syscall.O_NOFOLLOW | syscall.O_CLOEXEC\n+\n+ allowedOpenFlags = unix.O_TRUNC\n)\n// Config sets confi... | Go | Apache License 2.0 | google/gvisor | Return EROFS if mount is read-only
PiperOrigin-RevId: 327300635 |
259,885 | 18.08.2020 14:34:15 | 25,200 | 6405525b046bb82a39e3338e61e41690133c43c1 | Avoid holding locks when opening files in VFS2.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -834,7 +834,14 @@ func (fs *filesystem) OpenAt(ctx context.Context, rp *vfs.ResolvingPath, opts vf\nvar ds *[]*dentry\nfs.renameMu.RLock()\n- defer fs.rena... | Go | Apache License 2.0 | google/gvisor | Avoid holding locks when opening files in VFS2.
Fixes #3243, #3521
PiperOrigin-RevId: 327308890 |
259,896 | 18.08.2020 15:57:48 | 25,200 | 4184a7d5f189cfac4a7c9d7a1f0197d074e74e9b | RACK: Create a new list for segments.
RACK requires the segments to be in the order of their transmission
or retransmission times. This cl creates a new list and moves the
retransmitted segments to the end of the list. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/BUILD",
"new_path": "pkg/tcpip/transport/tcp/BUILD",
"diff": "@@ -11,7 +11,8 @@ go_template_instance(\ntemplate = \"//pkg/ilist:generic_list\",\ntypes = {\n\"Element\": \"*segment\",\n- \"Linker\": \"*segment\",\n+ \"ElementMapper\": \"... | Go | Apache License 2.0 | google/gvisor | RACK: Create a new list for segments.
RACK requires the segments to be in the order of their transmission
or retransmission times. This cl creates a new list and moves the
retransmitted segments to the end of the list.
PiperOrigin-RevId: 327325153 |
259,975 | 18.08.2020 16:02:52 | 25,200 | f6d24904829d71574821cce5515c5777e0837aff | Fix return value in shm_test for opensource
Some machines return 128 + signal for failures. Accept that
as a valid result. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/shm.cc",
"new_path": "test/syscalls/linux/shm.cc",
"diff": "@@ -29,6 +29,8 @@ namespace testing {\nnamespace {\nusing ::testing::_;\n+using ::testing::AnyOf;\n+using ::testing::Eq;\nconst uint64_t kAllocSize = kPageSize * 128ULL;\n@@ -394,7... | Go | Apache License 2.0 | google/gvisor | Fix return value in shm_test for opensource
Some machines return 128 + signal for failures. Accept that
as a valid result.
PiperOrigin-RevId: 327326113 |
259,992 | 18.08.2020 18:50:24 | 25,200 | afe7303c3cdcf04c9e4491004b3ef2d229bafc74 | Add more information to panic when device ID don't match | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/device/device.go",
"new_path": "pkg/sentry/device/device.go",
"diff": "@@ -256,7 +256,7 @@ func (m *MultiDevice) Load(key MultiDeviceKey, value uint64) bool {\n}\nif k, exists := m.rcache[value]; exists && k != key {\n// Should never happen.\n- pani... | Go | Apache License 2.0 | google/gvisor | Add more information to panic when device ID don't match
PiperOrigin-RevId: 327351357 |
259,992 | 18.08.2020 18:51:19 | 25,200 | 9da77d00fa682ff504c7ff549985f78b0574c79b | Don't set atime if mount is readonly
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/time.go",
"new_path": "pkg/sentry/fsimpl/gofer/time.go",
"diff": "@@ -38,7 +38,7 @@ func statxTimestampFromDentry(ns int64) linux.StatxTimestamp {\n// Preconditions: d.cachedMetadataAuthoritative() == true.\nfunc (d *dentry) touchAtime(... | Go | Apache License 2.0 | google/gvisor | Don't set atime if mount is readonly
Updates #1035
PiperOrigin-RevId: 327351475 |
259,860 | 18.08.2020 21:52:08 | 25,200 | e5f05d9bf4cfad75c295abfe2f994688a8863102 | Get rid of kernfs.Inode.Destroy.
This interface method is unneeded. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -432,17 +432,14 @@ func (i *inode) SetStat(ctx context.Context, fs *vfs.Filesystem, creds *auth.Cre\n// DecRef implements kernfs.Inode.\nfunc (i *inode) DecRef(ctx conte... | Go | Apache License 2.0 | google/gvisor | Get rid of kernfs.Inode.Destroy.
This interface method is unneeded.
PiperOrigin-RevId: 327370325 |
259,907 | 18.08.2020 21:55:16 | 25,200 | 35dc7fe7e78faab35b55eaa6f82360cc8b23f3b3 | [vfs] Allow offsets for special files other than regular files.
Some character and block devices can be seekable. So allow their FD to maintain
file offset. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"diff": "@@ -39,8 +39,14 @@ type specialFileFD struct {\n// handle is used for file I/O. handle is immutable.\nhandle handle\n+ // isRegularFile is true if this FD... | Go | Apache License 2.0 | google/gvisor | [vfs] Allow offsets for special files other than regular files.
Some character and block devices can be seekable. So allow their FD to maintain
file offset.
PiperOrigin-RevId: 327370684 |
259,860 | 19.08.2020 08:50:59 | 25,200 | 33c60b893fe8a0f039c781091bf96cbcd47ecc2d | Return appropriate errors when file locking is unsuccessful.
test_eintr now passes in the Python runtime tests.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/lock.go",
"new_path": "pkg/sentry/vfs/lock.go",
"diff": "@@ -46,8 +46,14 @@ func (fl *FileLocks) LockBSD(uid fslock.UniqueID, t fslock.LockType, block fsloc\nif fl.bsd.LockRegion(uid, t, fslock.LockRange{0, fslock.LockEOF}, block) {\nreturn nil\... | Go | Apache License 2.0 | google/gvisor | Return appropriate errors when file locking is unsuccessful.
test_eintr now passes in the Python runtime tests.
Updates #3515.
PiperOrigin-RevId: 327441081 |
259,975 | 19.08.2020 09:48:55 | 25,200 | 33317222917d805edd71f0d2ddd7a208bd57fc4c | Skip ECN test for native/linux tests.
Skip check for ECN bits in native/linux tests. General advice
for the ECN field is to leave the setting to the kernel, so
behavior of the test is undefined for different kernels. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_unbound.cc",
"new_path": "test/syscalls/linux/socket_ip_unbound.cc",
"diff": "@@ -217,6 +217,8 @@ TEST_P(IPUnboundSocketTest, InvalidLargeTOS) {\n}\nTEST_P(IPUnboundSocketTest, CheckSkipECN) {\n+ // Test is inconsistant on differe... | Go | Apache License 2.0 | google/gvisor | Skip ECN test for native/linux tests.
Skip check for ECN bits in native/linux tests. General advice
for the ECN field is to leave the setting to the kernel, so
behavior of the test is undefined for different kernels.
http://www.masterraghu.com/subjects/np/introduction/unix_network_programming_v1.3/ch07lev1sec6.html
PiperOrigin-RevId: 327451414 |
259,992 | 19.08.2020 11:43:24 | 25,200 | 41777e90ea6a48eadbfdedc71029a634e1a23b5f | Change runtimeoptions proto handling.
Stolen from cl/327337408 (ascannell is OOO) | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/v2/runtimeoptions/BUILD",
"new_path": "pkg/shim/v2/runtimeoptions/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\", \"proto_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\", \"proto_library\")\npackage(licenses = [\"notic... | Go | Apache License 2.0 | google/gvisor | Change runtimeoptions proto handling.
Stolen from cl/327337408 (ascannell is OOO)
PiperOrigin-RevId: 327475423 |
259,891 | 19.08.2020 11:55:21 | 25,200 | 5cf330106a0169856e87abe9fec9cfa8c0b3fc1a | ip6tables: test initial state
Tests that we have the correct initial (empty) state for ip6tables. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -250,6 +250,10 @@ syscall_test(\ntest = \"//test/syscalls/linux:iptables_test\",\n)\n+syscall_test(\n+ test = \"//test/syscalls/linux:ip6tables_test\",\n+)\n+\nsyscall_test(\nsize = \"large\"... | Go | Apache License 2.0 | google/gvisor | ip6tables: test initial state
Tests that we have the correct initial (empty) state for ip6tables.
#3549
PiperOrigin-RevId: 327477657 |
259,891 | 19.08.2020 13:45:20 | 25,200 | 182f66ee5e6dc0206531a31f4d0d66cbb58e8a76 | ip6tables: move ipv4-specific logic into its own file
A later change will introduce the equivalent IPv6 logic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/BUILD",
"new_path": "pkg/sentry/socket/netfilter/BUILD",
"diff": "@@ -6,6 +6,7 @@ go_library(\nname = \"netfilter\",\nsrcs = [\n\"extensions.go\",\n+ \"ipv4.go\",\n\"netfilter.go\",\n\"owner_matcher.go\",\n\"targets.go\",\n"
},
... | Go | Apache License 2.0 | google/gvisor | ip6tables: move ipv4-specific logic into its own file
A later change will introduce the equivalent IPv6 logic.
#3549
PiperOrigin-RevId: 327499064 |
259,975 | 19.08.2020 14:44:42 | 25,200 | f8a9483002a31eb96f99c93a77293ade35a8da5a | Fix return for rseq_test.
Accept 128 + SIGNAL as well as SIGNAL as valid
returns for fork/exec tests.
Also, make changes so that test compiles in opensource. Test
had compile errors on latest Ubuntu 16.04 image with updated bazel to
3.4.0 (as well as base 2.0) used for Kokoro tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1972,6 +1972,7 @@ cc_binary(\ngtest,\n\"//test/util:logging\",\n\"//test/util:multiprocess_util\",\n+ \"//test/util:posix_error\",\n\"//test/util:test_main\",\n\"//test/util:test... | Go | Apache License 2.0 | google/gvisor | Fix return for rseq_test.
Accept 128 + SIGNAL as well as SIGNAL as valid
returns for fork/exec tests.
Also, make changes so that test compiles in opensource. Test
had compile errors on latest Ubuntu 16.04 image with updated bazel to
3.4.0 (as well as base 2.0) used for Kokoro tests.
PiperOrigin-RevId: 327510310 |
259,992 | 19.08.2020 17:03:21 | 25,200 | 25babd63519151eb6e70d847d8fd0172c1d7090f | Run bazel build before deleting cached gopath files
bazel creates sysmlink to the cache on the first invokation.
On a new clone, there are no symlink, thus `rm -rf bazel-bin/gopath`
has no effect. Call `bazel build something` first, then delete
cached gopath. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -49,7 +49,12 @@ jobs:\nkey: ${{ runner.os }}-bazel-${{ hashFiles('WORKSPACE') }}\nrestore-keys: |\n${{ runner.os }}-bazel-\n+ # Create gopath to merge the changes. The first executi... | Go | Apache License 2.0 | google/gvisor | Run bazel build before deleting cached gopath files
bazel creates sysmlink to the cache on the first invokation.
On a new clone, there are no symlink, thus `rm -rf bazel-bin/gopath`
has no effect. Call `bazel build something` first, then delete
cached gopath.
PiperOrigin-RevId: 327536044 |
259,962 | 20.08.2020 11:05:37 | 25,200 | 710adf23cd151558af718e1a8a02f2abe1059d82 | Use a explicit random src for RandomID. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/testutil/testutil.go",
"new_path": "pkg/test/testutil/testutil.go",
"diff": "@@ -243,12 +243,15 @@ func writeSpec(dir string, spec *specs.Spec) error {\nreturn ioutil.WriteFile(filepath.Join(dir, \"config.json\"), b, 0755)\n}\n+// idRandomSrc is a pse... | Go | Apache License 2.0 | google/gvisor | Use a explicit random src for RandomID.
PiperOrigin-RevId: 327659759 |
259,962 | 20.08.2020 13:23:21 | 25,200 | f12b545d8fc484f0bb48f280d161acb348263372 | Skip listening TCP ports when trying to bind a free port. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -803,7 +803,20 @@ func (s *socketOpsCommon) Bind(t *kernel.Task, sockaddr []byte) *syserr.Error {\n}\n// Issue the bind request to the endpoint.\n- retur... | Go | Apache License 2.0 | google/gvisor | Skip listening TCP ports when trying to bind a free port.
PiperOrigin-RevId: 327686558 |
259,860 | 20.08.2020 14:10:46 | 25,200 | 3163aff866852e730777be4ef689b0405c6332cd | Add reference count checking to the fsimpl/host package.
Includes a minor refactor for inode construction.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/BUILD",
"new_path": "pkg/sentry/fsimpl/host/BUILD",
"diff": "load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\nlicenses([\"notice\"])\n+go_template_instance(\n+ name = \"inode_... | Go | Apache License 2.0 | google/gvisor | Add reference count checking to the fsimpl/host package.
Includes a minor refactor for inode construction.
Updates #1486.
PiperOrigin-RevId: 327694933 |
260,003 | 20.08.2020 15:38:06 | 25,200 | df4822709992c971af0f9b339d915f6e629c0225 | stateify: Fix afterLoad not being called for root object | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/decode.go",
"new_path": "pkg/state/decode.go",
"diff": "@@ -584,10 +584,12 @@ func (ds *decodeState) Load(obj reflect.Value) {\n})\n// Create the root object.\n- ds.objectsByID = append(ds.objectsByID, &objectDecodeState{\n+ rootOds := &objectDecodeS... | Go | Apache License 2.0 | google/gvisor | stateify: Fix afterLoad not being called for root object
PiperOrigin-RevId: 327711264 |
259,992 | 20.08.2020 16:16:46 | 25,200 | e8a25a283447443ee895d41ae7ae95e96fe62140 | Enable strace+debug in syscall tests
This is done to ease troubleshooting when tests fail. runsc
logs are not stored when tests passe, so this will only
affect failing tests and should not increase log storage
too badly. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -3,33 +3,40 @@ load(\"//test/runner:defs.bzl\", \"syscall_test\")\npackage(licenses = [\"notice\"])\nsyscall_test(\n+ debug = False,\ntest = \"//test/perf/linux:clock_getres_benchmark\",\n)\nsyscall_... | Go | Apache License 2.0 | google/gvisor | Enable strace+debug in syscall tests
This is done to ease troubleshooting when tests fail. runsc
logs are not stored when tests passe, so this will only
affect failing tests and should not increase log storage
too badly.
PiperOrigin-RevId: 327717551 |
259,907 | 20.08.2020 16:25:57 | 25,200 | 73c69cb4d8e7f47ce9205844e5f6e369ff4dfa53 | [vfs] Create recursive dir creation util.
Refactored the recursive dir creation util in runsc/boot/vfs.go to be more
flexible. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/vfs.go",
"new_path": "pkg/sentry/vfs/vfs.go",
"diff": "@@ -36,6 +36,7 @@ package vfs\nimport (\n\"fmt\"\n+ \"path\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n@@ -782,6 +783,38 @@ func (vfs *VirtualFilesystem) SyncA... | Go | Apache License 2.0 | google/gvisor | [vfs] Create recursive dir creation util.
Refactored the recursive dir creation util in runsc/boot/vfs.go to be more
flexible.
PiperOrigin-RevId: 327719100 |
259,975 | 21.08.2020 11:37:12 | 25,200 | c24db90be5cb4d81e71e7923fe85740721ec9d1e | Skip ElfInterpreterStaticTest for 5.X kernels.
gVisor emulates 4.6 kernel versions, and test doesn't work on 5.0 versions
(observed on our Ubuntu18.04 image). Skip it. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/exec_binary.cc",
"new_path": "test/syscalls/linux/exec_binary.cc",
"diff": "@@ -1042,6 +1042,13 @@ class ElfInterpreterStaticTest\n// Statically linked ELF with a statically linked ELF interpreter.\nTEST_P(ElfInterpreterStaticTest, Test) {\... | Go | Apache License 2.0 | google/gvisor | Skip ElfInterpreterStaticTest for 5.X kernels.
gVisor emulates 4.6 kernel versions, and test doesn't work on 5.0 versions
(observed on our Ubuntu18.04 image). Skip it.
PiperOrigin-RevId: 327845037 |
259,975 | 21.08.2020 14:19:29 | 25,200 | c9e752b6440cfa78f7bdcd47af4c4f5fe33d57b4 | Fix Inotify tests in open source.
The order of unlink events (dir event/file event) is undefined,
so make tests accept both orderings. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/inotify.cc",
"new_path": "test/syscalls/linux/inotify.cc",
"diff": "@@ -1371,8 +1371,9 @@ TEST(Inotify, HardlinksReuseSameWatch) {\n// that now and drain the resulting events.\nfile1_fd.reset();\nevents = ASSERT_NO_ERRNO_AND_VALUE(DrainEven... | Go | Apache License 2.0 | google/gvisor | Fix Inotify tests in open source.
The order of unlink events (dir event/file event) is undefined,
so make tests accept both orderings.
PiperOrigin-RevId: 327873316 |
260,003 | 21.08.2020 16:33:04 | 25,200 | bd3383a7e25b426fc6aa5a28fc8ffa6fe7fa333e | Move udp port exhaustion tests to a 'nogotsan' one.
It frequently times out under GoTSAN. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -667,6 +667,13 @@ syscall_test(\ntest = \"//test/syscalls/linux:socket_ipv4_udp_unbound_loopback_test\",\n)\n+syscall_test(\n+ size = \"medium\",\n+ # Takes too long under gotsan to run.\n+ t... | Go | Apache License 2.0 | google/gvisor | Move udp port exhaustion tests to a 'nogotsan' one.
It frequently times out under GoTSAN.
PiperOrigin-RevId: 327894343 |
260,003 | 21.08.2020 17:32:19 | 25,200 | 9607515aed13406a8550e8072cdaf53d4f1e437b | stateify: Fix pretty print not printing odd numbered fields. | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/pretty/pretty.go",
"new_path": "pkg/state/pretty/pretty.go",
"diff": "@@ -148,7 +148,6 @@ func format(graph uint64, depth int, encoded wire.Object, html bool) (string, bo\nelement, ok := format(graph, depth+1, *x.Field(i), html)\nallZero = allZero &&... | Go | Apache License 2.0 | google/gvisor | stateify: Fix pretty print not printing odd numbered fields.
PiperOrigin-RevId: 327902182 |
259,907 | 21.08.2020 20:04:31 | 25,200 | 17bc5c1b00ce0bb9944507b40b4bb6968bcdbe75 | [vfs] Allow mountpoint to be an existing non-directory.
Unlike linux mount(2), OCI spec allows mounting on top of an existing
non-directory file. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -18,12 +18,14 @@ import (\n\"bytes\"\n\"fmt\"\n\"math\"\n+ \"path\"\n\"sort\"\n\"strings\"\n\"sync/atomic\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n+ ... | Go | Apache License 2.0 | google/gvisor | [vfs] Allow mountpoint to be an existing non-directory.
Unlike linux mount(2), OCI spec allows mounting on top of an existing
non-directory file.
PiperOrigin-RevId: 327914342 |
260,023 | 21.08.2020 22:47:06 | 25,200 | 69008b68b0a70d8ae4f6c2fafcd9e60307f16bf9 | Add syscall tests for SO_REUSEADDR.
Add tests for socket re-bind/listen of client and server sockets
with the older connection still in TIME_WAIT state and with
SO_REUSEADDR enabled. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -861,36 +861,38 @@ TEST_P(SocketInetLoopbackTest, TCPResetAfterClose) {\nSyscallSucceedsWithValue(0));\n}\n-// This test is disabled under rand... | Go | Apache License 2.0 | google/gvisor | Add syscall tests for SO_REUSEADDR.
Add tests for socket re-bind/listen of client and server sockets
with the older connection still in TIME_WAIT state and with
SO_REUSEADDR enabled.
PiperOrigin-RevId: 327924702 |
259,860 | 24.08.2020 11:28:28 | 25,200 | bae25d2a087d4c493b3335803dbfe53ab5505267 | Update inotify documentation for gofer filesystem.
We now allow hard links to be created within gofer fs (see
github.com/google/gvisor/commit/f20e63e31b56784c596897e86f03441f9d05f567).
Update the inotify documentation accordingly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -703,6 +703,13 @@ type dentry struct {\nlocks vfs.FileLocks\n// Inotify watches for this dentry.\n+ //\n+ // Note that inotify may behave unexpectedly in the presenc... | Go | Apache License 2.0 | google/gvisor | Update inotify documentation for gofer filesystem.
We now allow hard links to be created within gofer fs (see
github.com/google/gvisor/commit/f20e63e31b56784c596897e86f03441f9d05f567).
Update the inotify documentation accordingly.
PiperOrigin-RevId: 328177485 |
259,881 | 24.08.2020 12:56:58 | 25,200 | ab6c474210cca380e8e6504bb2368b077f50ceae | Bump build constraints to 1.17
This enables pre-release testing with 1.16. The intention is to replace these
with a nogo check before the next release. | [
{
"change_type": "MODIFY",
"old_path": "pkg/procid/procid_amd64.s",
"new_path": "pkg/procid/procid_amd64.s",
"diff": "// +build amd64\n// +build go1.8\n-// +build !go1.16\n+// +build !go1.17\n#include \"textflag.h\"\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/procid/procid_arm64.s"... | Go | Apache License 2.0 | google/gvisor | Bump build constraints to 1.17
This enables pre-release testing with 1.16. The intention is to replace these
with a nogo check before the next release.
PiperOrigin-RevId: 328193911 |
259,975 | 24.08.2020 13:50:56 | 25,200 | 2b0b5e25210ea61c85610404d0eb7dc9383fcd14 | Remove go profiling flag from dockerutil.
Go profiling was removed from runsc debug in a previous change. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/dockerutil.go",
"new_path": "pkg/test/dockerutil/dockerutil.go",
"diff": "@@ -60,7 +60,6 @@ var (\n// enabled for each run.\npprofBlock = flag.Bool(\"pprof-block\", false, \"enables block profiling with runsc debug\")\npprofCPU = flag.Bool(... | Go | Apache License 2.0 | google/gvisor | Remove go profiling flag from dockerutil.
Go profiling was removed from runsc debug in a previous change.
PiperOrigin-RevId: 328203826 |
259,885 | 24.08.2020 20:04:12 | 25,200 | 4ad858a586fc560608d181b72ec78db0894bce48 | Flush in fsimpl/gofer.regularFileFD.OnClose() if there are no dirty pages.
This is closer to indistinguishable from VFS1 behavior. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -56,10 +56,16 @@ func (fd *regularFileFD) OnClose(ctx context.Context) error {\nif !fd.vfsfd.IsWritable() {\nreturn nil\n}\n- // Skip flushing if write... | Go | Apache License 2.0 | google/gvisor | Flush in fsimpl/gofer.regularFileFD.OnClose() if there are no dirty pages.
This is closer to indistinguishable from VFS1 behavior.
PiperOrigin-RevId: 328256068 |
259,860 | 25.08.2020 00:24:16 | 25,200 | c61f6fcf6ab3178da3a297d3e3199379b188ce61 | Fix deadlock in gofer direct IO.
Fixes several java runtime tests:
java/nio/channels/FileChannel/directio/ReadDirect.java
java/nio/channels/FileChannel/directio/PreadDirect.java
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -123,6 +123,10 @@ func (fd *regularFileFD) PRead(ctx context.Context, dst usermem.IOSequence, offs\nreturn 0, io.EOF\n}\n+ var (\n+ n int64\n+ readErr ... | Go | Apache License 2.0 | google/gvisor | Fix deadlock in gofer direct IO.
Fixes several java runtime tests:
java/nio/channels/FileChannel/directio/ReadDirect.java
java/nio/channels/FileChannel/directio/PreadDirect.java
Updates #3576.
PiperOrigin-RevId: 328281849 |
259,907 | 25.08.2020 09:21:59 | 25,200 | 46485f9d473b849e3780af8b757244dde3deacf9 | [go-marshal] Support marshalling for structs with names starting with W.
Due to how marshallable interface implementation was generated, we could not
marshal a struct whose named started with W because there was a naming
collision with parameter (w io.Writer) and type (w *StuctName).
Used "writer" as parameter name to avoid collision. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/gomarshal/generator_interfaces_struct.go",
"new_path": "tools/go_marshal/gomarshal/generator_interfaces_struct.go",
"diff": "@@ -400,13 +400,13 @@ func (g *interfaceGenerator) emitMarshallableForStruct(st *ast.StructType) {\ng.emit(\"// WriteT... | Go | Apache License 2.0 | google/gvisor | [go-marshal] Support marshalling for structs with names starting with W.
Due to how marshallable interface implementation was generated, we could not
marshal a struct whose named started with W because there was a naming
collision with parameter (w io.Writer) and type (w *StuctName).
Used "writer" as parameter name to avoid collision.
PiperOrigin-RevId: 328343930 |
259,858 | 25.08.2020 12:16:31 | 25,200 | b0c53f8475d14606ef82aeddfb2f742269c1b5b7 | Add nogo support to go_binary and go_test targets.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid_parse_x86_test.go",
"new_path": "pkg/cpuid/cpuid_parse_x86_test.go",
"diff": "@@ -32,27 +32,27 @@ func kernelVersion() (int, int, error) {\nreturn 0, 0, err\n}\n- var r string\n+ var sb strings.Builder\nfor _, b := range u.Release {\nif b == 0 ... | Go | Apache License 2.0 | google/gvisor | Add nogo support to go_binary and go_test targets.
Updates #3374
PiperOrigin-RevId: 328378700 |
259,858 | 25.08.2020 12:21:37 | 25,200 | 3b2e50f539457556c33ea635b401a4f52e6a5274 | Include shim in individual released binaries.
The debian rules are also moved to the top-level, since they
apply to binaries outside the //runsc directory.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -114,7 +114,7 @@ runsc: ## Builds the runsc binary.\n.PHONY: runsc\ndebian: ## Builds the debian packages.\n- @$(call submake,build OPTIONS=\"-c opt\" TARGETS=\"//runsc:runsc-debian\")\n+ @$(call submake,build OPT... | Go | Apache License 2.0 | google/gvisor | Include shim in individual released binaries.
The debian rules are also moved to the top-level, since they
apply to binaries outside the //runsc directory.
Fixes #3665
PiperOrigin-RevId: 328379709 |
259,891 | 25.08.2020 13:41:23 | 25,200 | 3cba0a41d9839d5c93dd2d7deb27de5254412e96 | remove iptables sockopt special cases
iptables sockopts were kludged into an unnecessary check, this properly
relegates them to the {get,set}SockOptIP functions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -983,53 +983,12 @@ func (s *SocketOperations) GetSockOpt(t *kernel.Task, level, name int, outPtr us\nreturn &val, nil\n}\n- if s.skType == linux.SOCK_RAW... | Go | Apache License 2.0 | google/gvisor | remove iptables sockopt special cases
iptables sockopts were kludged into an unnecessary check, this properly
relegates them to the {get,set}SockOptIP functions.
PiperOrigin-RevId: 328395135 |
259,858 | 25.08.2020 14:28:03 | 25,200 | e65089029922b8a56bde8a82e4add1556204beaf | Provide --secret-keyring parameter (for newer gpg). | [
{
"change_type": "MODIFY",
"old_path": "tools/make_apt.sh",
"new_path": "tools/make_apt.sh",
"diff": "@@ -64,8 +64,8 @@ trap cleanup EXIT\n# is not found. This isn't actually a failure for us, because we don't require\n# the public (this may be stored separately). The second import will succeed\n# b... | Go | Apache License 2.0 | google/gvisor | Provide --secret-keyring parameter (for newer gpg).
PiperOrigin-RevId: 328403914 |
259,885 | 25.08.2020 14:59:59 | 25,200 | bee07a2d68dedd49fa5790803fb2f7076323a616 | Link to PHP bug for disabled disk space tests. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude_php7.3.6.csv",
"new_path": "test/runtimes/exclude_php7.3.6.csv",
"diff": "@@ -13,13 +13,13 @@ ext/session/tests/session_set_save_handler_class_018.phpt,,\next/session/tests/session_set_save_handler_iface_003.phpt,,\next/session/tests/sess... | Go | Apache License 2.0 | google/gvisor | Link to PHP bug for disabled disk space tests.
PiperOrigin-RevId: 328410399 |
259,907 | 25.08.2020 15:26:54 | 25,200 | 430487c9e7cb4425def8605c6730aa4a168b000d | [go-marshal] Enable auto-marshalling for host tty. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/tty.go",
"new_path": "pkg/abi/linux/tty.go",
"diff": "@@ -23,6 +23,8 @@ const (\n)\n// Winsize is struct winsize, defined in uapi/asm-generic/termios.h.\n+//\n+// +marshal\ntype Winsize struct {\nRow uint16\nCol uint16\n@@ -31,6 +33,8 @@ type Win... | Go | Apache License 2.0 | google/gvisor | [go-marshal] Enable auto-marshalling for host tty.
PiperOrigin-RevId: 328415633 |
259,964 | 25.08.2020 16:13:39 | 25,200 | 70a7a3ac704a47ec50525d06438ba4983da3af8b | Only send an ICMP error message if UDP checksum is valid.
Test:
- TestV4UnknownDestination
- TestV6UnknownDestination | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -1366,6 +1366,22 @@ func (e *endpoint) Readiness(mask waiter.EventMask) waiter.EventMask {\nreturn result\n}\n+// verifyChecksum verifies the checksum unless R... | Go | Apache License 2.0 | google/gvisor | Only send an ICMP error message if UDP checksum is valid.
Test:
- TestV4UnknownDestination
- TestV6UnknownDestination
PiperOrigin-RevId: 328424137 |
259,885 | 25.08.2020 16:38:07 | 25,200 | 247dcd62d436943ad0bf8455c2be22bc36da6637 | Return non-zero size for tmpfs statfs(2).
This does not implement accepting or enforcing any size limit, which will be
more complex and has performance implications; it just returns a fixed non-zero
size.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fs.go",
"new_path": "pkg/abi/linux/fs.go",
"diff": "@@ -44,17 +44,18 @@ type Statfs struct {\n// Type is one of the filesystem magic values, defined above.\nType uint64\n- // BlockSize is the data block size.\n+ // BlockSize is the optimal transf... | Go | Apache License 2.0 | google/gvisor | Return non-zero size for tmpfs statfs(2).
This does not implement accepting or enforcing any size limit, which will be
more complex and has performance implications; it just returns a fixed non-zero
size.
Updates #1936
PiperOrigin-RevId: 328428588 |
259,922 | 21.08.2020 13:48:49 | -32,400 | 03fb0dbf4ce6c6f7f5b8a0c2da7e0df49e1444b5 | use is-active instead of status | [
{
"change_type": "MODIFY",
"old_path": "debian/postinst.sh",
"new_path": "debian/postinst.sh",
"diff": "@@ -21,7 +21,7 @@ fi\n# Update docker configuration.\nif [ -f /etc/docker/daemon.json ]; then\nrunsc install\n- if systemctl status docker 2>/dev/null; then\n+ if systemctl is-active -q docker; th... | Go | Apache License 2.0 | google/gvisor | use is-active instead of status |
259,975 | 25.08.2020 22:01:00 | 25,200 | ebf5293374bc94e01eb58ebe29a1e53aa404d3a7 | Fix SocketPairTest and BadSocketPairTest in opensource. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -97,11 +97,13 @@ TEST(BadSocketPairArgs, ValidateErrForBadCallsToSocketPair) {\nASSERT_THAT(socketpair(AF_INET6, 0, 0, fd),\nSyscallFailsWithEr... | Go | Apache License 2.0 | google/gvisor | Fix SocketPairTest and BadSocketPairTest in opensource.
PiperOrigin-RevId: 328467152 |
260,004 | 27.08.2020 13:43:47 | 25,200 | a5f1e742601aa0281cb2a170a97160dc35220ec3 | Skip IPv6UDPUnboundSocketNetlinkTest on native linux
...while we figure out of we want to consider the loopback interface
bound to all IPs in an assigned IPv6 subnet, or not (to maintain
compatibility with Linux). | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ipv6_udp_unbound_netlink.cc",
"new_path": "test/syscalls/linux/socket_ipv6_udp_unbound_netlink.cc",
"diff": "@@ -26,7 +26,10 @@ namespace testing {\n// Checks that the loopback interface considers itself bound to all IPs in an\n// as... | Go | Apache License 2.0 | google/gvisor | Skip IPv6UDPUnboundSocketNetlinkTest on native linux
...while we figure out of we want to consider the loopback interface
bound to all IPs in an assigned IPv6 subnet, or not (to maintain
compatibility with Linux).
PiperOrigin-RevId: 328807974 |
259,975 | 27.08.2020 14:09:25 | 25,200 | 26c588f06368c21130bb356c6088b76ea715d1ef | Fix BadSocketPair for open source.
BadSocketPair test will return several errnos (EPREM, ESOCKTNOSUPPORT,
EAFNOSUPPORT) meaning the test is just too specific. Checking the syscall
fails is appropriate. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -97,13 +97,9 @@ TEST(BadSocketPairArgs, ValidateErrForBadCallsToSocketPair) {\nASSERT_THAT(socketpair(AF_INET6, 0, 0, fd),\nSyscallFailsWithErr... | Go | Apache License 2.0 | google/gvisor | Fix BadSocketPair for open source.
BadSocketPair test will return several errnos (EPREM, ESOCKTNOSUPPORT,
EAFNOSUPPORT) meaning the test is just too specific. Checking the syscall
fails is appropriate.
PiperOrigin-RevId: 328813071 |
259,907 | 27.08.2020 16:28:36 | 25,200 | 57877b420caa02bf4c60004c7b434ceef8603b26 | [go-marshal] Support for usermem.IOOpts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_usermem.go",
"new_path": "pkg/sentry/kernel/task_usermem.go",
"diff": "@@ -301,3 +301,30 @@ func (t *Task) IovecsIOSequence(addr usermem.Addr, iovcnt int, opts usermem.IOOp\nOpts: opts,\n}, nil\n}\n+\n+// CopyContextWithOpts wraps a task... | Go | Apache License 2.0 | google/gvisor | [go-marshal] Support for usermem.IOOpts.
PiperOrigin-RevId: 328839759 |
259,853 | 27.08.2020 16:50:11 | 25,200 | dc008fbbccf69deba55fd7649424bc568f766596 | unix: return ECONNREFUSE if a socket file exists but a socket isn't bound to it | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1512,8 +1512,10 @@ func (fs *filesystem) BoundEndpointAt(ctx context.Context, rp *vfs.ResolvingPath\npath: opts.Addr,\n}, nil\n}\n+ if d.endpoint != nil {... | Go | Apache License 2.0 | google/gvisor | unix: return ECONNREFUSE if a socket file exists but a socket isn't bound to it
PiperOrigin-RevId: 328843560 |
259,907 | 27.08.2020 19:25:23 | 25,200 | 421e35020bbca240d8f1cb5a2a3efd39750c4589 | [go-marshal] Enable auto-marshalling for tundev. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/devices/tundev/tundev.go",
"new_path": "pkg/sentry/devices/tundev/tundev.go",
"diff": "@@ -64,12 +64,13 @@ func (fd *tunFD) Ioctl(ctx context.Context, uio usermem.IO, args arch.SyscallArg\nrequest := args[1].Uint()\ndata := args[2].Pointer()\n- swit... | Go | Apache License 2.0 | google/gvisor | [go-marshal] Enable auto-marshalling for tundev.
PiperOrigin-RevId: 328863725 |
260,004 | 28.08.2020 05:06:50 | 25,200 | 8ae0ab722c2e5d1bacb96fbac4baa25b49dadd3a | Use a single NetworkEndpoint per address
This change was already done as of
but
conflicted with that
change and it was missed in reviews.
This change fixes the conflict. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -137,6 +137,7 @@ func newNIC(stack *Stack, id tcpip.NICID, name string, ep LinkEndpoint, ctx NICC\nnic.mu.ndp.initializeTempAddrState()\n// Check for Neighbor Unreachability Detection s... | Go | Apache License 2.0 | google/gvisor | Use a single NetworkEndpoint per address
This change was already done as of
https://github.com/google/gvisor/commit/1736b2208f but
https://github.com/google/gvisor/commit/a174aa7597 conflicted with that
change and it was missed in reviews.
This change fixes the conflict.
PiperOrigin-RevId: 328920372 |
259,891 | 28.08.2020 10:33:44 | 25,200 | b3ff31d041c9455614a2a9f2a7be10afb6613357 | fix panic when calling SO_ORIGINAL_DST without initializing iptables
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -427,5 +427,10 @@ func (it *IPTables) checkRule(hook Hook, pkt *PacketBuffer, table Table, ruleIdx\n// OriginalDst returns the original destination of redirected connections. ... | Go | Apache License 2.0 | google/gvisor | fix panic when calling SO_ORIGINAL_DST without initializing iptables
Reported-by: syzbot+074ec22c42305725b79f@syzkaller.appspotmail.com
PiperOrigin-RevId: 328963899 |
259,860 | 28.08.2020 11:26:25 | 25,200 | 8b9cb36d1c74f71da5bc70b73330291f1df298ad | Fix EOF handling for splice.
Also, add corresponding EOF tests for splice/sendfile.
Discovered by syzkaller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/splice.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/splice.go",
"diff": "@@ -141,9 +141,14 @@ func Splice(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscal\ninOffset += n\n}\ndefault:\n- panic(\"not possibl... | Go | Apache License 2.0 | google/gvisor | Fix EOF handling for splice.
Also, add corresponding EOF tests for splice/sendfile.
Discovered by syzkaller.
PiperOrigin-RevId: 328975990 |
260,003 | 31.08.2020 12:01:46 | 25,200 | ba25485d96833b3852c2fbbca508414b3b96d430 | stateify: Bring back struct field and type names in pretty print | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/pretty/pretty.go",
"new_path": "pkg/state/pretty/pretty.go",
"diff": "@@ -26,12 +26,17 @@ import (\n\"gvisor.dev/gvisor/pkg/state/wire\"\n)\n-func formatRef(x *wire.Ref, graph uint64, html bool) string {\n+type printer struct {\n+ html bool\n+ typeSp... | Go | Apache License 2.0 | google/gvisor | stateify: Bring back struct field and type names in pretty print
PiperOrigin-RevId: 329349158 |
259,885 | 31.08.2020 13:55:18 | 25,200 | 6cdfa4fee06dfe4d37b79a8426906c99fe294964 | Don't use read-only host FD for writable gofer dentries in VFS2.
As documented for gofer.dentry.hostFD. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -1472,8 +1472,9 @@ func (d *dentry) ensureSharedHandle(ctx context.Context, read, write, trunc bool\nreturn err\n}\n- if d.hostFD < 0 && openReadable && h.fd >= 0 {\... | Go | Apache License 2.0 | google/gvisor | Don't use read-only host FD for writable gofer dentries in VFS2.
As documented for gofer.dentry.hostFD.
PiperOrigin-RevId: 329372319 |
259,975 | 31.08.2020 17:15:14 | 25,200 | 67484384935fa814e978f08dfa0f0bdbddbbd371 | Fix bug in bazel build benchmark. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/fs/bazel_test.go",
"new_path": "test/benchmarks/fs/bazel_test.go",
"diff": "@@ -62,7 +62,7 @@ func runBuildBenchmark(b *testing.B, image, workdir, target string) {\ncontainer := machine.GetContainer(ctx, b)\ndefer container.CleanUp(ctx)\n- // S... | Go | Apache License 2.0 | google/gvisor | Fix bug in bazel build benchmark.
PiperOrigin-RevId: 329409802 |
259,905 | 01.09.2020 14:55:57 | -28,800 | 66ee7c0e98a98d4046a23b85af42bc68b5ab6b13 | Dup stdio FDs for VFS2 when starting a child container
Currently the stdio FDs are not dupped and will be closed
unexpectedly in VFS2 when starting a child container. This
patch fixes this issue.
Fixes: | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -689,9 +689,18 @@ func (l *Loader) startContainer(spec *specs.Spec, conf *config.Config, cid strin\nreturn fmt.Errorf(\"creating new process: %v\", err)\n}\n- // setupContainerFS() dups std... | Go | Apache License 2.0 | google/gvisor | Dup stdio FDs for VFS2 when starting a child container
Currently the stdio FDs are not dupped and will be closed
unexpectedly in VFS2 when starting a child container. This
patch fixes this issue.
Fixes: #3821
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> |
259,884 | 01.09.2020 01:26:10 | 25,200 | f4be726fde31dac926052b03f5dc666fd4dd4783 | Use 1080p background image.
This makes the background image on the top page 1/3 as big and allows it to
load in roughly half the time. | [
{
"change_type": "MODIFY",
"old_path": "website/_sass/front.scss",
"new_path": "website/_sass/front.scss",
"diff": ".jumbotron {\n- background-image: url(/assets/images/background.jpg);\n+ background-image: url(/assets/images/background_1080p.jpg);\nbackground-position: center;\nbackground-repeat: n... | Go | Apache License 2.0 | google/gvisor | Use 1080p background image.
This makes the background image on the top page 1/3 as big and allows it to
load in roughly half the time.
PiperOrigin-RevId: 329462030 |
259,905 | 01.09.2020 16:01:22 | -28,800 | d5f20209cc34a5357486a2f495bfe30b5d6e2056 | fsimpl/host: fix the order of removing FD notifier
FD notifier should be removed before we close the FD,
otherwise there will be race condition that another FD
which has the same value is opened and added before the
existing FD notifier is removed.
Fixes: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/socket.go",
"new_path": "pkg/sentry/fsimpl/host/socket.go",
"diff": "@@ -348,10 +348,10 @@ func (e *SCMConnectedEndpoint) Init() error {\nfunc (e *SCMConnectedEndpoint) Release(ctx context.Context) {\ne.DecRef(func() {\ne.mu.Lock()\n+ fd... | Go | Apache License 2.0 | google/gvisor | fsimpl/host: fix the order of removing FD notifier
FD notifier should be removed before we close the FD,
otherwise there will be race condition that another FD
which has the same value is opened and added before the
existing FD notifier is removed.
Fixes: #3823
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> |
259,907 | 01.09.2020 12:59:49 | 25,200 | 723fb5c1164872fd1de418d794aa1e9eced8fd94 | [go-marshal] Enable auto-marshalling for fs/tty. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/tty.go",
"new_path": "pkg/abi/linux/tty.go",
"diff": "@@ -341,6 +341,7 @@ var DefaultSlaveTermios = KernelTermios{\n// include/uapi/asm-generic/termios.h.\n//\n// +stateify savable\n+// +marshal\ntype WindowSize struct {\nRows uint16\nCols uint16... | Go | Apache License 2.0 | google/gvisor | [go-marshal] Enable auto-marshalling for fs/tty.
PiperOrigin-RevId: 329564614 |
259,896 | 01.09.2020 13:38:44 | 25,200 | 04c284f8c2015b801c929325a6304e601eb94e56 | Fix panic when calling dup2(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -112,7 +112,7 @@ func (f *FDTable) loadDescriptorTable(m map[int32]descriptor) {\nctx := context.Background()\nf.init() // Initialize table.\nfor fd, d := range m {\n- f.s... | Go | Apache License 2.0 | google/gvisor | Fix panic when calling dup2().
PiperOrigin-RevId: 329572337 |
259,860 | 01.09.2020 17:19:26 | 25,200 | c67d8ece09f44900951c5e20d9c551b9759c7aba | Test opening file handles with different permissions.
These were problematic for vfs2 gofers before correctly implementing separate
read/write handles. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/open_create.cc",
"new_path": "test/syscalls/linux/open_create.cc",
"diff": "@@ -88,21 +88,21 @@ TEST(CreateTest, CreateExclusively) {\nSyscallFailsWithErrno(EEXIST));\n}\n-TEST(CreateTeast, CreatWithOTrunc) {\n+TEST(CreateTest, CreatWithOTr... | Go | Apache License 2.0 | google/gvisor | Test opening file handles with different permissions.
These were problematic for vfs2 gofers before correctly implementing separate
read/write handles.
PiperOrigin-RevId: 329613261 |
259,992 | 01.09.2020 19:20:37 | 25,200 | 37a217aca4a128d66a6dd4969375ea81bd879ac7 | Implement setattr+clunk in 9P
This is to cover the common pattern: open->read/write->close,
where SetAttr needs to be called to update atime/mtime before
the file is closed.
Benchmark results:
BM_OpenReadClose/10240 CPU
setattr+clunk: 63783 ns
VFS2: 68109 ns
VFS1: 72507 ns
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/client_file.go",
"new_path": "pkg/p9/client_file.go",
"diff": "@@ -54,6 +54,8 @@ func (c *Client) newFile(fid FID) *clientFile {\n//\n// This proxies all of the interfaces found in file.go.\ntype clientFile struct {\n+ DisallowServerCalls\n+\n// client ... | Go | Apache License 2.0 | google/gvisor | Implement setattr+clunk in 9P
This is to cover the common pattern: open->read/write->close,
where SetAttr needs to be called to update atime/mtime before
the file is closed.
Benchmark results:
BM_OpenReadClose/10240 CPU
setattr+clunk: 63783 ns
VFS2: 68109 ns
VFS1: 72507 ns
Updates #1198
PiperOrigin-RevId: 329628461 |
259,975 | 01.09.2020 21:01:33 | 25,200 | 563f28b7d56c11a418856f1defeb64e72beb0e9a | Fix statfs test for opensource. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/statfs.cc",
"new_path": "test/syscalls/linux/statfs.cc",
"diff": "@@ -43,9 +43,6 @@ TEST(StatfsTest, InternalTmpfs) {\nstruct statfs st;\nEXPECT_THAT(statfs(temp_file.path().c_str(), &st), SyscallSucceeds());\n- // Note: We could be an over... | Go | Apache License 2.0 | google/gvisor | Fix statfs test for opensource.
PiperOrigin-RevId: 329638946 |
259,907 | 02.09.2020 11:11:23 | 25,200 | 8ab08cdc01e2e4b36a050ffc3acad682aebaa7b5 | [runtime tests] Exclude flaky nodejs test | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude_nodejs12.4.0.csv",
"new_path": "test/runtimes/exclude_nodejs12.4.0.csv",
"diff": "@@ -11,8 +11,9 @@ parallel/test-dgram-socket-buffer-size.js,b/68847921,\nparallel/test-dns-channel-timeout.js,b/161893056,\nparallel/test-fs-access.js,,\npa... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Exclude flaky nodejs test
PiperOrigin-RevId: 329749191 |
259,907 | 02.09.2020 15:39:51 | 25,200 | 0ca0d8e0110d284120497569dca1b85d3ec227fe | [vfs] Fix error handling in overlayfs OpenAt.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"new_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"diff": "@@ -743,6 +743,9 @@ func (fs *filesystem) OpenAt(ctx context.Context, rp *vfs.ResolvingPath, opts vf\nstart := rp.Start().Impl().(*dentry)\nif rp.Done() {... | Go | Apache License 2.0 | google/gvisor | [vfs] Fix error handling in overlayfs OpenAt.
Updates #1199
PiperOrigin-RevId: 329802274 |
259,907 | 02.09.2020 17:56:30 | 25,200 | 1fec861939e393f637979e9ee5ef1a253d06c89d | [vfs] Implement xattr for overlayfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inode_overlay.go",
"new_path": "pkg/sentry/fs/inode_overlay.go",
"diff": "@@ -16,7 +16,6 @@ package fs\nimport (\n\"fmt\"\n- \"strings\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n@@ -539,7 +538,7 @@ func overlayGetX... | Go | Apache License 2.0 | google/gvisor | [vfs] Implement xattr for overlayfs.
PiperOrigin-RevId: 329825497 |
259,884 | 02.09.2020 19:37:06 | 25,200 | a8c174c04751799514ec2e89111e7d03ddf68b70 | Update version in cni tutorial
Update the cniVersion used in the CNI tutorial so that it works with
containerd 1.2. Containerd 1.2 includes a version of the cri plugin
(release/1.2) that, in turn, includes a version of the
cni library (0.6.0) that only supports up to 0.3.1. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/cni.md",
"new_path": "g3doc/user_guide/tutorials/cni.md",
"diff": "@@ -47,7 +47,7 @@ sudo mkdir -p /etc/cni/net.d\nsudo sh -c 'cat > /etc/cni/net.d/10-bridge.conf << EOF\n{\n- \"cniVersion\": \"0.4.0\",\n+ \"cniVersion\": \"0.3.1\",\... | Go | Apache License 2.0 | google/gvisor | Update version in cni tutorial
Update the cniVersion used in the CNI tutorial so that it works with
containerd 1.2. Containerd 1.2 includes a version of the cri plugin
(release/1.2) that, in turn, includes a version of the
cni library (0.6.0) that only supports up to 0.3.1.
https://github.com/containernetworking/cni/blob/v0.6.0/pkg/version/version.go#L38
PiperOrigin-RevId: 329837188 |
259,962 | 03.09.2020 17:34:56 | 25,200 | 805861ca37c0a6302ebc91f25dfa99618da137e2 | Use fine-grained mutex for stack.cleanupEndpoints.
stack.cleanupEndpoints is protected by the stack.mu but that can cause
contention as the stack mutex is already acquired in a lot of hot paths during
new endpoint creation /cleanup etc. Moving this to a fine grained mutex should
reduce contention on the stack.mu. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -418,6 +418,9 @@ type Stack struct {\nmu sync.RWMutex\nnics map[tcpip.NICID]*NIC\nforwarding bool\n+\n+ // cleanupEndpointsMu protects cleanupEndpoints.\n+ cleanupEndpointsMu sync.M... | Go | Apache License 2.0 | google/gvisor | Use fine-grained mutex for stack.cleanupEndpoints.
stack.cleanupEndpoints is protected by the stack.mu but that can cause
contention as the stack mutex is already acquired in a lot of hot paths during
new endpoint creation /cleanup etc. Moving this to a fine grained mutex should
reduce contention on the stack.mu.
PiperOrigin-RevId: 330026151 |
259,907 | 03.09.2020 21:42:49 | 25,200 | b6d6a120d07ec0d1b3c0a3abc9e78b6e0bbd3966 | Fix the release workflow. | [
{
"change_type": "MODIFY",
"old_path": "tools/make_apt.sh",
"new_path": "tools/make_apt.sh",
"diff": "@@ -54,18 +54,21 @@ declare -r release=\"${root}/dists/${suite}\"\nmkdir -p \"${release}\"\n# Create a temporary keyring, and ensure it is cleaned up.\n+# Using separate homedir allows us to install... | Go | Apache License 2.0 | google/gvisor | Fix the release workflow.
PiperOrigin-RevId: 330049242 |
259,860 | 03.09.2020 23:29:13 | 25,200 | c564293b65eefcf1342023694e4aae82314de014 | Adjust input file offset when sendfile only completes a partial write.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/BUILD",
"new_path": "pkg/sentry/syscalls/linux/vfs2/BUILD",
"diff": "@@ -44,6 +44,7 @@ go_library(\n\"//pkg/context\",\n\"//pkg/fspath\",\n\"//pkg/gohacks\",\n+ \"//pkg/log\",\n\"//pkg/sentry/arch\",\n\"//pkg/sentry/fs/lock\",\n\... | Go | Apache License 2.0 | google/gvisor | Adjust input file offset when sendfile only completes a partial write.
Fixes #3779.
PiperOrigin-RevId: 330057268 |
259,905 | 08.09.2020 15:50:29 | -28,800 | ceab2e21de0856c403dc4e37d7f3b68ee970f3d5 | Fix the use after nil check on args.MountNamespaceVFS2
The args.MountNamespaceVFS2 is used again after the nil check,
instead, mntnsVFS2 which holds the expected reference should be
used. This patch fixes this issue.
Fixes: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -888,17 +888,18 @@ func (k *Kernel) CreateProcess(args CreateProcessArgs) (*ThreadGroup, ThreadID,\nopener fsbridge.Lookup\nfsContext *FSContext\nmntns *fs.MountNamespace\n+ m... | Go | Apache License 2.0 | google/gvisor | Fix the use after nil check on args.MountNamespaceVFS2
The args.MountNamespaceVFS2 is used again after the nil check,
instead, mntnsVFS2 which holds the expected reference should be
used. This patch fixes this issue.
Fixes: #3855
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> |
259,962 | 08.09.2020 12:29:26 | 25,200 | 38cdb0579b698d67abad4f7f6ba18a84eef66bd7 | Fix data race in tcp.GetSockOpt.
e.ID can't be read without holding e.mu. GetSockOpt was reading e.ID
when looking up OriginalDst without holding e.mu. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -2019,8 +2019,10 @@ func (e *endpoint) GetSockOpt(opt tcpip.GettableSocketOption) *tcpip.Error {\ne.UnlockUser()\ncase *tcpip.OriginalDestinationOption:\n+ e.L... | Go | Apache License 2.0 | google/gvisor | Fix data race in tcp.GetSockOpt.
e.ID can't be read without holding e.mu. GetSockOpt was reading e.ID
when looking up OriginalDst without holding e.mu.
PiperOrigin-RevId: 330562293 |
259,907 | 08.09.2020 14:40:57 | 25,200 | 682c0edcdcdfbf26be5d0d6efa2319f6f5259df2 | [vfs] overlayfs: decref VD when not using it.
overlay/filesystem.go:lookupLocked() did not DecRef the VD on some error paths
when it would not end up saving or using the VD. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"new_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"diff": "@@ -211,6 +211,7 @@ func (fs *filesystem) lookupLocked(ctx context.Context, parent *dentry, name str\nlookupErr = err\nreturn false\n}\n+ defer childVD.De... | Go | Apache License 2.0 | google/gvisor | [vfs] overlayfs: decref VD when not using it.
overlay/filesystem.go:lookupLocked() did not DecRef the VD on some error paths
when it would not end up saving or using the VD.
PiperOrigin-RevId: 330589742 |
259,885 | 08.09.2020 18:31:17 | 25,200 | 8d3551da6a41c30fa9c04a5b0cef712c089d5d04 | Implement synthetic mountpoints for kernfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/BUILD",
"new_path": "pkg/sentry/fsimpl/kernfs/BUILD",
"diff": "@@ -83,6 +83,7 @@ go_library(\n\"slot_list.go\",\n\"static_directory_refs.go\",\n\"symlink.go\",\n+ \"synthetic_directory.go\",\n],\nvisibility = [\"//pkg/sentry:internal\"... | Go | Apache License 2.0 | google/gvisor | Implement synthetic mountpoints for kernfs.
PiperOrigin-RevId: 330629897 |
259,884 | 08.09.2020 21:57:28 | 25,200 | 00479af515289f42a63ab14cec128ab030120b38 | Add a Docker Compose tutorial
Adds a Docker Compose tutorial to the website that shows how to start a
Wordpress site and includes information about how to get DNS working.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/BUILD",
"new_path": "g3doc/user_guide/tutorials/BUILD",
"diff": "@@ -14,6 +14,15 @@ doc(\nweight = \"10\",\n)\n+doc(\n+ name = \"docker_compose\",\n+ src = \"docker-compose.md\",\n+ category = \"User Guide\",\n+ permalink = \"/docs/t... | Go | Apache License 2.0 | google/gvisor | Add a Docker Compose tutorial
Adds a Docker Compose tutorial to the website that shows how to start a
Wordpress site and includes information about how to get DNS working.
Fixes #115
PiperOrigin-RevId: 330652842 |
259,884 | 09.09.2020 09:06:26 | 25,200 | 26439f9a43a6a23bd9fbc64f2b43ca843ad25d99 | Add syntax highlighting to website
Adds a syntax highlighting theme css so that code snippets are highlighted
properly. | [
{
"change_type": "MODIFY",
"old_path": "images/jekyll/Dockerfile",
"new_path": "images/jekyll/Dockerfile",
"diff": "FROM jekyll/jekyll:4.0.0\nUSER root\n+\nRUN gem install \\\nhtml-proofer:3.10.2 \\\nnokogiri:1.10.1 \\\n@@ -10,5 +11,9 @@ RUN gem install \\\njekyll-relative-links:0.6.1 \\\njekyll-fee... | Go | Apache License 2.0 | google/gvisor | Add syntax highlighting to website
Adds a syntax highlighting theme css so that code snippets are highlighted
properly.
PiperOrigin-RevId: 330733737 |
259,884 | 09.09.2020 10:08:06 | 25,200 | fb281eea75799d662790cdf86ce0d55dc56b7470 | Fix formatting for Kubernetes tutorial | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/kubernetes.md",
"new_path": "g3doc/user_guide/tutorials/kubernetes.md",
"diff": "@@ -23,12 +23,12 @@ gcloud beta container node-pools create sandbox-pool --cluster=${CLUSTER_NAME} -\nIf you prefer to use the console, select your clus... | Go | Apache License 2.0 | google/gvisor | Fix formatting for Kubernetes tutorial
PiperOrigin-RevId: 330745430 |
259,853 | 09.09.2020 10:38:48 | 25,200 | 27897621da066fb7612781ae435d2bb6b7759433 | github: run actions for feature branches | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/build.yml",
"new_path": ".github/workflows/build.yml",
"diff": "@@ -3,9 +3,11 @@ on:\npush:\nbranches:\n- master\n+ - feature/**\npull_request:\nbranches:\n- master\n+ - feature/**\njobs:\ndefault:\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | github: run actions for feature branches
Signed-off-by: Andrei Vagin <avagin@google.com> |
259,885 | 09.09.2020 12:47:24 | 25,200 | f3172c3a11dda8aa21bbaf51b7f63196592cf1da | Don't sched_setaffinity in ptrace platform. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/BUILD",
"new_path": "pkg/sentry/platform/ptrace/BUILD",
"diff": "@@ -30,7 +30,6 @@ go_library(\n\"//pkg/safecopy\",\n\"//pkg/seccomp\",\n\"//pkg/sentry/arch\",\n- \"//pkg/sentry/hostcpu\",\n\"//pkg/sentry/memmap\",\n\"//pkg/sentry/pl... | Go | Apache License 2.0 | google/gvisor | Don't sched_setaffinity in ptrace platform.
PiperOrigin-RevId: 330777900 |
259,885 | 09.09.2020 18:38:02 | 25,200 | 644ac7b6bcf547cb44da6f298c92de4b3806c426 | Unlock VFS.mountMu before FilesystemImpl calls for /proc/[pid]/{mounts,mountinfo}.
Also move VFS.MakeSyntheticMountpoint() (which is a utility wrapper around
VFS.MkdirAllAt(), itself a utility wrapper around VFS.MkdirAt()) to not be in
the middle of the implementation of these proc files.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -18,14 +18,12 @@ import (\n\"bytes\"\n\"fmt\"\n\"math\"\n- \"path\"\n\"sort\"\n\"strings\"\n\"sync/atomic\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n- ... | Go | Apache License 2.0 | google/gvisor | Unlock VFS.mountMu before FilesystemImpl calls for /proc/[pid]/{mounts,mountinfo}.
Also move VFS.MakeSyntheticMountpoint() (which is a utility wrapper around
VFS.MkdirAllAt(), itself a utility wrapper around VFS.MkdirAt()) to not be in
the middle of the implementation of these proc files.
Fixes #3878
PiperOrigin-RevId: 330843106 |
259,884 | 09.09.2020 20:11:16 | 25,200 | 1ab097b08fc16d67b90f094a4316883c289ef77f | Add note about kubeadm to the FAQ
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/FAQ.md",
"new_path": "g3doc/user_guide/FAQ.md",
"diff": "@@ -96,6 +96,30 @@ containerd.\nSee [issue #1765](https://gvisor.dev/issue/1765) for more details.\n+### I'm getting an error like `RuntimeHandler \"runsc\" not supported` {#runtime-hand... | Go | Apache License 2.0 | google/gvisor | Add note about kubeadm to the FAQ
Fixes #3277
PiperOrigin-RevId: 330853338 |
259,907 | 10.09.2020 10:38:19 | 25,200 | 50c99a86d1c6807c67cdc52102b1fc570426669f | [vfs] Disable nlink tests for overlayfs.
Overlayfs intentionally does not compute nlink for directories (because it can
be really expensive). Linux returns 1, VFS2 returns 2 and VFS1 actually
calculates the correct value. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/stat.cc",
"new_path": "test/syscalls/linux/stat.cc",
"diff": "@@ -97,6 +97,11 @@ TEST_F(StatTest, FstatatSymlink) {\n}\nTEST_F(StatTest, Nlinks) {\n+ // Skip this test if we are testing overlayfs because overlayfs does not\n+ // (intentiona... | Go | Apache License 2.0 | google/gvisor | [vfs] Disable nlink tests for overlayfs.
Overlayfs intentionally does not compute nlink for directories (because it can
be really expensive). Linux returns 1, VFS2 returns 2 and VFS1 actually
calculates the correct value.
PiperOrigin-RevId: 330967139 |
259,907 | 10.09.2020 11:40:46 | 25,200 | 14e0eb6e0f58da34246c85ec6aa2b4a9beabc63e | [vfs] Add vfs2 runtime tests. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -157,6 +157,10 @@ syscall-tests: syscall-ptrace-tests syscall-kvm-tests syscall-native-tests\n@$(call submake,install-test-runtime)\n@$(call submake,test-runtime OPTIONS=\"--test_timeout=10800\" TARGETS=\"//test/r... | Go | Apache License 2.0 | google/gvisor | [vfs] Add vfs2 runtime tests.
PiperOrigin-RevId: 330981912 |
259,907 | 10.09.2020 16:48:03 | 25,200 | 365545855f7713236d77d3e263ad09ebffa85bb2 | [vfs] Disable inode number equality check for overlayfs.
Overlayfs does not persist a directory's inode number even while it is mounted.
See fs/overlayfs/inode.c:ovl_map_dev_ino(). VFS2 generates a new inode number
for directories everytime in lookup. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mount.cc",
"new_path": "test/syscalls/linux/mount.cc",
"diff": "@@ -147,8 +147,15 @@ TEST(MountTest, UmountDetach) {\n// Unmount the tmpfs.\nmount.Release()();\n+ // Only check for inode number equality if the directory is not in overlayfs.... | Go | Apache License 2.0 | google/gvisor | [vfs] Disable inode number equality check for overlayfs.
Overlayfs does not persist a directory's inode number even while it is mounted.
See fs/overlayfs/inode.c:ovl_map_dev_ino(). VFS2 generates a new inode number
for directories everytime in lookup.
PiperOrigin-RevId: 331045037 |
259,962 | 11.09.2020 11:53:54 | 25,200 | 831ab2dd993e834933e0b23310cd616dbc0551ad | Fix host unix socket to not swallow EOF incorrectly.
Fixes an error where in case of a receive buffer larger than the host send
buffer size for a host backed unix dgram socket we would end up swallowing EOF
from recvmsg syscall causing the read() to block forever. | [
{
"change_type": "MODIFY",
"old_path": "pkg/safemem/BUILD",
"new_path": "pkg/safemem/BUILD",
"diff": "@@ -11,9 +11,7 @@ go_library(\n\"seq_unsafe.go\",\n],\nvisibility = [\"//:sandbox\"],\n- deps = [\n- \"//pkg/safecopy\",\n- ],\n+ deps = [\"//pkg/safecopy\"],\n)\ngo_test(\n"
},
{
"change_ty... | Go | Apache License 2.0 | google/gvisor | Fix host unix socket to not swallow EOF incorrectly.
Fixes an error where in case of a receive buffer larger than the host send
buffer size for a host backed unix dgram socket we would end up swallowing EOF
from recvmsg syscall causing the read() to block forever.
PiperOrigin-RevId: 331192810 |
259,885 | 11.09.2020 13:00:02 | 25,200 | 9a5635eb179f3a21c51e912aa87277025d7950e9 | Implement copy-up-coherent mmap for VFS2 overlayfs.
This is very similar to copy-up-coherent mmap in the VFS1 overlay, with the
minor wrinkle that there is no fs.InodeOperations.Mappable().
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"new_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"diff": "@@ -23,6 +23,7 @@ import (\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/fspath\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel/auth\"\n+ \"gvisor.dev/gv... | Go | Apache License 2.0 | google/gvisor | Implement copy-up-coherent mmap for VFS2 overlayfs.
This is very similar to copy-up-coherent mmap in the VFS1 overlay, with the
minor wrinkle that there is no fs.InodeOperations.Mappable().
Updates #1199
PiperOrigin-RevId: 331206314 |
259,881 | 11.09.2020 13:00:30 | 25,200 | 490e5c83bd647639e36a9f7e871af33fa64b9bb1 | Make nogo more robust to variety of stdlib layouts. | [
{
"change_type": "MODIFY",
"old_path": "tools/nogo/nogo.go",
"new_path": "tools/nogo/nogo.go",
"diff": "@@ -202,29 +202,41 @@ func checkStdlib(config *stdlibConfig, ac map[*analysis.Analyzer]matcher) ([]str\nconfig.Srcs[i] = path.Clean(config.Srcs[i])\n}\n- // Calculate the root directory.\n- longes... | Go | Apache License 2.0 | google/gvisor | Make nogo more robust to variety of stdlib layouts.
PiperOrigin-RevId: 331206424 |
259,933 | 11.09.2020 13:26:33 | 25,200 | 325f7036b051a705d5ae595d2f3c351084262532 | Use correct test device name in Fuchsia packetimpact
Packetimpact on Fuchsia was formerly using the Linux test device name. This
change fixes that. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/dut.go",
"new_path": "test/packetimpact/runner/dut.go",
"diff": "@@ -171,11 +171,8 @@ func TestWithDUT(ctx context.Context, t *testing.T, mkDevice func(*dockerutil.Co\n}},\n}\n- // Add ctrlNet as eth1 and testNet as eth2.\n- const test... | Go | Apache License 2.0 | google/gvisor | Use correct test device name in Fuchsia packetimpact
Packetimpact on Fuchsia was formerly using the Linux test device name. This
change fixes that.
PiperOrigin-RevId: 331211518 |
259,964 | 12.09.2020 23:19:34 | 25,200 | b6ca96b9b9e71ba57653cf9d3ef0767771949378 | Cap reassembled IPv6 packets at 65535 octets
IPv4 can accept 65536-octet reassembled packets.
Test:
ipv4_test.TestInvalidFragments
ipv4_test.TestReceiveFragments
ipv6.TestInvalidIPv6Fragments
ipv6.TestReceiveIPv6Fragments
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv4.go",
"new_path": "pkg/tcpip/header/ipv4.go",
"diff": "@@ -88,6 +88,16 @@ const (\n// units, the header cannot exceed 15*4 = 60 bytes.\nIPv4MaximumHeaderSize = 60\n+ // IPv4MaximumPayloadSize is the maximum size of a valid IPv4 payload.\n+... | Go | Apache License 2.0 | google/gvisor | Cap reassembled IPv6 packets at 65535 octets
IPv4 can accept 65536-octet reassembled packets.
Test:
- ipv4_test.TestInvalidFragments
- ipv4_test.TestReceiveFragments
- ipv6.TestInvalidIPv6Fragments
- ipv6.TestReceiveIPv6Fragments
Fixes #3770
PiperOrigin-RevId: 331382977 |
259,891 | 14.09.2020 11:08:56 | 25,200 | 833ceb0f14485ee11719b52a42087dfac14de856 | Fix modprobe dependency
The modprobe command only takes 1 module per invocation. The second module name
is being passed as a module parameter. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -211,7 +211,8 @@ packetdrill-tests: load-packetdrill\n.PHONY: packetdrill-tests\npacketimpact-tests: load-packetimpact\n- @sudo modprobe iptable_filter ip6table_filter\n+ @sudo modprobe iptable_filter\n+ @sudo mod... | Go | Apache License 2.0 | google/gvisor | Fix modprobe dependency
The modprobe command only takes 1 module per invocation. The second module name
is being passed as a module parameter.
PiperOrigin-RevId: 331585765 |
260,023 | 14.09.2020 14:31:02 | 25,200 | 05d2ebee5e4ebc31cd71f6064ca433a58692be76 | Test RST handling in TIME_WAIT.
gVisor stack ignores RSTs when in TIME_WAIT which is not the default
Linux behavior. Add a packetimpact test to test the same.
Also update code comments to reflect the rationale for the current
gVisor behavior. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/rcv.go",
"new_path": "pkg/tcpip/transport/tcp/rcv.go",
"diff": "@@ -436,6 +436,13 @@ func (r *receiver) handleTimeWaitSegment(s *segment) (resetTimeWait bool, newSyn\n// Just silently drop any RST packets in TIME_WAIT. We do not support... | Go | Apache License 2.0 | google/gvisor | Test RST handling in TIME_WAIT.
gVisor stack ignores RSTs when in TIME_WAIT which is not the default
Linux behavior. Add a packetimpact test to test the same.
Also update code comments to reflect the rationale for the current
gVisor behavior.
PiperOrigin-RevId: 331629879 |
259,992 | 14.09.2020 16:02:07 | 25,200 | 52ffeb2d6475fa2e427daf246abdd32e4825f3f8 | Add note about gofer link(2) limitation | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64.go",
"diff": "@@ -138,7 +138,7 @@ var AMD64 = &kernel.SyscallTable{\n83: syscalls.Supported(\"mkdir\", Mkdir),\n84: syscalls.Supported(\"rmdir\", Rmdir),\n85: syscalls.Suppor... | Go | Apache License 2.0 | google/gvisor | Add note about gofer link(2) limitation
PiperOrigin-RevId: 331648296 |
259,885 | 15.09.2020 13:17:26 | 25,200 | 86b31a80777dd906b275fb4b21888e93836f8a9b | RFC: design for a 9P replacement
Tentatively `lisafs` (LInux SAndbox FileSystem). | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/lisafs/README.md",
"diff": "+# Replacing 9P\n+\n+## Background\n+\n+The Linux filesystem model consists of the following key aspects (modulo mounts,\n+which are outside the scope of this discussion):\n+\n+- A `struct inode` represents a \"fi... | Go | Apache License 2.0 | google/gvisor | RFC: design for a 9P replacement
Tentatively `lisafs` (LInux SAndbox FileSystem).
PiperOrigin-RevId: 331839246 |
259,896 | 15.09.2020 13:39:47 | 25,200 | 7f89a26e18edfe4335eaab965fb7a03eaebb2682 | Release FDTable lock before dropping the fds.
This is needed for SO_LINGER, where close() is blocked for linger timeout and
we are holding the FDTable lock for the entire timeout which will not allow
us to create/delete other fds. We have to release the locks and then drop the
fds. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -113,7 +113,9 @@ func (f *FDTable) loadDescriptorTable(m map[int32]descriptor) {\nf.init() // Initialize table.\nf.used = 0\nfor fd, d := range m {\n- f.setAll(ctx, fd, d.... | Go | Apache License 2.0 | google/gvisor | Release FDTable lock before dropping the fds.
This is needed for SO_LINGER, where close() is blocked for linger timeout and
we are holding the FDTable lock for the entire timeout which will not allow
us to create/delete other fds. We have to release the locks and then drop the
fds.
PiperOrigin-RevId: 331844185 |
259,951 | 15.09.2020 14:47:34 | 25,200 | 72a30b11486b48394fa0edca500b80e4ca83b10c | Move reusable IPv4 test code into a testutil module and refactor it
The refactor aims to simplify the package, by replacing the Go channel with a
PacketBuffer slice.
This code will be reused by tests for IPv6 fragmentation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/BUILD",
"new_path": "pkg/tcpip/network/ipv4/BUILD",
"diff": "@@ -30,6 +30,7 @@ go_test(\n\"//pkg/tcpip/link/channel\",\n\"//pkg/tcpip/link/sniffer\",\n\"//pkg/tcpip/network/ipv4\",\n+ \"//pkg/tcpip/network/testutil\",\n\"//pkg/tcpip/stac... | Go | Apache License 2.0 | google/gvisor | Move reusable IPv4 test code into a testutil module and refactor it
The refactor aims to simplify the package, by replacing the Go channel with a
PacketBuffer slice.
This code will be reused by tests for IPv6 fragmentation.
PiperOrigin-RevId: 331860411 |
259,860 | 15.09.2020 14:50:45 | 25,200 | a004f0d082458ce98114b59a3e5d41c2e74541d6 | Support setting STATX_SIZE for kernfs.InodeAttrs.
Make setting STATX_SIZE a no-op, if it is valid for the given permissions and
file type.
Also update proc tests, which were overfitted before.
Fixes
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"new_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"diff": "@@ -259,9 +259,19 @@ func (a *InodeAttrs) SetStat(ctx context.Context, fs *vfs.Filesystem, creds *aut\nif opts.Stat.Mask == 0 {\nreturn nil\n}\n- ... | Go | Apache License 2.0 | google/gvisor | Support setting STATX_SIZE for kernfs.InodeAttrs.
Make setting STATX_SIZE a no-op, if it is valid for the given permissions and
file type.
Also update proc tests, which were overfitted before.
Fixes #3842.
Updates #1193.
PiperOrigin-RevId: 331861087 |
259,885 | 15.09.2020 15:12:50 | 25,200 | 456c6c33e104e7421a5a815bba69d46b289ae724 | Invert dependency between the context and amutex packages.
This is to allow the syserror package to depend on the context package in a
future change. | [
{
"change_type": "MODIFY",
"old_path": "pkg/amutex/BUILD",
"new_path": "pkg/amutex/BUILD",
"diff": "@@ -6,7 +6,10 @@ go_library(\nname = \"amutex\",\nsrcs = [\"amutex.go\"],\nvisibility = [\"//:sandbox\"],\n- deps = [\"//pkg/syserror\"],\n+ deps = [\n+ \"//pkg/context\",\n+ \"//pkg/syserror\",\n+ ],... | Go | Apache License 2.0 | google/gvisor | Invert dependency between the context and amutex packages.
This is to allow the syserror package to depend on the context package in a
future change.
PiperOrigin-RevId: 331866252 |
260,001 | 15.09.2020 19:00:14 | 25,200 | cb2e3c946a376097f695118384cf3a147905aa18 | Implement gvisor verity fs ioctl with GETFLAGS | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/ioctl.go",
"new_path": "pkg/abi/linux/ioctl.go",
"diff": "@@ -113,6 +113,12 @@ const (\n_IOC_DIRSHIFT = _IOC_SIZESHIFT + _IOC_SIZEBITS\n)\n+// Constants from uapi/linux/fs.h.\n+const (\n+ FS_IOC_GETFLAGS = 2147771905\n+ FS_VERITY_FL = 1048576\n+)... | Go | Apache License 2.0 | google/gvisor | Implement gvisor verity fs ioctl with GETFLAGS
PiperOrigin-RevId: 331905347 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.