author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,884 | 15.09.2020 19:47:49 | 25,200 | c053c4bb03819a9b9bb4d485000789cb653cd9c7 | Fix GitHub issue template.
runsc -v doesn't work. It should be runsc -version | [
{
"change_type": "MODIFY",
"old_path": ".github/ISSUE_TEMPLATE/bug_report.md",
"new_path": ".github/ISSUE_TEMPLATE/bug_report.md",
"diff": "@@ -23,7 +23,7 @@ reproduced with software that is publicly available.\nPlease include the following details of your environment:\n-* `runsc -v`\n+* `runsc -ver... | Go | Apache License 2.0 | google/gvisor | Fix GitHub issue template.
runsc -v doesn't work. It should be runsc -version
PiperOrigin-RevId: 331911035 |
259,990 | 15.09.2020 20:50:07 | 25,200 | b8dc9a889f3d945bcd0f02f8ca34eb2e579e8b0e | Use container ID as cgroup name if not provided
Useful when you want to run multiple containers with the same config.
And runc does that too. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -311,6 +311,10 @@ func New(conf *boot.Config, args Args) (*Container, error) {\nif isRoot(args.Spec) {\nlog.Debugf(\"Creating new sandbox for container %q\", args.ID)\n+ if ... | Go | Apache License 2.0 | google/gvisor | Use container ID as cgroup name if not provided
Useful when you want to run multiple containers with the same config.
And runc does that too. |
259,992 | 16.09.2020 07:45:28 | 25,200 | 326a1dbb73addeaf8e51af55b8a9de95638b4017 | Refactor removed default test dimension
ptrace was always selected as a dimension before, but not
anymore. Some tests were specifying "overlay" expecting that
to be in addition to the default. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -293,22 +293,20 @@ var (\nfunc configs(t *testing.T, opts ...configOption) map[string]*config.Config {\n// Always load the default config.\ncs := make(map[string]*... | Go | Apache License 2.0 | google/gvisor | Refactor removed default test dimension
ptrace was always selected as a dimension before, but not
anymore. Some tests were specifying "overlay" expecting that
to be in addition to the default.
PiperOrigin-RevId: 332004111 |
259,983 | 14.08.2020 10:17:08 | 25,200 | d928d3c00a66a29933eee9671e3558cd8163337f | Add function generating array of iovec with different FUSE structs
This commit adds a function in the newly created fuse_util library,
which accepts a variable number of arguments and data structures.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/fuse/linux/BUILD",
"new_path": "test/fuse/linux/BUILD",
"diff": "@@ -12,6 +12,7 @@ cc_binary(\ndeps = [\ngtest,\n\":fuse_base\",\n+ \"//test/util:fuse_util\",\n\"//test/util:test_main\",\n\"//test/util:test_util\",\n],\n@@ -24,6 +25,7 @@ cc_library(\nhdrs... | Go | Apache License 2.0 | google/gvisor | Add function generating array of iovec with different FUSE structs
This commit adds a function in the newly created fuse_util library,
which accepts a variable number of arguments and data structures.
Fixes #3609 |
259,853 | 13.08.2020 22:23:40 | 0 | d6ee3ae6d797b7f66092971f395ef63f8a430c78 | Implement FUSE_LOOKUP
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "package linux\n+import \"gvisor.dev/gvisor/tools/go_marshal/marshal\"\n+\n// +marshal\ntype FUSEOpcode uint32\n// +marshal\ntype FUSEOpID uint64\n+// FUSE_ROOT_ID is the id of root inode.\n+... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_LOOKUP
Fixes #3231
Co-authored-by: Boyuan He <heboyuan@google.com> |
259,984 | 18.08.2020 01:46:39 | 0 | 32044f94e9dfbb88c17d07b235b8ed5b07d2ff18 | Implement FUSE_OPEN/OPENDIR
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -357,3 +357,41 @@ func (r *FUSELookupIn) MarshalUnsafe(buf []byte) {\nfunc (r *FUSELookupIn) SizeBytes() int {\nreturn len(r.Name) + 1\n}\n+\n+// MAX_NON_LFS indicates the maximum offset ... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_OPEN/OPENDIR
Fixes #3174 |
259,984 | 18.08.2020 20:59:28 | 0 | 947088e10a15b5236f2af3206f67f27245ef2770 | Implement FUSE_RELEASE/RELEASEDIR
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -395,3 +395,21 @@ type FUSEOpenOut struct {\n_ uint32\n}\n+\n+// FUSEReleaseIn is the request sent by the kernel to the daemon\n+// when there is no more reference to a file.\n+//\n+// +m... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_RELEASE/RELEASEDIR
Fixes #3314 |
259,984 | 18.08.2020 21:51:06 | 0 | b53e10f391929e4ad9345a823a0cf33bcfedf413 | Implement FUSE_MKNOD
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -413,3 +413,46 @@ type FUSEReleaseIn struct {\n// LockOwner is the id of the lock owner if there is one.\nLockOwner uint64\n}\n+\n+// FUSEMknodMeta contains all the static fields of FUSEM... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_MKNOD
Fixes #3492 |
259,984 | 18.08.2020 23:09:34 | 0 | b50c03b5715905ebd82b1006c1bb2e2d4eb9334d | Implement FUSE_SYMLINK
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -456,3 +456,30 @@ func (r *FUSEMknodIn) MarshalUnsafe(buf []byte) {\nfunc (r *FUSEMknodIn) SizeBytes() int {\nreturn r.MknodMeta.SizeBytes() + len(r.Name) + 1\n}\n+\n+// FUSESymLinkIn is ... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_SYMLINK
Fixes #3452 |
259,984 | 18.08.2020 23:50:22 | 0 | 733d013f979a2107fd866ff3c05249c3e8ba5102 | Implement FUSE_READLINK
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -483,3 +483,14 @@ func (r *FUSESymLinkIn) MarshalUnsafe(buf []byte) {\nfunc (r *FUSESymLinkIn) SizeBytes() int {\nreturn len(r.Name) + len(r.Target) + 2\n}\n+\n+// FUSEEmptyIn is used by ... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_READLINK
Fixes #3316 |
259,984 | 18.08.2020 22:45:47 | 0 | 4d26c9929de31cdfe3551d4b8be90a07f98fed55 | Implement FUSE_MKDIR
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -494,3 +494,41 @@ func (r *FUSEEmptyIn) MarshalUnsafe(buf []byte) {}\nfunc (r *FUSEEmptyIn) SizeBytes() int {\nreturn 0\n}\n+\n+// FUSEMkdirMeta contains all the static fields of FUSEMkdi... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_MKDIR
Fixes #3392 |
260,022 | 11.08.2020 12:13:01 | 14,400 | bc07df88878f47a496f8b364b286bf0b11c0e76f | Implement FUSE_RMDIR
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -569,3 +569,29 @@ func (r *FUSEMkdirIn) MarshalUnsafe(buf []byte) {\nfunc (r *FUSEMkdirIn) SizeBytes() int {\nreturn r.MkdirMeta.SizeBytes() + len(r.Name) + 1\n}\n+\n+// FUSERmDirIn is th... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_RMDIR
Fixes #3587
Co-authored-by: Craig Chi <craigchi@google.com> |
260,022 | 27.07.2020 14:42:31 | 14,400 | 4a5857d644ae0e62090bbbed86852dceca79395c | fuse: Implement IterDirents for directory file description
Fixes
This change adds support for IterDirents. You can now use `ls` in
the FUSE sandbox. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "package linux\n-import \"gvisor.dev/gvisor/tools/go_marshal/marshal\"\n+import (\n+ \"gvisor.dev/gvisor/tools/go_marshal/marshal\"\n+ \"gvisor.dev/gvisor/tools/go_marshal/primitive\"\n+)\n//... | Go | Apache License 2.0 | google/gvisor | fuse: Implement IterDirents for directory file description
Fixes #3255.
This change adds support for IterDirents. You can now use `ls` in
the FUSE sandbox.
Co-authored-by: Craig Chi <craigchi@google.com> |
260,022 | 19.08.2020 20:11:59 | 14,400 | d51ddcefdc46a1007f7345bfa2f7006bb820b157 | fuse: use safe go_marshal API for FUSE
Until is resolved, this change is needed to ensure we're not
corrupting memory anywhere. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -359,7 +359,12 @@ type FUSELookupIn struct {\n// MarshalUnsafe serializes r.name to the dst buffer.\nfunc (r *FUSELookupIn) MarshalUnsafe(buf []byte) {\n- copy(buf, []byte(r.Name))\n+ cop... | Go | Apache License 2.0 | google/gvisor | fuse: use safe go_marshal API for FUSE
Until #3698 is resolved, this change is needed to ensure we're not
corrupting memory anywhere. |
259,983 | 19.08.2020 22:12:15 | 25,200 | 21cac9dd042f3446258387378a743b8a7cd76443 | Fix FUSE_READDIR offset issue
According to readdir(3), the offset attribute in struct dirent is the
offset to the next dirent instead of the offset of itself. Send the
successive FUSE_READDIR requests with the offset retrieved from the last
entry.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/directory.go",
"new_path": "pkg/sentry/fsimpl/fuse/directory.go",
"diff": "@@ -87,7 +87,7 @@ func (dir *directoryFD) IterDirents(ctx context.Context, callback vfs.IterDirent\n}\nfor _, fuseDirent := range out.Dirents {\n- nextOff := int6... | Go | Apache License 2.0 | google/gvisor | Fix FUSE_READDIR offset issue
According to readdir(3), the offset attribute in struct dirent is the
offset to the next dirent instead of the offset of itself. Send the
successive FUSE_READDIR requests with the offset retrieved from the last
entry.
Updates #3255 |
259,983 | 20.08.2020 10:40:41 | 25,200 | 983e30c01616b40348735f894d42bbad204f6b99 | Implementing inode.Getlink
kernfs uses inode.Getlink to resolve symlink when look up paths.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"new_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"diff": "@@ -488,6 +488,12 @@ func (i *inode) newEntry(ctx context.Context, name string, fileType linux.FileMo\nreturn child.VFSDentry(), nil\n}\n+// Getlink implements Inode.Ge... | Go | Apache License 2.0 | google/gvisor | Implementing inode.Getlink
kernfs uses inode.Getlink to resolve symlink when look up paths.
Updates #3452 |
259,983 | 20.08.2020 12:31:52 | 25,200 | 449986264f9277c4c6174fc82294fc6644923e8b | Support multiple FUSE kernel versions of FUSE_INIT response struct
The fuse_init_out struct changes in different FUSE kernel versions. A
FUSE server may implement older versions of fuse_init_out, but they
share common attributes from the beginning. Implement variable-length
marshallable interface to support older versions of ABI.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "package linux\nimport (\n+ \"gvisor.dev/gvisor/pkg/usermem\"\n\"gvisor.dev/gvisor/tools/go_marshal/marshal\"\n\"gvisor.dev/gvisor/tools/go_marshal/primitive\"\n)\n@@ -262,6 +263,63 @@ type F... | Go | Apache License 2.0 | google/gvisor | Support multiple FUSE kernel versions of FUSE_INIT response struct
The fuse_init_out struct changes in different FUSE kernel versions. A
FUSE server may implement older versions of fuse_init_out, but they
share common attributes from the beginning. Implement variable-length
marshallable interface to support older versions of ABI.
Fixes #3707 |
259,983 | 02.09.2020 13:30:56 | 25,200 | 1d8029022e8ca45e177e36405506d42874f125e9 | fuse: remove unused marshalling functions
This commit removes unused marshalling functions in linux abi package
and moves self-defined FUSEInitRes wrapper to fuse package.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "package linux\nimport (\n- \"gvisor.dev/gvisor/pkg/usermem\"\n\"gvisor.dev/gvisor/tools/go_marshal/marshal\"\n\"gvisor.dev/gvisor/tools/go_marshal/primitive\"\n)\n@@ -263,63 +262,6 @@ type F... | Go | Apache License 2.0 | google/gvisor | fuse: remove unused marshalling functions
This commit removes unused marshalling functions in linux abi package
and moves self-defined FUSEInitRes wrapper to fuse package.
Updates #3707 |
259,913 | 02.09.2020 13:50:31 | 25,200 | e91c026672b9022d5554e20202648d322da0fe1d | Downgrade FUSE minor version support and clarify comments | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -151,6 +151,7 @@ type FUSEWriteIn struct {\n}\n// FUSE_INIT flags, consistent with the ones in include/uapi/linux/fuse.h.\n+// Our taget version is 7.23 but we have few implemented in adv... | Go | Apache License 2.0 | google/gvisor | Downgrade FUSE minor version support and clarify comments |
259,913 | 02.09.2020 13:55:08 | 25,200 | 7ed4e46a717ece014a962e4b9cacff1ff4c461f1 | FUSE device: clean up readLocked
This change removes the unnecessary loop and avoids
the recursive call. It also fixes minor bugs in this
function. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/dev.go",
"new_path": "pkg/sentry/fsimpl/fuse/dev.go",
"diff": "@@ -19,7 +19,6 @@ import (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n- \"gvisor.dev/gvisor/pkg/log\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel\"\n... | Go | Apache License 2.0 | google/gvisor | FUSE device: clean up readLocked
This change removes the unnecessary loop and avoids
the recursive call. It also fixes minor bugs in this
function. |
259,983 | 03.09.2020 14:06:59 | 25,200 | 18f1e1c91b05059c333197a2a6198716c12508e7 | Implement FUSE_CREATE
FUSE_CREATE is called when issuing creat(2) or open(2) with O_CREAT. It
creates a new file on the FUSE filesystem.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -445,6 +445,48 @@ type FUSEReleaseIn struct {\nLockOwner uint64\n}\n+// FUSECreateMeta contains all the static fields of FUSECreateIn,\n+// which is used for FUSE_CREATE.\n+//\n+// +marsh... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_CREATE
FUSE_CREATE is called when issuing creat(2) or open(2) with O_CREAT. It
creates a new file on the FUSE filesystem.
Fixes #3825 |
259,913 | 01.09.2020 01:49:57 | 0 | 98faed55e682cf34bb713c37b063a7d1da5e8352 | Implement FUSE_WRITE
This commit adds basic write(2) support for FUSE. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -124,32 +124,6 @@ type FUSEHeaderOut struct {\nUnique FUSEOpID\n}\n-// FUSEWriteIn is the header written by a daemon when it makes a\n-// write request to the FUSE filesystem.\n-//\n-// +... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_WRITE
This commit adds basic write(2) support for FUSE. |
259,983 | 28.08.2020 11:25:19 | 25,200 | e63abd82ddfbaeb35c1dfc7c553db3d78207b037 | Add default attr in fuse_util
fuse_util provides utilities for fuse testing. Add a function to return
a stub fuse_attr struct with specified mode and nodeid. | [
{
"change_type": "MODIFY",
"old_path": "test/fuse/linux/stat_test.cc",
"new_path": "test/fuse/linux/stat_test.cc",
"diff": "@@ -45,26 +45,7 @@ class StatTest : public FuseTest {\nTEST_F(StatTest, StatNormal) {\n// Set up fixture.\nmode_t expected_mode = S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOT... | Go | Apache License 2.0 | google/gvisor | Add default attr in fuse_util
fuse_util provides utilities for fuse testing. Add a function to return
a stub fuse_attr struct with specified mode and nodeid. |
259,983 | 08.09.2020 14:32:02 | 25,200 | 1146ab6bac7c4d34a9b78a6c318db3dae8150b4d | Add fuse_fd_util library to include common fuse fd test functions | [
{
"change_type": "MODIFY",
"old_path": "test/fuse/linux/BUILD",
"new_path": "test/fuse/linux/BUILD",
"diff": "@@ -141,6 +141,21 @@ cc_library(\n],\n)\n+cc_library(\n+ name = \"fuse_fd_util\",\n+ testonly = 1,\n+ srcs = [\"fuse_fd_util.cc\"],\n+ hdrs = [\"fuse_fd_util.h\"],\n+ deps = [\n+ gtest,\n+ \... | Go | Apache License 2.0 | google/gvisor | Add fuse_fd_util library to include common fuse fd test functions |
259,983 | 09.09.2020 09:16:09 | 25,200 | 4181e8c97482a3c787c2b508e6d75a21323ba515 | Add fh support for revise attr and fstat(2) test
According to Linux 4.4's FUSE behavior, the flags and fh attributes in
FUSE_GETATTR are only used in read, write, and lseek. fstat(2) doesn't
use them either. Add tests to ensure the requests sent from FUSE module
are consistent with Linux's.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -227,6 +227,11 @@ type FUSEInitOut struct {\n_ [8]uint32\n}\n+// FUSE_GETATTR_FH is currently the only flag of FUSEGetAttrIn.GetAttrFlags.\n+// If it is set, the file handle (FUSEGetAttrI... | Go | Apache License 2.0 | google/gvisor | Add fh support for revise attr and fstat(2) test
According to Linux 4.4's FUSE behavior, the flags and fh attributes in
FUSE_GETATTR are only used in read, write, and lseek. fstat(2) doesn't
use them either. Add tests to ensure the requests sent from FUSE module
are consistent with Linux's.
Updates #3655 |
259,983 | 09.09.2020 10:44:09 | 25,200 | bf8efe8cdf4b6af50ec89cda37342cf51c8b50b4 | Implement FUSE_SETATTR
This commit implements FUSE_SETATTR command. When a system call modifies
the metadata of a regular file or a folder by chown(2), chmod(2),
truncate(2), utime(2), or utimes(2), they should be translated to
corresponding FUSE_SETATTR command and sent to the FUSE server.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -749,3 +749,70 @@ func (r *FUSEDirent) UnmarshalBytes(src []byte) {\nname.UnmarshalBytes(src[:r.Meta.NameLen])\nr.Name = string(name)\n}\n+\n+// FATTR_* consts are the attribute flags def... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_SETATTR
This commit implements FUSE_SETATTR command. When a system call modifies
the metadata of a regular file or a folder by chown(2), chmod(2),
truncate(2), utime(2), or utimes(2), they should be translated to
corresponding FUSE_SETATTR command and sent to the FUSE server.
Fixes #3332 |
259,983 | 09.09.2020 13:10:56 | 25,200 | 2fbbe3b76864bc5b42f05d84166008b25e599bdb | Add comments for exported attributes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -252,21 +252,51 @@ type FUSEGetAttrIn struct {\n//\n// +marshal\ntype FUSEAttr struct {\n+ // Ino is the inode number of this file.\nIno uint64\n+\n+ // Size is the size of this file.\nSi... | Go | Apache License 2.0 | google/gvisor | Add comments for exported attributes |
259,913 | 03.09.2020 19:16:17 | 0 | 826a685a95bec32286688035922a56faf622e87e | Improve FUSE async/noreply call logic
This change adds bookkeeping variables for the
FUSE request. With them, old insecure confusing
code we used to process async requests is replaced
by new clear compiling ones. Future code can take
advantage of them to have better control of each
requests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection.go",
"diff": "package fuse\nimport (\n- \"errors\"\n\"sync\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -201,42 +200,40 @@ func newFUSEConnection(_ context.Context, fd *vfs.Fil... | Go | Apache License 2.0 | google/gvisor | Improve FUSE async/noreply call logic
This change adds bookkeeping variables for the
FUSE request. With them, old insecure confusing
code we used to process async requests is replaced
by new clear compiling ones. Future code can take
advantage of them to have better control of each
requests. |
259,913 | 03.09.2020 19:22:24 | 0 | 4edc56d3e99b161f2f3311bc22a51012bf0a90ee | Fix FUSE_RELEASE protocol reply processing
This commit fixes the potential unexpected errors
of original handling of FUSE_RELEASE responses while
keep the same behavior (ignoring any reply). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/dev.go",
"new_path": "pkg/sentry/fsimpl/fuse/dev.go",
"diff": "@@ -204,8 +204,11 @@ func (fd *DeviceFD) readLocked(ctx context.Context, dst usermem.IOSequence, opts\n// Fully done with this req, remove it from the queue.\nfd.queue.Remove... | Go | Apache License 2.0 | google/gvisor | Fix FUSE_RELEASE protocol reply processing
This commit fixes the potential unexpected errors
of original handling of FUSE_RELEASE responses while
keep the same behavior (ignoring any reply). |
259,913 | 09.09.2020 16:22:33 | 25,200 | d459bb3372384a4d16fe0d9791847285449dc184 | Add FUSE umount support
This change implements Release for the FUSE filesystem
and expected behaviors of the FUSE devices.
It includes several checks for aborted connection
in the path for making a request and a function
to abort all the ongoing FUSE requests in order. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/BUILD",
"new_path": "pkg/sentry/fsimpl/fuse/BUILD",
"diff": "@@ -66,7 +66,11 @@ go_library(\ngo_test(\nname = \"fuse_test\",\nsize = \"small\",\n- srcs = [\"dev_test.go\"],\n+ srcs = [\n+ \"connection_test.go\",\n+ \"dev_test.go\",\n+ \"... | Go | Apache License 2.0 | google/gvisor | Add FUSE umount support
This change implements Release for the FUSE filesystem
and expected behaviors of the FUSE devices.
It includes several checks for aborted connection
in the path for making a request and a function
to abort all the ongoing FUSE requests in order. |
259,983 | 09.09.2020 16:44:35 | 25,200 | 70cfea23776189575807f6aae28769bdfaa1e3fb | Fix comments of TODO issues. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -663,7 +663,7 @@ func (r *FUSEMkdirIn) SizeBytes() int {\ntype FUSERmDirIn struct {\nmarshal.StubMarshallable\n- // Name is a directory name to be looked up.\n+ // Name is a directory nam... | Go | Apache License 2.0 | google/gvisor | Fix comments of TODO issues. |
259,984 | 09.09.2020 17:13:18 | 25,200 | 2051260e8286b25ab39f3c1cb4614005236cbcc6 | Implement FUSE_UNLINK
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -846,3 +846,26 @@ type FUSESetAttrIn struct {\n_ uint32\n}\n+\n+// FUSEUnlinkIn is the request sent by the kernel to the daemon\n+// when trying to unlink a node.\n+//\n+// Dynamically-si... | Go | Apache License 2.0 | google/gvisor | Implement FUSE_UNLINK
Fixes #3696 |
259,983 | 09.09.2020 16:30:25 | 25,200 | dd103527298375edd3e14600ac762c9a3103ac37 | Unexport fusefs.inode.nodeID | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection.go",
"diff": "@@ -47,7 +47,7 @@ const (\ntype connection struct {\nfd *DeviceFD\n- // mu protect access to struct memebers.\n+ // mu protects access to struct memebers.\nmu s... | Go | Apache License 2.0 | google/gvisor | Unexport fusefs.inode.nodeID |
260,004 | 16.09.2020 12:19:06 | 25,200 | 87c5c0ad2568215675391f6fb7fe335bcae06173 | Receive broadcast packets on interested endpoints
When a broadcast packet is received by the stack, the packet should be
delivered to each endpoint that may be interested in the packet. This
includes all any address and specified broadcast address listeners.
Test: integration_test.TestReuseAddrAndBroadcast | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/transport_demuxer.go",
"new_path": "pkg/tcpip/stack/transport_demuxer.go",
"diff": "@@ -165,7 +165,7 @@ func (epsByNIC *endpointsByNIC) handlePacket(r *Route, id TransportEndpointID, p\n// If this is a broadcast or multicast datagram, deliver t... | Go | Apache License 2.0 | google/gvisor | Receive broadcast packets on interested endpoints
When a broadcast packet is received by the stack, the packet should be
delivered to each endpoint that may be interested in the packet. This
includes all any address and specified broadcast address listeners.
Test: integration_test.TestReuseAddrAndBroadcast
PiperOrigin-RevId: 332060652 |
259,913 | 14.09.2020 21:30:51 | 0 | 093b0ab6c57d83407704e31005c5c446cf51a5f1 | Fix FUSE go unit test merge conflict mistake | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/dev_test.go",
"new_path": "pkg/sentry/fsimpl/fuse/dev_test.go",
"diff": "@@ -16,12 +16,10 @@ package fuse\nimport (\n\"fmt\"\n- \"io\"\n\"math/rand\"\n\"testing\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n- \"gvisor.dev/gvisor/pkg/marshal\"\... | Go | Apache License 2.0 | google/gvisor | Fix FUSE go unit test merge conflict mistake |
259,913 | 14.09.2020 21:54:18 | 0 | 113928754c26ea3d4d7d387bae459ce447774d30 | Fix FUSE unit test after vfs interface change | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/utils_test.go",
"new_path": "pkg/sentry/fsimpl/fuse/utils_test.go",
"diff": "@@ -41,7 +41,7 @@ func setup(t *testing.T) *testutil.System {\nAllowUserMount: true,\n})\n- mntns, err := k.VFS().NewMountNamespace(ctx, creds, \"\", \"tmpfs\",... | Go | Apache License 2.0 | google/gvisor | Fix FUSE unit test after vfs interface change |
259,853 | 15.09.2020 13:31:40 | 25,200 | 92a020c798fe237fb7038f3da71f24c5a88bb744 | fuse: fix a compile time error
readdir_test.cc:134:24: error: variable length arrays are a C99 feature [-Werror,-Wvla-extension]
char readdir_payload[readdir_payload_size]; | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/file_description_impl_util.go",
"new_path": "pkg/sentry/vfs/file_description_impl_util.go",
"diff": "@@ -107,7 +107,7 @@ func (FileDescriptionDefaultImpl) Write(ctx context.Context, src usermem.IOSeque\n// file_operations::iterate == file_operat... | Go | Apache License 2.0 | google/gvisor | fuse: fix a compile time error
readdir_test.cc:134:24: error: variable length arrays are a C99 feature [-Werror,-Wvla-extension]
char readdir_payload[readdir_payload_size]; |
259,853 | 15.09.2020 13:51:18 | 25,200 | 3ea925a423ed2c195498fac63b200b8a1a302f4c | fuse: don't pass lock by value
copylocks: directory.go:34:7: Allocate passes lock by value:
fuse/fuse.directoryFD contains fuse/fuse.fileDescription contains
pkg/sentry/vfs/vfs.FileDescription contains pkg/sync/sync.Mutex | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/directory.go",
"new_path": "pkg/sentry/fsimpl/fuse/directory.go",
"diff": "@@ -31,27 +31,27 @@ type directoryFD struct {\n}\n// Allocate implements directoryFD.Allocate.\n-func (directoryFD) Allocate(ctx context.Context, mode, offset, le... | Go | Apache License 2.0 | google/gvisor | fuse: don't pass lock by value
copylocks: directory.go:34:7: Allocate passes lock by value:
fuse/fuse.directoryFD contains fuse/fuse.fileDescription contains
pkg/sentry/vfs/vfs.FileDescription contains pkg/sync/sync.Mutex |
259,913 | 14.09.2020 23:16:56 | 0 | 96fb1e60c355b330eaf42db3a14a828befe73db9 | Fix FUSE connection control lock ordering and race in unit test | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection_control.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection_control.go",
"diff": "@@ -95,6 +95,8 @@ func (conn *connection) InitSend(creds *auth.Credentials, pid uint32) error {\n}\n// InitRecv receives a FUSE_INIT reply and p... | Go | Apache License 2.0 | google/gvisor | Fix FUSE connection control lock ordering and race in unit test |
259,853 | 15.09.2020 14:25:31 | 25,200 | 99fca1bf9af0c3fb851bd4c6bf7d16d9c9e44458 | test/fuse: clean up | [
{
"change_type": "MODIFY",
"old_path": "test/util/fuse_util.cc",
"new_path": "test/util/fuse_util.cc",
"diff": "@@ -57,7 +57,7 @@ fuse_entry_out DefaultEntryOut(mode_t mode, uint64_t node_id, uint64_t size) {\n.attr = DefaultFuseAttr(mode, node_id, size),\n};\nreturn default_entry_out;\n-};\n+}\n} /... | Go | Apache License 2.0 | google/gvisor | test/fuse: clean up |
259,913 | 16.09.2020 01:34:28 | 0 | 26879c32b8b48b6c066f1a5ba2c787e7061dabae | FUSE readdir test fix ino initialization | [
{
"change_type": "MODIFY",
"old_path": "test/fuse/linux/readdir_test.cc",
"new_path": "test/fuse/linux/readdir_test.cc",
"diff": "@@ -41,13 +41,14 @@ namespace {\nclass ReaddirTest : public FuseTest {\npublic:\n- void fill_fuse_dirent(char *buf, const char *name) {\n+ void fill_fuse_dirent(char *buf... | Go | Apache License 2.0 | google/gvisor | FUSE readdir test fix ino initialization |
259,913 | 16.09.2020 17:39:55 | 0 | 70cf503b4c3653df8253438a8873a5d3ebb688e3 | fuse: fix FUSE_RELEASE reply handling
fix | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection.go",
"diff": "@@ -110,7 +110,7 @@ type connection struct {\n//\n// We call the \"background\" requests in unix term as async requests.\n// The \"async requests\" in unix term... | Go | Apache License 2.0 | google/gvisor | fuse: fix FUSE_RELEASE reply handling
fix #3963 |
259,913 | 16.09.2020 17:44:06 | 0 | c4c302a27e5811ce04bb904686e657c9ed830a44 | fuse: fix data race in fusefs Release()
fix | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection_control.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection_control.go",
"diff": "@@ -189,10 +189,9 @@ func (conn *connection) initProcessReply(out *linux.FUSEInitOut, hasSysAdminCap\n// Abort this FUSE connection.\n// It trie... | Go | Apache License 2.0 | google/gvisor | fuse: fix data race in fusefs Release()
fix #3956 |
259,907 | 16.09.2020 13:46:32 | 25,200 | 0356c7ef32dfcc05b1f5e7f242a022883a9ba816 | [runtime tests] Add documentation.
Added a README describing what these tests are, how they work and how to run
them locally. Also reorganized the exclude files into a directory. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/BUILD",
"new_path": "test/runtimes/BUILD",
"diff": "@@ -5,7 +5,7 @@ package(licenses = [\"notice\"])\nruntime_test(\nname = \"go1.12\",\n- exclude_file = \"exclude_go1.12.csv\",\n+ exclude_file = \"exclude/go1.12.csv\",\nlang = \"go\",\nshard_cou... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Add documentation.
Added a README describing what these tests are, how they work and how to run
them locally. Also reorganized the exclude files into a directory.
PiperOrigin-RevId: 332079697 |
260,003 | 16.09.2020 14:10:58 | 25,200 | 666397c5c82ee18a776491919312d19cfe6d4a07 | Gracefully translate unknown errno.
Neither POSIX.1 nor Linux defines an upperbound for errno. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/rawfile/BUILD",
"new_path": "pkg/tcpip/link/rawfile/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\npackage(licenses = [\"notice\"])\n@@ -18,3 +18,14 @@ go_library(\n\"@org_... | Go | Apache License 2.0 | google/gvisor | Gracefully translate unknown errno.
Neither POSIX.1 nor Linux defines an upperbound for errno.
PiperOrigin-RevId: 332085017 |
260,001 | 16.09.2020 14:43:37 | 25,200 | 3749e70a693007b706fb06529ab95d910a251ba6 | Implement PRead for verity fs
PRead is implemented by read from the underlying file in blocks, and
verify each block. The verified contents are saved into the output
buffer. | [
{
"change_type": "MODIFY",
"old_path": "pkg/merkletree/merkletree.go",
"new_path": "pkg/merkletree/merkletree.go",
"diff": "@@ -225,9 +225,9 @@ func Generate(data io.ReadSeeker, dataSize int64, treeReader io.ReadSeeker, tree\n// Verify will modify the cursor for data, but always restores it to its\n... | Go | Apache License 2.0 | google/gvisor | Implement PRead for verity fs
PRead is implemented by read from the underlying file in blocks, and
verify each block. The verified contents are saved into the output
buffer.
PiperOrigin-RevId: 332092267 |
260,001 | 16.09.2020 16:41:32 | 25,200 | 286830855552efb223afa500fbcfa532f33121c5 | Implement OpenAt() for verity fs
OpenAt() for verity fs is implemented by opening both the target file or
directory and the corresponding Merkle tree file in the underlying file
system. Generally they are only open for read. In allowRuntimeEnable
mode, the Merkle tree file is also open for write. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"fmt\"\n\"io\"\n\"strconv\"\n+ \"strings\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n@@ -556,8 +... | Go | Apache License 2.0 | google/gvisor | Implement OpenAt() for verity fs
OpenAt() for verity fs is implemented by opening both the target file or
directory and the corresponding Merkle tree file in the underlying file
system. Generally they are only open for read. In allowRuntimeEnable
mode, the Merkle tree file is also open for write.
PiperOrigin-RevId: 332116423 |
259,992 | 17.09.2020 01:07:55 | 25,200 | a11061d78a58ed75b10606d1a770b035ed944b66 | Add VFS2 overlay support in runsc
All tests under runsc are passing with overlay enabled.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -27,6 +27,7 @@ go_library(\n\"//pkg/abi\",\n\"//pkg/abi/linux\",\n\"//pkg/bpf\",\n+ \"//pkg/cleanup\",\n\"//pkg/context\",\n\"//pkg/control/server\",\n\"//pkg/cpuid\",\n"
},
{
"change_type"... | Go | Apache License 2.0 | google/gvisor | Add VFS2 overlay support in runsc
All tests under runsc are passing with overlay enabled.
Updates #1487, #1199
PiperOrigin-RevId: 332181267 |
259,885 | 17.09.2020 11:50:54 | 25,200 | 51a2fe8eb4f045383e67093e3f3fa0b5fac8e9ac | Disable nodejs12.4 test async-hooks/test-statwatcher. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude/nodejs12.4.0.csv",
"new_path": "test/runtimes/exclude/nodejs12.4.0.csv",
"diff": "test name,bug id,comment\n+async-hooks/test-statwatcher.js,https://github.com/nodejs/node/issues/21425,Check for fix inclusion in nodejs releases after 2020... | Go | Apache License 2.0 | google/gvisor | Disable nodejs12.4 test async-hooks/test-statwatcher.
PiperOrigin-RevId: 332281912 |
259,885 | 17.09.2020 11:50:59 | 25,200 | f0b1bd434eb00a0f13cbbc141078a95ba0bc15a4 | Deflake vdso_clock_gettime test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/vdso_clock_gettime.cc",
"new_path": "test/syscalls/linux/vdso_clock_gettime.cc",
"diff": "@@ -38,8 +38,6 @@ std::string PrintClockId(::testing::TestParamInfo<clockid_t> info) {\nswitch (info.param) {\ncase CLOCK_MONOTONIC:\nreturn \"CLOCK_M... | Go | Apache License 2.0 | google/gvisor | Deflake vdso_clock_gettime test.
PiperOrigin-RevId: 332281930 |
259,992 | 17.09.2020 11:55:54 | 25,200 | da07e38f7c986dca568466beea8a0b7db60f09db | Remove option to panic gofer
Gofer panics are suppressed by p9 server and an error
is returned to the caller, making it effectively the
same as returning EROFS. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -62,7 +62,6 @@ type Gofer struct {\napplyCaps bool\nsetUpRoot bool\n- panicOnWrite bool\nspecFD int\nmountsFD int\n}\n@@ -87,7 +86,6 @@ func (g *Gofer) SetFlags(f *flag.FlagSet) {\nf.StringVar(... | Go | Apache License 2.0 | google/gvisor | Remove option to panic gofer
Gofer panics are suppressed by p9 server and an error
is returned to the caller, making it effectively the
same as returning EROFS.
PiperOrigin-RevId: 332282959 |
259,907 | 17.09.2020 12:08:46 | 25,200 | d796b100ecfe529e350575655b972400c52390d7 | Provide testing container with docker config file.
This is needed by test/e2e/integration_test:TestCheckpointRestore to check for
filesystem versioning. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -31,6 +31,7 @@ DOCKER_PRIVILEGED ?= --privileged\nBAZEL_CACHE := $(shell readlink -m ~/.cache/bazel/)\nGCLOUD_CONFIG := $(shell readlink -m ~/.config/gcloud/)\nDOCKER_SOCKET := /var/run/docker.sock\n+D... | Go | Apache License 2.0 | google/gvisor | Provide testing container with docker config file.
This is needed by test/e2e/integration_test:TestCheckpointRestore to check for
filesystem versioning.
PiperOrigin-RevId: 332285566 |
259,913 | 16.09.2020 22:46:33 | 0 | 15f50c8da63486ac0f24cbb6c2891b66a8081c05 | Fix kernfs unlinkat and rmdirat incorrect resolved path name | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -658,9 +658,6 @@ func (fs *Filesystem) RmdirAt(ctx context.Context, rp *vfs.ResolvingPath) error\nfs.mu.Lock()\ndefer fs.mu.Unlock()\n- // Store the name... | Go | Apache License 2.0 | google/gvisor | Fix kernfs unlinkat and rmdirat incorrect resolved path name |
259,962 | 17.09.2020 15:14:01 | 25,200 | a4db85fff210f0f4f2164f0d620c6cfdc288e26c | Return ENOPROTOOPT for all SOL_PACKET options.
This is required to make tcpdump work. tcpdump falls back to not using things
like PACKET_RX_RING if setsockopt returns ENOPROTOOPT. This used to be the case
before
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1768,10 +1768,16 @@ func SetSockOpt(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, level int\ncase linux.SOL_IP:\nreturn setSockOptIP(t, s, ep, ... | Go | Apache License 2.0 | google/gvisor | Return ENOPROTOOPT for all SOL_PACKET options.
This is required to make tcpdump work. tcpdump falls back to not using things
like PACKET_RX_RING if setsockopt returns ENOPROTOOPT. This used to be the case
before https://github.com/google/gvisor/commit/6f8fb7e0db2790ff1f5ba835780c03fe245e437f.
Fixes #3981
PiperOrigin-RevId: 332326517 |
259,860 | 17.09.2020 15:36:40 | 25,200 | 319d1b8ba0604e7bc029f98ae0e9b09badd5abad | Complete vfs2 implementation of fallocate.
This change includes overlay, special regular gofer files, and hostfs.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1026,7 +1026,7 @@ func (d *dentry) open(ctx context.Context, rp *vfs.ResolvingPath, opts *vfs.Open\n// step is required even if !d.cachedMetadataAuthorita... | Go | Apache License 2.0 | google/gvisor | Complete vfs2 implementation of fallocate.
This change includes overlay, special regular gofer files, and hostfs.
Fixes #3589.
PiperOrigin-RevId: 332330860 |
260,001 | 17.09.2020 16:27:01 | 25,200 | f1f844daabdacf46f6237ddf0a90c370dbe2348a | Set mode when creating Merkle tree file | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -372,6 +372,7 @@ func (fs *filesystem) lookupAndVerifyLocked(ctx context.Context, parent *dentry,\nPath: fspath.Parse(childMerkleFilename),\n}, &vfs.Open... | Go | Apache License 2.0 | google/gvisor | Set mode when creating Merkle tree file
PiperOrigin-RevId: 332340342 |
260,001 | 17.09.2020 17:42:58 | 25,200 | 1e8beb5f1d925ed0c30a2b810fc2a0bffbd3cf58 | Change sizeofInt32 to string size
This constant is used to represent int32 stored in file xattrs. The
integers are stored as strings there, so the real size should be the
string size (number of digits) instead of an int size (4 bytes). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -185,8 +185,7 @@ func (fs *filesystem) verifyChild(ctx context.Context, parent *dentry, child *de\nStart: child.lowerMerkleVD,\n}, &vfs.GetXattrOptions{\... | Go | Apache License 2.0 | google/gvisor | Change sizeofInt32 to string size
This constant is used to represent int32 stored in file xattrs. The
integers are stored as strings there, so the real size should be the
string size (number of digits) instead of an int size (4 bytes).
PiperOrigin-RevId: 332353217 |
259,907 | 17.09.2020 18:25:20 | 25,200 | c0b74be54c336f53ff3596acad2c57330a63c6b1 | Fix root tests target in Makefile. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -129,10 +129,9 @@ tests: unit-tests\n@$(call submake,test TARGETS=\"test/syscalls/...\")\n.PHONY: tests\n-\nintegration-tests: ## Run all standard integration tests.\nintegration-tests: docker-tests overlay-tests ... | Go | Apache License 2.0 | google/gvisor | Fix root tests target in Makefile.
PiperOrigin-RevId: 332358833 |
259,896 | 17.09.2020 19:58:27 | 25,200 | d34bda027309695e3e6fb6f92a5839cd1f21173e | {Set,Get} SO_LINGER on all endpoints.
SO_LINGER is a socket level option and should be stored on all endpoints even
though it is used to linger only for TCP endpoints. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1185,7 +1185,7 @@ func getSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, fam\nvar v tcpip.LingerOption\nvar linger linux.Linger\ni... | Go | Apache License 2.0 | google/gvisor | {Set,Get} SO_LINGER on all endpoints.
SO_LINGER is a socket level option and should be stored on all endpoints even
though it is used to linger only for TCP endpoints.
PiperOrigin-RevId: 332369252 |
259,891 | 17.09.2020 22:48:47 | 25,200 | 2fbd31e726c5d7bcdd44f0498e73124807052d59 | Test IPv4 WritePackets stats
IPv6 tests will be added in another CL along with ip6tables. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"diff": "@@ -1046,3 +1046,211 @@ func TestReceiveFragments(t *testing.T) {\n})\n}\n}\n+\n+func TestWritePacketsStats(t *testing.T) {\n+ const nPackets = 3\n+ tests := []st... | Go | Apache License 2.0 | google/gvisor | Test IPv4 WritePackets stats
IPv6 tests will be added in another CL along with ip6tables.
PiperOrigin-RevId: 332389102 |
259,985 | 17.09.2020 23:35:43 | 25,200 | 07d832dbb539e0bcca74800d09d0ea607d8173a3 | fuse.DeviceFD needs to hold a reference on the associated filesystem.
This fixes a use-after-free in fuse.DeviceFD.Release. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/dev.go",
"new_path": "pkg/sentry/fsimpl/fuse/dev.go",
"diff": "@@ -95,9 +95,14 @@ type DeviceFD struct {\n}\n// Release implements vfs.FileDescriptionImpl.Release.\n-func (fd *DeviceFD) Release(context.Context) {\n+func (fd *DeviceFD) Re... | Go | Apache License 2.0 | google/gvisor | fuse.DeviceFD needs to hold a reference on the associated filesystem.
This fixes a use-after-free in fuse.DeviceFD.Release.
PiperOrigin-RevId: 332394146 |
260,004 | 18.09.2020 00:46:26 | 25,200 | 360006d894247ba78771d1244d5b849dabe3ce5a | Use common parsing utilities when sniffing
Extract parsing utilities so they can be used by the sniffer.
Fixes | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/tcpip/header/parse/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"parse\",\n+ srcs = [\"parse.go\"],\n+ visibility = [\"//visibility:public\"],\n+ deps = [\n+ \... | Go | Apache License 2.0 | google/gvisor | Use common parsing utilities when sniffing
Extract parsing utilities so they can be used by the sniffer.
Fixes #3930
PiperOrigin-RevId: 332401880 |
259,881 | 18.09.2020 09:54:00 | 25,200 | 313e1988c4609c74ada99c1a5e9ecde56c313125 | Drop ARCH_GET_FS
Go does not call arch_prctl(ARCH_GET_FS), nor am I sure it ever did. Drop the
filter. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config_amd64.go",
"new_path": "runsc/boot/filter/config_amd64.go",
"diff": "@@ -25,7 +25,6 @@ import (\nfunc init() {\nallowedSyscalls[syscall.SYS_ARCH_PRCTL] = append(allowedSyscalls[syscall.SYS_ARCH_PRCTL],\n- seccomp.Rule{seccomp.EqualTo(l... | Go | Apache License 2.0 | google/gvisor | Drop ARCH_GET_FS
Go does not call arch_prctl(ARCH_GET_FS), nor am I sure it ever did. Drop the
filter.
PiperOrigin-RevId: 332470532 |
259,992 | 18.09.2020 10:25:52 | 25,200 | 93fd164fa24e1f70e4c69fc2edfb0d4961a6683b | Add "Containing a Real Vulnerability" blog post | [
{
"change_type": "MODIFY",
"old_path": "images/jekyll/build.sh",
"new_path": "images/jekyll/build.sh",
"diff": "@@ -18,4 +18,5 @@ set -euxo pipefail\n# Generate the syntax highlighting css file.\n/usr/gem/bin/rougify style github >/input/_sass/syntax.css\n-/usr/gem/bin/jekyll build -t -s /input -d /... | Go | Apache License 2.0 | google/gvisor | Add "Containing a Real Vulnerability" blog post
PiperOrigin-RevId: 332477119 |
260,023 | 18.09.2020 10:47:52 | 25,200 | fcf8d7c6ddac1146cf0d48f833c982cbfb0991e5 | Enqueue TCP sends arriving in SYN_SENT state.
TCP needs to enqueue any send requests arriving when the connection is in
SYN_SENT state. The data should be sent out soon after completion of the
connection handshake.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1317,14 +1317,17 @@ func (e *endpoint) readLocked() (buffer.View, *tcpip.Error) {\n// indicating the reason why it's not writable.\n// Caller must hold e.mu a... | Go | Apache License 2.0 | google/gvisor | Enqueue TCP sends arriving in SYN_SENT state.
TCP needs to enqueue any send requests arriving when the connection is in
SYN_SENT state. The data should be sent out soon after completion of the
connection handshake.
Fixes #3995
PiperOrigin-RevId: 332482041 |
259,891 | 18.09.2020 11:06:53 | 25,200 | bd69afdcd1c9303602aadce9e59aecff3eb7b9c8 | Count packets dropped by iptables in IPStats | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -158,6 +158,9 @@ var Metrics = tcpip.Stats{\nOutgoingPacketErrors: mustCreateMetric(\"/netstack/ip/outgoing_packet_errors\", \"Total number of IP packets... | Go | Apache License 2.0 | google/gvisor | Count packets dropped by iptables in IPStats
PiperOrigin-RevId: 332486383 |
259,992 | 18.09.2020 11:19:04 | 25,200 | ddf37cb19f373ae47836db97349013081cc857b4 | Reduce the number of steps to get started with gVisor
Streamline instruction for the common case. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/FAQ.md",
"new_path": "g3doc/user_guide/FAQ.md",
"diff": "@@ -74,11 +74,10 @@ directories.\n### I'm getting an error like: `panic: unable to attach: operation not permitted` or `fork/exec /proc/self/exe: invalid argument: unknown` {#runsc-perms... | Go | Apache License 2.0 | google/gvisor | Reduce the number of steps to get started with gVisor
Streamline instruction for the common case.
PiperOrigin-RevId: 332488910 |
259,891 | 18.09.2020 12:19:02 | 25,200 | f911b43f05f88807a1e36adc6ab3b7c8cf8ec2ee | Remove SKIP_IF for now-supported features.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/ip6tables.cc",
"new_path": "test/syscalls/linux/ip6tables.cc",
"diff": "@@ -87,8 +87,6 @@ TEST(IP6TablesBasic, GetEntriesErrorPrecedence) {\n// empty when running in native, but we can test that gVisor has the same\n// initial state that a ... | Go | Apache License 2.0 | google/gvisor | Remove SKIP_IF for now-supported features.
Updates #3549.
PiperOrigin-RevId: 332501660 |
259,913 | 17.09.2020 23:27:16 | 0 | 9a06a1a1603f549808f842b658e5d13a0934916d | fuse: update design doc with I/O implementation | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/g3doc/fuse.md",
"new_path": "pkg/sentry/fs/g3doc/fuse.md",
"diff": "@@ -79,7 +79,7 @@ ops can be implemented in parallel.\n- Implement `/dev/fuse` - a character device used to establish an FD for\ncommunication between the sentry and the server d... | Go | Apache License 2.0 | google/gvisor | fuse: update design doc with I/O implementation |
259,885 | 18.09.2020 13:23:41 | 25,200 | ca4ecf481d617edfae22a5735a657d60186392e1 | Use a tmpfs file for shared anonymous and /dev/zero mmap on VFS2.
This is more consistent with Linux (see comment on MM.NewSharedAnonMappable()).
We don't do the same thing on VFS1 for reasons documented by the updated
comment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/devices/memdev/BUILD",
"new_path": "pkg/sentry/devices/memdev/BUILD",
"diff": "@@ -18,9 +18,10 @@ go_library(\n\"//pkg/rand\",\n\"//pkg/safemem\",\n\"//pkg/sentry/fsimpl/devtmpfs\",\n+ \"//pkg/sentry/fsimpl/tmpfs\",\n+ \"//pkg/sentry/kernel\",\n+ \"... | Go | Apache License 2.0 | google/gvisor | Use a tmpfs file for shared anonymous and /dev/zero mmap on VFS2.
This is more consistent with Linux (see comment on MM.NewSharedAnonMappable()).
We don't do the same thing on VFS1 for reasons documented by the updated
comment.
PiperOrigin-RevId: 332514849 |
259,885 | 18.09.2020 15:27:29 | 25,200 | c23e39f419f2dbdb67920fed1828399a5ac2479b | Implement fsimpl/overlay.filesystem.RenameAt.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1311,6 +1311,9 @@ func (fs *filesystem) RenameAt(ctx context.Context, rp *vfs.ResolvingPath, oldPa\nif !renamed.isDir() {\nreturn syserror.EISDIR\n}\n+ if... | Go | Apache License 2.0 | google/gvisor | Implement fsimpl/overlay.filesystem.RenameAt.
Updates #1199
PiperOrigin-RevId: 332539197 |
259,885 | 18.09.2020 20:51:56 | 25,200 | 916751039cca927a0e64b4e6f776d2d4732cf8d8 | Disable vdso_clock_gettime on KVM.
Unfortunately, I think TSC misalignment means that we can't really expect any
consistent correspondence between a TSC-based VDSO and the sentry's view of
time on the KVM platform. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/vdso_clock_gettime.cc",
"new_path": "test/syscalls/linux/vdso_clock_gettime.cc",
"diff": "@@ -48,6 +48,11 @@ std::string PrintClockId(::testing::TestParamInfo<clockid_t> info) {\nclass MonotonicVDSOClockTest : public ::testing::TestWithPara... | Go | Apache License 2.0 | google/gvisor | Disable vdso_clock_gettime on KVM.
Unfortunately, I think TSC misalignment means that we can't really expect any
consistent correspondence between a TSC-based VDSO and the sentry's view of
time on the KVM platform.
PiperOrigin-RevId: 332576147 |
259,975 | 21.09.2020 10:03:32 | 25,200 | 5ce58829515b7534a2a01210e1a18f1b200727e4 | Fix flakes in UdpSocketTest
`recv` calls with MSG_DONTWAIT can fail with EAGAIN randomly
in tests. Fix this by calling `select` on sockets with a timeout
prior to attempting a `recv`. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_test_util.cc",
"new_path": "test/syscalls/linux/socket_test_util.cc",
"diff": "@@ -753,6 +753,19 @@ PosixErrorOr<int> SendMsg(int sock, msghdr* msg, char buf[], int buf_size) {\nreturn ret;\n}\n+PosixErrorOr<int> RecvMsgTimeout(int s... | Go | Apache License 2.0 | google/gvisor | Fix flakes in UdpSocketTest
`recv` calls with MSG_DONTWAIT can fail with EAGAIN randomly
in tests. Fix this by calling `select` on sockets with a timeout
prior to attempting a `recv`.
PiperOrigin-RevId: 332873735 |
259,907 | 21.09.2020 10:25:41 | 25,200 | e09d78f016ecbada5784324925b3c6b18041a2ec | Port fuse tests to Makefile. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -121,8 +121,13 @@ smoke-tests: ## Runs a simple smoke test after build runsc.\n@$(call submake,run DOCKER_PRIVILEGED=\"\" ARGS=\"--alsologtostderr --network none --debug --TESTONLY-unsafe-nonroot=true --rootless d... | Go | Apache License 2.0 | google/gvisor | Port fuse tests to Makefile.
PiperOrigin-RevId: 332878900 |
259,860 | 21.09.2020 12:29:00 | 25,200 | d72022373f8ab2ca60ec1494858a3cb3e2be9040 | Add ftruncate test for writeable fd but no write permissions. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/truncate.cc",
"new_path": "test/syscalls/linux/truncate.cc",
"diff": "@@ -196,6 +196,26 @@ TEST(TruncateTest, FtruncateNonWriteable) {\nEXPECT_THAT(ftruncate(fd.get(), 0), SyscallFailsWithErrno(EINVAL));\n}\n+// ftruncate(2) should succeed ... | Go | Apache License 2.0 | google/gvisor | Add ftruncate test for writeable fd but no write permissions.
PiperOrigin-RevId: 332907453 |
259,975 | 21.09.2020 12:44:26 | 25,200 | a129204cf508b170a62c93ed7148453f346b32e4 | Fix proc_net_test_native for native tests.
"DefaultValueEqZero" is only valid if the test is in a
sandbox. Our CI VMs often have "/proc/sys/net/ipv4/ip_forward" set
to 1. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc_net.cc",
"new_path": "test/syscalls/linux/proc_net.cc",
"diff": "@@ -522,6 +522,9 @@ TEST(ProcSysNetIpv4IpForward, Exists) {\n}\nTEST(ProcSysNetIpv4IpForward, DefaultValueEqZero) {\n+ // Test is only valid in sandbox. Not hermetic in n... | Go | Apache License 2.0 | google/gvisor | Fix proc_net_test_native for native tests.
"DefaultValueEqZero" is only valid if the test is in a
sandbox. Our CI VMs often have "/proc/sys/net/ipv4/ip_forward" set
to 1.
PiperOrigin-RevId: 332910859 |
259,860 | 21.09.2020 14:46:51 | 25,200 | 10dcefbc77815314d56e45f01b8c9986a2c56778 | Use kernfs.Dentry for kernfs.Lookup.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devpts/devpts.go",
"new_path": "pkg/sentry/fsimpl/devpts/devpts.go",
"diff": "@@ -198,7 +198,7 @@ func (i *rootInode) Open(ctx context.Context, rp *vfs.ResolvingPath, vfsd *vfs.D\n}\n// Lookup implements kernfs.Inode.Lookup.\n-func (i *rootIn... | Go | Apache License 2.0 | google/gvisor | Use kernfs.Dentry for kernfs.Lookup.
Updates #1193.
PiperOrigin-RevId: 332939026 |
259,975 | 21.09.2020 15:04:13 | 25,200 | 06dbd5b7bcd8ff16d73c38bdeac4677698385a65 | Fix socket_ipv4_udp_unbound_test_native in opensource.
Calls to recv sometimes fail with EAGAIN, so call select beforehand. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -2413,6 +2413,7 @@ cc_library(\n\":socket_test_util\",\n\"@com_google_absl//absl/memory\",\ngtest,\n+ \"//test/util:posix_error\",\n\"//test/util:test_util\",\n],\nalwayslink = 1,... | Go | Apache License 2.0 | google/gvisor | Fix socket_ipv4_udp_unbound_test_native in opensource.
Calls to recv sometimes fail with EAGAIN, so call select beforehand.
PiperOrigin-RevId: 332943156 |
260,004 | 21.09.2020 16:32:41 | 25,200 | 059d90b9f1c52e6aed259ba7ac4847de297273c6 | Receive ACK when deleting address in syscall tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_netlink_route_util.cc",
"new_path": "test/syscalls/linux/socket_netlink_route_util.cc",
"diff": "@@ -42,7 +42,7 @@ PosixError PopulateNlmsghdr(LinkAddrModification modification,\nreturn NoError();\ncase LinkAddrModification::kDelete:... | Go | Apache License 2.0 | google/gvisor | Receive ACK when deleting address in syscall tests
PiperOrigin-RevId: 332961666 |
259,860 | 21.09.2020 23:42:47 | 25,200 | 742e58b873dbb8d3c14b2e40f212df90ec837671 | Allow partial writes for gofer.specialFileFD.
Originally, we avoided partial writes in case it caused us to write a partial
packet to a socket-backed specialFileFD. However, this check causes splicing
from a pipe to specialFileFD to fail if we hit EOF on the pipe. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"diff": "@@ -246,11 +246,12 @@ func (fd *specialFileFD) pwrite(ctx context.Context, src usermem.IOSequence, off\nd.touchCMtime()\n}\nbuf := make([]byte, src.NumByt... | Go | Apache License 2.0 | google/gvisor | Allow partial writes for gofer.specialFileFD.
Originally, we avoided partial writes in case it caused us to write a partial
packet to a socket-backed specialFileFD. However, this check causes splicing
from a pipe to specialFileFD to fail if we hit EOF on the pipe.
PiperOrigin-RevId: 333016216 |
260,021 | 22.09.2020 15:52:41 | -28,800 | a38f1d145797b307afc34985533f3b9208eacc7d | arm64: set SCTLR_UCI bit in SCTLR_EL1
some application such as openjdk will excute
DC CVAU at el0, if SCTLR_UCI is not set, it
will trap to EL1 which will cause panic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/entry_arm64.s",
"new_path": "pkg/sentry/platform/ring0/entry_arm64.s",
"diff": "#define SCTLR_C 1 << 2\n#define SCTLR_I 1 << 12\n#define SCTLR_UCT 1 << 15\n+#define SCTLR_UCI 1 << 26\n-#define SCTLR_EL1_DEFAULT (SCTLR_M | SCTLR_C | SC... | Go | Apache License 2.0 | google/gvisor | arm64: set SCTLR_UCI bit in SCTLR_EL1
some application such as openjdk will excute
DC CVAU at el0, if SCTLR_UCI is not set, it
will trap to EL1 which will cause panic.
Signed-off-by: Min Le <lemin.lm@antgroup.com> |
259,881 | 22.09.2020 08:38:53 | 25,200 | f134f873fc75f941405de7d0e046852a38795bec | Force clone parent_tidptr and child_tidptr to zero
Neither CLONE_PARENT_SETTID nor CLONE_CHILD_SETTID are used, so these arguments
will always be NULL. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -27,17 +27,6 @@ import (\n// allowedSyscalls is the set of syscalls executed by the Sentry to the host OS.\nvar allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_CLOCK_GETT... | Go | Apache License 2.0 | google/gvisor | Force clone parent_tidptr and child_tidptr to zero
Neither CLONE_PARENT_SETTID nor CLONE_CHILD_SETTID are used, so these arguments
will always be NULL.
PiperOrigin-RevId: 333085326 |
259,881 | 22.09.2020 09:56:06 | 25,200 | 13a9a622e13ccdda76ed02d3de99b565212f6b2f | Allow CLONE_SETTLS for Go 1.16
switches the Go runtime (on amd64)
from using arch_prctl(ARCH_SET_FS) to CLONE_SETTLS to set the TLS. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config_amd64.go",
"new_path": "runsc/boot/filter/config_amd64.go",
"diff": "@@ -25,6 +25,7 @@ import (\nfunc init() {\nallowedSyscalls[syscall.SYS_ARCH_PRCTL] = []seccomp.Rule{\n+ // TODO(b/168828518): No longer used in Go 1.16+.\n{seccomp.Eq... | Go | Apache License 2.0 | google/gvisor | Allow CLONE_SETTLS for Go 1.16
https://go.googlesource.com/go/+/0941fc3 switches the Go runtime (on amd64)
from using arch_prctl(ARCH_SET_FS) to CLONE_SETTLS to set the TLS.
PiperOrigin-RevId: 333100550 |
259,964 | 22.09.2020 12:43:28 | 25,200 | 6e5ea605f4ca9fb8c29adc9510edc980f844ddfc | Move stack.fakeClock into a separate package | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/tcpip/faketime/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"faketime\",\n+ srcs = [\"faketime.go\"],\n+ visibility = [\"//visibility:public\"],\n... | Go | Apache License 2.0 | google/gvisor | Move stack.fakeClock into a separate package
PiperOrigin-RevId: 333138701 |
259,992 | 22.09.2020 13:43:02 | 25,200 | 778c367171f96c6cfd269cd2363c9f608dd96bcb | Fix panic in `runsc flags`
When printing flags, FlagSet.PrintDefaults compares the Zero
value to the flag default value. The Zero refs.LeakMode value
was panicking in String() because it didn't expect the default
to be used
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -257,6 +257,8 @@ func (l *LeakMode) Get() interface{} {\n// String implements flag.Value.\nfunc (l *LeakMode) String() string {\nswitch *l {\n+ case UninitializedLeakChecking:\n+ return... | Go | Apache License 2.0 | google/gvisor | Fix panic in `runsc flags`
When printing flags, FlagSet.PrintDefaults compares the Zero
value to the flag default value. The Zero refs.LeakMode value
was panicking in String() because it didn't expect the default
to be used
Closes #4023
PiperOrigin-RevId: 333150836 |
259,951 | 22.09.2020 15:04:11 | 25,200 | cf3cef1171bdfb41a27d563eb368d4488e0b99f1 | Refactor testutil.TestEndpoint and use it instead of limitedEP
The new testutil.MockLinkEndpoint implementation is not composed by
channel.Channel anymore because none of its features were used. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"diff": "@@ -17,6 +17,7 @@ package ipv4_test\nimport (\n\"bytes\"\n\"encoding/hex\"\n+ \"math\"\n\"testing\"\n\"github.com/google/go-cmp/cmp\"\n@@ -160,47 +161,6 @@ func c... | Go | Apache License 2.0 | google/gvisor | Refactor testutil.TestEndpoint and use it instead of limitedEP
The new testutil.MockLinkEndpoint implementation is not composed by
channel.Channel anymore because none of its features were used.
PiperOrigin-RevId: 333167753 |
259,860 | 22.09.2020 22:29:28 | 25,200 | b54dbdfdc6b6cbdb6f45cd2abd9efb1f2f821a20 | Handle EOF properly in splice/sendfile.
Use HandleIOErrorVFS2 instead of custom error handling. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/pipe.go",
"new_path": "pkg/sentry/kernel/pipe/pipe.go",
"diff": "@@ -17,6 +17,7 @@ package pipe\nimport (\n\"fmt\"\n+ \"io\"\n\"sync/atomic\"\n\"syscall\"\n@@ -215,7 +216,7 @@ func (p *Pipe) readLocked(ctx context.Context, ops readOps) (... | Go | Apache License 2.0 | google/gvisor | Handle EOF properly in splice/sendfile.
Use HandleIOErrorVFS2 instead of custom error handling.
PiperOrigin-RevId: 333227581 |
259,898 | 23.09.2020 16:49:33 | 25,200 | c3c66ea428c8f56ff64e415961035feffef718f3 | Clean up flag.* usage in packetimpact's runner.RegisterFlags | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/dut.go",
"new_path": "test/packetimpact/runner/dut.go",
"diff": "@@ -69,8 +69,8 @@ func RegisterFlags(fs *flag.FlagSet) {\nfs.BoolVar(&native, \"native\", false, \"whether the test should be run natively\")\nfs.StringVar(&testbenchBina... | Go | Apache License 2.0 | google/gvisor | Clean up flag.* usage in packetimpact's runner.RegisterFlags
PiperOrigin-RevId: 333400865 |
260,001 | 23.09.2020 17:10:43 | 25,200 | 994062ec9ca70110c39d9c004cad62e23d4c7a41 | Set verity underlying fs mount as internal | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -159,6 +159,7 @@ func (fstype FilesystemType) GetFilesystem(ctx context.Context, vfsObj *vfs.Virt\n// verity, and should not be exposed or connected.\nmopts := &... | Go | Apache License 2.0 | google/gvisor | Set verity underlying fs mount as internal
PiperOrigin-RevId: 333404727 |
260,004 | 23.09.2020 17:13:32 | 25,200 | e02e7e999a65d4cb7784e67de74fb4ffa556b386 | Remove unused field from neighborEntry | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_entry.go",
"new_path": "pkg/tcpip/stack/neighbor_entry.go",
"diff": "@@ -74,7 +74,6 @@ type neighborEntry struct {\nneighborEntryEntry\nnic *NIC\n- protocol tcpip.NetworkProtocolNumber\n// linkRes provides the functionality to send rea... | Go | Apache License 2.0 | google/gvisor | Remove unused field from neighborEntry
PiperOrigin-RevId: 333405169 |
260,001 | 23.09.2020 18:03:21 | 25,200 | 9c8a6796fd88fbcffad1dd3fa80c301ec425fcbf | Let underlying fs handle LockFD in verity fs | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -677,10 +677,10 @@ func (fd *fileDescription) PRead(ctx context.Context, dst usermem.IOSequence, of\n// LockPOSIX implements vfs.FileDescriptionImpl.LockPOSIX.\n... | Go | Apache License 2.0 | google/gvisor | Let underlying fs handle LockFD in verity fs
PiperOrigin-RevId: 333412836 |
259,907 | 23.09.2020 18:43:16 | 25,200 | 08bbad690764dd55e333cade340d779df93de920 | [vfs] kernfs: Enable leak checking consistently.
There were some instances where we were not enabling leak checking. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"new_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"diff": "@@ -280,6 +280,7 @@ func (fs *filesystem) newRootInode(creds *auth.Credentials, mode linux.FileMode)\ni := &inode{fs: fs}\ni.InodeAttrs.Init(creds, linux.UNNAMED_MAJOR,... | Go | Apache License 2.0 | google/gvisor | [vfs] kernfs: Enable leak checking consistently.
There were some instances where we were not enabling leak checking.
PiperOrigin-RevId: 333418571 |
259,860 | 23.09.2020 22:40:10 | 25,200 | 6410e74a9602ecb92813375f45b953ab813cf313 | Add more descriptive comments on mount options. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/filesystem_type.go",
"new_path": "pkg/sentry/vfs/filesystem_type.go",
"diff": "@@ -56,9 +56,10 @@ type registeredFilesystemType struct {\n// RegisterFilesystemTypeOptions contains options to\n// VirtualFilesystem.RegisterFilesystem().\ntype Regi... | Go | Apache License 2.0 | google/gvisor | Add more descriptive comments on mount options.
PiperOrigin-RevId: 333447255 |
259,860 | 23.09.2020 23:00:27 | 25,200 | 03898a087d8858f7a006f3eda649a18b02949d80 | Clean up inotify tests.
Mostly simplifies SKIP_IF statements and adds some more documentation.
Also, mknod is now supported by gofer fs, so remove SKIP_IFs related to this. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/inotify.cc",
"new_path": "test/syscalls/linux/inotify.cc",
"diff": "@@ -465,7 +465,9 @@ TEST(Inotify, ConcurrentFileDeletionAndWatchRemoval) {\nfor (int i = 0; i < 100; ++i) {\nFileDescriptor file_fd =\nASSERT_NO_ERRNO_AND_VALUE(Open(filena... | Go | Apache License 2.0 | google/gvisor | Clean up inotify tests.
Mostly simplifies SKIP_IF statements and adds some more documentation.
Also, mknod is now supported by gofer fs, so remove SKIP_IFs related to this.
PiperOrigin-RevId: 333449932 |
259,905 | 24.09.2020 14:16:12 | -28,800 | 332e1716fc93e3f2ffe6961d3c296503d2079bc8 | Rename kernel.SocketEntry to kernel.SocketRecord
SocketEntry can be confusing with the template types as the 'Entry'
is usually used as a suffix for list element types, e.g. socketEntry
in the same package. Suggested by Dean (@dean-deng). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -69,8 +69,8 @@ go_template_instance(\nprefix = \"socket\",\ntemplate = \"//pkg/ilist:generic_list\",\ntypes = {\n- \"Element\": \"*SocketEntry\",\n- \"Linker\": \"*SocketEntry\",\n+ \... | Go | Apache License 2.0 | google/gvisor | Rename kernel.SocketEntry to kernel.SocketRecord
SocketEntry can be confusing with the template types as the 'Entry'
is usually used as a suffix for list element types, e.g. socketEntry
in the same package. Suggested by Dean (@dean-deng).
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> |
259,905 | 24.09.2020 14:16:12 | -28,800 | 71f8cab91b2005c9e3ab904e3a2cba99cb031230 | Fix socket record leak in VFS2
VFS2 socket record is not removed from the system-wide
socket table when the socket is released, which will lead
to a memory leak. This patch fixes this issue.
Fixes: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -69,8 +69,8 @@ go_template_instance(\nprefix = \"socket\",\ntemplate = \"//pkg/ilist:generic_list\",\ntypes = {\n- \"Element\": \"*SocketRecord\",\n- \"Linker\": \"*SocketRecord\",\n+... | Go | Apache License 2.0 | google/gvisor | Fix socket record leak in VFS2
VFS2 socket record is not removed from the system-wide
socket table when the socket is released, which will lead
to a memory leak. This patch fixes this issue.
Fixes: #3874
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> |
259,853 | 23.09.2020 23:32:46 | 25,200 | 3838e83a9844f1ebeafab50e33df588480986927 | fuse: don't call dentry.InsertChild
It is called from the kernfs code (OpenAt and revalidateChildLocked()).
For RemoveChildLocked, it is opposed. We need to call it from fuse.RmDir and
fuse.Unlink. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"new_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"diff": "@@ -528,12 +528,7 @@ func (i *inode) RmDir(ctx context.Context, name string, child *vfs.Dentry) error\nreturn err\n}\n- // TODO(Before merging): When creating new nodes... | Go | Apache License 2.0 | google/gvisor | fuse: don't call dentry.InsertChild
It is called from the kernfs code (OpenAt and revalidateChildLocked()).
For RemoveChildLocked, it is opposed. We need to call it from fuse.RmDir and
fuse.Unlink.
PiperOrigin-RevId: 333453218 |
259,853 | 24.09.2020 00:47:01 | 25,200 | 0a232a5e8c846406f2fcc985d2223c8021bbef8c | test/syscall/mknod: Don't use a hard-coded file name | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mknod.cc",
"new_path": "test/syscalls/linux/mknod.cc",
"diff": "@@ -105,11 +105,13 @@ TEST(MknodTest, UnimplementedTypesReturnError) {\n}\nTEST(MknodTest, Socket) {\n+ SKIP_IF(IsRunningOnGvisor() && IsRunningWithVFS1());\n+\nASSERT_THAT(chd... | Go | Apache License 2.0 | google/gvisor | test/syscall/mknod: Don't use a hard-coded file name
PiperOrigin-RevId: 333461380 |
259,975 | 24.09.2020 10:29:59 | 25,200 | c3fc69022afdbc1085c9b122a084168afa25cb80 | Fix Nginx Startup and Size Benchmarks.
Changes in Nginx Benchmarks in network_tests also affect Startup/Size
Nginx Benchmarks. Make sure the commands line up. | [
{
"change_type": "MODIFY",
"old_path": "images/benchmarks/nginx/Dockerfile",
"new_path": "images/benchmarks/nginx/Dockerfile",
"diff": "@@ -9,3 +9,4 @@ RUN mkdir -p /local && \\\nRUN touch /local/index.html\nCOPY ./nginx.conf /etc/nginx/nginx.conf\n+COPY ./nginx_gofer.conf /etc/nginx/nginx_gofer.con... | Go | Apache License 2.0 | google/gvisor | Fix Nginx Startup and Size Benchmarks.
Changes in Nginx Benchmarks in network_tests also affect Startup/Size
Nginx Benchmarks. Make sure the commands line up.
PiperOrigin-RevId: 333543697 |
259,907 | 24.09.2020 13:44:25 | 25,200 | 832d91b8058c3c716c648701cf93095dd3157541 | [vfs] kernfs: Do not hold reference on the inode when opening FD.
The FD should hold a reference on the dentry they were opened on which in turn
holds a reference on the inode it points to. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devpts/master.go",
"new_path": "pkg/sentry/fsimpl/devpts/master.go",
"diff": "@@ -58,14 +58,12 @@ func (mi *masterInode) Open(ctx context.Context, rp *vfs.ResolvingPath, d *kernf\nreturn nil, err\n}\n- mi.IncRef()\nfd := &masterFileDescriptio... | Go | Apache License 2.0 | google/gvisor | [vfs] kernfs: Do not hold reference on the inode when opening FD.
The FD should hold a reference on the dentry they were opened on which in turn
holds a reference on the inode it points to.
PiperOrigin-RevId: 333589223 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.