author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,962 | 25.09.2020 19:32:38 | 25,200 | ebc81fadfc6797758d63f8290ad3a9c2659ddb49 | Add openat() to list of permitted syscalls in gotsan runs. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/extra_filters_race.go",
"new_path": "runsc/fsgofer/filter/extra_filters_race.go",
"diff": "@@ -35,6 +35,7 @@ func instrumentationFilters() seccomp.SyscallRules {\nsyscall.SYS_MUNLOCK: {},\nsyscall.SYS_NANOSLEEP: {},\nsyscall.SYS_OPEN: {},\... | Go | Apache License 2.0 | google/gvisor | Add openat() to list of permitted syscalls in gotsan runs.
PiperOrigin-RevId: 333853498 |
259,860 | 28.09.2020 16:09:27 | 25,200 | a0e0ba690f3f4946890010e12084db7f081d5bc7 | Support inotify in overlayfs.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1416,11 +1416,11 @@ func (fs *filesystem) SetStatAt(ctx context.Context, rp *vfs.ResolvingPath, opts\nfs.renameMuRUnlockAndCheckCaching(ctx, &ds)\nreturn ... | Go | Apache License 2.0 | google/gvisor | Support inotify in overlayfs.
Fixes #1479, #317.
PiperOrigin-RevId: 334258052 |
259,896 | 28.09.2020 16:37:44 | 25,200 | 237b761f9a61ad1a821320e68f5a71e7cda6b29e | Fix lingering of TCP socket in the initial state.
When the socket is set with SO_LINGER and close()'d in the initial state, it
should not linger and return immediately. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -927,7 +927,12 @@ func (e *endpoint) Readiness(mask waiter.EventMask) waiter.EventMask {\nresult := waiter.EventMask(0)\nswitch e.EndpointState() {\n- case Sta... | Go | Apache License 2.0 | google/gvisor | Fix lingering of TCP socket in the initial state.
When the socket is set with SO_LINGER and close()'d in the initial state, it
should not linger and return immediately.
PiperOrigin-RevId: 334263149 |
259,885 | 28.09.2020 16:38:39 | 25,200 | ba44298a390c69dcf33ae591b9ddc6b3514cc9b3 | Don't leak dentries returned by sockfs.NewDentry(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket_vfs2.go",
"new_path": "pkg/sentry/socket/hostinet/socket_vfs2.go",
"diff": "@@ -52,6 +52,7 @@ var _ = socket.SocketVFS2(&socketVFS2{})\nfunc newVFS2Socket(t *kernel.Task, family int, stype linux.SockType, protocol int, fd int,... | Go | Apache License 2.0 | google/gvisor | Don't leak dentries returned by sockfs.NewDentry().
PiperOrigin-RevId: 334263322 |
259,964 | 29.09.2020 11:27:43 | 25,200 | f15182243e508b0754d59350a886397e2a0ba0b2 | Discard IP fragments as soon as it expires
Currently expired IP fragments are discarded only if another fragment for the
same IP datagram is received after timeout or the total size of the fragment
queue exceeded a predefined value.
Test: fragmentation.TestReassemblingTimeout
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/faketime/faketime.go",
"new_path": "pkg/tcpip/faketime/faketime.go",
"diff": "@@ -24,6 +24,26 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip\"\n)\n+// NullClock implements a clock that never advances.\n+type NullClock struct{}\n+\n+var _ tcpip.Clock = (*... | Go | Apache License 2.0 | google/gvisor | Discard IP fragments as soon as it expires
Currently expired IP fragments are discarded only if another fragment for the
same IP datagram is received after timeout or the total size of the fragment
queue exceeded a predefined value.
Test: fragmentation.TestReassemblingTimeout
Fixes #3960
PiperOrigin-RevId: 334423710 |
259,985 | 29.09.2020 12:32:32 | 25,200 | 44c7d550747a61baa6a85643de439fa45c2b9633 | Support embedded fields in go-marshal. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/README.md",
"new_path": "tools/go_marshal/README.md",
"diff": "@@ -113,3 +113,18 @@ The following are some guidelines for modifying the `go_marshal` tool:\n- No runtime reflection in the code generated for the marshallable interface.\nThe enti... | Go | Apache License 2.0 | google/gvisor | Support embedded fields in go-marshal.
PiperOrigin-RevId: 334437990 |
260,004 | 29.09.2020 13:44:03 | 25,200 | 1d88bce55e0c8ef77e31863d264b896493dce90f | Don't generate link-local IPv6 for loopback
Linux doesn't generate a link-local address for the loopback interface.
Test: integration_test.TestInitialLoopbackAddresses | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ipv6.go",
"new_path": "pkg/tcpip/network/ipv6/ipv6.go",
"diff": "@@ -258,7 +258,7 @@ func (e *endpoint) Enable() *tcpip.Error {\n}\n// Do not auto-generate an IPv6 link-local address for loopback devices.\n- if e.protocol.autoGenIPv6Link... | Go | Apache License 2.0 | google/gvisor | Don't generate link-local IPv6 for loopback
Linux doesn't generate a link-local address for the loopback interface.
Test: integration_test.TestInitialLoopbackAddresses
PiperOrigin-RevId: 334453182 |
259,992 | 29.09.2020 15:47:25 | 25,200 | 4a428b13b20baf055e7e70ecb51a87299f0c6d8e | Add /proc/[pid]/cwd | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -84,6 +84,7 @@ func (p *proc) newTaskDir(t *kernel.Task, msrc *fs.MountSource, isThreadGroup bo\n\"auxv\": newAuxvec(t, msrc),\n\"cmdline\": newExecArgInode(t, msrc, cmdlineExec... | Go | Apache License 2.0 | google/gvisor | Add /proc/[pid]/cwd
PiperOrigin-RevId: 334478850 |
259,858 | 29.09.2020 18:33:11 | 25,200 | d4d9238c52ee8eae127f566f1119d915fb6c1a00 | Stop depending on go_binary targets.
Closes | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/proctor/BUILD",
"new_path": "test/runtimes/proctor/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_binary\", \"go_test\")\n+load(\"//tools:defs.bzl\", \"go_binary\")\npackage(licenses = [\"notice\"])\ngo_binary(\nname = \"proctor\",\n- srcs = [... | Go | Apache License 2.0 | google/gvisor | Stop depending on go_binary targets.
Closes #3374
PiperOrigin-RevId: 334505627 |
260,004 | 29.09.2020 19:44:42 | 25,200 | e5ece9aea730c105ab336e6bd2858322686a5708 | Return permanent addresses when NIC is down
Test: stack_test.TestGetMainNICAddressWhenNICDisabled | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -595,6 +595,13 @@ func (e *endpoint) RemovePermanentAddress(addr tcpip.Address) *tcpip.Error {\nreturn e.mu.addressableEndpointState.RemovePermanentAddress(addr)\n}\n+//... | Go | Apache License 2.0 | google/gvisor | Return permanent addresses when NIC is down
Test: stack_test.TestGetMainNICAddressWhenNICDisabled
PiperOrigin-RevId: 334513286 |
259,891 | 29.09.2020 22:39:37 | 25,200 | 0aae51c6e09046e56f2d4b6064124da059731286 | iptables: remove unused min/max NAT range fields | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/targets.go",
"new_path": "pkg/sentry/socket/netfilter/targets.go",
"diff": "@@ -194,11 +194,9 @@ func (*redirectTargetMaker) marshal(target stack.Target) []byte {\nret := make([]byte, 0, linux.SizeOfXTRedirectTarget)\nxt.NfRange.Ran... | Go | Apache License 2.0 | google/gvisor | iptables: remove unused min/max NAT range fields
PiperOrigin-RevId: 334531794 |
259,891 | 29.09.2020 23:20:08 | 25,200 | 3ef549b67f83fdbc1c7aa30c2b8531f38419461e | Set transport protocol number during parsing | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/parse/parse.go",
"new_path": "pkg/tcpip/header/parse/parse.go",
"diff": "@@ -139,6 +139,7 @@ traverseExtensions:\n// Returns true if the header was successfully parsed.\nfunc UDP(pkt *stack.PacketBuffer) bool {\n_, ok := pkt.TransportHeader().... | Go | Apache License 2.0 | google/gvisor | Set transport protocol number during parsing
PiperOrigin-RevId: 334535896 |
260,001 | 30.09.2020 11:19:16 | 25,200 | 299e5d6e4035d0792dd06562d6b495a85797db87 | Add verity fs tests
The tests confirms that when a file is opened in verity, the
corresponding Merkle trees are generated. Also a normal read succeeds on
verity enabled files, but fails if either the verity file or the Merkle
tree file is modified. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/BUILD",
"new_path": "pkg/sentry/fsimpl/verity/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\nlicenses([\"notice\"])\n@@ -26,3 +26,22 @@ go_library(\n\"//pkg/userm... | Go | Apache License 2.0 | google/gvisor | Add verity fs tests
The tests confirms that when a file is opened in verity, the
corresponding Merkle trees are generated. Also a normal read succeeds on
verity enabled files, but fails if either the verity file or the Merkle
tree file is modified.
PiperOrigin-RevId: 334640331 |
259,891 | 30.09.2020 12:21:01 | 25,200 | b49a17fc3d33068a1235d97efd8cc8bc9f0f3ccf | Make all Target.Action implementation pointer receivers | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/targets.go",
"new_path": "pkg/sentry/socket/netfilter/targets.go",
"diff": "@@ -306,7 +306,7 @@ func (jt *JumpTarget) ID() stack.TargetID {\n}\n// Action implements stack.Target.Action.\n-func (jt JumpTarget) Action(*stack.PacketBuf... | Go | Apache License 2.0 | google/gvisor | Make all Target.Action implementation pointer receivers
PiperOrigin-RevId: 334652998 |
260,001 | 30.09.2020 14:43:06 | 25,200 | 38704d9b667b9ebabc3f694a6508b37ead567b6f | Implement ioctl with measure in verity fs | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/ioctl.go",
"new_path": "pkg/abi/linux/ioctl.go",
"diff": "@@ -122,8 +122,26 @@ const (\n// Constants from uapi/linux/fsverity.h.\nconst (\nFS_IOC_ENABLE_VERITY = 1082156677\n+ FS_IOC_MEASURE_VERITY = 3221513862\n)\n+// DigestMetadata is a helper ... | Go | Apache License 2.0 | google/gvisor | Implement ioctl with measure in verity fs
PiperOrigin-RevId: 334682753 |
259,951 | 30.09.2020 15:08:00 | 25,200 | 7f9e13053e84b82c67c12a4964fa4703ebaa571f | Count IP OutgoingPacketErrors in the NetworkEndpoint methods
Before this change, OutgoingPacketErrors was incremented in the
stack.Route methods. This was going to be a problem once
IPv4/IPv6 WritePackets support fragmentation because Route.WritePackets
might now know how many packets are left after an error occurs.
Test:
- pkg/tcpip/network/ipv4:ipv4_test
- pkg/tcpip/network/ipv6:ipv6_test | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -278,6 +278,7 @@ func (e *endpoint) writePacketFragments(r *stack.Route, gso *stack.GSO, mtu int,\n// Send out the fragment.\nif err := e.linkEP.WritePacket(r, gso, Prot... | Go | Apache License 2.0 | google/gvisor | Count IP OutgoingPacketErrors in the NetworkEndpoint methods
Before this change, OutgoingPacketErrors was incremented in the
stack.Route methods. This was going to be a problem once
IPv4/IPv6 WritePackets support fragmentation because Route.WritePackets
might now know how many packets are left after an error occurs.
Test:
- pkg/tcpip/network/ipv4:ipv4_test
- pkg/tcpip/network/ipv6:ipv6_test
PiperOrigin-RevId: 334687983 |
259,891 | 30.09.2020 16:02:46 | 25,200 | 6f8d64f4229be58814319003a397b971ca9b4e1b | ip6tables: redirect support
Adds support for the IPv6-compatible redirect target. Redirection is a limited
form of DNAT, where the destination is always the localhost.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter_ipv6.go",
"new_path": "pkg/abi/linux/netfilter_ipv6.go",
"diff": "@@ -321,3 +321,16 @@ const (\n// Enable all flags.\nIP6T_INV_MASK = 0x7F\n)\n+\n+// NFNATRange corresponds to struct nf_nat_range in\n+// include/uapi/linux/netfilter/nf_... | Go | Apache License 2.0 | google/gvisor | ip6tables: redirect support
Adds support for the IPv6-compatible redirect target. Redirection is a limited
form of DNAT, where the destination is always the localhost.
Updates #3549.
PiperOrigin-RevId: 334698344 |
259,858 | 30.09.2020 17:46:56 | 25,200 | ae51aef5bb31458a98c7f27546213a7d2bdff504 | Ensure proctor is built as pure Go binary. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/proctor/BUILD",
"new_path": "test/runtimes/proctor/BUILD",
"diff": "@@ -5,6 +5,7 @@ package(licenses = [\"notice\"])\ngo_binary(\nname = \"proctor\",\nsrcs = [\"main.go\"],\n+ pure = True,\nvisibility = [\"//test/runtimes:__pkg__\"],\ndeps = [\"/... | Go | Apache License 2.0 | google/gvisor | Ensure proctor is built as pure Go binary.
PiperOrigin-RevId: 334716351 |
260,001 | 01.10.2020 22:24:29 | 25,200 | 7f39d5342873f00a6d0a89c27ed4744168fa01bc | Add a verity test for modified parent Merkle file
When a child's root hash or its Merkle path is modified in its parent's
Merkle tree file, opening the file should fail, provided the directory
is verity enabled. The test for this behavior is added. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity_test.go",
"new_path": "pkg/sentry/fsimpl/verity/verity_test.go",
"diff": "@@ -67,7 +67,7 @@ func newVerityRoot(ctx context.Context) (*vfs.VirtualFilesystem, vfs.VirtualDent\n},\n})\nif err != nil {\n- return nil, vfs.VirtualDent... | Go | Apache License 2.0 | google/gvisor | Add a verity test for modified parent Merkle file
When a child's root hash or its Merkle path is modified in its parent's
Merkle tree file, opening the file should fail, provided the directory
is verity enabled. The test for this behavior is added.
PiperOrigin-RevId: 334963690 |
259,885 | 02.10.2020 11:49:24 | 25,200 | ed94c0de51412a41e6657e23685dda876df31d15 | Actually disable nodejs test parallel/test-fs-write-stream-double-close. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude/nodejs12.4.0.csv",
"new_path": "test/runtimes/exclude/nodejs12.4.0.csv",
"diff": "@@ -13,7 +13,7 @@ parallel/test-dns-channel-timeout.js,b/161893056,\nparallel/test-fs-access.js,,\nparallel/test-fs-watchfile.js,,Flaky - File already exist... | Go | Apache License 2.0 | google/gvisor | Actually disable nodejs test parallel/test-fs-write-stream-double-close.
PiperOrigin-RevId: 335070320 |
259,985 | 02.10.2020 12:22:34 | 25,200 | 4f462b0ed9912fa19b3a3eab6d2f08a98d364574 | Convert uses of the binary package in kernel to go-marshal. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/seccomp.go",
"new_path": "pkg/abi/linux/seccomp.go",
"diff": "@@ -83,3 +83,22 @@ type SockFprog struct {\npad [6]byte\nFilter *BPFInstruction\n}\n+\n+// SeccompData is equivalent to struct seccomp_data, which contains the data\n+// passed to secc... | Go | Apache License 2.0 | google/gvisor | Convert uses of the binary package in kernel to go-marshal.
PiperOrigin-RevId: 335077195 |
259,858 | 02.10.2020 13:12:22 | 25,200 | 0cea6472188e056673fd0ab8ff06a25dbe44ca52 | Save addresses for "allowed" functions. | [
{
"change_type": "MODIFY",
"old_path": "tools/checkescape/checkescape.go",
"new_path": "tools/checkescape/checkescape.go",
"diff": "@@ -398,7 +398,37 @@ func loadObjdump() (map[string][]string, error) {\nreturn nil, err\n}\n+ // Identify calls by address or name. Note that this is also\n+ // constru... | Go | Apache License 2.0 | google/gvisor | Save addresses for "allowed" functions.
PiperOrigin-RevId: 335086850 |
259,990 | 02.10.2020 14:37:55 | 25,200 | 6321eccddce2b59976454799dcd25bc60ce5b0e8 | Treat absent "linux" section is empty "cgroupsPath" too | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -311,7 +311,10 @@ func New(conf *boot.Config, args Args) (*Container, error) {\nif isRoot(args.Spec) {\nlog.Debugf(\"Creating new sandbox for container %q\", args.ID)\n- if ... | Go | Apache License 2.0 | google/gvisor | Treat absent "linux" section is empty "cgroupsPath" too |
259,891 | 05.10.2020 15:47:30 | 25,200 | e73bb6d3029273a3adde3807a88b668380af07e9 | Remove reference to deleted script | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/README.md",
"new_path": "test/iptables/README.md",
"diff": "# iptables Tests\n-iptables tests are run via `scripts/iptables_test.sh`.\n+iptables tests are run via `make iptables-tests`.\niptables requires raw socket support, so you must add the `... | Go | Apache License 2.0 | google/gvisor | Remove reference to deleted script
PiperOrigin-RevId: 335516625 |
259,992 | 05.10.2020 15:48:06 | 25,200 | 9e9fec3a09308a5df616c86b665b848eba2ba6f7 | Enable more VFS2 tests
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/testutil/testutil.go",
"new_path": "pkg/test/testutil/testutil.go",
"diff": "@@ -270,7 +270,7 @@ func RandomID(prefix string) string {\n// same name, sometimes between test runs the socket does not get cleaned up\n// quickly enough, causing container ... | Go | Apache License 2.0 | google/gvisor | Enable more VFS2 tests
Updates #1487
PiperOrigin-RevId: 335516732 |
259,860 | 05.10.2020 19:03:04 | 25,200 | a1df7f2ed1be5cb170218c3e127a9b5f51a314fd | Simplify nil assignment in kcov. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kcov.go",
"new_path": "pkg/sentry/kernel/kcov.go",
"diff": "@@ -215,10 +215,8 @@ func (kcov *Kcov) Clear() {\nfunc (kcov *Kcov) clearLocked() {\nkcov.mode = linux.KCOV_MODE_INIT\nkcov.owningTask = nil\n- if kcov.mappable != nil {\nkcov.mappab... | Go | Apache License 2.0 | google/gvisor | Simplify nil assignment in kcov.
PiperOrigin-RevId: 335548610 |
259,860 | 06.10.2020 00:18:55 | 25,200 | a57dc67b6386c4c75ba6b9b4cee11277a8a98898 | [vfs2] Don't leak reference from Mountnamespace.Root(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsbridge/vfs.go",
"new_path": "pkg/sentry/fsbridge/vfs.go",
"diff": "@@ -122,7 +122,7 @@ func NewVFSLookup(mntns *vfs.MountNamespace, root, workingDir vfs.VirtualDentry)\n// remainingTraversals is not configurable in VFS2, all callers are using the\... | Go | Apache License 2.0 | google/gvisor | [vfs2] Don't leak reference from Mountnamespace.Root().
PiperOrigin-RevId: 335583637 |
259,990 | 06.10.2020 15:34:02 | 25,200 | a2a27eedf44303a60f580e03be617124ce35bb17 | Ignore errors in rootless and test modes | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -327,9 +327,18 @@ func New(conf *boot.Config, args Args) (*Container, error) {\nif cg != nil {\n// If there is cgroup config, install it before creating sandbox process.\nif... | Go | Apache License 2.0 | google/gvisor | Ignore errors in rootless and test modes |
259,986 | 06.10.2020 16:15:45 | 25,200 | 95cac27d0d1ca93610f1bea554e3eb67c8a907d7 | Discard invalid Neighbor Solicitations
...per RFC 4861 s7.1.1. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6.go",
"new_path": "pkg/tcpip/header/ipv6.go",
"diff": "@@ -309,14 +309,21 @@ func IsV6UnicastAddress(addr tcpip.Address) bool {\nreturn addr[0] != 0xff\n}\n+const solicitedNodeMulticastPrefix = \"\\xff\\x02\\x00\\x00\\x00\\x00\\x00\\x00\\x... | Go | Apache License 2.0 | google/gvisor | Discard invalid Neighbor Solicitations
...per RFC 4861 s7.1.1.
PiperOrigin-RevId: 335742851 |
259,860 | 07.10.2020 11:43:31 | 25,200 | 7e55ee14eb9035ed737eb7ee4ddcb0fdf40feed6 | Fix text processing in bazel build command.
The extraction of the build target was overfitted before, making build_cmd fail
in some environments. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -152,8 +152,9 @@ build_cmd = docker exec $(FULL_DOCKER_EXEC_OPTIONS) $(DOCKER_NAME) sh -o pipefai\nbuild_paths = $(build_cmd) 2>&1 \\\n| tee /proc/self/fd/2 \\\n- | grep -E \"^ bazel-bin/\" \\\n- | tr ... | Go | Apache License 2.0 | google/gvisor | Fix text processing in bazel build command.
The extraction of the build target was overfitted before, making build_cmd fail
in some environments.
PiperOrigin-RevId: 335916651 |
259,858 | 07.10.2020 12:06:20 | 25,200 | ecf9a7ef09bd5ef722a0b6438a8e9770ca904475 | Add precise synchronization to KVM.
By using TSC scaling as a hack, we can trick the kernel into setting an offset
of exactly zero. Huzzah! | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/BUILD",
"new_path": "pkg/sentry/platform/kvm/BUILD",
"diff": "@@ -79,6 +79,7 @@ go_test(\n\"//pkg/sentry/platform/kvm/testutil\",\n\"//pkg/sentry/platform/ring0\",\n\"//pkg/sentry/platform/ring0/pagetables\",\n+ \"//pkg/sentry/time\",\n... | Go | Apache License 2.0 | google/gvisor | Add precise synchronization to KVM.
By using TSC scaling as a hack, we can trick the kernel into setting an offset
of exactly zero. Huzzah!
PiperOrigin-RevId: 335922019 |
259,907 | 07.10.2020 12:30:47 | 25,200 | 85a58d110f13298cb2afcd18a79049125ea86b73 | [runtime-tests] Exclude failing test due to expired cert. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude/java11.csv",
"new_path": "test/runtimes/exclude/java11.csv",
"diff": "@@ -57,6 +57,7 @@ java/nio/channels/SocketChannel/SocketOptionTests.java,b/77965901,\njava/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java,... | Go | Apache License 2.0 | google/gvisor | [runtime-tests] Exclude failing test due to expired cert.
PiperOrigin-RevId: 335927821 |
259,951 | 08.10.2020 00:54:05 | 25,200 | 0c3134028d63774914f560d51588b11a3ecfed5e | Change IPv6 reassembly timeout to 60s
It was originally set to 30s for IPv6 (same as IPv4) but this is not
what RFC 8200 prescibes. Linux also defaults to 60s [1].
[1] | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/fragmentation/fragmentation.go",
"new_path": "pkg/tcpip/network/fragmentation/fragmentation.go",
"diff": "@@ -29,9 +29,6 @@ import (\n)\nconst (\n- // DefaultReassembleTimeout is based on the linux stack: net.ipv4.ipfrag_time.\n- DefaultReass... | Go | Apache License 2.0 | google/gvisor | Change IPv6 reassembly timeout to 60s
It was originally set to 30s for IPv6 (same as IPv4) but this is not
what RFC 8200 prescibes. Linux also defaults to 60s [1].
[1] https://github.com/torvalds/linux/blob/47ec5303d73ea344e84f46660fff693c57641386/include/net/ipv6.h#L456
PiperOrigin-RevId: 336034636 |
260,021 | 22.09.2020 16:45:10 | -28,800 | 190cf30e41cdd7b23d53d86024afeabbcd92a0db | arm64: the mair_el1 value is wrong
the correct value needed is 0xbbff440c0400 but the const
defined is 0x000000000000ffc0 due to the operator error
in _MT_EL1_INIT, both kernel and user space memory
attribute should be Normal memory not DEVICE_nGnRE | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm_const_arm64.go",
"new_path": "pkg/sentry/platform/kvm/kvm_const_arm64.go",
"diff": "@@ -107,7 +107,14 @@ const (\n_MT_NORMAL_NC = 3\n_MT_NORMAL = 4\n_MT_NORMAL_WT = 5\n- _MT_EL1_INIT = (0 << _MT_DEVICE_nGnRnE) | (0x4 << _MT_DEVICE_n... | Go | Apache License 2.0 | google/gvisor | arm64: the mair_el1 value is wrong
the correct value needed is 0xbbff440c0400 but the const
defined is 0x000000000000ffc0 due to the operator error
in _MT_EL1_INIT, both kernel and user space memory
attribute should be Normal memory not DEVICE_nGnRE
Signed-off-by: Min Le <lemin.lm@antgroup.com> |
259,858 | 08.10.2020 10:03:31 | 25,200 | 06200cb5cfd44dbd3edc221fa3f6c1a716a8c4c6 | Improve multi-arch support.
This change allows Dockerfiles named Dockerfile.$(ARCH) and makes list-images
list only supported architectures.
Updates | [
{
"change_type": "MODIFY",
"old_path": "images/Makefile",
"new_path": "images/Makefile",
"diff": "@@ -23,7 +23,7 @@ ARCH := $(shell uname -m)\n# tests are using locally-defined images (that are consistent and idempotent).\nREMOTE_IMAGE_PREFIX ?= gcr.io/gvisor-presubmit\nLOCAL_IMAGE_PREFIX ?= gvisor.... | Go | Apache License 2.0 | google/gvisor | Improve multi-arch support.
This change allows Dockerfiles named Dockerfile.$(ARCH) and makes list-images
list only supported architectures.
Updates #2847
PiperOrigin-RevId: 336108293 |
259,858 | 08.10.2020 11:22:15 | 25,200 | 5124ce579d34079d2aefd45b486e0127ed6c2917 | Minor nogo cleanup. | [
{
"change_type": "MODIFY",
"old_path": "tools/checkescape/checkescape.go",
"new_path": "tools/checkescape/checkescape.go",
"diff": "@@ -102,8 +102,8 @@ var (\n// This may be set instead of Binary.\nReader io.Reader\n- // Tool is the tool used to dump a binary.\n- tool = flag.String(\"dump_tool\", \"... | Go | Apache License 2.0 | google/gvisor | Minor nogo cleanup.
PiperOrigin-RevId: 336126583 |
260,004 | 08.10.2020 14:33:58 | 25,200 | 40269d0c24d1ea9b040a8326c9fa01b03477410a | Send unicast probes when link address is known
When the neighbor table already has link address for a neighbor but is
trying to confirm reachability, it may send unicast probes to the
neighbor. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "@@ -646,18 +646,21 @@ func (*protocol) LinkAddressProtocol() tcpip.NetworkProtocolNumber {\n// LinkAddressRequest implements stack.LinkAddressResolver.\nfunc (*protocol) Li... | Go | Apache License 2.0 | google/gvisor | Send unicast probes when link address is known
When the neighbor table already has link address for a neighbor but is
trying to confirm reachability, it may send unicast probes to the
neighbor.
PiperOrigin-RevId: 336166711 |
259,885 | 08.10.2020 16:21:14 | 25,200 | 6bad4851d4a04b5f56ade1f8ba68bd9c16471533 | Implement MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ.
cf. "rseq/membarrier: Add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ" | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/membarrier.go",
"new_path": "pkg/abi/linux/membarrier.go",
"diff": "package linux\n-// membarrier(2) commands, from include/uapi/linux/membarrier.h\n+// membarrier(2) commands, from include/uapi/linux/membarrier.h.\nconst (\nMEMBARRIER_CMD_QUERY ... | Go | Apache License 2.0 | google/gvisor | Implement MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ.
cf. 2a36ab717e8f "rseq/membarrier: Add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ"
PiperOrigin-RevId: 336186795 |
260,004 | 08.10.2020 17:32:41 | 25,200 | 07b1d7413e8b648b85fa9276a516732dd93276b4 | Only block resolution when NUD is incomplete
When a completed entry exists for a neighbor, there is no need to block
while reachability is (re)confirmed. The stack should continue to use
the neighbor's link address while NUD is performed.
Test: stack_test.TestNeighborCacheReplace | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_cache.go",
"new_path": "pkg/tcpip/stack/neighbor_cache.go",
"diff": "@@ -131,10 +131,17 @@ func (n *neighborCache) entry(remoteAddr, localAddr tcpip.Address, linkRes LinkA\ndefer entry.mu.Unlock()\nswitch s := entry.neigh.State; s {\n-... | Go | Apache License 2.0 | google/gvisor | Only block resolution when NUD is incomplete
When a completed entry exists for a neighbor, there is no need to block
while reachability is (re)confirmed. The stack should continue to use
the neighbor's link address while NUD is performed.
Test: stack_test.TestNeighborCacheReplace
PiperOrigin-RevId: 336199043 |
259,853 | 09.10.2020 10:55:30 | 25,200 | 76a09f0cf5994bae5684fc80b7e7da6161b52975 | syscalls: Don't leak a file on the error path
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_file.go",
"new_path": "pkg/sentry/syscalls/linux/sys_file.go",
"diff": "@@ -84,6 +84,7 @@ func fileOpOn(t *kernel.Task, dirFD int32, path string, resolve bool, fn func(ro\n}\nrel = f.Dirent\nif !fs.IsDir(rel.Inode.StableAttr) {\n+... | Go | Apache License 2.0 | google/gvisor | syscalls: Don't leak a file on the error path
Reported-by: syzbot+bb82fb556d5d0a43f632@syzkaller.appspotmail.com
PiperOrigin-RevId: 336324720 |
259,853 | 09.10.2020 11:28:57 | 25,200 | 33d6622172a85209f644840409d1b00ae94d609c | test/syscall/iptables: don't use designated initializers
test/syscalls/linux/iptables.cc:130:3:
error: C99 designator 'name' outside aggregate initializer
130 | };
| | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/ip6tables.cc",
"new_path": "test/syscalls/linux/ip6tables.cc",
"diff": "@@ -89,12 +89,12 @@ TEST(IP6TablesBasic, GetRevision) {\nASSERT_THAT(sock = socket(AF_INET6, SOCK_RAW, IPPROTO_RAW),\nSyscallSucceeds());\n- struct xt_get_revision rev ... | Go | Apache License 2.0 | google/gvisor | test/syscall/iptables: don't use designated initializers
test/syscalls/linux/iptables.cc:130:3:
error: C99 designator 'name' outside aggregate initializer
130 | };
|
PiperOrigin-RevId: 336331738 |
259,858 | 09.10.2020 12:11:21 | 25,200 | 743327817faa1aa46ff3b31f74a0c5c2d047d65a | Infer receiver name for stateify. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_stateify/main.go",
"new_path": "tools/go_stateify/main.go",
"diff": "@@ -39,7 +39,7 @@ var (\n)\n// resolveTypeName returns a qualified type name.\n-func resolveTypeName(name string, typ ast.Expr) (field string, qualified string) {\n+func resolveTypeN... | Go | Apache License 2.0 | google/gvisor | Infer receiver name for stateify.
PiperOrigin-RevId: 336340035 |
259,858 | 09.10.2020 12:31:35 | 25,200 | 6229be5e48578dda3b08b6b0c3d381553e7b31ef | Minor nogo restructuring. | [
{
"change_type": "MODIFY",
"old_path": "tools/defs.bzl",
"new_path": "tools/defs.bzl",
"diff": "@@ -72,6 +72,7 @@ def go_binary(name, nogo = True, pure = False, static = False, x_defs = None, **\n)\nnogo_test(\nname = name + \"_nogo\",\n+ srcs = kwargs.get(\"srcs\", []),\nlibrary = \":\" + name + \"... | Go | Apache License 2.0 | google/gvisor | Minor nogo restructuring.
PiperOrigin-RevId: 336343819 |
259,898 | 09.10.2020 13:05:18 | 25,200 | 46e168b5a00bd85f3739bac6f185c3bdc39dfa37 | Set expect_failure flags on tests that currently fails on fuchsia | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/ipv4_id_uniqueness_test.go",
"new_path": "test/packetimpact/tests/ipv4_id_uniqueness_test.go",
"diff": "@@ -88,7 +88,8 @@ func TestIPv4RetransmitIdentificationUniqueness(t *testing.T) {\n// this test. Once the socket option is supported... | Go | Apache License 2.0 | google/gvisor | Set expect_failure flags on tests that currently fails on fuchsia
PiperOrigin-RevId: 336350318 |
259,853 | 09.10.2020 14:32:05 | 25,200 | a0ffc84adfe345e52a249bd1bac9c9f883bf0fe7 | platform/kvm: remove the unused field | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/defs_amd64.go",
"new_path": "pkg/sentry/platform/ring0/defs_amd64.go",
"diff": "@@ -92,7 +92,6 @@ type kernelEntry struct {\n// scratch space for temporary usage.\nscratch0 uint64\n- scratch1 uint64\n// stackTop is the top of the stac... | Go | Apache License 2.0 | google/gvisor | platform/kvm: remove the unused field
PiperOrigin-RevId: 336366624 |
259,891 | 09.10.2020 17:09:39 | 25,200 | 79a5910c04ed18901f755588003ca62d0646b763 | Add gvisor webhook configuration | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "test/kubernetes/gvisor-injection-admission-webhook.yaml",
"diff": "+# Copyright 2020 The gVisor Authors.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the Licens... | Go | Apache License 2.0 | google/gvisor | Add gvisor webhook configuration
PiperOrigin-RevId: 336393190 |
259,896 | 09.10.2020 17:45:23 | 25,200 | d75fe7660a61a454ece9472658eac609b3bf61e6 | RACK: Detect packet reordering.
RACK detects packet reordering by checking if the sender received ACK for
the packet which has the sequence number less than the already acknowledged
packets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -3013,6 +3013,7 @@ func (e *endpoint) completeState() stack.TCPEndpointState {\nEndSequence: rc.endSequence,\nFACK: rc.fack,\nRTT: rc.rtt,\n+ Reord: rc.reorder... | Go | Apache License 2.0 | google/gvisor | RACK: Detect packet reordering.
RACK detects packet reordering by checking if the sender received ACK for
the packet which has the sequence number less than the already acknowledged
packets.
PiperOrigin-RevId: 336397526 |
260,021 | 10.10.2020 16:38:34 | -28,800 | 2ae97b27aa385ddb51c234ec31fb4c4869c0088a | arm64: set DZE bit to make EL0 can use DC ZVA | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/entry_arm64.s",
"new_path": "pkg/sentry/platform/ring0/entry_arm64.s",
"diff": "#define SCTLR_M 1 << 0\n#define SCTLR_C 1 << 2\n#define SCTLR_I 1 << 12\n+#define SCTLR_DZE 1 << 14\n#define SCTLR_UCT 1 << 15\n#define SCTLR_UCI 1 << 26\... | Go | Apache License 2.0 | google/gvisor | arm64: set DZE bit to make EL0 can use DC ZVA
Signed-off-by: Min Le <lemin.lm@antgroup.com> |
259,960 | 11.10.2020 17:41:29 | -28,800 | d4413c31bd121bee66e42648360b1fc1ec7c04e1 | Assign ep.effectiveNetProtos in UDP forwarder's CreateEndpoint | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/forwarder.go",
"new_path": "pkg/tcpip/transport/udp/forwarder.go",
"diff": "@@ -81,6 +81,7 @@ func (r *ForwarderRequest) CreateEndpoint(queue *waiter.Queue) (tcpip.Endpoint,\nep.ID = r.id\nep.route = r.route.Clone()\nep.dstPort = r.id.R... | Go | Apache License 2.0 | google/gvisor | Assign ep.effectiveNetProtos in UDP forwarder's CreateEndpoint |
259,860 | 12.10.2020 10:39:03 | 25,200 | d861cd5f14bc42b32eeac20c444a685f1d9748f7 | [vfs2] Don't leak disconnected mounts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -1738,3 +1738,18 @@ func (k *Kernel) ShmMount() *vfs.Mount {\nfunc (k *Kernel) SocketMount() *vfs.Mount {\nreturn k.socketMount\n}\n+\n+// Release releases resources owned by ... | Go | Apache License 2.0 | google/gvisor | [vfs2] Don't leak disconnected mounts.
PiperOrigin-RevId: 336694658 |
260,001 | 12.10.2020 17:28:58 | 25,200 | 4885931ac342e033b39ba9645b8e6a584f4d9844 | Change verity mu to be per file system
verity Mu should be per file system instead of global, so that enabling
and verifying in different file systems won't block each other.
Also Lock verity Mu in PRead. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -174,8 +174,8 @@ func (fs *filesystem) verifyChild(ctx context.Context, parent *dentry, child *de\nreturn nil, err\n}\n- verityMu.RLock()\n- defer verity... | Go | Apache License 2.0 | google/gvisor | Change verity mu to be per file system
verity Mu should be per file system instead of global, so that enabling
and verifying in different file systems won't block each other.
Also Lock verity Mu in PRead.
PiperOrigin-RevId: 336779356 |
259,853 | 12.10.2020 17:55:37 | 25,200 | 10ca12b3d089fa16f67d886ed6dc2cacd2468d0b | gvisor/test: Set nogotsan for native tests
Tests are written in C++ and there is no reason to run them with gotsan without
gVisor. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -102,6 +102,10 @@ def _syscall_test(\n# Disable off-host networking.\ntags.append(\"requires-net:loopback\")\n+ # gotsan makes sense only if tests are running in gVisor.\n+ if platform == \... | Go | Apache License 2.0 | google/gvisor | gvisor/test: Set nogotsan for native tests
Tests are written in C++ and there is no reason to run them with gotsan without
gVisor.
PiperOrigin-RevId: 336783276 |
259,860 | 13.10.2020 00:12:28 | 25,200 | fc7df53222e56fdce7dee002f1fb4c332de616af | Don't leak VDSO mappings. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -1744,12 +1744,14 @@ func (k *Kernel) SocketMount() *vfs.Mount {\n// Precondition: This should only be called after the kernel is fully\n// initialized, e.g. after k.Start() h... | Go | Apache License 2.0 | google/gvisor | Don't leak VDSO mappings.
PiperOrigin-RevId: 336822021 |
259,860 | 13.10.2020 01:52:47 | 25,200 | 60f159b5580da98ab8261f4e694692c9412a2fae | [vfs2] Destroy all tmpfs files when the filesystem is released.
In addition to fixing reference leaks, this change also releases memory used
by regular tmpfs files once the containing filesystem is released. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"diff": "@@ -74,6 +74,8 @@ type filesystem struct {\nmu sync.RWMutex `state:\"nosave\"`\nnextInoMinusOne uint64 // accessed using atomic memory operations\n+\n+ root *dentry\n}\... | Go | Apache License 2.0 | google/gvisor | [vfs2] Destroy all tmpfs files when the filesystem is released.
In addition to fixing reference leaks, this change also releases memory used
by regular tmpfs files once the containing filesystem is released.
PiperOrigin-RevId: 336833111 |
259,858 | 13.10.2020 10:41:54 | 25,200 | d9b32efb306444440daa89a79e4d85516ff8f340 | Avoid excessive Tgkill and wait operations.
The required states may simply not be observed by the thread running bounce, so
track guest and user generations to ensure that at least one of the desired
state transitions happens.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go",
"diff": "@@ -62,6 +62,9 @@ func bluepillArchContext(context unsafe.Pointer) *arch.SignalContext64 {\n//\n//go:nosplit\nfunc bluepillGuestExit(c *vCPU, contex... | Go | Apache License 2.0 | google/gvisor | Avoid excessive Tgkill and wait operations.
The required states may simply not be observed by the thread running bounce, so
track guest and user generations to ensure that at least one of the desired
state transitions happens.
Fixes #3532
PiperOrigin-RevId: 336908216 |
259,967 | 13.10.2020 13:26:19 | 25,200 | 51913ba400ccff88be58ed12ac3f393258629a50 | Correct NA minimum size
Remove the duplicate NA size variable while I'm here.
See for the packet format. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/icmpv6.go",
"new_path": "pkg/tcpip/header/icmpv6.go",
"diff": "@@ -49,11 +49,6 @@ const (\n// neighbor advertisement packet.\nICMPv6NeighborAdvertMinimumSize = ICMPv6HeaderSize + NDPNAMinimumSize\n- // ICMPv6NeighborAdvertSize is size of a nei... | Go | Apache License 2.0 | google/gvisor | Correct NA minimum size
Remove the duplicate NA size variable while I'm here.
See https://tools.ietf.org/html/rfc4861#section-4.4 for the packet format.
PiperOrigin-RevId: 336943206 |
259,884 | 13.10.2020 18:58:01 | 25,200 | 631dd5330d438729a7a8f6e00b279386924de640 | Various website fixes
Formatting on the most recent blog post
Add a link to faq from containerd docs
Fix code in FAQ | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/FAQ.md",
"new_path": "g3doc/user_guide/FAQ.md",
"diff": "@@ -111,7 +111,7 @@ Please recreate your cluster and set the `--cni-socket` option on kubeadm\ncommands. For example:\n```bash\n-kubeadm init --cni-socket=/var/run/containerd/containerd.... | Go | Apache License 2.0 | google/gvisor | Various website fixes
- Formatting on the most recent blog post
- Add a link to faq from containerd docs
- Fix code in FAQ
PiperOrigin-RevId: 337001738 |
259,860 | 14.10.2020 09:52:05 | 25,200 | fc1e653973c97a857582b8f3651399673343589a | Fix SCM Rights reference leaks.
Control messages should be released on Read (which ignores the control message)
or zero-byte Send. Otherwise, open fds sent through the control messages will
be leaked. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/unix.go",
"new_path": "pkg/sentry/socket/unix/unix.go",
"diff": "@@ -573,13 +573,17 @@ func (s *SocketOperations) Read(ctx context.Context, _ *fs.File, dst usermem.IOS\nif dst.NumBytes() == 0 {\nreturn 0, nil\n}\n- return dst.CopyOutFrom... | Go | Apache License 2.0 | google/gvisor | Fix SCM Rights reference leaks.
Control messages should be released on Read (which ignores the control message)
or zero-byte Send. Otherwise, open fds sent through the control messages will
be leaked.
PiperOrigin-RevId: 337110774 |
260,004 | 14.10.2020 15:28:06 | 25,200 | 6e6a9d3f3dd6dd9ce290952406ba7ca7c5570311 | Find route before sending NA response
This change also brings back the stack.Route.ResolveWith method so that
we can immediately resolve a route when sending an NA in response to a
a NS with a source link layer address option.
Test: ipv6_test.TestNeighorSolicitationResponse | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "@@ -252,26 +252,29 @@ func (e *endpoint) handleICMP(r *stack.Route, pkt *stack.PacketBuffer, hasFragme\nreturn\n}\n+ var sourceLinkAddr tcpip.LinkAddress\n+ {\nit, err := n... | Go | Apache License 2.0 | google/gvisor | Find route before sending NA response
This change also brings back the stack.Route.ResolveWith method so that
we can immediately resolve a route when sending an NA in response to a
a NS with a source link layer address option.
Test: ipv6_test.TestNeighorSolicitationResponse
PiperOrigin-RevId: 337185461 |
259,951 | 15.10.2020 09:27:03 | 25,200 | 8f70c6ef351110cf94e758b6dc295387f0388707 | Refactor compareFragments to follow Go style
Test helpers should be used for test setup/teardown, not actual
testing. Use cmp.Diff instead of bytes.Equal to improve readability. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"diff": "package ipv4_test\nimport (\n- \"bytes\"\n\"context\"\n\"encoding/hex\"\n+ \"fmt\"\n\"math\"\n\"net\"\n\"testing\"\n@@ -243,7 +243,7 @@ func TestIPv4Sanity(t *tes... | Go | Apache License 2.0 | google/gvisor | Refactor compareFragments to follow Go style
Test helpers should be used for test setup/teardown, not actual
testing. Use cmp.Diff instead of bytes.Equal to improve readability.
PiperOrigin-RevId: 337323242 |
260,001 | 15.10.2020 14:33:18 | 25,200 | f0f7431ea2e9f6864bc81c375108857b79c6e64b | Change verity isEnable to be a member of dentry | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -377,12 +377,12 @@ func (fs *filesystem) getChildLocked(ctx context.Context, parent *dentry, name s\n// enabled, we should verify the child hash here bec... | Go | Apache License 2.0 | google/gvisor | Change verity isEnable to be a member of dentry
PiperOrigin-RevId: 337384146 |
259,858 | 15.10.2020 17:19:21 | 25,200 | 0a7e32bd17fb3f4aae8fdea427283cda49fe002f | Add easier-to-use docker_image target. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -94,9 +94,9 @@ endef\nrebuild-...: ## Rebuild the given image. Also may use 'rebuild-all-images'.\n$(eval $(call images,rebuild))\npush-...: ## Push the given image. Also may use 'push-all-images'.\n-$(eval $(call... | Go | Apache License 2.0 | google/gvisor | Add easier-to-use docker_image target.
PiperOrigin-RevId: 337415009 |
259,992 | 15.10.2020 21:48:50 | 25,200 | fc40ead6856603b85c978e9120c66721cdbfc87b | `runsc do` fallback to internal network on failure
In case setting up network fails, log a warning and fallback to internal
network.
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/do.go",
"new_path": "runsc/cmd/do.go",
"diff": "@@ -17,6 +17,7 @@ package cmd\nimport (\n\"context\"\n\"encoding/json\"\n+ \"errors\"\n\"fmt\"\n\"io/ioutil\"\n\"math/rand\"\n@@ -36,6 +37,8 @@ import (\n\"gvisor.dev/gvisor/runsc/specutils\"\n)\n+var e... | Go | Apache License 2.0 | google/gvisor | `runsc do` fallback to internal network on failure
In case setting up network fails, log a warning and fallback to internal
network.
Closes #4498
PiperOrigin-RevId: 337442632 |
259,853 | 15.10.2020 23:13:40 | 25,200 | c002fc36f9bbf0fe3ed8b7712c72376f8f8190c1 | sockets: ignore io.EOF from view.ReadAt
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netlink/socket.go",
"new_path": "pkg/sentry/socket/netlink/socket.go",
"diff": "package netlink\nimport (\n+ \"io\"\n\"math\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -748,6 +749,12 @@ func (s *socketOpsCommon) sendMsg(ctx context.Context, sr... | Go | Apache License 2.0 | google/gvisor | sockets: ignore io.EOF from view.ReadAt
Reported-by: syzbot+5466463b7604c2902875@syzkaller.appspotmail.com
PiperOrigin-RevId: 337451896 |
259,858 | 16.10.2020 09:03:21 | 25,200 | 14a003c60f35e55f9e8c29fc0d75478c9a1214f9 | Cache errors when processing stdlib with nogo. | [
{
"change_type": "MODIFY",
"old_path": "tools/nogo/nogo.go",
"new_path": "tools/nogo/nogo.go",
"diff": "@@ -264,12 +264,17 @@ func checkStdlib(config *stdlibConfig, ac map[*analysis.Analyzer]matcher) ([]str\n// Closure to check a single package.\nallFindings := make([]string, 0)\nstdlibFacts := make... | Go | Apache License 2.0 | google/gvisor | Cache errors when processing stdlib with nogo.
PiperOrigin-RevId: 337515664 |
259,858 | 16.10.2020 11:24:52 | 25,200 | b0da31b9213741aa035a77d602237b4fcd067c98 | Refactor nogo to better support ARM. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazeldefs/defs.bzl",
"new_path": "tools/bazeldefs/defs.bzl",
"diff": "@@ -158,11 +158,31 @@ def go_test_library(target):\nreturn target.attr.embed[0]\nreturn None\n-def go_context(ctx, std = False):\n+def go_context(ctx, goos = None, goarch = None, std =... | Go | Apache License 2.0 | google/gvisor | Refactor nogo to better support ARM.
PiperOrigin-RevId: 337544107 |
260,024 | 16.10.2020 12:28:54 | 25,200 | 4d27f33b09932a7f6cc5ccb03ad6f7462d497afb | Make IPv4 check the IP header checksum
The IPv4 header checksum has not been checked, at least in recent times,
so add code to do so. Fix all the tests that fail because they never
needed to set the checksum.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ip_test.go",
"new_path": "pkg/tcpip/network/ip_test.go",
"diff": "@@ -322,6 +322,7 @@ func TestSourceAddressValidation(t *testing.T) {\nSrcAddr: src,\nDstAddr: localIPv4Addr,\n})\n+ ip.SetChecksum(^ip.CalculateChecksum())\ne.InjectInbound(hea... | Go | Apache License 2.0 | google/gvisor | Make IPv4 check the IP header checksum
The IPv4 header checksum has not been checked, at least in recent times,
so add code to do so. Fix all the tests that fail because they never
needed to set the checksum.
Fixes #4484
PiperOrigin-RevId: 337556243 |
259,858 | 16.10.2020 14:42:02 | 25,200 | 9a3d8973c4fcd1475b3748c10eb3e255d44e8a20 | Refactor shared starlark files. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "tools/bazeldefs/cc.bzl",
"diff": "+\"\"\"C++ rules.\"\"\"\n+\n+load(\"@bazel_tools//tools/cpp:cc_flags_supplier.bzl\", _cc_flags_supplier = \"cc_flags_supplier\")\n+load(\"@rules_cc//cc:defs.bzl\", _cc_binary = \"cc_binary\", _cc_library = \"cc_... | Go | Apache License 2.0 | google/gvisor | Refactor shared starlark files.
PiperOrigin-RevId: 337581114 |
259,853 | 19.10.2020 11:51:15 | 25,200 | cd108432a50ec777ce92f9d207154173e3f0b665 | splice: return EINVAL is len is negative
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/splice.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/splice.go",
"diff": "@@ -45,6 +45,9 @@ func Splice(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscal\nif count > int64(kernel.MAX_RW_COUNT) {\ncount = int... | Go | Apache License 2.0 | google/gvisor | splice: return EINVAL is len is negative
Reported-by: syzbot+0268cc591c0f517a1de0@syzkaller.appspotmail.com
PiperOrigin-RevId: 337901664 |
259,860 | 19.10.2020 13:18:32 | 25,200 | 63f4cef4d160e37b0cbe30ba60b2be95092790ed | [vfs2] Fix fork reference leaks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"new_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"diff": "@@ -147,7 +147,12 @@ func CreateTask(ctx context.Context, name string, tc *kernel.ThreadGroup, mntns\nFSContext: kernel.NewFSContextVFS2(root, cwd, 0022),\nFDTa... | Go | Apache License 2.0 | google/gvisor | [vfs2] Fix fork reference leaks.
PiperOrigin-RevId: 337919424 |
259,992 | 19.10.2020 15:30:48 | 25,200 | 4b4d12d5bb9c4902380fa999b5f49d3ed7029938 | Fixes to cgroups
There were a few problems with cgroups:
cleanup loop what breaking too early
parse of /proc/[pid]/cgroups was skipping "name=systemd"
because "name=" was not being removed from name.
When no limits are specified, fillFromAncestor was not being
called, causing a failure to set cpuset.mems
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -201,13 +201,15 @@ func LoadPaths(pid string) (map[string]string, error) {\npaths := make(map[string]string)\nscanner := bufio.NewScanner(f)\nfor scanner.Scan() {\n- // Format: ID:contr... | Go | Apache License 2.0 | google/gvisor | Fixes to cgroups
There were a few problems with cgroups:
- cleanup loop what breaking too early
- parse of /proc/[pid]/cgroups was skipping "name=systemd"
because "name=" was not being removed from name.
- When no limits are specified, fillFromAncestor was not being
called, causing a failure to set cpuset.mems
Updates #4536
PiperOrigin-RevId: 337947356 |
259,858 | 19.10.2020 17:24:22 | 25,200 | 8f29b8d252ceda8a3e3b777b0b77ea967b0ef2d0 | Remove now unused remote3 configurations. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -28,20 +28,12 @@ build:remote --bes_results_url=\"https://source.cloud.google.com/results/invocati\nbuild:remote --bes_timeout=600s\nbuild:remote --project_id=gvisor-rbe\nbuild:remote --remote_instance_name=projec... | Go | Apache License 2.0 | google/gvisor | Remove now unused remote3 configurations.
PiperOrigin-RevId: 337968219 |
259,860 | 19.10.2020 18:07:38 | 25,200 | dcc1b71f1ba47646808f61cc86e560179c233af2 | Fix reference counting on kcov mappings.
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/sys/kcov.go",
"new_path": "pkg/sentry/fsimpl/sys/kcov.go",
"diff": "@@ -102,7 +102,7 @@ func (fd *kcovFD) ConfigureMMap(ctx context.Context, opts *memmap.MMapOpts) erro\nfunc (fd *kcovFD) Release(ctx context.Context) {\n// kcov instances have... | Go | Apache License 2.0 | google/gvisor | Fix reference counting on kcov mappings.
Reported-by: syzbot+078580ce5dd6d607fcd8@syzkaller.appspotmail.com
Reported-by: syzbot+2096681f6891e7bf8aed@syzkaller.appspotmail.com
PiperOrigin-RevId: 337973519 |
259,853 | 19.10.2020 18:16:37 | 25,200 | 34a6e9576a9684087f95f57ee73171a637bee8b2 | loader/elf: validate file offset
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/elf.go",
"new_path": "pkg/sentry/loader/elf.go",
"diff": "@@ -194,6 +194,10 @@ func parseHeader(ctx context.Context, f fullReader) (elfInfo, error) {\nlog.Infof(\"Too many phdrs (%d): total size %d > %d\", hdr.Phnum, totalPhdrSize, maxTotalPh... | Go | Apache License 2.0 | google/gvisor | loader/elf: validate file offset
Reported-by: syzbot+7406eef8247cb5a20855@syzkaller.appspotmail.com
PiperOrigin-RevId: 337974474 |
259,992 | 20.10.2020 09:18:51 | 25,200 | c21d8375d91ff037cf8eaf12d47c23657cb36b8b | Add /dev to mandatory mounts test | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader_test.go",
"new_path": "runsc/boot/loader_test.go",
"diff": "@@ -266,7 +266,7 @@ type CreateMountTestcase struct {\nfunc createMountTestcases() []*CreateMountTestcase {\ntestCases := []*CreateMountTestcase{\n- &CreateMountTestcase{\n+ {\n// On... | Go | Apache License 2.0 | google/gvisor | Add /dev to mandatory mounts test
PiperOrigin-RevId: 338072845 |
260,003 | 20.10.2020 15:45:38 | 25,200 | 4da10f873e22a43be648ab34c9b9b2759d33337d | Fix nogo tests.
//pkg/tcpip/stack:stack_x_test_nogo
//pkg/tcpip/transport/raw:raw_nogo | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/transport_test.go",
"new_path": "pkg/tcpip/stack/transport_test.go",
"diff": "@@ -28,7 +28,7 @@ import (\nconst (\nfakeTransNumber tcpip.TransportProtocolNumber = 1\n- fakeTransHeaderLen = 3\n+ fakeTransHeaderLen int = 3\n)\n// fakeTransportEnd... | Go | Apache License 2.0 | google/gvisor | Fix nogo tests.
//pkg/tcpip/stack:stack_x_test_nogo
//pkg/tcpip/transport/raw:raw_nogo
PiperOrigin-RevId: 338153265 |
260,004 | 20.10.2020 16:04:45 | 25,200 | 2bfdbfd1fdbe09615b51d3cf360e751bd2c6a981 | Fix locking in AddressableEndpointState | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/addressable_endpoint_state.go",
"new_path": "pkg/tcpip/stack/addressable_endpoint_state.go",
"diff": "@@ -361,6 +361,8 @@ func (a *AddressableEndpointState) RemovePermanentEndpoint(ep AddressEndpoint) *\nreturn tcpip.ErrInvalidEndpointState\n}\... | Go | Apache License 2.0 | google/gvisor | Fix locking in AddressableEndpointState
PiperOrigin-RevId: 338156438 |
259,907 | 20.10.2020 16:17:06 | 25,200 | e36a2b7930425fe062b3234a2f44ff4992eafe4e | [runtime tests] Update exclude files.
bhaskerh@ fixed a bunch of the EADDRINUSE flakes in so we should
unexclude them.
I have also tested other flaky tests on this list and removed those that do
not flake anymore. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude/nodejs12.4.0.csv",
"new_path": "test/runtimes/exclude/nodejs12.4.0.csv",
"diff": "test name,bug id,comment\nasync-hooks/test-statwatcher.js,https://github.com/nodejs/node/issues/21425,Check for fix inclusion in nodejs releases after 2020-... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Update exclude files.
bhaskerh@ fixed a bunch of the EADDRINUSE flakes in #3662 so we should
unexclude them.
I have also tested other flaky tests on this list and removed those that do
not flake anymore.
PiperOrigin-RevId: 338158545 |
260,003 | 20.10.2020 17:20:33 | 25,200 | 16ba350314b457a8d1dcdf17040b75b7a4e646cb | Fix nogo test in //pkg/tcpip/... | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet_test.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet_test.go",
"diff": "@@ -97,6 +97,9 @@ type testConnection struct {\nfunc connect(s *stack.Stack, addr tcpip.FullAddress) (*testConnection, *tcpip.Error) {\nwq := &waiter.Queue{... | Go | Apache License 2.0 | google/gvisor | Fix nogo test in //pkg/tcpip/...
PiperOrigin-RevId: 338168977 |
259,990 | 20.10.2020 20:03:04 | 25,200 | d579ed85052dfba0579bd3286b6ae04210e4f975 | Do not even try forcing cgroups in tests | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -314,7 +314,8 @@ func New(conf *boot.Config, args Args) (*Container, error) {\nif args.Spec.Linux == nil {\nargs.Spec.Linux = &specs.Linux{}\n}\n- if args.Spec.Linux.Cgroups... | Go | Apache License 2.0 | google/gvisor | Do not even try forcing cgroups in tests |
259,860 | 21.10.2020 19:15:02 | 25,200 | 4e389c785779114620b47e005d08ca469cc1ed68 | Check for nil in kernel.FSContext functions.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fs_context.go",
"new_path": "pkg/sentry/kernel/fs_context.go",
"diff": "@@ -147,19 +147,23 @@ func (f *FSContext) WorkingDirectory() *fs.Dirent {\nf.mu.Lock()\ndefer f.mu.Unlock()\n+ if f.cwd != nil {\nf.cwd.IncRef()\n+ }\nreturn f.cwd\n}\n//... | Go | Apache License 2.0 | google/gvisor | Check for nil in kernel.FSContext functions.
Reported-by: syzbot+c0e175d2b10708314eb3@syzkaller.appspotmail.com
PiperOrigin-RevId: 338386575 |
259,907 | 22.10.2020 11:44:47 | 25,200 | c188daf889ea71b30e6862f3a87fcd9924319b70 | [bazel] Reduce number of jobs to 100. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -42,5 +42,6 @@ build:remote --extra_toolchains=//tools/bazeldefs:cc-toolchain-clang-x86_64-defa\nbuild:remote --extra_execution_platforms=//tools/bazeldefs:rbe_ubuntu1604\nbuild:remote --platforms=//tools/bazeldef... | Go | Apache License 2.0 | google/gvisor | [bazel] Reduce number of jobs to 100.
PiperOrigin-RevId: 338517024 |
259,884 | 22.10.2020 21:21:16 | 25,200 | cc772f3d54d46b65c663c8cf7812103df31f17d3 | Add a platform portability blog post
Also fixes the docker_image bazel rule, and website-server make target.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -260,7 +260,7 @@ website-build: load-jekyll ## Build the site image locally.\n.PHONY: website-build\nwebsite-server: website-build ## Run a local server for development.\n- @docker run -i -p 8080:8080 gvisor.dev/i... | Go | Apache License 2.0 | google/gvisor | Add a platform portability blog post
Also fixes the docker_image bazel rule, and website-server make target.
Fixes #3273
PiperOrigin-RevId: 338606668 |
259,992 | 22.10.2020 22:04:57 | 25,200 | 293877cf647ac3e900f0ae15061317a512bba7a0 | Load spec during "runsc start" to process flag overrides
Subcontainers are only configured when the container starts, however because
start doesn't load the spec, flag annotations that may override flags were
not getting applied to the configuration.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -737,7 +737,7 @@ func (l *Loader) createContainerProcess(root bool, cid string, info *containerIn\nreturn nil, err\n}\n- // Add the HOME enviroment variable if it is not already set.\n+ // ... | Go | Apache License 2.0 | google/gvisor | Load spec during "runsc start" to process flag overrides
Subcontainers are only configured when the container starts, however because
start doesn't load the spec, flag annotations that may override flags were
not getting applied to the configuration.
Updates #3494
PiperOrigin-RevId: 338610953 |
259,935 | 21.10.2020 08:33:38 | 0 | 3b8193e762c1cc37df42104f5abeb6fdc7b70c01 | Add --traceback flag to customize GOTRACEBACK level | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/boot.go",
"new_path": "runsc/cmd/boot.go",
"diff": "@@ -131,11 +131,11 @@ func (b *Boot) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\nreturn subcommands.ExitUsageError\n}\n- // Ensure that if there is a panic, all goroutine stack... | Go | Apache License 2.0 | google/gvisor | Add --traceback flag to customize GOTRACEBACK level |
259,896 | 23.10.2020 10:46:12 | 25,200 | 39e9b3bb8a25cdfdbc2203e33c6881a7c2c88766 | Support getsockopt for SO_ACCEPTCONN.
The SO_ACCEPTCONN option is used only on getsockopt(). When this option is
specified, getsockopt() indicates whether socket listening is enabled for
the socket. A value of zero indicates that socket listening is disabled;
non-zero that it is enabled. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1244,6 +1244,18 @@ func getSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, fam\nvP := primitive.Int32(boolToInt32(v))\nreturn &vP, ... | Go | Apache License 2.0 | google/gvisor | Support getsockopt for SO_ACCEPTCONN.
The SO_ACCEPTCONN option is used only on getsockopt(). When this option is
specified, getsockopt() indicates whether socket listening is enabled for
the socket. A value of zero indicates that socket listening is disabled;
non-zero that it is enabled.
PiperOrigin-RevId: 338703206 |
259,907 | 23.10.2020 10:54:43 | 25,200 | 6237563f0a154ee3f62dc1a82be5903e405b98eb | [runtime tests] Exclude flaky tests.
Also updated a test which only fails with VFS1. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude/java11.csv",
"new_path": "test/runtimes/exclude/java11.csv",
"diff": "@@ -144,6 +144,7 @@ jdk/jfr/cmd/TestSplit.java,,java.lang.RuntimeException: 'Missing file' missing f\njdk/jfr/cmd/TestSummary.java,,java.lang.RuntimeException: 'Missing... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Exclude flaky tests.
Also updated a test which only fails with VFS1.
PiperOrigin-RevId: 338704940 |
260,001 | 23.10.2020 12:03:05 | 25,200 | 39e214090be6717c01e8a65ee50e194a1a50b462 | Implement Read in gvisor verity fs
Read is implemented by PRead, with offset obtained from Seek. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -499,6 +499,10 @@ type fileDescription struct {\n// directory that contains the current file/directory. This is only used\n// if allowRuntimeEnable is set to tru... | Go | Apache License 2.0 | google/gvisor | Implement Read in gvisor verity fs
Read is implemented by PRead, with offset obtained from Seek.
PiperOrigin-RevId: 338718587 |
259,967 | 23.10.2020 12:31:11 | 25,200 | 8db147b55423d7dbe5f9af4e6154eab2d19025e1 | Wait before transitioning NUD entries from Probe to Failed
Wait an additional RetransmitTimer duration after the last probe before
transitioning to Failed. The previous implementation transitions immediately to
Failed after sending the last probe, which is erroneous behavior. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_entry.go",
"new_path": "pkg/tcpip/stack/neighbor_entry.go",
"diff": "@@ -238,12 +238,6 @@ func (e *neighborEntry) setStateLocked(next NeighborState) {\n}\nretryCounter++\n- if retryCounter == config.MaxUnicastProbes {\n- e.dispatchRemo... | Go | Apache License 2.0 | google/gvisor | Wait before transitioning NUD entries from Probe to Failed
Wait an additional RetransmitTimer duration after the last probe before
transitioning to Failed. The previous implementation transitions immediately to
Failed after sending the last probe, which is erroneous behavior.
PiperOrigin-RevId: 338723794 |
259,907 | 23.10.2020 12:53:07 | 25,200 | 61b379ee19bd160de01ad483d883f09fa0bce23c | [vfs] kernfs: cleanup/refactor. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/fd_impl_util.go",
"new_path": "pkg/sentry/fsimpl/kernfs/fd_impl_util.go",
"diff": "@@ -145,8 +145,12 @@ func (fd *GenericDirectoryFD) filesystem() *vfs.Filesystem {\nreturn fd.vfsfd.VirtualDentry().Mount().Filesystem()\n}\n+func (fd *G... | Go | Apache License 2.0 | google/gvisor | [vfs] kernfs: cleanup/refactor.
PiperOrigin-RevId: 338728070 |
259,907 | 23.10.2020 13:54:57 | 25,200 | ad6d32f2260e85d2a7320265109868d753558c5e | [bazel] Increase number of jobs back to 300 | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -42,6 +42,5 @@ build:remote --extra_toolchains=//tools/bazeldefs:cc-toolchain-clang-x86_64-defa\nbuild:remote --extra_execution_platforms=//tools/bazeldefs:rbe_ubuntu1604\nbuild:remote --platforms=//tools/bazeldef... | Go | Apache License 2.0 | google/gvisor | [bazel] Increase number of jobs back to 300
PiperOrigin-RevId: 338739277 |
259,853 | 23.10.2020 14:33:20 | 25,200 | d18346e79022f4b7039593a5793ab24dd6169314 | tools/parsers: disable nogo checks
There are too many dependencies. | [
{
"change_type": "MODIFY",
"old_path": "tools/parsers/BUILD",
"new_path": "tools/parsers/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_test(\nsize = \"small\",\nsrcs = [\"go_parser_test.go\"],\nlibrary = \":parsers\",\n+ nogo = False,\ndeps = [\n\"//tools/bigquery\",\n\"@com_github_google_go_cmp//cmp:go_defau... | Go | Apache License 2.0 | google/gvisor | tools/parsers: disable nogo checks
There are too many dependencies.
PiperOrigin-RevId: 338746264 |
259,875 | 23.10.2020 15:29:35 | 25,200 | e5c1b035ab3bbbbaf187d746f858ddd0a859602a | Introduce SemidDs struct for amd64 and arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -55,6 +55,8 @@ go_library(\n\"sched.go\",\n\"seccomp.go\",\n\"sem.go\",\n+ \"sem_amd64.go\",\n+ \"sem_arm64.go\",\n\"shm.go\",\n\"signal.go\",\n\"signalfd.go\",\n"
},
{
"change_type":... | Go | Apache License 2.0 | google/gvisor | Introduce SemidDs struct for amd64 and arm64.
PiperOrigin-RevId: 338756277 |
259,891 | 23.10.2020 15:44:22 | 25,200 | a04c8ad4cee876a8dc5ebab43c0a4759602841d9 | iptables testing: handle EINTR on calls to accept().
This caused test flakes. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/nat.go",
"new_path": "test/iptables/nat.go",
"diff": "@@ -577,11 +577,18 @@ func listenForRedirectedConn(ctx context.Context, ipv6 bool, originalDsts []net.\nconnCh := make(chan int)\nerrCh := make(chan error)\ngo func() {\n+ for {\nconnFD, _, er... | Go | Apache License 2.0 | google/gvisor | iptables testing: handle EINTR on calls to accept().
This caused test flakes.
PiperOrigin-RevId: 338758723 |
259,975 | 23.10.2020 16:03:04 | 25,200 | 634e14a09408e50ef70442c0114a8b1dd12c8d03 | Fix socket_ipv4_udp_unbound_loopback_test_linux
Handle "Resource temporarily unavailable" EAGAIN errors with a select
call before calling recvmsg.
Also rename similar helper call from "RecvMsgTimeout" to "RecvTimeout",
because it calls "recv". | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ipv4_udp_unbound.cc",
"new_path": "test/syscalls/linux/socket_ipv4_udp_unbound.cc",
"diff": "@@ -75,7 +75,7 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackNoGroup) {\n// Check that we did not receive the multicast packet.\nch... | Go | Apache License 2.0 | google/gvisor | Fix socket_ipv4_udp_unbound_loopback_test_linux
Handle "Resource temporarily unavailable" EAGAIN errors with a select
call before calling recvmsg.
Also rename similar helper call from "RecvMsgTimeout" to "RecvTimeout",
because it calls "recv".
PiperOrigin-RevId: 338761695 |
259,992 | 23.10.2020 18:33:57 | 25,200 | 3ed8ace87123a5cee4fd3aa3751bb24c151749ff | Fix nogo errors in specutils | [
{
"change_type": "MODIFY",
"old_path": "runsc/specutils/specutils.go",
"new_path": "runsc/specutils/specutils.go",
"diff": "@@ -425,7 +425,7 @@ func Mount(src, dst, typ string, flags uint32) error {\n// Special case, as there is no source directory for proc mounts.\nisDir = true\n} else if fi, err :... | Go | Apache License 2.0 | google/gvisor | Fix nogo errors in specutils
PiperOrigin-RevId: 338780793 |
260,003 | 23.10.2020 19:22:07 | 25,200 | 8dfbec28a47483e0c03a5c94331081d7219f215b | Fix nogo tests in //pkg/sentry/socket/... | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/control_vfs2.go",
"new_path": "pkg/sentry/socket/control/control_vfs2.go",
"diff": "@@ -36,9 +36,9 @@ type SCMRightsVFS2 interface {\nFiles(ctx context.Context, max int) (rf RightsFilesVFS2, truncated bool)\n}\n-// RightsFilesVFS2 rep... | Go | Apache License 2.0 | google/gvisor | Fix nogo tests in //pkg/sentry/socket/...
PiperOrigin-RevId: 338784921 |
259,860 | 23.10.2020 19:24:51 | 25,200 | 54d2d927ac9c3ee290d44405a3028307459a49fb | Direct gvisor.dev/issues to the same place as gvisor.dev/issue.
Also let the Github bug reviver detect both in TODOs. | [
{
"change_type": "MODIFY",
"old_path": "tools/github/reviver/github.go",
"new_path": "tools/github/reviver/github.go",
"diff": "@@ -121,13 +121,24 @@ func (b *GitHubBugger) Activate(todo *Todo) (bool, error) {\nreturn true, nil\n}\n+var issuePrefixes = []string{\n+ \"gvisor.dev/issue/\",\n+ \"gvisor... | Go | Apache License 2.0 | google/gvisor | Direct gvisor.dev/issues to the same place as gvisor.dev/issue.
Also let the Github bug reviver detect both in TODOs.
PiperOrigin-RevId: 338785089 |
259,885 | 24.10.2020 00:22:11 | 25,200 | bc814b01ab022a95c586499d9f6105d6a023ae57 | Avoid excessive save/restore cycles in socket_ipv4_udp_unbound tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -2435,6 +2435,7 @@ cc_library(\n\"@com_google_absl//absl/memory\",\ngtest,\n\"//test/util:posix_error\",\n+ \"//test/util:save_util\",\n\"//test/util:test_util\",\n],\nalwayslink ... | Go | Apache License 2.0 | google/gvisor | Avoid excessive save/restore cycles in socket_ipv4_udp_unbound tests.
PiperOrigin-RevId: 338805321 |
259,860 | 24.10.2020 07:46:30 | 25,200 | 4feb5c7c263de2310608d1a0e608d4ffd5e2990f | Add leak checking to vfs2 structures that cannot use the refs_vfs2 template.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/BUILD",
"new_path": "pkg/sentry/fsimpl/gofer/BUILD",
"diff": "@@ -54,6 +54,7 @@ go_library(\n\"//pkg/log\",\n\"//pkg/p9\",\n\"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/safemem\",\n\"//pkg/sentry/fs/fsutil\",\n\"//pkg/sentry/fs/lock\... | Go | Apache License 2.0 | google/gvisor | Add leak checking to vfs2 structures that cannot use the refs_vfs2 template.
Updates #1486.
PiperOrigin-RevId: 338832085 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.