author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
260,001 | 24.10.2020 12:01:52 | 25,200 | 73a18635385d6a90942370e15fe2cbeb2a5a4386 | Implement Seek in verity fs | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -365,6 +365,7 @@ func (fs *filesystem) verifyStat(ctx context.Context, d *dentry, stat linux.Stat\nd.mode = uint32(stat.Mode)\nd.uid = stat.UID\nd.gid = ... | Go | Apache License 2.0 | google/gvisor | Implement Seek in verity fs
PiperOrigin-RevId: 338847417 |
259,975 | 26.10.2020 10:27:25 | 25,200 | e2dce046037c30b585cc62db45d517f59d1a08fc | Add parser for open source benchmarks.
Add a parser binary for parsing files containing
Benchmark output and sending data to BigQuery. | [
{
"change_type": "MODIFY",
"old_path": "tools/bigquery/BUILD",
"new_path": "tools/bigquery/BUILD",
"diff": "@@ -9,5 +9,8 @@ go_library(\nvisibility = [\n\"//:sandbox\",\n],\n- deps = [\"@com_google_cloud_go_bigquery//:go_default_library\"],\n+ deps = [\n+ \"@com_google_cloud_go_bigquery//:go_default... | Go | Apache License 2.0 | google/gvisor | Add parser for open source benchmarks.
Add a parser binary for parsing files containing
Benchmark output and sending data to BigQuery.
PiperOrigin-RevId: 339066396 |
259,860 | 26.10.2020 14:13:55 | 25,200 | 0bdcee38bdfa5c4585d28a0edd0c46e170cdc9b5 | Fix SCM Rights S/R reference leak.
Control messages collected when peeking into a socket were being leaked. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/unix.go",
"new_path": "pkg/sentry/socket/unix/transport/unix.go",
"diff": "@@ -32,6 +32,8 @@ import (\nconst initialLimit = 16 * 1024\n// A RightsControlMessage is a control message containing FDs.\n+//\n+// +stateify savable\n... | Go | Apache License 2.0 | google/gvisor | Fix SCM Rights S/R reference leak.
Control messages collected when peeking into a socket were being leaked.
PiperOrigin-RevId: 339114961 |
260,001 | 26.10.2020 16:49:54 | 25,200 | 528bc380222d1568fcbf95b449d0b19fd6dc0a00 | Add verity tests for deleted/renamed cases
Also change verity test to use a context with an active task. This is
required to delete/rename the file in the underlying file system. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/BUILD",
"new_path": "pkg/sentry/fsimpl/verity/BUILD",
"diff": "@@ -40,10 +40,12 @@ go_test(\n\"//pkg/context\",\n\"//pkg/fspath\",\n\"//pkg/sentry/arch\",\n+ \"//pkg/sentry/fsimpl/testutil\",\n\"//pkg/sentry/fsimpl/tmpfs\",\n+ \"//pkg/... | Go | Apache License 2.0 | google/gvisor | Add verity tests for deleted/renamed cases
Also change verity test to use a context with an active task. This is
required to delete/rename the file in the underlying file system.
PiperOrigin-RevId: 339146445 |
259,990 | 26.10.2020 18:02:52 | 25,200 | 2b72da8bf95e3e1afb361f8984584bcf0524cff3 | Allow overriding mount options for /dev and /dev/pts
This is useful to optionally set /dev ro,noexec.
Treat /dev and /dev/pts the same as /proc and /sys.
Make sure the Type is right though. Many config.json snippets
on the Internet suggest /dev is tmpfs, not devtmpfs. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -103,33 +103,28 @@ func addOverlay(ctx context.Context, conf *Config, lower *fs.Inode, name string,\n// mandatory mounts that are required by the OCI specification.\nfunc compileMounts(spec *specs.... | Go | Apache License 2.0 | google/gvisor | Allow overriding mount options for /dev and /dev/pts
This is useful to optionally set /dev ro,noexec.
Treat /dev and /dev/pts the same as /proc and /sys.
Make sure the Type is right though. Many config.json snippets
on the Internet suggest /dev is tmpfs, not devtmpfs. |
259,875 | 26.10.2020 19:24:28 | 25,200 | facb2fb9c39de72c2426849a972f7181e236e7ab | Implement command IPC_STAT for semctl. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "@@ -283,6 +283,33 @@ func (s *Set) Change(ctx context.Context, creds *auth.Credentials, owner fs.File\nreturn nil\n}\n+// GetStat extracts semid_ds info... | Go | Apache License 2.0 | google/gvisor | Implement command IPC_STAT for semctl.
PiperOrigin-RevId: 339166854 |
259,884 | 26.10.2020 21:59:47 | 25,200 | 3bb5f7164eefc6d5f33e7c08f87e2ae6df1c4bff | Update latest install docs to install containerd shim | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/install.md",
"new_path": "g3doc/user_guide/install.md",
"diff": "@@ -13,15 +13,19 @@ To download and install the latest release manually follow these steps:\n(\nset -e\nURL=https://storage.googleapis.com/gvisor/releases/release/latest\n- wget ... | Go | Apache License 2.0 | google/gvisor | Update latest install docs to install containerd shim
PiperOrigin-RevId: 339182137 |
259,884 | 26.10.2020 22:04:13 | 25,200 | ef9378711ba4a5d27f9e819ff4811d4b0c210cc5 | Fix platforms blog post permalink | [
{
"change_type": "MODIFY",
"old_path": "website/blog/BUILD",
"new_path": "website/blog/BUILD",
"diff": "@@ -46,7 +46,7 @@ doc(\n\"mpratt\",\n],\nlayout = \"post\",\n- permalink = \"/blog/2020/09/22/platform-portability/\",\n+ permalink = \"/blog/2020/10/22/platform-portability/\",\n)\ndocs(\n"
},
... | Go | Apache License 2.0 | google/gvisor | Fix platforms blog post permalink
PiperOrigin-RevId: 339182848 |
259,884 | 27.10.2020 00:16:14 | 25,200 | 59e2c9f16a9a4cce2ecf8b6449a47316fdf76ca2 | Add basic address deletion to netlink
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/inet/inet.go",
"new_path": "pkg/sentry/inet/inet.go",
"diff": "@@ -32,9 +32,13 @@ type Stack interface {\nInterfaceAddrs() map[int32][]InterfaceAddr\n// AddInterfaceAddr adds an address to the network interface identified by\n- // index.\n+ // idx.\... | Go | Apache License 2.0 | google/gvisor | Add basic address deletion to netlink
Updates #3921
PiperOrigin-RevId: 339195417 |
259,882 | 27.10.2020 18:05:16 | 25,200 | 1c2836da37261c47cb8372e3ae5a49adab369694 | Implement /proc/[pid]/mem
This PR implements /proc/[pid]/mem for `pkg/sentry/fs` (refer to and `pkg/sentry/fsimpl`.
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/4060 from lnsp:proc-pid-mem | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -92,6 +92,7 @@ func (p *proc) newTaskDir(t *kernel.Task, msrc *fs.MountSource, isThreadGroup bo\n\"gid_map\": newGIDMap(t, msrc),\n\"io\": newIO(t, msrc, isThreadGroup),\n\"maps... | Go | Apache License 2.0 | google/gvisor | Implement /proc/[pid]/mem
This PR implements /proc/[pid]/mem for `pkg/sentry/fs` (refer to #2716) and `pkg/sentry/fsimpl`.
@majek
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/4060 from lnsp:proc-pid-mem 2caf9021254646f441be618a9bb5528610e44d43
PiperOrigin-RevId: 339369629 |
260,001 | 27.10.2020 19:10:32 | 25,200 | bc91ae17f682d2a0a6062101707e2707f965a9b2 | Add SHA512 to merkle tree library | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/ioctl.go",
"new_path": "pkg/abi/linux/ioctl.go",
"diff": "@@ -121,6 +121,9 @@ const (\n// Constants from uapi/linux/fsverity.h.\nconst (\n+ FS_VERITY_HASH_ALG_SHA256 = 1\n+ FS_VERITY_HASH_ALG_SHA512 = 2\n+\nFS_IOC_ENABLE_VERITY = 1082156677\nFS_I... | Go | Apache License 2.0 | google/gvisor | Add SHA512 to merkle tree library
PiperOrigin-RevId: 339377254 |
259,992 | 27.10.2020 19:44:41 | 25,200 | 93d2d37a93640328f01add7d4866bc107ff6a74e | Add more cgroup unit tests | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -21,6 +21,7 @@ import (\n\"context\"\n\"errors\"\n\"fmt\"\n+ \"io\"\n\"io/ioutil\"\n\"os\"\n\"path/filepath\"\n@@ -198,8 +199,13 @@ func LoadPaths(pid string) (map[string]string, error)... | Go | Apache License 2.0 | google/gvisor | Add more cgroup unit tests
PiperOrigin-RevId: 339380431 |
260,003 | 28.10.2020 09:38:17 | 25,200 | 8fa18e8ecb3e3da2015e5c73db9e46494dcfeff7 | Bump honnef.co/go/tools to v0.0.1-2020.1.6 | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -482,8 +482,8 @@ go_repository(\ngo_repository(\nname = \"co_honnef_go_tools\",\nimportpath = \"honnef.co/go/tools\",\n- sum = \"h1:3JgtbtFHMiCmsznwGVTUWbgGov+pVqnlf1dEJTNAXeM=\",\n- version = \"v0.0.1-2019.2.3\... | Go | Apache License 2.0 | google/gvisor | Bump honnef.co/go/tools to v0.0.1-2020.1.6
PiperOrigin-RevId: 339476515 |
259,907 | 28.10.2020 11:46:18 | 25,200 | 4cc3894b27e8cfddb507b4c68b95695ec3979eba | [vfs] Refactor hostfs mmap into kernfs util. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/BUILD",
"new_path": "pkg/sentry/fsimpl/host/BUILD",
"diff": "@@ -33,7 +33,6 @@ go_library(\n\"host.go\",\n\"inode_refs.go\",\n\"ioctl_unsafe.go\",\n- \"mmap.go\",\n\"save_restore.go\",\n\"socket.go\",\n\"socket_iovec.go\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | [vfs] Refactor hostfs mmap into kernfs util.
PiperOrigin-RevId: 339505487 |
259,885 | 28.10.2020 13:40:56 | 25,200 | 9907539d92f0233fa7a0daba22484085da44d1c4 | Invalidate overlay.dentry.dirents during open() file creation.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"new_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"diff": "@@ -976,7 +976,10 @@ func (fs *filesystem) createAndOpenLocked(ctx context.Context, rp *vfs.Resolving\n}\nreturn nil, err\n}\n- // Finally construct the o... | Go | Apache License 2.0 | google/gvisor | Invalidate overlay.dentry.dirents during open() file creation.
Updates #1199
PiperOrigin-RevId: 339528827 |
259,858 | 28.10.2020 17:25:58 | 25,200 | b4b42a5fce4cdd134d7d28d96ae7d4862791d911 | Traversal embedded libraries, even for go_library rules. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazeldefs/go.bzl",
"new_path": "tools/bazeldefs/go.bzl",
"diff": "@@ -94,10 +94,10 @@ def go_rule(rule, implementation, **kwargs):\ntoolchains = kwargs.get(\"toolchains\", []) + [\"@io_bazel_rules_go//go:toolchain\"]\nreturn rule(implementation, attrs = ... | Go | Apache License 2.0 | google/gvisor | Traversal embedded libraries, even for go_library rules.
PiperOrigin-RevId: 339570821 |
259,860 | 28.10.2020 18:16:30 | 25,200 | 3b4674ffe0e6ef1b016333ee726293ecf70c4e4e | Add logging option to leak checker.
Also refactor the template and CheckedObject interface to make this cleaner.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -319,7 +319,8 @@ func makeStackKey(pcs []uintptr) stackKey {\nreturn key\n}\n-func recordStack() []uintptr {\n+// RecordStack constructs and returns the PCs on the current stack.\n+func... | Go | Apache License 2.0 | google/gvisor | Add logging option to leak checker.
Also refactor the template and CheckedObject interface to make this cleaner.
Updates #1486.
PiperOrigin-RevId: 339577120 |
259,860 | 28.10.2020 19:00:01 | 25,200 | 265f1eb2c7abbbf924448ef6bbd8cddb13e66b9f | Add leak checking for kernfs.Dentry.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/refsvfs2/refs_map.go",
"new_path": "pkg/refsvfs2/refs_map.go",
"diff": "@@ -16,16 +16,12 @@ package refsvfs2\nimport (\n\"fmt\"\n- \"strings\"\n\"gvisor.dev/gvisor/pkg/log\"\nrefs_vfs1 \"gvisor.dev/gvisor/pkg/refs\"\n\"gvisor.dev/gvisor/pkg/sync\"\n)\n-// ... | Go | Apache License 2.0 | google/gvisor | Add leak checking for kernfs.Dentry.
Updates #1486.
PiperOrigin-RevId: 339581879 |
259,884 | 28.10.2020 23:14:44 | 25,200 | b0b275449b215c59b1621d509b07277c46c506f4 | Add url option for blog authors | [
{
"change_type": "MODIFY",
"old_path": "website/_config.yml",
"new_path": "website/_config.yml",
"diff": "@@ -40,6 +40,7 @@ authors:\nianlewis:\nname: Ian Lewis\nemail: ianlewis@google.com\n+ url: https://twitter.com/IanMLewis\nmpratt:\nname: Michael Pratt\nemail: mpratt@google.com\n"
},
{
"... | Go | Apache License 2.0 | google/gvisor | Add url option for blog authors
PiperOrigin-RevId: 339608078 |
259,951 | 29.10.2020 10:42:39 | 25,200 | 337c4b9a19ea7b880383eb875c5dffddbc5bebde | Add support for bare IPv4 in packetimpact tests | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -839,6 +839,61 @@ func (conn *TCPIPv4) Drain(t *testing.T) {\nconn.sniffer.Drain(t)\n}\n+// IPv4Conn maintains the state for all the layers in a ... | Go | Apache License 2.0 | google/gvisor | Add support for bare IPv4 in packetimpact tests
PiperOrigin-RevId: 339699771 |
260,003 | 29.10.2020 13:50:28 | 25,200 | b9f18fe2f1ad0c8547e2bd66d1cd3bbbddfbddda | Fix TCP wildcard bind failure when netstack is v6 only
TCP endpoint unconditionly binds to v4 even when the stack only supports v6. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/dual_stack_test.go",
"new_path": "pkg/tcpip/transport/tcp/dual_stack_test.go",
"diff": "@@ -236,6 +236,25 @@ func TestV6ConnectWhenBoundToWildcard(t *testing.T) {\ntestV6Connect(t, c)\n}\n+func TestStackV6OnlyConnectWhenBoundToWildcard(... | Go | Apache License 2.0 | google/gvisor | Fix TCP wildcard bind failure when netstack is v6 only
TCP endpoint unconditionly binds to v4 even when the stack only supports v6.
PiperOrigin-RevId: 339739392 |
259,891 | 29.10.2020 14:26:48 | 25,200 | 181fea0b58f2e13a469a34eb0b921b169d292a9d | Make RedirectTarget thread safe
Fixes | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -210,6 +210,15 @@ iptables-tests: load-iptables\n@$(call submake,test-runtime RUNTIME=\"iptables\" TARGETS=\"//test/iptables:iptables_test\")\n.PHONY: iptables-tests\n+# Run the iptables tests with runsc only. Use... | Go | Apache License 2.0 | google/gvisor | Make RedirectTarget thread safe
Fixes #4613.
PiperOrigin-RevId: 339746784 |
259,907 | 29.10.2020 15:04:56 | 25,200 | 52f1dd5e7270dd78ae4ae246d583f2f7c6df0ba5 | [infra] Deflake Go / generate (pull_request.
does not seem to work. Try this new approach. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_branch.sh",
"new_path": "tools/go_branch.sh",
"diff": "@@ -61,14 +61,6 @@ go_branch=$( \\\n)\nreadonly go_branch\n-declare commit\n-commit=$(git rev-parse HEAD)\n-readonly commit\n-if [[ -n \"$(git branch --contains=\"${commit}\" go)\" ]]; then\n- # T... | Go | Apache License 2.0 | google/gvisor | [infra] Deflake Go / generate (pull_request.
#4673 does not seem to work. Try this new approach.
PiperOrigin-RevId: 339754794 |
259,951 | 29.10.2020 16:20:44 | 25,200 | dd056112b72abde9f570a69ad7cfc2a0a6beed14 | Add IPv4 reassembly packetimpact test
The IPv6 reassembly test was also refactored to be easily extended with
more cases. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/defs.bzl",
"new_path": "test/packetimpact/runner/defs.bzl",
"diff": "@@ -251,6 +251,9 @@ ALL_TESTS = [\n# TODO(b/159928940): Fix netstack then remove the line below.\nexpect_netstack_failure = True,\n),\n+ PacketimpactTestInfo(\n+ name... | Go | Apache License 2.0 | google/gvisor | Add IPv4 reassembly packetimpact test
The IPv6 reassembly test was also refactored to be easily extended with
more cases.
PiperOrigin-RevId: 339768605 |
259,858 | 30.10.2020 09:39:16 | 25,200 | 3a6f046ae8d852210ae2b82ba35e9a8c2e6757b9 | Avoid creating users if user is root already. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -26,13 +26,13 @@ BRANCH_NAME := $(shell (git branch --show-current 2>/dev/null || \\\nBUILD_ROOTS := bazel-bin/ bazel-out/\n# Bazel container configuration (see below).\n-USER ?= gvisor\n-HASH ?= $(she... | Go | Apache License 2.0 | google/gvisor | Avoid creating users if user is root already.
PiperOrigin-RevId: 339886754 |
259,860 | 30.10.2020 17:40:28 | 25,200 | 1f25697cfe0484198784afc947ae3bdf4eb05e9b | Fix rename error handling for VFS2 kernfs.
The non-errno error was causing panics before. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"new_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"diff": "@@ -568,13 +568,6 @@ func (o *OrderedChildren) RmDir(ctx context.Context, name string, child Inode) e\nreturn o.Unlink(ctx, name, child)\n}\n-// +... | Go | Apache License 2.0 | google/gvisor | Fix rename error handling for VFS2 kernfs.
The non-errno error was causing panics before.
PiperOrigin-RevId: 339969348 |
259,860 | 30.10.2020 19:37:29 | 25,200 | 4eb1c87e8033520981cce19dea7cde5f85f07737 | Adjust error handling in kernfs rename.
Read-only directories (e.g. under /sys, /proc) should return EPERM for rename. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"new_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"diff": "@@ -578,13 +578,18 @@ func (o *OrderedChildren) RmDir(ctx context.Context, name string, child Inode) e\n//\n// Postcondition: reference on any rep... | Go | Apache License 2.0 | google/gvisor | Adjust error handling in kernfs rename.
Read-only directories (e.g. under /sys, /proc) should return EPERM for rename.
PiperOrigin-RevId: 339979022 |
259,853 | 31.10.2020 01:17:29 | 25,200 | df88f223bb5474a462da65ede6f266eb52f1b2ef | net/tcpip: connect to unset loopback address has to return EADDRNOTAVAIL
In the docker container, the ipv6 loopback address is not set,
and connect("::1") has to return ENEADDRNOTAVAIL in this case.
Without this fix, it returns EHOSTUNREACH. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6.go",
"new_path": "pkg/tcpip/header/ipv6.go",
"diff": "@@ -375,6 +375,12 @@ func IsV6LinkLocalAddress(addr tcpip.Address) bool {\nreturn addr[0] == 0xfe && (addr[1]&0xc0) == 0x80\n}\n+// IsV6LoopbackAddress determines if the provided addre... | Go | Apache License 2.0 | google/gvisor | net/tcpip: connect to unset loopback address has to return EADDRNOTAVAIL
In the docker container, the ipv6 loopback address is not set,
and connect("::1") has to return ENEADDRNOTAVAIL in this case.
Without this fix, it returns EHOSTUNREACH.
PiperOrigin-RevId: 340002915 |
259,884 | 01.11.2020 18:01:57 | 28,800 | 5e606844df577936ebcd13225da85eda80317021 | Fix returned error when deleting non-existant address | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netlink/route/protocol.go",
"new_path": "pkg/sentry/socket/netlink/route/protocol.go",
"diff": "@@ -487,7 +487,7 @@ func (p *Protocol) delAddr(ctx context.Context, msg *netlink.Message, ms *netlin\nAddr: value,\n})\nif err != nil {\n- return ... | Go | Apache License 2.0 | google/gvisor | Fix returned error when deleting non-existant address
PiperOrigin-RevId: 340149214 |
259,857 | 13.08.2020 13:01:20 | -28,800 | 3425485b7c47861422c8bf285635d11911035383 | kvm: share upper halves among all pagtables
Fixes: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm.go",
"new_path": "pkg/sentry/platform/kvm/kvm.go",
"diff": "@@ -158,8 +158,7 @@ func (*KVM) MaxUserAddress() usermem.Addr {\n// NewAddressSpace returns a new pagetable root.\nfunc (k *KVM) NewAddressSpace(_ interface{}) (platform.Ad... | Go | Apache License 2.0 | google/gvisor | kvm: share upper halves among all pagtables
Fixes: #509
Signed-off-by: Lai Jiangshan <jiangshan.ljs@antfin.com>
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com> |
259,853 | 02.11.2020 10:39:33 | 28,800 | 73f980e97e2df13db736271ae8e8c3bfb1c1e1aa | Block external network for tests
And in this case, tests will run in separate network namespaces
and will not affect each other. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -97,10 +97,10 @@ def _syscall_test(\n# we figure out how to request ipv4 sockets on Guitar machines.\nif network == \"host\":\ntags.append(\"noguitar\")\n- tags.append(\"block-network\")\n#... | Go | Apache License 2.0 | google/gvisor | Block external network for tests
And in this case, tests will run in separate network namespaces
and will not affect each other.
PiperOrigin-RevId: 340267734 |
260,001 | 02.11.2020 11:15:09 | 28,800 | ed4f8573435763f08971374243934d3dcf65c06a | Pass hashing algorithms in verity fs opts | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -276,9 +276,9 @@ func (fs *filesystem) verifyChild(ctx context.Context, parent *dentry, child *de\nUID: parentStat.UID,\nGID: parentStat.GID,\n//TODO(b/1... | Go | Apache License 2.0 | google/gvisor | Pass hashing algorithms in verity fs opts
PiperOrigin-RevId: 340275942 |
259,853 | 02.11.2020 14:40:24 | 28,800 | 9efaf675187a2f22bb24492eb5b040e2ff8196a9 | Clean up the code of setupTimeWaitClose
The active_closefd has to be shutdown only for write,
otherwise the second poll will always return immediately.
The second poll should not be called from a separate thread. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -940,7 +940,7 @@ void setupTimeWaitClose(const TestAddress* listener,\n}\n// shutdown to trigger TIME_WAIT.\n- ASSERT_THAT(shutdown(active_clos... | Go | Apache License 2.0 | google/gvisor | Clean up the code of setupTimeWaitClose
The active_closefd has to be shutdown only for write,
otherwise the second poll will always return immediately.
The second poll should not be called from a separate thread.
PiperOrigin-RevId: 340319071 |
259,860 | 02.11.2020 19:13:16 | 28,800 | 51b062f6cdfb59ef82d0a6fa2ca79cb00dd953d2 | Skip log.Sprintfs when leak check logging is not enabled. | [
{
"change_type": "MODIFY",
"old_path": "pkg/refsvfs2/refs_map.go",
"new_path": "pkg/refsvfs2/refs_map.go",
"diff": "@@ -62,9 +62,11 @@ func Register(obj CheckedObject) {\n}\nliveObjects[obj] = struct{}{}\nliveObjectsMu.Unlock()\n+ if leakCheckEnabled() && obj.LogRefs() {\nlogEvent(obj, \"registered\... | Go | Apache License 2.0 | google/gvisor | Skip log.Sprintfs when leak check logging is not enabled.
PiperOrigin-RevId: 340361998 |
259,860 | 02.11.2020 22:30:23 | 28,800 | 1321f837bd9f082e3c1b0a37831453b3637202c3 | [vfs2] Refactor kernfs checkCreateLocked.
Don't return the filename, since it can already be determined by the caller.
This was causing a panic in RenameAt, which relied on the name to be nonempty
even if the error was EEXIST.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -207,24 +207,23 @@ func (fs *Filesystem) walkParentDirLocked(ctx context.Context, rp *vfs.Resolving\n// Preconditions:\n// * Filesystem.mu must be locked... | Go | Apache License 2.0 | google/gvisor | [vfs2] Refactor kernfs checkCreateLocked.
Don't return the filename, since it can already be determined by the caller.
This was causing a panic in RenameAt, which relied on the name to be nonempty
even if the error was EEXIST.
Reported-by: syzbot+e9f117d000301e42361f@syzkaller.appspotmail.com
PiperOrigin-RevId: 340381946 |
259,875 | 02.11.2020 23:56:29 | 28,800 | 1a3f417f4a329339d89fcf89262bd08c18c1f27e | Implement command GETZCNT for semctl. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "@@ -423,6 +423,29 @@ func (s *Set) GetPID(num int32, creds *auth.Credentials) (int32, error) {\nreturn sem.pid, nil\n}\n+// GetZeroWaiters returns numbe... | Go | Apache License 2.0 | google/gvisor | Implement command GETZCNT for semctl.
PiperOrigin-RevId: 340389884 |
259,914 | 03.11.2020 09:32:22 | 28,800 | 0e96f8065e7dc24aa5bc0a8cb14380c58ed6af13 | arm64 kvm: inject sError to trigger sigbus
Use an sErr injection to trigger sigbus when we receive EFAULT from the
run ioctl.
After applying this patch, mmap_test_runsc_kvm will be passed on
Arm64.
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/4542 from lubinszARM:pr_kvm_mmap_1 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_amd64_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_amd64_unsafe.go",
"diff": "@@ -79,6 +79,18 @@ func bluepillStopGuest(c *vCPU) {\nc.runData.requestInterruptWindow = 0\n}\n+// bluepillSigBus is reponsible for inje... | Go | Apache License 2.0 | google/gvisor | arm64 kvm: inject sError to trigger sigbus
Use an sErr injection to trigger sigbus when we receive EFAULT from the
run ioctl.
After applying this patch, mmap_test_runsc_kvm will be passed on
Arm64.
Signed-off-by: Bin Lu <bin.lu@arm.com>
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/gvisor/pull/4542 from lubinszARM:pr_kvm_mmap_1 f81bd42466d1d60a581e5fb34de18b78878c68c1
PiperOrigin-RevId: 340461239 |
259,860 | 03.11.2020 14:54:54 | 28,800 | 580bbb749747e8c8bbf4dfe60c15676c85065a6a | [vfs2] Do not drop inotify waiters across S/R.
The waits-for relationship between an epoll instance and an inotify fd should
be restored.
This fixes flaky inotify vfs2 tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/inotify.go",
"new_path": "pkg/sentry/vfs/inotify.go",
"diff": "@@ -65,7 +65,7 @@ type Inotify struct {\n// queue is used to notify interested parties when the inotify instance\n// becomes readable or writable.\n- queue waiter.Queue `state:\"nosa... | Go | Apache License 2.0 | google/gvisor | [vfs2] Do not drop inotify waiters across S/R.
The waits-for relationship between an epoll instance and an inotify fd should
be restored.
This fixes flaky inotify vfs2 tests.
PiperOrigin-RevId: 340531367 |
259,898 | 04.11.2020 18:17:33 | 28,800 | e29972ec04f96fa9c560f864113599ce313e1240 | Make the regex for inet6Line in packetimpact/netdevs more accurate | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/netdevs/netdevs.go",
"new_path": "test/packetimpact/netdevs/netdevs.go",
"diff": "@@ -40,7 +40,7 @@ var (\ndeviceLine = regexp.MustCompile(`^\\s*(\\d+): (\\w+)`)\nlinkLine = regexp.MustCompile(`^\\s*link/\\w+ ([0-9a-fA-F:]+)`)\ninetLine = reg... | Go | Apache License 2.0 | google/gvisor | Make the regex for inet6Line in packetimpact/netdevs more accurate
PiperOrigin-RevId: 340763455 |
259,860 | 04.11.2020 22:44:48 | 28,800 | 771e9ce8e18021fc8015c77c67e57f66ff93ea10 | Unlock tcp endpoint mutex before blocking forever.
This was occasionally causing tests to get stuck due to races with the save
process, during which the same mutex is acquired. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1370,7 +1370,9 @@ func (e *endpoint) protocolMainLoop(handshake bool, wakerInitDone chan<- struct{\ndrained := e.drainDone != nil\nif drained {\nclose(e.drainDo... | Go | Apache License 2.0 | google/gvisor | Unlock tcp endpoint mutex before blocking forever.
This was occasionally causing tests to get stuck due to races with the save
process, during which the same mutex is acquired.
PiperOrigin-RevId: 340789616 |
259,885 | 05.11.2020 12:05:36 | 28,800 | a00c5df98bb9a3df2eb1669c0f97778bb5067c92 | Deflake semaphore_test.
Disable saving in tests that wait for EINTR.
Do not execute async-signal-unsafe code after fork() (see fork(2)'s manpage,
"After a fork in a multithreaded program ...")
Check for errors returned by semctl(GETZCNT). | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/semaphore.cc",
"new_path": "test/syscalls/linux/semaphore.cc",
"diff": "@@ -543,13 +543,17 @@ TEST(SemaphoreTest, SemCtlIpcStat) {\nSyscallFailsWithErrno(EACCES));\n}\n-// The funcion keeps calling semctl's GETZCNT command until\n-// the re... | Go | Apache License 2.0 | google/gvisor | Deflake semaphore_test.
- Disable saving in tests that wait for EINTR.
- Do not execute async-signal-unsafe code after fork() (see fork(2)'s manpage,
"After a fork in a multithreaded program ...")
- Check for errors returned by semctl(GETZCNT).
PiperOrigin-RevId: 340901353 |
259,907 | 05.11.2020 17:09:28 | 28,800 | f27edcc708e412b5c5bbeb0c274837af94c625cc | [runtime tests] Add partitions to runtime tests.
This will allow us to run massive runtime tests live java to run in parallel
across multiple jobs. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -156,12 +156,24 @@ syscall-tests: ## Run all system call tests.\n@$(call submake,test TARGETS=\"test/syscalls/...\")\n%-runtime-tests: load-runtimes_%\n+ifeq ($(PARTITION),)\n+ @$(eval PARTITION := 1)\n+endif\n+if... | Go | Apache License 2.0 | google/gvisor | [runtime tests] Add partitions to runtime tests.
This will allow us to run massive runtime tests live java to run in parallel
across multiple jobs.
PiperOrigin-RevId: 340956246 |
259,992 | 05.11.2020 18:16:11 | 28,800 | 62b0e845b7301da7d0c75eb812e9cd75ade05b74 | Return failure when `runsc events` queries a stopped container
This was causing gvisor-containerd-shim to crash because the command
suceeded, but there was no stat present. | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/runsc/BUILD",
"new_path": "pkg/shim/runsc/BUILD",
"diff": "@@ -10,6 +10,7 @@ go_library(\n],\nvisibility = [\"//:sandbox\"],\ndeps = [\n+ \"@com_github_containerd_containerd//log:go_default_library\",\n\"@com_github_containerd_go_runc//:go_default_lib... | Go | Apache License 2.0 | google/gvisor | Return failure when `runsc events` queries a stopped container
This was causing gvisor-containerd-shim to crash because the command
suceeded, but there was no stat present.
PiperOrigin-RevId: 340964921 |
259,992 | 05.11.2020 19:04:28 | 28,800 | 0e8fdfd3885bda36c0cb9225a107f1ee30c6c65f | Re-add start/stop container tests
Due to a type doDestroyNotStartedTest was being tested
2x instead of doDestroyStartingTest. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -1976,11 +1976,11 @@ func doDestroyNotStartedTest(t *testing.T, vfs2 bool) {\n// TestDestroyStarting attempts to force a race between start and destroy.\nfunc Test... | Go | Apache License 2.0 | google/gvisor | Re-add start/stop container tests
Due to a type doDestroyNotStartedTest was being tested
2x instead of doDestroyStartingTest.
PiperOrigin-RevId: 340969797 |
259,962 | 05.11.2020 19:05:14 | 28,800 | 06e33cd737c59623ddcca60eacefb112fc1a0cd4 | Cache addressEndpoint.addr.Subnet() to avoid allocations.
This change adds a Subnet() method to AddressableEndpoint so that we
can avoid repeated calls to AddressableEndpoint.AddressWithPrefix().Subnet().
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -692,7 +692,7 @@ func (e *endpoint) AcquireAssignedAddress(localAddr tcpip.Address, allowTemp boo\nloopback := e.nic.IsLoopback()\naddressEndpoint := e.mu.addressableEnd... | Go | Apache License 2.0 | google/gvisor | Cache addressEndpoint.addr.Subnet() to avoid allocations.
This change adds a Subnet() method to AddressableEndpoint so that we
can avoid repeated calls to AddressableEndpoint.AddressWithPrefix().Subnet().
Updates #231
PiperOrigin-RevId: 340969877 |
259,885 | 06.11.2020 00:18:34 | 28,800 | 29683f359822310d0f81a5c0f6ccaf98d6c284a3 | Cap iovec array length in //pkg/sentry/hostfd. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/hostfd/BUILD",
"new_path": "pkg/sentry/hostfd/BUILD",
"diff": "@@ -6,10 +6,12 @@ go_library(\nname = \"hostfd\",\nsrcs = [\n\"hostfd.go\",\n+ \"hostfd_linux.go\",\n\"hostfd_unsafe.go\",\n],\nvisibility = [\"//pkg/sentry:internal\"],\ndeps = [\n+ \"/... | Go | Apache License 2.0 | google/gvisor | Cap iovec array length in //pkg/sentry/hostfd.
PiperOrigin-RevId: 341001328 |
260,004 | 06.11.2020 01:45:12 | 28,800 | 955e09dfbdb8a4cdae0a0b625001a567f6f15758 | Do not send to the zero port
Port 0 is not meant to identify any remote port so attempting to send
a packet to it should return an error. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -487,6 +487,11 @@ func (e *endpoint) write(p tcpip.Payloader, opts tcpip.WriteOptions) (int64, <-c\nnicID = e.BindNICID\n}\n+ if to.Port == 0 {\n+ // Port 0 is... | Go | Apache License 2.0 | google/gvisor | Do not send to the zero port
Port 0 is not meant to identify any remote port so attempting to send
a packet to it should return an error.
PiperOrigin-RevId: 341009528 |
259,860 | 06.11.2020 12:59:44 | 28,800 | bcd883f095d62ef790889e5516adc4f437512726 | Avoid extra DecRef on kernfs root for "kept" dentries.
The root dentry was not created through Inode.Lookup, so we should not
release a reference even if inode.Keep() is true. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -264,7 +264,7 @@ func (fs *Filesystem) Release(ctx context.Context) {\n//\n// Precondition: Filesystem.mu is held.\nfunc (d *Dentry) releaseKeptDentriesL... | Go | Apache License 2.0 | google/gvisor | Avoid extra DecRef on kernfs root for "kept" dentries.
The root dentry was not created through Inode.Lookup, so we should not
release a reference even if inode.Keep() is true.
PiperOrigin-RevId: 341103220 |
259,962 | 06.11.2020 13:53:21 | 28,800 | 9e82747d62e57ee7498c8f3f54c313917891273a | Return early in walkSACK if segment has no SACK blocks.
This avoids a needless allocation.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -1285,6 +1285,10 @@ func (s *sender) checkDuplicateAck(seg *segment) (rtx bool) {\n// See: https://tools.ietf.org/html/draft-ietf-tcpm-rack-08#section-7.2\n// steps 2 an... | Go | Apache License 2.0 | google/gvisor | Return early in walkSACK if segment has no SACK blocks.
This avoids a needless allocation.
Updates #231
PiperOrigin-RevId: 341113160 |
259,975 | 06.11.2020 15:44:38 | 28,800 | 6c93dc970f0acc110ae4f941574defa4aa113116 | Add pull image statment to benchmarks rule. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -291,7 +291,7 @@ init-benchmark-table: ## Initializes a BigQuery table with the benchmark schema\n--dataset=$(BENCHMARKS_DATASET) --table=$(BENCHMARKS_TABLE)\")\n.PHONY: init-benchmark-table\n-benchmark-platforms:... | Go | Apache License 2.0 | google/gvisor | Add pull image statment to benchmarks rule.
PiperOrigin-RevId: 341132662 |
260,004 | 06.11.2020 15:59:02 | 28,800 | 5288e194156a72a3efae7794e46e44f1dd0d7427 | Trim link headers from buffer clone when sniffing | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sniffer/sniffer.go",
"new_path": "pkg/tcpip/link/sniffer/sniffer.go",
"diff": "@@ -205,7 +205,12 @@ func logPacket(prefix string, protocol tcpip.NetworkProtocolNumber, pkt *stack.P\n//\n// We don't clone the original packet buffer so that the ne... | Go | Apache License 2.0 | google/gvisor | Trim link headers from buffer clone when sniffing
PiperOrigin-RevId: 341135083 |
259,875 | 06.11.2020 18:36:03 | 28,800 | 3ac00fe9c3396f07a1416ff7fc855f6f9a3c4304 | Implement command GETNCNT for semctl. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "@@ -103,6 +103,7 @@ type waiter struct {\nwaiterEntry\n// value represents how much resource the waiter needs to wake up.\n+ // The value is either 0 or... | Go | Apache License 2.0 | google/gvisor | Implement command GETNCNT for semctl.
PiperOrigin-RevId: 341154192 |
259,907 | 06.11.2020 18:50:33 | 28,800 | fe9442d3270d14c095932d917e4e53e706866217 | [vfs] Return EEXIST when file already exists and rp.MustBeDir() is true.
This is consistent with what Linux does. This was causing a PHP runtime test
failure. Fixed it for VFS2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -371,9 +371,6 @@ func (fs *filesystem) doCreateAt(ctx context.Context, rp *vfs.ResolvingPath, dir\nif len(name) > maxFilenameLen {\nreturn syserror.ENAMETO... | Go | Apache License 2.0 | google/gvisor | [vfs] Return EEXIST when file already exists and rp.MustBeDir() is true.
This is consistent with what Linux does. This was causing a PHP runtime test
failure. Fixed it for VFS2.
PiperOrigin-RevId: 341155209 |
259,885 | 06.11.2020 23:20:08 | 28,800 | 78cce3a46b953cab00731f8afacf7e9e7f4dc751 | Allow VFS2 gofer.dentries to have separate read and write FDs.
This is necessary to allow writes to files opened with O_WRONLY to go through
host FDs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/directory.go",
"new_path": "pkg/sentry/fsimpl/gofer/directory.go",
"diff": "@@ -98,7 +98,9 @@ func (d *dentry) createSyntheticChildLocked(opts *createSyntheticOpts) {\nuid: uint32(opts.kuid),\ngid: uint32(opts.kgid),\nblockSize: usermem... | Go | Apache License 2.0 | google/gvisor | Allow VFS2 gofer.dentries to have separate read and write FDs.
This is necessary to allow writes to files opened with O_WRONLY to go through
host FDs.
PiperOrigin-RevId: 341174509 |
259,891 | 09.11.2020 10:48:16 | 28,800 | 16caaf79f8f85233c6921d1ee953f365007d7a68 | iptables: add documentation about enabing docker ipv6 | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/README.md",
"new_path": "test/iptables/README.md",
"diff": "iptables tests are run via `make iptables-tests`.\n-iptables requires raw socket support, so you must add the `--net-raw=true` flag\n-to `/etc/docker/daemon.json` in order to use it.\n+i... | Go | Apache License 2.0 | google/gvisor | iptables: add documentation about enabing docker ipv6
PiperOrigin-RevId: 341439435 |
259,853 | 09.11.2020 12:13:13 | 28,800 | cbca5b2edde0920309029a0c591f28ce65cdad70 | Print a debug message if /sys/kernel/debug/kcov is available
This will help to debug: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/sys/sys.go",
"new_path": "pkg/sentry/fsimpl/sys/sys.go",
"diff": "@@ -23,6 +23,7 @@ import (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/coverage\"\n+ \"gvisor.dev/gvisor/pkg/log\"\n\"gviso... | Go | Apache License 2.0 | google/gvisor | Print a debug message if /sys/kernel/debug/kcov is available
This will help to debug:
https://syzkaller.appspot.com/bug?id=0d717bd7028dceeb4b38f09aab2841c398b41d81
PiperOrigin-RevId: 341458715 |
259,898 | 09.11.2020 13:14:23 | 28,800 | c59bdd18d521ebb3c8dedf03a6adfa56dd6245c7 | parameterize regexp in netdevs.ParseDevices | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/netdevs/netdevs.go",
"new_path": "test/packetimpact/netdevs/netdevs.go",
"diff": "@@ -43,14 +43,10 @@ var (\ninet6Line = regexp.MustCompile(`^\\s*inet6 ([0-9a-fA-F:/]+)`)\n)\n-// ParseDevices parses the output from `ip addr show` into a map f... | Go | Apache License 2.0 | google/gvisor | parameterize regexp in netdevs.ParseDevices
PiperOrigin-RevId: 341470647 |
259,853 | 09.11.2020 13:55:28 | 28,800 | 2fcca60a7bf084a28e878941d9dcb47e11268cbd | net: connect to the ipv4 localhost returns ENETUNREACH if the address isn't set
cl/340002915 modified the code to return EADDRNOTAVAIL if connect
is called for a localhost address which isn't set.
But actually, Linux returns EADDRNOTAVAIL for ipv6 addresses and ENETUNREACH
for ipv4 addresses.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1418,7 +1418,7 @@ func (s *Stack) FindRoute(id tcpip.NICID, localAddr, remoteAddr tcpip.Address, n\nif needRoute {\nreturn Route{}, tcpip.ErrNoRoute\n}\n- if isLoopback {\n+ if hea... | Go | Apache License 2.0 | google/gvisor | net: connect to the ipv4 localhost returns ENETUNREACH if the address isn't set
cl/340002915 modified the code to return EADDRNOTAVAIL if connect
is called for a localhost address which isn't set.
But actually, Linux returns EADDRNOTAVAIL for ipv6 addresses and ENETUNREACH
for ipv4 addresses.
Updates #4735
PiperOrigin-RevId: 341479129 |
259,858 | 09.11.2020 19:11:12 | 28,800 | b2d5b71ecdf7a7e07210b74610b5432b6f93f38d | Evaluate T as a shell variable, not a Make variable. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -276,7 +276,6 @@ containerd-tests: containerd-test-1.4.0-beta.0\n## BENCHMARKS_OFFICIAL - marks the data as official.\n## BENCHMARKS_PLATFORMS - platforms to run benchmarks (e.g. ptrace kvm).\n##\n-RUNTIME_ARGS :=... | Go | Apache License 2.0 | google/gvisor | Evaluate T as a shell variable, not a Make variable.
PiperOrigin-RevId: 341531230 |
260,024 | 09.11.2020 21:57:30 | 28,800 | 3b353ff0ef09caf53037a68a055418c7028557e7 | Additions to ICMP and IPv4 parsers
Teach ICMP.Parser/ToBytes to handle some non echo ICMP packets.
Teach IPv4.Parser that fragments only have a payload, not an upper layer.
Fix IPv4 and IPv6 reassembly tests to handle the change.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/layers.go",
"new_path": "test/packetimpact/testbench/layers.go",
"diff": "@@ -402,6 +402,10 @@ func parseIPv4(b []byte) (Layer, layerParser) {\nDstAddr: Address(h.DestinationAddress()),\n}\nvar nextParser layerParser\n+ // If it is ... | Go | Apache License 2.0 | google/gvisor | Additions to ICMP and IPv4 parsers
Teach ICMP.Parser/ToBytes to handle some non echo ICMP packets.
Teach IPv4.Parser that fragments only have a payload, not an upper layer.
Fix IPv4 and IPv6 reassembly tests to handle the change.
Fixes #4758
PiperOrigin-RevId: 341549665 |
259,860 | 10.11.2020 09:55:46 | 28,800 | e998b9904f35cca5df468e11a7da7c2d7de5f0e7 | Add logging to internal gvisor when checking for kcov.
May help with debugging | [
{
"change_type": "MODIFY",
"old_path": "pkg/coverage/BUILD",
"new_path": "pkg/coverage/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nsrcs = [\"coverage.go\"],\nvisibility = [\"//:sandbox\"],\ndeps = [\n+ \"//pkg/log\",\n\"//pkg/sync\",\n\"//pkg/usermem\",\n\"@io_bazel_rules_go//go/tools/coverdata\",... | Go | Apache License 2.0 | google/gvisor | Add logging to internal gvisor when checking for kcov.
May help with debugging
https://syzkaller.appspot.com/bug?id=0d717bd7028dceeb4b38f09aab2841c398b41d81
PiperOrigin-RevId: 341640485 |
259,975 | 10.11.2020 11:25:17 | 28,800 | 267d18408461350e41d914467608dfc418e61f05 | Add all base and fs tests to Continuous Tests. | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -64,9 +64,12 @@ build_test(\n\"//test/e2e:integration_test\",\n\"//test/image:image_test\",\n\"//test/root:root_test\",\n- \"//test/benchmarks/base:base_test\",\n+ \"//test/benchmarks/base:startup_test\",\n+ \"//test/be... | Go | Apache License 2.0 | google/gvisor | Add all base and fs tests to Continuous Tests.
PiperOrigin-RevId: 341660511 |
259,858 | 10.11.2020 11:59:15 | 28,800 | a0e2966df502360067b45c24c90951efaf4a942c | Show run-benchmark output. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -304,16 +304,15 @@ benchmark-platforms: load-benchmarks-images ## Runs benchmarks for runc and all\n.PHONY: benchmark-platforms\nrun-benchmark: ## Runs single benchmark and optionally sends data to BigQuery.\n- @T... | Go | Apache License 2.0 | google/gvisor | Show run-benchmark output.
PiperOrigin-RevId: 341667792 |
259,975 | 10.11.2020 21:18:57 | 28,800 | 792cbc06de41f226f76f55a828dfcfad9b8fb16e | Add debug logs to startup benchmark. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -283,7 +283,7 @@ BENCHMARKS_SUITE := start\nBENCHMARKS_UPLOAD := false\nBENCHMARKS_OFFICIAL := false\nBENCHMARKS_PLATFORMS := ptrace\n-BENCHMARKS_TARGETS := //test/benchmarks/base:base_test\n+BENCHMARKS_TARGETS :=... | Go | Apache License 2.0 | google/gvisor | Add debug logs to startup benchmark.
PiperOrigin-RevId: 341757694 |
260,019 | 12.11.2020 03:52:30 | 0 | b7de12fc03c6abde6d39b8bb326fc97cbc455901 | kvm-test: adjust the check logic in TestWrongVCPU case | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm_test.go",
"new_path": "pkg/sentry/platform/kvm/kvm_test.go",
"diff": "@@ -412,9 +412,10 @@ func TestWrongVCPU(t *testing.T) {\n// Basic test, one then the other.\nbluepill(c1)\nbluepill(c2)\n- if c2.guestExits == 0 {\n+ if c1.guestE... | Go | Apache License 2.0 | google/gvisor | kvm-test: adjust the check logic in TestWrongVCPU case
Signed-off-by: Robin Luk <lubin.lu@alibaba-inc.com> |
259,885 | 11.11.2020 22:43:33 | 28,800 | ac62743e380c90255fbca6b76d899c3b7cf70877 | Read fsimpl/tmpfs timestamps atomically. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"diff": "@@ -478,9 +478,9 @@ func (i *inode) statTo(stat *linux.Statx) {\nstat.GID = atomic.LoadUint32(&i.gid)\nstat.Mode = uint16(atomic.LoadUint32(&i.mode))\nstat.Ino = i.ino\... | Go | Apache License 2.0 | google/gvisor | Read fsimpl/tmpfs timestamps atomically.
PiperOrigin-RevId: 341982672 |
259,907 | 12.11.2020 16:28:17 | 28,800 | 2a1974b07613420cb95845052815afb51187fc85 | [infra] Do not use debug flags for testing.
This causes some networking related tests to take a very long time.
Upon failure, tests can be manually run with debug flags to debug. As is the
strace logs are not available from a test run. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -162,7 +162,7 @@ endif\nifeq ($(TOTAL_PARTITIONS),)\n@$(eval TOTAL_PARTITIONS := 1)\nendif\n- @$(call submake,install-test-runtime)\n+ @$(call submake,install-runtime)\n@$(call submake,test-runtime OPTIONS=\"--tes... | Go | Apache License 2.0 | google/gvisor | [infra] Do not use debug flags for testing.
This causes some networking related tests to take a very long time.
Upon failure, tests can be manually run with debug flags to debug. As is the
strace logs are not available from a test run.
PiperOrigin-RevId: 342156294 |
259,885 | 12.11.2020 16:54:22 | 28,800 | ae7ab0a330aaa1676d1fe066e3f5ac5fe805ec1c | Filter dentries with non-zero refs in VFS2 gofer/overlay checks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -114,6 +114,51 @@ func putDentrySlice(ds *[]*dentry) {\ndentrySlicePool.Put(ds)\n}\n+// renameMuRUnlockAndCheckCaching calls fs.renameMu.RUnlock(), then ca... | Go | Apache License 2.0 | google/gvisor | Filter dentries with non-zero refs in VFS2 gofer/overlay checks.
PiperOrigin-RevId: 342161204 |
259,992 | 12.11.2020 17:42:45 | 28,800 | 74be0dd0d59d468a9ebdcdf52f68eda78f4ea42a | Remove TESTONLY tag from vfs2 flag
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/config/flags.go",
"new_path": "runsc/config/flags.go",
"diff": "@@ -71,7 +71,7 @@ func RegisterFlags() {\nflag.Bool(\"overlay\", false, \"wrap filesystem mounts with writable overlay. All modifications are stored in memory inside the sandbox.\")\nflag.Bo... | Go | Apache License 2.0 | google/gvisor | Remove TESTONLY tag from vfs2 flag
Updates #1035
PiperOrigin-RevId: 342168926 |
260,024 | 12.11.2020 17:46:37 | 28,800 | d700ba22abb9e5f29749cc3843991c31dc00384d | Pad with a loop rather than a copy from an allocation.
Add a unit test for ipv4.Encode and a round trip test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv4.go",
"new_path": "pkg/tcpip/header/ipv4.go",
"diff": "@@ -374,8 +374,14 @@ func (b IPv4) Encode(i *IPv4Fields) {\nif hdrLen > len(b) {\npanic(fmt.Sprintf(\"encode received %d bytes, wanted >= %d\", len(b), hdrLen))\n}\n- if aLen != copy(b... | Go | Apache License 2.0 | google/gvisor | Pad with a loop rather than a copy from an allocation.
Add a unit test for ipv4.Encode and a round trip test.
PiperOrigin-RevId: 342169517 |
260,024 | 12.11.2020 18:36:45 | 28,800 | 638d64c6337d05b91f0bde81de8e1c8d6d9908d8 | Change AllocationSize to SizeWithPadding as requested
RELNOTES: n/a | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv4.go",
"new_path": "pkg/tcpip/header/ipv4.go",
"diff": "@@ -275,12 +275,12 @@ func (b IPv4) DestinationAddress() tcpip.Address {\n// IPv4Options is a buffer that holds all the raw IP options.\ntype IPv4Options []byte\n-// AllocationSize imp... | Go | Apache License 2.0 | google/gvisor | Change AllocationSize to SizeWithPadding as requested
RELNOTES: n/a
PiperOrigin-RevId: 342176296 |
259,885 | 12.11.2020 19:10:01 | 28,800 | bf392dcc7d7b1f256acfe8acd2758a77db3fc8a2 | Allow goid.Get() to be used outside of race builds. | [
{
"change_type": "MODIFY",
"old_path": "pkg/goid/BUILD",
"new_path": "pkg/goid/BUILD",
"diff": "@@ -8,8 +8,6 @@ go_library(\n\"goid.go\",\n\"goid_amd64.s\",\n\"goid_arm64.s\",\n- \"goid_race.go\",\n- \"goid_unsafe.go\",\n],\nvisibility = [\"//visibility:public\"],\n)\n@@ -18,7 +16,6 @@ go_test(\nnam... | Go | Apache License 2.0 | google/gvisor | Allow goid.Get() to be used outside of race builds.
PiperOrigin-RevId: 342179912 |
260,023 | 12.11.2020 23:02:15 | 28,800 | 8e6963491c7bc9b98fc7bcff5024089726a9c204 | Deflake tcp_socket test.
Increase the wait time for the thread to be blocked on read/write
syscall. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tcp_socket.cc",
"new_path": "test/syscalls/linux/tcp_socket.cc",
"diff": "@@ -467,7 +467,7 @@ TEST_P(TcpSocketTest, PollWithFullBufferBlocks) {\nTEST_P(TcpSocketTest, ClosedWriteBlockingSocket) {\nFillSocketBuffers(first_fd, second_fd);\n- ... | Go | Apache License 2.0 | google/gvisor | Deflake tcp_socket test.
Increase the wait time for the thread to be blocked on read/write
syscall.
PiperOrigin-RevId: 342204627 |
259,853 | 13.11.2020 00:46:16 | 28,800 | cc1b20590cf4505e04b8c221d1d950e45110f5f0 | fs/tmpfs: use atomic operations to access inode.mode | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"diff": "@@ -631,7 +631,8 @@ func (i *inode) direntType() uint8 {\n}\nfunc (i *inode) isDir() bool {\n- return linux.FileMode(i.mode).FileType() == linux.S_IFDIR\n+ mode := linu... | Go | Apache License 2.0 | google/gvisor | fs/tmpfs: use atomic operations to access inode.mode
PiperOrigin-RevId: 342214859 |
259,853 | 13.11.2020 01:49:36 | 28,800 | e869e2c7cddca0337b6dfb28584b05ee1b225a7f | fs/tmpfs: change regularFile.size atomically | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"diff": "@@ -565,7 +565,7 @@ func (rw *regularFileReadWriter) ReadToBlocks(dsts safemem.BlockSeq) (uint64, er\n// WriteFromBlocks implements safemem.Writer.WriteFr... | Go | Apache License 2.0 | google/gvisor | fs/tmpfs: change regularFile.size atomically
PiperOrigin-RevId: 342221309 |
259,885 | 13.11.2020 01:52:59 | 28,800 | 280cf46874cd8f4bd4fa16125aa6c0914b888deb | Minor fdchannel fixes.
Don't close fdchannel.Endpoint.sockfd in Shutdown(), while it still may be in
use.
Don't call runtime.enter/exitsyscall from RecvFDNonblock(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/fdchannel/fdchannel_unsafe.go",
"new_path": "pkg/fdchannel/fdchannel_unsafe.go",
"diff": "@@ -21,7 +21,6 @@ package fdchannel\nimport (\n\"fmt\"\n\"reflect\"\n- \"sync/atomic\"\n\"syscall\"\n\"unsafe\"\n)\n@@ -41,7 +40,7 @@ func NewConnectedSockets() ([2]i... | Go | Apache License 2.0 | google/gvisor | Minor fdchannel fixes.
- Don't close fdchannel.Endpoint.sockfd in Shutdown(), while it still may be in
use.
- Don't call runtime.enter/exitsyscall from RecvFDNonblock().
PiperOrigin-RevId: 342221770 |
259,885 | 13.11.2020 12:22:38 | 28,800 | d5e17d2dbc2809c6d70153f0d4c996eff899e69d | Disable save/restore in PartialBadBufferTest.SendMsgTCP. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/partial_bad_buffer.cc",
"new_path": "test/syscalls/linux/partial_bad_buffer.cc",
"diff": "@@ -320,7 +320,10 @@ PosixErrorOr<sockaddr_storage> InetLoopbackAddr(int family) {\n// EFAULT. It also verifies that passing a buffer which is made up... | Go | Apache License 2.0 | google/gvisor | Disable save/restore in PartialBadBufferTest.SendMsgTCP.
PiperOrigin-RevId: 342314586 |
260,004 | 13.11.2020 13:10:51 | 28,800 | 6c0f53002a7f3a518befbe667d308c3d64cc9a59 | Decrement TTL/Hop Limit when forwarding IP packets
If the packet must no longer be forwarded because its TTL/Hop Limit
reaches 0, send an ICMP Time Exceeded error to the source.
Required as per relevant RFCs. See comments in code for RFC references.
Fixes
Tests:
- ipv4_test.TestForwarding
- ipv6.TestForwarding | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/checker.go",
"new_path": "pkg/tcpip/checker/checker.go",
"diff": "@@ -904,6 +904,12 @@ func ICMPv4Payload(want []byte) TransportChecker {\nt.Fatalf(\"unexpected transport header passed to checker, got = %T, want = header.ICMPv4\", h)\n}\npayl... | Go | Apache License 2.0 | google/gvisor | Decrement TTL/Hop Limit when forwarding IP packets
If the packet must no longer be forwarded because its TTL/Hop Limit
reaches 0, send an ICMP Time Exceeded error to the source.
Required as per relevant RFCs. See comments in code for RFC references.
Fixes #1085
Tests:
- ipv4_test.TestForwarding
- ipv6.TestForwarding
PiperOrigin-RevId: 342323610 |
259,896 | 13.11.2020 13:57:02 | 28,800 | 839dd97008bacf526c05afa542e67c94f8b399ea | RACK: Detect DSACK
Detect if the ACK is a duplicate and update in RACK. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -82,6 +82,7 @@ type TCPRACKState struct {\nFACK seqnum.Value\nRTT time.Duration\nReord bool\n+ DSACKSeen bool\n}\n// TCPEndpointID is the unique 4 tuple that identifies a given endp... | Go | Apache License 2.0 | google/gvisor | RACK: Detect DSACK
Detect if the ACK is a duplicate and update in RACK.
PiperOrigin-RevId: 342332569 |
259,885 | 13.11.2020 14:29:47 | 28,800 | 89517eca414a311598aa6e64a229c7acc5e3a22f | Have fuse.DeviceFD hold reference on fuse.filesystem.
This is actually just b/168751672 again; cl/332394146 was incorrectly reverted
by cl/341411151. Document the reference holder to reduce the likelihood that
this happens again.
Also document a few other bugs observed in the process. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection.go",
"diff": "@@ -21,7 +21,6 @@ import (\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/log\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel\"\n- \"gvisor.dev/gvisor/pkg... | Go | Apache License 2.0 | google/gvisor | Have fuse.DeviceFD hold reference on fuse.filesystem.
This is actually just b/168751672 again; cl/332394146 was incorrectly reverted
by cl/341411151. Document the reference holder to reduce the likelihood that
this happens again.
Also document a few other bugs observed in the process.
PiperOrigin-RevId: 342339144 |
260,024 | 13.11.2020 17:11:12 | 28,800 | 0fee59c8c84bff0185e681b4550ba077a65739f2 | Requested Comment/Message wording changes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv4.go",
"new_path": "pkg/tcpip/header/ipv4.go",
"diff": "@@ -89,7 +89,17 @@ type IPv4Fields struct {\n// DstAddr is the \"destination ip address\" of an IPv4 packet.\nDstAddr tcpip.Address\n- // Options is between 0 and 40 bytes or nil if em... | Go | Apache License 2.0 | google/gvisor | Requested Comment/Message wording changes
PiperOrigin-RevId: 342366891 |
259,885 | 13.11.2020 18:09:15 | 28,800 | 182c126013a28f19594ff61326f1f9a2c481f1b4 | Log task goroutine IDs in the sentry watchdog. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_run.go",
"new_path": "pkg/sentry/kernel/task_run.go",
"diff": "@@ -390,6 +390,11 @@ func (t *Task) assertTaskGoroutine() {\n}\n}\n+// GoroutineID returns the ID of t's task goroutine.\n+func (t *Task) GoroutineID() int64 {\n+ return atom... | Go | Apache License 2.0 | google/gvisor | Log task goroutine IDs in the sentry watchdog.
PiperOrigin-RevId: 342373580 |
259,884 | 16.11.2020 00:04:07 | 28,800 | 43dd7a200569cb04c778b83df4b9007c76091756 | Fix labels on issue templates | [
{
"change_type": "MODIFY",
"old_path": ".github/ISSUE_TEMPLATE/bug_report.md",
"new_path": ".github/ISSUE_TEMPLATE/bug_report.md",
"diff": "name: Bug report\nabout: Create a bug report to help us improve\ntitle:\n-labels:\n- - 'type: bug'\n+labels: 'type: bug'\nassignees: ''\n---\n"
},
{
"ch... | Go | Apache License 2.0 | google/gvisor | Fix labels on issue templates
PiperOrigin-RevId: 342577869 |
259,992 | 16.11.2020 10:12:07 | 28,800 | 39f712f1d8a53db9d1ccbf7a894d9190edab076d | Add new shim debug options to docs | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/containerd/configuration.md",
"new_path": "g3doc/user_guide/containerd/configuration.md",
"diff": "@@ -4,41 +4,56 @@ This document describes how to configure runtime options for\n`containerd-shim-runsc-v1`. This follows the\n[Containerd Quick ... | Go | Apache License 2.0 | google/gvisor | Add new shim debug options to docs
PiperOrigin-RevId: 342662753 |
259,964 | 16.11.2020 13:05:01 | 28,800 | 758e45618f3d663a092b31baf29f24b3e4dc4d54 | Clean up fragmentation.Process
Pass a PacketBuffer directly instead of releaseCB
No longer pass a VectorisedView, which is included in the PacketBuffer
Make it an error if data size is not equal to (last - first + 1)
Set the callback for the reassembly timeout on NewFragmentation | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/parse/parse.go",
"new_path": "pkg/tcpip/header/parse/parse.go",
"diff": "@@ -109,6 +109,9 @@ traverseExtensions:\nfragOffset = extHdr.FragmentOffset()\nfragMore = extHdr.More()\n}\n+ rawPayload := it.AsRawHeader(true /* consume */)\n+ extensio... | Go | Apache License 2.0 | google/gvisor | Clean up fragmentation.Process
- Pass a PacketBuffer directly instead of releaseCB
- No longer pass a VectorisedView, which is included in the PacketBuffer
- Make it an error if data size is not equal to (last - first + 1)
- Set the callback for the reassembly timeout on NewFragmentation
PiperOrigin-RevId: 342702432 |
259,964 | 16.11.2020 13:11:36 | 28,800 | 373fd8310032ef19e05f8cc77a1eeb6fcb438da8 | Add packetimpact tests for ICMPv6 Error message for fragment
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/defs.bzl",
"new_path": "test/packetimpact/runner/defs.bzl",
"diff": "@@ -257,6 +257,9 @@ ALL_TESTS = [\nPacketimpactTestInfo(\nname = \"ipv6_fragment_reassembly\",\n),\n+ PacketimpactTestInfo(\n+ name = \"ipv6_fragment_icmp_error\",\n+... | Go | Apache License 2.0 | google/gvisor | Add packetimpact tests for ICMPv6 Error message for fragment
Updates #4427
PiperOrigin-RevId: 342703931 |
259,992 | 16.11.2020 16:29:16 | 28,800 | d48610795d94f4d1a1782bd5372cbb8e0a76931c | Allow RLIMIT_RSS to be set
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_rlimit.go",
"new_path": "pkg/sentry/syscalls/linux/sys_rlimit.go",
"diff": "@@ -90,6 +90,9 @@ var setableLimits = map[limits.LimitType]struct{}{\nlimits.FileSize: {},\nlimits.MemoryLocked: {},\nlimits.Stack: {},\n+ // RSS can be s... | Go | Apache License 2.0 | google/gvisor | Allow RLIMIT_RSS to be set
Closes #4746
PiperOrigin-RevId: 342747165 |
259,885 | 16.11.2020 18:52:20 | 28,800 | 267560d159b299a17f626029d7091ab923afeef6 | Reset watchdog timer between sendfile() iterations.
As part of this, change Task.interrupted() to not drain Task.interruptChan, and
do so explicitly using new function Task.unsetInterrupted() instead. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_block.go",
"new_path": "pkg/sentry/kernel/task_block.go",
"diff": "@@ -177,19 +177,23 @@ func (t *Task) SleepStart() <-chan struct{} {\n// SleepFinish implements context.ChannelSleeper.SleepFinish.\nfunc (t *Task) SleepFinish(success boo... | Go | Apache License 2.0 | google/gvisor | Reset watchdog timer between sendfile() iterations.
As part of this, change Task.interrupted() to not drain Task.interruptChan, and
do so explicitly using new function Task.unsetInterrupted() instead.
PiperOrigin-RevId: 342768365 |
259,885 | 16.11.2020 18:53:32 | 28,800 | 938aabeecb935771ab5be5eca5acff0bd19ebc97 | Minor flipcall refactoring. | [
{
"change_type": "MODIFY",
"old_path": "pkg/flipcall/ctrl_futex.go",
"new_path": "pkg/flipcall/ctrl_futex.go",
"diff": "@@ -40,71 +40,104 @@ func (ep *Endpoint) ctrlInit(opts ...EndpointOption) error {\nreturn nil\n}\n-type ctrlHandshakeRequest struct{}\n-\n-type ctrlHandshakeResponse struct{}\n-\nf... | Go | Apache License 2.0 | google/gvisor | Minor flipcall refactoring.
PiperOrigin-RevId: 342768550 |
260,019 | 17.11.2020 14:53:50 | -28,800 | 170b5842225176d3fa981e7d8628c1dda4a4f504 | arm64 kvm: add the processing functions for all el0/el1 exceptions
I added 2 unified processing functions for all exceptions of el/el0 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_arm64_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/machine_arm64_unsafe.go",
"diff": "@@ -263,13 +263,6 @@ func (c *vCPU) SwitchToUser(switchOpts ring0.SwitchOpts, info *arch.SignalInfo)\nreturn usermem.NoAccess, platform.Er... | Go | Apache License 2.0 | google/gvisor | arm64 kvm: add the processing functions for all el0/el1 exceptions
I added 2 unified processing functions for all exceptions of el/el0
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
260,019 | 17.11.2020 16:05:12 | -28,800 | 05d5e3cb2baaa9c91397b802c0cace45384b91fc | arm64 kvm: optimize all fpsimd related code
Optimize and bug fix all fpsimd related code. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/kernel_arm64.go",
"new_path": "pkg/sentry/platform/ring0/kernel_arm64.go",
"diff": "@@ -61,11 +61,13 @@ func (c *CPU) SwitchToUser(switchOpts SwitchOpts) (vector Vector) {\nregs.Pstate &= ^uint64(PsrFlagsClear)\nregs.Pstate |= UserFla... | Go | Apache License 2.0 | google/gvisor | arm64 kvm: optimize all fpsimd related code
Optimize and bug fix all fpsimd related code.
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
260,001 | 17.11.2020 14:26:52 | 28,800 | 2d89f234029d9e020bc12b78c29ce1abd58fb4c7 | Add consistent precondition formatting for verity
Also add the lock order for verity fs, and add a lock to protect dentry
hash. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -107,8 +107,10 @@ func (fs *filesystem) renameMuUnlockAndCheckDrop(ctx context.Context, ds **[]*de\n// Dentries which may have a reference count of zero,... | Go | Apache License 2.0 | google/gvisor | Add consistent precondition formatting for verity
Also add the lock order for verity fs, and add a lock to protect dentry
hash.
PiperOrigin-RevId: 342946537 |
259,927 | 17.11.2020 14:43:45 | 28,800 | 7492ed6bd63cd4f3b7c81a45b13b053b840f6d50 | Add per-sniffer instance log prefix
A prefix associated with a sniffer instance can help debug situations where
more than one NIC (i.e. more than one sniffer) exists. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sniffer/sniffer.go",
"new_path": "pkg/tcpip/link/sniffer/sniffer.go",
"diff": "@@ -53,16 +53,35 @@ type endpoint struct {\nnested.Endpoint\nwriter io.Writer\nmaxPCAPLen uint32\n+ logPrefix string\n}\nvar _ stack.GSOEndpoint = (*endpoint)(nil)\nv... | Go | Apache License 2.0 | google/gvisor | Add per-sniffer instance log prefix
A prefix associated with a sniffer instance can help debug situations where
more than one NIC (i.e. more than one sniffer) exists.
PiperOrigin-RevId: 342950027 |
259,853 | 17.11.2020 14:53:06 | 28,800 | 10ba578c018294bb037a7eb90010491cdda270a7 | tmpfs: make sure that a dentry will not be destroyed before the open() call
If we don't hold a reference, the dentry can be destroyed by another thread.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -381,6 +381,8 @@ afterTrailingSymlink:\ncreds := rp.Credentials()\nchild := fs.newDentry(fs.newRegularFile(creds.EffectiveKUID, creds.EffectiveKGID, opts.M... | Go | Apache License 2.0 | google/gvisor | tmpfs: make sure that a dentry will not be destroyed before the open() call
If we don't hold a reference, the dentry can be destroyed by another thread.
Reported-by: syzbot+f2132e50060c41f6d41f@syzkaller.appspotmail.com
PiperOrigin-RevId: 342951940 |
259,853 | 17.11.2020 19:00:36 | 28,800 | 05223889bd74faf0f3967e58fa11e3bdf1a518d7 | fs/fuse: don't dereference fuse.DeviceFD.fs if it is nil | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/dev.go",
"new_path": "pkg/sentry/fsimpl/fuse/dev.go",
"diff": "@@ -363,7 +363,7 @@ func (fd *DeviceFD) Readiness(mask waiter.EventMask) waiter.EventMask {\nfunc (fd *DeviceFD) readinessLocked(mask waiter.EventMask) waiter.EventMask {\nva... | Go | Apache License 2.0 | google/gvisor | fs/fuse: don't dereference fuse.DeviceFD.fs if it is nil
PiperOrigin-RevId: 342992936 |
259,962 | 17.11.2020 22:56:44 | 28,800 | 0e32d98f3a5d4f81459635efcaa53898f43996b9 | Fix endpoint.Read() when endpoint is in StateError.
If the endpoint is in StateError but e.hardErrorLocked() returns
nil then return ErrClosedForRecieve.
This can happen if a concurrent write on the same endpoint was in progress
when the endpoint transitioned to an error state. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1330,7 +1330,10 @@ func (e *endpoint) Read(*tcpip.FullAddress) (buffer.View, tcpip.ControlMessages,\nif s := e.EndpointState(); !s.connected() && s != StateCl... | Go | Apache License 2.0 | google/gvisor | Fix endpoint.Read() when endpoint is in StateError.
If the endpoint is in StateError but e.hardErrorLocked() returns
nil then return ErrClosedForRecieve.
This can happen if a concurrent write on the same endpoint was in progress
when the endpoint transitioned to an error state.
PiperOrigin-RevId: 343018257 |
259,962 | 17.11.2020 23:31:49 | 28,800 | a5e3fd1b29e14083cd558def8c0f7f283a33fa9e | Remove sniffer from gonet_test.
This was added by mistake in cl/342868552. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/BUILD",
"new_path": "pkg/tcpip/adapters/gonet/BUILD",
"diff": "@@ -26,7 +26,6 @@ go_test(\n\"//pkg/tcpip\",\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/link/loopback\",\n- \"//pkg/tcpip/link/sniffer\",\n\"//pkg/tcpip/network/ipv4\",\n\"//p... | Go | Apache License 2.0 | google/gvisor | Remove sniffer from gonet_test.
This was added by mistake in cl/342868552.
PiperOrigin-RevId: 343021431 |
259,860 | 18.11.2020 09:40:59 | 28,800 | 87ed61ea055dde0a11b3394c2d2aa4db3f7db5c6 | Remove outdated nogo exception. | [
{
"change_type": "MODIFY",
"old_path": "nogo.yaml",
"new_path": "nogo.yaml",
"diff": "@@ -74,7 +74,6 @@ global:\n- pkg/pool/pool.go:15\n- pkg/refs/refcounter.go:510\n- pkg/refs/refcounter_test.go:169\n- - pkg/refs_vfs2/refs.go:16\n- pkg/safemem/block_unsafe.go:89\n- pkg/seccomp/seccomp.go:82\n- pkg/... | Go | Apache License 2.0 | google/gvisor | Remove outdated nogo exception.
PiperOrigin-RevId: 343096420 |
259,868 | 18.11.2020 11:44:44 | 28,800 | d6e788a8d1a3941108e127ac8b7e14d00def35c6 | Add a few syslog messages. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/syslog.go",
"new_path": "pkg/sentry/kernel/syslog.go",
"diff": "@@ -75,6 +75,12 @@ func (s *syslog) Log() []byte {\n\"Checking naughty and nice process list...\", // Check it up to twice.\n\"Granting licence to kill(2)...\", // British spelli... | Go | Apache License 2.0 | google/gvisor | Add a few syslog messages.
PiperOrigin-RevId: 343123278 |
260,004 | 18.11.2020 12:43:51 | 28,800 | 60b97bfda6b5a2730c3016c8d243d521a89b6272 | Fix loopback subnet routing error
Packets should be properly routed when sending packets to addresses
in the loopback subnet which are not explicitly assigned to the loopback
interface.
Tests:
integration_test.TestLoopbackAcceptAllInSubnetUDP
integration_test.TestLoopbackAcceptAllInSubnetTCP | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/route.go",
"new_path": "pkg/tcpip/stack/route.go",
"diff": "@@ -71,22 +71,24 @@ type Route struct {\n// ownership of the provided local address.\n//\n// Returns an empty route if validation fails.\n-func constructAndValidateRoute(netProto tcpip... | Go | Apache License 2.0 | google/gvisor | Fix loopback subnet routing error
Packets should be properly routed when sending packets to addresses
in the loopback subnet which are not explicitly assigned to the loopback
interface.
Tests:
- integration_test.TestLoopbackAcceptAllInSubnetUDP
- integration_test.TestLoopbackAcceptAllInSubnetTCP
PiperOrigin-RevId: 343135643 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.