author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,898 | 18.11.2020 13:26:47 | 28,800 | d2b701758d3fb1c39162243521e6b985f8b5ef78 | Remove the redundant containerIP parameter | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/dut.go",
"new_path": "test/packetimpact/runner/dut.go",
"diff": "@@ -96,7 +96,7 @@ func (l logger) Logf(format string, args ...interface{}) {\n}\n// TestWithDUT runs a packetimpact test with the given information.\n-func TestWithDUT(ct... | Go | Apache License 2.0 | google/gvisor | Remove the redundant containerIP parameter
PiperOrigin-RevId: 343144023 |
259,907 | 18.11.2020 13:40:23 | 28,800 | 3e73c519a55191827dcc6e98ea0ffe977acbb73f | [netstack] Move SO_NO_CHECK option to SocketOptions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1232,12 +1232,8 @@ func getSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, fam\nreturn nil, syserr.ErrInvalidArgument\n}\n- v, err ... | Go | Apache License 2.0 | google/gvisor | [netstack] Move SO_NO_CHECK option to SocketOptions.
PiperOrigin-RevId: 343146856 |
259,992 | 18.11.2020 16:04:26 | 28,800 | 7158095d687dd9ede3a3fc8da1f4dfbb2ebc176e | Fix race condition in multi-container wait test
Container is not thread-safe, locking must be done in the caller.
The test was calling Container.Wait() from multiple threads with
no synchronization.
Also removed Container.WaitPID from test because the process might
have already existed when wait is called. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -80,6 +80,7 @@ func validateID(id string) error {\n// - It calls 'runsc delete'. runc implementation kills --all SIGKILL once\n// again just to be sure, waits, and then proc... | Go | Apache License 2.0 | google/gvisor | Fix race condition in multi-container wait test
Container is not thread-safe, locking must be done in the caller.
The test was calling Container.Wait() from multiple threads with
no synchronization.
Also removed Container.WaitPID from test because the process might
have already existed when wait is called.
PiperOrigin-RevId: 343176280 |
259,853 | 18.11.2020 18:35:14 | 28,800 | 764504c38fb589738f42a852c9288725dcf0f9f9 | runsc: check whether cgroup exists or not for each controller
We have seen a case when a memory cgroup exists but a perf_event one doesn't.
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -234,7 +234,7 @@ func loadPathsHelper(cgroup io.Reader) (map[string]string, error) {\ntype Cgroup struct {\nName string `json:\"name\"`\nParents map[string]string `json:\"parents\"`\n- ... | Go | Apache License 2.0 | google/gvisor | runsc: check whether cgroup exists or not for each controller
We have seen a case when a memory cgroup exists but a perf_event one doesn't.
Reported-by: syzbot+f31468b61d1a27e629dc@syzkaller.appspotmail.com
Reported-by: syzbot+1f163ec0321768f1497e@syzkaller.appspotmail.com
PiperOrigin-RevId: 343200070 |
260,004 | 18.11.2020 20:19:31 | 28,800 | 93750a600bb01fdc90703b8fa9ea2e163c615c6c | Remove unused methods from stack.Route | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/route.go",
"new_path": "pkg/tcpip/stack/route.go",
"diff": "@@ -397,23 +397,6 @@ func (r *Route) Clone() Route {\nreturn *r\n}\n-// MakeLoopedRoute duplicates the given route with special handling for routes\n-// used for sending multicast or b... | Go | Apache License 2.0 | google/gvisor | Remove unused methods from stack.Route
PiperOrigin-RevId: 343211553 |
259,907 | 18.11.2020 21:22:43 | 28,800 | e5650d124032e38a26e4b8058778e1c5b5aacbf0 | [netstack] Move SO_KEEPALIVE and SO_ACCEPTCONN option to SocketOptions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1162,13 +1162,8 @@ func getSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, fam\nreturn nil, syserr.ErrInvalidArgument\n}\n- v, err ... | Go | Apache License 2.0 | google/gvisor | [netstack] Move SO_KEEPALIVE and SO_ACCEPTCONN option to SocketOptions.
PiperOrigin-RevId: 343217712 |
260,019 | 19.11.2020 17:58:24 | -28,800 | 4f79706ccdc8b6515ad384c5f1896f5405e9d445 | arm64 tlb: add support for tlbi-vale1ls/tlbi-aside1ls
This patch adds support for tlbi-vale1ls/tlbi-aside1ls.
And make the code consistent with the flush strategy of the x86 platform. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/kernel_arm64.go",
"new_path": "pkg/sentry/platform/ring0/kernel_arm64.go",
"diff": "@@ -53,7 +53,7 @@ func IsCanonical(addr uint64) bool {\nfunc (c *CPU) SwitchToUser(switchOpts SwitchOpts) (vector Vector) {\nstoreAppASID(uintptr(swit... | Go | Apache License 2.0 | google/gvisor | arm64 tlb: add support for tlbi-vale1ls/tlbi-aside1ls
This patch adds support for tlbi-vale1ls/tlbi-aside1ls.
And make the code consistent with the flush strategy of the x86 platform.
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
260,003 | 19.11.2020 08:54:25 | 28,800 | e8df1ccef91993be379021aec5e771577f8d9196 | Fix some code not using NewPacketBuffer for creating a PacketBuffer. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/arp_test.go",
"new_path": "pkg/tcpip/network/arp/arp_test.go",
"diff": "@@ -319,9 +319,9 @@ func TestDirectRequestWithNeighborCache(t *testing.T) {\ncopy(h.HardwareAddressSender(), test.senderLinkAddr)\ncopy(h.ProtocolAddressSender(), tes... | Go | Apache License 2.0 | google/gvisor | Fix some code not using NewPacketBuffer for creating a PacketBuffer.
PiperOrigin-RevId: 343299993 |
259,927 | 19.11.2020 09:24:42 | 28,800 | 332671c33969c067398702f61071b004b988b24b | Remove unused NoChecksumOption
Migration to unified socket options left this behind. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tcpip.go",
"new_path": "pkg/tcpip/tcpip.go",
"diff": "@@ -713,10 +713,6 @@ const (\n// will be looped back.\nMulticastLoopOption\n- // NoChecksumOption is used by SetSockOptBool/GetSockOptBool to specify\n- // whether UDP checksum is disabled for thi... | Go | Apache License 2.0 | google/gvisor | Remove unused NoChecksumOption
Migration to unified socket options left this behind.
PiperOrigin-RevId: 343305434 |
259,992 | 19.11.2020 15:08:47 | 28,800 | 209a95a35a2e4d38998962f6a351766e816805d8 | Propagate IP address prefix from host to netstack
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1118,6 +1118,16 @@ func (s *Stack) AddAddress(id tcpip.NICID, protocol tcpip.NetworkProtocolNumber,\nreturn s.AddAddressWithOptions(id, protocol, addr, CanBePrimaryEndpoint)\n}\n+/... | Go | Apache License 2.0 | google/gvisor | Propagate IP address prefix from host to netstack
Closes #4022
PiperOrigin-RevId: 343378647 |
260,024 | 19.11.2020 15:14:12 | 28,800 | 49adf36ed7d301e8cbd312eaa69ef915731c9d03 | Fix possible panic due to bad data.
Found by a Fuzzer.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -1140,6 +1140,12 @@ func handleTimestamp(tsOpt header.IPv4OptionTimestamp, localAddress tcpip.Addres\n}\npointer := tsOpt.Pointer()\n+ // RFC 791 page 22 states: \"The s... | Go | Apache License 2.0 | google/gvisor | Fix possible panic due to bad data.
Found by a Fuzzer.
Reported-by: syzbot+619fa10be366d553ef7f@syzkaller.appspotmail.com
PiperOrigin-RevId: 343379575 |
260,004 | 19.11.2020 16:17:03 | 28,800 | 4cf7956dde56b29dda4ffd2b8bcb3aa6121c71c3 | Add types to parse MLD messages
Preparing for upcoming CLs that add MLD functionality.
Bug
Test: header.TestMLD | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/BUILD",
"new_path": "pkg/tcpip/header/BUILD",
"diff": "@@ -16,6 +16,7 @@ go_library(\n\"ipv6.go\",\n\"ipv6_extension_headers.go\",\n\"ipv6_fragment.go\",\n+ \"mld.go\",\n\"ndp_neighbor_advert.go\",\n\"ndp_neighbor_solicit.go\",\n\"ndp_options.... | Go | Apache License 2.0 | google/gvisor | Add types to parse MLD messages
Preparing for upcoming CLs that add MLD functionality.
Bug #4861
Test: header.TestMLD
PiperOrigin-RevId: 343391556 |
259,860 | 19.11.2020 16:50:25 | 28,800 | d35a25cc887d2b52fb7e11ba23da6324054a43d0 | Add a helpful message in stuck task logs.
This also makes the formatting nicer; the caller will add ":\n" to the end of
the message. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -338,6 +338,7 @@ func (w *Watchdog) report(offenders map[*kernel.Task]*offender, newTaskFound boo\ntid := w.k.TaskSet().Root.IDOfTask(t)\nbuf.WriteString(fmt.Sprintf(\... | Go | Apache License 2.0 | google/gvisor | Add a helpful message in stuck task logs.
This also makes the formatting nicer; the caller will add ":\n" to the end of
the message.
PiperOrigin-RevId: 343397099 |
259,985 | 19.11.2020 16:57:17 | 28,800 | 9c553f2d4e4b0f2c3d296d0dfac6a31579b60347 | Remove racy stringification of socket fds from /proc/net/*. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/task_net.go",
"new_path": "pkg/sentry/fsimpl/proc/task_net.go",
"diff": "@@ -208,7 +208,7 @@ func (n *netUnixData) Generate(ctx context.Context, buf *bytes.Buffer) error {\nfor _, se := range n.kernel.ListSockets() {\ns := se.SockVFS2\ni... | Go | Apache License 2.0 | google/gvisor | Remove racy stringification of socket fds from /proc/net/*.
PiperOrigin-RevId: 343398191 |
260,019 | 21.11.2020 14:13:06 | -28,800 | 6a85d13ccf68c5a647683569bdb774bdb79f6872 | arm64 kvm: add to ext_dabt injection support
If no vild syndrome(data abort outside memslots) was reported by kvm, let userspace to do the
ext_dabt injection to bail out this issue. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_amd64_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_amd64_unsafe.go",
"diff": "@@ -91,6 +91,13 @@ func bluepillSigBus(c *vCPU) {\n}\n}\n+// bluepillHandleEnosys is reponsible for handling enosys error.\n+//\n+//go:n... | Go | Apache License 2.0 | google/gvisor | arm64 kvm: add to ext_dabt injection support
If no vild syndrome(data abort outside memslots) was reported by kvm, let userspace to do the
ext_dabt injection to bail out this issue.
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
259,858 | 23.11.2020 13:36:19 | 28,800 | 5d5af881103b784374f7e5231224cacbf19ec2d4 | Ignore permission failures in CheckDuplicatesRecursively.
Not all files are always accessible by the process itself. This
was specifically seen with map_files, but there's no rule that
every entry must be accessible by the process itself. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -2478,6 +2478,10 @@ void CheckDuplicatesRecursively(std::string path) {\nabsl::EndsWith(path, \"/net\")) {\nbreak;\n}\n+ // We may also see permission failures traversing some... | Go | Apache License 2.0 | google/gvisor | Ignore permission failures in CheckDuplicatesRecursively.
Not all files are always accessible by the process itself. This
was specifically seen with map_files, but there's no rule that
every entry must be accessible by the process itself.
PiperOrigin-RevId: 343919117 |
259,858 | 23.11.2020 14:15:43 | 28,800 | b6c00520d314811d59485a42c2fba578f34b91ee | Omit sandbox from chown test.
This test fails because it must include additional UIDs. Omit
the bazel sandbox to ensure that it can function correctly. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -432,6 +432,9 @@ cc_binary(\ntestonly = 1,\nsrcs = [\"chown.cc\"],\nlinkstatic = 1,\n+ # We require additional UIDs for this test, so don't include the bazel\n+ # sandbox as stand... | Go | Apache License 2.0 | google/gvisor | Omit sandbox from chown test.
This test fails because it must include additional UIDs. Omit
the bazel sandbox to ensure that it can function correctly.
PiperOrigin-RevId: 343927190 |
259,858 | 23.11.2020 14:16:20 | 28,800 | 2320ce5b7d992973182a90b2885e852b2059ee08 | Fail gracefully if Docker is not configured with ipv6. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/container.go",
"new_path": "pkg/test/dockerutil/container.go",
"diff": "@@ -17,6 +17,7 @@ package dockerutil\nimport (\n\"bytes\"\n\"context\"\n+ \"errors\"\n\"fmt\"\n\"io/ioutil\"\n\"net\"\n@@ -351,6 +352,9 @@ func (c *Container) SandboxPi... | Go | Apache License 2.0 | google/gvisor | Fail gracefully if Docker is not configured with ipv6.
PiperOrigin-RevId: 343927315 |
259,858 | 23.11.2020 14:25:37 | 28,800 | 3deb5d0c043dcfd8523425792c6cf8ec13b19868 | Fix link against runtime.goyield.
This function does not exist in Go 1.13. We need to add an adaptor
to build against Go 1.13, which is the default Ubuntu version. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/BUILD",
"new_path": "pkg/sync/BUILD",
"diff": "@@ -40,6 +40,7 @@ go_library(\n\"race_unsafe.go\",\n\"rwmutex_unsafe.go\",\n\"seqcount.go\",\n+ \"spin_legacy_unsafe.go\",\n\"spin_unsafe.go\",\n\"sync.go\",\n],\n"
},
{
"change_type": "ADD",
... | Go | Apache License 2.0 | google/gvisor | Fix link against runtime.goyield.
This function does not exist in Go 1.13. We need to add an adaptor
to build against Go 1.13, which is the default Ubuntu version.
PiperOrigin-RevId: 343929132 |
259,858 | 23.11.2020 14:43:42 | 28,800 | 756bc3e52b2344dc48e0cefb929b0ebf1b9becf6 | Clean up build output.
This change also simplifies and documents the build_cmd pipeline, and
reduces general noise for debugging Makefile issues.
It also drops the mapping for /etc/docker/daemon.json, which if it
does not exist initially will create this as a directory (causing lots
of confusion and breaks). | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": "# Generated bazel symlinks.\n/bazel-*\n+# Generated build event file.\n+/.build_events.json\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Make... | Go | Apache License 2.0 | google/gvisor | Clean up build output.
This change also simplifies and documents the build_cmd pipeline, and
reduces general noise for debugging Makefile issues.
It also drops the mapping for /etc/docker/daemon.json, which if it
does not exist initially will create this as a directory (causing lots
of confusion and breaks).
PiperOrigin-RevId: 343932456 |
259,858 | 23.11.2020 16:02:41 | 28,800 | a94663ee569dd9ae340eb6b58a9a190715e15f57 | Fix bad Makefile variable reference. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -213,7 +213,7 @@ test: bazel-server\ntestlogs:\n@cat .build_events.json | jq -r \\\n'select(.testSummary?.overallStatus? | tostring | test(\"(FAILED|FLAKY|TIMEOUT)\")) | .testSummary.failed | .[] | .ur... | Go | Apache License 2.0 | google/gvisor | Fix bad Makefile variable reference.
PiperOrigin-RevId: 343946859 |
259,885 | 23.11.2020 17:24:20 | 28,800 | 986683124c41e3ba2d24420a95d7cdb945055381 | Don't evict gofer.dentries with inotify watches before saving. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -1353,16 +1353,11 @@ func (d *dentry) checkCachingLocked(ctx context.Context) {\nreturn\n}\nif refs > 0 {\n- if d.cached {\n// This isn't strictly necessary (fs.cach... | Go | Apache License 2.0 | google/gvisor | Don't evict gofer.dentries with inotify watches before saving.
PiperOrigin-RevId: 343959348 |
260,004 | 23.11.2020 22:45:42 | 28,800 | ba2d5cb7e1f3ac69a65d0e790f1319082ee01de2 | Use time.Duration for IGMP Max Response Time field
Bug | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/checker.go",
"new_path": "pkg/tcpip/checker/checker.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"encoding/binary\"\n\"reflect\"\n\"testing\"\n+ \"time\"\n\"github.com/google/go-cmp/cmp\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n@@ -1267,7 +1268,7 @@ ... | Go | Apache License 2.0 | google/gvisor | Use time.Duration for IGMP Max Response Time field
Bug #4682
PiperOrigin-RevId: 343993297 |
260,004 | 24.11.2020 01:17:25 | 28,800 | 1de08889dfad93734c1ba45e72fedb0b2a974ccc | Deduplicate code in ipv6.protocol | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ipv6.go",
"new_path": "pkg/tcpip/network/ipv6/ipv6.go",
"diff": "@@ -273,7 +273,7 @@ func (e *endpoint) Enable() *tcpip.Error {\n}\n// Do not auto-generate an IPv6 link-local address for loopback devices.\n- if e.protocol.autoGenIPv6Link... | Go | Apache License 2.0 | google/gvisor | Deduplicate code in ipv6.protocol
PiperOrigin-RevId: 344009602 |
259,860 | 24.11.2020 10:37:35 | 28,800 | e5fd23c18d1fd602603babd8297dabf679c336aa | Remove outdated TODO.
The bug has been fixed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -91,9 +91,6 @@ var (\n// noCrashOnVerificationFailure indicates whether the sandbox should panic\n// whenever verification fails. If true, an error is returned i... | Go | Apache License 2.0 | google/gvisor | Remove outdated TODO.
The bug has been fixed.
PiperOrigin-RevId: 344088206 |
259,967 | 24.11.2020 14:20:15 | 28,800 | f90ab60a8a5ce9663a878c7cabcc4ad66922e265 | Track number of packets queued to Failed neighbors
Add a NIC-specific neighbor table statistic so we can determine how many
packets have been queued to Failed neighbors, indicating an unhealthy local
network. This change assists us to debug in-field issues where subsequent
traffic to a neighbor fails.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_cache.go",
"new_path": "pkg/tcpip/stack/neighbor_cache.go",
"diff": "@@ -24,9 +24,16 @@ import (\nconst neighborCacheSize = 512 // max entries per interface\n+// NeighborStats holds metrics for the neighbor table.\n+type NeighborStats ... | Go | Apache License 2.0 | google/gvisor | Track number of packets queued to Failed neighbors
Add a NIC-specific neighbor table statistic so we can determine how many
packets have been queued to Failed neighbors, indicating an unhealthy local
network. This change assists us to debug in-field issues where subsequent
traffic to a neighbor fails.
Fixes #4819
PiperOrigin-RevId: 344131119 |
260,024 | 24.11.2020 15:23:31 | 28,800 | 4da63dc82e1a458404f0e30f8bba9391eb7dd806 | Report correct pointer value for "bad next header" ICMP error
Because the code handles a bad header as "payload" right up to the last moment
we need to make sure payload handling does not remove the error information.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"new_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"diff": "@@ -47,6 +47,11 @@ const (\n// IPv6NoNextHeaderIdentifier is the header identifier used to signify the end\n// of an IPv6 payload, as per RFC 8200 s... | Go | Apache License 2.0 | google/gvisor | Report correct pointer value for "bad next header" ICMP error
Because the code handles a bad header as "payload" right up to the last moment
we need to make sure payload handling does not remove the error information.
Fixes #4909
PiperOrigin-RevId: 344141690 |
259,967 | 24.11.2020 15:35:47 | 28,800 | 99f2d0ea2f2ec7a9758584d53db64008be33fac4 | Correctly lock when removing neighbor entries
Fix a panic when two entries in Failed state are removed at the same time. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_cache.go",
"new_path": "pkg/tcpip/stack/neighbor_cache.go",
"diff": "@@ -233,6 +233,8 @@ func (n *neighborCache) addStaticEntry(addr tcpip.Address, linkAddr tcpip.LinkAd\n}\n// removeEntryLocked removes the specified entry from the nei... | Go | Apache License 2.0 | google/gvisor | Correctly lock when removing neighbor entries
Fix a panic when two entries in Failed state are removed at the same time.
PiperOrigin-RevId: 344143777 |
260,019 | 25.11.2020 13:41:43 | -28,800 | be71d3569cacc9da7e260895914272e3f5b81764 | arm64 test: add exceptions related test cases
For now, I only added a halt test case for Arm64. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -621,10 +621,7 @@ cc_binary(\ncc_binary(\nname = \"exceptions_test\",\ntestonly = 1,\n- srcs = select_arch(\n- amd64 = [\"exceptions.cc\"],\n- arm64 = [],\n- ),\n+ srcs = [\"excep... | Go | Apache License 2.0 | google/gvisor | arm64 test: add exceptions related test cases
For now, I only added a halt test case for Arm64.
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
260,019 | 25.11.2020 14:36:38 | -28,800 | 3868c7dd407b954e6830fbb6e6557af459567e3c | arm64 kvm: add more handling of el0_exceptions
Add more comments and more handling for exceptions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_arm64_unsafe.go",
"new_path": "pkg/sentry/platform/kvm/machine_arm64_unsafe.go",
"diff": "@@ -235,12 +235,12 @@ func (c *vCPU) SwitchToUser(switchOpts ring0.SwitchOpts, info *arch.SignalInfo)\nttbr0App := switchOpts.PageTables.T... | Go | Apache License 2.0 | google/gvisor | arm64 kvm: add more handling of el0_exceptions
Add more comments and more handling for exceptions.
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
259,898 | 24.11.2020 23:19:46 | 28,800 | d04144fbb7b9fcb055e3aa3c2246f9b498923cc0 | [2/3] Support isolated containers for parallel packetimpact tests
Added a new flag num_duts to the test runner to create multiple DUTs for the
testbench can connect to. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/BUILD",
"new_path": "test/packetimpact/runner/BUILD",
"diff": "@@ -32,6 +32,7 @@ go_library(\ndeps = [\n\"//pkg/test/dockerutil\",\n\"//test/packetimpact/netdevs\",\n+ \"//test/packetimpact/testbench\",\n\"@com_github_docker_docker//ap... | Go | Apache License 2.0 | google/gvisor | [2/3] Support isolated containers for parallel packetimpact tests
Added a new flag num_duts to the test runner to create multiple DUTs for the
testbench can connect to.
PiperOrigin-RevId: 344195435 |
259,907 | 26.11.2020 00:41:20 | 28,800 | ad83112423ecf8729df582dd79cbe5a7e29bd937 | [netstack] Add SOL_TCP options to SocketOptions.
Ports the following options:
TCP_NODELAY
TCP_CORK
TCP_QUICKACK
Also deletes the {Get/Set}SockOptBool interface methods from all implementations | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -240,10 +240,6 @@ type commonEndpoint interface {\n// transport.Endpoint.SetSockOpt.\nSetSockOpt(tcpip.SettableSocketOption) *tcpip.Error\n- // SetSockOp... | Go | Apache License 2.0 | google/gvisor | [netstack] Add SOL_TCP options to SocketOptions.
Ports the following options:
- TCP_NODELAY
- TCP_CORK
- TCP_QUICKACK
Also deletes the {Get/Set}SockOptBool interface methods from all implementations
PiperOrigin-RevId: 344378824 |
260,004 | 27.11.2020 12:53:48 | 28,800 | 4fd71a7b20d53ba070bd2d937bb980991305b19d | Don't add a temporary address to send DAD/RS packets
Bug | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ndp.go",
"new_path": "pkg/tcpip/network/ipv6/ndp.go",
"diff": "@@ -471,17 +471,8 @@ type ndpState struct {\n// The default routers discovered through Router Advertisements.\ndefaultRouters map[tcpip.Address]defaultRouterState\n- rtrSolic... | Go | Apache License 2.0 | google/gvisor | Don't add a temporary address to send DAD/RS packets
Bug #4803
PiperOrigin-RevId: 344553664 |
260,004 | 30.11.2020 14:22:01 | 28,800 | e813008664ffb361211936dda8631754411cca4f | Perform IGMP/MLD when the NIC is enabled/disabled
Test: ip_test.TestMGPWithNICLifecycle
Bug | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -123,6 +123,15 @@ func (e *endpoint) Enable() *tcpip.Error {\n// We have no need for the address endpoint.\nep.DecRef()\n+ // Groups may have been joined while the endpo... | Go | Apache License 2.0 | google/gvisor | Perform IGMP/MLD when the NIC is enabled/disabled
Test: ip_test.TestMGPWithNICLifecycle
Bug #4682, #4861
PiperOrigin-RevId: 344888091 |
259,964 | 30.11.2020 16:34:33 | 28,800 | 54ad145f2eb6d16a3a18b69e1c2adfa558639b72 | Add more fragment reassembly tests
These tests check if a maximum-sized (64k) packet is reassembled without
receiving a fragment with MF flag set to zero. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"diff": "@@ -2424,6 +2424,28 @@ func TestReceiveFragments(t *testing.T) {\n},\nexpectedPayloads: [][]byte{udpPayload4Addr1ToAddr2},\n},\n+ {\n+ name: \"Two fragments with ... | Go | Apache License 2.0 | google/gvisor | Add more fragment reassembly tests
These tests check if a maximum-sized (64k) packet is reassembled without
receiving a fragment with MF flag set to zero.
PiperOrigin-RevId: 344913172 |
259,898 | 30.11.2020 21:21:21 | 28,800 | 59a2c785bfba56e2ffb04083c213fa2ad23a36a2 | Do not start a ContainerExec twice
ContainerExecStart and ContainerExecAttach both call the /exec/id/start API
endpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/exec.go",
"new_path": "pkg/test/dockerutil/exec.go",
"diff": "@@ -77,11 +77,6 @@ func (c *Container) doExec(ctx context.Context, r ExecOpts, args []string) (Proc\nreturn Process{}, fmt.Errorf(\"exec attach failed with err: %v\", err)\n}\n- ... | Go | Apache License 2.0 | google/gvisor | Do not start a ContainerExec twice
ContainerExecStart and ContainerExecAttach both call the /exec/id/start API
endpoint.
PiperOrigin-RevId: 344946627 |
259,860 | 30.11.2020 23:14:35 | 28,800 | 6b1dbbbdc8ec0b5d04e0961a216bd7323dbc45fb | Fix typo in ptrace documentation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/ptrace.go",
"new_path": "pkg/sentry/platform/ptrace/ptrace.go",
"diff": "//\n// In a nutshell, it works as follows:\n//\n-// The creation of a new address space creates a new child processes with a\n-// single thread which is traced ... | Go | Apache License 2.0 | google/gvisor | Fix typo in ptrace documentation.
PiperOrigin-RevId: 344958513 |
259,898 | 01.12.2020 18:52:02 | 28,800 | aa419cef4b0189d0dbe739e65553482a135cd5d1 | Avoid wrong error messages
Stop showing wrong timeout values in packetimpact test error messages. e.g.
"got frames ... want ... during -123ms" | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -598,7 +598,7 @@ func (conn *Connection) ExpectFrame(t *testing.T, layers Layers, timeout time.Du\nvar errs error\nfor {\nvar gotLayers Layers\n-... | Go | Apache License 2.0 | google/gvisor | Avoid wrong error messages
Stop showing wrong timeout values in packetimpact test error messages. e.g.
"got frames ... want ... during -123ms"
PiperOrigin-RevId: 345144938 |
260,004 | 01.12.2020 21:32:36 | 28,800 | 0c497394226b762dfd31b83bb33043d19073b0a4 | Correctly lock when listing neighbor entries | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_cache.go",
"new_path": "pkg/tcpip/stack/neighbor_cache.go",
"diff": "@@ -182,14 +182,15 @@ func (n *neighborCache) removeWaker(addr tcpip.Address, waker *sleep.Waker) {\n// entries returns all entries in the neighbor cache.\nfunc (n *n... | Go | Apache License 2.0 | google/gvisor | Correctly lock when listing neighbor entries
PiperOrigin-RevId: 345162450 |
260,004 | 01.12.2020 21:56:09 | 28,800 | 41675ebc6308bef2f227339d075b3af8b4062eec | Deflake stack_test.TestRouterSolicitation
...by using the fake clock.
TestRouterSolicitation no longer runs its sub-tests in parallel now that
the sub-tests are not long-running - the fake clock simulates time
moving forward. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -120,6 +120,7 @@ go_test(\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/checker\",\n+ \"//pkg/tcpip/faketime\",\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/link/channel\",\n\"//pk... | Go | Apache License 2.0 | google/gvisor | Deflake stack_test.TestRouterSolicitation
...by using the fake clock.
TestRouterSolicitation no longer runs its sub-tests in parallel now that
the sub-tests are not long-running - the fake clock simulates time
moving forward.
PiperOrigin-RevId: 345165794 |
259,875 | 02.12.2020 00:11:17 | 28,800 | b26dd6d9b78b2703a8a726376e6935011657123a | Add /proc/sys/kernel/sem. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/sem.go",
"new_path": "pkg/abi/linux/sem.go",
"diff": "@@ -32,6 +32,17 @@ const (\nSEM_STAT_ANY = 20\n)\n+// Information about system-wide sempahore limits and parameters.\n+//\n+// Source: include/uapi/linux/sem.h\n+const (\n+ SEMMNI = 32000\n+ S... | Go | Apache License 2.0 | google/gvisor | Add /proc/sys/kernel/sem.
PiperOrigin-RevId: 345178956 |
259,858 | 02.12.2020 09:13:59 | 28,800 | 9f02d2653bb790e8403b1c8b54656e06eb908802 | Fix containerd.sh for later Ubuntu and Debian-based distributions. | [
{
"change_type": "MODIFY",
"old_path": "tools/installers/containerd.sh",
"new_path": "tools/installers/containerd.sh",
"diff": "@@ -49,10 +49,10 @@ install_helper() {\n# and later versions no longer have the transitional package.\nsource /etc/os-release\ndeclare BTRFS_DEV\n-if [[ \"${ID}\" == \"ubun... | Go | Apache License 2.0 | google/gvisor | Fix containerd.sh for later Ubuntu and Debian-based distributions.
PiperOrigin-RevId: 345245285 |
259,907 | 02.12.2020 09:19:02 | 28,800 | f156fb6531918f62c1a14363af97240588948202 | [netstack] Add back EndpointInfo struct in tcp.
This was removed in an earlier commit. This should remain as it allows to add
tcp-only state to be exposed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -309,6 +309,19 @@ type Stats struct {\n// marker interface.\nfunc (*Stats) IsEndpointStats() {}\n+// EndpointInfo holds useful information about a transport en... | Go | Apache License 2.0 | google/gvisor | [netstack] Add back EndpointInfo struct in tcp.
This was removed in an earlier commit. This should remain as it allows to add
tcp-only state to be exposed.
PiperOrigin-RevId: 345246155 |
259,858 | 02.12.2020 09:24:52 | 28,800 | 496851d27b58bbb15ee863de0d8a106dd23b8050 | Skip CanKillAllPIDs when running natively.
This is quite disruptive to run in some environments. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/kill.cc",
"new_path": "test/syscalls/linux/kill.cc",
"diff": "@@ -58,6 +58,12 @@ void SigHandler(int sig, siginfo_t* info, void* context) { _exit(0); }\n// If pid equals -1, then sig is sent to every process for which the calling\n// proces... | Go | Apache License 2.0 | google/gvisor | Skip CanKillAllPIDs when running natively.
This is quite disruptive to run in some environments.
PiperOrigin-RevId: 345247206 |
259,860 | 02.12.2020 09:28:08 | 28,800 | b11f40db1ec2afed67d7227fd5b79e9897ffbf1d | Clean up verity tests.
Refactor some utilities and rename some others for clarity. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity_test.go",
"new_path": "pkg/sentry/fsimpl/verity/verity_test.go",
"diff": "@@ -35,14 +35,16 @@ import (\n\"gvisor.dev/gvisor/pkg/usermem\"\n)\n+const (\n// rootMerkleFilename is the name of the root Merkle tree file.\n-const root... | Go | Apache License 2.0 | google/gvisor | Clean up verity tests.
Refactor some utilities and rename some others for clarity.
PiperOrigin-RevId: 345247836 |
259,858 | 02.12.2020 10:46:10 | 28,800 | 7ccb0b6a7cd7fa33f2d58484aed5cfe1709018ca | Fix chown test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/chown.cc",
"new_path": "test/syscalls/linux/chown.cc",
"diff": "@@ -75,7 +75,16 @@ TEST_P(ChownParamTest, ChownFileSucceeds) {\nif (num_groups > 0) {\nstd::vector<gid_t> list(num_groups);\nEXPECT_THAT(getgroups(list.size(), list.data()), Sy... | Go | Apache License 2.0 | google/gvisor | Fix chown test.
PiperOrigin-RevId: 345265342 |
259,858 | 02.12.2020 11:26:03 | 28,800 | dbd4a6e3e581cc081f686096226873f3a39c0369 | Add BuildKite agent.
This has no effect on the continuous integration system, and simply
publishes a cached container image containing the agent and metrics
agent with known provenance. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/agent/Dockerfile",
"diff": "+FROM golang:1.15 as build-agent\n+RUN git clone --depth=1 --branch=v3.25.0 https://github.com/buildkite/agent\n+RUN cd agent && go build -i -o /buildkite-agent .\n+\n+FROM golang:1.15 as build-agent-metrics\n+... | Go | Apache License 2.0 | google/gvisor | Add BuildKite agent.
This has no effect on the continuous integration system, and simply
publishes a cached container image containing the agent and metrics
agent with known provenance.
PiperOrigin-RevId: 345274375 |
259,907 | 02.12.2020 11:31:38 | 28,800 | 1375a87a209ef1a2523ada84254e3a0101afb4f5 | [netstack] Refactor common utils out of netstack to socket package.
Moved AddressAndFamily() and ConvertAddress() to socket package from netstack.
This helps because these utilities are used by sibling netstack packages.
Such sibling dependencies can later cause circular dependencies. Common utils
shared between siblings should be moved up to the parent. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/BUILD",
"new_path": "pkg/sentry/socket/BUILD",
"diff": "@@ -20,6 +20,7 @@ go_library(\n\"//pkg/sentry/vfs\",\n\"//pkg/syserr\",\n\"//pkg/tcpip\",\n+ \"//pkg/tcpip/header\",\n\"//pkg/usermem\",\n],\n)\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | [netstack] Refactor common utils out of netstack to socket package.
Moved AddressAndFamily() and ConvertAddress() to socket package from netstack.
This helps because these utilities are used by sibling netstack packages.
Such sibling dependencies can later cause circular dependencies. Common utils
shared between siblings should be moved up to the parent.
PiperOrigin-RevId: 345275571 |
259,858 | 02.12.2020 11:35:54 | 28,800 | 24d6eb58e51be706ae66db31d027e2400307152f | Skip generating an empty (broken) test case.
It's possible that all the cases in a given batch are excluded if
the offsets line up just right, which will cause the test to fail.
Don't generate an invalid test in this case. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/runner/lib/lib.go",
"new_path": "test/runtimes/runner/lib/lib.go",
"diff": "@@ -122,6 +122,10 @@ func getTests(ctx context.Context, d *dockerutil.Container, lang, image string,\n}\ntcs = append(tcs, tests[tc])\n}\n+ if len(tcs) == 0 {\n+ // No te... | Go | Apache License 2.0 | google/gvisor | Skip generating an empty (broken) test case.
It's possible that all the cases in a given batch are excluded if
the offsets line up just right, which will cause the test to fail.
Don't generate an invalid test in this case.
PiperOrigin-RevId: 345276588 |
259,951 | 02.12.2020 14:09:40 | 28,800 | 6a26930eeb717f758ea7ba555df06d9028b24ec8 | Abandon reassembly of a packet if fragments overlap
However, receiving duplicated fragments will not cause reassembly to
fail. This is what Linux does too: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/fragmentation/fragmentation.go",
"new_path": "pkg/tcpip/network/fragmentation/fragmentation.go",
"diff": "@@ -46,9 +46,13 @@ const (\n)\nvar (\n- // ErrInvalidArgs indicates to the caller that that an invalid argument was\n+ // ErrInvalidArgs... | Go | Apache License 2.0 | google/gvisor | Abandon reassembly of a packet if fragments overlap
However, receiving duplicated fragments will not cause reassembly to
fail. This is what Linux does too:
https://github.com/torvalds/linux/blob/38525c6/net/ipv4/inet_fragment.c#L355
PiperOrigin-RevId: 345309546 |
259,951 | 02.12.2020 15:14:52 | 28,800 | bdaae08ee2b4834422d46cdfd292161e974e4d26 | Extract ICMPv4/v6 specific stats to their own types
This change lets us split the v4 stats from the v6 stats, which will be
useful when adding stats for each network endpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -84,7 +84,8 @@ var Metrics = tcpip.Stats{\nMalformedRcvdPackets: mustCreateMetric(\"/netstack/malformed_received_packets\", \"Number of packets received ... | Go | Apache License 2.0 | google/gvisor | Extract ICMPv4/v6 specific stats to their own types
This change lets us split the v4 stats from the v6 stats, which will be
useful when adding stats for each network endpoint.
PiperOrigin-RevId: 345322615 |
259,898 | 02.12.2020 19:09:17 | 28,800 | 8b692f593103d24d1de0d85ef89ec5b3f3e9cd5a | Make testutil.RandomID safe for concurrent uses
testutil.RandomID was using Rand.Read which is not safe for concurrent use.
It caused name conflicts in packetimpact tests when they are run in parallel.
Adding a mutex to protect the Rand.Read operation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/testutil/testutil.go",
"new_path": "pkg/test/testutil/testutil.go",
"diff": "@@ -248,14 +248,25 @@ func writeSpec(dir string, spec *specs.Spec) error {\n// idRandomSrc is a pseudo random generator used to in RandomID.\nvar idRandomSrc = rand.New(rand.... | Go | Apache License 2.0 | google/gvisor | Make testutil.RandomID safe for concurrent uses
testutil.RandomID was using Rand.Read which is not safe for concurrent use.
It caused name conflicts in packetimpact tests when they are run in parallel.
Adding a mutex to protect the Rand.Read operation.
PiperOrigin-RevId: 345360062 |
259,858 | 03.12.2020 00:58:36 | 28,800 | 80552b936d06e43ea77df09a6b6c5ce2600a6f6a | Support partitions for other tests. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -123,6 +123,7 @@ list-images: ## List all available images.\n##\nPARTITION ?= 1\nTOTAL_PARTITIONS ?= 1\n+PARTITIONS := --test_arg=--partition=$(PARTITION) --test_arg=--total_partitions=$(TOTAL_PARTITIONS)\nrunsc: ... | Go | Apache License 2.0 | google/gvisor | Support partitions for other tests.
PiperOrigin-RevId: 345399936 |
259,858 | 03.12.2020 11:04:34 | 28,800 | 3186b50dffc196755a3ce7ce0ab44253f78a2495 | Add BuildKite pipeline. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".buildkite/pipeline.yaml",
"diff": "+_templates:\n+ common: &common\n+ retry:\n+ automatic:\n+ - exit_status: -1\n+ limit: 10\n+ - exit_status: \"*\"\n+ limit: 2\n+\n+steps:\n+ # Run basic smoke tests before preceding to other tests.\n+ - label:... | Go | Apache License 2.0 | google/gvisor | Add BuildKite pipeline.
PiperOrigin-RevId: 345490319 |
259,860 | 03.12.2020 11:44:53 | 28,800 | bec8cea6513beaf6c2348ed0b71cb40e417beb68 | Surface usage message for `runsc do`.
c.Usage() only returns a string; f.Usage() will print the usage message. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/do.go",
"new_path": "runsc/cmd/do.go",
"diff": "@@ -81,7 +81,7 @@ func (c *Do) SetFlags(f *flag.FlagSet) {\n// Execute implements subcommands.Command.Execute.\nfunc (c *Do) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}) subcommands.... | Go | Apache License 2.0 | google/gvisor | Surface usage message for `runsc do`.
c.Usage() only returns a string; f.Usage() will print the usage message.
PiperOrigin-RevId: 345500123 |
259,992 | 03.12.2020 16:53:22 | 28,800 | 9eb77281c4fe1c1f252a0df67ca2c1fee8867b80 | Update containerd to 1.3.9 | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -57,8 +57,8 @@ steps:\nlabel: \":person_in_lotus_position: KVM tests\"\ncommand: make kvm-tests\n- <<: *common\n- label: \":docker: Containerd 1.3.4 tests\"\n- command: make contain... | Go | Apache License 2.0 | google/gvisor | Update containerd to 1.3.9
PiperOrigin-RevId: 345564927 |
259,875 | 03.12.2020 19:55:20 | 28,800 | a78cef0ed7ce15583424f5873f0aa6fdad1d5c2f | Implement command IPC_INFO for semctl. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/sem.go",
"new_path": "pkg/abi/linux/sem.go",
"diff": "@@ -41,6 +41,12 @@ const (\nSEMMNS = SEMMNI * SEMMSL\nSEMOPM = 500\nSEMVMX = 32767\n+ SEMAEM = SEMVMX\n+\n+ // followings are unused in kernel\n+ SEMUME = SEMOPM\n+ SEMMNU = SEMMNS\n+ SEMMAP =... | Go | Apache License 2.0 | google/gvisor | Implement command IPC_INFO for semctl.
PiperOrigin-RevId: 345589628 |
259,881 | 04.12.2020 08:17:39 | 28,800 | 6708c8c97e4ede29935c8d3e809c7bb76309112c | Require sync.RWMutex to lock and unlock from the same goroutine
This is the RWMutex equivalent to the preceding sync.Mutex CL.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fs.go",
"new_path": "pkg/sentry/fs/fs.go",
"diff": "@@ -65,7 +65,7 @@ var (\n// runs with the lock held for reading. AsyncBarrier will take the lock\n// for writing, thus ensuring that all Async work completes before\n// AsyncBarrier returns.\n- ... | Go | Apache License 2.0 | google/gvisor | Require sync.RWMutex to lock and unlock from the same goroutine
This is the RWMutex equivalent to the preceding sync.Mutex CL.
Updates #4804
PiperOrigin-RevId: 345681051 |
259,885 | 04.12.2020 09:44:25 | 28,800 | 5c16707568cafad1f86543c06a70285b86636aa0 | Avoid fallocate(FALLOC_FL_PUNCH_HOLE) when ManualZeroing is in effect. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/pgalloc/pgalloc.go",
"new_path": "pkg/sentry/pgalloc/pgalloc.go",
"diff": "@@ -423,11 +423,7 @@ func (f *MemoryFile) Allocate(length uint64, kind usage.MemoryKind) (memmap.File\n}\nif f.opts.ManualZeroing {\n- if err := f.forEachMappingSlice(fr, fun... | Go | Apache License 2.0 | google/gvisor | Avoid fallocate(FALLOC_FL_PUNCH_HOLE) when ManualZeroing is in effect.
PiperOrigin-RevId: 345696124 |
259,858 | 04.12.2020 15:03:21 | 28,800 | 216abfb6dfa437166627cf7e2d2a66ae95aad07e | Update containerd tests for 1.4+ to 1.4.3. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -60,8 +60,8 @@ steps:\nlabel: \":docker: Containerd 1.3.9 tests\"\ncommand: make containerd-test-1.3.9\n- <<: *common\n- label: \":docker: Containerd 1.4.1 tests\"\n- command: make ... | Go | Apache License 2.0 | google/gvisor | Update containerd tests for 1.4+ to 1.4.3.
PiperOrigin-RevId: 345764404 |
259,885 | 04.12.2020 19:05:08 | 28,800 | 8a45c8161601e62faa0d448ff6d5bc0604ea406f | Allow use of SeqAtomic with pointer-containing types.
Per runtime.memmove, pointers are always copied atomically, as this is required
by the GC. (Also, the init() safety check doesn't work because it gets renamed
to <prefix>init() by template instantiation.) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/seqatomic_unsafe.go",
"new_path": "pkg/sync/seqatomic_unsafe.go",
"diff": "package template\nimport (\n- \"fmt\"\n- \"reflect\"\n- \"strings\"\n\"unsafe\"\n\"gvisor.dev/gvisor/pkg/sync\"\n)\n// Value is a required type parameter.\n-//\n-// Value must ... | Go | Apache License 2.0 | google/gvisor | Allow use of SeqAtomic with pointer-containing types.
Per runtime.memmove, pointers are always copied atomically, as this is required
by the GC. (Also, the init() safety check doesn't work because it gets renamed
to <prefix>init() by template instantiation.)
PiperOrigin-RevId: 345800302 |
259,885 | 04.12.2020 19:05:26 | 28,800 | b80021afd2395fd40464ebbeac8f4c8034dee06e | Overlay runsc regular file mounts with regular files.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"new_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"diff": "@@ -16,7 +16,6 @@ package overlay\nimport (\n\"fmt\"\n- \"io\"\n\"sync/atomic\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -129,25 +128,9 @@ func (d *dentry) copy... | Go | Apache License 2.0 | google/gvisor | Overlay runsc regular file mounts with regular files.
Fixes #4991
PiperOrigin-RevId: 345800333 |
260,004 | 04.12.2020 22:02:09 | 28,800 | df2dbe3e38aac73926a51d8045dbb419c6167cf5 | Remove stack.ReadOnlyAddressableEndpointState
Startblock:
has LGTM from asfez
and then
add reviewer tamird | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -799,28 +799,12 @@ func (e *endpoint) AcquireAssignedAddress(localAddr tcpip.Address, allowTemp boo\ndefer e.mu.Unlock()\nloopback := e.nic.IsLoopback()\n- addressEndpoi... | Go | Apache License 2.0 | google/gvisor | Remove stack.ReadOnlyAddressableEndpointState
Startblock:
has LGTM from asfez
and then
add reviewer tamird
PiperOrigin-RevId: 345815146 |
259,986 | 07.12.2020 08:42:09 | 28,800 | eeb23531ebef4fc44af317b4e4a8834c8b069dd9 | Support icmpv6 transport protocol | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -207,7 +207,7 @@ swgso-tests: load-basic-images\nhostnet-tests: load-basic-images\n@$(call submake,install-runtime RUNTIME=\"hostnet\" ARGS=\"--network=host\")\n- @$(call submake,test-runtime RUNTIME=\"hostnet\" O... | Go | Apache License 2.0 | google/gvisor | Support icmpv6 transport protocol
PiperOrigin-RevId: 346101076 |
259,967 | 07.12.2020 14:49:26 | 28,800 | 0e5ba13b331d4e85548b6f095b28ae88df95a89a | Remove stale comment
Removes comment lines about MaxUnsolicitedReportDelay. This is already
documented in the comment for GenericMulticastProtocolOptions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ip/generic_multicast_protocol.go",
"new_path": "pkg/tcpip/network/ip/generic_multicast_protocol.go",
"diff": "@@ -152,9 +152,6 @@ type GenericMulticastProtocolState struct {\n}\n// Init initializes the Generic Multicast Protocol state.\n-//\n... | Go | Apache License 2.0 | google/gvisor | Remove stale comment
Removes comment lines about MaxUnsolicitedReportDelay. This is already
documented in the comment for GenericMulticastProtocolOptions.
PiperOrigin-RevId: 346185053 |
259,951 | 07.12.2020 15:50:23 | 28,800 | 615c3380d297ee3c61e47fb48a4cca87f7c99ba0 | Export IGMP stats | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -153,6 +153,28 @@ var Metrics = tcpip.Stats{\n},\n},\n},\n+ IGMP: tcpip.IGMPStats{\n+ PacketsSent: tcpip.IGMPSentPacketStats{\n+ IGMPPacketStats: tcpip.I... | Go | Apache License 2.0 | google/gvisor | Export IGMP stats
PiperOrigin-RevId: 346197760 |
259,975 | 07.12.2020 16:17:14 | 28,800 | 6d30688bd70370fd9327cd3fca178bb85342cc2a | Fix tags on benchmark targets. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "test/benchmarks/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"bzl_library\")\n+\n+package(licenses = [\"notice\"])\n+\n+bzl_library(\n+ name = \"defs_bzl\",\n+ srcs = [\"defs.bzl\"],\n+ visibility = [\n+ \"//:sandbox\",\n+ ],\n+)\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Fix tags on benchmark targets.
PiperOrigin-RevId: 346203209 |
259,985 | 07.12.2020 17:58:56 | 28,800 | 9c198e5df4216feb5ebbf144e3b616888dfe3c27 | Fix error handling on fusefs mount.
Don't propagate arbitrary golang errors up from fusefs because errors
that don't map to an errno result in a sentry panic.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection_control.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection_control.go",
"diff": "@@ -84,11 +84,7 @@ func (conn *connection) InitSend(creds *auth.Credentials, pid uint32) error {\nFlags: fuseDefaultInitFlags,\n}\n- req, err :=... | Go | Apache License 2.0 | google/gvisor | Fix error handling on fusefs mount.
Don't propagate arbitrary golang errors up from fusefs because errors
that don't map to an errno result in a sentry panic.
Reported-by: syzbot+697cb635346e456fddfc@syzkaller.appspotmail.com
PiperOrigin-RevId: 346220306 |
259,853 | 09.12.2020 00:42:53 | 28,800 | 658f874b94ad83d9b4abed47d9aba856fe5f617c | Prepare for supporting cross compilation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/flipcall/BUILD",
"new_path": "pkg/flipcall/BUILD",
"diff": "@@ -11,7 +11,8 @@ go_library(\n\"futex_linux.go\",\n\"io.go\",\n\"packet_window_allocator.go\",\n- \"packet_window_mmap.go\",\n+ \"packet_window_mmap_amd64.go\",\n+ \"packet_window_mmap_arm64.go\"... | Go | Apache License 2.0 | google/gvisor | Prepare for supporting cross compilation.
PiperOrigin-RevId: 346496532 |
259,927 | 09.12.2020 09:14:45 | 28,800 | f6cb96bd57dec4e3baa8c57ccdeb0f1d8706b682 | Cap UDP payload size to length informed in UDP header
startblock:
has LGTM from peterjohnston
and then
add reviewer ghanan,tamird | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/udp.go",
"new_path": "pkg/tcpip/header/udp.go",
"diff": "@@ -36,10 +36,10 @@ const (\n// UDPFields contains the fields of a UDP packet. It is used to describe the\n// fields of a packet that needs to be encoded.\ntype UDPFields struct {\n- // ... | Go | Apache License 2.0 | google/gvisor | Cap UDP payload size to length informed in UDP header
startblock:
has LGTM from peterjohnston
and then
add reviewer ghanan,tamird
PiperOrigin-RevId: 346565589 |
260,004 | 09.12.2020 10:50:42 | 28,800 | 50189b0d6f2401f842f63ae149de13b89b4c30f9 | Do not perform IGMP/MLD on loopback interfaces
The loopback interface will never have any neighbouring nodes so
advertising its interest in multicast groups is unnecessary.
Bug
Startblock:
has LGTM from asfez
and then
add reviewer tamird | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ip/generic_multicast_protocol.go",
"new_path": "pkg/tcpip/network/ip/generic_multicast_protocol.go",
"diff": "@@ -161,7 +161,8 @@ type GenericMulticastProtocolState struct {\n// Init initializes the Generic Multicast Protocol state.\n//\n-// ... | Go | Apache License 2.0 | google/gvisor | Do not perform IGMP/MLD on loopback interfaces
The loopback interface will never have any neighbouring nodes so
advertising its interest in multicast groups is unnecessary.
Bug #4682, #4861
Startblock:
has LGTM from asfez
and then
add reviewer tamird
PiperOrigin-RevId: 346587604 |
259,975 | 09.12.2020 11:55:06 | 28,800 | 992769c7748d886e7ee1580f0c6cfdfa7ce0eb75 | Add tensorflow, ffmpeg, and redis jobs. | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -67,11 +67,11 @@ build_test(\n\"//test/benchmarks/base:startup_test\",\n\"//test/benchmarks/base:size_test\",\n\"//test/benchmarks/base:sysbench_test\",\n- \"//test/benchmarks/database:database_test\",\n+ \"//test/bench... | Go | Apache License 2.0 | google/gvisor | Add tensorflow, ffmpeg, and redis jobs.
PiperOrigin-RevId: 346603153 |
259,975 | 09.12.2020 13:49:41 | 28,800 | b4af9d4572707718514e66b7e537bc51216b60f6 | Add network benchmarks jobs
Add httpd, nginx, node, and ruby benchmarks to continuous jobs. | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -72,7 +72,10 @@ build_test(\n\"//test/benchmarks/fs:fio_test\",\n\"//test/benchmarks/media:ffmpeg_test\",\n\"//test/benchmarks/ml:tensorflow_test\",\n- \"//test/benchmarks/network:network_test\",\n+ \"//test/benchmarks/... | Go | Apache License 2.0 | google/gvisor | Add network benchmarks jobs
Add httpd, nginx, node, and ruby benchmarks to continuous jobs.
PiperOrigin-RevId: 346629115 |
259,962 | 09.12.2020 14:54:43 | 28,800 | 92ca72ecb73d91e9def31e7f9835adf7a50b3d65 | Add support for IP_RECVORIGDSTADDR IP option.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/control.go",
"new_path": "pkg/sentry/socket/control/control.go",
"diff": "@@ -359,13 +359,26 @@ func PackIPPacketInfo(t *kernel.Task, packetInfo tcpip.IPPacketInfo, buf []byte)\n)\n}\n+// PackOriginalDstAddress packs an IP_RECVORIGINA... | Go | Apache License 2.0 | google/gvisor | Add support for IP_RECVORIGDSTADDR IP option.
Fixes #5004
PiperOrigin-RevId: 346643745 |
259,858 | 09.12.2020 18:48:52 | 28,800 | 65a2242db409e7f4aeef04a01eb4f89699557866 | Tweak aarch64 support.
A few images were broken with respect to aarch64. We should now
be able to run push-all-images with ARCH=aarch64 as part of the
regular continuous integration builds, and add aarch64 smoke tests
(via user emulation for now) to the regular test suite (future). | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -9,7 +9,8 @@ _templates:\nsteps:\n# Run basic smoke tests before preceding to other tests.\n- - label: \":fire: Smoke tests\"\n+ - <<: *common\n+ label: \":fire: Smoke tests\"\ncomm... | Go | Apache License 2.0 | google/gvisor | Tweak aarch64 support.
A few images were broken with respect to aarch64. We should now
be able to run push-all-images with ARCH=aarch64 as part of the
regular continuous integration builds, and add aarch64 smoke tests
(via user emulation for now) to the regular test suite (future).
PiperOrigin-RevId: 346685462 |
259,885 | 10.12.2020 15:17:20 | 28,800 | ed0c7be614eaf1ec19dae90d1516a5e90ec1f793 | Proposal for runtime.DedicateOSThread().
Updates | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "g3doc/proposals/runtime_dedicate_os_thread.md",
"diff": "+# `runtime.DedicateOSThread`\n+\n+Status as of 2020-09-18: Deprioritized; initial studies in #2180 suggest that\n+this may be difficult to support in the Go runtime due to issues with GC.... | Go | Apache License 2.0 | google/gvisor | Proposal for runtime.DedicateOSThread().
Updates #2184
PiperOrigin-RevId: 346875966 |
259,860 | 10.12.2020 15:28:57 | 28,800 | dbc86593db8f9d34dbe5098d38f6dc374d50280c | Fix typo in go template error messages. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_generics/defs.bzl",
"new_path": "tools/go_generics/defs.bzl",
"diff": "@@ -67,7 +67,7 @@ def _go_template_instance_impl(ctx):\n# Check that all defined types are expected by the template.\nfor t in ctx.attr.types:\nif (t not in info.types) and (t not ... | Go | Apache License 2.0 | google/gvisor | Fix typo in go template error messages.
PiperOrigin-RevId: 346878344 |
259,884 | 10.12.2020 18:04:45 | 28,800 | 28c3260d74930a556febafdfaf9e2cecae1b9d3e | Add simple guidelines & instructions for blog contribution
Modeled after knative's blog guidelines. | [
{
"change_type": "MODIFY",
"old_path": "website/blog/index.html",
"new_path": "website/blog/index.html",
"diff": "@@ -20,3 +20,8 @@ pagination:\n{% if paginator.total_pages > 1 %}\n{% include paginator.html %}\n{% endif %}\n+\n+<hr>\n+\n+If you would like to contribute to the gVisor blog check out t... | Go | Apache License 2.0 | google/gvisor | Add simple guidelines & instructions for blog contribution
Modeled after knative's blog guidelines.
https://github.com/knative/docs/blob/master/blog/README.md
PiperOrigin-RevId: 346905713 |
260,001 | 10.12.2020 20:50:45 | 28,800 | e7279936e8128c1ade57a26eb76726cabcb762a9 | Change merkle root file name to avoid collision | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -64,6 +64,10 @@ const (\n// tree file for \"/foo\" is \"/.merkle.verity.foo\".\nmerklePrefix = \".merkle.verity.\"\n+ // merkleRootPrefix is the prefix of the Me... | Go | Apache License 2.0 | google/gvisor | Change merkle root file name to avoid collision
PiperOrigin-RevId: 346923826 |
259,884 | 10.12.2020 21:47:38 | 28,800 | 0eb4acad37c448a298c77090b3475ce6903ecf18 | Fix website build
Fix 'run' function call so that parameters are passed properly to the function. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -371,7 +371,7 @@ WEBSITE_PROJECT := gvisordev\nWEBSITE_REGION := us-central1\nwebsite-build: load-jekyll ## Build the site image locally.\n- @$(call run,//website:website $(WEBSITE_IMAGE))\n+ @$(call run,//website... | Go | Apache License 2.0 | google/gvisor | Fix website build
Fix 'run' function call so that parameters are passed properly to the function.
PiperOrigin-RevId: 346929952 |
259,875 | 11.12.2020 04:19:58 | 28,800 | 73eccab91ec58aafd1ffdf038993b78a812ba30f | Make semctl IPC_INFO cmd return the index of highest used entry. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "@@ -52,6 +52,9 @@ type Registry struct {\nmu sync.Mutex `state:\"nosave\"`\nsemaphores map[int32]*Set\nlastIDUsed int32\n+ // indexes maintains a mappin... | Go | Apache License 2.0 | google/gvisor | Make semctl IPC_INFO cmd return the index of highest used entry.
PiperOrigin-RevId: 346973338 |
259,858 | 11.12.2020 09:42:58 | 28,800 | e0cde3fb87e8fd41437da7e2506664881544ef2b | Ensure individual steps timeout in case of infinite hang.
Also, add a basic release test. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "_templates:\ncommon: &common\n+ timeout_in_minutes: 30\nretry:\nautomatic:\n- exit_status: -1\n@@ -22,6 +23,11 @@ steps:\n- git checkout go && git clean -f\n- go build ./...\n+ # Relea... | Go | Apache License 2.0 | google/gvisor | Ensure individual steps timeout in case of infinite hang.
Also, add a basic release test.
PiperOrigin-RevId: 347016796 |
259,975 | 11.12.2020 11:24:22 | 28,800 | 3c673caf86c83070786a6baec0e92e109bfcbb54 | Fix parser to include iterations. | [
{
"change_type": "MODIFY",
"old_path": "tools/bigquery/bigquery.go",
"new_path": "tools/bigquery/bigquery.go",
"diff": "@@ -21,6 +21,7 @@ package bigquery\nimport (\n\"context\"\n\"fmt\"\n+ \"strconv\"\n\"strings\"\n\"time\"\n@@ -109,6 +110,12 @@ func NewBenchmark(name string, iters int) *Benchmark ... | Go | Apache License 2.0 | google/gvisor | Fix parser to include iterations.
PiperOrigin-RevId: 347038652 |
259,858 | 11.12.2020 11:50:08 | 28,800 | 76c2f21cecf6c690aaf3aba8eccbc593eb3a6305 | Add local hooks for BuildKite. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".buildkite/hooks/post-command",
"diff": "+# Upload test logs on failure, if there are any.\n+if [[ \"${BUILDKITE_COMMAND_EXIT_STATUS}\" -ne \"0\" ]]; then\n+ declare log_count=0\n+ for log in $(make testlogs 2>/dev/null | sort | uniq); do\n+ bui... | Go | Apache License 2.0 | google/gvisor | Add local hooks for BuildKite.
PiperOrigin-RevId: 347044353 |
259,858 | 11.12.2020 13:23:27 | 28,800 | 5bdc167d174515eb51ba1bb0f4b4d1e484e8996c | Fix run and sudo targets.
These are not passing arguments properly. This breaks the current
pre-command for BuildKite. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -4,7 +4,8 @@ PARTITION=$((${PARTITION}+1)) # 1-indexed, but PARALLEL_JOB is 0-indexed.\nexport TOTAL_PARTITIONS=${BUILDKITE_PARALLEL_JOB_COUNT:-1}\n# Ensure Docker has exper... | Go | Apache License 2.0 | google/gvisor | Fix run and sudo targets.
These are not passing arguments properly. This breaks the current
pre-command for BuildKite.
PiperOrigin-RevId: 347062729 |
259,860 | 11.12.2020 15:41:44 | 28,800 | 1e92732eb19ac5cfa3df6ff01cc1ea71d80a9198 | Make fixes to vfs2 leak checking. | [
{
"change_type": "MODIFY",
"old_path": "pkg/refsvfs2/BUILD",
"new_path": "pkg/refsvfs2/BUILD",
"diff": "@@ -9,7 +9,7 @@ go_template(\n\"refs_template.go\",\n],\nopt_consts = [\n- \"logTrace\",\n+ \"enableLogging\",\n],\ntypes = [\n\"T\",\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/... | Go | Apache License 2.0 | google/gvisor | Make fixes to vfs2 leak checking.
PiperOrigin-RevId: 347089828 |
259,975 | 11.12.2020 20:53:59 | 28,800 | 4b697aae55eacac75f5e9c76aacd40981720c3fd | Fix long running bazel build jobs.
Skip the bazel clean command on the last run of the benchmark.
Use --test.benchtime=1ns to force running the benchmark once
(https://github.com/golang/go/issues/32051) | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/fs/bazel_test.go",
"new_path": "test/benchmarks/fs/bazel_test.go",
"diff": "@@ -61,10 +61,10 @@ func runBuildBenchmark(b *testing.B, image, workdir, target string) {\nfor _, bm := range benchmarks {\npageCache := tools.Parameter{\nName: \"page_... | Go | Apache License 2.0 | google/gvisor | Fix long running bazel build jobs.
- Skip the bazel clean command on the last run of the benchmark.
- Use --test.benchtime=1ns to force running the benchmark once
(https://github.com/golang/go/issues/32051)
PiperOrigin-RevId: 347124606 |
259,896 | 14.12.2020 10:20:49 | 28,800 | ab593661efe4924369265a6b9f0dc719dcb371ab | Move SO_ERROR and SO_OOBINLINE option to socketops.
SO_OOBINLINE option is set/get as boolean value, which is the same as linux.
As we currently do not support disabling this option, we always return it as
true. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -965,7 +965,7 @@ func getSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, fam\n}\n// Get the last error and convert it.\n- err := ep.... | Go | Apache License 2.0 | google/gvisor | Move SO_ERROR and SO_OOBINLINE option to socketops.
SO_OOBINLINE option is set/get as boolean value, which is the same as linux.
As we currently do not support disabling this option, we always return it as
true.
PiperOrigin-RevId: 347413905 |
259,860 | 14.12.2020 10:44:53 | 28,800 | 65e4ed8fbe15e3a8ebf96fdacf439d30d8a0e491 | Do not check for reference leaks after saving.
We should not assert that all resources are dropped after saving. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/state.go",
"new_path": "pkg/sentry/control/state.go",
"diff": "@@ -62,6 +62,7 @@ func (s *State) Save(o *SaveOpts, _ *struct{}) error {\nCallback: func(err error) {\nif err == nil {\nlog.Infof(\"Save succeeded: exiting...\")\n+ s.Kernel.SetS... | Go | Apache License 2.0 | google/gvisor | Do not check for reference leaks after saving.
We should not assert that all resources are dropped after saving.
PiperOrigin-RevId: 347420131 |
259,896 | 14.12.2020 12:00:46 | 28,800 | 2e191cb3f72858c61943168a69b0aff0fda6ee45 | Move SO_LINGER option to socketops. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -428,11 +428,7 @@ func (s *socketOpsCommon) Release(ctx context.Context) {\nreturn\n}\n- var v tcpip.LingerOption\n- if err := s.Endpoint.GetSockOpt(&v);... | Go | Apache License 2.0 | google/gvisor | Move SO_LINGER option to socketops.
PiperOrigin-RevId: 347437786 |
259,992 | 14.12.2020 21:15:49 | 28,800 | b2a697334890705fa899fd81db52d7b11c03f785 | Update containerd/cgroups | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -524,8 +524,8 @@ go_repository(\nname = \"com_github_containerd_cgroups\",\nbuild_file_proto_mode = \"disable\",\nimportpath = \"github.com/containerd/cgroups\",\n- sum = \"h1:5yg0k8gqOssNLsjjCtXIADoPbAtUtQZJfC8... | Go | Apache License 2.0 | google/gvisor | Update containerd/cgroups
PiperOrigin-RevId: 347532687 |
260,003 | 15.12.2020 09:53:20 | 28,800 | 25ebddbddfbc518a810c0aebde85a1b2e14bc7df | Fix a data race in packetEPs
packetEPs may get into a state that `len < cap`, casuing append() modifying the
original slice storage.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -54,9 +54,9 @@ type NIC struct {\nsync.RWMutex\nspoofing bool\npromiscuous bool\n- // packetEPs is protected by mu, but the contained PacketEndpoint\n- // values are not.\n- packetEPs m... | Go | Apache License 2.0 | google/gvisor | Fix a data race in packetEPs
packetEPs may get into a state that `len < cap`, casuing append() modifying the
original slice storage.
Reported-by: syzbot+978dd0e9c2600ab7a76b@syzkaller.appspotmail.com
PiperOrigin-RevId: 347634351 |
259,858 | 15.12.2020 10:02:55 | 28,800 | 4e963c99ce23ce6838b4bca351f767460601f34a | Cleanup GitHub actions workflows.
Also, drop the pull_request template, since this has not proved to be
helpful, and just results in a commit message the includes the list. | [
{
"change_type": "DELETE",
"old_path": ".github/pull_request_template.md",
"new_path": null,
"diff": "-* [ ] Have you followed the guidelines in [CONTRIBUTING.md](../blob/master/CONTRIBUTING.md)?\n-* [ ] Have you formatted and linted your code?\n-* [ ] Have you added relevant tests?\n-* [ ] Have you... | Go | Apache License 2.0 | google/gvisor | Cleanup GitHub actions workflows.
Also, drop the pull_request template, since this has not proved to be
helpful, and just results in a commit message the includes the list.
PiperOrigin-RevId: 347636507 |
259,896 | 15.12.2020 11:04:49 | 28,800 | b15acae9a6e20a09a97b5fdfee5850469ff3b0ea | Fix error code for connect in raw sockets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -404,7 +404,7 @@ func (*endpoint) Disconnect() *tcpip.Error {\nfunc (e *endpoint) Connect(addr tcpip.FullAddress) *tcpip.Error {\n// Raw sockets do not support... | Go | Apache License 2.0 | google/gvisor | Fix error code for connect in raw sockets.
PiperOrigin-RevId: 347650354 |
260,001 | 15.12.2020 15:38:19 | 28,800 | 7aa674eb68e9b760ea72508dfb79a19dbf5b85ed | Change violation mode to an enum | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -163,7 +163,7 @@ afterSymlink:\n// verifyChildLocked verifies the hash of child against the already verified\n// hash of the parent to ensure the child i... | Go | Apache License 2.0 | google/gvisor | Change violation mode to an enum
PiperOrigin-RevId: 347706953 |
259,875 | 15.12.2020 16:03:41 | 28,800 | 1e56a2f9a29ff72eada493bf024a4e3fd5a963b6 | Implement command SEM_INFO and SEM_STAT for semctl. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/sem.go",
"new_path": "pkg/abi/linux/sem.go",
"diff": "@@ -43,10 +43,10 @@ const (\nSEMVMX = 32767\nSEMAEM = SEMVMX\n- // followings are unused in kernel\nSEMUME = SEMOPM\nSEMMNU = SEMMNS\nSEMMAP = SEMMNS\n+ SEMUSZ = 20\n)\nconst SEM_UNDO = 0x1000... | Go | Apache License 2.0 | google/gvisor | Implement command SEM_INFO and SEM_STAT for semctl.
PiperOrigin-RevId: 347711998 |
260,004 | 15.12.2020 16:27:01 | 28,800 | 50c658a9f6df85998a08f51f680302366c2df240 | Don't split enabled flag across multicast group state
Startblock:
has LGTM from asfez
and then
add reviewer brunodalbo | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ip/generic_multicast_protocol.go",
"new_path": "pkg/tcpip/network/ip/generic_multicast_protocol.go",
"diff": "@@ -131,17 +131,6 @@ type multicastGroupState struct {\n// GenericMulticastProtocolOptions holds options for the generic multicast\n... | Go | Apache License 2.0 | google/gvisor | Don't split enabled flag across multicast group state
Startblock:
has LGTM from asfez
and then
add reviewer brunodalbo
PiperOrigin-RevId: 347716242 |
260,004 | 15.12.2020 17:43:38 | 28,800 | c55e5bda4d4590c84c6210b78c4b44c849f4400a | Validate router alert's data length
RFC 2711 specifies that the router alert's length field is always 2
so we should make sure only 2 bytes are read from a router alert
option's data field.
Test: header.TestIPv6OptionsExtHdrIterErr | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"new_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"bufio\"\n\"bytes\"\n\"encoding/binary\"\n+ \"errors\"\n\"fmt\"\n\"io\"\n\"math\"\n@@ -274,6 +275,10 @@ func ipv6Unknow... | Go | Apache License 2.0 | google/gvisor | Validate router alert's data length
RFC 2711 specifies that the router alert's length field is always 2
so we should make sure only 2 bytes are read from a router alert
option's data field.
Test: header.TestIPv6OptionsExtHdrIterErr
PiperOrigin-RevId: 347727876 |
259,858 | 16.12.2020 11:42:58 | 28,800 | 7da25e6dc3095378ecaf292759ef84b656a306b8 | Restore refresh target. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -132,6 +132,9 @@ configure = $(call configure_noreload,$(1),$(2)) && $(reload_docker)\ninstall_runtime = $(call configure,$(RUNTIME),$(1) --TESTONLY-test-name-env=RUNSC_TEST_NAME)\ntest_runtime = $(call test,--tes... | Go | Apache License 2.0 | google/gvisor | Restore refresh target.
PiperOrigin-RevId: 347864621 |
260,004 | 16.12.2020 17:23:40 | 28,800 | c740865f86e3b5f1692194c9d0b0d4986218f294 | Cleanup locking in multicast group protocol tests
Startblock:
has LGTM from asfez
and then
add reviewer tamird | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ip/generic_multicast_protocol_test.go",
"new_path": "pkg/tcpip/network/ip/generic_multicast_protocol_test.go",
"diff": "@@ -37,46 +37,105 @@ const (\nvar _ ip.MulticastGroupProtocol = (*mockMulticastGroupProtocol)(nil)\n-type mockMulticastGro... | Go | Apache License 2.0 | google/gvisor | Cleanup locking in multicast group protocol tests
Startblock:
has LGTM from asfez
and then
add reviewer tamird
PiperOrigin-RevId: 347928471 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.