author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,907 | 17.12.2020 08:45:38 | 28,800 | 74788b1b6194ef62f8355f7e4721c00f615d16ad | [netstack] Implement MSG_ERRQUEUE flag for recvmsg(2).
Introduces the per-socket error queue and the necessary cmsg mechanisms. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -21,6 +21,7 @@ go_library(\n\"epoll_amd64.go\",\n\"epoll_arm64.go\",\n\"errors.go\",\n+ \"errqueue.go\",\n\"eventfd.go\",\n\"exec.go\",\n\"fadvise.go\",\n"
},
{
"change_type": "ADD",
... | Go | Apache License 2.0 | google/gvisor | [netstack] Implement MSG_ERRQUEUE flag for recvmsg(2).
Introduces the per-socket error queue and the necessary cmsg mechanisms.
PiperOrigin-RevId: 348028508 |
259,992 | 17.12.2020 10:43:55 | 28,800 | e7493a9e23325c00ad9a0db341d5887afe3ae5eb | Set max memory not min
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -294,7 +294,7 @@ func New(args Args) (*Loader, error) {\nif args.TotalMem > 0 {\n// Adjust the total memory returned by the Sentry so that applications that\n// use /proc/meminfo can make a... | Go | Apache License 2.0 | google/gvisor | Set max memory not min
Closes #5048
PiperOrigin-RevId: 348050472 |
259,992 | 17.12.2020 10:53:50 | 28,800 | 30860902f6953348577e6a1d742521c6fbc4c75d | Set process group and session on host TTY
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -31,6 +31,7 @@ import (\nfslock \"gvisor.dev/gvisor/pkg/sentry/fs/lock\"\n\"gvisor.dev/gvisor/pkg/sentry/fsimpl/kernfs\"\n\"gvisor.dev/gvisor/pkg/sentry/hostfd\"\n+ \"gv... | Go | Apache License 2.0 | google/gvisor | Set process group and session on host TTY
Closes #5128
PiperOrigin-RevId: 348052446 |
259,907 | 17.12.2020 11:07:56 | 28,800 | 028271b5308708463d2aa593122840e70c93f02c | [netstack] Implement IP(V6)_RECVERR socket option. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -331,12 +331,12 @@ func (s *socketOpsCommon) GetSockOpt(t *kernel.Task, level int, name int, outPtr\nswitch level {\ncase linux.SOL_IP:\nswitch name {\n- cas... | Go | Apache License 2.0 | google/gvisor | [netstack] Implement IP(V6)_RECVERR socket option.
PiperOrigin-RevId: 348055514 |
259,992 | 17.12.2020 12:40:26 | 28,800 | eeee055d60bed55c864c3b87c23785b00f1609e8 | Set --nocache_test_results to runtime tests
If not set, the cached result is used even when runtime options
are changed, because they are not visible to blaze/bazel. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -130,7 +130,9 @@ configure = $(call configure_noreload,$(1),$(2)) && $(reload_docker)\n# Helpers for above. Requires $(RUNTIME_BIN) dependency.\ninstall_runtime = $(call configure,$(RUNTIME),$(1) --TESTONLY-test-n... | Go | Apache License 2.0 | google/gvisor | Set --nocache_test_results to runtime tests
If not set, the cached result is used even when runtime options
are changed, because they are not visible to blaze/bazel.
PiperOrigin-RevId: 348074339 |
260,001 | 17.12.2020 14:20:56 | 28,800 | 433fd0e64650e31ab28e9d918d6dfcd9a67b4246 | Set verityMu to be state nosave | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -180,7 +180,7 @@ type filesystem struct {\n// its children. So they shouldn't be enabled the same time. This lock\n// is for the whole file system to ensure that... | Go | Apache License 2.0 | google/gvisor | Set verityMu to be state nosave
PiperOrigin-RevId: 348092999 |
259,891 | 21.12.2020 14:42:32 | 28,800 | 981faa2c122922e0cb9f2996c56b4b7c38e18bfb | RLock Endpoint in raw.Endpoint.HandlePacket | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -620,6 +620,7 @@ func (e *endpoint) GetSockOptInt(opt tcpip.SockOptInt) (int, *tcpip.Error) {\n// HandlePacket implements stack.RawTransportEndpoint.HandlePack... | Go | Apache License 2.0 | google/gvisor | RLock Endpoint in raw.Endpoint.HandlePacket
PiperOrigin-RevId: 348530530 |
259,853 | 21.12.2020 15:47:58 | 28,800 | 946cb909e62e0aaca9e3bbb7cf059dd6b0eab2ce | Don't modify a packet header when it can be used by other endpoints
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/checksum_test.go",
"new_path": "pkg/tcpip/header/checksum_test.go",
"diff": "@@ -19,6 +19,7 @@ package header_test\nimport (\n\"fmt\"\n\"math/rand\"\n+ \"sync\"\n\"testing\"\n\"gvisor.dev/gvisor/pkg/tcpip/buffer\"\n@@ -169,3 +170,96 @@ func Be... | Go | Apache License 2.0 | google/gvisor | Don't modify a packet header when it can be used by other endpoints
Reported-by: syzbot+48c43f82fe7738fceae9@syzkaller.appspotmail.com
PiperOrigin-RevId: 348540796 |
259,896 | 22.12.2020 14:41:11 | 28,800 | 7c8ba72b026db3b79f12e679ab69078a25c143e8 | Move SO_BINDTODEVICE to socketops. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1042,10 +1042,7 @@ func getSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, fam\nreturn &v, nil\ncase linux.SO_BINDTODEVICE:\n- var ... | Go | Apache License 2.0 | google/gvisor | Move SO_BINDTODEVICE to socketops.
PiperOrigin-RevId: 348696094 |
259,853 | 23.12.2020 11:08:42 | 28,800 | d07915987631f4c3c6345275019a5b5b0cf28dbb | vfs1: don't allow to open socket files
open() has to return ENXIO in this case.
O_PATH isn't supported by vfs1. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/inode.go",
"new_path": "pkg/sentry/fs/gofer/inode.go",
"diff": "@@ -475,6 +475,9 @@ func (i *inodeOperations) Check(ctx context.Context, inode *fs.Inode, p fs.PermM\nfunc (i *inodeOperations) GetFile(ctx context.Context, d *fs.Dirent, flags... | Go | Apache License 2.0 | google/gvisor | vfs1: don't allow to open socket files
open() has to return ENXIO in this case.
O_PATH isn't supported by vfs1.
PiperOrigin-RevId: 348820478 |
259,891 | 23.12.2020 15:18:54 | 28,800 | 5259b90dac7201c2e2f80ff5e1c25050e11d4035 | Resolve compiler warnings
The buildkite syscall tests start with a lot of C++ warnings. This
cleans that up a little. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pipe.cc",
"new_path": "test/syscalls/linux/pipe.cc",
"diff": "@@ -71,13 +71,13 @@ class PipeTest : public ::testing::TestWithParam<PipeCreator> {\n// Returns true iff the pipe represents a named pipe.\nbool IsNamedPipe() const { return name... | Go | Apache License 2.0 | google/gvisor | Resolve compiler warnings
The buildkite syscall tests start with a lot of C++ warnings. This
cleans that up a little. |
259,857 | 26.12.2020 11:20:38 | -28,800 | d56ea8dfe40f02600de233797ba0ba0c4c340cbb | typo: change whicy to which | [
{
"change_type": "MODIFY",
"old_path": "tools/checkescape/checkescape.go",
"new_path": "tools/checkescape/checkescape.go",
"diff": "// heap: A direct allocation is made on the heap (hard).\n// builtin: A call is made to a built-in allocation function (hard).\n// stack: A stack split as part of a fun... | Go | Apache License 2.0 | google/gvisor | typo: change whicy to which
Signed-off-by: Lai Jiangshan <jiangshan.ljs@antfin.com> |
260,019 | 29.12.2020 17:40:50 | -28,800 | 7e91b3cdec3d744d86f808662fcfb1510470d1c0 | arm64 kvm: revert some kpti related codes, and configure upper pagetable as global
In order to improve the performance, some kpti related codes(TCR.A1) have
been reverted, and set kernel pagetable as global. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_arm64.go",
"new_path": "pkg/sentry/platform/kvm/machine_arm64.go",
"diff": "@@ -54,7 +54,7 @@ func (m *machine) mapUpperHalf(pageTable *pagetables.PageTables) {\npageTable.Map(\nusermem.Addr(ring0.KernelStartAddress|pr.virtual),... | Go | Apache License 2.0 | google/gvisor | arm64 kvm: revert some kpti related codes, and configure upper pagetable as global
In order to improve the performance, some kpti related codes(TCR.A1) have
been reverted, and set kernel pagetable as global.
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
259,858 | 29.12.2020 16:21:27 | 28,800 | 85c1c3ed4b8d32c499c53917765acef20cb16248 | Make profiling commands synchronous.
This allows for a model of profiling when you can start collection, and
it will terminate when the sandbox terminates. Without this synchronous
call, it is effectively impossible to collect length blocking and mutex
profiles. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/pprof.go",
"new_path": "pkg/sentry/control/pprof.go",
"diff": "package control\nimport (\n- \"errors\"\n\"runtime\"\n\"runtime/pprof\"\n\"runtime/trace\"\n+ \"time\"\n\"gvisor.dev/gvisor/pkg/fd\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel\"\n@@ ... | Go | Apache License 2.0 | google/gvisor | Make profiling commands synchronous.
This allows for a model of profiling when you can start collection, and
it will terminate when the sandbox terminates. Without this synchronous
call, it is effectively impossible to collect length blocking and mutex
profiles.
PiperOrigin-RevId: 349483418 |
259,875 | 29.12.2020 17:36:45 | 28,800 | d302c05700ab3474facded345d3d59d7cbc38184 | Deflake semaphore_test_native | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/semaphore.cc",
"new_path": "test/syscalls/linux/semaphore.cc",
"diff": "#include \"test/util/test_util.h\"\n#include \"test/util/thread_util.h\"\n-using ::testing::Contains;\n-\nnamespace gvisor {\nnamespace testing {\nnamespace {\n@@ -793,... | Go | Apache License 2.0 | google/gvisor | Deflake semaphore_test_native
PiperOrigin-RevId: 349490873 |
259,858 | 29.12.2020 17:44:25 | 28,800 | 3c58405a544dcd599bd84406b5d52848941675f7 | Exclude changing generated file from go_branch. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_branch.sh",
"new_path": "tools/go_branch.sh",
"diff": "@@ -89,8 +89,14 @@ git merge --no-commit --strategy ours \"${head}\" || \\\nfind . -type f -exec chmod 0644 {} \\;\nfind . -type d -exec chmod 0755 {} \\;\n-# Sync the entire gopath_dir.\n-rsync -... | Go | Apache License 2.0 | google/gvisor | Exclude changing generated file from go_branch.
PiperOrigin-RevId: 349491589 |
259,858 | 29.12.2020 23:26:29 | 28,800 | ed5850e8eb98c33d90f7233c0fb196d74e347439 | Add continuous VFS1 tests. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -105,3 +105,30 @@ steps:\nlabel: \":python: Python runtime tests\"\ncommand: make python3.7.3-runtime-tests_vfs2\nparallelism: 10\n+\n+ # Runtime tests (VFS1).\n+ - <<: *common\n+ l... | Go | Apache License 2.0 | google/gvisor | Add continuous VFS1 tests.
PiperOrigin-RevId: 349517093 |
259,992 | 30.12.2020 11:16:12 | 28,800 | 1b66bad7c47e914994e19f39119d91ab6805002a | Fix condition checking in `runsc debug`
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/debug.go",
"new_path": "runsc/cmd/debug.go",
"diff": "@@ -124,7 +124,7 @@ func (d *Debug) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\n}\n}\n- if c.IsSandboxRunning() {\n+ if !c.IsSandboxRunning() {\nreturn Errorf(\"container san... | Go | Apache License 2.0 | google/gvisor | Fix condition checking in `runsc debug`
Closes #5052
PiperOrigin-RevId: 349579814 |
259,858 | 30.12.2020 14:51:23 | 28,800 | 0fb5de1154411bd207dadae31c37054db9941061 | Use a stable ordering for generated types.
Otherwise this pollutes the 'go' branch and doesn't conform to standards
for generate bazel files. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/gomarshal/generator.go",
"new_path": "tools/go_marshal/gomarshal/generator.go",
"diff": "@@ -447,7 +447,15 @@ func (g *Generator) Run() error {\nfor i, a := range asts {\n// Collect type declarations marked for code generation and generate\n//... | Go | Apache License 2.0 | google/gvisor | Use a stable ordering for generated types.
Otherwise this pollutes the 'go' branch and doesn't conform to standards
for generate bazel files.
PiperOrigin-RevId: 349605037 |
259,860 | 30.12.2020 15:20:34 | 28,800 | 4691a8125370d61ccb9732574e97ccc26362af42 | Add test for open(2) with O_WRONLY|O_RDWR. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/open.cc",
"new_path": "test/syscalls/linux/open.cc",
"diff": "@@ -505,6 +505,18 @@ TEST_F(OpenTest, OpenNonDirectoryWithTrailingSlash) {\nEXPECT_THAT(open(bad_path.c_str(), O_RDONLY), SyscallFailsWithErrno(ENOTDIR));\n}\n+TEST_F(OpenTest, O... | Go | Apache License 2.0 | google/gvisor | Add test for open(2) with O_WRONLY|O_RDWR.
PiperOrigin-RevId: 349607959 |
259,858 | 30.12.2020 16:52:06 | 28,800 | 3b1d37f6ab5ca547020fdd573d3bf6a621313132 | Remove remote execution support. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "# See the License for the specific language governing permissions and\n# limitations under the License.\n-# RBE requires a strong hash function, such as SHA256.\n+# Ensure a strong hash function.\nstartup --host_jvm_... | Go | Apache License 2.0 | google/gvisor | Remove remote execution support.
PiperOrigin-RevId: 349616845 |
259,853 | 05.01.2021 09:45:27 | 28,800 | 2a200811d4c95e1c84d2bdd56068f02d46ebc524 | fs/fuse: check that a task has a specified file descriptor
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"new_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"diff": "@@ -129,6 +129,9 @@ func (fsType FilesystemType) GetFilesystem(ctx context.Context, vfsObj *vfs.Virt\nreturn nil, nil, syserror.EINVAL\n}\nfuseFDGeneric := kernelTask.G... | Go | Apache License 2.0 | google/gvisor | fs/fuse: check that a task has a specified file descriptor
Reported-by: syzbot+814105309d2ae8651084@syzkaller.appspotmail.com
PiperOrigin-RevId: 350159452 |
259,858 | 05.01.2021 12:38:12 | 28,800 | 33d59811fc4882a1fffeb7452be7a370fb769ddf | Change the build badge to point to BuildKite. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/build.yml",
"new_path": ".github/workflows/build.yml",
"diff": "# posts them to GitHub, if applicable. This leverages the fact that the\n# workflow token has appropriate permissions to do so, and attempts to\n# leverage the GitHub workflow ca... | Go | Apache License 2.0 | google/gvisor | Change the build badge to point to BuildKite.
PiperOrigin-RevId: 350197814 |
259,891 | 05.01.2021 14:43:35 | 28,800 | ce7a4440cae8ee4b2a41808f967c9847cafd2937 | Fix panic when parsing SO_TIMESTAMP cmsg | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/BUILD",
"new_path": "pkg/sentry/socket/control/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\npackage(licenses = [\"notice\"])\n@@ -26,3 +26,17 @@ go_library(\n\... | Go | Apache License 2.0 | google/gvisor | Fix panic when parsing SO_TIMESTAMP cmsg
PiperOrigin-RevId: 350223482 |
259,853 | 05.01.2021 16:46:00 | 28,800 | b9b99d3d26b0d4907e8d24b4a842b31a91151aab | Don't check that msg_flags contains MSG_ERRQUEUE on gvisor platforms. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/udp_socket.cc",
"new_path": "test/syscalls/linux/udp_socket.cc",
"diff": "@@ -835,6 +835,11 @@ TEST_P(UdpSocketTest, RecvErrorConnRefused) {\n// Check the contents of msg.\nEXPECT_EQ(memcmp(got, buf, sizeof(buf)), 0); // iovec check\n+ // T... | Go | Apache License 2.0 | google/gvisor | Don't check that msg_flags contains MSG_ERRQUEUE on gvisor platforms.
PiperOrigin-RevId: 350246333 |
259,858 | 05.01.2021 18:13:18 | 28,800 | ab32fa2481d84e3f390f2cd81e25c537756b7aa1 | Make type sanity checking happen only in race builds.
This adds significant costs to startup, since it is done for
every type in the system. Since the state package already saves
sanity checks for race builds, use this for type registration. | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/tests/register_test.go",
"new_path": "pkg/state/tests/register_test.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n+// +build race\n+\npackage tests\nimport (\n@@ -165,3 +167,1... | Go | Apache License 2.0 | google/gvisor | Make type sanity checking happen only in race builds.
This adds significant costs to startup, since it is done for
every type in the system. Since the state package already saves
sanity checks for race builds, use this for type registration.
PiperOrigin-RevId: 350259336 |
259,858 | 05.01.2021 18:52:55 | 28,800 | a1e3845b65c266fe083e67811657bb7b764c4413 | Make build command more robust.
This returns all targets, and handles no targets. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -189,13 +189,13 @@ build_paths = \\\n(set -euo pipefail; \\\n$(call wrapper,$(BAZEL) build $(BASE_OPTIONS) $(1)) 2>&1 \\\n| tee /proc/self/fd/2 \\\n- | grep -A1 -E '^Target' \\\n- | grep -E '^ ($(subst... | Go | Apache License 2.0 | google/gvisor | Make build command more robust.
This returns all targets, and handles no targets.
PiperOrigin-RevId: 350263578 |
259,881 | 06.01.2021 08:15:48 | 28,800 | 23f94cee675744dd4e5d6cbcca5a3492d08e28fb | Include objdump failures in test output.
We log a warning if objdump fails, but this appears in the build log, not test
log, which can make it hard to notice.
Include it with the actual escape output as context on "(possible)" to make it
more clear when something is wrong. | [
{
"change_type": "MODIFY",
"old_path": "tools/checkescape/checkescape.go",
"new_path": "tools/checkescape/checkescape.go",
"diff": "@@ -618,12 +618,12 @@ func findReasons(pass *analysis.Pass, fdecl *ast.FuncDecl) ([]EscapeReason, bool\n// run performs the analysis.\nfunc run(pass *analysis.Pass, loc... | Go | Apache License 2.0 | google/gvisor | Include objdump failures in test output.
We log a warning if objdump fails, but this appears in the build log, not test
log, which can make it hard to notice.
Include it with the actual escape output as context on "(possible)" to make it
more clear when something is wrong.
PiperOrigin-RevId: 350355759 |
260,004 | 06.01.2021 14:01:05 | 28,800 | 7817e3b5e4202eb2001806b5043052a2f5b591a4 | Do not filter frames in ethernet link endpoint
Ethernet frames are usually filtered at the hardware-level so there is
no need to filter the frames in software.
For test purposes, a new link endpoint was introduced to filter frames
based on their destination. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/ethernet/BUILD",
"new_path": "pkg/tcpip/link/ethernet/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\npackage(licenses = [\"notice\"])\n@@ -13,3 +13,17 @@ go_library(\n\"//p... | Go | Apache License 2.0 | google/gvisor | Do not filter frames in ethernet link endpoint
Ethernet frames are usually filtered at the hardware-level so there is
no need to filter the frames in software.
For test purposes, a new link endpoint was introduced to filter frames
based on their destination.
PiperOrigin-RevId: 350422941 |
259,891 | 06.01.2021 15:23:47 | 28,800 | 084ad582105901e8f655539ace21339db8bf8be4 | Run external networking test | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -639,6 +639,10 @@ syscall_test(\ntest = \"//test/syscalls/linux:socket_inet_loopback_nogotsan_test\",\n)\n+syscall_test(\n+ test = \"//test/syscalls/linux:socket_ipv4_udp_unbound_external_net... | Go | Apache License 2.0 | google/gvisor | Run external networking test
PiperOrigin-RevId: 350438564 |
259,858 | 06.01.2021 15:36:02 | 28,800 | f89af8b5045bfdcb24ce8cc74ed676d77c9e67a6 | Don't canonicalize cache directory.
... Otherwise it will be mounted in via some other path, and will
not be available inside the container at all. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -47,8 +47,8 @@ HASH := $(shell readlink -m $(CURDIR) | md5sum | cut -c1-8)\nBUILDER_NAME := gvisor-builder-$(HASH)-$(ARCH)\nDOCKER_NAME := gvisor-bazel-$(HASH)-$(ARCH)\nDOCKER_PRIVILEGED := --privilege... | Go | Apache License 2.0 | google/gvisor | Don't canonicalize cache directory.
... Otherwise it will be mounted in via some other path, and will
not be available inside the container at all.
PiperOrigin-RevId: 350440843 |
259,858 | 06.01.2021 15:36:23 | 28,800 | fa8682da0fd43556ae0a405c02bac27e6d15a8e6 | Export a pprof visualization endpoint.
This allows us to link directly to profiling results from
the build results. The code uses the standard pprof http
server, exported from the Cloud Run instance. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/post-command",
"new_path": ".buildkite/hooks/post-command",
"diff": "@@ -27,10 +27,14 @@ make -s testlogs 2>/dev/null | grep // | sort | uniq | (\n# Upload all profiles, and include in an annotation.\ndeclare profile_output=$(mktemp --tmpdir)\... | Go | Apache License 2.0 | google/gvisor | Export a pprof visualization endpoint.
This allows us to link directly to profiling results from
the build results. The code uses the standard pprof http
server, exported from the Cloud Run instance.
PiperOrigin-RevId: 350440910 |
259,858 | 07.01.2021 01:15:20 | 28,800 | 776016ac6412006671a5dbccb5e9af21bf9b01f7 | Fix native benchmarks. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -12,7 +12,7 @@ _templates:\nretry:\nautomatic: false\nsoft_fail: true\n- if: build.message =~ /benchmarks/ || build.branch == \"master\"\n+ if: build.branch == \"master\"\nenv:\n# B... | Go | Apache License 2.0 | google/gvisor | Fix native benchmarks.
PiperOrigin-RevId: 350509137 |
259,881 | 07.01.2021 09:53:33 | 18,000 | a0037b8976d1ea482e1545adfa65403ca43dbb1a | website: redirect module to pkg.go.dev
Add redirects from any module package path to its corressponding
pkg.go.dev documentation. e.g., gvisor.dev/gvisor/pkg/sentry/kernel ->
This is a handy way to get to documentation, also used by other vanity
domains, like golang.org/x/tools. | [
{
"change_type": "MODIFY",
"old_path": "website/cmd/server/main.go",
"new_path": "website/cmd/server/main.go",
"diff": "@@ -171,7 +171,7 @@ func redirectHandler(target string) http.Handler {\n})\n}\n-// redirectRedirects registers redirect http handlers.\n+// registerRedirects registers redirect htt... | Go | Apache License 2.0 | google/gvisor | website: redirect module to pkg.go.dev
Add redirects from any module package path to its corressponding
pkg.go.dev documentation. e.g., gvisor.dev/gvisor/pkg/sentry/kernel ->
https://pkg.go.dev/gvisor.dev/gvisor/pkg/sentry/kernel.
This is a handy way to get to documentation, also used by other vanity
domains, like golang.org/x/tools. |
259,992 | 07.01.2021 09:29:48 | 28,800 | 4c5f36e7bd4781fc9984ef4fdf98009b5ec4cb4c | Update link to benchmarks
Closes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/architecture_guide/performance.md",
"new_path": "g3doc/architecture_guide/performance.md",
"diff": "@@ -269,7 +269,7 @@ operations are less of an issue. The above figure shows the total time required\nfor an `ffmpeg` container to start, load and transcod... | Go | Apache License 2.0 | google/gvisor | Update link to benchmarks
Closes #5192
PiperOrigin-RevId: 350578130 |
259,975 | 07.01.2021 12:47:12 | 28,800 | f4b4ed666d13eef6aebe23189b1431a933de0d8e | Add runsc build job to BuildKite. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -158,6 +158,9 @@ steps:\n- <<: *benchmarks\nlabel: \":bazel: ABSL build benchmarks\"\ncommand: make benchmark-platforms BENCHMARKS_FILTER=\"ABSL/page_cache.clean\" BENCHMARKS_SUITE=... | Go | Apache License 2.0 | google/gvisor | Add runsc build job to BuildKite.
PiperOrigin-RevId: 350619346 |
260,023 | 07.01.2021 15:06:18 | 28,800 | 04b37c822022c27cb144e4af5ef21043a74127f3 | Fix tuntap_test to cleanup after CreateInterfaceNoCap | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tuntap.cc",
"new_path": "test/syscalls/linux/tuntap.cc",
"diff": "@@ -162,12 +162,19 @@ TEST(TuntapStaticTest, NetTunExists) {\nclass TuntapTest : public ::testing::Test {\nprotected:\n+ void SetUp() override {\n+ have_net_admin_cap_ =\n+ A... | Go | Apache License 2.0 | google/gvisor | Fix tuntap_test to cleanup after CreateInterfaceNoCap
PiperOrigin-RevId: 350646249 |
259,858 | 07.01.2021 15:28:41 | 28,800 | 77b340ce82230e4e0bded01f43232c708328cd7e | Require specific buckets for pprof handler.
This further restricts the surface exposed only to artifacts
generated by the continuous integration system.
This change also installs appropriate root certificates, so
that objects can be fetched from | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "load(\"@bazel_tools//tools/build_defs/repo:http.bzl\", \"http_archive\", \"http_file\")\nload(\"@bazel_tools//tools/build_defs/repo:git.bzl\", \"git_repository\")\n+# Root certificates.\n+#\n+# Note that the sha256... | Go | Apache License 2.0 | google/gvisor | Require specific buckets for pprof handler.
This further restricts the surface exposed only to artifacts
generated by the continuous integration system.
This change also installs appropriate root certificates, so
that objects can be fetched from https://storage.googleapis.com.
PiperOrigin-RevId: 350650197 |
259,853 | 30.12.2020 01:28:26 | 28,800 | 8de562b79942f5383ffbe67873df07509ca7fcb0 | Add ARM smoke test
make BAZEL_CONFIG=aarch64 arm-qemu-smoke-test | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -20,3 +20,8 @@ build --cxxopt=-std=c++17\n# Display the current git revision in the info block.\nbuild --stamp --workspace_status_command tools/workspace_status.sh\n+\n+# Set flags for aarch64.\n+build:cross-aarch... | Go | Apache License 2.0 | google/gvisor | Add ARM smoke test
make BAZEL_CONFIG=aarch64 arm-qemu-smoke-test
Signed-off-by: Andrei Vagin <avagin@gmail.com> |
259,858 | 08.01.2021 08:14:58 | 28,800 | df1b23c8dedfa6b29f74cbd00d04182a9fa01925 | Fix sha256 for github-workflow.json.
This was not being tested as part of the unit test workflows, and thus was
not being hit normally. These tests are also added to the unit tests target. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -192,7 +192,7 @@ fuse-tests:\n.PHONY: fuse-tests\nunit-tests: ## Local package unit tests in pkg/..., runsc/, tools/.., etc.\n- @$(call test,pkg/... runsc/... tools/...)\n+ @$(call test,//:all pkg/... runsc/... to... | Go | Apache License 2.0 | google/gvisor | Fix sha256 for github-workflow.json.
This was not being tested as part of the unit test workflows, and thus was
not being hit normally. These tests are also added to the unit tests target.
PiperOrigin-RevId: 350766814 |
259,858 | 08.01.2021 09:06:52 | 28,800 | 0538ffa8ba6105e83a392c135453eb432f0860ca | Add prefix helper to link to code search results.
This is extremely convenient similar to being able to link to Go
package documentation via the canonical package names. | [
{
"change_type": "MODIFY",
"old_path": "website/cmd/server/main.go",
"new_path": "website/cmd/server/main.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"fmt\"\n\"log\"\n\"net/http\"\n+ \"net/url\"\n\"os\"\n\"path\"\n\"regexp\"\n@@ -61,19 +62,37 @@ var redirects = map[string]string{\n// Deprecated, but ... | Go | Apache License 2.0 | google/gvisor | Add prefix helper to link to code search results.
This is extremely convenient similar to being able to link to Go
package documentation via the canonical package names.
PiperOrigin-RevId: 350774913 |
259,858 | 08.01.2021 18:01:05 | 28,800 | 0c99ab70905fa4eaf8bc7b0ca846e12d7bbc6e39 | Support releasing aarch64 builds.
This change works around an issue in rules_pkg, described here: | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -40,7 +40,10 @@ steps:\n# Release workflow.\n- <<: *common\nlabel: \":ship: Release tests\"\n- commands: make release\n+ commands:\n+ - make artifacts/x86_64\n+ - make BAZEL_OPTIONS... | Go | Apache License 2.0 | google/gvisor | Support releasing aarch64 builds.
This change works around an issue in rules_pkg, described here:
https://github.com/bazelbuild/rules_pkg/pull/263
PiperOrigin-RevId: 350869030 |
259,858 | 11.01.2021 13:15:38 | 28,800 | 4c4de66443174f2ed7f4fa533a1d09c709be9427 | Make ilist split safe.
This allows for use in restricted contexts.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/ilist/list.go",
"new_path": "pkg/ilist/list.go",
"diff": "@@ -72,16 +72,22 @@ func (l *List) Reset() {\n}\n// Empty returns true iff the list is empty.\n+//\n+//go:nosplit\nfunc (l *List) Empty() bool {\nreturn l.head == nil\n}\n// Front returns the first ... | Go | Apache License 2.0 | google/gvisor | Make ilist split safe.
This allows for use in restricted contexts.
Updates #5039
PiperOrigin-RevId: 351220385 |
259,992 | 11.01.2021 16:23:44 | 28,800 | 7e462a1c7f56b9b8439ad1ac92906bd8dd376ab7 | OCI spec may contain duplicate environment variables
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -440,6 +440,10 @@ func createProcessArgs(id string, spec *specs.Spec, creds *auth.Credentials, k *\nif err != nil {\nreturn kernel.CreateProcessArgs{}, fmt.Errorf(\"creating limits: %v\", e... | Go | Apache License 2.0 | google/gvisor | OCI spec may contain duplicate environment variables
Closes #5226
PiperOrigin-RevId: 351259576 |
259,858 | 11.01.2021 16:44:35 | 28,800 | aac477733f68eb32fc65383f2974752e11b617f0 | Add additional required packages. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -7,7 +7,8 @@ function install_pkgs() {\nfi\ndone\n}\n-install_pkgs graphviz jq curl binutils gnupg gnupg-agent linux-libc-dev \\\n+install_pkgs make \"linux-headers-$(uname ... | Go | Apache License 2.0 | google/gvisor | Add additional required packages.
PiperOrigin-RevId: 351263241 |
259,858 | 11.01.2021 16:57:53 | 28,800 | e06c2b1264f5800730b93eff5c9913fd870025b9 | Make segment range type split safe.
This allows for use in restricted contexts.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/segment/range.go",
"new_path": "pkg/segment/range.go",
"diff": "@@ -30,27 +30,37 @@ type Range struct {\n// WellFormed returns true if r.Start <= r.End. All other methods on a Range\n// require that the Range is well-formed.\n+//\n+//go:nosplit\nfunc (r Ra... | Go | Apache License 2.0 | google/gvisor | Make segment range type split safe.
This allows for use in restricted contexts.
Updates #5039
PiperOrigin-RevId: 351265378 |
259,907 | 12.01.2021 15:57:48 | 28,800 | ad0ac73626c3d65712791eba652c05869ed287f8 | [rack] Set up TLP timer and configure timeout.
This change implements TLP details enumerated in
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1357,6 +1357,7 @@ func (e *endpoint) protocolMainLoop(handshake bool, wakerInitDone chan<- struct{\n// e.mu is expected to be hold upon entering this section.\n... | Go | Apache License 2.0 | google/gvisor | [rack] Set up TLP timer and configure timeout.
This change implements TLP details enumerated in
https://tools.ietf.org/html/draft-ietf-tcpm-rack-08#section-7.5.1.
Fixes #5083
PiperOrigin-RevId: 351467357 |
259,858 | 12.01.2021 16:59:23 | 28,800 | be2b9d75d75e0e7371cd868589d57f4ddee44781 | Drop shutdown in docker run.
This can race and cause issues. Instead, a manual shutdown can be done
via 'bazel-shutdown' if required for specific cases. The ARM64 builds
are now done using cross-compilation, so this hack is not necessary. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -161,11 +161,7 @@ bazel-image: load-default ## Ensures that the local builder exists.\n.PHONY: bazel-image\n# Note: when starting the bazel server, we tie the life of the container to the\n-# bazel ser... | Go | Apache License 2.0 | google/gvisor | Drop shutdown in docker run.
This can race and cause issues. Instead, a manual shutdown can be done
via 'bazel-shutdown' if required for specific cases. The ARM64 builds
are now done using cross-compilation, so this hack is not necessary.
PiperOrigin-RevId: 351477908 |
260,004 | 12.01.2021 19:34:43 | 28,800 | 62b4c2f5173dfa75387c079bd3dd6d5e5c3abae9 | Drop TransportEndpointID from HandleControlPacket
When a control packet is delivered, it is delivered to a transport
endpoint with a matching stack.TransportEndpointID so there is no
need to pass the ID to the endpoint as it already knows its ID. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/registration.go",
"new_path": "pkg/tcpip/stack/registration.go",
"diff": "@@ -84,7 +84,7 @@ type TransportEndpoint interface {\n// HandleControlPacket is called by the stack when new control (e.g.\n// ICMP) packets arrive to this transport endp... | Go | Apache License 2.0 | google/gvisor | Drop TransportEndpointID from HandleControlPacket
When a control packet is delivered, it is delivered to a transport
endpoint with a matching stack.TransportEndpointID so there is no
need to pass the ID to the endpoint as it already knows its ID.
PiperOrigin-RevId: 351497588 |
259,858 | 12.01.2021 22:23:13 | 28,800 | fb95e13df5749082e4be0a2b5c470dd09f1f8554 | Don't remove release directory.
If the release directory is a parent directory (for reasons), then this causes
a few problems (to say the least). | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -433,7 +433,7 @@ $(RELEASE_ARTIFACTS)/%:\n@$(call copy,//debian:debian,$@)\nrelease: $(RELEASE_KEY) $(RELEASE_ARTIFACTS)/$(ARCH)\n- @rm -rf $(RELEASE_ROOT) && mkdir -p $(RELEASE_ROOT)\n+ @mkdir -p $(RELEASE_ROOT)\... | Go | Apache License 2.0 | google/gvisor | Don't remove release directory.
If the release directory is a parent directory (for reasons), then this causes
a few problems (to say the least).
PiperOrigin-RevId: 351515882 |
259,907 | 13.01.2021 04:23:30 | 28,800 | 19ab0f15f3d2069611257d619acf551071a2aedc | [rack] TLP: Recovery detection.
This change implements TLP details enumerated in
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/rack.go",
"new_path": "pkg/tcpip/transport/tcp/rack.go",
"diff": "@@ -67,6 +67,14 @@ type rackControl struct {\n// probeTimer and probeWaker are used to schedule PTO for RACK TLP algorithm.\nprobeTimer timer `state:\"nosave\"`\nprobeWak... | Go | Apache License 2.0 | google/gvisor | [rack] TLP: Recovery detection.
This change implements TLP details enumerated in
https://tools.ietf.org/html/draft-ietf-tcpm-rack-08#section-7.6
Fixes #5131
PiperOrigin-RevId: 351558449 |
259,951 | 13.01.2021 10:19:35 | 28,800 | 0f25aa24f9f0502bfb1fbead37bbbc2a012dfd64 | Clean up the dummy network interface used by UDP tests
It is now composed by a NetworkInterface interface which lets us delete
the methods we don't need. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/udp_test.go",
"new_path": "pkg/tcpip/transport/udp/udp_test.go",
"diff": "@@ -1560,33 +1560,17 @@ func TestNoChecksum(t *testing.T) {\nvar _ stack.NetworkInterface = (*testInterface)(nil)\ntype testInterface struct {\n- stack.NetworkLin... | Go | Apache License 2.0 | google/gvisor | Clean up the dummy network interface used by UDP tests
It is now composed by a NetworkInterface interface which lets us delete
the methods we don't need.
PiperOrigin-RevId: 351613267 |
259,858 | 13.01.2021 11:46:25 | 28,800 | a684bfb6c035ac6f283649b007176f8bac713acd | Split container tests from unit tests. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -49,6 +49,9 @@ steps:\n- <<: *common\nlabel: \":test_tube: Unit tests\"\ncommand: make unit-tests\n+ - <<: *common\n+ label: \":test_tube: runsc tests\"\n+ command: make runsc-tests... | Go | Apache License 2.0 | google/gvisor | Split container tests from unit tests.
PiperOrigin-RevId: 351632484 |
260,020 | 10.01.2021 22:52:15 | 28,800 | 37855aff121a7cf9deae0405910a62518e806a9e | Add support for pause/restore in containerd shim | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/runsc/runsc.go",
"new_path": "pkg/shim/runsc/runsc.go",
"diff": "@@ -167,6 +167,20 @@ func (r *Runsc) Create(context context.Context, id, bundle string, opts *CreateO\nreturn err\n}\n+func (r *Runsc) Pause(context context.Context, id string) error {\n... | Go | Apache License 2.0 | google/gvisor | Add support for pause/restore in containerd shim |
259,868 | 13.01.2021 15:07:24 | 28,800 | f34aaf7ef17aa10c7ba1923d0694347e47634192 | testutil: Create a `multiLogger` that logs to multiple `Loggers`.
This is useful when using the shell library in order to log to both the test
log and the standard logs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/testutil/testutil.go",
"new_path": "pkg/test/testutil/testutil.go",
"diff": "@@ -111,6 +111,30 @@ func (d DefaultLogger) Logf(fmt string, args ...interface{}) {\nlog.Printf(fmt, args...)\n}\n+// multiLogger logs to multiple Loggers.\n+type multiLogger... | Go | Apache License 2.0 | google/gvisor | testutil: Create a `multiLogger` that logs to multiple `Loggers`.
This is useful when using the shell library in order to log to both the test
log and the standard logs.
PiperOrigin-RevId: 351673465 |
259,860 | 13.01.2021 15:10:03 | 28,800 | 1efe0ebc5973ec8a06b881c087dae2183898504b | Switch uses of os.Getenv that check for empty string to os.LookupEnv.
Whether the variable was found is already returned by syscall.Getenv.
os.Getenv drops this value while os.Lookupenv passes it along. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/sharedmem_test.go",
"new_path": "pkg/tcpip/link/sharedmem/sharedmem_test.go",
"diff": "@@ -191,8 +191,8 @@ func shuffle(b []int) {\n}\nfunc createFile(t *testing.T, size int64, initQueue bool) int {\n- tmpDir := os.Getenv(\"TEST_TMPDIR... | Go | Apache License 2.0 | google/gvisor | Switch uses of os.Getenv that check for empty string to os.LookupEnv.
Whether the variable was found is already returned by syscall.Getenv.
os.Getenv drops this value while os.Lookupenv passes it along.
PiperOrigin-RevId: 351674032 |
259,992 | 14.01.2021 13:41:25 | 28,800 | dbe4176565b56d9e2f5395e410468a4c98aafd37 | Check for existence before permissions
Return EEXIST when overwritting a file as long as the caller has exec
permission on the parent directory, even if the caller doesn't have
write permission.
Also reordered the mount write check, which happens before permission
is checked.
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -407,33 +407,44 @@ func (fs *filesystem) doCreateAt(ctx context.Context, rp *vfs.ResolvingPath, dir\nif err != nil {\nreturn err\n}\n- if err := parent.che... | Go | Apache License 2.0 | google/gvisor | Check for existence before permissions
Return EEXIST when overwritting a file as long as the caller has exec
permission on the parent directory, even if the caller doesn't have
write permission.
Also reordered the mount write check, which happens before permission
is checked.
Closes #5164
PiperOrigin-RevId: 351868123 |
259,951 | 14.01.2021 15:14:11 | 28,800 | 833516c139b5fde1b23abab1868798c8309eaa6b | Add stats for ARP
Fixes
Startblock:
has LGTM from sbalana
and then
add reviewer ghanan | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -186,6 +186,21 @@ var Metrics = tcpip.Stats{\nIPTablesInputDropped: mustCreateMetric(\"/netstack/ip/iptables/input_dropped\", \"Total number of IP packet... | Go | Apache License 2.0 | google/gvisor | Add stats for ARP
Fixes #4963
Startblock:
has LGTM from sbalana
and then
add reviewer ghanan
PiperOrigin-RevId: 351886320 |
259,975 | 14.01.2021 17:02:01 | 28,800 | 95371cff350ef5c22c0e0b76ef9474c16e29a6f6 | Don't run profiles on runc. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -323,6 +323,7 @@ containerd-tests: containerd-test-1.4.3\n## BENCHMARKS_PLATFORMS - platforms to run benchmarks (e.g. ptrace kvm).\n## BENCHMARKS_FILTER - filter to be applied to the test suite.\n## BENCHMARKS_OPT... | Go | Apache License 2.0 | google/gvisor | Don't run profiles on runc.
PiperOrigin-RevId: 351906812 |
260,023 | 15.01.2021 12:01:14 | 28,800 | f7f66c8c6cb5284afe11f4571568866e3c605466 | Add tests for cases of ARP failures on TCP connect
Also fix test expectation for UDP sendto() case in tuntap syscall test.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tuntap.cc",
"new_path": "test/syscalls/linux/tuntap.cc",
"diff": "#include <linux/if_tun.h>\n#include <netinet/ip.h>\n#include <netinet/ip_icmp.h>\n+#include <poll.h>\n#include <sys/ioctl.h>\n#include <sys/socket.h>\n#include <sys/types.h>\... | Go | Apache License 2.0 | google/gvisor | Add tests for cases of ARP failures on TCP connect
Also fix test expectation for UDP sendto() case in tuntap syscall test.
Fixes #5155
PiperOrigin-RevId: 352056612 |
260,003 | 15.01.2021 12:48:58 | 28,800 | f1420cf48418c01694eaf3110ac411915b217d36 | Add sanity check on return values from Write
io.Writer.Write requires err to be non-nil if n < len(v).
We could allow this but it will be irreversible if users depend on this
behavior.
Ported the test that discovered this. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/buffer/view.go",
"new_path": "pkg/tcpip/buffer/view.go",
"diff": "@@ -17,6 +17,7 @@ package buffer\nimport (\n\"bytes\"\n+ \"fmt\"\n\"io\"\n)\n@@ -167,6 +168,9 @@ func (vv *VectorisedView) ReadTo(dst io.Writer, count int, peek bool) (int, erro\nif er... | Go | Apache License 2.0 | google/gvisor | Add sanity check on return values from Write
io.Writer.Write requires err to be non-nil if n < len(v).
We could allow this but it will be irreversible if users depend on this
behavior.
Ported the test that discovered this.
PiperOrigin-RevId: 352065946 |
259,992 | 15.01.2021 13:01:21 | 28,800 | f03144d886791afcdd37962388e9a6294a08c49f | Support TEST_PREMATURE_EXIT_FILE in syscall tests | [
{
"change_type": "MODIFY",
"old_path": "test/runner/runner.go",
"new_path": "test/runner/runner.go",
"diff": "@@ -49,7 +49,6 @@ var (\noverlay = flag.Bool(\"overlay\", false, \"wrap filesystem mounts with writable tmpfs overlay\")\nvfs2 = flag.Bool(\"vfs2\", false, \"enable VFS2\")\nfuse = flag.Bool... | Go | Apache License 2.0 | google/gvisor | Support TEST_PREMATURE_EXIT_FILE in syscall tests
PiperOrigin-RevId: 352068182 |
259,860 | 15.01.2021 14:38:44 | 28,800 | 9db126eb65ada4b2233ccb85a0e9c402b7efc5de | Combine reference count logs into one message.
Otherwise, races can occur between concurrent logs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/refsvfs2/refs_map.go",
"new_path": "pkg/refsvfs2/refs_map.go",
"diff": "@@ -109,8 +109,7 @@ func LogDecRef(obj CheckedObject, refs int64) {\n// obj.LogRefs() should be checked before calling logEvent, in order to avoid\n// calling any text processing neede... | Go | Apache License 2.0 | google/gvisor | Combine reference count logs into one message.
Otherwise, races can occur between concurrent logs.
PiperOrigin-RevId: 352086914 |
259,992 | 15.01.2021 14:49:27 | 28,800 | c7fc4a5d66dc5d6680219819f872c070a0590ca9 | Add fsstress tests
Updates | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -295,6 +295,11 @@ packetimpact-tests: load-packetimpact $(RUNTIME_BIN)\n@$(call test_runtime,$(RUNTIME),--jobs=HOST_CPUS*3 --local_test_jobs=HOST_CPUS*3 //test/packetimpact/tests:all_tests)\n.PHONY: packetimpact-t... | Go | Apache License 2.0 | google/gvisor | Add fsstress tests
Updates #5273
PiperOrigin-RevId: 352088736 |
260,004 | 15.01.2021 15:01:18 | 28,800 | 55c7fe48d223ee5678dff7f5bf9a9e5f0482ab37 | Populate EgressRoute, GSO, Netproto for batch writes
We loop over the list of packets anyways so setting these aren't
expensive.
Now that they are populated only by the link endpoint that uses them,
TCP does not need to. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/packetsocket/endpoint.go",
"new_path": "pkg/tcpip/link/packetsocket/endpoint.go",
"diff": "@@ -43,7 +43,7 @@ func (e *endpoint) WritePacket(r *stack.Route, gso *stack.GSO, protocol tcpip.Ne\n// WritePackets implements stack.LinkEndpoint.WritePac... | Go | Apache License 2.0 | google/gvisor | Populate EgressRoute, GSO, Netproto for batch writes
We loop over the list of packets anyways so setting these aren't
expensive.
Now that they are populated only by the link endpoint that uses them,
TCP does not need to.
PiperOrigin-RevId: 352090853 |
260,003 | 15.01.2021 15:03:30 | 28,800 | ec9e263f213c59e93f9c8b8123012b3db2dddc9a | Correctly return EMSGSIZE when packet is too big in raw socket.
IPv4 previously accepts the packet, while IPv6 panics. Neither is the behavior
in Linux.
splice() in Linux has different behavior than in gVisor. This change documents
it in the SpliceTooLong test.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/igmp.go",
"new_path": "pkg/tcpip/network/ipv4/igmp.go",
"diff": "@@ -262,13 +262,15 @@ func (igmp *igmpState) writePacket(destAddress tcpip.Address, groupAddress tcpip\nlocalAddr := addressEndpoint.AddressWithPrefix().Address\naddressEnd... | Go | Apache License 2.0 | google/gvisor | Correctly return EMSGSIZE when packet is too big in raw socket.
IPv4 previously accepts the packet, while IPv6 panics. Neither is the behavior
in Linux.
splice() in Linux has different behavior than in gVisor. This change documents
it in the SpliceTooLong test.
Reported-by: syzbot+b550e78e5c24d1d521f2@syzkaller.appspotmail.com
PiperOrigin-RevId: 352091286 |
259,907 | 15.01.2021 15:17:23 | 28,800 | f37ace6661dfed8acae7e22ed0eb9ad78bdeab34 | [rack] Retransmit the probe segment after the probe timer expires.
This change implements TLP details enumerated in
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/rack.go",
"new_path": "pkg/tcpip/transport/tcp/rack.go",
"diff": "@@ -197,18 +197,42 @@ func (s *sender) probeTimerExpired() *tcpip.Error {\nif !s.rc.probeTimer.checkExpiration() {\nreturn nil\n}\n- // TODO(gvisor.dev/issue/5084): Imple... | Go | Apache License 2.0 | google/gvisor | [rack] Retransmit the probe segment after the probe timer expires.
This change implements TLP details enumerated in
https://tools.ietf.org/html/draft-ietf-tcpm-rack-08#section-7.5.2.
Fixes #5084
PiperOrigin-RevId: 352093473 |
260,004 | 15.01.2021 18:12:50 | 28,800 | 2814a032be7b34e4cc0c0607dba8030e74e11208 | Support GetLinkAddress with neighborCache
Test: integration_test.TestGetLinkAddress | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/pipe/pipe.go",
"new_path": "pkg/tcpip/link/pipe/pipe.go",
"diff": "@@ -55,7 +55,22 @@ func (e *Endpoint) WritePacket(r stack.RouteInfo, _ *stack.GSO, proto tcpip.Netw\n// remote address from the perspective of the other end of the pipe\n// (e.li... | Go | Apache License 2.0 | google/gvisor | Support GetLinkAddress with neighborCache
Test: integration_test.TestGetLinkAddress
PiperOrigin-RevId: 352119404 |
260,004 | 19.01.2021 12:06:08 | 28,800 | a2ec1932c9b76d80d3af93aa74acf945829cd582 | Drop CheckLocalAddress from LinkAddressCache | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/arp.go",
"new_path": "pkg/tcpip/network/arp/arp.go",
"diff": "@@ -138,16 +138,6 @@ func (e *endpoint) HandlePacket(pkt *stack.PacketBuffer) {\nstats.RequestsReceived.Increment()\nlocalAddr := tcpip.Address(h.ProtocolAddressTarget())\n- if... | Go | Apache License 2.0 | google/gvisor | Drop CheckLocalAddress from LinkAddressCache
PiperOrigin-RevId: 352623277 |
259,891 | 19.01.2021 12:10:01 | 28,800 | 833ba3590b422d453012e5b2ec2e780211d9caf9 | Ensure that IP{V6}_RECVORIGDSTADDR yields the post-NAT address and port. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/BUILD",
"new_path": "test/iptables/BUILD",
"diff": "@@ -15,7 +15,9 @@ go_library(\n],\nvisibility = [\"//test/iptables:__subpackages__\"],\ndeps = [\n+ \"//pkg/binary\",\n\"//pkg/test/testutil\",\n+ \"//pkg/usermem\",\n],\n)\n"
},
{
"chan... | Go | Apache License 2.0 | google/gvisor | Ensure that IP{V6}_RECVORIGDSTADDR yields the post-NAT address and port.
PiperOrigin-RevId: 352624174 |
260,004 | 19.01.2021 16:54:48 | 28,800 | 7ff5ceaeae66303ed6a2199963c00cb08b2fe7ca | Do not have a stack-wide linkAddressCache
Link addresses are cached on a per NIC basis so instead of having a
single cache that includes the NIC ID for neighbor entry lookups,
use a single cache per NIC. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/arp.go",
"new_path": "pkg/tcpip/network/arp/arp.go",
"diff": "@@ -147,7 +147,7 @@ func (e *endpoint) HandlePacket(pkt *stack.PacketBuffer) {\nremoteLinkAddr := tcpip.LinkAddress(h.HardwareAddressSender())\nif e.nud == nil {\n- e.linkAddrC... | Go | Apache License 2.0 | google/gvisor | Do not have a stack-wide linkAddressCache
Link addresses are cached on a per NIC basis so instead of having a
single cache that includes the NIC ID for neighbor entry lookups,
use a single cache per NIC.
PiperOrigin-RevId: 352684111 |
259,885 | 20.01.2021 15:54:51 | 28,800 | 9af6150b5e36bcc731db6f4693fe8e9c5848a5e3 | Remove string allocation from strings.Repeat() in /proc/[pid]/maps. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/procfs.go",
"new_path": "pkg/sentry/mm/procfs.go",
"diff": "@@ -17,7 +17,6 @@ package mm\nimport (\n\"bytes\"\n\"fmt\"\n- \"strings\"\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/sentry/fs/proc/seqfile\"\n@@ -165,12 +164,12 @@ func... | Go | Apache License 2.0 | google/gvisor | Remove string allocation from strings.Repeat() in /proc/[pid]/maps.
PiperOrigin-RevId: 352894106 |
259,885 | 20.01.2021 16:46:18 | 28,800 | ca9a45f282a08a88df19c93d5968d720b5153c41 | Fix refcount increments in gofer.filesystem.Sync.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -36,17 +36,27 @@ import (\n// Sync implements vfs.FilesystemImpl.Sync.\nfunc (fs *filesystem) Sync(ctx context.Context) error {\n// Snapshot current syncab... | Go | Apache License 2.0 | google/gvisor | Fix refcount increments in gofer.filesystem.Sync.
Fixes #5263
PiperOrigin-RevId: 352903844 |
259,860 | 20.01.2021 16:56:58 | 28,800 | a733a8142e42b5405cb9b0da41b051dfd2f03716 | Fix typo boundry -> boundary. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_unix_cmsg.cc",
"new_path": "test/syscalls/linux/socket_unix_cmsg.cc",
"diff": "@@ -362,7 +362,7 @@ TEST_P(UnixSocketPairCmsgTest, BasicThreeFDPassTruncationMsgCtrunc) {\n// BasicFDPassUnalignedRecv starts off by sending a single FD j... | Go | Apache License 2.0 | google/gvisor | Fix typo boundry -> boundary.
PiperOrigin-RevId: 352905565 |
259,885 | 20.01.2021 17:14:04 | 28,800 | a50bc8446c7f2167bf65588020924bd9c644d174 | Don't use task goroutine context in fsimpl tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/tasks_test.go",
"new_path": "pkg/sentry/fsimpl/proc/tasks_test.go",
"diff": "@@ -393,7 +393,7 @@ func TestProcSelf(t *testing.T) {\nt.Fatalf(\"CreateTask(): %v\", err)\n}\n- collector := s.WithTemporaryContext(task).ListDirents(&vfs.Path... | Go | Apache License 2.0 | google/gvisor | Don't use task goroutine context in fsimpl tests.
PiperOrigin-RevId: 352908368 |
259,896 | 20.01.2021 18:14:40 | 28,800 | b0136253e6de393b2892e0fee8d85d636e82616c | Remove unimplemented message for SO_LINGER
Removes the unimplemented message for SO_LINGER
Fix the length for IP_PKTINFO option | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -377,10 +377,8 @@ func (s *socketOpsCommon) SetSockOpt(t *kernel.Task, level int, name int, opt []\nswitch level {\ncase linux.SOL_IP:\nswitch name {\n- case... | Go | Apache License 2.0 | google/gvisor | Remove unimplemented message for SO_LINGER
- Removes the unimplemented message for SO_LINGER
- Fix the length for IP_PKTINFO option
PiperOrigin-RevId: 352917611 |
259,884 | 20.01.2021 21:51:29 | 28,800 | 33b803e47f78206787bf0e53662534c5e428eb09 | Add syscall docs back to menu
Syscall docs were excluded from the navigation menu. This change adds them
back. | [
{
"change_type": "MODIFY",
"old_path": "website/cmd/syscalldocs/main.go",
"new_path": "website/cmd/syscalldocs/main.go",
"diff": "@@ -52,6 +52,7 @@ layout: docs\ncategory: Compatibility\nweight: 50\npermalink: /docs/user_guide/compatibility/{{.OS}}/{{.Arch}}/\n+include_in_menu: True\n---\nThis table... | Go | Apache License 2.0 | google/gvisor | Add syscall docs back to menu
Syscall docs were excluded from the navigation menu. This change adds them
back.
PiperOrigin-RevId: 352942238 |
259,860 | 20.01.2021 23:37:41 | 28,800 | 2c58af226476a47fa129cb4717738e36d44a4491 | Update splice syscall documentation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64.go",
"diff": "@@ -504,7 +504,7 @@ var ARM64 = &kernel.SyscallTable{\n73: syscalls.Supported(\"ppoll\", Ppoll),\n74: syscalls.PartiallySupported(\"signalfd4\", Signalfd4, \"Se... | Go | Apache License 2.0 | google/gvisor | Update splice syscall documentation.
PiperOrigin-RevId: 352954044 |
259,898 | 21.01.2021 00:42:26 | 28,800 | 60b07541dbfa3db29e9e21f554762cc192e14ab3 | Syscall test for connecting to unspecified address
For an active OPEN call with unspecified foreign socket, TCP MUST
return error: foreign socket unspecified | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tcp_socket.cc",
"new_path": "test/syscalls/linux/tcp_socket.cc",
"diff": "@@ -2008,6 +2008,29 @@ TEST_P(SimpleTcpSocketTest, GetSocketAcceptConnWithShutdown) {\nEXPECT_EQ(got, 0);\n}\n+// Tests that connecting to an unspecified address resu... | Go | Apache License 2.0 | google/gvisor | Syscall test for connecting to unspecified address
For an active OPEN call with unspecified foreign socket, TCP MUST
return error: foreign socket unspecified
PiperOrigin-RevId: 352961691 |
259,992 | 21.01.2021 13:19:02 | 28,800 | 1005a8849173c84f12f4a86b32fb170ab9149082 | Fix fsstress argument name
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/fsstress/fsstress_test.go",
"new_path": "test/fsstress/fsstress_test.go",
"diff": "@@ -41,7 +41,7 @@ func fsstress(t *testing.T, dir string) {\nimage = \"basic/fsstress\"\n)\nseed := strconv.FormatUint(uint64(rand.Uint32()), 10)\n- args := []string{\"-d\"... | Go | Apache License 2.0 | google/gvisor | Fix fsstress argument name
Updates #5273
PiperOrigin-RevId: 353087710 |
260,004 | 21.01.2021 14:08:20 | 28,800 | 0ca4cf769840afa7c44477d75d9f780540c01fcd | Populate EgressRoute, GSO, Netproto in NIC
fdbased and qdisc layers expect these fields to already be
populated before being reached. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/qdisc/fifo/endpoint.go",
"new_path": "pkg/tcpip/link/qdisc/fifo/endpoint.go",
"diff": "@@ -165,12 +165,15 @@ func (e *endpoint) WritePacket(r stack.RouteInfo, gso *stack.GSO, protocol tcpip\n}\n// WritePackets implements stack.LinkEndpoint.Write... | Go | Apache License 2.0 | google/gvisor | Populate EgressRoute, GSO, Netproto in NIC
fdbased and qdisc layers expect these fields to already be
populated before being reached.
PiperOrigin-RevId: 353099492 |
260,004 | 21.01.2021 14:51:24 | 28,800 | 89df5a681c004a3772facc08de73d930636227be | Queue packets in WritePackets when resolving link address
Test: integration_test.TestWritePacketsLinkResolution
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/pipe/pipe.go",
"new_path": "pkg/tcpip/link/pipe/pipe.go",
"diff": "@@ -45,12 +45,7 @@ type Endpoint struct {\nlinkAddr tcpip.LinkAddress\n}\n-// WritePacket implements stack.LinkEndpoint.\n-func (e *Endpoint) WritePacket(r stack.RouteInfo, _ *st... | Go | Apache License 2.0 | google/gvisor | Queue packets in WritePackets when resolving link address
Test: integration_test.TestWritePacketsLinkResolution
Fixes #4458.
PiperOrigin-RevId: 353108826 |
259,858 | 21.01.2021 15:39:24 | 28,800 | 48dfb8db9e784604e9c7ad8e1a36cc862dac1b4d | Add image presubmit tests and mark fsstress x86_64 only. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -45,6 +45,14 @@ steps:\n- make BAZEL_OPTIONS=--config=cross-aarch64 artifacts/aarch64\n- make release\n+ # Images tests.\n+ - <<: *common\n+ label: \":docker: Images (x86_64)\"\n+ c... | Go | Apache License 2.0 | google/gvisor | Add image presubmit tests and mark fsstress x86_64 only.
PiperOrigin-RevId: 353118942 |
260,004 | 21.01.2021 19:53:31 | 28,800 | 9f46328e1174be6b8b5442467050ad0b2f0b260f | Only use callback for GetLinkAddress
GetLinkAddress's callback will be called immediately with a
stack.LinkResolutionResult which will hold the link address
so no need to also return the link address from the function.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ndp_test.go",
"new_path": "pkg/tcpip/network/ipv6/ndp_test.go",
"diff": "@@ -162,6 +162,11 @@ func TestStackNDPEndpointInvalidateDefaultRouter(t *testing.T) {\n}\n}\n+type linkResolutionResult struct {\n+ linkAddr tcpip.LinkAddress\n+ ok... | Go | Apache License 2.0 | google/gvisor | Only use callback for GetLinkAddress
GetLinkAddress's callback will be called immediately with a
stack.LinkResolutionResult which will hold the link address
so no need to also return the link address from the function.
Fixes #5151.
PiperOrigin-RevId: 353157857 |
259,884 | 21.01.2021 20:09:32 | 28,800 | d02c03a268f98b471bcaf3afd99e61ddb161bfb4 | Syscall docs update
Moves the id to the <tr> tag so that the page aligns properly when using an
anchor.
Makes the syscall number a link to the anchor.
Fixes some broken links to syscalls without man pages. | [
{
"change_type": "MODIFY",
"old_path": "website/cmd/syscalldocs/main.go",
"new_path": "website/cmd/syscalldocs/main.go",
"diff": "@@ -76,9 +76,9 @@ syscalls. {{if .Undocumented}}{{.Undocumented}} syscalls are not yet documented.\n</thead>\n<tbody>\n{{range $i, $syscall := .Syscalls}}\n- <tr>\n- <td>... | Go | Apache License 2.0 | google/gvisor | Syscall docs update
- Moves the id to the <tr> tag so that the page aligns properly when using an
anchor.
- Makes the syscall number a link to the anchor.
- Fixes some broken links to syscalls without man pages.
PiperOrigin-RevId: 353159903 |
260,004 | 21.01.2021 23:19:38 | 28,800 | e0f4e46e340f2f5e666332ac3ff14f113239400a | Resolve static link addresses in GetLinkAddress
If a network address has a static mapping to a link address, calculate
it in GetLinkAddress.
Test: stack_test.TestStaticGetLinkAddress | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1533,7 +1533,7 @@ type LinkResolutionResult struct {\nSuccess bool\n}\n-// GetLinkAddress finds the link address corresponding to a neighbor's address.\n+// GetLinkAddress finds th... | Go | Apache License 2.0 | google/gvisor | Resolve static link addresses in GetLinkAddress
If a network address has a static mapping to a link address, calculate
it in GetLinkAddress.
Test: stack_test.TestStaticGetLinkAddress
PiperOrigin-RevId: 353179616 |
259,907 | 22.01.2021 09:39:52 | 28,800 | 010cadd3b8b9bc524b1c61c4338e32262d49632b | [infra] Fix Build Github action failure.
The GH Build action has been failing with the error message:
```
BUILD -c opt //runsc
tee: /proc/self/fd/2: No such device or address
```
tee /dev/fd/2 seems to be the canonical way of copying stdin to stderr.
So use that instead. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -191,7 +191,7 @@ endif\nbuild_paths = \\\n(set -euo pipefail; \\\n$(call wrapper,$(BAZEL) build $(BASE_OPTIONS) $(BAZEL_OPTIONS) $(1)) 2>&1 \\\n- | tee /proc/self/fd/2 \\\n+ | tee /dev/fd/2 \\\n| sed -... | Go | Apache License 2.0 | google/gvisor | [infra] Fix Build Github action failure.
The GH Build action has been failing with the error message:
```
--- BUILD -c opt //runsc
tee: /proc/self/fd/2: No such device or address
```
tee /dev/fd/2 seems to be the canonical way of copying stdin to stderr.
So use that instead.
PiperOrigin-RevId: 353259087 |
259,992 | 22.01.2021 09:55:31 | 28,800 | f14f3ba3eff3a445a043a7b2f877ebf4ff862e7d | Fix TestDuplicateEnvVariable flakyness
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -52,7 +52,7 @@ func waitForProcessList(cont *Container, want []*control.Process) error {\ncb := func() error {\ngot, err := cont.Processes()\nif err != nil {\n- er... | Go | Apache License 2.0 | google/gvisor | Fix TestDuplicateEnvVariable flakyness
Updates #5226
PiperOrigin-RevId: 353262133 |
259,992 | 22.01.2021 10:43:19 | 28,800 | 9b4f4655ed5ddcbe34806a28b2bc5d8f61fbb215 | Remove dependency to abi/linux
abi package is to be used by the Sentry to implement the Linux ABI.
Code dealing with the host should use x/sys/unix. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/BUILD",
"new_path": "runsc/fsgofer/BUILD",
"diff": "@@ -12,7 +12,6 @@ go_library(\n],\nvisibility = [\"//runsc:__subpackages__\"],\ndeps = [\n- \"//pkg/abi/linux\",\n\"//pkg/cleanup\",\n\"//pkg/fd\",\n\"//pkg/log\",\n"
},
{
"change_type":... | Go | Apache License 2.0 | google/gvisor | Remove dependency to abi/linux
abi package is to be used by the Sentry to implement the Linux ABI.
Code dealing with the host should use x/sys/unix.
PiperOrigin-RevId: 353272679 |
259,975 | 22.01.2021 10:49:57 | 28,800 | 16b81308cfb7cf2265d69e7180cd024f7c5b89e4 | Add initial mitigate code and cpu parsing. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "runsc/mitigate/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"mitigate\",\n+ srcs = [\n+ \"cpu.go\",\n+ \"mitigate.go\",\n+ ],\n+)\n+\n+go_test(\n+ nam... | Go | Apache License 2.0 | google/gvisor | Add initial mitigate code and cpu parsing.
PiperOrigin-RevId: 353274135 |
259,860 | 22.01.2021 11:25:13 | 28,800 | 65594d30ad1b1a2ca676c7ea78f4815f83dc4d06 | Avoid atomic operations in kcov processing.
Atomic operations here significantly slow down gVisor builds with
kcov/coverage enabled. Also mark these functions go:norace to avoid
complaints from the race detector. | [
{
"change_type": "MODIFY",
"old_path": "pkg/coverage/coverage.go",
"new_path": "pkg/coverage/coverage.go",
"diff": "@@ -26,7 +26,6 @@ import (\n\"fmt\"\n\"io\"\n\"sort\"\n- \"sync/atomic\"\n\"testing\"\n\"gvisor.dev/gvisor/pkg/sync\"\n@@ -69,12 +68,18 @@ var globalData struct {\n}\n// ClearCoverageD... | Go | Apache License 2.0 | google/gvisor | Avoid atomic operations in kcov processing.
Atomic operations here significantly slow down gVisor builds with
kcov/coverage enabled. Also mark these functions go:norace to avoid
complaints from the race detector.
PiperOrigin-RevId: 353281865 |
259,896 | 22.01.2021 11:27:13 | 28,800 | 527ef5fc0307102fa7cc0b32bcc2eb8cca3e21a8 | Add tests for RACK
Added packetimpact tests for RACK. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/defs.bzl",
"new_path": "test/packetimpact/runner/defs.bzl",
"diff": "@@ -277,6 +277,10 @@ ALL_TESTS = [\nPacketimpactTestInfo(\nname = \"tcp_rcv_buf_space\",\n),\n+ PacketimpactTestInfo(\n+ name = \"tcp_rack\",\n+ expect_netstack_failu... | Go | Apache License 2.0 | google/gvisor | Add tests for RACK
- Added packetimpact tests for RACK.
PiperOrigin-RevId: 353282342 |
260,004 | 22.01.2021 14:23:48 | 28,800 | f190e13a74c261176d8619a2fa03fd80a5c74f6d | Pass RouteInfo to the route resolve callback
The route resolution callback will be called with a
stack.ResolvedFieldsResult which will hold the route info so callers
can avoid attempting resolution again to check if a previous resolution
attempt succeeded or not.
Test: integration_test.TestRouteResolvedFields | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/pending_packets.go",
"new_path": "pkg/tcpip/stack/pending_packets.go",
"diff": "@@ -145,7 +145,7 @@ func (f *packetsPendingLinkResolution) enqueue(r *Route, gso *GSO, proto tcpip.N\n//\n// To make sure B does not interleave with A and C, we mak... | Go | Apache License 2.0 | google/gvisor | Pass RouteInfo to the route resolve callback
The route resolution callback will be called with a
stack.ResolvedFieldsResult which will hold the route info so callers
can avoid attempting resolution again to check if a previous resolution
attempt succeeded or not.
Test: integration_test.TestRouteResolvedFields
PiperOrigin-RevId: 353319019 |
260,004 | 22.01.2021 16:03:27 | 28,800 | 76da673a0ddaf33e410d48501a9b089979411d4d | Do not modify IGMP packets when verifying checksum | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/igmp.go",
"new_path": "pkg/tcpip/network/ipv4/igmp.go",
"diff": "@@ -157,14 +157,13 @@ func (igmp *igmpState) handleIGMP(pkt *stack.PacketBuffer) {\n}\nh := header.IGMP(headerView)\n- // Temporarily reset the checksum field to 0 in order... | Go | Apache License 2.0 | google/gvisor | Do not modify IGMP packets when verifying checksum
PiperOrigin-RevId: 353336894 |
259,992 | 22.01.2021 16:24:17 | 28,800 | 99aa5eedcfa3f2e458171cbc6b20ee6f78af3229 | Update containerd minimal version | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/FAQ.md",
"new_path": "g3doc/user_guide/FAQ.md",
"diff": "@@ -137,9 +137,16 @@ sandbox isolation. There are a few different workarounds you can try:\n* Use IPs instead of container names.\n* Use [Kubernetes][k8s]. Container name lookup works fi... | Go | Apache License 2.0 | google/gvisor | Update containerd minimal version
PiperOrigin-RevId: 353340554 |
259,992 | 22.01.2021 18:04:14 | 28,800 | cac70c65e6b5b8a7a3eda55f83f9ceffdfdaba89 | Detect failures in forked function
EXPECT*/ASSERT* functions are not async-signal-safe and should not
be called from the function passed to InForkedProcess. However,
these happen accidentally sometimes but do no cause InForkedProcess
to fail.
Detect and notify in such cases. | [
{
"change_type": "MODIFY",
"old_path": "test/util/BUILD",
"new_path": "test/util/BUILD",
"diff": "@@ -172,6 +172,7 @@ cc_library(\n\":posix_error\",\n\":save_util\",\n\":test_util\",\n+ gtest,\n\"@com_google_absl//absl/strings\",\n],\n)\n"
},
{
"change_type": "MODIFY",
"old_path": "test/... | Go | Apache License 2.0 | google/gvisor | Detect failures in forked function
EXPECT*/ASSERT* functions are not async-signal-safe and should not
be called from the function passed to InForkedProcess. However,
these happen accidentally sometimes but do no cause InForkedProcess
to fail.
Detect and notify in such cases.
PiperOrigin-RevId: 353354540 |
259,877 | 24.01.2021 10:14:25 | -10,800 | a7f11f8161af71b4951ca99cf410ce120cccff97 | FAQ.md: fix kubeadm init instructions
The current version of FAQ.md contains an incorrect example of how to instruct kubelet to prefer containerd over docker. More specifically, it refers to a non-existent `--cni-socket` flag whereas it should have been `--cri-socket`.
The suggested PR fixes that. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/FAQ.md",
"new_path": "g3doc/user_guide/FAQ.md",
"diff": "@@ -107,11 +107,11 @@ kubeadm to create your cluster please check if Docker is also installed on that\nsystem. Kubeadm prefers using Docker if both Docker and containerd are\ninstalled.\... | Go | Apache License 2.0 | google/gvisor | FAQ.md: fix kubeadm init instructions
The current version of FAQ.md contains an incorrect example of how to instruct kubelet to prefer containerd over docker. More specifically, it refers to a non-existent `--cni-socket` flag whereas it should have been `--cri-socket`.
The suggested PR fixes that. |
259,992 | 25.01.2021 10:28:33 | 28,800 | a358de583b54be3eab2f960bdaffe74c619e84d4 | Fix Inotify.Exec test
The test was execve itself into `/bin/true`, so the test was
not actually executing. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -980,6 +980,7 @@ cc_binary(\n\"//test/util:epoll_util\",\n\"//test/util:file_descriptor\",\n\"//test/util:fs_util\",\n+ \"//test/util:multiprocess_util\",\n\"//test/util:posix_err... | Go | Apache License 2.0 | google/gvisor | Fix Inotify.Exec test
The test was execve itself into `/bin/true`, so the test was
not actually executing.
PiperOrigin-RevId: 353676855 |
259,992 | 25.01.2021 11:00:26 | 28,800 | 0592dac851addb9b95c9c56b90587d809a894832 | Remove side effect from shm tests
Individual test cases must not rely on being executed in a clean environment. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/shm.cc",
"new_path": "test/syscalls/linux/shm.cc",
"diff": "@@ -256,32 +256,26 @@ TEST(ShmTest, IpcInfo) {\n}\nTEST(ShmTest, ShmInfo) {\n- struct shm_info info;\n-\n- // We generally can't know what other processes on a linux machine\n- // ... | Go | Apache License 2.0 | google/gvisor | Remove side effect from shm tests
Individual test cases must not rely on being executed in a clean environment.
PiperOrigin-RevId: 353684155 |
259,885 | 25.01.2021 11:56:16 | 28,800 | 032d14a06611304b18db659513f6db1edbc7cf75 | Remove synchronous decommit for MADV_DONTNEED on private anonymous vmas. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/syscalls.go",
"new_path": "pkg/sentry/mm/syscalls.go",
"diff": "@@ -1055,18 +1055,11 @@ func (mm *MemoryManager) Decommit(addr usermem.Addr, length uint64) error {\nmm.activeMu.Lock()\ndefer mm.activeMu.Unlock()\n- // Linux's mm/madvise.c:madvise... | Go | Apache License 2.0 | google/gvisor | Remove synchronous decommit for MADV_DONTNEED on private anonymous vmas.
PiperOrigin-RevId: 353697719 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.