author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,975 | 25.01.2021 12:16:00 | 28,800 | 3d9f88894e50b747bb123ea745f16d026550f83e | Adjust benchtime for failing redis benchmarks. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -200,7 +200,7 @@ steps:\ncommand: make benchmark-platforms BENCHMARKS_SUITE=node BENCHMARKS_TARGETS=test/benchmarks/network:node_test\n- <<: *benchmarks\nlabel: \":redis: Redis benc... | Go | Apache License 2.0 | google/gvisor | Adjust benchtime for failing redis benchmarks.
PiperOrigin-RevId: 353702265 |
260,003 | 25.01.2021 16:26:10 | 28,800 | b4665aef8717d00f2f3320616ae4ef0914f9a1b4 | fdbased: Dedup code related to iovec reading | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/BUILD",
"new_path": "pkg/tcpip/link/fdbased/BUILD",
"diff": "@@ -35,7 +35,6 @@ go_test(\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/header\",\n- \"//pkg/tcpip/link/rawfile\",\n\"//pkg/tcpip/stack\",\n\"@com_github_google_go... | Go | Apache License 2.0 | google/gvisor | fdbased: Dedup code related to iovec reading
PiperOrigin-RevId: 353755271 |
259,951 | 25.01.2021 16:50:14 | 28,800 | 39db3b93554ea74611602ad4c20dfa5c08e748f2 | Add per endpoint ARP statistics
The ARP stat NetworkUnreachable was removed, and was replaced by
InterfaceHasNoLocalAddress. No stats are recorded when dealing with an
missing endpoint (ErrNotConnected) (because if there is no endpoint,
there is no valid per-endpoint stats). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -193,7 +193,6 @@ var Metrics = tcpip.Stats{\nRequestsReceivedUnknownTargetAddress: mustCreateMetric(\"/netstack/arp/requests_received_unknown_addr\", \"N... | Go | Apache License 2.0 | google/gvisor | Add per endpoint ARP statistics
The ARP stat NetworkUnreachable was removed, and was replaced by
InterfaceHasNoLocalAddress. No stats are recorded when dealing with an
missing endpoint (ErrNotConnected) (because if there is no endpoint,
there is no valid per-endpoint stats).
PiperOrigin-RevId: 353759462 |
259,860 | 26.01.2021 00:00:52 | 28,800 | 3946075403a93907138f13e61bdba075aeabfecf | Do not generate extraneous IN_CLOSE inotify events.
IN_CLOSE should only be generated when a file description loses its last
reference; not when a file descriptor is closed.
See fs/file_table.c:__fput.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -159,13 +159,6 @@ func (f *FDTable) dropVFS2(ctx context.Context, file *vfs.FileDescription) {\npanic(fmt.Sprintf(\"UnlockPOSIX failed: %v\", err))\n}\n- // Generate inoti... | Go | Apache License 2.0 | google/gvisor | Do not generate extraneous IN_CLOSE inotify events.
IN_CLOSE should only be generated when a file description loses its last
reference; not when a file descriptor is closed.
See fs/file_table.c:__fput.
Updates #5348.
PiperOrigin-RevId: 353810697 |
259,860 | 26.01.2021 09:47:24 | 28,800 | abdff887483f1d9487bffa0278dd6f7a40e59a74 | Do not send SCM Rights more than once when message is truncated.
If data is sent over a stream socket that will not fit all at once, it will
be sent over multiple packets. SCM Rights should only be sent with the first
packet (see net/unix/af_unix.c:unix_stream_sendmsg in Linux).
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/unix.go",
"new_path": "pkg/sentry/socket/unix/unix.go",
"diff": "@@ -496,6 +496,9 @@ func (s *socketOpsCommon) SendMsg(t *kernel.Task, src usermem.IOSequence, to []b\nreturn int(n), syserr.FromError(err)\n}\n+ // Only send SCM Rights onc... | Go | Apache License 2.0 | google/gvisor | Do not send SCM Rights more than once when message is truncated.
If data is sent over a stream socket that will not fit all at once, it will
be sent over multiple packets. SCM Rights should only be sent with the first
packet (see net/unix/af_unix.c:unix_stream_sendmsg in Linux).
Reported-by: syzbot+aa26482e9c4887aff259@syzkaller.appspotmail.com
PiperOrigin-RevId: 353886442 |
260,004 | 26.01.2021 10:32:46 | 28,800 | 9ba24d449f8c62756b809610ec4cd02222e18bd3 | Drop nicID from transport endpoint reg/cleanup fns
...as it is unused. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1629,25 +1629,25 @@ func (s *Stack) ClearNeighbors(nicID tcpip.NICID) *tcpip.Error {\n// transport dispatcher. Received packets that match the provided id will be\n// delivered to ... | Go | Apache License 2.0 | google/gvisor | Drop nicID from transport endpoint reg/cleanup fns
...as it is unused.
PiperOrigin-RevId: 353896981 |
259,860 | 26.01.2021 12:00:04 | 28,800 | 96bd076e8a002ccacc414e92c83dedf2e35ca07b | Initialize timestamps for gofer synthetic children.
Contrary to the comment on the socket test, the failure was due to an issue
with goferfs rather than kernfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/directory.go",
"new_path": "pkg/sentry/fsimpl/gofer/directory.go",
"diff": "@@ -90,6 +90,7 @@ type createSyntheticOpts struct {\n// * d.isDir().\n// * d does not already contain a child with the given name.\nfunc (d *dentry) createSynth... | Go | Apache License 2.0 | google/gvisor | Initialize timestamps for gofer synthetic children.
Contrary to the comment on the socket test, the failure was due to an issue
with goferfs rather than kernfs.
PiperOrigin-RevId: 353918021 |
259,962 | 26.01.2021 12:07:16 | 28,800 | a90661654d14e77b6442c4a34ced900e2cd9953e | Fix couple of potential route leaks.
connect() can be invoked multiple times on UDP/RAW sockets and in such
a case we should release the cached route from the previous connect.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -413,7 +413,10 @@ func (e *endpoint) Connect(addr tcpip.FullAddress) *tcpip.Error {\ne.RegisterNICID = nic\n}\n- // Save the route we've connected via.\n+ if e... | Go | Apache License 2.0 | google/gvisor | Fix couple of potential route leaks.
connect() can be invoked multiple times on UDP/RAW sockets and in such
a case we should release the cached route from the previous connect.
Fixes #5359
PiperOrigin-RevId: 353919891 |
260,004 | 26.01.2021 15:43:22 | 28,800 | 8bb7d61bdca59b98761b198ec258a6d77441c7ed | Do not use stack.Route to send NDP NS
When sending packets through a stack.Route, we attempt to perform
link resolution. Neighbor Solicitation messages do not need link
resolution to be performed so send the packets out the interface
directly instead. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "@@ -688,25 +688,38 @@ func (*protocol) LinkAddressProtocol() tcpip.NetworkProtocolNumber {\n// LinkAddressRequest implements stack.LinkAddressResolver.\nfunc (p *protocol) ... | Go | Apache License 2.0 | google/gvisor | Do not use stack.Route to send NDP NS
When sending packets through a stack.Route, we attempt to perform
link resolution. Neighbor Solicitation messages do not need link
resolution to be performed so send the packets out the interface
directly instead.
PiperOrigin-RevId: 353967435 |
259,896 | 26.01.2021 18:02:53 | 28,800 | 8e660447410117edd49f41f7aa758e49254ae2d5 | Initialize the send buffer handler in endpoint creation.
This CL will initialize the function handler used for getting the send
buffer size limits during endpoint creation and does not require the caller of
SetSendBufferSize(..) to know the endpoint type(tcp/udp/..) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1615,20 +1615,15 @@ func setSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, nam\nreturn syserr.ErrInvalidArgument\n}\n- family, skT... | Go | Apache License 2.0 | google/gvisor | Initialize the send buffer handler in endpoint creation.
- This CL will initialize the function handler used for getting the send
buffer size limits during endpoint creation and does not require the caller of
SetSendBufferSize(..) to know the endpoint type(tcp/udp/..)
PiperOrigin-RevId: 353992634 |
260,023 | 27.01.2021 12:25:20 | 28,800 | de3c63cd9dd536cf36e29aad381096b7cd061af9 | Deflake tcp_zero_window_probe_retransmit_test
Fix the test to rely on more deterministic retransmission interval
computations by skipping the initial probe transmission time as that
can be non-deterministic given arbitrary time taken for the DUT to
receive a send command and initiate a send.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/tcp_zero_window_probe_retransmit_test.go",
"new_path": "test/packetimpact/tests/tcp_zero_window_probe_retransmit_test.go",
"diff": "@@ -66,33 +66,39 @@ func TestZeroWindowProbeRetransmit(t *testing.T) {\nprobeSeq := testbench.Uint32(uin... | Go | Apache License 2.0 | google/gvisor | Deflake tcp_zero_window_probe_retransmit_test
Fix the test to rely on more deterministic retransmission interval
computations by skipping the initial probe transmission time as that
can be non-deterministic given arbitrary time taken for the DUT to
receive a send command and initiate a send.
Fixes #5080
PiperOrigin-RevId: 354146256 |
259,896 | 27.01.2021 16:11:49 | 28,800 | 99988e45ed651f64e16e2f2663b06b4a1eee50d4 | Add support for more fields in netstack for TCP_INFO
This CL adds support for the following fields:
RTT, RTTVar, RTO
send congestion window (sndCwnd) and send slow start threshold (sndSsthresh)
congestion control state(CaState)
ReorderSeen | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -416,6 +416,18 @@ type TCPInfo struct {\nRwndLimited uint64\n// SndBufLimited is the time in microseconds limited by send buffer.\nSndBufLimited uint64\n+\n+ Delievered uint32\n+ Deli... | Go | Apache License 2.0 | google/gvisor | Add support for more fields in netstack for TCP_INFO
This CL adds support for the following fields:
- RTT, RTTVar, RTO
- send congestion window (sndCwnd) and send slow start threshold (sndSsthresh)
- congestion control state(CaState)
- ReorderSeen
PiperOrigin-RevId: 354195361 |
259,898 | 28.01.2021 12:29:18 | 28,800 | bc4039353d5b744871ee61cf4d76b3fe6f783ba7 | Make tcp_noaccept_close_rst more robust
There used to be a race condition where we may call Close before the connection
is established. Adding poll support so that we can eliminate this kind of race.
Startblock:
has LGTM from iyerm
and then
add reviewer tamird | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/dut/BUILD",
"new_path": "test/packetimpact/dut/BUILD",
"diff": "@@ -14,6 +14,7 @@ cc_binary(\ngrpcpp,\n\"//test/packetimpact/proto:posix_server_cc_grpc_proto\",\n\"//test/packetimpact/proto:posix_server_cc_proto\",\n+ \"@com_google_absl//absl... | Go | Apache License 2.0 | google/gvisor | Make tcp_noaccept_close_rst more robust
There used to be a race condition where we may call Close before the connection
is established. Adding poll support so that we can eliminate this kind of race.
Startblock:
has LGTM from iyerm
and then
add reviewer tamird
PiperOrigin-RevId: 354369130 |
259,907 | 28.01.2021 13:51:38 | 28,800 | 62a37034f0185979d71f15bae38815309bd07f03 | [vfs] Fix rename implementation in OrderedChildren.
Fixes as there is just 1 writable user using OrderedChildren's rename,
unlink and rmdir (kernfs.syntheticDirectory) but it doesn't support the sticky
bit yet.
Fuse which is the other writable user implements its own Inode operations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"new_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"diff": "@@ -371,6 +371,8 @@ type OrderedChildrenOptions struct {\n// OrderedChildren may modify the tracked children. This applies to\n// operations relat... | Go | Apache License 2.0 | google/gvisor | [vfs] Fix rename implementation in OrderedChildren.
Fixes #3027 as there is just 1 writable user using OrderedChildren's rename,
unlink and rmdir (kernfs.syntheticDirectory) but it doesn't support the sticky
bit yet.
Fuse which is the other writable user implements its own Inode operations.
PiperOrigin-RevId: 354386522 |
260,004 | 28.01.2021 17:05:44 | 28,800 | 56fb2ec1194bff7c57c7bbb84b7b74f63142b915 | Do not use clockwork for faketime
Clockwork does not support timers being reset/stopped from different
goroutines. Our current use of clockwork causes data races and
gotsan complains about clockwork.
This change uses our own implementation of faketime, avoiding data
races. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/faketime/BUILD",
"new_path": "pkg/tcpip/faketime/BUILD",
"diff": "@@ -6,10 +6,7 @@ go_library(\nname = \"faketime\",\nsrcs = [\"faketime.go\"],\nvisibility = [\"//visibility:public\"],\n- deps = [\n- \"//pkg/tcpip\",\n- \"@com_github_dpjacques_clockw... | Go | Apache License 2.0 | google/gvisor | Do not use clockwork for faketime
Clockwork does not support timers being reset/stopped from different
goroutines. Our current use of clockwork causes data races and
gotsan complains about clockwork.
This change uses our own implementation of faketime, avoiding data
races.
PiperOrigin-RevId: 354428208 |
259,992 | 28.01.2021 18:22:54 | 28,800 | 9cc2570ea74c678238ed82d044cfecbfe62c5981 | Change EXPECT/ASSERT to TEST_CHECK inside InForkedProcess | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/madvise.cc",
"new_path": "test/syscalls/linux/madvise.cc",
"diff": "@@ -179,9 +179,9 @@ TEST(MadviseDontforkTest, DontforkShared) {\n// First page is mapped in child and modifications are visible to parent\n// via the shared mapping.\nTEST_... | Go | Apache License 2.0 | google/gvisor | Change EXPECT/ASSERT to TEST_CHECK inside InForkedProcess
PiperOrigin-RevId: 354441239 |
260,004 | 28.01.2021 20:30:02 | 28,800 | d6a39734c4934aa98141074c67389e80ed130a94 | Avoid locking when route doesn't require resolution
When a route does not need to resolve a remote link address to send a
packet, avoid having to obtain the pending packets queue's lock. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -309,7 +309,26 @@ func (n *NIC) WritePacket(r *Route, gso *GSO, protocol tcpip.NetworkProtocolNumb\nreturn err\n}\n+func (n *NIC) writePacketBuffer(r RouteInfo, gso *GSO, protocol tcpip... | Go | Apache License 2.0 | google/gvisor | Avoid locking when route doesn't require resolution
When a route does not need to resolve a remote link address to send a
packet, avoid having to obtain the pending packets queue's lock.
PiperOrigin-RevId: 354456280 |
259,986 | 29.01.2021 08:34:45 | 28,800 | 71623e40680c79e82390016a10376e73ff2370db | Discard invalid Neighbor Advertisements
...per RFC 4861 s7.1.2.
Startblock:
has LGTM from sbalana
and then
add reviewer ghanan | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "@@ -445,6 +445,17 @@ func (e *endpoint) handleICMP(pkt *stack.PacketBuffer, hasFragmentHeader bool) {\nreturn\n}\n+ // As per RFC 4861 section 7.1.2:\n+ // A node MUST sile... | Go | Apache License 2.0 | google/gvisor | Discard invalid Neighbor Advertisements
...per RFC 4861 s7.1.2.
Startblock:
has LGTM from sbalana
and then
add reviewer ghanan
PiperOrigin-RevId: 354539026 |
259,992 | 29.01.2021 12:16:55 | 28,800 | 0fa534f1164f2bf6cf50a37d4dce584b6fc8ec07 | Fix deadlock in specialFileFD.pwrite
When file is regular and metadata cache is authoritative, metadata lock
is taken. The code deadlocks trying to acquire the metadata lock
again to update time stampts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"diff": "@@ -299,10 +299,15 @@ func (fd *specialFileFD) pwrite(ctx context.Context, src usermem.IOSequence, off\nsrc = src.TakeFirst64(limit)\n}\n- // Do a buffere... | Go | Apache License 2.0 | google/gvisor | Fix deadlock in specialFileFD.pwrite
When file is regular and metadata cache is authoritative, metadata lock
is taken. The code deadlocks trying to acquire the metadata lock
again to update time stampts.
PiperOrigin-RevId: 354584594 |
259,896 | 29.01.2021 13:13:46 | 28,800 | 0a52b647945e557c446b173309644458cd0a2ec3 | Add more comments for the TCP_INFO struct fields. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -347,26 +347,57 @@ const SizeOfLinger = 8\n//\n// +marshal\ntype TCPInfo struct {\n+ // State is the state of the connection.\nState uint8\n+\n+ // CaState is the congestion control s... | Go | Apache License 2.0 | google/gvisor | - Add more comments for the TCP_INFO struct fields.
PiperOrigin-RevId: 354595623 |
260,004 | 29.01.2021 13:47:58 | 28,800 | 5e2edfb8726ddb255a02352e2f68ea028f543e4b | Refresh delayed report timers on query messages
...as per As per RFC 2236 section 3 page 3 (for IGMPv2) and
RFC 2710 section 4 page 5 (for MLDv1).
See comments in code for more details.
Test: ip_test.TestHandleQuery | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ip/generic_multicast_protocol.go",
"new_path": "pkg/tcpip/network/ip/generic_multicast_protocol.go",
"diff": "@@ -126,6 +126,16 @@ type multicastGroupState struct {\n//\n// Must not be nil.\ndelayedReportJob *tcpip.Job\n+\n+ // delyedReportJo... | Go | Apache License 2.0 | google/gvisor | Refresh delayed report timers on query messages
...as per As per RFC 2236 section 3 page 3 (for IGMPv2) and
RFC 2710 section 4 page 5 (for MLDv1).
See comments in code for more details.
Test: ip_test.TestHandleQuery
PiperOrigin-RevId: 354603068 |
259,992 | 29.01.2021 13:54:34 | 28,800 | fdbfd447a02e52296f48a5cb1020030756ed8da6 | Remove side effect from test cases
Individual test cases must not rely on being executed in a clean environment. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -482,7 +482,9 @@ cc_binary(\n\"//test/util:fs_util\",\n\"@com_google_absl//absl/strings\",\ngtest,\n+ \"//test/util:logging\",\n\"//test/util:mount_util\",\n+ \"//test/util:multip... | Go | Apache License 2.0 | google/gvisor | Remove side effect from test cases
Individual test cases must not rely on being executed in a clean environment.
PiperOrigin-RevId: 354604389 |
259,891 | 29.01.2021 14:46:41 | 28,800 | 66aa6f3d4fb148145ab1b91c49f483d501185ff8 | setgid directory syscall tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -556,6 +556,10 @@ syscall_test(\ntest = \"//test/syscalls/linux:sendfile_test\",\n)\n+syscall_test(\n+ test = \"//test/syscalls/linux:setgid_test\",\n+)\n+\nsyscall_test(\nadd_overlay = True,... | Go | Apache License 2.0 | google/gvisor | setgid directory syscall tests
PiperOrigin-RevId: 354615220 |
260,004 | 29.01.2021 16:09:14 | 28,800 | 45fe9fe9c6fa92954a5017b98835eac5fd8d3987 | Clear IGMPv1 present flag on NIC down
This is dynamic state that can be re-learned when the NIC comes
back up.
Test: ipv4_test.TestIgmpV1Present | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/igmp.go",
"new_path": "pkg/tcpip/network/ipv4/igmp.go",
"diff": "@@ -215,6 +215,11 @@ func (igmp *igmpState) setV1Present(v bool) {\n}\n}\n+func (igmp *igmpState) resetV1Present() {\n+ igmp.igmpV1Job.Cancel()\n+ igmp.setV1Present(false)\... | Go | Apache License 2.0 | google/gvisor | Clear IGMPv1 present flag on NIC down
This is dynamic state that can be re-learned when the NIC comes
back up.
Test: ipv4_test.TestIgmpV1Present
PiperOrigin-RevId: 354630921 |
259,992 | 30.01.2021 13:35:59 | 28,800 | ccf9138e6de27e666129e97b8c2ff9d117f69f60 | Remove side effect from open tests
Individual test cases must not rely on being executed in a clean environment. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1383,6 +1383,7 @@ cc_binary(\n\"//test/util:file_descriptor\",\n\"//test/util:fs_util\",\ngtest,\n+ \"//test/util:posix_error\",\n\"//test/util:temp_path\",\n\"//test/util:temp_u... | Go | Apache License 2.0 | google/gvisor | Remove side effect from open tests
Individual test cases must not rely on being executed in a clean environment.
PiperOrigin-RevId: 354730126 |
260,004 | 31.01.2021 13:46:02 | 28,800 | c5e3c1c7bd5b7d1dc389fd93ac0cd56cdb4d9ac9 | Use closure for IPv6 testContext cleanup | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp_test.go",
"new_path": "pkg/tcpip/network/ipv6/icmp_test.go",
"diff": "@@ -492,8 +492,6 @@ func visitStats(v reflect.Value, f func(string, *tcpip.StatCounter)) {\n}\ntype testContext struct {\n- t *testing.T\n-\ns0 *stack.Stack\ns1 *... | Go | Apache License 2.0 | google/gvisor | Use closure for IPv6 testContext cleanup
PiperOrigin-RevId: 354827491 |
259,907 | 01.02.2021 11:51:36 | 28,800 | cbcebfea80bd59091e142cc6dad4192915194550 | [infra] Fix gazelle target. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -152,7 +152,7 @@ nogo: ## Surfaces all nogo findings.\n.PHONY: nogo\ngazelle: ## Runs gazelle to update WORKSPACE.\n- @$(call run,//:gazelle update-repos -from_file=go.mod -prune)\n+ @$(call run,//:gazelle,update-... | Go | Apache License 2.0 | google/gvisor | [infra] Fix gazelle target.
PiperOrigin-RevId: 354991724 |
259,858 | 18.09.2020 20:26:11 | 0 | 196c9de99e65a7c794814f26d2f397a27443b255 | Add basic VSCode plumbing. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": ".devcontainer.json",
"diff": "+{\n+ \"dockerFile\": \"images/default/Dockerfile\",\n+ \"mounts\": [\"source=/var/run/docker.sock,target=/var/run/docker.sock,type=bind\"],\n+ \"overrideCommand\": true,\n+ \"extensions\": [\n+ \"bazelbuild.vscode-... | Go | Apache License 2.0 | google/gvisor | Add basic VSCode plumbing. |
259,858 | 01.02.2021 12:16:48 | 28,800 | 4fcf8b2282c2841920cd1c2b10c023e4b7c578e6 | Update .devcontainer.json
Provide appropriate capabilities and adjust Docker socket. | [
{
"change_type": "MODIFY",
"old_path": ".devcontainer.json",
"new_path": ".devcontainer.json",
"diff": "{\n\"dockerFile\": \"images/default/Dockerfile\",\n- \"mounts\": [\"source=/var/run/docker.sock,target=/var/run/docker.sock,type=bind\"],\n\"overrideCommand\": true,\n+ \"mounts\": [\"source=/var/... | Go | Apache License 2.0 | google/gvisor | Update .devcontainer.json
Provide appropriate capabilities and adjust Docker socket. |
259,907 | 01.02.2021 12:28:31 | 28,800 | 0da3c72c9d24c322af8203511142462fab3b1bd9 | [infra] Consolidate all ubuntu tests into one image.
This makes it easier to add more tests that run on Ubuntu. We can now just
add a bash script and call that from integration_test without having to set up
another image. | [
{
"change_type": "DELETE",
"old_path": "images/basic/hostoverlaytest/Dockerfile",
"new_path": null,
"diff": "-FROM ubuntu:bionic\n-\n-WORKDIR /root\n-COPY . .\n-\n-RUN apt-get update && apt-get install -y gcc\n-RUN gcc -O2 -o test_copy_up test_copy_up.c\n-RUN gcc -O2 -o test_rewinddir test_rewinddir... | Go | Apache License 2.0 | google/gvisor | [infra] Consolidate all ubuntu tests into one image.
This makes it easier to add more tests that run on Ubuntu. We can now just
add a bash script and call that from integration_test without having to set up
another image.
PiperOrigin-RevId: 355000410 |
259,858 | 01.02.2021 16:59:01 | 28,800 | 5d8054e75a9ce2a4ee3feeb0a6d284967ff3ba46 | Remove Go cache on failure.
It's unclear why permissions wind up corrupted, but these can be cleared
on any failure, similar to the bazel cache itself: | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/post-command",
"new_path": ".buildkite/hooks/post-command",
"diff": "@@ -51,6 +51,9 @@ if test \"${BUILDKITE_COMMAND_EXIT_STATUS}\" -ne \"0\"; then\n# Attempt to clear the cache and shut down.\nmake clean || echo \"make clean failed with code ... | Go | Apache License 2.0 | google/gvisor | Remove Go cache on failure.
It's unclear why permissions wind up corrupted, but these can be cleared
on any failure, similar to the bazel cache itself:
https://buildkite.com/gvisor/pipeline/builds/2304#_
PiperOrigin-RevId: 355057421 |
259,896 | 01.02.2021 17:58:24 | 28,800 | d3855ad6bddb4680b4dc5de40da1820fc8608f88 | Add RACK reorder tests. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/tcp_rack_test.go",
"new_path": "test/packetimpact/tests/tcp_rack_test.go",
"diff": "@@ -70,8 +70,11 @@ func closeSACKConnection(t *testing.T, dut testbench.DUT, conn testbench.TCPIPv4\nfunc getRTTAndRTO(t *testing.T, dut testbench.DUT, ... | Go | Apache License 2.0 | google/gvisor | Add RACK reorder tests.
PiperOrigin-RevId: 355067082 |
259,992 | 01.02.2021 19:26:12 | 28,800 | aae4803808dc7358492db3fa787e8dd8f4a0e97a | Enable container checkpoint/restore tests with VFS2
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/console_test.go",
"new_path": "runsc/container/console_test.go",
"diff": "@@ -122,7 +122,7 @@ func receiveConsolePTY(srv *unet.ServerSocket) (*os.File, error) {\n// Test that an pty FD is sent over the console socket if one is provided.\nfunc T... | Go | Apache License 2.0 | google/gvisor | Enable container checkpoint/restore tests with VFS2
Updates #1663
PiperOrigin-RevId: 355077816 |
259,858 | 01.02.2021 23:01:50 | 28,800 | 0c8cc66117f2f966870f78e9db78f264b1948a86 | Fix empty Packages file for APT repository.
This change also adds an extra sanity check to the make_apt.sh script,
in order to ensure that this simple mistake does not occur again. | [
{
"change_type": "MODIFY",
"old_path": "tools/make_apt.sh",
"new_path": "tools/make_apt.sh",
"diff": "@@ -119,7 +119,11 @@ for dir in \"${root}\"/pool/*/binary-*; do\narches+=(\"${arch}\")\nrepo_packages=\"${release}\"/main/\"${name}\"\nmkdir -p \"${repo_packages}\"\n- (cd \"${root}\" && apt-ftparch... | Go | Apache License 2.0 | google/gvisor | Fix empty Packages file for APT repository.
This change also adds an extra sanity check to the make_apt.sh script,
in order to ensure that this simple mistake does not occur again.
PiperOrigin-RevId: 355101754 |
259,858 | 02.02.2021 09:34:29 | 28,800 | 3817c7349de2dde950fd65dcab1f4859c095eeaf | Remove go_tool_library references.
This is required only for the built-in bazel nogo functionality.
Since we roll these targets manually via the wrappers, we don't need
to use go_tool_library. The inconsistent use of these targets leads
to conflicting instantiations of go_default_library and go_tool_library,
which both contain the same output files. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -8,7 +8,7 @@ load(\"@bazel_tools//tools/build_defs/repo:git.bzl\", \"git_repository\")\nhttp_file(\nname = \"google_root_pem\",\nurls = [\n- \"https://pki.goog/roots.pem\"\n+ \"https://pki.goog/roots.pem\",\n],\... | Go | Apache License 2.0 | google/gvisor | Remove go_tool_library references.
This is required only for the built-in bazel nogo functionality.
Since we roll these targets manually via the wrappers, we don't need
to use go_tool_library. The inconsistent use of these targets leads
to conflicting instantiations of go_default_library and go_tool_library,
which both contain the same output files.
PiperOrigin-RevId: 355184975 |
259,858 | 02.02.2021 11:26:37 | 28,800 | 017348af99b3aa129596a1345851b1b67cd9633e | Drop gazelle target from the Makefile.
This is replaced with a straight call to bazel. Unfortunately,
the built gazelle target requires a bazel installation to run
anyways. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -151,10 +151,6 @@ nogo: ## Surfaces all nogo findings.\n@$(call run,//tools/github $(foreach dir,$(BUILD_ROOTS),-path=$(CURDIR)/$(dir)) -dry-run nogo)\n.PHONY: nogo\n-gazelle: ## Runs gazelle to update WORKSPACE.\... | Go | Apache License 2.0 | google/gvisor | Drop gazelle target from the Makefile.
This is replaced with a straight call to bazel. Unfortunately,
the built gazelle target requires a bazel installation to run
anyways.
PiperOrigin-RevId: 355211990 |
259,992 | 02.02.2021 11:35:07 | 28,800 | d6d169320cd40d0910955debc9b0c91877b53900 | Add ETIMEDOUT to partial result list
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/error.go",
"new_path": "pkg/sentry/syscalls/linux/error.go",
"diff": "@@ -134,8 +134,8 @@ func handleIOErrorImpl(t *kernel.Task, partialResult bool, err, intr error, op s\n// Similar to EPIPE. Return what we wrote this time, and let\n... | Go | Apache License 2.0 | google/gvisor | Add ETIMEDOUT to partial result list
Reported-by: syzbot+db8d83f93b84fcb84374@syzkaller.appspotmail.com
PiperOrigin-RevId: 355213994 |
259,891 | 02.02.2021 12:45:25 | 28,800 | 5f7bf3152652d36903f9659688321ae7c42995d0 | Stub out basic `runsc events --stat` CPU functionality
Because we lack gVisor-internal cgroups, we take the CPU usage of the entire pod
and divide it proportionally according to sentry-internal usage stats.
This fixes `kubectl top pods`, which gets a pod's CPU usage by summing the usage
of its containers.
Addresses | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -404,3 +404,16 @@ func ttyName(tty *kernel.TTY) string {\n}\nreturn fmt.Sprintf(\"pts/%d\", tty.Index)\n}\n+\n+// ContainerUsage retrieves per-container CPU usage.\n+func Contai... | Go | Apache License 2.0 | google/gvisor | Stub out basic `runsc events --stat` CPU functionality
Because we lack gVisor-internal cgroups, we take the CPU usage of the entire pod
and divide it proportionally according to sentry-internal usage stats.
This fixes `kubectl top pods`, which gets a pod's CPU usage by summing the usage
of its containers.
Addresses #172.
PiperOrigin-RevId: 355229833 |
259,896 | 02.02.2021 13:19:51 | 28,800 | 49f783fb659327966ce23ff4b4a7f977cb270723 | Rename HandleNDupAcks in TCP.
Rename HandleNDupAcks() to HandleLossDetected() as it will enter this when
is detected after:
reorder window expires and TLP (in case of RACK)
dupAckCount >= 3 | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/cubic.go",
"new_path": "pkg/tcpip/transport/tcp/cubic.go",
"diff": "@@ -178,8 +178,8 @@ func (c *cubicState) getCwnd(packetsAcked, sndCwnd int, srtt time.Duration) int\nreturn int(cwnd)\n}\n-// HandleNDupAcks implements congestionContro... | Go | Apache License 2.0 | google/gvisor | Rename HandleNDupAcks in TCP.
Rename HandleNDupAcks() to HandleLossDetected() as it will enter this when
is detected after:
- reorder window expires and TLP (in case of RACK)
- dupAckCount >= 3
PiperOrigin-RevId: 355237858 |
259,975 | 02.02.2021 13:38:24 | 28,800 | fcc2468db573fec37c91236f805f7fa0e46e4492 | Add CPUSet for runsc mitigate. | [
{
"change_type": "MODIFY",
"old_path": "runsc/mitigate/cpu.go",
"new_path": "runsc/mitigate/cpu.go",
"diff": "@@ -16,6 +16,7 @@ package mitigate\nimport (\n\"fmt\"\n+ \"io/ioutil\"\n\"regexp\"\n\"strconv\"\n\"strings\"\n@@ -35,12 +36,100 @@ const (\nvendorIDKey = \"vendor_id\"\ncpuFamilyKey = \"cpu ... | Go | Apache License 2.0 | google/gvisor | Add CPUSet for runsc mitigate.
PiperOrigin-RevId: 355242055 |
259,885 | 02.02.2021 13:59:42 | 28,800 | ff8b308a30f46993f31f398c6e8d5b3bad03d865 | Remove call to Notify from pipe.VFSPipeFD.CopyOutFrom.
This was missed in cl/351911375; pipe.VFSPipeFD.SpliceFromNonPipe already calls
Notify. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/vfs.go",
"new_path": "pkg/sentry/kernel/pipe/vfs.go",
"diff": "@@ -368,17 +368,15 @@ func (fd *VFSPipeFD) CopyInTo(ctx context.Context, ars usermem.AddrRangeSeq, dst\n})\n}\n-// CopyOutFrom implements usermem.IO.CopyOutFrom.\n+// CopyOut... | Go | Apache License 2.0 | google/gvisor | Remove call to Notify from pipe.VFSPipeFD.CopyOutFrom.
This was missed in cl/351911375; pipe.VFSPipeFD.SpliceFromNonPipe already calls
Notify.
PiperOrigin-RevId: 355246655 |
260,019 | 14.01.2021 16:50:52 | -28,800 | 25130d6183d399fc3bfa93385aeba6819437ea6c | arm64: clean code
In order to improve the performance and stability, I reorg 2 modules slightly.
arch: no red zone on Arm64.
ring0: use stp instead of movd, and set RSV_REG_APP=R19. | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/defs_arm64.go",
"new_path": "pkg/ring0/defs_arm64.go",
"diff": "@@ -38,7 +38,7 @@ type KernelArchState struct {\n// CPUArchState contains CPU-specific arch state.\ntype CPUArchState struct {\n// stack is the stack used for interrupts on this CPU.\n- ... | Go | Apache License 2.0 | google/gvisor | arm64: clean code
In order to improve the performance and stability, I reorg 2 modules slightly.
arch: no red zone on Arm64.
ring0: use stp instead of movd, and set RSV_REG_APP=R19.
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
260,019 | 14.01.2021 19:06:46 | -28,800 | 6eb80b2e2df4a7e0a0b9dcfc99906a84fd8fc3f0 | arm64 kvm:implement basic lazy save and restore for FPSIMD registers
Implement basic lazy save and restore for FPSIMD registers, which only
restore FPSIMD state on el0_fpsimd_acc and save FPSIMD state in switch(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/defs_arm64.go",
"new_path": "pkg/ring0/defs_arm64.go",
"diff": "@@ -55,6 +55,9 @@ type CPUArchState struct {\n// faultAddr is the value of far_el1.\nfaultAddr uintptr\n+ // el0Fp is the address of application's fpstate.\n+ el0Fp uintptr\n+\n// ttbr0K... | Go | Apache License 2.0 | google/gvisor | arm64 kvm:implement basic lazy save and restore for FPSIMD registers
Implement basic lazy save and restore for FPSIMD registers, which only
restore FPSIMD state on el0_fpsimd_acc and save FPSIMD state in switch().
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
259,896 | 03.02.2021 11:06:55 | 28,800 | e3bce9689fcdbd1f6a3cfd9ead23abcdb0afd368 | Add a function to enable RACK in tests.
Adds a function to enable RACK in tests.
RACK update functions are guarded behind the flag tcpRecovery. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -1320,7 +1320,9 @@ func (s *sender) handleRcvdSegment(rcvdSeg *segment) {\n// unacknowledged and also never retransmitted sequence below\n// RACK.fack, then the correspo... | Go | Apache License 2.0 | google/gvisor | Add a function to enable RACK in tests.
- Adds a function to enable RACK in tests.
- RACK update functions are guarded behind the flag tcpRecovery.
PiperOrigin-RevId: 355435973 |
259,907 | 04.02.2021 08:25:44 | 28,800 | fa2d3698c44c7a691dd438ce8a7f92789bd909d2 | [infra] Do not recompile integration test executables each time.
Instead build the executable into the image. | [
{
"change_type": "MODIFY",
"old_path": "images/basic/integrationtest/Dockerfile.x86_64",
"new_path": "images/basic/integrationtest/Dockerfile.x86_64",
"diff": "@@ -5,3 +5,9 @@ COPY . .\nRUN chmod +x *.sh\nRUN apt-get update && apt-get install -y gcc iputils-ping iproute2\n+\n+# Compilation Steps.\n+... | Go | Apache License 2.0 | google/gvisor | [infra] Do not recompile integration test executables each time.
Instead build the executable into the image.
PiperOrigin-RevId: 355631672 |
259,896 | 04.02.2021 09:36:09 | 28,800 | eaba5bc7ef382c6070c02186ca86f734bf5d8a57 | Fix flaky packetimpact test | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/tcp_rack_test.go",
"new_path": "test/packetimpact/tests/tcp_rack_test.go",
"diff": "@@ -168,9 +168,10 @@ func TestRACKTLPLost(t *testing.T) {\ncloseSACKConnection(t, dut, conn, acceptFd, listenFd)\n}\n-// TestRACKTLPWithSACK tests TLP b... | Go | Apache License 2.0 | google/gvisor | Fix flaky packetimpact test
PiperOrigin-RevId: 355645297 |
259,853 | 04.02.2021 10:39:04 | 28,800 | 63c9dd365666c35a0c10444e56367c2d13e15562 | images: Rework syzkaller documentation. | [
{
"change_type": "MODIFY",
"old_path": "images/syzkaller/Dockerfile",
"new_path": "images/syzkaller/Dockerfile",
"diff": "FROM gcr.io/syzkaller/env\n+# This image is mostly for investigating syzkaller crashes, so let's install\n+# developer tools.\nRUN apt update && apt install -y git vim strace gdb... | Go | Apache License 2.0 | google/gvisor | images: Rework syzkaller documentation.
PiperOrigin-RevId: 355660221 |
259,881 | 04.02.2021 14:54:42 | 28,800 | 41510d2746756818269b0bf8f3961f026a0c247c | Move getcpu() to core filter list
Some versions of the Go runtime call getcpu(), so add it for compatibility. The
hostcpu package already uses getcpu() on arm64. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ptrace/filters.go",
"new_path": "pkg/sentry/platform/ptrace/filters.go",
"diff": "@@ -17,14 +17,12 @@ package ptrace\nimport (\n\"syscall\"\n- \"golang.org/x/sys/unix\"\n\"gvisor.dev/gvisor/pkg/seccomp\"\n)\n// SyscallFilters returns syscal... | Go | Apache License 2.0 | google/gvisor | Move getcpu() to core filter list
Some versions of the Go runtime call getcpu(), so add it for compatibility. The
hostcpu package already uses getcpu() on arm64.
PiperOrigin-RevId: 355717757 |
260,004 | 04.02.2021 17:58:58 | 28,800 | 71def1c5869af69e4127f2b07ebd7d5c62642597 | Lock ConnTrack before initializing buckets | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -231,6 +231,12 @@ func newConn(orig, reply tupleID, manip manipType, hook Hook) *conn {\nreturn &conn\n}\n+func (ct *ConnTrack) init() {\n+ ct.mu.Lock()\n+ defer ct.mu.Unloc... | Go | Apache License 2.0 | google/gvisor | Lock ConnTrack before initializing buckets
PiperOrigin-RevId: 355751801 |
260,004 | 05.02.2021 16:44:49 | 28,800 | 24416032ab848cff7696b3f37e4c18220aeee2c0 | Refactor locally delivered packets
Make it clear that failing to parse a looped back is not a packet
sending error but a malformed received packet error.
FindNetworkEndpoint returns nil when no network endpoint is found
instead of an error. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/BUILD",
"new_path": "pkg/tcpip/network/BUILD",
"diff": "@@ -16,7 +16,6 @@ go_test(\n\"//pkg/tcpip/checker\",\n\"//pkg/tcpip/faketime\",\n\"//pkg/tcpip/header\",\n- \"//pkg/tcpip/header/parse\",\n\"//pkg/tcpip/link/channel\",\n\"//pkg/tcpip/li... | Go | Apache License 2.0 | google/gvisor | Refactor locally delivered packets
Make it clear that failing to parse a looped back is not a packet
sending error but a malformed received packet error.
FindNetworkEndpoint returns nil when no network endpoint is found
instead of an error.
PiperOrigin-RevId: 355954946 |
260,003 | 05.02.2021 17:25:35 | 28,800 | 120c8e34687129c919ae45263c14b239a0a5d343 | Replace TaskFromContext(ctx).Kernel() with KernelFromContext(ctx)
Panic seen at some code path like control.ExecAsync where
ctx does not have a Task.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket_vfs2.go",
"new_path": "pkg/sentry/socket/hostinet/socket_vfs2.go",
"diff": "@@ -80,8 +80,7 @@ func newVFS2Socket(t *kernel.Task, family int, stype linux.SockType, protocol in\n// Release implements vfs.FileDescriptionImpl.Rele... | Go | Apache License 2.0 | google/gvisor | Replace TaskFromContext(ctx).Kernel() with KernelFromContext(ctx)
Panic seen at some code path like control.ExecAsync where
ctx does not have a Task.
Reported-by: syzbot+55ce727161cf94a7b7d6@syzkaller.appspotmail.com
PiperOrigin-RevId: 355960596 |
260,004 | 06.02.2021 09:47:26 | 28,800 | 9530f624e971183a0e72fe5123f542e0a4e1b329 | Unexpose NIC
The NIC structure is not to be used outside of the stack package
directly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/linkaddrcache.go",
"new_path": "pkg/tcpip/stack/linkaddrcache.go",
"diff": "@@ -30,7 +30,7 @@ const linkAddrCacheSize = 512 // max cache entries\n//\n// This struct is safe for concurrent use.\ntype linkAddrCache struct {\n- nic *NIC\n+ nic *ni... | Go | Apache License 2.0 | google/gvisor | Unexpose NIC
The NIC structure is not to be used outside of the stack package
directly.
PiperOrigin-RevId: 356036737 |
260,004 | 06.02.2021 13:23:44 | 28,800 | c5afaf2854679fbb7470f9a615d3c0fbb2af0999 | Remove (*stack.Stack).FindNetworkEndpoint
The network endpoints only look for other network endpoints of the
same kind. Since the network protocols keeps track of all endpoints,
go through the protocol to find an endpoint with an address instead
of the stack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -130,6 +130,20 @@ func (p *protocol) NewEndpoint(nic stack.NetworkInterface, dispatcher stack.Tran\nreturn e\n}\n+func (p *protocol) findEndpointWithAddress(addr tcpip.A... | Go | Apache License 2.0 | google/gvisor | Remove (*stack.Stack).FindNetworkEndpoint
The network endpoints only look for other network endpoints of the
same kind. Since the network protocols keeps track of all endpoints,
go through the protocol to find an endpoint with an address instead
of the stack.
PiperOrigin-RevId: 356051498 |
259,896 | 08.02.2021 12:08:11 | 28,800 | fe63db2e96069140a3e02a0dc7b7e28af9b463db | RACK: Detect loss
Detect packet loss using reorder window and re-transmit them after the reorder
timer expires. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1301,7 +1301,8 @@ func (e *endpoint) protocolMainLoop(handshake bool, wakerInitDone chan<- struct{\n// e.mu is expected to be hold upon entering this section.\n... | Go | Apache License 2.0 | google/gvisor | RACK: Detect loss
Detect packet loss using reorder window and re-transmit them after the reorder
timer expires.
PiperOrigin-RevId: 356321786 |
259,907 | 08.02.2021 18:00:36 | 28,800 | e51f775cbb8db89d1dac6dcf584be5eef1f82d3c | [go-marshal] Remove binary package reference from syscalls package.
Fixes a bug in our getsockopt(2) implementation which was incorrectly using
binary.Size() instead of Marshallable.SizeBytes(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/BUILD",
"new_path": "pkg/sentry/syscalls/linux/BUILD",
"diff": "@@ -62,7 +62,6 @@ go_library(\ndeps = [\n\"//pkg/abi\",\n\"//pkg/abi/linux\",\n- \"//pkg/binary\",\n\"//pkg/bpf\",\n\"//pkg/context\",\n\"//pkg/log\",\n"
},
{
"ch... | Go | Apache License 2.0 | google/gvisor | [go-marshal] Remove binary package reference from syscalls package.
Fixes a bug in our getsockopt(2) implementation which was incorrectly using
binary.Size() instead of Marshallable.SizeBytes().
PiperOrigin-RevId: 356396551 |
259,853 | 08.02.2021 19:15:45 | 28,800 | bf4968e17d7d08299493835a34af1a6d8551c375 | exec: don't panic if an elf file is malformed
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/elf.go",
"new_path": "pkg/sentry/loader/elf.go",
"diff": "@@ -517,12 +517,14 @@ func loadParsedELF(ctx context.Context, m *mm.MemoryManager, f fsbridge.File, in\nstart, ok = start.AddLength(uint64(offset))\nif !ok {\n- panic(fmt.Sprintf(\"Sta... | Go | Apache License 2.0 | google/gvisor | exec: don't panic if an elf file is malformed
Reported-by: syzbot+d54bc27a15aefe52c330@syzkaller.appspotmail.com
PiperOrigin-RevId: 356406975 |
259,898 | 08.02.2021 20:10:54 | 28,800 | 95500ece56f2acf34fcdc74e420f91beea888ada | Allow UDP sockets connect()ing to port 0
We previously return EINVAL when connecting to port 0, however this is not the
observed behavior on Linux. One of the observable effects after connecting to
port 0 on Linux is that getpeername() will fail with ENOTCONN. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -938,11 +938,6 @@ func (e *endpoint) Disconnect() tcpip.Error {\n// Connect connects the endpoint to its peer. Specifying a NIC is optional.\nfunc (e *endpoint... | Go | Apache License 2.0 | google/gvisor | Allow UDP sockets connect()ing to port 0
We previously return EINVAL when connecting to port 0, however this is not the
observed behavior on Linux. One of the observable effects after connecting to
port 0 on Linux is that getpeername() will fail with ENOTCONN.
PiperOrigin-RevId: 356413451 |
260,004 | 08.02.2021 21:39:29 | 28,800 | 6671a42d605d681e6aa63b610617523ab632e95a | Remove unnecessary locking
The thing the lock protects will never be accessed concurrently. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ndp.go",
"new_path": "pkg/tcpip/network/ipv6/ndp.go",
"diff": "@@ -466,20 +466,6 @@ type ndpState struct {\ntemporaryAddressDesyncFactor time.Duration\n}\n-type remainingCounter struct {\n- mu struct {\n- sync.Mutex\n-\n- remaining uint8... | Go | Apache License 2.0 | google/gvisor | Remove unnecessary locking
The thing the lock protects will never be accessed concurrently.
PiperOrigin-RevId: 356423331 |
259,853 | 09.02.2021 01:32:55 | 28,800 | d6dbe6e5ca5445dac278d3b6654af8d13379878a | pipe: writeLocked has to return ErrWouldBlock if the pipe is full | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"diff": "@@ -656,6 +656,9 @@ func (rw *regularFileReadWriter) WriteFromBlocks(srcs safemem.BlockSeq) (uint64,\n// Write to that memory as usual.\nseg, gap = rw.fil... | Go | Apache License 2.0 | google/gvisor | pipe: writeLocked has to return ErrWouldBlock if the pipe is full
PiperOrigin-RevId: 356450303 |
259,853 | 09.02.2021 10:34:49 | 28,800 | fe4f4789601ddf61260271f7e1d33ba0f2756fcd | kernel: reparentLocked has to update children maps of old and new parents
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_exit.go",
"new_path": "pkg/sentry/kernel/task_exit.go",
"diff": "@@ -415,6 +415,12 @@ func (tg *ThreadGroup) anyNonExitingTaskLocked() *Task {\nfunc (t *Task) reparentLocked(parent *Task) {\noldParent := t.parent\nt.parent = parent\n+ if... | Go | Apache License 2.0 | google/gvisor | kernel: reparentLocked has to update children maps of old and new parents
Reported-by: syzbot+9ffc71246fe72c73fc25@syzkaller.appspotmail.com
PiperOrigin-RevId: 356536113 |
259,992 | 09.02.2021 14:10:59 | 28,800 | 0f84ea5afe21c9ebbccb9fa41482a8f7f8d9d3a1 | Fix fd leak from test | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/open_create.cc",
"new_path": "test/syscalls/linux/open_create.cc",
"diff": "@@ -46,8 +46,10 @@ TEST(CreateTest, ExistingFile) {\nTEST(CreateTest, CreateAtFile) {\nauto dir = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateDir());\nauto dirfd = AS... | Go | Apache License 2.0 | google/gvisor | Fix fd leak from test
PiperOrigin-RevId: 356587965 |
259,860 | 09.02.2021 19:15:53 | 28,800 | f6de413c398231cb392bccda3807897703653ab5 | Add cleanup TODO for integer-based proc files. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/file_description_impl_util.go",
"new_path": "pkg/sentry/vfs/file_description_impl_util.go",
"diff": "@@ -238,6 +238,8 @@ func (s *StaticData) Generate(ctx context.Context, buf *bytes.Buffer) error {\n// WritableDynamicBytesSource extends Dynamic... | Go | Apache License 2.0 | google/gvisor | Add cleanup TODO for integer-based proc files.
PiperOrigin-RevId: 356645022 |
259,975 | 10.02.2021 10:46:31 | 28,800 | 1ac58cc23e7c069ff59ddea333a89c5c5972a555 | Add mitigate command to runsc | [
{
"change_type": "MODIFY",
"old_path": "runsc/cli/main.go",
"new_path": "runsc/cli/main.go",
"diff": "@@ -85,6 +85,7 @@ func Main(version string) {\nsubcommands.Register(new(cmd.Start), \"\")\nsubcommands.Register(new(cmd.Symbolize), \"\")\nsubcommands.Register(new(cmd.Wait), \"\")\n+ subcommands.Re... | Go | Apache License 2.0 | google/gvisor | Add mitigate command to runsc
PiperOrigin-RevId: 356772367 |
259,985 | 10.02.2021 13:04:24 | 28,800 | c2f204658ed4a6b0bd110577f22fbfd4104a6f96 | Add proposal for io_uring project. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "g3doc/proposals/BUILD",
"diff": "+load(\"//website:defs.bzl\", \"doc\")\n+\n+package(\n+ default_visibility = [\"//website:__pkg__\"],\n+ licenses = [\"notice\"],\n+)\n+\n+doc(\n+ name = \"gsoc_2021\",\n+ src = \"gsoc-2021-ideas.md\",\n+ categor... | Go | Apache License 2.0 | google/gvisor | Add proposal for io_uring project.
PiperOrigin-RevId: 356807933 |
259,975 | 10.02.2021 15:40:19 | 28,800 | 36e4100a2851b42d8f812e92d44eb75ea5e737d4 | Update benchmarks README.md | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/README.md",
"new_path": "test/benchmarks/README.md",
"diff": "@@ -13,49 +13,26 @@ To run benchmarks you will need:\n* Docker installed (17.09.0 or greater).\n-The easiest way to setup runsc for running benchmarks is to use the make file.\n-From... | Go | Apache License 2.0 | google/gvisor | Update benchmarks README.md
PiperOrigin-RevId: 356843249 |
259,907 | 10.02.2021 16:20:31 | 28,800 | 96d3b3188bb19669f09ccad99d243555eb00c3f7 | Fix broken IFTTT link in tcpip. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tcpip.go",
"new_path": "pkg/tcpip/tcpip.go",
"diff": "@@ -1590,7 +1590,7 @@ type IPStats struct {\n// OptionUnknownReceived is the number of unknown IP options seen.\nOptionUnknownReceived *StatCounter\n- // LINT.ThenChange(network/ip/stats.go:MultiC... | Go | Apache License 2.0 | google/gvisor | Fix broken IFTTT link in tcpip.
PiperOrigin-RevId: 356852625 |
259,853 | 10.02.2021 16:30:22 | 28,800 | 97a36d1696982949722c6d6da1e5031d79e90b48 | Don't allow to umount the namespace root mount
Linux does the same thing.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -309,6 +309,11 @@ func (vfs *VirtualFilesystem) UmountAt(ctx context.Context, creds *auth.Credenti\nvfs.mountMu.Unlock()\nreturn syserror.EINVAL\n}\n+\n+ if vd.mount == vd.mount.ns.ro... | Go | Apache License 2.0 | google/gvisor | Don't allow to umount the namespace root mount
Linux does the same thing.
Reported-by: syzbot+6c79385c930c929d1d9e@syzkaller.appspotmail.com
PiperOrigin-RevId: 356854562 |
259,891 | 10.02.2021 17:43:25 | 28,800 | 81ea0016e62318053f97ec714967047e6191fb2b | Support setgid directories in tmpfs and kernfs | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"new_path": "pkg/sentry/fsimpl/kernfs/inode_impl_util.go",
"diff": "@@ -294,22 +294,41 @@ func (a *InodeAttrs) SetStat(ctx context.Context, fs *vfs.Filesystem, creds *aut\nreturn err\n}\n+ clearSID := false\nstat :... | Go | Apache License 2.0 | google/gvisor | Support setgid directories in tmpfs and kernfs
PiperOrigin-RevId: 356868412 |
259,992 | 11.02.2021 10:58:55 | 28,800 | 192780946fdf584c5e504b24f47dbd9bd411a3a6 | Allow rt_sigaction in gofer seccomp
rt_sigaction may be called by Go runtime when trying to panic:
https://cs.opensource.google/go/go/+/master:src/runtime/signal_unix.go;drc=ed3e4afa12d655a0c5606bcf3dd4e1cdadcb1476;bpv=1;bpt=1;l=780?q=rt_sigaction&ss=go
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/config.go",
"new_path": "runsc/fsgofer/filter/config.go",
"diff": "@@ -182,6 +182,8 @@ var allowedSyscalls = seccomp.SyscallRules{\n},\nsyscall.SYS_RENAMEAT: {},\nsyscall.SYS_RESTART_SYSCALL: {},\n+ // May be used by the runtime during pan... | Go | Apache License 2.0 | google/gvisor | Allow rt_sigaction in gofer seccomp
rt_sigaction may be called by Go runtime when trying to panic:
https://cs.opensource.google/go/go/+/master:src/runtime/signal_unix.go;drc=ed3e4afa12d655a0c5606bcf3dd4e1cdadcb1476;bpv=1;bpt=1;l=780?q=rt_sigaction&ss=go
Updates #5038
PiperOrigin-RevId: 357013186 |
259,891 | 11.02.2021 11:06:56 | 28,800 | ae8d966f5af0bba9978a1aedac64038ef65a4cc9 | Assign controlling terminal when tty is opened and support NOCTTY | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tty/master.go",
"new_path": "pkg/sentry/fs/tty/master.go",
"diff": "@@ -153,7 +153,7 @@ func (mf *masterFileOperations) Write(ctx context.Context, _ *fs.File, src userm\n}\n// Ioctl implements fs.FileOperations.Ioctl.\n-func (mf *masterFileOperat... | Go | Apache License 2.0 | google/gvisor | Assign controlling terminal when tty is opened and support NOCTTY
PiperOrigin-RevId: 357015186 |
259,875 | 11.02.2021 12:19:48 | 28,800 | c833eed80a4ceaf9da852ef361dd5f4864eb647d | Implement semtimedop. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64.go",
"diff": "@@ -272,7 +272,7 @@ var AMD64 = &kernel.SyscallTable{\n217: syscalls.Supported(\"getdents64\", Getdents64),\n218: syscalls.Supported(\"set_tid_address\", SetTid... | Go | Apache License 2.0 | google/gvisor | Implement semtimedop.
PiperOrigin-RevId: 357031904 |
259,891 | 11.02.2021 15:59:20 | 28,800 | c39284f457383dabd52f468a10072ca6d2211cbb | Let sentry understand tcpip.ErrMalformedHeader
Added a LINT IfChange/ThenChange check to catch this in the future. | [
{
"change_type": "MODIFY",
"old_path": "pkg/syserr/netstack.go",
"new_path": "pkg/syserr/netstack.go",
"diff": "@@ -21,6 +21,8 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip\"\n)\n+// LINT.IfChange\n+\n// Mapping for tcpip.Error types.\nvar (\nErrUnknownProtocol = New((&tcpip.ErrUnknownProtocol{}).Strin... | Go | Apache License 2.0 | google/gvisor | Let sentry understand tcpip.ErrMalformedHeader
Added a LINT IfChange/ThenChange check to catch this in the future.
PiperOrigin-RevId: 357077564 |
259,885 | 11.02.2021 19:08:18 | 28,800 | 34614c39860a7316132a2bf572366618e7a78be9 | Unconditionally check for directory-ness in overlay.filesystem.UnlinkAt(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"new_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"diff": "@@ -1308,8 +1308,8 @@ func (fs *filesystem) RmdirAt(ctx context.Context, rp *vfs.ResolvingPath) error\nreturn err\n}\n- // Unlike UnlinkAt, we need a dent... | Go | Apache License 2.0 | google/gvisor | Unconditionally check for directory-ness in overlay.filesystem.UnlinkAt().
PiperOrigin-RevId: 357106080 |
259,907 | 11.02.2021 22:03:45 | 28,800 | 845d0a65f449ade1952568b5fc120e7cb8cd709f | [rack] TLP: ACK Processing and PTO scheduling.
This change implements TLP details enumerated in
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -222,6 +222,7 @@ var Metrics = tcpip.Stats{\nRetransmits: mustCreateMetric(\"/netstack/tcp/retransmits\", \"Number of TCP segments retransmitted.\"),\nFa... | Go | Apache License 2.0 | google/gvisor | [rack] TLP: ACK Processing and PTO scheduling.
This change implements TLP details enumerated in
https://tools.ietf.org/html/draft-ietf-tcpm-rack-08#section-7.5.3
Fixes #5085
PiperOrigin-RevId: 357125037 |
259,853 | 12.02.2021 10:56:15 | 28,800 | a6d813ad55ae80a2c4173fc3fd3961236327cf8b | tests: getsockname expects that addrlen will be initialized | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/udp_socket.cc",
"new_path": "test/syscalls/linux/udp_socket.cc",
"diff": "@@ -2131,8 +2131,8 @@ TEST(UdpInet6SocketTest, ConnectInet4Sockaddr) {\nreinterpret_cast<const struct sockaddr*>(&connect_sockaddr),\nsizeof(sockaddr_in)),\nSyscallSu... | Go | Apache License 2.0 | google/gvisor | tests: getsockname expects that addrlen will be initialized
PiperOrigin-RevId: 357224877 |
259,975 | 12.02.2021 11:25:53 | 28,800 | ba51999fa65d9a5a87b4d9848a6e2573a8812e8d | Fix bug with iperf and don't profile runc.
Fix issue with iperf where b.N wasn't changing across runs.
Also, if the given runtime is runc/not given, don't run a profile against it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/container.go",
"new_path": "pkg/test/dockerutil/container.go",
"diff": "@@ -216,7 +216,7 @@ func (c *Container) Create(ctx context.Context, r RunOpts, args ...string) error\n}\nfunc (c *Container) create(ctx context.Context, profileImage st... | Go | Apache License 2.0 | google/gvisor | Fix bug with iperf and don't profile runc.
Fix issue with iperf where b.N wasn't changing across runs.
Also, if the given runtime is runc/not given, don't run a profile against it.
PiperOrigin-RevId: 357231450 |
259,985 | 12.02.2021 12:11:03 | 28,800 | c99ad8d541670e7fec7480b97d6d258460f041e3 | Add reference to gsoc 2021 proposal page for website. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/proposals/BUILD",
"new_path": "g3doc/proposals/BUILD",
"diff": "@@ -10,7 +10,7 @@ doc(\nsrc = \"gsoc-2021-ideas.md\",\ncategory = \"Project\",\ninclude_in_menu = False,\n- permalink = \"/community/gsoc_2021\",\n+ permalink = \"/community/gsoc_2021/\",\ns... | Go | Apache License 2.0 | google/gvisor | Add reference to gsoc 2021 proposal page for website.
PiperOrigin-RevId: 357241880 |
259,975 | 12.02.2021 12:53:51 | 28,800 | 58a0a66900b6f38c8eee638a7c249bcc0a1bd9be | Rename params for iperf and tensorflow.
Rename operation params in iperf and tensorflow to
match other similar benchmarks. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/ml/BUILD",
"new_path": "test/benchmarks/ml/BUILD",
"diff": "@@ -18,5 +18,6 @@ benchmark_test(\ndeps = [\n\"//pkg/test/dockerutil\",\n\"//test/benchmarks/harness\",\n+ \"//test/benchmarks/tools\",\n],\n)\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | Rename params for iperf and tensorflow.
Rename operation params in iperf and tensorflow to
match other similar benchmarks.
PiperOrigin-RevId: 357250304 |
259,896 | 12.02.2021 15:23:52 | 28,800 | 33c617cae3d6e5261e67090faf52c4101f5b7713 | Remove packetimpact test tcp_reordering
Remove flaky tcp_reordering_test as it does not check reordering. We have
added new reorder tests in tcp_rack_test.go | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/defs.bzl",
"new_path": "test/packetimpact/runner/defs.bzl",
"diff": "@@ -180,11 +180,6 @@ ALL_TESTS = [\nPacketimpactTestInfo(\nname = \"udp_icmp_error_propagation\",\n),\n- PacketimpactTestInfo(\n- name = \"tcp_reordering\",\n- # TODO... | Go | Apache License 2.0 | google/gvisor | Remove packetimpact test tcp_reordering
Remove flaky tcp_reordering_test as it does not check reordering. We have
added new reorder tests in tcp_rack_test.go
PiperOrigin-RevId: 357278769 |
259,858 | 12.02.2021 17:11:14 | 28,800 | 3ef012944d32313cee4df244585f48e8d4fd8e9e | Stop the control server only once.
Operations are now shut down automatically by the main Stop
command, and it is not necessary to call Stop during Destroy.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -477,14 +477,16 @@ func createProcessArgs(id string, spec *specs.Spec, creds *auth.Credentials, k *\n// been closed. For that reason, this should NOT be called in a defer, because\n// a pan... | Go | Apache License 2.0 | google/gvisor | Stop the control server only once.
Operations are now shut down automatically by the main Stop
command, and it is not necessary to call Stop during Destroy.
Fixes #5454
PiperOrigin-RevId: 357295930 |
259,896 | 17.02.2021 14:23:15 | 28,800 | 3145fe1d1e99746fe39aa68e6e00f77f6fd27fb9 | Use TCP_INFO to get RTO in tcp_retransmits_test
TCP_INFO is used to get the RTO instead of calculating it manually. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/BUILD",
"new_path": "test/packetimpact/tests/BUILD",
"diff": "@@ -103,7 +103,10 @@ packetimpact_testbench(\nname = \"tcp_retransmits\",\nsrcs = [\"tcp_retransmits_test.go\"],\ndeps = [\n+ \"//pkg/abi/linux\",\n+ \"//pkg/binary\",\n\"//p... | Go | Apache License 2.0 | google/gvisor | Use TCP_INFO to get RTO in tcp_retransmits_test
- TCP_INFO is used to get the RTO instead of calculating it manually.
PiperOrigin-RevId: 358032487 |
259,885 | 17.02.2021 15:32:02 | 28,800 | 4bc7daf91a0d9102fa477b199964e7db45066da1 | Check for directory emptiness in VFS1 overlay rmdir().
Note that this CL reorders overlayEntry.copyMu before overlayEntry.dirCacheMu
in the overlayFileOperations.IterateDir() => readdirEntries() path - but this
lock ordering is already required by overlayRemove/Bind() =>
overlayEntry.markDirectoryDirty(), so this actually just fixes an
inconsistency. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/file_overlay.go",
"new_path": "pkg/sentry/fs/file_overlay.go",
"diff": "@@ -177,10 +177,16 @@ func (f *overlayFileOperations) Readdir(ctx context.Context, file *File, seriali\n// IterateDir implements DirIterator.IterateDir.\nfunc (f *overlayFile... | Go | Apache License 2.0 | google/gvisor | Check for directory emptiness in VFS1 overlay rmdir().
Note that this CL reorders overlayEntry.copyMu before overlayEntry.dirCacheMu
in the overlayFileOperations.IterateDir() => readdirEntries() path - but this
lock ordering is already required by overlayRemove/Bind() =>
overlayEntry.markDirectoryDirty(), so this actually just fixes an
inconsistency.
PiperOrigin-RevId: 358047121 |
259,891 | 17.02.2021 18:22:27 | 28,800 | 1fc2c5f750bc90d75a3ac19fc95145a748a3811f | Move Name() out of netstack Matcher. It can live in the sentry. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/extensions.go",
"new_path": "pkg/sentry/socket/netfilter/extensions.go",
"diff": "@@ -40,13 +40,17 @@ type matchMaker interface {\nname() string\n// marshal converts from a stack.Matcher to an ABI struct.\n- marshal(matcher stack.Ma... | Go | Apache License 2.0 | google/gvisor | Move Name() out of netstack Matcher. It can live in the sentry.
PiperOrigin-RevId: 358078157 |
259,907 | 17.02.2021 19:26:45 | 28,800 | dea894238bf404523a6c78819e242e0fb727e225 | [infra] Update JDK11 version for java runtime tests. | [
{
"change_type": "MODIFY",
"old_path": "images/runtimes/java11/Dockerfile",
"new_path": "images/runtimes/java11/Dockerfile",
"diff": "@@ -11,9 +11,9 @@ RUN apt-get update && apt-get install -y \\\n# Download the JDK test library.\nWORKDIR /root\nRUN set -ex \\\n- && curl -fsSL --retry 10 -o /tmp/jdk... | Go | Apache License 2.0 | google/gvisor | [infra] Update JDK11 version for java runtime tests.
PiperOrigin-RevId: 358085809 |
259,992 | 18.02.2021 10:17:07 | 28,800 | 582f7bf6c0ccccaeb1215a232709df38d5d409f7 | Remove side effect from pty tests
Individual test cases must not rely on being executed in a clean environment. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pty.cc",
"new_path": "test/syscalls/linux/pty.cc",
"diff": "@@ -1316,7 +1316,10 @@ class JobControlTest : public ::testing::Test {\n// In the gVisor test environment, this test will be run as the session\n// leader already (as the sentry in... | Go | Apache License 2.0 | google/gvisor | Remove side effect from pty tests
Individual test cases must not rely on being executed in a clean environment.
PiperOrigin-RevId: 358207468 |
259,967 | 18.02.2021 11:37:46 | 28,800 | bb5db80448c268f4d3eed932a01e78fcab7fb5d1 | Remove deprecated NUD types Failed and FailedEntryLookups
Completes the soft migration to Unreachable state by removing the Failed state
and the the FailedEntryLookups StatCounter.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_cache.go",
"new_path": "pkg/tcpip/stack/neighbor_cache.go",
"diff": "@@ -25,10 +25,6 @@ const neighborCacheSize = 512 // max entries per interface\n// NeighborStats holds metrics for the neighbor table.\ntype NeighborStats struct {\n- ... | Go | Apache License 2.0 | google/gvisor | Remove deprecated NUD types Failed and FailedEntryLookups
Completes the soft migration to Unreachable state by removing the Failed state
and the the FailedEntryLookups StatCounter.
Fixes #4667
PiperOrigin-RevId: 358226380 |
259,975 | 18.02.2021 12:59:22 | 28,800 | ec20f4f38ef49efc8756595e6ec3fb3e578cc097 | Make b.N increase by KB not bytes on iperf.
Currently, iperf runs a client that scales by
bytes sent. In practice, this causes b.N to scale
slowly and have several short lived containers.
Instead, scale by KB to more quickly reach required time. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/network/iperf_test.go",
"new_path": "test/benchmarks/network/iperf_test.go",
"diff": "@@ -97,7 +97,7 @@ func BenchmarkIperf(b *testing.B) {\n}\niperf := tools.Iperf{\n- Num: b.N,\n+ Num: b.N, // KB for the client to send.\n}\n// Run the client.... | Go | Apache License 2.0 | google/gvisor | Make b.N increase by KB not bytes on iperf.
Currently, iperf runs a client that scales by
bytes sent. In practice, this causes b.N to scale
slowly and have several short lived containers.
Instead, scale by KB to more quickly reach required time.
PiperOrigin-RevId: 358244926 |
259,881 | 18.02.2021 15:29:15 | 28,800 | f80a857a4f5f57908c64a22f5de0e07df722227d | Bump build constraints to Go 1.18
These are bumped to allow early testing of Go 1.17. Use will be audited closer
to the 1.17 release. | [
{
"change_type": "MODIFY",
"old_path": "pkg/gohacks/gohacks_unsafe.go",
"new_path": "pkg/gohacks/gohacks_unsafe.go",
"diff": "// limitations under the License.\n// +build go1.13\n-// +build !go1.17\n+// +build !go1.18\n// Check type signatures when updating Go version.\n"
},
{
"change_type":... | Go | Apache License 2.0 | google/gvisor | Bump build constraints to Go 1.18
These are bumped to allow early testing of Go 1.17. Use will be audited closer
to the 1.17 release.
PiperOrigin-RevId: 358278615 |
259,962 | 18.02.2021 15:58:50 | 28,800 | ec7f44f36b57c8472a692cdd736ad721c5170ee2 | Make socketops reflect correct sndbuf value for host UDS.
Also skips a test if the setsockopt to increase send buffer did not result in an
increase. This is possible when the underlying socket is a host backed unix
domain socket as in such cases gVisor does not permit increasing SO_SNDBUF. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/connectioned.go",
"new_path": "pkg/sentry/socket/unix/transport/connectioned.go",
"diff": "@@ -364,7 +364,9 @@ func (e *connectionedEndpoint) Connect(ctx context.Context, server BoundEndpoint\ne.connected = ce\n// Make sure the... | Go | Apache License 2.0 | google/gvisor | Make socketops reflect correct sndbuf value for host UDS.
Also skips a test if the setsockopt to increase send buffer did not result in an
increase. This is possible when the underlying socket is a host backed unix
domain socket as in such cases gVisor does not permit increasing SO_SNDBUF.
PiperOrigin-RevId: 358285158 |
259,985 | 19.02.2021 00:50:40 | 28,800 | 599579d0e554eea3b2a1bc5390026a6226e5e979 | Add a few more project ideas to the gsoc 2021 list | [
{
"change_type": "MODIFY",
"old_path": "g3doc/proposals/gsoc-2021-ideas.md",
"new_path": "g3doc/proposals/gsoc-2021-ideas.md",
"diff": "@@ -13,9 +13,54 @@ If you're interested in contributing to gVisor through Google Summer of Code\n[roadmap](../roadmap.md) for areas of development, and get in touch... | Go | Apache License 2.0 | google/gvisor | Add a few more project ideas to the gsoc 2021 list
PiperOrigin-RevId: 358354414 |
259,975 | 19.02.2021 17:10:27 | 28,800 | 7544eeb242d0aba2da054a1663e043feaedb9618 | Correctly set and respect b.N in fio benchmark.
fio should scale by written/read bytes and not iterate runs
of the fio container. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/fs/fio_test.go",
"new_path": "test/benchmarks/fs/fio_test.go",
"diff": "@@ -34,37 +34,31 @@ func BenchmarkFio(b *testing.B) {\ntestCases := []tools.Fio{\n{\nTest: \"write\",\n- Size: b.N,\nBlockSize: 4,\nIODepth: 4,\n},\n{\nTest: \"write\",\n- ... | Go | Apache License 2.0 | google/gvisor | Correctly set and respect b.N in fio benchmark.
fio should scale by written/read bytes and not iterate runs
of the fio container.
PiperOrigin-RevId: 358511771 |
259,853 | 22.02.2021 11:37:13 | 28,800 | c5a4e100085ccbd063df36706cccf93951439cb7 | unix: sendmmsg and recvmsg have to cap a number of message to UIO_MAXIOV
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"new_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"diff": "@@ -657,6 +657,10 @@ func RecvMMsg(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysc\nreturn 0, nil, syserror.EINVAL\n}\n+ if vlen > linu... | Go | Apache License 2.0 | google/gvisor | unix: sendmmsg and recvmsg have to cap a number of message to UIO_MAXIOV
Reported-by: syzbot+f2489ba0b999a45d1ad1@syzkaller.appspotmail.com
PiperOrigin-RevId: 358866218 |
259,992 | 22.02.2021 15:54:58 | 28,800 | 34e2cda9ad6a20861844776abfbb45052d20c3fa | Return nicer error message when cgroups v1 isn't available
Updates
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/BUILD",
"new_path": "runsc/cgroup/BUILD",
"diff": "@@ -11,6 +11,7 @@ go_library(\n\"//pkg/log\",\n\"@com_github_cenkalti_backoff//:go_default_library\",\n\"@com_github_opencontainers_runtime_spec//specs-go:go_default_library\",\n+ \"@org_golang_x_... | Go | Apache License 2.0 | google/gvisor | Return nicer error message when cgroups v1 isn't available
Updates #3481
Closes #5430
PiperOrigin-RevId: 358923208 |
259,975 | 22.02.2021 16:00:33 | 28,800 | 24ea8003a49dbbcdfbbf2e5969c4bf8002063b86 | Only detect mds for mitigate.
Only detect and mitigate on mds for the mitigate command. | [
{
"change_type": "MODIFY",
"old_path": "runsc/mitigate/cpu.go",
"new_path": "runsc/mitigate/cpu.go",
"diff": "@@ -23,15 +23,10 @@ import (\n)\nconst (\n- // constants of coomm\n- meltdown = \"cpu_meltdown\"\n- l1tf = \"l1tf\"\n+ // mds is the only bug we care about.\nmds = \"mds\"\n- swapgs = \"swap... | Go | Apache License 2.0 | google/gvisor | Only detect mds for mitigate.
Only detect and mitigate on mds for the mitigate command.
PiperOrigin-RevId: 358924466 |
259,860 | 24.02.2021 01:46:44 | 28,800 | 6e000d3424c0eed685483f54348c6b0a752a0435 | Use async task context for async IO. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/error.go",
"new_path": "pkg/sentry/syscalls/linux/error.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"io\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n+ \"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/log\"\n\"gvisor.dev/gvisor/pkg... | Go | Apache License 2.0 | google/gvisor | Use async task context for async IO.
PiperOrigin-RevId: 359235699 |
259,853 | 24.02.2021 11:34:08 | 28,800 | 055073f11813a7b675cb19aa6c540a667cd746a5 | runsc/filters: permit clock_nanosleep for race
Syzkaller hosts contains many audit messages that runsc tries
to call the clock_nanosleep syscall. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/extra_filters_race.go",
"new_path": "runsc/boot/filter/extra_filters_race.go",
"diff": "@@ -27,6 +27,7 @@ func instrumentationFilters() seccomp.SyscallRules {\nReport(\"TSAN is enabled: syscall filters less restrictive!\")\nreturn seccomp.Sys... | Go | Apache License 2.0 | google/gvisor | runsc/filters: permit clock_nanosleep for race
Syzkaller hosts contains many audit messages that runsc tries
to call the clock_nanosleep syscall.
PiperOrigin-RevId: 359331413 |
259,951 | 24.02.2021 16:54:11 | 28,800 | 1d2975ffbe0e32ebcd2fe9307544799b2f9ae632 | Validate MLD packets
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/icmp.go",
"new_path": "pkg/tcpip/network/ipv6/icmp.go",
"diff": "@@ -260,12 +260,31 @@ func getTargetLinkAddr(it header.NDPOptionIterator) (tcpip.LinkAddress, bool) {\n})\n}\n-func (e *endpoint) handleICMP(pkt *stack.PacketBuffer, hasFra... | Go | Apache License 2.0 | google/gvisor | Validate MLD packets
Fixes #5490
PiperOrigin-RevId: 359401532 |
259,858 | 25.02.2021 10:54:14 | 28,800 | 56053f084f06e61e963b0007e7bf99e69a0f9144 | Strip all non-numeric characters from version.
This will fix debian packaging.
Updates | [
{
"change_type": "MODIFY",
"old_path": "tools/bazeldefs/BUILD",
"new_path": "tools/bazeldefs/BUILD",
"diff": "@@ -41,7 +41,7 @@ config_setting(\ngenrule(\nname = \"version\",\nouts = [\"version.txt\"],\n- cmd = \"cat bazel-out/stable-status.txt | grep STABLE_VERSION | cut -d' ' -f2- >$@\",\n+ cmd = ... | Go | Apache License 2.0 | google/gvisor | Strip all non-numeric characters from version.
This will fix debian packaging.
Updates #5510
PiperOrigin-RevId: 359563378 |
259,875 | 25.02.2021 12:54:36 | 28,800 | e50ee26207a99930be966bd48e04f5bccd85cc05 | Implement SEM_STAT_ANY cmd of semctl. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "@@ -381,15 +381,24 @@ func (s *Set) Change(ctx context.Context, creds *auth.Credentials, owner fs.File\n// GetStat extracts semid_ds information from th... | Go | Apache License 2.0 | google/gvisor | Implement SEM_STAT_ANY cmd of semctl.
PiperOrigin-RevId: 359591577 |
259,896 | 25.02.2021 16:27:30 | 28,800 | f3de211bb764d4e720879509debf918d37a71ce7 | RACK: recovery logic should check for receive window before re-transmitting.
Use maybeSendSegment while sending segments in RACK recovery which checks if
the receiver has space and splits the segments when the segment size is
greater than MSS. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/rack.go",
"new_path": "pkg/tcpip/transport/tcp/rack.go",
"diff": "@@ -475,9 +475,11 @@ func (rc *rackControl) DoRecovery(_ *segment, fastRetransmit bool) {\nbreak\n}\n- snd.outstanding++\n+ if sent := snd.maybeSendSegment(seg, int(snd.e... | Go | Apache License 2.0 | google/gvisor | RACK: recovery logic should check for receive window before re-transmitting.
Use maybeSendSegment while sending segments in RACK recovery which checks if
the receiver has space and splits the segments when the segment size is
greater than MSS.
PiperOrigin-RevId: 359641097 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.